Re: [PATCH tip/core/rcu 11/13] rculist: Make list_entry_rcu() use lockless_dereference()

2015-10-28 Thread Patrick Marlier
On 10/28/2015 09:33 AM, Ingo Molnar wrote: * Tejun Heo wrote: Subject: writeback: don't use list_entry_rcu() for pointer offsetting in bdi_split_work_to_wbs() bdi_split_work_to_wbs() uses list_for_each_entry_rcu_continue() to walk @bdi->wb_list. To set up the initial iteration condition,

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

2015-09-23 Thread Patrick Marlier
On 09/22/2015 10:50 PM, Paul E. McKenney wrote: On Sun, Sep 13, 2015 at 09:10:24AM -0700, Paul E. McKenney wrote: On Sun, Sep 13, 2015 at 12:06:33PM +0200, Patrick Marlier wrote: [ . . . ] Paul, This sounds good to me. It should fix the performance issue (will check with my benchmark

Re: [fprint] FPrint after Windows Usage

2015-09-13 Thread Patrick Marlier
Hi Pierre, On 09/09/2015 08:32 PM, Vasily Khoruzhick wrote: On Wed, Sep 9, 2015 at 10:35 AM, HERAULT-MARTIN Pierre wrote: Hello list users, Hi Pierre, I'm new to the whole fingerprint thingy. I have purchased a laptop and it offers this fingerprint reader (Some sort of EgisTek device, it i

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

2015-09-13 Thread Patrick Marlier
On 09/12/2015 01:05 AM, Paul E. McKenney wrote: On Tue, May 19, 2015 at 03:07:25PM -0700, Paul E. McKenney wrote: On Mon, May 18, 2015 at 09:43:21AM -0400, Steven Rostedt wrote: On Mon, 18 May 2015 12:06:47 +1000 NeilBrown wrote: struct mddev { ... struct list_headd

Re: [committed] taking transactional credits

2015-09-01 Thread Patrick Marlier
On Tue, Sep 1, 2015 at 4:10 PM, Aldy Hernandez wrote: > On 09/01/2015 07:03 AM, Richard Henderson wrote: >> >> On 09/01/2015 06:55 AM, Aldy Hernandez wrote: >>> >>> If you don't like it, sue me. =) >> >> >> Share the blame... ;-) > > > That's right! I ain't going down in posterity alone on this.

Re: [fprint] Improving the etes603 driver

2015-08-31 Thread Patrick Marlier
On 08/27/2015 01:07 AM, Jason Gerard DeRose wrote: Patrick, On 08/26/2015 02:53 PM, Patrick Marlier wrote: Jason, On 08/26/2015 05:57 PM, Jason Gerard DeRose wrote: Patrick, A little update on where I'm at with this. Through many iterations of adding extra debug logging and rem

[PATCH COMMITTED] MAINTAINERS (Write After Approval): Add myself.

2015-08-27 Thread Patrick Marlier
@@ +2015-08-27 Patrick Marlier + + * MAINTAINERS (Write After Approval): Add myself. + 2015-08-23 Francois-Xavier Coudert PR libfortran/54572 Index: MAINTAINERS === --- MAINTAINERS (revision 227278) +++ MAINTAINERS

Re: [fprint] Improving the etes603 driver

2015-08-26 Thread Patrick Marlier
Jason, On 08/26/2015 05:57 PM, Jason Gerard DeRose wrote: Patrick, A little update on where I'm at with this. Through many iterations of adding extra debug logging and removing logging that was too noisy and wasn't helpful to me, I've discovered a problem that at least seems to exist with the

Re: [fprint] Improving the etes603 driver

2015-08-24 Thread Patrick Marlier
Jason, On Fri, Aug 21, 2015 at 6:18 PM, Jason Gerard DeRose wrote: > etes603.c mentions: > > 1. Tuning of DTVRT for contact detection > 2. Contact detection via capacitance Those 2 are the calibration issue for detecting a finger. > 3. Capture mode using assembled frames (usually better quality

Re: [fprint] Improving the etes603 driver

2015-08-21 Thread Patrick Marlier
Hi Jason and Vasily, On Fri, Aug 21, 2015 at 3:58 AM, Vasily Khoruzhick wrote: > Hi Jason, > > On Thu, Aug 20, 2015 at 11:51 AM, Jason Gerard DeRose > wrote: >> Hello, >> >> I work at System76 and am going to take a stab at improving the etes603 >> driver (1c7a:0603) as it's the fingerprint read

Re: [PR64164] drop copyrename, integrate into expand

2015-08-10 Thread Patrick Marlier
On Mon, Aug 10, 2015 at 5:14 PM, Jeff Law wrote: > On 08/10/2015 02:23 AM, James Greenhalgh wrote: >> >> On Tue, Aug 04, 2015 at 12:45:28AM +0100, Alexandre Oliva wrote: >>> >>> On Jul 30, 2015, "H.J. Lu" wrote: >>> aoliva/pr64164 is fine on x32. >>> >>> >>> Thanks. I have made a large num

Re: [fprint] Fprint - EGIStec ES603 scanning errors.

2015-05-27 Thread Patrick Marlier
Hi Dupo, Is this the exact same issue? Could you try to enable the debug mode and send me the log? I don't remember how Thomas Rohloff solved his issue (calibration issue probably?). Could you comment on this bug report and maybe Thomas will answer? Thanks -- Pat On Wed, May 27, 2015 at 4:34 PM,

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

2015-05-18 Thread Patrick Marlier
On 05/18/2015 03:53 PM, Patrick Marlier wrote: On Mon, May 18, 2015 at 4:06 AM, NeilBrown wrote: On Sat, 16 May 2015 19:42:54 +0200 Patrick Marlier wrote: On 05/13/2015 04:58 AM, NeilBrown wrote: On Tue, 12 May 2015 22:38:53 -0400 Steven Rostedt wrote: On Tue, 12 May 2015 15:46:26 -0700

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

2015-05-18 Thread Patrick Marlier
On Mon, May 18, 2015 at 4:06 AM, NeilBrown wrote: > On Sat, 16 May 2015 19:42:54 +0200 Patrick Marlier > wrote: >> On 05/13/2015 04:58 AM, NeilBrown wrote: >> > On Tue, 12 May 2015 22:38:53 -0400 Steven Rostedt >> > wrote: >> >> On Tue, 12 May 2

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

2015-05-16 Thread Patrick Marlier
On 05/13/2015 04:58 AM, NeilBrown wrote: On Tue, 12 May 2015 22:38:53 -0400 Steven Rostedt wrote: On Tue, 12 May 2015 15:46:26 -0700 "Paul E. McKenney" wrote: From: Patrick Marlier Signed-off-by: Patrick Marlier Signed-off-by: Paul E. McKenney --- drivers/md/bitmap.c

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-04-13 Thread Patrick Marlier
:01:24PM +0100, Patrick Marlier wrote: >> > On 03/25/2015 03:30 PM, Paul E. McKenney wrote: >> > >On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: >> > >>Change to read effectively ptr with rcu_dereference_raw and not the >> > >>_

Re: [PATCH 2/3] netfilter: fix list_entry_rcu usage.

2015-03-25 Thread Patrick Marlier
On 03/25/2015 03:36 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:44AM +0100, Patrick Marlier wrote: >Signed-off-by: Patrick Marlier >--- > net/netfilter/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/net/netfilter/core.c b/ne

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-25 Thread Patrick Marlier
On 03/25/2015 03:30 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier Avoiding an extra load could be worthwhile in a

[PATCH 3/3] md/bitmap: fix list_entry_rcu usage.

2015-03-24 Thread Patrick Marlier
Signed-off-by: Patrick Marlier --- drivers/md/bitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 3a57679..ed00e46 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c @@ -181,7 +181,7 @@ static struct md_rdev

[PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-24 Thread Patrick Marlier
Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier --- include/linux/rculist.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/linux/rculist.h b/include/linux/rculist.h index a18b16f

[PATCH 2/3] netfilter: fix list_entry_rcu usage.

2015-03-24 Thread Patrick Marlier
Signed-off-by: Patrick Marlier --- net/netfilter/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/core.c b/net/netfilter/core.c index fea9ef5..05bd311 100644 --- a/net/netfilter/core.c +++ b/net/netfilter/core.c @@ -174,7 +174,7 @@ int nf_hook_slow

[PATCH 0/3] rculist: Fix list_entry_rcu to read ptr with, rcu_dereference_raw

2015-03-24 Thread Patrick Marlier
y this can be fixed differently. Fixing this showed 2 problems in the usage of list_entry_rcu. Since it touches other parts of kernel, I guess it requires ack from other maintainers. Thanks. PS: I will Cc the others maintainers when somebody confirms the problem. Signed-off-by: Patrick

Re: [doc, rfa] (v2) improve x86 transactional memory intrinsics section

2015-02-24 Thread Patrick Marlier
On 02/24/2015 01:51 AM, Sandra Loosemore wrote: On 02/23/2015 03:36 AM, Patrick Marlier wrote: On 02/22/2015 04:06 AM, Sandra Loosemore wrote: +Here is an example showing handling for @code{_XABORT_RETRY} +and a fallback path for other failures: + +@smallexample +#include + +int n_tries

Re: [doc, rfa] improve x86 transactional memory intrinsics section

2015-02-23 Thread Patrick Marlier
On 02/22/2015 04:06 AM, Sandra Loosemore wrote: On 02/19/2015 12:36 PM, Sandra Loosemore wrote: On 02/19/2015 09:38 AM, Patrick Marlier wrote: Thanks Sandra. Just a minor comment. -Valid abort status bits (when the value is not @code{_XBEGIN_STARTED}) are: +If the transaction aborts, the

Re: [doc, committed] copy-edit x86 transactional memory intrinsics section

2015-02-19 Thread Patrick Marlier
Thanks Sandra. Just a minor comment. -Valid abort status bits (when the value is not @code{_XBEGIN_STARTED}) are: +If the transaction aborts, the return value is one of: Here it is really bits. So maybe something like that: If the transaction aborts, the return value is a combination of the follo

Re: [PATCH, trans-mem, PR 61393] Copy tm_clone field of cgraph_node when cloning the node

2014-08-06 Thread Patrick Marlier
clone of particular function. So the question is: Can the compiler replace a function pointer by its corresponding constprop function pointer in some cases? -- Patrick Marlier

Re: [fprint] etes603 error

2014-06-24 Thread Patrick Marlier
Hi Paolo, Just to tell you that I can reproduce the problem on my machine. However I have no clue yet on why it happens with the enroll example. I am not sure when I will have time to dig more so you can try to use fprintd-enroll (it was working months, or years ago). Regards, -- Patrick On

Re: [fprint] EgisTec ES603 Error -22

2014-04-24 Thread Patrick Marlier
stay at the default value (0x23). Try to adjust first dcoffset and then vrt/vrb. What are your values with the auto-calibration? Thanks! -- Patrick Marlier ___ fprint mailing list fprint@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/fprint

Re: [fprint] 1c7a:0603 LighTuning Technology Inc. fingerprint scanner

2014-04-24 Thread Patrick Marlier
Jordan, It seems that you have an auto-calibration problem. Could you try to build libfprint in debug mode and send me the output when you start fprint_demo? If you restart many times fprint_demo, do you still get the same kind of image? Thanks! -- Patrick Marlier On Tue, Apr 15, 2014 at 8:48

Re: [fprint] EgisTec ES603 Error -22

2014-03-26 Thread Patrick Marlier
On Tue, Mar 25, 2014 at 10:22 PM, Martin Hejnfelt wrote: > On Tue, 2014-03-25 at 13:19 +0100, Patrick Marlier wrote: >> Indeed first capture looks fine even though 354 lines are removed from >> the capture. How fast did you swipe? Did you try fprint_demo to check >> the q

Re: [fprint] EgisTec ES603 Error -22

2014-03-25 Thread Patrick Marlier
Hi Martin, On Thu, Mar 20, 2014 at 9:52 PM, Martin Hejnfelt wrote: > Hi, > > I'm working with a EgisTec ES603 (1c7a:0603). I am using the current > HEAD from anarsoul git repository. > > When I try to enroll or identify (with async methods), sometimes it > works, but most of the time I get a resu

Re: [PATCH] Add -mtune=ia support

2013-12-05 Thread Patrick Marlier
ssors. At first, 'ia' means to me Itanium, ie IA-64. I would personally prefer another name but maybe I am the only one to think that. -- Patrick Marlier

[doc] Fixing reference inside Extended-Asm.html

2013-11-20 Thread Patrick Marlier
#x27;-'. $ curl http://gcc.gnu.org/onlinedocs/gcc/Extended-asm-with-goto.html\#Extended-asm-with-goto Locally I have: Is the version of texinfo buggy to generate online documentation? Thanks, -- Patrick Marlier

Re: [wwwdocs] Broken links

2013-11-20 Thread Patrick Marlier
+ Secify [docs] in the subject header. Also [wwwdocs] instead of [docs]. -- Patrick Marlier

Re: Libitm issues porting to POWER8 HTM

2013-06-17 Thread Patrick Marlier
Hi Peter, On Sat, Jun 15, 2013 at 2:44 AM, Peter Bergner wrote: > I'm currently implementing support for hardware transactional memory in > the rs6000 backend for POWER8. Things seem to be mostly working, but I > have run into a few issues I'm wondering whether other people are seeing. It sound

Re: [testsuite] Adding target nonpic to certain tests part. 2

2013-06-05 Thread Patrick Marlier
Hi Alexander, At least for TM testcase, I would prefer to add 'transaction_safe' attribute on foobar as in the attached patch. Aldy and Richard H: What do you think? Thanks, -- Patrick On Wed, Jun 5, 2013 at 1:13 PM, Alexander Ivchenko wrote: > Hi, > > Another bunch of tests that fails with -fp

Re: [testsuite] Adding target nonpic to g++.dg/tm/pr47746.C

2013-05-27 Thread Patrick Marlier
Hi, This is just a memo about why the testcase failed: When it tries to compile, we get this: gcc/testsuite/g++.dg/tm/pr47746.C:20:14: error: unsafe function call ‘void Building::load(InputStream*)’ within ‘transaction_safe’ function load(stream); Indeed, with PIC, the 'load' method can be ove

Re: [testsuite] Adding target nonpic to g++.dg/tm/pr47746.C

2013-04-18 Thread Patrick Marlier
Hi Alexander, On Thu, Apr 18, 2013 at 12:49 PM, Alexander Ivchenko wrote: > I'm trying it on linux/x86_64 on trunk. Testing just by adding -fpic > to the dg-options: > > --- a/gcc/testsuite/g++.dg/tm/pr47746.C > +++ b/gcc/testsuite/g++.dg/tm/pr47746.C > @@ -1,5 +1,5 @@ > // { dg-do compile } > -

Re: [testsuite] Adding target nonpic to g++.dg/tm/pr47746.C

2013-04-18 Thread Patrick Marlier
e a testfail for Android. Where/how does it fails? (backtrace?) I cannot reproduce with -fpic on linux/x86. Actually the test is not supposed to fail even with pic. So maybe you should open a PR. Thanks, -- Patrick Marlier

Re: [fprint] device not found..

2013-04-02 Thread Patrick Marlier
Dear Milan, Please use libfprint 0.5 and give the output of the configure to understand why you cannot compile it. Thanks. PS: When you put the driver into 0.4, did you update all required files (update configure.ac, ..., regenerate the configure/Makefile with autotools) -- Patrick On 04/0

Re: [PATCH] Fix PR libitm/55693

2013-02-06 Thread Patrick Marlier
Jack, On Wed, Feb 6, 2013 at 10:27 PM, Jack Howarth wrote: >I think you are making this much more complex than it really is. > The ENDFILE_SPEC on ppc is obtained from gcc/config/darwin.h and is > only... > > #define TM_DESTRUCTOR "%{fgnu-tm: -lcrttme.o}" > > whereas for intel darwin, it is d

Re: [PATCH] Fix PR libitm/55693

2013-02-06 Thread Patrick Marlier
On Wed, Feb 6, 2013 at 6:28 PM, Iain Sandoe wrote: > > On 6 Feb 2013, at 17:20, Jack Howarth wrote: > >> On Wed, Feb 06, 2013 at 05:37:12PM +0100, Patrick Marlier wrote: >>> Hi Jack, >>> >>> Thanks for having a look at this. >>> >>> Howe

Re: [PATCH] Fix PR libitm/55693

2013-02-06 Thread Patrick Marlier
Hi Jack, Thanks for having a look at this. However I don't understand why you need this: Index: gcc/config/i386/darwin.h === --- gcc/config/i386/darwin.h (revision 195764) +++ gcc/config/i386/darwin.h (working copy) @@ -131,8 +131,7

Re: [Libunwind-devel] [PATCH] siglongjmp documentation fix

2012-09-11 Thread Patrick Marlier
On 09/11/2012 02:14 AM, Tommi Rantala wrote: 2012/9/10 Patrick Marlier : Hi, I noticed a glitch in the documentation of libunwind-setjmp. Attached the patch. Nice catch! I don't have any account so if you could commit. Thanks! -- Patrick Ma

[Libunwind-devel] [PATCH] siglongjmp documentation fix

2012-09-10 Thread Patrick Marlier
Hi, I noticed a glitch in the documentation of libunwind-setjmp. Attached the patch. Thanks. -- Patrick Marlier diff --git a/doc/libunwind-setjmp.man b/doc/libunwind-setjmp.man index e8b9de8..1faa38e 100644 --- a/doc/libunwind-setjmp.man +++ b/doc/libunwind-setjmp.man @@ -36,7 +36,7 @@ _longjmp

Re: [fprint] Egistec ES603 Driver

2012-09-05 Thread Patrick Marlier
nable-debug-log" and send me the log output? Thanks for your help! -- Patrick :-( 2012/9/5 Patrick Marlier : Do you have a udev rules for the device? On my ubuntu I added the file "/etc/udev/rules.d/90-egis.rules" with the following content (on one line): SUBSYSTEM=="usb&

Re: [fprint] Egistec ES603 Driver

2012-09-05 Thread Patrick Marlier
has to be done at each reboot): $ lsusb Bus 002 Device 004: ID 1c7a:0603 LighTuning Technology Inc. $ sudo chmod a+rw /dev/bus/usb/002/004 -- Patrick Thnaks. 2012/9/5 Eriberto : Ok. Worked fine. I am using Debian Wheezy (7.0) testing. 2012/9/5 Patrick Marlier : Actually the problem here is also in

Re: [fprint] Egistec ES603 Driver

2012-09-05 Thread Patrick Marlier
On 09/05/2012 03:40 PM, Eriberto wrote: Patrick, another problem... configure: WARNING: unrecognized options: --enable-maintainer-mode Actually the problem here is also in the trunk. This is just a warning. Just remove --enable-maintained-mode in the "autogen.sh" file. Indeed, I think this --e

Re: [fprint] Egistec ES603 Driver

2012-09-05 Thread Patrick Marlier
On 09/05/2012 12:45 PM, Eriberto wrote: Patrick, I got this error when making ./autogen.sh: checking dynamic linker characteristics... (cached) GNU/Linux ld.so checking how to hardcode library paths into programs... immediate ./configure: line 15326: syntax error near unexpected token `)' ./con

Re: [fprint] Egistec ES603 Driver

2012-09-05 Thread Patrick Marlier
On 09/05/2012 09:24 AM, Eriberto wrote: Patrick, what is the download site? http://code.google.com/p/etes603/ Here to download the ubuntu 12.04 amd64 package: http://code.google.com/p/etes603/downloads/list or if you want to compile from sources: $ git clone https://code.google.com/p/etes603/

Re: [fprint] Egistec ES603 Driver

2012-09-05 Thread Patrick Marlier
6:38 PM, Patrick Marlier mailto:patrick.marl...@gmail.com>> wrote: Ronnie, On 09/04/2012 10:25 AM, Ronnie Koch wrote: On 08/13/2012 20:20 PM, Patrick Marlier wrote: I have also added a ubuntu package for 12.04 amd64 in the download section.

Re: [fprint] Egistec ES603 Driver

2012-09-05 Thread Patrick Marlier
Ronnie, On 09/04/2012 10:25 AM, Ronnie Koch wrote: On 08/13/2012 20:20 PM, Patrick Marlier wrote: I have also added a ubuntu package for 12.04 amd64 in the download section. Patrick, Had an urge this morning to see if I could get the fingerprint reader on my Lenovo B570 with Ubuntu 12.04

Re: [fprint] Egistec ES603 Driver

2012-08-28 Thread Patrick Marlier
Hi Bastien, On 08/28/2012 02:24 PM, Bastien Nocera wrote: On Fri, 2012-08-24 at 16:10 -0400, Patrick Marlier wrote: Bastien: I have two testers (if I consider Sachin) where the device works properly. I need to clean up few comments in the source file. Also I have some unused functions but

Re: [fprint] Egistec ES603 Driver

2012-08-24 Thread Patrick Marlier
, Patrick Marlier mailto:patrick.marl...@gmail.com>> wrote: Hi Sachin, On 08/20/2012 01:19 PM, Sachin Khadilkar wrote: Hi Patrick, This is really awesome, thanks for writing the driver. I installed the ubuntu package and tested it with fprint_demo. If it

Re: [fprint] Egistec ES603 Driver

2012-08-20 Thread Patrick Marlier
Hi Sachin, On 08/20/2012 01:19 PM, Sachin Khadilkar wrote: Hi Patrick, This is really awesome, thanks for writing the driver. I installed the ubuntu package and tested it with fprint_demo. If it works with fprint_demo, this is already a good point. The pam authentication with fingerprint is s

[PATCH] PR53992 - openmp lower transaction code

2012-08-20 Thread Patrick Marlier
I ask for that?). Tested on trunk / i686. Ok for trunk? Ok to backport to 4.7 branch if no regression? Thanks. gcc/ 2012-08-17 Patrick Marlier PR libgomp/53992 * omp-low.c (lower_omp_1): Handle GIMPLE_TRANSACTION. Index: omp-

Re: [fprint] Egistec ES603 Driver

2012-08-13 Thread Patrick Marlier
On 07/26/2012 09:42 AM, Patrick Marlier wrote: Hello, I have released a first public version. It is not yet complete (calibration is not perfect) but I would like some people to test it. You can find it here: http://code.google.com/p/etes603/ Thanks in advance for any tests and feedbacks, I

Re: Copyright assignment forms

2012-08-02 Thread Patrick Marlier
Hi, Here the links about that: http://gcc.gnu.org/wiki/CopyrightAssignment -- Patrick On 08/02/2012 09:14 AM, Paulo J. Matos wrote: Hello, Could someone please send me the copyright assignment forms for single contributions and for all future contributions? Cheers,

[fprint] Egistec ES603 Driver

2012-07-26 Thread Patrick Marlier
Hello, I have released a first public version. It is not yet complete (calibration is not perfect) but I would like some people to test it. You can find it here: http://code.google.com/p/etes603/ Thanks in advance for any tests and feedbacks, ___ fpr

[patch, libitm] fix __cxa_end_catch declaration

2012-05-21 Thread Patrick Marlier
Hi, __cxa_end_catch declaration was wrong. No functional change just correctness. Ok for trunk? Thanks. 2012-05-21 Patrick Marlier * eh_cpp.cc: Fix __cxa_end_catch declaration. -- Patrick Marlier Index: eh_cpp.cc

Re: trans-mem: functions making indirect calls are not transformed (issue6194061)

2012-05-15 Thread Patrick Marlier
Follow-up of Dave's patch with a testcase. Functions with indirect calls must be transactified (transformed). Tested on i686. Ok for trunk? -- Patrick 2012-05-15 Dave Boutcher Patrick Marlier * trans-mem.c (ipa_tm_transform_clone): Transform functions

Re: gnu-tm: Dont allow assigning transaction_unsafe functions to transaction_safe function pointers (issue6198054)

2012-05-15 Thread Patrick Marlier
ssert because the clone is not found. Tested on i686. Is the patch ok? Thanks. BTW, Should we generate a warning or an error? -- 2012-05-15 Patrick Marlier * trans-mem.c (diagnose_tm_1_op): Warn about assignment of transaction unsafe function to safe function pointer. testsuite/

Re: [trans-mem,darwin] PR/52042 find tm_clone_table with PIE

2012-02-28 Thread Patrick Marlier
Jack, Can I ask you to close this PR? http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52042 Indeed, my bugzilla account is a simple one and I cannot to change the bug status... -- Patrick On 02/07/2012 10:36 PM, Patrick Marlier wrote: Hi, The problem in this PR is that with PIE, getsectdata

Re: PATCH: PR boehm-gc/48299: FAIL: boehm-gc.c/thread_leak_test.c

2012-02-23 Thread Patrick Marlier
On 02/23/2012 09:34 PM, Jack Howarth wrote: On Thu, Feb 23, 2012 at 02:14:17PM -0500, Patrick Marlier wrote: On 02/23/2012 02:04 PM, Patrick Marlier wrote: Hello, As I see in my x86_64/linux gcc build and for example recently in: http://gcc.gnu.org/ml/gcc-testresults/2012-02/msg02269.html

Re: PATCH: PR boehm-gc/48299: FAIL: boehm-gc.c/thread_leak_test.c

2012-02-23 Thread Patrick Marlier
On 02/23/2012 02:04 PM, Patrick Marlier wrote: Hello, As I see in my x86_64/linux gcc build and for example recently in: http://gcc.gnu.org/ml/gcc-testresults/2012-02/msg02269.html === boehm-gc tests === Running target unix/-m32 FAIL: boehm-gc.c/thread_leak_test.c -O2 (test for excess errors

Re: PATCH: PR boehm-gc/48299: FAIL: boehm-gc.c/thread_leak_test.c

2012-02-23 Thread Patrick Marlier
Hello, As I see in my x86_64/linux gcc build and for example recently in: http://gcc.gnu.org/ml/gcc-testresults/2012-02/msg02269.html === boehm-gc tests === Running target unix/-m32 FAIL: boehm-gc.c/thread_leak_test.c -O2 (test for excess errors) === boehm-gc Summ

Re: [PATCH, i386] RTM support

2012-02-21 Thread Patrick Marlier
On 02/21/2012 02:52 AM, Uros Bizjak wrote: On Tue, Feb 21, 2012 at 12:26 AM, Andi Kleen wrote: IIUC the documentation, the fallback label is a parameter to xbegin insn, but the insn itself doesn't jump anywhere - it just records the From the point of view of the program XBEGIN behaves like a

Re: [PATCH, i386] RTM support

2012-02-20 Thread Patrick Marlier
On 02/20/2012 01:51 PM, Uros Bizjak wrote: On Mon, Feb 20, 2012 at 7:43 PM, Richard Henderson wrote: IIUC the documentation, the fallback label is a parameter to xbegin insn, but the insn itself doesn't jump anywhere - it just records the parameter as a fallback address. However, there is no g

Re: [PATCH, i386] RTM support

2012-02-16 Thread Patrick Marlier
On 02/16/2012 11:47 AM, Jakub Jelinek wrote: if you want to use different fallback code from the transaction code. So the above is right and needed, though perhaps we might want a combine pattern or peephole to turn the movl $-1, %eax xbegin .+6 cmpl %eax, $-1 jne 1f sequence into movl $-1, %eax

Re: [PATCH, i386] RTM support

2012-02-16 Thread Patrick Marlier
Hi, On 02/16/2012 11:06 AM, Kirill Yukhin wrote: > +(define_insn "xbegin_1" > + [(set (match_operand:SI 0 "register_operand" "=a") > +(unspec_volatile:SI [(match_dup 0)] UNSPECV_XBEGIN)) > + (set (match_operand:BLK 1 "" "") > +(unspec_volatile:BLK [(match_dup 1)] UNSPECV_XBEGIN))] > +

Re: [libitm, darwin] PR52220 move dummy functions definition

2012-02-15 Thread Patrick Marlier
On 02/15/2012 08:24 PM, Jack Howarth wrote: On Wed, Feb 15, 2012 at 11:48:29PM +, Iain Sandoe wrote: On 15 Feb 2012, at 23:39, Patrick Marlier wrote: PR libitm/52220 * alloc_cpp.cc: No dummy definitions for darwin. * eh_cpp.cc: Likewise. libgcc/ 2012-02-15 Iain

[libitm, darwin] PR52220 move dummy functions definition

2012-02-15 Thread Patrick Marlier
by Iain Sandoe. This was approved off-list by Mike Stump. Committed and tested on darwin 10/11. -- Patrick. libitm/ 2012-02-15 Iain Sandoe Patrick Marlier PR libitm/52220 * alloc_cpp.cc: No dummy definitions for darwin. * eh_cpp.cc: Likewise. libgcc

Re: [trans-mem,darwin] PR/52042 find tm_clone_table with PIE

2012-02-15 Thread Patrick Marlier
Here the committed patch approved off-list by Mike Stump which fixed PR/52042. Tested on darwin10/11 with x86_64. PS: this is my first commit so I hope I get it right. Otherwise do not hesitate to yell at me. Thanks. -- Patrick. 2012-02-15 Iain Sandoe Patrick Marlier

Re: [trans-mem,darwin] PR/52042 find tm_clone_table with PIE

2012-02-09 Thread Patrick Marlier
Hi Iain, On 02/09/2012 07:26 AM, Iain Sandoe wrote: apologies for (a) the extra loop - I missed a deprecation warning when I built your last version ... Thanks! Actually, I saw the depreciation but I didn't found that dladdr. (b) rolling two things into one mail ... ... (point 1 is related th

Re: [trans-mem,darwin] PR/52042 find tm_clone_table with PIE

2012-02-08 Thread Patrick Marlier
On 02/08/2012 12:12 AM, Jack Howarth wrote: I believe the remaining libitm.c++/eh-1.C execution test failures are due to the weakref linker bug currently in Xcode 4.x (radr://10466868) which I hae been told will be fixed in the next Xcode release after Xcode 4.3. Jack Humm... I

Re: [trans-mem,darwin] PR/52042 find tm_clone_table with PIE

2012-02-08 Thread Patrick Marlier
On 02/08/2012 04:14 PM, Mike Stump wrote: On Feb 7, 2012, at 7:36 PM, Patrick Marlier wrote: The problem in this PR is that with PIE, getsectdata does not return the position of tm_clone_table after the relocation. If tests passed, ok for 4.7? Ok. Thanks for all your hard work. If you

[trans-mem,darwin] PR/52042 find tm_clone_table with PIE

2012-02-07 Thread Patrick Marlier
(my knowledge of darwin is really limited)? Can someone do a bootstrap and test libitm on darwin (I have a limited access to a darwin machine, at least libitm tests pass)? Thanks! If tests passed, ok for 4.7? -- Patrick Marlier. libgcc: PR libitm/52042 * config/darwin-crt-tm.c

[trans-mem,libitm] brief report on known bugs

2012-02-07 Thread Patrick Marlier
renamed to simply itm.h? Thanks! -- Patrick Marlier.

Re: MAINTAINERS (Write After Approval): Add myself.

2012-02-03 Thread Patrick Marlier
On 02/03/2012 11:44 AM, Kumar, Venkataramanan wrote: Index: MAINTAINERS === --- MAINTAINERS (revision 183872) +++ MAINTAINERS (working copy) @@ -538,6 +538,7 @@ Jon zieglerj...@apple.com Roman zippelzip...@linux-m68k.org Josef

Re: [trans-mem, PATCH] do not dereference node if null in expand_call_tm (PR middle-end/52047)

2012-02-02 Thread Patrick Marlier
On 02/02/2012 04:22 AM, Richard Guenther wrote: On Wed, Feb 1, 2012 at 10:19 PM, Patrick Marlier wrote: On 02/01/2012 03:59 AM, Richard Guenther wrote: The patch looks ok, but I'm not sure why you do not get a cgraph node here - cgraph doesn't really care for builtins as far as

Re: [trans-mem, PATCH] do not dereference node if null in expand_call_tm (PR middle-end/52047)

2012-02-01 Thread Patrick Marlier
On 02/01/2012 03:59 AM, Richard Guenther wrote: The patch looks ok, but I'm not sure why you do not get a cgraph node here - cgraph doesn't really care for builtins as far as I can see. Honza? I cannot help on this... Don't you maybe want to handle builtins in a special way here? Indeed, I th

[trans-mem, PATCH] do not dereference node if null in expand_call_tm (PR middle-end/52047)

2012-01-31 Thread Patrick Marlier
OK? (I am almost sure I already proposed this modification few time ago but it have been lost somewhere.) -- Patrick. 2012-01-31 Patrick Marlier PR middle-end/52047 * trans-mem.c (expand_call_tm): Dereference node only if non-NULL. Index:

Re: [fprint] Adding new driver

2012-01-30 Thread Patrick Marlier
On 01/30/2012 01:18 PM, MOGANESHWARAN RAJASEGARAN wrote: I tested the driver with libfprint-0.4.0. And too bad it cannot work. Why? Any specific reason? libusb problem? If you give more information, I hope some people can help you. -- Patrick. ___ fp

Re: [libitm] Link eh-1.exe with -shared-libgcc on Solaris (PR libitm/51822)

2012-01-30 Thread Patrick Marlier
On 01/30/2012 12:15 PM, Jack Howarth wrote: On Mon, Jan 30, 2012 at 05:40:21PM +0100, Rainer Orth wrote: Richard Henderson writes: On 01/25/2012 12:03 AM, Rainer Orth wrote: Er.. how did we get two copies? The link line boils down to ld -o eh-1.exe crt1.o crti.o crtbegin.o eh-1.o -litm -l

Re: [fprint] EgisTec ES603 traces

2012-01-28 Thread Patrick Marlier
the libfprint without a beta test? Should I post as is in bugzilla and wait until somebody test it? Thanks. Patrick. On 01/22/2012 06:35 PM, Patrick Marlier wrote: Hi, I have started to write a driver for EgisTec (aka Lightuning) ES603 based on traces. I am looking for some more traces in

Re: [fprint] Driver skeleton

2012-01-28 Thread Patrick Marlier
Hi Suco, I guess you can have a look at this: http://www.nitgen.com.br/downloads/drivers And particularly at this: http://www.nitgen.com.br/Content/Uploads/Downloads/VenusDrv-1.0.1-7.2.tar.gz Since you do not have the specifications, I would advice you to start writing a C (or whatever) program

Re: PR testsuite/52011: add regparm to LTO/TM tests

2012-01-27 Thread Patrick Marlier
On 01/27/2012 11:02 AM, Aldy Hernandez wrote: If you all agree to remove ITM_REGPARM from libitm.h, then the tests on x86-32 will work. What is the status of this-- was there agreement on removing regparm? Note that I meant only for _ITM_beginTransaction. Indeed, regparm is ignored with varia

Re: PR testsuite/52011: add regparm to LTO/TM tests

2012-01-27 Thread Patrick Marlier
On 01/27/2012 10:14 AM, Aldy Hernandez wrote: +ITM_REGPARM noinline uint32_t _ITM_beginTransaction(uint32_t a, ...) { asm(""); } No ITM_REGPARM here. It should be also removed from libitm.h. -- Patrick.

Re: [fprint] Adding new driver

2012-01-25 Thread Patrick Marlier
s one for libusb 1.0 (AFAIK current version used in libfprint): int libusb_bulk_transfer (struct libusb_device_handle *dev_handle, unsigned char endpoint, unsigned char *data, int length, int *transferred, unsigned int timeout) -- Patrick Marlier. ___ fprint mailing list fprint@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/fprint

Re: [trans-mem] Do not instrument thread locals

2012-01-24 Thread Patrick Marlier
On 01/24/2012 08:32 PM, Andi Kleen wrote: Hi, > > I found that all thread local variables are instrumented with > _ITM_W/R* calls whereas they should not be shared with other > threads. This patch takes care of thread locals into requires_barrier > and also adds the local save/restore for the

Re: [libitm] Minor changes to libitm.h

2012-01-24 Thread Patrick Marlier
On 01/24/2012 07:32 PM, Torvald Riegel wrote: * Remove ITM_REGPARM from _ITM_beginTransaction since on x86-32, a > variadic function ignores regparm. > * Add ITM_PURE to _ITM_addUserCommitAction and _ITM_addUserUndoAction to > be usable inside transactions. Those should be called from transac

[libitm] Minor changes to libitm.h

2012-01-24 Thread Patrick Marlier
transactions. * Cosmetic changes to match GCC coding rules. By the way, is it on purpose that libitm.h is not installed? Tested on x86_64-unknown-linux-gnu. Ok for trunk? (Aldy, I am really sorry to bother you one more time. I owe you one) Thanks. -- Patrick. libitm/ 2012-01-24 Patrick Marlier

Re: [fprint] Adding new driver

2012-01-24 Thread Patrick Marlier
On 01/24/2012 10:55 AM, MOGANESHWARAN RAJASEGARAN wrote: Hi, I am having trouble creating the diff file for the newly written source file for eikontouch 300. I named it upeket.c. The source code is based on upektc.c. So how to create the diff file if there is no other source file to diff it? Or s

Re: [trans-mem,c++] PR51928

2012-01-24 Thread Patrick Marlier
On 01/24/2012 08:32 AM, Aldy Hernandez wrote: On 01/23/12 18:34, Patrick Marlier wrote: Hi, In this PR51928, it tries to look_for_tm_attr_overrides on a thunk but there is no DECL_NAME for thunk. So it fails in lookup_fnfields_idx_nolazy because name is NULL. #0 0x00764b5a in

[trans-mem,c++] PR51928

2012-01-23 Thread Patrick Marlier
(type=0x76a091f8, fndecl=0x769f8800) at ../../trunk/gcc/cp/class.c:4337 I hope the good way to solve this is to use the THUNK_TARGET instead of the thunk itself. (or just ignore when it is a thunk?) Tested on x86_64-unknown-linux-gnu. Thanks. -- Patrick Marlier. Changelog 2012-01-23

[trans-mem] Do not instrument thread locals

2012-01-23 Thread Patrick Marlier
fill any PR since I have already a patch for it but tell me if I have to. Tested on x86_64-unknown-linux-gnu, ok for trunk? Thanks. -- Patrick Marlier. ChangeLog 2012-01-23 Patrick Marlier * trans-mem.c (requires_barrier): Do not instrument thread local variables and emit

[fprint] EgisTec ES603 traces

2012-01-22 Thread Patrick Marlier
-SS500 / SS501 in case the protocol is the same or close. Michel, I have CCed you since you seem to have a ES603. Thanks for your help. -- Patrick Marlier. ___ fprint mailing list fprint@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-21 Thread Patrick Marlier
On 01/20/2012 08:04 AM, Dominique Dhumieres wrote: The following patch fixes the problem. The test fails on *-apple-darwin*: pr51916. TIA Dominique Dominique or Iain, may I ask you to test this patch on darwin? I have a sporadic access to a darwin machine. Bootstrapped and tested on x86_

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-21 Thread Patrick Marlier
On 01/20/2012 08:04 AM, Dominique Dhumieres wrote: The following patch fixes the problem. The test fails on *-apple-darwin*: pr51916. TIA Dominique Dominique or Iain, may I ask you to test this patch on darwin? I have a sporadic access to a darwin machine. Bootstrapped and tested on x86_

Re: [fprint] Minor fix

2012-01-20 Thread Patrick Marlier
On 01/20/2012 07:59 AM, Bastien Nocera wrote: On Wed, 2012-01-18 at 18:52 -0500, Patrick Marlier wrote: Hi, This patch fixes a minor bug if there is no deactivate callback. Pushed. In the future, I would prefer patches to be attached to bugs in the freedesktop bugzilla, so I don't miss

  1   2   >