[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

2021-12-22 Thread Kyrill Tkachov via Phabricator via cfe-commits
ktkachov added a comment. I think the most important use of the __ARM_FEATURE_MOPS is to check whether it's safe to use the new intrinsics, so it should only be defined by the compiler once it supports the intrinsics proposed in https://github.com/ARM-software/acle/pull/38/files Repository:

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

2020-12-15 Thread Kyrill Tkachov via Phabricator via cfe-commits
ktkachov added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:673-686 +def ProcA78C : SubtargetFeature<"cortex-a78c", "ARMProcFamily", +"CortexA78C", +"Cortex-A78C ARM processors", [ +

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

2020-12-10 Thread Kyrill Tkachov via Phabricator via cfe-commits
ktkachov added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:673-686 +def ProcA78C : SubtargetFeature<"cortex-a78c", "ARMProcFamily", +"CortexA78C", +"Cortex-A78C ARM processors", [ +

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

2020-08-05 Thread Kyrill Tkachov via Phabricator via cfe-commits
ktkachov added a comment. In D75181#2193447 , @danielkiss wrote: > Would it be better to add a new value to `"sign-return-address"` as `"none"`? > I don't see any other alternative option, I'm open to any other idea. FWIW GCC has a "sign-return-address"

[PATCH] D78129: Add Marvell ThunderX3T110 support

2020-04-24 Thread Kyrill Tkachov via Phabricator via cfe-commits
ktkachov added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These pointer authentication instructions require armv8.3a +let Predicates = [HasV8_3a, HasPA] in { let Uses = [LR], Defs = [LR] in { def PACIAZ : SystemNoOperands<0b000, "hi

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

2019-07-16 Thread Kyrill Tkachov via Phabricator via cfe-commits
ktkachov added a comment. In D64495#1587266 , @sammccall wrote: > FYI, this change broke git-llvm for everyone with a different username :-) > Fixed in r366198 Ah sorry, I accidentally included it in the commit! Repository: rL LLVM CHANGES SINCE LA

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

2019-07-16 Thread Kyrill Tkachov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366197: [AArch64] Implement __jcvt intrinsic from Armv8.3-A (authored by ktkachov, committed by ). Changed prior to commit: https://reviews.llvm.org/D64495?vs=209149&id=210051#toc Repository: rL LLVM

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

2019-07-11 Thread Kyrill Tkachov via Phabricator via cfe-commits
ktkachov updated this revision to Diff 209149. ktkachov added a comment. Fix comments plus an offline comment I had (copy-pasto in an assert message) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64495/new/ https://reviews.llvm.org/D64495 Files: clang/include/clang/Basic/BuiltinsAArc

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

2019-07-10 Thread Kyrill Tkachov via Phabricator via cfe-commits
ktkachov updated this revision to Diff 208980. ktkachov added a comment. Add more CHECK-LABEL tests, test v8.4a and v8.5a features. Fix formatting in pattern. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64495/new/ https://reviews.llvm.org/D64495 Files: clang/include/clang/Basic/Bu

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

2019-07-10 Thread Kyrill Tkachov via Phabricator via cfe-commits
ktkachov created this revision. ktkachov added reviewers: t.p.northover, SjoerdMeijer, pbarrio, momchil.velikov. ktkachov added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. The __jcvt intrinsic defined in ACLE [1] is available