Integrated: 8351290: Clarify integral only for vector operators

2025-04-04 Thread Ian Graves
On Tue, 25 Mar 2025 20:44:31 GMT, Ian Graves wrote: > Updating Javadoc for vector operators with VO_NOFP flags, but no > corresponding "Integral only." note in docs. This pull request has now been integrated. Changeset: fe8bd756 Author:Ian Graves URL: https://git

Re: RFR: 8351290: Clarify integral only for vector operators [v2]

2025-03-25 Thread Ian Graves
> Updating Javadoc for vector operators with VO_NOFP flags, but no > corresponding "Integral only." note in docs. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Missing period - Changes: - all: https:/

RFR: 8351290: Clarify integral only for vector operators

2025-03-25 Thread Ian Graves
Updating Javadoc for vector operators with VO_NOFP flags, but no corresponding "Integral only." note in docs. - Commit messages: - JDK-8351290: Clarify integral only for vector operators Changes: https://git.openjdk.org/jdk/pull/24237/files Webrev: https://webrevs.openjdk.org/?re

Integrated: 8339543: [vectorapi] laneHelper and withLaneHelper should be ForceInline

2025-03-24 Thread Ian Graves
On Fri, 21 Mar 2025 17:38:53 GMT, Ian Graves wrote: > Adding ForceInline to helper methods. This pull request has now been integrated. Changeset: 7d1fe0e0 Author: Ian Graves URL: https://git.openjdk.org/jdk/commit/7d1fe0e03fbdc73920094ff7905208a57dc4ee65 Stats: 64 lines in

RFR: 8339543: [vectorapi] laneHelper and withLaneHelper should be ForceInline

2025-03-21 Thread Ian Graves
Adding ForceInline to helper methods. - Commit messages: - Adding ForceInline to helper operations Changes: https://git.openjdk.org/jdk/pull/24165/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24165&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339543 Stats: 64

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v7]

2023-08-16 Thread Ian Graves
On Wed, 16 Aug 2023 09:11:34 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are a

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v4]

2023-08-15 Thread Ian Graves
On Thu, 3 Aug 2023 12:34:19 GMT, Raffaello Giulietti wrote: >> Cristian Vat has updated the pull request incrementally with one additional >> commit since the last revision: >> >> changes and test for CIBackRef > > The change looks good. > However, I'm not a Reviewer. This looks good to me,

Integrated: 8304898: Fix Copyright Headers for JLink Source Files

2023-03-24 Thread Ian Graves
On Fri, 24 Mar 2023 17:56:03 GMT, Ian Graves wrote: > Updating copyright headers on some files missed in a previous commit This pull request has now been integrated. Changeset: 3f59b75b Author: Ian Graves URL: https://git.openjdk.org/jdk/com

RFR: 8304898: Fix Copyright Headers for JLink Source Files

2023-03-24 Thread Ian Graves
Updating copyright headers on some files missed in a previous commit - Commit messages: - 8304898: Fix Copyright Headers for JLink Source Files Changes: https://git.openjdk.org/jdk/pull/13181/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13181&range=00 Issue: https://bug

Integrated: 8304691: Remove jlink --post-process-path option

2023-03-23 Thread Ian Graves
On Tue, 21 Mar 2023 20:39:38 GMT, Ian Graves wrote: > Removing the hidden `jlink --post-process-path` option. This pull request has now been integrated. Changeset: af0504e3 Author: Ian Graves URL: https://git.openjdk.org/jdk/commit/af0504e3f3de4ba40fa6187e48b584854b8e41f3 St

Re: RFR: 8304691: Remove jlink --post-process-path option [v5]

2023-03-23 Thread Ian Graves
> Removing the hidden `jlink --post-process-path` option. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing last bits of post process test - Changes: - all: https://git.openjdk.org/jdk/pull/13126/files -

Re: RFR: 8304691: Remove jlink --post-process-path option [v4]

2023-03-22 Thread Ian Graves
> Removing the hidden `jlink --post-process-path` option. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing post process opt reference - Changes: - all: https://git.openjdk.org/jdk/pull/13126/files - new: ht

Re: RFR: 8304691: Remove jlink --post-process-path option [v3]

2023-03-22 Thread Ian Graves
On Wed, 22 Mar 2023 19:57:51 GMT, Mandy Chung wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing leftover properties > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Jlin

Re: RFR: 8304691: Remove jlink --post-process-path option [v3]

2023-03-22 Thread Ian Graves
> Removing the hidden `jlink --post-process-path` option. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing leftover properties - Changes: - all: https://git.openjdk.org/jdk/pull/13126/files - new: ht

Re: RFR: 8304691: Remove jlink --post-process-path option [v2]

2023-03-22 Thread Ian Graves
On Wed, 22 Mar 2023 16:25:51 GMT, Ian Graves wrote: >> Removing the hidden `jlink --post-process-path` option. > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Updates per feedback Thanks! Upd

Re: RFR: 8304691: Remove jlink --post-process-path option [v2]

2023-03-22 Thread Ian Graves
> Removing the hidden `jlink --post-process-path` option. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Updates per feedback - Changes: - all: https://git.openjdk.org/jdk/pull/13126/files - new: ht

RFR: 8304691: Remove jlink --post-process-path option

2023-03-21 Thread Ian Graves
Removing the hidden `jlink --post-process-path` option. - Commit messages: - Removing Post Processing functionality Changes: https://git.openjdk.org/jdk/pull/13126/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13126&range=00 Issue: https://bugs.openjdk.org/browse/JDK-830

Integrated: 8217496: Matcher.group() can return null after usePattern

2023-03-07 Thread Ian Graves
On Thu, 2 Mar 2023 17:13:28 GMT, Ian Graves wrote: > Updates to the documentation to describe behavior in Matcher.group(). This pull request has now been integrated. Changeset: ac3ab5b0 Author: Ian Graves URL: https://git.openjdk.org/jdk/com

RFR: 8217496: Matcher.group() can return null after usePattern

2023-03-02 Thread Ian Graves
Updates to the documentation to describe behavior in Matcher.group(). - Commit messages: - Updating verbiage - Merge branch 'master' into matcher-group-doc-update - 8217496 Matcher.group() can return null after usePattern Changes: https://git.openjdk.org/jdk/pull/12835/files Webr

Integrated: 8293667: Align jlink's --compress option with jmod's --compress option

2023-02-27 Thread Ian Graves
On Fri, 9 Dec 2022 21:42:15 GMT, Ian Graves wrote: > This is an approach to adding a flag to jlink that will allow --compress to > take the same types of arguments as jmod, thus bringing the two into > alignment. This likely requires a CSR and a discussion on whether we should >

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v14]

2023-02-24 Thread Ian Graves
On Fri, 24 Feb 2023 03:52:31 GMT, Mandy Chung wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Additional cleanup > > src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.p

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v15]

2023-02-24 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: s/from/in - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull/11617/files/186e0224..05841fb5 Webr

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v14]

2023-02-23 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Additional cleanup - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull/11617/files/271eb254..186e0

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v13]

2023-02-23 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Tweaking warning messages and shortening them - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v12]

2023-02-23 Thread Ian Graves
On Thu, 23 Feb 2023 18:27:53 GMT, Mandy Chung wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tweaking properties > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/Defa

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v12]

2023-02-23 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Tweaking properties - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull/11617/files/74ec4f4b..b4339

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v11]

2023-02-22 Thread Ian Graves
On Wed, 22 Feb 2023 19:39:28 GMT, Ian Graves wrote: >> This is an approach to adding a flag to jlink that will allow --compress to >> take the same types of arguments as jmod, thus bringing the two into >> alignment. This likely requires a CSR and a discussion on

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v11]

2023-02-22 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding runtime testing of new compression args - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v10]

2023-02-21 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Updates per feedback - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull/11617/files/a9a4d4f0..b2c44

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2023-02-21 Thread Ian Graves
On Thu, 16 Feb 2023 22:50:25 GMT, Mandy Chung wrote: >> I think, there's also a typo in the next line: >> >> checkCompress(classes, compressPlugin, >> >> should have been: >> >> checkCompress(classes, compressPluginZip0, >> >> I haven't yet looked at the existing test code in `checkCompress`

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v9]

2023-02-17 Thread Ian Graves
On Fri, 17 Feb 2023 02:12:41 GMT, Mandy Chung wrote: >> Thanks. I note that there is a non-localized warning done this way elsewhere >> in jlink. May need to make a bug to localize this. > > I prefer this one should use the localized message. The other ones should be > followed up in a separat

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v9]

2023-02-16 Thread Ian Graves
On Thu, 16 Feb 2023 23:04:30 GMT, Mandy Chung wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Additional updates > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/Default

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v5]

2023-02-16 Thread Ian Graves
On Wed, 8 Feb 2023 13:27:09 GMT, Jaikiran Pai wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding plugin type to force compact strings vs zip ordering > > src/jdk.jlink/share/cl

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option

2023-02-16 Thread Ian Graves
On Mon, 9 Jan 2023 21:38:59 GMT, Mandy Chung wrote: >> I skimmed through this (not a detailed review) and I think it's mostly okay. >> It's --compress 0 and 2 that should be listed as deprecated as --compress 1 >> is string sharing rather than zip compression. > >> I skimmed through this (not a

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v9]

2023-02-16 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Additional updates - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull/11617/files/c9f4f32b..a9a4d

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v8]

2023-02-16 Thread Ian Graves
On Thu, 16 Feb 2023 19:08:39 GMT, Mandy Chung wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updating properties > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePlugi

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v8]

2023-02-15 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Updating properties - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull/11617/files/92416003..c9f4f

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v7]

2023-02-15 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with three additional commits since the last revision: - Removing string compression plugin - Fixing errant compact-constant-pools - ShareUTF8Entries update - Changes: - all: https://git.openjdk.org/jdk/pull

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v6]

2023-02-15 Thread Ian Graves
On Wed, 15 Feb 2023 18:23:02 GMT, Mandy Chung wrote: >> I think that deprecating the entire plugin could be appropriate, given the >> overhead, unless there's some performance data to the contrary. I haven't >> seen much in favor of keeping it, but I do think that breaking it apart from >> zip

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v6]

2023-02-15 Thread Ian Graves
On Tue, 14 Feb 2023 20:20:03 GMT, Mandy Chung wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing up resources > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/C

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v6]

2023-02-08 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Fixing up resources - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull/11617/files/06f4b3c3..2af25

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v5]

2023-02-06 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding plugin type to force compact strings vs zip ordering - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2023-01-25 Thread Ian Graves
On Thu, 15 Dec 2022 07:22:49 GMT, Jaikiran Pai wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Swapping deprecations in properties > > src/jdk.jlink/share/classes/jdk/tools/jlink/in

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v4]

2023-01-25 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding test for new plugin - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull/11617/files/9c03c6

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v3]

2023-01-25 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge remote-tra

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2023-01-09 Thread Ian Graves
On Thu, 15 Dec 2022 06:45:22 GMT, Jaikiran Pai wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Swapping deprecations in properties > > src/jdk.jlink/share/classes/jdk/tools/jlink/i

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2023-01-09 Thread Ian Graves
On Thu, 15 Dec 2022 06:43:40 GMT, Jaikiran Pai wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Swapping deprecations in properties > > src/jdk.jlink/share/classes/jd

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2022-12-12 Thread Ian Graves
compression arguments. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Swapping deprecations in properties - Changes: - all: https://git.openjdk.org/jdk/pull/11617/files - new: https://git.openjdk.org/jdk/pull/11617/fi

RFR: 8293667: Align jlink's --compress option with jmod's --compress option

2022-12-09 Thread Ian Graves
This is an approach to adding a flag to jlink that will allow --compress to take the same types of arguments as jmod, thus bringing the two into alignment. This likely requires a CSR and a discussion on whether we should deprecate or simply remove the original numeric compression arguments. ---

Integrated: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS

2022-03-28 Thread Ian Graves
On Fri, 18 Feb 2022 19:47:09 GMT, Ian Graves wrote: > Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters This pull request has now been integrated. Changeset: f01cce23 Author: Ian Graves URL: https://git.openjdk.java.net/jdk/

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v7]

2022-03-10 Thread Ian Graves
On Thu, 10 Mar 2022 16:23:13 GMT, Ian Graves wrote: >> Proposed change in behavior to correct inconsistencies between `\w` and `\b` >> metacharacters > > Ian Graves has refreshed the contents of this pull request, and previous > commits have been removed. Incremental vi

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v7]

2022-03-10 Thread Ian Graves
On Thu, 10 Mar 2022 16:23:13 GMT, Ian Graves wrote: >> Proposed change in behavior to correct inconsistencies between `\w` and `\b` >> metacharacters > > Ian Graves has updated the pull request incrementally with 196 additional > commits since the last revision: >

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v7]

2022-03-10 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request incrementally with 196 additional commits since the last revision: - Merge branch 'bug-8264160' of github.com:igraves/jdk into bug-8

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v6]

2022-03-10 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding description of word-boundary regex - Changes: - all:

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v5]

2022-03-09 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing superfluous 'if' - Changes: - all: https://git.

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v4]

2022-03-09 Thread Ian Graves
On Wed, 9 Mar 2022 16:30:24 GMT, Brian Burkhalter wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updating with additional descriptors. Removing DataProvider import > > src/java.base

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v3]

2022-03-08 Thread Ian Graves
On Tue, 8 Mar 2022 18:54:13 GMT, Lance Andersen wrote: >> Ian Graves has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains six commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jdk

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v4]

2022-03-08 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Updating with additional descriptors. Removing DataProvider import - C

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v3]

2022-03-08 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' of https://github.com/

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v2]

2022-03-08 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Bug id's to header and some other cleanup - Changes: -

Integrated: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag.

2022-03-08 Thread Ian Graves
On Mon, 14 Feb 2022 19:54:00 GMT, Ian Graves wrote: > Fixing a bug in `NFCCharProperty` where code falling through an if-statement > can prematurely set the matcher's `hitEnd` field to true. This pull request has now been integrated. Changeset: 3fc009be Author: Ian

Re: RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. [v4]

2022-03-07 Thread Ian Graves
> Fixing a bug in `NFCCharProperty` where code falling through an if-statement > can prematurely set the matcher's `hitEnd` field to true. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding back some missing CAN

Re: RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. [v2]

2022-03-07 Thread Ian Graves
On Tue, 8 Mar 2022 03:49:43 GMT, Jaikiran Pai wrote: >> Ian Graves has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - merging master >> - Catching erronious setting of matcher

Re: RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. [v3]

2022-03-07 Thread Ian Graves
> Fixing a bug in `NFCCharProperty` where code falling through an if-statement > can prematurely set the matcher's `hitEnd` field to true. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing errant newline ---

Re: RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. [v3]

2022-03-07 Thread Ian Graves
On Mon, 7 Mar 2022 23:05:55 GMT, Lance Andersen wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing errant newline > > src/java.base/share/classes/java/util/regex/Patt

RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS

2022-03-07 Thread Ian Graves
Proposed change in behavior to correct inconsistencies between `\w` and `\b` metacharacters - Commit messages: - Fixing bad javadoc - Merge remote-tracking branch 'upstream/master' into bug-8264160 - Updating spec - Proposed change for \b metacharacter Changes: https://git.openj

Re: RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. [v2]

2022-03-07 Thread Ian Graves
> Fixing a bug in `NFCCharProperty` where code falling through an if-statement > can prematurely set the matcher's `hitEnd` field to true. Ian Graves has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - mer

Integrated: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception

2022-02-22 Thread Ian Graves
On Wed, 16 Feb 2022 18:45:29 GMT, Ian Graves wrote: > This is a fix in the buggy way CIBackRef traverses unicode characters that > could be variable-length. Originally it followed the approach that BackRef > does, but failed to account for unicode characters that could be 2 > cha

Integrated: 8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java

2022-02-22 Thread Ian Graves
On Thu, 17 Feb 2022 18:02:20 GMT, Ian Graves wrote: > Adding a missing period per this doc bug. This pull request has now been integrated. Changeset: 41355e2d Author: Ian Graves URL: https://git.openjdk.java.net/jdk/commit/41355e2daa43fa8433bf77ed187979c49d453f4a Stats: 1 l

RFR: 8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java

2022-02-17 Thread Ian Graves
Adding a missing period per this doc bug. - Commit messages: - Adding missing period Changes: https://git.openjdk.java.net/jdk/pull/7521/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7521&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276686 Stats: 1 li

Re: RFR: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception [v2]

2022-02-16 Thread Ian Graves
this could potentially > result in multiple scans and codepoint conversions of the same matcher group > which could be long. The solution that adjusts the loop bounds on the fly > avoids this case. Ian Graves has updated the pull request incrementally with one additional commit since

Re: RFR: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception

2022-02-16 Thread Ian Graves
On Wed, 16 Feb 2022 21:00:00 GMT, Naoto Sato wrote: >> This is a fix in the buggy way CIBackRef traverses unicode characters that >> could be variable-length. Originally it followed the approach that BackRef >> does, but failed to account for unicode characters that could be 2 >> chars-long. T

RFR: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception

2022-02-16 Thread Ian Graves
This is a fix in the buggy way CIBackRef traverses unicode characters that could be variable-length. Originally it followed the approach that BackRef does, but failed to account for unicode characters that could be 2 chars-long. The upper bound (groupSize) for the traversing loop is set by the d

RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag.

2022-02-14 Thread Ian Graves
Fixing a bug in `NFCCharProperty` where code falling through an if-statement can prematurely set the matcher's `hitEnd` field to true. - Commit messages: - Catching erronious setting of matcher.hitEnd Changes: https://git.openjdk.java.net/jdk/pull/7466/files Webrev: https://webrev

Integrated: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException This pull request has now been integrated. Changeset: e3076552 Author: Ian Graves URL: https://git.openjdk.java.n

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Thanks @turbanoff , left off the JBS ID in the comment. - PR: https://git.openjdk.java.net/jdk/pull/7201

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match [v2]

2022-01-24 Thread Ian Graves
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Fixing docs and dates - Changes: - all:

RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
Replacing a buggy NullPointerException in `Pattern.compile()` with the proper PatternSyntaxException - Commit messages: - 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match Changes: https://git.openjdk.java.net/jdk/pull/7201/files Webrev: https://webre

Withdrawn: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
On Mon, 24 Jan 2022 16:22:08 GMT, Ian Graves wrote: > Replacing a buggy NPE with a PatternSyntaxException for cases with a bad > intersection operator. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/7199

RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
Replacing a buggy NPE with a PatternSyntaxException for cases with a bad intersection operator. - Commit messages: - 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match Changes: https://git.openjdk.java.net/jdk/pull/7199/files Webrev: https://webrevs.op

Re: RFR: 8276694: Pattern trailing unescaped backslash causes internal error

2022-01-11 Thread Ian Graves
On Mon, 20 Dec 2021 09:57:14 GMT, Masanori Yano wrote: > Could you please review the 8276694 bug fixes? > > A message specific for this exception should be printed instead of an > internal error. This fix adds a new check to output an appropriate exception > message when the regular expression

RFR: 8217496: Matcher.group() can return null after usePattern

2021-10-05 Thread Ian Graves
Specification update to clarify Matcher behavior to include a null return value. - Commit messages: - 8217496 Matcher.group() can return null after usePattern Changes: https://git.openjdk.java.net/jdk/pull/5827/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5827&range=

RFR: 8217501: Matcher.hitEnd returns false for incomplete surrogate pairs

2021-09-27 Thread Ian Graves
Fixing a bug where character matcher doesn't mark hitEnd as true if it's a code point with more than one character. - Commit messages: - 8217501: Matcher.hitEnd returns false for incomplete surrogate pairs Changes: https://git.openjdk.java.net/jdk/pull/5725/files Webrev: https://w

Integrated: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure

2021-09-15 Thread Ian Graves
On Thu, 9 Sep 2021 04:19:07 GMT, Ian Graves wrote: > Relaxing some assertion bounds to allow for small error values that still > show improvement over previous summation method. This pull request has now been integrated. Changeset: f531b5c7 Author: Ian Graves URL:

Re: RFR: 8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice

2021-09-13 Thread Ian Graves
On Tue, 14 Sep 2021 00:15:31 GMT, David Holmes wrote: > Please review this trivial fix to add the missing comma. > > Thanks, > David LGTM. Thanks @dholmes-ora - PR: https://git.openjdk.java.net/jdk/pull/5504

Integrated: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark

2021-09-13 Thread Ian Graves
On Wed, 8 Sep 2021 20:24:31 GMT, Ian Graves wrote: > The duplicate condition in this chain of expressions needs to be shrunk to > drop a couple of character that are not excluded spacing marks. This pull request has now been integrated. Changeset: 3d9dc8f8 Author: Ian Grave

Integrated: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark

2021-09-13 Thread Ian Graves
On Wed, 8 Sep 2021 20:24:31 GMT, Ian Graves wrote: > The duplicate condition in this chain of expressions needs to be shrunk to > drop a couple of character that are not excluded spacing marks. This pull request has now been integrated. Changeset: 3d9dc8f8 Author: Ian Grave

Re: RFR: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure [v3]

2021-09-13 Thread Ian Graves
> Relaxing some assertion bounds to allow for small error values that still > show improvement over previous summation method. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Factoring out Math.pow for squares - C

Re: RFR: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure [v2]

2021-09-13 Thread Ian Graves
On Mon, 13 Sep 2021 00:08:20 GMT, Joe Darcy wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tweaking asserts > > test/jdk/java/util/DoubleStreamSums/Compensa

Re: RFR: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark [v2]

2021-09-10 Thread Ian Graves
On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves wrote: >> The duplicate condition in this chain of expressions needs to be shrunk to >> drop a couple of character that are not excluded spacing marks. > > Ian Graves has updated the pull request incrementally with one additional

Re: RFR: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark [v2]

2021-09-10 Thread Ian Graves
On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves wrote: >> The duplicate condition in this chain of expressions needs to be shrunk to >> drop a couple of character that are not excluded spacing marks. > > Ian Graves has updated the pull request incrementally with one additional

Re: RFR: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark [v2]

2021-09-10 Thread Ian Graves
> The duplicate condition in this chain of expressions needs to be shrunk to > drop a couple of character that are not excluded spacing marks. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Refactoring test to wh

Re: RFR: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark [v2]

2021-09-10 Thread Ian Graves
> The duplicate condition in this chain of expressions needs to be shrunk to > drop a couple of character that are not excluded spacing marks. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Refactoring test to wh

Re: RFR: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure [v2]

2021-09-09 Thread Ian Graves
> Relaxing some assertion bounds to allow for small error values that still > show improvement over previous summation method. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Tweaking asserts - Changes: - all:

RFR: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure

2021-09-08 Thread Ian Graves
Relaxing some assertion bounds to allow for small error values that still show improvement over previous summation method. - Commit messages: - Dropping unnecessary equals case - Dropping equals zero assert Changes: https://git.openjdk.java.net/jdk/pull/5430/files Webrev: https:/

RFR: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark

2021-09-08 Thread Ian Graves
The duplicate condition in this chain of expressions needs to be shrunk to drop a couple of character that are not excluded spacing marks. - Commit messages: - 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark Changes: https://git.openjdk.ja

RFR: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark

2021-09-08 Thread Ian Graves
The duplicate condition in this chain of expressions needs to be shrunk to drop a couple of character that are not excluded spacing marks. - Commit messages: - 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark Changes: https://git.openjdk.ja

Integrated: 8214761: Bug in parallel Kahan summation implementation

2021-09-02 Thread Ian Graves
On Fri, 2 Jul 2021 20:12:39 GMT, Ian Graves wrote: > 8214761: Bug in parallel Kahan summation implementation This pull request has now been integrated. Changeset: dd871819 Author: Ian Graves URL: https://git.openjdk.java.net/jdk/commit/dd871819a05886ee09fc00c7c778268440ebedb7 St

Re: RFR: 8214761: Bug in parallel Kahan summation implementation [v4]

2021-09-01 Thread Ian Graves
> 8214761: Bug in parallel Kahan summation implementation Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Fixing compensation test - Changes: - all: https://git.openjdk.java.net/jdk/pull/4674/files - new: ht

Re: RFR: 8214761: Bug in parallel Kahan summation implementation [v3]

2021-08-31 Thread Ian Graves
> 8214761: Bug in parallel Kahan summation implementation Ian Graves has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since

  1   2   3   4   >