Re: r345660 - [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

2018-10-31 Thread Friedman, Eli via cfe-commits
On 10/30/2018 2:58 PM, Roman Lebedev via cfe-commits wrote: Author: lebedevri Date: Tue Oct 30 14:58:56 2018 New Revision: 345660 URL: http://llvm.org/viewvc/llvm-project?rev=345660&view=rev Log: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part This is the second

Re: r344199 - Add a flag to remap manglings when reading profile data information.

2018-10-10 Thread Friedman, Eli via cfe-commits
On 10/10/2018 4:13 PM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Wed Oct 10 16:13:35 2018 New Revision: 344199 URL: http://llvm.org/viewvc/llvm-project?rev=344199&view=rev Log: Add a flag to remap manglings when reading profile data information. This can be used to preserve prof

Re: r338239 - [mips64][clang] Provide the signext attribute for i32 return values

2018-07-30 Thread Friedman, Eli via cfe-commits
On 7/30/2018 3:44 AM, Stefan Maksimovic via cfe-commits wrote: Author: smaksimovic Date: Mon Jul 30 03:44:46 2018 New Revision: 338239 URL: http://llvm.org/viewvc/llvm-project?rev=338239&view=rev Log: [mips64][clang] Provide the signext attribute for i32 return values Additional info: see r3380

Re: r331370 - Add -foutline option to enable the MachineOutliner in AArch64

2018-05-02 Thread Friedman, Eli via cfe-commits
On 5/2/2018 9:42 AM, Jessica Paquette via cfe-commits wrote: Author: paquette Date: Wed May 2 09:42:51 2018 New Revision: 331370 URL: http://llvm.org/viewvc/llvm-project?rev=331370&view=rev Log: Add -foutline option to enable the MachineOutliner in AArch64 It probably makes sense to also have

Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

2018-04-12 Thread Friedman, Eli via cfe-commits
The test wasn't checking anything useful; the clang driver never passes "-arm-long-calls" to clang -cc1.  See https://reviews.llvm.org/rL241565 . -Eli On 4/12/2018 3:55 PM, George Karpenkov wrote: Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-ke

Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-25 Thread Friedman, Eli via cfe-commits
On 10/25/2017 12:49 PM, Reid Kleckner wrote: On Wed, Oct 25, 2017 at 12:14 PM, Friedman, Eli mailto:efrie...@codeaurora.org>> wrote: Maybe we should just ignore -fno-short-wchar, instead?  I think that's what gcc and released versions of clang do (that means -fno-short-wchar doesn't

Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-25 Thread Friedman, Eli via cfe-commits
On 10/25/2017 11:54 AM, Reid Kleckner wrote: On Wed, Oct 25, 2017 at 10:56 AM, Friedman, Eli mailto:efrie...@codeaurora.org>> wrote: On 10/6/2017 4:09 PM, Saleem Abdulrasool via cfe-commits wrote: Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL: http://llvm

Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-25 Thread Friedman, Eli via cfe-commits
On 10/6/2017 4:09 PM, Saleem Abdulrasool via cfe-commits wrote: Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=315126&r1=315125&r2=315126&view=diff

Re: r316046 - Basic: fix __{,U}INTPTR_TYPE__ on ARM

2017-10-20 Thread Friedman, Eli via cfe-commits
On 10/17/2017 5:00 PM, Saleem Abdulrasool via cfe-commits wrote: Author: compnerd Date: Tue Oct 17 17:00:50 2017 New Revision: 316046 URL: http://llvm.org/viewvc/llvm-project?rev=316046&view=rev Log: Basic: fix __{,U}INTPTR_TYPE__ on ARM Darwin and OpenBSD are the only platforms which use `long

Re: Patch bug 27628 (clang-tidy should exit with a failure code when there are errors)

2017-10-17 Thread Friedman, Eli via cfe-commits
Sometimes people just lose track; "pinging" is normal (see http://llvm.org/docs/DeveloperPolicy.html#code-reviews).  And sometimes it's helpful to CC reviewers in the area; adding Alexander Kornienko. -Eli On 10/17/2017 12:03 PM, Antoni Boucher wrote: Since the patch was redirected to the rig

Re: r314262 - Emit section information for extern variables.

2017-10-04 Thread Friedman, Eli via cfe-commits
On 10/4/2017 1:48 PM, Keane, Erich wrote: Ah, cool!  I didn’t realize that, and that is actually exactly what Elizabeth is looking into now. Elizabeth, if you send me a diff, I’ll commit it as review-after-commit if Eli is alright with this.  It should be something like changing: +      i

Re: r314262 - Emit section information for extern variables.

2017-10-04 Thread Friedman, Eli via cfe-commits
Oh, that's easy to explain; sorry, I didn't think of it when I was reviewing. DefinitionKind has three possible values: DeclarationOnly, TentativeDefinition, and Definition.  (Tentative definitions are C weirdness that allows you to write "int x; int x = 10;".) For the purpose of this warnin

Re: Patch bug 27628 (clang-tidy should exit with a failure code when there are errors)

2017-09-28 Thread Friedman, Eli via cfe-commits
When you're submitting a patch, please make sure you're sending it to the right list, and the "subject" line actually describes what the patch changes; otherwise, reviewers won't notice the patch.  Optionally, you can submit a patch using Phabricator, a tool which which makes patch reviews a li

Re: r314235 - Allow IUnknown/IInterface types to come from extern C++

2017-09-26 Thread Friedman, Eli via cfe-commits
On 9/26/2017 11:55 AM, Erich Keane via cfe-commits wrote: Author: erichkeane Date: Tue Sep 26 11:55:16 2017 New Revision: 314235 URL: http://llvm.org/viewvc/llvm-project?rev=314235&view=rev Log: Allow IUnknown/IInterface types to come from extern C++ It was brought up in response to my last imp

Re: r313907 - Suppress Wsign-conversion for enums with matching underlying type

2017-09-21 Thread Friedman, Eli via cfe-commits
On 9/21/2017 12:58 PM, Erich Keane via cfe-commits wrote: Author: erichkeane Date: Thu Sep 21 12:58:55 2017 New Revision: 313907 URL: http://llvm.org/viewvc/llvm-project?rev=313907&view=rev Log: Suppress Wsign-conversion for enums with matching underlying type As reported here: https://bugs.llv

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

2017-09-08 Thread Friedman, Eli via cfe-commits
On 9/8/2017 2:18 PM, Hans Wennborg via cfe-commits wrote: On Fri, Sep 8, 2017 at 2:09 PM, Roman Lebedev wrote: Interesting. My first thought was to explicitly specify enum as signed: enum MediaDeviceType : signed int { MEDIA_DEVICE_TYPE_AUDIO_INPUT = 0, MEDIA_DEVICE_TYPE_VIDEO_INPUT, MEDIA_DE

Re: r302255 - Warn that the [] spelling of uuid(...) is deprecated.

2017-05-05 Thread Friedman, Eli via cfe-commits
On 5/5/2017 10:20 AM, Nico Weber via cfe-commits wrote: Timestamps on cfe-commits are a bit messed up. I landed that just now, but the timestamp is from 13 minutes in the past. Maybe the clock on the mail server is off by 13 min? The timestamp on the message matches the timestamp in the svn lo

Re: [cfe-dev] Testcase for LLVM PR9350

2017-01-12 Thread Friedman, Eli via cfe-commits
On 1/6/2017 3:05 PM, Andrew Rogers wrote: Hi, This is a (tested!) patch to add checks that both pre-increment and pre-decrement don’t overflow, for both char and short integer types (since they’re both narrower than int), as per the problem fixed in PR9350. r291805. -Eli -- Employee o

Re: r290146 - Fix completely bogus types for some builtins:

2016-12-21 Thread Friedman, Eli via cfe-commits
On 12/20/2016 6:56 PM, Richard Smith wrote: On 20 December 2016 at 18:14, Richard Smith <mailto:rich...@metafoo.co.uk>> wrote: On 19 December 2016 at 17:00, Friedman, Eli via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: On 12/19/2016 3:59 PM, Richar

Re: r290146 - Fix completely bogus types for some builtins:

2016-12-19 Thread Friedman, Eli via cfe-commits
On 12/19/2016 3:59 PM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Mon Dec 19 17:59:34 2016 New Revision: 290146 URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/vfprintf-valid-redecl.c?rev=290146&r1=290145&r2=290146&view=diff ==

Re: [PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

2016-09-09 Thread Friedman, Eli via cfe-commits
It probably makes sense to say that alloca should have the same alignment as the default stack alignment, simply because it's hard to do anything useful with completely unaligned memory. That said, the default stack alignment is 4 bytes on 32-bit Windows, not 16. -Eli On 9/9/2016 10:29 AM, R