[clang] af2968e - [clang] Fix invalid comparator in tablegen

2020-04-16 Thread Eric Fiselier via cfe-commits
Author: Eric Fiselier Date: 2020-04-16T18:38:32-04:00 New Revision: af2968e37f4c95846ffe287b64a4fcd72c765bee URL: https://github.com/llvm/llvm-project/commit/af2968e37f4c95846ffe287b64a4fcd72c765bee DIFF: https://github.com/llvm/llvm-project/commit/af2968e37f4c95846ffe287b64a4fcd72c765bee.diff

Re: [PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

2020-03-11 Thread Eric Fiselier via cfe-commits
On Wed, Mar 11, 2020 at 8:35 PM Arthur O'Dwyer via Phabricator < revi...@reviews.llvm.org> wrote: > Quuxplusone added inline comments. > > > > Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.h:27 > +class UnintendedADLCheck : public ClangTidyCheck { > + const

[clang-tools-extra] 020ed67 - [clang-tidy] Fix check for Abseil internal namespace access

2020-01-21 Thread Eric Fiselier via cfe-commits
Author: Eric Fiselier Date: 2020-01-21T15:21:53-05:00 New Revision: 020ed6713d889a95f8c98d7725c87b458d99f6b3 URL: https://github.com/llvm/llvm-project/commit/020ed6713d889a95f8c98d7725c87b458d99f6b3 DIFF: https://github.com/llvm/llvm-project/commit/020ed6713d889a95f8c98d7725c87b458d99f6b3.diff

[clang-tools-extra] r367263 - [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

2019-07-29 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 29 14:38:56 2019 New Revision: 367263 URL: http://llvm.org/viewvc/llvm-project?rev=367263&view=rev Log: [clang-tidy]: Google: new check 'google-upgrade-googletest-case' Introduce a new check to upgrade user code based on API changes in Googletest. The check finds use

r361920 - Make __has_builtin work with __builtin_LINE and friends.

2019-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue May 28 20:15:36 2019 New Revision: 361920 URL: http://llvm.org/viewvc/llvm-project?rev=361920&view=rev Log: Make __has_builtin work with __builtin_LINE and friends. The source location builtins are implemented as keywords, but __has_builtin should still report true for th

Re: [PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

2019-05-28 Thread Eric Fiselier via cfe-commits
* The alignment check can be removed, and I'll do so tomorrow if someone doesn't beat me to it. On Tue, May 28, 2019 at 1:54 AM Eric Fiselier wrote: > The alignment check can just be removed. > > On Mon., May 27, 2019, 7:57 p.m. Ulrich Weigand via Phabricator, < > revi...@reviews.llvm.org> wrote

Re: [PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

2019-05-27 Thread Eric Fiselier via cfe-commits
The alignment check can just be removed. On Mon., May 27, 2019, 7:57 p.m. Ulrich Weigand via Phabricator, < revi...@reviews.llvm.org> wrote: > uweigand added a comment. > > Looks like this test is failing on SystemZ since it was added, making all > our build bots red: > > > /home/uweigand/sandbox

r361571 - Fix hang during constant evaluation of union assignment.

2019-05-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 23 16:34:43 2019 New Revision: 361571 URL: http://llvm.org/viewvc/llvm-project?rev=361571&view=rev Log: Fix hang during constant evaluation of union assignment. HandleUnionActiveMemberChange forgot to walk over a nop implicit conversion node and got stuck in the proce

r360951 - Remove unneeded alignment spec from builtin_FUNCTION.cpp test

2019-05-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 16 16:07:45 2019 New Revision: 360951 URL: http://llvm.org/viewvc/llvm-project?rev=360951&view=rev Log: Remove unneeded alignment spec from builtin_FUNCTION.cpp test Modified: cfe/trunk/test/CodeGenCXX/builtin_FUNCTION.cpp Modified: cfe/trunk/test/CodeGenCXX/buil

r360947 - Fix failing source location test on Windows

2019-05-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 16 15:21:42 2019 New Revision: 360947 URL: http://llvm.org/viewvc/llvm-project?rev=360947&view=rev Log: Fix failing source location test on Windows Modified: cfe/trunk/test/CodeGenCXX/builtin_FUNCTION.cpp Modified: cfe/trunk/test/CodeGenCXX/builtin_FUNCTION.cpp U

r360943 - Fix PCC test failures for source location builtins

2019-05-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 16 14:51:39 2019 New Revision: 360943 URL: http://llvm.org/viewvc/llvm-project?rev=360943&view=rev Log: Fix PCC test failures for source location builtins Modified: cfe/trunk/test/CodeGenCXX/builtin-source-location.cpp cfe/trunk/test/CodeGenCXX/builtin_LINE.cp

r360937 - Implement __builtin_LINE() et. al. to support source location capture.

2019-05-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 16 14:04:15 2019 New Revision: 360937 URL: http://llvm.org/viewvc/llvm-project?rev=360937&view=rev Log: Implement __builtin_LINE() et. al. to support source location capture. Summary: This patch implements the source location builtins `__builtin_LINE(), `__builtin_FU

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

2019-05-08 Thread Eric Fiselier via cfe-commits
Sorry, I should have been on top of this. /Eric On Wed., May 8, 2019, 11:47 p.m. Richard Smith, wrote: > I went ahead and did this in r360310. > > On Thu, 25 Apr 2019 at 14:31, Richard Smith wrote: > > > > On Wed, 24 Apr 2019 at 19:28, Eric Fiselier via cfe-commits > &

Re: r359361 - Revert Fix interactions between __builtin_constant_p and constexpr to match current trunk GCC.

2019-04-30 Thread Eric Fiselier via cfe-commits
Jorge, Why did you revert this? /Eric On Sat, Apr 27, 2019 at 6:01 AM Roman Lebedev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Sat, Apr 27, 2019 at 3:29 AM Jorge Gorbe Moya via cfe-commits > wrote: > > > > Author: jgorbe > > Date: Fri Apr 26 17:32:04 2019 > > New Revision: 35936

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

2019-04-24 Thread Eric Fiselier via cfe-commits
Do I just edit the HTML file directly? Or is it generated by something? On Wed, Apr 24, 2019 at 3:35 PM Richard Smith wrote: > Thanks! Can you update cxx_status.html to mark P0595R2 as done? > > On Tue, 23 Apr 2019 at 19:21, Eric Fiselier via cfe-commits > wrote: > >

r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

2019-04-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Apr 23 19:23:30 2019 New Revision: 359067 URL: http://llvm.org/viewvc/llvm-project?rev=359067&view=rev Log: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a Summary: This patch implements `__builtin_is_constant_evaluated` as specifier by [P0595R2](ht

r355743 - [8.0 Regression] Fix handling of `__builtin_constant_p` inside template arguments, enumerators, case statements, and the enable_if attribute.

2019-03-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Mar 8 14:06:48 2019 New Revision: 355743 URL: http://llvm.org/viewvc/llvm-project?rev=355743&view=rev Log: [8.0 Regression] Fix handling of `__builtin_constant_p` inside template arguments, enumerators, case statements, and the enable_if attribute. Summary: The followin

r352983 - Correct test my *really really* overaligning a type.

2019-02-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 2 20:10:38 2019 New Revision: 352983 URL: http://llvm.org/viewvc/llvm-project?rev=352983&view=rev Log: Correct test my *really really* overaligning a type. Modified: cfe/trunk/test/SemaCXX/extended-usual-deallocation-functions.cpp Modified: cfe/trunk/test/SemaCX

r352980 - Fix handling of usual deallocation functions in various configuratios.

2019-02-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 2 19:44:31 2019 New Revision: 352980 URL: http://llvm.org/viewvc/llvm-project?rev=352980&view=rev Log: Fix handling of usual deallocation functions in various configuratios. Clang allows users to enable or disable various types of allocation and deallocation regardle

r352927 - Improve diagnostic to tell you a type is incomplete.

2019-02-01 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 1 14:06:02 2019 New Revision: 352927 URL: http://llvm.org/viewvc/llvm-project?rev=352927&view=rev Log: Improve diagnostic to tell you a type is incomplete. I recently ran into this code: ``` \#include void foo(const std::string &s, const std::string& = ""); \#includ

r352919 - Don't use ASTContext in DeclOpenMP.h because it's still incomplete.

2019-02-01 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 1 13:19:20 2019 New Revision: 352919 URL: http://llvm.org/viewvc/llvm-project?rev=352919&view=rev Log: Don't use ASTContext in DeclOpenMP.h because it's still incomplete. Modified: cfe/trunk/include/clang/AST/DeclOpenMP.h cfe/trunk/lib/AST/DeclOpenMP.cpp Mod

r351484 - Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides.

2019-01-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jan 17 13:44:24 2019 New Revision: 351484 URL: http://llvm.org/viewvc/llvm-project?rev=351484&view=rev Log: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides. Summary: Some style guides want to allow using CTAD only on types tha

r351294 - [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03

2019-01-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jan 15 18:34:36 2019 New Revision: 351294 URL: http://llvm.org/viewvc/llvm-project?rev=351294&view=rev Log: [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03 When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t as an unscoped

r349195 - [Clang] Add __builtin_launder

2018-12-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Dec 14 13:11:28 2018 New Revision: 349195 URL: http://llvm.org/viewvc/llvm-project?rev=349195&view=rev Log: [Clang] Add __builtin_launder Summary: This patch adds `__builtin_launder`, which is required to implement `std::launder`. Additionally GCC provides `__builtin_lau

r348977 - [AST] Store "UsesADL" information in CallExpr.

2018-12-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Dec 12 13:50:55 2018 New Revision: 348977 URL: http://llvm.org/viewvc/llvm-project?rev=348977&view=rev Log: [AST] Store "UsesADL" information in CallExpr. Summary: Currently the Clang AST doesn't store information about how the callee of a CallExpr was found. Specificall

r348864 - Pass PartialOverloading argument to the correct corresponding parameter

2018-12-11 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Dec 11 08:53:25 2018 New Revision: 348864 URL: http://llvm.org/viewvc/llvm-project?rev=348864&view=rev Log: Pass PartialOverloading argument to the correct corresponding parameter Modified: cfe/trunk/lib/Sema/SemaOverload.cpp cfe/trunk/test/CodeCompletion/function

[clang-tools-extra] r348633 - [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'

2018-12-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Dec 7 12:03:03 2018 New Revision: 348633 URL: http://llvm.org/viewvc/llvm-project?rev=348633&view=rev Log: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions' Patch by Alex Strelnikov. Reviewed as D53830 Introduce a new check to upgrade user code based

Re: r345306 - Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"

2018-10-25 Thread Eric Fiselier via cfe-commits
t; >> When reverting (even when reverting your own commit), please include in >> the commit description a reason for the revert. >> >> On Thu, 25 Oct 2018 at 12:52, Eric Fiselier via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Aut

Re: r345306 - Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"

2018-10-25 Thread Eric Fiselier via cfe-commits
Ack. My bad. On Thu, Oct 25, 2018 at 4:02 PM Richard Smith wrote: > When reverting (even when reverting your own commit), please include in > the commit description a reason for the revert. > > On Thu, 25 Oct 2018 at 12:52, Eric Fiselier via cfe-commits < > cfe-commits@lis

r345306 - Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"

2018-10-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Oct 25 12:50:43 2018 New Revision: 345306 URL: http://llvm.org/viewvc/llvm-project?rev=345306&view=rev Log: Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03" This reverts commit b5d8d0de744d2c212bdb17d5c5fd4447dd14dbd2. Removed: cfe/trunk/

Re: r345296 - [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03

2018-10-25 Thread Eric Fiselier via cfe-commits
reverting On Thu., Oct. 25, 2018, 2:18 p.m. Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org wrote: > Author: ericwf > Date: Thu Oct 25 11:16:16 2018 > New Revision: 345296 > > URL: http://llvm.org/viewvc/llvm-project?rev=345296&view=rev > Log: > [SemaC

r345296 - [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03

2018-10-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Oct 25 11:16:16 2018 New Revision: 345296 URL: http://llvm.org/viewvc/llvm-project?rev=345296&view=rev Log: [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03 Summary: When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t as an

r345225 - Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"

2018-10-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 24 16:47:04 2018 New Revision: 345225 URL: http://llvm.org/viewvc/llvm-project?rev=345225&view=rev Log: Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03" This reverts commit 6f47cdd51341344c0e32630e19e72c94cd25f34e. Removed: cfe/trunk/

r345211 - [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03

2018-10-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 24 15:38:49 2018 New Revision: 345211 URL: http://llvm.org/viewvc/llvm-project?rev=345211&view=rev Log: [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03 Summary: When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t as an

Re: [libcxx] r342073 - Implement the infrastructure for feature-test macros. Very few actual feature test macros, though. Reviewed as: https://reviews.llvm.org/D51955

2018-10-04 Thread Eric Fiselier via cfe-commits
On Thu, Oct 4, 2018 at 11:42 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Perhaps libc++ could provide a __version file that contains the headers, > and use #include <__version> internally? We'd still need a header > that just includes <__version> for conformance, but t

Re: r342827 - Fix modules build with shared library.

2018-10-01 Thread Eric Fiselier via cfe-commits
gt;>> wrote: >>>>> >>>>>> Hey Eric - thanks for the fix - but could you explain the issue here >>>>>> in a bit more detail, as I'm a bit confused (& really interested in >>>>>> understanding any layering problems

r343420 - Fix linkage error on ProgramPoint's dump method.

2018-09-30 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Sep 30 11:05:39 2018 New Revision: 343420 URL: http://llvm.org/viewvc/llvm-project?rev=343420&view=rev Log: Fix linkage error on ProgramPoint's dump method. Currently, ProgramPoint::dump calls the out-of-line function ProgramPoint::print. This causes libraries which incl

Re: r342827 - Fix modules build with shared library.

2018-09-30 Thread Eric Fiselier via cfe-commits
> understanding any layering problems in LLVM - and fixing them/making sure >>>> they're fixed/holding the line/etc) >>>> >>>> What do you mean by "pull all of the AST matchers library into clang" - >>>> how does including a head

Re: r342827 - Fix modules build with shared library.

2018-09-30 Thread Eric Fiselier via cfe-commits
T matchers library into clang" - >>> how does including a header ever add a link dependency? >>> >>> - Dave >>> >>> >>> On Sat, Sep 22, 2018 at 5:49 PM Eric Fiselier via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >&

r342827 - Fix modules build with shared library.

2018-09-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Sep 22 17:48:05 2018 New Revision: 342827 URL: http://llvm.org/viewvc/llvm-project?rev=342827&view=rev Log: Fix modules build with shared library. r341994 caused clangAnalysis to pull all of the AST matchers library into clang. Due to inline key functions in the headers,

[libcxx] r340426 - Add diagnostics for min/max algorithms when a InputIterator is used.

2018-08-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Aug 22 10:47:13 2018 New Revision: 340426 URL: http://llvm.org/viewvc/llvm-project?rev=340426&view=rev Log: Add diagnostics for min/max algorithms when a InputIterator is used. These algorithms require a ForwardIterator or better. Ensure we diagnose the contract violation

[libcxx] r340406 - Attempt to unbreak filesystem tests on certain linux distros.

2018-08-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Aug 22 06:29:52 2018 New Revision: 340406 URL: http://llvm.org/viewvc/llvm-project?rev=340406&view=rev Log: Attempt to unbreak filesystem tests on certain linux distros. On some platforms clock_gettime is in librt, which we don't link by default when building the tests. H

[libcxx] r338103 - Move Filesystem namespace definition out of a clang specific ifdef block.

2018-07-26 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jul 26 23:12:46 2018 New Revision: 338103 URL: http://llvm.org/viewvc/llvm-project?rev=338103&view=rev Log: Move Filesystem namespace definition out of a clang specific ifdef block. Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL:

[libcxx] r338096 - Add libc++fs to the test deps, and not to the target 'cxx'.

2018-07-26 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jul 26 20:47:46 2018 New Revision: 338096 URL: http://llvm.org/viewvc/llvm-project?rev=338096&view=rev Log: Add libc++fs to the test deps, and not to the target 'cxx'. Modified: libcxx/trunk/lib/CMakeLists.txt libcxx/trunk/test/CMakeLists.txt Modified: libcxx/tru

[libcxx] r338095 - Attempt to unbreak *all the bots*

2018-07-26 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jul 26 20:42:58 2018 New Revision: 338095 URL: http://llvm.org/viewvc/llvm-project?rev=338095&view=rev Log: Attempt to unbreak *all the bots* The bots were failing to build the cxx_filesystem target, so the tests were failing. Though this does lead me to wonder how it was

[libcxx] r338094 - Correctly mark the Filesystem status as complete.

2018-07-26 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jul 26 20:16:02 2018 New Revision: 338094 URL: http://llvm.org/viewvc/llvm-project?rev=338094&view=rev Log: Correctly mark the Filesystem status as complete. Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.o

[libcxx] r338093 - Implement

2018-07-26 Thread Eric Fiselier via cfe-commits
Copied: libcxx/trunk/test/std/input.output/filesystems/class.path/path.nonmember/path.factory.pass.cpp (from r338006, libcxx/trunk/test/std/experimental/filesystem/class.path/path.nonmember/path.factory.pass.cpp) URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/input.output/filesy

[libcxx] r338005 - Copy LLVM CMake configuration for CMake Policy CMP0068

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 22:08:30 2018 New Revision: 338005 URL: http://llvm.org/viewvc/llvm-project?rev=338005&view=rev Log: Copy LLVM CMake configuration for CMake Policy CMP0068 Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL: http://llvm.org/viewvc

[libcxx] r338002 - Be more consistent about which bool value means an error occurred

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 21:02:06 2018 New Revision: 338002 URL: http://llvm.org/viewvc/llvm-project?rev=338002&view=rev Log: Be more consistent about which bool value means an error occurred Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified: libcxx/trunk/src/

[libcxx] r338001 - Cleanup the last_write_time internals

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 20:57:26 2018 New Revision: 338001 URL: http://llvm.org/viewvc/llvm-project?rev=338001&view=rev Log: Cleanup the last_write_time internals Modified: libcxx/trunk/src/experimental/filesystem/filesystem_common.h libcxx/trunk/src/experimental/filesystem/operat

[libcxx] r338000 - Correct comment about stat truncating st_mtimespec to seconds

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 20:42:25 2018 New Revision: 338000 URL: http://llvm.org/viewvc/llvm-project?rev=338000&view=rev Log: Correct comment about stat truncating st_mtimespec to seconds Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_wr

[libcxx] r337999 - Fix attribute placement WRT extern C

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 20:36:37 2018 New Revision: 337999 URL: http://llvm.org/viewvc/llvm-project?rev=337999&view=rev Log: Fix attribute placement WRT extern C Modified: libcxx/trunk/src/experimental/filesystem/int128_builtins.cpp Modified: libcxx/trunk/src/experimental/filesystem/

Re: [libcxx] r337960 - [libc++] Use __int128_t to represent file_time_type.

2018-07-25 Thread Eric Fiselier via cfe-commits
macOS 10.13) stores timestamps > at a 1-second granularity, and APFS (now the default) at a 1 nanosecond > granularity. > > 1-second granularity is also the norm on many of the supported filesystems > on Linux as well. > > On Wed, Jul 25, 2018 at 10:43 PM Eric Fiselie

[libcxx] r337998 - Workaround OS X 10.11 behavior where stat truncates st_mtimespec to seconds.

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 20:28:48 2018 New Revision: 337998 URL: http://llvm.org/viewvc/llvm-project?rev=337998&view=rev Log: Workaround OS X 10.11 behavior where stat truncates st_mtimespec to seconds. Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_wri

[libcxx] r337991 - Add print statements to help debugging

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 18:10:50 2018 New Revision: 337991 URL: http://llvm.org/viewvc/llvm-project?rev=337991&view=rev Log: Add print statements to help debugging Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp Modi

[libcxx] r337990 - [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined)

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 17:34:50 2018 New Revision: 337990 URL: http://llvm.org/viewvc/llvm-project?rev=337990&view=rev Log: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined) Summary: Using int128_t with UBSAN causes link errors unless compiler-rt is provi

[libcxx] r337976 - Work around GCC bug in constexpr function

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 15:21:47 2018 New Revision: 337976 URL: http://llvm.org/viewvc/llvm-project?rev=337976&view=rev Log: Work around GCC bug in constexpr function Modified: libcxx/trunk/test/libcxx/experimental/filesystem/convert_file_time.sh.cpp Modified: libcxx/trunk/test/libc

[libcxx] r337974 - Fix GCC build in C++14 w/o c++14 constexpr

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 15:07:36 2018 New Revision: 337974 URL: http://llvm.org/viewvc/llvm-project?rev=337974&view=rev Log: Fix GCC build in C++14 w/o c++14 constexpr Modified: libcxx/trunk/src/experimental/filesystem/filesystem_common.h Modified: libcxx/trunk/src/experimental/files

[libcxx] r337971 - Remove test which shouldn't have been committed

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 14:58:37 2018 New Revision: 337971 URL: http://llvm.org/viewvc/llvm-project?rev=337971&view=rev Log: Remove test which shouldn't have been committed Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.

[libcxx] r337970 - Fix failing test under C++14

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 14:53:43 2018 New Revision: 337970 URL: http://llvm.org/viewvc/llvm-project?rev=337970&view=rev Log: Fix failing test under C++14 Modified: libcxx/trunk/src/experimental/filesystem/filesystem_common.h Modified: libcxx/trunk/src/experimental/filesystem/filesyst

[libcxx] r337962 - Make compile with gcc 4.8.5

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 14:01:45 2018 New Revision: 337962 URL: http://llvm.org/viewvc/llvm-project?rev=337962&view=rev Log: Make compile with gcc 4.8.5 Patch by Victor Zverovich. This fixes an error when compiling `` with gcc 4.8.5: ``` .../libcxx/src/experimental/filesystem/filesyste

[libcxx] r337960 - [libc++] Use __int128_t to represent file_time_type.

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 13:51:49 2018 New Revision: 337960 URL: http://llvm.org/viewvc/llvm-project?rev=337960&view=rev Log: [libc++] Use __int128_t to represent file_time_type. Summary: The ``file_time_type`` time point is used to represent the write times for files. Its job is to act a

Re: r337790 - Warn if a local variable's initializer retains a pointer/reference to a

2018-07-25 Thread Eric Fiselier via cfe-commits
Nice! This found one bug in the libc++abi tests (r337906), and started diagnosing the dangling tuple reference case that libc++ worked hard to diagnose manually (r337905). /Eric On Mon, Jul 23, 2018 at 6:55 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith >

[libcxxabi] r337906 - Fix dangling reference in test

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 04:19:13 2018 New Revision: 337906 URL: http://llvm.org/viewvc/llvm-project?rev=337906&view=rev Log: Fix dangling reference in test Modified: libcxxabi/trunk/test/cxa_bad_cast.pass.cpp Modified: libcxxabi/trunk/test/cxa_bad_cast.pass.cpp URL: http://llvm.org/

[libcxx] r337905 - Fix diagnostic test to tolerate Clang diagnosing it as well.

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 04:16:39 2018 New Revision: 337905 URL: http://llvm.org/viewvc/llvm-project?rev=337905&view=rev Log: Fix diagnostic test to tolerate Clang diagnosing it as well. Tuple has tests that ensure we diagnose non-lifetime extended reference bindings inside tuples construc

[libcxx] r337900 - Fix another typo in the FileTimeType docs

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 03:22:07 2018 New Revision: 337900 URL: http://llvm.org/viewvc/llvm-project?rev=337900&view=rev Log: Fix another typo in the FileTimeType docs Modified: libcxx/trunk/docs/DesignDocs/FileTimeType.rst Modified: libcxx/trunk/docs/DesignDocs/FileTimeType.rst URL:

[libcxx] r337897 - Fix typos, spelling, and grammar in the FileTimeType design docs.

2018-07-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 25 03:17:04 2018 New Revision: 337897 URL: http://llvm.org/viewvc/llvm-project?rev=337897&view=rev Log: Fix typos, spelling, and grammar in the FileTimeType design docs. I'm sure I'll discover more mistakes as I go on... Modified: libcxx/trunk/docs/DesignDocs/Fil

[libcxx] r337888 - Fix bugs in create_directory implementation.

2018-07-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 24 21:46:32 2018 New Revision: 337888 URL: http://llvm.org/viewvc/llvm-project?rev=337888&view=rev Log: Fix bugs in create_directory implementation. Libc++ was incorrectly reporting an error when the target of create_directory already exists, but was not a directory.

[libcxx] r337886 - Fix missing includes in format_string.hpp helper

2018-07-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 24 21:21:59 2018 New Revision: 337886 URL: http://llvm.org/viewvc/llvm-project?rev=337886&view=rev Log: Fix missing includes in format_string.hpp helper Modified: libcxx/trunk/test/support/format_string.hpp Modified: libcxx/trunk/test/support/format_string.hpp UR

[libcxx] r337884 - Make explicitly require C++11.

2018-07-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 24 20:41:31 2018 New Revision: 337884 URL: http://llvm.org/viewvc/llvm-project?rev=337884&view=rev Log: Make explicitly require C++11. Previously the didn't guard its contents in any dialect. However, the implementation implicitly requires at least C++11, and the te

[libcxx] r337883 - Ensure path::iterator and PathParser share the same enumeration values.

2018-07-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 24 20:31:48 2018 New Revision: 337883 URL: http://llvm.org/viewvc/llvm-project?rev=337883&view=rev Log: Ensure path::iterator and PathParser share the same enumeration values. To avoid exposing implementation details, path::iterator and PathParser both implicitly used

[libcxx] r337880 - Add design docs for upcoming file_time_type change.

2018-07-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 24 19:53:53 2018 New Revision: 337880 URL: http://llvm.org/viewvc/llvm-project?rev=337880&view=rev Log: Add design docs for upcoming file_time_type change. In upcoming changes to filesystem I plan to change file_time_type to use __int128_t as its underlying representa

[libcxx] r337817 - Fix use of incorrect _LIBCXX macro (should be _LIBCPP).

2018-07-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 24 02:15:03 2018 New Revision: 337817 URL: http://llvm.org/viewvc/llvm-project?rev=337817&view=rev Log: Fix use of incorrect _LIBCXX macro (should be _LIBCPP). Modified: libcxx/trunk/include/future Modified: libcxx/trunk/include/future URL: http://llvm.org/viewv

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

2018-07-24 Thread Eric Fiselier via cfe-commits
; > > <<>>/projects/libcxx/test/std/experimental/filesystem/class.rec.dir.itr/rec.dir.itr.members/increment.pass.cpp > >> > >> In test_PR35078_with_symlink_file():461 Assertion TEST_CHECK(*it == > >> symFile) failed. > >> in file: > >

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

2018-07-23 Thread Eric Fiselier via cfe-commits
/std/experimental/filesystem/class.rec.dir.itr/rec.dir.itr.members/increment.pass.cpp >>>> >>>> In test_PR35078_with_symlink_file():461 Assertion TEST_CHECK(*it == >>>> symFile) failed. >>>> in file: >>>> >>>> <&

[libcxx] r337768 - Handle DT_UNKNOWN correctly during directory iteration.

2018-07-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 23 15:58:46 2018 New Revision: 337768 URL: http://llvm.org/viewvc/llvm-project?rev=337768&view=rev Log: Handle DT_UNKNOWN correctly during directory iteration. Unlike stat and lstat, where unknown really means we know it's something weird, during directory iteration D

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

2018-07-23 Thread Eric Fiselier via cfe-commits
le) failed. >>> in file: >>> >>> <<>>/projects/libcxx/test/std/experimental/filesystem/class.rec.dir.itr/rec.dir.itr.members/increment.pass.cpp >>> >>> In test_PR35078_with_symlink_file():467 Assertion TEST_REQUIRE(it != >>>

[libcxx] r337765 - Recommit "Use possibly cached directory entry values when performing recursive directory iteration."

2018-07-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 23 15:40:41 2018 New Revision: 337765 URL: http://llvm.org/viewvc/llvm-project?rev=337765&view=rev Log: Recommit "Use possibly cached directory entry values when performing recursive directory iteration." The initial patch didn't correctly handle systems when the dir

[libcxx] r337764 - Fix accidentally removed test.

2018-07-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 23 15:39:56 2018 New Revision: 337764 URL: http://llvm.org/viewvc/llvm-project?rev=337764&view=rev Log: Fix accidentally removed test. When adding the new tests for the filesystem_error::what method, I incorrectly removed a test case and replaced it with something els

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

2018-07-23 Thread Eric Fiselier via cfe-commits
8_with_symlink_file():467 Assertion TEST_REQUIRE(it != >> EndIt) failed. >> in file: >> >> <<>>/projects/libcxx/test/std/experimental/filesystem/class.rec.dir.itr/rec.dir.itr.members/increment.pass.cpp >> >> Summary for testsuite recursive_dire

[libcxx] r337749 - Revert "Use possibly cached directory entry values when performing recursive directory iteration."

2018-07-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 23 14:52:29 2018 New Revision: 337749 URL: http://llvm.org/viewvc/llvm-project?rev=337749&view=rev Log: Revert "Use possibly cached directory entry values when performing recursive directory iteration." This reverts commit 04ce4aef00d3ee508327f6cf7bf1b1d200ab6238. M

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

2018-07-23 Thread Eric Fiselier via cfe-commits
gt; > <<>>/projects/libcxx/test/std/experimental/filesystem/class.rec.dir.itr/rec.dir.itr.members/increment.pass.cpp > > Summary for testsuite recursive_directory_iterator_increment_tests: > 5 of 9 test cases passed. > 156 of 164 assertions passed. > 0 unsu

[libcxx] r337685 - Cleanup unnecessary conversions in filesystem.

2018-07-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 23 04:55:13 2018 New Revision: 337685 URL: http://llvm.org/viewvc/llvm-project?rev=337685&view=rev Log: Cleanup unnecessary conversions in filesystem. Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified: libcxx/trunk/src/experimental/filesy

[libcxx] r337684 - Cleanup name qualification in the filesystem internals.

2018-07-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 23 04:46:47 2018 New Revision: 337684 URL: http://llvm.org/viewvc/llvm-project?rev=337684&view=rev Log: Cleanup name qualification in the filesystem internals. In most cases there is no reason why the filesystem internals use the qualifier std:: or _VSTD::. This patch

[libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

2018-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 22 21:55:57 2018 New Revision: 337669 URL: http://llvm.org/viewvc/llvm-project?rev=337669&view=rev Log: Use possibly cached directory entry values when performing recursive directory iteration. Modified: libcxx/trunk/src/experimental/filesystem/directory_iterator

[libcxx] r337666 - Fix use of C++14 syntax in C++11 filesystem tests.

2018-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 22 20:41:46 2018 New Revision: 337666 URL: http://llvm.org/viewvc/llvm-project?rev=337666&view=rev Log: Fix use of C++14 syntax in C++11 filesystem tests. Modified: libcxx/trunk/test/support/format_string.hpp Modified: libcxx/trunk/test/support/format_string.hpp

[libcxx] r337665 - Work around various GCC 4.9 build errors

2018-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 22 20:06:57 2018 New Revision: 337665 URL: http://llvm.org/viewvc/llvm-project?rev=337665&view=rev Log: Work around various GCC 4.9 build errors Modified: libcxx/trunk/src/experimental/filesystem/filesystem_common.h libcxx/trunk/src/experimental/filesystem/ope

[libcxx] r337664 - Implement filesystem_error::what() and improve reporting.

2018-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 22 19:00:52 2018 New Revision: 337664 URL: http://llvm.org/viewvc/llvm-project?rev=337664&view=rev Log: Implement filesystem_error::what() and improve reporting. This patch implements the `what()` for filesystem errors. The message includes the 'what_arg', any paths t

[libcxxabi] r337662 - Add GCC 9 to XFAILs list for test

2018-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 22 14:58:46 2018 New Revision: 337662 URL: http://llvm.org/viewvc/llvm-project?rev=337662&view=rev Log: Add GCC 9 to XFAILs list for test Modified: libcxxabi/trunk/test/catch_member_function_pointer_02.pass.cpp Modified: libcxxabi/trunk/test/catch_member_function

[libcxx] r337661 - Workaround bug in GCC trunk.

2018-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 22 14:56:40 2018 New Revision: 337661 URL: http://llvm.org/viewvc/llvm-project?rev=337661&view=rev Log: Workaround bug in GCC trunk. For some reason GCC ToT is failing to deduce the auto type for a static data member from its initializer in some cases. Though I'm sur

[libcxx] r337659 - Harden copy_file even more.

2018-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 22 14:15:15 2018 New Revision: 337659 URL: http://llvm.org/viewvc/llvm-project?rev=337659&view=rev Log: Harden copy_file even more. This patch removes the O_CREAT open flag when we first attempt to open the destination file but we expect it to already exist. This the

[libcxx] r337658 - fix test failures with older clang versions

2018-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 22 13:50:16 2018 New Revision: 337658 URL: http://llvm.org/viewvc/llvm-project?rev=337658&view=rev Log: fix test failures with older clang versions Added: libcxx/trunk/test/std/experimental/filesystem/class.directory_entry/directory_entry.cons/default_const.pass.

[libcxx] r337649 - Implement a better copy_file.

2018-07-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Jul 21 19:00:53 2018 New Revision: 337649 URL: http://llvm.org/viewvc/llvm-project?rev=337649&view=rev Log: Implement a better copy_file. This patch improves both the performance, and the safety of the copy_file implementation. The performance improvements are achieved b

[libcxx] r337532 - adjust incorrect comment

2018-07-20 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 20 01:36:45 2018 New Revision: 337532 URL: http://llvm.org/viewvc/llvm-project?rev=337532&view=rev Log: adjust incorrect comment Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp UR

[libcxx] r337520 - Fix two test failures in

2018-07-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jul 19 18:51:48 2018 New Revision: 337520 URL: http://llvm.org/viewvc/llvm-project?rev=337520&view=rev Log: Fix two test failures in First, didn't correctly guard against min/max macros. This adds the proper push/pop macro guards. Second, an internal time helper had be

[libcxx] r337519 - Use _LIBCPP_UNREACHABLE to convince GCC that non-void functions actually always return

2018-07-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jul 19 18:44:33 2018 New Revision: 337519 URL: http://llvm.org/viewvc/llvm-project?rev=337519&view=rev Log: Use _LIBCPP_UNREACHABLE to convince GCC that non-void functions actually always return Modified: libcxx/trunk/include/experimental/filesystem libcxx/trunk/

[libcxx] r337517 - cleanup test assertion inside library

2018-07-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jul 19 18:25:06 2018 New Revision: 337517 URL: http://llvm.org/viewvc/llvm-project?rev=337517&view=rev Log: cleanup test assertion inside library Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified: libcxx/trunk/src/experimental/filesystem/oper

[libcxx] r337235 - Address "always inline function is not always inlinable" warning with GCC.

2018-07-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 16 22:48:48 2018 New Revision: 337235 URL: http://llvm.org/viewvc/llvm-project?rev=337235&view=rev Log: Address "always inline function is not always inlinable" warning with GCC. When an always_inline function is used prior to the functions definition, the compiler ma

[libcxx] r337205 - Fix PR38160 - init_priority attribute not supported by GCC on Apple.

2018-07-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 16 13:01:59 2018 New Revision: 337205 URL: http://llvm.org/viewvc/llvm-project?rev=337205&view=rev Log: Fix PR38160 - init_priority attribute not supported by GCC on Apple. This patch guards the use of __attribute__((init_priority(101))) within memory_resource.cpp whe

[libcxx] r336666 - Remove BUILD file from google-benchmark

2018-07-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 10 06:25:26 2018 New Revision: 33 URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev Log: Remove BUILD file from google-benchmark Removed: libcxx/trunk/utils/google-benchmark/test/BUILD Removed: libcxx/trunk/utils/google-benchmark/test/BUILD URL: h

  1   2   3   4   5   6   7   8   9   10   >