[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-09-14 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach added a comment. No real comment on the issue itself but on the example as a former Eigen maintainer (sorry for the noise if that's all obvious for you): auto round (Tensor m) { return (m + 0.5f).cast().cast(); } does not return a Tensor but an expression encoding the compu

[PATCH] D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

2023-08-14 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach accepted this revision. tellenbach added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157925/new/ https://reviews.llvm.org/D157925 __

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2020-07-03 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach added a comment. In D68076#2131108 , @hiraditya wrote: > do we have a plan to follow up on this patch? Hi! I'm currently not working on this (and LLVM in general) anymore. However, the issue seems to be still present and this patch would fix

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2019-10-10 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach added a comment. This patch would fix PR37240 but is probably not the most optimal solution. For other ideas see http://lists.llvm.org/pipermail/llvm-dev/2019-September/135433.html . I'll leave this patch open unt

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2019-09-26 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach added a comment. This would fix PR37240 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits mailing list c

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2019-09-26 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach added a comment. Please also see the ongoing discussion on the mailing list: http://lists.llvm.org/pipermail/llvm-dev/2019-September/135433.html Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2019-09-26 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach created this revision. Herald added subscribers: cfe-commits, kristof.beyls, aprantl. Herald added a project: clang. Currently the following situation can occur: During AArch64 frame lowering cfi instructions get emitted if debug information is generated but not if not. Since cfi inst