On 4/11/25 1:53 PM, Alison Schofield wrote:
> On Fri, Apr 11, 2025 at 11:47:36AM -0700, Dave Jiang wrote:
>
> big snip...
>
>> +char path[CXL_PATH_MAX];
>
> A bit of minutiae, not directly related to your patch-
>
> I see:
> ndctl keys code, (ndct
Add helper function cxl_bus_get_by_provider() in order to support unit
test that will utilize the API call.
Signed-off-by: Dave Jiang
---
v5:
- Add documentation for API. (Alison)
---
Documentation/cxl/lib/libcxl.txt | 2 ++
cxl/lib/libcxl.c | 11 +++
cxl/lib/libcxl.sym
Add a unit test to verify the features ioctl commands. Test support added
for locating a features device, retrieve and verify the supported features
commands, retrieve specific feature command data, retrieve test feature
data, and write and verify test feature data.
Signed-off-by: Dave Jiang
e major and minor of the
FWCTL character device.
Signed-off-by: Dave Jiang
---
v5:
- Add documentation. (Alison)
- Alloc path on stack. (Alison)
- Deal with out of entry and no match case. (Alison)
- Make fwctl operations part of 'struct cxl_fwctl' (Dan)
---
Documentation/cxl/lib/libc
ue all the supported ioctls to the associated
FWCTL char device to verify that all the ioctl paths are working as expected.
Kernel series:
https://lore.kernel.org/linux-cxl/20250207233914.2375110-1-dave.ji...@intel.com/T/#t
Dave Jiang (3):
cxl: Add cxl_bus_get_by_provider()
cxl: Enume
On 4/9/25 1:40 PM, Alison Schofield wrote:
> On Tue, Feb 18, 2025 at 03:59:56PM -0700, Dave Jiang wrote:
>> Add a unit test to verify the features ioctl commands. Test support added
>> for locating a features device, retrieve and verify the supported features
>> comman
On 4/9/25 1:40 PM, Alison Schofield wrote:
> On Tue, Feb 18, 2025 at 03:59:56PM -0700, Dave Jiang wrote:
>> Add a unit test to verify the features ioctl commands. Test support added
>> for locating a features device, retrieve and verify the supported features
>> comman
On 3/9/25 1:41 AM, Thomas Gleixner wrote:
> Convert the code to use the new guard(msi_descs_lock).
>
> No functional change intended.
>
> Signed-off-by: Thomas Gleixner
> Cc: Jon Mason
> Cc: Dave Jiang
> Cc: Allen Hubbe
> Cc: n...@lists.linux.dev
Acked-by: Da
slot in the for loop header. That
> keeps the comparison to a u32 as is and avoids overflow.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
> ---
> ndctl/dimm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/ndctl/dimm.c b/nd
;
> Add check for ULLONG_MAX upon return from parse_size64.
> Add check for overflow in subsequent PFN_MODE offset calculation.
>
> This issue was reported in a coverity scan.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
> ---
> ndctl/namespace.c |
hecks for both values.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
> ---
> ndctl/namespace.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/ndctl/namespace.c b/ndctl/namespace.c
> index 40bcf4ca65ac..3224c9ff 100644
> -
On 3/3/25 5:37 PM, alison.schofi...@intel.com wrote:
> From: Alison Schofield
>
> A coverity scan higlighted an overflow issue when the slot variable,
> an unsigned integer that is initialized to -1, is incremented and
> overflows.
>
> Initialize slot to 0 and move the increment statement to
e all returns through
> that path.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
> ---
> ndctl/namespace.c | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/ndctl/namespace.c b/ndctl/namespace.c
> index bb0c
l not
> exceed the maximimum value that an unsigned long long can hold.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
nit below
> ---
> ndctl/namespace.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/ndctl/namespace.
so on.
>
> So, with these changes, fix 12 of the following warnings:
>
> drivers/acpi/nfit/intel.c:692:35: warning: structure containing a flexible
> array member is not at the end of another structure
> [-Wflex-array-member-not-at-end]
>
> Signed-off-by: Gustavo A. R. S
request:
> https://github.com/pmem/ndctl/pull/268/
>
> [ alison: commit msg and log edits ]
>
> Fixes: 9873123fce03 ("cxl/list: collect and parse media_error records")
> Signed-off-by: Michal Suchanek
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Ji
ort was not reviewed at this time.
>
> [1] 91677390f9e6 ("ndctl: import cli infrastructure from perf")
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
> ---
> util/strbuf.c | 51 ---
> util/strbuf.h
On 1/23/25 9:39 AM, Murad Masimov wrote:
> Syzkaller has reported a warning in to_nfit_bus_uuid(): "only secondary
> bus families can be translated". This warning is emited if the argument
> is equal to NVDIMM_BUS_FAMILY_NFIT == 0. Function acpi_nfit_ctl() first
> verifies that a user-provided v
On 1/8/25 5:58 PM, Li Ming wrote:
> On 1/9/2025 12:46 AM, Dave Jiang wrote:
>>
>> On 12/5/24 6:10 PM, Alison Schofield wrote:
>>> On Thu, Dec 05, 2024 at 12:14:56AM +0800, Li Ming wrote:
>>>> If CONFIG_MEMORY_HOTREMOVE is disabled by kernel, memblocks will
On 12/5/24 6:10 PM, Alison Schofield wrote:
> On Thu, Dec 05, 2024 at 12:14:56AM +0800, Li Ming wrote:
>> If CONFIG_MEMORY_HOTREMOVE is disabled by kernel, memblocks will not be
>> removed, so 'dax offline-memory all' will output below error logs:
>>
>> libdaxctl: offline_one_memblock: dax0.0:
ved2 array.
>
> Reported-by: syzbot+7534f060ebda6b8b5...@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=7534f060ebda6b8b51b3
> Tested-by: syzbot+7534f060ebda6b8b5...@syzkaller.appspotmail.com
> Fixes: ebe9f6f19d80 ("acpi/nfit: Fix bus command validation")
&
ved2 array.
>
> Reported-by: syzbot+7534f060ebda6b8b5...@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=7534f060ebda6b8b51b3
> Tested-by: syzbot+7534f060ebda6b8b5...@syzkaller.appspotmail.com
> Fixes: ebe9f6f19d80 ("acpi/nfit: Fix bus command validation")
&
On 11/14/24 2:19 AM, Suraj Sonawane wrote:
> On 13/11/24 22:32, Dave Jiang wrote:
>>
>>
>> On 11/13/24 5:51 AM, Suraj Sonawane wrote:
>>> Fix an issue detected by syzbot with KASAN:
>>>
>>> BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func dr
and
> improve its readability.
>
> Signed-off-by: Yi Yang
Reviewed-by: Dave Jiang
but a few comments for future patches:
Is this v2 of the patch? Please label patch subject prefix as so.
> ---
Please include change history here from previous versions.
> drivers/nvdimm/dax_devs.c
On 11/13/24 5:51 AM, Suraj Sonawane wrote:
> Fix an issue detected by syzbot with KASAN:
>
> BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/
> core.c:416 [inline]
> BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0
> drivers/acpi/nfit/core.c:459
>
> The issue
ow/intel enable their PCI-Device with pci_enable_device().
> Thus, they need the never-managed version.
>
> Replace pci_intx() with pci_intx_unmanaged().
>
> Signed-off-by: Philipp Stanner
> Acked-by: Shyam Sundar S K #for ntb_hw_amd.c
Acked-by: Dave Jiang # for ntb_hw_g
On 11/7/24 1:58 PM, Ira Weiny wrote:
> A git tree of this series can be found here:
>
> https://github.com/weiny2/linux-kernel/tree/dcd-v4-2024-11-07
>
> This is a quick spin with minor clean ups Dave was going to apply as
> well as a couple of clean ups I had slated for after V4 landed.
On 11/4/24 7:10 PM, Ira Weiny wrote:
> DCD regions have 0 or more extents. The ability to list those and their
> properties is useful to end users.
>
> Add extent output to region queries.
>
> Signed-off-by: Ira Weiny
> ---
> Documentation/cxl/cxl-list.txt | 4 ++
> cxl/filter.h
On 11/4/24 7:10 PM, Ira Weiny wrote:
> cxl_test provides a good way to ensure quick smoke and regression
> testing. The complexity of DCD and the new sparse DAX regions required
> to use them benefits greatly with a series of smoke tests.
>
> The only part of the kernel stack which must be byp
On 11/4/24 7:10 PM, ira.we...@intel.com wrote:
> From: Navneet Singh
>
> CXL Dynamic Capacity Devices (DCDs) optionally support dynamic capacity
> with up to eight partitions (Regions) (dc0-dc7). CXL regions can now be
> spare and defined as dynamic capacity (dc).
>
> Add support for DCD dev
a new region mode enumeration and access function.
>
> To maintain compatibility with existing software the region mode values
> are defined the same as the current decoder mode. In addition
> cxl_region_get_mode() is retained.
>
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jian
t; Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
> ---
> cxl/region.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cxl/region.c b/cxl/region.c
> index
> 96aa5931d2281c7577679b7f6165218964fa0425..207cf2d003148992255c715f286bc0f38de2ca84
ount checks for pass/fail
> of the test.
>
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
> ---
> test/cxl-events.sh | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/test/cxl-events.sh b/test/cxl-events.sh
> index
On 10/30/24 7:48 AM, Jonathan Cameron wrote:
> On Tue, 29 Oct 2024 15:34:35 -0500
> Ira Weiny wrote:
>
>> A git tree of this series can be found here:
>>
>> https://github.com/weiny2/linux-kernel/tree/dcd-v4-2024-10-29
>>
>> Series info
>> ===
>>
>> This series has 4 parts:
>>
>>
: Jonathan Cameron
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
> ---
> Changes:
> [Fan: remove unwanted blank line]
> [Rafael: Split out acpi change]
> [iweiny: remove %pra use]
> [Jonathan: s/cdat/CDAT/]
> ---
> drivers/cxl/core/cdat.c | 39 +
On 9/27/24 6:41 AM, Nathan Chancellor wrote:
> On Fri, Sep 27, 2024 at 09:39:54AM +0800, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git
>> cxl/fwctl
>> head: b4f2900f53c72de8fc639b62e44763c6a9695d3b
>> commit: 5a0496c19151d83cd0d926f8a1488
amepace ==> namespace
> drivers/nvdimm/pmem.c:319: reenable ==> re-enable
>
> Signed-off-by: Shen Lichuan
Reviewed-by: Dave Jiang
> ---
> drivers/nvdimm/nd_virtio.c | 2 +-
> drivers/nvdimm/pfn_devs.c | 2 +-
> drivers/nvdimm/pmem.c | 2 +-
> 3 files changed, 3 inse
On 8/30/24 1:42 PM, Keith Busch wrote:
> From: Keith Busch
>
> bip is NULL before bio_integrity_prep().
>
> Signed-off-by: Keith Busch
Reviewed-by: Dave Jiang
> ---
> drivers/nvdimm/btt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff
On 9/3/24 7:39 AM, Li Zetao wrote:
> Since the debugfs_create_dir() never returns a null pointer, checking
> the return value for a null pointer is redundant, and using IS_ERR is
> safe enough.
>
> Signed-off-by: Li Zetao
Reviewed-by: Dave Jiang
> ---
> drivers/nvdim
On 8/22/24 7:28 PM, Ira Weiny wrote:
> Dave Jiang wrote:
>>
>>
>> On 8/16/24 7:44 AM, ira.we...@intel.com wrote:
>>> From: Navneet Singh
>>>
>>> To properly configure CXL regions on Dynamic Capacity Devices (DCD),
>>> user space wil
ates to true, since 0 is less
> than 9. The result is that ndctl builds for Fedora lack support for
> libtraceevent and libtracefs. Correct the expression.
>
> Reposted here from github pull request:
> https://github.com/pmem/ndctl/pull/266/
>
> Signed-off-by: Jerry James
Revie
e concurrency required when user space is allowed to
> control DCD extents
>
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
>
> ---
> Changes:
> [iweiny: rebase]
> ---
> tools/testing/cxl/test/mem.c | 278
> ++-
> 1
ed-off-by: Navneet Singh
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
small nit below
>
> ---
> Changes:
> [Alison: Update commit message]
> ---
> drivers/cxl/core/mbox.c | 4 +++
> drivers/cxl/core/trace.h | 65
>
On 8/20/24 10:22 AM, Philip Chen wrote:
> If a pmem device is in a bad status, the driver side could wait for
> host ack forever in virtio_pmem_flush(), causing the system to hang.
>
> So add a status check in the beginning of virtio_pmem_flush() to return
> early if the device is not activated
minor numbers
> that large, but let's fix it.
>
> Signed-off-by: Jeff Moyer
Reviewed-by: Dave Jiang
> ---
> ndctl/lib/libndctl.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
> index dd
On 8/20/24 11:26 AM, jmo...@redhat.com wrote:
> From: Jeff Moyer
>
> Static analysis points out that fd is leaked in some cases. The
> change to the while loop is optional. I only did that to make the
> code consistent.
>
> Signed-off-by: Jeff Moyer
Re
On 8/16/24 7:44 AM, ira.we...@intel.com wrote:
> From: Navneet Singh
>
> Dynamic capacity device extents may be left in an accepted state on a
> device due to an unexpected host crash. In this case it is expected
> that the creation of a new region on top of a DC partition can read
> those ex
On 8/16/24 7:44 AM, ira.we...@intel.com wrote:
> From: Navneet Singh
>
> DAX regions which map dynamic capacity partitions require that memory be
> allowed to come and go. Recall sparse regions were created for this
> purpose. Now that extents can be realized within DAX regions the DAX
> reg
e tree
> which is less complicated for finding space.
>
> In preparation for this change, factor out the dev_dax_resize logic.
> For static regions use dax_region->res as the parent to find space for
> the dax ranges. Future patches will use the same algorithm with
> individual exte
On 8/16/24 7:44 AM, ira.we...@intel.com wrote:
> From: Navneet Singh
>
> Extent information can be helpful to the user to coordinate memory usage
> with the external orchestrator and FM.
>
> Expose the details of region extents by creating the following
> sysfs entries.
>
> /sys/bus/
Process DCD events and create region devices.
>
> Signed-off-by: Navneet Singh
> Co-developed-by: Ira Weiny
> Signed-off-by: Ira Weiny
A few nits below, but in general
Reviewed-by: Dave Jiang
>
> ---
> Changes:
> [iweiny: combine this with the extent surface patches to be
addition, well behaved
> extents should be contained within an endpoint decoder.
>
> Return the endpoint decoder found to be used in subsequent DCD code.
>
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
> ---
> drivers/cxl/core/core.h | 6 --
> drivers/cxl/c
by the FW if FW first
> has been selected by the BIOS.
>
> Signed-off-by: Navneet Singh
> Co-developed-by: Ira Weiny
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
>
> ---
> Changes:
> [iweiny: update commit message]
> [iweiny: rebase to upstream irq code]
&g
onfiguration.
>
> Split cxl_event_config_msgnums() from irq setup in preparation for
> separate DCD interrupts configuration.
>
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
> ---
> drivers/cxl/pci.c | 24
> 1 file changed, 12 insertions(+), 12 de
ax devices. There is no
> known use case for range mapping on sparse regions. Avoid the
> complication by preventing range mapping of dax devices on sparse
> regions.
>
> Interleaving is deferred for now. Add checks.
>
> Signed-off-by: Navneet Singh
> Co-d
ion_store() and create_ram_region_store() to use
> a single common function to be used in subsequent DC code.
>
> Suggested-by: Fan Ni
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
> ---
> drivers/cxl/core/region.c | 28 +++-
> 1 file changed, 11 inse
On 8/16/24 7:44 AM, ira.we...@intel.com wrote:
> From: Navneet Singh
>
> To properly configure CXL regions on Dynamic Capacity Devices (DCD),
> user space will need to know the details of the DC partitions available.
>
> Expose dynamic capacity capabilities through sysfs.
>
> Signed-off-by:
> Signed-off-by: Navneet Singh
> Co-developed-by: Ira Weiny
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
>
> ---
> Changes:
> [Fan: change mode range logic]
> [Fan: use !resource_size()]
> [djiang: use the static mode name string array in mode_store()]
>
On 8/16/24 7:44 AM, ira.we...@intel.com wrote:
> From: Navneet Singh
>
> To support Dynamic Capacity Devices (DCD) endpoint decoders will need to
> map DC partitions (regions). In addition to assigning the size of the
> DC partition, the decoder must assign any skip value from the previous
>
-by: Navneet Singh
> Co-developed-by: Ira Weiny
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
>
> ---
> Changes:
> [iweiny: keep tags on simple patch]
> [Fan: s/partitions/partition/]
> [djiang: New wording for the commit message]
> [iweiny: reword commit mess
just the code to process these modes
> independently.
>
> There is no equal to decoder mode dead in region modes. Avoid
> constructing regions with decoders which have been flagged as dead.
>
> Suggested-by: Jonathan Cameron
> Signed-off-by: Navneet Singh
> Co-developed-by: Ir
On 8/16/24 7:44 AM, ira.we...@intel.com wrote:
> From: Navneet Singh
>
> Devices which optionally support Dynamic Capacity (DC) are configured
> via mailbox commands. CXL 3.1 requires the host to issue the Get DC
> Configuration command in order to properly configure DCDs. Without the
> Get
Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
>
> ---
> Changes:
> [iweiny: move to start of series]
> ---
> drivers/dax/dax-private.h | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dax/dax-private.h b/drivers/dax/dax-private.
e the dax flag to queue_limits")
> Signed-off-by: Zhihao Cheng
Reviewed-by: Dave Jiang
> ---
> drivers/nvdimm/pmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 1ae8b2351654..210fb77f5
ar functions.
> of_(find|get)_property() leak the DT struct property and data pointers
> which is a problem for dynamically allocated nodes which may be freed.
>
> Signed-off-by: Rob Herring (Arm)
Reviewed-by: Dave Jiang
> ---
> drivers/nvdimm/of_pmem.c | 2 +-
> drivers/n
ew json member to the default memdev listing.
>
> This means users of the -F option will get the same info twice if
> GET_FW_INFO is supported.
>
> [
> {
> "memdev":"mem9",
> "pmem_size":268435456,
> "serial":0,
> "ho
> object and it allows the parse_event function to access any
> members of the event_ctx structure.
>
> This is in preparation for adding a private parser requiring more
> context for cxl_poison events.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
> ---
>
ove them to the ndctl/util/ where other generic helpers reside.
> Replace cxl-ish naming with generic names and update the single
> user, cxl/monitor.c, to match.
>
> This move is in preparation for extending the helpers in support
> of cxl_poison trace events.
>
> Signed-o
On 7/1/24 7:12 PM, Shiyang Ruan wrote:
>
>
> 在 2024/6/25 21:56, Shiyang Ruan 写道:
>>
>>
>> 在 2024/6/22 1:51, Dan Williams 写道:
>>> Shiyang Ruan wrote:
Background:
Since CXL device is a memory device, while CPU consumes a poison page of
CXL device, it always triggers a MCE by inter
tel.com/content/www/us/en/content-details/643805/cxl-memory-device-sw-guide.html
>
> Signed-off-by: Alison Schofield
Looks ok to me. This is a direct copy of the kernel translation code? Is the
intention to keep them in sync?
Reviewed-by: Dave Jiang
> ---
>
> More sample data
On 6/19/24 2:24 AM, Shiyang Ruan wrote:
>
>
> 在 2024/6/19 7:35, Dave Jiang 写道:
>>
>>
>> On 6/18/24 9:53 AM, Shiyang Ruan wrote:
>>> Background:
>>> Since CXL device is a memory device, while CPU consumes a poison page of
>>> CXL device, it
On 6/18/24 9:53 AM, Shiyang Ruan wrote:
> Background:
> Since CXL device is a memory device, while CPU consumes a poison page of
> CXL device, it always triggers a MCE by interrupt (INT18), no matter
> which-First path is configured. This is the first report. Then
> currently, in FW-First p
On 6/3/24 8:16 PM, Li Zhijian wrote:
> Don't allocate devs again when it's valid pointer which has pionted to
> the memory allocated above with size (count + 2 * sizeof(dev)).
>
> A kmemleak reports:
> unreferenced object 0x88800dda1980 (size 16):
> comm "kworker/u10:5", pid 69, jiffies 4
ON() in drivers/nvdimm/nd_btt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_e820.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/of_pmem.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_virtio.o
>
> Signed-off-by:
f-by: Erick Archer
Reviewed-by: Dave Jiang
> ---
> drivers/nvdimm/btt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index 1e5aedaf8c7b..b25df8fa8e8e 100644
> --- a/drivers/nvdimm/btt.c
> +++
On 6/3/24 6:30 AM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/acpi/nfit/nfit.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson
On 5/30/24 11:29 PM, Li Zhijian wrote:
> RECONFIG_OPTIONS and ZONE_OPTIONS are not implemented for create-device
> and they will be ignored by create-device. Remove them so that the usage
> message is identical to the manual.
>
> Signed-off-by: Li Zhijian
Reviewed-by: Dave Ji
"target_node":1,
> "align":2097152,
> "mode":"devdax"
> }
> ]
> created 1 device
>
> where above user would want to specify '-r region0'.
>
> Check extra parameters starting from index 0 to ensure no extra paramet
Re: Lockdep annotation introduced warn in VMD driver
>>>
>>> On Tue, 28 May 2024, Nirmal Patel wrote:
>>>> On Tue, 28 May 2024 15:36:54 +0300
>>>> Imre Deak wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> commit
On 5/28/24 5:36 AM, Imre Deak wrote:
> Hi,
>
> commit 7e89efc6e9e402839643cb297bab14055c547f07
> Author: Dave Jiang
> Date: Thu May 2 09:57:31 2024 -0700
>
> PCI: Lock upstream bridge for pci_reset_function()
>
> introduced the WARN below in the VMD drive
ptions,
> dictionaries and lists thereof.'}
>
> Fix this by explicit string concatenation for building paths for the
> version script, whence the warnings originated.
>
> Signed-off-by: Dan Williams
> Signed-off-by: Vishal Verma
Thanks for fixing this!
Reviewed-by: Da
On 4/17/24 12:50 AM, Shiyang Ruan wrote:
> Currently driver only traces cxl events, poison creation (for both vmem
> and pmem type) on cxl memdev is silent. OS needs to be notified then it
> could handle poison pages in time. Per CXL spec, the device error event
> could be signaled through FW-
ning: Value stored to 'rc' is never
> read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King
Reviewed-by: Dave Jiang
> ---
> drivers/dax/bus.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index 797e
ed status instead of returning the status of the last
> device processed.
>
> Cc: Dan Williams
> Cc: Alison Schofield
> Signed-off-by: Vishal Verma
Reviewed-by: Dave Jiang
> ---
> daxctl/device.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> dif
an EBUSY.
>
> Cc: Dan Williams
> Cc: Alison Schofield
> Reported-by: Ira Weiny
> Reported-by: Dave Jiang
> Signed-off-by: Vishal Verma
Reviewed-by: Dave Jiang
> ---
> daxctl/device.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/daxctl/devic
vers/nvdimm/of_pmem.c | 6 ++
> 2 files changed, 4 insertions(+), 7 deletions(-)
>
> base-commit: 6ebf211bb11dfc004a2ff73a9de5386fa309c430
Reviewed-by: Dave Jiang
for the series
in the
> trace event.
>
> Add a test case that triggers these events with DPAs that map
> into a region. Verify the region is included in the trace event.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
> ---
> test/cxl-events.sh | 24 ++
converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König
Reviewed-by: Dave Jiang
> ---
> tools/testing/nvdimm/test/ndt
On 3/27/24 5:41 AM, Krzysztof Kozlowski wrote:
> virtio core already sets the .owner, so driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Dave Jiang
>
> ---
>
> Depends on the first patch.
> ---
> drivers/nvdimm/virtio_pmem.c | 1 -
&g
On 3/27/24 5:41 AM, Krzysztof Kozlowski wrote:
> virtio core already sets the .owner, so driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Dave Jiang
>
> ---
>
> Depends on the first patch.
> ---
> drivers/nvdimm/virtio_pmem.c | 1 -
&g
On 3/25/24 12:09 AM, Damien Le Moal wrote:
> Use the macro PCI_IRQ_INTX instead of the deprecated PCI_IRQ_LEGACY
> macro.
>
> Signed-off-by: Damien Le Moal
Reviewed-by: Dave Jiang
> ---
> drivers/ntb/hw/idt/ntb_hw_idt.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On 3/18/24 5:38 PM, Dan Williams wrote:
> Jonathan Cameron wrote:
>> On Mon, 18 Mar 2024 10:29:28 +0800
>> Yuquan Wang wrote:
>>
>>> The dev_dbg info for Clear Event Records mailbox command would report
>>> the handle of the next record to clear not the current one.
>>>
>>> This was because the
Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
> ---
> test/cxl-poison.sh | 137 +
> test/meson.build | 2 +
> 2 files changed, 139 insertions(+)
> create mode 100644 test/cxl-poison.sh
>
> diff --git a/test/cxl-pois
This option can apply to
> memdevs or regions.
>
> Include media-errors in the -vvv verbose option.
>
> Example usage in the Documentation/cxl/cxl-list.txt update.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
> ---
> Documentation/cxl/cxl-list.txt | 6
ed
> cxl_poison events into a json representation.
>
> Use the event_trace private parsing option to customize the json
> representation based on cxl-list calling options and event field
> settings.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
Minor
so return
> the 'type'_MAX of the type when the field is
>
> Since this is in preparation for adding a cxl_poison private parser
> for 'cxl list --media-errors' support those specific required
> types: u8, u32, u64.
>
> Signed-off-by: Alison Schofield
Hi Linus, please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
tags/libnvdimm-for-6.9
... to get updates to the nvdimm tree. They are a number of updates to
interfaces used by nvdimm/dax and a documentation fix.
Doc fixes:
ACPI_NFIT Kconfig documetation f
On 2/29/24 6:31 PM, alison.schofi...@intel.com wrote:
> From: Alison Schofield
>
> Media_error records are logged as events in the kernel tracing
> subsystem. To prepare the media_error records for cxl list, enable
> tracing, trigger the poison list read, and parse the generated
> cxl_poison e
> Since this is in preparation for adding a cxl_poison private parser
> for 'cxl list --media-errors' support, add those specific required
> types: u8, u32, u64, char*
>
> Signed-off-by: Alison Schofield
Reviewed-by: Dave Jiang
> ---
> cxl/event_trace.c | 75 +
Add tests in cxl-qos-class.sh to verify qos_class are set with the fake
qos_class create by the kernel. Root decoders should have qos_class
attribute set. Memory devices should have ram_qos_class or pmem_qos_class
set depending on which partitions are valid.
Signed-off-by: Dave Jiang
---
test
1 - 100 of 1648 matches
Mail list logo
