Hey,
I tested this on an intel macbook, virsh capabilities shows 'hvf' for
the x86_64 qemu binary, I started a f35 guest, -accel hvf is present
on the command line, and the VM is a lot faster than without hvf.
Feel free to add my Tested-by to the series:
Tested-by: Christophe Fergeau
Hey,
yup fine with me too.
Christophe
On Thu, Jun 13, 2019 at 03:40:17AM -0400, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > Fine with me.
> >
>
> This is also related to
> https://gitlab.freedesktop.org/spice/spice/merge_requests/2,
> I talked with Christophe and he agreed would be sensible to
On Fri, Jun 07, 2019 at 10:04:19AM -0300, Eduardo Lima (Etrunko) wrote:
> On 6/6/19 1:22 PM, Christophe Fergeau wrote:
> > Hey,
> >
> > I'm not really comfortable with that patch, which ignores some errors,
> > and adds some code not to crash when we do that, in
Hey,
I'm not really comfortable with that patch, which ignores some errors,
and adds some code not to crash when we do that, in the hope that the
end result will make sense. I'm under the impression that if the oVirt
instance does not have the permissions issues that you mention, but if
instead we
Hey,
On Tue, Apr 23, 2019 at 09:34:10AM +0200, Fabiano Fidêncio wrote:
> Altough there's no issue on using "=" with the test, let's standardize
> on a single way to compare values, using "==".
'man test' only lists '=', not '==', so I'd go with a single equal sign,
not 2.
Christophe
signature.
On Mon, Apr 15, 2019 at 03:42:05PM +0300, Yuri Benditovich wrote:
> IIUC, what you call 'simpler' is:
> - making unneeded changes in several files (instead of one)
> - in the next patch remove these changes completely
>
> Did I miss something?
Ah I did not look at the next patches :) Since you in
On Thu, Apr 11, 2019 at 12:37:17PM +, Victor Toso wrote:
> Hi,
>
> On Thu, Apr 11, 2019 at 02:57:21PM +0300, Yuri Benditovich wrote:
> > On Thu, Apr 11, 2019 at 12:35 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Wed, Apr 10, 2019 at 10:31:37PM +0300, Yuri Benditovich wrote:
> > > > li
Acked-by: Christophe Fergeau
On Mon, Apr 15, 2019 at 12:56:49PM +0200, Fabiano Fidêncio wrote:
> The typo was introduced as part of b6f5ea9e6da.
>
> Signed-off-by: Fabiano Fidêncio
> ---
> data/install-script/centos.org/centos-kickstart-desktop.xml.in | 2 +-
> data/install
default:
| ^~~
Signed-off-by: Christophe Fergeau
---
Maybe a bit too much for a single commit, I can split :)
common/log.h| 8 ++--
common/macros.h | 8
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/common/log.h b/common/log.h
index 7
On Wed, Mar 27, 2019 at 04:24:02AM -0400, Frediano Ziglio wrote:
> ping
Acked-by: Christophe Fergeau
though imo this should be reflected in version numbering ;)
>
> > >
> > > This is breaking spice-protocol API even if this should not impact
> > > current c
On Tue, Mar 12, 2019 at 05:58:40AM -0400, Frediano Ziglio wrote:
> ping
I guess I would reword this as "char-device: Don't use RedClient API"
RedCharDevice only use red_client_get_server() once, we can store a
Reds* in RedCharDeviceClient instead. This will make it possible to turn
the RedClient r
Hey,
Your VM configuration does not seem to have a spicevmc channel device,
so I assume spice-vdagent is not running in the guest? This is required
for proper mouse behaviour in multiscreen setups.
Christophe
On Thu, Mar 28, 2019 at 10:59:16AM +0100, Mathias Egekvist wrote:
> Hi Spice Developer(
On Thu, Mar 28, 2019 at 10:27:46AM -0400, Frediano Ziglio wrote:
> > On Thu, Mar 28, 2019 at 04:25:31AM -0400, Frediano Ziglio wrote:
> > > >
> > > > On Mon, Mar 11, 2019 at 02:03:33PM +, Frediano Ziglio wrote:
> > > > > Signed-off-by: Frediano Ziglio
> > > > > ---
> > > > > docs/spice_threa
For the series,
Acked-by: Christophe Fergeau
On Fri, Mar 29, 2019 at 12:29:58PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/server/red-channel.c b/server/red
Hey,
On Wed, Mar 27, 2019 at 01:32:44PM +0100, Ján Tomko wrote:
> Please use --cover-letter for series with two or more patches for neater
> alignment of e-mails.
>
> On Wed, Mar 27, 2019 at 12:21:24PM +0100, Christophe Fergeau wrote:
> > This also adjusts the argument na
Signed-off-by: Christophe Fergeau
---
common/verify.h | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/common/verify.h b/common/verify.h
index 267de29..ecd8cdb 100644
--- a/common/verify.h
+++ b/common/verify.h
@@ -1,6 +1,6 @@
/* Compile-time assert
On Fri, Mar 29, 2019 at 06:44:49AM -0400, Frediano Ziglio wrote:
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> > common/verify.h | 24 ++--
> > 1 file changed, 14 insertions(+), 10 deletions(-)
> >
> > diff --git a/common/ve
On Fri, Mar 29, 2019 at 06:51:54AM -0400, Frediano Ziglio wrote:
> >
> > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
> > will never return.
> >
> > Signed-off-by: Christophe Fergeau
>
> I prefer the "for" way. But by th
On Fri, Mar 29, 2019 at 07:18:35AM -0400, Frediano Ziglio wrote:
> > On Fri, Mar 29, 2019 at 06:57:59AM -0400, Frediano Ziglio wrote:
> > > > On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote:
> > > > > Without the added abort(), it canno
They were suggested by gcc when using -Wsuggest-attribute=format
Signed-off-by: Christophe Fergeau
---
common/log.c | 1 +
tests/test-logging.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/common/log.c b/common/log.c
index b73da71..ce162a1 100644
--- a/common/log.c
+++ b/common
Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
will never return.
Signed-off-by: Christophe Fergeau
---
common/log.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/common/log.h b/common/log.h
index 7c67e7a..1482358 100644
--- a/common/log.h
+++ b/common/log.h
test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
prevent multiple #include for the same header.
Signed-off-by: Christophe Fergeau
---
tests/test-marshallers.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/test-marshallers.h b/tests/test
encoder->type is only going to be set by lz_set_sizes() after the
error() call. We can use 'type' directly which is what encoder->type is
going to be set to.
Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
---
common/lz.c | 2 +-
1 file changed, 1 insertion(+), 1 d
This fixes a warning about missing prototype for backtrace()
Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
---
common/backtrace.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/backtrace.c b/common/backtrace.c
index c4edde1..ff72d1b 100644
--- a/common/backtrace.c
QUIC_VERSION_MINOR is never used.. Set QUIC_VERSION_MINOR to the same
version as QUIC_VERSION_MAJOR to avoid breaking backwards compatibility,
and fix the QUIC_VERSION macro.
Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
---
common/quic.c | 4 ++--
1 file changed, 2 insertions
canvas_base.c is #included by spice-common users. They currently don't
enable this warning, but if/when they do, we don't want code from
spice-common to trigger it.
Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
---
common/canvas_base.c | 8
1 file changed, 4
Signed-off-by: Christophe Fergeau
---
common/verify.h | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/common/verify.h b/common/verify.h
index 267de29..3f3dece 100644
--- a/common/verify.h
+++ b/common/verify.h
@@ -1,10 +1,10 @@
/* Compile-time
On Thu, Mar 28, 2019 at 01:54:01PM -0400, Frediano Ziglio wrote:
> >
> > test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
> > prevent multiple #include for the same header.
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> >
On Thu, Mar 28, 2019 at 01:56:06PM -0400, Frediano Ziglio wrote:
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> > common/verify.h | 24 +++-
> > 1 file changed, 15 insertions(+), 9 deletions(-)
> >
> > diff --git a/common/ve
On Thu, Mar 28, 2019 at 02:02:58PM -0400, Frediano Ziglio wrote:
> >
> > The for(;;) hack was taken from glib's logging macros.
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> > common/log.h | 8
> > 1 file changed, 8 insertions(+)
&g
This fixes a warning about missing prototype for backtrace()
Signed-off-by: Christophe Fergeau
---
common/backtrace.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/backtrace.c b/common/backtrace.c
index c4edde1..ff72d1b 100644
--- a/common/backtrace.c
+++ b/common/backtrace.c
test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
prevent multiple #include for the same header.
Signed-off-by: Christophe Fergeau
---
tests/test-marshallers.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-marshallers.h b/tests/test-marshallers.h
index
canvas_base.c is #included by spice-common users. They currently don't
enable this warning, but if/when they do, we don't want code from
spice-common to trigger it.
Signed-off-by: Christophe Fergeau
---
common/canvas_base.c | 8
1 file changed, 4 insertions(+), 4 deletion
The for(;;) hack was taken from glib's logging macros.
Signed-off-by: Christophe Fergeau
---
common/log.h | 8
1 file changed, 8 insertions(+)
diff --git a/common/log.h b/common/log.h
index 7c67e7a..b397306 100644
--- a/common/log.h
+++ b/common/log.h
@@ -20,6 +20,7 @@
#in
Hey,
This is the first set of hopefully more patches, long story short, I
wanted to add manywarnings.m4 to spice-common, but its compilation is
not fully clean at the moment. Here are patches for some of the warnings
I got when trying to add support for it.
Christophe
encoder->type is only going to be set by lz_set_sizes() after the
error() call. We can use 'type' directly which is what encoder->type is
going to be set to.
Signed-off-by: Christophe Fergeau
---
common/lz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
QUIC_VERSION_MINOR is never used.. Set QUIC_VERSION_MINOR to the same
version as QUIC_VERSION_MAJOR to avoid breaking backwards compatibility,
and fix the QUIC_VERSION macro.
Signed-off-by: Christophe Fergeau
---
common/quic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Signed-off-by: Christophe Fergeau
---
common/verify.h | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/common/verify.h b/common/verify.h
index 267de29..b2e5f64 100644
--- a/common/verify.h
+++ b/common/verify.h
@@ -1,19 +1,19 @@
/* Compile-time
They were suggested by gcc when using -Wsuggest-attribute=format
Signed-off-by: Christophe Fergeau
---
common/log.c | 13 +++--
tests/test-logging.c | 1 +
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/common/log.c b/common/log.c
index b73da71..7cb3e36 100644
On Thu, Mar 28, 2019 at 04:25:31AM -0400, Frediano Ziglio wrote:
> >
> > On Mon, Mar 11, 2019 at 02:03:33PM +, Frediano Ziglio wrote:
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > docs/spice_threading_model.txt | 8
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --gi
Hey,
On Wed, Mar 27, 2019 at 10:48:45AM +0200, Yuri Benditovich wrote:
> On Tue, Mar 26, 2019 at 3:11 PM Christophe Fergeau
> wrote:
> >
> > On Mon, Mar 25, 2019 at 08:03:05PM +0200, Yuri Benditovich wrote:
> > > Yes, it looks like this finally does the same thing.
This also adjusts the argument name which should be 'isListen' in both
cases rather than 'listen'.
Signed-off-by: Christophe Fergeau
---
Changes since v1:
- really fix 'boolen' typo
src/qemu/qemu_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 delet
qcow
luks
This also matches what virStorageEncryptionParseNode() is doing.
Signed-off-by: Christophe Fergeau
---
docs/formatdomain.html.in | 2 +-
docs/formatstorage.html.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatd
On Wed, Mar 27, 2019 at 12:13:41PM +0100, Pino Toscano wrote:
> On Wednesday, 27 March 2019 12:00:21 CET Christophe Fergeau wrote:
> > This also adjusts the argument name which should be 'isListen' in both
> > cases rather than 'listen'.
> >
> > Sign
qcow
luks
This also matches what virStorageEncryptionParseNode() is doing.
Signed-off-by: Christophe Fergeau
---
docs/formatdomain.html.in | 2 +-
docs/formatstorage.html.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatd
This also adjusts the argument name which should be 'isListen' in both
cases rather than 'listen'.
Signed-off-by: Christophe Fergeau
---
src/qemu/qemu_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/
On Mon, Mar 25, 2019 at 08:03:05PM +0200, Yuri Benditovich wrote:
> Yes, it looks like this finally does the same thing.
> From my personal point of view, this is less obvious than previous
> code, so I would add 2 comments:
> that we unreference the device from the new list
> that we add referenc
On Thu, Mar 21, 2019 at 05:16:03PM +0200, Yuri Benditovich wrote:
> > > @@ -412,10 +428,17 @@ static void notify_dev_state_change(GUdevClient
> > > *self,
> > > GList *dev;
> > >
> > > for (dev = g_list_first(old_list); dev != NULL; dev =
> > > g_list_next(dev)) {
> > > -if (g_l
commit makes sure that we always keep the older
instance in GUdevClient::udev_list.
At the moment, this should not be making any difference, but will make
things more consistent later on.
Based on a patch from Yuri Benditovich.
Signed-off-by: Christophe Fergeau
---
Code is a bit longer this way
From: Yuri Benditovich
Change internal device list to maintain libusb devices
instead of GUdevDevice objects. Create temporary
GUdevDevice object only for indication to usb-dev-manager.
Signed-off-by: Yuri Benditovich
Acked-by: Christophe Fergeau
---
Changes since version on the list
On Thu, Mar 21, 2019 at 02:15:41PM +0100, Christophe Fergeau wrote:
> Hey,
>
> Overall series looks good to me, you seem to have ignored most of the
> suggestions to change the commit logs/comments, I dunno if that's
> intentional?
Actually, while doing the review, I adju
On Tue, Mar 19, 2019 at 07:56:05AM +0200, Yuri Benditovich wrote:
> Change internal device list to maintain libusb devices
> instead of GUdevDevice objects. Create temporary
> GUdevDevice object only for indication to usb-dev-manager.
>
> Signed-off-by: Yuri Benditovich
> ---
> src/win-usb-dev.c
Hey,
Overall series looks good to me, you seem to have ignored most of the
suggestions to change the commit logs/comments, I dunno if that's
intentional? Still a few comments on "win-usb-dev: maintain list of
libusb devices"
So apart from this patch,
Acked-by: Christophe Ferge
On Wed, Mar 20, 2019 at 03:57:46PM +, Frediano Ziglio wrote:
> From: Christophe Fergeau
>
> If worker->qxl->id is bigger than 0x7ff (in other words, it's a
> negative signed int) then
> printf(worker_str, "display[%d]", worker->qxl->id);
>
by: Frediano Ziglio
> > > ---
> > > server/red-worker.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > This was signaled by Christophe Fergeau
> > >
> > > diff --git a/server/red-worker.c b/server/red
> This was signaled by Christophe Fergeau
>
> diff --git a/server/red-worker.c b/server/red-worker.c
> index 8051d1e4..a25a0cd8 100644
> --- a/server/red-worker.c
> +++ b/server/red-worker.c
> @@ -1291,7 +1291,7 @@ RedWorker* red_worker_new(QXLInstance *qxl,
> worke
On Tue, Mar 19, 2019 at 01:01:54PM +, Frediano Ziglio wrote:
> We should not reuse the same interface twice as doing so will
> cause dandling pointers.
'dangling'
Acked-by: Christophe Fergeau
> Unregister it at every iteration.
>
> Signed-off-by: Frediano Zigl
On Tue, Mar 19, 2019 at 01:01:55PM +, Frediano Ziglio wrote:
> To avoid possibly regression check it only if extra checks are
"To avoid possible/potential regressions, check it .."
> enabled.
> This allows to check previous "Move channel registration to constructed
> vfunc" commit.
>
> Signe
Ping? Or should I just go with one of the earlier versions?
On Fri, Feb 22, 2019 at 11:40:32AM +0100, Christophe Fergeau wrote:
> spice-server does not deal properly with multiple smartcard readers,
> only the first one will be working. Add a warning when this happens to
> make it
On Fri, Feb 22, 2019 at 05:42:22PM +, Victor Toso wrote:
> From: Victor Toso
>
> We already require libusb 1.0.16 or above since 8269a5be62f4ce1
> (build-sys: drop support for libusb < 1.0.16)
>
> Signed-off-by: Victor Toso
> ---
> src/win-usb-dev.c | 4 +---
> 1 file changed, 1 insertion(
On Mon, Mar 11, 2019 at 12:42:10PM -0400, Frediano Ziglio wrote:
> >
> > Series looks good to me,
> >
> > Reviewed-by: Christophe Fergeau
> >
>
> Why not ack? Not good enough? Not tested? Missing something?
libvirt/qemu use of Reviewed-by/Acked-by confuses
This is breaking spice-protocol API even if this should not impact
current code. Do we want to advertise this somehow? Switch to
spice-protocol 0.14.x?
On Fri, Feb 22, 2019 at 12:16:52PM +, Frediano Ziglio wrote:
> spice.proto was updated to remove really old definitions,
> update enums.h acco
On Mon, Mar 11, 2019 at 02:03:33PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> docs/spice_threading_model.txt | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/docs/spice_threading_model.txt b/docs/spice_threading_model.txt
> index 9351141c8..25a3a030c 1
On Mon, Mar 11, 2019 at 02:03:32PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> docs/spice_threading_model.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/spice_threading_model.txt b/docs/spice_threading_model.txt
> index df4922168..935
For the series:
Acked-by: Christophe Fergeau
On Fri, Mar 08, 2019 at 12:25:48PM +, Frediano Ziglio wrote:
> This brings in the following changes:
>
> Frediano Ziglio (11):
> codegen: Document ptr_array attribute
> codegen: Use a better type for pointer conve
Acked-by: Christophe Fergeau
On Mon, Mar 18, 2019 at 10:57:41AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> AUTHORS | 1 +
> 1 file changed, 1 insertion(+)
>
> This fixed "make syntax-check"
>
> diff --git a/AUTHORS b/AUTHORS
On Wed, Mar 13, 2019 at 08:14:14PM +0200, Yuri Benditovich wrote:
> On Tue, Mar 12, 2019 at 4:02 PM Christophe Fergeau
> wrote:
> >
> > On Sun, Mar 10, 2019 at 04:46:07PM +0200, Yuri Benditovich wrote:
> > > Changing signal definition from (boxed-boxed) to (pointer,i
> -#ifdef G_OS_WIN32
> -guint8 state;
Nit: This removal is not related to this commit, not a big problem to
keep it in this commit if you don't want to split this..
Acked-by: Christophe Fergeau
> -#else
> libusb_device *libdev;
> -#endif
> gin
On Wed, Mar 13, 2019 at 10:38:09AM +0200, Yuri Benditovich wrote:
> On Tue, Mar 12, 2019 at 7:31 PM Christophe Fergeau
> wrote:
> >
> > On Sun, Mar 10, 2019 at 04:46:11PM +0200, Yuri Benditovich wrote:
> > > Unify SpiceUsbDeviceInfo for Linux and Windows by using
>
dr/vid/pid, at least on linux (in short, this indeed looks like
something which could happen).
Acked-by: Christophe Fergeau
> Make device comparison more strict: check not only bus:addr,
> but also vid:pid.
>
> Signed-off-by: Yuri Benditovich
> ---
> src/win-usb-dev.c | 9 +
Acked-by: Christophe Fergeau
On Wed, Mar 13, 2019 at 12:20:22PM +, Frediano Ziglio wrote:
> Check that attempting to quote an invalid character result in
> a error.
>
> Signed-off-by: Frediano Ziglio
> ---
> tests/test-ssl-verify.c | 1 +
> 1 file changed, 1 inserti
Acked-by: Christophe Fergeau
On Tue, Mar 12, 2019 at 09:32:23PM +, Frediano Ziglio wrote:
> The file is already distributed as included in the source list.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/Makefile.am | 1 -
> 1 file changed, 1 deletion(-)
>
On Wed, Mar 13, 2019 at 09:36:06AM +0200, Yuri Benditovich wrote:
> On Tue, Mar 12, 2019 at 7:22 PM Christophe Fergeau
> wrote:
> >
> > On Sun, Mar 10, 2019 at 04:46:09PM +0200, Yuri Benditovich wrote:
> > > Change internal device list to maintain libusb devices
&
On Wed, Mar 13, 2019 at 09:49:19AM +0200, Yuri Benditovich wrote:
> On Mon, Mar 11, 2019 at 7:07 PM Christophe Fergeau
> wrote:
> >
> > On Sun, Mar 10, 2019 at 04:46:01PM +0200, Yuri Benditovich wrote:
> > > Removing unused parameter for GUdevClient constructor.
>
On Wed, Mar 13, 2019 at 09:40:14AM +0200, Yuri Benditovich wrote:
> On Mon, Mar 11, 2019 at 7:17 PM Christophe Fergeau
> wrote:
> >
> > On Sun, Mar 10, 2019 at 04:46:03PM +0200, Yuri Benditovich wrote:
> > > In initial device enumeration hotplug notification can be
Great :)
Acked-by: Christophe Fergeau
On Sun, Mar 10, 2019 at 04:46:12PM +0200, Yuri Benditovich wrote:
> Remove unused code related to GUdevDevice.
>
> Signed-off-by: Yuri Benditovich
> ---
> src/win-usb-dev.c | 74 ---
> src/
On Sun, Mar 10, 2019 at 04:46:11PM +0200, Yuri Benditovich wrote:
> Unify SpiceUsbDeviceInfo for Linux and Windows by using
> persistent libusb_device.
This really needs to be more detailed and explain why this is no longer
a valid concern:
* On win32 we need to do this the hard and slow way, by
On Sun, Mar 10, 2019 at 04:46:09PM +0200, Yuri Benditovich wrote:
> @@ -388,18 +402,20 @@ static gboolean get_usb_dev_info(libusb_device *dev,
> GUdevDeviceInfo *udevinfo)
> }
>
> /* comparing bus:addr and vid:pid */
> -static gint gudev_devices_differ(gconstpointer a, gconstpointer b)
> +stat
G_GUDEV_DEVICE_LISTS
> @@ -249,15 +247,7 @@ static void
> g_udev_client_initable_iface_init(GInitableIface *iface)
>
> static void g_udev_notify_device(GUdevClient *self, libusb_device *dev, int
> add)
> {
> -GUdevDeviceInfo *u
/* keep old existing libusb_device in the new list, when
> + usb-dev-manager will maintain its own list of libusb_device,
> + these lists will be completely consistent */
> +libusb_device *temp = found->data;
> +found->data = dev->data;
> +dev->data = temp;
Is this chunk required in this commit for proper behaviour the usb code?
Or will it be required in some follow-up commit? If it's only going to
be required later, I'd squash this bit in the commit where it's needed
so that it's clearer why we want this.
Apart from these,
Acked-by: Christophe Fergeau
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Sun, Mar 10, 2019 at 04:46:08PM +0200, Yuri Benditovich wrote:
> When processing list of USB devices, avoid allocating memory
> for devices which later will be skipped. Use existing libusb
> struct first to check whether the device shall be excluded.
I probably would reword the short log
"win-u
On Sun, Mar 10, 2019 at 04:46:07PM +0200, Yuri Benditovich wrote:
> Changing signal definition from (boxed-boxed) to (pointer,int).
> There is no need for additional referencing of GUdevDevice
> object before signal callback.
I still feel it would be nicer to guarantee the GUdevDevice will stay
al
ice_list(priv->coldplug_list, 1);
> -priv->coldplug_list = NULL;
> +g_udev_client_report_devices(priv->udev);
I think I would have gone with 'coldplug' or 'signal' instead of
'report" but that really is nitpicking
Acked-by: Christophe Fergeau
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Tue, Mar 12, 2019 at 05:58:40AM -0400, Frediano Ziglio wrote:
> ping
>
> >
> > RedClient was an opaque structure for RedCharDevice.
> > It started to be used when RedsState started to contain all
> > the global state.
> > Make it opaque again.
It seems we don't put the same meaning to 'opaque
Ah sure,
Acked-by: Christophe Fergeau
On Wed, Feb 27, 2019 at 10:02:37AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> mingw-spice-vdagent.spec.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mingw-spice-vdagent.spe
On Sun, Mar 10, 2019 at 04:46:05PM +0200, Yuri Benditovich wrote:
> Remove unused g_udev_device_get_sysfs_attr.
>
Indeed, last user was apparently removed in 45cfbe8f86c in July 2013.
Acked-by: Christophe Fergeau
> Signed-off-by: Yuri Benditovich
> ---
> src/win
On Sun, Mar 10, 2019 at 04:46:03PM +0200, Yuri Benditovich wrote:
> In initial device enumeration hotplug notification can be
> called twice with the same libusb device. For details, see
> http://libusb.sourceforge.net/api-1.0/group__libusb__hotplug.html#ga00e0c69ddf1fb1b6774dc918192e8dc7
> Filter
which add devices under Windows.
"It also removes the identical call ..., which adds devices..."
Acked-by: Christophe Fergeau
>
> Signed-off-by: Yuri Benditovich
> ---
> src/usb-device-manager.c | 22 +++---
> 1 file changed, 11 insertions(+), 11 de
t reuse the existing one created by
win-usb-dev.c » + an explanation why we want to do that.
Iirc, we need a shared libusb_context if we want to share libusb_device
between the 2 files, so I'd add that to the commit log.
Apart from this,
Acked-by: Christophe Fergeau
>
> Signed-of
windows code.
Apart from this minor comment,
Acked-by: Christophe Fergeau
Christophe
>
> Signed-off-by: Yuri Benditovich
> ---
> src/usb-device-manager.c | 5 +
> src/win-usb-dev.c| 2 +-
> src/win-usb-dev.h| 2 +-
> 3 files changed, 3 insertions(+)
Acked-by: Christophe Fergeau
On Sun, Mar 10, 2019 at 04:46:00PM +0200, Yuri Benditovich wrote:
> Replacing USE_GUDEV with G_OS_WIN32 anywhere. GUDEV simulation
> is used only in Windows build.
>
> Signed-off-by: Yuri Benditovich
> ---
> src/usb-dev
Series looks good to me,
Reviewed-by: Christophe Fergeau
On Mon, Mar 11, 2019 at 01:59:09PM +, Frediano Ziglio wrote:
> Allows to declare C declarations (that were in common/messages.h)
> automatically.
> I added an attribute to:
> - be compatible;
> - allows to decla
On Fri, Mar 08, 2019 at 04:47:35PM -0500, Frediano Ziglio wrote:
> >
> > On Sun, Mar 03, 2019 at 07:10:25PM +, Frediano Ziglio wrote:
> > > Allows to specify a @declare attribute for messages and structure
> > > that can generate the needed C structures.
> > >
> > > Signed-off-by: Frediano Zi
On Fri, Mar 08, 2019 at 04:42:24PM -0500, Frediano Ziglio wrote:
> >
> >
> > Bit unsure about the option name. --header-name maybe? Or just infer it
> > from the .c file name?
> >
>
> It's similar to --generate-enums and similars. Yes, on the other end this
> option is an additional generation
On Fri, Mar 08, 2019 at 04:51:20PM -0500, Frediano Ziglio wrote:
> >
> > On Sun, Mar 03, 2019 at 07:10:26PM +, Frediano Ziglio wrote:
> > > Generate and include C declarations.
> > > Next patch will use this facility.
> >
> > Since none of the spice.proto types are decorated with @declare, ad
On Mon, Mar 11, 2019 at 12:12:45PM +, Victor Toso wrote:
> Hi,
>
> On Mon, Mar 11, 2019 at 12:33:20PM +0100, Christophe Fergeau wrote:
> > Hey,
> >
> > One comment, even if the commit log mentions a bug #, it does not seem
> > to be describing what the bug
Hey,
One comment, even if the commit log mentions a bug #, it does not seem
to be describing what the bug is/how it's fixed (maybe this can be
inferred from the traces, but I did not read them closely as the log
does not hint that a bug can be seen by looking at them).
Christophe
On Mon, Mar 11,
Hey,
On Thu, Mar 07, 2019 at 02:42:45PM +, Daniel P. Berrangé wrote:
> After investigating in more detail it seems you can provide custom rules
> for XML files by setting GETTEXTDATADIR, so I can support mime files with
> this extra diff:
Ah indeed, nice finding. Seeing what is shipped in
htt
On Thu, Mar 07, 2019 at 04:05:27PM -0500, Frediano Ziglio wrote:
> >
> > On Sun, Mar 03, 2019 at 07:10:30PM +, Frediano Ziglio wrote:
> > > The option is used to add a suffix to public functions, not a
> > > prefix.
> >
> > Sometimes it's a suffix to a prefix, sometimes it's indeed just a
> >
Sure,
Acked-by: Christophe Fergeau
On Fri, Mar 08, 2019 at 10:39:19AM +0100, Fabiano Fidêncio wrote:
> Signed-off-by: Fabiano Fidêncio
> ---
> README | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/README b/README
> index 411ceb2..b0faebb 100644
> ---
1 - 100 of 11794 matches
Mail list logo
