On Wednesday, July 23, 2025 5:55:58 PM CEST Mark Johnston wrote:
> This is largely derived from existing Darwin support. FreeBSD
> apparently has better support for *at() system calls so doesn't require
> workarounds for a missing mknodat(). The implementation has a couple of
> warts however:
> -
source file. No behavior change.
Signed-off-by: Sean Wei
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20250613.qemu.9p.01@sean.taipei>
[CS: fix code style (max. 80 chars per line)]
Signed-off-by: Christian Schoenebeck
---
fsdev/9p-marshal.c | 3 +--
fsdev/9p-marshal.h | 3 ++-
2 files c
. No behavior change.
Signed-off-by: Sean Wei
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20250613.qemu.9p.02@sean.taipei>
[CS: fix code style (max. 80 chars per line)]
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p.c | 3 +--
hw/9pfs/9p.h | 3 ++-
2 files changed, 3 insertions
The following changes since commit c079d3a31e45093286c65f8ca5350beb3a4404a9:
Merge tag 'pull-10.1-rc0-maintainer-140725-1' of
https://gitlab.com/stsquad/qemu into staging (2025-07-15 00:12:07 -0400)
are available in the Git repository at:
https://github.com/cschoenebeck/qemu.git tags/pull-9
On Thursday, July 10, 2025 3:30:22 PM CEST Peter Maydell wrote:
> On Mon, 5 May 2025 at 10:54, Christian Schoenebeck
> wrote:
> >
> > Add and implement functions to 9pfs test client for sending a 9p2000.L
> > 'Tsetattr' request and receiving its 'Rsetattr&#x
On Saturday, June 14, 2025 4:07:40 AM CEST Sean Wei wrote:
> v9fs_string_sprintf() and v9fs_path_sprintf() already have
> G_GNUC_PRINTF annotations in their own *.c files, but the
> prototypes in the corresponding headers lack them. When another
> translation unit includes only the header, -Wforma
On Tuesday, June 17, 2025 2:16:19 AM CEST Philippe DIDIER wrote:
> Hi
Hi Philippe,
> We use to create rpms of gig linuxsampler gigedit and qsampler for i686
> , x86_64 , aarch64 and armv7hl...
>
> There's something wrong when we try to build linuxsampler 2.4.0 for
> armv7hl :
>
> This concern
On Tuesday, June 10, 2025 11:52:32 PM CEST Rui Nuno Capela via Linuxsampler-
devel wrote:
> On 6/10/25 22:11, Christian Schoenebeck wrote:
[...]
> > I saw that you also added an optional installation of Qt onto the system.
> > While that probably makes sense for Windows, on a Mac th
On Tuesday, June 10, 2025 9:38:26 PM CEST Rui Nuno Capela via
Linuxsampler-devel wrote:
> On 6/6/25 17:34, Rui Nuno Capela via Linuxsampler-devel wrote:
> > On 6/6/25 10:52, Christian Schoenebeck wrote:
> >> The problem rather is *what* cmake installs. For the QSampler Ma
On Thursday, June 5, 2025 5:17:13 PM CEST Rui Nuno Capela via
Linuxsampler-devel wrote:
> On 6/5/25 11:34, Christian Schoenebeck wrote:
> > On Tuesday, June 3, 2025 8:53:36 PM CEST TJ Lindgren via
> > Linuxsampler-devel wrote:
> >
> > The problem I have is, I don&
On Thursday, June 5, 2025 12:34:40 PM CEST Christian Schoenebeck wrote:
> On Tuesday, June 3, 2025 8:53:36 PM CEST TJ Lindgren via Linuxsampler-devel
> wrote:
> > Has anyone tested Linuxsampler with a recent version of MacOS? I cannot
> > get
> > LinuxSampler working at
On Tuesday, June 3, 2025 8:53:36 PM CEST TJ Lindgren via Linuxsampler-devel
wrote:
> Has anyone tested Linuxsampler with a recent version of MacOS? I cannot get
> LinuxSampler working at all. Obviously, it’s not apple silicon but there
> are several issues preventing LinuxSampler from working it s
Hi everyone,
a new release had been rolled out today:
o LinuxSampler 2.4.0
o Gigedit 1.2.2
o libgig 4.5.0
This is a new feature release. Check the release notes for details:
http://doc.linuxsampler.org/Release_Notes/LinuxSampler_2_4_0/
/Christian
___
On Tuesday, May 6, 2025 4:34:42 PM CEST BALATON Zoltan wrote:
> On Tue, 8 Apr 2025, Volker Rümelin wrote:
> > Am 08.04.25 um 14:55 schrieb Christian Schoenebeck:
> >> On Friday, April 4, 2025 1:34:27 PM CEST BALATON Zoltan wrote:
> >>> On Fri, 4 Apr 2025, Christia
-off-by: Greg Kurz
Reviewed-by: Christian Schoenebeck
Message-Id: <20250312152933.383967-4-gr...@kaod.org>
Signed-off-by: Christian Schoenebeck
---
fsdev/file-op-9p.h | 2 ++
hw/9pfs/9p-local.c | 9 +
hw/9pfs/9p-synth.c | 8
hw/9pfs/9p.c | 6 +-
hw/9pfs/
From: Greg Kurz
Enhance the `use-after-unlink` test with a new check for the
case where the client wants to alter the size of an unlinked
file for which it still has an active fid.
Suggested-by: Christian Schoenebeck
Signed-off-by: Greg Kurz
Reviewed-by: Christian Schoenebeck
Message-Id
Add and implement functions to 9pfs test client for sending a 9p2000.L
'Tsetattr' request and receiving its 'Rsetattr' response counterpart.
Signed-off-by: Christian Schoenebeck
Signed-off-by: Greg Kurz
Message-Id: <20250312152933.383967-6-gr...@kaod.org>
---
te
crementing 'total_open_fd' on a close() error is wrong
and would yield in a higher open file descriptor count than actually the
case, leading to 9p server reclaiming open file descriptors too soon.
Based-on: <20250312152933.383967-7-gr...@kaod.org>
Signed-off-by: Christian Schoenebeck
Reviewed
-off-by: Greg Kurz
Reviewed-by: Christian Schoenebeck
Message-Id: <20250312152933.383967-5-gr...@kaod.org>
Signed-off-by: Christian Schoenebeck
---
fsdev/file-op-9p.h | 2 ++
hw/9pfs/9p-local.c | 9 +
hw/9pfs/9p-synth.c | 8
hw/9pfs/9p-util.h | 1 +
hw/9pfs/9p.c
m (i.e. when running
towards host's allowed limit of max. open file descriptors).
* Additional fixes on use-after-unlink idiom (i.e. client operations on a
file descriptor after file has been removed).
--------
Christian Schoenebeck (4):
9fs_co_closedir() inside of v9fs_reclaim_fd() and not performing the
v9fs_request_cancelled(pdu) check there.
Fixes: 7a46274529c ('hw/9pfs: Add file descriptor reclaim support')
Fixes: bccacf6c792 ('hw/9pfs: Implement TFLUSH operation')
Signed-off-by: Christian Schoenebeck
From: Greg Kurz
Factor out duplicated code to a single helper. More users to come.
Signed-off-by: Greg Kurz
Reviewed-by: Christian Schoenebeck
Message-Id: <20250312152933.383967-2-gr...@kaod.org>
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p-local.c | 25 +++---
.
Abstract that with a new has_valid_file_handle() backend operation.
Signed-off-by: Greg Kurz
Reviewed-by: Christian Schoenebeck
Message-Id: <20250312152933.383967-3-gr...@kaod.org>
Signed-off-by: Christian Schoenebeck
---
fsdev/file-op-9p.h | 1 +
hw/9pfs/9p-local.c | 8
hw/9pfs/9p-s
27;hw/9pfs: Add file descriptor reclaim support')
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<5c622067efd66dd4ee5eca740dcf263f41db20b2.1741339452.git.qemu_...@crudebyte.com>
---
hw/9pfs/9p.c | 10 ++
hw/9pfs/9p.h | 1 +
2 files changed, 11 insertion
On Saturday, April 12, 2025 12:21:47 PM CEST Christian Schoenebeck wrote:
> On Saturday, April 12, 2025 10:21:47 AM CEST Christian Schoenebeck wrote:
> > On Friday, April 11, 2025 12:47:29 PM CEST Kohei Tokunaga wrote:
[...]
> Let my answer my own question: I just checked the wasi
On Saturday, April 12, 2025 12:21:47 PM CEST Christian Schoenebeck wrote:
> On Saturday, April 12, 2025 10:21:47 AM CEST Christian Schoenebeck wrote:
> > On Friday, April 11, 2025 12:47:29 PM CEST Kohei Tokunaga wrote:
[...]
> Let my answer my own question: I just checked the wasi
On Saturday, April 12, 2025 10:21:47 AM CEST Christian Schoenebeck wrote:
> On Friday, April 11, 2025 12:47:29 PM CEST Kohei Tokunaga wrote:
> > Hi Christian,
> >
> > > > Emscripten's fiber does not support submitting coroutines to other
> > > > thread
On Saturday, April 12, 2025 10:21:47 AM CEST Christian Schoenebeck wrote:
> On Friday, April 11, 2025 12:47:29 PM CEST Kohei Tokunaga wrote:
> > Hi Christian,
> >
> > > > Emscripten's fiber does not support submitting coroutines to other
> > > > thread
On Friday, April 11, 2025 12:47:29 PM CEST Kohei Tokunaga wrote:
> Hi Christian,
>
> > > Emscripten's fiber does not support submitting coroutines to other
> > > threads. So this commit modifies hw/9pfs/coth.h to disable this behavior
> > > when compiled with Emscripten.
> >
> > The lack of being
On Friday, April 11, 2025 12:47:29 PM CEST Kohei Tokunaga wrote:
> Hi Christian,
>
> > > Emscripten's fiber does not support submitting coroutines to other
> > > threads. So this commit modifies hw/9pfs/coth.h to disable this behavior
> > > when compiled with Emscripten.
> >
> > The lack of being
On Friday, April 4, 2025 1:34:27 PM CEST BALATON Zoltan wrote:
> On Fri, 4 Apr 2025, Christian Schoenebeck wrote:
> > On Monday, March 31, 2025 3:05:24 PM CEST BALATON Zoltan wrote:
> >> On Sun, 23 Mar 2025, Christian Schoenebeck wrote:
> >>> On Sunday, March 16, 2025
On Monday, April 7, 2025 4:45:59 PM CEST Kohei Tokunaga wrote:
> Emscripten's fiber does not support submitting coroutines to other
> threads. So this commit modifies hw/9pfs/coth.h to disable this behavior
> when compiled with Emscripten.
The lack of being able to dispatch a coroutine to a worker
On Monday, April 7, 2025 4:45:59 PM CEST Kohei Tokunaga wrote:
> Emscripten's fiber does not support submitting coroutines to other
> threads. So this commit modifies hw/9pfs/coth.h to disable this behavior
> when compiled with Emscripten.
The lack of being able to dispatch a coroutine to a worker
On Friday, April 4, 2025 3:15:23 PM CEST Gastón Taylor wrote:
> Hello!
Hi!
> I've been trying to use more than 16 channels in LinuxSampler but I have
> failed once and again. I add a second instance in another REAPER track and
> set a channel both in Qsampler and Jsampler Classic to "Device 1", b
On Monday, March 31, 2025 3:52:31 PM CEST Zheng Huang wrote:
> Hi,
Hi!
> This patch adds a cleanup operation for 9p-synth, which fixes a memory
> leak bug in synth_init() and other related operations.
Which other operations?
> All child nodes
> of synth_root need to be freed before the entire
On Monday, March 31, 2025 3:05:24 PM CEST BALATON Zoltan wrote:
> On Sun, 23 Mar 2025, Christian Schoenebeck wrote:
> > On Sunday, March 16, 2025 1:20:46 AM CET BALATON Zoltan wrote:
> >> Quoting Volker Rümelin: "try-poll=on tells the ALSA backend to try to
> >>
On Thursday, March 20, 2025 11:59:38 AM CET Greg Kurz wrote:
> On Thu, 20 Mar 2025 10:48:11 +0100
> Christian Schoenebeck wrote:
>
> > On Wednesday, March 19, 2025 7:52:51 PM CET Greg Kurz wrote:
> > > On Wed, 19 Mar 2025 13:14:27 +0100
> > > Christian Scho
On Thursday, March 20, 2025 1:16:20 PM CET Christian Schoenebeck wrote:
> According to 'man 2 close' errors returned by close() should only be used
> for either diagnostic purposes or for catching data loss due to a previous
> write error, as an error result of close() usually i
On Sunday, March 16, 2025 1:20:46 AM CET BALATON Zoltan wrote:
> Quoting Volker Rümelin: "try-poll=on tells the ALSA backend to try to
> use an event loop instead of the audio timer. This works most of the
> time. But the poll event handler in the ALSA backend has a bug. For
> example, if the guest
On Wednesday, March 19, 2025 7:52:51 PM CET Greg Kurz wrote:
> On Wed, 19 Mar 2025 13:14:27 +0100
> Christian Schoenebeck wrote:
>
> > On Wednesday, March 19, 2025 11:08:58 AM CET Christian Schoenebeck wrote:
> > > According to 'man 2 close' errors retur
crementing 'total_open_fd' on a close() error is wrong
and would yield in a higher open file descriptor count than actually the
case, leading to 9p server reclaiming open file descriptors too soon.
Based-on: <20250312152933.383967-7-gr...@kaod.org>
Signed-off-by: Christian Schoenebeck
---
V2
On Wednesday, March 19, 2025 11:08:58 AM CET Christian Schoenebeck wrote:
> According to 'man 2 close' errors returned by close() should only be used
> for either diagnostic purposes or for catching data loss due to a previous
> write error, as an error result of close()
crementing 'total_open_fd' on a close() error is wrong
and would yield in a higher open file descriptor count than actually the
case, leading to 9p server reclaiming open file descriptors too soon.
Based-on: <20250312152933.383967-7-gr...@kaod.org>
Signed-off-by: Christian Schoenebeck
On Friday, March 7, 2025 10:24:12 AM CET Christian Schoenebeck wrote:
> Three fixes for 9p server's v9fs_reclaim_fd() function:
>
> * Patch 1 fixes a concurrency issue.
>
> * Patch 2 fixes a file descriptor leak and optimizes overall latency. On a
> test
> machin
er :
>
> creat("./foo", 000) = 3
> ftruncate(3, 100) = 0
> unlink("./foo") = 0
> ftruncate(3, 1000) = 0
>
> Cheers,
>
> --
> Greg
>
> Christian Schoenebeck (1):
On Wednesday, March 12, 2025 4:29:32 PM CET Greg Kurz wrote:
> Enhance the `use-after-unlink` test with a new check for the
> case where the client wants to alter the size of an unlinked
> file for which it still has an active fid.
>
> Suggested-by: Christian Schoenebeck
> S
On Wednesday, March 12, 2025 3:25:20 PM CET Greg Kurz wrote:
> On Wed, 12 Mar 2025 15:11:41 +0100
> Christian Schoenebeck wrote:
>
> > On Tuesday, March 11, 2025 6:28:09 PM CET Greg Kurz wrote:
> > > Enhance the `use-after-unlink` test with a new check for the
> >
On Tuesday, March 11, 2025 6:28:09 PM CET Greg Kurz wrote:
> Enhance the `use-after-unlink` test with a new check for the
> case where the client wants to alter the size of an unlinked
> file for which it still has an active fid.
>
> Suggested-by: Christian Schoenebeck
> Signed
an open file decriptor for.
>
> Only 9P2000.L was considered.
>
> Reviewed-by: Christian Schoenebeck
> Signed-off-by: Greg Kurz
>
> v2: - moved v9fs_co_ftruncate() near v9fs_co_truncate() in coth.h
> - similar change in file-op-9p.h
> ---
> fsdev/file-
; +.has_valid_file_handle = synth_has_valid_file_handle,
> };
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index 7cad2bce6209..10363f1a1df8 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -1574,6 +1574,11 @@ out_nofid:
> pdu_complete(pdu, err);
> }
>
> +static bo
On Tuesday, March 11, 2025 6:28:04 PM CET Greg Kurz wrote:
> Factor out duplicated code to a single helper. More users to come.
>
> Signed-off-by: Greg Kurz
>
> v2: - simplified local_fid_fd()
> ---
Reviewed-by: Christian Schoenebeck
> hw/9pfs/9p-local.c | 23 +++
On Tuesday, March 11, 2025 3:03:13 PM CET Greg Kurz wrote:
> On Tue, 11 Mar 2025 12:13:06 +0100
> Christian Schoenebeck wrote:
>
> > On Monday, March 10, 2025 6:10:59 PM CET Greg Kurz wrote:
[...]
> > Follow-up on previous patch, this could be reduced to:
> >
>
On Monday, March 10, 2025 6:10:59 PM CET Greg Kurz wrote:
> v9fs_getattr() currently peeks into V9fsFidOpenState to know if a fid
> has a valid file descriptor or directory stream. Even though the fields
> are accessible, this is an implementation detail of the local backend
> that should not be ma
9fsPDU *pdu, V9fsPath
> *path, mode_t,
> V9fsStatDotl *v9stat);
> int coroutine_fn v9fs_co_ftruncate(V9fsPDU *pdu, V9fsFidState *fidp,
> off_t size);
> +int coroutine_fn v9fs_co_futimens(V9fsPDU *pdu, V9fsFidState *fidp,
> + struct timespec times[2]);
>
> #endif
Same nit as with previous patch: I would group v9fs_co_futimens() and
v9fs_co_utimensat() together in this header file for overview reason.
Reviewed-by: Christian Schoenebeck
/Christian
sPDU *, V9fsPath
> *,
> const char *, V9fsPath *);
> int coroutine_fn v9fs_co_st_gen(V9fsPDU *pdu, V9fsPath *path, mode_t,
> V9fsStatDotl *v9stat);
> +int coroutine_fn v9fs_co_ftruncate(V9fsPDU *pdu, V9fsFidState *fidp,
> + off_t size);
>
> #endif
Nit: I would move v9fs_co_ftruncate() close to v9fs_co_truncate() to make it
easier preserving the overview on this header file.
Rest looks fine:
Reviewed-by: Christian Schoenebeck
/Christian
On Monday, March 10, 2025 6:10:58 PM CET Greg Kurz wrote:
> Factor out duplicated code to a single helper. More users to come.
>
> Signed-off-by: Greg Kurz
> ---
> hw/9pfs/9p-local.c | 21 +++--
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/hw/9pfs/9p-loca
On Monday, March 10, 2025 6:10:57 PM CET Greg Kurz wrote:
> QEMU 9.2 already fixed the long standing limitation of failing fstat() on
> unlinked files. This series does something similar for ftruncate().
>
> The following program can be straced inside the guest with a shared fs in
> passthrough mo
Add and implement functions to 9pfs test client for sending a 9p2000.L
'Tsetattr' request and receiving its 'Rsetattr' response counterpart.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/libqos/virtio-9p-client.c | 49 +++
tests/qtest/libqo
On Friday, March 7, 2025 10:23:02 AM CET Christian Schoenebeck wrote:
> This patch fixes two different bugs in v9fs_reclaim_fd():
>
> 1. Reduce latency:
>
> This function calls v9fs_co_close() and v9fs_co_closedir() in a loop. Each
> one of the calls adds two thread hops (betwe
tch 2: Decrement global variable total_open_fd on main thread, not
on fs driver background thread.
- Patch 2: Update commit log about file descriptor leak being fixed.
Christian Schoenebeck (2):
9pfs: fix concurrent v9fs_reclaim_fd() calls
9pfs: fix FD leak and reduce latency of v9fs_recla
9fs_co_closedir() inside of v9fs_reclaim_fd() and not performing the
v9fs_request_cancelled(pdu) check there.
Fixes: 7a46274529c ('hw/9pfs: Add file descriptor reclaim support')
Fixes: bccacf6c792 ('hw/9pfs: Implement TFLUSH operation')
Signed-off-by: Christian
27;hw/9pfs: Add file descriptor reclaim support')
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
---
hw/9pfs/9p.c | 10 ++
hw/9pfs/9p.h | 1 +
2 files changed, 11 insertions(+)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 7cad2bce62..4f9c2dde9c 100644
--- a/hw/9pfs/9p.
On Thursday, March 6, 2025 10:07:56 AM CET Greg Kurz wrote:
> On Tue, 4 Mar 2025 16:16:05 +0100
> Christian Schoenebeck wrote:
>
> > This function calls v9fs_co_close() and v9fs_co_closedir() in a loop. Each
> > one of the calls adds two thread hops (between main t
oding what v9fs_co_close() and
v9fs_co_closedir() do, executing those and the loop itself altogether in
only one background thread block, hence reducing the total amount of
thread hops to only two.
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p.c | 26 +-
1 file ch
27;hw/9pfs: Add file descriptor reclaim support')
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p.c | 10 ++
hw/9pfs/9p.h | 1 +
2 files changed, 11 insertions(+)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 7cad2bce62..4f9c2dde9c 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
Two fixes for 9p server's v9fs_reclaim_fd() function:
* Patch 1 fixes a concurrency issue.
* Patch 2 optimizes overall latency. On a test machine with ~800,000 FIDs, this
reduced execution duration of v9fs_reclaim_fd() from 30ms to 1ms.
Christian Schoenebeck (2):
9pfs: fix concu
On Tuesday, February 25, 2025 9:00:51 PM CET Brandon Smith wrote:
> Thank you Christian, that worked! With the latest version from svn I was
> able to save gig files in both standalone and live mode.
> Btw here is my script for installing linuxsampler from svn on mint 22:
>
> #!/bin/bash
> # local
Hi Brandon,
please try with latest SVN version, especially of libgig.
I've fixed a bunch of issues in the last few days, including problems while
saving with gigedit (e.g. save progress being stuck in gigedit sometimes).
/Christian
___
Linuxsample
On Tuesday, February 11, 2025 3:47:33 PM CET Peter Maydell wrote:
> On Mon, 10 Feb 2025 at 14:40, Christian Schoenebeck
> wrote:
> >
> > Coverity scan complained about expression "|LARGEFILE" to be non reachable
> > and the detailed Coverity report cl
On Monday, February 10, 2025 4:32:08 PM CET Philippe Mathieu-Daudé wrote:
> On 10/2/25 15:33, Christian Schoenebeck wrote:
> > Coverity scan complained about expression "|LARGEFILE" to be non reachable
> > and the detailed Coverity report claims O_LARGEFILE was zero. I
ust whether the macro was defined.
Fixes: 9a0dd4b3
Resolves: Coverity CID 1591178
Reported-by: Coverity Scan
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p-util-generic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
index 4c1e9c887d..0
or even just only one device being shared with the
same 9p export, expected to be constant Theta(1). The inode numbers
emitted to guest also just loose one bit (since 6b6aa8285d) for the 1st
device being shared.
Signed-off-by: Christian Schoenebec
From: Greg Kurz
I still review 9pfs changes from time to time but I'm definitely
not able to do actual maintainer work. Drop my tree on the way
as I'll obviously not use it anymore, and it has been left
untouched since May 2020.
Signed-off-by: Greg Kurz
Reviewed-by: Christian S
for both protocol variants, use the already existing conversion functions
that convert the mode flags from respective protocol constants to host's
native open() numeric flag constants and pass that result to the new
string conversion function qemu_open_flags_tostr().
Signed-off-by: Christian S
multidevs=remap default option (instead of multidevs=warn)
and update documentation related to this option.
* Improve tracing (i.e. usefulness of log output content).
----
Christian Schoenebeck (3):
9pfs: improve v9fs_walk
alled if tracing of event 'v9fs_walk' is currently enabled.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Reviewed-by: Stefan Hajnoczi
Message-Id:
---
hw/9pfs/9p.c | 36 +++-
hw/9pfs/trace-events | 2 +-
2 files changed, 32 insertions(
On Thursday, February 6, 2025 7:49:07 PM CET Stefan Hajnoczi wrote:
> On Thu, Feb 6, 2025 at 11:49 AM Christian Schoenebeck
> wrote:
> >
> > The following changes since commit d922088eb4ba6bc31a99f17b32cf75e59dd306cd:
> >
> > Merge tag 'ui-pull-request'
After removing a directory from the filesystem, it should still be
possible to operate on the directory if the directory has been opened
before.
As a first step this new test will verify whether Tgetattr request
works on the unlinked directory.
Signed-off-by: Christian Schoenebeck
Message-Id
of to date that would allow a removed directory to have any
content (files, links, devices, subdirectories) and POSIX specifies that
a directory must be empty when trying to remove it from the file system.
Signed-off-by: Christian Schoenebeck
Message-Id:
---
tests/qtest/virtio-9p-test.c | 3
From: Greg Kurz
I still review 9pfs changes from time to time but I'm definitely
not able to do actual maintainer work. Drop my tree on the way
as I'll obviously not use it anymore, and it has been left
untouched since May 2020.
Signed-off-by: Greg Kurz
Reviewed-by: Christian S
alled if tracing of event 'v9fs_walk' is currently enabled.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Reviewed-by: Stefan Hajnoczi
Message-Id:
---
hw/9pfs/9p.c | 36 +++-
hw/9pfs/trace-events | 2 +-
2 files changed, 32 insertions(
for both protocol variants, use the already existing conversion functions
that convert the mode flags from respective protocol constants to host's
native open() numeric flag constants and pass that result to the new
string conversion function qemu_open_flags_tostr().
Signed-off-by: Christian S
To pave the way for adding new test use_dir_after_unlink with subsequent
patch, i.e. making it clear that the existing test is just about unlinked
files, not unlinked directories.
Signed-off-by: Christian Schoenebeck
Message-Id:
<9d2ca46a58b812ad17ca7bb8a84f12252d3e3832.1736427878.git.qe
or even just only one device being shared with the
same 9p export, expected to be constant Theta(1). The inode numbers
emitted to guest also just loose one bit (since 6b6aa8285d) for the 1st
device being shared.
Signed-off-by: Christian Schoenebec
ap default option (instead of multidevs=warn)
and update documentation related to this option.
* Improve tracing (i.e. usefulness of log output content).
* Add test cases for accessing a directory after removal.
----
Christian Scho
On Wednesday, January 15, 2025 11:08:49 AM CET Greg Kurz wrote:
> I still review 9pfs changes from time to time but I'm definitely
> not able to do actual maintainer work. Drop my tree on the way
> as I'll obviously not use it anymore, and it has been left
> untouched since May 2020.
>
> Signed-of
On Thursday, January 9, 2025 2:04:38 PM CET Christian Schoenebeck wrote:
> Add a test case that verifies that it is possible to do some basic operations
> on a deleted directory if 9p client opened the directory before directory was
> removed.
>
> Unlike the previous open-unlink-
On Saturday, January 25, 2025 6:58:30 AM CET Akihiko Odaki wrote:
> On 2025/01/24 18:39, Christian Schoenebeck wrote:
> > On Friday, January 24, 2025 6:12:04 AM CET Akihiko Odaki wrote:
> >> coreaudio had unnecessary explicit casts and they had extra whitespaces
> >>
ioVoiceOut *core, const char
> *fn_name)
> +static int coreaudio_buf_unlock(coreaudioVoiceOut *core, const char *fn_name)
> {
> int err;
>
> -err = pthread_mutex_unlock (&core->buf_mutex);
> +err = pthread_mutex_unlock(&core->buf_mutex);
> if
n, start;
>
> @@ -348,16 +350,16 @@ static OSStatus audioDeviceIOProc(
> out += write_len;
> }
>
> -coreaudio_buf_unlock(core, "audioDeviceIOProc");
> +coreaudio_voice_out_buf_unlock(core, "out_device_ioproc");
> return 0;
&
On Friday, January 24, 2025 6:12:04 AM CET Akihiko Odaki wrote:
> coreaudio had unnecessary explicit casts and they had extra whitespaces
> around them so remove them.
>
> Signed-off-by: Akihiko Odaki
> ---
> audio/coreaudio.m | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> di
On Friday, January 17, 2025 7:47:00 AM CET Akihiko Odaki wrote:
> init_out_device may only commit some part of the result and leave the
> state inconsistent when it encounters a fatal error or the device gets
> unplugged during the operation, which is expressed by
> kAudioHardwareBadObjectError or
On Friday, January 17, 2025 7:47:02 AM CET Akihiko Odaki wrote:
> Reallocate buffers when the active device change as the required buffer
> size may differ.
>
> Signed-off-by: Akihiko Odaki
OTOH it also re-allocates the buffer when the size did not change, but Ok.
Acked-b
On Thursday, January 16, 2025 6:17:46 AM CET Akihiko Odaki wrote:
> On 2025/01/16 2:10, Christian Schoenebeck wrote:
> > On Wednesday, January 15, 2025 4:37:28 PM CET Akihiko Odaki wrote:
> >> On 2025/01/16 0:14, Christian Schoenebeck wrote:
> >>> On Wednesday, J
On Wednesday, January 15, 2025 4:37:28 PM CET Akihiko Odaki wrote:
> On 2025/01/16 0:14, Christian Schoenebeck wrote:
> > On Wednesday, January 15, 2025 1:06:55 PM CET Akihiko Odaki wrote:
> >> init_out_device may only commit some part of the result and leave the
> >>
On Wednesday, January 15, 2025 1:06:56 PM CET Akihiko Odaki wrote:
> Reallocate buffers when the active device change as the required buffer
> size may differ.
>
> Signed-off-by: Akihiko Odaki
> ---
> audio/audio_int.h | 2 ++
> audio/audio.c | 24 ++--
> audio/coreaudio
On Wednesday, January 15, 2025 1:06:55 PM CET Akihiko Odaki wrote:
> init_out_device may only commit some part of the result and leave the
> state inconsistent when it encounters an error. Commit the result in
> the end of the function so that it commits the result iff it sees no
Typo "if".
> err
May 2020.
>
> Signed-off-by: Greg Kurz
> ---
Even though foreseeable, I still acknowledge your step with regret:
Reviewed-by: Christian Schoenebeck
Thanks for all your work over the years!
I try to continue your work on 9pfs as far as possible. Let's see how this
evolves, bei
On Saturday, January 11, 2025 7:42:36 AM CET Akihiko Odaki wrote:
> Commit 8b46d7e2dc8e ("audio: Rename coreaudio extension to use
> Objective-C compiler") renamed coreaudio.c to coreaudio.m.
>
> Signed-off-by: Akihiko Odaki
> ---
Reviewed-by: Christian Schoene
of to date that would allow a removed directory to have any
content (files, links, devices, subdirectories) and POSIX specifies that
a directory must be empty when trying to remove it from the file system.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 3 +++
1 file
1 - 100 of 1485 matches
Mail list logo
