Re: svn commit: r354076 - head/sys/dev/ow

2019-10-26 Thread Bruce Evans
On Fri, 25 Oct 2019, Andriy Gapon wrote: On 25/10/2019 18:46, Ian Lepore wrote: On Fri, 2019-10-25 at 15:38 +, Andriy Gapon wrote: Author: avg Date: Fri Oct 25 15:38:09 2019 New Revision: 354076 URL: https://svnweb.freebsd.org/changeset/base/354076 Log: owc_gpiobus_read_data: compare ti

Re: svn commit: r354076 - head/sys/dev/ow

2019-10-26 Thread Bruce Evans
On Fri, 25 Oct 2019, Andriy Gapon wrote: On 25/10/2019 18:46, Ian Lepore wrote: On Fri, 2019-10-25 at 15:38 +, Andriy Gapon wrote: Author: avg Date: Fri Oct 25 15:38:09 2019 New Revision: 354076 URL: https://svnweb.freebsd.org/changeset/base/354076 Log: owc_gpiobus_read_data: compare ti

Re: svn commit: r353640 - head/sys/kern

2019-10-23 Thread Bruce Evans
On Tue, 22 Oct 2019, Alan Somers wrote: On Wed, Oct 16, 2019 at 7:21 AM Andrew Turner wrote: Author: andrew Date: Wed Oct 16 13:21:01 2019 New Revision: 353640 URL: https://svnweb.freebsd.org/changeset/base/353640 Log: Stop leaking information from the kernel through timespec The timesp

Re: svn commit: r353640 - head/sys/kern

2019-10-23 Thread Bruce Evans
On Tue, 22 Oct 2019, Alan Somers wrote: On Wed, Oct 16, 2019 at 7:21 AM Andrew Turner wrote: Author: andrew Date: Wed Oct 16 13:21:01 2019 New Revision: 353640 URL: https://svnweb.freebsd.org/changeset/base/353640 Log: Stop leaking information from the kernel through timespec The timesp

Re: svn commit: r353103 - head/sys/net

2019-10-04 Thread Bruce Evans
On Fri, 4 Oct 2019, John Baldwin wrote: On 10/4/19 6:43 AM, Kyle Evans wrote: Author: kevans Date: Fri Oct 4 13:43:07 2019 New Revision: 353103 URL: https://svnweb.freebsd.org/changeset/base/353103 Log: tuntap(4): loosen up tunclose restrictions Realistically, this cannot work. We don't

Re: svn commit: r353103 - head/sys/net

2019-10-04 Thread Bruce Evans
On Fri, 4 Oct 2019, John Baldwin wrote: On 10/4/19 6:43 AM, Kyle Evans wrote: Author: kevans Date: Fri Oct 4 13:43:07 2019 New Revision: 353103 URL: https://svnweb.freebsd.org/changeset/base/353103 Log: tuntap(4): loosen up tunclose restrictions Realistically, this cannot work. We don't

Re: svn commit: r352795 - head/lib/libc/sys

2019-10-02 Thread Bruce Evans
On Tue, 1 Oct 2019, Ed Maste wrote: On Tue, 1 Oct 2019 at 12:23, Brooks Davis wrote: This isn't true with CHERI and as a result I've moved the variadic argument handling (except for syscall() and __syscall()) into libc. My grep found: open, openat, fcntl, semsys, msgsys, shmsys Is that the

Re: svn commit: r352795 - head/lib/libc/sys

2019-10-02 Thread Bruce Evans
On Tue, 1 Oct 2019, Ed Maste wrote: On Tue, 1 Oct 2019 at 12:23, Brooks Davis wrote: This isn't true with CHERI and as a result I've moved the variadic argument handling (except for syscall() and __syscall()) into libc. My grep found: open, openat, fcntl, semsys, msgsys, shmsys Is that the

Re: svn commit: r352846 - head/lib/libc/sys

2019-09-29 Thread Bruce Evans
On Sun, 29 Sep 2019, Konstantin Belousov wrote: On Sat, Sep 28, 2019 at 05:15:48PM +, Warner Losh wrote: Author: imp Date: Sat Sep 28 17:15:48 2019 New Revision: 352846 URL: https://svnweb.freebsd.org/changeset/base/352846 Log: Revert the mode_t -> int changes and add a warning in the BU

Re: svn commit: r352846 - head/lib/libc/sys

2019-09-29 Thread Bruce Evans
On Sun, 29 Sep 2019, Konstantin Belousov wrote: On Sat, Sep 28, 2019 at 05:15:48PM +, Warner Losh wrote: Author: imp Date: Sat Sep 28 17:15:48 2019 New Revision: 352846 URL: https://svnweb.freebsd.org/changeset/base/352846 Log: Revert the mode_t -> int changes and add a warning in the BU

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Bruce Evans
On Fri, 27 Sep 2019, Konstantin Belousov wrote: On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz Guzik wrote: On 9/27/19, Warner Losh wrote: Author: imp Date: Fri Sep 27 16:11:47 2019 New Revision: 352795 URL: https://svnweb.freebsd.org/changeset/base/352795 Log: Document varadic args as

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Bruce Evans
On Fri, 27 Sep 2019, Konstantin Belousov wrote: On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz Guzik wrote: On 9/27/19, Warner Losh wrote: Author: imp Date: Fri Sep 27 16:11:47 2019 New Revision: 352795 URL: https://svnweb.freebsd.org/changeset/base/352795 Log: Document varadic args as

Re: svn commit: r351700 - head/lib/libc/string

2019-09-25 Thread Bruce Evans
On Wed, 25 Sep 2019, Ed Maste wrote: On Fri, 20 Sep 2019 at 08:14, Bruce Evans wrote: Optimizing this function [memchr] is especially unimportant, Why? Because it is almost never used, and most of its uses are unimportant. It is used a whole 26 times in all of /usr/src/*bin: - sh/exec.c

Re: svn commit: r351700 - head/lib/libc/string

2019-09-25 Thread Bruce Evans
On Wed, 25 Sep 2019, Ed Maste wrote: On Fri, 20 Sep 2019 at 08:14, Bruce Evans wrote: Optimizing this function [memchr] is especially unimportant, Why? Because it is almost never used, and most of its uses are unimportant. It is used a whole 26 times in all of /usr/src/*bin: - sh/exec.c

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

2019-09-24 Thread Bruce Evans
On Tue, 24 Sep 2019, Randall Stewart wrote: Log: lets put (void) in a couple of functions to keep older platforms that are stuck with gcc happy (ppc). The changes are needed in both bbr and rack. You mean "Don't use K&R declarations. clang is too broken to warn about K&R declarations even

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

2019-09-24 Thread Bruce Evans
On Tue, 24 Sep 2019, Randall Stewart wrote: Log: lets put (void) in a couple of functions to keep older platforms that are stuck with gcc happy (ppc). The changes are needed in both bbr and rack. You mean "Don't use K&R declarations. clang is too broken to warn about K&R declarations even

Re: svn commit: r351700 - head/lib/libc/string

2019-09-20 Thread Bruce Evans
On Mon, 2 Sep 2019, Ed Maste wrote: Author: emaste Date: Mon Sep 2 13:56:44 2019 New Revision: 351700 URL: https://svnweb.freebsd.org/changeset/base/351700 Log: libc: Use musl's optimized memchr Parentheses added to HASZERO macro to avoid a GCC warning. Reviewed by: kib, mjg Obtained f

Re: svn commit: r351700 - head/lib/libc/string

2019-09-20 Thread Bruce Evans
On Mon, 2 Sep 2019, Ed Maste wrote: Author: emaste Date: Mon Sep 2 13:56:44 2019 New Revision: 351700 URL: https://svnweb.freebsd.org/changeset/base/351700 Log: libc: Use musl's optimized memchr Parentheses added to HASZERO macro to avoid a GCC warning. Reviewed by: kib, mjg Obtained f

Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio

2019-09-13 Thread Bruce Evans
On Sun, 1 Sep 2019, Cy Schubert wrote: I'm replying to this reply since I lost the original mail. In message <201909011612.x81gc5dw097...@repo.freebsd.org>, Ed Maste writes: Author: emaste Date: Sun Sep 1 16:12:05 2019 New Revision: 351659 URL: https://svnweb.freebsd.org/changeset/base/351659

Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio

2019-09-13 Thread Bruce Evans
On Sun, 1 Sep 2019, Cy Schubert wrote: I'm replying to this reply since I lost the original mail. In message <201909011612.x81gc5dw097...@repo.freebsd.org>, Ed Maste writes: Author: emaste Date: Sun Sep 1 16:12:05 2019 New Revision: 351659 URL: https://svnweb.freebsd.org/changeset/base/351659

svn commit: r346641 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 16:03:35 2019 New Revision: 346641 URL: https://svnweb.freebsd.org/changeset/base/346641 Log: Avoid hiding and unhiding the mouse cursor when copying bitmaps to the screen. Instead, copy a merged bitmap 1 line at a time. This fixes flashing of the cursor and

svn commit: r346416 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Apr 19 20:29:49 2019 New Revision: 346416 URL: https://svnweb.freebsd.org/changeset/base/346416 Log: Fix copying of overlapping bitmaps. The cases of copying within the screen bitmap and within a single MEMBUF were broken when first source line is before the first dest

svn commit: r346631 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 13:15:56 2019 New Revision: 346631 URL: https://svnweb.freebsd.org/changeset/base/346631 Log: Fix some races and screeen clearing in VGLEnd(). The mouse signal SIGUSR2 was not turned off for normal termination and in some other cases. Thus mouse signals arriv

svn commit: r346580 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 22 19:31:16 2019 New Revision: 346580 URL: https://svnweb.freebsd.org/changeset/base/346580 Log: Fix mouse cursor coloring in depths > 8 (previously, a hack that only worked right for white interiors and black borders was used). Advertise this by changing the defau

svn commit: r346639 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 15:35:29 2019 New Revision: 346639 URL: https://svnweb.freebsd.org/changeset/base/346639 Log: Refactor mouse freezing and fix some minor bugs. VGLMouseFreeze() now only defers mouse signals and leaves it to higher levels to hide and unhide the mouse cursor if

svn commit: r346488 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 21 16:17:35 2019 New Revision: 346488 URL: https://svnweb.freebsd.org/changeset/base/346488 Log: Use a shadow buffer and never read from the frame buffer. Remove large slow code for reading from the frame buffer. Reading from the frame buffer is usually much slo

svn commit: r346280 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:52:04 2019 New Revision: 346280 URL: https://svnweb.freebsd.org/changeset/base/346280 Log: Sigh, r346279 was also a test version with the reduced size doubled (so it was actually double the full size in current kernels where the reduction is null, so overran t

svn commit: r346486 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 21 10:33:09 2019 New Revision: 346486 URL: https://svnweb.freebsd.org/changeset/base/346486 Log: Fix missing restoring of the mouse cursor position, the border color and the blank state after a screen switch. Modified: head/lib/libvgl/main.c head/lib/libvgl/mouse

svn commit: r346279 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:41:45 2019 New Revision: 346279 URL: https://svnweb.freebsd.org/changeset/base/346279 Log: Oops, r346278 committed a test version with the change annulled. Modified: head/lib/libvgl/main.c Modified: head/lib/libvgl/main.c ==

svn commit: r346454 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sat Apr 20 20:29:03 2019 New Revision: 346454 URL: https://svnweb.freebsd.org/changeset/base/346454 Log: Make libvgl mostly work without superuser privilege in direct modes by not doing any unnecessary PIO instructions or refusing to start when the i/o privilege needed for

Re: svn commit: r346554 - head/sys/netinet

2019-09-03 Thread Bruce Evans
On Mon, 22 Apr 2019, Bjoern A. Zeeb wrote: On 22 Apr 2019, at 14:20, Bjoern A. Zeeb wrote: Log: Remove some excessive brackets. No functional change. But it includes a stye bug; sorry; I had re-indented the lines to validate the change. Ill remedy this with the follow-up commit which w

svn commit: r346631 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 13:15:56 2019 New Revision: 346631 URL: https://svnweb.freebsd.org/changeset/base/346631 Log: Fix some races and screeen clearing in VGLEnd(). The mouse signal SIGUSR2 was not turned off for normal termination and in some other cases. Thus mouse signals arriv

svn commit: r346639 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 15:35:29 2019 New Revision: 346639 URL: https://svnweb.freebsd.org/changeset/base/346639 Log: Refactor mouse freezing and fix some minor bugs. VGLMouseFreeze() now only defers mouse signals and leaves it to higher levels to hide and unhide the mouse cursor if

svn commit: r346278 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:31:23 2019 New Revision: 346278 URL: https://svnweb.freebsd.org/changeset/base/346278 Log: Quick fix for slow clearing and context switches of large frame buffers with old kernels, by breaking the support for large frame buffers in the same way as for current

svn commit: r346580 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 22 19:31:16 2019 New Revision: 346580 URL: https://svnweb.freebsd.org/changeset/base/346580 Log: Fix mouse cursor coloring in depths > 8 (previously, a hack that only worked right for white interiors and black borders was used). Advertise this by changing the defau

svn commit: r346641 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 16:03:35 2019 New Revision: 346641 URL: https://svnweb.freebsd.org/changeset/base/346641 Log: Avoid hiding and unhiding the mouse cursor when copying bitmaps to the screen. Instead, copy a merged bitmap 1 line at a time. This fixes flashing of the cursor and

svn commit: r346276 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 14:28:33 2019 New Revision: 346276 URL: https://svnweb.freebsd.org/changeset/base/346276 Log: Fix a variable name in r346215. Clearing of the right of the screen was broken, except it worked accidentally in most cases where the virtual screen is larger than the

svn commit: r346215 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 14 13:37:50 2019 New Revision: 346215 URL: https://svnweb.freebsd.org/changeset/base/346215 Log: For writing and reading single pixels, avoid some pessimizations for depths > 8. Add some smaller optimizations for these depths. Use a more generic method for all dep

Re: svn commit: r346554 - head/sys/netinet

2019-09-03 Thread Bruce Evans
On Mon, 22 Apr 2019, Bjoern A. Zeeb wrote: On 22 Apr 2019, at 14:20, Bjoern A. Zeeb wrote: Log: Remove some excessive brackets. No functional change. But it includes a stye bug; sorry; I had re-indented the lines to validate the change. Ill remedy this with the follow-up commit which w

svn commit: r346486 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 21 10:33:09 2019 New Revision: 346486 URL: https://svnweb.freebsd.org/changeset/base/346486 Log: Fix missing restoring of the mouse cursor position, the border color and the blank state after a screen switch. Modified: head/lib/libvgl/main.c head/lib/libvgl/mouse

svn commit: r346454 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sat Apr 20 20:29:03 2019 New Revision: 346454 URL: https://svnweb.freebsd.org/changeset/base/346454 Log: Make libvgl mostly work without superuser privilege in direct modes by not doing any unnecessary PIO instructions or refusing to start when the i/o privilege needed for

svn commit: r346488 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 21 16:17:35 2019 New Revision: 346488 URL: https://svnweb.freebsd.org/changeset/base/346488 Log: Use a shadow buffer and never read from the frame buffer. Remove large slow code for reading from the frame buffer. Reading from the frame buffer is usually much slo

Re: svn commit: r346176 - head/sys/sys

2019-09-03 Thread Bruce Evans
On Sat, 13 Apr 2019, Warner Losh wrote: Fix sbttons for values > 2s Add test against negative times. Add code to cope with larger values properly. Discussed with: bde@ (quite some time ago, for an earlier version) I am unhappy with previous attempted fixes in this area, and still have la

Re: svn commit: r346176 - head/sys/sys

2019-09-03 Thread Bruce Evans
On Sat, 13 Apr 2019, Bruce Evans wrote: On Sat, 13 Apr 2019, Warner Losh wrote: Fix sbttons for values > 2s Add test against negative times. Add code to cope with larger values properly. Discussed with: bde@ (quite some time ago, for an earlier version) I am unhappy with previ

svn commit: r346416 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Apr 19 20:29:49 2019 New Revision: 346416 URL: https://svnweb.freebsd.org/changeset/base/346416 Log: Fix copying of overlapping bitmaps. The cases of copying within the screen bitmap and within a single MEMBUF were broken when first source line is before the first dest

svn commit: r346279 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:41:45 2019 New Revision: 346279 URL: https://svnweb.freebsd.org/changeset/base/346279 Log: Oops, r346278 committed a test version with the change annulled. Modified: head/lib/libvgl/main.c Modified: head/lib/libvgl/main.c ==

svn commit: r346025 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 8 04:54:15 2019 New Revision: 346025 URL: https://svnweb.freebsd.org/changeset/base/346025 Log: Fix copying of MEMBUFs to MEMBUFs. This case was implemented by using the same code as the VIDBUF8 case, so it only worked for depths <= 8. The 2 directions for copying

svn commit: r346280 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:52:04 2019 New Revision: 346280 URL: https://svnweb.freebsd.org/changeset/base/346280 Log: Sigh, r346279 was also a test version with the reduced size doubled (so it was actually double the full size in current kernels where the reduction is null, so overran t

svn commit: r346278 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:31:23 2019 New Revision: 346278 URL: https://svnweb.freebsd.org/changeset/base/346278 Log: Quick fix for slow clearing and context switches of large frame buffers with old kernels, by breaking the support for large frame buffers in the same way as for current

svn commit: r346276 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 14:28:33 2019 New Revision: 346276 URL: https://svnweb.freebsd.org/changeset/base/346276 Log: Fix a variable name in r346215. Clearing of the right of the screen was broken, except it worked accidentally in most cases where the virtual screen is larger than the

svn commit: r346024 - head/usr.sbin/vidcontrol

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 8 04:07:37 2019 New Revision: 346024 URL: https://svnweb.freebsd.org/changeset/base/346024 Log: Fix restoring the geometry when recovering from an error. Just restore the previous geometry, and don't do extra work to calculate the default geometry so as to reset t

svn commit: r346215 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 14 13:37:50 2019 New Revision: 346215 URL: https://svnweb.freebsd.org/changeset/base/346215 Log: For writing and reading single pixels, avoid some pessimizations for depths > 8. Add some smaller optimizations for these depths. Use a more generic method for all dep

Re: svn commit: r346176 - head/sys/sys

2019-09-03 Thread Bruce Evans
On Sat, 13 Apr 2019, Bruce Evans wrote: On Sat, 13 Apr 2019, Warner Losh wrote: Fix sbttons for values > 2s Add test against negative times. Add code to cope with larger values properly. Discussed with: bde@ (quite some time ago, for an earlier version) I am unhappy with previ

Re: svn commit: r346176 - head/sys/sys

2019-09-03 Thread Bruce Evans
On Sat, 13 Apr 2019, Warner Losh wrote: Fix sbttons for values > 2s Add test against negative times. Add code to cope with larger values properly. Discussed with: bde@ (quite some time ago, for an earlier version) I am unhappy with previous attempted fixes in this area, and still have la

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Bruce Evans
On Fri, 5 Apr 2019, Ed Maste wrote: On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: +static const u_char dot_name[] = { + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; +static const u_char dotdot_name[] = { + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; + Does it make s

svn commit: r346025 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 8 04:54:15 2019 New Revision: 346025 URL: https://svnweb.freebsd.org/changeset/base/346025 Log: Fix copying of MEMBUFs to MEMBUFs. This case was implemented by using the same code as the VIDBUF8 case, so it only worked for depths <= 8. The 2 directions for copying

Re: svn commit: r345853 - head/usr.bin/rctl

2019-09-03 Thread Bruce Evans
On Wed, 3 Apr 2019, Enji Cooper wrote: On Apr 3, 2019, at 1:37 PM, Mateusz Guzik wrote: Author: mjg Date: Wed Apr 3 20:37:14 2019 New Revision: 345853 URL: https://svnweb.freebsd.org/changeset/base/345853 Log: rctl: fix sysctl kern.racct.enable use after r341182 The value was changed from

svn commit: r346024 - head/usr.sbin/vidcontrol

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 8 04:07:37 2019 New Revision: 346024 URL: https://svnweb.freebsd.org/changeset/base/346024 Log: Fix restoring the geometry when recovering from an error. Just restore the previous geometry, and don't do extra work to calculate the default geometry so as to reset t

Re: svn commit: r345807 - head/usr.bin/top

2019-09-03 Thread Bruce Evans
On Tue, 2 Apr 2019, Dimitry Andric wrote: Author: dim Date: Tue Apr 2 18:01:54 2019 New Revision: 345807 URL: https://svnweb.freebsd.org/changeset/base/345807 Log: Fix regression in top(1) after r344381, causing informational messages to no longer be displayed. This was because the reimplem

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Bruce Evans
On Fri, 5 Apr 2019, Ed Maste wrote: On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: +static const u_char dot_name[] = { + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; +static const u_char dotdot_name[] = { + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; + Does it make s

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sun, 31 Mar 2019, Konstantin Belousov wrote: On Sun, Mar 31, 2019 at 10:27:54PM +1100, Bruce Evans wrote: On Sat, 30 Mar 2019, Konstantin Belousov wrote: On Sat, Mar 30, 2019 at 03:24:40PM +1100, Bruce Evans wrote: On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at

Re: svn commit: r345853 - head/usr.bin/rctl

2019-09-03 Thread Bruce Evans
On Wed, 3 Apr 2019, Enji Cooper wrote: On Apr 3, 2019, at 1:37 PM, Mateusz Guzik wrote: Author: mjg Date: Wed Apr 3 20:37:14 2019 New Revision: 345853 URL: https://svnweb.freebsd.org/changeset/base/345853 Log: rctl: fix sysctl kern.racct.enable use after r341182 The value was changed from

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sun, 31 Mar 2019, Konstantin Belousov wrote: On Mon, Apr 01, 2019 at 12:04:45AM +1100, Bruce Evans wrote: Serial consoles are not always available. Better debuggers switch the screen mode as necessary. I recently noticed another mode switching problem. On i386, cycling through about 50

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sat, 30 Mar 2019, Konstantin Belousov wrote: On Sat, Mar 30, 2019 at 03:24:40PM +1100, Bruce Evans wrote: On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at 03:57:09PM +, Bruce Evans wrote: Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL

Re: svn commit: r345807 - head/usr.bin/top

2019-09-03 Thread Bruce Evans
On Tue, 2 Apr 2019, Dimitry Andric wrote: Author: dim Date: Tue Apr 2 18:01:54 2019 New Revision: 345807 URL: https://svnweb.freebsd.org/changeset/base/345807 Log: Fix regression in top(1) after r344381, causing informational messages to no longer be displayed. This was because the reimplem

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at 03:57:09PM +, Bruce Evans wrote: Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL: https://svnweb.freebsd.org/changeset/base/345696 Log: Fix endless loops for handling SIGBUS and SIGSEGV

svn commit: r345695 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 15:20:48 2019 New Revision: 345695 URL: https://svnweb.freebsd.org/changeset/base/345695 Log: Fix races in mouse signal handling almost properly using the INTOFF/INTON method as in /bin/sh. We still do technically undefined things in the signal handler, but it

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sun, 31 Mar 2019, Konstantin Belousov wrote: On Sun, Mar 31, 2019 at 10:27:54PM +1100, Bruce Evans wrote: On Sat, 30 Mar 2019, Konstantin Belousov wrote: On Sat, Mar 30, 2019 at 03:24:40PM +1100, Bruce Evans wrote: On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at

Re: svn commit: r345680 - head/sys/conf

2019-09-03 Thread Bruce Evans
On Thu, 28 Mar 2019, Ravi Pokala wrote: -Original Message- From: on behalf of Kyle Evans Date: 2019-03-28, Thursday at 21:00 To: , , Subject: svn commit: r345680 - head/sys/conf Author: kevans Date: Fri Mar 29 04:00:46 2019 New Revision: 345680 URL: https://svnweb.freebsd.org/chan

Re: svn commit: r345680 - head/sys/conf

2019-09-03 Thread Bruce Evans
On Fri, 29 Mar 2019, Alexey Dokuchaev wrote: On Fri, Mar 29, 2019 at 05:40:05PM +1100, Bruce Evans wrote: ... -optionsBOOT_TAG=\"---<>---\" +optionsBOOT_TAG=\"\" Useful variations are not always easy to invent. I usually just add 1 for numeric value

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sun, 31 Mar 2019, Konstantin Belousov wrote: On Mon, Apr 01, 2019 at 12:04:45AM +1100, Bruce Evans wrote: Serial consoles are not always available. Better debuggers switch the screen mode as necessary. I recently noticed another mode switching problem. On i386, cycling through about 50

svn commit: r345698 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 16:30:19 2019 New Revision: 345698 URL: https://svnweb.freebsd.org/changeset/base/345698 Log: Fix restoring to graphics modes in VGLEnd(). Correct restoring was only attempted for mode 258 (800x600x4 P). (This was the only useful graphics mode supported in th

svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL: https://svnweb.freebsd.org/changeset/base/345696 Log: Fix endless loops for handling SIGBUS and SIGSEGV. r80270 has the usual wrong fix for unsafe signal handling -- just set a flag and return to let an event loop check

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sat, 30 Mar 2019, Konstantin Belousov wrote: On Sat, Mar 30, 2019 at 03:24:40PM +1100, Bruce Evans wrote: On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at 03:57:09PM +, Bruce Evans wrote: Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL

svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL: https://svnweb.freebsd.org/changeset/base/345696 Log: Fix endless loops for handling SIGBUS and SIGSEGV. r80270 has the usual wrong fix for unsafe signal handling -- just set a flag and return to let an event loop check

svn commit: r345698 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 16:30:19 2019 New Revision: 345698 URL: https://svnweb.freebsd.org/changeset/base/345698 Log: Fix restoring to graphics modes in VGLEnd(). Correct restoring was only attempted for mode 258 (800x600x4 P). (This was the only useful graphics mode supported in th

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at 03:57:09PM +, Bruce Evans wrote: Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL: https://svnweb.freebsd.org/changeset/base/345696 Log: Fix endless loops for handling SIGBUS and SIGSEGV

svn commit: r345695 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 15:20:48 2019 New Revision: 345695 URL: https://svnweb.freebsd.org/changeset/base/345695 Log: Fix races in mouse signal handling almost properly using the INTOFF/INTON method as in /bin/sh. We still do technically undefined things in the signal handler, but it

Re: svn commit: r345680 - head/sys/conf

2019-09-03 Thread Bruce Evans
On Fri, 29 Mar 2019, Alexey Dokuchaev wrote: On Fri, Mar 29, 2019 at 05:40:05PM +1100, Bruce Evans wrote: ... -optionsBOOT_TAG=\"---<>---\" +optionsBOOT_TAG=\"\" Useful variations are not always easy to invent. I usually just add 1 for numeric value

Re: svn commit: r345680 - head/sys/conf

2019-09-03 Thread Bruce Evans
On Thu, 28 Mar 2019, Ravi Pokala wrote: -Original Message- From: on behalf of Kyle Evans Date: 2019-03-28, Thursday at 21:00 To: , , Subject: svn commit: r345680 - head/sys/conf Author: kevans Date: Fri Mar 29 04:00:46 2019 New Revision: 345680 URL: https://svnweb.freebsd.org/chan

svn commit: r345639 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 12:28:29 2019 New Revision: 345639 URL: https://svnweb.freebsd.org/changeset/base/345639 Log: Fix VGLGetXY(), VGLSetXY() and VGLClear() for MEMBUFs in depths > 8. This depends on PixelBytes being properly initialized, which it is for all bitmaps constructed by

svn commit: r345637 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 09:51:37 2019 New Revision: 345637 URL: https://svnweb.freebsd.org/changeset/base/345637 Log: Oops, r345496 got the pointer args backwards for bcopy() in VGLClear for segmented modes. Also fix some style bugs in the 2 changed lines. libvgl uses a very non-KNF

svn commit: r345643 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 14:21:22 2019 New Revision: 345643 URL: https://svnweb.freebsd.org/changeset/base/345643 Log: Fix VGLLine() in depths > 8. It started truncating its color arg to 8 bits using plot() in r229415. The version in r229415 is also more than 3 times slower in segment

svn commit: r345639 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 12:28:29 2019 New Revision: 345639 URL: https://svnweb.freebsd.org/changeset/base/345639 Log: Fix VGLGetXY(), VGLSetXY() and VGLClear() for MEMBUFs in depths > 8. This depends on PixelBytes being properly initialized, which it is for all bitmaps constructed by

svn commit: r345643 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 14:21:22 2019 New Revision: 345643 URL: https://svnweb.freebsd.org/changeset/base/345643 Log: Fix VGLLine() in depths > 8. It started truncating its color arg to 8 bits using plot() in r229415. The version in r229415 is also more than 3 times slower in segment

svn commit: r345637 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 09:51:37 2019 New Revision: 345637 URL: https://svnweb.freebsd.org/changeset/base/345637 Log: Oops, r345496 got the pointer args backwards for bcopy() in VGLClear for segmented modes. Also fix some style bugs in the 2 changed lines. libvgl uses a very non-KNF

svn commit: r345585 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Mar 27 18:03:34 2019 New Revision: 345585 URL: https://svnweb.freebsd.org/changeset/base/345585 Log: Fix accessing pixels under the mouse cursor: Reading of single pixels didn't look under the cursor. Copying of 1x1 bitmaps didn't look under the cursor for either

svn commit: r345585 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Mar 27 18:03:34 2019 New Revision: 345585 URL: https://svnweb.freebsd.org/changeset/base/345585 Log: Fix accessing pixels under the mouse cursor: Reading of single pixels didn't look under the cursor. Copying of 1x1 bitmaps didn't look under the cursor for either

Re: [Bug 235031] [em] em0: poor NFS performance, strange behavior

2019-08-31 Thread Bruce Evans
On Thu, 15 Aug 2019 a bug that doesn't want repl...@freebsd.org wrote: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235031 --- Comment #36 from Martin Birgmeier --- I just notice that the console and syslog have about 20 messages of em: frame error: ignored em: frame error: ignored em: f

Re: svn commit: r351319 - in head/usr.sbin/makefs: ffs msdos

2019-08-29 Thread Bruce Evans
On Wed, 21 Aug 2019, Ed Maste wrote: Author: emaste Date: Wed Aug 21 01:45:29 2019 New Revision: 351319 URL: https://svnweb.freebsd.org/changeset/base/351319 Log: makefs: use `char *` not `void *` for buf b_data, drop casts in msdos (The kernel uses caddr_t.) This is much better than churn

Re: svn commit: r351319 - in head/usr.sbin/makefs: ffs msdos

2019-08-29 Thread Bruce Evans
On Wed, 21 Aug 2019, Ed Maste wrote: Author: emaste Date: Wed Aug 21 01:45:29 2019 New Revision: 351319 URL: https://svnweb.freebsd.org/changeset/base/351319 Log: makefs: use `char *` not `void *` for buf b_data, drop casts in msdos (The kernel uses caddr_t.) This is much better than churn

Re: FreeBSD Security Advisory FreeBSD-SA-19:23.midi

2019-08-29 Thread Bruce Evans
On Wed, 21 Aug 2019, Eugene Grosbein wrote: 21.08.2019 3:12, FreeBSD Security Advisories wrote: [skip] IV. Workaround No workaround is available. Custom kernels without "device sound" are not vulnerable. Is it true that there is no way to disable vulnerable and unneeded device driver bui

Re: [Bug 240121] Serial console can eat a lot of CPU with low baudrate

2019-08-29 Thread Bruce Evans
On Mon, 26 Aug 2019 a bug that doesn't want repl...@freebsd.org wrote: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240121 That effect is unexpected to me. I would expect opposite -- reduction of wait time, since code reduces number of buffer flushes and utilizes hardware FIFO. I may need

Re: svn commit: r350713 - head/sys/kern

2019-08-08 Thread Bruce Evans
On Thu, 8 Aug 2019, Conrad Meyer wrote: Log: ddb(4): Add 'sysctl' command Implement `sysctl` in `ddb` by overriding `SYSCTL_OUT`. When handling the req, we install custom ddb in/out handlers. The out handler prints straight to the debugger, while the in handler ignores all input. This is

Re: svn commit: r350713 - head/sys/kern

2019-08-08 Thread Bruce Evans
On Thu, 8 Aug 2019, Conrad Meyer wrote: Log: ddb(4): Add 'sysctl' command Implement `sysctl` in `ddb` by overriding `SYSCTL_OUT`. When handling the req, we install custom ddb in/out handlers. The out handler prints straight to the debugger, while the in handler ignores all input. This is

Re: svn commit: r350532 - head/sys/netinet6

2019-08-02 Thread Bruce Evans
On Fri, 2 Aug 2019, Bjoern A. Zeeb wrote: Log: frag6.c: sort includes Sort includes and remove duplicate kernel.h as well as the unneeded systm.h. sys/systm.h is always needed, since it defines macros and functions which might be needed in other headers. frag6.c even uses KASSERT() direct

Re: svn commit: r350532 - head/sys/netinet6

2019-08-02 Thread Bruce Evans
On Fri, 2 Aug 2019, Bjoern A. Zeeb wrote: Log: frag6.c: sort includes Sort includes and remove duplicate kernel.h as well as the unneeded systm.h. sys/systm.h is always needed, since it defines macros and functions which might be needed in other headers. frag6.c even uses KASSERT() direct

Re: svn commit: r350179 - head/lib/libutil

2019-07-20 Thread Bruce Evans
On Sat, 20 Jul 2019, John Baldwin wrote: Log: expand_number(3) parses suffixes, not prefixes. This is not quite correct, although conflating prefixes and suffixes is one of the bugs that I pointed out in mails about [de]humanize_number and expand_number() long ago. Bugs in expand_number() st

Re: svn commit: r350179 - head/lib/libutil

2019-07-20 Thread Bruce Evans
On Sat, 20 Jul 2019, John Baldwin wrote: Log: expand_number(3) parses suffixes, not prefixes. This is not quite correct, although conflating prefixes and suffixes is one of the bugs that I pointed out in mails about [de]humanize_number and expand_number() long ago. Bugs in expand_number() st

Re: svn commit: r349391 - head/sys/kern

2019-07-17 Thread Bruce Evans
On Tue, 16 Jul 2019, Alan Somers wrote: On Tue, Jul 16, 2019 at 3:48 AM Bruce Evans wrote: On Mon, 15 Jul 2019, John Baldwin wrote: ... I'm not sure which variants are most readable: ... C) if (fp->f_seqcount + howmany(resid, 16384) < fp->f_seqcount)

  1   2   3   4   5   6   7   8   9   10   >