Re: [PATCH] ltmain.sh: allow more flags at link-time

2024-09-24 Thread Alan Modra
#x27; of libtool into sync with > >> upstream libtool commit 22a7e547e9857fc94fe5bc7c921d9a4b49c09f8e. Looks OK to me, thanks. -- Alan Modra

Re: Why is 32-bit objdump not able to read 64-bit executable?

2024-04-16 Thread Alan Modra
On Thu, Apr 11, 2024 at 04:32:31AM +0200, oset wrote: > Why is 32-bit objdump not able to read 64-bit executable? It can, if you configure bfd with the targets you require. If you don't select a 64-bit target the you need to use --enable-64-bit-bfd. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH 0/2] mmap: Avoid the sanitizer configure check failure

2024-04-09 Thread Alan Modra
f course is to update autotools to something more recent. -- Alan Modra Australia Development Lab, IBM

Re: CREL relocation format for ELF (was: RELLEB)

2024-03-28 Thread Alan Modra via Gcc
Your thoughts on RELLEB are welcome! Does anyone really care about relocatable object file size? If they do, wouldn't they be better off using a compressed file system? -- Alan Modra Australia Development Lab, IBM

Re: integer overflow vulnerability in strings

2024-03-06 Thread Alan Modra
cgi?id=30598 which were fixed in June 2023. $ binutils/strings -n 4294967295 /usr/bin/strings binutils/strings: minimum string length 4294967295 is too big -- Alan Modra Australia Development Lab, IBM

[Desktop-packages] [Bug 2011244] Re: emacs launching in GNOME is all messed up

2024-02-19 Thread Alan Modra
I see this on both 23.04 and 23.10, around 10% of the time emacs launches from a shell, and with emacs -Q too. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/2011244 Title: emacs

[Bug 2011244] Re: emacs launching in GNOME is all messed up

2024-02-19 Thread Alan Modra
I see this on both 23.04 and 23.10, around 10% of the time emacs launches from a shell, and with emacs -Q too. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/2011244 Title: ema

Re: bfd_find_nearest_line() leaks memory due to dwarf_rnglists_buffer never being freed

2023-12-10 Thread Alan Modra
->dwarf_str_buffer); >free (file->dwarf_ranges_buffer); > + free (file->dwarf_rnglists_buffer); >free (file->dwarf_line_buffer); >free (file->dwarf_abbrev_buffer); >free (file->dwarf_info_buffer); Thanks, I've committed this patch to c

Re: Parse out the function address wrong in `nm` version 3.40

2023-07-27 Thread Alan Modra
other files, but only this one trigger this thing. See the ARM EABI documents. Thumb function symbols are marked by setting the low bit of their value. -- Alan Modra Australia Development Lab, IBM

[Touch-packages] [Bug 2023437]

2023-06-21 Thread Alan Modra
Should now be fixed. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to binutils in Ubuntu. https://bugs.launchpad.net/bugs/2023437 Title: ppc64el gold linker produces unusable clang-16 binary Status in binutils: Fix Releas

[Touch-packages] [Bug 2023437]

2023-06-21 Thread Alan Modra
I've been going down the wrong rabbit hole, I should have asked you at the outset to post the result of your g++ command with -v added. That would have shown your compiler is defaulting to PIEs while mine is not. Adding -pie to the gold command line shows a huge number of relative dynamic relocati

[Touch-packages] [Bug 2023437]

2023-06-16 Thread Alan Modra
Linking with your .so files still doesn't give me any difference between gold-2.39 and gold mainline. I'm using my crt*.o, libc_nonshared.a, libgcc.a. From ld -t output it seems nothing from libc_nonshared.a or libgcc.a is extracted, so the only real difference ought to be crt1.o, crti.o, crtn.o,

[Touch-packages] [Bug 2023437]

2023-06-14 Thread Alan Modra
When I build clang-16 from your object files (plus my system libraries and startup files) for powerpc64le using gold 2.40.50.20230614 I get exactly the same binary as when using gold 2.39.0.20230101. That's comparing gold from the tip of master and binutils-2_39-branch in sourceware.org/git/binuti

Re: [RFC,patch] Linker plugin - extend API for offloading corner case (aka: LDPT_REGISTER_CLAIM_FILE_HOOK_V2 linker plugin hook [GCC PR109128])

2023-05-10 Thread Alan Modra via Gcc-patches
le to restore the state of symbols to what they would be without that object. (Yes, we do that sort of thing for as-needed shared libraries, but the restoration happens immediately after adding the symbols. I also regret implementing it the way I did.) The patch posted is OK from the linker side o

Re: [binutils] error in readelf when trying to search for missing section header table

2023-05-08 Thread Alan Modra
This was fixed with commit 907b52f4ceb6 2022-10-03. -- Alan Modra Australia Development Lab, IBM

Re: bfd.h fails to compile on FreeBSD: error: unknown type name 'ENUM_BITFIELD'

2023-02-28 Thread Alan Modra
On Tue, Feb 28, 2023 at 09:07:17AM -0800, Yuri wrote: > On 2/28/23 01:39, Alan Modra wrote: > > include/ansidecl.h is in the binutils sources. > > Ok, I see that include/ansidecl.h is not installed by binutils. It is installed for me. With default configure and current mainline:

Re: bfd.h fails to compile on FreeBSD: error: unknown type name 'ENUM_BITFIELD'

2023-02-28 Thread Alan Modra
On Tue, Feb 28, 2023 at 01:23:25AM -0800, Yuri wrote: > On 2/28/23 01:14, Nick Clifton wrote: > > Hi Yuri, > > > > > Where is ENUM_BITFIELD expected to come from? > > > > /usr/include/anisdecl.h > > > There's no such file on FreeBSD. includ

Re: Overloading ld linker script is not working after 2_36

2023-02-14 Thread Alan Modra
INFOA" and similarly for the other output sections in your extra script. By specifying the input sections these will match your output section before orphan sections are handled. This modification should work with older linkers too. 2) Add INSERT BEFORE .infoA; at the end of your extra script. -- Alan Modra Australia Development Lab, IBM

Re: [RFC][top-level] Add configure test-case

2022-11-07 Thread Alan Modra via Gcc
On Mon, Nov 07, 2022 at 06:23:45PM +, Joseph Myers wrote: > On Mon, 7 Nov 2022, Alan Modra via Binutils wrote: > > > a) that top-level binutils/gdb patches don't get applied to the gcc > >git repository in a timely manner, or > > If a toplevel patch is appr

Re: A heap buffer overflow bug in binutils-2.39

2022-10-30 Thread Alan Modra
124013.html -- Alan Modra Australia Development Lab, IBM

Re: Report a bug of binutils-2.38

2022-09-30 Thread Alan Modra
On Fri, Sep 30, 2022 at 09:52:41PM +0800, bjchan9an wrote: > There is an uncontrolled stack recursion vulnerability in binutils-2.38 Sorry, fuzzing reports against anything but current mainline will be ignored. -- Alan Modra Australia Development Lab, IBM

Re: Number of bfd_count_sections changes during bfd_simple_get_relocated_section_contents

2022-07-13 Thread Alan Modra
mbols in order to apply relocations. If a symbol with a section of SHN_COMMON is seen, a per-file COMMON section will be created. Hmm, I suppose you could argue that since this is done for the linker, there is no need to do so for simple_get_relocated_section_contents. -- Alan Modra Australia Development Lab, IBM

Re: 2.39 Release Schedule

2022-06-27 Thread Alan Modra
sables the warnings by default since it needs an # executable stack to support older kernels and an RWX segment to -# support its PLT. -if { [istarget "hppa*-*-*"] } { +# support its PLT. MIPS also turns off exec stack warnings. +if { [istarget "hppa*-*-*"] || [istarget mips*-*-*] } { set extra_link_opts "--warn-execstack --warn-rwx-segments" } else { set extra_link_opts "" -- Alan Modra Australia Development Lab, IBM

Correct spelling of DW_AT_namelist_item

2022-05-31 Thread Alan Modra via Gcc-patches
(DW_AT_namelist_items, 0x44) +DW_AT (DW_AT_namelist_item, 0x44) DW_AT (DW_AT_priority, 0x45) DW_AT (DW_AT_segment, 0x46) DW_AT (DW_AT_specification, 0x47) -- Alan Modra Australia Development Lab, IBM

Re: binutils as sparc/setx issue

2022-05-25 Thread Alan Modra
ze_setx being converted in tc_gen_reloc. That's not the only problem. The relocs emitted in synthetize_setx will cause text relocations in a dynamic library or PIE. So it looks to me that setx with a non-constant value when PIC is simply unsupported. I'd encourage you to post a patch to binut...@sourceware.org fixing the problem, or at least emitting an error rather than bad code. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH] libiberty: remove FINAL and OVERRIDE from ansidecl.h

2022-05-24 Thread Alan Modra via Gcc-patches
On Mon, May 23, 2022 at 07:42:29PM -0400, David Malcolm via Binutils wrote: > Any objections, or is there a reason to keep these macros that I'm > not aware of? (and did I send this to all the pertinent lists?) No objection from me. These macros are not used anywhere in binutils-gdb

Re: [PATCH] powerpc/vdso: Fix incorrect CFI in gettimeofday.S

2022-05-18 Thread Alan Modra
> It seemed clearer to just set the offset back to 0, which is what it is > at the start of the function. Yes. In detail, both .cfi_def_cfa_offset and .cfi_adjust_cfa_offset are interpreteted by the assembler into DW_CFA_def_cfa_offset byte codes, so you should get the same .eh_frame contents if using Naveen's suggestion. It boils down to style really, and the most common style is to use ".cfi_def_cfa_offset 0" here. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH] libiberty: stop using PTR macro.

2022-05-10 Thread Alan Modra via Gcc-patches
*)); >else > -nentries = (PTR *) (*htab->alloc_f) (nsize, sizeof (PTR *)); > +nentries = (void **) (*htab->alloc_f) (nsize, sizeof (void **)); >if (nentries == NULL) > return 0; >htab->entries = nentries; Here too. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH] Remove non-ANSI C macros in ansidecl.h.

2022-05-10 Thread Alan Modra via Gcc-patches
ere are occurrences of PTR in the cgen generated parts of opcodes, sim, and even gdb. I have a few patches I haven't yet committed. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH] powerpc/vdso: Fix incorrect CFI in gettimeofday.S

2022-05-02 Thread Alan Modra
e codes in .eh_frame. > Alan proposed a larger patch that changed to a single stack frame, but it > needs changes to > take into account the red zone. Yes, now that you mention it, I see the obvious error in the patch I wrote. I did say it was untested! -- Alan Modra Australia Development Lab, IBM

[Touch-packages] [Bug 1958389]

2022-02-09 Thread Alan Modra
Fixed mainline and 2.38 branch -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to binutils in Ubuntu. https://bugs.launchpad.net/bugs/1958389 Title: Jammy builds of xen segfault, but only on launchpad x86 builders Status in b

[Bug 1958389]

2022-02-09 Thread Alan Modra
Fixed mainline and 2.38 branch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1958389 Title: Jammy builds of xen segfault, but only on launchpad x86 builders To manage notifications about this bug g

[Touch-packages] [Bug 1958389]

2022-01-28 Thread Alan Modra
Created attachment 13937 Likely fix >From the backtrace in https://bugs.debian.org/1004269 it is clear that the problem is triggered by commit e86fc4a5bc37 in which a new extrap field was added to coffcode.h combined_entry_type but is not used on anything except rs6000 coff targets. -- You recei

[Touch-packages] [Bug 1958389]

2022-01-28 Thread Alan Modra
HJ, you likely can reproduce the failue with an asan build of binutils, or using MALLOC_PERTURB_. I haven't tested the patch yet. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to binutils in Ubuntu. https://bugs.launchpad.net/

[Bug 1958389]

2022-01-28 Thread Alan Modra
HJ, you likely can reproduce the failue with an asan build of binutils, or using MALLOC_PERTURB_. I haven't tested the patch yet. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1958389 Title: Jammy

[Bug 1958389]

2022-01-28 Thread Alan Modra
Created attachment 13937 Likely fix From the backtrace in https://bugs.debian.org/1004269 it is clear that the problem is triggered by commit e86fc4a5bc37 in which a new extrap field was added to coffcode.h combined_entry_type but is not used on anything except rs6000 coff targets. -- You receiv

Re: Errors in binutils man pages

2021-12-20 Thread Alan Modra
[d|i|l|e|x|h]} @itemx --unicode=@var{[default|invalid|locale|escape|hex|highlight]} -Controls the display of UTF-8 encoded mulibyte characters in strings. +Controls the display of UTF-8 encoded multibyte characters in strings. The default (@option{--unicode=default}) is to give them no special treatment, and instead rely upon the setting of the @option{--encoding} option. The other values for this option -- Alan Modra Australia Development Lab, IBM

Re: nm/objdump --hep still display unsupported styles about --demangle.

2021-12-10 Thread Alan Modra
0d64622696e02 nm now shows -C, --demangle[=STYLE] Decode mangled/processed symbol names STYLE can be "none", "auto", "gnu-v3", "java", "gnat", "dlang", "rust" -- Alan Modra Australia Development Lab, IBM

Make opcodes configure depend on bfd configure

2021-11-12 Thread Alan Modra via Gcc-patches
stageautoprofile-bfd +configure-stageautofeedback-opcodes: configure-stageautofeedback-bfd install-opcodes: maybe-install-bfd install-strip-opcodes: maybe-install-strip-bfd configure-gas: maybe-configure-intl -- Alan Modra Australia Development Lab, IBM

Re: [PATCH] fix prototype and definition of yyerror in *.y

2021-11-06 Thread Alan Modra
generates these prototypes. Thanks for the report and patch. I've extended your patch to other files too. https://sourceware.org/pipermail/binutils/2021-November/118441.html -- Alan Modra Australia Development Lab, IBM

Re: 回复:gas couldn't handle comments leaved by C preprocessor properly

2021-10-04 Thread Alan Modra
ort of binutils build problem, for example you might have a problem caused by system installed libbfd headers or shared library. That sort of thing has been reported by other people in the past. -- Alan Modra Australia Development Lab, IBM

Re: gas couldn't handle comments leaved by C preprocessor properly

2021-10-03 Thread Alan Modra
I modified > input-file.c, and I successfully solved the problem. The problem with this patch is that ungetc is only guaranteed to work for *one* character. Also, since f_in might be a pipe you can't rewind. -- Alan Modra Australia Development Lab, IBM

obstack.h __PTR_ALIGN vs. ubsan

2021-09-01 Thread Alan Modra via Gcc-patches
A))) #ifndef __attribute_pure__ # if defined __GNUC_MINOR__ && __GNUC__ * 1000 + __GNUC_MINOR__ >= 2096 -- Alan Modra Australia Development Lab, IBM

Re: crosscompilation of the kernel for MIPS fails with binutils-2_37

2021-08-17 Thread Alan Modra
On Tue, Aug 17, 2021 at 12:14:46PM +0100, Sudip Mukherjee wrote: > arch/mips/dec/prom/locore.S:29: Error: opcode not supported on this > processor: r4600 (mips3) `rfe' Answered in pr28241. -- Alan Modra Australia Development Lab, IBM

Re: Report UBSan integer overflow bugs found by automatic tools

2021-07-29 Thread Alan Modra
Not a bug. ../../binutils/readelf.c:5586:28: runtime error: unsigned integer overflow: 18446744073178963944 + 536870912 cannot be represented in type 'unsigned long' Not a bug. ../../binutils/readelf.c:9312:17: runtime error: unsigned integer overflow: 18446744073709421054 + 4294967299 cannot be represented in type 'unsigned long' Not a bug. I'll be committing a few fixes for the real bugs you found. -- Alan Modra Australia Development Lab, IBM

Re: Report UBSan integer overflow bugs found by automatic tools

2021-07-29 Thread Alan Modra
ivered to anyone. I see all of these reports are unsigned integer overflow, which is an odd thing for ubsan to complain about. Overflow of unsigned integers is not undefined behaviour! -- Alan Modra Australia Development Lab, IBM

Re: [POWER10] __morestack calls from pcrel code

2021-07-21 Thread Alan Modra via Gcc-patches
On Wed, Jul 21, 2021 at 08:59:04AM -0400, David Edelsohn wrote: > On Wed, Jul 21, 2021 at 4:29 AM Alan Modra wrote: > > > > On Wed, Jul 14, 2021 at 08:24:16PM -0400, David Edelsohn wrote: > > > > > > * config/rs6000/morestack.S (R2_SAVE): Define. > &

Re: [PATCH 2/4 REVIEW] libtool.m4: fix nm BSD flag detection

2021-07-21 Thread Alan Modra via Gcc-patches
www.gnu.org/software/libtool/ > > I considered this, but there is *serious* divergence between the > libtool.m4 in our tree and upstream. Fixing this divergence looks to be > a fairly major project in and of itself :( the last real sync looked > like being all the way back in 2008. Ye

Re: [PATCH] Change undefined "uint" to "unsigned"

2021-07-19 Thread Alan Modra
On Sun, Jul 18, 2021 at 04:57:19PM -0400, Christopher Wellons wrote: > This fixes a defect introduced in 25162c795. The "uint" type has not > been explicitly defined here, causing compilation to fail. Thanks, I pushed this to the 2.37 branch, commit 999566402e. -- Alan

Re: [POWER10] __morestack calls from pcrel code

2021-07-14 Thread Alan Modra via Gcc-patches
On Wed, Jun 30, 2021 at 05:06:30PM -0300, Tulio Magno Quites Machado Filho wrote: > Alan Modra via Gcc-patches writes: > > > Compiling gcc/testsuite/gcc.dg/split-*.c and others with -mcpu=power10 > > and linking with a non-pcrel libgcc results in crashes due to the > >

Re: [RS6000] Adjust testcases for power10 instructions

2021-07-01 Thread Alan Modra via Gcc-patches
On Thu, Jul 01, 2021 at 04:47:21PM -0500, Segher Boessenkool wrote: > Hi! > > On Thu, Jul 01, 2021 at 10:59:15PM +0930, Alan Modra wrote: > > * lib/target-supports.exp (check_effective_target_has_arch_pwr10): New. > > Mike added this already, please make sure to not

[RS6000] Adjust testcases for power10 instructions

2021-07-01 Thread Alan Modra via Gcc-patches
messages arch_pwr10 assembly { + #ifndef _ARCH_PWR10 + #error does not have power10 support. + #else + /* "has power10 support" */ + #endif + }] +} + # Return 1 if this is a PowerPC target supporting -mcpu=power10. # Limit this to 64-bit linux systems for now until other targets support # power10. -- Alan Modra Australia Development Lab, IBM

[POWER10] __morestack calls from pcrel code

2021-06-29 Thread Alan Modra via Gcc-patches
0 +#if _CALL_ELF == 2 + ld %r2,R2_SAVE(%r29) +#endif ld %r3,PARAMREG_SAVE+0(%r29) ld %r4,PARAMREG_SAVE+8(%r29) ld %r5,PARAMREG_SAVE+16(%r29) -- Alan Modra Australia Development Lab, IBM

[Touch-packages] [Bug 40214]

2021-06-03 Thread Alan Modra
Documented -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to binutils in Ubuntu. https://bugs.launchpad.net/bugs/40214 Title: ld checks for libs in wrong order. it should be inline with ld.so and check configured folders fi

[Bug 40214]

2021-06-03 Thread Alan Modra
Documented -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/40214 Title: ld checks for libs in wrong order. it should be inline with ld.so and check configured folders first. To manage notif

Re: PowerPC64 ELFv2 -fpatchable-function-entry

2021-05-19 Thread Alan Modra via Gcc-patches
to contribute new gcc work. This one was just flushing some patches that I wrote a while ago. -- Alan Modra Australia Development Lab, IBM

Re: PowerPC64 ELFv2 -fpatchable-function-entry

2021-05-18 Thread Alan Modra via Gcc-patches
On Mon, May 10, 2021 at 04:39:55PM -0500, Segher Boessenkool wrote: > Hi! > > On Fri, May 07, 2021 at 12:19:52PM +0930, Alan Modra wrote: > > PowerPC64 ELFv2 dual entry point functions have a couple of problems > > with -fpatchable-function-entry. One is that the nops added

Re: PowerPC64 ELFv1 -fpatchable-function-entry

2021-05-18 Thread Alan Modra via Gcc-patches
ultimate_transparent_alias_target (&id); - const char *name = IDENTIFIER_POINTER (id); - name = targetm.strip_name_encoding (name); - fprintf (asm_out_file, ",%s", name); + fprintf (asm_out_file, ","); + assemble_name_raw (asm_out_file, func_label); } if (HAVE_COMDAT_GROUP && (flags & SECTION_LINKONCE)) { -- Alan Modra Australia Development Lab, IBM

PowerPC64 ELFv2 -fpatchable-function-entry

2021-05-06 Thread Alan Modra via Gcc-patches
PowerPC64 ELFv2 dual entry point functions have a couple of problems with -fpatchable-function-entry. One is that the nops added after the global entry land in the global entry code which is constrained to be a power of two number of instructions, and zero global entry code has special meaning for

Revert "rs6000: Avoid -fpatchable-function-entry* regressions on powerpc64 be [PR98125]"

2021-05-06 Thread Alan Modra via Gcc-patches
This reverts commit b680b9049737198d010e49cf434704c6a6ed2b3f now that the PowerPC64 ELFv1 regression is fixed properly. PR testsuite/98125 * targhooks.h (default_print_patchable_function_entry_1): Delete. * targhooks.c (default_print_patchable_function_entry_1): Delete.

PowerPC64 ELFv1 -fpatchable-function-entry

2021-05-06 Thread Alan Modra via Gcc-patches
On PowerPC64 ELFv1 function symbols are defined on function descriptors in an .opd section rather than in the function code. .opd is not split up by the PowerPC64 backend for comdat groups or other situations where per-function sections are required. Thus SECTION_LINK_ORDER can't use the function

PR98125, PowerPC64 -fpatchable-function-entry

2021-05-06 Thread Alan Modra via Gcc-patches
on on both targets, libgo runtime/pprof. It's unclear to me what that means. Alan Modra (3): PowerPC64 ELFv1 -fpatchable-function-entry Revert "rs6000: Avoid -fpatchable-function-entry* regressions on powerpc64 be [PR98125]" PowerPC64 ELFv2 -fpatchable-function-entry gcc/con

Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure

2021-05-05 Thread Alan Modra via Gcc-patches
On Wed, May 05, 2021 at 08:05:29AM +0100, Iain Sandoe wrote: > Alan Modra via Gcc-patches wrote: > > > On 2021-05-04 8:42 a.m., Nick Clifton wrote: > > > Hi Guys, > > > > > > On 4/30/21 7:36 PM, Simon Marchi wrote: > > > > I think thi

Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure

2021-05-04 Thread Alan Modra via Gcc-patches
c/config/i386/i386.h @@ -73,8 +73,8 @@ struct stringop_algs { const enum stringop_alg unknown_size; const struct stringop_strategy { -const int max; -const enum stringop_alg alg; +int max; +enum stringop_alg alg; int noalign; } size [MAX_STRINGOP_ALGS]; }; -- Alan Mo

Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure

2021-05-03 Thread Alan Modra via Gcc-patches
less the C99 check at top-level somehow does not > play well with the C11 check in sim/? Like if that would cause CC to be > set to "gcc -std=gnu99 -std=gnu11" or something like that. > > Simon -- Alan Modra Australia Development Lab, IBM

Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure

2021-05-02 Thread Alan Modra via Gcc-patches
ial patch to make ppc-dis.c > compile again with C89, but if we're going to update configure.ac > appropriately, then it wouldn't be needed. Yes, I prefer the configure fix too. If we state we require C99 in binutils then we ought to be able to use C99.. Nick, does the configure.ac change also need to go in all subdirs, to support people running make in say ld/ rather than running make in the top build dir? -- Alan Modra Australia Development Lab, IBM

Re: Undefined use of weak symbols in gnulib

2021-05-02 Thread Alan Modra
ist or are both NULL. ppc gets that one wrong too. -- Alan Modra Australia Development Lab, IBM

Re: Error cross-compiling binutils-gdb for windows

2021-04-06 Thread Alan Modra
> int (64 bit integer) in the host platform (Windows), however, the function > os_time from the file sim/common/callback.c:414 (path relative to project > root), takes a long (32 bit integer) as a parameter: > > static longos_time (host_callback *p, long *t){ > return wrap (p, time (t)); > } > > How can I fix this error? > > > Stepan Klymonchuk -- Alan Modra Australia Development Lab, IBM

Re: PowerPC64 future proof kernel toc, revised for lld

2021-03-10 Thread Alan Modra
On Wed, Mar 10, 2021 at 01:44:57PM +0100, Christophe Leroy wrote: > > > Le 10/03/2021 à 13:25, Alan Modra a écrit : > > On Wed, Mar 10, 2021 at 08:33:37PM +1100, Alexey Kardashevskiy wrote: > > > One more question - the older version had a construct "DEFINED (.TOC.)

Re: PowerPC64 future proof kernel toc, revised for lld

2021-03-10 Thread Alan Modra
hen was it added? I have > the same check in SLOF, for example, do I still need it? .TOC. symbol support was first added 2012-11-06, so you need binutils-2.24 or later to use .TOC. as a symbol. -- Alan Modra Australia Development Lab, IBM

Re: PowerPC64 future proof kernel toc, revised for lld

2021-03-09 Thread Alan Modra
? No. "objdump -r prom_init.o | grep GOT" will tell you whether prom_init.o *may* cause ld to generate .got entries. (Linker optimisations or --gc-sections might remove the need for those .got entries.) > objdump: section '.got' mentioned in a -j option, but not found in any inpu

Re: PowerPC64 future proof kernel toc, revised for lld

2021-03-09 Thread Alan Modra
del=medium if you appropriately decorate variable declarations with non-default visibility. Signed-off-by: Alan Modra diff --git a/arch/powerpc/boot/crt0.S b/arch/powerpc/boot/crt0.S index 1d83966f5ef6..e45907fe468f 100644 --- a/arch/powerpc/boot/crt0.S +++ b/arch/powerpc/boot/crt0.S @@ -28,7 +28,7 @@ p

PowerPC64 future proof kernel toc, revised

2021-03-08 Thread Alan Modra
__prom_init_toc_start = .; - arch/powerpc/kernel/prom_init.o*(.toc .got) + arch/powerpc/kernel/prom_init.o*(.toc) __prom_init_toc_end = .; #endif - *(.got) *(.toc) } + __toc_ptr = DEFINED (.TOC.) ? .TOC. : ADDR (.got) + 0x8000; #endif /* The initial task and kernel stack */ -- Alan Modra Australia Development Lab, IBM

Re: binutils fails to compile on AIX due to mismatched declaration

2021-03-03 Thread Alan Modra
bfd *exec_bfd); char * rs6000coff_core_file_failing_command (bfd *abfd); -- Alan Modra Australia Development Lab, IBM

Re: [PATCH] Add -fgnu-retain/-fno-gnu-retain

2021-02-18 Thread Alan Modra via Gcc-patches
ollection. Surely you don't expect ".retain foo" to create a separate .data section for foo? If you do, I'm strongly against that idea. Note that gas indeed supports multiple sections named .data that can serve the same purpose as -fdata-sections. See the gas doc for the optional .section field "unique". That might be the best way to avoid an under-the-hood -ffunction-sections/-fdata-sections. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH 4/8] intl: turn LIBINTL into -L / -l form

2021-02-10 Thread Alan Modra via Gcc-patches
On Mon, Feb 08, 2021 at 11:16:31AM +, Nick Alcock via Binutils wrote: > intl/ChangeLog > 2021-02-04 Nick Alcock > > * configure.ac (LIBINTL): Transform into -L/-lintl form. > * configure: Regenerate. OK for binutils. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH 3/8] intl: always picify

2021-02-10 Thread Alan Modra via Gcc-patches
(COMPILE): Use it. > * configure: Regenerate. OK for binutils. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH, rs6000] Optimization for PowerPC 64bit constant generation [PR94395]

2021-02-02 Thread Alan Modra via Gcc-patches
;-mno-prefixed" { target { lp64 } } } */ in order to keep scan-assembler-times counts correct for power10. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH 5/8] [RS6000] rs6000_rtx_costs cost IOR

2021-01-31 Thread Alan Modra via Gcc-patches
On Mon, Jan 25, 2021 at 04:51:43PM -0600, Segher Boessenkool wrote: > Hi! > > On Thu, Oct 08, 2020 at 09:27:57AM +1030, Alan Modra wrote: > > * config/rs6000/rs6000.c (rotate_insert_cost): New function. > > (rs6000_rtx_costs): Cost IOR. > > > > diff --g

Re: [PATCH 3/8] [RS6000] rs6000_rtx_costs tidy AND

2021-01-31 Thread Alan Modra via Gcc-patches
onsistency I made the change in old code too. -- Alan Modra Australia Development Lab, IBM

Re: [RS6000] Adjust testcases for power10 instructions V3

2021-01-21 Thread Alan Modra via Gcc-patches
Ping. On Tue, Jan 12, 2021 at 02:03:18PM +1030, Alan Modra wrote: > Ping > https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557587.html > > On Fri, Oct 30, 2020 at 07:00:14PM +1030, Alan Modra wrote: > > And now waking up to what you meant by the lvsl-lvsr.c \s comment,

Re: [PATCH 8/8] [RS6000] rs6000_rtx_costs for !speed

2021-01-21 Thread Alan Modra via Gcc-patches
Ping. On Tue, Jan 12, 2021 at 02:02:36PM +1030, Alan Modra wrote: > Ping > https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555759.html > > On Thu, Oct 08, 2020 at 09:28:00AM +1030, Alan Modra wrote: > > When optimizing for size we shouldn't be using metrics bas

Re: [PATCH 7/8] [RS6000] rs6000_rtx_costs reduce cost for SETs

2021-01-21 Thread Alan Modra via Gcc-patches
Ping. On Tue, Jan 12, 2021 at 02:02:27PM +1030, Alan Modra wrote: > Ping > https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555758.html > > On Thu, Oct 08, 2020 at 09:27:59AM +1030, Alan Modra wrote: > > The aim of this patch is to make rtx_costs for SETs closer to >

Re: [PATCH 5/8] [RS6000] rs6000_rtx_costs cost IOR

2021-01-21 Thread Alan Modra via Gcc-patches
Ping. On Tue, Jan 12, 2021 at 02:02:18PM +1030, Alan Modra wrote: > Ping > https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555756.html > > On Thu, Oct 08, 2020 at 09:27:57AM +1030, Alan Modra wrote: > > * config/rs6000/rs6000.c (rotate_insert_c

Re: [PATCH 4/8] [RS6000] rs6000_rtx_costs tidy break/return

2021-01-21 Thread Alan Modra via Gcc-patches
Ping. On Tue, Jan 12, 2021 at 02:02:09PM +1030, Alan Modra wrote: > Ping > https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555755.html > > On Thu, Oct 08, 2020 at 09:27:56AM +1030, Alan Modra wrote: > > Most cases use "return false" rather than breaking out of

Re: [PATCH 3/8] [RS6000] rs6000_rtx_costs tidy AND

2021-01-21 Thread Alan Modra via Gcc-patches
Ping. On Tue, Jan 12, 2021 at 02:01:57PM +1030, Alan Modra wrote: > Ping > https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555754.html > > On Thu, Oct 08, 2020 at 09:27:55AM +1030, Alan Modra wrote: > > * config/rs6000/rs6000.c (rs6000_rtx_costs): Tidy AND code. &

Re: [PATCH] binuitils: Check if AR is usable for LTO build

2021-01-11 Thread Alan Modra via Gcc-patches
On Mon, Jan 11, 2021 at 02:52:43PM -0800, H.J. Lu wrote: > On Mon, Jan 11, 2021 at 1:20 PM Alan Modra wrote: > > > > On Mon, Jan 11, 2021 at 11:53:15AM -0800, H.J. Lu via Binutils wrote: > > > Check if AR is usable for LTO build with --enable-pgo-build=lto: > > >

Re: V2 [PATCH 1/2] GCC: Check if AR works with --plugin and rc

2021-01-11 Thread Alan Modra via Gcc-patches
On Mon, Jan 11, 2021 at 04:07:22PM -0800, H.J. Lu wrote: > These are not fatal errors. Here is the updated patch to use > AC_MSG_WARN instead. OK for master? OK by me. Please squash the two patches. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH 1/2] GCC: Check if AR works with --plugin and rc

2021-01-11 Thread Alan Modra via Gcc-patches
test -n "$plugin_option"; then >if $AR --help 2>&1 | grep -q "\--plugin"; then > -AR="$AR $plugin_option" > +touch conftest.c > +$AR $plugin_option rc conftest.a conftest.c > + if test "$?" != 0; then > + echo "Failed: $AR $plugin_option rc" AC_MSG_ERROR again. > +else > + AR="$AR $plugin_option" > +fi > +rm -f conftest.* >fi > fi > test -z "$AR_FLAGS" && AR_FLAGS=cru -- Alan Modra Australia Development Lab, IBM

Re: [PATCH 0/2] Check if AR works with --plugin and rc

2021-01-11 Thread Alan Modra via Gcc-patches
email. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH 0/8] [RS6000] rs6000_rtx_costs V2

2021-01-11 Thread Alan Modra via Gcc-patches
On Sat, Dec 05, 2020 at 07:42:07PM +1030, Alan Modra wrote: > Hi Segher, > I've been holding off pinging these knowing you had a lot of other > review work, but maybe that's settling down now? You already OK'd > 1/8, 2/8 and 6/8. Ping. > [PATCH 3/8] [RS6000] rs6

Re: [PATCH] binuitils: Check if AR is usable for LTO build

2021-01-11 Thread Alan Modra via Gcc-patches
n > RANLIB_PLUGIN_OPTION="$PLUGIN_OPTION" >fi > +else > + if test "$enable_pgo_build" != "no"; then > +AC_MSG_ERROR([AR with --plugin and rc is required for LTO build]) > + fi > fi > AC_SUBST(AR_PLUGIN_OPTION) > AC_SUBST(RANLIB_PLUGIN_OPTION) > -- > 2.29.2 -- Alan Modra Australia Development Lab, IBM

commit 5e531d391852 broke powerpc-eabivle

2021-01-06 Thread Alan Modra
powerpc-elf-lynxos5 powerpc-haiku powerpc-unknown-haiku -- Alan Modra Australia Development Lab, IBM

config.sub update broke powerpc-eabivle

2021-01-06 Thread Alan Modra
,7 @@ case $os in musl* | newlib* | uclibc*) ;; # Likewise for "kernel-libc" - eabi | eabihf | gnueabi | gnueabihf) + eabi* | gnueabi*) ;; # Now accept the basic system types. # The portable systems comes first. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH toplevel] libctf: new testsuite

2021-01-05 Thread Alan Modra via Gcc-patches
hanges too. I could fix that easily enough but I'm going to ask that you post a combined patch to bring the gcc repo up to date with any libctf changes. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH] arm64: link with -z norelro regardless of CONFIG_RELOCATABLE

2020-12-14 Thread Alan Modra
may have other unwanted effects. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH, powerpc] testsuite update tests for powerpc power10 target codegen.

2020-12-08 Thread Alan Modra via Gcc-patches
ore-builtin_vec_xst-longlong.c, due to -mdejagnu-cpu=power8 in that test meaning we don't see any power10 insns. -- Alan Modra Australia Development Lab, IBM

Re: testsuite: Adjust target requirements for sad-vectorize and signbit

2020-12-05 Thread Alan Modra via Gcc-patches
On Thu, Oct 29, 2020 at 10:10:58PM +1030, Alan Modra wrote: > Fixes > FAIL: gcc.target/powerpc/signbit-1.c scan-assembler-not stxvd2x > FAIL: gcc.target/powerpc/signbit-1.c scan-assembler-times mfvsrd 3 > FAIL: gcc.target/powerpc/signbit-1.c scan-assembler-times srdi 3 > FAIL: gcc

Re: [PATCH 0/8] [RS6000] rs6000_rtx_costs V2

2020-12-05 Thread Alan Modra via Gcc-patches
t testcases for power10 instructions V3 https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557587.html -- Alan Modra Australia Development Lab, IBM

Re: Error: invalid switch -me200

2020-11-16 Thread Alan Modra
gt; > > > > > The help text for this config options says that e200 is used in 55xx, > > > and there *is* an -me5500 GAS flag (which probably does this same > > > thing, too). But is any of this tested, or useful, or wanted? > > > > > > Maybe Chris

  1   2   3   4   5   6   7   8   9   10   >