Re: [9fans] replica bug

2011-03-03 Thread Russ Cox
please fix the avl code, not the callers. thanks.

Re: [9fans] replica bug

2011-03-03 Thread erik quanstrom
excellent find. i'd forgotten about this pointy thing. the problem of course is that the avl library uses the return value directly as an index into a 3 element array. this all comes to tears if the compare function can return something other than {-1, 0, 1}. On Thu Mar 3 07:26:22 EST 2011, r.

[9fans] replica bug

2011-03-03 Thread rod
The replica utilities use an avl tree to store sets of filenames and attributes. When new trees are created, the function "mkavltree" is called. It's argument is the comparison routine "entrycmp" in db.c. "entrycmp" in turn uses "strcmp" to do it's donkey work, and returns that value directly. The