Re: [yocto] [meta-raspberrypi][PATCH 1/6] linux-raspberrypi: Allow override of PV
On Sun, 29 May 2016 21:20:21 +0300 Khem Raj wrote: > On May 29, 2016 9:00 AM, "Paul Barker" wrote: > > > > PV is now set in each version of the linux-raspberrypi recipe > > instead of > in > > linux-raspberrypi.inc. This allows linux-raspberrypi.inc to be used > > in > custom > > kernel recipes in another layer which require a different PV value. > > You can also use weak define. Instead of duplicated value in each > recipe Weak define doesn't work here as PV is already weakly defined based on the recipe filename and that's what we're trying to override. We end up with PV values like "4.1" instead of "4.1.21+git..." if "?=" is used. Thanks, Paul Barker -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [meta-raspberrypi][PATCH 5/6] linux-raspberrypi: Drop version 3.18
On Sun, 29 May 2016 21:17:29 +0300 Khem Raj wrote: > I think we should remove it. But lets give a chance for folks to > respond if any one is using 3.18 still > On May 29, 2016 9:07 AM, "Paul Barker" wrote: > > > The linux-raspberrypi v3.18 recipe does not build after commit > > 519c387e3b97ecc21ac1d7b4fc9197298f289a71 as it lacks the necessary > > dtb files. > > > > Signed-off-by: Paul Barker I'll drop this from the patch series for now so that we can get the other changes in. Thanks, Paul Barker -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [PATCH][matchbox-wm] wm: Do not set MB theme based on Net/ThemeName
On 27 May 2016 at 12:32, Burton, Ross wrote: > On 26 April 2016 at 08:57, Jussi Kukkonen wrote: >> >> MBWM already supports setting MB theme with "MATCHBOX/THEME", >> there is no advantage to also set it with "Net/ThemeName" -- the >> expectation that MBWM has a matching theme for all toolkit themes >> is not realistic. >> >> Net/ThemeName is used by Gtk+ to set Gtk theme so this change allows >> the Gtk theme and MBWM theme to have different names. > > This behaviour is useful though, how about supporting both but having Matchbox/Theme override Net/ThemeName? I've solved what I think is the issue by supporting the "MATCHBOX/THEME" property via the /desktop/poky/interface/wmtheme gconf key (similar to how "Net/ThemeName" is supported via /desktop/poky/interface/theme) in xsettings-daemon. So now both can be set at the same time very easily at runtime -- the override should not be necessary. - Jussi -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] How to set a cmake cache variable to a spezific value?
Hej I want to build a recipe for a cmake based application. To make it run I need to set a cached cmake variable. What is the common/best way to achive it? Regards! Stefan Jaritz ESA Elektroschaltanlagen Grimma GmbH Broner Ring 30 04668 Grimma Telefon: +49 3437 9211 176 Telefax: +49 3437 9211 26 E-Mail: s.jar...@esa-grimma.de Internet: www.esa-grimma.de Geschäftsführer: Dipl.-Ing. Jörg Gaitzsch Jörg Reinker Sitz der Gesellschaft: Grimma Ust.-ID: DE 141784437 Amtsgericht: Leipzig, HRB 5159 Steuernummer: 238/108/00755 Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und löschen Sie diese Nachricht. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.-- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] Is There a Package Limit to use of Smart / RPM?
Thanks! I think what was happening in my case was some post install scriptlets triggered activity that in turned killed an upgrade service that was running. We handle the upgrades with the system in sort of an offline state so we don't want the RPM installs / upgrades launching things. Since manually installing an RPM is not a normal use case in our design, what I wound up having to do was to override the update-rc.d.bbclass to remove the "-s" option passed when installing an RPM on the target. The result of this was all RPMs to install OK without inadvertently launching the services. Then we launch the services afterwards. Another question: If I want to install RPMs onto my file system offline, but mounted onto a ramdisk boot so that I can run smart/rpm in a chroot scheme, will this work? I see that in the build system, it relies on '$D' being set to indicate an alternate path. This handles alternate paths, and usually bypasses stop/start of services. Do I need to set '$D' up in a similar way on the target? I am thinking of an offline upgrade scheme on the target similar in intent to say 'fedup' so that I don't have to worry about an RPM upgrade to say 'db' package or 'rpm' pulling the rug out from under the upgrade. In this case, my offline rootfs may be mounted say at /mnt/... Thanks! Regards, Darcy Darcy Watkins :: Staff Engineer, Firmware SIERRA WIRELESS Direct +1 604 233 7989 :: Fax +1 604 231 1109 :: Main +1 604 231 1100 13811 Wireless Way :: Richmond, BC Canada V6V 3A4 [P2] dwatk...@sierrawireless.com :: www.sierrawireless.com :: www.inmotiontechnology.com -Original Message- From: Mike Looijmans [mailto:mike.looijm...@topic.nl] Sent: May-30-16 12:18 AM To: yocto@yoctoproject.org Cc: Darcy Watkins Subject: Re: [yocto] Is There a Package Limit to use of Smart / RPM? We've seen similar effects with IPK packages and opkg, but the problem then isn't so much the package manager, but it's just that some packages don't upgrade properly when bunched together with some others. For example, two packages A and B which individually upgrade just fine, but if you try to upgrade them both, something in their pre/post-install/remove actions messes things up and causes one or both of them to fail. Also, things like upgrading network components while using ssh to start the upgrade, or upgrading parts of the package manager can also cause strange upgrade problems. I doubt there's some magic "maximum number of packages" in any package manager. On 28-05-16 21:16, Darcy Watkins wrote: > Hi, ---snip!--- -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [meta-raspberrypi][PATCH 1/6] linux-raspberrypi: Allow override of PV
On May 30, 2016 1:09 AM, "Paul Barker" wrote: > > On Sun, 29 May 2016 21:20:21 +0300 > Khem Raj wrote: > > > On May 29, 2016 9:00 AM, "Paul Barker" wrote: > > > > > > PV is now set in each version of the linux-raspberrypi recipe > > > instead of > > in > > > linux-raspberrypi.inc. This allows linux-raspberrypi.inc to be used > > > in > > custom > > > kernel recipes in another layer which require a different PV value. > > > > You can also use weak define. Instead of duplicated value in each > > recipe > > Weak define doesn't work here as PV is already weakly defined based on > the recipe filename and that's what we're trying to override. We end up > with PV values like "4.1" instead of "4.1.21+git..." if "?=" is used. What issue do we have if we ask custom recipes to define LINUX_VERSION > > Thanks, > Paul Barker -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v4 0/5] Support for .dtbo files for dtb overlays, required by kernels 4.4.6+
v4: rebased For kernels 4.4.9+, the behavior for the device tree overlays loading has been modified on RaspberryPi. For overlays, it loads .dtbo files, not .dtb anymore. Also, it does not check for -overlay extension, so the name of the overlay that is placed in the "overlays" directory must be .dtbo, instead of -overlay.dtb. This patch addresses the issue for kernels 4.4+, while keeping the same behavior for older kernels. This patch must be used in conjunction with another patch to meta/recipes-kernel/linux-dtb.inc, which will allow the processing of .dtbo files for overlays, instead of only .dtb like before. .dtb are still in use, but only for the "real" device trees (not the overlays). Herve Jourdain (5): linux-raspberrypi-base.bbclass: support for .dtbo files for dtb overlays sdcard_image-rpi.bbclass: support for .dtbo files for dtb overlays rpi-base.inc: support for .dtbo files for dtb overlays linux-raspberrypi_4.4.inc: support for .dtbo files for dtb overlays linux-raspberrypi_4.4.inc: support for .dtbo files for dtb overlays classes/linux-raspberrypi-base.bbclass | 4 ++- classes/sdcard_image-rpi.bbclass | 7 +++-- conf/machine/include/rpi-base.inc | 36 +- .../0001-fix-dtbo-rules.patch | 27 recipes-kernel/linux/linux-raspberrypi_4.4.bb | 1 + 5 files changed, 70 insertions(+), 5 deletions(-) create mode 100644 recipes-kernel/linux/linux-raspberrypi-4.4/0001-fix-dtbo-rules.patch -- 2.7.4 -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v4 1/5] linux-raspberrypi-base.bbclass: support for .dtbo files for dtb overlays
Kernel 4.4.6+ on RaspberryPi support .dtbo files for overlays, instead of .dtb.
Add support for both variants of overlays ("-overlay.dtb" and ".dtbo")
Signed-off-by: Herve Jourdain
---
classes/linux-raspberrypi-base.bbclass | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/classes/linux-raspberrypi-base.bbclass
b/classes/linux-raspberrypi-base.bbclass
index 40beef1..2eca037 100644
--- a/classes/linux-raspberrypi-base.bbclass
+++ b/classes/linux-raspberrypi-base.bbclass
@@ -33,7 +33,9 @@ def split_overlays(d, out):
dts = get_dts(d, None)
if out:
overlays = oe.utils.str_filter_out('\S+\-overlay\.dtb$', dts, d)
+overlays = oe.utils.str_filter_out('\S+\.dtbo$', overlays, d)
else:
-overlays = oe.utils.str_filter('\S+\-overlay\.dtb$', dts, d)
+overlays = oe.utils.str_filter('\S+\-overlay\.dtb$', dts, d) + \
+ " " + oe.utils.str_filter('\S+\.dtbo$', dts, d)
return overlays
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v4 2/5] sdcard_image-rpi.bbclass: support for .dtbo files for dtb overlays
Kernel 4.4.6+ on RaspberryPi support .dtbo files for overlays, instead of .dtb.
Add support for both extensions for overlays (".dtb" and ".dtbo")
Signed-off-by: Herve Jourdain
---
classes/sdcard_image-rpi.bbclass | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/classes/sdcard_image-rpi.bbclass b/classes/sdcard_image-rpi.bbclass
index 4dfd7a3..b3a8bc0 100644
--- a/classes/sdcard_image-rpi.bbclass
+++ b/classes/sdcard_image-rpi.bbclass
@@ -110,7 +110,7 @@ IMAGE_CMD_rpi-sdimg () {
;;
*)
if test -n "${DTS}"; then
- # Device Tree Overlays are assumed to be suffixed by
'-overlay.dtb' string and will be put in a dedicated folder
+ # Device Tree Overlays are assumed to be suffixed by
'-overlay.dtb' (4.1.x) or by '.dtbo' (4.4.9+) string and will be put in a
dedicated folder
DT_OVERLAYS="${@split_overlays(d, 0)}"
DT_ROOT="${@split_overlays(d, 1)}"
@@ -124,9 +124,10 @@ IMAGE_CMD_rpi-sdimg () {
# Copy device tree overlays to dedicated folder
mmd -i ${WORKDIR}/boot.img overlays
for DTB in ${DT_OVERLAYS}; do
- DTB_BASE_NAME=`basename ${DTB} .dtb`
+ DTB_EXT=${DTB##*.}
+ DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
- mcopy -i ${WORKDIR}/boot.img -s
${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${DTB_BASE_NAME}.dtb
::overlays/${DTB_BASE_NAME}.dtb
+ mcopy -i ${WORKDIR}/boot.img -s
${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${DTB_BASE_NAME}.${DTB_EXT}
::overlays/${DTB_BASE_NAME}.${DTB_EXT}
done
fi
mcopy -i ${WORKDIR}/boot.img -s
${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}${KERNEL_INITRAMFS}-${MACHINE}.bin
::${SDIMG_KERNELIMAGE}
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v4 3/5] rpi-base.inc: support for .dtbo files for dtb overlays
Kernel 4.4.6+ on RaspberryPi support .dtbo files for overlays, instead of .dtb.
Add support for both variants of overlays ("-overlay.dtb" and ".dtbo") for the
default KERNEL_DEVICETREE variable
Signed-off-by: Herve Jourdain
---
conf/machine/include/rpi-base.inc | 36 +++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/conf/machine/include/rpi-base.inc
b/conf/machine/include/rpi-base.inc
index 56ca83e..2c9d8e0 100644
--- a/conf/machine/include/rpi-base.inc
+++ b/conf/machine/include/rpi-base.inc
@@ -16,7 +16,7 @@ XSERVER = " \
"
# Really supported starting from linux-raspberrypi 3.18.y only
-KERNEL_DEVICETREE ?= " \
+KERNEL_DEVICETREE_OVERLAYS_DTB = " \
bcm2708-rpi-b.dtb \
bcm2708-rpi-b-plus.dtb \
bcm2709-rpi-2-b.dtb \
@@ -38,6 +38,40 @@ KERNEL_DEVICETREE ?= " \
overlays/w1-gpio-pullup-overlay.dtb \
overlays/pi3-miniuart-bt-overlay.dtb \
"
+KERNEL_DEVICETREE_OVERLAYS_DTBO = " \
+bcm2708-rpi-b.dtb \
+bcm2708-rpi-b-plus.dtb \
+bcm2709-rpi-2-b.dtb \
+bcm2710-rpi-3-b.dtb \
+\
+overlays/hifiberry-amp.dtbo \
+overlays/hifiberry-dac.dtbo \
+overlays/hifiberry-dacplus.dtbo \
+overlays/hifiberry-digi.dtbo \
+overlays/i2c-rtc.dtbo \
+overlays/iqaudio-dac.dtbo \
+overlays/iqaudio-dacplus.dtbo \
+overlays/lirc-rpi.dtbo \
+overlays/pitft22.dtbo \
+overlays/pitft28-resistive.dtbo \
+overlays/pps-gpio.dtbo \
+overlays/rpi-ft5406.dtbo \
+overlays/w1-gpio.dtbo \
+overlays/w1-gpio-pullup.dtbo \
+overlays/pi3-miniuart-bt.dtbo \
+"
+
+def cmpver_strings(ver1, ver2, truevalue, falsevalue):
+from distutils.version import LooseVersion
+ver1 = ''.join(ch for ch in ver1 if ch in '0123456789.')
+ver2 = ''.join(ch for ch in ver2 if ch in '0123456789.')
+if LooseVersion(ver1) >= LooseVersion(ver2):
+return truevalue
+else:
+return falsevalue
+
+KERNEL_DEVICETREE ?=
"${@cmpver_strings("${PREFERRED_VERSION_linux-raspberrypi}", "4.4",
"${KERNEL_DEVICETREE_OVERLAYS_DTBO}", "${KERNEL_DEVICETREE_OVERLAYS_DTB}")}"
+
KERNEL_IMAGETYPE ?= "Image"
MACHINE_FEATURES += "apm usbhost keyboard vfat ext2 screen touchscreen alsa
bluetooth wifi sdio"
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v4 4/5] linux-raspberrypi_4.4.inc: support for .dtbo files for dtb overlays
Kernel 4.4.6+ on RaspberryPi support .dtbo files for overlays, instead of .dtb.
Patch the kernel, which has faulty rules to generate .dtbo the way yocto does
Signed-off-by: Herve Jourdain
---
.../0001-fix-dtbo-rules.patch | 27 ++
1 file changed, 27 insertions(+)
create mode 100644
recipes-kernel/linux/linux-raspberrypi-4.4/0001-fix-dtbo-rules.patch
diff --git
a/recipes-kernel/linux/linux-raspberrypi-4.4/0001-fix-dtbo-rules.patch
b/recipes-kernel/linux/linux-raspberrypi-4.4/0001-fix-dtbo-rules.patch
new file mode 100644
index 000..ef04a72
--- /dev/null
+++ b/recipes-kernel/linux/linux-raspberrypi-4.4/0001-fix-dtbo-rules.patch
@@ -0,0 +1,27 @@
+diff --git a/arch/arm/Makefile b/arch/arm/Makefile
+index a2e7cf7..673c1cb 100644
+--- a/arch/arm/Makefile
b/arch/arm/Makefile
+@@ -333,6 +333,8 @@ $(INSTALL_TARGETS):
+
+ %.dtb: | scripts
+ $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@
++%.dtbo: | scripts
++ $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@
+
+ PHONY += dtbs dtbs_install
+
+diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
+index 3079c4f..6cc3766 100644
+--- a/scripts/Makefile.lib
b/scripts/Makefile.lib
+@@ -293,7 +293,8 @@ $(obj)/%.dtb: $(src)/%.dts FORCE
+ $(call if_changed_dep,dtc)
+
+ quiet_cmd_dtco = DTCO$@
+-cmd_dtco = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
++cmd_dtco = mkdir -p $(dir ${dtc-tmp}) ; \
++ $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
+ $(objtree)/scripts/dtc/dtc -@ -H epapr -O dtb -o $@ -b 0 \
+ -i $(dir $<) $(DTC_FLAGS) \
+ -d $(depfile).dtc.tmp $(dtc-tmp) ; \
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v4 5/5] linux-raspberrypi_4.4.inc: support for .dtbo files for dtb overlays
Signed-off-by: Herve Jourdain --- recipes-kernel/linux/linux-raspberrypi_4.4.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/recipes-kernel/linux/linux-raspberrypi_4.4.bb b/recipes-kernel/linux/linux-raspberrypi_4.4.bb index ba47b22..789fef1 100644 --- a/recipes-kernel/linux/linux-raspberrypi_4.4.bb +++ b/recipes-kernel/linux/linux-raspberrypi_4.4.bb @@ -4,5 +4,6 @@ LINUX_VERSION ?= "4.4.9" SRCREV = "3b440738b5c1adc3ec3ee72ceca799d1b8d264df" SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.4.y \ + file://0001-fix-dtbo-rules.patch \ " require linux-raspberrypi.inc -- 2.7.4 -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 00/14] Support for VC4 graphics driver
This v3 series addresses the following issues with the v2 series:
a. patch rebased
b. new revision of kernel, to get a version of the VC4 graphics driver that
handles render nodes
c. patch to the VC4 driver to enable proper working of the render nodes (need
to add authorization for IOCTLs)
v2 series:
a. Fix the 4.4.10 kernel revision
b. Effectively add vc4-kms-v3d overlay to the list of overlays to build
(forgotten previously)
c. Make the parameter to the v4c-kms-v3d overlay configurable
d. Add default values for the cma parameter to the v4c-kms-v3d overlay,
depending on the board (and the memory it has)
This patch series enables the support for the VC4 graphics driver from Eric
Anholt.
There was a previous patch series by Javier Martinez Canillas, but it required
use of a different kernel.
VC4 is now supported in the raspberrypi official kernel, at least for 4.4.9+.
The support in 4.1 exists, but it is NOT STABLE, so it has been deemed
unreasonable to support VC4 with 4.1 kernels.
THEREFORE, VC4 graphics is supported ONLY for kernel versions 4.4.9 and later.
This patch series proposes to support VC4 by only adding 'vc4graphics' to
MACHINE_FEATURES, for raspberrypi. If this is set, it will trigger all the
necessary configuration/changes to use the VC4 driver, including
mesa/wayland/weston currently, and adding the overlay required.
In order for this series to work, some previous patches are needed (support for
.dtbo, and fix of the mesa packaging when there is no DRI driver).
The memory reserved for the VC4 driver has default values depending on the
version of the board used, but it can be configured by setting VC4_CMA_SIZE to
a value supported by the overlay ('cma-256', 'cma-192', 'cma-128', 'cma-96',
'cma-64').
'cma-256' is the recommended value, but it might not be possible on boards with
512MB or DRAM, or less...
'cma-64' is known to not being able to support FHD/1080p.
It was tested with wayland/weston, without the support for X11.
This patch series depends on two other patch series previously posted, that
enable the support for .dtbo overlay files.
Herve Jourdain (14):
rpi-default-providers.inc: change default providers to support
vc4graphics
rpi-base.inc: add vc4-kms-v3d to the overlays to support vc4graphics
raspberrypi.conf: set the default value of VC4_CMA_SIZE to support
vc4graphics
raspberrypi0.conf: set the default value of VC4_CMA_SIZE to support
vc4graphics
raspberrypi2.conf: set the default value of VC4_CMA_SIZE to support
vc4graphics
raspberrypi3.conf: set the default value of VC4_CMA_SIZE to support
vc4graphics
rpi-config_git.bb: add v4c overlay to config.txt to support
vc4graphics
wayland/weston_%.bbappend: modify configuration options to support
vc4graphics
weston/weston_%.bbappend: modify configuration options to support
vc4graphics
mesa_%.bbappend: new file to add the correct configuration options to
support vc4graphics
linux-rpi.inc: add the configuration options required to support
vc4graphics
firmware.inc: bump version to support vc4graphics
linux-raspberrypi_4.4.bb: bump the kernel revision to 4.4.10 to
support vc4graphics (including renderD128 device)
linux-raspberrypi-4.4: add patch to enable proper operation of
renderD128 device
conf/machine/include/rpi-base.inc | 1 +
conf/machine/include/rpi-default-providers.inc | 8
conf/machine/raspberrypi.conf | 2 ++
conf/machine/raspberrypi0.conf | 2 ++
conf/machine/raspberrypi2.conf | 2 ++
conf/machine/raspberrypi3.conf | 2 ++
recipes-bsp/bootfiles/rpi-config_git.bb| 10 +-
recipes-bsp/common/firmware.inc| 4 ++--
recipes-graphics/mesa/mesa_%.bbappend | 4
recipes-graphics/wayland/weston_%.bbappend | 6 ++
recipes-graphics/weston/weston_%.bbappend | 13 ++--
.../0002-vc4-ioctl-rendering-allow.patch | 23 ++
recipes-kernel/linux/linux-raspberrypi_4.4.bb | 5 +++--
recipes-kernel/linux/linux-rpi.inc | 10 ++
14 files changed, 73 insertions(+), 19 deletions(-)
create mode 100644 recipes-graphics/mesa/mesa_%.bbappend
create mode 100644
recipes-kernel/linux/linux-raspberrypi-4.4/0002-vc4-ioctl-rendering-allow.patch
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 01/14] rpi-default-providers.inc: change default providers to support vc4graphics
Signed-off-by: Herve Jourdain
---
conf/machine/include/rpi-default-providers.inc | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/conf/machine/include/rpi-default-providers.inc
b/conf/machine/include/rpi-default-providers.inc
index cabbd43..0bc8838 100644
--- a/conf/machine/include/rpi-default-providers.inc
+++ b/conf/machine/include/rpi-default-providers.inc
@@ -3,8 +3,8 @@
PREFERRED_PROVIDER_virtual/kernel ?= "linux-raspberrypi"
PREFERRED_PROVIDER_u-boot ?= "u-boot-rpi"
PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
-PREFERRED_PROVIDER_virtual/egl ?= "userland"
-PREFERRED_PROVIDER_virtual/libgles2 ?= "userland"
-PREFERRED_PROVIDER_virtual/libgl ?= "mesa-gl"
-PREFERRED_PROVIDER_virtual/mesa ?= "mesa-gl"
+PREFERRED_PROVIDER_virtual/egl ?= "${@bb.utils.contains("MACHINE_FEATURES",
"vc4graphics", "mesa", "userland", d)}"
+PREFERRED_PROVIDER_virtual/libgles2 ?=
"${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "mesa", "userland",
d)}"
+PREFERRED_PROVIDER_virtual/libgl ?= "${@bb.utils.contains("MACHINE_FEATURES",
"vc4graphics", "mesa", "mesa-gl", d)}"
+PREFERRED_PROVIDER_virtual/mesa ?= "${@bb.utils.contains("MACHINE_FEATURES",
"vc4graphics", "mesa", "mesa-gl", d)}"
PREFERRED_PROVIDER_jpeg ?= "jpeg"
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 02/14] rpi-base.inc: add vc4-kms-v3d to the overlays to support vc4graphics
Signed-off-by: Herve Jourdain --- conf/machine/include/rpi-base.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/conf/machine/include/rpi-base.inc b/conf/machine/include/rpi-base.inc index 2c9d8e0..23f8619 100644 --- a/conf/machine/include/rpi-base.inc +++ b/conf/machine/include/rpi-base.inc @@ -59,6 +59,7 @@ KERNEL_DEVICETREE_OVERLAYS_DTBO = " \ overlays/w1-gpio.dtbo \ overlays/w1-gpio-pullup.dtbo \ overlays/pi3-miniuart-bt.dtbo \ +overlays/vc4-kms-v3d.dtbo \ " def cmpver_strings(ver1, ver2, truevalue, falsevalue): -- 2.7.4 -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 04/14] raspberrypi0.conf: set the default value of VC4_CMA_SIZE to support vc4graphics
Signed-off-by: Herve Jourdain
---
conf/machine/raspberrypi0.conf | 2 ++
1 file changed, 2 insertions(+)
diff --git a/conf/machine/raspberrypi0.conf b/conf/machine/raspberrypi0.conf
index ccf9ae7..0df9121 100644
--- a/conf/machine/raspberrypi0.conf
+++ b/conf/machine/raspberrypi0.conf
@@ -6,3 +6,5 @@ MACHINEOVERRIDES = "raspberrypi:${MACHINE}"
include conf/machine/raspberrypi.conf
SERIAL_CONSOLE = "115200 ttyAMA0"
+VC4_CMA_SIZE ?= "cma-128"
+
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 03/14] raspberrypi.conf: set the default value of VC4_CMA_SIZE to support vc4graphics
Signed-off-by: Herve Jourdain --- conf/machine/raspberrypi.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/conf/machine/raspberrypi.conf b/conf/machine/raspberrypi.conf index 0f95f1a..b369c67 100644 --- a/conf/machine/raspberrypi.conf +++ b/conf/machine/raspberrypi.conf @@ -8,3 +8,5 @@ require conf/machine/include/tune-arm1176jzf-s.inc include conf/machine/include/rpi-base.inc SERIAL_CONSOLE = "115200 ttyAMA0" +VC4_CMA_SIZE_raspberrypi ?= "cma-64" + -- 2.7.4 -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 05/14] raspberrypi2.conf: set the default value of VC4_CMA_SIZE to support vc4graphics
Signed-off-by: Herve Jourdain --- conf/machine/raspberrypi2.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/conf/machine/raspberrypi2.conf b/conf/machine/raspberrypi2.conf index b6346e6..3a82d66 100644 --- a/conf/machine/raspberrypi2.conf +++ b/conf/machine/raspberrypi2.conf @@ -8,3 +8,5 @@ require conf/machine/include/tune-cortexa7.inc include conf/machine/include/rpi-base.inc SERIAL_CONSOLE = "115200 ttyAMA0" +VC4_CMA_SIZE ?= "cma-256" + -- 2.7.4 -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 06/14] raspberrypi3.conf: set the default value of VC4_CMA_SIZE to support vc4graphics
Signed-off-by: Herve Jourdain --- conf/machine/raspberrypi3.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/conf/machine/raspberrypi3.conf b/conf/machine/raspberrypi3.conf index cb6056e..438c6e6 100644 --- a/conf/machine/raspberrypi3.conf +++ b/conf/machine/raspberrypi3.conf @@ -9,3 +9,5 @@ MACHINE_EXTRA_RRECOMMENDS += "linux-firmware-brcm43430" include conf/machine/raspberrypi2.conf SERIAL_CONSOLE = "115200 ttyS0" +VC4_CMA_SIZE ?= "cma-256" + -- 2.7.4 -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 08/14] wayland/weston_%.bbappend: modify configuration options to support vc4graphics
Signed-off-by: Herve Jourdain
---
recipes-graphics/wayland/weston_%.bbappend | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/recipes-graphics/wayland/weston_%.bbappend
b/recipes-graphics/wayland/weston_%.bbappend
index c3a7421..57b8079 100644
--- a/recipes-graphics/wayland/weston_%.bbappend
+++ b/recipes-graphics/wayland/weston_%.bbappend
@@ -1,4 +1,2 @@
-EXTRA_OECONF_append_rpi = "\
---enable-rpi-compositor \
-WESTON_NATIVE_BACKEND=rpi-backend.so \
- "
+EXTRA_OECONF_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES',
'vc4graphics', '', ' --enable-rpi-compositor
WESTON_NATIVE_BACKEND=rpi-backend.so', d)}"
+
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 07/14] rpi-config_git.bb: add v4c overlay to config.txt to support vc4graphics
Signed-off-by: Herve Jourdain
---
recipes-bsp/bootfiles/rpi-config_git.bb | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb
b/recipes-bsp/bootfiles/rpi-config_git.bb
index 4bc8eb7..f610718 100644
--- a/recipes-bsp/bootfiles/rpi-config_git.bb
+++ b/recipes-bsp/bootfiles/rpi-config_git.bb
@@ -13,12 +13,14 @@ SRC_URI =
"git://github.com/Evilpaul/RPi-config.git;protocol=git;branch=master \
S = "${WORKDIR}/git"
-PR = "r4"
+PR = "r5"
PITFT="${@bb.utils.contains("MACHINE_FEATURES", "pitft", "1", "0", d)}"
PITFT22="${@bb.utils.contains("MACHINE_FEATURES", "pitft22", "1", "0", d)}"
PITFT28r="${@bb.utils.contains("MACHINE_FEATURES", "pitft28r", "1", "0", d)}"
+VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1", "0",
d)}"
+
inherit deploy
do_deploy() {
@@ -102,6 +104,12 @@ do_deploy() {
echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
fi
+
+# VC4 Graphics support
+if [ "${VC4GRAPHICS}" = "1" ]; then
+echo "# Enable VC4 Graphics" >>
${DEPLOYDIR}/bcm2835-bootfiles/config.txt
+echo "dtoverlay=vc4-kms-v3d,${VC4_CMA_SIZE}" >>
${DEPLOYDIR}/bcm2835-bootfiles/config.txt
+fi
}
addtask deploy before do_package after do_install
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 09/14] weston/weston_%.bbappend: modify configuration options to support vc4graphics
Signed-off-by: Herve Jourdain
---
recipes-graphics/weston/weston_%.bbappend | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/recipes-graphics/weston/weston_%.bbappend
b/recipes-graphics/weston/weston_%.bbappend
index 3ec311d..70f4360 100644
--- a/recipes-graphics/weston/weston_%.bbappend
+++ b/recipes-graphics/weston/weston_%.bbappend
@@ -1,7 +1,8 @@
-EXTRA_OECONF += "--enable-rpi-compositor \
- --disable-resize-optimization \
- --disable-setuid-install \
- --disable-xwayland-test \
- --disable-simple-egl-clients \
- WESTON_NATIVE_BACKEND=rpi-backend.so \
+PACKAGECONFIG_rpi_remove = "${@bb.utils.contains('MACHINE_FEATURES',
'vc4graphics', ' fbdev', '', d)}"
+EXTRA_OECONF += "--disable-xwayland-test \
+ --disable-simple-egl-clients \
"
+EXTRA_OECONF += "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '',
'--enable-rpi-compositor', d)}"
+EXTRA_OECONF += "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '',
'--disable-resize-optimization', d)}"
+EXTRA_OECONF += "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '',
'--disable-setuid-install', d)}"
+EXTRA_OECONF += "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '',
'WESTON_NATIVE_BACKEND=rpi-backend.so', d)}"
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 10/14] mesa_%.bbappend: new file to add the correct configuration options to support vc4graphics
Signed-off-by: Herve Jourdain --- recipes-graphics/mesa/mesa_%.bbappend | 4 1 file changed, 4 insertions(+) create mode 100644 recipes-graphics/mesa/mesa_%.bbappend diff --git a/recipes-graphics/mesa/mesa_%.bbappend b/recipes-graphics/mesa/mesa_%.bbappend new file mode 100644 index 000..b182388 --- /dev/null +++ b/recipes-graphics/mesa/mesa_%.bbappend @@ -0,0 +1,4 @@ +PACKAGECONFIG_append_rpi = " gallium" +GALLIUMDRIVERS_rpi = "vc4" +DRIDRIVERS_rpi = "" + -- 2.7.4 -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 11/14] linux-rpi.inc: add the configuration options required to support vc4graphics
Signed-off-by: Herve Jourdain
---
recipes-kernel/linux/linux-rpi.inc | 10 ++
1 file changed, 10 insertions(+)
diff --git a/recipes-kernel/linux/linux-rpi.inc
b/recipes-kernel/linux/linux-rpi.inc
index 1755685..c120dbd 100644
--- a/recipes-kernel/linux/linux-rpi.inc
+++ b/recipes-kernel/linux/linux-rpi.inc
@@ -111,6 +111,16 @@ do_configure_prepend() {
# Activate CONFIG_LEGACY_PTYS
kernel_configure_variable LEGACY_PTYS y
+# Activate the configuration options for VC4
+VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1",
"0", d)}"
+if [ ${VC4GRAPHICS} = "1" ]; then
+kernel_configure_variable I2C_BCM2835 y
+kernel_configure_variable DRM y
+kernel_configure_variable DRM_FBDEV_EMULATION n
+kernel_configure_variable DRM_VC4 y
+kernel_configure_variable FB_BCM2708 n
+fi
+
# Keep this the last line
# Remove all modified configs and add the rest to .config
sed -e "${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config'
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 12/14] firmware.inc: bump version to support vc4graphics
Signed-off-by: Herve Jourdain
---
recipes-bsp/common/firmware.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/recipes-bsp/common/firmware.inc b/recipes-bsp/common/firmware.inc
index bf11e4c..b467fc6 100644
--- a/recipes-bsp/common/firmware.inc
+++ b/recipes-bsp/common/firmware.inc
@@ -1,5 +1,5 @@
-RPIFW_SRCREV ?= "3816e1ce1e6ebc6d2bf0596dbd52849e16aa7e94"
-RPIFW_DATE ?= "20160512"
+RPIFW_SRCREV ?= "c17fa41b8e8321d891230f97837fee98feebc1ac"
+RPIFW_DATE ?= "20160513"
RPIFW_SRC_URI ?=
"git://github.com/raspberrypi/firmware.git;protocol=git;branch=master"
RPIFW_S ?= "${WORKDIR}/git"
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 13/14] linux-raspberrypi_4.4.bb: bump the kernel revision to 4.4.10 to support vc4graphics (including renderD128 device)
Signed-off-by: Herve Jourdain
---
recipes-kernel/linux/linux-raspberrypi_4.4.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
index 789fef1..02016fe 100644
--- a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
+++ b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
@@ -1,8 +1,8 @@
FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
-LINUX_VERSION ?= "4.4.9"
+LINUX_VERSION ?= "4.4.10"
-SRCREV = "3b440738b5c1adc3ec3ee72ceca799d1b8d264df"
+SRCREV = "d7646fd3757515dfda0fd4ecd33212d175786ac4"
SRC_URI =
"git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.4.y \
file://0001-fix-dtbo-rules.patch \
"
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH v3 14/14] linux-raspberrypi-4.4: add patch to enable proper operation of renderD128 device
Signed-off-by: Herve Jourdain
---
.../0002-vc4-ioctl-rendering-allow.patch | 23 ++
recipes-kernel/linux/linux-raspberrypi_4.4.bb | 1 +
2 files changed, 24 insertions(+)
create mode 100644
recipes-kernel/linux/linux-raspberrypi-4.4/0002-vc4-ioctl-rendering-allow.patch
diff --git
a/recipes-kernel/linux/linux-raspberrypi-4.4/0002-vc4-ioctl-rendering-allow.patch
b/recipes-kernel/linux/linux-raspberrypi-4.4/0002-vc4-ioctl-rendering-allow.patch
new file mode 100644
index 000..823ffd8
--- /dev/null
+++
b/recipes-kernel/linux/linux-raspberrypi-4.4/0002-vc4-ioctl-rendering-allow.patch
@@ -0,0 +1,23 @@
+diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
+index a5b68c1..14b5ec1 100644
+--- a/drivers/gpu/drm/vc4/vc4_drv.c
b/drivers/gpu/drm/vc4/vc4_drv.c
+@@ -75,12 +75,12 @@ static const struct file_operations vc4_drm_fops = {
+ };
+
+ static const struct drm_ioctl_desc vc4_drm_ioctls[] = {
+- DRM_IOCTL_DEF_DRV(VC4_SUBMIT_CL, vc4_submit_cl_ioctl, 0),
+- DRM_IOCTL_DEF_DRV(VC4_WAIT_SEQNO, vc4_wait_seqno_ioctl, 0),
+- DRM_IOCTL_DEF_DRV(VC4_WAIT_BO, vc4_wait_bo_ioctl, 0),
+- DRM_IOCTL_DEF_DRV(VC4_CREATE_BO, vc4_create_bo_ioctl, 0),
+- DRM_IOCTL_DEF_DRV(VC4_MMAP_BO, vc4_mmap_bo_ioctl, 0),
+- DRM_IOCTL_DEF_DRV(VC4_CREATE_SHADER_BO, vc4_create_shader_bo_ioctl, 0),
++ DRM_IOCTL_DEF_DRV(VC4_SUBMIT_CL, vc4_submit_cl_ioctl,
0|DRM_RENDER_ALLOW),
++ DRM_IOCTL_DEF_DRV(VC4_WAIT_SEQNO, vc4_wait_seqno_ioctl,
0|DRM_RENDER_ALLOW),
++ DRM_IOCTL_DEF_DRV(VC4_WAIT_BO, vc4_wait_bo_ioctl, 0|DRM_RENDER_ALLOW),
++ DRM_IOCTL_DEF_DRV(VC4_CREATE_BO, vc4_create_bo_ioctl,
0|DRM_RENDER_ALLOW),
++ DRM_IOCTL_DEF_DRV(VC4_MMAP_BO, vc4_mmap_bo_ioctl, 0|DRM_RENDER_ALLOW),
++ DRM_IOCTL_DEF_DRV(VC4_CREATE_SHADER_BO, vc4_create_shader_bo_ioctl,
0|DRM_RENDER_ALLOW),
+ DRM_IOCTL_DEF_DRV(VC4_GET_HANG_STATE, vc4_get_hang_state_ioctl,
+ DRM_ROOT_ONLY),
+ };
diff --git a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
index 02016fe..ba0973d 100644
--- a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
+++ b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
@@ -5,5 +5,6 @@ LINUX_VERSION ?= "4.4.10"
SRCREV = "d7646fd3757515dfda0fd4ecd33212d175786ac4"
SRC_URI =
"git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.4.y \
file://0001-fix-dtbo-rules.patch \
+ file://0002-vc4-ioctl-rendering-allow.patch \
"
require linux-raspberrypi.inc
--
2.7.4
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [psplash][PATCH] Add fbdev option to set the proper /dev/fbX.
Thanks for your reply Richard.
For FBDEV, I have been told on #yocto that the FBENV variable is kind of
useless at least for the startup as the environment is not read yet.
This why I replaced it. But I will let it available in the next patch if
this is what should be done.
For the psplash documentation, I did not find any. Where am I supposed
to complete it?
Thanks for pointing out that a patch should serve a single purpose. I
will correct the indentation in a separate commit.
Best Regards,
Julien
Le 25/05/2016 10:00, Richard Leitner a écrit :
Hi Julien,
comments on the code are below.
On 05/22/2016 07:46 PM, Julien Gueytat wrote:
It works exactly the same way than the angle parameter:
* --angle <-> /etc/rotation file
* --fbdev <-> /etc/fbdev file
Signed-off-by: Julien Gueytat
---
psplash-fb.c | 16 ++--
psplash-fb.h | 4 ++--
psplash.c| 57 -
3 files changed, 44 insertions(+), 33 deletions(-)
diff --git a/psplash-fb.c b/psplash-fb.c
index 8daaf6f..d344e5a 100644
--- a/psplash-fb.c
+++ b/psplash-fb.c
@@ -99,18 +99,20 @@ attempt_to_change_pixel_format (PSplashFB *fb,
}
PSplashFB*
-psplash_fb_new (int angle)
+psplash_fb_new (int angle, int fbdev_id)
{
struct fb_var_screeninfo fb_var;
struct fb_fix_screeninfo fb_fix;
int off;
- char*fbdev;
+ char fbdev[9] = "/dev/fb0";
PSplashFB *fb = NULL;
- fbdev = getenv("FBDEV");
- if (fbdev == NULL)
-fbdev = "/dev/fb0";
+ if (fbdev_id > 0 && fbdev_id < 10)
+{
+// Conversion from integer to ascii.
+fbdev[7] = fbdev_id + 48;
+}
You removed the possiblity to get the fb device from FBDEV!
Please don't to that as people may rely on that feature!
If you like to add a fbdev commandline option make sure it can co-exist
with the already available methods for setting this option.
And don't forget to add documentation!
if ((fb = malloc (sizeof(PSplashFB))) == NULL)
{
...
@@ -205,35 +205,41 @@ int
main (int argc, char** argv)
{
char *tmpdir;
- intpipe_fd, i = 0, angle = 0, ret = 0;
+ intpipe_fd, i = 0, angle = 0, fbdev_id = 0, ret = 0;
PSplashFB *fb;
bool disable_console_switch = FALSE;
-
+
signal(SIGHUP, psplash_exit);
signal(SIGINT, psplash_exit);
signal(SIGQUIT, psplash_exit);
- while (++i < argc)
-{
- if (!strcmp(argv[i],"-n") || !strcmp(argv[i],"--no-console-switch"))
-{
- disable_console_switch = TRUE;
- continue;
- }
+ while (++i < argc) {
+if (!strcmp(argv[i],"-n") || !strcmp(argv[i],"--no-console-switch"))
+ {
+disable_console_switch = TRUE;
+continue;
+ }
+
+if (!strcmp(argv[i],"-a") || !strcmp(argv[i],"--angle"))
+ {
+if (++i >= argc) goto fail;
+angle = atoi(argv[i]);
+continue;
+ }
+
+if (!strcmp(argv[i],"-f") || !strcmp(argv[i],"--fbdev"))
+ {
+if (++i >= argc) goto fail;
+fbdev_id = atoi(argv[i]);
+continue;
+ }
- if (!strcmp(argv[i],"-a") || !strcmp(argv[i],"--angle"))
-{
- if (++i >= argc) goto fail;
- angle = atoi(argv[i]);
- continue;
- }
-
fail:
fprintf(stderr,
- "Usage: %s [-n|--no-console-switch][-a|--angle <0|90|180|270>]\n",
- argv[0]);
+ "Usage: %s [-n|--no-console-switch][-a|--angle <0|90|180|270>][-f|--fbdev
<0..9>]\n",
+ argv[0]);
exit(-1);
-}
+ }
Please use the same coding style everywhere in psplash.
Furthermore please avoid/remove trailing whitespaces in new/changed code
tmpdir = getenv("TMPDIR");
@@ -245,10 +251,10 @@ main (int argc, char** argv)
if (mkfifo(PSPLASH_FIFO, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP))
{
if (errno!=EEXIST)
- {
- perror("mkfifo");
- exit(-1);
- }
+ {
+ perror("mkfifo");
+ exit(-1);
+ }
}
This change is irrelevant for new fbdev option.
Please send this whitespace fix as a separate patch.
pipe_fd = open (PSPLASH_FIFO,O_RDONLY|O_NONBLOCK);
@@ -262,10 +268,11 @@ main (int argc, char** argv)
if (!disable_console_switch)
psplash_console_switch ();
- if ((fb = psplash_fb_new(angle)) == NULL) {
+ if ((fb = psplash_fb_new(angle,fbdev_id)) == NULL)
+{
ret = -1;
goto fb_fail;
- }
+}
/* Clear the background with #ecece1 */
psplash_fb_draw_rect (fb, 0, 0, fb->width, fb->height,
IMHO in this case fixing the whitespace is fine because the if clause
needs to be adopted for the new option.
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [meta-raspberrypi][PATCH 1/6] linux-raspberrypi: Allow override of PV
On Mon, 30 May 2016 20:58:53 +0300
Khem Raj wrote:
> On May 30, 2016 1:09 AM, "Paul Barker" wrote:
> >
> > On Sun, 29 May 2016 21:20:21 +0300
> > Khem Raj wrote:
> >
> > > On May 29, 2016 9:00 AM, "Paul Barker"
> > > wrote:
> > > >
> > > > PV is now set in each version of the linux-raspberrypi recipe
> > > > instead of
> > > in
> > > > linux-raspberrypi.inc. This allows linux-raspberrypi.inc to be
> > > > used in
> > > custom
> > > > kernel recipes in another layer which require a different PV
> > > > value.
> > >
> > > You can also use weak define. Instead of duplicated value in each
> > > recipe
> >
> > Weak define doesn't work here as PV is already weakly defined based
> > on the recipe filename and that's what we're trying to override. We
> > end up with PV values like "4.1" instead of "4.1.21+git..." if "?="
> > is used.
>
> What issue do we have if we ask custom recipes to define LINUX_VERSION
I'm trying to build from a source archive instead of a git repository
(to avoid a ~1.3GB git clone operation) so the use of ${SRCPV} is
causing me trouble.
Thanks,
Paul Barker
--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] Is There a Package Limit to use of Smart / RPM?
We've seen similar effects with IPK packages and opkg, but the problem then isn't so much the package manager, but it's just that some packages don't upgrade properly when bunched together with some others. For example, two packages A and B which individually upgrade just fine, but if you try to upgrade them both, something in their pre/post-install/remove actions messes things up and causes one or both of them to fail. Also, things like upgrading network components while using ssh to start the upgrade, or upgrading parts of the package manager can also cause strange upgrade problems. I doubt there's some magic "maximum number of packages" in any package manager. On 28-05-16 21:16, Darcy Watkins wrote: Hi, In my project, we have exceeded 700 packages and have run into numerous issues using smart with rpm handling large transactions on the target (e.g. update from a non-PR service build to a PR-service build resulting in all RPMs being updated, though most are just version/release 'bumped' by the PR service). Before I dig too deep, I figured I would see if anyone recognizes this signature as a known issue. 1. Are there any hard coded limits to number of packages that can be handled in a smart/rpm transaction? (Particularly around 700)? 2. Are there known issues related to when 'smart' updates itself and/or 'rpm'? Daisy branch Layerscape (ARM) architecture Kernel 3.19 (yocto-linux + BSP patches) Installing on ext3 rootfs Building on CentOS7 All appeared to work fine until recently when a bunch of added kernel modules and other firmware packages were added, which makes me wonder about a magic limit of 700. Thanks in advance for your insights. Regards, Darcy Darcy Watkins :: Staff Engineer, Firmware SIERRA WIRELESS Direct +1 604 233 7989 :: Fax +1 604 231 1109 :: Main +1 604 231 1100 13811 Wireless Way :: Richmond, BC Canada V6V 3A4 [M1] dwatk...@sierrawireless.com :: www.sierrawireless.com :: www.inmotiontechnology.com Kind regards, Mike Looijmans System Expert TOPIC Embedded Products Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best Telefoon: +31 (0) 499 33 69 79 E-mail: mike.looijm...@topicproducts.com Website: www.topicproducts.com Please consider the environment before printing this e-mail -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
