Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for VC4 graphics driver
I have tried these patches, but there were some hunks and errors during applying to current master revision (69840c0bbe03c2e61601e2377c8e2adc264e0478). Building 'rpi-hwup-image' passed, but while building 'rpi-test-image' (omxplayer recipe) I have noticed some errors due to missing files: - IL/OMX_Core.h - VG/openvg.h - bcm_host.h I'm attaching omxplayer_build_errors.txt with build log and my patch with changes created by Herve (adapted to current master revision) - Support_for_VC4_graphics_driver.patch (Herve- if you decide to use that and resend v3 of patches - please remove my TODO from "conf/machine/include/rpi-base.inc" Could you take a look at that and help me resolve those issues? I currently have a problem that I'm forced to use Raspbian because playing FHD/1080p videos with omxplayer from Yocto runs choppy (I'm not sure if that's the right word, but playback is not smooth) while with Raspbian it works perfect. Do you think that enabling VC4 graphics driver can solve my issue? Did any of you experienced similar problems? Do you have some other solution or do you know what's the cause of this? Thanks, Piotr Lewicki On 20.05.2016 13:51, Herve Jourdain wrote: This v2 series addresses the following issues with the first series: a. Fix the 4.4.10 kernel revision b. Effectively add vc4-kms-v3d overlay to the list of overlays to build (forgotten previously) c. Make the parameter to the v4c-kms-v3d overlay configurable d. Add default values for the cma parameter to the v4c-kms-v3d overlay, depending on the board (and the memory it has) This patch series enables the support for the VC4 graphics driver from Eric Anholt. There was a previous patch series by Javier Martinez Canillas, but it required use of a different kernel. VC4 is now supported in the raspberrypi official kernel, at least for 4.4.9+. The support in 4.1 exists, but it is NOT STABLE, so it has been deemed unreasonable to support VC4 with 4.1 kernels. THEREFORE, VC4 graphics is supported ONLY for kernel versions 4.4.9 and later. This patch series proposes to support VC4 by only adding 'vc4graphics' to MACHINE_FEATURES, for raspberrypi. If this is set, it will trigger all the necessary configuration/changes to use the VC4 driver, including mesa/wayland/weston currently, and adding the overlay required. In order for this series to work, some previous patches are needed (support for .dtbo, and fix of the mesa packaging when there is no DRI driver). The memory reserved for the VC4 driver has default values depending on the version of the board used, but it can be configured by setting VC4_CMA_SIZE to a value supported by the overlay ('cma-256', 'cma-192', 'cma-128', 'cma-96', 'cma-64'). 'cma-256' is the recommended value, but it might not be possible on boards with 512MB or DRAM, or less... 'cma-64' is known to not being able to support FHD/1080p. It was tested with wayland/weston, without the support for X11. This patch series depends on two other patch series previously posted, that enable the support for .dtbo overlay files. Herve Jourdain (13): rpi-default-providers.inc: change default providers to support vc4graphics rpi-base.inc: add vc4-kms-v3d to the overlays to support vc4graphics raspberrypi.conf: set the default value of VC4_CMA_SIZE to support vc4graphics raspberrypi0.conf: set the default value of VC4_CMA_SIZE to support vc4graphics raspberrypi2.conf: set the default value of VC4_CMA_SIZE to support vc4graphics raspberrypi3.conf: set the default value of VC4_CMA_SIZE to support vc4graphics firmware.inc: bump version to support vc4graphics rpi-config_git.bb: add v4c overlay to config.txt to support vc4graphics wayland/weston_%.bbappend: modify configuration options to support vc4graphics weston/weston_%.bbappend: modify configuration options to support vc4graphics mesa_%.bbappend: new file to add the correct configuration options to support vc4graphics linux-raspberrypi_4.4.bb: bump the kernel revision to 4.4.10 to support vc4graphics linux-rpi.inc: add the configuration options required to support vc4graphics conf/machine/include/rpi-base.inc | 1 + conf/machine/include/rpi-default-providers.inc | 8 conf/machine/raspberrypi.conf | 2 ++ conf/machine/raspberrypi0.conf | 2 ++ conf/machine/raspberrypi2.conf | 2 ++ conf/machine/raspberrypi3.conf | 2 ++ recipes-bsp/bootfiles/rpi-config_git.bb| 10 +- recipes-bsp/common/firmware.inc| 4 ++-- recipes-graphics/mesa/mesa_%.bbappend | 4 recipes-graphics/wayland/weston_%.bbappend | 6 ++ recipes-graphics/weston/weston_%.bbappend | 13 +++-- recipes-kernel/linux/linux-raspberrypi_4.4.bb | 4 ++-- recipes-kernel/linux/linux-rpi.inc | 10 ++ 13 files changed, 49
Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for VC4 graphics driver
Hi Piotr, I know that the omxplayer would not build at this time, because VC4 and userland will conflict, and currently omxplayer depends on userland. I will check if it can be supported with VC4 driver enabled, but for the moment it's true I disabled it in my build. Regarding your patches: 1. Are you using linux kernel 4.4? You should set PREFERRED_VERSION_linux-raspberrypi = "4.4.%" somewhere, either in your distro configuration file, or your local.conf. If you do so, it should get kernel 4.4.10, which requires .dtbo files for overlay. As mentioned in the patch, support for VC4 in 4.1 is not stable, and therefore not supported. 2. I've seen only one TODO, did you make only one modification? 3. There are other patches that are needed to be applied, before this patch series is applied: 2 for .dtbo support (1 in meta-raspberrypi, 1 in meta), 1 for mesa (to allow packaging with empty DRI). I'll take a look at the omxplayer issue as soon as I can, in the meanwhile I recommend to not use it... Herve -Original Message- From: piotr.lewicki [mailto:piotr.lewi...@elfin.de] Sent: mardi 24 mai 2016 11:59 To: Herve Jourdain ; yocto@yoctoproject.org Subject: Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for VC4 graphics driver I have tried these patches, but there were some hunks and errors during applying to current master revision (69840c0bbe03c2e61601e2377c8e2adc264e0478). Building 'rpi-hwup-image' passed, but while building 'rpi-test-image' (omxplayer recipe) I have noticed some errors due to missing files: - IL/OMX_Core.h - VG/openvg.h - bcm_host.h I'm attaching omxplayer_build_errors.txt with build log and my patch with changes created by Herve (adapted to current master revision) - Support_for_VC4_graphics_driver.patch (Herve- if you decide to use that and resend v3 of patches - please remove my TODO from "conf/machine/include/rpi-base.inc" Could you take a look at that and help me resolve those issues? I currently have a problem that I'm forced to use Raspbian because playing FHD/1080p videos with omxplayer from Yocto runs choppy (I'm not sure if that's the right word, but playback is not smooth) while with Raspbian it works perfect. Do you think that enabling VC4 graphics driver can solve my issue? Did any of you experienced similar problems? Do you have some other solution or do you know what's the cause of this? Thanks, Piotr Lewicki On 20.05.2016 13:51, Herve Jourdain wrote: > This v2 series addresses the following issues with the first series: > a. Fix the 4.4.10 kernel revision > b. Effectively add vc4-kms-v3d overlay to the list of overlays to > build (forgotten previously) c. Make the parameter to the v4c-kms-v3d > overlay configurable d. Add default values for the cma parameter to > the v4c-kms-v3d overlay, depending on the board (and the memory it > has) > > This patch series enables the support for the VC4 graphics driver from Eric Anholt. > There was a previous patch series by Javier Martinez Canillas, but it required use of a different kernel. > VC4 is now supported in the raspberrypi official kernel, at least for 4.4.9+. > The support in 4.1 exists, but it is NOT STABLE, so it has been deemed unreasonable to support VC4 with 4.1 kernels. > > THEREFORE, VC4 graphics is supported ONLY for kernel versions 4.4.9 and later. > > This patch series proposes to support VC4 by only adding 'vc4graphics' to MACHINE_FEATURES, for raspberrypi. If this is set, it will trigger all the necessary configuration/changes to use the VC4 driver, including mesa/wayland/weston currently, and adding the overlay required. > In order for this series to work, some previous patches are needed (support for .dtbo, and fix of the mesa packaging when there is no DRI driver). > The memory reserved for the VC4 driver has default values depending on the version of the board used, but it can be configured by setting VC4_CMA_SIZE to a value supported by the overlay ('cma-256', 'cma-192', 'cma-128', 'cma-96', 'cma-64'). > 'cma-256' is the recommended value, but it might not be possible on boards with 512MB or DRAM, or less... > 'cma-64' is known to not being able to support FHD/1080p. > > It was tested with wayland/weston, without the support for X11. > > This patch series depends on two other patch series previously posted, that enable the support for .dtbo overlay files. > > Herve Jourdain (13): >rpi-default-providers.inc: change default providers to support > vc4graphics >rpi-base.inc: add vc4-kms-v3d to the overlays to support vc4graphics >raspberrypi.conf: set the default value of VC4_CMA_SIZE to support > vc4graphics >raspberrypi0.conf: set the default value of VC4_CMA_SIZE to support > vc4graphics >raspberrypi2.conf: set the default value of VC4_CMA_SIZE to support > vc4graphics >raspberrypi3.conf: set the default value of VC4_CMA_SIZE to support > vc4graphics >firmware.inc: bump version to support vc4graphics >rpi-config_git.bb: ad
Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for VC4 graphics driver
On 24.05.2016 12:42, Herve Jourdain wrote: Hi Piotr, Hi, There were issues with patches 02, 07 and 12. 02- due to different overlay naming (overlays/vc4-kms-v3d-overlay.dtb instead of overlays/vc4-kms-v3d.dtbo) and 07 and 12 due to bump of linux-raspberrypi from 4.4.8 to 4.4.9 (on master). I know that the omxplayer would not build at this time, because VC4 and userland will conflict, and currently omxplayer depends on userland. I will check if it can be supported with VC4 driver enabled, but for the moment it's true I disabled it in my build. Regarding your patches: 1. Are you using linux kernel 4.4? You should set PREFERRED_VERSION_linux-raspberrypi = "4.4.%" somewhere, either in your distro configuration file, or your local.conf. If you do so, it should get kernel 4.4.10, which requires .dtbo files for overlay. As mentioned in the patch, support for VC4 in 4.1 is not stable, and therefore not supported. I did that :-) 2. I've seen only one TODO, did you make only one modification? There were issues with patches 02, 07 and 12. 02- due to different overlay naming (overlays/vc4-kms-v3d-overlay.dtb instead of overlays/vc4-kms-v3d.dtbo) and 07 and 12 due to bump of linux-raspberrypi from 4.4.8 to 4.4.9 (on master). Now I see that 02 whas not necessary- I just missed the patch you provided earlier. 3. There are other patches that are needed to be applied, before this patch series is applied: 2 for .dtbo support (1 in meta-raspberrypi, 1 in meta), 1 for mesa (to allow packaging with empty DRI). Ok. I didn't know. Can you confirm that I have the right patches? Patch for meta is from thread "[yocto] [PATCH v2 0/1] Support for .dtbo files for dtb overlays"? Patch for meta-raspberrypi is "[yocto] [meta-raspberrypi][PATCH 0/8] Support for vc4 graphics driver"? Patch for mesa is part of those patches above? I'll take a look at the omxplayer issue as soon as I can, in the meanwhile I recommend to not use it... This would be great. Thank you. Herve -Original Message- From: piotr.lewicki [mailto:piotr.lewi...@elfin.de] Sent: mardi 24 mai 2016 11:59 To: Herve Jourdain ; yocto@yoctoproject.org Subject: Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for VC4 graphics driver I have tried these patches, but there were some hunks and errors during applying to current master revision (69840c0bbe03c2e61601e2377c8e2adc264e0478). Building 'rpi-hwup-image' passed, but while building 'rpi-test-image' (omxplayer recipe) I have noticed some errors due to missing files: - IL/OMX_Core.h - VG/openvg.h - bcm_host.h I'm attaching omxplayer_build_errors.txt with build log and my patch with changes created by Herve (adapted to current master revision) - Support_for_VC4_graphics_driver.patch (Herve- if you decide to use that and resend v3 of patches - please remove my TODO from "conf/machine/include/rpi-base.inc" Could you take a look at that and help me resolve those issues? I currently have a problem that I'm forced to use Raspbian because playing FHD/1080p videos with omxplayer from Yocto runs choppy (I'm not sure if that's the right word, but playback is not smooth) while with Raspbian it works perfect. Do you think that enabling VC4 graphics driver can solve my issue? Did any of you experienced similar problems? Do you have some other solution or do you know what's the cause of this? Thanks, Piotr Lewicki On 20.05.2016 13:51, Herve Jourdain wrote: This v2 series addresses the following issues with the first series: a. Fix the 4.4.10 kernel revision b. Effectively add vc4-kms-v3d overlay to the list of overlays to build (forgotten previously) c. Make the parameter to the v4c-kms-v3d overlay configurable d. Add default values for the cma parameter to the v4c-kms-v3d overlay, depending on the board (and the memory it has) This patch series enables the support for the VC4 graphics driver from Eric Anholt. There was a previous patch series by Javier Martinez Canillas, but it required use of a different kernel. VC4 is now supported in the raspberrypi official kernel, at least for 4.4.9+. The support in 4.1 exists, but it is NOT STABLE, so it has been deemed unreasonable to support VC4 with 4.1 kernels. THEREFORE, VC4 graphics is supported ONLY for kernel versions 4.4.9 and later. This patch series proposes to support VC4 by only adding 'vc4graphics' to MACHINE_FEATURES, for raspberrypi. If this is set, it will trigger all the necessary configuration/changes to use the VC4 driver, including mesa/wayland/weston currently, and adding the overlay required. In order for this series to work, some previous patches are needed (support for .dtbo, and fix of the mesa packaging when there is no DRI driver). The memory reserved for the VC4 driver has default values depending on the version of the board used, but it can be configured by setting VC4_CMA_SIZE to a value supported by the overlay ('cma-256', 'cma-192', 'cma-128', 'cma-96', 'cma-64'). 'cma-256' is the recommended value, bu
Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for VC4 graphics driver
Hi Piotr, Please make sure you have the latest series, the 02 was modified actually, and is different from what you have. If meta-raspberrypi was changed since I sent the patch, then there might be some need to rebase it. Dear list, do you need me to send a v3 taking into account the latest modifications of the meta-raspberrypi master, if any? The other patch threads, that are needed, are: 1. [yocto][meta-raspberrypi][PATCH v3 0/5] Support for .dtbo files for dtb overlays, required by kernels 4.4.6+ 2. [yocto][PATCH v2 0/1] Support for .dtbo files for dtb overlays 3. [OE-core][mesa][PATCH v2 0/1] Fix mesa_populate_packages() when dri is disabled [I believe Ross Burton has modified the original one to use oe.path.join() when committing it] To be more specific, I will most likely start by fixing gst-omx (which currently wants to use userland on RPI), then go for omxplayer. Herve -Original Message- From: piotr.lewicki [mailto:piotr.lewi...@elfin.de] Sent: mardi 24 mai 2016 13:08 To: Herve Jourdain ; yocto@yoctoproject.org Subject: Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for VC4 graphics driver On 24.05.2016 12:42, Herve Jourdain wrote: > Hi Piotr, Hi, There were issues with patches 02, 07 and 12. 02- due to different overlay naming (overlays/vc4-kms-v3d-overlay.dtb instead of overlays/vc4-kms-v3d.dtbo) and 07 and 12 due to bump of linux-raspberrypi from 4.4.8 to 4.4.9 (on master). > I know that the omxplayer would not build at this time, because VC4 > and userland will conflict, and currently omxplayer depends on userland. > I will check if it can be supported with VC4 driver enabled, but for > the moment it's true I disabled it in my build. > > Regarding your patches: > 1. Are you using linux kernel 4.4? You should set > PREFERRED_VERSION_linux-raspberrypi = "4.4.%" somewhere, either in > your distro configuration file, or your local.conf. > If you do so, it should get kernel 4.4.10, which requires .dtbo > files for overlay. As mentioned in the patch, support for VC4 in 4.1 > is not stable, and therefore not supported. I did that :-) > 2. I've seen only one TODO, did you make only one modification? There were issues with patches 02, 07 and 12. 02- due to different overlay naming (overlays/vc4-kms-v3d-overlay.dtb instead of overlays/vc4-kms-v3d.dtbo) and 07 and 12 due to bump of linux-raspberrypi from 4.4.8 to 4.4.9 (on master). Now I see that 02 whas not necessary- I just missed the patch you provided earlier. > 3. There are other patches that are needed to be applied, before this > patch series is applied: 2 for .dtbo support (1 in meta-raspberrypi, 1 > in meta), 1 for mesa (to allow packaging with empty DRI). Ok. I didn't know. Can you confirm that I have the right patches? Patch for meta is from thread "[yocto] [PATCH v2 0/1] Support for .dtbo files for dtb overlays"? Patch for meta-raspberrypi is "[yocto] [meta-raspberrypi][PATCH 0/8] Support for vc4 graphics driver"? Patch for mesa is part of those patches above? > I'll take a look at the omxplayer issue as soon as I can, in the > meanwhile I recommend to not use it... This would be great. Thank you. > > Herve > > -Original Message- > From: piotr.lewicki [mailto:piotr.lewi...@elfin.de] > Sent: mardi 24 mai 2016 11:59 > To: Herve Jourdain ; yocto@yoctoproject.org > Subject: Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for > VC4 graphics driver > > I have tried these patches, but there were some hunks and errors > during applying to current master revision > (69840c0bbe03c2e61601e2377c8e2adc264e0478). > Building 'rpi-hwup-image' passed, but while building 'rpi-test-image' > (omxplayer recipe) I have noticed some errors due to missing files: > - IL/OMX_Core.h > - VG/openvg.h > - bcm_host.h > > I'm attaching omxplayer_build_errors.txt with build log and my patch > with changes created by Herve (adapted to current master revision) - > Support_for_VC4_graphics_driver.patch (Herve- if you decide to use > that and resend v3 of patches - please remove my TODO from > "conf/machine/include/rpi-base.inc" > > Could you take a look at that and help me resolve those issues? > > > I currently have a problem that I'm forced to use Raspbian because > playing FHD/1080p videos with omxplayer from Yocto runs choppy (I'm > not sure if that's the right word, but playback is not smooth) while > with Raspbian it works perfect. > Do you think that enabling VC4 graphics driver can solve my issue? > Did any of you experienced similar problems? Do you have some other > solution or do you know what's the cause of this? > > > Thanks, > Piotr Lewicki > > > On 20.05.2016 13:51, Herve Jourdain wrote: >> This v2 series addresses the following issues with the first series: >> a. Fix the 4.4.10 kernel revision >> b. Effectively add vc4-kms-v3d overlay to the list of overlays to >> build (forgotten previously) c. Make the parameter to the v4c-kms-v3d >> overlay configurable d. Add default values for the cma parameter
Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for VC4 graphics driver
So I understand that 1 and 2 should be applied and 3rd is already merged into master (of poky). I cannot wait to for your fixes for gst-omx and later omxplayer. Thanks, Piotr On 24.05.2016 14:06, Herve Jourdain wrote: Hi Piotr, Please make sure you have the latest series, the 02 was modified actually, and is different from what you have. If meta-raspberrypi was changed since I sent the patch, then there might be some need to rebase it. Dear list, do you need me to send a v3 taking into account the latest modifications of the meta-raspberrypi master, if any? The other patch threads, that are needed, are: 1. [yocto][meta-raspberrypi][PATCH v3 0/5] Support for .dtbo files for dtb overlays, required by kernels 4.4.6+ 2. [yocto][PATCH v2 0/1] Support for .dtbo files for dtb overlays 3. [OE-core][mesa][PATCH v2 0/1] Fix mesa_populate_packages() when dri is disabled [I believe Ross Burton has modified the original one to use oe.path.join() when committing it] To be more specific, I will most likely start by fixing gst-omx (which currently wants to use userland on RPI), then go for omxplayer. Herve -Original Message- From: piotr.lewicki [mailto:piotr.lewi...@elfin.de] Sent: mardi 24 mai 2016 13:08 To: Herve Jourdain ; yocto@yoctoproject.org Subject: Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for VC4 graphics driver On 24.05.2016 12:42, Herve Jourdain wrote: Hi Piotr, Hi, There were issues with patches 02, 07 and 12. 02- due to different overlay naming (overlays/vc4-kms-v3d-overlay.dtb instead of overlays/vc4-kms-v3d.dtbo) and 07 and 12 due to bump of linux-raspberrypi from 4.4.8 to 4.4.9 (on master). I know that the omxplayer would not build at this time, because VC4 and userland will conflict, and currently omxplayer depends on userland. I will check if it can be supported with VC4 driver enabled, but for the moment it's true I disabled it in my build. Regarding your patches: 1. Are you using linux kernel 4.4? You should set PREFERRED_VERSION_linux-raspberrypi = "4.4.%" somewhere, either in your distro configuration file, or your local.conf. If you do so, it should get kernel 4.4.10, which requires .dtbo files for overlay. As mentioned in the patch, support for VC4 in 4.1 is not stable, and therefore not supported. I did that :-) 2. I've seen only one TODO, did you make only one modification? There were issues with patches 02, 07 and 12. 02- due to different overlay naming (overlays/vc4-kms-v3d-overlay.dtb instead of overlays/vc4-kms-v3d.dtbo) and 07 and 12 due to bump of linux-raspberrypi from 4.4.8 to 4.4.9 (on master). Now I see that 02 whas not necessary- I just missed the patch you provided earlier. 3. There are other patches that are needed to be applied, before this patch series is applied: 2 for .dtbo support (1 in meta-raspberrypi, 1 in meta), 1 for mesa (to allow packaging with empty DRI). Ok. I didn't know. Can you confirm that I have the right patches? Patch for meta is from thread "[yocto] [PATCH v2 0/1] Support for .dtbo files for dtb overlays"? Patch for meta-raspberrypi is "[yocto] [meta-raspberrypi][PATCH 0/8] Support for vc4 graphics driver"? Patch for mesa is part of those patches above? I'll take a look at the omxplayer issue as soon as I can, in the meanwhile I recommend to not use it... This would be great. Thank you. Herve -Original Message- From: piotr.lewicki [mailto:piotr.lewi...@elfin.de] Sent: mardi 24 mai 2016 11:59 To: Herve Jourdain ; yocto@yoctoproject.org Subject: Re: [yocto] [meta-raspberrypi][PATCH v2 00/13] Support for VC4 graphics driver I have tried these patches, but there were some hunks and errors during applying to current master revision (69840c0bbe03c2e61601e2377c8e2adc264e0478). Building 'rpi-hwup-image' passed, but while building 'rpi-test-image' (omxplayer recipe) I have noticed some errors due to missing files: - IL/OMX_Core.h - VG/openvg.h - bcm_host.h I'm attaching omxplayer_build_errors.txt with build log and my patch with changes created by Herve (adapted to current master revision) - Support_for_VC4_graphics_driver.patch (Herve- if you decide to use that and resend v3 of patches - please remove my TODO from "conf/machine/include/rpi-base.inc" Could you take a look at that and help me resolve those issues? I currently have a problem that I'm forced to use Raspbian because playing FHD/1080p videos with omxplayer from Yocto runs choppy (I'm not sure if that's the right word, but playback is not smooth) while with Raspbian it works perfect. Do you think that enabling VC4 graphics driver can solve my issue? Did any of you experienced similar problems? Do you have some other solution or do you know what's the cause of this? Thanks, Piotr Lewicki On 20.05.2016 13:51, Herve Jourdain wrote: This v2 series addresses the following issues with the first series: a. Fix the 4.4.10 kernel revision b. Effectively add vc4-kms-v3d overlay to the list of overlays to build (forgotten previously) c. Make the parame
Re: [yocto] Change in override behavior?
On Fri, 2016-04-29 at 22:09 +1200, Paul Eggleton wrote: > On Fri, 29 Apr 2016 12:00:58 Gary Thomas wrote: > > On 2016-04-29 11:51, Paul Eggleton wrote: > > > On Fri, 29 Apr 2016 09:24:23 Gary Thomas wrote: > > > > On 2016-04-29 09:16, Paul Eggleton wrote: > > > > Indeed, my machine names do have an upper case letter in them. > > > > Any suggestions for how to handle this (short of renaming > > > > everything > > > > which > > > > would be a HUGE chore)? > > > > > > It's no longer supported I'm afraid, BitBake's datastore is now > > > coded to > > > expect lowercase for all override values. You say it's a huge > > > chore but > > > surely a grep -l | xargs -n1 sed -i would do it? > > > > If I were to rename my target (MACHINE), I'd then have to go > > through > > and rename all of the directories in the recipes that hold machine > > customizations and there are quite a few of those. Similarly I'd > > have to rework all the recipes that use the old names (with upper > > case > > letters) to the new ones. Not impossible, but quite a lot of work. > > That is unfortunate, but again should be pretty easy to automate > (assuming > they are local of course and not proliferated across many users' > build > machines). > > > Short of actually renaming the target machines, I could add an > > additional > > override (in .conf) that is lowercase only and update just > > the > > recipes to use that instead. > > > > By experimentation, I have found that XYZ_append_ seems to > > do > > the correct thing, even when has upper case letters. > > Maybe this > > is an oversight that will be fixed? > > I'm not sure - Richard? Sorry for the delay in getting to this. It does sound like there is a codepath in bitbake which is still recognising variables with mixed case. I took a quick look and think this change appears to address it: diff --git a/bitbake/lib/bb/data_smart.py b/bitbake/lib/bb/data_smart.py index 25c412c..ec6709f 100644 --- a/bitbake/lib/bb/data_smart.py +++ b/bitbake/lib/bb/data_smart.py @@ -39,7 +39,7 @@ from bb.COW import COWDictBase logger = logging.getLogger("BitBake.Data") __setvar_keyword__ = ["_append", "_prepend", "_remove"] -__setvar_regexp__ = re.compile('(?P.*?)(?P_append|_prepend|_remove)(_(?P.*))?$') +__setvar_regexp__ = re.compile('(?P.*?)(?P_append|_prepend|_remove)(_(?P[^A-Z]*))?$') __expand_var_regexp__ = re.compile(r"\${[^{}@\n\t :]+}") __expand_python_regexp__ = re.compile(r"\${@.+?}") Cheers, Richard -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [yocto-autobuilder][PATCH] bin/release_scripts/release.py
pulled into master. thanks! -b On 24 May 2016 at 03:12, Graydon, Tracy wrote: > Remove the step for syncing the staged release to downloads directory. We > pretty much NEVER do the sync to downloads at the time we do staging. Sync > happens much later, as a separate process. We don't need this in the release > script. > > Signed-off-by: Graydon, Tracy > --- > bin/release_scripts/release.py | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/bin/release_scripts/release.py b/bin/release_scripts/release.py > index 3d4ce39..2b4d21c 100755 > --- a/bin/release_scripts/release.py > +++ b/bin/release_scripts/release.py > @@ -488,17 +488,7 @@ if __name__ == '__main__': > print "Generating the master md5sum table." > gen_rel_md5(RELEASE_DIR, REL_MD5_FILE) > > -# 8) sync to downloads > -if REL_TYPE == "milestone": > -DL_DIR = os.path.join(DL_BASE, "milestones", RELEASE) > -print "DL_DIR for milestones: %s" %DL_DIR > -else: > -DL_DIR = os.path.join(DL_BASE, RELEASE) > -print "DL_DIR for point/major: %s" %DL_DIR > -print "Publishing release to downloads." > -sync_it(RELEASE_DIR, DL_DIR, "") > - > -# 9) Publish the ADT repo. The default is NOT to publish the ADT. The ADT > +# 8) Publish the ADT repo. The default is NOT to publish the ADT. The ADT > # is deprecated as of 2.1_M1. However, we need to retain backward > # compatability for point releases, etc. We do this step after all the > other > # stuff because we want the symlinks to have been converted, extraneous > -- > 2.7.0 > -- Elizabeth Flanagan Yocto Project Build and Release -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] Retrieve SRCREV variable value outside of a specific recipe (not modifying it)
Hi, My goal is to pull recipe's SRCREV variable into a top level *.bbclass file. I understand we can use SRCREV_pn- to modify the revision on the fly outside of recipe in configuration files but when I print out SRCREV information using ${SRCREV_pn-recipename} all I got back is the recipe name instead of SREREV value for that specific recipe. Is there a way to retrieve SREREV value outside of recipe? Thanks, Michael -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] Retrieve SRCREV variable value outside of a specific recipe (not modifying it)
On Tue, May 24, 2016 at 7:32 AM, Michael Hu wrote: > Hi, > > My goal is to pull recipe's SRCREV variable into a top level *.bbclass > file. I understand we can use SRCREV_pn- to modify the > revision on the fly outside of recipe in configuration files but when I > print out SRCREV information using ${SRCREV_pn-recipename} all I got back > is the recipe name instead of SREREV value for that specific recipe. > > Is there a way to retrieve SREREV value outside of recipe? > One recipe cannot access metadata from another, nor can config metadata access recipe metadata, by design. I'd recommend enabling buildhistory and using the buildhistory-collect-srcrevs script, which dumps SRCREV_pn- lines for recipes, for use in a .conf/.inc/.bbclass. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [yocto-autobuilder][PATCH] bin/release_scripts/release.py
On Mon, 2016-05-23 at 19:07 -0700, Graydon, Tracy wrote: > Fixed the path for the publishing of the eclipse plugins. They were > going to the wrong subdirectory under downloads. > > Signed-off-by: Graydon, Tracy > --- > bin/release_scripts/release.py | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/bin/release_scripts/release.py b/bin/release_scripts/release.py > index 51cd607..3d4ce39 100755 > --- a/bin/release_scripts/release.py > +++ b/bin/release_scripts/release.py > @@ -340,18 +340,18 @@ def publish_adt(rel_id, rel_type, opts): > QEMU_TARGET = os.path.join(ADT_ROOTFS, dirname) > print "QEMU_SRC: %s" %QEMU_SRC > sync_it(QEMU_SRC, QEMU_TARGET, "") > - > sync_it(IPK_DIR, ADT_IPK, "") > return > > if __name__ == '__main__': > - > + > os.system("clear") > print > - > + > VHOSTS = "/srv/www/vhosts" > AB_BASE = os.path.join(VHOSTS, > "autobuilder.yoctoproject.org/pub/releases") > -DL_BASE = os.path.join(VHOSTS, > "downloads.yoctoproject.org/releases/yocto") > +DL_DIR = os.path.join(VHOSTS, "downloads.yoctoproject.org/releases") > +DL_BASE = os.path.join(DL_DIR, "/releases/yocto") > ADT_BASE = os.path.join(VHOSTS, "adtrepo.yoctoproject.org") > So is the intent is to create a new DL_BASE directory downloads.yoctoproject.org/releases/releases/yocto or should that be: DL_BASE = os.path.join(DL_DIR, "/yocto") -Bill -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [yocto-autobuilder][PATCH] bin/release_scripts/relnotes.py
Works better for all major/point releases if the poky version isn't hardcoded to 14.0.1. Fixed that. Signed-off-by: Graydon, Tracy --- bin/release_scripts/relnotes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/release_scripts/relnotes.py b/bin/release_scripts/relnotes.py index 6476364..6eccbe4 100755 --- a/bin/release_scripts/relnotes.py +++ b/bin/release_scripts/relnotes.py @@ -132,7 +132,7 @@ if __name__ == '__main__': os.chdir(RELEASE_DIR) files = glob.glob('*.bz2') allfiles = filter(lambda f: os.path.isfile(f), files) -found = filter(lambda x: '14.0.1' not in x, allfiles) +found = filter(lambda x: POKY_VER not in x, allfiles) filelist = filter(lambda z: 'fsl' not in z, found) filelist.sort() for item in filelist: -- 2.7.0 -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [yocto-autobuilder][PATCH] bin/release_scripts/release.py
On 05/24/16, 8:46 AM, "Randle, William C" wrote: >On Mon, 2016-05-23 at 19:07 -0700, Graydon, Tracy wrote: >> Fixed the path for the publishing of the eclipse plugins. They were >> going to the wrong subdirectory under downloads. >> >> Signed-off-by: Graydon, Tracy >> --- >> bin/release_scripts/release.py | 22 +++--- >> 1 file changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/bin/release_scripts/release.py >>b/bin/release_scripts/release.py >> index 51cd607..3d4ce39 100755 >> --- a/bin/release_scripts/release.py >> +++ b/bin/release_scripts/release.py >> @@ -340,18 +340,18 @@ def publish_adt(rel_id, rel_type, opts): >> QEMU_TARGET = os.path.join(ADT_ROOTFS, dirname) >> print "QEMU_SRC: %s" %QEMU_SRC >> sync_it(QEMU_SRC, QEMU_TARGET, "") >> - >> sync_it(IPK_DIR, ADT_IPK, "") >> return >> >> if __name__ == '__main__': >> - >> + >> os.system("clear") >> print >> - >> + >> VHOSTS = "/srv/www/vhosts" >> AB_BASE = os.path.join(VHOSTS, >> "autobuilder.yoctoproject.org/pub/releases") >> -DL_BASE = os.path.join(VHOSTS, >> "downloads.yoctoproject.org/releases/yocto") >> +DL_DIR = os.path.join(VHOSTS, >>"downloads.yoctoproject.org/releases") >> +DL_BASE = os.path.join(DL_DIR, "/releases/yocto") >> ADT_BASE = os.path.join(VHOSTS, "adtrepo.yoctoproject.org") >> >So is the intent is to create a new DL_BASE >directory downloads.yoctoproject.org/releases/releases/yocto or should >that be: >DL_BASE = os.path.join(DL_DIR, "/yocto") > >-Bill > Argh. No, that DL_BASE line shouldn’t be there. It’s cruft. I thought I had deleted it. Thanks for catching. I will resubmit the patch with that fix. -t -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [yocto-autobuilder][PATCH] bin/release_scripts/release.py
Get rid of the extraneous DL_BASE line. It's not used and should have been removed when I fixed the eclipse-plugin release path. Signed-off-by: Graydon, Tracy --- bin/release_scripts/release.py | 1 - 1 file changed, 1 deletion(-) diff --git a/bin/release_scripts/release.py b/bin/release_scripts/release.py index 2b4d21c..89f68be 100755 --- a/bin/release_scripts/release.py +++ b/bin/release_scripts/release.py @@ -351,7 +351,6 @@ if __name__ == '__main__': VHOSTS = "/srv/www/vhosts" AB_BASE = os.path.join(VHOSTS, "autobuilder.yoctoproject.org/pub/releases") DL_DIR = os.path.join(VHOSTS, "downloads.yoctoproject.org/releases") -DL_BASE = os.path.join(DL_DIR, "/releases/yocto") ADT_BASE = os.path.join(VHOSTS, "adtrepo.yoctoproject.org") # List of the directories we delete from all releases -- 2.7.0 -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [yocto-autobuilder][PATCH] bin/release_scripts/release.py
On Tue, 2016-05-24 at 16:06 -0700, Graydon, Tracy wrote: > Get rid of the extraneous DL_BASE line. It's not used and should have > been removed when I fixed the eclipse-plugin release path. > > Signed-off-by: Graydon, Tracy > --- > bin/release_scripts/release.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/bin/release_scripts/release.py b/bin/release_scripts/release.py > index 2b4d21c..89f68be 100755 > --- a/bin/release_scripts/release.py > +++ b/bin/release_scripts/release.py > @@ -351,7 +351,6 @@ if __name__ == '__main__': > VHOSTS = "/srv/www/vhosts" > AB_BASE = os.path.join(VHOSTS, > "autobuilder.yoctoproject.org/pub/releases") > DL_DIR = os.path.join(VHOSTS, "downloads.yoctoproject.org/releases") > -DL_BASE = os.path.join(DL_DIR, "/releases/yocto") > ADT_BASE = os.path.join(VHOSTS, "adtrepo.yoctoproject.org") > > # List of the directories we delete from all releases Since your previous version of this patch has not yet been applied to master, I would think it would be better to incorporate this as part of a V2 of your previous patch, rather than a new patch on top of an as yet unapplied patch. -Bill -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [yocto-autobuilder][PATCH] bin/release_scripts/release.py
On 05/24/16, 4:30 PM, "Randle, William C" wrote: >On Tue, 2016-05-24 at 16:06 -0700, Graydon, Tracy wrote: >> Get rid of the extraneous DL_BASE line. It's not used and should have >> been removed when I fixed the eclipse-plugin release path. >> >> Signed-off-by: Graydon, Tracy >> --- >> bin/release_scripts/release.py | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/bin/release_scripts/release.py >>b/bin/release_scripts/release.py >> index 2b4d21c..89f68be 100755 >> --- a/bin/release_scripts/release.py >> +++ b/bin/release_scripts/release.py >> @@ -351,7 +351,6 @@ if __name__ == '__main__': >> VHOSTS = "/srv/www/vhosts" >> AB_BASE = os.path.join(VHOSTS, >> "autobuilder.yoctoproject.org/pub/releases") >> DL_DIR = os.path.join(VHOSTS, >>"downloads.yoctoproject.org/releases") >> -DL_BASE = os.path.join(DL_DIR, "/releases/yocto") >> ADT_BASE = os.path.join(VHOSTS, "adtrepo.yoctoproject.org") >> >> # List of the directories we delete from all releases > >Since your previous version of this patch has not yet been applied to >master, I >would think it would be better to incorporate this as part of a V2 of your >previous patch, rather than a new patch on top of an as yet unapplied >patch. Ah, you are right. I thought it had been pulled in already. I’ll rebase. > >-Bill -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto