Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nick Wellnhofer]

On 22/11/2018 18:32, Daniel Veillard via xml wrote:

Please give it some testing, if we need to make changes I will likely push
an RC2 mid next week, and if everything goes well I will push 2.9.9 final
end of next week.


Built and tested (with `make check`) succesfully on:

- Windows 10
  - MingW64, gcc 7.2.0, both 64 and 32 bits (requires CFLAGS=-posix
and PRINTF_EXPONENT_DIGITS=2 to make the XPath tests pass)
  - MSVC 14.11
- macOS 10.14 with stock command-line developer tools

Nick

___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Shlomi Fish]

Hi,

On Thu, 22 Nov 2018 18:32:59 +0100
Daniel Veillard via xml  wrote:

>   I have just tagged the Release Candidate 1 in git and pushed a signed
> tarball and signed rpms to the usual place:
> 
>   ftp://xmlsoft.org/libxml2/
> 
> (also available as http://xmlsoft.org/download/)
> 

I am getting a failure in one of the tests of
https://github.com/shlomif/perl-XML-LibXML - it works fine with 2.9.8:

Test Summary Report
---
t/40reader.t (Wstat: 256 Tests: 100 Failed: 1)
  Failed test:  79
  Non-zero exit status: 1
Files=1, Tests=100,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.12 cusr  0.04 
csys =  0.21 CPU)
Result: FAIL
shlomif[XML-LibXML]:$trunk$ gvim s
shlomif[XML-LibXML]:$trunk$ prove -b t/40reader.t   
t/40reader.t .. 1/100 
#   Failed test 'preserved content'
#   at t/40reader.t line 184.
#  got: ' xx preserved yy FOO
#   
#   
#   '
# expected: 'preserved'
# Looks like you failed 1 test of 100.
t/40reader.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/100 subtests 

Test Summary Report
---
t/40reader.t (Wstat: 256 Tests: 100 Failed: 1)
  Failed test:  79
  Non-zero exit status: 1
Files=1, Tests=100,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.12 cusr  0.01 
csys =  0.17 CPU)
Result: FAIL
shlomif[XML-LibXML]:$trunk$ 



-- 
-
Shlomi Fish   http://www.shlomifish.org/
Selina Mandrake - The Slayer (Buffy parody) - http://shlom.in/selina

Sarah: Ken, would you like some more juice?
Ken: No, Sarah, that's OK, I’m stuffed. Anyway, I think I’ll return to my
dimension of evil now - they will be clueless without me. Thanks for everything.
— http://www.shlomifish.org/humour/Buffy/A-Few-Good-Slayers/

Please reply to list if it's a mailing list post - http://shlom.in/reply .
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Stefan Behnel]

Salut Daniel!

Daniel Veillard via xml schrieb am 22.11.18 um 18:32:
>   I have just tagged the Release Candidate 1 in git and pushed a signed
> tarball and signed rpms to the usual place:
> 
>   ftp://xmlsoft.org/libxml2/

I think something changed in the RelaxNG code. When I try to validate a
simple Schematron schema file (attached) against the schematron RNG spec here:

https://github.com/lxml/lxml/blob/82601a09d015bc3e7a4090223fcbb9a5d5d4590d/src/lxml/isoschematron/resources/rng/iso-schematron.rng

it validates in libxml2 2.9.4 (sorry, that's what I have installed, but I'm
pretty sure it also worked with at least 2.9.7 and probably also 2.9.8) but
fails in 2.9.9-rc1. I attached the output of both attempts.

Specifically, I get the following error, which seems nonsense, given that
"title" is the first child:

"""
-:3: element title: Relax-NG validity error : Expecting element p, got title
Relax-NG validity error : Extra element rule in interleave
"""

Something seems to be wrong with the interleave/group combination in the
schema, lines 56/61.

Any idea?

Stefan
$ xmllint --relaxng src/lxml/isoschematron/resources/rng/iso-schematron.rng - 


Open Model

 BBB element is not present
 CCC element is not present



Closed model"

 BBB element is not present
 CCC element is not present
There is an extra 
element



EOF


http://purl.oclc.org/dsdl/schematron";>

Open Model

 BBB element is not present
 CCC element is not present



Closed model"

 BBB element is not present
 CCC element is not present
There is an extra 
element



- validates

$ build/tmp/libxml2-2.9.9/xmllint --relaxng 
src/lxml/isoschematron/resources/rng/iso-schematron.rng - 

Open Model

 BBB element is not present
 CCC element is not present



Closed model"

 BBB element is not present
 CCC element is not present
There is an extra 
element



EOF


http://purl.oclc.org/dsdl/schematron";>

Open Model

 BBB element is not present
 CCC element is not present



Closed model"

 BBB element is not present
 CCC element is not present
There is an extra 
element



-:3: element title: Relax-NG validity error : Expecting element p, got title
Relax-NG validity error : Extra element rule in interleave
-:4: element rule: Relax-NG validity error : Element pattern failed to validate 
content
-:10: element title: Relax-NG validity error : Expecting element p, got title
Relax-NG validity error : Extra element rule in interleave
-:11: element rule: Relax-NG validity error : Element pattern failed to 
validate content
-:9: element pattern: Relax-NG validity error : Expecting element p, got pattern
Relax-NG validity error : Extra element pattern in interleave
-:9: element pattern: Relax-NG validity error : Element schema failed to 
validate content
- fails to validate
http://purl.oclc.org/dsdl/schematron";>

Open Model

 BBB element is not present
 CCC element is not present



Closed model"

 BBB element is not present
 CCC element is not present
There is an extra 
element



___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nick Wellnhofer]

On 23/11/2018 20:51, Shlomi Fish wrote:

I am getting a failure in one of the tests of
https://github.com/shlomif/perl-XML-LibXML - it works fine with 2.9.8:


Can you check if it's caused by one of the following commits?

https://gitlab.gnome.org/GNOME/libxml2/commit/d2ef114c6b0d9a840b94cdecf554a873fc6f6df5
https://gitlab.gnome.org/GNOME/libxml2/commit/bfec41b3de1cbd35e547b57c80ae3a5101f8891c
https://gitlab.gnome.org/GNOME/libxml2/commit/39fbfb4fd08eae88d4b0c15f3a8ac33babc740e6

Thanks,
Nick
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nick Wellnhofer]

On 23/11/2018 22:38, Nick Wellnhofer wrote:

On 23/11/2018 20:51, Shlomi Fish wrote:

I am getting a failure in one of the tests of
https://github.com/shlomif/perl-XML-LibXML - it works fine with 2.9.8:


Can you check if it's caused by one of the following commits?


Nevermind, it's this commit:

https://gitlab.gnome.org/GNOME/libxml2/commit/bfec41b3de1cbd35e547b57c80ae3a5101f8891c

It seems that XML::LibXML implements its own workaround for 
xmlTextReaderNextSibling only being supported on preparsed documents:


https://github.com/shlomif/perl-XML-LibXML/blob/master/LibXML.xs#L8667

The function now claims to work without preparsed documents, so the workaround 
isn't used. But apparently there's problem with the commit. I'm CC'ing the 
author. If we can't get this fixed, let's revert.


Nick
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Earnie via xml]

On 11/23/2018 1:11 PM, Nick Wellnhofer wrote:

On 22/11/2018 18:32, Daniel Veillard via xml wrote:
Please give it some testing, if we need to make changes I will likely 
push

an RC2 mid next week, and if everything goes well I will push 2.9.9 final
end of next week.


Built and tested (with `make check`) succesfully on:

- Windows 10
   - MingW64, gcc 7.2.0, both 64 and 32 bits (requires CFLAGS=-posix


I suggest that you test with gcc 8.x.x as well if possible.  I don't 
have version 8 as yet and no time to build it at the moment.


--
Earnie
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nikolai Weibull via xml]

Hi!

Stefan Behnel, 2018-11-23 21:54:


I think something changed in the RelaxNG code.


Yes, it seems that my patch for data in interleaves was added and 
this may be the cause of these issues.  The regression tests 
didn’t display them, so this is something different.  Could we 
perhaps get a minimal test that breaks?


 Nikolai
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nikolai Weibull via xml]

Hi!

Daniel Veillard via xml, 2018-11-22 18:32:

  I have just tagged the Release Candidate 1 in git and pushed a 
  signed

tarball and signed rpms to the usual place:


Could we please get merge request 10 into 


https://gitlab.gnome.org/GNOME/libxml2/merge_requests/10

this release?  It fixes various issues with the RELAX NG code and 
it even has tests!


 Nikolai
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml