[Xen-devel] [distros-debian-stretch test] 66608: tolerable trouble: blocked/broken
flight 66608 distros-debian-stretch real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66608/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-armhf-pvops 3 host-install(3) broken like 66552 build-armhf 3 host-install(3) broken like 66552 build-amd64 3 host-install(3) broken like 66552 build-amd64-pvops 3 host-install(3) broken like 66552 build-i3863 host-install(3) broken like 66552 build-i386-pvops 3 host-install(3) broken like 66552 Tests which did not succeed, but are not blocking: test-amd64-amd64-amd64-stretch-netboot-pvgrub 1 build-check(1)blocked n/a test-amd64-i386-i386-stretch-netboot-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-i386-stretch-netboot-pygrub 1 build-check(1) blocked n/a test-amd64-i386-amd64-stretch-netboot-pygrub 1 build-check(1) blocked n/a test-armhf-armhf-armhf-stretch-netboot-pygrub 1 build-check(1)blocked n/a baseline version: flight 66552 jobs: build-amd64 broken build-armhf broken build-i386 broken build-amd64-pvopsbroken build-armhf-pvopsbroken build-i386-pvops broken test-amd64-amd64-amd64-stretch-netboot-pvgrubblocked test-amd64-i386-i386-stretch-netboot-pvgrub blocked test-amd64-i386-amd64-stretch-netboot-pygrub blocked test-armhf-armhf-armhf-stretch-netboot-pygrubblocked test-amd64-amd64-i386-stretch-netboot-pygrub blocked sg-report-flight on osstest.xs.citrite.net logs: /home/osstest/logs images: /home/osstest/images Logs, config files, etc. are available at http://osstest.xs.citrite.net/~osstest/testlogs/logs Test harness code can be found at http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary Push not applicable. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [linux-3.18 test] 97377: regressions - FAIL
flight 97377 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/97377/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-freebsd10-amd64 9 freebsd-installfail REGR. vs. 96188 test-amd64-amd64-pygrub 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-xl-qemut-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 96188 test-amd64-amd64-xl-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96188 test-armhf-armhf-xl 9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96188 test-armhf-armhf-xl-xsm 9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl-qemut-win7-amd64 9 windows-installfail REGR. vs. 96188 test-amd64-i386-qemut-rhel6hvm-amd 9 redhat-install fail REGR. vs. 96188 test-amd64-i386-xl-qemut-winxpsp3 9 windows-install fail REGR. vs. 96188 test-armhf-armhf-libvirt 9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl-qemut-winxpsp3-vcpus1 9 windows-install fail REGR. vs. 96188 test-amd64-amd64-amd64-pvgrub 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-multivcpu 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-xl-xsm9 debian-installfail REGR. vs. 96188 test-amd64-amd64-xl-qcow2 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemut-winxpsp3 6 xen-bootfail REGR. vs. 96188 test-amd64-amd64-xl 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-i386-pvgrub 6 xen-boot fail REGR. vs. 96188 test-armhf-armhf-libvirt-xsm 9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 9 windows-install fail REGR. vs. 96188 test-amd64-i386-qemut-rhel6hvm-intel 9 redhat-installfail REGR. vs. 96188 test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 96188 test-amd64-amd64-libvirt 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-freebsd10-i386 9 freebsd-install fail REGR. vs. 96188 test-amd64-i386-xl-qemut-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96188 test-armhf-armhf-xl-multivcpu 9 debian-install fail REGR. vs. 96188 test-armhf-armhf-xl-cubietruck 9 debian-install fail REGR. vs. 96188 test-amd64-i386-qemuu-rhel6hvm-amd 9 redhat-install fail REGR. vs. 96188 test-amd64-amd64-xl-qemut-win7-amd64 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemuu-debianhvm-amd64 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96188 test-amd64-i386-libvirt-xsm 9 debian-installfail REGR. vs. 96188 test-amd64-amd64-libvirt-vhd 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-pvh-amd 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-qemuu-nested-intel 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemut-debianhvm-amd64 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemuu-winxpsp3 6 xen-bootfail REGR. vs. 96188 test-amd64-amd64-xl-pvh-intel 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemuu-win7-amd64 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-libvirt-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-qemuu-rhel6hvm-intel 9 redhat-installfail REGR. vs. 96188 test-amd64-amd64-xl-qemuu-ovmf-amd64 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-xl-qemuu-win7-amd64 9 windows-installfail REGR. vs. 96188 test-amd64-i386-libvirt 9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl-raw9 debian-di-install fail REGR. vs. 96188 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-qemuu-nested-amd 6 xen-boot fail REGR. vs. 96188 test-armhf-armhf-xl-vhd 9 debian-di-install fail REGR. vs. 96188 test-amd64-i386-xl-qemuu-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 96188 test-amd64-i386-libvirt-pair 15 debian-install/dst_host fail REGR. vs. 96188 test-armhf-armhf-xl-credit2 9 debian-installfail REGR. vs. 96188 test-armhf-armhf-xl-arndale 9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl-qemuu-winxpsp3 9 windows-install fail REGR. vs. 96188 test-amd64-i386-pair
[Xen-devel] [qemu-mainline test] 97396: regressions - trouble: broken/fail/pass
flight 97396 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/97396/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 3 host-install(3) broken REGR. vs. 96791 test-amd64-amd64-libvirt-xsm 11 guest-start fail REGR. vs. 96791 test-amd64-amd64-libvirt-pair 20 guest-start/debian fail REGR. vs. 96791 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96791 test-amd64-amd64-libvirt 11 guest-start fail REGR. vs. 96791 test-amd64-amd64-xl-qcow2 9 debian-di-install fail REGR. vs. 96791 test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 96791 test-amd64-amd64-libvirt-vhd 9 debian-di-install fail REGR. vs. 96791 Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 96791 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail like 96791 test-amd64-amd64-xl-rtds 9 debian-install fail like 96791 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-pvh-amd 11 guest-start fail never pass test-amd64-amd64-xl-pvh-intel 11 guest-start fail never pass test-armhf-armhf-libvirt 14 guest-saverestorefail never pass test-armhf-armhf-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 12 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 13 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-qcow2 11 migrate-support-checkfail never pass test-armhf-armhf-libvirt-qcow2 13 guest-saverestorefail never pass test-amd64-i386-libvirt 12 migrate-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2 fail never pass test-amd64-i386-libvirt-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 12 migrate-support-checkfail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-credit2 12 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt-xsm 14 guest-saverestorefail never pass test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-raw 13 guest-saverestorefail never pass test-armhf-armhf-libvirt-raw 11 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 12 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 11 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 12 saverestore-support-checkfail never pass version targeted for testing: qemuu6b92bbfe812746fe7841a24c24e6460f5359ce72 baseline version: qemuu4f4a9ca4a4386c137301b3662faba076455ff15a Last test of basis96791 2016-07-08 12:20:07 Z7 days Failing since 97271 2016-07-13 13:44:26 Z2 days5 attempts Testing same since97396 2016-07-15 21:43:55 Z0 days1 attempts People who touched revisions under test: Alberto Garcia Alex Bennée Alexander Yarygin Andrew Jones Anthony PERARD Ashok Raj Cao jin Cornelia Huck Cédric Le Goater Daniel P. Berrange David Gibson David Hildenbrand Denis V. Lunev Dmitry Osipenko Eduardo Habkost Eric Blake Eugene (jno) Dvurechenski Evgeny Yakovlev Fam Zheng Gerd Hoffmann Gonglei Haibin Wang Haozhong Zhang Igor Mammedov James Hogan Jarkko Lavinen Jeff Cody Jing Liu Kevin Wolf Laszlo Ersek Leon Alrae Lin Ma Marc Marà Marc-André Lureau Marcin Krzeminski Mark Cave-Ayland Markus Armbruster Max Filippov Max Reitz Paolo Bonzini Paul Burton Peter Lieven Peter Maydell Pierre Morel Reda Sallahi Richard Henderson Richard W.M. Jones Samuel Damashek Sascha Silbe Sean Bruno Sergey Sorokin Stanislav Shmarov S
[Xen-devel] [linux-4.1 test] 97394: regressions - FAIL
flight 97394 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/97394/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 96211 test-amd64-i386-xl-qemut-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96211 test-amd64-i386-xl-qemuu-winxpsp3 9 windows-install fail REGR. vs. 96211 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96211 test-amd64-amd64-xl-multivcpu 6 xen-boot fail REGR. vs. 96211 test-amd64-i386-qemut-rhel6hvm-amd 9 redhat-install fail REGR. vs. 96211 test-amd64-i386-qemuu-rhel6hvm-intel 9 redhat-installfail REGR. vs. 96211 test-amd64-i386-xl-qemut-winxpsp3-vcpus1 9 windows-install fail REGR. vs. 96211 test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 9 windows-install fail REGR. vs. 96211 test-amd64-amd64-xl-qemut-debianhvm-amd64 6 xen-boot fail REGR. vs. 96211 test-amd64-i386-xl-xsm9 debian-installfail REGR. vs. 96211 test-amd64-i386-libvirt 9 debian-installfail REGR. vs. 96211 test-amd64-i386-xl-qemut-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 96211 test-amd64-i386-freebsd10-amd64 9 freebsd-installfail REGR. vs. 96211 test-amd64-amd64-xl-credit2 6 xen-boot fail REGR. vs. 96211 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96211 test-amd64-i386-xl9 debian-installfail REGR. vs. 96211 test-amd64-i386-xl-qemut-winxpsp3 9 windows-install fail REGR. vs. 96211 test-amd64-i386-xl-raw9 debian-di-install fail REGR. vs. 96211 test-amd64-i386-qemuu-rhel6hvm-amd 9 redhat-install fail REGR. vs. 96211 test-armhf-armhf-xl-arndale 9 debian-installfail REGR. vs. 96211 test-amd64-i386-freebsd10-i386 9 freebsd-install fail REGR. vs. 96211 test-armhf-armhf-xl 9 debian-installfail REGR. vs. 96211 test-armhf-armhf-libvirt-xsm 9 debian-installfail REGR. vs. 96211 test-armhf-armhf-xl-xsm 9 debian-installfail REGR. vs. 96211 test-amd64-i386-libvirt-xsm 9 debian-installfail REGR. vs. 96211 test-amd64-amd64-xl-xsm 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-i386-pvgrub 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-qemuu-nested-amd 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-xl-qemut-win7-amd64 6 xen-boot fail REGR. vs. 96211 test-armhf-armhf-xl-multivcpu 9 debian-install fail REGR. vs. 96211 test-armhf-armhf-libvirt 9 debian-installfail REGR. vs. 96211 test-armhf-armhf-xl-cubietruck 9 debian-install fail REGR. vs. 96211 test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-xl-qemut-winxpsp3 6 xen-bootfail REGR. vs. 96211 test-amd64-amd64-xl 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-qemuu-nested-intel 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-pygrub 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-xl-qemuu-debianhvm-amd64 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-xl-pvh-amd 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-xl-qcow2 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-libvirt-vhd 6 xen-boot fail REGR. vs. 96211 test-amd64-i386-xl-qemuu-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 96211 test-amd64-amd64-xl-qemuu-ovmf-amd64 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-xl-pvh-intel 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-xl-qemuu-winxpsp3 6 xen-bootfail REGR. vs. 96211 test-amd64-amd64-libvirt-xsm 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-libvirt 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96211 test-armhf-armhf-xl-credit2 9 debian-installfail REGR. vs. 96211 test-amd64-i386-qemut-rhel6hvm-intel 9 redhat-installfail REGR. vs. 96211 test-amd64-amd64-xl-qemuu-win7-amd64 6 xen-boot fail REGR. vs. 96211 test-amd64-amd64-amd64-pvgrub 6 xen-boot fail REGR. vs. 96211 test-amd64-i386-libvirt-pair 15 debian-install/dst_host fail REGR. vs. 96211 test-amd64-i386-pair 15 debian-install/dst_host fail REGR. vs. 96211 test-armhf-armhf-libvirt-qcow2 9 debian-di-install fail REGR. vs. 96211 test-amd64-i386-xl-qemut-win7-amd64 9 windows-installfail REGR. vs. 96211 test-amd64-amd64-pair
[Xen-devel] [libvirt test] 97416: tolerable FAIL - PUSHED
flight 97416 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/97416/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail never pass
test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass
test-amd64-i386-libvirt 12 migrate-support-checkfail never pass
test-armhf-armhf-libvirt 14 guest-saverestorefail never pass
test-armhf-armhf-libvirt 12 migrate-support-checkfail never pass
test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail never pass
test-armhf-armhf-libvirt-xsm 14 guest-saverestorefail never pass
test-amd64-i386-libvirt-xsm 12 migrate-support-checkfail never pass
test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check
fail never pass
test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check
fail never pass
test-amd64-amd64-libvirt-vhd 11 migrate-support-checkfail never pass
test-armhf-armhf-libvirt-qcow2 11 migrate-support-checkfail never pass
test-armhf-armhf-libvirt-qcow2 13 guest-saverestorefail never pass
test-armhf-armhf-libvirt-raw 13 guest-saverestorefail never pass
test-armhf-armhf-libvirt-raw 11 migrate-support-checkfail never pass
version targeted for testing:
libvirt fe8bad38f58f8b60518947441fb3be8d89d51c58
baseline version:
libvirt b7caf4fcd2abca727a2325e0c66c2fb273b85642
Last test of basis97340 2016-07-15 04:20:40 Z1 days
Testing same since97416 2016-07-16 04:21:36 Z0 days1 attempts
People who touched revisions under test:
Daniel P. Berrange
jobs:
build-amd64-xsm pass
build-armhf-xsm pass
build-i386-xsm pass
build-amd64 pass
build-armhf pass
build-i386 pass
build-amd64-libvirt pass
build-armhf-libvirt pass
build-i386-libvirt pass
build-amd64-pvopspass
build-armhf-pvopspass
build-i386-pvops pass
test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass
test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsmpass
test-amd64-amd64-libvirt-xsm pass
test-armhf-armhf-libvirt-xsm fail
test-amd64-i386-libvirt-xsm pass
test-amd64-amd64-libvirt pass
test-armhf-armhf-libvirt fail
test-amd64-i386-libvirt pass
test-amd64-amd64-libvirt-pairpass
test-amd64-i386-libvirt-pair pass
test-armhf-armhf-libvirt-qcow2 fail
test-armhf-armhf-libvirt-raw fail
test-amd64-amd64-libvirt-vhd pass
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images
Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs
Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master
Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
Pushing revision :
+ branch=libvirt
+ revision=fe8bad38f58f8b60518947441fb3be8d89d51c58
+ . ./cri-lock-repos
++ . ./cri-common
+++ . ./cri-getconfig
+++ umask 002
+++ getrepos
getconfig Repos
perl -e '
use Osstest;
readglobalconfig();
print $c{"Repos"} or die $!;
'
+++ local repos=/home/osstest/repos
+++ '[' -z /home/osstest/repos ']'
+++ '[' '!' -d /home/osstest/repos ']'
+++ echo /home/osstest/repos
++ repos=/home/osstest/repos
++ repos_lock=/home/osstest/repos/lock
++ '[' x '!=' x/home/osstest/repos/lock ']'
++ OSSTEST_REPOS_LOCK_LOCKED=/home/osstest/repos/lock
++ exec with-lock-ex -w /home/osstest/repos/lock ./ap-push libvirt
fe8bad38f58f8b60518947441fb3be8d89d51c58
+ branch=libvirt
+ revision=fe8bad38f58f8b60518947441fb3b
Re: [Xen-devel] [PATCH 3/3] xen: Remove buggy initial placement algorithm
On Fri, 2016-07-15 at 19:02 +0100, George Dunlap wrote: > The initial placement algorithm sometimes picks cpus outside of the > mask it's given, does a lot of unnecessary bitmasking, does its own > separate load calculation, and completely ignores vcpu hard and soft > affinities. > Not to mention that I wouldn't even call what it does "load calculation". It just counts the number of vcpus that are executing (or have executed their last instance) on each CPU, which tells very few about load. And it does that without any locking at all, which I see the reason why, but the net effect is that the final result comes from a wrong calculation done on unreliable data... I don't see how this could be more broken! :-P > Just get rid of it and rely on the schedulers to do > initial placement. > This all makes a lot of sense to me, and I'm all for it, thanks for doing it! :-) > Signed-off-by: George Dunlap > --- > Since many of scheduler cpu_pick functions have a strong preference > to > just leave the cpu where it is (in particular, credit1 and rt), this > may cause some cpus to be overloaded when creating a lot of domains. > Arguably this should be fixed in the schedulers themselves. > Indeed. Still, maybe... > @@ -691,7 +643,7 @@ long > do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > continue; > > cpu = (i == 0) ? > -default_vcpu0_location(online) : > +cpumask_first(online) : > cpumask_cycle(d->vcpu[i-1]->processor, online); > ...cpumask_any() ? It's a bit more expensive, but it at least would provided a less biased (toward lower CPU indexes) basis to the schedulers? Regards, Dario -- <> (Raistlin Majere) - Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) signature.asc Description: This is a digitally signed message part ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 2/3] xen: Have schedulers revise initial placement
On Fri, 2016-07-15 at 19:07 +0100, Andrew Cooper wrote: > On 15/07/16 19:02, George Dunlap wrote: > > > > diff --git a/xen/common/sched_credit2.c > > b/xen/common/sched_credit2.c > > index 3b9aa27..5a04985 100644 > > --- a/xen/common/sched_credit2.c > > +++ b/xen/common/sched_credit2.c > > @@ -1620,15 +1620,23 @@ csched2_vcpu_insert(const struct scheduler > > *ops, struct vcpu *vc) > > > > BUG_ON(is_idle_vcpu(vc)); > > > > +/* Locks in cpu_pick expect irqs to be disabled */ > > +local_irq_disable(); > This doesn't make the problem much worse, but is there a plan to fix > this issue? > There's a little bit more than a plan. I've got a proof of concept implementation which was working (now I need to refresh it), but for which I never really managed to evaluate the performance impact as accurately as I wanted to. In fact, I actually have a couple of variants implemented, that I was comparing against each others, in addition to against 'vanilla'. The problem was that I really was not seeing any impact at all, which looked strange (I was expecting improvement, at least on some workloads), and I wanted to investigate further. I'm leaving here the link to two branches, where I stashed some of the code that I have come up so far. As I said, it's WIP and needs refreshing and reworking. > None of the scheduler-accounting functions should be disabling > interrupts. > They don't. But you can't keep irq disabled for some operations and enabled for others, on the same lock (because of the irq-safety spinlock checks/enforcement). So you have to always keep IRQ enabled, for all scheduling operations, which is ok for _almost_ all of them, with the only exception of the wakeup of a vcpu. So, the idea was to treat that one case specially, i.e., put the waking vcpus in a queue, and then drain the queue somehow. The insertion in the queue needs to be done disabling interrupts, but the draining --which is where the actual scheduling related hooks and operations are done-- can be done with IRQs on, which is what we want. What I was experimenting on was trying different ways of managing such a queue, e.g., only one queue for all CPUs or per-CPU queues; or whether to always drain the queue or only pick a couple of vcpu and defer the rest again; or whether to allow concurrent draining of the queue, or only have one CPU (at a time) doing that; etc etc. The "1 queue for all" and "per-CPU queues" is what's in the following two branches: git://xenbits.xen.org/people/dariof/xen.git wip/sched/irq-enabled http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/wip/sched/irq-enabled git://xenbits.xen.org/people/dariof/xen.git wip/sched/irq-enabled-percpu http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/wip/sched/irq-enabled-percpu I'll get back to this soon. In the meanwhile, feel free to comment, toss ideas, criticize, whatever. :-D Regards, Dario -- <> (Raistlin Majere) - Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) signature.asc Description: This is a digitally signed message part ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-credit2
branch xen-unstable
xenbranch xen-unstable
job test-amd64-amd64-xl-credit2
testid xen-boot
Tree: linux
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
*** Found and reproduced problem changeset ***
Bug is in tree: linux
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
Bug introduced: a2d8c514753276394d68414f563591f174ef86cb
Bug not present: 8f620446135b64ca6f96cf32066a76d64e79a388
Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/97435/
commit a2d8c514753276394d68414f563591f174ef86cb
Author: Lukasz Odzioba
Date: Fri Jun 24 14:50:01 2016 -0700
mm/swap.c: flush lru pvecs on compound page arrival
[ Upstream commit 8f182270dfec432e93fae14f9208a6b9af01009f ]
Currently we can have compound pages held on per cpu pagevecs, which
leads to a lot of memory unavailable for reclaim when needed. In the
systems with hundreads of processors it can be GBs of memory.
On of the way of reproducing the problem is to not call munmap
explicitly on all mapped regions (i.e. after receiving SIGTERM). After
that some pages (with THP enabled also huge pages) may end up on
lru_add_pvec, example below.
void main() {
#pragma omp parallel
{
size_t size = 55 * 1000 * 1000; // smaller than MEM/CPUS
void *p = mmap(NULL, size, PROT_READ | PROT_WRITE,
MAP_PRIVATE | MAP_ANONYMOUS , -1, 0);
if (p != MAP_FAILED)
memset(p, 0, size);
//munmap(p, size); // uncomment to make the problem go away
}
}
When we run it with THP enabled it will leave significant amount of
memory on lru_add_pvec. This memory will be not reclaimed if we hit
OOM, so when we run above program in a loop:
for i in `seq 100`; do ./a.out; done
many processes (95% in my case) will be killed by OOM.
The primary point of the LRU add cache is to save the zone lru_lock
contention with a hope that more pages will belong to the same zone and
so their addition can be batched. The huge page is already a form of
batched addition (it will add 512 worth of memory in one go) so skipping
the batching seems like a safer option when compared to a potential
excess in the caching which can be quite large and much harder to fix
because lru_add_drain_all is way to expensive and it is not really clear
what would be a good moment to call it.
Similarly we can reproduce the problem on lru_deactivate_pvec by adding:
madvise(p, size, MADV_FREE); after memset.
This patch flushes lru pvecs on compound page arrival making the problem
less severe - after applying it kill rate of above example drops to 0%,
due to reducing maximum amount of memory held on pvec from 28MB (with
THP) to 56kB per CPU.
Suggested-by: Michal Hocko
Link:
http://lkml.kernel.org/r/1466180198-18854-1-git-send-email-lukasz.odzi...@intel.com
Signed-off-by: Lukasz Odzioba
Acked-by: Michal Hocko
Cc: Kirill Shutemov
Cc: Andrea Arcangeli
Cc: Vladimir Davydov
Cc: Ming Li
Cc: Minchan Kim
Cc:
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
Signed-off-by: Sasha Levin
For bisection revision-tuple graph see:
http://logs.test-lab.xenproject.org/osstest/results/bisect/linux-3.18/test-amd64-amd64-xl-credit2.xen-boot.html
Revision IDs in each graph node refer, respectively, to the Trees above.
Running cs-bisection-step
--graph-out=/home/logs/results/bisect/linux-3.18/test-amd64-amd64-xl-credit2.xen-boot
--summary-out=tmp/97435.bisection-summary --basis-template=96188
--blessings=real,real-bisect linux-3.18 test-amd64-amd64-xl-credit2 xen-boot
Searching for failure / basis pass:
97377 fail [host=chardonnay0] / 96188 [host=italia0] 96161 [host=baroque1]
95844 [host=godello0] 95809 [host=godello1] 95597 [host=fiano0] 95521
[host=pinot1] 95458 [host=elbling1] 95406 [host=fiano1] 94728 [host=merlot1]
94153 [host=elbling0] 94083 ok.
Failure / basis pass flights: 97377 / 94083
(tree with no url: minios)
(tree with no url: ovmf)
(tree with no url: seabios)
Tree: linux
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 0ac0a856d986c1ab240753479f5e50fdfab82b14
c530a75c1e6a472b0eb9558310b518f0dfcd8860
6e20809727261599e8527c456e
Re: [Xen-devel] [PATCH 12/18] arm/altp2m: Cosmetic fixes - function prototypes.
Hi Julien,
On 07/15/2016 03:45 PM, Julien Grall wrote:
> Hi Sergej,
>
> On 04/07/16 12:45, Sergej Proskurin wrote:
>> This commit changes the prototype of the following functions:
>> - apply_p2m_changes
>> - apply_one_level
>> - p2m_shatter_page
>> - p2m_create_table
>> - __p2m_lookup
>> - __p2m_get_mem_access
>>
>> These changes are required as our implementation reuses most of the
>> existing ARM p2m implementation to set page table attributes of the
>> individual altp2m views. Therefore, exiting function prototypes have
>> been extended to hold another argument (of type struct p2m_domain *).
>> This allows to specify the p2m/altp2m domain that should be processed by
>> the individual function -- instead of accessing the host's default p2m
>> domain.
>
> I am actually reworking the whole p2m code to be complain with the ARM
> architecture (such as break-before-make) and make easier to implement
> new features such as altp2m.
>
> Would it be possible to send this patch separately with nothing altp2m
> related in it?
>
I will look into that, thank you for asking. The current implementation
already provides more cosmetic fixes, therefore I need to shortly assess
which parts might be submitted independently of altp2m. I will respond
as quickly as possible.
>>
>> Signed-off-by: Sergej Proskurin
>> ---
>> Cc: Stefano Stabellini
>> Cc: Julien Grall
>> ---
>> xen/arch/arm/p2m.c | 80
>> +-
>> 1 file changed, 43 insertions(+), 37 deletions(-)
>>
>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>> index 019f10e..9c8fefd 100644
>> --- a/xen/arch/arm/p2m.c
>> +++ b/xen/arch/arm/p2m.c
>> @@ -200,9 +200,8 @@ void flush_tlb_domain(struct domain *d)
>>* There are no processor functions to do a stage 2 only lookup
>> therefore we
>>* do a a software walk.
>>*/
>> -static paddr_t __p2m_lookup(struct domain *d, paddr_t paddr,
>> p2m_type_t *t)
>> +static paddr_t __p2m_lookup(struct p2m_domain *p2m, paddr_t paddr,
>> p2m_type_t *t)
>> {
>> -struct p2m_domain *p2m = &d->arch.p2m;
>> const unsigned int offsets[4] = {
>> zeroeth_table_offset(paddr),
>> first_table_offset(paddr),
>> @@ -282,10 +281,11 @@ err:
>> paddr_t p2m_lookup(struct domain *d, paddr_t paddr, p2m_type_t *t)
>> {
>> paddr_t ret;
>> -struct p2m_domain *p2m = &d->arch.p2m;
>> +struct vcpu *v = current;
>> +struct p2m_domain *p2m = altp2m_active(d) ? p2m_get_altp2m(v) :
>> p2m_get_hostp2m(d);
>
> This change is wrong, this function is called in hypercalls to translate
> an IPA for another domain to an MFN. So current->domain != d.
>
>>
>> spin_lock(&p2m->lock);
>> -ret = __p2m_lookup(d, paddr, t);
>> +ret = __p2m_lookup(p2m, paddr, t);
>> spin_unlock(&p2m->lock);
>>
>> return ret;
>> @@ -441,10 +441,12 @@ static inline void p2m_remove_pte(lpae_t *p,
>> bool_t flush_cache)
>>*
>>* level_shift is the number of bits at the level we want to create.
>>*/
>> -static int p2m_create_table(struct domain *d, lpae_t *entry,
>> -int level_shift, bool_t flush_cache)
>> +static int p2m_create_table(struct domain *d,
>
> Please drop "struct domain *d", it was only here to get the p2m.
>
>> +struct p2m_domain *p2m,
>> +lpae_t *entry,
>> +int level_shift,
>> +bool_t flush_cache)
>> {
>> -struct p2m_domain *p2m = &d->arch.p2m;
>> struct page_info *page;
>> lpae_t *p;
>> lpae_t pte;
>> @@ -502,10 +504,9 @@ static int p2m_create_table(struct domain *d,
>> lpae_t *entry,
>> return 0;
>> }
>>
>> -static int __p2m_get_mem_access(struct domain *d, gfn_t gfn,
>> +static int __p2m_get_mem_access(struct p2m_domain *p2m, gfn_t gfn,
>> xenmem_access_t *access)
>> {
>> -struct p2m_domain *p2m = p2m_get_hostp2m(d);
>> void *i;
>> unsigned int index;
>>
>> @@ -548,7 +549,7 @@ static int __p2m_get_mem_access(struct domain *d,
>> gfn_t gfn,
>>* No setting was found in the Radix tree. Check if the
>>* entry exists in the page-tables.
>>*/
>> -paddr_t maddr = __p2m_lookup(d, gfn_x(gfn) << PAGE_SHIFT, NULL);
>> +paddr_t maddr = __p2m_lookup(p2m, gfn_x(gfn) << PAGE_SHIFT,
>> NULL);
>> if ( INVALID_PADDR == maddr )
>> return -ESRCH;
>>
>> @@ -677,17 +678,17 @@ static const paddr_t level_shifts[] =
>> { ZEROETH_SHIFT, FIRST_SHIFT, SECOND_SHIFT, THIRD_SHIFT };
>>
>> static int p2m_shatter_page(struct domain *d,
>
> Ditto.
>
>> +struct p2m_domain *p2m,
>> lpae_t *entry,
>> unsigned int level,
>> bool_t flush_cache)
>> {
>> const paddr_t level_shift = level_shifts[level];
>> -int rc = p2m_creat
Re: [Xen-devel] [PATCH 1/3] xen: Some code motion to avoid having to do forward-declaration
On Fri, Jul 15, 2016 at 2:02 PM, George Dunlap wrote: > For sched_credit2, move the vcpu insert / remove / free functions near the > domain > insert / remove / alloc / free functions (and after cpu_pick). > > For sched_rt, move rt_cpu_pick() further up. > > This is pure code motion; no functional change. > > Signed-off-by: George Dunlap > As to sched_rt.c, Reviewed-by: Meng Xu Thanks, Meng Meng Xu PhD Student in Computer and Information Science University of Pennsylvania http://www.cis.upenn.edu/~mengxu/ ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [xen-unstable test] 97410: tolerable FAIL - PUSHED
flight 97410 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/97410/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 6 xen-boot fail REGR. vs. 97275 build-amd64-rumpuserxen 6 xen-buildfail like 97275 build-i386-rumpuserxen6 xen-buildfail like 97275 test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop fail like 97275 test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stop fail like 97275 test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 97275 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail like 97275 Tests which did not succeed, but are not blocking: test-amd64-i386-rumpuserxen-i386 1 build-check(1) blocked n/a test-amd64-amd64-rumpuserxen-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvh-amd 11 guest-start fail never pass test-amd64-amd64-xl-pvh-intel 11 guest-start fail never pass test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt-xsm 14 guest-saverestorefail never pass test-armhf-armhf-libvirt-qcow2 11 migrate-support-checkfail never pass test-armhf-armhf-libvirt-qcow2 13 guest-saverestorefail never pass test-amd64-i386-libvirt-xsm 12 migrate-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 12 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 13 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 11 migrate-support-checkfail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-armhf-armhf-libvirt 14 guest-saverestorefail never pass test-armhf-armhf-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 saverestore-support-checkfail never pass test-amd64-i386-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt-raw 13 guest-saverestorefail never pass test-armhf-armhf-libvirt-raw 11 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 12 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-credit2 12 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 11 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 12 saverestore-support-checkfail never pass version targeted for testing: xen b48be35ac86cd6369124cf06ca3006d086095297 baseline version: xen ea210c52abb6458e39f5365f7f2c3abb9c191c47 Last test of basis97275 2016-07-13 17:16:42 Z2 days Failing since 97285 2016-07-14 03:18:24 Z2 days4 attempts Testing same since97410 2016-07-16 02:52:34 Z0 days1 attempts People who touched revisions under test: Andrew Cooper Anshul Makkar Corneliu ZUZU Daniel De Graaf Doug Goldstein Jan Beulich Julien Grall Kevin Tian Quan Xu Shanker Donthineni Stefano Stabellini Tim Deegan jobs: build-amd64-xsm pass build-armhf-xsm pass build-i386-xsm pass build-amd64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-armhf-libvirt pass build-i386-libvirt
[Xen-devel] [ovmf test] 97415: regressions - FAIL
flight 97415 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/97415/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 94748 test-amd64-amd64-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 94748 version targeted for testing: ovmf e2f5c491d8749c88cbf56168a3493d70ff19a382 baseline version: ovmf dc99315b8732b6e3032d01319d3f534d440b43d0 Last test of basis94748 2016-05-24 22:43:25 Z 52 days Failing since 94750 2016-05-25 03:43:08 Z 52 days 113 attempts Testing same since97375 2016-07-15 14:23:16 Z1 days2 attempts People who touched revisions under test: Anandakrishnan Loganathan Ard Biesheuvel Bi, Dandan Bret Barkelew Bruce Cran Bruce Cran Chao Zhang Cinnamon Shia Cohen, Eugene Dandan Bi Darbin Reyes david wei Eric Dong Eugene Cohen Evan Lloyd Evgeny Yakovlev Feng Tian Fu Siyuan Fu, Siyuan Gary Li Gary Lin Giri P Mudusuru Graeme Gregory Hao Wu Hegde Nagaraj P Hegde, Nagaraj P hegdenag Heyi Guo Jan D?bro? Jan Dabros Jeff Fan Jeremy Linton Jiaxin Wu Jiewen Yao Joe Zhou Jordan Justen Katie Dellaquila Laszlo Ersek Liming Gao Lu, ShifeiX A lushifex Marcin Wojtas Mark Rutland Marvin H?user Marvin Haeuser Maurice Ma Michael Zimmermann Mudusuru, Giri P Ni, Ruiyu Qiu Shumin Ruiyu Ni Ruiyu Niã Ryan Harkin Sami Mujawar Satya Yarlagadda Shannon Zhao Sriram Subramanian Star Zeng Subramanian, Sriram (EG Servers Platform SW) Sunny Wang Tapan Shah Thomas Palmer Yarlagadda, Satya P Yonghong Zhu Zhang Lubo Zhang, Chao B Zhang, Lubo jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvopspass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 10330 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [PATCH 0/3] xen-scsiback: Fine-tuning for scsiback_device_action()
From: Markus Elfring Date: Sat, 16 Jul 2016 22:06:54 +0200 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (3): Delete an unnecessary check before the function call "kfree" One function call less in scsiback_device_action() after error detection Pass a failure indication as a constant drivers/xen/xen-scsiback.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.9.1 ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [PATCH 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"
From: Markus Elfring Date: Sat, 16 Jul 2016 21:21:05 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/xen/xen-scsiback.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c index d6950e0..4a48c06 100644 --- a/drivers/xen/xen-scsiback.c +++ b/drivers/xen/xen-scsiback.c @@ -627,8 +627,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req, transport_generic_free_cmd(&pending_req->se_cmd, 1); return; err: - if (tmr) - kfree(tmr); + kfree(tmr); scsiback_do_resp_with_sense(NULL, err, 0, pending_req); } -- 2.9.1 ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection
From: Markus Elfring
Date: Sat, 16 Jul 2016 21:42:42 +0200
The kfree() function was called in one case by the
scsiback_device_action() function during error handling
even if the passed variable "tmr" contained a null pointer.
Adjust jump targets according to the Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/xen/xen-scsiback.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
index 4a48c06..7612bc9 100644
--- a/drivers/xen/xen-scsiback.c
+++ b/drivers/xen/xen-scsiback.c
@@ -606,7 +606,7 @@ static void scsiback_device_action(struct vscsibk_pend
*pending_req,
tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL);
if (!tmr) {
target_put_sess_cmd(se_cmd);
- goto err;
+ goto do_resp;
}
init_waitqueue_head(&tmr->tmr_wait);
@@ -616,7 +616,7 @@ static void scsiback_device_action(struct vscsibk_pend
*pending_req,
unpacked_lun, tmr, act, GFP_KERNEL,
tag, TARGET_SCF_ACK_KREF);
if (rc)
- goto err;
+ goto free_tmr;
wait_event(tmr->tmr_wait, atomic_read(&tmr->tmr_complete));
@@ -626,8 +626,9 @@ static void scsiback_device_action(struct vscsibk_pend
*pending_req,
scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
transport_generic_free_cmd(&pending_req->se_cmd, 1);
return;
-err:
+free_tmr:
kfree(tmr);
+do_resp:
scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
}
--
2.9.1
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
[Xen-devel] [PATCH 3/3] xen-scsiback: Pass a failure indication as a constant
From: Markus Elfring
Date: Sat, 16 Jul 2016 21:55:01 +0200
Pass the constant "FAILED" in a function call directly instead of
using an intialisation for a local variable.
Signed-off-by: Markus Elfring
---
drivers/xen/xen-scsiback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
index 7612bc9..ec5546c 100644
--- a/drivers/xen/xen-scsiback.c
+++ b/drivers/xen/xen-scsiback.c
@@ -601,7 +601,7 @@ static void scsiback_device_action(struct vscsibk_pend
*pending_req,
struct se_cmd *se_cmd = &pending_req->se_cmd;
struct scsiback_tmr *tmr;
u64 unpacked_lun = pending_req->v2p->lun;
- int rc, err = FAILED;
+ int rc, err;
tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL);
if (!tmr) {
@@ -629,7 +629,7 @@ static void scsiback_device_action(struct vscsibk_pend
*pending_req,
free_tmr:
kfree(tmr);
do_resp:
- scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
+ scsiback_do_resp_with_sense(NULL, FAILED, 0, pending_req);
}
/*
--
2.9.1
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
[Xen-devel] [qemu-mainline test] 97429: regressions - FAIL
flight 97429 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/97429/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 11 guest-start fail REGR. vs. 96791 test-amd64-amd64-libvirt-pair 20 guest-start/debian fail REGR. vs. 96791 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96791 test-amd64-amd64-libvirt 11 guest-start fail REGR. vs. 96791 test-amd64-amd64-xl-qcow2 9 debian-di-install fail REGR. vs. 96791 test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 96791 test-amd64-amd64-libvirt-vhd 9 debian-di-install fail REGR. vs. 96791 Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 96791 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail like 96791 test-amd64-amd64-xl-rtds 9 debian-install fail like 96791 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-pvh-amd 11 guest-start fail never pass test-amd64-amd64-xl-pvh-intel 11 guest-start fail never pass test-armhf-armhf-libvirt 14 guest-saverestorefail never pass test-armhf-armhf-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt-qcow2 11 migrate-support-checkfail never pass test-armhf-armhf-libvirt-qcow2 13 guest-saverestorefail never pass test-amd64-i386-libvirt 12 migrate-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-arndale 12 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 13 saverestore-support-checkfail never pass test-amd64-i386-libvirt-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 12 migrate-support-checkfail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-credit2 12 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt-xsm 14 guest-saverestorefail never pass test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-raw 13 guest-saverestorefail never pass test-armhf-armhf-libvirt-raw 11 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 11 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 12 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 12 migrate-support-checkfail never pass version targeted for testing: qemuu6b92bbfe812746fe7841a24c24e6460f5359ce72 baseline version: qemuu4f4a9ca4a4386c137301b3662faba076455ff15a Last test of basis96791 2016-07-08 12:20:07 Z8 days Failing since 97271 2016-07-13 13:44:26 Z3 days6 attempts Testing same since97396 2016-07-15 21:43:55 Z1 days2 attempts People who touched revisions under test: Alberto Garcia Alex Bennée Alexander Yarygin Andrew Jones Anthony PERARD Ashok Raj Cao jin Cornelia Huck Cédric Le Goater Daniel P. Berrange David Gibson David Hildenbrand Denis V. Lunev Dmitry Osipenko Eduardo Habkost Eric Blake Eugene (jno) Dvurechenski Evgeny Yakovlev Fam Zheng Gerd Hoffmann Gonglei Haibin Wang Haozhong Zhang Igor Mammedov James Hogan Jarkko Lavinen Jeff Cody Jing Liu Kevin Wolf Laszlo Ersek Leon Alrae Lin Ma Marc Marà Marc-André Lureau Marcin Krzeminski Mark Cave-Ayland Markus Armbruster Max Filippov Max Reitz Paolo Bonzini Paul Burton Peter Lieven Peter Maydell Pierre Morel Reda Sallahi Richard Henderson Richard W.M. Jones Samuel Damashek Sascha Silbe Sean Bruno Sergey Sorokin Stanislav Shmarov Suresh Vijay Vijaya Kumar K Xiao Guangrong Yi Min Zhao Yongbok Kim
[Xen-devel] [ovmf test] 97452: regressions - FAIL
flight 97452 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/97452/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 94748 test-amd64-amd64-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 94748 version targeted for testing: ovmf e2f5c491d8749c88cbf56168a3493d70ff19a382 baseline version: ovmf dc99315b8732b6e3032d01319d3f534d440b43d0 Last test of basis94748 2016-05-24 22:43:25 Z 53 days Failing since 94750 2016-05-25 03:43:08 Z 52 days 114 attempts Testing same since97375 2016-07-15 14:23:16 Z1 days3 attempts People who touched revisions under test: Anandakrishnan Loganathan Ard Biesheuvel Bi, Dandan Bret Barkelew Bruce Cran Bruce Cran Chao Zhang Cinnamon Shia Cohen, Eugene Dandan Bi Darbin Reyes david wei Eric Dong Eugene Cohen Evan Lloyd Evgeny Yakovlev Feng Tian Fu Siyuan Fu, Siyuan Gary Li Gary Lin Giri P Mudusuru Graeme Gregory Hao Wu Hegde Nagaraj P Hegde, Nagaraj P hegdenag Heyi Guo Jan D?bro? Jan Dabros Jeff Fan Jeremy Linton Jiaxin Wu Jiewen Yao Joe Zhou Jordan Justen Katie Dellaquila Laszlo Ersek Liming Gao Lu, ShifeiX A lushifex Marcin Wojtas Mark Rutland Marvin H?user Marvin Haeuser Maurice Ma Michael Zimmermann Mudusuru, Giri P Ni, Ruiyu Qiu Shumin Ruiyu Ni Ruiyu Niã Ryan Harkin Sami Mujawar Satya Yarlagadda Shannon Zhao Sriram Subramanian Star Zeng Subramanian, Sriram (EG Servers Platform SW) Sunny Wang Tapan Shah Thomas Palmer Yarlagadda, Satya P Yonghong Zhu Zhang Lubo Zhang, Chao B Zhang, Lubo jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvopspass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 10330 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [xen-unstable baseline-only test] 66611: regressions - FAIL
This run is configured for baseline tests only. flight 66611 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66611/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-winxpsp3 20 leak-check/checkfail REGR. vs. 66565 Regressions which are regarded as allowable (not blocking): build-amd64-rumpuserxen 6 xen-buildfail like 66565 build-i386-rumpuserxen6 xen-buildfail like 66565 test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 66565 test-amd64-amd64-i386-pvgrub 10 guest-start fail like 66565 test-amd64-amd64-qemuu-nested-intel 16 debian-hvm-install/l1/l2 fail like 66565 Tests which did not succeed, but are not blocking: test-amd64-amd64-rumpuserxen-amd64 1 build-check(1) blocked n/a test-amd64-i386-rumpuserxen-i386 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt-xsm 14 guest-saverestorefail never pass test-armhf-armhf-libvirt 14 guest-saverestorefail never pass test-armhf-armhf-libvirt 12 migrate-support-checkfail never pass test-amd64-amd64-xl-pvh-amd 11 guest-start fail never pass test-amd64-amd64-xl-pvh-intel 11 guest-start fail never pass test-armhf-armhf-libvirt-qcow2 11 migrate-support-checkfail never pass test-armhf-armhf-libvirt-qcow2 13 guest-saverestorefail never pass test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-midway 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-midway 12 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt-raw 13 guest-saverestorefail never pass test-armhf-armhf-libvirt-raw 11 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-credit2 12 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 12 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail never pass test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-amd64-i386-libvirt-xsm 12 migrate-support-checkfail never pass test-amd64-i386-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 11 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 12 saverestore-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stop fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 11 migrate-support-checkfail never pass version targeted for testing: xen b48be35ac86cd6369124cf06ca3006d086095297 baseline version: xen ea210c52abb6458e39f5365f7f2c3abb9c191c47 Last test of basis66565 2016-07-14 03:19:07 Z2 days Testing same since66611 2016-07-16 17:19:41 Z0 days1 attempts People who touched revisions under test: Andrew Cooper Anshul Makkar Corneliu ZUZU Daniel De Graaf Doug Goldstein Jan Beulich Julien Grall Kevin Tian Quan Xu Shanker Donthineni Stefano Stabellini Tim Deegan jobs: build-amd64-xsm pass build-armhf-xsm pass build-i386-xsm pass build-amd64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-armhf-libvirt
[Xen-devel] [linux-3.18 test] 97426: regressions - FAIL
flight 97426 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/97426/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-xl-qemut-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 96188 test-amd64-amd64-xl-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-pygrub 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96188 test-armhf-armhf-xl-xsm 9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl-qemut-win7-amd64 9 windows-installfail REGR. vs. 96188 test-amd64-i386-xl-qemut-winxpsp3 9 windows-install fail REGR. vs. 96188 test-armhf-armhf-libvirt 9 debian-installfail REGR. vs. 96188 test-amd64-amd64-amd64-pvgrub 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-freebsd10-amd64 9 freebsd-installfail REGR. vs. 96188 test-amd64-i386-xl-xsm9 debian-installfail REGR. vs. 96188 test-amd64-amd64-xl-qcow2 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-i386-pvgrub 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-qemut-rhel6hvm-amd 9 redhat-install fail REGR. vs. 96188 test-armhf-armhf-libvirt-xsm 9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 96188 test-amd64-i386-xl-qemut-winxpsp3-vcpus1 9 windows-install fail REGR. vs. 96188 test-amd64-amd64-libvirt 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemut-winxpsp3 6 xen-bootfail REGR. vs. 96188 test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 9 windows-install fail REGR. vs. 96188 test-amd64-i386-xl-qemut-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96188 test-armhf-armhf-xl-multivcpu 9 debian-install fail REGR. vs. 96188 test-armhf-armhf-xl-cubietruck 9 debian-install fail REGR. vs. 96188 test-armhf-armhf-libvirt-qcow2 9 debian-di-install fail REGR. vs. 96188 test-amd64-i386-qemuu-rhel6hvm-amd 9 redhat-install fail REGR. vs. 96188 test-amd64-i386-qemut-rhel6hvm-intel 9 redhat-installfail REGR. vs. 96188 test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemuu-debianhvm-amd64 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-libvirt-xsm 9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 96188 test-amd64-amd64-libvirt-vhd 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-multivcpu 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemut-win7-amd64 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-freebsd10-i386 9 freebsd-install fail REGR. vs. 96188 test-amd64-amd64-qemuu-nested-intel 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemut-debianhvm-amd64 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemuu-winxpsp3 6 xen-bootfail REGR. vs. 96188 test-amd64-amd64-xl-pvh-intel 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-qemuu-win7-amd64 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-libvirt-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-qemuu-rhel6hvm-intel 9 redhat-installfail REGR. vs. 96188 test-amd64-amd64-xl-qemuu-ovmf-amd64 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-xl-qemuu-win7-amd64 9 windows-installfail REGR. vs. 96188 test-amd64-i386-libvirt 9 debian-installfail REGR. vs. 96188 test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-i386-xl-raw9 debian-di-install fail REGR. vs. 96188 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-xl-pvh-amd 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 96188 test-amd64-amd64-qemuu-nested-amd 6 xen-boot fail REGR. vs. 96188 test-armhf-armhf-xl-vhd 9 debian-di-install fail REGR. vs. 96188 test-amd64-i386-xl-qemuu-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 96188 test-amd64-i386-libvirt-pair 15 debian-install/dst_host fail REGR. vs. 96188 test-armhf-armhf-xl-credit2 9 debian-installfail REGR. vs. 96188 test-amd64-i386-xl-qemuu-winxpsp3 9 windows-install fail REGR. vs. 96188 test-amd64-i386-pair 15 debian-install/dst_host fail REGR. vs. 96188 test-armhf-armhf-xl
