[Wireshark-dev] Fix for Windows build.

[Anders Broman]

diff --git a/epan/wslua/lrexlib_algo.h b/epan/wslua/lrexlib_algo.h
index 4aad145..ece7c8c 100644
--- a/epan/wslua/lrexlib_algo.h
+++ b/epan/wslua/lrexlib_algo.h
@@ -94,7 +94,7 @@ static int get_startoffset(lua_State *L, int stackpos, size_t
   if(startoffset > 0)
 startoffset--;
   else if(startoffset < 0) {
-startoffset += len/ALG_CHARSIZE;
+startoffset += (int)(len/ALG_CHARSIZE);
 if(startoffset < 0)
   startoffset = 0;
   }
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Fix for Windows build.

[Pascal Quantin]

2014-03-10 10:18 GMT+01:00 Anders Broman :

>  diff --git a/epan/wslua/lrexlib_algo.h b/epan/wslua/lrexlib_algo.h
>
> index 4aad145..ece7c8c 100644
>
> --- a/epan/wslua/lrexlib_algo.h
>
> +++ b/epan/wslua/lrexlib_algo.h
>
> @@ -94,7 +94,7 @@ static int get_startoffset(lua_State *L, int stackpos,
> size_t
>
>if(startoffset > 0)
>
>  startoffset--;
>
>else if(startoffset < 0) {
>
> -startoffset += len/ALG_CHARSIZE;
>
> +startoffset += (int)(len/ALG_CHARSIZE);
>
>  if(startoffset < 0)
>
>startoffset = 0;
>
>}
>

https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3b012acd26de8be4d0abdabd50e8278689baf87

Regards,
Pascal.
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Fix for Windows build.

[Hadriel Kaplan]

Sorry about that - I uploaded that commit before I made it a habit to turn on 
extra compiler warnings on my Mac OSX. :(

It's surprising, though, since the files which caused you and others issues are 
from a very-widely-used Lua library that's been around for years.  You'd think 
they'd have cleaned that stuff up.

-hadriel


On Mar 10, 2014, at 5:18 AM, Anders Broman  wrote:

> diff --git a/epan/wslua/lrexlib_algo.h b/epan/wslua/lrexlib_algo.h
> index 4aad145..ece7c8c 100644
> --- a/epan/wslua/lrexlib_algo.h
> +++ b/epan/wslua/lrexlib_algo.h
> @@ -94,7 +94,7 @@ static int get_startoffset(lua_State *L, int stackpos, 
> size_t
>if(startoffset > 0)
>  startoffset--;
>else if(startoffset < 0) {
> -startoffset += len/ALG_CHARSIZE;
> +startoffset += (int)(len/ALG_CHARSIZE);
>  if(startoffset < 0)
>startoffset = 0;
>}
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Build bot failure

[Anders Broman]

Hi,

stock_icons.c:176: error: 'GTK_STOCK_CAPS_LOCK_WARNING' undeclared here 
(not in a function) stock_icons.c:242: error: 'GTK_STOCK_PAGE_SETUP' 
undeclared here (not in a function) stock_icons.c:246: error: 
'GTK_STOCK_PRINT_ERROR' undeclared here (not in a function) 
stock_icons.c:247: error: 'GTK_STOCK_PRINT_PAUSED' undeclared here (not 
in a function) stock_icons.c:249: error: 'GTK_STOCK_PRINT_REPORT' 
undeclared here (not in a function) stock_icons.c:250: error: 
'GTK_STOCK_PRINT_WARNING' undeclared here (not in a function)


These probably needs to be protected with GTK_CHECK_VERSION
GTK_STOCK_CAPS_LOCK_WARNING Since 2.16
GTK_STOCK_PAGE_SETUP  Since 2.14
GTK_STOCK_PRINT_ERRORSince 2.14
GTK_STOCK_PRINT_PAUSED  Since 2.14
GTK_STOCK_PRINT_REPORT  Since 2.14
GTK_STOCK_PRINT_WARNING Since 2.14

Regards
Anders
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe