Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands
OK merged trunk. I get some
../src/wlapplication.cc:1476:30: warning: unused exception parameter 'e'
[-Wunused-exception-parameter]
} catch (const FileError& e) {
will now use a debugger to poke into that code.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+merge/363584
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website.
Commit message:
Make use of a global setting to queue emails or not
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/queued_emails/+merge/363951
Added a global setting to use a queue for emails. This makes it possible to
queue emails on wl.widelands.org, but not on alpha.widelands.org.
So i do not have to run ./manage.py emit_notices manually on alpha.
After merging add
NOTIFICATION_QUEUE_ALL = True
to local_settings.py of wl.widelands.org
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website.
=== modified file 'pybb/views.py'
--- pybb/views.py 2018-12-21 13:20:43 +
+++ pybb/views.py 2019-03-05 09:11:39 +
@@ -201,14 +201,14 @@
'post': post,
'user': post.topic.user
},
- queue = True)
+ )
# Topics author is subscriber for all new posts in his topic
post.topic.subscribers.add(request.user)
else:
# Send mails about a new post to topic subscribers
notification.send(post.topic.subscribers.exclude(username=post.user), 'forum_new_post',
- {'post': post, 'topic': topic, 'user': post.user}, queue = True)
+ {'post': post, 'topic': topic, 'user': post.user},)
return HttpResponseRedirect(post.get_absolute_url())
=== modified file 'settings.py'
--- settings.py 2019-02-26 13:32:06 +
+++ settings.py 2019-03-05 09:11:39 +
@@ -358,6 +358,15 @@
}
}
+#
+# Notification settings #
+#
+# When set to True, one has to run ./manage.py emit_notices
+# for sending emails
+
+NOTIFICATION_QUEUE_ALL = False
+
+
try:
from local_settings import *
except ImportError:
=== modified file 'wlmaps/models.py'
--- wlmaps/models.py 2018-11-18 17:03:56 +
+++ wlmaps/models.py 2019-03-05 09:11:39 +
@@ -69,6 +69,6 @@
'user': self.uploader,
'uploader_comment': self.uploader_comment
},
- queue=True)
+ )
return map
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisian_music into lp:widelands
It would have been nice to have the track's title in the commit message - now I'll have to dig into it when creating the changelog ;) -- https://code.launchpad.net/~widelands-dev/widelands/frisian_music/+merge/350429 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/frisian_music. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands
Please do not report unrelated issues in merge requests - it makes the merge request noisy with unrelated discussions. Create a bug for it ;) I have fixed this one directly in trunk, thanks for reporting! -- https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+merge/363584 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website
Review: Approve LGTM -- https://code.launchpad.net/~widelands-dev/widelands-website/queued_emails/+merge/363951 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands
Review: Needs Information OK, his is te code that will (new in R20) add the Helpbutton so the correct helpwindow for the building in progress will be shown. _parent is the same as igbase() which is used at the very start of the function, so I have no idea how this should be come null? Teh origiinal bug is about some heap-use-after-free, in this case the prt would be != null but be freed before? I see no operator() (e.g. from unique Pointer) involved? So my bues guess is that this _may_ be a help window for some consntruction side, that is open longer then the original building window(). Ill use this branch to try to provoke such conditions. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+merge/363584 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website
The proposal to merge lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/queued_emails/+merge/363951 -- Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website
Thanks :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/queued_emails/+merge/363951 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands
I quick game for some 40 minutes, found nothing, will try to produce this in some coop game perhaps. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+merge/363584 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
