Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1687100-reveal_fields into lp:widelands
I guess the bug in the military scenario is that the soldiers see where they are going - do you want that switched off? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1687100-reveal_fields/+merge/323721 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1687100-reveal_fields. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-boost-asio into lp:widelands
Codecheck from travis fails, but for some compilers? grep '^[/_.a-zA-Z]\+:[0-9]\+:' codecheck.out /home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:225: Use log() from base/log.h instead of printf. /home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:238: Comments need to start with a space. /home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:261: Old C-Style cast. Change to static_cast(var) or similar! /home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:264: Use log() from base/log.h instead of printf. /home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:271: Use log() from base/log.h instead of printf. /home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:275: Comments need to start with a space. /home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:280: Old C-Style cast. Change to static_cast(var) or similar! /home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:283: Use log() from base/log.h instead of printf. +echo 'You have codecheck warnings (see above) Please fix.' You have codecheck warnings (see above) Please fix. -- https://code.launchpad.net/~widelands-dev/widelands/net-boost-asio/+merge/324364 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/net-boost-asio. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/weaver_spins_gold into lp:widelands
This is breaking savegame compatibility and writing good code for that takes more time than I'm willing to invest right now. Postponed to after Build 20. -- https://code.launchpad.net/~widelands-dev/widelands/weaver_spins_gold/+merge/324692 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/weaver_spins_gold into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/weaver_spins_gold into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/weaver_spins_gold into lp:widelands has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~widelands-dev/widelands/weaver_spins_gold/+merge/324692 -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/weaver_spins_gold into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1687100-reveal_fields into lp:widelands
> do you want that switched off? Lets say: If it doesn't make much work it would be fine to have the possibility to switch that off :-) Otherwise i could live with the current state. The bug with the disappearing census and statistics is gone now. Thank you very much for working on this. You can always test your code if you run widelands with the --datadir= option pointing the data folder of my branch. Doesn't that work for you? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1687100-reveal_fields/+merge/323721 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1687100-reveal_fields. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-boost-asio into lp:widelands
Travis is only complaining about my coding style, which I have to agree with. The current apple-test-code is totally ugly. ;-) The failing builds are the debug builds, seems like release builds aren't doing codechecks. When I understood it right, the new code worked on your system, or? If you want to try with only IPv6 enabled, add "close_socket(&socket_v4);" at the end of LanBase::LanBase(uint16_t port). If the code is working, I will keep it in and clean it up. -- https://code.launchpad.net/~widelands-dev/widelands/net-boost-asio/+merge/324364 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/net-boost-asio. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
