Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_path_dbg into lp:widelands

2017-02-27 Thread GunChleoc
There is a segfault in the economy test on AppVeyor that Tino is still trying 
to fix - nothing to do with this branch.

@bunnybot merge
-- 
https://code.launchpad.net/~widelands-dev/widelands/ship_path_dbg/+merge/318316
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/ship_path_dbg.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_path_dbg into lp:widelands

2017-02-27 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/ship_path_dbg into 
lp:widelands has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ship_path_dbg/+merge/318316
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/ship_path_dbg.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-27 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1653460-panel-init-width 
into lp:widelands has been updated.

Commit Message changed to:

Fixed assertion failure in int UI::Panel::get_inner_h():

- Fixed bug with automatic column sizing for tables where the columns were 
already being resized before all of them were added.
- Allow getting inner width/height for panels that have their borders set but 
w/h == 0. Added assertions and fallbacks to set_size and set_desired_size to 
make sure that width/height will never be negative.
- Explicitly initialize all variables in ui_basic.

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-27 Thread GunChleoc
GunChleoc has proposed merging 
lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands.

Commit message:
Fixed assertion failure in int UI::Panel::get_inner_h():

- Fixed bug with automatic column sizing for tables where the columns were 
already being resized before all of them were added.
- Allow getting inner width/height for panels that have their borders set but 
w/h == 0. Added assertions and fallbacks to set_size and set_desired_size to 
make sure that width/height will never be negative.
- Explicitly initialize all variables in ui_basic.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1653460 in widelands: "UI::Panel::get_inner_h() const: Assertion 
`tborder_ + bborder_ <= h_' failed."
  https://bugs.launchpad.net/widelands/+bug/1653460

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358

The assertion in the bug should now be fixed for all panels containing tables:

* Fullscreen menus:

- campaign_select
- internet_lobby
- launch_mpg
- launch_spg
- loadgame
- mapselect
- netsetup_lan

* In-game:
- game_message_menu
- game_summary
- productionsitewindow
- trainingsitewindow
- tribal_encyclopedia

* Editor:
- help
- main_menu_load_map
- main_menu_save_map

I don't know why this happened only sometimes and not all the time though.
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands.
=== modified file 'src/ui_basic/box.cc'
--- src/ui_basic/box.cc	2017-02-25 13:27:40 +
+++ src/ui_basic/box.cc	2017-02-27 14:05:30 +
@@ -98,7 +98,7 @@
 	int maxbreadth = mindesiredbreadth_;
 
 	for (uint32_t idx = 0; idx < items_.size(); ++idx) {
-		int depth, breadth;
+		int depth, breadth = 0;
 		get_item_desired_size(idx, &depth, &breadth);
 
 		totaldepth += depth;
@@ -137,7 +137,7 @@
 	int totaldepth = 0;
 
 	for (size_t idx = 0; idx < items_.size(); ++idx) {
-		int depth, unused;
+		int depth, unused = 0;
 		get_item_desired_size(idx, &depth, &unused);
 		totaldepth += depth;
 	}
@@ -221,7 +221,7 @@
 		totalbreadth -= Scrollbar::kSize;
 
 	for (uint32_t idx = 0; idx < items_.size(); ++idx) {
-		int depth, breadth;
+		int depth, breadth = 0;
 		get_item_size(idx, &depth, &breadth);
 
 		if (items_[idx].type == Item::ItemPanel) {
@@ -371,7 +371,7 @@
 
 	switch (it.type) {
 	case Item::ItemPanel: {
-		int32_t breadth, maxbreadth;
+		int32_t breadth, maxbreadth = 0;
 
 		if (orientation_ == Horizontal) {
 			breadth = it.u.panel.panel->get_inner_h();

=== modified file 'src/ui_basic/listselect.cc'
--- src/ui_basic/listselect.cc	2017-02-23 19:38:51 +
+++ src/ui_basic/listselect.cc	2017-02-27 14:05:30 +
@@ -69,10 +69,9 @@
 	scrollbar_.moved.connect(boost::bind(&BaseListselect::set_scrollpos, this, _1));
 
 	if (selection_mode_ == ListselectLayout::kShowCheck) {
-		int pic_h;
 		check_pic_ = g_gr->images().get("images/ui_basic/list_selected.png");
 		max_pic_width_ = check_pic_->width();
-		pic_h = check_pic_->height();
+		int pic_h = check_pic_->height();
 		if (pic_h > lineheight_)
 			lineheight_ = pic_h;
 	} else {

=== modified file 'src/ui_basic/multilineeditbox.cc'
--- src/ui_basic/multilineeditbox.cc	2017-02-23 17:58:25 +
+++ src/ui_basic/multilineeditbox.cc	2017-02-27 14:05:30 +
@@ -303,7 +303,7 @@
 			if (d_->cursor_pos < d_->text.size()) {
 d_->refresh_ww();
 
-uint32_t cursorline, cursorpos;
+uint32_t cursorline, cursorpos = 0;
 d_->ww.calc_wrapped_pos(d_->cursor_pos, cursorline, cursorpos);
 
 if (cursorline + 1 < d_->ww.nrlines()) {
@@ -332,7 +332,7 @@
 			if (d_->cursor_pos > 0) {
 d_->refresh_ww();
 
-uint32_t cursorline, cursorpos;
+uint32_t cursorline, cursorpos = 0;
 d_->ww.calc_wrapped_pos(d_->cursor_pos, cursorline, cursorpos);
 
 if (cursorline > 0) {
@@ -361,7 +361,7 @@
 			} else {
 d_->refresh_ww();
 
-uint32_t cursorline, cursorpos;
+uint32_t cursorline, cursorpos = 0;
 d_->ww.calc_wrapped_pos(d_->cursor_pos, cursorline, cursorpos);
 
 d_->set_cursor_pos(d_->ww.line_offset(cursorline));
@@ -379,7 +379,7 @@
 			} else {
 d_->refresh_ww();
 
-uint32_t cursorline, cursorpos;
+uint32_t cursorline, cursorpos = 0;
 d_->ww.calc_wrapped_pos(d_->cursor_pos, cursorline, cursorpos);
 
 if (cursorline + 1 < d_->ww.nrlines())
@@ -488,7 +488,7 @@
 void MultilineEditbox::Data::scroll_cursor_into_view() {
 	refresh_ww();
 
-	uint32_t cursorline, cursorpos;
+	uint32_t cursorline, cursorpos = 0;
 	ww.calc_wrapped_pos(cursor_pos, cursorline, cursorpos);
 
 	int32_t lineheight = textstyle.font->height();

=== modified file 'src/ui_basic/multilinetextarea.cc'
--- src/ui_basic/multilinetextarea.cc	2017-02-23 19:38:51 +
+++ src/ui_basic/multilinetextarea.cc	2017-02-27 14:05:30 +
@@ -79,7 +79,7 @@
  * and adjust scrollbar settings acc

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands

2017-02-27 Thread Tino
Tino has proposed merging lp:~widelands-dev/widelands/gcc63 into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1668200 in widelands: "Segfault on exit with GCC 6.3.0 Release Builds"
  https://bugs.launchpad.net/widelands/+bug/1668200

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374

Quick workaround for segfaulting builds with GCC 6.3.0 (on Appveyor).
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/gcc63 into lp:widelands.
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2017-02-14 18:17:38 +
+++ CMakeLists.txt	2017-02-27 15:34:50 +
@@ -93,11 +93,21 @@
 if(CMAKE_BUILD_TYPE STREQUAL "Debug")
   set(WL_DEBUG_FLAGS "-g -DDEBUG")
 elseif(CMAKE_BUILD_TYPE STREQUAL "Release")
-  set(WL_OPTIMIZE_FLAGS "-O3")
+  if(("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") AND (CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 6.3))
+message(STATUS "GCC 6.3.0 breaks -03, setting -02")
+set(WL_OPTIMIZE_FLAGS "-O2")
+  else()
+set(WL_OPTIMIZE_FLAGS "-O3")
+  endif ()
   set(WL_DEBUG_FLAGS "-DNDEBUG -DNOPARACHUTE")
 elseif(CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
-  set(WL_OPTIMIZE_FLAGS "-O3")
-  set(WL_DEBUG_FLAGS "-g -DNDEBUG -DNOPARACHUTE")
+  if(("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") AND (CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 6.3.0))
+message(STATUS "GCC 6.3.0 breaks -03, setting -02")
+set(WL_OPTIMIZE_FLAGS "-O2")
+  else()
+set(WL_OPTIMIZE_FLAGS "-O3")
+  endif ()
+  set(WL_DEBUG_FLAGS "-DNDEBUG -DNOPARACHUTE")
 else()
   message(FATAL_ERROR "Unknown CMAKE_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
 endif()

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands

2017-02-27 Thread GunChleoc
The first change has

CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 6.3

and the second change has

CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 6.3.0

I guess one of them must be fixed?

I'd also rather have some research whether this breaks on non-Windows systems 
as well and fix the segfault.
-- 
https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/gcc63 into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands

2017-02-27 Thread GunChleoc
Thanks for the review!

The coordinates from std::map wanted_building_windows_ are used - I have marked 
up the line.

I also fixed the window warping for both construction sites and dismantle sites 
in all cases - having the window stay open is only 2 lines of code, so we might 
as well do it in this branch.

Now I'll go hunt the segfault.

Diff comments:

> 
> === modified file 'src/wui/interactive_gamebase.cc'
> --- src/wui/interactive_gamebase.cc   2017-02-24 08:07:50 +
> +++ src/wui/interactive_gamebase.cc   2017-02-27 16:52:58 +
> @@ -56,6 +62,28 @@
>   chat_provider_(nullptr),
>   multiplayer_(multiplayer),
>   playertype_(pt) {
> + buildingnotes_subscriber_ = 
> Notifications::subscribe(
> +[this](const Widelands::NoteBuilding& note) {
> +switch (note.action) {
> +case Widelands::NoteBuilding::Action::kFinishWarp: {
> +if (upcast(
> +   Widelands::Building const, building, 
> game().objects().get_object(note.serial))) {
> +const Widelands::Coords coords = 
> building->get_position();
> +// Check whether the window is wanted
> +if 
> (wanted_building_windows_.count(coords.hash()) == 1) {
> +UI::UniqueWindow* building_window = 
> show_building_window(coords, true);
> +
> building_window->set_pos(std::get<1>(wanted_building_windows_.at(coords.hash(;

The coordinates from std::map wanted_building_windows_ are used here.

> +if 
> (std::get<2>(wanted_building_windows_.at(coords.hash( {
> +building_window->minimize();
> +}
> +
> wanted_building_windows_.erase(coords.hash());
> +}
> +}
> +} break;
> +default:
> +break;
> +}
> + });
>  }
>  
>  /// \return a pointer to the running \ref Game instance.


-- 
https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/notifications_buildingwindows.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


[Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands

2017-02-27 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/notifications_buildingwindows 
into lp:widelands has been updated.

Commit Message changed to:

Building windows are now handled by a new notification 'NoteBuilding', so that 
Map Objects and the economy no longer depend directly on wui. This also brings 
some improvements regarding the closing/minimizing of windows:
- Productionsites no longer close their window when the stop/start button is 
pressed.
- Minimized construction windows no longer get maximized when the construction 
is finished.
- Window is no longer closed on enhance or dismantle.

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/notifications_buildingwindows.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-27 Thread Klaus Halfmann
Going to fetch this now, but will need som testing on my multi Monitor setup.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-27 Thread Klaus Halfmann
Review: Needs Fixing

Now Can always reproduce this :-(

Open in fullscreeen mode:

 GRAPHICS REPORT 
 VIDEO DRIVER cocoa
 pixel fmt 372645892
 size 1440 900
 END GRAPHICS REPORT 

Open options menu:
4   widelands   0x000100946b2e 
UI::Panel::set_size(int, int) + 142 (panel.cc:243)
5   widelands   0x00010095af4b 
UI::SpinBox::layout() + 1131 (spinbox.cc:202)
6   widelands   0x00010095a3ae 
UI::SpinBox::SpinBox(UI::Panel*, int, int, unsigned int, unsigned int, int, 
int, int, std::__1::basic_string, 
std::__1::allocator > const&, UI::SpinBox::Units const&, Image const*, 
UI::SpinBox::Type, int, int) + 10814 (spinbox.cc:171)
7   widelands   0x00010095a9c9 
UI::SpinBox::SpinBox(UI::Panel*, int, int, unsigned int, unsigned int, int, 
int, int, std::__1::basic_string, 
std::__1::allocator > const&, UI::SpinBox::Units const&, Image const*, 
UI::SpinBox::Type, int, int) + 249 (spinbox.cc:173)
8   widelands   0x000100a0ee9c 
FullscreenMenuOptions::FullscreenMenuOptions(OptionsCtrl::OptionsStruct) + 8076 
(options.cc:152)

So I would suggest we should spin^h^h^h^h fix these Boxes, too.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1653460-panel-init-width.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands

2017-02-27 Thread GunChleoc
Review: Resubmit

Next try - should be all fixed now.

> Minor nit (can be ignored): When the building is finished, the (minimized) 
> window is brought to the front (!= maximized). Not really a problem in my 
> opinion.

We will probably have to dig into the UI toolkit for that, so let's leave it 
for later and see if it annoys anybody.
-- 
https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/notifications_buildingwindows.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-27 Thread kaputtnik
Review: Needs Fixing

konsole output and Backtrace:

widelands: 
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/panel.cc:243:
 void UI::Panel::set_size(int, int): Assertion `nw >= 0' failed.

Thread 1 "widelands" received signal SIGABRT, Aborted.
0x7513b04f in raise () from /usr/lib/libc.so.6
(gdb) backtrace
#0  0x7513b04f in raise () from /usr/lib/libc.so.6
#1  0x7513c47a in abort () from /usr/lib/libc.so.6
#2  0x75133ea7 in __assert_fail_base () from /usr/lib/libc.so.6
#3  0x75133f52 in __assert_fail () from /usr/lib/libc.so.6
#4  0x00edafe4 in UI::Panel::set_size (this=0x1c30c40, nw=-8, nh=10)
at 
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/panel.cc:243
#5  0x00ee55ad in UI::SpinBox::layout (this=0x1c08e70) at 
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/spinbox.cc:201
#6  0x00ee4fb3 in UI::SpinBox::SpinBox (this=0x1c08e70, 
parent=0x1c077c8, x=0, y=0, w=0, unit_w=0, startval=30, minval=0, maxval=99, 
label_text="Maximum FPS:", 
unit=@0x7fffbc4c: UI::SpinBox::Units::kNone, 
button_background=0x1dea428, type=UI::SpinBox::Type::kSmall, step_size=1, 
big_step_size=10)
at 
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/spinbox.cc:171
#7  0x00f4c6ee in FullscreenMenuOptions::FullscreenMenuOptions 
(this=0x1c06fa0, opt=...)
at 
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_fsmenu/options.cc:234
#8  0x00f51430 in OptionsCtrl::OptionsCtrl (this=0x7fffdf10, s=...)
at 
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_fsmenu/options.cc:539
#9  0x00c3136e in WLApplication::mainmenu (this=0x1960b10) at 
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/wlapplication.cc:1013
#10 0x00c2de4c in WLApplication::run (this=0x1960b10) at 
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/wlapplication.cc:444
#11 0x00c2c4c1 in main (argc=1, argv=0x7fffe588) at 
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/main.cc:49
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1653460-panel-init-width.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands

2017-02-27 Thread bunnybot
Continuous integration builds have changed state:

Travis build 2007. State: failed. Details: 
https://travis-ci.org/widelands/widelands/builds/205821093.
Appveyor build 1843. State: failed. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1653460_panel_init_width-1843.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1653460-panel-init-width.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands

2017-02-27 Thread Notabilis
Review: Approve

Thanks for fixing, diffs looks good to me and it works as wanted when testing. 
Thanks for the change regarding upgrades and dismantling.

I don't really understand your fix for the segfault. As far as I can see, your 
only change is storing the parent pointer now in the BuildingWindow instead of 
inheriting it. Do you know what is happening there? Wild guess: A strange order 
of destructing the classes and using the already cleared pointer when 
destroying BuildingWindow?

Also, I don't believe that you are using the coord-entry (partially because I 
removed it without any visible complains). There isn't any call to  
std::get<0>() anywhere and the coords variable which is used in the marked line 
comes from the handled building. It's not important, though.

As far as I am concerned, the branch can be merged now.
-- 
https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/notifications_buildingwindows.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


[Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands

2017-02-27 Thread bunnybot
Continuous integration builds have changed state:

Travis build 2008. State: passed. Details: 
https://travis-ci.org/widelands/widelands/builds/205845483.
Appveyor build 1844. State: success. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_gcc63-1844.
-- 
https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/gcc63 into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653254-flagaction-roads into lp:widelands

2017-02-27 Thread bunnybot
Continuous integration builds have changed state:

Travis build 2010. State: passed. Details: 
https://travis-ci.org/widelands/widelands/builds/205917921.
Appveyor build 1846. State: failed. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1653254_flagaction_roads-1846.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1653254-flagaction-roads/+merge/317709
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1653254-flagaction-roads.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


[Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands

2017-02-27 Thread bunnybot
Continuous integration builds have changed state:

Travis build 2011. State: passed. Details: 
https://travis-ci.org/widelands/widelands/builds/205918080.
Appveyor build 1847. State: failed. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_notifications_buildingwindows-1847.
-- 
https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/notifications_buildingwindows.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp