[Widelands-dev] [Merge] lp:~widelands-dev/widelands/changelog-201609 into lp:widelands

2016-09-24 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/changelog-201609 
into lp:widelands.

Commit message:
Updated changelog until r8110

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/changelog-201609/+merge/306689

I removed all bugs that weren't present in Build 18, summarized some entries 
and categorized everything for easier reading.
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/changelog-201609 into lp:widelands.
=== modified file 'ChangeLog'
--- ChangeLog	2016-08-07 11:33:13 +
+++ ChangeLog	2016-09-24 08:53:43 +
@@ -1,592 +1,430 @@
-### Build 19 until r7914
-
-- Reversed semantics of "Do not zip" checkbox on the Options screen.
-- More intelligent handling of units in spinboxes.
-- Fixed bug #1162527: Military statistics button seem cropped when selected.
-- Fixed bug #1562071: Visual glitch in chat overlay as well as chat overlay
-  transparency.
-- Added missing pixel on the bottom right corner in the draw_rect program.
-- Fixed bug #1540827: Bug with establishing smuggling routes in the Smugglers
-  scenario.
-- Stopped the infotool from painting.
-- Fixed bug #1252625: Plot areas now update their data less often.
-- Fixed bug #1559729: Port space not shown.
-- Added census/statistics strings to ships and ship construction.
-- Ship states are now an enum class.
-- Watchwindow fixes: Fixed some oddities such as view duplication:
-  - Possibly fixed bug #1553699 (probable cause: std::erase used on invalid
-position, which results in undefined behavior).
-  - Highlight the current view button.
-- Better coloring for workarea pics.
-- Fixed a crash where a leaked remnant of the game session would still be
-  subscribed to the 'changed resolution' event if a savegame failed to load.
-- Fixed bug #1556621: Catalogs with overlapping source file by moving win
-  condition helper scripts into win_conditions directory.
-- Unified debug button texts.
-- Added Hasi50 (Klaus Halfmann) to developers list.
-- Ships get debug window. Also its content are extended.
-- Fixed bug #1550568: Editor crashes upon placing resources.
-- Changed color of statistics string for Dismantlesite to match Constructionsite.
-- AI: Roads rework.
-- Fixed bug #1191556: The "Cancel Expedition" button in Port windows will now
-  toggle and remove the tab.
-- Using auto for more efficient iterating over maps.
-- Deleted stillborn translation projects (en_AU and es_CO).
-- Added map/wiki credit for king of nowhere.
-- Added a new codecheck rule that requires comments to start with a blank space.
-- Various string fixes for issues reported on Transifex.
-- Some refactoring for the Soldier code.
-- Added New starting condition "Training Outpost" that will periodically give
-  the player some wares if needed (cheat mode)
-- Fixed line drawing by replacing the broken use of GL_LINES with a tessellation
-  algorithm for drawing lines.
-- Listselect now uses the new font renderer, and text is aligned according to rtl/ltr per entry.
-- Implemented locale fontset selection by word into the new renderer.
-- Fontsets now have a representative character that is used to calculate line height.
-- Fixed an overflow bug in the renderer.
-- Use -Werror=deprecated for clang compiles.
-- Fixes to buildcat.py: United 'do_compile' and 'do_compile_src' functions and
-  also improved error handling a bit.
-- Fixed overlapping building names and long window titles.
-- Shut up spammy sphinx-warning.
-- Fixed bug #1525706: Wincondition artifacts could be chosen if no artifacts
-  are available in map.
-- Fixed bug #1546153: Editor removes "Suggested Teams" when saving.
-- Fixed pointer error in box.cc. This fixes the button width in the general
-  statistics GUI.
-- Fixed text cropping in DiscreteSlider.
-- Gave plot area bottom axis labels some space.
-- autofit_ui_text now calls richtext_escape.
-- New tree/terrain values.
-- Fixed bug #1540782: Multiline edit box shows new text only when hitting
-  backspace.
-- Fixed bug #1551578: Fortified Village crashes when building can't be placed.
-  Also fixed some building names in starting conditions.
-- Returned editor strings to buildcat.py.
-- Fixed bug #1542705: Consolidate names in bob worker programs: Renamed program
-  "geologist-find" to "geologist_find" and "playFX" to
-  "play_sound".
-- Fixed bug #1546095: Crash when typing "\" in Editor text fields.
-- Fixed bug #1513181: Multiplayer chat don't display any more my fixing the check
-  in ChatOverlay whether a chat provider has been assigned.
-- Added the buildings where a worker can work to worker help.
-- AI: reworked upgrading.
-- Fixed bug #1509172: Editor gives error on saving maps in Wi

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/changelog-201609 into lp:widelands

2016-09-24 Thread bunnybot
Continuous integration builds have changed state:

Travis build 1354. State: passed. Details: 
https://travis-ci.org/widelands/widelands/builds/162405856.
Appveyor build 1196. State: success. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_changelog_201609-1196.
-- 
https://code.launchpad.net/~widelands-dev/widelands/changelog-201609/+merge/306689
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/changelog-201609 into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-536489-dropdown into lp:widelands

2016-09-24 Thread Klaus Halfmann
Review: Needs Fixing compile, test

This Drodown is missing a feature found in all normal GUIs:

when you click outside the dropdown it will NOT collapse, 
allowing the user to click somewhere else. 
This implementation will do nothing in this case.
So if I forgot that the Dropdown is open and click somwhere else
It seems stuck as I get no visual feedback what to do.
This may frustrate players upto a level where theey will kill the game.

In additon it does not collapse when pressing Escape, 
instead the complete dialog is canceled.


Sorry Gun.

Good work otherwise. I will continue to review the usage and code.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-536489-dropdown/+merge/306303
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-536489-dropdown.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-536489-dropdown into lp:widelands

2016-09-24 Thread GunChleoc
Good points. The escape key thing should be easy to do, for the collapse when 
clicked outside of it I will need to dig around a bit.

Thanks for testing!
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-536489-dropdown/+merge/306303
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-536489-dropdown.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp