Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/cleanup_ggz into lp:widelands-website
Review: Approve
the metaserver executes only these two queries:
select password from wlggz_ggzauth where user_id=?
select permissions from wlggz_ggzauth where user_id=?
so your assessment is correct, only user_id, permissions and password are ever
read.
I'd vote for removing the fields - since they are unused removing them will
reveal the real structure of the code better and allow us to refactor
eventually towards something that makes more sense. Unused code is always
better deleted!
One nit in the comments below.
Diff comments:
>
> === modified file 'local_settings.py.sample'
> --- local_settings.py.sample 2016-06-26 11:30:10 +
> +++ local_settings.py.sample 2016-07-31 12:32:05 +
> @@ -19,8 +19,40 @@
>
>
> # The following are just dummy values, but needed defined
> +# To use the registration you have to create an API key pair
> +# See https://developers.google.com/recaptcha/docs/start
> +# You have to use 'localhost' as Domain
> NORECAPTCHA_SITE_KEY = 'dummy'
> NORECAPTCHA_SECRET_KEY = 'dummy'
>
> # The logo used for mainpage
> LOGO_FILE = 'Logo_alpha.png'
> +
> +# Setting an email backend prevents 'connection refused' errors
> +# This Backend shows Emails in console
> +EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'
Add a comment that this is overwritte on the server to actually send email?
> +
> +# Uncomment 'LOGGING = {...}' for debugging purposes when you have set
> DEBUG=False.
> +# Use then in the code:
> +
> +# import logging
> +# log = logging.getLogger(__name__)
> +# log.info('Variable x: %s', x)
> +
> +# This prints the value for Variable 'x' to log.txt
> +
> +#LOGGING = {
> +#'version': 1,
> +#'disable_existing_loggers': False,
> +#'handlers': {
> +#'logfile': {
> +#'level':'DEBUG',
> +#'class':'logging.FileHandler',
> +#'filename': bd + "/log.txt",
> +#},
> +#},
> +#'root': {
> +#'level': 'INFO',
> +#'handlers': ['logfile']
> +#},
> +#}
--
https://code.launchpad.net/~widelands-dev/widelands-website/cleanup_ggz/+merge/301588
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1588063 into lp:widelands
Continuous integration builds have changed state: Travis build 1229. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/149710458. Appveyor build 1071. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1588063-1071. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1588063. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands
Yes, you need to start the tutorial from the beginning again - otherwise, the Lua script won't be loaded from scratch. Sorry for nor doing the trunk merge myself, I'm a bit snowed under at the moment. -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/seafaring-final-objective. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1588063 into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1588063 into lp:widelands has been updated. Commit Message changed to: Fix automatic creation of the maps/My_Maps folder in Windows. Prevent the user from entering illegal filenames. For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1588063. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1588063 into lp:widelands
Continuous integration builds have changed state: Travis build 1229. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/149710458. Appveyor build 1071. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1588063-1071. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1588063. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands
Review: Approve compile, play OK, finally it works. Now please tell me why that simple code change did this trick. Can I merge this wia launchpad now, or must someone else do this? -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/seafaring-final-objective. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands
Do you see the o.done = true a few lines below the changed line? That marks the objective as done. However, the current objective was o2, so it was never marked as done. -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/seafaring-final-objective. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/seafaring-final-objective. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/seafaring-final-objective into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/seafaring-final-objective. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Build #10563218] amd64 build of widelands 1:18-ppa0-bzr8049-201608041702~ubuntu16.10.1 in ubuntu yakkety RELEASE [~widelands-dev/ubuntu/widelands-daily]
* Source Package: widelands * Version: 1:18-ppa0-bzr8049-201608041702~ubuntu16.10.1 * Architecture: amd64 * Archive: ~widelands-dev/ubuntu/widelands-daily * Component: main * State: Failed to build * Duration: 26 minutes * Build Log: https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/10563218/+files/buildlog_ubuntu-yakkety-amd64.widelands_1%3A18-ppa0-bzr8049-201608041702~ubuntu16.10.1_BUILDING.txt.gz * Builder: https://launchpad.net/builders/lgw01-28 * Source: not available If you want further information about this situation, feel free to contact a member of the Launchpad Buildd Administrators team. -- amd64 build of widelands 1:18-ppa0-bzr8049-201608041702~ubuntu16.10.1 in ubuntu yakkety RELEASE https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/10563218 You are receiving this email because you created this version of this package. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Build #10563219] i386 build of widelands 1:18-ppa0-bzr8049-201608041702~ubuntu16.10.1 in ubuntu yakkety RELEASE [~widelands-dev/ubuntu/widelands-daily]
* Source Package: widelands * Version: 1:18-ppa0-bzr8049-201608041702~ubuntu16.10.1 * Architecture: i386 * Archive: ~widelands-dev/ubuntu/widelands-daily * Component: main * State: Failed to build * Duration: 49 minutes * Build Log: https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/10563219/+files/buildlog_ubuntu-yakkety-i386.widelands_1%3A18-ppa0-bzr8049-201608041702~ubuntu16.10.1_BUILDING.txt.gz * Builder: https://launchpad.net/builders/lcy01-02 * Source: not available If you want further information about this situation, feel free to contact a member of the Launchpad Buildd Administrators team. -- i386 build of widelands 1:18-ppa0-bzr8049-201608041702~ubuntu16.10.1 in ubuntu yakkety RELEASE https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/10563219 You are receiving this email because you created this version of this package. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1588063 into lp:widelands
Bunnybot encountered an error while working on this merge proposal: The read operation timed out -- https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1588063. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1588063 into lp:widelands
Continuous integration builds have changed state: Travis build 1231. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/149798427. Appveyor build 1073. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1588063-1073. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1588063. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/cleanup_ggz into lp:widelands-website
Regarding your code comment: I actually do not know how sending e-mails is processed on the server. A value for EMAIL_BACKEND isn't set there. So adding a comment like: "Disable this on the widelands server"? Or we make it dependent of the DEBUG value: if DEBUG = True: EMAIL_BACKEND = ? Should the related tables in the database also be dropped? Namely: | wlggz_matches| | wlggz_matchplayers | | wlggz_permissions| | wlggz_stats | Those tables are the ones created by ggz_models.py (which will be removed in this branch). Actually they are empty (no data). The only table which contains data is wlggz_ggzauth (461 rows) which is used by wlggz.models.py. The latter one is also the only one which is listed in table django_content_type. -- https://code.launchpad.net/~widelands-dev/widelands-website/cleanup_ggz/+merge/301588 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-986611-cppcheck_performance into lp:widelands
Continuous integration builds have changed state: Travis build 1234. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/149822460. Appveyor build 1076. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_986611_cppcheck_performance-1076. -- https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck_performance/+merge/301043 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-986611-cppcheck_performance into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-986611-cppcheck_performance into lp:widelands
Continuous integration builds have changed state: Travis build 1234. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/149822460. Appveyor build 1076. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_986611_cppcheck_performance-1076. -- https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck_performance/+merge/301043 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-986611-cppcheck_performance into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1588063 into lp:widelands
Testing on OSX: * removed .widelands folder * :bug-1588063$ ./widelands --editor * Created some random map and saved it * found ./widelands/maps/My_Maps, OK * Copied some selfmade map into ./widelands/maps ls -R maps Crossriver.wmf My_Maps maps/My_Maps: Test1608558.wmf * I can open Crossriver.wmf in the Editor, is merged into the list of Maps. I now will restore my old .widelands folder an try some evil characters -- https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1588063. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
