Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/food_icons into lp:widelands
It positions the center of an animation. In this case, when the ware is lying at a flag or is being carried. -- https://code.launchpad.net/~widelands-dev/widelands/food_icons/+merge/259327 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/food_icons into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/food_icons into lp:widelands
OK, the code looks good (no much code here in fact), but I will have to compile it to look at this. When my time allows it... Or if somebody else would look at it... -- https://code.launchpad.net/~widelands-dev/widelands/food_icons/+merge/259327 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/food_icons into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/food_icons into lp:widelands
Since there are no changes in C++, you could just copy the tribes directory into trunk for testing. -- https://code.launchpad.net/~widelands-dev/widelands/food_icons/+merge/259327 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/food_icons into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1455732 into lp:widelands
Review: Needs Fixing Hi, I did some quick testing of this patch. I found that if any mine is selected, I get a similar crash when attempting to save. I guess that needs a similar fix. I saw some crashes when selecting dismantling site and then something else, but those might have been caused by the other building happening to be a mine. Hard to tell, but I can check again once that's fixed. I only skimmed the code changes, but thumbs up for replacing the if statements with a switch, :) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1455732/+merge/259326 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1455732. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/food_icons into lp:widelands
Review: Approve OK, I tested it. I havent seen a much, but as images were discussed on the forum, it can go... -- https://code.launchpad.net/~widelands-dev/widelands/food_icons/+merge/259327 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/food_icons. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/food_icons into lp:widelands
Review: Needs Information Thanks. Now I need some input on how to handle the license before we merge this. -- https://code.launchpad.net/~widelands-dev/widelands/food_icons/+merge/259327 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/food_icons. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
