Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands
Looks generally good to me :). Good work martin! About the different problems: * the Mac problems SirVer faced are possibly based upon the clearing of LANGUAGE and the setting of LANG - I am quite sure that there was a comment somewhere, that macos needs the variable LANGUAGE set (perhaps "only the variable" ?) - however following the way of "never change a running system" (and it seems it does work before), we should try to not clear LANGUAGE initially and perhaps all the changes of LANG should be removed as well. SirVer could you please test, whether that solves your problems? * I support Hans Joachim Desserud's wish, to not block languages, that can not be found - here on my German localized Mandriva Linux (just de and en locales installed) switching the language to Spanish or Swedish worked quite fine until now, ... -- https://code.launchpad.net/~widelands-dev/widelands/martin_i18n/+merge/49202 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/martin_i18n. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands
Review: Needs Information Sorry, still didn't find out, how to contribute code on this launchpad branch. So again, I posted a patch via pastebin: http://pastebin.com/qPmabxe7 The LANGUAGE environment variable is now used on Mac OS X, instead of LANG. Moreover, unsetting the variable now happens just under Linux. If (in Linux) no installed locale for the selected language is found, I now set the LANG variable directly to the selected language. This should bring back the feature of selecting uninstalled languages on other distros than Ubuntu. Please try, if this patch works - or whether we still need to set the LANGUAGE variable again. I can confirm, that it works with Ubuntu (except for the selection of uninstalled languages, but this should be no problem). -- https://code.launchpad.net/~widelands-dev/widelands/martin_i18n/+merge/49202 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/martin_i18n. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands
Review: Needs Information Okay, I found the problem with mac os x not filling the list: widelands checks in the CWD for the localedir and enumerates the locales it finds there but it tries to load the locales from the --localedir= commandline option. So things are a bit awkward - currently I can either have the list of all languages or get the game localized. Okay, so we have success reports from windows, mac and linux. The problems described are likely not related to this bug. Martin, with ID i mean your credit card. It is common that new developers pay a fee to join in the widelands development which is currently 50€. ... just kidding. I need a name or nickname that you want to have apearing on our developers list: http://wl.widelands.org/developers I can then go ahead and merge this branch. Maybe you are also interested to sort the remaining issues out, even though they are not of your making? -- https://code.launchpad.net/~widelands-dev/widelands/martin_i18n/+merge/49202 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/martin_i18n. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands
> Okay, so we have success reports from windows, mac and linux. You mean 5829? Or the later patch (see above)? > I need a name or nickname that you want to have apearing on our > developers list: > http://wl.widelands.org/developers Thank you! You can add my name to the list like this: Martin Prussak (martin) (for Coders and Translators, I think) but my user IDs for widelands.org and launchpad.net are not the same... -- https://code.launchpad.net/~widelands-dev/widelands/martin_i18n/+merge/49202 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/martin_i18n. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands
>I can confirm, that it works with Ubuntu (except for the selection of >uninstalled languages, but this >should be no problem). I'd preferably like to see this fixed before the branch is merged, as it is a somewhat strange regression. Out of curiosity I checked Wesnoth earlier today, and I was able to switch to other languages even when the locale wasn't installed. Slightly off-topic: Martin, for uploading code to Launchpad see https://help.launchpad.net/YourAccount/CreatingAnSSHKeyPair and https://help.launchpad.net/Code/UploadingABranch . -- https://code.launchpad.net/~widelands-dev/widelands/martin_i18n/+merge/49202 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/martin_i18n. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
