[webkit-changes] [WebKit/WebKit] 49fef5: [PlayStation] Build fix after 274652@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 49fef559975eadeb4609dfe423aed84f43dcacb9 https://github.com/WebKit/WebKit/commit/49fef559975eadeb4609dfe423aed84f43dcacb9 Author: Stephan Szabo Date: 2024-02-14 (Wed, 14 Feb 2024) Changed paths: M Source/WebCore/page/PageOverlayController.h Log Message: --- [PlayStation] Build fix after 274652@main https://bugs.webkit.org/show_bug.cgi?id=269415 Unreviewed build fix. In our configuration GraphicsLayer is just a forward declaration in PageOverlayController, so we have errors, so make sure that the header is included. * Source/WebCore/page/PageOverlayController.h: Canonical link: https://commits.webkit.org/274693@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6bfe0: Cherry-pick 266736@main (241927320742). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: a6bfe0fc626d853651f40a5d9ea387fbad230a5e https://github.com/WebKit/WebKit/commit/a6bfe0fc626d853651f40a5d9ea387fbad230a5e Author: Stephan Szabo Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M Source/WebCore/rendering/style/RenderStyle.h Log Message: --- Cherry-pick 266736@main (241927320742). https://bugs.webkit.org/show_bug.cgi?id=259986 [PlayStation] Fix build after 266683@main https://bugs.webkit.org/show_bug.cgi?id=259986 Unreviewed build fix Add header needed to get OptionSet. * Source/WebCore/rendering/style/RenderStyle.h: Canonical link: https://commits.webkit.org/266736@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c8c1c: [PlayStation] LLVM17 warning workaround for system...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c8c1cb79116b9d5ce4f27a97a8cbca3132a578e https://github.com/WebKit/WebKit/commit/8c8c1cb79116b9d5ce4f27a97a8cbca3132a578e Author: Stephan Szabo Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- [PlayStation] LLVM17 warning workaround for system macro redef https://bugs.webkit.org/show_bug.cgi?id=261896 Unreviewed build fix Turn off warning for system macro redefinition until we can stop undefining __cpp_char8_t because we have only limited support. * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/268268@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c24c48: Remove warnings in NativePromise when both log and...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c24c48984502bd991c37671f60c089e0104454a3 https://github.com/WebKit/WebKit/commit/c24c48984502bd991c37671f60c089e0104454a3 Author: Stephan Szabo Date: 2023-09-22 (Fri, 22 Sep 2023) Changed paths: M Source/WTF/wtf/NativePromise.h Log Message: --- Remove warnings in NativePromise when both log and release log are disabled. https://bugs.webkit.org/show_bug.cgi?id=261899 Reviewed by Youenn Fablet. Add conditional UNUSED_PARAMs to additional methods in NativePromise when both LOG_DISABLED and RELEASE_LOG_DISABLED are true. * Source/WTF/wtf/NativePromise.h: Canonical link: https://commits.webkit.org/268318@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8ad41: Fix build issue when !ENABLE(FILTERS_LEVEL_2)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8ad412976d94ba6f1d0d1cceaea43e9a05ce0d8 https://github.com/WebKit/WebKit/commit/c8ad412976d94ba6f1d0d1cceaea43e9a05ce0d8 Author: Stephan Szabo Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/rendering/RenderLayer.cpp Log Message: --- Fix build issue when !ENABLE(FILTERS_LEVEL_2) https://bugs.webkit.org/show_bug.cgi?id=262384 Unreviewed build fix Add enable check around use of cssUnprefixedBackdropFilterEnabled * Source/WebCore/rendering/RenderLayer.cpp: Canonical link: https://commits.webkit.org/268665@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fbd5eb: [PlayStation] Build fix after 255274@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fbd5ebf5082dbaaff4b5f817445cc5eae795 https://github.com/WebKit/WebKit/commit/fbd5ebf5082dbaaff4b5f817445cc5eae795 Author: Stephan Szabo Date: 2022-10-07 (Fri, 07 Oct 2022) Changed paths: M Source/WTF/wtf/ThreadAssertions.h Log Message: --- [PlayStation] Build fix after 255274@main 2022-10-07 Stephan Szabo [PlayStation] Build fix after 255274@main https://bugs.webkit.org/show_bug.cgi?id=246232 Unreviewed build fix * Source/WTF/wtf/ThreadAssertions.h: Canonical link: https://commits.webkit.org/255303@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55e44f: Fix running jsc tests on Windows (non-cygwin) afte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55e44f92c5bb72f9ed33bbb571c531b738c38634 https://github.com/WebKit/WebKit/commit/55e44f92c5bb72f9ed33bbb571c531b738c38634 Author: Stephan Szabo Date: 2024-01-14 (Sun, 14 Jan 2024) Changed paths: M Tools/Scripts/run-jsc-stress-tests M Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb Log Message: --- Fix running jsc tests on Windows (non-cygwin) after 272663@main https://bugs.webkit.org/show_bug.cgi?id=267424 Reviewed by Ryan Haddad. Update the ruby writer to no longer use the removed variable name for the 'prefix' of the results name and to append results to that file. Change the reading to not use directly File.open().each as that appears to not automatically close the file which causes issues on Windows for later unlink attempts. * Tools/Scripts/run-jsc-stress-tests: * Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb: Canonical link: https://commits.webkit.org/273028@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ec45c: [PlayStation] Build fix for missing optional after...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ec45ca99e568b0e785d39aed8c6d62516846ad0 https://github.com/WebKit/WebKit/commit/9ec45ca99e568b0e785d39aed8c6d62516846ad0 Author: Stephan Szabo Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h Log Message: --- [PlayStation] Build fix for missing optional after 273655@main https://bugs.webkit.org/show_bug.cgi?id=268336 Unreviewed build fix. Add the optional include to get std::optional in WebFrameLoaderClient.h * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h: Canonical link: https://commits.webkit.org/273711@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 19ef7f: [Windows] Update buildbot TestJSCFactory to get re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 19ef7f2cb6037b1706c1d86418cee11f8d7ef5e9 https://github.com/WebKit/WebKit/commit/19ef7f2cb6037b1706c1d86418cee11f8d7ef5e9 Author: Stephan Szabo Date: 2023-04-28 (Fri, 28 Apr 2023) Changed paths: M Tools/CISupport/build-webkit-org/factories.py M Tools/CISupport/build-webkit-org/factories_unittest.py Log Message: --- [Windows] Update buildbot TestJSCFactory to get requirements for wincairo https://bugs.webkit.org/show_bug.cgi?id=256070 Reviewed by Jonathan Bedard. Add step for wincairo TestJSCFactory to get the requirements like we do in TestFactory after extracting the built product. * Tools/CISupport/build-webkit-org/factories.py: (TestJSCFactory.__init__): * Tools/CISupport/build-webkit-org/factories_unittest.py: (TestExpectedBuildSteps): Canonical link: https://commits.webkit.org/263508@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 415f4e: [PlayStation] Fix build issue after 263493@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 415f4e946387218d7c0a55157859b7d9b0a6db1d https://github.com/WebKit/WebKit/commit/415f4e946387218d7c0a55157859b7d9b0a6db1d Author: Stephan Szabo Date: 2023-04-28 (Fri, 28 Apr 2023) Changed paths: M Source/WebCore/platform/playstation/WidgetPlayStation.cpp Log Message: --- [PlayStation] Fix build issue after 263493@main https://bugs.webkit.org/show_bug.cgi?id=256106 Unreviewed build fix Follow change from EventRegionContext to RegionContext in playstation specific implementation file. * Source/WebCore/platform/playstation/WidgetPlayStation.cpp: (WebCore::Widget::paint): Canonical link: https://commits.webkit.org/263515@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 241927: [PlayStation] Fix build after 266683@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2419273207423907ea3421af58a34cb12d2b89d5 https://github.com/WebKit/WebKit/commit/2419273207423907ea3421af58a34cb12d2b89d5 Author: Stephan Szabo Date: 2023-08-09 (Wed, 09 Aug 2023) Changed paths: M Source/WebCore/rendering/style/RenderStyle.h Log Message: --- [PlayStation] Fix build after 266683@main https://bugs.webkit.org/show_bug.cgi?id=259986 Unreviewed build fix Add header needed to get OptionSet. * Source/WebCore/rendering/style/RenderStyle.h: Canonical link: https://commits.webkit.org/266736@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287555] trunk/Source/WebKit
Title: [287555] trunk/Source/WebKit Revision 287555 Author stephan.sz...@sony.com Date 2022-01-03 15:46:51 -0800 (Mon, 03 Jan 2022) Log Message [PlayStation] Build fix after r287552 https://bugs.webkit.org/show_bug.cgi?id=234828 Unreviewed build fix. Needed WebCore prefixing on SRGBA. * UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (287554 => 287555) --- trunk/Source/WebKit/ChangeLog 2022-01-03 21:49:37 UTC (rev 287554) +++ trunk/Source/WebKit/ChangeLog 2022-01-03 23:46:51 UTC (rev 287555) @@ -1,3 +1,14 @@ +2022-01-03 Stephan Szabo + +[PlayStation] Build fix after r287552 +https://bugs.webkit.org/show_bug.cgi?id=234828 + +Unreviewed build fix. + +Needed WebCore prefixing on SRGBA. + +* UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp: + 2022-01-03 Sam Weinig Add resolved/unresolved color type accessors to require users to be explicit about whether they will handle missing/none color components Modified: trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp (287554 => 287555) --- trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp 2022-01-03 21:49:37 UTC (rev 287554) +++ trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp 2022-01-03 23:46:51 UTC (rev 287555) @@ -42,7 +42,7 @@ if (!backgroundColor || backgroundColor.value().isVisible()) return; -auto [r, g, b, a] = backgroundColor.value().toColorTypeLossy>().resolved(); +auto [r, g, b, a] = backgroundColor.value().toColorTypeLossy>().resolved(); cairo_set_source_rgba(ctx, r, g, b, a); cairo_rectangle(ctx, rect.x(), rect.y(), rect.width(), rect.height()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287585] trunk/Source/JavaScriptCore
Title: [287585] trunk/Source/_javascript_Core Revision 287585 Author stephan.sz...@sony.com Date 2022-01-04 13:38:09 -0800 (Tue, 04 Jan 2022) Log Message [PlayStation] Fix non-ninja build of zydis https://bugs.webkit.org/show_bug.cgi?id=234854 Unreviewed build fix * PlatformPlayStation.cmake: Set Zycore.c as CXX Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/PlatformPlayStation.cmake Diff Modified: trunk/Source/_javascript_Core/ChangeLog (287584 => 287585) --- trunk/Source/_javascript_Core/ChangeLog 2022-01-04 21:34:48 UTC (rev 287584) +++ trunk/Source/_javascript_Core/ChangeLog 2022-01-04 21:38:09 UTC (rev 287585) @@ -1,3 +1,12 @@ +2022-01-04 Stephan Szabo + +[PlayStation] Fix non-ninja build of zydis +https://bugs.webkit.org/show_bug.cgi?id=234854 + +Unreviewed build fix + +* PlatformPlayStation.cmake: Set Zycore.c as CXX + 2022-01-04 Yusuke Suzuki [JSC] Remove JSWebAssemblyCalleeGroup cell Modified: trunk/Source/_javascript_Core/PlatformPlayStation.cmake (287584 => 287585) --- trunk/Source/_javascript_Core/PlatformPlayStation.cmake 2022-01-04 21:34:48 UTC (rev 287584) +++ trunk/Source/_javascript_Core/PlatformPlayStation.cmake 2022-01-04 21:38:09 UTC (rev 287585) @@ -15,7 +15,7 @@ disassembler/zydis/Zydis/ZycoreList.c disassembler/zydis/Zydis/ZycoreString.c disassembler/zydis/Zydis/ZycoreVector.c -disassembler/zydis/Zydis/ZycoreZycore.c +disassembler/zydis/Zydis/Zycore.c disassembler/zydis/Zydis/Zydis.c disassembler/zydis/Zydis/ZydisDecoder.c disassembler/zydis/Zydis/ZydisDecoderData.c ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287685] trunk/Source/bmalloc
Title: [287685] trunk/Source/bmalloc
Revision 287685
Author stephan.sz...@sony.com
Date 2022-01-06 07:57:49 -0800 (Thu, 06 Jan 2022)
Log Message
[PlayStation] Fix non-ninja PlayStation build after r285853
https://bugs.webkit.org/show_bug.cgi?id=234922
Unreviewed build fix.
* PlatformPlayStation.cmake: Added. For MSVS playstatino builds, compile as C++ to
avoid issues with the standard set being invalid.
Modified Paths
trunk/Source/bmalloc/ChangeLog
Added Paths
trunk/Source/bmalloc/PlatformPlayStation.cmake
Diff
Modified: trunk/Source/bmalloc/ChangeLog (287684 => 287685)
--- trunk/Source/bmalloc/ChangeLog 2022-01-06 15:31:46 UTC (rev 287684)
+++ trunk/Source/bmalloc/ChangeLog 2022-01-06 15:57:49 UTC (rev 287685)
@@ -1,3 +1,13 @@
+2022-01-06 Stephan Szabo
+
+[PlayStation] Fix non-ninja PlayStation build after r285853
+https://bugs.webkit.org/show_bug.cgi?id=234922
+
+Unreviewed build fix.
+
+* PlatformPlayStation.cmake: Added. For MSVS playstatino builds, compile as C++ to
+avoid issues with the standard set being invalid.
+
2022-01-04 Philippe Normand
[PAS] constant-logical-operand clang warnings
Added: trunk/Source/bmalloc/PlatformPlayStation.cmake (0 => 287685)
--- trunk/Source/bmalloc/PlatformPlayStation.cmake (rev 0)
+++ trunk/Source/bmalloc/PlatformPlayStation.cmake 2022-01-06 15:57:49 UTC (rev 287685)
@@ -0,0 +1,8 @@
+if (${CMAKE_GENERATOR} MATCHES "Visual Studio")
+# With the VisualStudio generator, the compiler complains about -std=c++* for C sources.
+set_source_files_properties(
+${bmalloc_SOURCES}
+PROPERTIES LANGUAGE CXX
+)
+endif ()
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287718] trunk
Title: [287718] trunk Revision 287718 Author stephan.sz...@sony.com Date 2022-01-06 15:00:36 -0800 (Thu, 06 Jan 2022) Log Message [PlayStation] Fix build break after r287698 https://bugs.webkit.org/show_bug.cgi?id=234931 Unreviewed build fix .: * Source/cmake/OptionsPlayStation.cmake: Workaround for not having u8string for gtest. Source/WTF: * wtf/PlatformHave.h: Use MISSING_STD_FILESYSTEM_PATH_CONSTRUCTOR on PlayStation Modified Paths trunk/ChangeLog trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/cmake/OptionsPlayStation.cmake Diff Modified: trunk/ChangeLog (287717 => 287718) --- trunk/ChangeLog 2022-01-06 22:31:58 UTC (rev 287717) +++ trunk/ChangeLog 2022-01-06 23:00:36 UTC (rev 287718) @@ -1,3 +1,12 @@ +2022-01-06 Stephan Szabo + +[PlayStation] Fix build break after r287698 +https://bugs.webkit.org/show_bug.cgi?id=234931 + +Unreviewed build fix + +* Source/cmake/OptionsPlayStation.cmake: Workaround for not having u8string for gtest. + 2022-01-06 Fujii Hironori [MSVC] Suppress new warnings C5054 and C5055 introduced by /permissive- Modified: trunk/Source/WTF/ChangeLog (287717 => 287718) --- trunk/Source/WTF/ChangeLog 2022-01-06 22:31:58 UTC (rev 287717) +++ trunk/Source/WTF/ChangeLog 2022-01-06 23:00:36 UTC (rev 287718) @@ -1,3 +1,12 @@ +2022-01-06 Stephan Szabo + +[PlayStation] Fix build break after r287698 +https://bugs.webkit.org/show_bug.cgi?id=234931 + +Unreviewed build fix + +* wtf/PlatformHave.h: Use MISSING_STD_FILESYSTEM_PATH_CONSTRUCTOR on PlayStation + 2022-01-06 Alex Christensen Start using C++20 Modified: trunk/Source/WTF/wtf/PlatformHave.h (287717 => 287718) --- trunk/Source/WTF/wtf/PlatformHave.h 2022-01-06 22:31:58 UTC (rev 287717) +++ trunk/Source/WTF/wtf/PlatformHave.h 2022-01-06 23:00:36 UTC (rev 287718) @@ -115,6 +115,8 @@ #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 12 #define HAVE_MISSING_STD_FILESYSTEM_PATH_CONSTRUCTOR 1 +#elif PLATFORM(PLAYSTATION) +#define HAVE_MISSING_STD_FILESYSTEM_PATH_CONSTRUCTOR 1 #elif COMPILER(GCC) #if !GCC_VERSION_AT_LEAST(9, 0, 0) #define HAVE_MISSING_STD_FILESYSTEM_PATH_CONSTRUCTOR 1 Modified: trunk/Source/cmake/OptionsPlayStation.cmake (287717 => 287718) --- trunk/Source/cmake/OptionsPlayStation.cmake 2022-01-06 22:31:58 UTC (rev 287717) +++ trunk/Source/cmake/OptionsPlayStation.cmake 2022-01-06 23:00:36 UTC (rev 287718) @@ -299,3 +299,7 @@ if (HAVE_MEMMEM) add_definitions(-DHAVE_MEMMEM=1) endif () + +# FIXME: gtest assumes that you will have u8string if __cpp_char8_t +# (feature test macro) is defined. +add_compile_options(-U__cpp_char8_t) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292313] trunk
Title: [292313] trunk
Revision 292313
Author stephan.sz...@sony.com
Date 2022-04-04 12:53:55 -0700 (Mon, 04 Apr 2022)
Log Message
[PlayStation] Re-disable WebDriver
https://bugs.webkit.org/show_bug.cgi?id=238756
Unreviewed build fix
* Source/cmake/OptionsPlayStation.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsPlayStation.cmake
Diff
Modified: trunk/ChangeLog (292312 => 292313)
--- trunk/ChangeLog 2022-04-04 19:48:18 UTC (rev 292312)
+++ trunk/ChangeLog 2022-04-04 19:53:55 UTC (rev 292313)
@@ -1,3 +1,12 @@
+2022-04-04 Stephan Szabo
+
+[PlayStation] Re-disable WebDriver
+https://bugs.webkit.org/show_bug.cgi?id=238756
+
+Unreviewed build fix
+
+* Source/cmake/OptionsPlayStation.cmake:
+
2022-04-04 Adrian Perez de Castro
[WPE][GTK] REGRESSION(r292263): Cannot make release tarballs
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (292312 => 292313)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2022-04-04 19:48:18 UTC (rev 292312)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2022-04-04 19:53:55 UTC (rev 292313)
@@ -50,7 +50,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SMOOTH_SCROLLING PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PRIVATE ${ENABLE_WEBKIT})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_CRYPTO PRIVATE ON)
# Experimental features
@@ -65,6 +64,9 @@
# Features to investigate
#
+# Features that require additional implementation pieces
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PRIVATE OFF)
+
# Features that are temporarily turned off because an implementation is not
# present at this time
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD PRIVATE OFF)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292406] trunk/Source/WTF
Title: [292406] trunk/Source/WTF Revision 292406 Author stephan.sz...@sony.com Date 2022-04-05 11:25:27 -0700 (Tue, 05 Apr 2022) Log Message [PlayStation] Build fix after r292389 https://bugs.webkit.org/show_bug.cgi?id=238816 Unreviewed build fix Add UnixFileDescriptor.h to PlatformPlayStation.cmake as per the changes to PlatformGTK and PlatformWPE. * wtf/PlatformPlayStation.cmake: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformPlayStation.cmake Diff Modified: trunk/Source/WTF/ChangeLog (292405 => 292406) --- trunk/Source/WTF/ChangeLog 2022-04-05 18:05:12 UTC (rev 292405) +++ trunk/Source/WTF/ChangeLog 2022-04-05 18:25:27 UTC (rev 292406) @@ -1,3 +1,15 @@ +2022-04-05 Stephan Szabo + +[PlayStation] Build fix after r292389 +https://bugs.webkit.org/show_bug.cgi?id=238816 + +Unreviewed build fix + +Add UnixFileDescriptor.h to PlatformPlayStation.cmake +as per the changes to PlatformGTK and PlatformWPE. + +* wtf/PlatformPlayStation.cmake: + 2022-04-05 Zan Dobersek [Unix] Add UnixFileDescriptor, use it in IPC::Semaphore Modified: trunk/Source/WTF/wtf/PlatformPlayStation.cmake (292405 => 292406) --- trunk/Source/WTF/wtf/PlatformPlayStation.cmake 2022-04-05 18:05:12 UTC (rev 292405) +++ trunk/Source/WTF/wtf/PlatformPlayStation.cmake 2022-04-05 18:25:27 UTC (rev 292406) @@ -1,3 +1,7 @@ +list(APPEND WTF_PUBLIC_HEADERS +unix/UnixFileDescriptor.h +) + list(APPEND WTF_SOURCES generic/MainThreadGeneric.cpp generic/MemoryFootprintGeneric.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292440] trunk/Source
Title: [292440] trunk/Source
Revision 292440
Author stephan.sz...@sony.com
Date 2022-04-05 16:28:55 -0700 (Tue, 05 Apr 2022)
Log Message
[PlayStation[ Fix build break after r292408
https://bugs.webkit.org/show_bug.cgi?id=238840
Unreviewed build fix.
Source/WebCore:
* platform/LocalizedStrings.cpp:
* platform/network/playstation/CurlSSLHandlePlayStation.cpp:
* platform/playstation/UserAgentPlayStation.cpp:
Source/WebKit:
* UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/LocalizedStrings.cpp
trunk/Source/WebCore/platform/network/playstation/CurlSSLHandlePlayStation.cpp
trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292439 => 292440)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 23:28:55 UTC (rev 292440)
@@ -1,3 +1,14 @@
+2022-04-05 Stephan Szabo
+
+[PlayStation[ Fix build break after r292408
+https://bugs.webkit.org/show_bug.cgi?id=238840
+
+Unreviewed build fix.
+
+* platform/LocalizedStrings.cpp:
+* platform/network/playstation/CurlSSLHandlePlayStation.cpp:
+* platform/playstation/UserAgentPlayStation.cpp:
+
2022-04-05 Matt Woodrow
Support transitions/animations on grid-template-columns|rows
Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (292439 => 292440)
--- trunk/Source/WebCore/platform/LocalizedStrings.cpp 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp 2022-04-05 23:28:55 UTC (rev 292440)
@@ -82,7 +82,7 @@
return String::fromUTF8(result.get());
#else
notImplemented();
-return format;
+return String::fromUTF8(format);
#endif
}
#endif
Modified: trunk/Source/WebCore/platform/network/playstation/CurlSSLHandlePlayStation.cpp (292439 => 292440)
--- trunk/Source/WebCore/platform/network/playstation/CurlSSLHandlePlayStation.cpp 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebCore/platform/network/playstation/CurlSSLHandlePlayStation.cpp 2022-04-05 23:28:55 UTC (rev 292440)
@@ -40,8 +40,8 @@
if (certificateData->size())
setCACertData(WTFMove(caCertData));
-setCipherList(CertificateStore::cipherSuites());
-setCurvesList(CertificateStore::supportedGroups());
+setCipherList(String::fromUTF8(CertificateStore::cipherSuites()));
+setCurvesList(String::fromUTF8(CertificateStore::supportedGroups()));
setIgnoreSSLErrors(CertificateStore::shouldIgnoreTLSErrors());
}
Modified: trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp (292439 => 292440)
--- trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp 2022-04-05 23:28:55 UTC (rev 292440)
@@ -43,9 +43,9 @@
#if HAS_GETENV_NP
char buf[32];
if (!getenv_np("SYSTEM_SOFTWARE_NAME", buf, sizeof(buf)))
-return buf;
+return String::fromUTF8(buf);
#endif
-return "PlayStation";
+return "PlayStation"_s;
}
static String getSystemSoftwareVersion()
@@ -53,9 +53,9 @@
#if HAS_GETENV_NP
char buf[32];
if (!getenv_np("SYSTEM_SOFTWARE_VERSION", buf, sizeof(buf)))
-return buf;
+return String::fromUTF8(buf);
#endif
-return "0.00";
+return "0.00"_s;
}
static constexpr const char* versionForUAString()
@@ -87,7 +87,7 @@
String finalApplicationVersion = applicationVersion;
if (finalApplicationVersion.isEmpty())
-finalApplicationVersion = versionForUAString();
+finalApplicationVersion = String::fromUTF8(versionForUAString());
return makeString(standardUserAgentStatic(), ' ', applicationName, '/', finalApplicationVersion);
}
Modified: trunk/Source/WebKit/ChangeLog (292439 => 292440)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 23:28:55 UTC (rev 292440)
@@ -1,3 +1,12 @@
+2022-04-05 Stephan Szabo
+
+[PlayStation[ Fix build break after r292408
+https://bugs.webkit.org/show_bug.cgi?id=238840
+
+Unreviewed build fix.
+
+* UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp:
+
2022-04-05 Alex Christensen
Revert r291598
Modified: trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp (292439 => 292440)
--- trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp 2022-04-05 23:28:55 UTC (rev 292440)
@@ -74,7 +74
[webkit-changes] [292583] trunk/Source/WebKit
Title: [292583] trunk/Source/WebKit Revision 292583 Author stephan.sz...@sony.com Date 2022-04-07 17:49:58 -0700 (Thu, 07 Apr 2022) Log Message Build-fix for not ENABLE(SERVICE_WORKER) after r292539 https://bugs.webkit.org/show_bug.cgi?id=238957 Unreviewed build fix. * UIProcess/WebPageProxy.cpp: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebPageProxy.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (292582 => 292583) --- trunk/Source/WebKit/ChangeLog 2022-04-08 00:47:15 UTC (rev 292582) +++ trunk/Source/WebKit/ChangeLog 2022-04-08 00:49:58 UTC (rev 292583) @@ -1,3 +1,12 @@ +2022-04-07 Stephan Szabo + +Build-fix for not ENABLE(SERVICE_WORKER) after r292539 +https://bugs.webkit.org/show_bug.cgi?id=238957 + +Unreviewed build fix. + +* UIProcess/WebPageProxy.cpp: + 2022-04-07 Simon Fraser Add a LayerBacking RenderingPurpose Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (292582 => 292583) --- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2022-04-08 00:47:15 UTC (rev 292582) +++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2022-04-08 00:49:58 UTC (rev 292583) @@ -4610,8 +4610,10 @@ m_mainFrame = WebFrameProxy::create(*this, frameID); +#if ENABLE(SERVICE_WORKER) if (m_serviceWorkerOpenWindowCompletionCallback) m_mainFrame->setNavigationCallback(WTFMove(m_serviceWorkerOpenWindowCompletionCallback)); +#endif // Add the frame to the process wide map. m_process->frameCreated(frameID, *m_mainFrame); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292590] trunk/Source/WebKit
Title: [292590] trunk/Source/WebKit
Revision 292590
Author stephan.sz...@sony.com
Date 2022-04-07 21:06:57 -0700 (Thu, 07 Apr 2022)
Log Message
[WinCairo] Fix DrawingAreaWC after r292557
https://bugs.webkit.org/show_bug.cgi?id=238979
Unreviewed build fix
* WebProcess/WebPage/wc/DrawingAreaWC.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (292589 => 292590)
--- trunk/Source/WebKit/ChangeLog 2022-04-08 03:46:56 UTC (rev 292589)
+++ trunk/Source/WebKit/ChangeLog 2022-04-08 04:06:57 UTC (rev 292590)
@@ -1,3 +1,12 @@
+2022-04-07 Stephan Szabo
+
+[WinCairo] Fix DrawingAreaWC after r292557
+https://bugs.webkit.org/show_bug.cgi?id=238979
+
+Unreviewed build fix
+
+* WebProcess/WebPage/wc/DrawingAreaWC.cpp:
+
2022-04-07 Simon Fraser
Fix the CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER build (again)
Modified: trunk/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp (292589 => 292590)
--- trunk/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp 2022-04-08 03:46:56 UTC (rev 292589)
+++ trunk/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp 2022-04-08 04:06:57 UTC (rev 292590)
@@ -365,8 +365,8 @@
RefPtr DrawingAreaWC::createImageBuffer(FloatSize size)
{
if (WebProcess::singleton().shouldUseRemoteRenderingFor(RenderingPurpose::DOM))
-return m_webPage.ensureRemoteRenderingBackendProxy().createImageBuffer(size, RenderingPurpose::DOM, RenderingMode::Unaccelerated, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8);
-return ConcreteImageBuffer::create(size, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8, nullptr);
+return m_webPage.ensureRemoteRenderingBackendProxy().createImageBuffer(size, RenderingMode::Unaccelerated, RenderingPurpose::DOM, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8);
+return ConcreteImageBuffer::create(size, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8, RenderingPurpose::DOM, nullptr);
}
void DrawingAreaWC::didUpdate()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289945] trunk/Source/WebKit
Title: [289945] trunk/Source/WebKit Revision 289945 Author stephan.sz...@sony.com Date 2022-02-16 12:26:05 -0800 (Wed, 16 Feb 2022) Log Message [PlayStation] Build fix after r289872 https://bugs.webkit.org/show_bug.cgi?id=236716 Unreviewed build fix Add Webcore/Frame.h to include set * WebProcess/Geolocation/WebGeolocationManager.cpp: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (289944 => 289945) --- trunk/Source/WebKit/ChangeLog 2022-02-16 20:23:41 UTC (rev 289944) +++ trunk/Source/WebKit/ChangeLog 2022-02-16 20:26:05 UTC (rev 289945) @@ -1,3 +1,14 @@ +2022-02-16 Stephan Szabo + +[PlayStation] Build fix after r289872 +https://bugs.webkit.org/show_bug.cgi?id=236716 + +Unreviewed build fix + +Add Webcore/Frame.h to include set + +* WebProcess/Geolocation/WebGeolocationManager.cpp: + 2022-02-16 Per Arne Vollan [macOS] Add access to mach service in the Networking process for all users Modified: trunk/Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.cpp (289944 => 289945) --- trunk/Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.cpp 2022-02-16 20:23:41 UTC (rev 289944) +++ trunk/Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.cpp 2022-02-16 20:26:05 UTC (rev 289945) @@ -30,6 +30,7 @@ #include "WebGeolocationManagerProxyMessages.h" #include "WebPage.h" #include "WebProcess.h" +#include #include #include #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75bf0d: Build fix for not ENABLE(SERVICE_WORKER) after 260...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75bf0d7a24781ac0e1cc5ef4d23952b3af784945 https://github.com/WebKit/WebKit/commit/75bf0d7a24781ac0e1cc5ef4d23952b3af784945 Author: Stephan Szabo Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M Source/WebKit/NetworkProcess/BackgroundFetchLoad.cpp M Source/WebKit/NetworkProcess/BackgroundFetchLoad.h Log Message: --- Build fix for not ENABLE(SERVICE_WORKER) after 260928@main https://bugs.webkit.org/show_bug.cgi?id=253097 Unreviewed build fix Add ENABLE(SERVICE_WORKER) guards around BackgroundFetchLoad since it depends on BackgroundFetchRecordLoader which is guarded such. Canonical link: https://commits.webkit.org/260963@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0cc968: Build fixes for !ENABLE(SERVICE_WORKER) after 2609...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0cc96819dbaf270ff4d6ac9db974159d46bc6c06 https://github.com/WebKit/WebKit/commit/0cc96819dbaf270ff4d6ac9db974159d46bc6c06 Author: Stephan Szabo Date: 2023-03-02 (Thu, 02 Mar 2023) Changed paths: M Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp M Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in Log Message: --- Build fixes for !ENABLE(SERVICE_WORKER) after 260990@main https://bugs.webkit.org/show_bug.cgi?id=253187 Reviewed by Alex Christensen. Add ENABLE(SERVICE_WORKER) guards to code in OriginStorageManager that is using StorageType::BackgroundFetchStorage. We saw errors where the generated serializers appeared to be effectively missing the trailing semi-colon on the allValidBitsValue calculation in isValidOptionSet due to the last item being in a preprocessor if. Add a check for the case where the last item is in such an if and add an else that provides the semi-colon. * Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp: (WebKit::OriginStorageManager::StorageBucket::toStorageIdentifier const): (WebKit::OriginStorageManager::StorageBucket::resolvedPath): * Source/WebKit/Scripts/generate-serializers.py: (generate_impl): * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp: * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h: * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: * Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in: Canonical link: https://commits.webkit.org/261094@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 28f733: [PlayStation] Build fix for non-experimental featu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 28f733a50d4fb00641cd2386501a99d9cf9e5ce6 https://github.com/WebKit/WebKit/commit/28f733a50d4fb00641cd2386501a99d9cf9e5ce6 Author: Stephan Szabo Date: 2023-03-03 (Fri, 03 Mar 2023) Changed paths: M Source/WebKit/NetworkProcess/EarlyHintsResourceLoader.h Log Message: --- [PlayStation] Build fix for non-experimental features build after 261079@main https://bugs.webkit.org/show_bug.cgi?id=253282 Unreviewed build fix Add WebCore:: namespace to ResourceRequest parameter as this seems to be necessary for us when we're not building experimental features. Return value for the function already used the namespace. * Source/WebKit/NetworkProcess/EarlyHintsResourceLoader.h: Canonical link: https://commits.webkit.org/261150@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 22729d: [PlayStation] Remove Warnings
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 22729d7ebb8b747e5dda9abe92d5a6d11676b2d9 https://github.com/WebKit/WebKit/commit/22729d7ebb8b747e5dda9abe92d5a6d11676b2d9 Author: Stephan Szabo Date: 2023-03-22 (Wed, 22 Mar 2023) Changed paths: M Source/WebCore/loader/cache/CachedResourceLoader.cpp M Source/WebCore/platform/network/curl/SynchronousLoaderClientCurl.cpp Log Message: --- [PlayStation] Remove Warnings https://bugs.webkit.org/show_bug.cgi?id=254243 Reviewed by Fujii Hironori. For CachedResourceLoader, it appears the users of the resourceRequest variable are inside the CONTENT_EXTENSIONS enable. For the SynchronousLoaderClientCurl, the body of the method was removed as part of a cleanup but the parameters are still named and no longer used (and the names don't provide a lot of information) * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestResource): * Source/WebCore/platform/network/curl/SynchronousLoaderClientCurl.cpp: (WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge): Canonical link: https://commits.webkit.org/261952@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b70307: [Windows] Fix loading modules from JSC shell
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b7030754b74c7c062b2d1a176c05900bbf7ecaa5 https://github.com/WebKit/WebKit/commit/b7030754b74c7c062b2d1a176c05900bbf7ecaa5 Author: Stephan Szabo Date: 2023-03-28 (Tue, 28 Mar 2023) Changed paths: M Source/JavaScriptCore/jsc.cpp Log Message: --- [Windows] Fix loading modules from JSC shell https://bugs.webkit.org/show_bug.cgi?id=254606 Reviewed by Ross Kirsling. We try to use a \\?\ path for loading modules in the shell, but this doesn't seem to work with forward slash directory separators. \\?\D:\foo\bar can work but \\?\D:/foo/bar appears to not do so. The docs imply that using the prefix prevents any of the normal string manipulation that would go on. * Source/JavaScriptCore/jsc.cpp: (fetchModuleFromLocalFileSystem): Canonical link: https://commits.webkit.org/262257@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f7167b: [PlayStation][CFI] Remove unnecessary cast in Fram...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f7167b05ac1aaf64265665ca9f5a6bf9371ef8a2 https://github.com/WebKit/WebKit/commit/f7167b05ac1aaf64265665ca9f5a6bf9371ef8a2 Author: Stephan Szabo Date: 2023-04-12 (Wed, 12 Apr 2023) Changed paths: M Source/WebCore/page/FrameTree.cpp Log Message: --- [PlayStation][CFI] Remove unnecessary cast in FrameTree.cpp https://bugs.webkit.org/show_bug.cgi?id=255348 Reviewed by Chris Dumez. The FrameTree constructor was doing an unnecessary cast to LocalFrame on one of its parameters that made CFI checks on PlayStation unhappy due to timing of construction. * Source/WebCore/page/FrameTree.cpp: (WebCore::FrameTree::FrameTree): Canonical link: https://commits.webkit.org/262878@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b7306: [CMake][Ninja] Allow configuration of link/compile...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b7306b44d5b914fc5ad27f4fc5766345798811f https://github.com/WebKit/WebKit/commit/3b7306b44d5b914fc5ad27f4fc5766345798811f Author: Stephan Szabo Date: 2022-12-13 (Tue, 13 Dec 2022) Changed paths: M Source/cmake/WebKitCommon.cmake Log Message: --- [CMake][Ninja] Allow configuration of link/compile pool sizes https://bugs.webkit.org/show_bug.cgi?id=249221 Reviewed by NOBODY (OOPS\!). * Source/cmake/WebKitCommon.cmake: Check environment for new variables to set the default link pool size (otherwise configure as before), also check for compile pool size and if present set up a pool for compile tasks. Canonical link: https://commits.webkit.org/257800@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [265564] trunk/Source/WebCore
Title: [265564] trunk/Source/WebCore
Revision 265564
Author stephan.sz...@sony.com
Date 2020-08-12 14:31:45 -0700 (Wed, 12 Aug 2020)
Log Message
[PlayStation] Build fix for !ENABLE(ACCESSIBILITY) after r265514
https://bugs.webkit.org/show_bug.cgi?id=215426
AXObjectCache::getOrCreate(AccessibilityRole) changed names
in the above, but the short definition for
!ENABLE(ACCESSIBILITY) didn't update.
Unreviewed build fix.
* accessibility/AXObjectCache.h: Update name to match new name
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (265563 => 265564)
--- trunk/Source/WebCore/ChangeLog 2020-08-12 21:11:20 UTC (rev 265563)
+++ trunk/Source/WebCore/ChangeLog 2020-08-12 21:31:45 UTC (rev 265564)
@@ -1,3 +1,16 @@
+2020-08-12 Stephan Szabo
+
+[PlayStation] Build fix for !ENABLE(ACCESSIBILITY) after r265514
+https://bugs.webkit.org/show_bug.cgi?id=215426
+
+AXObjectCache::getOrCreate(AccessibilityRole) changed names
+in the above, but the short definition for
+!ENABLE(ACCESSIBILITY) didn't update.
+
+Unreviewed build fix.
+
+* accessibility/AXObjectCache.h: Update name to match new name
+
2020-08-12 Peng Liu
Add the support to return to element fullscreen from picture-in-picture
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (265563 => 265564)
--- trunk/Source/WebCore/accessibility/AXObjectCache.h 2020-08-12 21:11:20 UTC (rev 265563)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h 2020-08-12 21:31:45 UTC (rev 265564)
@@ -546,7 +546,7 @@
inline AccessibilityObject* AXObjectCache::get(Node*) { return nullptr; }
inline AccessibilityObject* AXObjectCache::get(Widget*) { return nullptr; }
inline AccessibilityObject* AXObjectCache::getOrCreate(RenderObject*) { return nullptr; }
-inline AccessibilityObject* AXObjectCache::getOrCreate(AccessibilityRole) { return nullptr; }
+inline AccessibilityObject* AXObjectCache::create(AccessibilityRole) { return nullptr; }
inline AccessibilityObject* AXObjectCache::getOrCreate(Node*) { return nullptr; }
inline AccessibilityObject* AXObjectCache::getOrCreate(Widget*) { return nullptr; }
inline AXCoreObject* AXObjectCache::rootObject() { return nullptr; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266249] trunk
Title: [266249] trunk
Revision 266249
Author stephan.sz...@sony.com
Date 2020-08-27 12:52:20 -0700 (Thu, 27 Aug 2020)
Log Message
[PlayStation] Build fix due to memmem not always being available.
https://bugs.webkit.org/show_bug.cgi?id=215893
Unreviewed build fix
.:
* Source/cmake/OptionsPlayStation.cmake: Check for memmem
Source/WTF:
* wtf/PlatformHave.h: Don't always HAVE_MEMMEM on playstation
Modified Paths
trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/cmake/OptionsPlayStation.cmake
Diff
Modified: trunk/ChangeLog (266248 => 266249)
--- trunk/ChangeLog 2020-08-27 18:56:38 UTC (rev 266248)
+++ trunk/ChangeLog 2020-08-27 19:52:20 UTC (rev 266249)
@@ -1,3 +1,12 @@
+2020-08-27 Stephan Szabo
+
+[PlayStation] Build fix due to memmem not always being available.
+https://bugs.webkit.org/show_bug.cgi?id=215893
+
+Unreviewed build fix
+
+* Source/cmake/OptionsPlayStation.cmake: Check for memmem
+
2020-08-22 Philippe Normand
[GTK][WPE] Compilation warnings with clang/gcc 10
Modified: trunk/Source/WTF/ChangeLog (266248 => 266249)
--- trunk/Source/WTF/ChangeLog 2020-08-27 18:56:38 UTC (rev 266248)
+++ trunk/Source/WTF/ChangeLog 2020-08-27 19:52:20 UTC (rev 266249)
@@ -1,3 +1,12 @@
+2020-08-27 Stephan Szabo
+
+[PlayStation] Build fix due to memmem not always being available.
+https://bugs.webkit.org/show_bug.cgi?id=215893
+
+Unreviewed build fix
+
+* wtf/PlatformHave.h: Don't always HAVE_MEMMEM on playstation
+
2020-08-27 Carlos Garcia Campos
[GTK] Include the run loop source name in frame rendering timeline
Modified: trunk/Source/WTF/wtf/PlatformHave.h (266248 => 266249)
--- trunk/Source/WTF/wtf/PlatformHave.h 2020-08-27 18:56:38 UTC (rev 266248)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2020-08-27 19:52:20 UTC (rev 266249)
@@ -308,6 +308,9 @@
#if !OS(WINDOWS)
#define HAVE_STACK_BOUNDS_FOR_NEW_THREAD 1
+#endif
+
+#if !OS(WINDOWS) && !PLATFORM(PLAYSTATION)
#define HAVE_MEMMEM 1
#endif
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (266248 => 266249)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2020-08-27 18:56:38 UTC (rev 266248)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2020-08-27 19:52:20 UTC (rev 266249)
@@ -1,5 +1,7 @@
set(PORT PlayStation)
+include(CheckSymbolExists)
+
string(APPEND CMAKE_C_FLAGS_RELEASE " -g")
string(APPEND CMAKE_CXX_FLAGS_RELEASE " -g")
set(CMAKE_CONFIGURATION_TYPES "Debug" "Release")
@@ -285,3 +287,8 @@
endforeach ()
add_custom_target(${target_name} ALL DEPENDS ${dst_shared_libs})
endfunction()
+
+check_symbol_exists(memmem string.h HAVE_MEMMEM)
+if (HAVE_MEMMEM)
+add_definitions(-DHAVE_MEMMEM=1)
+endif ()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266357] trunk
Title: [266357] trunk
Revision 266357
Author stephan.sz...@sony.com
Date 2020-08-31 09:56:44 -0700 (Mon, 31 Aug 2020)
Log Message
[PlayStation] Build fix for intermittent copy errors
https://bugs.webkit.org/show_bug.cgi?id=215951
Reviewed by Ross Kirsling.
* Source/cmake/OptionsPlayStation.cmake:
When copying platform specific files into the binary
directory post build on executable targets, we'd
intermittently get copy errors in parallel builds.
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsPlayStation.cmake
Diff
Modified: trunk/ChangeLog (266356 => 266357)
--- trunk/ChangeLog 2020-08-31 16:47:16 UTC (rev 266356)
+++ trunk/ChangeLog 2020-08-31 16:56:44 UTC (rev 266357)
@@ -1,3 +1,15 @@
+2020-08-31 Stephan Szabo
+
+[PlayStation] Build fix for intermittent copy errors
+https://bugs.webkit.org/show_bug.cgi?id=215951
+
+Reviewed by Ross Kirsling.
+
+* Source/cmake/OptionsPlayStation.cmake:
+When copying platform specific files into the binary
+directory post build on executable targets, we'd
+intermittently get copy errors in parallel builds.
+
2020-08-28 Adrian Perez de Castro
[WPE] Enable Notifications support
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (266356 => 266357)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2020-08-31 16:47:16 UTC (rev 266356)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2020-08-31 16:56:44 UTC (rev 266357)
@@ -222,6 +222,12 @@
endif ()
endfunction()
+add_custom_target(playstation_tools_copy
+COMMAND ${CMAKE_COMMAND} -E copy_directory
+${WEBKIT_LIBRARIES_DIR}/tools/sce_sys/
+${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/sce_sys/
+)
+
macro(WEBKIT_EXECUTABLE _target)
_WEBKIT_EXECUTABLE(${_target})
playstation_setup_libc(${_target})
@@ -234,12 +240,7 @@
target_link_options(${_target} PRIVATE -Wl,--wrap=${WRAP})
endforeach ()
endif ()
-add_custom_command(TARGET ${_target}
-POST_BUILD
-COMMAND ${CMAKE_COMMAND} -E copy_directory
-${WEBKIT_LIBRARIES_DIR}/tools/sce_sys/
-$/sce_sys/
-)
+add_dependencies(${_target} playstation_tools_copy)
endmacro()
function(PLAYSTATION_COPY_SHARED_LIBRARIES target_name)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283745] trunk/Tools
Title: [283745] trunk/Tools
Revision 283745
Author stephan.sz...@sony.com
Date 2021-10-07 14:29:40 -0700 (Thu, 07 Oct 2021)
Log Message
[WinCairo] Support run-jsc-stress-tests without posix commands
https://bugs.webkit.org/show_bug.cgi?id=231101
Reviewed by Adrian Perez de Castro.
Add support for collecting the test result files when not on
a posix host platform by roughly emulating the find command
current used in ruby code when using the ruby-runner or
for playstation.
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (283744 => 283745)
--- trunk/Tools/ChangeLog 2021-10-07 21:25:07 UTC (rev 283744)
+++ trunk/Tools/ChangeLog 2021-10-07 21:29:40 UTC (rev 283745)
@@ -1,3 +1,17 @@
+2021-10-07 Stephan Szabo
+
+[WinCairo] Support run-jsc-stress-tests without posix commands
+https://bugs.webkit.org/show_bug.cgi?id=231101
+
+Reviewed by Adrian Perez de Castro.
+
+Add support for collecting the test result files when not on
+a posix host platform by roughly emulating the find command
+current used in ruby code when using the ruby-runner or
+for playstation.
+
+* Scripts/run-jsc-stress-tests:
+
2021-10-07 Jonathan Bedard
[WebKitBot] Land local changes on production host
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (283744 => 283745)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2021-10-07 21:25:07 UTC (rev 283744)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2021-10-07 21:29:40 UTC (rev 283745)
@@ -2349,10 +2349,12 @@
}
else
Dir.chdir($runnerDir) {
-IO.popen(find_cmd).each_line {
-| line |
-processStatusLine(map, line)
-}
+Dir.glob("#{STATUS_FILE_PREFIX}*").each do |name|
+if File.size(name) > 0
+line = File.open(name).first
+processStatusLine(map, "./#{name} #{line}")
+end
+end
}
end
map
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283844] trunk/Source/JavaScriptCore
Title: [283844] trunk/Source/_javascript_Core
Revision 283844
Author stephan.sz...@sony.com
Date 2021-10-08 15:35:14 -0700 (Fri, 08 Oct 2021)
Log Message
[JSC] Add private C API for JSGlobalObject::setEvalEnabled
https://bugs.webkit.org/show_bug.cgi?id=231448
Reviewed by Yusuke Suzuki.
WebCore can prohibit eval (and Function constructor) usage in JS execution based on content security policy;
this patch gives embedders the ability to do similarly.
* API/JSContextRef.cpp:
(JSGlobalContextSetEvalEnabled): Added.
* API/JSContextRefPrivate.h:
* API/tests/testapi.c:
Modified Paths
trunk/Source/_javascript_Core/API/JSContextRef.cpp
trunk/Source/_javascript_Core/API/JSContextRefPrivate.h
trunk/Source/_javascript_Core/API/tests/testapi.c
trunk/Source/_javascript_Core/ChangeLog
Diff
Modified: trunk/Source/_javascript_Core/API/JSContextRef.cpp (283843 => 283844)
--- trunk/Source/_javascript_Core/API/JSContextRef.cpp 2021-10-08 22:21:19 UTC (rev 283843)
+++ trunk/Source/_javascript_Core/API/JSContextRef.cpp 2021-10-08 22:35:14 UTC (rev 283844)
@@ -268,6 +268,20 @@
globalObject->setUnhandledRejectionCallback(vm, object);
}
+void JSGlobalContextSetEvalEnabled(JSGlobalContextRef ctx, bool enabled, JSStringRef message)
+{
+if (!ctx) {
+ASSERT_NOT_REACHED();
+return;
+}
+
+JSGlobalObject* globalObject = toJS(ctx);
+VM& vm = globalObject->vm();
+JSLockHolder locker(vm);
+
+globalObject->setEvalEnabled(enabled, message ? message->string() : String());
+}
+
class BacktraceFunctor {
public:
BacktraceFunctor(StringBuilder& builder, unsigned remainingCapacityForFrameCapture)
Modified: trunk/Source/_javascript_Core/API/JSContextRefPrivate.h (283843 => 283844)
--- trunk/Source/_javascript_Core/API/JSContextRefPrivate.h 2021-10-08 22:21:19 UTC (rev 283843)
+++ trunk/Source/_javascript_Core/API/JSContextRefPrivate.h 2021-10-08 22:35:14 UTC (rev 283844)
@@ -138,6 +138,15 @@
*/
JS_EXPORT void JSGlobalContextSetUnhandledRejectionCallback(JSGlobalContextRef ctx, JSObjectRef function, JSValueRef* exception) JSC_API_AVAILABLE(macos(10.15.4), ios(13.4));
+/*!
+@function
+@abstract Sets whether a context allows use of eval (or the Function constructor).
+@param ctx The JSGlobalContext that you want to change.
+@param enabled The new eval enabled setting for the context.
+@param message The error message to display when user attempts to call eval (or the Function constructor). Pass NULL when setting enabled to true.
+*/
+JS_EXPORT void JSGlobalContextSetEvalEnabled(JSGlobalContextRef ctx, bool enabled, JSStringRef message) JSC_API_AVAILABLE(macos(JSC_MAC_TBA), ios(JSC_IOS_TBA));
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/_javascript_Core/API/tests/testapi.c (283843 => 283844)
--- trunk/Source/_javascript_Core/API/tests/testapi.c 2021-10-08 22:21:19 UTC (rev 283843)
+++ trunk/Source/_javascript_Core/API/tests/testapi.c 2021-10-08 22:35:14 UTC (rev 283844)
@@ -33,6 +33,7 @@
#endif
#include "JSBasePrivate.h"
+#include "JSContextRefPrivate.h"
#include "JSHeapFinalizerPrivate.h"
#include "JSMarkingConstraintPrivate.h"
#include "JSObjectRefPrivate.h"
@@ -1992,6 +1993,19 @@
JSStringRelease(sourceURL);
JSStringRelease(sourceURLKey);
+JSGlobalContextSetEvalEnabled(context, false, jsOneIString);
+exception = NULL;
+script = JSStringCreateWithUTF8CString("eval(\"3\");");
+JSEvaluateScript(context, script, NULL, NULL, 1, &exception);
+ASSERT(exception);
+JSStringRelease(script);
+exception = NULL;
+script = JSStringCreateWithUTF8CString("Function(\"return 3;\");");
+JSEvaluateScript(context, script, NULL, NULL, 1, &exception);
+ASSERT(exception);
+JSStringRelease(script);
+JSGlobalContextSetEvalEnabled(context, true, NULL);
+
// Verify that creating a constructor for a class with no static functions does not trigger
// an assert inside putDirect or lead to a crash during GC.
nullDefinition = kJSClassDefinitionEmpty;
Modified: trunk/Source/_javascript_Core/ChangeLog (283843 => 283844)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-08 22:21:19 UTC (rev 283843)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-08 22:35:14 UTC (rev 283844)
@@ -1,3 +1,18 @@
+2021-10-08 Ross Kirsling and Stephan Szabo
+
+[JSC] Add private C API for JSGlobalObject::setEvalEnabled
+https://bugs.webkit.org/show_bug.cgi?id=231448
+
+Reviewed by Yusuke Suzuki.
+
+WebCore can prohibit eval (and Function constructor) usage in JS execution based on content security policy;
+this patch gives embedders the ability to do similarly.
+
+* API/JSContextRef.cpp:
+(JSGlobalContextSetEvalEnabled): Added.
+* API/JSContextRefPrivate.h:
+* API/tests/testapi.c:
+
2021-10-08 Yusuke Suzuki
[webkit-changes] [285061] trunk/Tools
Title: [285061] trunk/Tools
Revision 285061
Author stephan.sz...@sony.com
Date 2021-10-29 16:29:51 -0700 (Fri, 29 Oct 2021)
Log Message
[PlayStation] Build fix after r285020
https://bugs.webkit.org/show_bug.cgi?id=232494
Unreviewed temporary Build Fix
Remove test that requires unsupported WTF::FileSystem functions.
* TestWebKitAPI/PlatformPlayStation.cmake:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake
Diff
Modified: trunk/Tools/ChangeLog (285060 => 285061)
--- trunk/Tools/ChangeLog 2021-10-29 23:24:41 UTC (rev 285060)
+++ trunk/Tools/ChangeLog 2021-10-29 23:29:51 UTC (rev 285061)
@@ -1,3 +1,14 @@
+2021-10-29 Stephan Szabo
+
+[PlayStation] Build fix after r285020
+https://bugs.webkit.org/show_bug.cgi?id=232494
+
+Unreviewed temporary Build Fix
+
+Remove test that requires unsupported WTF::FileSystem functions.
+
+* TestWebKitAPI/PlatformPlayStation.cmake:
+
2021-10-29 Alex Christensen
Revert r285034
Modified: trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake (285060 => 285061)
--- trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake 2021-10-29 23:24:41 UTC (rev 285060)
+++ trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake 2021-10-29 23:29:51 UTC (rev 285061)
@@ -29,8 +29,6 @@
list(APPEND TestWebKit_SOURCES
${test_main_SOURCES}
-Tests/WebKit/CookieStorageFile.cpp
-
Tests/WebKit/curl/Certificates.cpp
generic/UtilitiesGeneric.cpp
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285522] trunk/Tools
Title: [285522] trunk/Tools
Revision 285522
Author stephan.sz...@sony.com
Date 2021-11-09 12:25:57 -0800 (Tue, 09 Nov 2021)
Log Message
[Windows] Non-find based status file finding in run-jsc-stress-tests needs to release status files
https://bugs.webkit.org/show_bug.cgi?id=232851
Reviewed by Don Olmstead.
Change the reading of status files in the non-find search
to properly scope the file access to release the status
files.
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (285521 => 285522)
--- trunk/Tools/ChangeLog 2021-11-09 20:04:19 UTC (rev 285521)
+++ trunk/Tools/ChangeLog 2021-11-09 20:25:57 UTC (rev 285522)
@@ -1,3 +1,16 @@
+2021-11-09 Stephan Szabo
+
+[Windows] Non-find based status file finding in run-jsc-stress-tests needs to release status files
+https://bugs.webkit.org/show_bug.cgi?id=232851
+
+Reviewed by Don Olmstead.
+
+Change the reading of status files in the non-find search
+to properly scope the file access to release the status
+files.
+
+* Scripts/run-jsc-stress-tests:
+
2021-11-09 Chris Dumez
New spec: Block external protocol handler in sandboxed frames
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (285521 => 285522)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2021-11-09 20:04:19 UTC (rev 285521)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2021-11-09 20:25:57 UTC (rev 285522)
@@ -2367,8 +2367,10 @@
Dir.chdir($runnerDir) {
Dir.glob("#{STATUS_FILE_PREFIX}*").each do |name|
if File.size(name) > 0
-line = File.open(name).first
-processStatusLine(map, "./#{name} #{line}")
+File.open(name, 'r') { |f|
+line = f.first
+processStatusLine(map, "./#{name} #{line}")
+}
end
end
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281730] trunk
Title: [281730] trunk
Revision 281730
Author stephan.sz...@sony.com
Date 2021-08-27 19:09:00 -0700 (Fri, 27 Aug 2021)
Log Message
[PlayStation][CMake] Add control over whether _javascript_Core should be shared
https://bugs.webkit.org/show_bug.cgi?id=229591
.:
Add option for controlling whether to build a shared _javascript_Core and
set build type for that appropriately.
Reviewed by Don Olmstead.
* Source/cmake/OptionsPlayStation.cmake:
Source/_javascript_Core:
Reviewed by Don Olmstead.
Make LowLevelInterpreterLib objects get added via _PRIVATE_LIBRARIES when
using _javascript_Core as an object library in order to propogate them
correctly.
* CMakeLists.txt:
Tools:
Reviewed by Don Olmstead.
Add frameworks to test applications to build with an object library version
of _javascript_Core.
* TestWebKitAPI/CMakeLists.txt:
Modified Paths
trunk/ChangeLog
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/cmake/OptionsPlayStation.cmake
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/CMakeLists.txt
Diff
Modified: trunk/ChangeLog (281729 => 281730)
--- trunk/ChangeLog 2021-08-28 00:57:09 UTC (rev 281729)
+++ trunk/ChangeLog 2021-08-28 02:09:00 UTC (rev 281730)
@@ -1,3 +1,15 @@
+2021-08-27 Stephan Szabo
+
+[PlayStation][CMake] Add control over whether _javascript_Core should be shared
+https://bugs.webkit.org/show_bug.cgi?id=229591
+
+Add option for controlling whether to build a shared _javascript_Core and
+set build type for that appropriately.
+
+Reviewed by Don Olmstead.
+
+* Source/cmake/OptionsPlayStation.cmake:
+
2021-08-27 Russell Epstein
Land Windows build fixes from safari-612.1.29.14-branch.
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (281729 => 281730)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2021-08-28 00:57:09 UTC (rev 281729)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2021-08-28 02:09:00 UTC (rev 281730)
@@ -1454,7 +1454,13 @@
COMPILE_DEFINITIONS "POSTPROCESS_ASM=llint/LowLevelInterpreter.cpp")
endif ()
-list(APPEND _javascript_Core_SOURCES $)
+# When building _javascript_Core as an object library, we need to make sure the
+# lowlevelinterpreter lib objects get propogated.
+if (${_javascript_Core_LIBRARY_TYPE} STREQUAL "OBJECT")
+list(APPEND _javascript_Core_PRIVATE_LIBRARIES $)
+else ()
+list(APPEND _javascript_Core_SOURCES $)
+endif ()
WEBKIT_COMPUTE_SOURCES(_javascript_Core)
WEBKIT_FRAMEWORK(_javascript_Core)
Modified: trunk/Source/_javascript_Core/ChangeLog (281729 => 281730)
--- trunk/Source/_javascript_Core/ChangeLog 2021-08-28 00:57:09 UTC (rev 281729)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-08-28 02:09:00 UTC (rev 281730)
@@ -1,3 +1,16 @@
+2021-08-27 Stephan Szabo
+
+[PlayStation][CMake] Add control over whether _javascript_Core should be shared
+https://bugs.webkit.org/show_bug.cgi?id=229591
+
+Reviewed by Don Olmstead.
+
+Make LowLevelInterpreterLib objects get added via _PRIVATE_LIBRARIES when
+using _javascript_Core as an object library in order to propogate them
+correctly.
+
+* CMakeLists.txt:
+
2021-08-27 Russell Epstein
Land Windows build fixes from safari-612.1.29.14-branch.
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (281729 => 281730)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2021-08-28 00:57:09 UTC (rev 281729)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2021-08-28 02:09:00 UTC (rev 281730)
@@ -28,6 +28,9 @@
WEBKIT_OPTION_BEGIN()
+# PlayStation Specific Options
+WEBKIT_OPTION_DEFINE(ENABLE_STATIC_JSC "Control whether to build a non-shared JSC" PUBLIC ON)
+
# Turn off JIT
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_JIT PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PRIVATE OFF)
@@ -174,8 +177,13 @@
# not be exposed.
set(bmalloc_LIBRARY_TYPE OBJECT)
set(WTF_LIBRARY_TYPE OBJECT)
-set(_javascript_Core_LIBRARY_TYPE SHARED)
+if (ENABLE_STATIC_JSC)
+set(_javascript_Core_LIBRARY_TYPE OBJECT)
+else ()
+set(_javascript_Core_LIBRARY_TYPE SHARED)
+endif ()
+
# Create a shared WebKit
#
# Use OBJECT libraries for PAL and WebCore. The size of a libWebCore.a is too much
Modified: trunk/Tools/ChangeLog (281729 => 281730)
--- trunk/Tools/ChangeLog 2021-08-28 00:57:09 UTC (rev 281729)
+++ trunk/Tools/ChangeLog 2021-08-28 02:09:00 UTC (rev 281730)
@@ -1,3 +1,15 @@
+2021-08-27 Stephan Szabo
+
+[PlayStation][CMake] Add control over whether _javascript_Core should be shared
+https://bugs.webkit.org/show_bug.cgi?id=229591
+
+Reviewed by Don Olmstead.
+
+Add frameworks to test applications to build with an object library version
+of _javascript_Core.
+
+* TestWebKitAPI/CMakeLists.txt:
+
2021-08-27 Ryan Haddad
[EWS] Do not notify Apple bot watchers about failure
[webkit-changes] [281998] trunk/Source/WebKit
Title: [281998] trunk/Source/WebKit
Revision 281998
Author stephan.sz...@sony.com
Date 2021-09-03 09:14:31 -0700 (Fri, 03 Sep 2021)
Log Message
Fix for debug mode with ENABLE_SERVICE_WORKER=OFF after r281706
https://bugs.webkit.org/show_bug.cgi?id=229845
Reviewed by Alex Christensen.
Put m_serviceWorkerFetchTask check into #if.
No new tests, is a build fix for having service workers off.
* NetworkProcess/NetworkResourceLoader.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (281997 => 281998)
--- trunk/Source/WebKit/ChangeLog 2021-09-03 16:10:11 UTC (rev 281997)
+++ trunk/Source/WebKit/ChangeLog 2021-09-03 16:14:31 UTC (rev 281998)
@@ -1,3 +1,16 @@
+2021-09-03 Stephan Szabo
+
+Fix for debug mode with ENABLE_SERVICE_WORKER=OFF after r281706
+https://bugs.webkit.org/show_bug.cgi?id=229845
+
+Reviewed by Alex Christensen.
+
+Put m_serviceWorkerFetchTask check into #if.
+
+No new tests, is a build fix for having service workers off.
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+
2021-09-03 Wenson Hsieh
[iOS 15] editing/caret/ios/caret-in-overflow-area.html is failing
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (281997 => 281998)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2021-09-03 16:10:11 UTC (rev 281997)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2021-09-03 16:14:31 UTC (rev 281998)
@@ -527,7 +527,11 @@
m_connection = newConnection;
m_parameters.identifier = newCoreIdentifier;
-ASSERT(m_responseCompletionHandler || m_cacheEntryWaitingForContinueDidReceiveResponse || m_serviceWorkerFetchTask);
+ASSERT(m_responseCompletionHandler || m_cacheEntryWaitingForContinueDidReceiveResponse
+#if ENABLE(SERVICE_WORKER)
+|| m_serviceWorkerFetchTask
+#endif
+);
bool willWaitForContinueDidReceiveResponse = true;
send(Messages::WebResourceLoader::DidReceiveResponse { m_response, willWaitForContinueDidReceiveResponse });
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [282036] trunk/Source/WebKit
Title: [282036] trunk/Source/WebKit
Revision 282036
Author stephan.sz...@sony.com
Date 2021-09-03 16:40:42 -0700 (Fri, 03 Sep 2021)
Log Message
Fix for debug mode on MSVC after r281998
https://bugs.webkit.org/show_bug.cgi?id=229894
Unreviewed build fix for wincairo debug.
No new tests, build fix only.
Pull the #if out from inside the ASSERT.
* NetworkProcess/NetworkResourceLoader.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (282035 => 282036)
--- trunk/Source/WebKit/ChangeLog 2021-09-03 23:19:49 UTC (rev 282035)
+++ trunk/Source/WebKit/ChangeLog 2021-09-03 23:40:42 UTC (rev 282036)
@@ -1,3 +1,16 @@
+2021-09-03 Stephan Szabo
+
+Fix for debug mode on MSVC after r281998
+https://bugs.webkit.org/show_bug.cgi?id=229894
+
+Unreviewed build fix for wincairo debug.
+
+No new tests, build fix only.
+
+Pull the #if out from inside the ASSERT.
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+
2021-09-03 Kate Cheney
Safari’s Privacy Report window is completely blank
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (282035 => 282036)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2021-09-03 23:19:49 UTC (rev 282035)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2021-09-03 23:40:42 UTC (rev 282036)
@@ -528,11 +528,11 @@
m_connection = newConnection;
m_parameters.identifier = newCoreIdentifier;
-ASSERT(m_responseCompletionHandler || m_cacheEntryWaitingForContinueDidReceiveResponse
#if ENABLE(SERVICE_WORKER)
-|| m_serviceWorkerFetchTask
+ASSERT(m_responseCompletionHandler || m_cacheEntryWaitingForContinueDidReceiveResponse || m_serviceWorkerFetchTask);
+#else
+ASSERT(m_responseCompletionHandler || m_cacheEntryWaitingForContinueDidReceiveResponse);
#endif
-);
bool willWaitForContinueDidReceiveResponse = true;
send(Messages::WebResourceLoader::DidReceiveResponse { m_response, willWaitForContinueDidReceiveResponse });
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [282295] trunk
Title: [282295] trunk
Revision 282295
Author stephan.sz...@sony.com
Date 2021-09-10 15:32:43 -0700 (Fri, 10 Sep 2021)
Log Message
[PlayStation] Support running applications with ENABLE_STATIC_JSC=ON
https://bugs.webkit.org/show_bug.cgi?id=230170
Reviewed by Ross Kirsling.
Updating loading code to not load libJavaScriptCore shared library
Source/_javascript_Core:
if we are using a static version.
* shell/playstation/Initializer.cpp:
Source/WebKit:
if we are using a static version.
* NetworkProcess/EntryPoint/playstation/NetworkProcessMain.cpp:
* WebProcess/EntryPoint/playstation/WebProcessMain.cpp:
Tools:
if we are using a static version. Fix platform bits for
TestJavaScriptCore to load libraries at all.
* MiniBrowser/playstation/main.cpp:
* TestWebKitAPI/PlatformPlayStation.cmake:
* TestWebKitAPI/playstation/main.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/playstation/Initializer.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/EntryPoint/playstation/NetworkProcessMain.cpp
trunk/Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/playstation/main.cpp
trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake
trunk/Tools/TestWebKitAPI/playstation/main.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (282294 => 282295)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-10 22:16:06 UTC (rev 282294)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-10 22:32:43 UTC (rev 282295)
@@ -1,3 +1,15 @@
+2021-09-10 Stephan Szabo
+
+[PlayStation] Support running applications with ENABLE_STATIC_JSC=ON
+https://bugs.webkit.org/show_bug.cgi?id=230170
+
+Reviewed by Ross Kirsling.
+
+Updating loading code to not load libJavaScriptCore shared library
+if we are using a static version.
+
+* shell/playstation/Initializer.cpp:
+
2021-09-09 Ross Kirsling
[JSC] Clean up current state of Temporal API
Modified: trunk/Source/_javascript_Core/shell/playstation/Initializer.cpp (282294 => 282295)
--- trunk/Source/_javascript_Core/shell/playstation/Initializer.cpp 2021-09-10 22:16:06 UTC (rev 282294)
+++ trunk/Source/_javascript_Core/shell/playstation/Initializer.cpp 2021-09-10 22:32:43 UTC (rev 282295)
@@ -43,6 +43,8 @@
loadLibraryOrExit("SystemServices");
loadLibraryOrExit("Perf");
loadLibraryOrExit("PosixWebKit");
+#if !ENABLE(STATIC_JSC)
loadLibraryOrExit("libJavaScriptCore");
+#endif
loadLibraryOrExit("libicu");
}
Modified: trunk/Source/WebKit/ChangeLog (282294 => 282295)
--- trunk/Source/WebKit/ChangeLog 2021-09-10 22:16:06 UTC (rev 282294)
+++ trunk/Source/WebKit/ChangeLog 2021-09-10 22:32:43 UTC (rev 282295)
@@ -1,3 +1,16 @@
+2021-09-10 Stephan Szabo
+
+[PlayStation] Support running applications with ENABLE_STATIC_JSC=ON
+https://bugs.webkit.org/show_bug.cgi?id=230170
+
+Reviewed by Ross Kirsling.
+
+Updating loading code to not load libJavaScriptCore shared library
+if we are using a static version.
+
+* NetworkProcess/EntryPoint/playstation/NetworkProcessMain.cpp:
+* WebProcess/EntryPoint/playstation/WebProcessMain.cpp:
+
2021-09-10 Per Arne
[macOS] Close XPC connection before entering the WP sandbox
Modified: trunk/Source/WebKit/NetworkProcess/EntryPoint/playstation/NetworkProcessMain.cpp (282294 => 282295)
--- trunk/Source/WebKit/NetworkProcess/EntryPoint/playstation/NetworkProcessMain.cpp 2021-09-10 22:16:06 UTC (rev 282294)
+++ trunk/Source/WebKit/NetworkProcess/EntryPoint/playstation/NetworkProcessMain.cpp 2021-09-10 22:32:43 UTC (rev 282295)
@@ -54,7 +54,9 @@
loadLibraryOrExit("libcurl");
loadLibraryOrExit("libicu");
loadLibraryOrExit("libSceNKWebKitRequirements");
+#if !ENABLE(STATIC_JSC)
loadLibraryOrExit("libJavaScriptCore");
+#endif
loadLibraryOrExit("libWebKit");
char* coreProcessIdentifier = argv[1];
Modified: trunk/Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp (282294 => 282295)
--- trunk/Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp 2021-09-10 22:16:06 UTC (rev 282294)
+++ trunk/Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp 2021-09-10 22:32:43 UTC (rev 282295)
@@ -54,7 +54,9 @@
loadLibraryOrExit("libharfbuzz");
loadLibraryOrExit("libcairo");
loadLibraryOrExit("libSceNKWebKitRequirements");
+#if !ENABLE(STATIC_JSC)
loadLibraryOrExit("libJavaScriptCore");
+#endif
loadLibraryOrExit("libWebKit");
char* coreProcessIdentifier = argv[1];
Modified: trunk/Tools/ChangeLog (282294 => 282295)
--- trunk/Tools/ChangeLog 2021-09-10 22:16:06 UTC (rev 282294)
+++ trunk/Tools/ChangeLog 2021-09-1
[webkit-changes] [280569] trunk/Source/JavaScriptCore
Title: [280569] trunk/Source/_javascript_Core
Revision 280569
Author stephan.sz...@sony.com
Date 2021-08-02 16:39:10 -0700 (Mon, 02 Aug 2021)
Log Message
[PlayStation] Make C files in testapi compile with a C standard rather than C++ one
https://bugs.webkit.org/show_bug.cgi?id=228701
Reviewed by Ross Kirsling.
* shell/PlatformPlayStation.cmake: Set standard for C files in testapi
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/PlatformPlayStation.cmake
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (280568 => 280569)
--- trunk/Source/_javascript_Core/ChangeLog 2021-08-02 23:19:18 UTC (rev 280568)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-08-02 23:39:10 UTC (rev 280569)
@@ -1,3 +1,12 @@
+2021-08-02 Stephan Szabo
+
+[PlayStation] Make C files in testapi compile with a C standard rather than C++ one
+https://bugs.webkit.org/show_bug.cgi?id=228701
+
+Reviewed by Ross Kirsling.
+
+* shell/PlatformPlayStation.cmake: Set standard for C files in testapi
+
2021-08-02 Yusuke Suzuki
[JSC] Yarr should use Bitmap instead of ByteVector for BoyerMoore search
Modified: trunk/Source/_javascript_Core/shell/PlatformPlayStation.cmake (280568 => 280569)
--- trunk/Source/_javascript_Core/shell/PlatformPlayStation.cmake 2021-08-02 23:19:18 UTC (rev 280568)
+++ trunk/Source/_javascript_Core/shell/PlatformPlayStation.cmake 2021-08-02 23:39:10 UTC (rev 280569)
@@ -24,3 +24,13 @@
if (${CMAKE_GENERATOR} MATCHES "Visual Studio")
set_target_properties(jsc PROPERTIES VS_DEBUGGER_WORKING_DIRECTORY "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}")
endif ()
+
+
+if (${CMAKE_GENERATOR} MATCHES "Visual Studio")
+# With the VisualStudio generator, the compiler complains about -std=c++* for C sources.
+set_source_files_properties(
+../API/tests/CustomGlobalObjectClassTest.c
+../API/tests/testapi.c
+PROPERTIES COMPILE_FLAGS --std=gnu17
+)
+endif ()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280784] trunk/Source/WebKitLegacy/win
Title: [280784] trunk/Source/WebKitLegacy/win
Revision 280784
Author stephan.sz...@sony.com
Date 2021-08-09 11:24:39 -0700 (Mon, 09 Aug 2021)
Log Message
[WinCairo][Debug] Build fix after r280756
https://bugs.webkit.org/show_bug.cgi?id=228918
Reviewed by Darin Adler.
* WebView.cpp: Update call to initializeLogChannelsIfNecessary
Modified Paths
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebView.cpp
Diff
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (280783 => 280784)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2021-08-09 18:22:41 UTC (rev 280783)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2021-08-09 18:24:39 UTC (rev 280784)
@@ -1,3 +1,12 @@
+2021-08-09 Stephan Szabo
+
+[WinCairo][Debug] Build fix after r280756
+https://bugs.webkit.org/show_bug.cgi?id=228918
+
+Reviewed by Darin Adler.
+
+* WebView.cpp: Update call to initializeLogChannelsIfNecessary
+
2021-08-02 Fujii Hironori
[Win] ASSERTION FAILED: evt->type() == eventNames().keydownEvent || evt->type() == eventNames().keypressEvent in WebView::interpretKeyEvent since r280492
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (280783 => 280784)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2021-08-09 18:22:41 UTC (rev 280783)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2021-08-09 18:24:39 UTC (rev 280784)
@@ -3090,7 +3090,7 @@
static bool didOneTimeInitialization;
if (!didOneTimeInitialization) {
#if !LOG_DISABLED || !RELEASE_LOG_DISABLED
-initializeLogChannelsIfNecessary();
+logChannels().initializeLogChannelsIfNecessary();
#endif // !LOG_DISABLED || !RELEASE_LOG_DISABLED
// Initialize our platform strategies first before invoking the rest
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280866] trunk/Source/WTF
Title: [280866] trunk/Source/WTF Revision 280866 Author stephan.sz...@sony.com Date 2021-08-10 14:53:12 -0700 (Tue, 10 Aug 2021) Log Message [WTF][PlayStation] REGRESSION(r280795) error: undefined symbol: WTF::logLevelString() https://bugs.webkit.org/show_bug.cgi?id=228959 Reviewed by Fujii Hironori. As per followup win fix, for declspec platforms, LoggingUnix needs to include LogInitialization to get the export declaration. * wtf/unix/LoggingUnix.cpp: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/unix/LoggingUnix.cpp Diff Modified: trunk/Source/WTF/ChangeLog (280865 => 280866) --- trunk/Source/WTF/ChangeLog 2021-08-10 21:37:20 UTC (rev 280865) +++ trunk/Source/WTF/ChangeLog 2021-08-10 21:53:12 UTC (rev 280866) @@ -1,3 +1,15 @@ +2021-08-10 Stephan Szabo + +[WTF][PlayStation] REGRESSION(r280795) error: undefined symbol: WTF::logLevelString() +https://bugs.webkit.org/show_bug.cgi?id=228959 + +Reviewed by Fujii Hironori. + +As per followup win fix, for declspec platforms, LoggingUnix needs +to include LogInitialization to get the export declaration. + +* wtf/unix/LoggingUnix.cpp: + 2021-08-10 Keith Miller CallFrame::returnPC should untag the return address before passing it to ReturnAddressPtr Modified: trunk/Source/WTF/wtf/unix/LoggingUnix.cpp (280865 => 280866) --- trunk/Source/WTF/wtf/unix/LoggingUnix.cpp 2021-08-10 21:37:20 UTC (rev 280865) +++ trunk/Source/WTF/wtf/unix/LoggingUnix.cpp 2021-08-10 21:53:12 UTC (rev 280866) @@ -24,6 +24,7 @@ #if !LOG_DISABLED || !RELEASE_LOG_DISABLED +#include "LogInitialization.h" #include #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [277985] trunk/Tools
Title: [277985] trunk/Tools
Revision 277985
Author stephan.sz...@sony.com
Date 2021-05-24 17:07:50 -0700 (Mon, 24 May 2021)
Log Message
[PlayStation] Update scripts for JSC test changes
https://bugs.webkit.org/show_bug.cgi?id=226181
Reviewed by Ross Kirsling.
Update the scripts to pass the status file location and
unique test id into the runner for handling some crash
cases, and update the status command because the status
is written as a number in our case rather than being
the return type from executing the program directly.
* Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb
Diff
Modified: trunk/Tools/ChangeLog (277984 => 277985)
--- trunk/Tools/ChangeLog 2021-05-25 00:03:46 UTC (rev 277984)
+++ trunk/Tools/ChangeLog 2021-05-25 00:07:50 UTC (rev 277985)
@@ -1,3 +1,18 @@
+2021-05-24 Stephan Szabo
+
+[PlayStation] Update scripts for JSC test changes
+https://bugs.webkit.org/show_bug.cgi?id=226181
+
+Reviewed by Ross Kirsling.
+
+Update the scripts to pass the status file location and
+unique test id into the runner for handling some crash
+cases, and update the status command because the status
+is written as a number in our case rather than being
+the return type from executing the program directly.
+
+* Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
+
2021-05-24 Chris Fleizach
AX: Settings: Increase contrast isn't detected in browser until an additional setting is applied
Modified: trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb (277984 => 277985)
--- trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb 2021-05-25 00:03:46 UTC (rev 277984)
+++ trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb 2021-05-25 00:07:50 UTC (rev 277985)
@@ -311,7 +311,7 @@
# something that's clearly invalid.
<<-END_STATUS_COMMAND
File.open("#{statusFile}", "w") { |f|
- f.puts("#{$runUniqueId} \#{status.nil? ? 9 : status.exitstatus} #{status_code}")
+ f.puts("#{$runUniqueId} \#{status.nil? ? 9 : status} #{status_code}")
}
END_STATUS_COMMAND
end
@@ -358,6 +358,7 @@
outputName: @name.gsub(/(\\|\/)/, '_'),
checkScript: filename,
args: @arguments,
+statusFile: "#{statusFile}",
})
}
@@ -412,7 +413,7 @@
options = ENV["JSCTEST_options"]
fsRoot = $jscPath.dirname
-command = "PlayStationTestRunner #{options} -numProcesses=#{$numChildProcesses.to_s} -exe=#{$jscPath} -fsroot=#{fsRoot} @#{$runnerDir}/runscript"
+command = "PlayStationTestRunner #{options} -numProcesses=#{$numChildProcesses.to_s} -exe=#{$jscPath} -fsroot=#{fsRoot} --runUniqueId=#{$runUniqueId} @#{$runnerDir}/runscript"
print command
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [278138] trunk/Tools
Title: [278138] trunk/Tools
Revision 278138
Author stephan.sz...@sony.com
Date 2021-05-26 17:35:38 -0700 (Wed, 26 May 2021)
Log Message
Cleanup temporary directory after TestWTF's FileSystemTests
https://bugs.webkit.org/show_bug.cgi?id=226300
Reviewed by Chris Dumez.
* TestWebKitAPI/Tests/WTF/FileSystem.cpp: move to deleteNonEmptyDirectory during test cleanup
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp
Diff
Modified: trunk/Tools/ChangeLog (278137 => 278138)
--- trunk/Tools/ChangeLog 2021-05-27 00:10:35 UTC (rev 278137)
+++ trunk/Tools/ChangeLog 2021-05-27 00:35:38 UTC (rev 278138)
@@ -1,3 +1,12 @@
+2021-05-26 Stephan Szabo
+
+Cleanup temporary directory after TestWTF's FileSystemTests
+https://bugs.webkit.org/show_bug.cgi?id=226300
+
+Reviewed by Chris Dumez.
+
+* TestWebKitAPI/Tests/WTF/FileSystem.cpp: move to deleteNonEmptyDirectory during test cleanup
+
2021-05-26 Don Olmstead
[CMake] Support USE_ANGLE_EGL on additional platforms
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp (278137 => 278138)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp 2021-05-27 00:10:35 UTC (rev 278137)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp 2021-05-27 00:35:38 UTC (rev 278138)
@@ -91,7 +91,7 @@
{
FileSystem::deleteFile(m_tempFilePath);
FileSystem::deleteFile(m_tempFileSymlinkPath);
-FileSystem::deleteEmptyDirectory(m_tempEmptyFolderPath);
+FileSystem::deleteNonEmptyDirectory(m_tempEmptyFolderPath);
FileSystem::deleteFile(m_tempEmptyFolderSymlinkPath);
FileSystem::deleteFile(m_tempEmptyFilePath);
FileSystem::deleteFile(m_spaceContainingFilePath);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [278210] trunk/Source/JavaScriptCore
Title: [278210] trunk/Source/_javascript_Core Revision 278210 Author stephan.sz...@sony.com Date 2021-05-28 11:11:33 -0700 (Fri, 28 May 2021) Log Message Regenerate builtins generator expectations after optional changes https://bugs.webkit.org/show_bug.cgi?id=226381 Reviewed by Chris Dumez. * Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result: * Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result: * Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result: * Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result: * Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result: * Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result: * Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result: * Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result: * Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result: * Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result: * Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result: * Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result: * Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result Diff Modified: trunk/Source/_javascript_Core/ChangeLog (278209 => 278210) --- trunk/Source/_javascript_Core/ChangeLog 2021-05-28 17:59:21 UTC (rev 278209) +++ trunk/Source/_javascript_Core/ChangeLog 2021-05-28 18:11:33 UTC (rev 278210) @@ -1,3 +1,24 @@ +2021-05-28 Stephan Szabo + +Regenerate builtins generator expectations after optional changes +https://bugs.webkit.org/show_bug.cgi?id=226381 + +Reviewed by Chris Dumez. + +* Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result: +* Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result: +* Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result: +* Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result: +* Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result: +* Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result: +* Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result: +* Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result: +* Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result: +* Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result: +* Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result: +* Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result: +* Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result: + 2021-05-28 Mark Lam The jsc shell should not continue executing after a termination has been received. Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result (278209 => 278210) --- trunk/Source/_javascript_Core/Scripts/tests/builtins/ex
[webkit-changes] [267768] trunk/Source/WebKit
Title: [267768] trunk/Source/WebKit
Revision 267768
Author stephan.sz...@sony.com
Date 2020-09-29 15:57:06 -0700 (Tue, 29 Sep 2020)
Log Message
[PlayStation] Build fix for GPU Process after r267725
https://bugs.webkit.org/show_bug.cgi?id=217098
Unreviewed build fix.
Update playstation specific code for signature changes in the above.
Fix MediaPlayerPrivateRemote constructor when RELEASE_LOG_DISABLED was specified.
* GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp:
* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (267767 => 267768)
--- trunk/Source/WebKit/ChangeLog 2020-09-29 22:04:19 UTC (rev 267767)
+++ trunk/Source/WebKit/ChangeLog 2020-09-29 22:57:06 UTC (rev 267768)
@@ -1,3 +1,16 @@
+2020-09-29 Stephan Szabo
+
+[PlayStation] Build fix for GPU Process after r267725
+https://bugs.webkit.org/show_bug.cgi?id=217098
+
+Unreviewed build fix.
+
+Update playstation specific code for signature changes in the above.
+Fix MediaPlayerPrivateRemote constructor when RELEASE_LOG_DISABLED was specified.
+
+* GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp:
+* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
+
2020-09-29 Alex Christensen
Move NetworkProcessProxy ownership from WebProcessPool to WebsiteDataStore
Modified: trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp (267767 => 267768)
--- trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp 2020-09-29 22:04:19 UTC (rev 267767)
+++ trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp 2020-09-29 22:57:06 UTC (rev 267768)
@@ -33,7 +33,7 @@
namespace WebKit {
-void RemoteMediaPlayerProxy::prepareForPlayback(bool, WebCore::MediaPlayerEnums::Preload, bool, bool, float videoContentScale, CompletionHandler&& inlineLayerHostingContextId, Optional&& fullscreenLayerHostingContextId)>&&)
+void RemoteMediaPlayerProxy::prepareForPlayback(bool, WebCore::MediaPlayerEnums::Preload, bool, bool, float videoContentScale, CompletionHandler&& inlineLayerHostingContextId)>&&)
{
notImplemented();
}
Modified: trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp (267767 => 267768)
--- trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp 2020-09-29 22:04:19 UTC (rev 267767)
+++ trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp 2020-09-29 22:57:06 UTC (rev 267768)
@@ -92,11 +92,11 @@
#if !PLATFORM(COCOA)
MediaPlayerPrivateRemote::MediaPlayerPrivateRemote(MediaPlayer* player, MediaPlayerEnums::MediaEngineIdentifier engineIdentifier, MediaPlayerPrivateRemoteIdentifier playerIdentifier, RemoteMediaPlayerManager& manager)
+: m_player(player)
#if !RELEASE_LOG_DISABLED
-: m_logger(player->mediaPlayerLogger())
+, m_logger(player->mediaPlayerLogger())
, m_logIdentifier(player->mediaPlayerLogIdentifier())
#endif
-, m_player(player)
, m_mediaResourceLoader(*player->createResourceLoader())
, m_manager(manager)
, m_remoteEngineIdentifier(engineIdentifier)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268471] trunk/Tools
Title: [268471] trunk/Tools
Revision 268471
Author stephan.sz...@sony.com
Date 2020-10-14 10:30:15 -0700 (Wed, 14 Oct 2020)
Log Message
builtins-generator-tests and bindings-generation-tests are reporting "Failed to install configparser-4.0.2!" since r268267 on WinCairo Buildbot
https://bugs.webkit.org/show_bug.cgi?id=217586
Reviewed by Jonathan Bedard.
Pass proxy environment variables to setup.py so wincairo bots
which need the proxy set can reach pypi.org.
* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:
* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py
Diff
Modified: trunk/Tools/ChangeLog (268470 => 268471)
--- trunk/Tools/ChangeLog 2020-10-14 17:20:35 UTC (rev 268470)
+++ trunk/Tools/ChangeLog 2020-10-14 17:30:15 UTC (rev 268471)
@@ -1,3 +1,16 @@
+2020-10-14 Stephan Szabo
+
+builtins-generator-tests and bindings-generation-tests are reporting "Failed to install configparser-4.0.2!" since r268267 on WinCairo Buildbot
+https://bugs.webkit.org/show_bug.cgi?id=217586
+
+Reviewed by Jonathan Bedard.
+
+Pass proxy environment variables to setup.py so wincairo bots
+which need the proxy set can reach pypi.org.
+
+* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:
+* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
+
2020-10-14 Ryan Haddad
Temporarily reduce the number of iOS simulators booted during testing
Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py (268470 => 268471)
--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py 2020-10-14 17:20:35 UTC (rev 268470)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py 2020-10-14 17:30:15 UTC (rev 268471)
@@ -35,7 +35,7 @@
from webkitcorepy.subprocess_utils import TimeoutExpired, CompletedProcess, run
from webkitcorepy.output_capture import LoggerCapture, OutputCapture, OutputDuplicate
-version = Version(0, 4, 15)
+version = Version(0, 4, 16)
from webkitcorepy.autoinstall import Package, AutoInstall
if sys.version_info > (3, 0):
Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py (268470 => 268471)
--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py 2020-10-14 17:20:35 UTC (rev 268470)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py 2020-10-14 17:30:15 UTC (rev 268471)
@@ -258,6 +258,8 @@
],
cwd=candidate,
env=dict(
+HTTP_PROXY=os.environ.get('HTTP_PROXY', ''),
+HTTPS_PROXY=os.environ.get('HTTPS_PROXY', ''),
PATH=os.environ.get('PATH', ''),
PATHEXT=os.environ.get('PATHEXT', ''),
PYTHONPATH=install_location,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [272790] trunk/Source/WebCore
Title: [272790] trunk/Source/WebCore
Revision 272790
Author stephan.sz...@sony.com
Date 2021-02-12 10:50:05 -0800 (Fri, 12 Feb 2021)
Log Message
[WinCairo][Debug] Build fix after r272772
https://bugs.webkit.org/show_bug.cgi?id=221814
Unreviewed build fix.
* platform/graphics/cairo/FontCairo.cpp:
* platform/graphics/cairo/GraphicsContextImplCairo.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/FontCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextImplCairo.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (272789 => 272790)
--- trunk/Source/WebCore/ChangeLog 2021-02-12 18:40:44 UTC (rev 272789)
+++ trunk/Source/WebCore/ChangeLog 2021-02-12 18:50:05 UTC (rev 272790)
@@ -1,3 +1,13 @@
+2021-02-12 Stephan Szabo
+
+[WinCairo][Debug] Build fix after r272772
+https://bugs.webkit.org/show_bug.cgi?id=221814
+
+Unreviewed build fix.
+
+* platform/graphics/cairo/FontCairo.cpp:
+* platform/graphics/cairo/GraphicsContextImplCairo.cpp:
+
2021-02-12 Chris Dumez
Reduce explicit usage of [objC release] in WebKit
Modified: trunk/Source/WebCore/platform/graphics/cairo/FontCairo.cpp (272789 => 272790)
--- trunk/Source/WebCore/platform/graphics/cairo/FontCairo.cpp 2021-02-12 18:40:44 UTC (rev 272789)
+++ trunk/Source/WebCore/platform/graphics/cairo/FontCairo.cpp 2021-02-12 18:50:05 UTC (rev 272790)
@@ -58,8 +58,6 @@
auto xOffset = point.x();
Vector cairoGlyphs(numGlyphs);
{
-ASSERT(from + numGlyphs <= glyphBuffer.size());
-
auto yOffset = point.y();
for (size_t i = 0; i < numGlyphs; ++i) {
cairoGlyphs[i] = { glyphs[i], xOffset, yOffset };
Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextImplCairo.cpp (272789 => 272790)
--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextImplCairo.cpp 2021-02-12 18:40:44 UTC (rev 272789)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextImplCairo.cpp 2021-02-12 18:50:05 UTC (rev 272790)
@@ -240,7 +240,6 @@
auto xOffset = point.x();
Vector cairoGlyphs(numGlyphs);
{
-ASSERT(from + numGlyphs <= numGlyphs);
auto yOffset = point.y();
for (size_t i = 0; i < numGlyphs; ++i) {
cairoGlyphs[i] = { glyphs[i], xOffset, yOffset };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [272811] trunk/Source/WebCore
Title: [272811] trunk/Source/WebCore
Revision 272811
Author stephan.sz...@sony.com
Date 2021-02-12 14:07:47 -0800 (Fri, 12 Feb 2021)
Log Message
[PlayStation][Debug] Build fix after r272772
https://bugs.webkit.org/show_bug.cgi?id=221836
Unreviewed Build Fix
* platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (272810 => 272811)
--- trunk/Source/WebCore/ChangeLog 2021-02-12 22:01:59 UTC (rev 272810)
+++ trunk/Source/WebCore/ChangeLog 2021-02-12 22:07:47 UTC (rev 272811)
@@ -1,3 +1,12 @@
+2021-02-12 Stephan Szabo
+
+[PlayStation][Debug] Build fix after r272772
+https://bugs.webkit.org/show_bug.cgi?id=221836
+
+Unreviewed Build Fix
+
+* platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
+
2021-02-12 Zalan Bujtas
[LFC][IFC] Multiline inline boxes have incorrect content box height/width values
Modified: trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp (272810 => 272811)
--- trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp 2021-02-12 22:01:59 UTC (rev 272810)
+++ trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp 2021-02-12 22:07:47 UTC (rev 272811)
@@ -516,7 +516,6 @@
auto xOffset = point.x();
Vector cairoGlyphs(numGlyphs);
{
-ASSERT(from + numGlyphs <= numGlyphs);
auto yOffset = point.y();
for (size_t i = 0; i < numGlyphs; ++i) {
cairoGlyphs[i] = { glyphs[i], xOffset, yOffset };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273037] trunk/Source/WebCore
Title: [273037] trunk/Source/WebCore
Revision 273037
Author stephan.sz...@sony.com
Date 2021-02-17 15:30:59 -0800 (Wed, 17 Feb 2021)
Log Message
[PlayStation] Fix build break after r272948
https://bugs.webkit.org/show_bug.cgi?id=222061
Reviewed by Don Olmstead.
* inspector/InspectorOverlay.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorOverlay.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (273036 => 273037)
--- trunk/Source/WebCore/ChangeLog 2021-02-17 23:14:39 UTC (rev 273036)
+++ trunk/Source/WebCore/ChangeLog 2021-02-17 23:30:59 UTC (rev 273037)
@@ -1,3 +1,12 @@
+2021-02-17 Stephan Szabo
+
+[PlayStation] Fix build break after r272948
+https://bugs.webkit.org/show_bug.cgi?id=222061
+
+Reviewed by Don Olmstead.
+
+* inspector/InspectorOverlay.cpp:
+
2021-02-17 Alex Christensen
Effectively revert r272908
Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (273036 => 273037)
--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2021-02-17 23:14:39 UTC (rev 273036)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2021-02-17 23:30:59 UTC (rev 273037)
@@ -1390,7 +1390,10 @@
}
if (gridOverlay.config.showAreaNames) {
-for (auto& [name, area] : node->renderStyle()->namedGridArea()) {
+for (auto& gridArea : node->renderStyle()->namedGridArea()) {
+auto& name = gridArea.key;
+auto& area = gridArea.value;
+
// Named grid areas will always be rectangular per the CSS Grid specification.
auto columnStartLine = area.columns.startLine();
auto columnEndLine = area.columns.endLine();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273694] trunk/Source/WebKit
Title: [273694] trunk/Source/WebKit
Revision 273694
Author stephan.sz...@sony.com
Date 2021-03-01 15:06:10 -0800 (Mon, 01 Mar 2021)
Log Message
[WinCairo] Building with ENABLE_SERVICE_WORKER=OFF fails
https://bugs.webkit.org/show_bug.cgi?id=222566
Unreviewed build fix.
* UIProcess/WebProcessPool.cpp: Only compile a method when service
worker is enabled.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (273693 => 273694)
--- trunk/Source/WebKit/ChangeLog 2021-03-01 22:58:01 UTC (rev 273693)
+++ trunk/Source/WebKit/ChangeLog 2021-03-01 23:06:10 UTC (rev 273694)
@@ -1,3 +1,13 @@
+2021-03-01 Stephan Szabo
+
+[WinCairo] Building with ENABLE_SERVICE_WORKER=OFF fails
+https://bugs.webkit.org/show_bug.cgi?id=222566
+
+Unreviewed build fix.
+
+* UIProcess/WebProcessPool.cpp: Only compile a method when service
+worker is enabled.
+
2021-03-01 Chris Dumez
Have WebProcessPool::processForRegistrableDomain() return a Ref
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (273693 => 273694)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2021-03-01 22:58:01 UTC (rev 273693)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2021-03-01 23:06:10 UTC (rev 273694)
@@ -1011,6 +1011,7 @@
return createNewWebProcess(&websiteDataStore);
}
+#if ENABLE(SERVICE_WORKER)
UserContentControllerIdentifier WebProcessPool::userContentControllerIdentifierForServiceWorkers()
{
if (!m_userContentControllerForServiceWorker)
@@ -1018,6 +1019,7 @@
return m_userContentControllerForServiceWorker->identifier();
}
+#endif
Ref WebProcessPool::createWebPage(PageClient& pageClient, Ref&& pageConfiguration)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [272173] trunk/Source/WebKit
Title: [272173] trunk/Source/WebKit
Revision 272173
Author stephan.sz...@sony.com
Date 2021-02-01 13:27:01 -0800 (Mon, 01 Feb 2021)
Log Message
[PlayStation] Build fix after r272058
https://bugs.webkit.org/show_bug.cgi?id=221141
Unreviewed build fix.
* Platform/unix/SharedMemoryUnix.cpp: Include ArgumentCoders.h on PlayStation
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (272172 => 272173)
--- trunk/Source/WebKit/ChangeLog 2021-02-01 21:24:39 UTC (rev 272172)
+++ trunk/Source/WebKit/ChangeLog 2021-02-01 21:27:01 UTC (rev 272173)
@@ -1,3 +1,12 @@
+2021-02-01 Stephan Szabo
+
+[PlayStation] Build fix after r272058
+https://bugs.webkit.org/show_bug.cgi?id=221141
+
+Unreviewed build fix.
+
+* Platform/unix/SharedMemoryUnix.cpp: Include ArgumentCoders.h on PlayStation
+
2021-02-01 Sihui Liu
Use user media permission prompt for speech recognition
Modified: trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp (272172 => 272173)
--- trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp 2021-02-01 21:24:39 UTC (rev 272172)
+++ trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp 2021-02-01 21:27:01 UTC (rev 272173)
@@ -49,6 +49,10 @@
#include
#endif
+#if PLATFORM(PLAYSTATION)
+#include "ArgumentCoders.h"
+#endif
+
namespace WebKit {
SharedMemory::Handle::Handle()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [267166] trunk
Title: [267166] trunk Revision 267166 Author stephan.sz...@sony.com Date 2020-09-16 15:30:00 -0700 (Wed, 16 Sep 2020) Log Message Remove ENABLE_METER_ELEMENT https://bugs.webkit.org/show_bug.cgi?id=216582 Reviewed by Fujii Hironori. With PlayStation finally planning to turn this on, no ports had this disabled, so remove the enable flag. .: * Source/cmake/OptionsFTW.cmake: * Source/cmake/OptionsMac.cmake: * Source/cmake/OptionsPlayStation.cmake: * Source/cmake/OptionsWin.cmake: * Source/cmake/WebKitFeatures.cmake: * Source/cmake/tools/vsprops/FeatureDefines.props: * Source/cmake/tools/vsprops/FeatureDefinesCairo.props: Source/WebCore: * DerivedSources.make: * accessibility/AXObjectCache.cpp: * accessibility/AccessibilityObject.cpp: * accessibility/AccessibilityProgressIndicator.cpp: * accessibility/AccessibilityProgressIndicator.h: * accessibility/AccessibilityRenderObject.cpp: * css/html.css: * html/HTMLMeterElement.cpp: * html/HTMLMeterElement.h: * html/HTMLMeterElement.idl: * html/HTMLTagNames.in: * platform/LocalizedStrings.h: * platform/cocoa/LocalizedStringsCocoa.mm: * rendering/RenderMeter.cpp: * rendering/RenderMeter.h: * rendering/RenderObject.h: * rendering/RenderTheme.cpp: * rendering/RenderTheme.h: * rendering/RenderThemeMac.h: * rendering/RenderThemeMac.mm: * rendering/RenderThemeWin.cpp: * rendering/RenderThemeWin.h: Source/WTF: * wtf/PlatformEnable.h: Tools: * Scripts/webkitperl/FeatureList.pm: Modified Paths trunk/ChangeLog trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformEnable.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp trunk/Source/WebCore/accessibility/AccessibilityProgressIndicator.h trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/css/html.css trunk/Source/WebCore/html/HTMLMeterElement.cpp trunk/Source/WebCore/html/HTMLMeterElement.h trunk/Source/WebCore/html/HTMLMeterElement.idl trunk/Source/WebCore/html/HTMLTagNames.in trunk/Source/WebCore/platform/LocalizedStrings.h trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm trunk/Source/WebCore/rendering/RenderMeter.cpp trunk/Source/WebCore/rendering/RenderMeter.h trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderTheme.cpp trunk/Source/WebCore/rendering/RenderTheme.h trunk/Source/WebCore/rendering/RenderThemeMac.h trunk/Source/WebCore/rendering/RenderThemeMac.mm trunk/Source/WebCore/rendering/RenderThemeWin.cpp trunk/Source/WebCore/rendering/RenderThemeWin.h trunk/Source/cmake/OptionsFTW.cmake trunk/Source/cmake/OptionsMac.cmake trunk/Source/cmake/OptionsPlayStation.cmake trunk/Source/cmake/OptionsWin.cmake trunk/Source/cmake/WebKitFeatures.cmake trunk/Source/cmake/tools/vsprops/FeatureDefines.props trunk/Source/cmake/tools/vsprops/FeatureDefinesCairo.props trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitperl/FeatureList.pm Diff Modified: trunk/ChangeLog (267165 => 267166) --- trunk/ChangeLog 2020-09-16 22:05:10 UTC (rev 267165) +++ trunk/ChangeLog 2020-09-16 22:30:00 UTC (rev 267166) @@ -1,3 +1,21 @@ +2020-09-16 Stephan Szabo + +Remove ENABLE_METER_ELEMENT +https://bugs.webkit.org/show_bug.cgi?id=216582 + +Reviewed by Fujii Hironori. + +With PlayStation finally planning to turn this on, +no ports had this disabled, so remove the enable flag. + +* Source/cmake/OptionsFTW.cmake: +* Source/cmake/OptionsMac.cmake: +* Source/cmake/OptionsPlayStation.cmake: +* Source/cmake/OptionsWin.cmake: +* Source/cmake/WebKitFeatures.cmake: +* Source/cmake/tools/vsprops/FeatureDefines.props: +* Source/cmake/tools/vsprops/FeatureDefinesCairo.props: + 2020-09-15 David Kilzer WebKit should support building with clang ThreadSanitizer enabled Modified: trunk/Source/WTF/ChangeLog (267165 => 267166) --- trunk/Source/WTF/ChangeLog 2020-09-16 22:05:10 UTC (rev 267165) +++ trunk/Source/WTF/ChangeLog 2020-09-16 22:30:00 UTC (rev 267166) @@ -1,3 +1,15 @@ +2020-09-16 Stephan Szabo + +Remove ENABLE_METER_ELEMENT +https://bugs.webkit.org/show_bug.cgi?id=216582 + +Reviewed by Fujii Hironori. + +With PlayStation finally planning to turn this on, +no ports had this disabled, so remove the enable flag. + +* wtf/PlatformEnable.h: + 2020-09-16 Alex Christensen Remove unneeded HAVE_FOUNDATION_WITH_SAVE_COOKIES_WITH_COMPLETION_HANDLER Modified: trunk/Source/WTF/wtf/PlatformEnable.h (267165 => 267166) --- trunk/Source/WTF/wtf/PlatformEnable.h 2020-09-16 22:05:10 UTC (rev 267165) +++ trunk/Source/WTF/wtf/PlatformEnable.h 2020-09-16 22:30:00 UTC (rev 267166) @@ -365,10 +365,6 @@ #define ENABLE_MEDIA_STREAM 0 #endif -#if !defined(ENABLE_METER_ELEMENT)
[webkit-changes] [269001] trunk/Source/WebCore
Title: [269001] trunk/Source/WebCore
Revision 269001
Author stephan.sz...@sony.com
Date 2020-10-26 16:47:18 -0700 (Mon, 26 Oct 2020)
Log Message
evictCodedFrames does extra work if RELEASE_LOG_DISABLED is set
https://bugs.webkit.org/show_bug.cgi?id=218203
Reviewed by Eric Carlson.
Undo part of previous logging change that prevents checking
if the buffer is still full after the first part of eviction
if RELEASE_LOG_DISABLED is set.
* Modules/mediasource/SourceBuffer.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (269000 => 269001)
--- trunk/Source/WebCore/ChangeLog 2020-10-26 23:38:10 UTC (rev 269000)
+++ trunk/Source/WebCore/ChangeLog 2020-10-26 23:47:18 UTC (rev 269001)
@@ -1,3 +1,16 @@
+2020-10-26 Stephan Szabo
+
+evictCodedFrames does extra work if RELEASE_LOG_DISABLED is set
+https://bugs.webkit.org/show_bug.cgi?id=218203
+
+Reviewed by Eric Carlson.
+
+Undo part of previous logging change that prevents checking
+if the buffer is still full after the first part of eviction
+if RELEASE_LOG_DISABLED is set.
+
+* Modules/mediasource/SourceBuffer.cpp:
+
2020-10-26 Simon Fraser
REGRESSION (r260276): Unable to click on image and text link at the bottom of https://www.nytimes.com/ article
Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp (269000 => 269001)
--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2020-10-26 23:38:10 UTC (rev 269000)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2020-10-26 23:47:18 UTC (rev 269001)
@@ -974,12 +974,12 @@
rangeEnd += thirtySeconds;
}
+if (!m_bufferFull) {
#if !RELEASE_LOG_DISABLED
-if (!m_bufferFull) {
DEBUG_LOG(LOGIDENTIFIER, "evicted ", initialBufferedSize - extraMemoryCost());
+#endif
return;
}
-#endif
// If there still isn't enough free space and there buffers in time ranges after the current range (ie. there is a gap after
// the current buffered range), delete 30 seconds at a time from duration back to the current time range or 30 seconds after
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269325] trunk/Source
Title: [269325] trunk/Source
Revision 269325
Author stephan.sz...@sony.com
Date 2020-11-03 12:06:15 -0800 (Tue, 03 Nov 2020)
Log Message
[WinCairo/PlayStation] ICU 68.1 no longer exposes FALSE and TRUE macros by default
https://bugs.webkit.org/show_bug.cgi?id=218522
Reviewed by Don Olmstead.
Source/WebCore:
* platform/text/TextCodecICU.cpp: Replace use of TRUE with true
Source/WebKit:
* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp: Replace FALSE with false
Source/WTF:
Replace uses of FALSE and TRUE with false and true.
* wtf/text/icu/UTextProvider.h:
* wtf/text/icu/UTextProviderLatin1.cpp:
* wtf/text/icu/UTextProviderUTF16.cpp:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/icu/UTextProvider.h
trunk/Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp
trunk/Source/WTF/wtf/text/icu/UTextProviderUTF16.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/TextCodecICU.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (269324 => 269325)
--- trunk/Source/WTF/ChangeLog 2020-11-03 19:54:44 UTC (rev 269324)
+++ trunk/Source/WTF/ChangeLog 2020-11-03 20:06:15 UTC (rev 269325)
@@ -1,3 +1,16 @@
+2020-11-03 Stephan Szabo
+
+[WinCairo/PlayStation] ICU 68.1 no longer exposes FALSE and TRUE macros by default
+https://bugs.webkit.org/show_bug.cgi?id=218522
+
+Reviewed by Don Olmstead.
+
+Replace uses of FALSE and TRUE with false and true.
+
+* wtf/text/icu/UTextProvider.h:
+* wtf/text/icu/UTextProviderLatin1.cpp:
+* wtf/text/icu/UTextProviderUTF16.cpp:
+
2020-10-30 Tim Horton
REGRESSION (r267689): Rise of the Tomb Raider gets stuck while launching
Modified: trunk/Source/WTF/wtf/text/icu/UTextProvider.h (269324 => 269325)
--- trunk/Source/WTF/wtf/text/icu/UTextProvider.h 2020-11-03 19:54:44 UTC (rev 269324)
+++ trunk/Source/WTF/wtf/text/icu/UTextProvider.h 2020-11-03 20:06:15 UTC (rev 269325)
@@ -79,12 +79,12 @@
// Ensure chunk offset is well formed if computed offset exceeds int32_t range.
ASSERT(offset < std::numeric_limits::max());
text->chunkOffset = offset < std::numeric_limits::max() ? static_cast(offset) : 0;
-isAccessible = TRUE;
+isAccessible = true;
return true;
}
if (nativeIndex >= nativeLength && text->chunkNativeLimit == nativeLength) {
text->chunkOffset = text->chunkLength;
-isAccessible = FALSE;
+isAccessible = false;
return true;
}
} else {
@@ -93,12 +93,12 @@
// Ensure chunk offset is well formed if computed offset exceeds int32_t range.
ASSERT(offset < std::numeric_limits::max());
text->chunkOffset = offset < std::numeric_limits::max() ? static_cast(offset) : 0;
-isAccessible = TRUE;
+isAccessible = true;
return true;
}
if (nativeIndex <= 0 && !text->chunkNativeStart) {
text->chunkOffset = 0;
-isAccessible = FALSE;
+isAccessible = false;
return true;
}
}
Modified: trunk/Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp (269324 => 269325)
--- trunk/Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp 2020-11-03 19:54:44 UTC (rev 269324)
+++ trunk/Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp 2020-11-03 20:06:15 UTC (rev 269325)
@@ -100,23 +100,23 @@
if (index < uText->chunkNativeLimit && index >= uText->chunkNativeStart) {
// Already inside the buffer. Set the new offset.
uText->chunkOffset = static_cast(index - uText->chunkNativeStart);
-return TRUE;
+return true;
}
if (index >= length && uText->chunkNativeLimit == length) {
// Off the end of the buffer, but we can't get it.
uText->chunkOffset = static_cast(index - uText->chunkNativeStart);
-return FALSE;
+return false;
}
} else {
if (index <= uText->chunkNativeLimit && index > uText->chunkNativeStart) {
// Already inside the buffer. Set the new offset.
uText->chunkOffset = static_cast(index - uText->chunkNativeStart);
-return TRUE;
+return true;
}
if (!index && !uText->chunkNativeStart) {
// Already at the beginning; can't go any farther.
uText->chunkOffset = 0;
-return FALSE;
+return false;
}
}
@@ -144,7 +144,7 @@
uText->nativeIndexingLimit = uText->chunkLength;
-return TRUE;
+return true;
}
[webkit-changes] [275504] trunk/Source/WebCore
Title: [275504] trunk/Source/WebCore
Revision 275504
Author stephan.sz...@sony.com
Date 2021-04-06 04:25:34 -0700 (Tue, 06 Apr 2021)
Log Message
[PlayStation] Change mediaControlsLocalizedStrings to use unicode escapes
https://bugs.webkit.org/show_bug.cgi?id=224195
Reviewed by Yusuke Suzuki.
* en.lproj/mediaControlsLocalizedStrings.js:
Switch from literal smart quotes to unicode escapes.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/en.lproj/mediaControlsLocalizedStrings.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (275503 => 275504)
--- trunk/Source/WebCore/ChangeLog 2021-04-06 11:22:08 UTC (rev 275503)
+++ trunk/Source/WebCore/ChangeLog 2021-04-06 11:25:34 UTC (rev 275504)
@@ -1,3 +1,14 @@
+2021-04-06 Stephan Szabo
+
+[PlayStation] Change mediaControlsLocalizedStrings to use unicode escapes
+https://bugs.webkit.org/show_bug.cgi?id=224195
+
+Reviewed by Yusuke Suzuki.
+
+* en.lproj/mediaControlsLocalizedStrings.js:
+
+Switch from literal smart quotes to unicode escapes.
+
2021-04-06 Rob Buis
Migrate layout ascents and descents to LayoutUnits instead of ints
Modified: trunk/Source/WebCore/en.lproj/mediaControlsLocalizedStrings.js (275503 => 275504)
--- trunk/Source/WebCore/en.lproj/mediaControlsLocalizedStrings.js 2021-04-06 11:22:08 UTC (rev 275503)
+++ trunk/Source/WebCore/en.lproj/mediaControlsLocalizedStrings.js 2021-04-06 11:25:34 UTC (rev 275504)
@@ -1,6 +1,6 @@
var UIStringTable = {
'##WIRELESS_PLAYBACK_DEVICE_TYPE##': 'AirPlay',
-'##WIRELESS_PLAYBACK_DEVICE_NAME##': 'This video is playing on “##DEVICE_NAME##”.',
+'##WIRELESS_PLAYBACK_DEVICE_NAME##': 'This video is playing on \u201C##DEVICE_NAME##\u201D.',
'##TVOUT_DEVICE_TYPE##': 'TV Connected',
'##TVOUT_DEVICE_NAME##': 'This video is playing on the TV.',
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [275518] trunk/Source/WebCore
Title: [275518] trunk/Source/WebCore
Revision 275518
Author stephan.sz...@sony.com
Date 2021-04-06 08:41:57 -0700 (Tue, 06 Apr 2021)
Log Message
[PlayStation] Fix build of DiagnosticLoggingDomain.h
https://bugs.webkit.org/show_bug.cgi?id=224205
Reviewed by Don Olmstead.
No new tests, build fix only.
* page/DiagnosticLoggingDomain.h: Include wtf/EnumTraits.h
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DiagnosticLoggingDomain.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (275517 => 275518)
--- trunk/Source/WebCore/ChangeLog 2021-04-06 14:58:36 UTC (rev 275517)
+++ trunk/Source/WebCore/ChangeLog 2021-04-06 15:41:57 UTC (rev 275518)
@@ -1,3 +1,14 @@
+2021-04-06 Stephan Szabo
+
+[PlayStation] Fix build of DiagnosticLoggingDomain.h
+https://bugs.webkit.org/show_bug.cgi?id=224205
+
+Reviewed by Don Olmstead.
+
+No new tests, build fix only.
+
+* page/DiagnosticLoggingDomain.h: Include wtf/EnumTraits.h
+
2021-04-06 Philippe Normand
REGRESSION(r274358) [GStreamer] http/tests/images/mp4-partial-load.html is flaky crashing inside GStreamer
Modified: trunk/Source/WebCore/page/DiagnosticLoggingDomain.h (275517 => 275518)
--- trunk/Source/WebCore/page/DiagnosticLoggingDomain.h 2021-04-06 14:58:36 UTC (rev 275517)
+++ trunk/Source/WebCore/page/DiagnosticLoggingDomain.h 2021-04-06 15:41:57 UTC (rev 275518)
@@ -25,6 +25,8 @@
#pragma once
+#include
+
namespace WebCore {
enum class DiagnosticLoggingDomain : uint8_t { Media };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [275590] trunk/Source/WebCore
Title: [275590] trunk/Source/WebCore
Revision 275590
Author stephan.sz...@sony.com
Date 2021-04-07 00:40:41 -0700 (Wed, 07 Apr 2021)
Log Message
[PlayStation] Provide a non-empty User Agent
https://bugs.webkit.org/show_bug.cgi?id=224216
Reviewed by Ross Kirsling.
Add non-empty implementation of User Agent code for port.
* platform/playstation/UserAgentPlayStation.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (275589 => 275590)
--- trunk/Source/WebCore/ChangeLog 2021-04-07 07:38:50 UTC (rev 275589)
+++ trunk/Source/WebCore/ChangeLog 2021-04-07 07:40:41 UTC (rev 275590)
@@ -1,3 +1,14 @@
+2021-04-07 Stephan Szabo
+
+[PlayStation] Provide a non-empty User Agent
+https://bugs.webkit.org/show_bug.cgi?id=224216
+
+Reviewed by Ross Kirsling.
+
+Add non-empty implementation of User Agent code for port.
+
+* platform/playstation/UserAgentPlayStation.cpp:
+
2021-04-06 Myles C. Maxfield
[GPU Process] Simplify DisplayList::Iterator part 5: Tweak the return type of DisplayList::Iterator::operator*()
Modified: trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp (275589 => 275590)
--- trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp 2021-04-07 07:38:50 UTC (rev 275589)
+++ trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp 2021-04-07 07:40:41 UTC (rev 275590)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2018 Sony Interactive Entertainment Inc.
+ * Copyright (C) 2021 Sony Interactive Entertainment Inc.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -26,16 +26,110 @@
#include "config.h"
#include "UserAgent.h"
+#include
+#include
+#include
+
+// WARNING! WARNING! WARNING!
+//
+// The user agent is ludicrously fragile. The most innocent change can
+// and will break websites. Read the git log for this file and
+// WebCore/platform/glib/UserAgentGLib.cpp carefully before changing
+// user agent construction. You have been warned.
+
namespace WebCore {
-String standardUserAgent(const String&, const String&)
+static String getSystemSoftwareName()
{
-return emptyString();
+#if HAS_GETENV_NP
+char buf[32];
+if (!getenv_np("SYSTEM_SOFTWARE_NAME", buf, sizeof(buf)))
+return buf;
+#endif
+return "PlayStation";
}
+static String getSystemSoftwareVersion()
+{
+#if HAS_GETENV_NP
+char buf[32];
+if (!getenv_np("SYSTEM_SOFTWARE_VERSION", buf, sizeof(buf)))
+return buf;
+#endif
+return "0.00";
+}
+
+static const String platformForUAString()
+{
+static NeverDestroyed uaSystemSoftwareName(getSystemSoftwareName());
+return uaSystemSoftwareName;
+}
+
+static const String platformVersionForUAString()
+{
+static NeverDestroyed uaSystemSoftwareVersion(getSystemSoftwareVersion());
+return uaSystemSoftwareVersion;
+}
+
+static constexpr const char* versionForUAString()
+{
+// https://bugs.webkit.org/show_bug.cgi?id=180365
+return "605.1.15";
+}
+
+static String buildUserAgentString()
+{
+StringBuilder uaString;
+uaString.appendLiteral("Mozilla/5.0 ");
+uaString.append('(');
+
+uaString.appendLiteral("PlayStation; ");
+
+uaString.append(platformForUAString());
+uaString.append('/');
+uaString.append(platformVersionForUAString());
+
+uaString.appendLiteral(") AppleWebKit/");
+uaString.append(versionForUAString());
+uaString.appendLiteral(" (KHTML, like Gecko) ");
+
+// Version/X is mandatory *before* Safari/X to be a valid Safari UA. See
+// https://bugs.webkit.org/show_bug.cgi?id=133403 for details.
+uaString.appendLiteral("Version/14.0 Safari/");
+uaString.append(versionForUAString());
+
+return uaString.toString();
+}
+
+static const String standardUserAgentStatic()
+{
+static NeverDestroyed uaStatic(buildUserAgentString());
+return uaStatic;
+}
+
+String standardUserAgent(const String& applicationName, const String& applicationVersion)
+{
+// Create a default user agent string with a liberal interpretation of
+// https://developer.mozilla.org/en-US/docs/User_Agent_Strings_Reference
+//
+// Forming a functional user agent is really difficult. We must mention Safari, because some
+// sites check for that when detecting WebKit browsers. Additionally some sites assume that
+// browsers that are "Safari" but not running on OS X are the Safari iOS browser. Getting this
+// wrong can cause sites to load the wrong _javascript_, CSS, or custom fonts. In some cases
+// sites won't load resources at all.
+if (applicationName.isEmpty())
+return standar
[webkit-changes] [275674] trunk/Source/WTF
Title: [275674] trunk/Source/WTF
Revision 275674
Author stephan.sz...@sony.com
Date 2021-04-08 13:45:16 -0700 (Thu, 08 Apr 2021)
Log Message
[RunLoopGeneric] OneShotTimer should not remain "isActive" after fired
https://bugs.webkit.org/show_bug.cgi?id=189335
Reviewed by Geoffrey Garen.
* wtf/generic/RunLoopGeneric.cpp:
Deactivate one-shot timer before invoking its callback.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/generic/RunLoopGeneric.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (275673 => 275674)
--- trunk/Source/WTF/ChangeLog 2021-04-08 20:04:35 UTC (rev 275673)
+++ trunk/Source/WTF/ChangeLog 2021-04-08 20:45:16 UTC (rev 275674)
@@ -1,3 +1,15 @@
+2021-04-08 Stephan Szabo
+
+[RunLoopGeneric] OneShotTimer should not remain "isActive" after fired
+https://bugs.webkit.org/show_bug.cgi?id=189335
+
+
+Reviewed by Geoffrey Garen.
+
+* wtf/generic/RunLoopGeneric.cpp:
+
+Deactivate one-shot timer before invoking its callback.
+
2021-04-08 Khem Raj
[WPE] Build fixes for musl C library on Linux
Modified: trunk/Source/WTF/wtf/generic/RunLoopGeneric.cpp (275673 => 275674)
--- trunk/Source/WTF/wtf/generic/RunLoopGeneric.cpp 2021-04-08 20:04:35 UTC (rev 275673)
+++ trunk/Source/WTF/wtf/generic/RunLoopGeneric.cpp 2021-04-08 20:45:16 UTC (rev 275674)
@@ -50,12 +50,14 @@
if (!isActive())
return false;
+if (!m_isRepeating)
+deactivate();
+
+if (isActive())
+updateReadyTime();
+
m_function();
-if (!m_isRepeating)
-return false;
-
-updateReadyTime();
return isActive();
}
@@ -296,7 +298,7 @@
bool RunLoop::TimerBase::isActive(const AbstractLocker&) const
{
-return m_scheduledTask;
+return m_scheduledTask && m_scheduledTask->isActive();
}
Seconds RunLoop::TimerBase::secondsUntilFire() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270579] trunk/Source/WebKit
Title: [270579] trunk/Source/WebKit
Revision 270579
Author stephan.sz...@sony.com
Date 2020-12-09 08:05:07 -0800 (Wed, 09 Dec 2020)
Log Message
[PlayStation] Fix PlayStation GPU process code after r270563
https://bugs.webkit.org/show_bug.cgi?id=219682
Unreviewed build fix.
Remove mediaPlayerRenderingModeChanged from playstation specific
RemoteMediaPlayerProxyPlayStation file similar to the removals from
other versions in r270563.
* GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (270578 => 270579)
--- trunk/Source/WebKit/ChangeLog 2020-12-09 15:40:17 UTC (rev 270578)
+++ trunk/Source/WebKit/ChangeLog 2020-12-09 16:05:07 UTC (rev 270579)
@@ -1,3 +1,16 @@
+2020-12-09 Stephan Szabo
+
+[PlayStation] Fix PlayStation GPU process code after r270563
+https://bugs.webkit.org/show_bug.cgi?id=219682
+
+Unreviewed build fix.
+
+Remove mediaPlayerRenderingModeChanged from playstation specific
+RemoteMediaPlayerProxyPlayStation file similar to the removals from
+other versions in r270563.
+
+* GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp:
+
2020-12-09 Per Arne Vollan
[macOS] Change Universal Access zoom in the UI process
Modified: trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp (270578 => 270579)
--- trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp 2020-12-09 15:40:17 UTC (rev 270578)
+++ trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp 2020-12-09 16:05:07 UTC (rev 270579)
@@ -43,11 +43,6 @@
notImplemented();
}
-void RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged()
-{
-notImplemented();
-}
-
#if ENABLE(VIDEO_PRESENTATION_MODE)
void RemoteMediaPlayerProxy::enterFullscreen(CompletionHandler&& completionHandler)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [274089] trunk/Source
Title: [274089] trunk/Source
Revision 274089
Author stephan.sz...@sony.com
Date 2021-03-08 12:09:15 -0800 (Mon, 08 Mar 2021)
Log Message
[WinCairo] Builds with ENABLE_CONTEXT_MENUS=OFF fail
https://bugs.webkit.org/show_bug.cgi?id=222771
Reviewed by Don Olmstead.
Build fix for turning off context menus adding ifdefs as necessary.
Source/WebKit:
* UIProcess/win/PageClientImpl.h:
* UIProcess/win/WebView.cpp:
Source/WebKitLegacy/win:
* WebCoreSupport/WebContextMenuClient.cpp:
* WebCoreSupport/WebContextMenuClient.h:
* WebView.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/win/PageClientImpl.h
trunk/Source/WebKit/UIProcess/win/WebView.cpp
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebCoreSupport/WebContextMenuClient.cpp
trunk/Source/WebKitLegacy/win/WebCoreSupport/WebContextMenuClient.h
trunk/Source/WebKitLegacy/win/WebView.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (274088 => 274089)
--- trunk/Source/WebKit/ChangeLog 2021-03-08 19:55:56 UTC (rev 274088)
+++ trunk/Source/WebKit/ChangeLog 2021-03-08 20:09:15 UTC (rev 274089)
@@ -1,3 +1,15 @@
+2021-03-08 Stephan Szabo
+
+[WinCairo] Builds with ENABLE_CONTEXT_MENUS=OFF fail
+https://bugs.webkit.org/show_bug.cgi?id=222771
+
+Reviewed by Don Olmstead.
+
+Build fix for turning off context menus adding ifdefs as necessary.
+
+* UIProcess/win/PageClientImpl.h:
+* UIProcess/win/WebView.cpp:
+
2021-03-08 John Wilander
PCM: Align fraud prevention token naming with issue 73 in the Privacy CG repo
Modified: trunk/Source/WebKit/UIProcess/win/PageClientImpl.h (274088 => 274089)
--- trunk/Source/WebKit/UIProcess/win/PageClientImpl.h 2021-03-08 19:55:56 UTC (rev 274088)
+++ trunk/Source/WebKit/UIProcess/win/PageClientImpl.h 2021-03-08 20:09:15 UTC (rev 274089)
@@ -86,7 +86,9 @@
WebCore::IntRect rootViewToAccessibilityScreen(const WebCore::IntRect&) override;
void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled) override;
RefPtr createPopupMenuProxy(WebPageProxy&) override;
+#if ENABLE(CONTEXT_MENUS)
Ref createContextMenuProxy(WebPageProxy&, ContextMenuContextData&&, const UserData&) override;
+#endif
#if ENABLE(INPUT_TYPE_COLOR)
RefPtr createColorPicker(WebPageProxy*, const WebCore::Color& intialColor, const WebCore::IntRect&) override;
Modified: trunk/Source/WebKit/UIProcess/win/WebView.cpp (274088 => 274089)
--- trunk/Source/WebKit/UIProcess/win/WebView.cpp 2021-03-08 19:55:56 UTC (rev 274088)
+++ trunk/Source/WebKit/UIProcess/win/WebView.cpp 2021-03-08 20:09:15 UTC (rev 274089)
@@ -640,6 +640,7 @@
LRESULT WebView::onMenuCommand(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam, bool& handled)
{
+#if ENABLE(CONTEXT_MENUS)
auto hMenu = reinterpret_cast(lParam);
auto index = static_cast(wParam);
@@ -664,6 +665,14 @@
m_page->contextMenuItemSelected(item);
handled = true;
+#else
+UNUSED_PARAM(hWnd);
+UNUSED_PARAM(message);
+UNUSED_PARAM(wParam);
+UNUSED_PARAM(lParam);
+handled = false;
+#endif
+
return 0;
}
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (274088 => 274089)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2021-03-08 19:55:56 UTC (rev 274088)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2021-03-08 20:09:15 UTC (rev 274089)
@@ -1,3 +1,16 @@
+2021-03-08 Stephan Szabo
+
+[WinCairo] Builds with ENABLE_CONTEXT_MENUS=OFF fail
+https://bugs.webkit.org/show_bug.cgi?id=222771
+
+Reviewed by Don Olmstead.
+
+Build fix for turning off context menus adding ifdefs as necessary.
+
+* WebCoreSupport/WebContextMenuClient.cpp:
+* WebCoreSupport/WebContextMenuClient.h:
+* WebView.cpp:
+
2021-03-05 Don Olmstead
[CMake] Bump cmake_minimum_required version to 3.12 or later
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebContextMenuClient.cpp (274088 => 274089)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebContextMenuClient.cpp 2021-03-08 19:55:56 UTC (rev 274088)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebContextMenuClient.cpp 2021-03-08 20:09:15 UTC (rev 274089)
@@ -33,6 +33,7 @@
#include
#include
+#if ENABLE(CONTEXT_MENUS)
WebContextMenuClient::WebContextMenuClient(WebView* webView)
: m_webView(webView)
{
@@ -84,3 +85,5 @@
notImplemented();
return false;
}
+#endif
+
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebContextMenuClient.h (274088 => 274089)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebContextMenuClient.h 2021-03-08 19:55:56 UTC (rev 274088)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebContextMenuClient.h 2021-03-08 20:09:15 UTC (rev 274089)
@@ -29,6 +29,8 @@
#include
#include
+#if ENABLE(CONTEXT_MENUS)
+
class WebView;
class WebContextMenuClient : public WebCore::ContextMen
[webkit-changes] [274128] trunk/Tools
Title: [274128] trunk/Tools Revision 274128 Author stephan.sz...@sony.com Date 2021-03-08 18:44:59 -0800 (Mon, 08 Mar 2021) Log Message TestWebKitAPI WebKit.HitTestResultNodeHandle does not complete with ENABLE_CONTEXT_MENUS=OFF https://bugs.webkit.org/show_bug.cgi?id=222938 Reviewed by Ross Kirsling. Make the test only build with context menus are supported. * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp: * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp: Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp trunk/Tools/TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp Diff Modified: trunk/Tools/ChangeLog (274127 => 274128) --- trunk/Tools/ChangeLog 2021-03-09 02:10:09 UTC (rev 274127) +++ trunk/Tools/ChangeLog 2021-03-09 02:44:59 UTC (rev 274128) @@ -1,3 +1,15 @@ +2021-03-08 Stephan Szabo + +TestWebKitAPI WebKit.HitTestResultNodeHandle does not complete with ENABLE_CONTEXT_MENUS=OFF +https://bugs.webkit.org/show_bug.cgi?id=222938 + +Reviewed by Ross Kirsling. + +Make the test only build with context menus are supported. + +* TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp: +* TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp: + 2021-03-08 Jonathan Bedard [webkitscmpy] Isolate dateutil imports Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp (274127 => 274128) --- trunk/Tools/TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp 2021-03-09 02:10:09 UTC (rev 274127) +++ trunk/Tools/TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp 2021-03-09 02:44:59 UTC (rev 274128) @@ -27,6 +27,8 @@ #if WK_HAVE_C_SPI +#if ENABLE(CONTEXT_MENUS) + #include "PlatformUtilities.h" #include "PlatformWebView.h" #include @@ -89,5 +91,6 @@ } } // namespace TestWebKitAPI +#endif #endif Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp (274127 => 274128) --- trunk/Tools/TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp 2021-03-09 02:10:09 UTC (rev 274127) +++ trunk/Tools/TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp 2021-03-09 02:44:59 UTC (rev 274128) @@ -27,6 +27,8 @@ #if WK_HAVE_C_SPI +#if ENABLE(CONTEXT_MENUS) + #include "InjectedBundleTest.h" #include "InjectedBundleController.h" #include "PlatformUtilities.h" @@ -69,3 +71,5 @@ } // namespace TestWebKitAPI #endif + +#endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [274135] trunk/Tools
Title: [274135] trunk/Tools
Revision 274135
Author stephan.sz...@sony.com
Date 2021-03-08 21:40:29 -0800 (Mon, 08 Mar 2021)
Log Message
[PlayStation] Various small fixes for TestWTF/TestWebKit tests on PlayStation
https://bugs.webkit.org/show_bug.cgi?id=222931
Reviewed by Don Olmstead.
* TestWebKitAPI/PlatformPlayStation.cmake: Link to API for process termination
* TestWebKitAPI/Tests/WTF/DataMutex.cpp: Turn off test using ASSERT_DEATH
* TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp: Use PlayStation api to kill webprocess for this test
* TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp: Set size in resizeTo
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake
trunk/Tools/TestWebKitAPI/Tests/WTF/DataMutex.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp
trunk/Tools/TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp
Diff
Modified: trunk/Tools/ChangeLog (274134 => 274135)
--- trunk/Tools/ChangeLog 2021-03-09 05:24:29 UTC (rev 274134)
+++ trunk/Tools/ChangeLog 2021-03-09 05:40:29 UTC (rev 274135)
@@ -1,5 +1,17 @@
2021-03-08 Stephan Szabo
+[PlayStation] Various small fixes for TestWTF/TestWebKit tests on PlayStation
+https://bugs.webkit.org/show_bug.cgi?id=222931
+
+Reviewed by Don Olmstead.
+
+* TestWebKitAPI/PlatformPlayStation.cmake: Link to API for process termination
+* TestWebKitAPI/Tests/WTF/DataMutex.cpp: Turn off test using ASSERT_DEATH
+* TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp: Use PlayStation api to kill webprocess for this test
+* TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp: Set size in resizeTo
+
+2021-03-08 Stephan Szabo
+
TestWebKitAPI WebKit.HitTestResultNodeHandle does not complete with ENABLE_CONTEXT_MENUS=OFF
https://bugs.webkit.org/show_bug.cgi?id=222938
Modified: trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake (274134 => 274135)
--- trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake 2021-03-09 05:24:29 UTC (rev 274134)
+++ trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake 2021-03-09 05:40:29 UTC (rev 274135)
@@ -38,6 +38,10 @@
Tests/WebKit/ForceRepaint.cpp
Tests/WebKit/Geolocation.cpp
)
+
+list(APPEND TestWebKit_PRIVATE_LIBRARIES
+WebKitRequirements::ProcessLauncher
+)
endif ()
# Set the debugger working directory for Visual Studio
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/DataMutex.cpp (274134 => 274135)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/DataMutex.cpp 2021-03-09 05:24:29 UTC (rev 274134)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/DataMutex.cpp 2021-03-09 05:40:29 UTC (rev 274135)
@@ -62,6 +62,8 @@
}
}
+// FIXME: Tests using ASSERT_DEATH currently panic on playstation
+#if !PLATFORM(PLAYSTATION)
TEST(WTF_DataMutex, RunUnlockedIllegalAccessDeathTest)
{
::testing::FLAGS_gtest_death_test_style = "threadsafe";
@@ -81,5 +83,6 @@
DataMutex::LockedWrapper wrapper1(myDataMutex);
ASSERT_DEATH(DataMutex::LockedWrapper wrapper2(myDataMutex), "");
}
+#endif
} // namespace TestWebKitAPI
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp (274134 => 274135)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp 2021-03-09 05:24:29 UTC (rev 274134)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp 2021-03-09 05:40:29 UTC (rev 274135)
@@ -34,6 +34,10 @@
#include
#include
+#if PLATFORM(PLAYSTATION)
+#include
+#endif
+
namespace TestWebKitAPI {
static bool loadBeforeCrash = false;
@@ -137,7 +141,11 @@
while (!WKPageGetFocusedFrame(webView.page()))
Util::spinRunLoop(10);
+#if PLATFORM(PLAYSTATION)
+PlayStation::terminateProcess(WKPageGetProcessIdentifier(webView.page()));
+#else
kill(WKPageGetProcessIdentifier(webView.page()), 9);
+#endif
Util::run(&calledCrashHandler);
}
Modified: trunk/Tools/TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp (274134 => 274135)
--- trunk/Tools/TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp 2021-03-09 05:24:29 UTC (rev 274134)
+++ trunk/Tools/TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp 2021-03-09 05:40:29 UTC (rev 274135)
@@ -72,7 +72,7 @@
void PlatformWebView::resizeTo(unsigned width, unsigned height)
{
-// Not implemented.
+WKViewSetSize(m_view, WKSizeMake(width, height));
}
WKPageRef PlatformWebView::page() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264121] trunk/Source/WebCore
Title: [264121] trunk/Source/WebCore
Revision 264121
Author stephan.sz...@sony.com
Date 2020-07-08 11:39:22 -0700 (Wed, 08 Jul 2020)
Log Message
[PlayStation] Build fix after r264050
https://bugs.webkit.org/show_bug.cgi?id=214091
Unreviewed build fix
No new tests, only build fix.
* platform/playstation/ScrollbarThemePlayStation.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (264120 => 264121)
--- trunk/Source/WebCore/ChangeLog 2020-07-08 18:30:44 UTC (rev 264120)
+++ trunk/Source/WebCore/ChangeLog 2020-07-08 18:39:22 UTC (rev 264121)
@@ -1,3 +1,14 @@
+2020-07-08 Stephan Szabo
+
+[PlayStation] Build fix after r264050
+https://bugs.webkit.org/show_bug.cgi?id=214091
+
+Unreviewed build fix
+
+No new tests, only build fix.
+
+* platform/playstation/ScrollbarThemePlayStation.cpp:
+
2020-07-08 Sihui Liu
Text manipulation should ignore white spaces between nodes
Modified: trunk/Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp (264120 => 264121)
--- trunk/Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp 2020-07-08 18:30:44 UTC (rev 264120)
+++ trunk/Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp 2020-07-08 18:39:22 UTC (rev 264121)
@@ -75,7 +75,7 @@
void ScrollbarThemePlayStation::paintTrackBackground(GraphicsContext& context, Scrollbar& scrollbar, const IntRect& trackRect)
{
-context.fillRect(trackRect, scrollbar.enabled() ? Color::lightGray : Color(0xFFE0E0E0));
+context.fillRect(trackRect, scrollbar.enabled() ? Color::lightGray : Color(makeSimpleColor(0xE0, 0xE0, 0xE0)));
}
void ScrollbarThemePlayStation::paintThumb(GraphicsContext& context, Scrollbar& scrollbar, const IntRect& thumbRect)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264142] trunk/Tools
Title: [264142] trunk/Tools
Revision 264142
Author stephan.sz...@sony.com
Date 2020-07-08 17:14:42 -0700 (Wed, 08 Jul 2020)
Log Message
[Windows] Fix errors from calls to uname when not available
https://bugs.webkit.org/show_bug.cgi?id=214101
Reviewed by Darin Adler.
As bare windows doesn't default to having uname, avoid calls
to it for architecture determination.
* Scripts/webkitdirs.pm:
Do not call uname on windows (non-cygwin) perl
* Scripts/webkitpy/common/system/platforminfo.py:
Do not call uname for windows (non-cygwin) python,
os.uname() also doesn't necessarily exist there,
so use platform.uname() instead.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py
Diff
Modified: trunk/Tools/ChangeLog (264141 => 264142)
--- trunk/Tools/ChangeLog 2020-07-08 23:47:11 UTC (rev 264141)
+++ trunk/Tools/ChangeLog 2020-07-09 00:14:42 UTC (rev 264142)
@@ -1,3 +1,20 @@
+2020-07-08 Stephan Szabo
+
+[Windows] Fix errors from calls to uname when not available
+https://bugs.webkit.org/show_bug.cgi?id=214101
+
+Reviewed by Darin Adler.
+
+As bare windows doesn't default to having uname, avoid calls
+to it for architecture determination.
+
+* Scripts/webkitdirs.pm:
+ Do not call uname on windows (non-cygwin) perl
+* Scripts/webkitpy/common/system/platforminfo.py:
+ Do not call uname for windows (non-cygwin) python,
+ os.uname() also doesn't necessarily exist there,
+ so use platform.uname() instead.
+
2020-07-08 Chris Dumez
ASSERTION FAILURE: Completion handlers not invalidated when WebPage::~WebPage() invoked navigating to docs.google.com and signing in
Modified: trunk/Tools/Scripts/webkitdirs.pm (264141 => 264142)
--- trunk/Tools/Scripts/webkitdirs.pm 2020-07-08 23:47:11 UTC (rev 264141)
+++ trunk/Tools/Scripts/webkitdirs.pm 2020-07-09 00:14:42 UTC (rev 264142)
@@ -360,11 +360,11 @@
my $output;
if ($target eq "") {
-$output = `uname -m`;
+$output = `uname -m` unless isWindows();
} else {
$output = `ssh -o NoHostAuthenticationForLocalhost=yes -p $port $target 'uname -m'`;
}
-chomp $output;
+chomp $output if defined $output;
$output = "x86_64" if (not defined $output);
# FIXME: Remove this when is resolved
Modified: trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py (264141 => 264142)
--- trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py 2020-07-08 23:47:11 UTC (rev 264141)
+++ trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py 2020-07-09 00:14:42 UTC (rev 264142)
@@ -31,6 +31,7 @@
import logging
import re
import sys
+import platform
from webkitpy.common.memoized import memoized
from webkitpy.common.version import Version
@@ -109,6 +110,11 @@
@memoized
def architecture(self):
try:
+# Windows doesn't have built in uname, nor guarantee of
+# os.uname()
+if os.name == 'nt':
+return platform.uname()[4]
+
# os.uname() won't work on embedded devices, we may support multiple architectures for a single embedded platform
output = self._executive.run_command(['uname', '-m']).rstrip()
if output:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264419] trunk/Source/WebCore
Title: [264419] trunk/Source/WebCore Revision 264419 Author stephan.sz...@sony.com Date 2020-07-15 14:15:16 -0700 (Wed, 15 Jul 2020) Log Message [PlayStation] Build fix after r264213 https://bugs.webkit.org/show_bug.cgi?id=214373 Unreviewed build fix No new tests, build fix only * PlatformPlayStation.cmake: Stop compiling UserAgentQuirks Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformPlayStation.cmake Diff Modified: trunk/Source/WebCore/ChangeLog (264418 => 264419) --- trunk/Source/WebCore/ChangeLog 2020-07-15 20:28:06 UTC (rev 264418) +++ trunk/Source/WebCore/ChangeLog 2020-07-15 21:15:16 UTC (rev 264419) @@ -1,3 +1,14 @@ +2020-07-15 Stephan Szabo + +[PlayStation] Build fix after r264213 +https://bugs.webkit.org/show_bug.cgi?id=214373 + +Unreviewed build fix + +No new tests, build fix only + +* PlatformPlayStation.cmake: Stop compiling UserAgentQuirks + 2020-07-15 Daniel Bates [iOS] Caret should be before text placeholder instead of after it Modified: trunk/Source/WebCore/PlatformPlayStation.cmake (264418 => 264419) --- trunk/Source/WebCore/PlatformPlayStation.cmake 2020-07-15 20:28:06 UTC (rev 264418) +++ trunk/Source/WebCore/PlatformPlayStation.cmake 2020-07-15 21:15:16 UTC (rev 264419) @@ -29,7 +29,6 @@ platform/ScrollAnimationKinetic.cpp platform/ScrollAnimationSmooth.cpp -platform/UserAgentQuirks.cpp platform/generic/KeyedDecoderGeneric.cpp platform/generic/KeyedEncoderGeneric.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258907] trunk/Source/WebCore
Title: [258907] trunk/Source/WebCore Revision 258907 Author stephan.sz...@sony.com Date 2020-03-23 21:51:34 -0700 (Mon, 23 Mar 2020) Log Message [WinCairo][PlayStation] Failure to build with ENABLE_XSLT=OFF https://bugs.webkit.org/show_bug.cgi?id=209454 Reviewed by Ross Kirsling. No new tests, build fix. * xml/parser/XMLDocumentParserLibxml2.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (258906 => 258907) --- trunk/Source/WebCore/ChangeLog 2020-03-24 04:48:49 UTC (rev 258906) +++ trunk/Source/WebCore/ChangeLog 2020-03-24 04:51:34 UTC (rev 258907) @@ -1,3 +1,14 @@ +2020-03-23 Stephan Szabo + +[WinCairo][PlayStation] Failure to build with ENABLE_XSLT=OFF +https://bugs.webkit.org/show_bug.cgi?id=209454 + +Reviewed by Ross Kirsling. + +No new tests, build fix. + +* xml/parser/XMLDocumentParserLibxml2.cpp: + 2020-03-23 Zalan Bujtas becu.org: Placeholder text "Search" is cut off Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp (258906 => 258907) --- trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2020-03-24 04:48:49 UTC (rev 258906) +++ trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2020-03-24 04:51:34 UTC (rev 258907) @@ -42,6 +42,7 @@ #include "HTTPParsers.h" #include "InlineClassicScript.h" #include "MIMETypeRegistry.h" +#include "PageConsoleClient.h" #include "PendingScript.h" #include "ProcessingInstruction.h" #include "ResourceError.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259755] trunk
Title: [259755] trunk
Revision 259755
Author stephan.sz...@sony.com
Date 2020-04-08 14:06:36 -0700 (Wed, 08 Apr 2020)
Log Message
[PlayStation] Update import of libdl stubs for new Angle dladdr use
https://bugs.webkit.org/show_bug.cgi?id=210200
Reviewed by Don Olmstead.
* Source/cmake/OptionsPlayStation.cmake:
Use find_package to get libdl wrappers on playstation, include
them in both executables and shared libraries.
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsPlayStation.cmake
Diff
Modified: trunk/ChangeLog (259754 => 259755)
--- trunk/ChangeLog 2020-04-08 20:54:14 UTC (rev 259754)
+++ trunk/ChangeLog 2020-04-08 21:06:36 UTC (rev 259755)
@@ -1,3 +1,14 @@
+2020-04-08 Stephan Szabo
+
+[PlayStation] Update import of libdl stubs for new Angle dladdr use
+https://bugs.webkit.org/show_bug.cgi?id=210200
+
+Reviewed by Don Olmstead.
+
+* Source/cmake/OptionsPlayStation.cmake:
+Use find_package to get libdl wrappers on playstation, include
+them in both executables and shared libraries.
+
2020-04-08 Truitt Savell
Unreviewed, reverting r259708.
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (259754 => 259755)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2020-04-08 20:54:14 UTC (rev 259754)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2020-04-08 21:06:36 UTC (rev 259755)
@@ -188,13 +188,10 @@
add_definitions(/MP)
endif ()
-find_library(DL_LIBRARY NAMES dl PATHS ${WEBKIT_LIBRARIES_DIR}/lib)
-if (DL_LIBRARY)
-add_link_options("$<$,EXECUTABLE>:${DL_LIBRARY}>")
-add_link_options("$<$,EXECUTABLE>:-Wl,--wrap=dlopen>")
-add_link_options("$<$,EXECUTABLE>:-Wl,--wrap=dlclose>")
-add_link_options("$<$,EXECUTABLE>:-Wl,--wrap=dlerror>")
-add_link_options("$<$,EXECUTABLE>:-Wl,--wrap=dlsym>")
+find_package(libdl)
+if (TARGET libdl::dl)
+add_link_options("$<$,EXECUTABLE>,$,SHARED_LIBRARY>>:$>")
+add_link_options("$<$,EXECUTABLE>,$,SHARED_LIBRARY>>:$>")
endif ()
function(add_library target type)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [260387] trunk
Title: [260387] trunk Revision 260387 Author stephan.sz...@sony.com Date 2020-04-20 12:37:03 -0700 (Mon, 20 Apr 2020) Log Message [PlayStation] Fix build after r260277 https://bugs.webkit.org/show_bug.cgi?id=210756 Reviewed by Don Olmstead. Source/WebKit: Build fix, no new tests. * PlatformPlayStation.cmake: Tools: * TestWebKitAPI/PlatformPlayStation.cmake: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/PlatformPlayStation.cmake trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake Diff Modified: trunk/Source/WebKit/ChangeLog (260386 => 260387) --- trunk/Source/WebKit/ChangeLog 2020-04-20 19:35:22 UTC (rev 260386) +++ trunk/Source/WebKit/ChangeLog 2020-04-20 19:37:03 UTC (rev 260387) @@ -1,3 +1,14 @@ +2020-04-20 Stephan Szabo + +[PlayStation] Fix build after r260277 +https://bugs.webkit.org/show_bug.cgi?id=210756 + +Reviewed by Don Olmstead. + +Build fix, no new tests. + +* PlatformPlayStation.cmake: + 2020-04-20 Chris Dumez Sending beacons when Fetch KeepAlive feature is disabled crashes the WebProcess Modified: trunk/Source/WebKit/PlatformPlayStation.cmake (260386 => 260387) --- trunk/Source/WebKit/PlatformPlayStation.cmake 2020-04-20 19:35:22 UTC (rev 260386) +++ trunk/Source/WebKit/PlatformPlayStation.cmake 2020-04-20 19:37:03 UTC (rev 260387) @@ -162,4 +162,5 @@ # so they are added here. list(APPEND WebKit_PRIVATE_LIBRARIES $ +$ ) Modified: trunk/Tools/ChangeLog (260386 => 260387) --- trunk/Tools/ChangeLog 2020-04-20 19:35:22 UTC (rev 260386) +++ trunk/Tools/ChangeLog 2020-04-20 19:37:03 UTC (rev 260387) @@ -1,3 +1,12 @@ +2020-04-20 Stephan Szabo + +[PlayStation] Fix build after r260277 +https://bugs.webkit.org/show_bug.cgi?id=210756 + +Reviewed by Don Olmstead. + +* TestWebKitAPI/PlatformPlayStation.cmake: + 2020-04-20 Wenson Hsieh Oversized caret and selection rects in text fields on ganji.com and netflix.com/login Modified: trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake (260386 => 260387) --- trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake 2020-04-20 19:35:22 UTC (rev 260386) +++ trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake 2020-04-20 19:37:03 UTC (rev 260387) @@ -27,6 +27,7 @@ # so they are added here. list(APPEND TestWebCore_PRIVATE_LIBRARIES $ +$ ) # TestWebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [260391] trunk/Source/WebKit
Title: [260391] trunk/Source/WebKit
Revision 260391
Author stephan.sz...@sony.com
Date 2020-04-20 13:09:47 -0700 (Mon, 20 Apr 2020)
Log Message
Fix build when !ENABLE(RESOURCE_LOAD_STATISTICS)
https://bugs.webkit.org/show_bug.cgi?id=210757
Reviewed by Ross Kirsling.
Build fix, no new tests
* NetworkProcess/NetworkDataTask.cpp:
Add ENABLE(RESOURCE_LOAD_STATISTICS) around block
using NetworkSession functions only declared when
that is enabled.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (260390 => 260391)
--- trunk/Source/WebKit/ChangeLog 2020-04-20 20:04:49 UTC (rev 260390)
+++ trunk/Source/WebKit/ChangeLog 2020-04-20 20:09:47 UTC (rev 260391)
@@ -1,3 +1,17 @@
+2020-04-20 Stephan Szabo
+
+Fix build when !ENABLE(RESOURCE_LOAD_STATISTICS)
+https://bugs.webkit.org/show_bug.cgi?id=210757
+
+Reviewed by Ross Kirsling.
+
+Build fix, no new tests
+
+* NetworkProcess/NetworkDataTask.cpp:
+Add ENABLE(RESOURCE_LOAD_STATISTICS) around block
+using NetworkSession functions only declared when
+that is enabled.
+
2020-04-20 Alex Christensen
When SpeculativeLoadManager is destroyed, properly clean up its PendingFrameLoads
Modified: trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp (260390 => 260391)
--- trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp 2020-04-20 20:04:49 UTC (rev 260390)
+++ trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp 2020-04-20 20:09:47 UTC (rev 260391)
@@ -178,8 +178,10 @@
void NetworkDataTask::restrictRequestReferrerToOriginIfNeeded(WebCore::ResourceRequest& request)
{
+#if ENABLE(RESOURCE_LOAD_STATISTICS)
if ((m_session->sessionID().isEphemeral() || m_session->isResourceLoadStatisticsEnabled()) && m_session->shouldDowngradeReferrer() && isThirdPartyRequest(request))
request.setExistingHTTPReferrerToOriginString();
+#endif
}
} // namespace WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [260487] trunk/Source/WebKit
Title: [260487] trunk/Source/WebKit
Revision 260487
Author stephan.sz...@sony.com
Date 2020-04-21 19:03:12 -0700 (Tue, 21 Apr 2020)
Log Message
[PlayStation] Fix GPU Process build for VIDEO_PRESENTATION_MODE changes
https://bugs.webkit.org/show_bug.cgi?id=210836
Reviewed by Darin Adler.
Build fix, no new tests.
* GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (260486 => 260487)
--- trunk/Source/WebKit/ChangeLog 2020-04-22 01:54:13 UTC (rev 260486)
+++ trunk/Source/WebKit/ChangeLog 2020-04-22 02:03:12 UTC (rev 260487)
@@ -1,3 +1,14 @@
+2020-04-21 Stephan Szabo
+
+[PlayStation] Fix GPU Process build for VIDEO_PRESENTATION_MODE changes
+https://bugs.webkit.org/show_bug.cgi?id=210836
+
+Reviewed by Darin Adler.
+
+Build fix, no new tests.
+
+* GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp:
+
2020-04-21 Peng Liu
Fix MACCATALYST build failures
Modified: trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp (260486 => 260487)
--- trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp 2020-04-22 01:54:13 UTC (rev 260486)
+++ trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp 2020-04-22 02:03:12 UTC (rev 260487)
@@ -48,6 +48,7 @@
notImplemented();
}
+#if ENABLE(VIDEO_PRESENTATION_MODE)
void RemoteMediaPlayerProxy::enterFullscreen(CompletionHandler&& completionHandler)
{
notImplemented();
@@ -57,6 +58,7 @@
{
notImplemented();
}
+#endif
} // namespace WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [263220] trunk/Source/WebCore
Title: [263220] trunk/Source/WebCore
Revision 263220
Author stephan.sz...@sony.com
Date 2020-06-18 10:45:03 -0700 (Thu, 18 Jun 2020)
Log Message
[PlayStation] Build fix for errors with structured bindings to const structure
https://bugs.webkit.org/show_bug.cgi?id=213323
Reviewed by Fujii Hironori.
Our system seems to have trouble with these structured bindings,
similar to what was previously seen for clang-cl.
No new tests, build fix.
* inspector/agents/InspectorNetworkAgent.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (263219 => 263220)
--- trunk/Source/WebCore/ChangeLog 2020-06-18 17:42:43 UTC (rev 263219)
+++ trunk/Source/WebCore/ChangeLog 2020-06-18 17:45:03 UTC (rev 263220)
@@ -1,3 +1,17 @@
+2020-06-18 Stephan Szabo
+
+[PlayStation] Build fix for errors with structured bindings to const structure
+https://bugs.webkit.org/show_bug.cgi?id=213323
+
+Reviewed by Fujii Hironori.
+
+Our system seems to have trouble with these structured bindings,
+similar to what was previously seen for clang-cl.
+
+No new tests, build fix.
+
+* inspector/agents/InspectorNetworkAgent.cpp:
+
2020-06-18 Youenn Fablet
REGRESSION (r263098): [Win10] http/tests/security/cross-origin-clean-css-resource-timing.html and http/tests/security/cross-origin-css-resource-timing.html are failing
Modified: trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp (263219 => 263220)
--- trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp 2020-06-18 17:42:43 UTC (rev 263219)
+++ trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp 2020-06-18 17:45:03 UTC (rev 263220)
@@ -1186,10 +1186,10 @@
request.setHTTPMethod(*method);
if (headers) {
HTTPHeaderMap explicitHeaders;
-for (auto& [key, value] : *headers) {
+for (auto& header : *headers) {
String headerValue;
-if (value->asString(headerValue))
-explicitHeaders.add(key, headerValue);
+if (header.value->asString(headerValue))
+explicitHeaders.add(header.key, headerValue);
}
request.setHTTPHeaderFields(WTFMove(explicitHeaders));
}
@@ -1283,10 +1283,10 @@
response.setHTTPStatusCode(status);
response.setHTTPStatusText(statusText);
HTTPHeaderMap explicitHeaders;
-for (auto& [key, value] : headers) {
+for (auto& header : headers) {
String headerValue;
-if (value->asString(headerValue))
-explicitHeaders.add(key, headerValue);
+if (header.value->asString(headerValue))
+explicitHeaders.add(header.key, headerValue);
}
response.setHTTPHeaderFields(WTFMove(explicitHeaders));
response.setHTTPHeaderField(HTTPHeaderName::ContentType, response.mimeType());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [263568] trunk/Source/WebKit
Title: [263568] trunk/Source/WebKit
Revision 263568
Author stephan.sz...@sony.com
Date 2020-06-26 10:16:24 -0700 (Fri, 26 Jun 2020)
Log Message
[WinCairo] Cannot build without resource load statistics
https://bugs.webkit.org/show_bug.cgi?id=213534
Reviewed by Don Olmstead.
Build fix for !ENABLE(RESOURCE_LOAD_STATISTICS)
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (263567 => 263568)
--- trunk/Source/WebKit/ChangeLog 2020-06-26 17:00:50 UTC (rev 263567)
+++ trunk/Source/WebKit/ChangeLog 2020-06-26 17:16:24 UTC (rev 263568)
@@ -1,3 +1,15 @@
+2020-06-26 Stephan Szabo
+
+[WinCairo] Cannot build without resource load statistics
+https://bugs.webkit.org/show_bug.cgi?id=213534
+
+Reviewed by Don Olmstead.
+
+Build fix for !ENABLE(RESOURCE_LOAD_STATISTICS)
+
+* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+
2020-06-25 Alex Christensen
WKHTTPCookieStore.setCookie should flush the cookies to disk before calling completion handler when we are using the UIProcess's default cookie storage
Modified: trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp (263567 => 263568)
--- trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp 2020-06-26 17:00:50 UTC (rev 263567)
+++ trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp 2020-06-26 17:16:24 UTC (rev 263568)
@@ -70,6 +70,7 @@
void WKWebsiteDataStoreRemoveITPDataForDomain(WKWebsiteDataStoreRef dataStoreRef, WKStringRef host, void* context, WKWebsiteDataStoreRemoveITPDataForDomainFunction callback)
{
+#if ENABLE(RESOURCE_LOAD_STATISTICS)
WebKit::WebsiteDataRecord dataRecord;
dataRecord.types.add(WebKit::WebsiteDataType::ResourceLoadStatistics);
dataRecord.addResourceLoadStatisticsRegistrableDomain(WebCore::RegistrableDomain::uncheckedCreateFromHost(WebKit::toImpl(host)->string()));
@@ -79,6 +80,9 @@
WebKit::toImpl(dataStoreRef)->removeData(dataTypes, dataRecords, [context, callback] {
callback(context);
});
+#else
+callback(context);
+#endif
}
void WKWebsiteDataStoreDoesStatisticsDomainIDExistInDatabase(WKWebsiteDataStoreRef dataStoreRef, int domainID, void* context, WKWebsiteDataStoreDoesStatisticsDomainIDExistInDatabaseFunction callback)
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (263567 => 263568)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2020-06-26 17:00:50 UTC (rev 263567)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2020-06-26 17:16:24 UTC (rev 263568)
@@ -1010,8 +1010,10 @@
cookieHostNames.append(hostName);
for (auto& hostName : dataRecord.HSTSCacheHostNames)
HSTSCacheHostNames.append(hostName);
+#if ENABLE(RESOURCE_LOAD_STATISTICS)
for (auto& registrableDomain : dataRecord.resourceLoadStatisticsRegistrableDomains)
registrableDomains.append(registrableDomain);
+#endif
}
callbackAggregator->addPendingCallback();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [263616] trunk
Title: [263616] trunk
Revision 263616
Author stephan.sz...@sony.com
Date 2020-06-27 07:18:34 -0700 (Sat, 27 Jun 2020)
Log Message
[PlayStation] Update test runner for changes to Options and signing
https://bugs.webkit.org/show_bug.cgi?id=213650
Reviewed by Don Olmstead.
Source/_javascript_Core:
* shell/playstation/Initializer.cpp: Load ICU library
* shell/playstation/TestShell.cpp: Update between test options reset
Tools:
* Scripts/webkitdirs.pm: Update extension for PlayStation binary
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/playstation/Initializer.cpp
trunk/Source/_javascript_Core/shell/playstation/TestShell.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (263615 => 263616)
--- trunk/Source/_javascript_Core/ChangeLog 2020-06-27 06:17:10 UTC (rev 263615)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-06-27 14:18:34 UTC (rev 263616)
@@ -1,3 +1,13 @@
+2020-06-27 Stephan Szabo
+
+[PlayStation] Update test runner for changes to Options and signing
+https://bugs.webkit.org/show_bug.cgi?id=213650
+
+Reviewed by Don Olmstead.
+
+* shell/playstation/Initializer.cpp: Load ICU library
+* shell/playstation/TestShell.cpp: Update between test options reset
+
2020-06-26 Geoffrey Garen
Initializing the main thread should initialize the main run loop
Modified: trunk/Source/_javascript_Core/shell/playstation/Initializer.cpp (263615 => 263616)
--- trunk/Source/_javascript_Core/shell/playstation/Initializer.cpp 2020-06-27 06:17:10 UTC (rev 263615)
+++ trunk/Source/_javascript_Core/shell/playstation/Initializer.cpp 2020-06-27 14:18:34 UTC (rev 263616)
@@ -44,4 +44,5 @@
loadLibraryOrExit("Perf");
loadLibraryOrExit("PosixWebKit");
loadLibraryOrExit("libJavaScriptCore");
+loadLibraryOrExit("libicu");
}
Modified: trunk/Source/_javascript_Core/shell/playstation/TestShell.cpp (263615 => 263616)
--- trunk/Source/_javascript_Core/shell/playstation/TestShell.cpp 2020-06-27 06:17:10 UTC (rev 263615)
+++ trunk/Source/_javascript_Core/shell/playstation/TestShell.cpp 2020-06-27 14:18:34 UTC (rev 263616)
@@ -25,8 +25,21 @@
#include "../jsc.cpp"
+#include
+
+#define STATIC_OPTION(type_, name_, defaultValue_, availability_, description_) \
+static OptionsStorage::type_ orig##name_;
+FOR_EACH_JSC_OPTION(STATIC_OPTION)
+#undef STATIC_OPTION
+
extern "C" void setupTestRun()
{
+CommandLine options(0, nullptr);
+#define STATIC_OPTION(type_, name_, defaultValue_, availability_, description_) \
+orig##name_ = JSC::Options::name_();
+FOR_EACH_JSC_OPTION(STATIC_OPTION)
+#undef STATIC_OPTION
+
// Need to initialize WTF threading before we start any threads. Cannot initialize JSC
// threading yet, since that would do somethings that we'd like to defer until after we
// have a chance to parse options.
@@ -46,9 +59,10 @@
extern "C" void preTest()
{
#define INIT_OPTION(type_, name_, defaultValue_, availability_, description_) \
-JSC::Options::name_() = JSC::Options::name_##Default();
+JSC::Options::name_() = orig##name_;
FOR_EACH_JSC_OPTION(INIT_OPTION)
#undef INIT_OPTION
+overrideUserPreferredLanguages(platformUserPreferredLanguages());
}
extern "C" int runTest(int argc, char* argv[])
Modified: trunk/Tools/ChangeLog (263615 => 263616)
--- trunk/Tools/ChangeLog 2020-06-27 06:17:10 UTC (rev 263615)
+++ trunk/Tools/ChangeLog 2020-06-27 14:18:34 UTC (rev 263616)
@@ -1,3 +1,12 @@
+2020-06-27 Stephan Szabo
+
+[PlayStation] Update test runner for changes to Options and signing
+https://bugs.webkit.org/show_bug.cgi?id=213650
+
+Reviewed by Don Olmstead.
+
+* Scripts/webkitdirs.pm: Update extension for PlayStation binary
+
2020-06-26 Jonathan Bedard
[webkitpy] Allow callers to override the reported model (Part 1)
Modified: trunk/Tools/Scripts/webkitdirs.pm (263615 => 263616)
--- trunk/Tools/Scripts/webkitdirs.pm 2020-06-27 06:17:10 UTC (rev 263615)
+++ trunk/Tools/Scripts/webkitdirs.pm 2020-06-27 14:18:34 UTC (rev 263616)
@@ -502,7 +502,7 @@
my $jscName = "jsc";
$jscName .= "_debug" if configuration() eq "Debug_All";
if (isPlayStation()) {
-$jscName .= ".elf";
+$jscName .= ".self";
} elsif (isAnyWindows()) {
$jscName .= ".exe";
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [263717] trunk/Source/WebCore
Title: [263717] trunk/Source/WebCore
Revision 263717
Author stephan.sz...@sony.com
Date 2020-06-29 18:49:46 -0700 (Mon, 29 Jun 2020)
Log Message
Fix build when !ENABLE(ACCESSIBILITY) after r263673
https://bugs.webkit.org/show_bug.cgi?id=213759
Reviewed by Chris Fleizach.
No new tests, build fix.
* accessibility/AXObjectCache.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (263716 => 263717)
--- trunk/Source/WebCore/ChangeLog 2020-06-30 01:36:26 UTC (rev 263716)
+++ trunk/Source/WebCore/ChangeLog 2020-06-30 01:49:46 UTC (rev 263717)
@@ -1,3 +1,14 @@
+2020-06-29 Stephan Szabo
+
+Fix build when !ENABLE(ACCESSIBILITY) after r263673
+https://bugs.webkit.org/show_bug.cgi?id=213759
+
+Reviewed by Chris Fleizach.
+
+No new tests, build fix.
+
+* accessibility/AXObjectCache.h:
+
2020-06-29 Sam Weinig
Simplify Color's interface by removing isDark()
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (263716 => 263717)
--- trunk/Source/WebCore/accessibility/AXObjectCache.h 2020-06-30 01:36:26 UTC (rev 263716)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h 2020-06-30 01:49:46 UTC (rev 263717)
@@ -577,7 +577,7 @@
inline void AXObjectCache::frameLoadingEventPlatformNotification(AccessibilityObject*, AXLoadingEvent) { }
inline void AXObjectCache::handleActiveDescendantChanged(Node*) { }
inline void AXObjectCache::handleAriaExpandedChange(Node*) { }
-inline void AXObjectCache::handleModalChange(Element*) { }
+inline void AXObjectCache::handleModalChange(Element&) { }
inline void AXObjectCache::deferModalChange(Element*) { }
inline void AXObjectCache::handleAriaRoleChanged(Node*) { }
inline void AXObjectCache::deferAttributeChangeIfNeeded(const QualifiedName&, Element*) { }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a206f: Build fix after 289300@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a206f4e922cb22fe53a691f99ec9206743caaaf https://github.com/WebKit/WebKit/commit/1a206f4e922cb22fe53a691f99ec9206743caaaf Author: Stephan Szabo Date: 2025-01-23 (Thu, 23 Jan 2025) Changed paths: M Source/WebCore/platform/libwpe/PlatformPasteboardLibWPE.cpp Log Message: --- Build fix after 289300@main https://bugs.webkit.org/show_bug.cgi?id=286445 Reviewed by Ryosuke Niwa. Add the NOESCAPE note to PlatformPasteboardLibWPE.cpp to match changes in header. * Source/WebCore/platform/libwpe/PlatformPasteboardLibWPE.cpp: (WebCore::PlatformPasteboard::performAsDataOwner): Canonical link: https://commits.webkit.org/289325@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
