[webkit-changes] [WebKit/WebKit] ca7fae: Re-sync web-platform-tests/cookie-store from upstr...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca7faec33a9b5f82c8d4e457b071407da02f087b
  
https://github.com/WebKit/WebKit/commit/ca7faec33a9b5f82c8d4e457b071407da02f087b
  Author: Rupin Mittal 
  Date:   2024-08-07 (Wed, 07 Aug 2024)

  Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/cookie-store/META.yml
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.serviceworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.serviceworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.sharedworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.sharedworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.worker.html
R 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.html
R 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.js
R 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.serviceworker-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.serviceworker.html
R 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.sharedworker-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.sharedworker.html
R 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.worker-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.worker.html
M LayoutTests/imported/w3c/web-platform-tests/cookie-store/w3c-import.log

  Log Message:
  ---
  Re-sync web-platform-tests/cookie-store from upstream WPT
https://bugs.webkit.org/show_bug.cgi?id=277781
rdar://133420953

Reviewed by Sihui Liu.

Upstream commit: 
https://github.com/web-platform-tests/wpt/commit/fee8ca2d5f4462af5f1dd2cb31b4e38c7256f410

* LayoutTests/imported/w3c/web-platform-tests/cookie-store/META.yml:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any-expected.txt:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any-expected.txt.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.html.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.js:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.js.
(async idl_array):
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.serviceworker-expected.txt:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.serviceworker-expected.txt.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.serviceworker.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.serviceworker.html.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.sharedworker-expected.txt:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.sharedworker-expected.txt.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.sharedworker.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.sharedworker.html.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.worker-expected.txt:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.worker-expected.txt.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.worker.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.worker.html.
* LayoutTests/imported/w3c/web-platform-tests/cookie-store/w3c-import.log:

Canonical link: https://commits.webkit.org/281978@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit

[webkit-changes] [WebKit/WebKit] da6bdd: Add CookieStoreManagerEnabled feature flag

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da6bddd2e4c193b8e6aa8064ebc233d05382ec39
  
https://github.com/WebKit/WebKit/commit/da6bddd2e4c193b8e6aa8064ebc233d05382ec39
  Author: Rupin Mittal 
  Date:   2024-08-16 (Fri, 16 Aug 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Modules/cookie-store/CookieStoreManager.idl
M Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.idl
M Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl
M Source/WebCore/workers/service/ServiceWorkerRegistration.idl

  Log Message:
  ---
  Add CookieStoreManagerEnabled feature flag
https://bugs.webkit.org/show_bug.cgi?id=278245
rdar://134075274

Reviewed by Chris Dumez and Sihui Liu.

This patch adds a new feature flag that surrounds the functionality
of allowing service workers to subscribe to cookie change notifications.
Since we intend to expose the Cookie Store API to service workers, there
is no need for the CookieStoreAPIServiceWorkerEnabled flag, since we
have the CookieStoreAPIEnabled flag.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/cookie-store/CookieStoreManager.idl:
* Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.idl:
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl:
* Source/WebCore/workers/service/ServiceWorkerRegistration.idl:

Canonical link: https://commits.webkit.org/282371@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c1a5c6: Implement CookieStoreManager for the CookieStore API

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1a5c61946b9f75678be873346223d40f774f814
  
https://github.com/WebKit/WebKit/commit/c1a5c61946b9f75678be873346223d40f774f814
  Author: Rupin Mittal 
  Date:   2024-08-18 (Sun, 18 Aug 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_empty.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_empty.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_multiple.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_multiple.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_single.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_single.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_subscribe_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_subscribe_arguments.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_subscriptions_empty.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookieStore_subscriptions_reset.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookiechange_eventhandler_mismatched_subscription.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookiechange_eventhandler_multiple_subscriptions.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookiechange_eventhandler_overlapping_subscriptions.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookiechange_eventhandler_single_subscription.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_oncookiechange_eventhandler_single_subscription.https.any.serviceworker-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Headers.cmake
A Source/WebCore/Modules/cookie-store/CookieChangeSubscription.h
M Source/WebCore/Modules/cookie-store/CookieStoreGetOptions.idl
M Source/WebCore/Modules/cookie-store/CookieStoreManager.cpp
M Source/WebCore/Modules/cookie-store/CookieStoreManager.h
M Source/WebCore/Modules/cookie-store/CookieStoreManager.idl
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/workers/service/SWClientConnection.h
M Source/WebCore/workers/service/ServiceWorkerContainer.cpp
M Source/WebCore/workers/service/ServiceWorkerContainer.h
M Source/WebCore/workers/service/ServiceWorkerRegistration.cpp
M Source/WebCore/workers/service/ServiceWorkerRegistration.h
M Source/WebCore/workers/service/WorkerSWClientConnection.cpp
M Source/WebCore/workers/service/WorkerSWClientConnection.h
M Source/WebCore/workers/service/server/SWServerRegistration.cpp
M Source/WebCore/workers/service/server/SWServerRegistration.h
M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h
M 
Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp
M Source/WebKit/WebProcess/Storage/WebSWClientConnection.h

  Log Message:
  ---
  Implement CookieStoreManager for the CookieStore API
rdar://133575968
https://bugs.webkit.org/show_bug.cgi?id=277892

Reviewed by Chris Dumez.

This patch implements the CookieStoreManager which allows
Service Workers to subscribe to events on cookie changes
(https://wicg.github.io/cookie-store/#CookieStoreManager).

We implement the subscribe, unsubscribe, and getSubscriptions
functions. The list of subscriptions is stored in the Service
Worker Registration on the Network Process side. The WebProcess
sends IPC messages to alter or get a copy of the list.

This patch causes some WPT Layout Tests that were previously
failing to now pass. Some of the tests whose results changed
to timeout are timing out because they are testing the
functionality of the ExtendableCookieChangeEvent for Service
Workers which has not yet been implemented. Since we currently
don't plan on firing cookie change events to the Service Workers,
there's no plan to implement ExtendableCookieChang

[webkit-changes] [WebKit/WebKit] b1fd85: Use strongly typed identifiers for IDBObjectStore

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1fd85148bfa59caad8ef20286edb36e73256a42
  
https://github.com/WebKit/WebKit/commit/b1fd85148bfa59caad8ef20286edb36e73256a42
  Author: Rupin Mittal 
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
M LayoutTests/inspector/indexeddb/clearObjectStore-expected.txt
M LayoutTests/inspector/indexeddb/clearObjectStore.html
M LayoutTests/inspector/indexeddb/requestData-expected.txt
M LayoutTests/inspector/indexeddb/requestData.html
M LayoutTests/inspector/indexeddb/requestDatabase.html
M Source/WebCore/Headers.cmake
A Source/WebCore/Modules/indexeddb/IDBObjectStoreIdentifier.h
M Source/WebCore/Modules/indexeddb/IDBRequest.cpp
M Source/WebCore/Modules/indexeddb/IDBRequest.h
M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
M Source/WebCore/Modules/indexeddb/IDBTransaction.h
M Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp
M Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h
M Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp
M Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h
M Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h
M Source/WebCore/Modules/indexeddb/client/TransactionOperation.h
M Source/WebCore/Modules/indexeddb/server/IDBBackingStore.h
M Source/WebCore/Modules/indexeddb/server/IDBServer.cpp
M Source/WebCore/Modules/indexeddb/server/IDBServer.h
M Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp
M Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.h
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.cpp
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.h
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h
M Source/WebCore/Modules/indexeddb/shared/IDBCursorInfo.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBCursorInfo.h
M Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h
M Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.h
M Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.h
M Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.h
M Source/WebCore/Modules/indexeddb/shared/IDBRequestData.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
M Source/WebKit/Shared/WTFArgumentCoders.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp
M Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h
M Source/WebKitLegacy/Storage/InProcessIDBServer.cpp
M Source/WebKitLegacy/Storage/InProcessIDBServer.h

  Log Message:
  ---
  Use strongly typed identifiers for IDBObjectStore
https://bugs.webkit.org/show_bug.cgi?id=279098
rdar://135250696

Reviewed by Chris Dumez and Sihui Liu.

We prefer to use strongly-typed identifiers where possible.

Initially, this change caused three tests (requestData.html,
requestDatabase.html, and clearObjectStore.html) to fail. It turns
out that these tests were retrieving ObjectStores using
IDBDatabaseInfo::ObjectStoreNames() and relying on the order of the
ObjectStores being the same every time. These ObjectStores are stored
in a HashMap and this function uses a for-each loop to iterate through
the HashMap and return the ObjectStore names. But HashMaps are not
ordered and so iteration through them does not occur in any guaranteed
order. Yet these tests were relying on this iteration occuring in the
same order each time. When the identifiers changed from uint64_t to
ObjectIdentifiers, the hashes for the ObjectStores changed, and
so the ObjectStores were returned in a different order--causing
the tests to fail. Expecting iteration

[webkit-changes] [WebKit/WebKit] cd981f: Add error-checking for no arguments, empty options...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd981fa847062f9a7164e2643c3d90b5a257286d
  
https://github.com/WebKit/WebKit/commit/cd981fa847062f9a7164e2643c3d90b5a257286d
  Author: Rupin Mittal 
  Date:   2024-09-09 (Mon, 09 Sep 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any.serviceworker-expected.txt
M Source/WebCore/Modules/cookie-store/CookieStore.cpp

  Log Message:
  ---
  Add error-checking for no arguments, empty options and invalid URLs in 
CookieStore::get()
https://bugs.webkit.org/show_bug.cgi?id=279230
rdar://135373104

Reviewed by Sihui Liu.

The Cookie Store API spec specifies that if CookieStore::get()
is called with no options, a TypeError should be returned.
Also, if a URL is passed in, return TypeError if either:
(1) The global object is a Window and the URL is not the same as
the complete URL for this context (Window's base URL + URL)
(2) The complete URL for this context and URL do not have the
same origin
See (https://wicg.github.io/cookie-store/#CookieStore-get)

We already do this URL checking in CookieStore::getAll(), so
we re-use the logic here.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any.serviceworker-expected.txt:
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::get):

Canonical link: https://commits.webkit.org/283374@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a2b85: Ensure CookieStore uses the creation URL for setti...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a2b852c5d38ea4ecae01783031902f7a99d3a8b
  
https://github.com/WebKit/WebKit/commit/8a2b852c5d38ea4ecae01783031902f7a99d3a8b
  Author: Rupin Mittal 
  Date:   2024-09-11 (Wed, 11 Sep 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_creation_url.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_creation_url.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_creation_url.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_creation_url.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_creation_url.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_creation_url.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_origin.https-expected.txt
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/EmptyScriptExecutionContext.h
M Source/WebCore/dom/ScriptExecutionContext.h
M Source/WebCore/workers/WorkerGlobalScope.h
M Source/WebCore/worklets/WorkletGlobalScope.h

  Log Message:
  ---
  Ensure CookieStore uses the creation URL for setting/getting cookies
https://bugs.webkit.org/show_bug.cgi?id=279454
rdar://135730639

Reviewed by Brady Eidson.

Per the Cookie Store API spec, (https://wicg.github.io/cookie-store/), when 
setting or
getting cookies, the CookieStore should use the url passed in or setting's 
creation url.
Up till now, we were using setting's current url. This is a problem because the 
current
url can change--meaning that if the current url changes, then requests to get 
cookies
set using the preivous url will fail. The current WPT tests don't test this 
scenario.

This patch updates set(), get(), and getAll() to use the url passed in or the 
creation url.
We also add two layout tests to test the case where a cookie is set, the 
document's
current URL changes, and then there is a request to get the cookies. These 
tests fail
without the changes to set(), get(), and getAll().

There will be a future patch to the WPT repository to add the tests there.

Since the CookieStoreGetOptions passed into get() and getAll() are still sent 
over IPC
but their `url` field is not used, we set this field to a null string so that 
we are not
sending data unnecessarily. We still want to send the options because this 
object may
change in the future, so it's better practice to have the code sending it 
already.

Note that this causes the layout test cookieStore_opaque_origin.https.html to 
fail. This
test attempts to set a cookie from an iframe. Before this change, this 
succeeded because
CookieStore::get() was incorrectly using the host obtained from the iframe's 
security
origin. Since the iframe didn't have it's own security origin, it was given the 
security
origin of it's parent--so the test was able to obtain the correct host. But 
this is the
wrong method of obtaining the host. As per the spec, the host should be 
obtained from the
url. Now that we use the creation URL (which is about:srcdoc for this iframe), 
the host
is null, and the test fails.

This breakage in iframe (also occurring in 
cookieStore_get_set_across_frames.https.html)
will be fixed in the next patch that will travel up the parent tree until a 
valid creation
url is found. I didn't do this in this patch so that this patch could be small 
and focus
on switching set(), get(), and getAll() to using the creation url.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_creation_url.https.any-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_creation_url.https.any.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_creation_url.https.any.js:
 Added.
(promise_test.async testCase.async let):
(promise_test.async testCase):
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_creation_url.https.any-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_creation_url.https.any.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_creation_url.https.any.js:
 Added.
(promise_test.async testCase.async let):
(promise_test.async testCase):
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_o

[webkit-changes] [WebKit/WebKit] bdba4e: Re-add DOMWindow+CookieStore.idl after omission in...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bdba4eda037926f690b12be328953fb250695bff
  
https://github.com/WebKit/WebKit/commit/bdba4eda037926f690b12be328953fb250695bff
  Author: Rupin Mittal 
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
M Source/WebCore/WebCore.xcodeproj/project.pbxproj

  Log Message:
  ---
  Re-add DOMWindow+CookieStore.idl after omission in 277704@main
https://bugs.webkit.org/show_bug.cgi?id=279575
rdar://135850116

Reviewed by Tim Horton.

277704@main renamed LocalDOMWindow+CookieStore.idl to
DOMWindow+CookieStore.idl but didn't change this in
Source/WebCore/WebCore.xcodeproj/project.pbxproj--so the
file wasn't showing up in the Xcode editor. This patch
adds the file back in the Xcode project configuation.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/283544@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 402a27: Ensure CookieStoreManager is exposed only to Windo...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 402a2777996a7e7680023e5d3083801ab1de8d3e
  
https://github.com/WebKit/WebKit/commit/402a2777996a7e7680023e5d3083801ab1de8d3e
  Author: Rupin Mittal 
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.sharedworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.worker-expected.txt
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/workers/service/ServiceWorkerRegistration.idl

  Log Message:
  ---
  Ensure CookieStoreManager is exposed only to Window and ServiceWorker
https://bugs.webkit.org/show_bug.cgi?id=279573
rdar://135847353

Reviewed by Chris Dumez and Sihui Liu.

As per the Cookie Store API spec 
(https://wicg.github.io/cookie-store/#ServiceWorkerRegistration),
the ServiceWorkerRegistration interface gives access to a CookieStoreManager 
via cookies. This
cookies attribute should be exposed only to Window and ServiceWorker.

In order to support exposing this to ServiceWorker, we update 
CodeGeneratorJS.pm. Previously,
adding Exposed=ServiceWorker for a partial interface, or for a single attribute 
within an interface,
would result in an IDL parsing error.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.sharedworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.worker-expected.txt:
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateRuntimeEnableConditionalStringForExposeScope):
* Source/WebCore/workers/service/ServiceWorkerRegistration.idl:

Canonical link: https://commits.webkit.org/283588@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4973ae: Use a non-empty, non-'about:' cookie url when gett...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4973ae3a5e854e1e056dedcbced9c1db450bc6f0
  
https://github.com/WebKit/WebKit/commit/4973ae3a5e854e1e056dedcbced9c1db450bc6f0
  Author: Rupin Mittal 
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_origin.https-expected.txt
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/EmptyScriptExecutionContext.h
M Source/WebCore/dom/ScriptExecutionContext.h
M Source/WebCore/workers/WorkerGlobalScope.h
M Source/WebCore/worklets/WorkletGlobalScope.h

  Log Message:
  ---
  Use a non-empty, non-'about:' cookie url when getting/setting cookies in 
CookieStore
https://bugs.webkit.org/show_bug.cgi?id=279578
rdar://135853069

Reviewed by Chris Dumez and Sihui Liu.

As per the CookieStore API spec, the CookieStore uses the 
ScriptExecutionContext's
creation URL when getting/setting cookies. Two of the layout tests attempt to 
get/set
cookies from iFrames. The creation URL's for these iFrames are 'about:blank' and
'about:srcdoc'. These url's don't have hosts and so the get/set requests fail.

We fix this by using Document::cookieURL() in the Document case. The document's 
cookie
URL is set when the Document is created and never changed after that (so it 
matches the
creation URL). This works in the iFrame case because 
Document::initSecurityContext()
sets the cookieURL to the parent document's cookies URL for a Document if it
shouldInheritSecurityOriginFromOwner (which is true for iFrames).

We added ScriptExecutionContext::creationURL() in 283530@main specifically for 
getting/
setting cookies. Since Document had a creationURL() function, we wanted one in
ServiceWorkerGlobalScope so that the usage in CookieStore was consistent. Since 
we are
now using cookieURL() in Document instead of creationURL(), we want to do the 
same in
ServiceWorkerGlobalScope. So we rename ScriptExecutionContext::creationURL() to
ScriptExecutionContext::cookieURL(). So now, we use cookieURL() in both the 
Document
and Service Worker case. This works in all cases, not just for iFrames.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_origin.https-expected.txt:
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::get):
(WebCore::CookieStore::getAll):
(WebCore::CookieStore::set):
* Source/WebCore/dom/Document.h:
(WebCore::Document::creationURL const):
(WebCore::Document::cookieURL const): Deleted.
* Source/WebCore/dom/EmptyScriptExecutionContext.h:
* Source/WebCore/dom/ScriptExecutionContext.h:
* Source/WebCore/workers/WorkerGlobalScope.h:
* Source/WebCore/worklets/WorkletGlobalScope.h:

Canonical link: https://commits.webkit.org/283622@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ea42e8: Check for invalid characters in name and value whe...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea42e80465ced88ed7a4d396eb4aacffcae500f0
  
https://github.com/WebKit/WebKit/commit/ea42e80465ced88ed7a4d396eb4aacffcae500f0
  Author: Rupin Mittal 
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any.serviceworker-expected.txt
M Source/WebCore/Modules/cookie-store/CookieStore.cpp

  Log Message:
  ---
  Check for invalid characters in name and value when setting a cookie
https://bugs.webkit.org/show_bug.cgi?id=279151
rdar://135304982

Reviewed by Chris Dumez.

As per the CookieStore API spec 
(https://wicg.github.io/cookie-store/#set-a-cookie),
we must return a type error when setting a cookie if:
(1) Certain invalid characters are in the name or value
(2) Name is empty and Value contains a '=' (signifies that user is trying to set
both the name and value in the value field with "name=value" syntax)
(3) Name and Value are both empty

Currently, the WPT tests only test (2). This test was passing before this 
change--but
for the wrong reason. It was not passing because the CookieStore returns a type 
error
on empty name and '=' in value, but rather because the CookieStore allows this 
call and
eventually reaches the CFNetwork function to set a cookie--which incorrectly 
rejects
the request to set a cookie with an empty name (a bug has been filed for this).

This test for (2) now passes for the right reason, and we also add tests for 
(1) and (3).
A future patch will add them to the WPT repo as well.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any.js:
(promise_test.async testCase):
(promise_test.async testCase.async const):
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any.serviceworker-expected.txt:
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::containsInvalidCharacters):
(WebCore::CookieStore::set):

Canonical link: https://commits.webkit.org/283624@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ef7b76: Enable the Cookie Store API

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef7b76c3d42c5f4f040f4cdea76a264c13fd8ada
  
https://github.com/WebKit/WebKit/commit/ef7b76c3d42c5f4f040f4cdea76a264c13fd8ada
  Author: Rupin Mittal 
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Enable the Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=279688
rdar://135969444

Reviewed by Chris Dumez.

Turn on the feature flag for the CookieStore API on Cocoa platforms.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/283654@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 656e0b: Adopt more smart pointers in RemoteMediaPlayerMana...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 656e0b0b7ce11d7261a552cda74476edeab67380
  
https://github.com/WebKit/WebKit/commit/656e0b0b7ce11d7261a552cda74476edeab67380
  Author: Rupin Mittal 
  Date:   2024-09-16 (Mon, 16 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in RemoteMediaPlayerManagerProxy and 
RemoteMediaSourceProxy
https://bugs.webkit.org/show_bug.cgi?id=279779
rdar://136100757

Reviewed by Ryosuke Niwa.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::didReceivePlayerMessage):
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp:
(WebKit::RemoteMediaSourceProxy::waitForTarget):
(WebKit::RemoteMediaSourceProxy::seekToTime):
(WebKit::RemoteMediaSourceProxy::addSourceBuffer):
(WebKit::RemoteMediaSourceProxy::shutdown):

Canonical link: https://commits.webkit.org/283747@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b5c665: Adopt more smart pointers in RemoteCDMInstanceProx...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b5c6650e0ec320d8cb4ce92e14d45266cc65ca87
  
https://github.com/WebKit/WebKit/commit/b5c6650e0ec320d8cb4ce92e14d45266cc65ca87
  Author: Rupin Mittal 
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp
M Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxy.h
M 
Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp

  Log Message:
  ---
  Adopt more smart pointers in RemoteCDMInstanceProxy and 
RemoteVideoFrameObjectHeap
https://bugs.webkit.org/show_bug.cgi?id=279785
rdar://136103868

Reviewed by Chris Dumez.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.cpp:
(WebKit::RemoteCDMInstanceProxy::unrequestedInitializationDataReceived):
* Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
(WebKit::remoteVideoFrameObjectHeapQueueSingleton):
(WebKit::RemoteVideoFrameObjectHeap::create):
(WebKit::RemoteVideoFrameObjectHeap::releaseVideoFrame):
(WebKit::RemoteVideoFrameObjectHeap::getVideoFrameBuffer):
(WebKit::RemoteVideoFrameObjectHeap::pixelBuffer):
(WebKit::remoteVideoFrameObjectHeapQueue): Deleted.
* Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxy.h:
* 
Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
(WebKit::RemoteVideoFrameObjectHeapProxyProcessor::gpuProcessConnectionDidClose):
(WebKit::RemoteVideoFrameObjectHeapProxyProcessor::getNativeImage):

Canonical link: https://commits.webkit.org/283775@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 27bb6f: Add IDL files and empty implementation to support ...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 27bb6fc299f4133ec433d4fb49a3adeaf5cf9e87
  
https://github.com/WebKit/WebKit/commit/27bb6fc299f4133ec433d4fb49a3adeaf5cf9e87
  Author: Rupin Mittal 
  Date:   2023-08-24 (Thu, 24 Aug 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieListItem_attributes.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_empty.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_empty.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_multiple.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_multiple.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_single.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStoreManager_getSubscriptions_single.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_basic.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_delete_basic.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_basic.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_ordering.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_subscribe_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_subscribe_arguments.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_subscriptions_empty.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/encoding.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.sharedworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookieStore_subscriptions_reset.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookiechange_eventhandler_mismatched_subscription.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookiechange_eventhandler_multiple_subscriptions.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookiechange_eventhandler_overlapping_subscriptions.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookiechange_eventhandler_single_subscription.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/serviceworker_oncookiechange_eventhandler_single_subscription.https.any.serviceworker-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
M Source/WebCore/Modules/cookie-store/CookieChangeEvent.cpp
M Source/WebCore/Modules/cookie-store/CookieChangeEvent.h
M Source/WebCore/Modules/cookie-store/CookieStore.h
M Source

[webkit-changes] [WebKit/WebKit] 2ecb71: Implement the Cookie Store API get/set/delete func...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ecb71d1b38b5f41d1c2cfd7baf45972e01c76d7
  
https://github.com/WebKit/WebKit/commit/2ecb71d1b38b5f41d1c2cfd7baf45972e01c76d7
  Author: Rupin Mittal 
  Date:   2023-09-16 (Sat, 16 Sep 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieListItem_attributes.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_basic.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_delete_basic.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_basic.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_ordering.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_origin.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/encoding.https.any.serviceworker-expected.txt
M Source/WebCore/Modules/cookie-store/CookieInit.h
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/Modules/cookie-store/CookieStore.h
M Source/WebCore/Modules/cookie-store/CookieStoreGetOptions.h
M Source/WebCore/loader/CookieJar.cpp
M Source/WebCore/platform/Cookie.h
M Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp

  Log Message:
  ---
  Implement the Cookie Store API get/set/delete functions for Service Workers
https://bugs.webkit.org/show_bug.cgi?id=260737

Reviewed by Chris Dumez.

The Cookie Store API should be supported for Service Workers. This patch
adds Service Worker support for the get/set/delete cookie functions.
The Cookie Store is now created using a ScriptExecutionContext rather
the CookieJar where needed.

Since get/set/delete are called through the CookieJar, and CookieJar is
a main thread object, we now have a CookieStore::MainThreadBridge which
is used to hop between the main thread and the service worker thread
when needed. This will also be used for cookie change notifications in
a future patch.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieListItem_attributes.https.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_basic.https.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_delete_basic.https.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_basic.https.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_ordering.https.any.serviceworker-expected.txt:
* 
LayoutTests

[webkit-changes] [WebKit/WebKit] d725cb: Add a new email for Rupin Mittal to contributors.json

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d725cbd9692926baf17bf56ed46a385a7113d32d
  
https://github.com/WebKit/WebKit/commit/d725cbd9692926baf17bf56ed46a385a7113d32d
  Author: Rupin Mittal 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add a new email for Rupin Mittal to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=245302

Reviewed by Aditya Keerthi.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/254580@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d32859: Add myself (Rupin Mittal) as a committer

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d32859e714715a7e2a3ce8d6ae1665d1b2ef2c72
  
https://github.com/WebKit/WebKit/commit/d32859e714715a7e2a3ce8d6ae1665d1b2ef2c72
  Author: Rupin Mittal 
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add myself (Rupin Mittal) as a committer
https://bugs.webkit.org/show_bug.cgi?id=258638

Reviewed by Chris Dumez.

Add myself (Rupin Mittal) as a committer to contributors.json

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/265599@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6178f6: Add IDL files and empty implementation for Cookie ...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6178f6321703c1007f79e9beeef8d27f8da9eec2
  
https://github.com/WebKit/WebKit/commit/6178f6321703c1007f79e9beeef8d27f8da9eec2
  Author: Rupin Mittal 
  Date:   2023-06-30 (Fri, 30 Jun 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_http_cookie_and_set_cookie_headers.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_and_no_value.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_equals_in_value.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_multiple_values.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieListItem_attributes.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_basic.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_delete.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_overwrite.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_delete_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_ordering.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_in_detached_frame.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_origin.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/encoding.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/httponly_cookies.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookies/partitioned-cookies/partitioned-cookies.tentative.https-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_origins.sub.https-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookieStore_cross_origin.https.sub-expected.txt
M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
A Source/WebCore/Modules/cookie-store/CookieInit.h
A Source/WebCore/Modules/cookie-store/CookieInit.idl
A Source/WebCore/Modules/cookie-store/CookieListItem.h
A Source/WebCore/Modules/cookie-store/CookieListItem.idl
A Source/WebCore/Modules/cookie-store/CookieSameSite.h
A Source/WebCore/Modules/cookie-store/CookieSameSite.idl
A Source/WebCore/Modules/cookie-store/CookieStore.cpp
A Source/WebCore/Modules/cookie-store/CookieStore.h
A Source/WebCore/Modules/cookie-store/CookieStore.idl
A Source/WebCore/Modules/cookie-store/CookieStoreDeleteOptions.h
A Source/WebCore/Modules/cookie-store/CookieStoreDeleteOptions.idl
A Source/WebCore/Modules/cookie-store/CookieStoreGetOptions.h
A Source/WebCore/Modules/cookie-store/CookieStoreGetOptions.idl
A Source/WebCore/Modules/cookie-store/LocalDOMWindow+CookieStore.idl

[webkit-changes] [WebKit/WebKit] 9ae242: Implement the get(name) function in Cookie Store API

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ae242a9a2f095eed7c17d453874a733bd57ce92
  
https://github.com/WebKit/WebKit/commit/9ae242a9a2f095eed7c17d453874a733bd57ce92
  Author: Rupin Mittal 
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any-expected.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/Modules/cookie-store/CookieListItem.idl
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/Modules/cookie-store/CookieStore.h
M Source/WebCore/Modules/cookie-store/CookieStore.idl
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/loader/CookieJar.cpp
M Source/WebCore/loader/CookieJar.h
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/platform/network/NetworkStorageSession.h
M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
M Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp
M Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
M Source/WebKit/WebProcess/WebPage/WebCookieJar.h

  Log Message:
  ---
  Implement the get(name) function in Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=259071

Reviewed by Chris Dumez.

CookieStore (on the WebProcess side), will make an IPC to the
Network Process (via WebCookieJar) and will pass the relevant
CookieStoreGetOptions through the IPC. The Network process will
retrieve the stored cookies, filter them using the provided
options and will asynchronously resolve the promise with a
vector of the filtered cookies. In the get(name) function, the
promise is resolved with only the first cookie in the vector
(if there are any at all).

* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/cookie-store/CookieListItem.idl:
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::create):
(WebCore::CookieStore::CookieStore):
(WebCore::CookieStore::get):
(WebCore::CookieStore::activeDOMObjectName const):
(WebCore::CookieStore::scriptExecutionContext const):
* Source/WebCore/Modules/cookie-store/CookieStore.h:
* Source/WebCore/Modules/cookie-store/CookieStore.idl:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/loader/CookieJar.h:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::cookieStore):
* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::vectorOfCookiesForSession const):
(WebCore::NetworkStorageSession::vectorOfCookiesForDOM const):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::cookiesForDOMAsync):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::WebCookieJar::getCookiesAsync const):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.h:

Canonical link: https://commits.webkit.org/265963@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9c1b15: Add more error handling in the get(name) function ...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c1b157f42a10fb8078e54f048f6250dc1f74b24
  
https://github.com/WebKit/WebKit/commit/9c1b157f42a10fb8078e54f048f6250dc1f74b24
  Author: Rupin Mittal 
  Date:   2023-07-12 (Wed, 12 Jul 2023)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/wincairo/TestExpectations
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/loader/CookieJar.cpp
M Source/WebCore/loader/CookieJar.h
M Source/WebCore/platform/network/NetworkStorageSession.h
M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
M Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp
M Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
M Source/WebKit/WebProcess/WebPage/WebCookieJar.h

  Log Message:
  ---
  Add more error handling in the get(name) function in the Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=259126

Reviewed by Chris Dumez.

If querying for the cookie fails, the promise should be rejected with a 
TypeError.

* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::get):
* Source/WebCore/loader/CookieJar.cpp:
(WebCore::CookieJar::getCookiesAsync const):
* Source/WebCore/loader/CookieJar.h:
* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::cookiesForSessionAsVector const):
(WebCore::NetworkStorageSession::cookiesForDOMAsVector const):
* Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:
(WebCore::NetworkStorageSession::cookiesForDOMAsVector const):
* Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::cookiesForDOMAsVector const):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::cookiesForDOMAsync):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::WebCookieJar::getCookiesAsync const):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.h:

Canonical link: https://commits.webkit.org/266006@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7d9ead: Implement the set function in the Cookie Store API

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d9eadacc38058d8875e9b9fd7f093d617a8e409
  
https://github.com/WebKit/WebKit/commit/7d9eadacc38058d8875e9b9fd7f093d617a8e409
  Author: Rupin Mittal 
  Date:   2023-07-14 (Fri, 14 Jul 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_basic.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_delete.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_overwrite.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_delete_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_ordering.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookies/partitioned-cookies/partitioned-cookies.tentative.https-expected.txt
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/wincairo/TestExpectations
M Source/WebCore/Modules/cookie-store/CookieInit.h
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/Modules/cookie-store/CookieStore.h
M Source/WebCore/loader/CookieJar.cpp
M Source/WebCore/loader/CookieJar.h
M Source/WebCore/platform/network/NetworkStorageSession.h
M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
M Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp
M Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
M Source/WebKit/WebProcess/WebPage/WebCookieJar.h

  Log Message:
  ---
  Implement the set function in the Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=259196

Reviewed by Chris Dumez.

CookieStore (on the WebProcess side), will make an IPC to the
Network Process (via WebCookieJar) and will pass the constructed
cookie through the IPC. The Network process will store the cookie
and if this process is successful, the promise will be resolved
with undefined. Otherwise, the promise will be rejected with a
TypeError.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_basic.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_delete.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_overwrite.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_delete_basic.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_basic.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_ordering.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt

[webkit-changes] [WebKit/WebKit] 525b38: Implement the delete function in the Cookie Store API

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 525b38fe412e28097b9c30af5d549d13bd19899c
  
https://github.com/WebKit/WebKit/commit/525b38fe412e28097b9c30af5d549d13bd19899c
  Author: Rupin Mittal 
  Date:   2023-07-14 (Fri, 14 Jul 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieListItem_attributes.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_delete.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_delete_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any-expected.txt
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/Modules/cookie-store/CookieStore.h

  Log Message:
  ---
  Implement the delete function in the Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=259220

Reviewed by Chris Dumez.

The delete function creates a cookie with the options given and
sets the expires field to a time in the past (we set it to the
epoch). Then it uses the Cookie Store API set function to set
this cookie so that the CFNetwork will update the existing cookies
with these options and delete them since they are expired.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieListItem_attributes.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_basic.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_delete.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_delete_basic.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_basic.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any-expected.txt:
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::remove):
* Source/WebCore/Modules/cookie-store/CookieStore.h:

Canonical link: https://commits.webkit.org/266078@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 70923b: Implement the getAll function in the Cookie Store API

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70923b0491297aa141f7dd6ea55206d417e6b30d
  
https://github.com/WebKit/WebKit/commit/70923b0491297aa141f7dd6ea55206d417e6b30d
  Author: Rupin Mittal 
  Date:   2023-07-18 (Tue, 18 Jul 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_http_cookie_and_set_cookie_headers.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_and_no_value.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_equals_in_value.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_multiple_values.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_origin.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/encoding.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/httponly_cookies.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookies/partitioned-cookies/partitioned-cookies.tentative.https-expected.txt
A 
LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookie-store/encoding.https.any-expected.txt
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/Modules/cookie-store/CookieStore.h

  Log Message:
  ---
  Implement the getAll function in the Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=259295

Reviewed by Chris Dumez.

The getAll function follows the same code path as the get
function (where the Web process sends an async IPC to the
Network process which responds with a vector of cookies that
match the options that were passed in) to return the relevant
cookies.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_http_cookie_and_set_cookie_headers.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_and_no_value.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_equals_in_value.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_multiple_values.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_origin.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/encoding.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/httponly_cookies.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookies/partitioned-cookies/partitioned-cookies.tentative.https-expected.txt:
* 
LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookie-store/encoding.https.any-expected.txt:
 Added.
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::getAll):
* Source/WebCore/Modules/cookie-store/CookieStore.h:

Canonical link: https://commits.webkit.org/266153@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0fd5d6: Add support for the extended attributes of Cookies...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0fd5d68a2b262b5899042bed3223e53c94f413cd
  
https://github.com/WebKit/WebKit/commit/0fd5d68a2b262b5899042bed3223e53c94f413cd
  Author: Rupin Mittal 
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieListItem_attributes.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Modules/cookie-store/CookieListItem.h
M Source/WebCore/Modules/cookie-store/CookieListItem.idl
M Source/WebCore/Modules/cookie-store/CookieStore.cpp

  Log Message:
  ---
  Add support for the extended attributes of Cookies in the Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=259340

Reviewed by Chris Dumez.

Cookies have more attributes besides just name and value. We want to add
support for gettting/setting these attributes. However, we are not yet
sure if we wish to expose these attributes to JavaScript. So this patch
adds support for the attributes and hides them behind the
CookieStoreAPIExtendedAttributesEnabled feature flag.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieListItem_attributes.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/cookie-store/CookieListItem.h:
(WebCore::CookieListItem::CookieListItem):
* Source/WebCore/Modules/cookie-store/CookieListItem.idl:
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::get):
(WebCore::CookieStore::getAll):

Canonical link: https://commits.webkit.org/266171@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d52eb0: Properly handle a '/' in the cookie's path when se...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d52eb029fa40b2be7f7a8275c2e5fccf962a2e7d
  
https://github.com/WebKit/WebKit/commit/d52eb029fa40b2be7f7a8275c2e5fccf962a2e7d
  Author: Rupin Mittal 
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt
M Source/WebCore/Modules/cookie-store/CookieStore.cpp

  Log Message:
  ---
  Properly handle a '/' in the cookie's path when setting a cookie with the 
Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=259505

Reviewed by Chris Dumez and Alex Christensen.

The spec (https://wicg.github.io/cookie-store/#set-cookie-algorithm)
dictates that in the set function, if the path is not null, then if
the path does not begin with a '/', the promise should be rejected
with a TypeError. If the path does begin with a '/',  but does not
end with a '/', then a '/' should be added, and then the rest of the

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt:
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::set):

Canonical link: https://commits.webkit.org/266317@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 58f6a2: Properly handle errors in the cookie's domain when...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58f6a2dd0bf84e0bba186126c6474a0ff1064353
  
https://github.com/WebKit/WebKit/commit/58f6a2dd0bf84e0bba186126c6474a0ff1064353
  Author: Rupin Mittal 
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_origin.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt
M Source/WebCore/Modules/cookie-store/CookieStore.cpp

  Log Message:
  ---
  Properly handle errors in the cookie's domain when setting a cookie with the 
Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=259529

Reviewed by Alex Christensen.

The spec (https://wicg.github.io/cookie-store/#set-cookie-algorithm)
dictates that in the set function, if the domain is not null, then if
the domain begins with a '.', the promise should be rejected with a
TypeError. If the domain does not begin with a '.' but the url's host
is not equal to domain and it does not end with a '.' followed by the
domain, the promise should be rejected with a TypeError. Additionally,
if the byte sequence length of the domain (in UTF8 format) is greater
than the maximum attribute value size (current 1024 bytes according to
https://wicg.github.io/cookie-store/#cookie-maximum-attribute-value-size),
then the promise should be rejected with a TypeError. This patch adds
these checks.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_origin.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt:
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::set):

Canonical link: https://commits.webkit.org/266351@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d7472f: Check that the size of a cookie's path is not too ...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7472f0d81e69ab8c62df926720430d69fdba732
  
https://github.com/WebKit/WebKit/commit/d7472f0d81e69ab8c62df926720430d69fdba732
  Author: Rupin Mittal 
  Date:   2023-07-28 (Fri, 28 Jul 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any.serviceworker-expected.txt
M Source/WebCore/Modules/cookie-store/CookieStore.cpp

  Log Message:
  ---
  Check that the size of a cookie's path is not too large when setting a cookie 
with the Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=259571

Reviewed by Alex Christensen.

The spec (https://wicg.github.io/cookie-store/#set-cookie-algorithm)
dictates that in the set function, if the byte sequence length of the
path (in UTF8 format) is greater than the maximum attribute value size
(currently 1024 bytes according to
https://wicg.github.io/cookie-store/#cookie-maximum-attribute-value-size),
then the promise should be rejected with a TypeError. This patch adds
this check the same way a previous patch added the same check for a
cookie's domain. It also adds testing for the length check for both path
and domain.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any.js:
(promise_test.async testCase):
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any.serviceworker-expected.txt:
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::set):

Canonical link: https://commits.webkit.org/266410@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 08f56b: Add CookieChangeListener base class and make WebCo...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 08f56b30694ca5a973f159ad51c86a6b294fcbce
  
https://github.com/WebKit/WebKit/commit/08f56b30694ca5a973f159ad51c86a6b294fcbce
  Author: Rupin Mittal 
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/loader/CookieChangeListener.h
M Source/WebCore/loader/CookieJar.cpp
M Source/WebCore/loader/CookieJar.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
M Source/WebKit/WebProcess/Network/NetworkProcessConnection.h
M Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp
M Source/WebKit/WebProcess/WebPage/WebCookieCache.h
M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
M Source/WebKit/WebProcess/WebPage/WebCookieJar.h

  Log Message:
  ---
  Add CookieChangeListener base class and make WebCookieCache a 
CookieChangeListener
https://bugs.webkit.org/show_bug.cgi?id=259710

Reviewed by Chris Dumez.

This patch is a step towards implementing the notifications upon
changes in cookies part of the new Cookie Store API. We would like
the CookieStore to listen for changes in cookies. So we add a
CookieChangeListener abstract base class which requires subclasses
to define what should happen when a cookie is added or deleted.

Currently, we have a WebCookieCache in the Web Process which listens
to updates in cookies (per host) from the Network Process. It sends
an IPC to NetworkConnectionToWebProcess to subscribe to cookie-update
notifications. When a change happends, NetworkConnectionToWebProcess
sends an IPC with the update to WebCookieaJar, which notifies the
WebCookieCache.

The new design is that: WebCookieCache is a subclass of
CookieChangeListener (so it specifies what to do on cookie add/delete).
As before, when it receives a request to obtain cookies for a host and
it's the first request for this host, WebCookieCache will subscribe to
listen to updates. Except, instead of directly sending an IPC to the
NetworkProcess, it will register itself as a listener with the
WebCookieJar. The WebCookieJar will maintain a map from hosts to their
listeners. The WebCookieJar will send an IPC to the Network Process
to subscribe the listener. On updates, the WebCookieJar will be sent
an IPC and it will notify the relevant listeners for that host. When
the WebCookieCache wants to unsubscribe to notifications for a certain
host, it will tell the WebCookieJar, which will send the IPC to the
Network Process to unsubscribe the listener. It will also update it's
map accordingly.

A future patch will make the CookieStore a CookieChangeListener too.

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/loader/CookieChangeListener.h: Copied from 
Source/WebKit/WebProcess/WebPage/WebCookieCache.h.
(WebCore::CookieChangeListener::~CookieChangeListener):
* Source/WebCore/loader/CookieJar.cpp:
(WebCore::CookieJar::addChangeListener):
(WebCore::CookieJar::removeChangeListener):
* Source/WebCore/loader/CookieJar.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::domCookiesForHost):
(WebKit::NetworkConnectionToWebProcess::subscribeToCookieChangeNotifications):
(WebKit::NetworkConnectionToWebProcess::unsubscribeFromCookieChangeNotifications):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::cookiesAdded):
(WebKit::NetworkProcessConnection::cookiesDeleted):
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.h:
* Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp:
(WebKit::WebCookieCache::cookiesForDOM):
(WebKit::WebCookieCache::cookiesAdded):
(WebKit::WebCookieCache::clear):
(WebKit::WebCookieCache::clearForHost):
* Source/WebKit/WebProcess/WebPage/WebCookieCache.h:
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::WebCookieJar::cookiesAdded):
(WebKit::WebCookieJar::cookiesDeleted):
(WebKit::WebCookieJar::addChangeListener):
(WebKit::WebCookieJar::removeChangeListener):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.h:

Canonical link: https://commits.webkit.org/266570@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0fb388: Add IDL files and implementation of CookieChangeEvent

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0fb388663dbd3ffced8adfc4c1bb722aebf44d30
  
https://github.com/WebKit/WebKit/commit/0fb388663dbd3ffced8adfc4c1bb722aebf44d30
  Author: Rupin Mittal 
  Date:   2023-08-09 (Wed, 09 Aug 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_arguments.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any-expected.txt
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
A Source/WebCore/Modules/cookie-store/CookieChangeEvent.cpp
A Source/WebCore/Modules/cookie-store/CookieChangeEvent.h
A Source/WebCore/Modules/cookie-store/CookieChangeEvent.idl
A Source/WebCore/Modules/cookie-store/CookieChangeEventInit.h
A Source/WebCore/Modules/cookie-store/CookieChangeEventInit.idl
M Source/WebCore/Modules/cookie-store/CookieListItem.h
M Source/WebCore/Modules/cookie-store/CookieListItem.idl
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/bindings/js/WebCoreBuiltinNames.h
M Source/WebCore/dom/EventNames.in

  Log Message:
  ---
  Add IDL files and implementation of CookieChangeEvent
https://bugs.webkit.org/show_bug.cgi?id=259932

Reviewed by Chris Dumez.

CookieChangeEvent and CookieChangeEventInit are needed
for the change events of the CookieStore API. This patch
adds the needed IDL and implementation files.

* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_arguments.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any-expected.txt:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/cookie-store/CookieChangeEvent.cpp: Copied from 
Source/WebCore/Modules/cookie-store/CookieListItem.idl.
(WebCore::CookieChangeEvent::create):
(WebCore::CookieChangeEvent::CookieChangeEvent):
(WebCore::CookieChangeEvent::eventInterface const):
* Source/WebCore/Modules/cookie-store/CookieChangeEvent.h: Copied from 
Source/WebCore/Modules/cookie-store/CookieListItem.idl.
* Source/WebCore/Modules/cookie-store/CookieChangeEvent.idl: Copied from 
Source/WebCore/Modules/cookie-store/CookieListItem.idl.
* Source/WebCore/Modules/cookie-store/CookieChangeEventInit.h: Copied from 
Source/WebCore/Modules/cookie-store/CookieListItem.idl.
* Source/WebCore/Modules/cookie-store/CookieChangeEventInit.idl: Copied from 
Source/WebCore/Modules/cookie-store/CookieListItem.idl.
* Source/WebCore/Modules/cookie-store/CookieListItem.h:
* Source/WebCore/Modules/cookie-store/CookieListItem.idl:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/dom/EventNames.in:

Canonical link: https://commits.webkit.org/266739@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5e29d9: Add the change event for the Cookie Store API

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e29d991fbf6dd8193d81b5fd706b2224ed7caf2
  
https://github.com/WebKit/WebKit/commit/5e29d991fbf6dd8193d81b5fd706b2224ed7caf2
  Author: Rupin Mittal 
  Date:   2023-08-12 (Sat, 12 Aug 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_http_cookie_and_set_cookie_headers.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_basic.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_delete.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_overwrite.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/httponly_cookies.https.window-expected.txt
A 
LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window-expected.txt
A 
LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_http_cookie_and_set_cookie_headers.https.window-expected.txt
M Source/WebCore/Modules/cookie-store/CookieChangeEvent.idl
M Source/WebCore/Modules/cookie-store/CookieListItem.h
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/Modules/cookie-store/CookieStore.h
M Source/WebCore/loader/CookieJar.h

  Log Message:
  ---
  Add the change event for the Cookie Store API
https://bugs.webkit.org/show_bug.cgi?id=260028

Reviewed by Chris Dumez.

CookieStore now subclasses CookieChangeListener so that when an
event listener changes, it can register (or unregister) itself
as a listener. If it is registered and a cookie changed, the
relevant function (cookiesAdded or cookiesDeleted) will be called
to fire a change event.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_http_cookie_and_set_cookie_headers.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_basic.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_delete.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_overwrite.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/cookie-store/httponly_cookies.https.window-expected.txt:
* 
LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window-expected.txt:
 Added.
* 
LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_http_cookie_and_set_cookie_headers.https.window-expected.txt:
 Added.
* Source/WebCore/Modules/cookie-store/CookieChangeEvent.idl:
* Source/WebCore/Modules/cookie-store/CookieListItem.h:
(WebCore::CookieListItem::CookieListItem):
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::CookieStore):
(WebCore::CookieStore::get):
(WebCore::CookieStore::getAll):
(WebCore::CookieStore::set):
(WebCore::CookieStore::cookiesAdded):
(WebCore::CookieStore::cookiesDeleted):
(WebCore::CookieStore::stop):
(WebCore::CookieStore::virtualHasPendingActivity const):
(WebCore::CookieStore::eventListenersDidChange):
* Source/WebCore/Modules/cookie-store/CookieStore.h:
* Source/WebCore/loader/CookieJar.h:

Canonical link: https://commits.webkit.org/266850@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d17644: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d17644b0b23980c7089ff0d64e4d738382e44e26
  
https://github.com/WebKit/WebKit/commit/d17644b0b23980c7089ff0d64e4d738382e44e26
  Author: Rupin Mittal 
  Date:   2024-10-13 (Sun, 13 Oct 2024)

  Changed paths:
M Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp
M Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h
M Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp
M Source/WebKit/WebProcess/Inspector/WebInspectorUI.h
M Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make 
WebInspectorUIExtensionController ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281348
rdar://137778022

Reviewed by Chris Dumez and Ryosuke Niwa.

Remove IsDeprecatedWeakRefSmartPointerException] by making 
WebInspectorUIExtensionController ref-counted.

* Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp:
(WebKit::RemoteWebInspectorUI::initialize):
(WebKit::RemoteWebInspectorUI::didShowExtensionTab):
(WebKit::RemoteWebInspectorUI::didHideExtensionTab):
(WebKit::RemoteWebInspectorUI::didNavigateExtensionTab):
(WebKit::RemoteWebInspectorUI::inspectedPageDidNavigate):
* Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h:
* Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::establishConnection):
(WebKit::WebInspectorUI::didShowExtensionTab):
(WebKit::WebInspectorUI::didHideExtensionTab):
(WebKit::WebInspectorUI::didNavigateExtensionTab):
(WebKit::WebInspectorUI::inspectedPageDidNavigate):
* Source/WebKit/WebProcess/Inspector/WebInspectorUI.h:
* Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.h:
(WebKit::WebInspectorUIExtensionController::create):

Canonical link: https://commits.webkit.org/285087@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 882c85: [IsDeprecatedWeakRefSmartPointerException] Remove ...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 882c85a823c9d74a342a951da9cf1df88df7596b
  
https://github.com/WebKit/WebKit/commit/882c85a823c9d74a342a951da9cf1df88df7596b
  Author: Rupin Mittal 
  Date:   2024-10-13 (Sun, 13 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm
M Source/WebKit/UIProcess/ios/ProcessStateMonitor.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Remove exception from 
ProcessStateMonitor
https://bugs.webkit.org/show_bug.cgi?id=281350
rdar://137778725

Reviewed by Chris Dumez and Ryosuke Niwa.

Remove IsDeprecatedWeakRefSmartPointerException] by making ProcessStateMonitor 
ref-counted.

* Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm:
(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):
(-[WKProcessAssertionBackgroundTaskManager setProcessStateMonitorEnabled:]):
* Source/WebKit/UIProcess/ios/ProcessStateMonitor.h:
(WebKit::ProcessStateMonitor::create):

Canonical link: https://commits.webkit.org/285088@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 71ca97: [IsDeprecatedWeakRefSmartPointerException] Make Au...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71ca97e249546e4c37cd7988764047a98719ad7e
  
https://github.com/WebKit/WebKit/commit/71ca97e249546e4c37cd7988764047a98719ad7e
  Author: Rupin Mittal 
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
M 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.cpp
M 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.h
M 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.cpp
M 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.h
M 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp
M 
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp
M 
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make 
AudioMediaStreamTrackRendererInternalUnitManager ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281260
rdar://137714138

Reviewed by Chris Dumez.

Remove IsDeprecatedWeakRefSmartPointerException by making
AudioMediaStreamTrackRendererInternalUnitManager ref-counted.

* 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.cpp:
(WebCore::LocalAudioMediaStreamTrackRendererInternalUnit::render):
(WebCore::AudioMediaStreamTrackRendererInternalUnit::create):
* 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.h:
* 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.cpp:
(WebCore::AudioMediaStreamTrackRendererUnit::setAudioOutputDevice):
(WebCore::AudioMediaStreamTrackRendererUnit::start):
(WebCore::AudioMediaStreamTrackRendererUnit::stop):
(WebCore::AudioMediaStreamTrackRendererUnit::retrieveFormatDescription):
* Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.h:
(WebCore::AudioMediaStreamTrackRendererUnit::protectedInternalUnit):
* 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::protectedLocalUnit):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::start):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::stop):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::setAudioOutputDevice):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::captureUnitIsStarting):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::captureUnitHasStopped):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::beginAudioSessionInterruption):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::endAudioSessionInterruption):
* 
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::createRemoteAudioMediaStreamTrackRendererInternalUnitProxy):
(WebKit::AudioMediaStreamTrackRendererInternalUnitManagerProxy::startThread):
(WebKit::AudioMediaStreamTrackRendererInternalUnitManagerProxy::reset):
* 
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.h:

Canonical link: https://commits.webkit.org/285139@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 259a47: Adopt more smart pointers in WebPageProxy (part 2)

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 259a471d12137011bc115533fbc94bd2060fa9a7
  
https://github.com/WebKit/WebKit/commit/259a471d12137011bc115533fbc94bd2060fa9a7
  Author: Rupin Mittal 
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessPool.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h

  Log Message:
  ---
  Adopt more smart pointers in WebPageProxy (part 2)
https://bugs.webkit.org/show_bug.cgi?id=281458
rdar://137911329

Reviewed by Chris Dumez and Geoffrey Garen.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::m_pageForTesting):
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::canShowMIMEType):
(WebKit::WebPageProxy::setUnderPageBackgroundColorOverride):
(WebKit::WebPageProxy::activityStateDidChange):
(WebKit::WebPageProxy::executeEditCommand):
(WebKit::WebPageProxy::performDragOperation):
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::cacheWheelEventScrollingAccelerationCurve):
(WebKit::WebPageProxy::clearServiceWorkerEntitlementOverride):
(WebKit::WebPageProxy::commitProvisionalPage):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::saveResources):
(WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation):
(WebKit::WebPageProxy::dataTaskWithRequest):
(WebKit::WebPageProxy::backForwardAddItemShared):
(WebKit::WebPageProxy::backForwardGoToItem):
(WebKit::WebPageProxy::backForwardItemAtIndex):
(WebKit::WebPageProxy::backForwardListCounts):
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithImageTranscoding):
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::appPrivacyReportTestingData):
(WebKit::WebPageProxy::clearAppPrivacyReportTestingData):
* Source/WebKit/UIProcess/WebProcessPool.h:
(WebKit::WebProcessProxy::protectedProcessPool const):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::protectedProcessPool const): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:

Canonical link: https://commits.webkit.org/285182@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b15f86: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b15f86cdf39f27860179698c6d67898c43dce4f4
  
https://github.com/WebKit/WebKit/commit/b15f86cdf39f27860179698c6d67898c43dce4f4
  Author: Rupin Mittal 
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
M Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.h
M Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.mm
M Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm
M Source/WebKit/UIProcess/Cocoa/UIRemoteObjectRegistry.cpp
M Source/WebKit/UIProcess/Cocoa/UIRemoteObjectRegistry.h
M Source/WebKit/WebProcess/WebPage/Cocoa/WebRemoteObjectRegistry.cpp
M Source/WebKit/WebProcess/WebPage/Cocoa/WebRemoteObjectRegistry.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make WebRemoteObjectRegistry 
ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281263
rdar://137716730

Reviewed by Chris Dumez.

Remove IsDeprecatedWeakRefSmartPointerException] by making
WebRemoteObjectRegistry ref-counted.

* Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.h:
* Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.mm:
(WebKit::RemoteObjectRegistry::send):
* Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(-[_WKRemoteObjectRegistry _initWithWebPage:]):
(-[_WKRemoteObjectRegistry _initWithWebPageProxy:]):
(-[_WKRemoteObjectRegistry _sendInvocation:interface:]):
(-[_WKRemoteObjectRegistry _invokeMethod:]):
* Source/WebKit/UIProcess/Cocoa/UIRemoteObjectRegistry.cpp:
(WebKit::UIRemoteObjectRegistry::backgroundActivity):
(WebKit::UIRemoteObjectRegistry::sendInvocation):
(WebKit::UIRemoteObjectRegistry::messageSender):
(WebKit::UIRemoteObjectRegistry::messageDestinationID):
(WebKit::UIRemoteObjectRegistry::protectedPage): Deleted.
* Source/WebKit/UIProcess/Cocoa/UIRemoteObjectRegistry.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebRemoteObjectRegistry.cpp:
(WebKit::WebRemoteObjectRegistry::close):
(WebKit::WebRemoteObjectRegistry::messageSender):
(WebKit::WebRemoteObjectRegistry::messageDestinationID):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebRemoteObjectRegistry.h:

Canonical link: https://commits.webkit.org/285150@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4e64b3: Adopt more smart pointers in GPUProcess related files

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e64b34dc5a6cc10db26b60feb2b86061927db02
  
https://github.com/WebKit/WebKit/commit/4e64b34dc5a6cc10db26b60feb2b86061927db02
  Author: Rupin Mittal 
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h
M Source/WebKit/GPUProcess/graphics/ScopedWebGLRenderingResourcesRequest.cpp
M Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioSourceProviderProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioSourceProviderProxy.h
M Source/WebKit/GPUProcess/media/RemoteAudioTrackProxy.h
M Source/WebKit/GPUProcess/media/RemoteVideoTrackProxy.h
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess related files
https://bugs.webkit.org/show_bug.cgi?id=281101
rdar://137553976

Reviewed by Chris Dumez.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::remoteGraphicsContextGLStreamWorkQueueSingleton):
(WebKit::RemoteGraphicsContextGL::RemoteGraphicsContextGL):
(WebKit::remoteGraphicsContextGLStreamWorkQueue): Deleted.
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h:
* Source/WebKit/GPUProcess/graphics/ScopedWebGLRenderingResourcesRequest.cpp:
(WebKit::ScopedWebGLRenderingResourcesRequest::scheduleFreeWebGLRenderingResources):
(WebKit::ScopedWebGLRenderingResourcesRequest::freeWebGLRenderingResources):
* Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp:
(WebKit::remoteGraphicsStreamWorkQueue):
* Source/WebKit/GPUProcess/media/RemoteAudioSourceProviderProxy.cpp:
(WebKit::RemoteAudioSourceProviderProxy::configureAudioStorage):
(WebKit::RemoteAudioSourceProviderProxy::newAudioSamples):
* Source/WebKit/GPUProcess/media/RemoteAudioSourceProviderProxy.h:
(WebKit::RemoteAudioSourceProviderProxy::protectedConnection const):
* Source/WebKit/GPUProcess/media/RemoteAudioTrackProxy.h:
* Source/WebKit/GPUProcess/media/RemoteVideoTrackProxy.h:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::GPUProcessConnection):
(WebKit::GPUProcessConnection::~GPUProcessConnection):
(WebKit::GPUProcessConnection::invalidate):
(WebKit::GPUProcessConnection::waitForDidInitialize):

Canonical link: https://commits.webkit.org/284909@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a0a16a: Adopt more smart pointers in RemoteGraphicsContext...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a0a16a8c8413a9b76aabc3eec67418f2c09baf8c
  
https://github.com/WebKit/WebKit/commit/a0a16a8c8413a9b76aabc3eec67418f2c09baf8c
  Author: Rupin Mittal 
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
M 
Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Tools/Scripts/generate-gpup-webgl

  Log Message:
  ---
  Adopt more smart pointers in RemoteGraphicsContextGLFunctionsGenerated.h
https://bugs.webkit.org/show_bug.cgi?id=281098
rdar://137549546

Reviewed by Chris Dumez.

Smart pointer adoption as per the static analyzer.

We update the generate-gpup-webgl script to generate 
RemoteGraphicsContextGLFunctionsGenerated.h
so that it uses `protectedContext()` (defined in RemoteGraphicsContextGL.h) 
instead of `m_context`.

* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:
(activeTexture):
(attachShader):
(bindAttribLocation):
(bindBuffer):
(bindFramebuffer):
(bindRenderbuffer):
(bindTexture):
(blendColor):
(blendEquation):
(blendEquationSeparate):
(blendFunc):
(blendFuncSeparate):
(checkFramebufferStatus):
(clear):
(clearColor):
(clearDepth):
(clearStencil):
(colorMask):
(compileShader):
(copyTexImage2D):
(copyTexSubImage2D):
(createBuffer):
(createFramebuffer):
(createProgram):
(createRenderbuffer):
(createShader):
(createTexture):
(cullFace):
(deleteBuffer):
(deleteFramebuffer):
(deleteProgram):
(deleteRenderbuffer):
(deleteShader):
(deleteTexture):
(depthFunc):
(depthMask):
(depthRange):
(detachShader):
(disable):
(disableVertexAttribArray):
(drawArrays):
(drawElements):
(enable):
(enableVertexAttribArray):
(finish):
(flush):
(framebufferRenderbuffer):
(framebufferTexture2D):
(frontFace):
(generateMipmap):
(getActiveAttrib):
(getActiveUniform):
(getAttribLocation):
(getBufferParameteri):
(getString):
(getFloatv):
(getIntegerv):
(getIntegeri_v):
(getInteger64):
(getInteger64i):
(getProgrami):
(getBooleanv):
(getFramebufferAttachmentParameteri):
(getProgramInfoLog):
(getRenderbufferParameteri):
(getShaderi):
(getShaderInfoLog):
(getShaderPrecisionFormat):
(getShaderSource):
(getTexParameterf):
(getTexParameteri):
(getUniformfv):
(getUniformiv):
(getUniformuiv):
(getUniformLocation):
(getVertexAttribOffset):
(hint):
(isBuffer):
(isEnabled):
(isFramebuffer):
(isProgram):
(isRenderbuffer):
(isShader):
(isTexture):
(lineWidth):
(linkProgram):
(pixelStorei):
(polygonOffset):
(renderbufferStorage):
(sampleCoverage):
(scissor):
(shaderSource):
(stencilFunc):
(stencilFuncSeparate):
(stencilMask):
(stencilMaskSeparate):
(stencilOp):
(stencilOpSeparate):
(texParameterf):
(texParameteri):
(uniform1f):
(uniform1fv):
(uniform1i):
(uniform1iv):
(uniform2f):
(uniform2fv):
(uniform2i):
(uniform2iv):
(uniform3f):
(uniform3fv):
(uniform3i):
(uniform3iv):
(uniform4f):
(uniform4fv):
(uniform4i):
(uniform4iv):
(uniformMatrix2fv):
(uniformMatrix3fv):
(uniformMatrix4fv):
(useProgram):
(validateProgram):
(vertexAttrib1f):
(vertexAttrib1fv):
(vertexAttrib2f):
(vertexAttrib2fv):
(vertexAttrib3f):
(vertexAttrib3fv):
(vertexAttrib4f):
(vertexAttrib4fv):
(vertexAttribPointer):
(viewport):
(bufferData0):
(bufferData1):
(bufferSubData):
(readPixelsBufferObject):
(texImage2D0):
(texImage2D1):
(texSubImage2D0):
(texSubImage2D1):
(compressedTexImage2D0):
(compressedTexImage2D1):
(compressedTexSubImage2D0):
(compressedTexSubImage2D1):
(drawArraysInstanced):
(drawElementsInstanced):
(vertexAttribDivisor):
(createVertexArray):
(deleteVertexArray):
(isVertexArray):
(bindVertexArray):
(copyBufferSubData):
(blitFramebuffer):
(framebufferTextureLayer):
(invalidateFramebuffer):
(invalidateSubFramebuffer):
(readBuffer):
(renderbufferStorageMultisample):
(texStorage2D):
(texStorage3D):
(texImage3D0):
(texImage3D1):
(texSubImage3D0):
(texSubImage3D1):
(copyTexSubImage3D):
(compressedTexImage3D0):
(compressedTexImage3D1):
(compressedTexSubImage3D0):
(compressedTexSubImage3D1):
(getFragDataLocation):
(uniform1ui):
(uniform2ui):
(uniform3ui):
(uniform4ui):
(uniform1uiv):
(uniform2uiv):
(uniform3uiv):
(uniform4uiv):
(uniformMatrix2x3fv):
(uniformMatrix3x2fv):
(uniformMatrix2x4fv):
(uniformMatrix4x2fv):
(uniformMatrix3x4fv):
(uniformMatrix4x3fv):
(vertexAttribI4i):
(vertexAttribI4iv):
(vertexAttribI4ui):
(vertexAttribI4uiv):
(vertexAttribIPointer):
(drawRangeElements):
(drawBuffers):
(clearBufferiv):
(clearBufferuiv):
(clearBufferfv):
(clearBufferfi):
(createQuery):
(deleteQuery):
(isQuery):
(beginQuery):
(endQuery):
(getQuery):
(getQueryObjectui):
(createSampler):
(deleteSampler):
(isSampler):
(bindSampler):
(samplerParameteri):
(samplerParameterf):
(getSamplerParameterf):
(getSamplerParameteri):
(fenceSync):
(isSync):
(deleteSync):
(clientWaitSync):
(waitSync):
(getSynci):
(createTransformFeedback):
(deleteTransformFeedback):
(isTransformFeedback):
(bindTransformFeedback):
(beginTransformFeedback

[webkit-changes] [WebKit/WebKit] dae38b: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dae38b66a9715cd1750a2a6690fd4c955d8542d6
  
https://github.com/WebKit/WebKit/commit/dae38b66a9715cd1750a2a6690fd4c955d8542d6
  Author: Rupin Mittal 
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
M Source/WebCore/html/BaseDateAndTimeInputType.cpp
M Source/WebCore/html/BaseDateAndTimeInputType.h
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/loader/EmptyClients.h
M Source/WebCore/page/Chrome.cpp
M Source/WebCore/page/Chrome.h
M Source/WebCore/page/ChromeClient.h
M Source/WebCore/platform/DateTimeChooser.h
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebDateTimeChooser.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebDateTimeChooser.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make WebDateTimeChooser ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281110
rdar://137563134

Reviewed by Ryosuke Niwa.

We remove IsDeprecatedWeakRefSmartPointerException by making WebDateTimeChooser
ref-counted.

WebPage holds a WeakPtr to WebDateTimeChooser and WebDateTimeChooser holds a
WeakRef to WebPage. Since WebDateTimeChooser is now ref-counted, it's possible
for it to out-live the WebPage, which would make a use of it's WeakRef m_page
member unsafe. To ensure that WebDateTimeChooser never tries to use it's WebPage
member if the WebPage has been destroyed, we change the m_page member to be a
WeakPtr instead of a WeakRef and null-check m_page before using it.

* Source/WebCore/html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::showPicker):
(WebCore::BaseDateAndTimeInputType::didChangeValueFromControl):
(WebCore::BaseDateAndTimeInputType::closeDateTimeChooser):
(WebCore::BaseDateAndTimeInputType::didEndChooser): Deleted.
* Source/WebCore/html/BaseDateAndTimeInputType.h:
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::createDateTimeChooser):
* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/page/Chrome.cpp:
(WebCore::Chrome::createDateTimeChooser):
* Source/WebCore/page/Chrome.h:
* Source/WebCore/page/ChromeClient.h:
* Source/WebCore/platform/DateTimeChooser.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createDateTimeChooser):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebDateTimeChooser.cpp:
(WebKit::WebDateTimeChooser::endChooser):
(WebKit::WebDateTimeChooser::showChooser):
* Source/WebKit/WebProcess/WebCoreSupport/WebDateTimeChooser.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChooseDate):
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createDateTimeChooser):

Canonical link: https://commits.webkit.org/284882@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9e6935: [IsDeprecatedWeakRefSmartPointerException] Remove ...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e6935faed8654391f8d9d3d4ff78cef98a91bac
  
https://github.com/WebKit/WebKit/commit/9e6935faed8654391f8d9d3d4ff78cef98a91bac
  Author: Rupin Mittal 
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.h
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.h
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h
M Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.cpp
M Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Remove exception from 
WebRTCMonitor and LibWebRTCSocket
https://bugs.webkit.org/show_bug.cgi?id=281115
rdar://137565108

Reviewed by Chris Dumez and Ryosuke Niwa.

We remove IsDeprecatedWeakRefSmartPointerException by making WebRTCMonitor 
ref-counted.

In the case of LibWebRTCSocket, we cannot make it ref-counted because
LibWebRTCSocketFactory::createUdpSocket and 
LibWebRTCSocketFactory::createClientTcpSocket
return a raw pointer of LibWebRTCSocket's base class type 
rtc::AsyncPacketSocket, which
could be destroyed--completely ignoring the ref-counting of LibWebRTCSocket. So 
we remove
the exception by making LibWebRTCSocket able to be a CheckedPtr.

* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp:
(WebKit::LibWebRTCNetworkManager::getOrCreate):
(WebKit::LibWebRTCNetworkManager::signalUsedInterface):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.h:
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
(WebKit::LibWebRTCProvider::createPeerConnection):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.h:
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:
(WebKit::LibWebRTCSocketFactory::forSocketInGroup):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h:
* Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.cpp:
(WebKit::WebRTCMonitor::networksChanged):
(WebKit::WebRTCMonitor::networkProcessCrashed):
* Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.h:

Canonical link: https://commits.webkit.org/285004@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7fd886: [IsDeprecatedWeakRefSmartPointerException] Make Sa...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7fd8860065303c1f5a14252916b24a1b5e57a27f
  
https://github.com/WebKit/WebKit/commit/7fd8860065303c1f5a14252916b24a1b5e57a27f
  Author: Rupin Mittal 
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
M Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp
M Source/WebKit/WebProcess/GPU/GPUProcessConnection.h
M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp
M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.cpp
M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make 
SampleBufferDisplayLayerManager ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281248
rdar://137706376

Reviewed by Ryosuke Niwa.

SampleBufferDisplayLayerManager is owned by GPUProcessConnection, so we forward
the ref/deref'ing to GPUProcessConnection.

* Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::sampleBufferDisplayLayerManager):
(WebKit::GPUProcessConnection::protectedSampleBufferDisplayLayerManager):
(WebKit::GPUProcessConnection::dispatchMessage):
* Source/WebKit/WebProcess/GPU/GPUProcessConnection.h:
* Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
(WebKit::SampleBufferDisplayLayer::~SampleBufferDisplayLayer):
* Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.cpp:
(WebKit::SampleBufferDisplayLayerManager::SampleBufferDisplayLayerManager):
(WebKit::SampleBufferDisplayLayerManager::ref const):
(WebKit::SampleBufferDisplayLayerManager::deref const):
* Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.h:

Canonical link: https://commits.webkit.org/285025@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7c1bf9: Adopt more smart pointers in GPUProcess/graphics (...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c1bf961dde2d1f272b81bfcc0f514a57b1a5009
  
https://github.com/WebKit/WebKit/commit/7c1bf961dde2d1f272b81bfcc0f514a57b1a5009
  Author: Rupin Mittal 
  Date:   2024-10-04 (Fri, 04 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRSubImage.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.h

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/graphics (part 7)
https://bugs.webkit.org/show_bug.cgi?id=280860
rdar://137241513

Reviewed by Mike Wyrzykowski.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp:
(WebKit::RemoteGPU::workQueueUninitialize):
(WebKit::RemoteGPU::requestAdapter):
(WebKit::RemoteGPU::createPresentationContext):
(WebKit::RemoteGPU::createCompositorIntegration):
(WebKit::RemoteGPU::paintNativeImageToImageBuffer):
(WebKit::RemoteGPU::isValid):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp:
(WebKit::RemoteRenderBundleEncoder::RemoteRenderBundleEncoder):
(WebKit::RemoteRenderBundleEncoder::destruct):
(WebKit::RemoteRenderBundleEncoder::stopListeningForIPC):
(WebKit::RemoteRenderBundleEncoder::setPipeline):
(WebKit::RemoteRenderBundleEncoder::setIndexBuffer):
(WebKit::RemoteRenderBundleEncoder::setVertexBuffer):
(WebKit::RemoteRenderBundleEncoder::unsetVertexBuffer):
(WebKit::RemoteRenderBundleEncoder::draw):
(WebKit::RemoteRenderBundleEncoder::drawIndexed):
(WebKit::RemoteRenderBundleEncoder::drawIndirect):
(WebKit::RemoteRenderBundleEncoder::drawIndexedIndirect):
(WebKit::RemoteRenderBundleEncoder::setBindGroup):
(WebKit::RemoteRenderBundleEncoder::pushDebugGroup):
(WebKit::RemoteRenderBundleEncoder::popDebugGroup):
(WebKit::RemoteRenderBundleEncoder::insertDebugMarker):
(WebKit::RemoteRenderBundleEncoder::finish):
(WebKit::RemoteRenderBundleEncoder::setLabel):
(WebKit::RemoteRenderBundleEncoder::protectedBacking const):
(WebKit::RemoteRenderBundleEncoder::protectedStreamConnection const):
(WebKit::RemoteRenderBundleEncoder::protectedObjectHeap const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRSubImage.cpp:
(WebKit::RemoteXRSubImage::destruct):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp:
(WebKit::RemoteGPUProxy::initializeIPC):
(WebKit::RemoteGPUProxy::disconnectGpuProcessIfNeeded):
(WebKit::RemoteGPUProxy::abandonGPUProcess):
(WebKit::RemoteGPUProxy::wasCreated):
(WebKit::RemoteGPUProxy::waitUntilInitialized):
(WebKit::RemoteGPUProxy::requestAdapter):
(WebKit::RemoteGPUProxy::createPresentationContext):
(WebKit::RemoteGPUProxy::createCompositorIntegration):
(WebKit::RemoteGPUProxy::protectedConvertToBackingContext const):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h:
* 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.cpp:
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::setPipeline):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::setIndexBuffer):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::setVertexBuffer):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::drawIndirect):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::drawIndexedIndirect):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::setBindGroup):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::finish):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::protectedConvertToBackingContext
 const):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.h:

Canonical link: https://commits.webkit.org/284693@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 41a1c9: Adopt more smart pointers in GPUProcess/graphics (...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41a1c99f58fcef1a446468ff959bc9ea41a3dd36
  
https://github.com/WebKit/WebKit/commit/41a1c99f58fcef1a446468ff959bc9ea41a3dd36
  Author: Rupin Mittal 
  Date:   2024-10-04 (Fri, 04 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePresentationContextProxy.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePresentationContextProxy.h

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/graphics (part 6)
https://bugs.webkit.org/show_bug.cgi?id=280846
rdar://137229955

Reviewed by Mike Wyrzykowski.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp:
(WebKit::RemoteAdapter::requestDevice):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp:
(WebKit::RemoteDevice::RemoteDevice):
(WebKit::RemoteDevice::stopListeningForIPC):
(WebKit::RemoteDevice::destroy):
(WebKit::RemoteDevice::createXRBinding):
(WebKit::RemoteDevice::createBuffer):
(WebKit::RemoteDevice::createTexture):
(WebKit::RemoteDevice::createSampler):
(WebKit::RemoteDevice::importExternalTextureFromVideoFrame):
(WebKit::RemoteDevice::createBindGroupLayout):
(WebKit::RemoteDevice::createPipelineLayout):
(WebKit::RemoteDevice::createBindGroup):
(WebKit::RemoteDevice::createShaderModule):
(WebKit::RemoteDevice::createComputePipeline):
(WebKit::RemoteDevice::createRenderPipeline):
(WebKit::RemoteDevice::createComputePipelineAsync):
(WebKit::RemoteDevice::createRenderPipelineAsync):
(WebKit::RemoteDevice::createCommandEncoder):
(WebKit::RemoteDevice::createRenderBundleEncoder):
(WebKit::RemoteDevice::createQuerySet):
(WebKit::RemoteDevice::pushErrorScope):
(WebKit::RemoteDevice::popErrorScope):
(WebKit::RemoteDevice::resolveUncapturedErrorEvent):
(WebKit::RemoteDevice::resolveDeviceLostPromise):
(WebKit::RemoteDevice::setLabel):
(WebKit::RemoteDevice::protectedBacking):
(WebKit::RemoteDevice::protectedObjectHeap const):
(WebKit::RemoteDevice::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp:
(WebKit::RemotePresentationContext::RemotePresentationContext):
(WebKit::RemotePresentationContext::stopListeningForIPC):
(WebKit::RemotePresentationContext::configure):
(WebKit::RemotePresentationContext::unconfigure):
(WebKit::RemotePresentationContext::present):
(WebKit::RemotePresentationContext::getCurrentTexture):
(WebKit::RemotePresentationContext::protectedBacking):
(WebKit::RemotePresentationContext::protectedObjectHeap const):
(WebKit::RemotePresentationContext::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.cpp:
(WebKit::RemoteShaderModule::RemoteShaderModule):
(WebKit::RemoteShaderModule::stopListeningForIPC):
(WebKit::RemoteShaderModule::compilationInfo):
(WebKit::RemoteShaderModule::setLabel):
(WebKit::RemoteShaderModule::protectedBacking):
(WebKit::RemoteShaderModule::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp:
(WebKit::WebGPU::RemoteAdapterProxy::requestDevice):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp:
(WebKit::WebGPU::RemoteDeviceProxy::createXRBinding):
(WebKit::WebGPU::RemoteDeviceProxy::createBuffer):
(WebKit::WebGPU::RemoteDeviceProxy::createTexture):
(WebKit::WebGPU::RemoteDeviceProxy::createSampler):
(WebKit::WebGPU::RemoteDeviceProxy::importExternalTexture):
(WebKit::WebGPU::RemoteDeviceProxy::updateExternalTexture):
(WebKit::WebGPU::RemoteDeviceProxy::createBindGroupLayout):
(WebKit::WebGPU::RemoteDeviceProxy::createPipelineLayout):
(WebKit::WebGPU::RemoteDeviceProxy::createBindGroup):
(WebKit::WebGPU::RemoteDeviceProxy::createShaderModule):
(WebKit::WebGPU::RemoteDeviceProxy::createComputePipeline):
(WebKit::WebGPU::RemoteDeviceProxy::createRenderPipeline):
(WebKit::WebGPU::RemoteDeviceProxy::createComputePipelineAsync):
(WebKit::WebGPU::RemoteDeviceProxy::createRenderPipelineAsync):
(WebKit::WebGPU::RemoteDeviceProxy::createCommandEncoder):
(WebKit::WebGPU

[webkit-changes] [WebKit/WebKit] 9827a6: Adopt more smart pointers in GPUProcess/graphics (...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9827a6f785a6f929421ff4c909dfad3ac63e3c1f
  
https://github.com/WebKit/WebKit/commit/9827a6f785a6f929421ff4c909dfad3ac63e3c1f
  Author: Rupin Mittal 
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCompositorIntegrationProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/graphics (part 3)
https://bugs.webkit.org/show_bug.cgi?id=280694
rdar://137069460

Reviewed by Chris Dumez and Mike Wyrzykowski.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp:
(WebKit::RemoteCommandEncoder::beginRenderPass):
(WebKit::RemoteCommandEncoder::beginComputePass):
(WebKit::RemoteCommandEncoder::copyBufferToBuffer):
(WebKit::RemoteCommandEncoder::copyBufferToTexture):
(WebKit::RemoteCommandEncoder::copyTextureToBuffer):
(WebKit::RemoteCommandEncoder::copyTextureToTexture):
(WebKit::RemoteCommandEncoder::clearBuffer):
(WebKit::RemoteCommandEncoder::pushDebugGroup):
(WebKit::RemoteCommandEncoder::popDebugGroup):
(WebKit::RemoteCommandEncoder::insertDebugMarker):
(WebKit::RemoteCommandEncoder::writeTimestamp):
(WebKit::RemoteCommandEncoder::resolveQuerySet):
(WebKit::RemoteCommandEncoder::finish):
(WebKit::RemoteCommandEncoder::setLabel):
(WebKit::RemoteCommandEncoder::protectedBacking):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.cpp:
(WebKit::RemoteCompositorIntegration::RemoteCompositorIntegration):
(WebKit::RemoteCompositorIntegration::paintCompositedResultsToCanvas):
(WebKit::RemoteCompositorIntegration::stopListeningForIPC):
(WebKit::RemoteCompositorIntegration::recreateRenderBuffers):
(WebKit::RemoteCompositorIntegration::prepareForDisplay):
(WebKit::RemoteCompositorIntegration::protectedBacking):
(WebKit::RemoteCompositorIntegration::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp:
(WebKit::RemoteQueue::destruct):
(WebKit::RemoteQueue::submit):
(WebKit::RemoteQueue::onSubmittedWorkDone):
(WebKit::RemoteQueue::writeBuffer):
(WebKit::RemoteQueue::writeTexture):
(WebKit::RemoteQueue::copyExternalImageToTexture):
(WebKit::RemoteQueue::setLabel):
(WebKit::RemoteQueue::protectedBacking):
(WebKit::RemoteQueue::protectedObjectHeap const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.cpp:
(WebKit::RemoteTextureView::RemoteTextureView):
(WebKit::RemoteTextureView::destruct):
(WebKit::RemoteTextureView::stopListeningForIPC):
(WebKit::RemoteTextureView::setLabel):
(WebKit::RemoteTextureView::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp:
(WebKit::WebGPU::RemoteCommandEncoderProxy::beginRenderPass):
(WebKit::WebGPU::RemoteCommandEncoderProxy::beginComputePass):
(WebKit::WebGPU::RemoteCommandEncoderProxy::copyBufferToBuffer):
(WebKit::WebGPU::RemoteCommandEncoderProxy::copyBufferToTexture):
(WebKit::WebGPU::RemoteCommandEncoderProxy::copyTextureToBuffer):
(WebKit::WebGPU::RemoteCommandEncoderProxy::copyTextureToTexture):
(WebKit::WebGPU::RemoteCommandEncoderProxy::clearBuffer):
(WebKit::WebGPU::RemoteCommandEncoderProxy::writeTimestamp):
(WebKit::WebGPU::RemoteCommandEncoderProxy::resolveQuerySet):
(WebKit::WebGPU::RemoteCommandEncoderProxy::finish):
(WebKit::WebGPU::RemoteCommandEncoderProxy::protectedConvertToBackingContext 
const):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.h:
* 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCompositorIntegrationProxy.cpp:
(WebKit::WebGPU::RemoteCompositorIntegrationProxy::prepareForDisplay):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp:
(WebKit::WebGPU::RemoteQueueProxy::submit):
(WebKit::WebGPU::RemoteQueueProxy::writeBuffer):
(WebKit::WebGPU

[webkit-changes] [WebKit/WebKit] 697816: Adopt smart pointers in more GPUProcess files

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 697816712dab2d91eff5343d0511586edad9cd97
  
https://github.com/WebKit/WebKit/commit/697816712dab2d91eff5343d0511586edad9cd97
  Author: Rupin Mittal 
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
M Source/WebKit/GPUProcess/RemoteSharedResourceCache.cpp
M Source/WebKit/GPUProcess/ShapeDetection/RemoteFaceDetector.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundle.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundle.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRBinding.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/WebProcess/GPU/ShapeDetection/RemoteFaceDetectorProxy.cpp
M Source/WebKit/WebProcess/GPU/ShapeDetection/RemoteFaceDetectorProxy.h

  Log Message:
  ---
  Adopt smart pointers in more GPUProcess files
https://bugs.webkit.org/show_bug.cgi?id=280988
rdar://137437166

Reviewed by Ryosuke Niwa and Mike Wyrzykowski.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::m_sharedPreferencesForWebProcess):
(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::didClose):
(WebKit::GPUConnectionToWebProcess::lowMemoryHandler):
(WebKit::GPUConnectionToWebProcess::updateSharedPreferencesForWebProcess):
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:
(WebKit::GPUConnectionToWebProcess::protectedConnection const): Deleted.
* Source/WebKit/GPUProcess/RemoteSharedResourceCache.cpp:
(WebKit::RemoteSharedResourceCache::lowMemoryHandler):
* Source/WebKit/GPUProcess/ShapeDetection/RemoteFaceDetector.cpp:
(WebKit::RemoteFaceDetector::detect):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp:
(WebKit::RemoteBuffer::RemoteBuffer):
(WebKit::RemoteBuffer::stopListeningForIPC):
(WebKit::RemoteBuffer::mapAsync):
(WebKit::RemoteBuffer::getMappedRange):
(WebKit::RemoteBuffer::unmap):
(WebKit::RemoteBuffer::copy):
(WebKit::RemoteBuffer::destroy):
(WebKit::RemoteBuffer::destruct):
(WebKit::RemoteBuffer::setLabel):
(WebKit::RemoteBuffer::protectedBacking):
(WebKit::RemoteBuffer::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundle.cpp:
(WebKit::RemoteRenderBundle::RemoteRenderBundle):
(WebKit::RemoteRenderBundle::destruct):
(WebKit::RemoteRenderBundle::stopListeningForIPC):
(WebKit::RemoteRenderBundle::setLabel):
(WebKit::RemoteRenderBundle::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundle.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.cpp:
(WebKit::RemoteTexture::createView):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRBinding.cpp:
(WebKit::RemoteXRBinding::destruct):
* Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp:
(WebKit::RemoteAudioSessionProxyManager::updateSpatialExperience):
(WebKit::RemoteAudioSessionProxyManager::hasOtherActiveProxyThan):
(WebKit::RemoteAudioSessionProxyManager::hasActiveNotInterruptedProxy):
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/WebProcess/GPU/ShapeDetection/RemoteFaceDetectorProxy.cpp:
(WebKit::ShapeDetection::RemoteFaceDetectorProxy::~RemoteFaceDetectorProxy):
(WebKit::ShapeDetection::RemoteFaceDetectorProxy::detect):
(WebKit::ShapeDetection::RemoteFaceDetectorProxy::protectedStreamClientConnection
 const):
* Source/WebKit/WebProcess/GPU/ShapeDetection/RemoteFaceDetectorProxy.h:

Canonical link: https://commits.webkit.org/284789@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd2ef1: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd2ef148fe9e3887b1f3f0a84d7e138173b6f809
  
https://github.com/WebKit/WebKit/commit/bd2ef148fe9e3887b1f3f0a84d7e138173b6f809
  Author: Rupin Mittal 
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebNavigationState.cpp
M Source/WebKit/UIProcess/WebNavigationState.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make WebNavigationState ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281464
rdar://137914645

Reviewed by Chris Dumez and Geoffrey Garen.

WebNavigationState is owned by WebPageProxy, so WebNavigationState forwards
ref/deref'ing to WebPageProxy.

* Source/WebKit/UIProcess/WebNavigationState.cpp:
(WebKit::WebNavigationState::WebNavigationState):
(WebKit::WebNavigationState::ref const):
(WebKit::WebNavigationState::deref const):
* Source/WebKit/UIProcess/WebNavigationState.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::launchProcessForReload):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadSimulatedRequest):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didDestroyNavigationShared):
(WebKit::WebPageProxy::processIsNoLongerAssociatedWithPage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
(WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation):
(WebKit::WebPageProxy::protectedNavigationState):
* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/285239@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 09fcd1: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 09fcd1e009e755c345383b09640e4bc2903bc54e
  
https://github.com/WebKit/WebKit/commit/09fcd1e009e755c345383b09640e4bc2903bc54e
  Author: Rupin Mittal 
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M 
Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp
M 
Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.h
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make 
WebDeviceOrientationAndMotionAccessController ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281353
rdar://137781505

Reviewed by Chris Dumez and Geoffrey Garen.

We forward WebDeviceOrientationAndMotionAccessController's ref/deref
to it's owner WebsiteDataStore.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationActionPolicyDecision):
(WebKit::WebPageProxy::shouldAllowDeviceOrientationAndMotionAccess):
* 
Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp:
(WebKit::WebDeviceOrientationAndMotionAccessController::WebDeviceOrientationAndMotionAccessController):
(WebKit::WebDeviceOrientationAndMotionAccessController::ref const):
(WebKit::WebDeviceOrientationAndMotionAccessController::deref const):
(WebKit::WebDeviceOrientationAndMotionAccessController::clearPermissions): 
Deleted.
* 
Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.h:
(WebKit::WebDeviceOrientationAndMotionAccessController::clearPermissions):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::protectedDeviceOrientationAndMotionAccessController):

Canonical link: https://commits.webkit.org/285242@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b7f8ba: Drop IsDeprecatedWeakRefSmartPointerException from...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7f8ba6a5b1056bdd8a909d9fba303671a9365b2
  
https://github.com/WebKit/WebKit/commit/b7f8ba6a5b1056bdd8a909d9fba303671a9365b2
  Author: Rupin Mittal 
  Date:   2024-10-19 (Sat, 19 Oct 2024)

  Changed paths:
M Source/WebCore/Modules/webaudio/AudioContext.h
M Source/WebCore/Modules/webaudio/BaseAudioContext.h
M Source/WebCore/dom/Document.cpp
M Source/WebCore/page/MediaCanStartListener.h
M Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp
M Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.h
M Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h
M 
Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.cpp
M 
Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.h
M Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h
M Source/WebKit/WebProcess/WebCoreSupport/WebMediaKeySystemClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebMediaKeySystemClient.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h

  Log Message:
  ---
  Drop IsDeprecatedWeakRefSmartPointerException from 
UserMediaPermissionRequestManager
https://bugs.webkit.org/show_bug.cgi?id=281724
rdar://138168649

Reviewed by Chris Dumez.

UserMediaPermissionRequestManager forwards its ref/deref to its owner WebPage.

* Source/WebCore/Modules/webaudio/AudioContext.h:
* Source/WebCore/Modules/webaudio/BaseAudioContext.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::takeAnyMediaCanStartListener):
* Source/WebCore/page/MediaCanStartListener.h:
* Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::RealtimeMediaSourceCenter::captureDeviceWillBeRemoved):
(WebCore::RealtimeMediaSourceCenter::triggerDevicesChangedObservers):
* Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.h:
* Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h:
* 
Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.cpp:
(WebKit::MediaKeySystemPermissionRequestManager::ref const):
(WebKit::MediaKeySystemPermissionRequestManager::deref const):
* 
Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.h:
* Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebMediaKeySystemClient.cpp:
(WebKit::WebMediaKeySystemClient::protectedPage const):
(WebKit::WebMediaKeySystemClient::requestMediaKeySystem):
(WebKit::WebMediaKeySystemClient::cancelMediaKeySystemRequest):
* Source/WebKit/WebProcess/WebCoreSupport/WebMediaKeySystemClient.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::protectedMediaKeySystemPermissionRequestManager):
(WebKit::WebPage::mediaKeySystemWasGranted):
(WebKit::WebPage::mediaKeySystemWasDenied):
* Source/WebKit/WebProcess/WebPage/WebPage.h:

Canonical link: https://commits.webkit.org/285464@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fffcab: Adopt more smart pointers in Cookie Store API rela...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fffcabbac578cf202b46286d4101c2daef3eaa01
  
https://github.com/WebKit/WebKit/commit/fffcabbac578cf202b46286d4101c2daef3eaa01
  Author: Rupin Mittal 
  Date:   2024-10-19 (Sat, 19 Oct 2024)

  Changed paths:
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/workers/WorkerGlobalScope.cpp
M Source/WebCore/workers/WorkerGlobalScope.h
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp
M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/WebProcess/WebProcess.h

  Log Message:
  ---
  Adopt more smart pointers in Cookie Store API related code
https://bugs.webkit.org/show_bug.cgi?id=281738
rdar://138174266

Reviewed by Geoffrey Garen and Chris Dumez.

Smart pointer adoption as per the static analyzer.

* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::MainThreadBridge::ensureOnMainThread):
(WebCore::CookieStore::MainThreadBridge::getAll):
(WebCore::CookieStore::MainThreadBridge::set):
(WebCore::CookieStore::~CookieStore):
(WebCore::CookieStore::stop):
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::protectedThread const):
* Source/WebCore/workers/WorkerGlobalScope.h:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp:
(WebKit::WebCookieCache::cookiesForDOM):
(WebKit::WebCookieCache::clear):
(WebKit::WebCookieCache::clearForHost):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::shouldBlockCookies):
(WebKit::WebCookieJar::isEligibleForCache const):
(WebKit::shouldRelaxThirdPartyCookieBlocking):
(WebKit::WebCookieJar::cookies const):
(WebKit::WebCookieJar::setCookies):
(WebKit::WebCookieJar::cookiesEnabled):
(WebKit::WebCookieJar::remoteCookiesEnabledSync const):
(WebKit::WebCookieJar::remoteCookiesEnabled const):
(WebKit::WebCookieJar::cookieRequestHeaderFieldValue const):
(WebKit::WebCookieJar::getRawCookies const):
(WebKit::WebCookieJar::setRawCookie):
(WebKit::WebCookieJar::deleteCookie):
(WebKit::WebCookieJar::getCookiesAsync const):
(WebKit::WebCookieJar::setCookieAsync const):
(WebKit::WebCookieJar::addChangeListener):
(WebKit::WebCookieJar::removeChangeListener):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::protectedCookieJar):
* Source/WebKit/WebProcess/WebProcess.h:

Canonical link: https://commits.webkit.org/285466@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 464ae7: Drop IsDeprecatedWeakRefSmartPointerException from...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 464ae7587760613493986520f2543cfb6b0b0198
  
https://github.com/WebKit/WebKit/commit/464ae7587760613493986520f2543cfb6b0b0198
  Author: Rupin Mittal 
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
M 
Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h

  Log Message:
  ---
  Drop IsDeprecatedWeakRefSmartPointerException from VirtualAuthenticatorManager
https://bugs.webkit.org/show_bug.cgi?id=281735
rdar://138173190

Reviewed by Geoffrey Garen and Chris Dumez.

VirtualAuthenticatorManager is already ref-counted.

* 
Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h:

Canonical link: https://commits.webkit.org/285432@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3795f9: Drop IsDeprecatedWeakRefSmartPointerException from...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3795f9bc47b07d4b3ba5fee7430ca86e63fa0c9f
  
https://github.com/WebKit/WebKit/commit/3795f9bc47b07d4b3ba5fee7430ca86e63fa0c9f
  Author: Rupin Mittal 
  Date:   2024-10-21 (Mon, 21 Oct 2024)

  Changed paths:
M 
Source/WebKit/UIProcess/Cocoa/SOAuthorization/NavigationSOAuthorizationSession.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebViewDidMoveToWindowObserver.h

  Log Message:
  ---
  Drop IsDeprecatedWeakRefSmartPointerException from 
WebViewDidMoveToWindowObserver
https://bugs.webkit.org/show_bug.cgi?id=281733
rdar://138170848

Reviewed by Geoffrey Garen and Chris Dumez.

Make WebViewDidMoveToWindowObserver ref-counted.

* 
Source/WebKit/UIProcess/Cocoa/SOAuthorization/NavigationSOAuthorizationSession.h:
(WebKit::NavigationSOAuthorizationSession::ref const):
(WebKit::NavigationSOAuthorizationSession::deref const):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::webViewDidMoveToWindow):
* Source/WebKit/UIProcess/WebViewDidMoveToWindowObserver.h:

Canonical link: https://commits.webkit.org/285523@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 24571d: Drop IsDeprecatedWeakRefSmartPointerException from...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24571d6c14c80adfa95c868880c487448d6f6899
  
https://github.com/WebKit/WebKit/commit/24571d6c14c80adfa95c868880c487448d6f6899
  Author: Rupin Mittal 
  Date:   2024-10-20 (Sun, 20 Oct 2024)

  Changed paths:
M Source/WebCore/html/ColorInputType.cpp
M Source/WebCore/html/ColorInputType.h
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/loader/EmptyClients.h
M Source/WebCore/page/Chrome.cpp
M Source/WebCore/page/Chrome.h
M Source/WebCore/page/ChromeClient.h
M Source/WebCore/platform/ColorChooser.h
M Source/WebCore/platform/ColorChooserClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm

  Log Message:
  ---
  Drop IsDeprecatedWeakRefSmartPointerException from WebColorChooser
https://bugs.webkit.org/show_bug.cgi?id=281720
rdar://138165163

Reviewed by Geoffrey Garen and Chris Dumez.

Remove the exception by making WebColorChooser ref-counted. Since it's now
ref-counted, it can out-live it's m_colorChooserClient member. So we make
m_colorChooserClient a WeakPtr and null-check before use.

* Source/WebCore/html/ColorInputType.cpp:
(WebCore::ColorInputType::setValue):
(WebCore::ColorInputType::showPicker):
(WebCore::ColorInputType::endColorChooser):
* Source/WebCore/html/ColorInputType.h:
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::createColorChooser):
* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/page/Chrome.cpp:
(WebCore::Chrome::createColorChooser):
* Source/WebCore/page/Chrome.h:
* Source/WebCore/page/ChromeClient.h:
* Source/WebCore/platform/ColorChooser.h:
* Source/WebCore/platform/ColorChooserClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createColorChooser):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:
(WebKit::WebColorChooser::didChooseColor):
(WebKit::WebColorChooser::didEndChooser):
(WebKit::WebColorChooser::reattachColorChooser):
* Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.h:
(WebKit::WebColorChooser::create):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
(WebKit::WebPage::didEndColorPicker):
(WebKit::WebPage::didChooseColor):
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createColorChooser):

Canonical link: https://commits.webkit.org/285496@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2d61ca: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d61ca6cdb324fb7e5de0180473a7843f82428d7
  
https://github.com/WebKit/WebKit/commit/2d61ca6cdb324fb7e5de0180473a7843f82428d7
  Author: Rupin Mittal 
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebContextMenuListenerProxy.cpp
M Source/WebKit/UIProcess/WebContextMenuListenerProxy.h
M Source/WebKit/UIProcess/WebContextMenuProxy.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make 
WebContextMenuListenerProxyClient ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281557
rdar://138016028

Reviewed by Chris Dumez and Geoffrey Garen.

Remove IsDeprecatedWeakRefSmartPointerException] by making
WebContextMenuListenerProxyClient ref-counted. The sub-classes of
WebContextMenuListenerProxyClient are already ref-counted, so this
does not require any other refactoring.

* Source/WebKit/UIProcess/WebContextMenuListenerProxy.cpp:
(WebKit::WebContextMenuListenerProxy::useContextMenuItems):
* Source/WebKit/UIProcess/WebContextMenuListenerProxy.h:
* Source/WebKit/UIProcess/WebContextMenuProxy.h:

Canonical link: https://commits.webkit.org/285314@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c2dea7: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2dea7aaf6eb365fe0ff325254c1a44aba2e6572
  
https://github.com/WebKit/WebKit/commit/c2dea7aaf6eb365fe0ff325254c1a44aba2e6572
  Author: Rupin Mittal 
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
M Source/WebCore/html/TextFieldInputType.cpp
M Source/WebCore/html/TextFieldInputType.h
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/loader/EmptyClients.h
M Source/WebCore/page/Chrome.cpp
M Source/WebCore/page/Chrome.h
M Source/WebCore/page/ChromeClient.h
M Source/WebCore/platform/DataListSuggestionPicker.h
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make WebDataListSuggestionPicker 
ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281341
rdar://137771975

Reviewed by Chris Dumez.

Remove IsDeprecatedWeakRefSmartPointerException] by making 
WebDataListSuggestionPicker
ref-counted. Since WebDataListSuggestionPicker could now outlive WebPage or
DataListSuggestionsClient, we make those members WeakPtr and CheckedPtr and 
null-check
them before use. Accordingly, we ensure the DataListSuggestionsClient is set to 
nullptr
before the DataListSuggestionsClient is destroyed.

* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::~TextFieldInputType):
(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::didCloseSuggestions):
(WebCore::TextFieldInputType::displaySuggestions):
(WebCore::TextFieldInputType::closeSuggestions):
* Source/WebCore/html/TextFieldInputType.h:
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::createDataListSuggestionPicker):
* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/page/Chrome.cpp:
(WebCore::Chrome::createDataListSuggestionPicker):
* Source/WebCore/page/Chrome.h:
* Source/WebCore/page/ChromeClient.h:
* Source/WebCore/platform/DataListSuggestionPicker.h:
(WebCore::DataListSuggestionPicker::detach):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createDataListSuggestionPicker):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.cpp:
(WebKit::WebDataListSuggestionPicker::handleKeydownWithIdentifier):
(WebKit::WebDataListSuggestionPicker::didSelectOption):
(WebKit::WebDataListSuggestionPicker::didCloseSuggestions):
(WebKit::WebDataListSuggestionPicker::close):
(WebKit::WebDataListSuggestionPicker::displayWithActivationType):
(WebKit::WebDataListSuggestionPicker::detach):
* Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didSelectDataListOption):
(WebKit::WebPage::didCloseSuggestions):
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createDataListSuggestionPicker):

Canonical link: https://commits.webkit.org/285306@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 06d849: [IsDeprecatedWeakRefSmartPointerException] Remove ...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 06d849415c31fc9b3d9b32eded8b601692390e4a
  
https://github.com/WebKit/WebKit/commit/06d849415c31fc9b3d9b32eded8b601692390e4a
  Author: Rupin Mittal 
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Remove exception from 
RemoteRenderingBackendProxy
https://bugs.webkit.org/show_bug.cgi?id=281558
rdar://138016364

Reviewed by Chris Dumez and Geoffrey Garen.

Since RemoteRenderingBackendProxy does not inherit from `CanMakeWeakPtr`,
it does not need IsDeprecatedWeakRefSmartPointerException.

* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:

Canonical link: https://commits.webkit.org/285283@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c7f286: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7f286cac5e719c0493d44658f8a381f0e8b6738
  
https://github.com/WebKit/WebKit/commit/c7f286cac5e719c0493d44658f8a381f0e8b6738
  Author: Rupin Mittal 
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebLockRegistryProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make WebLockRegistryProxy 
ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281465
rdar://137916057

Reviewed by Chris Dumez.

Forward WebLockRegistryProxy's ref/deref to its owner WebProcessProxy.

* Source/WebKit/UIProcess/WebLockRegistryProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setWebsiteDataStore):
(WebKit::WebProcessProxy::shutDown):

Canonical link: https://commits.webkit.org/285274@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 86f47a: Adopt more smart pointers in WebPageProxy (part 1)

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86f47a122dab488a2ba7f695bd582028193107bd
  
https://github.com/WebKit/WebKit/commit/86f47a122dab488a2ba7f695bd582028193107bd
  Author: Rupin Mittal 
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
M Source/WebKit/UIProcess/API/APIPageConfiguration.h
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
M Source/WebKit/UIProcess/ProvisionalPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebProcessPool.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm

  Log Message:
  ---
  Adopt more smart pointers in WebPageProxy (part 1)
https://bugs.webkit.org/show_bug.cgi?id=281075
rdar://137526627

Reviewed by Ryosuke Niwa and Chris Dumez.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::setRelatedPage): Deleted.
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::setRelatedPage):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::didGeneratePageLoadTiming):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
(WebKit::WebPageProxy::Internals::sharedPreferencesForWebPaymentMessages const):
(WebKit::WebPageProxy::Internals::paymentCoordinatorPresentingWindow const):
(WebKit::WebPageProxy::fullscreenVideoTextRecognitionTimerFired):
(WebKit::WebPageProxy::tryToSendCommandToActiveControlledVideo):
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::protectedBrowsingContextGroup):
* Source/WebKit/UIProcess/ProvisionalPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::takeVisibleActivity):
(WebKit::WebPageProxy::takeAudibleActivity):
(WebKit::WebPageProxy::takeCapturingActivity):
(WebKit::WebPageProxy::takeMutedCaptureAssertion):
(WebKit::WebPageProxy::resetActivityState):
(WebKit::WebPageProxy::dropVisibleActivity):
(WebKit::WebPageProxy::dropAudibleActivity):
(WebKit::WebPageProxy::dropCapturingActivity):
(WebKit::WebPageProxy::dropMutedCaptureAssertion):
(WebKit::WebPageProxy::hasValidVisibleActivity const):
(WebKit::WebPageProxy::hasValidAudibleActivity const):
(WebKit::WebPageProxy::hasValidCapturingActivity const):
(WebKit::WebPageProxy::hasValidMutedCaptureAssertion const):
(WebKit::WebPageProxy::takeOpeningAppLinkActivity):
(WebKit::WebPageProxy::dropOpeningAppLinkActivity):
(WebKit::WebPageProxy::hasValidOpeningAppLinkActivity const):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::m_pageForTesting):
(WebKit::WebPageProxy::sharedPreferencesForWebProcess const):
(WebKit::WebPageProxy::attachmentElementEnabled):
(WebKit::WebPageProxy::modelElementEnabled):
(WebKit::WebPageProxy::send):
(WebKit::WebPageProxy::setPageLoadStateObserver):
(WebKit::WebPageProxy::handleMessageWithAsyncReply):
(WebKit::WebPageProxy::launchProcess):
(WebKit::WebPageProxy::suspendCurrentPageIfPossible):
(WebKit::WebPageProxy::shouldUseBackForwardCache const):
(WebKit::WebPageProxy::setBrowsingContextGroup):
(WebKit::WebPageProxy::swapToProvisionalPage):
(WebKit::WebPageProxy::finishAttachingToWebProcess):
(WebKit::WebPageProxy::didAttachToRunningProcess):
(WebKit::WebPageProxy::launchProcessForReload):
(WebKit::WebPageProxy::setDrawingArea):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::setControlledByAutomation):
(WebKit::WebPageProxy::disableServiceWorkerEntitlementInNetworkProcess):
(WebKit::WebPageProxy::observeAndCreateRemoteSubframesInOtherProcesses):
(WebKit::WebPageProxy::logFrameNavigation):
(WebKit::WebPageProxy::protectedPlaybackSessionManager):
(WebKit::WebPageProxy::isJITEnabled):
(WebKit::WebPageProxy::protectedBrowsingContextGroup const):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebProcessPool.h:
(WebKit::WebProcessProxy::processPool const):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::processPool const): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showValidationMessage):

Canonical link: https://commits.webkit.org/284984@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

[webkit-changes] [WebKit/WebKit] c1b908: Adopt more smart pointers in media and webrtc files

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1b9086983fd1aa00746b6f97e0718dfebf4fe28
  
https://github.com/WebKit/WebKit/commit/c1b9086983fd1aa00746b6f97e0718dfebf4fe28
  Author: Rupin Mittal 
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
M Source/WebCore/platform/graphics/MediaPlayer.cpp
M Source/WebCore/platform/graphics/MediaPlayer.h
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm

  Log Message:
  ---
  Adopt more smart pointers in media and webrtc files
https://bugs.webkit.org/show_bug.cgi?id=280841
rdar://137225606

Reviewed by Ryosuke Niwa.

Smart pointer adoption as per the static analyzer.

* Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::protectedPlayerPrivate):
* Source/WebCore/platform/graphics/MediaPlayer.h:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::loadMediaSource):
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy):
(WebKit::LibWebRTCCodecsProxy::updateSharedPreferencesForWebProcess):

Canonical link: https://commits.webkit.org/284650@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a0b60b: Suppress static analyzer false-positive warnings u...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a0b60b95688050ca27cd988d8aa9e8373828874a
  
https://github.com/WebKit/WebKit/commit/a0b60b95688050ca27cd988d8aa9e8373828874a
  Author: Rupin Mittal 
  Date:   2024-10-04 (Fri, 04 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandBuffer.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteExternalTexture.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePipelineLayout.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQuerySet.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundle.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteSampler.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRBinding.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRProjectionLayer.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRSubImage.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRView.h
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteCDMProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteLegacyCDMProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp
M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
M Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp
M 
Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.cpp
M Source/WebKit/UIProcess/SpeechRecognitionServer.cpp
M Source/WebKit/UIProcess/WebLockRegistryProxy.h
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp

  Log Message:
  ---
  Suppress static analyzer false-positive warnings until they're fixed.
https://bugs.webkit.org/show_bug.cgi?id=280906
rdar://137304761

Reviewed by Ryosuke Niwa and Mike Wyrzykowski.

Suppress false positives until they're fixed by 
https://github.com/llvm/llvm-project/pull/98.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandBuffer.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteExternalTexture.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemotePipelineLayout.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQuerySet.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundle.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteSampler.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRBinding.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRProjectionLayer.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRSubImage.h

[webkit-changes] [WebKit/WebKit] 759668: Drop IsDeprecatedWeakRefSmartPointerException from...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 759668c3b7e07ee703f5a0ea76ecbcb0965e2787
  
https://github.com/WebKit/WebKit/commit/759668c3b7e07ee703f5a0ea76ecbcb0965e2787
  Author: Rupin Mittal 
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxyInternals.h
M Source/WebKit/UIProcess/XR/PlatformXRCoordinator.h
M Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp
M Source/WebKit/UIProcess/XR/PlatformXRSystem.h
M Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm

  Log Message:
  ---
  Drop IsDeprecatedWeakRefSmartPointerException from PlatformXRSystem and 
PlatformXRCoordinator
https://bugs.webkit.org/show_bug.cgi?id=281740
rdar://138175388

Reviewed by Chris Dumez.

Drop the exception by making both classes ref-counted.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didAttachToRunningProcess):
(WebKit::WebPageProxy::restartXRSessionActivityOnProcessResumeIfNeeded):
(WebKit::WebPageProxy::resetState):
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/UIProcess/XR/PlatformXRCoordinator.h:
* Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp:
(WebKit::PlatformXRSystem::PlatformXRSystem):
(WebKit::PlatformXRSystem::~PlatformXRSystem):
(WebKit::PlatformXRSystem::sharedPreferencesForWebProcess const):
(WebKit::PlatformXRSystem::invalidate):
(WebKit::PlatformXRSystem::ensureImmersiveSessionActivity):
(WebKit::PlatformXRSystem::enumerateImmersiveXRDevices):
(WebKit::PlatformXRSystem::requestPermissionOnSessionFeatures):
(WebKit::PlatformXRSystem::initializeTrackingAndRendering):
(WebKit::PlatformXRSystem::shutDownTrackingAndRendering):
(WebKit::PlatformXRSystem::requestFrame):
(WebKit::PlatformXRSystem::submitFrame):
(WebKit::PlatformXRSystem::didCompleteShutdownTriggeredBySystem):
(WebKit::PlatformXRSystem::sessionDidEnd):
(WebKit::PlatformXRSystem::sessionDidUpdateVisibilityState):
(WebKit::PlatformXRSystem::setImmersiveSessionState):
(WebKit::PlatformXRSystem::webXREnabled const):
(WebKit::PlatformXRSystem::protectedPage const): Deleted.
* Source/WebKit/UIProcess/XR/PlatformXRSystem.h:
(WebKit::PlatformXRSystem::create):
* Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm:
(WebKit::ARKitCoordinator::startSession):

Canonical link: https://commits.webkit.org/285559@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f76b82: Drop IsDeprecatedWeakRefSmartPointerException from...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f76b826b5fc047c430744a474795de677f948f22
  
https://github.com/WebKit/WebKit/commit/f76b826b5fc047c430744a474795de677f948f22
  Author: Rupin Mittal 
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.h
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp
M Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp
M Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.h
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/WebProcess/WebProcess.h

  Log Message:
  ---
  Drop IsDeprecatedWeakRefSmartPointerException from WebMDNSRegister
https://bugs.webkit.org/show_bug.cgi?id=281729
rdar://138170193

Reviewed by Chris Dumez.

WebMDNSRegister forwards its ref-counting to its owner LibWebRTCNetwork,
which forwards its own ref-counting to its owner WebProcess.

* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp:
(WebKit::LibWebRTCNetwork::LibWebRTCNetwork):
(WebKit::LibWebRTCNetwork::ref const):
(WebKit::LibWebRTCNetwork::deref const):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.h:
(WebKit::LibWebRTCNetwork::create): Deleted.
(WebKit::LibWebRTCNetwork::connection): Deleted.
(WebKit::LibWebRTCNetwork::isActive const): Deleted.
(WebKit::LibWebRTCNetwork::monitor): Deleted.
(WebKit::LibWebRTCNetwork::socketFactory): Deleted.
(WebKit::LibWebRTCNetwork::disableNonLocalhostConnections): Deleted.
(WebKit::LibWebRTCNetwork::resolver): Deleted.
(WebKit::LibWebRTCNetwork::mdnsRegister): Deleted.
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp:
(WebKit::LibWebRTCNetworkManager::unregisterMDNSNames):
(WebKit::LibWebRTCNetworkManager::CreateNameForAddress):
* Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp:
(WebKit::WebMDNSRegister::WebMDNSRegister):
(WebKit::WebMDNSRegister::ref const):
(WebKit::WebMDNSRegister::deref const):
(WebKit::WebMDNSRegister::registerMDNSName):
* Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.h:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::libWebRTCNetwork):
(WebKit::WebProcess::protectedLibWebRTCNetwork):
* Source/WebKit/WebProcess/WebProcess.h:

Canonical link: https://commits.webkit.org/285554@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 84c507: Build fix after 285547@main

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 84c50740ffead67c7410d8866cd231501e57a5ac
  
https://github.com/WebKit/WebKit/commit/84c50740ffead67c7410d8866cd231501e57a5ac
  Author: Rupin Mittal 
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  ---
  Build fix after 285547@main
https://bugs.webkit.org/show_bug.cgi?id=281911
rdar://138407951

Reviewed by Charlie Wolfe.

Build Fix.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:

Canonical link: https://commits.webkit.org/285558@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 076349: Drop IsDeprecatedWeakRefSmartPointerException from...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 076349f5d081726a70e001209bb231dd767051ae
  
https://github.com/WebKit/WebKit/commit/076349f5d081726a70e001209bb231dd767051ae
  Author: Rupin Mittal 
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.cpp
M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h
M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivate.h
M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp
M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.h
M 
Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.cpp
M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.h
M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h
M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h
M Source/WebCore/platform/graphics/LegacyCDMSession.h
M Source/WebCore/platform/graphics/MediaPlayer.cpp
M Source/WebCore/platform/graphics/MediaPlayer.h
M Source/WebCore/platform/graphics/MediaPlayerPrivate.h
M 
Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M Source/WebCore/testing/LegacyMockCDM.cpp
M Source/WebCore/testing/LegacyMockCDM.h
M Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.h
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
M Source/WebKit/WebProcess/GPU/media/RemoteLegacyCDM.cpp
M Source/WebKit/WebProcess/GPU/media/RemoteLegacyCDM.h
M Source/WebKit/WebProcess/GPU/media/RemoteLegacyCDMSession.cpp
M Source/WebKit/WebProcess/GPU/media/RemoteLegacyCDMSession.h

  Log Message:
  ---
  Drop IsDeprecatedWeakRefSmartPointerException from RemoteLegacyCDMSession
https://bugs.webkit.org/show_bug.cgi?id=282317
rdar://138894092

Reviewed by Geoffrey Garen.

Drop IsDeprecatedWeakRefSmartPointerException from RemoteLegacyCDMSession by
making it ref-counted.

* Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.cpp:
(WebCore::LegacyCDM::createSession):
* Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h:
* Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivate.h:
* Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp:
(WebCore::LegacyCDMPrivateClearKey::createSession):
* Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.h:
* Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.cpp:
(WebCore::CDMPrivateMediaPlayer::createSession):
* Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.h:
* Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h:
* Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:
* Source/WebCore/platform/graphics/LegacyCDMSession.h:
* Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::createSession):
* Source/WebCore/platform/graphics/MediaPlayer.h:
* Source/WebCore/platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::createSession):
* Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:
(WebCore::CDMPrivateMediaSourceAVFObjC::createSession):
* Source/WebCore/platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
(WebCore::CDMSessionAVContentKeySession::create):
* 
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createSession):
* Source/WebCore/testing/LegacyMockCDM.cpp:
(WebCore::MockCDMSession::create):
(WebCore::LegacyMockCDM::createSession):
* Source/WebCore/testing/LegacyMockCDM.h:
* Source

[webkit-changes] [WebKit/WebKit] 9cfacd: Ensure SQLiteStorageArea does not use SQLiteStatem...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9cfacd819f89639031bcef018ee6955f0824a95f
  
https://github.com/WebKit/WebKit/commit/9cfacd819f89639031bcef018ee6955f0824a95f
  Author: Rupin Mittal 
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
M Source/WebCore/platform/sql/SQLiteStatement.h
M Source/WebCore/platform/sql/SQLiteStatementAutoResetScope.cpp
M Source/WebCore/platform/sql/SQLiteStatementAutoResetScope.h
M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp

  Log Message:
  ---
  Ensure SQLiteStorageArea does not use SQLiteStatement after it's been freed
https://bugs.webkit.org/show_bug.cgi?id=278538
rdar://127866416

Reviewed by Chris Dumez, Geoffrey Garen, and Sihui Liu.

SQLiteStorageArea::getItemFromDatabase() holds a SQLiteStatementAutoResetScope
statement variable. This goes out of scope at the end of getItemFromDatabase()
and so it's destructor is called. There is a crash occurring here. It turns out
that SQLiteStatementAutoResetScope holds a raw pointer to a SQLiteStatement.
A series of function calls: getItemFromDatabase() -> 
handleDatabaseErrorIfNeeded()
-> close() results in this SQLiteStatement object being destroyed
(SQLiteStorageArea holds a unique pointer to this SQLiteStatement object which 
is
destroyed in close()). After this destruction, the SQLiteStatementAutoResetScope
statement variable goes out of scope and it's destructor attempts to access the
raw pointer to the now-destroyed SQLiteStatement object. This use-after-free
causes the crash.

We fix this problem by using a block-scope to ensure the 
SQLiteStatementAutoResetScope
statement variable is destroyed before handleDatabaseErrorIfNeeded() is called. 
Although
the crash was only in getItemFromDatabase(), there are other functions in 
SQLiteStorageArea
that follow this same pattern and could potentially have a use-after-free. We 
make this
block-scope change there as well. Additionally, we change the SQLiteStatement 
raw pointer
in SQLiteStatementAutoResetScope to a CheckedPtr.

We use a block-scope rather than declare a new function 
SQLiteStatementAutoResetScope that
could call reset on the SQLiteStatement object because we want the object to 
live and be
reset in sync with the scope's lifetime.

* Source/WebCore/platform/sql/SQLiteStatement.h:
* Source/WebCore/platform/sql/SQLiteStatementAutoResetScope.cpp:
(WebCore::SQLiteStatementAutoResetScope::operator=): Deleted.
* Source/WebCore/platform/sql/SQLiteStatementAutoResetScope.h:
(WebCore::SQLiteStatementAutoResetScope::operator bool const):
(WebCore::SQLiteStatementAutoResetScope::get):
(WebCore::SQLiteStatementAutoResetScope::operator->):
* Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp:
(WebKit::SQLiteStorageArea::getItemFromDatabase):
(WebKit::SQLiteStorageArea::allItems):
(WebKit::SQLiteStorageArea::setItem):
(WebKit::SQLiteStorageArea::removeItem):
(WebKit::SQLiteStorageArea::clear):

Originally-landed-as: 280938.269@safari-7619-branch (d76a8be1ba40). 
rdar://138875969
Canonical link: https://commits.webkit.org/285939@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9b1ffc: Adopt more smart pointers in RemoteCDMInstanceSess...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b1ffca8bc3f2d8fd1e83a3c6d06e1eb0965a33d
  
https://github.com/WebKit/WebKit/commit/9b1ffca8bc3f2d8fd1e83a3c6d06e1eb0965a33d
  Author: Rupin Mittal 
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h
M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in RemoteCDMInstanceSessionProxy, 
RemoteAudioSessionProxyManager, and RemoteAudioSessionProxy
https://bugs.webkit.org/show_bug.cgi?id=279877
rdar://136208358

Reviewed by Youenn Fablet.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp:
(WebKit::RemoteAudioSessionProxy::configurationChanged):
(WebKit::RemoteAudioSessionProxy::beginInterruption):
(WebKit::RemoteAudioSessionProxy::endInterruption):
(WebKit::RemoteAudioSessionProxy::protectedConnection const):
(WebKit::RemoteAudioSessionProxy::connection): Deleted.
* Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h:
* Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp:
(WebKit::RemoteAudioSessionProxyManager::updatePresentingProcesses):
* Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
(WebKit::RemoteCDMInstanceSessionProxy::updateKeyStatuses):
(WebKit::RemoteCDMInstanceSessionProxy::sendMessage):
(WebKit::RemoteCDMInstanceSessionProxy::sessionIdChanged):

Canonical link: https://commits.webkit.org/283890@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e9e8ec: Adopt more smart pointers in RemoteImageDecoderAVF...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9e8ec4d1acd086c42721398e553c170eea92736
  
https://github.com/WebKit/WebKit/commit/e9e8ec4d1acd086c42721398e553c170eea92736
  Author: Rupin Mittal 
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in RemoteImageDecoderAVFProxy and 
RemoteLegacyCDMSessionProxy
https://bugs.webkit.org/show_bug.cgi?id=279878
rdar://136209504

Reviewed by Youenn Fablet.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp:
(WebKit::RemoteImageDecoderAVFProxy::deleteDecoder):
(WebKit::RemoteImageDecoderAVFProxy::encodedDataStatusChanged):
(WebKit::RemoteImageDecoderAVFProxy::setExpectedContentSize):
(WebKit::RemoteImageDecoderAVFProxy::createFrameImageAtIndex):
(WebKit::RemoteImageDecoderAVFProxy::clearFrameBufferCache):
* Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
(WebKit::RemoteLegacyCDMSessionProxy::sendMessage):
(WebKit::RemoteLegacyCDMSessionProxy::sendError):

Canonical link: https://commits.webkit.org/283891@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 39736f: Adopt more smart pointers in WebExtensionContext-r...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39736fe29ef8f60b794a701ff647e764dfa58911
  
https://github.com/WebKit/WebKit/commit/39736fe29ef8f60b794a701ff647e764dfa58911
  Author: Rupin Mittal 
  Date:   2024-09-21 (Sat, 21 Sep 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp
M Source/WebKit/UIProcess/API/APIContentRuleListStore.h
M Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListStore.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIActionCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICommandsCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICookiesCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIEventCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPortCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIScriptingCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp
M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h
M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm
M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.cpp
M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h

  Log Message:
  ---
  Adopt more smart pointers in WebExtensionContext-related files
https://bugs.webkit.org/show_bug.cgi?id=280093
rdar://136391189

Reviewed by Timothy Hatcher.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:
(API::ContentRuleListStore::defaultStoreSingleton):
(API::ContentRuleListStore::defaultStore): Deleted.
* Source/WebKit/UIProcess/API/APIContentRuleListStore.h:
* Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListStore.mm:
(+[WKContentRuleListStore defaultStore]):
(+[WKContentRuleListStore defaultStoreWithLegacyFilename]):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIActionCocoa.mm:
(WebKit::WebExtensionContext::isActionMessageAllowed):
(WebKit::WebExtensionContext::actionGetTitle):
(WebKit::WebExtensionContext::actionGetPopup):
(WebKit::WebExtensionContext::actionOpenPopup):
(WebKit::WebExtensionContext::actionGetBadgeText):
(WebKit::WebExtensionContext::actionGetEnabled):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICommandsCocoa.mm:
(WebKit::WebExtensionContext::isCommandsMessageAllowed):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICookiesCocoa.mm:
(WebKit::WebExtensionContext::fetchCookies):
(WebKit::WebExtensionContext::cookiesGetAllCookieStores):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm:
(WebKit::WebExtensionContext::loadDeclarativeNetRequestRulesetStateFromStorage):
(WebKit::WebExtensionContext::declarativeNetRequestValidateRulesetIdentifiers):
(WebKit::WebExtensionContext::declarativeNetRequestToggleRulesets):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIEventCocoa.mm:
(WebKit::WebExtensionContext::addListener):
(WebKit::WebExtensionContext::removeListener):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPortCocoa.mm:
(WebKit::WebExtensionContext::firePortMessageEventsIfNeeded):
(WebKit::WebExtensionContext::sendQueuedNativePortMessagesIfNeeded):
(WebKit::WebExtensionContext::firePortDisconnectEventIfNeeded):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm:
(WebKit::WebExtensionContext::runtimeWebPageSendMessage):
(WebKit::WebExtensionContext::runtimeWebPageConnect):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIScriptingCocoa.mm:
(WebKit::WebExtensionContext::scriptingInsertCSS):
(WebKit::WebExtensionContext::createInjectedContentForScripts):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm:
(WebKit::WebExtensionContext::tabsInsertCSS):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::errors):
(WebKit::WebExtensionContext::load):
(WebKit::WebExtensionContext::localization):
(WebKit::WebExtensionContext::setInspectable):
(WebKit::WebExtensionContext::optionsPageURL const):
(WebKit::WebExtensionContext::overrideNewTabPageURL const):
(WebKit::WebExtensionContext::permissionState):
(WebKit::WebExtensionContext::getCurrentTab const):
(WebKit::WebExtensionContext

[webkit-changes] [WebKit/WebKit] 9f9c1d: Adopt more smart pointers in some GPUProcess files

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f9c1d32557f25de7633a1bbfaf7f15426e2318c
  
https://github.com/WebKit/WebKit/commit/9f9c1d32557f25de7633a1bbfaf7f15426e2318c
  Author: Rupin Mittal 
  Date:   2024-09-21 (Sat, 21 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/ImageBufferShareableAllocator.cpp
M Source/WebKit/GPUProcess/graphics/ShareablePixelBuffer.cpp
M Source/WebKit/GPUProcess/graphics/ShareablePixelBuffer.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.cpp
M Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioTrackProxy.cpp
M Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/WebProcess/WebProcess.h

  Log Message:
  ---
  Adopt more smart pointers in some GPUProcess files
https://bugs.webkit.org/show_bug.cgi?id=280115
rdar://136413700

Reviewed by Mike Wyrzykowski.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/graphics/ImageBufferShareableAllocator.cpp:
(WebKit::ImageBufferShareableAllocator::createPixelBuffer const):
* Source/WebKit/GPUProcess/graphics/ShareablePixelBuffer.cpp:
(WebKit::ShareablePixelBuffer::protectedData const):
* Source/WebKit/GPUProcess/graphics/ShareablePixelBuffer.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp:
(WebKit::RemoteBindGroup::destruct):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.cpp:
(WebKit::RemoteCompositorIntegration::destruct):
* Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.cpp:
(WebKit::LocalAudioSessionRoutingArbitrator::beginRoutingArbitrationWithCategory):
(WebKit::LocalAudioSessionRoutingArbitrator::leaveRoutingAbritration):
(WebKit::LocalAudioSessionRoutingArbitrator::canLog const):
* Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.cpp:
(WebKit::RemoteAudioHardwareListenerProxy::audioHardwareDidBecomeActive):
(WebKit::RemoteAudioHardwareListenerProxy::audioHardwareDidBecomeInactive):
(WebKit::RemoteAudioHardwareListenerProxy::audioOutputDeviceChanged):
* Source/WebKit/GPUProcess/media/RemoteAudioTrackProxy.cpp:
(WebKit::RemoteAudioTrackProxy::RemoteAudioTrackProxy):
(WebKit::RemoteAudioTrackProxy::~RemoteAudioTrackProxy):
(WebKit::RemoteAudioTrackProxy::configuration):
(WebKit::RemoteAudioTrackProxy::configurationChanged):
* Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::dispatchMessage):
(WebKit::GPUProcessConnection::didInitialize):
(WebKit::GPUProcessConnection::createVisibilityPropagationContextForPage):
(WebKit::GPUProcessConnection::destroyVisibilityPropagationContextForPage):
(WebKit::GPUProcessConnection::configureLoggingChannel):
(WebKit::GPUProcessConnection::updateMediaConfiguration):
(WebKit::GPUProcessConnection::setMediaEnvironment):
(WebKit::GPUProcessConnection::createRenderingBackend):
(WebKit::GPUProcessConnection::releaseRenderingBackend):
(WebKit::GPUProcessConnection::createGraphicsContextGL):
(WebKit::GPUProcessConnection::releaseGraphicsContextGL):
(WebKit::GPUProcessConnection::createGPU):
(WebKit::GPUProcessConnection::releaseGPU):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::protectedLibWebRTCCodecs):
(WebKit::WebProcess::protectedRemoteMediaPlayerManager):
* Source/WebKit/WebProcess/WebProcess.h:

Canonical link: https://commits.webkit.org/284039@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0d2cb3: Adopt more smart pointers in RemoteMediaPlayerProx...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d2cb3af153dba86d5907bb3a3d869d44541334d
  
https://github.com/WebKit/WebKit/commit/0d2cb3af153dba86d5907bb3a3d869d44541334d
  Author: Rupin Mittal 
  Date:   2024-09-21 (Sat, 21 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in RemoteMediaPlayerProxy (part 2)
https://bugs.webkit.org/show_bug.cgi?id=280114
rdar://136412173

Reviewed by Basuke Suzuki.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerCachedKeyForKeyId const):
(WebKit::RemoteMediaPlayerProxy::setLegacyCDMSession):
(WebKit::RemoteMediaPlayerProxy::cdmInstanceAttached):
(WebKit::RemoteMediaPlayerProxy::cdmInstanceDetached):
(WebKit::RemoteMediaPlayerProxy::attemptToDecryptWithInstance):

Canonical link: https://commits.webkit.org/284040@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 196e7e: Adopt more smart pointers in GPUProcess/media files

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 196e7e8346777164305d3a3484c88c7ff67e
  
https://github.com/WebKit/WebKit/commit/196e7e8346777164305d3a3484c88c7ff67e
  Author: Rupin Mittal 
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.cpp
M Source/WebKit/GPUProcess/media/RemoteTextTrackProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteVideoTrackProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/media files
https://bugs.webkit.org/show_bug.cgi?id=280358
rdar://136710828

Reviewed by Geoffrey Garen.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::commitAllTransactions):
(WebKit::RemoteMediaPlayerProxy::loadMediaSource):
(WebKit::RemoteMediaPlayerProxy::requestResource):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaKeysStorageDirectory const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaCacheDirectory const):
(WebKit::RemoteMediaPlayerProxy::addRemoteAudioTrackProxy):
(WebKit::RemoteMediaPlayerProxy::addRemoteVideoTrackProxy):
(WebKit::RemoteMediaPlayerProxy::addRemoteTextTrackProxy):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerCachedKeyForKeyId const):
(WebKit::RemoteMediaPlayerProxy::setLegacyCDMSession):
(WebKit::RemoteMediaPlayerProxy::cdmInstanceAttached):
(WebKit::RemoteMediaPlayerProxy::cdmInstanceDetached):
(WebKit::RemoteMediaPlayerProxy::attemptToDecryptWithInstance):
(WebKit::RemoteMediaPlayerProxy::sharedPreferencesForWebProcess const):
* Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.cpp:
(WebKit::RemoteMediaResourceLoader::requestResource):
(WebKit::RemoteMediaResourceLoader::sendH2Ping):
* Source/WebKit/GPUProcess/media/RemoteTextTrackProxy.cpp:
(WebKit::RemoteTextTrackProxy::RemoteTextTrackProxy):
(WebKit::RemoteTextTrackProxy::~RemoteTextTrackProxy):
(WebKit::RemoteTextTrackProxy::configuration):
(WebKit::RemoteTextTrackProxy::configurationChanged):
(WebKit::RemoteTextTrackProxy::addDataCue):
(WebKit::RemoteTextTrackProxy::updateDataCue):
(WebKit::RemoteTextTrackProxy::removeDataCue):
(WebKit::RemoteTextTrackProxy::addGenericCue):
(WebKit::RemoteTextTrackProxy::updateGenericCue):
(WebKit::RemoteTextTrackProxy::removeGenericCue):
(WebKit::RemoteTextTrackProxy::parseWebVTTFileHeader):
(WebKit::RemoteTextTrackProxy::parseWebVTTCueData):
* Source/WebKit/GPUProcess/media/RemoteVideoTrackProxy.cpp:
(WebKit::RemoteVideoTrackProxy::RemoteVideoTrackProxy):
(WebKit::RemoteVideoTrackProxy::~RemoteVideoTrackProxy):
(WebKit::RemoteVideoTrackProxy::configuration):
(WebKit::RemoteVideoTrackProxy::updateConfiguration):

Canonical link: https://commits.webkit.org/284264@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 608e68: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 608e68962f08d8e1b0e05c26788b0b08e9552981
  
https://github.com/WebKit/WebKit/commit/608e68962f08d8e1b0e05c26788b0b08e9552981
  Author: Rupin Mittal 
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
M Source/WebKit/Shared/XR/XRDeviceProxy.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp
M Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h
M Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.cpp
M Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.h
M Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.cpp
M Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make WebProcess/XR and 
WebProcess/WebStorage files ref counted
https://bugs.webkit.org/show_bug.cgi?id=280231
rdar://136536190

Reviewed by Chris Dumez.

Remove IsDeprecatedWeakRefSmartPointerException. Since PlatformXRSystemProxy
has a single owner which does not re-assign it, we make PlatformXRSystemProxy
ref counted by adding ref() and deref() functions that forward the ref'ing to
the owner rather than making PlatformXRSystemProxy a subclass of RefCounted<>.

That's not the case for StorageAreaMap, so we make it subclass RefCounted.

* Source/WebKit/Shared/XR/XRDeviceProxy.cpp:
(WebKit::XRDeviceProxy::initializeTrackingAndRendering):
(WebKit::XRDeviceProxy::shutDownTrackingAndRendering):
(WebKit::XRDeviceProxy::didCompleteShutdownTriggeredBySystem):
(WebKit::XRDeviceProxy::requestFrame):
(WebKit::XRDeviceProxy::createLayerProjection):
(WebKit::XRDeviceProxy::submitFrame):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::xrSystemProxy):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::networkProcessConnectionClosed):
* Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::~StorageAreaImpl):
(WebKit::StorageAreaImpl::length):
(WebKit::StorageAreaImpl::key):
(WebKit::StorageAreaImpl::item):
(WebKit::StorageAreaImpl::setItem):
(WebKit::StorageAreaImpl::removeItem):
(WebKit::StorageAreaImpl::clear):
(WebKit::StorageAreaImpl::contains):
(WebKit::StorageAreaImpl::storageType const):
(WebKit::StorageAreaImpl::prewarm):
* Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h:
* Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
* Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.h:
* Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.cpp:
(WebKit::PlatformXRSystemProxy::ref const):
(WebKit::PlatformXRSystemProxy::deref const):
* Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.h:

Canonical link: https://commits.webkit.org/284189@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 095c55: Remove IsDeprecatedWeakRefSmartPointerException fr...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 095c5547863ec1ab1318873faebf412eb435d6ef
  
https://github.com/WebKit/WebKit/commit/095c5547863ec1ab1318873faebf412eb435d6ef
  Author: Rupin Mittal 
  Date:   2024-09-23 (Mon, 23 Sep 2024)

  Changed paths:
M Source/WebKit/webpushd/ApplePushServiceConnection.h
M Source/WebKit/webpushd/ApplePushServiceConnection.mm
M Source/WebKit/webpushd/MockPushServiceConnection.h
M Source/WebKit/webpushd/PushService.h
M Source/WebKit/webpushd/PushService.mm
M Source/WebKit/webpushd/PushServiceConnection.h
M Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h
M Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm
M Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm

  Log Message:
  ---
  Remove IsDeprecatedWeakRefSmartPointerException from webpushd files
https://bugs.webkit.org/show_bug.cgi?id=280204
rdar://136527276

Reviewed by Geoffrey Garen.

Removing IsDeprecatedWeakRefSmartPointerException.

* Source/WebKit/webpushd/ApplePushServiceConnection.h:
* Source/WebKit/webpushd/ApplePushServiceConnection.mm:
* Source/WebKit/webpushd/MockPushServiceConnection.h:
* Source/WebKit/webpushd/PushService.h:
* Source/WebKit/webpushd/PushService.mm:
(WebPushD::PushService::create):
(WebPushD::PushService::createMockService):
(WebPushD::PushService::PushService):
* Source/WebKit/webpushd/PushServiceConnection.h:
* Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:
* Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm:
(WebPushTool::Connection::create):
* Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm:
(WebKit::WebPushToolMain):

Canonical link: https://commits.webkit.org/284136@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a22b3d: Remove dead code (LoadListener in WebFrame)

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a22b3d9f030ecc68be1cddc286fba57cbb843581
  
https://github.com/WebKit/WebKit/commit/a22b3d9f030ecc68be1cddc286fba57cbb843581
  Author: Rupin Mittal 
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.h

  Log Message:
  ---
  Remove dead code (LoadListener in WebFrame)
https://bugs.webkit.org/show_bug.cgi?id=280242
rdar://136546453

Reviewed by Chris Dumez.

LoadListener is not used anywhere since we removed plug-in code.

* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebLocalFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebLocalFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebLocalFrameLoaderClient::didFinishLoad):
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
(WebKit::LoadListener::~LoadListener): Deleted.
(WebKit::WebFrame::setLoadListener): Deleted.
(WebKit::WebFrame::loadListener const): Deleted.

Canonical link: https://commits.webkit.org/284161@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 79e4ba: Adopt more smart pointers in some GPUProcess/graph...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79e4ba7417b545be856b78df6875e1c966e44425
  
https://github.com/WebKit/WebKit/commit/79e4ba7417b545be856b78df6875e1c966e44425
  Author: Rupin Mittal 
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp
M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h
M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.mm
M Source/WebKit/GPUProcess/GPUProcess.cpp
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h
M 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp

  Log Message:
  ---
  Adopt more smart pointers in some GPUProcess/graphics files
https://bugs.webkit.org/show_bug.cgi?id=280347
rdar://136702392

Reviewed by Geoffrey Garen.

Smart pointer adoption as per the static analyzer.

* Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
(WebCore::AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices
 const):
* Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::unit):
(WebCore::CoreAudioCaptureSource::unit const):
(WebCore::CoreAudioCaptureSourceFactory::unit):
(WebCore::CoreAudioCaptureSourceFactory::scheduleReconfiguration):
(WebCore::CoreAudioCaptureSourceFactory::enableMutedSpeechActivityEventListener):
(WebCore::CoreAudioCaptureSourceFactory::disableMutedSpeechActivityEventListener):
(WebCore::CoreAudioCaptureSourceFactory::registerSpeakerSamplesProducer):
(WebCore::CoreAudioCaptureSourceFactory::unregisterSpeakerSamplesProducer):
(WebCore::CoreAudioCaptureSourceFactory::isAudioCaptureUnitRunning):
(WebCore::CoreAudioCaptureSourceFactory::whenAudioCaptureUnitIsNotRunning):
(WebCore::CoreAudioCaptureSourceFactory::shouldAudioCaptureUnitRenderAudio):
(WebCore::CoreAudioCaptureSource::setIsInBackground):
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp:
(WebCore::CoreAudioSharedInternalUnit::create):
(WebCore::CoreAudioSharedInternalUnit::~CoreAudioSharedInternalUnit):
(WebCore::CoreAudioSharedUnit::unitSingleton):
(WebCore::CoreAudioSharedUnit::unit): Deleted.
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h:
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.mm:
(-[WebCoreAudioInputMuteChangeListener handleMuteStatusChangedNotification:]):
(WebCore::CoreAudioSharedUnit::processVoiceActivityEvent):
(WebCore::CoreAudioSharedInternalUnit::setVoiceActivityDetection):
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::updateCaptureAccess):
* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::initializeGPUProcess):
(WebKit::GPUProcess::enableMicrophoneMuteStatusAPI):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::drawSurfaceBufferToImageBuffer):
(WebKit::RemoteGraphicsContextGL::surfaceBufferToVideoFrame):
(WebKit::RemoteGraphicsContextGL::getBufferSubDataInline):
(WebKit::RemoteGraphicsContextGL::getBufferSubDataSharedMemory):
(WebKit::RemoteGraphicsContextGL::readPixelsInline):
(WebKit::RemoteGraphicsContextGL::readPixelsSharedMemory):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.cpp:
(WebKit::RemoteBindGroupLayout::destruct):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp:
(WebKit::RemoteComputePassEncoder::destruct):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp:
(WebKit::RemoteGPU::initialize):
(WebKit::RemoteGPU::stopListeningForIPC):
(WebKit::RemoteGPU::workQueueInitialize):
(WebKit::RemoteGPU::isValid):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h:
* 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::captureUnitHasStopped):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::endAudioSessionInterruption):

Canonical link: https://commits.webkit.org/284293@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 14f320: Adopt more smart pointers in WebPageProxyCocoa.mm

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 14f320dd03601d111ea53d4ac6d80c47d087123d
  
https://github.com/WebKit/WebKit/commit/14f320dd03601d111ea53d4ac6d80c47d087123d
  Author: Rupin Mittal 
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
M Source/WTF/wtf/WorkQueue.h
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in WebPageProxyCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=280362
rdar://136714038

Reviewed by Geoffrey Garen.

Smart pointer adoption as per the static analyzer.

* Source/WTF/wtf/WorkQueue.h:
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::grantAccessToCurrentPasteboardData):
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
(WebKit::WebPageProxy::createSandboxExtensionsIfNeeded):
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection):
(WebKit::WebPageProxy::insertDictatedTextAsync):
(WebKit::WebPageProxy::addDictationAlternative):
(WebKit::WebPageProxy::dictationAlternativesAtSelection):
(WebKit::WebPageProxy::clearDictationAlternatives):
(WebKit::WebPageProxy::Internals::paymentCoordinatorPresentingWindow const):
(WebKit::WebPageProxy::updateFullscreenVideoTextRecognition):
(WebKit::WebPageProxy::requestThumbnail):
(WebKit::WebPageProxy::updateIconForDirectory):
(WebKit::WebPageProxy::scheduleActivityStateUpdate):
(WebKit::WebPageProxy::createAppHighlightInSelectedRange):
(WebKit::WebPageProxy::restoreAppHighlightsAndScrollToIndex):
(WebKit::WebPageProxy::setAppHighlightsVisibility):
(WebKit::WebPageProxy::requestActiveNowPlayingSessionInfo):
(WebKit::WebPageProxy::lastNavigationWasAppInitiated):
(WebKit::WebPageProxy::grantAccessToAssetServices):
(WebKit::WebPageProxy::revokeAccessToAssetServices):
(WebKit::WebPageProxy::disableURLSchemeCheckInDataDetectors const):
(WebKit::WebPageProxy::switchFromStaticFontRegistryToUserFontRegistry):
(WebKit::WebPageProxy::contentsOfUserInterfaceItem):
(WebKit::WebPageProxy::insertMultiRepresentationHEIC):
(WebKit::WebPageProxy::replaceSelectionWithPasteboardData):
(WebKit::WebPageProxy::replaceImageForRemoveBackground):
(WebKit::WebPageProxy::useGPUProcessForDOMRenderingEnabled const):
(WebKit::WebPageProxy::setMediaCapability):
(WebKit::WebPageProxy::willBeginWritingToolsSession):
(WebKit::WebPageProxy::didBeginWritingToolsSession):
(WebKit::WebPageProxy::proofreadingSessionDidReceiveSuggestions):
(WebKit::WebPageProxy::proofreadingSessionDidUpdateStateForSuggestion):
(WebKit::WebPageProxy::didEndWritingToolsSession):
(WebKit::WebPageProxy::compositionSessionDidReceiveTextWithReplacementRange):
(WebKit::WebPageProxy::writingToolsSessionDidReceiveAction):
(WebKit::WebPageProxy::enableSourceTextAnimationAfterElementWithID):
(WebKit::WebPageProxy::enableTextAnimationTypeForElementWithID):
(WebKit::WebPageProxy::getTextIndicatorForID):
(WebKit::WebPageProxy::updateUnderlyingTextVisibilityForTextAnimationID):
(WebKit::WebPageProxy::intelligenceTextAnimationsDidComplete):
(WebKit::WebPageProxy::playPredominantOrNowPlayingMediaSession):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::useGPUProcessForDOMRenderingEnabled const):

Canonical link: https://commits.webkit.org/284295@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eb7e6e: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb7e6e832deb5c0511825feefcfae917e2035236
  
https://github.com/WebKit/WebKit/commit/eb7e6e832deb5c0511825feefcfae917e2035236
  Author: Rupin Mittal 
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h
M Source/WebKit/WebProcess/WebPage/DrawingArea.cpp
M Source/WebKit/WebProcess/WebPage/DrawingArea.h
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.h
M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make WebProcess DrawingArea 
objects RefCounted
https://bugs.webkit.org/show_bug.cgi?id=280281
rdar://136602976

Reviewed by Geoffrey Garen.

The same will need to be done for the associated Proxy objects, but
that will be done in a later patch.

* 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:
* Source/WebKit/WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
* Source/WebKit/WebProcess/WebPage/DrawingArea.h:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
(WebKit::RemoteLayerTreeDrawingArea::create):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):
(WebKit::WebPage::updateAfterDrawingAreaCreation):
(WebKit::WebPage::gpuProcessConnectionWasDestroyed):
(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::enterAcceleratedCompositingMode):
(WebKit::WebPage::exitAcceleratedCompositingMode):
(WebKit::WebPage::close):
(WebKit::WebPage::setSize):
(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::didScalePage):
(WebKit::WebPage::setDeviceScaleFactor):
(WebKit::WebPage::viewportPropertiesDidChange):
(WebKit::WebPage::updateDrawingAreaLayerTreeFreezeState):
(WebKit::WebPage::updateFrameSize):
(WebKit::WebPage::tryMarkLayersVolatile):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::setBackgroundColor):
(WebKit::WebPage::setTopContentInsetFenced):
(WebKit::WebPage::setActivityState):
(WebKit::WebPage::setLayerHostingMode):
(WebKit::WebPage::updateRenderingWithForcedRepaintWithoutCallback):
(WebKit::WebPage::updateRenderingWithForcedRepaint):
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::willDestroyDecodedDataForAllImages):
(WebKit::WebPage::setMainFrameIsScrollable):
(WebKit::WebPage::willReplaceMultipartContent):
(WebKit::WebPage::didReplaceMultipartContent):
(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::setShouldScaleViewToFitDocument):
(WebKit::WebPage::dispatchDidReachLayoutMilestone):
(WebKit::WebPage::protectedDrawingArea const):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.h:
* Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.h:

Canonical link: https://commits.webkit.org/284292@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8864e6: Adopt more smart pointers in WebExtensionContext a...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8864e650bf5ab2a2e90de8324002db7ba71c6f67
  
https://github.com/WebKit/WebKit/commit/8864e650bf5ab2a2e90de8324002db7ba71c6f67
  Author: Rupin Mittal 
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionAction.h
M Source/WebKit/UIProcess/WebContextSupplement.h
M Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp
M 
Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp
M Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h

  Log Message:
  ---
  Adopt more smart pointers in WebExtensionContext and 
WebGeolocationManagerProxy
https://bugs.webkit.org/show_bug.cgi?id=280420
rdar://136769688

Reviewed by Chris Dumez, Geoffrey Garen, and Timothy Hatcher.

Smart pointer adoption as per the static analyzer.

We are now able to use WebContextSupplement::protectedProcessPool() in
WebGeolocationManagerProxy::WebGeolocationManagerProxy since 284304@main
makes it safe to ref an API object in it's constructor.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(WebKit::WebExtensionAction::tab const): Deleted.
(WebKit::WebExtensionAction::window const): Deleted.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::getCurrentTab const):
(WebKit::WebExtensionContext::getAction):
(WebKit::WebExtensionContext::inspectorPageIdentifiers const):
(WebKit::WebExtensionContext::addExtensionTabPage):
* Source/WebKit/UIProcess/Extensions/WebExtensionAction.h:
(WebKit::WebExtensionAction::tab const):
(WebKit::WebExtensionAction::window const):
* Source/WebKit/UIProcess/WebContextSupplement.h:
(WebKit::WebContextSupplement::protectedProcessPool):
* Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::startUpdatingWithProxy):
* Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::ref const):
(WebKit::GeolocationPermissionRequestManager::deref const):
* Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::protectedGeolocationPermissionRequestManager):
* Source/WebKit/WebProcess/WebPage/WebPage.h:

Canonical link: https://commits.webkit.org/284338@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d7e96f: Adopt more smart pointers in WebPageProxyMac.mm

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7e96fa0c746a0c4e5f945a21158603041e4c17c
  
https://github.com/WebKit/WebKit/commit/d7e96fa0c746a0c4e5f945a21158603041e4c17c
  Author: Rupin Mittal 
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxyMessageReceiverRegistration.cpp
M Source/WebKit/UIProcess/WebPageProxyMessageReceiverRegistration.h
M Source/WebKit/UIProcess/WebPageProxyTesting.cpp
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm

  Log Message:
  ---
  Adopt more smart pointers in WebPageProxyMac.mm
https://bugs.webkit.org/show_bug.cgi?id=280372
rdar://136716929

Reviewed by Geoffrey Garen.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/UIProcess/WebPageProxyMessageReceiverRegistration.cpp:
(WebKit::WebPageProxyMessageReceiverRegistration::stopReceivingMessages):
(WebKit::WebPageProxyMessageReceiverRegistration::transferMessageReceivingFrom):
(WebKit::WebPageProxyMessageReceiverRegistration::Data::protectedProcess):
* Source/WebKit/UIProcess/WebPageProxyMessageReceiverRegistration.h:
* Source/WebKit/UIProcess/WebPageProxyTesting.cpp:
(WebKit::WebPageProxyTesting::dispatchActivityStateUpdate):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::setMainFrameIsScrollable):
(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):
(WebKit::WebPageProxy::stringSelectionForPasteboard):
(WebKit::WebPageProxy::dataSelectionForPasteboard):
(WebKit::WebPageProxy::readSelectionFromPasteboard):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::semanticContextDidChange):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
(WebKit::WebPageProxy::acceptsFirstMouse):
(WebKit::WebPageProxy::platformWindow):
(WebKit::WebPageProxy::showValidationMessage):
(WebKit::WebPageProxy::activeContextMenu const):
(WebKit::WebPageProxy::Internals::platformView const):
(WebKit::WebPageProxy::pdfZoomIn):
(WebKit::WebPageProxy::pdfZoomOut):
(WebKit::WebPageProxy::pdfSaveToPDF):
(WebKit::WebPageProxy::pdfOpenWithPreview):
(WebKit::WebPageProxy::handleContextMenuLookUpImage):
(WebKit::WebPageProxy::handleContextMenuCopySubject):

Canonical link: https://commits.webkit.org/284309@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4e1ba6: [IsDeprecatedWeakRefSmartPointerException] Make Sp...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e1ba66c57dfdc05d16b3e221ca567d5da4f000e
  
https://github.com/WebKit/WebKit/commit/4e1ba66c57dfdc05d16b3e221ca567d5da4f000e
  Author: Rupin Mittal 
  Date:   2024-09-29 (Sun, 29 Sep 2024)

  Changed paths:
M Source/WebCore/Modules/speech/SpeechSynthesis.cpp
M Source/WebCore/Modules/speech/SpeechSynthesis.h
M Source/WebCore/page/Page.h
M Source/WebCore/page/PageConfiguration.h
M Source/WebCore/page/SpeechSynthesisClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make SpeechSynthesisClient 
ref-counted
https://bugs.webkit.org/show_bug.cgi?id=280555
rdar://136865003

Reviewed by Chris Dumez.

We remove IsDeprecatedWeakRefSmartPointerException by making 
SpeechSynthesisClient
ref-counted.

WebSpeechSynthesisClient is owned by Page. Since it's 'now ref-counted, it's 
possible
for it to out-live the Page, which would be a problem. To ensure that
WebSpeecSynthesisClient never tries to use it's WebPage member if the Page has 
been
destroyed, we change the m_page member to be a WeakPtr instead of a WeakRef and
null-check m_page before using it.

* Source/WebCore/Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::create):
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::getVoices):
(WebCore::SpeechSynthesis::startSpeakingImmediately):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resumeSynthesis):
(WebCore::RefSpeechSynthesis::create): Deleted.
* Source/WebCore/Modules/speech/SpeechSynthesis.h:
* Source/WebCore/page/Page.h:
* Source/WebCore/page/PageConfiguration.h:
* Source/WebCore/page/SpeechSynthesisClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:
(WebKit::WebSpeechSynthesisClient::voiceList):
(WebKit::WebSpeechSynthesisClient::corePageObserver const):
(WebKit::WebSpeechSynthesisClient::resetState):
(WebKit::WebSpeechSynthesisClient::speak):
(WebKit::WebSpeechSynthesisClient::cancel):
(WebKit::WebSpeechSynthesisClient::pause):
(WebKit::WebSpeechSynthesisClient::resume):
(WebKit::WebSpeechSynthesisClient::protectedPage const): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.h:
(WebKit::WebSpeechSynthesisClient::~WebSpeechSynthesisClient): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):

Canonical link: https://commits.webkit.org/284434@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d43ec2: Adopt more smart pointers in PlaybackSessionManage...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d43ec2c6ee3129a34902915efc7177a6811a10f5
  
https://github.com/WebKit/WebKit/commit/d43ec2c6ee3129a34902915efc7177a6811a10f5
  Author: Rupin Mittal 
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm

  Log Message:
  ---
  Adopt more smart pointers in PlaybackSessionManagerProxy and 
VideoPresentationManagerProxy
https://bugs.webkit.org/show_bug.cgi?id=279955
rdar://136272392

Reviewed by Jean-Yves Avenard.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionModelContext::sendRemoteCommand):
(WebKit::PlaybackSessionModelContext::setSpatialTrackingLabel):
(WebKit::PlaybackSessionModelContext::addNowPlayingMetadataObserver):
(WebKit::PlaybackSessionModelContext::removeNowPlayingMetadataObserver):
(WebKit::PlaybackSessionModelContext::setSoundStageSize):
(WebKit::PlaybackSessionModelContext::play):
(WebKit::PlaybackSessionModelContext::pause):
(WebKit::PlaybackSessionModelContext::togglePlayState):
(WebKit::PlaybackSessionModelContext::beginScrubbing):
(WebKit::PlaybackSessionModelContext::endScrubbing):
(WebKit::PlaybackSessionModelContext::seekToTime):
(WebKit::PlaybackSessionModelContext::fastSeek):
(WebKit::PlaybackSessionModelContext::beginScanningForward):
(WebKit::PlaybackSessionModelContext::beginScanningBackward):
(WebKit::PlaybackSessionModelContext::endScanning):
(WebKit::PlaybackSessionModelContext::setDefaultPlaybackRate):
(WebKit::PlaybackSessionModelContext::setPlaybackRate):
(WebKit::PlaybackSessionModelContext::selectAudioMediaOption):
(WebKit::PlaybackSessionModelContext::selectLegibleMediaOption):
(WebKit::PlaybackSessionModelContext::togglePictureInPicture):
(WebKit::PlaybackSessionModelContext::enterInWindowFullscreen):
(WebKit::PlaybackSessionModelContext::exitInWindowFullscreen):
(WebKit::PlaybackSessionModelContext::toggleMuted):
(WebKit::PlaybackSessionModelContext::setMuted):
(WebKit::PlaybackSessionModelContext::setVolume):
(WebKit::PlaybackSessionModelContext::setPlayingOnSecondScreen):
(WebKit::PlaybackSessionManagerProxy::PlaybackSessionManagerProxy):
(WebKit::PlaybackSessionManagerProxy::invalidate):
(WebKit::PlaybackSessionManagerProxy::play):
(WebKit::PlaybackSessionManagerProxy::pause):
(WebKit::PlaybackSessionManagerProxy::togglePlayState):
(WebKit::PlaybackSessionManagerProxy::beginScrubbing):
(WebKit::PlaybackSessionManagerProxy::endScrubbing):
(WebKit::PlaybackSessionManagerProxy::seekToTime):
(WebKit::PlaybackSessionManagerProxy::fastSeek):
(WebKit::PlaybackSessionManagerProxy::beginScanningForward):
(WebKit::PlaybackSessionManagerProxy::beginScanningBackward):
(WebKit::PlaybackSessionManagerProxy::endScanning):
(WebKit::PlaybackSessionManagerProxy::setDefaultPlaybackRate):
(WebKit::PlaybackSessionManagerProxy::setPlaybackRate):
(WebKit::PlaybackSessionManagerProxy::selectAudioMediaOption):
(WebKit::PlaybackSessionManagerProxy::selectLegibleMediaOption):
(WebKit::PlaybackSessionManagerProxy::togglePictureInPicture):
(WebKit::PlaybackSessionManagerProxy::enterFullscreen):
(WebKit::PlaybackSessionManagerProxy::exitFullscreen):
(WebKit::PlaybackSessionManagerProxy::enterInWindow):
(WebKit::PlaybackSessionManagerProxy::exitInWindow):
(WebKit::PlaybackSessionManagerProxy::toggleMuted):
(WebKit::PlaybackSessionManagerProxy::setMuted):
(WebKit::PlaybackSessionManagerProxy::setVolume):
(WebKit::PlaybackSessionManagerProxy::setPlayingOnSecondScreen):
(WebKit::PlaybackSessionManagerProxy::sendRemoteCommand):
(WebKit::PlaybackSessionManagerProxy::setSpatialTrackingLabel):
(WebKit::PlaybackSessionManagerProxy::setSoundStageSize):
(WebKit::PlaybackSessionManagerProxy::requestControlledElementID):
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationModelContext::requestCloseAllMediaPresentations):
(WebKit::VideoPresentationModelContext::requestFullscreenMode):
(WebKit::VideoPresentationModelContext::setVideoLayerFrame):
(WebKit::VideoPresentationModelContext::setVideoLayerGravity):
(WebKit::VideoPresentationModelContext::setVideoFullscreenFrame):
(WebKit::VideoPresentationModelContext::fullscreenModeChanged):
(WebKit::VideoPresentationModelContext::requestUpdateInlineRect):
(WebKit::VideoPresentationModelContext::requestVideoContentLayer):
(WebKit::VideoPresentationModelContext::returnVideoContentLayer):
(WebKit::VideoPresentationModelContext::returnVideoView):
(WebKit::VideoPresentationModelContext::didSetupFullscreen):
(WebKit::VideoPresentationModelContext::failedToEnterFullscreen):
(WebKit::VideoPresentationModelContext::didEnterFullscreen):
(WebKit::VideoPresentationModelContext::willExitFullscreen):
(WebKit::VideoPresentationModelContext::didExitFullscreen):
(WebKit::VideoPresentationModelContext::didCleanupFullscreen

[webkit-changes] [WebKit/WebKit] 75044a: Adopt more smart pointers in RemoteMediaPlayerMana...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75044ae40f14fe812f0aa40485716893f0778b90
  
https://github.com/WebKit/WebKit/commit/75044ae40f14fe812f0aa40485716893f0778b90
  Author: Rupin Mittal 
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in RemoteMediaPlayerManagerProxy, 
RemoteSourceBufferProxy, and RemoteMediaPlayerProxy (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=280025
rdar://136327268

Reviewed by Geoffrey Garen.

Second round of smart pointer adoption in these files per
the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::didReceiveSyncPlayerMessage):
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerDurationChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerSeekableTimeRangesChanged):
(WebKit::RemoteMediaPlayerProxy::addRemoteVideoTrackProxy):
(WebKit::RemoteMediaPlayerProxy::addRemoteTextTrackProxy):
(WebKit::RemoteMediaPlayerProxy::setWirelessVideoPlaybackDisabled):
(WebKit::RemoteMediaPlayerProxy::updateCachedVideoMetrics):
* Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateDidReceiveInitializationSegment):
(WebKit::RemoteSourceBufferProxy::append):
(WebKit::RemoteSourceBufferProxy::removeCodedFrames):
(WebKit::RemoteSourceBufferProxy::setMaximumBufferSize):
(WebKit::RemoteSourceBufferProxy::computeSeekTime):
(WebKit::RemoteSourceBufferProxy::bufferedSamplesForTrackId):
(WebKit::RemoteSourceBufferProxy::enqueuedSamplesForTrackID):

Canonical link: https://commits.webkit.org/283976@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c29543: Adopt more smart pointers in WebScreenOrientationM...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c29543ecbb6ad433a92582c629fd2828a8912447
  
https://github.com/WebKit/WebKit/commit/c29543ecbb6ad433a92582c629fd2828a8912447
  Author: Rupin Mittal 
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp
M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.h

  Log Message:
  ---
  Adopt more smart pointers in WebScreenOrientationManagerProxy and 
UserMediaCaptureManagerProxy
https://bugs.webkit.org/show_bug.cgi?id=279952
rdar://136268991

Reviewed by Chris Dumez.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::createCameraSource):
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManagerProxy::capabilities):
(WebKit::UserMediaCaptureManagerProxy::applyConstraints):
(WebKit::UserMediaCaptureManagerProxy::clone):
(WebKit::UserMediaCaptureManagerProxy::takePhoto):
(WebKit::UserMediaCaptureManagerProxy::getPhotoCapabilities):
(WebKit::UserMediaCaptureManagerProxy::getPhotoSettings):
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
(WebKit::UserMediaCaptureManagerProxy::ConnectionProxy::protectedConnection):
(WebKit::UserMediaCaptureManagerProxy::ConnectionProxy::protectedLogger):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp:
(WebKit::WebScreenOrientationManagerProxy::WebScreenOrientationManagerProxy):
(WebKit::WebScreenOrientationManagerProxy::~WebScreenOrientationManagerProxy):
(WebKit::WebScreenOrientationManagerProxy::setCurrentOrientation):
(WebKit::WebScreenOrientationManagerProxy::protectedPage const):
* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.h:

Canonical link: https://commits.webkit.org/283959@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 90680d: Adopt more smart pointers in LibWebRTCCodecsProxy, ...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90680d756766091c46b6a4d80f7d20388bcca87a
  
https://github.com/WebKit/WebKit/commit/90680d756766091c46b6a4d80f7d20388bcca87a
  Author: Rupin Mittal 
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
M Source/WebCore/platform/graphics/SourceBrush.h
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in LibWebRTCCodecsProxy, RemoteDisplayListRecorder, 
and RemoteDisplayListRecorderProxy
https://bugs.webkit.org/show_bug.cgi?id=279926
rdar://136253336

Reviewed by Chris Dumez and Geoffrey Garen.

Smart pointer adoption as per the static analyzer.

* Source/WebCore/platform/graphics/SourceBrush.h:
(WebCore::SourceBrush::protectedPattern const):
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
(WebKit::RemoteDisplayListRecorder::setState):
(WebKit::RemoteDisplayListRecorder::drawFilteredImageBufferInternal):
(WebKit::RemoteDisplayListRecorder::drawDisplayListItems):
(WebKit::RemoteDisplayListRecorder::drawControlPart):
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:
(WebKit::RemoteDisplayListRecorder::protectedControlFactory):
(WebKit::RemoteDisplayListRecorder::drawingContext):
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::flushDecoder):
(WebKit::LibWebRTCCodecsProxy::flushEncoder):
* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::recordResourceUse):

Canonical link: https://commits.webkit.org/283897@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0f54db: Adopt more smart pointers in miscellaneous files

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f54db92edc6de5cb6dc96335ecfafcb6329169d
  
https://github.com/WebKit/WebKit/commit/0f54db92edc6de5cb6dc96335ecfafcb6329169d
  Author: Rupin Mittal 
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp
M Source/WebKit/UIProcess/Cocoa/UIRemoteObjectRegistry.cpp
M Source/WebKit/UIProcess/WebContextSupplement.h
M Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in miscellaneous files
https://bugs.webkit.org/show_bug.cgi?id=280026
rdar://136328218

Reviewed by Geoffrey Garen.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp:
(WebKit::RemoteImageDecoderAVFProxy::setData):
* Source/WebKit/UIProcess/Cocoa/UIRemoteObjectRegistry.cpp:
(WebKit::UIRemoteObjectRegistry::backgroundActivity):
* Source/WebKit/UIProcess/WebContextSupplement.h:
(WebKit::WebContextSupplement::processPool):
(WebKit::WebContextSupplement::protectedProcessPool):
(WebKit::WebContextSupplement::processPool const): Deleted.
* Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
(WebKit::WebGeolocationManagerProxy::resetPermissions):

Canonical link: https://commits.webkit.org/284006@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0061ee: Fix WebContentProcess crashes after 284006@main

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0061ee04041ab917a1e1ba865a76a8ad1cd86751
  
https://github.com/WebKit/WebKit/commit/0061ee04041ab917a1e1ba865a76a8ad1cd86751
  Author: Rupin Mittal 
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebContextSupplement.h
M Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp

  Log Message:
  ---
  Fix WebContentProcess crashes after 284006@main
https://bugs.webkit.org/show_bug.cgi?id=280095
rdar://136391408

Reviewed by Geoffrey Garen.

Based on an issue found by the smart pointer static analyzer, to ensure
that the WebProcessPool is alive while making a call to addMessageReceiver()
in the WebGeolocationManagerProxy constructor, 284006@main added a
protectedProcessPool() function.

The problem is that we are ref'ing the C++ wrapper of the Objective-C process
pool while it's being constructed (The process pool's constructor is what
calls the constructor of WebGeolocationManagerProxy). This causes
WebContentProcess crashes, so we're undoing this change for now until we can
figure out a better way to make this code pointer safe.

* Source/WebKit/UIProcess/WebContextSupplement.h:
(WebKit::WebContextSupplement::protectedProcessPool): Deleted.
* Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):

Canonical link: https://commits.webkit.org/284023@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 63afd2: Adopt more smart pointers in GPUProcess/media (par...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63afd2ffd4d0c566d1ed6654de22d53ffd4702f5
  
https://github.com/WebKit/WebKit/commit/63afd2ffd4d0c566d1ed6654de22d53ffd4702f5
  Author: Rupin Mittal 
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h
M Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/media (part 3)
https://bugs.webkit.org/show_bug.cgi?id=280650
rdar://137003153

Reviewed by Ryosuke Niwa.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::RemoteMediaPlayerProxy):
(WebKit::RemoteMediaPlayerProxy::invalidate):
(WebKit::RemoteMediaPlayerProxy::commitAllTransactions):
(WebKit::RemoteMediaPlayerProxy::load):
(WebKit::RemoteMediaPlayerProxy::loadMediaSource):
(WebKit::RemoteMediaPlayerProxy::cancelLoad):
(WebKit::RemoteMediaPlayerProxy::prepareForPlayback):
(WebKit::RemoteMediaPlayerProxy::prepareToPlay):
(WebKit::RemoteMediaPlayerProxy::pause):
(WebKit::RemoteMediaPlayerProxy::seekToTarget):
(WebKit::RemoteMediaPlayerProxy::setVolume):
(WebKit::RemoteMediaPlayerProxy::setMuted):
(WebKit::RemoteMediaPlayerProxy::setPreload):
(WebKit::RemoteMediaPlayerProxy::setPrivateBrowsingMode):
(WebKit::RemoteMediaPlayerProxy::setPreservesPitch):
(WebKit::RemoteMediaPlayerProxy::setPitchCorrectionAlgorithm):
(WebKit::RemoteMediaPlayerProxy::prepareForRendering):
(WebKit::RemoteMediaPlayerProxy::setPageIsVisible):
(WebKit::RemoteMediaPlayerProxy::setShouldMaintainAspectRatio):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenGravity):
(WebKit::RemoteMediaPlayerProxy::acceleratedRenderingStateChanged):
(WebKit::RemoteMediaPlayerProxy::setShouldDisableSleep):
(WebKit::RemoteMediaPlayerProxy::setRate):
(WebKit::RemoteMediaPlayerProxy::setPresentationSize):
(WebKit::RemoteMediaPlayerProxy::requestResource):
(WebKit::RemoteMediaPlayerProxy::sendH2Ping):
(WebKit::RemoteMediaPlayerProxy::removeResource):
(WebKit::RemoteMediaPlayerProxy::updateVideoFullscreenInlineImage):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenMode):
(WebKit::RemoteMediaPlayerProxy::videoFullscreenStandbyChanged):
(WebKit::RemoteMediaPlayerProxy::setBufferingPolicy):
(WebKit::RemoteMediaPlayerProxy::accessLog):
(WebKit::RemoteMediaPlayerProxy::errorLog):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerNetworkStateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerReadyStateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerVolumeChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMuteChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerSeeked):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerTimeChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerDurationChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerEngineFailedToLoad):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerGetRawCookies const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerPlaybackStateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerCharacteristicChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerDidRemoveAudioTrack):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerDidRemoveVideoTrack):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerDidRemoveTextTrack):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerResourceNotSupported):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerSizeChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerActiveSourceBuffersChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerKeyNeeded):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerInitializationDataEncountered):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerWaitingForKeyChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
(WebKit::RemoteMediaPlayerProxy::setShouldPlayToPlaybackTarget):
(WebKit::RemoteMediaPlayerProxy::setWirelessPlaybackTarget):
(WebKit::RemoteMediaPlayerProxy::currentTimeChanged):
(WebKit::RemoteMediaPlayerProxy::videoFrameForCurrentTimeIfChanged):
(WebKit::RemoteMediaPlayerProxy::setShouldDisableHDR):
(WebKit::RemoteMediaPlayerProxy::sendCachedState):
(WebKit::RemoteMediaPlayerProxy::setLegacyCDMSession):
(WebKit::RemoteMediaPlayerProxy::keyAdded):
(WebKit::RemoteMediaPlayerProxy::cdmInstanceAttached):
(WebKit::RemoteMediaPlayerProxy::cdmInstanceDetached):
(WebKit::RemoteMediaPlayerProxy::attemptToDecryptWithInstance):
(WebKit::RemoteMediaPlayerProxy::setShouldContinueAfterKeyNeeded):
(WebKit::RemoteMediaPlayerProxy::beginSimulatedHDCPError):
(WebKit::RemoteMediaPlayerProxy::endSimulatedHDCPError):
(WebKit::RemoteMediaPlayerProxy::notifyActiveSourceBuffersChanged):
(WebKit::RemoteMediaPlayerProxy::applicationWillResignActive):
(WebKit::RemoteMediaPlayerProxy

[webkit-changes] [WebKit/WebKit] 0acb00: Adopt more smart pointers in GPUProcess/webrtc

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0acb006bca65fc3b800382f2b36d3cb1eefa47c0
  
https://github.com/WebKit/WebKit/commit/0acb006bca65fc3b800382f2b36d3cb1eefa47c0
  Author: Rupin Mittal 
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
M 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/webrtc
https://bugs.webkit.org/show_bug.cgi?id=280652
rdar://137007140

Reviewed by Chris Dumez.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::stopListeningForIPC):
(WebKit::LibWebRTCCodecsProxy::initialize):
(WebKit::LibWebRTCCodecsProxy::releaseDecoder):
(WebKit::LibWebRTCCodecsProxy::releaseEncoder):
(WebKit::LibWebRTCCodecsProxy::encodeFrame):
(WebKit::LibWebRTCCodecsProxy::notifyEncoderResult):
(WebKit::LibWebRTCCodecsProxy::notifyDecoderResult):
* 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::reset):
* Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp:
(WebKit::RemoteMediaRecorder::~RemoteMediaRecorder):
(WebKit::RemoteMediaRecorder::audioSamplesAvailable):
(WebKit::RemoteMediaRecorder::videoFrameAvailable):
(WebKit::RemoteMediaRecorder::fetchData):
(WebKit::RemoteMediaRecorder::stopRecording):
(WebKit::RemoteMediaRecorder::pause):
(WebKit::RemoteMediaRecorder::resume):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::initialize):
(WebKit::RemoteSampleBufferDisplayLayer::updateDisplayMode):
(WebKit::RemoteSampleBufferDisplayLayer::updateBoundsAndPosition):
(WebKit::RemoteSampleBufferDisplayLayer::flush):
(WebKit::RemoteSampleBufferDisplayLayer::flushAndRemoveImage):
(WebKit::RemoteSampleBufferDisplayLayer::enqueueVideoFrame):
(WebKit::RemoteSampleBufferDisplayLayer::clearVideoFrames):
(WebKit::RemoteSampleBufferDisplayLayer::setShouldMaintainAspectRatio):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
(WebKit::RemoteSampleBufferDisplayLayerManager::close):
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
(WebKit::RemoteSampleBufferDisplayLayerManager::releaseLayer):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:

Canonical link: https://commits.webkit.org/284506@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a234ce: Adopt more smart pointers in GPUProcess/graphics (...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a234cec946ade67426c0e14e8e5759fe60d4d3be
  
https://github.com/WebKit/WebKit/commit/a234cec946ade67426c0e14e8e5759fe60d4d3be
  Author: Rupin Mittal 
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQuerySet.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQuerySet.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteSampler.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteSampler.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.h

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/graphics (part 1)
https://bugs.webkit.org/show_bug.cgi?id=280657
rdar://137016134

Reviewed by Mike Wyrzykowski.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp:
(WebKit::RemoteBindGroup::RemoteBindGroup):
(WebKit::RemoteBindGroup::updateExternalTextures):
(WebKit::RemoteBindGroup::stopListeningForIPC):
(WebKit::RemoteBindGroup::setLabel):
(WebKit::RemoteBindGroup::protectedBacking):
(WebKit::RemoteBindGroup::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.cpp:
(WebKit::RemoteBindGroupLayout::RemoteBindGroupLayout):
(WebKit::RemoteBindGroupLayout::stopListeningForIPC):
(WebKit::RemoteBindGroupLayout::setLabel):
(WebKit::RemoteBindGroupLayout::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQuerySet.cpp:
(WebKit::RemoteQuerySet::RemoteQuerySet):
(WebKit::RemoteQuerySet::stopListeningForIPC):
(WebKit::RemoteQuerySet::destroy):
(WebKit::RemoteQuerySet::destruct):
(WebKit::RemoteQuerySet::setLabel):
(WebKit::RemoteQuerySet::protectedBacking):
(WebKit::RemoteQuerySet::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQuerySet.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp:
(WebKit::RemoteRenderPassEncoder::destruct):
(WebKit::RemoteRenderPassEncoder::setPipeline):
(WebKit::RemoteRenderPassEncoder::setIndexBuffer):
(WebKit::RemoteRenderPassEncoder::setVertexBuffer):
(WebKit::RemoteRenderPassEncoder::unsetVertexBuffer):
(WebKit::RemoteRenderPassEncoder::draw):
(WebKit::RemoteRenderPassEncoder::drawIndexed):
(WebKit::RemoteRenderPassEncoder::drawIndirect):
(WebKit::RemoteRenderPassEncoder::drawIndexedIndirect):
(WebKit::RemoteRenderPassEncoder::setBindGroup):
(WebKit::RemoteRenderPassEncoder::pushDebugGroup):
(WebKit::RemoteRenderPassEncoder::popDebugGroup):
(WebKit::RemoteRenderPassEncoder::insertDebugMarker):
(WebKit::RemoteRenderPassEncoder::setViewport):
(WebKit::RemoteRenderPassEncoder::setScissorRect):
(WebKit::RemoteRenderPassEncoder::setBlendConstant):
(WebKit::RemoteRenderPassEncoder::setStencilReference):
(WebKit::RemoteRenderPassEncoder::beginOcclusionQuery):
(WebKit::RemoteRenderPassEncoder::endOcclusionQuery):
(WebKit::RemoteRenderPassEncoder::executeBundles):
(WebKit::RemoteRenderPassEncoder::end):
(WebKit::RemoteRenderPassEncoder::setLabel):
(WebKit::RemoteRenderPassEncoder::protectedBacking):
(WebKit::RemoteRenderPassEncoder::protectedObjectHeap const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteSampler.cpp:
(WebKit::RemoteSampler::RemoteSampler):
(WebKit::RemoteSampler::destruct):
(WebKit::RemoteSampler::stopListeningForIPC):
(WebKit::RemoteSampler::setLabel):
(WebKit::RemoteSampler::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteSampler.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.cpp:
(WebKit::WebGPU::RemoteBindGroupProxy::updateExternalTextures):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.cpp:
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setPipeline):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setIndexBuffer):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setVertexBuffer):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::drawIndirect):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::drawIndexedIndirect):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setBindGroup):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy

[webkit-changes] [WebKit/WebKit] e3c582: Adopt more smart pointers in GPUProcess/media (par...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3c582fa0da7f9cef9234f45e03ccc035f7c33bf
  
https://github.com/WebKit/WebKit/commit/e3c582fa0da7f9cef9234f45e03ccc035f7c33bf
  Author: Rupin Mittal 
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.h
M Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.h
M Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.cpp
M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/media (part 2)
https://bugs.webkit.org/show_bug.cgi?id=280641
rdar://136999349

Reviewed by Ryosuke Niwa.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
(WebKit::RemoteCDMInstanceSessionProxy::create):
(WebKit::RemoteCDMInstanceSessionProxy::setLogIdentifier):
(WebKit::RemoteCDMInstanceSessionProxy::requestLicense):
(WebKit::RemoteCDMInstanceSessionProxy::updateLicense):
(WebKit::RemoteCDMInstanceSessionProxy::loadSession):
(WebKit::RemoteCDMInstanceSessionProxy::closeSession):
(WebKit::RemoteCDMInstanceSessionProxy::removeSessionData):
(WebKit::RemoteCDMInstanceSessionProxy::storeRecordOfKeyUsage):
(WebKit::RemoteCDMInstanceSessionProxy::updateKeyStatuses):
(WebKit::RemoteCDMInstanceSessionProxy::sendMessage):
(WebKit::RemoteCDMInstanceSessionProxy::sessionIdChanged):
* Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.h:
* Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
(WebKit::RemoteLegacyCDMSessionProxy::sendMessage):
(WebKit::RemoteLegacyCDMSessionProxy::sendError):
(WebKit::RemoteLegacyCDMSessionProxy::mediaKeysStorageDirectory const):
(WebKit::RemoteLegacyCDMSessionProxy::sharedPreferencesForWebProcess const):
* Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.h:
(WebKit::RemoteLegacyCDMSessionProxy::protectedFactory const):
* Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.cpp:
(WebKit::RemoteMediaResourceManager::initializeConnection):
* Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::RemoteSourceBufferProxy):
(WebKit::RemoteSourceBufferProxy::append):
(WebKit::RemoteSourceBufferProxy::abort):
(WebKit::RemoteSourceBufferProxy::resetParserState):
(WebKit::RemoteSourceBufferProxy::removedFromMediaSource):
(WebKit::RemoteSourceBufferProxy::setMediaSourceEnded):
(WebKit::RemoteSourceBufferProxy::setActive):
(WebKit::RemoteSourceBufferProxy::canSwitchToType):
(WebKit::RemoteSourceBufferProxy::setMode):
(WebKit::RemoteSourceBufferProxy::startChangingType):
(WebKit::RemoteSourceBufferProxy::removeCodedFrames):
(WebKit::RemoteSourceBufferProxy::asyncEvictCodedFrames):
(WebKit::RemoteSourceBufferProxy::addTrackBuffer):
(WebKit::RemoteSourceBufferProxy::resetTrackBuffers):
(WebKit::RemoteSourceBufferProxy::clearTrackBuffers):
(WebKit::RemoteSourceBufferProxy::setAllTrackBuffersNeedRandomAccess):
(WebKit::RemoteSourceBufferProxy::reenqueueMediaIfNeeded):
(WebKit::RemoteSourceBufferProxy::setGroupStartTimestamp):
(WebKit::RemoteSourceBufferProxy::setGroupStartTimestampToEndTimestamp):
(WebKit::RemoteSourceBufferProxy::setShouldGenerateTimestamps):
(WebKit::RemoteSourceBufferProxy::resetTimestampOffsetInTrackBuffers):
(WebKit::RemoteSourceBufferProxy::setTimestampOffset):
(WebKit::RemoteSourceBufferProxy::setAppendWindowStart):
(WebKit::RemoteSourceBufferProxy::setAppendWindowEnd):
(WebKit::RemoteSourceBufferProxy::setMaximumBufferSize):
(WebKit::RemoteSourceBufferProxy::computeSeekTime):
(WebKit::RemoteSourceBufferProxy::seekToTime):
(WebKit::RemoteSourceBufferProxy::updateTrackIds):
(WebKit::RemoteSourceBufferProxy::bufferedSamplesForTrackId):
(WebKit::RemoteSourceBufferProxy::enqueuedSamplesForTrackID):
(WebKit::RemoteSourceBufferProxy::memoryPressure):
(WebKit::RemoteSourceBufferProxy::minimumUpcomingPresentationTimeForTrackID):
(WebKit::RemoteSourceBufferProxy::setMaximumQueueDepthForTrackID):
(WebKit::RemoteSourceBufferProxy::detach):
(WebKit::RemoteSourceBufferProxy::attach):
(WebKit::RemoteSourceBufferProxy::createInitializationSegmentInfo):
* Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h:

Canonical link: https://commits.webkit.org/284501@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0edb14: Adopt more smart pointers in GPUProcess/media (par...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0edb1455f0f997c444242dfc4d4043ce99fbe7d7
  
https://github.com/WebKit/WebKit/commit/0edb1455f0f997c444242dfc4d4043ce99fbe7d7
  Author: Rupin Mittal 
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteLegacyCDMProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteLegacyCDMProxy.h
M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp
M Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h
M Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxy.h
M 
Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp
M 
Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.h

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/media (part 1)
https://bugs.webkit.org/show_bug.cgi?id=280628
rdar://136985413

Reviewed by Chris Dumez.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.cpp:
(WebKit::RemoteCDMInstanceProxy::RemoteCDMInstanceProxy):
(WebKit::RemoteCDMInstanceProxy::~RemoteCDMInstanceProxy):
(WebKit::RemoteCDMInstanceProxy::initializeWithConfiguration):
(WebKit::RemoteCDMInstanceProxy::setServerCertificate):
(WebKit::RemoteCDMInstanceProxy::setStorageDirectory):
(WebKit::RemoteCDMInstanceProxy::createSession):
* Source/WebKit/GPUProcess/media/RemoteLegacyCDMProxy.cpp:
(WebKit::RemoteLegacyCDMProxy::sharedPreferencesForWebProcess const):
* Source/WebKit/GPUProcess/media/RemoteLegacyCDMProxy.h:
(WebKit::RemoteLegacyCDMProxy::protectedFactory const):
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp:
(WebKit::RemoteMediaSourceProxy::setMediaPlayers):
(WebKit::RemoteMediaSourceProxy::addSourceBuffer):
(WebKit::RemoteMediaSourceProxy::durationChanged):
(WebKit::RemoteMediaSourceProxy::bufferedChanged):
(WebKit::RemoteMediaSourceProxy::markEndOfStream):
(WebKit::RemoteMediaSourceProxy::unmarkEndOfStream):
(WebKit::RemoteMediaSourceProxy::setMediaPlayerReadyState):
(WebKit::RemoteMediaSourceProxy::setTimeFudgeFactor):
(WebKit::RemoteMediaSourceProxy::shutdown):
(WebKit::RemoteMediaSourceProxy::connectionToWebProcess const):
* Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
(WebKit::RemoteVideoFrameObjectHeap::create):
(WebKit::RemoteVideoFrameObjectHeap::close):
(WebKit::RemoteVideoFrameObjectHeap::getVideoFrameBuffer):
(WebKit::RemoteVideoFrameObjectHeap::convertFrameBuffer):
* Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h:
* Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxy.h:
(WebKit::RemoteVideoFrameObjectHeapProxy::protectedProcessor):
(WebKit::RemoteVideoFrameObjectHeapProxy::getVideoFrameBuffer):
(WebKit::RemoteVideoFrameObjectHeapProxy::getNativeImage):
* 
Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
(WebKit::RemoteVideoFrameObjectHeapProxyProcessor::initialize):
(WebKit::RemoteVideoFrameObjectHeapProxyProcessor::clearCallbacks):
* 
Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.h:
(WebKit::RemoteVideoFrameObjectHeapProxyProcessor::protectedQueue const):

Canonical link: https://commits.webkit.org/284509@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dd852d: Rename RunLoop::current() to RunLoop::currentSingl...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd852d454a9e4df133641b7e908543d8bfbb79f3
  
https://github.com/WebKit/WebKit/commit/dd852d454a9e4df133641b7e908543d8bfbb79f3
  Author: Rupin Mittal 
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
M Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.cpp
M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp
M 
Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.cpp
M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp
M Source/JavaScriptCore/jsc.cpp
M Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp
M Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp
M Source/JavaScriptCore/runtime/VM.cpp
M Source/JavaScriptCore/runtime/WaiterListManager.cpp
M Source/WTF/wtf/MainThread.cpp
M Source/WTF/wtf/MemoryPressureHandler.cpp
M Source/WTF/wtf/NativePromise.h
M Source/WTF/wtf/RunLoop.cpp
M Source/WTF/wtf/RunLoop.h
M Source/WTF/wtf/cocoa/MainThreadCocoa.mm
M Source/WTF/wtf/generic/RunLoopGeneric.cpp
M Source/WTF/wtf/generic/WorkQueueGeneric.cpp
M Source/WTF/wtf/glib/RunLoopGLib.cpp
M Source/WTF/wtf/glib/SocketConnection.cpp
M Source/WTF/wtf/linux/RealTimeThreads.cpp
M Source/WTF/wtf/win/RunLoopWin.cpp
M Source/WebCore/Modules/airplay/WebMediaSessionManager.cpp
M Source/WebCore/Modules/applepay/ApplePaySession.cpp
M Source/WebCore/Modules/mediastream/ImageCapture.cpp
M Source/WebCore/Modules/mediastream/MediaDevices.cpp
M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
M Source/WebCore/Modules/webaudio/BaseAudioContext.cpp
M Source/WebCore/Modules/websockets/WebSocket.cpp
M Source/WebCore/PAL/pal/HysteresisActivity.h
M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
M Source/WebCore/dom/WindowEventLoop.cpp
M Source/WebCore/html/FileInputType.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/inspector/InspectorFrontendAPIDispatcher.cpp
M Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
M Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp
M Source/WebCore/inspector/agents/WebHeapAgent.cpp
M Source/WebCore/loader/DocumentLoader.cpp
M Source/WebCore/loader/cocoa/BundleResourceLoader.mm
M Source/WebCore/page/Navigator.cpp
M Source/WebCore/page/mac/TextIndicatorWindow.mm
M Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp
M 
Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.cpp
M Source/WebCore/platform/AbortableTaskQueue.h
M Source/WebCore/platform/MainThreadSharedTimer.cpp
M Source/WebCore/platform/PreviewConverter.cpp
M Source/WebCore/platform/ScrollAnimator.cpp
M Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm
M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp
M Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm
M Source/WebCore/platform/cocoa/PowerSourceNotifier.mm
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm
M Source/WebCore/platform/gamepad/libwpe/GamepadProviderLibWPE.cpp
M Source/WebCore/platform/gamepad/manette/ManetteGamepadProvider.cpp
M Source/WebCore/platform/graphics/MediaPlaybackTargetPicker.cpp
M Source/WebCore/platform/graphics/MediaSourcePrivate.cpp
M Source/WebCore/platform/graphics/ShadowBlur.cpp
M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
M 
Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.mm
M Source/WebCore/platform/graphics/cg/CGSubimageCacheWithTimer.cpp
M Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
M Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm
M Source/WebCore/platform/graphics/gstreamer/MainThreadNotifier.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
M 
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp
M Source/WebCore/platform

[webkit-changes] [WebKit/WebKit] c3b24f: Adopt more smart pointers in RemoteRenderingBacken...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3b24f1e01760226b0b00ad8596e45f883d32526
  
https://github.com/WebKit/WebKit/commit/c3b24f1e01760226b0b00ad8596e45f883d32526
  Author: Rupin Mittal 
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
M Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp
M Source/WebKit/WebProcess/GPU/GPUProcessConnection.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in RemoteRenderingBackend and 
RemoteGraphicsContextGL
https://bugs.webkit.org/show_bug.cgi?id=279945
rdar://136262516

Reviewed by Ryosuke Niwa.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::initialize):
(WebKit::RemoteGraphicsContextGL::stopListeningForIPC):
(WebKit::RemoteGraphicsContextGL::workQueueInitialize):
(WebKit::RemoteGraphicsContextGL::reshape):
(WebKit::RemoteGraphicsContextGL::getErrors):
(WebKit::RemoteGraphicsContextGL::ensureExtensionEnabled):
(WebKit::RemoteGraphicsContextGL::simulateEventForTesting):
(WebKit::RemoteGraphicsContextGL::getBufferSubDataInline):
(WebKit::RemoteGraphicsContextGL::getBufferSubDataSharedMemory):
(WebKit::RemoteGraphicsContextGL::readPixelsInline):
(WebKit::RemoteGraphicsContextGL::readPixelsSharedMemory):
(WebKit::RemoteGraphicsContextGL::multiDrawArraysANGLE):
(WebKit::RemoteGraphicsContextGL::multiDrawArraysInstancedANGLE):
(WebKit::RemoteGraphicsContextGL::multiDrawElementsANGLE):
(WebKit::RemoteGraphicsContextGL::multiDrawElementsInstancedANGLE):
(WebKit::RemoteGraphicsContextGL::multiDrawArraysInstancedBaseInstanceANGLE):
(WebKit::RemoteGraphicsContextGL::multiDrawElementsInstancedBaseVertexBaseInstanceANGLE):
(WebKit::RemoteGraphicsContextGL::protectedContext):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h:
(WebKit::RemoteGraphicsContextGL::protectedWorkQueue const):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::stopListeningForIPC):
(WebKit::RemoteRenderingBackend::dispatch):
(WebKit::RemoteRenderingBackend::allocateImageBuffer):
(WebKit::RemoteRenderingBackend::getImageBufferResourceLimitsForTesting):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
(WebKit::RemoteRenderingBackend::protectedWorkQueue const):
* Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::protectedVideoFrameObjectHeapProxy):
* Source/WebKit/WebProcess/GPU/GPUProcessConnection.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::surfaceBufferToVideoFrame):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::connection):

Canonical link: https://commits.webkit.org/283930@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9cf1b1: Adopt more smart pointers in GPUProcess/graphics (...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9cf1b11b2983b1135d07858f035a2acd6b0fd4dc
  
https://github.com/WebKit/WebKit/commit/9cf1b11b2983b1135d07858f035a2acd6b0fd4dc
  Author: Rupin Mittal 
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp
M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePipelineLayout.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePipelineLayout.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRView.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/graphics (part 4)
https://bugs.webkit.org/show_bug.cgi?id=280706
rdar://137077186

Reviewed by Mike Wyrzykowski.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp:
(WebKit::RemoteImageBuffer::putPixelBuffer):
(WebKit::RemoteImageBuffer::filteredNativeImage):
(WebKit::RemoteImageBuffer::convertToLuminanceMask):
(WebKit::RemoteImageBuffer::transformToColorSpace):
(WebKit::RemoteImageBuffer::flushContext):
(WebKit::RemoteImageBuffer::flushContextSync):
(WebKit::RemoteImageBuffer::dynamicContentScalingDisplayList):
* Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp:
(WebKit::RemoteImageBufferSet::endPrepareForDisplay):
(WebKit::RemoteImageBufferSet::ensureBufferForDisplay):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp:
(WebKit::RemoteComputePassEncoder::RemoteComputePassEncoder):
(WebKit::RemoteComputePassEncoder::stopListeningForIPC):
(WebKit::RemoteComputePassEncoder::setPipeline):
(WebKit::RemoteComputePassEncoder::dispatch):
(WebKit::RemoteComputePassEncoder::dispatchIndirect):
(WebKit::RemoteComputePassEncoder::end):
(WebKit::RemoteComputePassEncoder::setBindGroup):
(WebKit::RemoteComputePassEncoder::pushDebugGroup):
(WebKit::RemoteComputePassEncoder::popDebugGroup):
(WebKit::RemoteComputePassEncoder::insertDebugMarker):
(WebKit::RemoteComputePassEncoder::setLabel):
(WebKit::RemoteComputePassEncoder::protectedBacking):
(WebKit::RemoteComputePassEncoder::protectedStreamConnection const):
(WebKit::RemoteComputePassEncoder::protectedObjectHeap const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemotePipelineLayout.cpp:
(WebKit::RemotePipelineLayout::RemotePipelineLayout):
(WebKit::RemotePipelineLayout::destruct):
(WebKit::RemotePipelineLayout::stopListeningForIPC):
(WebKit::RemotePipelineLayout::setLabel):
(WebKit::RemotePipelineLayout::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemotePipelineLayout.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.cpp:
(WebKit::RemoteRenderPipeline::RemoteRenderPipeline):
(WebKit::RemoteRenderPipeline::destruct):
(WebKit::RemoteRenderPipeline::stopListeningForIPC):
(WebKit::RemoteRenderPipeline::getBindGroupLayout):
(WebKit::RemoteRenderPipeline::setLabel):
(WebKit::RemoteRenderPipeline::protectedBacking):
(WebKit::RemoteRenderPipeline::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRView.cpp:
(WebKit::RemoteXRView::destruct):
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp:
(WebKit::RemoteSerializedImageBufferProxy::~RemoteSerializedImageBufferProxy):
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp:
(WebKit::RemoteImageBufferSetProxy::didPrepareForDisplay):
(WebKit::RemoteImageBufferSetProxy::close):
(WebKit::RemoteImageBufferSetProxy::willPrepareForDisplay):
(WebKit::RemoteImageBufferSetProxy::remoteBufferSetWasDestroyed):

Canonical link: https://commits.webkit.org/284538@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] de9684: Adopt more smart pointers in UIProcess (part 1)

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de9684148c23921b360994695679f21f92175579
  
https://github.com/WebKit/WebKit/commit/de9684148c23921b360994695679f21f92175579
  Author: Rupin Mittal 
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIActionCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionController.cpp
M Source/WebKit/UIProcess/RemotePageVisitedLinkStoreRegistration.h
M Source/WebKit/UIProcess/VisitedLinkStore.cpp
M Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h

  Log Message:
  ---
  Adopt more smart pointers in UIProcess (part 1)
https://bugs.webkit.org/show_bug.cgi?id=280770
rdar://137137674

Reviewed by Timothy Hatcher.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::createModelAndInterface):
(WebKit::VideoPresentationManagerProxy::removeClientForContext):
(WebKit::VideoPresentationManagerProxy::createLayerWithID):
(WebKit::VideoPresentationManagerProxy::setVideoDimensions):
(WebKit::VideoPresentationManagerProxy::protectedPlaybackSessionManagerProxy 
const):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIActionCocoa.mm:
(WebKit::WebExtensionContext::actionSetTitle):
(WebKit::WebExtensionContext::actionSetIcon):
(WebKit::WebExtensionContext::actionSetPopup):
(WebKit::WebExtensionContext::actionSetBadgeText):
(WebKit::WebExtensionContext::actionSetEnabled):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm:
(WebKit::WebExtensionContext::declarativeNetRequestDisplayActionCountAsBadgeText):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::injectedContents const):
(WebKit::WebExtensionContext::permissionState):
(WebKit::WebExtensionContext::corsDisablingPatterns):
(WebKit::WebExtensionContext::addInjectedContent):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm:
(WebKit::WebExtensionController::removePage):
* Source/WebKit/UIProcess/Extensions/WebExtensionController.cpp:
(WebKit::WebExtensionController::allProcesses const):
* Source/WebKit/UIProcess/RemotePageVisitedLinkStoreRegistration.h:
(WebKit::RemotePageVisitedLinkStoreRegistration::RemotePageVisitedLinkStoreRegistration):
(WebKit::RemotePageVisitedLinkStoreRegistration::~RemotePageVisitedLinkStoreRegistration):
(WebKit::RemotePageVisitedLinkStoreRegistration::protectedProcess const):
* Source/WebKit/UIProcess/VisitedLinkStore.cpp:
(WebKit::VisitedLinkStore::addVisitedLinkHashFromPage):
(WebKit::VisitedLinkStore::didUpdateSharedStringHashes):
* Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::startUpdatingWithProxy):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::protectedGeolocationPermissionRequestManager):
* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/284590@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6933b8: Adopt more smart pointers in UIProcess (part 2)

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6933b863ad8e50835b80f114df0eab2e1dd2f7db
  
https://github.com/WebKit/WebKit/commit/6933b863ad8e50835b80f114df0eab2e1dd2f7db
  Author: Rupin Mittal 
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
M Source/WebKit/UIProcess/Automation/WebAutomationSession.h
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
M Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp
M Source/WebKit/UIProcess/Downloads/DownloadProxy.h
M Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp
M Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.h
M Source/WebKit/UIProcess/ViewGestureController.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm

  Log Message:
  ---
  Adopt more smart pointers in UIProcess (part 2)
https://bugs.webkit.org/show_bug.cgi?id=280779
rdar://137149473

Reviewed by Chris Dumez.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::dispatchMessageFromRemote):
(WebKit::WebAutomationSession::connect):
(WebKit::WebAutomationSession::terminate):
(WebKit::WebAutomationSession::buildBrowsingContextForPage):
(WebKit::WebAutomationSession::waitForNavigationToComplete):
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnPage):
(WebKit::WebAutomationSession::willShowJavaScriptDialog):
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):
(WebKit::WebAutomationSession::protectedFrontendRouter const):
(WebKit::WebAutomationSession::protectedBackendDispatcher const):
* Source/WebKit/UIProcess/Automation/WebAutomationSession.h:
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
* Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
(WebKit::DownloadProxy::willSendRequest):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
(WebKit::DownloadProxy::protectedClient const):
* Source/WebKit/UIProcess/Downloads/DownloadProxy.h:
* Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp:
(WebKit::RemoteMediaSessionCoordinatorProxy::RemoteMediaSessionCoordinatorProxy):
(WebKit::RemoteMediaSessionCoordinatorProxy::join):
(WebKit::RemoteMediaSessionCoordinatorProxy::leave):
(WebKit::RemoteMediaSessionCoordinatorProxy::coordinateSeekTo):
(WebKit::RemoteMediaSessionCoordinatorProxy::coordinatePlay):
(WebKit::RemoteMediaSessionCoordinatorProxy::coordinatePause):
(WebKit::RemoteMediaSessionCoordinatorProxy::coordinateSetTrack):
(WebKit::RemoteMediaSessionCoordinatorProxy::positionStateChanged):
(WebKit::RemoteMediaSessionCoordinatorProxy::playbackStateChanged):
(WebKit::RemoteMediaSessionCoordinatorProxy::readyStateChanged):
(WebKit::RemoteMediaSessionCoordinatorProxy::trackIdentifierChanged):
* Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.h:
(WebKit::RemoteMediaSessionCoordinatorProxy::protectedPrivateCoordinator):
* Source/WebKit/UIProcess/ViewGestureController.cpp:
(WebKit::ViewGestureController::checkForActiveLoads):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::protectedPageLoadState):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didExceedMemoryFootprintThreshold):
* Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::resetState):

Canonical link: https://commits.webkit.org/284594@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d2c82d: Adopt more smart pointers in GPUProcess/graphics (...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2c82d24e299ae964167f8036fff02b14c072327
  
https://github.com/WebKit/WebKit/commit/d2c82d24e299ae964167f8036fff02b14c072327
  Author: Rupin Mittal 
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/graphics (part 5)
https://bugs.webkit.org/show_bug.cgi?id=280721
rdar://137091365

Reviewed by Ryosuke Niwa.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
(WebKit::RemoteDisplayListRecorder::imageBuffer const):
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:
(WebKit::RemoteDisplayListRecorder::protectedRenderingBackend const):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::surfaceBufferToVideoFrame):
(WebKit::RemoteGraphicsContextGL::paintNativeImageToImageBuffer):
(WebKit::RemoteGraphicsContextGL::protectedVideoFrameObjectHeap const):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
(WebKit::RemoteGraphicsContextGL::copyTextureFromVideoFrame):
(WebKit::RemoteGraphicsContextGLCocoa::prepareForDisplay):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::workQueueInitialize):
(WebKit::RemoteRenderingBackend::workQueueUninitialize):
(WebKit::RemoteRenderingBackend::moveToSerializedBuffer):
(WebKit::RemoteRenderingBackend::moveToImageBuffer):
(WebKit::RemoteRenderingBackend::createRemoteBarcodeDetector):
(WebKit::RemoteRenderingBackend::releaseRemoteBarcodeDetector):
(WebKit::RemoteRenderingBackend::createRemoteFaceDetector):
(WebKit::RemoteRenderingBackend::releaseRemoteFaceDetector):
(WebKit::RemoteRenderingBackend::createRemoteTextDetector):
(WebKit::RemoteRenderingBackend::releaseRemoteTextDetector):
(WebKit::RemoteRenderingBackend::protectedShapeDetectionObjectHeap const):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::initializeIPC):
(WebKit::RemoteGraphicsContextGLProxy::protectedVideoFrameObjectHeapProxy 
const):
(WebKit::RemoteGraphicsContextGLProxy::videoFrameToImage):
(WebKit::RemoteGraphicsContextGLProxy::wasCreated):
(WebKit::RemoteGraphicsContextGLProxy::waitUntilInitialized):
(WebKit::RemoteGraphicsContextGLProxy::abandonGpuProcess):
(WebKit::RemoteGraphicsContextGLProxy::disconnectGpuProcessIfNeeded):
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
(WebKit::RemoteGraphicsContextGLProxy::send):
(WebKit::RemoteGraphicsContextGLProxy::sendSync):
(WebKit::RemoteGraphicsContextGLProxy::protectedStreamConnection const):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::ensureGPUProcessConnection):
(WebKit::RemoteRenderingBackendProxy::disconnectGPUProcess):
(WebKit::RemoteRenderingBackendProxy::didInitialize):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
(WebKit::RemoteRenderingBackendProxy::protectedConnection const):
* 
Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm:

Canonical link: https://commits.webkit.org/284620@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f66e2c: Adopt more smart pointers in GPUProcess/graphics (...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f66e2c40cc0621e5282e4c5b25ae9c245cab952d
  
https://github.com/WebKit/WebKit/commit/f66e2c40cc0621e5282e4c5b25ae9c245cab952d
  Author: Rupin Mittal 
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandBuffer.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandBuffer.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteExternalTexture.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteExternalTexture.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRProjectionLayer.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in GPUProcess/graphics (part 2)
https://bugs.webkit.org/show_bug.cgi?id=280661
rdar://137023471

Reviewed by Chris Dumez and Mike Wyrzykowski.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp:
(WebKit::RemoteImageBufferSet::endPrepareForDisplay):
(WebKit::RemoteImageBufferSet::ensureBufferForDisplay):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandBuffer.cpp:
(WebKit::RemoteCommandBuffer::RemoteCommandBuffer):
(WebKit::RemoteCommandBuffer::destruct):
(WebKit::RemoteCommandBuffer::stopListeningForIPC):
(WebKit::RemoteCommandBuffer::setLabel):
(WebKit::RemoteCommandBuffer::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandBuffer.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.cpp:
(WebKit::RemoteComputePipeline::RemoteComputePipeline):
(WebKit::RemoteComputePipeline::destruct):
(WebKit::RemoteComputePipeline::stopListeningForIPC):
(WebKit::RemoteComputePipeline::getBindGroupLayout):
(WebKit::RemoteComputePipeline::setLabel):
(WebKit::RemoteComputePipeline::protectedBacking):
(WebKit::RemoteComputePipeline::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteExternalTexture.cpp:
(WebKit::RemoteExternalTexture::RemoteExternalTexture):
(WebKit::RemoteExternalTexture::destroy):
(WebKit::RemoteExternalTexture::undestroy):
(WebKit::RemoteExternalTexture::destruct):
(WebKit::RemoteExternalTexture::stopListeningForIPC):
(WebKit::RemoteExternalTexture::setLabel):
(WebKit::RemoteExternalTexture::protectedBacking):
(WebKit::RemoteExternalTexture::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteExternalTexture.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.cpp:
(WebKit::RemoteTexture::createView):
(WebKit::RemoteTexture::destroy):
(WebKit::RemoteTexture::destruct):
(WebKit::RemoteTexture::setLabel):
(WebKit::RemoteTexture::protectedBacking):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.cpp:
(WebKit::RemoteTextureView::RemoteTextureView):
(WebKit::RemoteTextureView::destruct):
(WebKit::RemoteTextureView::stopListeningForIPC):
(WebKit::RemoteTextureView::setLabel):
(WebKit::RemoteTextureView::protectedStreamConnection const):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteXRProjectionLayer.cpp:
(WebKit::RemoteXRProjectionLayer::destruct):
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp:
(WebKit::RemoteImageBufferSetProxy::didPrepareForDisplay):
(WebKit::RemoteImageBufferSetProxy::close):
(WebKit::RemoteImageBufferSetProxy::willPrepareForDisplay):
(WebKit::RemoteImageBufferSetProxy::remoteBufferSetWasDestroyed):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp:
(WebKit::WebGPU::RemoteTextureProxy::createView):

Canonical link: https://commits.webkit.org/284621@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b7b8fa: Adopt more smart pointers in RemoteSourceBufferProxy

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7b8fa7a163976d33d36e2d31208776bafe9baa4
  
https://github.com/WebKit/WebKit/commit/b7b8fa7a163976d33d36e2d31208776bafe9baa4
  Author: Rupin Mittal 
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
M Source/WebCore/platform/graphics/SourceBufferPrivateClient.h
M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in RemoteSourceBufferProxy
https://bugs.webkit.org/show_bug.cgi?id=279797
rdar://136114766

Reviewed by Ryosuke Niwa.

Smart pointer adoption as per the static analyzer.

* Source/WebCore/platform/graphics/SourceBufferPrivateClient.h:
(WebCore::SourceBufferPrivateClient::InitializationSegment::AudioTrackInformation::protectedTrack
 const):
(WebCore::SourceBufferPrivateClient::InitializationSegment::VideoTrackInformation::protectedTrack
 const):
(WebCore::SourceBufferPrivateClient::InitializationSegment::TextTrackInformation::protectedTrack
 const):
* Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateDidReceiveInitializationSegment):
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateHighestPresentationTimestampChanged):
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateDurationChanged):
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateBufferedChanged):
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateDidDropSample):
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateDidReceiveRenderingError):
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateEvictionDataChanged):
(WebKit::RemoteSourceBufferProxy::append):
(WebKit::RemoteSourceBufferProxy::evictCodedFrames):
(WebKit::RemoteSourceBufferProxy::shutdown):

Canonical link: https://commits.webkit.org/283822@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 166599: Adopt more smart pointers in RemoteMediaPlayerProxy

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 166599751ffd630dfe2e47f6c6e5f55cb61f1fc5
  
https://github.com/WebKit/WebKit/commit/166599751ffd630dfe2e47f6c6e5f55cb61f1fc5
  Author: Rupin Mittal 
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.h
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h
M Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm

  Log Message:
  ---
  Adopt more smart pointers in RemoteMediaPlayerProxy
https://bugs.webkit.org/show_bug.cgi?id=279841
rdar://136174429

Reviewed by Ryosuke Niwa and Charlie Wolfe.

Smart pointer adoption as per the static analyzer.

* Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.cpp:
(WebKit::RemoteCDMInstanceProxy::protectedInstance const):
* Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.h:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::getConfiguration):
(WebKit::RemoteMediaPlayerProxy::loadMediaSource):
(WebKit::RemoteMediaPlayerProxy::play):
(WebKit::RemoteMediaPlayerProxy::didLoadingProgress):
(WebKit::RemoteMediaPlayerProxy::requestResource):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerReadyStateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerVolumeChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMuteChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerSeeked):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerTimeChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerEngineFailedToLoad):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerPlaybackStateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerCharacteristicChanged):
(WebKit::RemoteMediaPlayerProxy::addRemoteAudioTrackProxy):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerWaitingForKeyChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
(WebKit::RemoteMediaPlayerProxy::currentTimeChanged):
(WebKit::RemoteMediaPlayerProxy::updateCachedState):
(WebKit::RemoteMediaPlayerProxy::cdmInstanceAttached):
(WebKit::RemoteMediaPlayerProxy::cdmInstanceDetached):
(WebKit::RemoteMediaPlayerProxy::attemptToDecryptWithInstance):
(WebKit::RemoteMediaPlayerProxy::performTaskAtTime):
(WebKit::RemoteMediaPlayerProxy::isCrossOrigin):
(WebKit::RemoteMediaPlayerProxy::createAudioSourceProvider):
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h:
* Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged):

Canonical link: https://commits.webkit.org/283823@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b0cea8: Use strongly typed identifiers for IDBIndex

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0cea80e2b0e598465448c484053e1f8ab202078
  
https://github.com/WebKit/WebKit/commit/b0cea80e2b0e598465448c484053e1f8ab202078
  Author: Rupin Mittal 
  Date:   2024-11-06 (Wed, 06 Nov 2024)

  Changed paths:
M Source/WebCore/Headers.cmake
A Source/WebCore/Modules/indexeddb/IDBIndexIdentifier.h
M Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp
M Source/WebCore/Modules/indexeddb/IDBObjectStore.h
M Source/WebCore/Modules/indexeddb/IDBRequest.cpp
M Source/WebCore/Modules/indexeddb/IDBRequest.h
M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
M Source/WebCore/Modules/indexeddb/IDBTransaction.h
M Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp
M Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h
M Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp
M Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h
M Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h
M Source/WebCore/Modules/indexeddb/client/TransactionOperation.h
M Source/WebCore/Modules/indexeddb/server/IDBBackingStore.h
M Source/WebCore/Modules/indexeddb/server/IDBServer.cpp
M Source/WebCore/Modules/indexeddb/server/IDBServer.h
M Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp
M Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h
M Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp
M Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.h
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.h
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.cpp
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.h
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h
M Source/WebCore/Modules/indexeddb/shared/IDBCursorInfo.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBCursorInfo.h
M Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h
M Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.h
M Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.h
M Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.h
M Source/WebCore/Modules/indexeddb/shared/IDBRequestData.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h
M Source/WebCore/Modules/indexeddb/shared/IndexKey.h
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
M Source/WebKit/Shared/WTFArgumentCoders.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp
M Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h
M Source/WebKitLegacy/Storage/InProcessIDBServer.cpp
M Source/WebKitLegacy/Storage/InProcessIDBServer.h

  Log Message:
  ---
  Use strongly typed identifiers for IDBIndex
https://bugs.webkit.org/show_bug.cgi?id=281918
rdar://135232997

Reviewed by Sihui Liu.

We prefer to use strongly-typed identifiers where possible.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/indexeddb/IDBIndexIdentifier.h: Copied from 
Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.h.
* Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::rollbackForVersionChangeAbort):
* Source/WebCore/Modules/indexeddb/IDBObjectStore.h:
* Source/WebCore/Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::sourceIndexIdentifier const):
* Source/WebCore/Modules/indexeddb/IDBRequest.h:
* Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::renameIndex):
(WebCore::IDBTransaction::renameIndexOnServer):
(WebCore::IDBTransaction::requestGetAllObjectStoreRecords):
* Source/WebCore/Modules/indexeddb/IDBTransaction.h:
* Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::renameIndex

[webkit-changes] [WebKit/WebKit] 5fb6d5: CrossThreadRecord allows you to control uint64_t r...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5fb6d5a7c2a572d1453131b92ed757359014852b
  
https://github.com/WebKit/WebKit/commit/5fb6d5a7c2a572d1453131b92ed757359014852b
  Author: Rupin Mittal 
  Date:   2024-11-06 (Wed, 06 Nov 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.h
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h

  Log Message:
  ---
  CrossThreadRecord allows you to control uint64_t responseBodySize
rdar://124960263
https://bugs.webkit.org/show_bug.cgi?id=278357

Reviewed by Sihui Liu.

There are two problems in this bug that we fix:
(1) In the function CacheStorageCache::putRecords, uint64_t responseBodySize
is added and subtracted from int64_t spaceRequested. We fix this mismatch
by changing the type of spaceRequested to CheckedUint64 and then checking
for overflow.

Some of the records being added already exist in the cache. We keep track
of whether the new version of that record needs more or less space than
the existing record and request additional space only if needed.

(2) When the client sends the records over IPC, they also send the record's
size--and this size is used to calculate and then allocate space. But
because the client is sending the size, it's possible an attacker sends
a false value for the size. This size is calculated on the client side
in CacheStorageConnection::computeRecordBodySize. It does not return the
exact size of the body, but rather a size that has a random padding added.
We do this for security concerns: 
https://github.com/whatwg/storage/issues/31.
Since this size is random, we cannot check the size by re-calculating it.
What we can do is ensure that the size is greater than the actual size
because a smaller size would be a clear indication that the size has been
tampered with. So we add a check to at least ensure that the size is greater
since all the randomly padded sizes are indeed greater than the true sizes.

This check is done in NetworkStorageManager::cacheStoragePutRecords using
MESSAGE_CHECK so the WebContent process can be killed if the size is 
invalid,
indicating that the process is compromised.

* Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp:
(WebKit::CacheStorageCache::putRecords):
* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp:
(WebKit::encodeRecordBody):
(WebKit::CacheStorageDiskStore::computeRealBodySizeForStorage):
(WebKit::CacheStorageDiskStore::writeRecords):
* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.h:
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::cacheStoragePutRecords):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h:

Originally-landed-as: 280938.255@safari-7619-branch (8150063459d1). 
rdar://138929915
Canonical link: https://commits.webkit.org/286232@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes