[webkit-changes] [WebKit/WebKit] f997f0: Remove unused iExploder scripts

[Daniel Jalkut]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f997f0d12d7a9f05bdc10b67ad08726090500220
  
https://github.com/WebKit/WebKit/commit/f997f0d12d7a9f05bdc10b67ad08726090500220
  Author: Daniel Jalkut 
  Date:   2023-10-30 (Mon, 30 Oct 2023)

  Changed paths:
R Tools/Scripts/run-iexploder-tests
R Tools/Scripts/update-iexploder-cssproperties

  Log Message:
  ---
  Remove unused iExploder scripts
https://bugs.webkit.org/show_bug.cgi?id=263900

Reviewed by Alexey Proskuryakov.

Since the removal of iExploder from the repository a few years ago, these 
scripts have
only been cruft with no apparent value. Removing them will make the Scripts 
folder
ever-so-slightly more comprehensible.
* Tools/Scripts/run-iexploder-tests: Removed.
* Tools/Scripts/update-iexploder-cssproperties: Removed.

Canonical link: https://commits.webkit.org/269975@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f9aed0: Add Daniel Jalkut to contributors

[Daniel Jalkut]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f9aed021cbba1165eeb4298a3dbdf128009e75be
  
https://github.com/WebKit/WebKit/commit/f9aed021cbba1165eeb4298a3dbdf128009e75be
  Author: Daniel Jalkut 
  Date:   2022-10-17 (Mon, 17 Oct 2022)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add Daniel Jalkut to contributors
https://bugs.webkit.org/show_bug.cgi?id=246644

Reviewed by Jonathan Bedard.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/255651@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 76bb96: Defer to non-anonymous ancestor when determining s...

[Daniel Jalkut]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76bb9606ee1b4724d5df8ad4b259092268af8fe0
  
https://github.com/WebKit/WebKit/commit/76bb9606ee1b4724d5df8ad4b259092268af8fe0
  Author: Daniel Jalkut 
  Date:   2023-11-26 (Sun, 26 Nov 2023)

  Changed paths:
A LayoutTests/fast/selectors/selection-gap-background-color-expected.html
A LayoutTests/fast/selectors/selection-gap-background-color.html
M Source/WebCore/rendering/RenderElement.cpp

  Log Message:
  ---
  Defer to non-anonymous ancestor when determining selection background color 
for anonymous blocks.
https://bugs.webkit.org/show_bug.cgi?id=263658

Reviewed by Ryosuke Niwa.

There is a precedent for anonymous blocks deferring to their non-anonymous
ancestors when deriving selectionBackgroundColor. For example RenderText
defers to its ancestor in order to ensure text blocks are colored correctly
when a custom color has been set with a Selection pseudo-element. This
change addresses the failure to defer to an ancestor when painting the
selection on gaps between two blocks with uneven widths. By deferring to
nonAnonymousAncestor at the RenderElement level, it should ensure a fix for
bug #263658 as well as potentially alleviating failures in other areas that
have not yet been diagnosed. Because the change is limited to anonymous nodes,
and because the selectionBackgroundColor is only consulted specifically when
managing the painting of selected ranges, I believe this is a low risk proposal
which cleanly addresses the linked bug report.

* 
LayoutTests/platform/mac/fast/selectors/selection-gap-background-color-expected.png:
 Added.
* LayoutTests/platform/mac/fast/selectors/selection-gap-background-color.html: 
Added.
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::selectionBackgroundColor const):

Canonical link: https://commits.webkit.org/271129@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes