[webkit-changes] [WebKit/WebKit] 93cc2e: [GTK] WebView empty with GTK Vulkan renderer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 93cc2e901af9447420859e26973feb8a73b5dd81 https://github.com/WebKit/WebKit/commit/93cc2e901af9447420859e26973feb8a73b5dd81 Author: Carlos Garcia Campos Date: 2024-01-31 (Wed, 31 Jan 2024) Changed paths: M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h Log Message: --- [GTK] WebView empty with GTK Vulkan renderer https://bugs.webkit.org/show_bug.cgi?id=267578 Reviewed by Alejandro G. Castro. The problem is that we are creating to GdkTextures and reusing them all the time. That works for the GL renderer, but it's not the way GTK expects the API tyo be used. GdkTexture can be cached by GTK internally, so it's not expected to change its contents and the associated GL resources should be released by the destroy notify. This patch creates a new GL texture and GdkTexture every time a buffer changes its contents. * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp: (WebKit::AcceleratedBackingStoreDMABuf::~AcceleratedBackingStoreDMABuf): (WebKit::AcceleratedBackingStoreDMABuf::Buffer::Buffer): (WebKit::AcceleratedBackingStoreDMABuf::BufferEGLImage::create): (WebKit::AcceleratedBackingStoreDMABuf::BufferEGLImage::BufferEGLImage): (WebKit::AcceleratedBackingStoreDMABuf::BufferEGLImage::~BufferEGLImage): (WebKit::Texture::Texture): (WebKit::Texture::~Texture): (WebKit::AcceleratedBackingStoreDMABuf::BufferEGLImage::didUpdateContents): (WebKit::AcceleratedBackingStoreDMABuf::BufferGBM::create): (WebKit::AcceleratedBackingStoreDMABuf::BufferGBM::BufferGBM): (WebKit::AcceleratedBackingStoreDMABuf::BufferGBM::didUpdateContents): (WebKit::AcceleratedBackingStoreDMABuf::BufferSHM::create): (WebKit::AcceleratedBackingStoreDMABuf::BufferSHM::BufferSHM): (WebKit::AcceleratedBackingStoreDMABuf::BufferSHM::didUpdateContents): (WebKit::AcceleratedBackingStoreDMABuf::Renderer::snapshot const): (WebKit::AcceleratedBackingStoreDMABuf::Renderer::paint const): (WebKit::AcceleratedBackingStoreDMABuf::didCreateBuffer): (WebKit::AcceleratedBackingStoreDMABuf::didCreateBufferSHM): (WebKit::AcceleratedBackingStoreDMABuf::frame): (WebKit::AcceleratedBackingStoreDMABuf::unrealize): (WebKit::AcceleratedBackingStoreDMABuf::prepareForRendering): (WebKit::AcceleratedBackingStoreDMABuf::snapshot): (WebKit::AcceleratedBackingStoreDMABuf::paint): (WebKit::AcceleratedBackingStoreDMABuf::BufferGBM::surface const): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::BufferSHM::surface const): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::Renderer::setBuffer): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::RendererGL::RendererGL): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::RendererGL::~RendererGL): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::RendererGL::setBuffer): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::RendererGL::snapshot const): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::RendererGL::paint const): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::RendererCairo::setBuffer): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::RendererCairo::snapshot const): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::RendererCairo::paint const): Deleted. (WebKit::AcceleratedBackingStoreDMABuf::ensureRenderer): Deleted. * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h: Canonical link: https://commits.webkit.org/273818@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a9dda: [TextureMapper] Remove SurfaceUpdateInfo
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a9ddac3f43f8b4bd95d3427a86612e216947c63 https://github.com/WebKit/WebKit/commit/8a9ddac3f43f8b4bd95d3427a86612e216947c63 Author: Carlos Garcia Campos Date: 2024-01-31 (Wed, 31 Jan 2024) Changed paths: M Source/WebCore/platform/TextureMapper.cmake M Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.h M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.h M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineBasic.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineBasic.h M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.h M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp R Source/WebCore/platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h M Source/WebCore/platform/graphics/texmap/coordinated/Tile.cpp M Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStoreClient.h M Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp Log Message: --- [TextureMapper] Remove SurfaceUpdateInfo https://bugs.webkit.org/show_bug.cgi?id=268447 Reviewed by Alejandro G. Castro and Nikolas Zimmermann. Nowadays it only contains the update rect and buffer, so it's simpler to just pass those to updateTile(). Also change NicosiaPaintingEngine paint function to receive a reference to the buffer and return void since they always return true. * Source/WebCore/platform/TextureMapper.cmake: * Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.cpp: (Nicosia::BackingStore::updateTile): * Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.h: * Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.h: * Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.h: * Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineBasic.cpp: (Nicosia::PaintingEngineBasic::paint): * Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineBasic.h: * Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp: (Nicosia::PaintingEngineThreaded::paint): * Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::updateContentBuffers): * Source/WebCore/platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h: Removed. * Source/WebCore/platform/graphics/texmap/coordinated/Tile.cpp: * Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStoreClient.h: * Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: (WebKit::updateBackingStore): Canonical link: https://commits.webkit.org/273822@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a07d3e: [GTK] Use the new GTK API to create a GdkTexture f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a07d3e4e2067578a818215d89f5742b5e9707389 https://github.com/WebKit/WebKit/commit/a07d3e4e2067578a818215d89f5742b5e9707389 Author: Carlos Garcia Campos Date: 2024-02-01 (Thu, 01 Feb 2024) Changed paths: M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h Log Message: --- [GTK] Use the new GTK API to create a GdkTexture from a DMA-BUF buffer https://bugs.webkit.org/show_bug.cgi?id=268445 Reviewed by Alejandro G. Castro. Using GdkDmabufTextureBuilder we can create a GdkTexture to pass to GTK without having to use EGL. * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp: (WebKit::AcceleratedBackingStoreDMABuf::BufferDMABuf::create): (WebKit::AcceleratedBackingStoreDMABuf::BufferDMABuf::BufferDMABuf): (WebKit::AcceleratedBackingStoreDMABuf::BufferDMABuf::didUpdateContents): (WebKit::AcceleratedBackingStoreDMABuf::Renderer::snapshot const): (WebKit::AcceleratedBackingStoreDMABuf::didCreateBuffer): * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h: Canonical link: https://commits.webkit.org/273890@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 63192f: Unreviewed. [CMake] Move platform specific headers...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63192fc76e3caa50890203fdebb31996f0564a87 https://github.com/WebKit/WebKit/commit/63192fc76e3caa50890203fdebb31996f0564a87 Author: Carlos Garcia Campos Date: 2024-02-02 (Fri, 02 Feb 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/PlatformMac.cmake Log Message: --- Unreviewed. [CMake] Move platform specific headers to platform cmake file * Source/WebCore/Headers.cmake: * Source/WebCore/PlatformMac.cmake: Canonical link: https://commits.webkit.org/273982@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 01374b: Unreviewed. Update OptionsGTK.cmake and NEWS for 2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 01374b445fe1adb5d13fc598ed998675324c23ac https://github.com/WebKit/WebKit/commit/01374b445fe1adb5d13fc598ed998675324c23ac Author: Carlos Garcia Campos Date: 2024-02-02 (Fri, 02 Feb 2024) Changed paths: M Source/WebKit/gtk/NEWS M Source/cmake/OptionsGTK.cmake Log Message: --- Unreviewed. Update OptionsGTK.cmake and NEWS for 2.43.4 release * Source/WebKit/gtk/NEWS: Add release notes for 2.43.4. * Source/cmake/OptionsGTK.cmake: Bump version numbers. Canonical link: https://commits.webkit.org/273983@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/webkitgtk-2.43.4 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5051f8: Unreviewed. Update OptionsGTK.cmake and NEWS for 2...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 5051f8e7aeb8cbdb0c36f9b73cf213436ebc9301 https://github.com/WebKit/WebKit/commit/5051f8e7aeb8cbdb0c36f9b73cf213436ebc9301 Author: Carlos Garcia Campos Date: 2024-02-05 (Mon, 05 Feb 2024) Changed paths: M Source/WebKit/gtk/NEWS M Source/cmake/OptionsGTK.cmake Log Message: --- Unreviewed. Update OptionsGTK.cmake and NEWS for 2.42.5 release * Source/WebKit/gtk/NEWS: Add release notes for 2.42.5. * Source/cmake/OptionsGTK.cmake: Bump version numbers. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/webkitgtk-2.42.5 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fda621: [WPE] WPE Platform: add monitors API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fda6216679915707208bd7794ae22c0c92b808cd https://github.com/WebKit/WebKit/commit/fda6216679915707208bd7794ae22c0c92b808cd Author: Carlos Garcia Campos Date: 2024-02-05 (Mon, 05 Feb 2024) Changed paths: M Source/WebCore/platform/PlatformScreen.cpp M Source/WebCore/platform/ScreenProperties.h M Source/WebCore/platform/wpe/PlatformScreenWPE.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/Shared/WebPageCreationParameters.h M Source/WebKit/Shared/WebPageCreationParameters.serialization.in M Source/WebKit/Shared/WebProcessCreationParameters.h M Source/WebKit/Shared/WebProcessCreationParameters.serialization.in M Source/WebKit/SourcesGTK.txt M Source/WebKit/SourcesWPE.txt M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp A Source/WebKit/UIProcess/glib/ScreenManager.cpp A Source/WebKit/UIProcess/glib/ScreenManager.h M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp R Source/WebKit/UIProcess/gtk/ScreenManager.cpp R Source/WebKit/UIProcess/gtk/ScreenManager.h A Source/WebKit/UIProcess/gtk/ScreenManagerGtk.cpp A Source/WebKit/UIProcess/wpe/ScreenManagerWPE.cpp M Source/WebKit/WPEPlatform/CMakeLists.txt M Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp M Source/WebKit/WPEPlatform/wpe/WPEDisplay.h A Source/WebKit/WPEPlatform/wpe/WPEMonitor.cpp A Source/WebKit/WPEPlatform/wpe/WPEMonitor.h M Source/WebKit/WPEPlatform/wpe/WPEView.cpp M Source/WebKit/WPEPlatform/wpe/WPEView.h M Source/WebKit/WPEPlatform/wpe/wayland/CMakeLists.txt M Source/WebKit/WPEPlatform/wpe/wayland/WPEDisplayWayland.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEDisplayWaylandPrivate.h A Source/WebKit/WPEPlatform/wpe/wayland/WPEMonitorWayland.cpp A Source/WebKit/WPEPlatform/wpe/wayland/WPEMonitorWayland.h A Source/WebKit/WPEPlatform/wpe/wayland/WPEMonitorWaylandPrivate.h M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp M Source/WebKit/WPEPlatform/wpe/wayland/wpe-wayland.h M Source/WebKit/WPEPlatform/wpe/wpe-platform.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/WebProcess.messages.in M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp Log Message: --- [WPE] WPE Platform: add monitors API https://bugs.webkit.org/show_bug.cgi?id=265639 Reviewed by Adrian Perez de Castro. Add monitors API with implementation for the wayland platform for now. This API is used inside WebKit to set the screen properties, set the platform display ID and get the refresh rate for display link. * Source/WebCore/platform/PlatformScreen.cpp: * Source/WebCore/platform/ScreenProperties.h: * Source/WebCore/platform/wpe/PlatformScreenWPE.cpp: (WebCore::widgetDisplayID): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenDPI): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::setScreenDPIObserverHandler): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/Shared/WebPageCreationParameters.serialization.in: * Source/WebKit/Shared/WebProcessCreationParameters.h: * Source/WebKit/Shared/WebProcessCreationParameters.serialization.in: * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::m_backend): (WKWPE::View::~View): (WKWPE::View::updateDisplayID): * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): * Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp: (WebKit::findCrtc): (WebKit::DisplayVBlankMonitorDRM::create): * Source/WebKit/UIProcess/glib/ScreenManager.cpp: Copied from Source/WebKit/UIProcess/gtk/ScreenManager.h. (WebKit::ScreenManager::singleton): (WebKit::ScreenManager::displayID const): (WebKit::ScreenManager::monitor const): (WebKit::ScreenManager::addMonitor): (WebKit::ScreenManager::removeMonitor): (WebKit::ScreenManager::propertiesDidChange const): * Source/WebKit/UIProcess/glib/ScreenManager.h: Renamed from Source/WebKit/UIProcess/gtk/ScreenManager.h. * Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp: (WebKit::WebProcessPool::platformInitializeWebProcess): * Source/WebKit/UIProcess/gtk/ScreenManagerGtk.cpp: Renamed from Source/WebKit/UIProcess/gtk/ScreenManager.cpp. (WebKit::ScreenManager::generatePlatformDisplayID): (WebKit::ScreenManager::ScreenManager): (WebKit::ScreenManager::collectScreenProperties const): * Source/WebKit/UIProcess
[webkit-changes] [WebKit/WebKit] cad5d7: [GTK][WPE] Initialize display ID as early as possible
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cad5d7e5ed760db4515ca25da8080fe5e85b7e90 https://github.com/WebKit/WebKit/commit/cad5d7e5ed760db4515ca25da8080fe5e85b7e90 Author: Carlos Garcia Campos Date: 2024-02-06 (Tue, 06 Feb 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/glib/DisplayVBlankMonitor.cpp M Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp M Source/WebKit/UIProcess/glib/ScreenManager.h M Source/WebKit/UIProcess/gtk/ScreenManagerGtk.cpp M Source/WebKit/UIProcess/wpe/ScreenManagerWPE.cpp Log Message: --- [GTK][WPE] Initialize display ID as early as possible https://bugs.webkit.org/show_bug.cgi?id=268744 Reviewed by Adrian Perez de Castro. In GTK we currently get the display ID when the toplevel window is realized and gets a monitor assigned. This is happening right after the web page is initialized, which means we always create the web page with 0 display ID and right after that a window screen change happens. Because of this we end up creating two display link monitors. We can avoid this by initializing the web view display id as soon as possible using the primary display ID, that in most of the cases will be then one used when the monitor is assigned to the toplevel. This patch also ensures we never create a DRM vblank monitor when display ID is 0, since that's never a valid monitor. We just fallback to the timer vblank monitor in that case. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseConstructed): * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::m_backend): * Source/WebKit/UIProcess/glib/DisplayVBlankMonitor.cpp: (WebKit::DisplayVBlankMonitor::create): * Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp: (WebKit::DisplayVBlankMonitorDRM::create): * Source/WebKit/UIProcess/glib/ScreenManager.h: (WebKit::ScreenManager::primaryDisplayID const): * Source/WebKit/UIProcess/gtk/ScreenManagerGtk.cpp: (WebKit::ScreenManager::ScreenManager): (WebKit::ScreenManager::updatePrimaryDisplayID): (WebKit::ScreenManager::collectScreenProperties const): * Source/WebKit/UIProcess/wpe/ScreenManagerWPE.cpp: (WebKit::ScreenManager::ScreenManager): (WebKit::ScreenManager::updatePrimaryDisplayID): (WebKit::ScreenManager::collectScreenProperties const): Canonical link: https://commits.webkit.org/274136@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0a6147: [GTK][WPE] Do not use real time priority for the d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0a61478183a9db5ee3be866b5106eabd336a0be1 https://github.com/WebKit/WebKit/commit/0a61478183a9db5ee3be866b5106eabd336a0be1 Author: Carlos Garcia Campos Date: 2024-02-07 (Wed, 07 Feb 2024) Changed paths: M Source/WebKit/UIProcess/glib/DisplayVBlankMonitor.cpp Log Message: --- [GTK][WPE] Do not use real time priority for the display link thread https://bugs.webkit.org/show_bug.cgi?id=268900 Reviewed by Michael Catanzaro. In some cases it can cause the rtkit daemon to kill the ui process due to CPU usage limit. * Source/WebKit/UIProcess/glib/DisplayVBlankMonitor.cpp: (WebKit::DisplayVBlankMonitor::startThreadIfNeeded): Canonical link: https://commits.webkit.org/274210@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4756fe: [WPE] WPE Platform: use the primary device to allo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4756fe12807725f145572d0a0e873a6f517bb3bd https://github.com/WebKit/WebKit/commit/4756fe12807725f145572d0a0e873a6f517bb3bd Author: Carlos Garcia Campos Date: 2024-02-09 (Fri, 09 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/PlatformDisplay.cpp M Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp M Source/WebCore/platform/graphics/gbm/GBMDevice.cpp M Source/WebCore/platform/graphics/gbm/GBMDevice.h M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp M Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp M Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp Log Message: --- [WPE] WPE Platform: use the primary device to allocate buffers when doing direct scanout under wayland https://bugs.webkit.org/show_bug.cgi?id=268821 Reviewed by Nikolas Zimmermann. We currently use always the render node, but for scanout we should use the primary device. GBMDevice has now two devices, render and display, and only the filename is set during the initialization. We search the DRM node for the given file and set the filename of the render and display devices. If they are the same display is not initialized and render is always used. When the GBM device is requested for the first time, the device is actually opened and GBM device created, to make sure we only create the devices if they are really used. * Source/WebCore/platform/graphics/PlatformDisplay.cpp: (WebCore::PlatformDisplay::createPlatformDisplay): (WebCore::PlatformDisplay::gbmDevice): * Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp: (WebCore::GBMBufferSwapchain::getBuffer): * Source/WebCore/platform/graphics/gbm/GBMDevice.cpp: (WebCore::GBMDevice::Device::~Device): (WebCore::GBMDevice::Device::device const): (WebCore::GBMDevice::singleton): (WebCore::GBMDevice::~GBMDevice): (WebCore::GBMDevice::initialize): (WebCore::GBMDevice::device const): * Source/WebCore/platform/graphics/gbm/GBMDevice.h: (WebCore::GBMDevice::isInitialized const): (WebCore::GBMDevice::Device::setFilename): (WebCore::GBMDevice::Device::hasFilename const): (WebCore::GBMDevice::device const): Deleted. * Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp: (WebCore::GraphicsContextGLGBM::platformInitializeContext): * Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp: (webKitDMABufVideoSinkIsEnabled): * Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp: (WebKit::AcceleratedSurfaceDMABuf::RenderTargetEGLImage::create): Canonical link: https://commits.webkit.org/274361@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de802f: [WPE] Import the initial painting implementation u...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de802f3b8dfb14d2f8ca791924761285726ab392 https://github.com/WebKit/WebKit/commit/de802f3b8dfb14d2f8ca791924761285726ab392 Author: Carlos Garcia Campos Date: 2024-02-12 (Mon, 12 Feb 2024) Changed paths: M Source/CMakeLists.txt M Source/WTF/wtf/PlatformUse.h M Source/WebCore/PlatformWPE.cmake M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/platform/DragImage.h M Source/WebCore/platform/ImageDecoders.cmake M Source/WebCore/platform/SharedBuffer.cpp M Source/WebCore/platform/SharedBuffer.h A Source/WebCore/platform/Skia.cmake M Source/WebCore/platform/SourcesGStreamer.txt A Source/WebCore/platform/SourcesSkia.txt M Source/WebCore/platform/TextureMapper.cmake M Source/WebCore/platform/graphics/FloatRect.h M Source/WebCore/platform/graphics/Font.cpp M Source/WebCore/platform/graphics/FontCache.cpp M Source/WebCore/platform/graphics/FontCache.h M Source/WebCore/platform/graphics/FontCustomPlatformData.h M Source/WebCore/platform/graphics/FontPlatformData.cpp M Source/WebCore/platform/graphics/FontPlatformData.h M Source/WebCore/platform/graphics/Gradient.h M Source/WebCore/platform/graphics/GraphicsContextGLImageExtractor.h M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/ImageBufferPlatformBackend.h M Source/WebCore/platform/graphics/Pattern.h M Source/WebCore/platform/graphics/PlatformDisplay.h M Source/WebCore/platform/graphics/PlatformGraphicsContext.h M Source/WebCore/platform/graphics/PlatformImage.h M Source/WebCore/platform/graphics/PlatformPath.h M Source/WebCore/platform/graphics/PlatformPathImpl.h M Source/WebCore/platform/graphics/ShareableBitmap.cpp M Source/WebCore/platform/graphics/ShareableBitmap.h M Source/WebCore/platform/graphics/WidthCache.h M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp A Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp M Source/WebCore/platform/graphics/harfbuzz/HbUniquePtr.h M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.h M Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp M Source/WebCore/platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.cpp A Source/WebCore/platform/graphics/skia/ComplexTextControllerSkia.cpp A Source/WebCore/platform/graphics/skia/DrawGlyphsRecorderSkia.cpp A Source/WebCore/platform/graphics/skia/FloatRectSkia.cpp A Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp A Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp A Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp A Source/WebCore/platform/graphics/skia/FontDescriptionSkia.cpp A Source/WebCore/platform/graphics/skia/FontPlatformDataSkia.cpp A Source/WebCore/platform/graphics/skia/FontSkia.cpp A Source/WebCore/platform/graphics/skia/FontVariationsSkia.cpp A Source/WebCore/platform/graphics/skia/FontVariationsSkia.h A Source/WebCore/platform/graphics/skia/GlyphPageSkia.cpp A Source/WebCore/platform/graphics/skia/GradientSkia.cpp A Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp A Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp A Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h A Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp A Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.h A Source/WebCore/platform/graphics/skia/ImageBufferSkiaBackend.cpp A Source/WebCore/platform/graphics/skia/ImageBufferSkiaBackend.h A Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp A Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h A Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp A Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.h A Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp A Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.h A Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp A Source/WebCore/platform/graphics/skia/PathSkia.cpp A Source/WebCore/platform/graphics/skia/PathSkia.h A Source/WebCore/platform/graphics/skia/PatternSkia.cpp A Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp A Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp A Source/WebCore/platform/graphics/skia/SkiaHarfBuzzFont.cpp A Source/WebCore/platform/graphics/skia/SkiaHarfBuzzFont.h A Source/WebCore/platform/graphics/skia/SkiaHarfBuzzFontCache.cpp A Source/WebCore/platform/graphics/skia/SkiaHarfBuzzFontCache.h A Source
[webkit-changes] [WebKit/WebKit] 0e6f02: [Skia] Building with USE_SKIA=ON still uses Cairo ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0e6f0245ab8d06d0bfa36cb19d3054d86b8ed798 https://github.com/WebKit/WebKit/commit/0e6f0245ab8d06d0bfa36cb19d3054d86b8ed798 Author: Carlos Garcia Campos Date: 2024-02-13 (Tue, 13 Feb 2024) Changed paths: M Source/ThirdParty/skia/CMakeLists.txt M Tools/ImageDiff/Cairo.cmake M Tools/ImageDiff/PlatformImage.h M Tools/ImageDiff/PlatformWPE.cmake A Tools/ImageDiff/Skia.cmake A Tools/ImageDiff/skia/PlatformImageSkia.cpp Log Message: --- [Skia] Building with USE_SKIA=ON still uses Cairo for ImageDiff https://bugs.webkit.org/show_bug.cgi?id=269190 Reviewed by Alejandro G. Castro and Nikolas Zimmermann. Add ImageDiff implementation for Skia. * Source/ThirdParty/skia/CMakeLists.txt: * Tools/ImageDiff/Cairo.cmake: * Tools/ImageDiff/PlatformImage.h: * Tools/ImageDiff/PlatformWPE.cmake: * Tools/ImageDiff/Skia.cmake: Added. * Tools/ImageDiff/skia/PlatformImageSkia.cpp: Added. (ImageDiff::createFromStream): (ImageDiff::PlatformImage::createFromFile): (ImageDiff::PlatformImage::createFromStdin): (ImageDiff::PlatformImage::createFromDiffData): (ImageDiff::PlatformImage::PlatformImage): (ImageDiff::PlatformImage::~PlatformImage): (ImageDiff::PlatformImage::width const): (ImageDiff::PlatformImage::height const): (ImageDiff::PlatformImage::rowBytes const): (ImageDiff::PlatformImage::hasAlpha const): (ImageDiff::PlatformImage::pixels const): (ImageDiff::PlatformImage::writeAsPNGToStdout): Canonical link: https://commits.webkit.org/274544@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 046aeb: [WPE][Skia] Implement HeadlessViewBackend
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 046aebec01c45777cebdc558cd92e1865cc70abb https://github.com/WebKit/WebKit/commit/046aebec01c45777cebdc558cd92e1865cc70abb Author: Carlos Garcia Campos Date: 2024-02-14 (Wed, 14 Feb 2024) Changed paths: M Tools/wpe/backends/HeadlessViewBackend.h M Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp Log Message: --- [WPE][Skia] Implement HeadlessViewBackend https://bugs.webkit.org/show_bug.cgi?id=269350 Reviewed by Nikolas Zimmermann. This allows to run ref tests with skia when using the old libwpe API. * Tools/wpe/backends/HeadlessViewBackend.h: * Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp: (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend): (WPEToolingBackends::HeadlessViewBackend::snapshot): (WPEToolingBackends::HeadlessViewBackend::updateSnapshot): Canonical link: https://commits.webkit.org/274613@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b96094: [WPE] WPE Platform: Implement monitors API in DRM ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b96094f5ce941b472f4490d05cef37214fc6f2e4 https://github.com/WebKit/WebKit/commit/b96094f5ce941b472f4490d05cef37214fc6f2e4 Author: Carlos Garcia Campos Date: 2024-02-14 (Wed, 14 Feb 2024) Changed paths: M Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp M Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt M Source/WebKit/WPEPlatform/wpe/drm/WPEDRM.cpp M Source/WebKit/WPEPlatform/wpe/drm/WPEDRM.h M Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp M Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRMPrivate.h A Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRM.cpp A Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRM.h A Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRMPrivate.h M Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp M Source/WebKit/WPEPlatform/wpe/drm/wpe-drm.h Log Message: --- [WPE] WPE Platform: Implement monitors API in DRM platform https://bugs.webkit.org/show_bug.cgi?id=269062 Reviewed by Adrian Perez de Castro. Add WPEMonitor implementation for DRM. * Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp: (WebKit::DisplayVBlankMonitorDRM::create): * Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt: * Source/WebKit/WPEPlatform/wpe/drm/WPEDRM.cpp: (WPE::DRM::Crtc::Crtc): (WPE::DRM::Connector::Connector): * Source/WebKit/WPEPlatform/wpe/drm/WPEDRM.h: (WPE::DRM::Crtc::x const): (WPE::DRM::Crtc::y const): (WPE::DRM::Crtc::width const): (WPE::DRM::Crtc::height const): (WPE::DRM::Connector::widthMM const): (WPE::DRM::Connector::heightMM const): * Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp: (wpeDisplayDRMConnect): (wpeDisplayDRMGetNMonitors): (wpeDisplayDRMGetMonitor): (wpe_display_drm_class_init): (wpeDisplayDRMGetCrtc): Deleted. * Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRMPrivate.h: * Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRM.cpp: Added. (wpeMonitorDRMInvalidate): (wpeMonitorDRMDispose): (wpe_monitor_drm_class_init): (wpeMonitorDRMCreate): (wpeMonitorDRMGetMode): (wpeMonitorDRMGetCrtc): (wpe_monitor_drm_get_crtc_index): * Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRM.h: Copied from Source/WebKit/WPEPlatform/wpe/drm/wpe-drm.h. * Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRMPrivate.h: Copied from Source/WebKit/WPEPlatform/wpe/drm/wpe-drm.h. * Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp: (wpeViewDRMConstructed): (wpeViewDRMCommitAtomic): (wpeViewDRMCommitLegacy): (wpeViewDRMGetMonitor): (wpeViewDRMScheduleCursorUpdate): (wpe_view_drm_class_init): * Source/WebKit/WPEPlatform/wpe/drm/wpe-drm.h: Canonical link: https://commits.webkit.org/274619@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b1ef42: Unreviewed. [Skia] Fix the build after 274689@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b1ef42f9451e4b8391bfcaa14082a72308eb390e https://github.com/WebKit/WebKit/commit/b1ef42f9451e4b8391bfcaa14082a72308eb390e Author: Carlos Garcia Campos Date: 2024-02-15 (Thu, 15 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp Log Message: --- Unreviewed. [Skia] Fix the build after 274689@main * Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp: (WebCore::FontCustomPlatformData::create): (WebCore::FontCustomPlatformData::createMemorySafe): (WebCore::createFontCustomPlatformData): Deleted. Canonical link: https://commits.webkit.org/274709@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1512e4: [WPE] Web Platform: implement WebPageProxy::callAf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1512e48affb3304f86b9b4cbbcb2b934e594faf5 https://github.com/WebKit/WebKit/commit/1512e48affb3304f86b9b4cbbcb2b934e594faf5 Author: Carlos Garcia Campos Date: 2024-02-15 (Thu, 15 Feb 2024) Changed paths: M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp Log Message: --- [WPE] Web Platform: implement WebPageProxy::callAfterNextPresentationUpdate https://bugs.webkit.org/show_bug.cgi?id=269353 Reviewed by Adrian Perez de Castro. With the old API we just use a 0 seconds timer, but with the new API we can use the buffer-renderer signal of WPEView to actually call the callback after the next buffer is rendered. This will hopefully reduce the flakiness of ref tests. * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp: (WebKit::PageClientImpl::callAfterNextPresentationUpdate): * Source/WebKit/UIProcess/API/wpe/PageClientImpl.h: * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::View::callAfterNextPresentationUpdate): * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp: (WebKit::WebPageProxy::callAfterNextPresentationUpdate): Canonical link: https://commits.webkit.org/274710@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 56d099: [WPE][Skia] Implement support for canvas toDataURL
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 56d0998a1ebb77d9b7e3f6948de2336de044d6a0 https://github.com/WebKit/WebKit/commit/56d0998a1ebb77d9b7e3f6948de2336de044d6a0 Author: Carlos Garcia Campos Date: 2024-02-15 (Thu, 15 Feb 2024) Changed paths: M Source/ThirdParty/skia/CMakeLists.txt M Source/WebCore/platform/ImageDecoders.cmake M Source/WebCore/platform/MIMETypeRegistry.cpp M Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp M Source/cmake/FindWebP.cmake Log Message: --- [WPE][Skia] Implement support for canvas toDataURL https://bugs.webkit.org/show_bug.cgi?id=269362 Reviewed by Adrian Perez de Castro. Implement encodeData(). * Source/ThirdParty/skia/CMakeLists.txt: Add JPEG and WebP encoder files. * Source/WebCore/platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::createMIMETypeRegistryThreadGlobalData): Mark JPEG, PNG and WebP as formats support for encoding when building with Skia. * Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp: (WebCore::encodeAcceleratedImage): (WebCore::encodeUnacceleratedImage): (WebCore::encodeData): * Source/cmake/FindWebP.cmake: Also look for mux library if requested as component Canonical link: https://commits.webkit.org/274723@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ac8eb: Unreviewed. [Skia] Fix the build after 274746@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ac8eb88cca92d828de2c874f27aa80fd45ebf23 https://github.com/WebKit/WebKit/commit/9ac8eb88cca92d828de2c874f27aa80fd45ebf23 Author: Carlos Garcia Campos Date: 2024-02-15 (Thu, 15 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp Log Message: --- Unreviewed. [Skia] Fix the build after 274746@main * Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp: (WebCore::GraphicsContextGLImageExtractor::extractImage): Canonical link: https://commits.webkit.org/274804@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2df7b1: Unreviewed. [Skia] Fix the build with clang after ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2df7b15c5d07c89a21df445b7ea48d987762f68a https://github.com/WebKit/WebKit/commit/2df7b15c5d07c89a21df445b7ea48d987762f68a Author: Carlos Garcia Campos Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp Log Message: --- Unreviewed. [Skia] Fix the build with clang after 274723@main * Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp: Canonical link: https://commits.webkit.org/274807@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a97c62: Unreviewed, reverting 274804@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a97c6257b7d09416f8e608eda6cf5ec436d32849 https://github.com/WebKit/WebKit/commit/a97c6257b7d09416f8e608eda6cf5ec436d32849 Author: Carlos Garcia Campos Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp Log Message: --- Unreviewed, reverting 274804@main This was a build fix for 274746@main, that has been reverted in 274896@main. "Unreviewed. [Skia] Fix the build after 274746@main" https://commits.webkit.org/274804@main Canonical link: https://commits.webkit.org/274965@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a9886a: [Skia] Implement canvas addPath()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9886a567ff733125ff94eca0b6055514da6ef6c https://github.com/WebKit/WebKit/commit/a9886a567ff733125ff94eca0b6055514da6ef6c Author: Carlos Garcia Campos Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/PathSkia.cpp Log Message: --- [Skia] Implement canvas addPath() https://bugs.webkit.org/show_bug.cgi?id=269573 Reviewed by Nikolas Zimmermann. * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::addPath): Canonical link: https://commits.webkit.org/274966@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 119e9b: [Skia] Initialize stroke miter limit to the skia d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 119e9b2efd07ac40a081ebd76273eabfd1bba1b1 https://github.com/WebKit/WebKit/commit/119e9b2efd07ac40a081ebd76273eabfd1bba1b1 Author: Carlos Garcia Campos Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h Log Message: --- [Skia] Initialize stroke miter limit to the skia default value https://bugs.webkit.org/show_bug.cgi?id=269663 Reviewed by Nikolas Zimmermann. Initialize stroke miter limit to 4, which is the Skia default value. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h: Canonical link: https://commits.webkit.org/274967@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7874af: [Skia] Remove m_elementsStream from PathSkia
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7874af8ac73eddcceeea51497d9df2e2b7297d50 https://github.com/WebKit/WebKit/commit/7874af8ac73eddcceeea51497d9df2e2b7297d50 Author: Carlos Garcia Campos Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/PathSkia.cpp M Source/WebCore/platform/graphics/skia/PathSkia.h Log Message: --- [Skia] Remove m_elementsStream from PathSkia https://bugs.webkit.org/show_bug.cgi?id=269698 Reviewed by Adrian Perez de Castro. We copied it from cairo, but it's not needed with Skia. * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::PathSkia): (WebCore::PathSkia::copy const): (WebCore::PathSkia::add): (WebCore::PathSkia::addPath): (WebCore::PathSkia::applyElements const): (WebCore::PathSkia::fastBoundingRect const): (WebCore::PathSkia::boundingRect const): * Source/WebCore/platform/graphics/skia/PathSkia.h: Canonical link: https://commits.webkit.org/274969@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a94df: [Skia] Implement stroke gradients
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a94dff5de5a1852323be73786aee08e71f0a8f7 https://github.com/WebKit/WebKit/commit/8a94dff5de5a1852323be73786aee08e71f0a8f7 Author: Carlos Garcia Campos Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Implement stroke gradients https://bugs.webkit.org/show_bug.cgi?id=269664 Reviewed by Adrian Perez de Castro. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::createStrokePaint const): Canonical link: https://commits.webkit.org/274970@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b6e052: [Skia] Implement stroke pattern
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6e052de1e99f167cc6ed8d30565a1f8ebef5050 https://github.com/WebKit/WebKit/commit/b6e052de1e99f167cc6ed8d30565a1f8ebef5050 Author: Carlos Garcia Campos Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Implement stroke pattern https://bugs.webkit.org/show_bug.cgi?id=269703 Reviewed by Adrian Perez de Castro. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::createStrokePaint const): Canonical link: https://commits.webkit.org/274972@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f7d847: [Skia] Implement PathSkia::strokeContains
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f7d847c5baf3deec5e1fb251cdb93a960cad58f7 https://github.com/WebKit/WebKit/commit/f7d847c5baf3deec5e1fb251cdb93a960cad58f7 Author: Carlos Garcia Campos Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/ThirdParty/skia/CMakeLists.txt M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h M Source/WebCore/platform/graphics/skia/PathSkia.cpp Log Message: --- [Skia] Implement PathSkia::strokeContains https://bugs.webkit.org/show_bug.cgi?id=269701 Reviewed by Adrian Perez de Castro. This patch adds GraphicsContextSkia::createStrokeStylePaint() that creates the SkPaint for stroke with only the stroke style state, because it's needed by PathSkia::strokeContains(). It also simplifies the dash line handling by creating the SkDashPathEffect when the line dash is set instead of when it's applied. * Source/ThirdParty/skia/CMakeLists.txt: * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::createStrokeStylePaint const): (WebCore::GraphicsContextSkia::createStrokePaint const): (WebCore::GraphicsContextSkia::setLineDash): * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h: * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::strokeContains const): Canonical link: https://commits.webkit.org/274973@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cef2f7: [Skia] Implement canvas ellipse
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cef2f7b37e4a6819e0a83b24a053d0c4c6b4e855 https://github.com/WebKit/WebKit/commit/cef2f7b37e4a6819e0a83b24a053d0c4c6b4e855 Author: Carlos Garcia Campos Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/PathSkia.cpp M Source/WebCore/platform/graphics/skia/PathSkia.h Log Message: --- [Skia] Implement canvas ellipse https://bugs.webkit.org/show_bug.cgi?id=269569 Reviewed by Nikolas Zimmermann. Move the implementation from PathSkia::add(PathArc) to a new helper method that can be used for PathSkia::add(PathEllipse). Also remove the angle normalization, because angles are already normalized by CanvasPath. * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::addEllipse): (WebCore::PathSkia::add): * Source/WebCore/platform/graphics/skia/PathSkia.h: Canonical link: https://commits.webkit.org/274974@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 816ab2: [Skia] Implement PathSkia::strokeBoundingRect
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 816ab2fdfc9f38ae3693087525ec52da802f07d3 https://github.com/WebKit/WebKit/commit/816ab2fdfc9f38ae3693087525ec52da802f07d3 Author: Carlos Garcia Campos Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/PathSkia.cpp Log Message: --- [Skia] Implement PathSkia::strokeBoundingRect https://bugs.webkit.org/show_bug.cgi?id=269705 Reviewed by Adrian Perez de Castro. * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::strokeBoundingRect const): Canonical link: https://commits.webkit.org/275030@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 68c992: [Skia] Fix arcs when direction is counterclockwise...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 68c99280815be0b90f3541350037619b33b0dd06 https://github.com/WebKit/WebKit/commit/68c99280815be0b90f3541350037619b33b0dd06 Author: Carlos Garcia Campos Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/PathSkia.cpp M Source/WebCore/platform/graphics/skia/PathSkia.h Log Message: --- [Skia] Fix arcs when direction is counterclockwise or more than one arc is added to the path https://bugs.webkit.org/show_bug.cgi?id=269780 Reviewed by Adrian Perez de Castro. We can't use SkPath::addOval() because it closes the path, so new arcs added are not correctly handled. We also need to make the sweep angle negative when direction is counterclockwise. * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::addEllipse): (WebCore::PathSkia::add): * Source/WebCore/platform/graphics/skia/PathSkia.h: Canonical link: https://commits.webkit.org/275034@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d9a65: [Skia] Use Skia API when adding rounded rect to pa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d9a6549eb1269c0d823ac95fe940f17f49a4b53 https://github.com/WebKit/WebKit/commit/7d9a6549eb1269c0d823ac95fe940f17f49a4b53 Author: Carlos Garcia Campos Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/platform/SourcesSkia.txt M Source/WebCore/platform/graphics/FloatRoundedRect.h A Source/WebCore/platform/graphics/skia/FloatRoundedRectSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M Source/WebCore/platform/graphics/skia/PathSkia.cpp Log Message: --- [Skia] Use Skia API when adding rounded rect to path and strategy is PreferNative https://bugs.webkit.org/show_bug.cgi?id=269845 Reviewed by Adrian Perez de Castro. Also add conversion operators between FloatRounrdedRect and SkRREct to remove duplicated code. * Source/WebCore/platform/SourcesSkia.txt: * Source/WebCore/platform/graphics/FloatRoundedRect.h: * Source/WebCore/platform/graphics/skia/FloatRoundedRectSkia.cpp: Added. (WebCore::FloatRoundedRect::FloatRoundedRect): (WebCore::FloatRoundedRect::operator SkRRect const): * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::fillRoundedRectImpl): (WebCore::GraphicsContextSkia::fillRectWithRoundedHole): * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::add): Canonical link: https://commits.webkit.org/275106@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ff9e1: [Skia] Implement PlatformImageNativeImageBackend::...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ff9e131b2d53d4803aaf14ea466f5fbf7179bf2 https://github.com/WebKit/WebKit/commit/7ff9e131b2d53d4803aaf14ea466f5fbf7179bf2 Author: Carlos Garcia Campos Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp Log Message: --- [Skia] Implement PlatformImageNativeImageBackend::hasAlpha() https://bugs.webkit.org/show_bug.cgi?id=269896 Reviewed by Alejandro G. Castro and Nikolas Zimmermann. * Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp: (WebCore::PlatformImageNativeImageBackend::hasAlpha const): Canonical link: https://commits.webkit.org/275164@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e8eb0b: [Skia] Implement GraphicsContextGL::createNativeIm...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8eb0b9c77e95bb57b20cdd0349de3622a4d4df6 https://github.com/WebKit/WebKit/commit/e8eb0b9c77e95bb57b20cdd0349de3622a4d4df6 Author: Carlos Garcia Campos Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp Log Message: --- [Skia] Implement GraphicsContextGL::createNativeImageFromPixelBuffer https://bugs.webkit.org/show_bug.cgi?id=269849 Reviewed by Alejandro G. Castro and Nikolas Zimmermann. * Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp: (WebCore::GraphicsContextGL::createNativeImageFromPixelBuffer): Canonical link: https://commits.webkit.org/275165@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e9496d: [WPE] WPE Platform: add API to maximize/unmaximize...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e9496d0854d091f2a23e372089fa7b98c8c514bd https://github.com/WebKit/WebKit/commit/e9496d0854d091f2a23e372089fa7b98c8c514bd Author: Carlos Garcia Campos Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/WPEView.cpp M Source/WebKit/WPEPlatform/wpe/WPEView.h M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp M Tools/MiniBrowser/wpe/main.cpp Log Message: --- [WPE] WPE Platform: add API to maximize/unmaximize a WPEView https://bugs.webkit.org/show_bug.cgi?id=269842 Reviewed by Adrian Perez de Castro. * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpe_view_maximize): (wpe_view_unmaximize): * Source/WebKit/WPEPlatform/wpe/WPEView.h: * Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp: (wpeViewWaylandSaveSize): (wpeViewWaylandSetFullscreen): (wpeViewWaylandSetMaximized): (wpe_view_wayland_class_init): * Tools/MiniBrowser/wpe/main.cpp: Canonical link: https://commits.webkit.org/275175@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5afce8: [Skia][GStreamer] Implement ImageGStreamer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5afce8e3f3a69057b9eb565af0c341d72d23ce62 https://github.com/WebKit/WebKit/commit/5afce8e3f3a69057b9eb565af0c341d72d23ce62 Author: Carlos Garcia Campos Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp Log Message: --- [Skia][GStreamer] Implement ImageGStreamer https://bugs.webkit.org/show_bug.cgi?id=269907 Reviewed by Philippe Normand. * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp: (WebCore::ImageGStreamer::ImageGStreamer): (WebCore::ImageGStreamer::~ImageGStreamer): Canonical link: https://commits.webkit.org/275224@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fc13b1: [Skia] Add Color operators to easily convert from/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fc13b190064d364d3046e56370ce5202826655fc https://github.com/WebKit/WebKit/commit/fc13b190064d364d3046e56370ce5202826655fc Author: Carlos Garcia Campos Date: 2024-02-25 (Sun, 25 Feb 2024) Changed paths: M Source/WebCore/platform/SourcesSkia.txt M Source/WebCore/platform/graphics/Color.h A Source/WebCore/platform/graphics/skia/ColorSkia.cpp M Source/WebCore/platform/graphics/skia/GradientSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Add Color operators to easily convert from/to SkColor and SkColor4f https://bugs.webkit.org/show_bug.cgi?id=269978 Reviewed by Nikolas Zimmermann. We avoid duplicated code and simplify the use of colors. * Source/WebCore/platform/SourcesSkia.txt: * Source/WebCore/platform/graphics/Color.h: * Source/WebCore/platform/graphics/skia/ColorSkia.cpp: Added. (WebCore::Color::Color): (WebCore::Color::operator SkColor const): (WebCore::Color::operator SkColor4f const): * Source/WebCore/platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::shader): * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::createDropShadowFilterIfNeeded const): (WebCore::GraphicsContextSkia::createFillPaint const): (WebCore::GraphicsContextSkia::createStrokePaint const): Canonical link: https://commits.webkit.org/275308@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b5742: [Skia] Implement NativeImage::singlePixelSolidColor()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b5742cba30a6551c279ae3a16083852f18b6353 https://github.com/WebKit/WebKit/commit/2b5742cba30a6551c279ae3a16083852f18b6353 Author: Carlos Garcia Campos Date: 2024-02-25 (Sun, 25 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp Log Message: --- [Skia] Implement NativeImage::singlePixelSolidColor() https://bugs.webkit.org/show_bug.cgi?id=269979 Reviewed by Nikolas Zimmermann. * Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImage::singlePixelSolidColor const): Canonical link: https://commits.webkit.org/275309@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 85958c: [TextureMapper] Add GLContextWrapper to handle the...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85958c82a712c120494f04dc54d3f7b681a052a9 https://github.com/WebKit/WebKit/commit/85958c82a712c120494f04dc54d3f7b681a052a9 Author: Carlos Garcia Campos Date: 2024-02-26 (Mon, 26 Feb 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/PlatformPlayStation.cmake M Source/WebCore/PlatformWin.cmake M Source/WebCore/SourcesGTK.txt M Source/WebCore/SourcesWPE.txt M Source/WebCore/platform/graphics/egl/GLContext.cpp M Source/WebCore/platform/graphics/egl/GLContext.h A Source/WebCore/platform/graphics/egl/GLContextWrapper.cpp A Source/WebCore/platform/graphics/egl/GLContextWrapper.h M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h Log Message: --- [TextureMapper] Add GLContextWrapper to handle the current GL context https://bugs.webkit.org/show_bug.cgi?id=270078 Reviewed by Miguel Gomez. We currently have GLContext handling the current context, but it doesn't always work. For example, if there's WebGL content, after ANGLE context is made current. This is not problematic with Cairo because only ANGLE is making it context current in the main thread, but with Skia there's another GL context that is made current in the main thread when using the GPU renderer. GLContextWrapper is a new class to handle the current GL context, implemented by GLContext and GraphicsContextGLTextureMapperANGLE. * Source/WebCore/Headers.cmake: * Source/WebCore/PlatformPlayStation.cmake: * Source/WebCore/PlatformWin.cmake: * Source/WebCore/SourcesGTK.txt: * Source/WebCore/SourcesWPE.txt: * Source/WebCore/platform/graphics/egl/GLContext.cpp: (WebCore::GLContext::~GLContext): (WebCore::GLContext::makeCurrentImpl): (WebCore::GLContext::unmakeCurrentImpl): (WebCore::GLContext::makeContextCurrent): (WebCore::GLContext::unmakeContextCurrent): (WebCore::GLContext::current): (WebCore::GLContext::ScopedGLContext::ScopedGLContext): (WebCore::GLContext::ScopedGLContext::~ScopedGLContext): (WebCore::GLContext::ScopedGLContextCurrent::ScopedGLContextCurrent): (WebCore::GLContext::ScopedGLContextCurrent::~ScopedGLContextCurrent): (): Deleted. * Source/WebCore/platform/graphics/egl/GLContext.h: (WebCore::GLContext::display const): Deleted. (WebCore::GLContext::config const): Deleted. * Source/WebCore/platform/graphics/egl/GLContextWrapper.cpp: Added. (WebCore::GLContextWrapper::~GLContextWrapper): (WebCore::GLContextWrapper::currentContext): (WebCore::GLContextWrapper::makeCurrent): (WebCore::GLContextWrapper::unmakeCurrent): * Source/WebCore/platform/graphics/egl/GLContextWrapper.h: Added. * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: (WebCore::GraphicsContextGLANGLE::makeContextCurrent): (WebCore::GraphicsContextGLTextureMapperANGLE::makeCurrentImpl): (WebCore::GraphicsContextGLTextureMapperANGLE::unmakeCurrentImpl): * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h: Canonical link: https://commits.webkit.org/275316@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d009eb: [TextureMapper] Add GLContextWrapper to handle the...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d009eb90543f0e25ee70cfb6eef3db2b0ec64d62 https://github.com/WebKit/WebKit/commit/d009eb90543f0e25ee70cfb6eef3db2b0ec64d62 Author: Carlos Garcia Campos Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/PlatformPlayStation.cmake M Source/WebCore/PlatformWin.cmake M Source/WebCore/SourcesGTK.txt M Source/WebCore/SourcesWPE.txt M Source/WebCore/platform/graphics/angle/PlatformDisplayANGLE.cpp M Source/WebCore/platform/graphics/egl/GLContext.cpp M Source/WebCore/platform/graphics/egl/GLContext.h A Source/WebCore/platform/graphics/egl/GLContextWrapper.cpp A Source/WebCore/platform/graphics/egl/GLContextWrapper.h M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h Log Message: --- [TextureMapper] Add GLContextWrapper to handle the current GL context https://bugs.webkit.org/show_bug.cgi?id=270078 Reviewed by Miguel Gomez. We currently have GLContext handling the current context, but it doesn't always work. For example, if there's WebGL content, after ANGLE context is made current. This is not problematic with Cairo because only ANGLE is making it context current in the main thread, but with Skia there's another GL context that is made current in the main thread when using the GPU renderer. GLContextWrapper is a new class to handle the current GL context, implemented by GLContext and GraphicsContextGLTextureMapperANGLE. * Source/WebCore/Headers.cmake: * Source/WebCore/PlatformPlayStation.cmake: * Source/WebCore/PlatformWin.cmake: * Source/WebCore/SourcesGTK.txt: * Source/WebCore/SourcesWPE.txt: * Source/WebCore/platform/graphics/egl/GLContext.cpp: (WebCore::GLContext::~GLContext): (WebCore::GLContext::makeCurrentImpl): (WebCore::GLContext::unmakeCurrentImpl): (WebCore::GLContext::makeContextCurrent): (WebCore::GLContext::unmakeContextCurrent): (WebCore::GLContext::current): (WebCore::GLContext::ScopedGLContext::ScopedGLContext): (WebCore::GLContext::ScopedGLContext::~ScopedGLContext): (WebCore::GLContext::ScopedGLContextCurrent::ScopedGLContextCurrent): (WebCore::GLContext::ScopedGLContextCurrent::~ScopedGLContextCurrent): (): Deleted. * Source/WebCore/platform/graphics/egl/GLContext.h: (WebCore::GLContext::display const): Deleted. (WebCore::GLContext::config const): Deleted. * Source/WebCore/platform/graphics/egl/GLContextWrapper.cpp: Added. (WebCore::GLContextWrapper::~GLContextWrapper): (WebCore::GLContextWrapper::currentContext): (WebCore::GLContextWrapper::makeCurrent): (WebCore::GLContextWrapper::unmakeCurrent): * Source/WebCore/platform/graphics/egl/GLContextWrapper.h: Added. * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: (WebCore::GraphicsContextGLANGLE::makeContextCurrent): (WebCore::GraphicsContextGLTextureMapperANGLE::makeCurrentImpl): (WebCore::GraphicsContextGLTextureMapperANGLE::unmakeCurrentImpl): * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h: Canonical link: https://commits.webkit.org/275377@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a3492: [Skia] Stop using ScopedGLContextCurrent to make t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a34924425e4d87f83bd33db586ee4f7a9a56a95 https://github.com/WebKit/WebKit/commit/1a34924425e4d87f83bd33db586ee4f7a9a56a95 Author: Carlos Garcia Campos Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp M Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp Log Message: --- [Skia] Stop using ScopedGLContextCurrent to make the Skia GL context current https://bugs.webkit.org/show_bug.cgi?id=270082 Reviewed by Miguel Gomez. In most of the cases we are setting anf unsetting the same context all the time. If there's WebGL content, ANGLE graphics context will make the ANGLE context current on every operation that requires it. * Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp: (WebCore::GraphicsContextGLImageExtractor::extractImage): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp: (WebCore::ImageBufferSkiaAcceleratedBackend::create): (WebCore::ImageBufferSkiaAcceleratedBackend::getPixelBuffer): (WebCore::ImageBufferSkiaAcceleratedBackend::putPixelBuffer): * Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp: (WebCore::encodeAcceleratedImage): * Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImage::singlePixelSolidColor const): * Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp: (WebCore::PlatformDisplay::skiaGLContext): * Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp: (WebCore::SkiaAcceleratedBufferPool::~SkiaAcceleratedBufferPool): (WebCore::SkiaAcceleratedBufferPool::releaseUnusedBuffersTimerFired): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp: (WebCore::CoordinatedGraphicsLayer::paintTile): Canonical link: https://commits.webkit.org/275379@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 832bcc: [Skia] Make sure the Skia GL context is current wh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 832bcc5229f97a3f10f2387c9b9da94723ce9834 https://github.com/WebKit/WebKit/commit/832bcc5229f97a3f10f2387c9b9da94723ce9834 Author: Carlos Garcia Campos Date: 2024-02-28 (Wed, 28 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h M Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/PathSkia.cpp M Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp Log Message: --- [Skia] Make sure the Skia GL context is current when calling SkCanvas draw operations for 2D canvas https://bugs.webkit.org/show_bug.cgi?id=269984 Reviewed by Nikolas Zimmermann. When rendering layer contents, we make the Skia GL context current before rendering the layer contents and it remains current, but in the case of 2D canvas, we can't make sure the context is current when the draw operations are called. This is causing rendering issues in some cases that only happen with the GL renderer. This patch adds RenderingMode and RenderingPurpose parameters to GraphicsContextSkia, and a helper function makeGLContextCurrentIfNeeded() that makes the Skia GL context current when the RenderingMode is Accelerated and RenderingPurpose is Canvas. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::GraphicsContextSkia): (WebCore::GraphicsContextSkia::makeGLContextCurrentIfNeeded): (WebCore::GraphicsContextSkia::drawRect): (WebCore::GraphicsContextSkia::drawNativeImageInternal): (WebCore::GraphicsContextSkia::drawLine): (WebCore::GraphicsContextSkia::drawEllipse): (WebCore::GraphicsContextSkia::fillPath): (WebCore::GraphicsContextSkia::strokePath): (WebCore::GraphicsContextSkia::fillRect): (WebCore::GraphicsContextSkia::beginTransparencyLayer): (WebCore::GraphicsContextSkia::endTransparencyLayer): (WebCore::GraphicsContextSkia::clearRect): (WebCore::GraphicsContextSkia::strokeRect): (WebCore::GraphicsContextSkia::fillRoundedRectImpl): (WebCore::GraphicsContextSkia::fillRectWithRoundedHole): (WebCore::GraphicsContextSkia::drawPattern): (WebCore::GraphicsContextSkia::renderingMode const): Deleted. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h: * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp: (WebCore::ImageBufferSkiaAcceleratedBackend::ImageBufferSkiaAcceleratedBackend): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp: (WebCore::ImageBufferSkiaSurfaceBackend::ImageBufferSkiaSurfaceBackend): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h: * Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp: (WebCore::ImageBufferSkiaUnacceleratedBackend::ImageBufferSkiaUnacceleratedBackend): * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::strokeContains const): (WebCore::PathSkia::strokeBoundingRect const): * Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp: (WebCore::ShareableBitmap::createGraphicsContext): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp: (WebCore::CoordinatedGraphicsLayer::paintTile): (WebCore::CoordinatedGraphicsLayer::paintImage): Canonical link: https://commits.webkit.org/275432@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1eceb0: [Skia] Implement VideoFrame::fromNativeImage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1eceb04bb62bd87bd1ea725094111e06727a8790 https://github.com/WebKit/WebKit/commit/1eceb04bb62bd87bd1ea725094111e06727a8790 Author: Carlos Garcia Campos Date: 2024-02-28 (Wed, 28 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp Log Message: --- [Skia] Implement VideoFrame::fromNativeImage https://bugs.webkit.org/show_bug.cgi?id=270217 Reviewed by Philippe Normand. * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp: (WebCore::VideoFrame::fromNativeImage): Canonical link: https://commits.webkit.org/275441@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 918ee4: [Skia] Handle image orientation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 918ee481e548f0291ff69b7ffb35c018638abb82 https://github.com/WebKit/WebKit/commit/918ee481e548f0291ff69b7ffb35c018638abb82 Author: Carlos Garcia Campos Date: 2024-02-29 (Thu, 29 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Handle image orientation https://bugs.webkit.org/show_bug.cgi?id=270222 Reviewed by Alejandro G. Castro. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::drawNativeImageInternal): Canonical link: https://commits.webkit.org/275482@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1fb32b: [Skia] Disable antialiasing when rendering text wi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fb32b543a9cdd5a9f3b2b0d7888c7b0cafac8f8 https://github.com/WebKit/WebKit/commit/1fb32b543a9cdd5a9f3b2b0d7888c7b0cafac8f8 Author: Carlos Garcia Campos Date: 2024-02-29 (Thu, 29 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp M Source/WebCore/platform/graphics/skia/FontSkia.cpp Log Message: --- [Skia] Disable antialiasing when rendering text with Ahem font https://bugs.webkit.org/show_bug.cgi?id=270290 Reviewed by Alejandro G. Castro. Ahem font is used by the test and they require the antialising to be disabled. * Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp: (WebCore::FontCascade::drawGlyphs): * Source/WebCore/platform/graphics/skia/FontSkia.cpp: (WebCore::Font::platformInit): Canonical link: https://commits.webkit.org/275491@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a7b2d: [GTK] Crash in WebPageProxy::getLoadDecisionForIcon
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a7b2d62c79487e7c4040fadf997e9238e6d9047 https://github.com/WebKit/WebKit/commit/6a7b2d62c79487e7c4040fadf997e9238e6d9047 Author: Carlos Garcia Campos Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- [GTK] Crash in WebPageProxy::getLoadDecisionForIcon https://bugs.webkit.org/show_bug.cgi?id=269699 Reviewed by Michael Catanzaro. This probably regressed in 274563@main, that changed the way a SharedBuffer is serialized for IPC and now segments are sent, instead of the contiguous. So, in getLoadDecisionForIcon() we need to handle the case of data being non contiguous, by using SharedBufferReference::unsafeBuffer() * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getLoadDecisionForIcon): Canonical link: https://commits.webkit.org/275540@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7ee83: [Skia] Do not set synthetic bold offset
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7ee831c38599255e3ae78a2b28b71968615107f https://github.com/WebKit/WebKit/commit/c7ee831c38599255e3ae78a2b28b71968615107f Author: Carlos Garcia Campos Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontSkia.cpp Log Message: --- [Skia] Do not set synthetic bold offset https://bugs.webkit.org/show_bug.cgi?id=270291 Reviewed by Don Olmstead. It's handled internally by Skia. * Source/WebCore/platform/graphics/skia/FontSkia.cpp: (WebCore::Font::platformPathForGlyph const): (WebCore::Font::platformInit): Canonical link: https://commits.webkit.org/275541@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 472779: [Skia] Implement patterns with spacing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 47277981855c291da36dd487ce00c654fd2401e0 https://github.com/WebKit/WebKit/commit/47277981855c291da36dd487ce00c654fd2401e0 Author: Carlos Garcia Campos Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Implement patterns with spacing https://bugs.webkit.org/show_bug.cgi?id=270288 Reviewed by Alejandro G. Castro. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::drawPattern): Canonical link: https://commits.webkit.org/275543@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a99725: [WPE] WPE Platform: add API to get/set the primary...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a997251a7158008b2d0d9698567f77912e114948 https://github.com/WebKit/WebKit/commit/a997251a7158008b2d0d9698567f77912e114948 Author: Carlos Garcia Campos Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/UIProcess/wpe/ScreenManagerWPE.cpp M Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp M Source/WebKit/WPEPlatform/wpe/WPEDisplay.h Log Message: --- [WPE] WPE Platform: add API to get/set the primary display https://bugs.webkit.org/show_bug.cgi?id=270336 Reviewed by Alejandro G. Castro. We are currently using the default display for the screen manager, which is wrong for apps not using the default display and explicitly creating one. In most of the cases there's only one display, and in most of the cases where there's more than one, the first one created is the primary one. So, we can add API to get the primary display that is set automatically for the first created display, but still allow to set any other display as primary. * Source/WebKit/UIProcess/wpe/ScreenManagerWPE.cpp: (WebKit::ScreenManager::ScreenManager): (WebKit::ScreenManager::updatePrimaryDisplayID): * Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp: (wpe_display_class_init): (wpe_display_get_primary): (wpe_display_set_primary): * Source/WebKit/WPEPlatform/wpe/WPEDisplay.h: Canonical link: https://commits.webkit.org/275544@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6b96e2: [WPE] WPE Platform: Opaque region support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6b96e27c62baf1a2d8040ec73bb71c4c4e847030 https://github.com/WebKit/WebKit/commit/6b96e27c62baf1a2d8040ec73bb71c4c4e847030 Author: Carlos Garcia Campos Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp M Source/WebKit/WPEPlatform/CMakeLists.txt A Source/WebKit/WPEPlatform/wpe/WPERectangle.cpp A Source/WebKit/WPEPlatform/wpe/WPERectangle.h M Source/WebKit/WPEPlatform/wpe/WPEView.cpp M Source/WebKit/WPEPlatform/wpe/WPEView.h M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp M Source/WebKit/WPEPlatform/wpe/wpe-platform.h Log Message: --- [WPE] WPE Platform: Opaque region support https://bugs.webkit.org/show_bug.cgi?id=267705 Reviewed by Alejandro G. Castro. Add API to set the opaque region on a WPEView and use it from WebKit to set the web view region as opaque when the background color is opaque. * Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp: (webkit_web_view_set_background_color): * Source/WebKit/WPEPlatform/CMakeLists.txt: * Source/WebKit/WPEPlatform/wpe/WPERectangle.cpp: Copied from Source/WebKit/WPEPlatform/wpe/wpe-platform.h. (wpe_rectangle_copy): (wpe_rectangle_free): * Source/WebKit/WPEPlatform/wpe/WPERectangle.h: Copied from Source/WebKit/WPEPlatform/wpe/wpe-platform.h. * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpe_view_set_opaque_rectangles): * Source/WebKit/WPEPlatform/wpe/WPEView.h: * Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp: (wpeViewWaylandConstructed): (wpeViewWaylandSetOpaqueRectangles): (wpe_view_wayland_class_init): * Source/WebKit/WPEPlatform/wpe/wpe-platform.h: Canonical link: https://commits.webkit.org/275684@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75df56: [GTK] Make it possible to build with Skia instead ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75df56fbd143a4ac7df5e554b01c22030ea0ab22 https://github.com/WebKit/WebKit/commit/75df56fbd143a4ac7df5e554b01c22030ea0ab22 Author: Carlos Garcia Campos Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebCore/PlatformGTK.cmake M Source/WebCore/platform/DragImage.h M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp M Source/WebCore/platform/graphics/IntRect.h M Source/WebCore/platform/graphics/cairo/IntRectCairo.cpp M Source/WebCore/platform/graphics/cairo/RefPtrCairo.cpp M Source/WebCore/platform/graphics/cairo/RefPtrCairo.h M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp M Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp M Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.h M Source/WebCore/platform/graphics/gtk/ImageAdapterGtk.cpp M Source/WebCore/platform/gtk/CursorGtk.cpp M Source/WebCore/platform/gtk/DragImageGtk.cpp M Source/WebCore/platform/gtk/RenderThemeGadget.cpp M Source/WebCore/platform/gtk/RenderThemeGadget.h M Source/WebCore/platform/gtk/RenderThemeScrollbar.cpp M Source/WebCore/platform/gtk/RenderThemeScrollbar.h M Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp M Source/WebCore/platform/gtk/ScrollbarThemeGtk.h M Source/WebKit/SourcesGTK.txt M Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp M Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h M Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/gtk/DragSourceGtk3.cpp M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp M Source/WebKit/UIProcess/BackingStore.h M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h M Source/WebKit/UIProcess/ViewGestureController.h M Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/gtk/ViewSnapshotStoreGtk3.cpp M Source/WebKit/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp M Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp M Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.h M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/WebProcess.messages.in M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp M Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.cpp M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake M Source/cmake/WebKitFeatures.cmake M Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h M Tools/WebKitTestRunner/PlatformGTK.cmake M Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp M Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp Log Message: --- [GTK] Make it possible to build with Skia instead of Cairo https://bugs.webkit.org/show_bug.cgi?id=270510 Reviewed by Don Olmstead. Add build option to enable Skia in the GTK port. This is just an initial patch, there are many features broken when building with Skia like printing, non-accelerated mode, favicons, snapshots, etc. We will fix them all in follow up patches. * Source/WTF/wtf/PlatformUse.h: * Source/WebCore/PlatformGTK.cmake: * Source/WebCore/SourcesGTK.txt: * Source/WebCore/platform/DragImage.h: * Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp: * Source/WebCore/platform/graphics/IntRect.h: * Source/WebCore/platform/graphics/cairo/RefPtrCairo.cpp: * Source/WebCore/platform/graphics/cairo/RefPtrCairo.h: * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp: * Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp: * Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.h: * Source/WebCore/platform/graphics/gtk/ImageAdapterGtk.cpp: (WebCore::ImageAdapter::gdkPixbuf): (WebCore::ImageAdapter::gdkTexture): * Source/WebCore/platform/gtk/CursorGtk.cpp: (WebCore::createCustomCursor): * Source/WebCore/platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): * Source/WebCore/platform/gtk/RenderThemeGadget.cpp: * Source/WebCore/platform/gtk/RenderThemeGadget.h: * Source/WebCore/platform/gtk/RenderThemeScrollbar.cpp: * Source/WebCore/platform/gtk/RenderThemeScrollbar.h: * Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp: * Source/WebCore/platform/gtk/ScrollbarThemeGtk.h: * Source/WebKit/SourcesGTK.txt: * Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp
[webkit-changes] [WebKit/WebKit] c2361c: [WPE] WPE Platform: make functions to get DRM devi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2361c31a74159368c4298faa9049cd0cc3a3453 https://github.com/WebKit/WebKit/commit/c2361c31a74159368c4298faa9049cd0cc3a3453 Author: Carlos Garcia Campos Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp M Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp M Source/WebKit/WPEPlatform/wpe/WPEBufferDMABuf.cpp M Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp M Source/WebKit/WPEPlatform/wpe/WPEDisplay.h M Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt A Source/WebKit/WPEPlatform/wpe/drm/RefPtrUdev.cpp A Source/WebKit/WPEPlatform/wpe/drm/RefPtrUdev.h M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSeat.cpp M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSeat.h M Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEDisplayWayland.cpp Log Message: --- [WPE] WPE Platform: make functions to get DRM device and render node members of WPEDisplay https://bugs.webkit.org/show_bug.cgi?id=270629 Reviewed by Alejandro G. Castro. They are currently global, and in the case of DRM might not be consistent with what it's actually used. Now that we have the primary display, we can move the API to WPEDisplay and return what every platform is actually using. * Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp: (WebKit::WebKitProtocolHandler::handleGPU): * Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp: (WebKit::DisplayVBlankMonitorDRM::create): * Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp: (WebKit::WebProcessPool::platformInitializeWebProcess): * Source/WebKit/WPEPlatform/wpe/WPEBufferDMABuf.cpp: (wpeBufferDMABufDispose): (wpeBufferDMABufTryEnsureGBMDevice): (wpeBufferDMABufImportToPixels): (gbmDevice): Deleted. * Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp: (wpe_display_get_drm_device): (wpe_display_get_drm_render_node): (renderNodeFile): Deleted. (wpeDRMRenderNodeFile): Deleted. (wpe_render_node_device): Deleted. (renderDeviceFile): Deleted. (wpeDRMRenderDeviceFile): Deleted. (wpe_render_device): Deleted. * Source/WebKit/WPEPlatform/wpe/WPEDisplay.h: * Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt: * Source/WebKit/WPEPlatform/wpe/drm/RefPtrUdev.cpp: Added. (WTF::udev>::refIfNotNull): (WTF::udev>::derefIfNotNull): (WTF::udev_device>::refIfNotNull): (WTF::udev_device>::derefIfNotNull): (WTF::udev_enumerate>::refIfNotNull): (WTF::udev_enumerate>::derefIfNotNull): * Source/WebKit/WPEPlatform/wpe/drm/RefPtrUdev.h: Added. * Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSeat.cpp: (WPE::DRM::Seat::create): (WPE::DRM::Seat::Seat): * Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSeat.h: * Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp: (findDevice): (wpeDisplayDRMConnect): (wpeDisplayDRMGetDRMDevice): (wpeDisplayDRMGetDRMRenderNode): (wpe_display_drm_class_init): * Source/WebKit/WPEPlatform/wpe/wayland/WPEDisplayWayland.cpp: (wpeDisplayWaylandDispose): (wpeDisplayWaylandConnect): (wpeDisplayWaylandGetDRMDevice): (wpeDisplayWaylandGetDRMRenderNode): (wpe_display_wayland_class_init): Canonical link: https://commits.webkit.org/275830@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 01716a: [WPE] WPE Platform: do not release buffers when re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 01716ada465537d722308dd31ec31171ffeffe86 https://github.com/WebKit/WebKit/commit/01716ada465537d722308dd31ec31171ffeffe86 Author: Carlos Garcia Campos Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: M Source/WebKit/UIProcess/wpe/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/wpe/AcceleratedBackingStoreDMABuf.h M Source/WebKit/WPEPlatform/wpe/WPEBuffer.cpp M Source/WebKit/WPEPlatform/wpe/WPEBuffer.h M Source/WebKit/WPEPlatform/wpe/WPEBufferDMABuf.cpp M Source/WebKit/WPEPlatform/wpe/WPEBufferDMABuf.h M Source/WebKit/WPEPlatform/wpe/WPEBufferSHM.cpp M Source/WebKit/WPEPlatform/wpe/WPEBufferSHM.h M Source/WebKit/WPEPlatform/wpe/WPEView.cpp M Source/WebKit/WPEPlatform/wpe/WPEView.h M Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp M Source/WebKit/WPEPlatform/wpe/headless/WPEViewHeadless.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp Log Message: --- [WPE] WPE Platform: do not release buffers when rendered https://bugs.webkit.org/show_bug.cgi?id=270693 Reviewed by Alejandro G. Castro. The buffers can be rendered again, so we need to keep them locked until a new frame is ready to be rendered. This patch adds WPEView::buffer-released in addition to the existing WPEView::buffer-rendered to notify that the buffer is no longer used and can be destroyed or reused. This patch also changes the WPEBuffer API to receive a WPEView in constructor instead of WPEDisplay, since buffers are actually attached to a specific WPEView, because we need to easily get the WPEView from the wayland buffer release callback. * Source/WebKit/UIProcess/wpe/AcceleratedBackingStoreDMABuf.cpp: (WebKit::AcceleratedBackingStoreDMABuf::AcceleratedBackingStoreDMABuf): (WebKit::AcceleratedBackingStoreDMABuf::updateSurfaceID): (WebKit::AcceleratedBackingStoreDMABuf::didCreateBuffer): (WebKit::AcceleratedBackingStoreDMABuf::didCreateBufferSHM): (WebKit::AcceleratedBackingStoreDMABuf::bufferRendered): (WebKit::AcceleratedBackingStoreDMABuf::bufferReleased): * Source/WebKit/UIProcess/wpe/AcceleratedBackingStoreDMABuf.h: * Source/WebKit/WPEPlatform/wpe/WPEBuffer.cpp: (wpeBufferGetProperty): (wpe_buffer_class_init): (wpe_buffer_get_view): (wpe_buffer_get_display): Deleted. * Source/WebKit/WPEPlatform/wpe/WPEBuffer.h: * Source/WebKit/WPEPlatform/wpe/WPEBufferDMABuf.cpp: (wpeBufferDMABufDispose): (wpeBufferDMABufImportToEGLImage): (wpeBufferDMABufTryEnsureGBMDevice): (wpe_buffer_dma_buf_new): * Source/WebKit/WPEPlatform/wpe/WPEBufferDMABuf.h: * Source/WebKit/WPEPlatform/wpe/WPEBufferSHM.cpp: (wpe_buffer_shm_new): * Source/WebKit/WPEPlatform/wpe/WPEBufferSHM.h: * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpe_view_class_init): (wpe_view_buffer_released): * Source/WebKit/WPEPlatform/wpe/WPEView.h: * Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp: (drmBufferCreateDMABuf): (drmBufferCreate): (wpeViewDRMRequestUpdate): (wpeViewDRMRenderBuffer): (wpeViewDRMDidPageFlip): * Source/WebKit/WPEPlatform/wpe/headless/WPEViewHeadless.cpp: (wpeViewHeadlessRenderBuffer): * Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp: (createWaylandBufferFromDMABuf): (createWaylandBufferSHM): (createWaylandBuffer): (createWaylandBufferFromEGLImage): Deleted. Canonical link: https://commits.webkit.org/275903@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 071a8e: [Skia] Improve the way we decide when to use CPU o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 071a8e4ca7a56a134f7c3573e76e00b392515861 https://github.com/WebKit/WebKit/commit/071a8e4ca7a56a134f7c3573e76e00b392515861 Author: Carlos Garcia Campos Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/html/ImageBitmap.cpp M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/page/Settings.yaml M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.h M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp M Source/WebKit/SourcesWPE.txt M Source/WebKit/UIProcess/WebPreferences.cpp M Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp A Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp Log Message: --- [Skia] Improve the way we decide when to use CPU or GPU https://bugs.webkit.org/show_bug.cgi?id=270083 Reviewed by Adrian Perez de Castro. We normally assume we always want hardware acceleration for rendering with Skia, but there are several situations in which we need to use the CPU: - If we fail to create the GL context. - If we fail to create the SkSurface (for example because the size is bigger than the maximum render target size allowed). - When accelerated compositing is disabled. - When accelerated 2D canvas is disabled. - When CPU rendering is disabled. - When the canvas is too small (we use 128 * 129 to match chromium). * Source/WebCore/html/CanvasBase.cpp: (WebCore::CanvasBase::shouldAccelerate const): * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createContext2d): (WebCore::HTMLCanvasElement::createContextBitmapRenderer): (WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer const): (WebCore::HTMLCanvasElement::createImageBuffer const): * Source/WebCore/html/ImageBitmap.cpp: (WebCore::bufferRenderingMode): (WebCore::ImageBitmap::create): (WebCore::ImageBitmap::createImageBuffer): (WebCore::ImageBitmap::createBlankImageBuffer): (WebCore::ImageBitmap::createCompletionHandler): (WebCore::ImageBitmap::createFromBuffer): * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::isAccelerated const): * Source/WebCore/page/Settings.yaml: * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::create): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp: (WebCore::ImageBufferSkiaAcceleratedBackend::create): * Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp: (WebCore::PlatformDisplay::skiaGLContext): * Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp: (WebCore::SkiaAcceleratedBufferPool::acquireBuffer): (WebCore::SkiaAcceleratedBufferPool::createAcceleratedBuffer): * Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp: (WebCore::CoordinatedGraphicsLayer::paintTile): * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/WebPreferences.cpp: * Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp: (WebKit::WebPreferences::platformInitializeStore): * Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp: Copied from Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp. (WebKit::WebPreferences::platformInitializeStore): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp: (WebKit::CompositingCoordinator::CompositingCoordinator): (WebKit::skiaForceUseCpuRendering): Deleted. Canonical link: https://commits.webkit.org/276016@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8efe42: [GTK][Skia] Add support for shared memory buffer i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8efe423f38b6d002cf19bbb2a0548ebe1a62f568 https://github.com/WebKit/WebKit/commit/8efe423f38b6d002cf19bbb2a0548ebe1a62f568 Author: Carlos Garcia Campos Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h Log Message: --- [GTK][Skia] Add support for shared memory buffer in accelerated compositing mode https://bugs.webkit.org/show_bug.cgi?id=270789 Reviewed by Adrian Perez de Castro. Create a cairo surface for the ShareableBitmap data. * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp: (WebKit::AcceleratedBackingStoreDMABuf::BufferSHM::didUpdateContents): * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h: Canonical link: https://commits.webkit.org/276017@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 015bce: [GTK][Skia] Add support for non-accelerated rendering
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 015bce0872dcce7de3173685094b0a73dbfb93b6 https://github.com/WebKit/WebKit/commit/015bce0872dcce7de3173685094b0a73dbfb93b6 Author: Carlos Garcia Campos Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp M Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp Log Message: --- [GTK][Skia] Add support for non-accelerated rendering https://bugs.webkit.org/show_bug.cgi?id=270788 Reviewed by Adrian Perez de Castro. GTK uses cairo for non-accelerated rendering, so we need to render the ShareableBitmap with skia, but into a cairo surface. * Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp: (WebCore::ShareableBitmap::paint): * Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp: (WebKit::BackingStore::incorporateUpdate): (WebKit::BackingStore::scroll): Canonical link: https://commits.webkit.org/276018@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f0325: [WPE] WPE Platform: make width, height, scale and ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f03251130ef53d46a41acffbebd1cb1a5f50f1f https://github.com/WebKit/WebKit/commit/2f03251130ef53d46a41acffbebd1cb1a5f50f1f Author: Carlos Garcia Campos Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/WPEView.cpp M Source/WebKit/WPEPlatform/wpe/WPEView.h M Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp M Source/WebKit/WPEPlatform/wpe/headless/WPEViewHeadless.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp Log Message: --- [WPE] WPE Platform: make width, height, scale and state read only properties of WPEView https://bugs.webkit.org/show_bug.cgi?id=270906 Reviewed by Alejandro G. Castro. The API to get and set those properties is a bit confusing and users are confused thinking they can call wpe_view_resize() from the app to resize the view, for example. Those properties should only be changed by WPEView derived classes in platform implementations. This patch makes the properties read only and the setters are renamed as notification functions and documented as only expected to be called by derived classes. wpe_view_resize() now requests a resize and a virtual method has been added for platforms to implement it only if they support resizing (DRM doesn't, for example). * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpeViewGetProperty): (wpe_view_class_init): (wpe_view_get_width): (wpe_view_get_height): (wpe_view_resize): (wpe_view_resized): (wpe_view_scale_changed): (wpe_view_state_changed): (wpe_view_set_width): Deleted. (wpe_view_set_height): Deleted. (wpe_view_set_scale): Deleted. (wpe_view_set_state): Deleted. * Source/WebKit/WPEPlatform/wpe/WPEView.h: * Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp: (wpeViewDRMConstructed): * Source/WebKit/WPEPlatform/wpe/headless/WPEViewHeadless.cpp: (wpeViewHeadlessResize): (wpeViewHeadlessSetFullscreen): (wpe_view_headless_class_init): * Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp: (wpeViewWaylandConstructed): (wpeViewWaylandResize): (wpe_view_wayland_class_init): Canonical link: https://commits.webkit.org/276070@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53d402: [GTK][WPE] Prefer opaque buffer formats for DMABuf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53d402bb927616eb7764d51818d3c80abcb3d885 https://github.com/WebKit/WebKit/commit/53d402bb927616eb7764d51818d3c80abcb3d885 Author: Carlos Garcia Campos Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/PlatformDisplay.cpp M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h M Source/WebKit/Shared/glib/DMABufRendererBufferFormat.h M Source/WebKit/WebProcess/WebPage/AcceleratedSurface.cpp M Source/WebKit/WebProcess/WebPage/AcceleratedSurface.h M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.h M Source/WebKit/WebProcess/WebPage/DrawingArea.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp M Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.h Log Message: --- [GTK][WPE] Prefer opaque buffer formats for DMABuf renderer if page background color is opaque https://bugs.webkit.org/show_bug.cgi?id=270964 Reviewed by Alejandro G. Castro. And make sure to not clear every frame with transparent color when the page background is opaque. * Source/WebCore/platform/graphics/PlatformDisplay.cpp: (WebCore::PlatformDisplay::dmabufFormats): * Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp: (WebKit::ThreadedCompositor::renderLayerTree): * Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h: * Source/WebKit/Shared/glib/DMABufRendererBufferFormat.h: (WebKit::DMABufRendererBufferFormat::operator== const): * Source/WebKit/WebProcess/WebPage/AcceleratedSurface.cpp: (WebKit::AcceleratedSurface::AcceleratedSurface): (WebKit::AcceleratedSurface::backgroundColorDidChange): (WebKit::AcceleratedSurface::clearIfNeeded): * Source/WebKit/WebProcess/WebPage/AcceleratedSurface.h: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp: (WebKit::DrawingAreaCoordinatedGraphics::backgroundColorDidChange): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp: (WebKit::LayerTreeHost::backgroundColorDidChange): (WebKit::LayerTreeHost::clearIfNeeded): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp: (WebKit::LayerTreeHost::backgroundColorDidChange): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.h: * Source/WebKit/WebProcess/WebPage/DrawingArea.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setBackgroundColor): * Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp: (WebKit::AcceleratedSurfaceDMABuf::AcceleratedSurfaceDMABuf): (WebKit::AcceleratedSurfaceDMABuf::SwapChain::setupBufferFormat): (WebKit::AcceleratedSurfaceDMABuf::preferredBufferFormatsDidChange): (WebKit::AcceleratedSurfaceDMABuf::backgroundColorDidChange): * Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.h: Canonical link: https://commits.webkit.org/276146@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 760062: [Skia] Fix font style values passed to matchFamily...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7600623697cb7564118f1f7ff022746ef638a13d https://github.com/WebKit/WebKit/commit/7600623697cb7564118f1f7ff022746ef638a13d Author: Carlos Garcia Campos Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp Log Message: --- [Skia] Fix font style values passed to matchFamilyStyle https://bugs.webkit.org/show_bug.cgi?id=271049 Reviewed by Alejandro G. Castro. We are doing a very simple conversion, but we should check values and thresholds. * Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp: (WebCore::skiaFontStyle): (WebCore::FontCache::createFontPlatformData): Canonical link: https://commits.webkit.org/276149@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2731ad: Unreviewed. Fix non-unified build
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 2731ad6c67a948d10217887f95401a3075954c5c https://github.com/WebKit/WebKit/commit/2731ad6c67a948d10217887f95401a3075954c5c Author: Carlos Garcia Campos Date: 2024-03-16 (Sat, 16 Mar 2024) Changed paths: M Source/WebCore/html/track/TrackBase.cpp Log Message: --- Unreviewed. Fix non-unified build * Source/WebCore/html/track/TrackBase.cpp: To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd82e6: Unreviewed. Update OptionsGTK.cmake and NEWS for 2...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: cd82e6bb7223de29d3696d7957c4a04ce3f64356 https://github.com/WebKit/WebKit/commit/cd82e6bb7223de29d3696d7957c4a04ce3f64356 Author: Carlos Garcia Campos Date: 2024-03-16 (Sat, 16 Mar 2024) Changed paths: M Source/WebKit/gtk/NEWS M Source/cmake/OptionsGTK.cmake Log Message: --- Unreviewed. Update OptionsGTK.cmake and NEWS for 2.44.0 release * Source/WebKit/gtk/NEWS: Add release notes for 2.44.0. * Source/cmake/OptionsGTK.cmake: Bump version numbers. To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/webkitgtk-2.44.0 Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e5efc: [Skia] Add support for font render properties
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e5efc33fac0f5a7214e55db7af541d8f6523260 https://github.com/WebKit/WebKit/commit/1e5efc33fac0f5a7214e55db7af541d8f6523260 Author: Carlos Garcia Campos Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/platform/SourcesCairo.txt M Source/WebCore/platform/SourcesSkia.txt A Source/WebCore/platform/graphics/FontRenderOptions.cpp A Source/WebCore/platform/graphics/FontRenderOptions.h M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp M Source/WebCore/platform/graphics/cairo/CairoUtilities.h A Source/WebCore/platform/graphics/cairo/FontRenderOptionsCairo.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp M Source/WebCore/platform/graphics/skia/FontPlatformDataSkia.cpp A Source/WebCore/platform/graphics/skia/FontRenderOptionsSkia.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp M Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp M Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.cpp Log Message: --- [Skia] Add support for font render properties https://bugs.webkit.org/show_bug.cgi?id=271112 Reviewed by Michael Catanzaro. Set hinting, antialias and pixel geometry. * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/platform/SourcesCairo.txt: * Source/WebCore/platform/SourcesSkia.txt: * Source/WebCore/platform/graphics/FontRenderOptions.cpp: Added. (WebCore::FontRenderOptions::singleton): * Source/WebCore/platform/graphics/FontRenderOptions.h: Added. (WebCore::FontRenderOptions::fontOptions const): (WebCore::FontRenderOptions::hinting const): (WebCore::FontRenderOptions::antialias const): (WebCore::FontRenderOptions::subpixelOrder const): * Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp: (WebCore::getDefaultCairoFontOptions): (WebCore::defaultCairoFontOptions): Deleted. (WebCore::disableCairoFontHintingForTesting): Deleted. (WebCore::setDefaultCairoHintOptions): Deleted. (WebCore::setDefaultCairoAntialiasOptions): Deleted. * Source/WebCore/platform/graphics/cairo/CairoUtilities.h: * Source/WebCore/platform/graphics/cairo/FontRenderOptionsCairo.cpp: Added. (WebCore::FontRenderOptions::FontRenderOptions): (WebCore::FontRenderOptions::setHinting): (WebCore::FontRenderOptions::setAntialias): (WebCore::FontRenderOptions::setSubpixelOrder): (WebCore::FontRenderOptions::disableHintingForTesting): * Source/WebCore/platform/graphics/skia/FontRenderOptionsSkia.cpp: Added. (WebCore::FontRenderOptions::setHinting): (WebCore::FontRenderOptions::setAntialias): (WebCore::FontRenderOptions::setSubpixelOrder): (WebCore::FontRenderOptions::disableHintingForTesting): * Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp: * Source/WebKit/WebProcess/glib/WebProcessGLib.cpp: (WebKit::WebProcess::platformInitializeWebProcess): * Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.cpp: (WebKit::GtkSettingsManagerProxy::applyHintingSettings): (WebKit::GtkSettingsManagerProxy::applyAntialiasSettings): Canonical link: https://commits.webkit.org/276255@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9bcc76: Unreviewed. [GTK] Bump version numbers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9bcc76df9f5d94cb122a0afe4ca2d9761f8bb131 https://github.com/WebKit/WebKit/commit/9bcc76df9f5d94cb122a0afe4ca2d9761f8bb131 Author: Carlos Garcia Campos Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/cmake/OptionsGTK.cmake Log Message: --- Unreviewed. [GTK] Bump version numbers * Source/cmake/OptionsGTK.cmake: Canonical link: https://commits.webkit.org/276256@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] accfe3: Unreviewed. Add Skia reviewers to the watch list
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: accfe39ad62017b79b1741efd264b5e5a9416cf5 https://github.com/WebKit/WebKit/commit/accfe39ad62017b79b1741efd264b5e5a9416cf5 Author: Carlos Garcia Campos Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M .github/CODEOWNERS Log Message: --- Unreviewed. Add Skia reviewers to the watch list * .github/CODEOWNERS: Canonical link: https://commits.webkit.org/276262@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ded93: [Skia] ImageBufferSkiaAcceleratedBackend should se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ded935fb7008e1b3222f34a9f508a34fa365923 https://github.com/WebKit/WebKit/commit/5ded935fb7008e1b3222f34a9f508a34fa365923 Author: Carlos Garcia Campos Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.h Log Message: --- [Skia] ImageBufferSkiaAcceleratedBackend should set RenderingMode as Accelerated https://bugs.webkit.org/show_bug.cgi?id=271149 Reviewed by Alejandro G. Castro. This is used by ImageBuffer on construction to populate ImageBufferBackend::Info. * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.h: Canonical link: https://commits.webkit.org/276265@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c3a017: [GTK] Failed to create GBM buffer of size 0x0: Inv...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c3a01735d06427eafeffe86bef0c139eddb7f3c4 https://github.com/WebKit/WebKit/commit/c3a01735d06427eafeffe86bef0c139eddb7f3c4 Author: Carlos Garcia Campos Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp Log Message: --- [GTK] Failed to create GBM buffer of size 0x0: Invalid argument https://bugs.webkit.org/show_bug.cgi?id=265154 Reviewed by Michael Catanzaro. This happens because in some cases we schedule a layer flush before the drawing area size is initially updated. It's easier to happen in the case of inspector because we don't delay the web process creation until the first load in that case. We should just ignore layer flush requests when the view size is empty since we won't be able to render anything anyway. Also set the device scale factor before the page is initialized to avoid sending an IPC message right after web page creation. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseCreateWebPage): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp: (WebKit::LayerTreeHost::scheduleLayerFlush): Canonical link: https://commits.webkit.org/276337@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4a8cfe: [GTK][Skia] Initialize SkGraphics
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4a8cfe4ed331acffe7d447cda6bdc7c8feff5bf4 https://github.com/WebKit/WebKit/commit/4a8cfe4ed331acffe7d447cda6bdc7c8feff5bf4 Author: Carlos Garcia Campos Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp M Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp Log Message: --- [GTK][Skia] Initialize SkGraphics https://bugs.webkit.org/show_bug.cgi?id=271225 Reviewed by Alejandro G. Castro. It's done for WPE in the web process, we should do the same for GTK and also initialize it in the UI process. * Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp: (WebKit::webkitInitialize): * Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp: Canonical link: https://commits.webkit.org/276338@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1007bd: [Skia] SkFontMgr should be created with the curren...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1007bd9ff1d656d0b19c6076d2043995d7109de4 https://github.com/WebKit/WebKit/commit/1007bd9ff1d656d0b19c6076d2043995d7109de4 Author: Carlos Garcia Campos Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp Log Message: --- [Skia] SkFontMgr should be created with the current FontConfig configuration https://bugs.webkit.org/show_bug.cgi?id=271230 Reviewed by Alejandro G. Castro. This makes sure we use the configuration created by WTR when running layout tests. * Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp: (WebCore::FontCache::platformInit): Canonical link: https://commits.webkit.org/276390@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8dbfd: [WTR][Skia] Draw repaint rects mask
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8dbfdb0176c402869c7bfb0ec6c837d289c79aa https://github.com/WebKit/WebKit/commit/c8dbfdb0176c402869c7bfb0ec6c837d289c79aa Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp Log Message: --- [WTR][Skia] Draw repaint rects mask https://bugs.webkit.org/show_bug.cgi?id=271236 Reviewed by Alejandro G. Castro. * Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Canonical link: https://commits.webkit.org/276391@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9d2e18: [WPE] Introduce USE(ATK)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9d2e1868ff2f6788291d06b764513846dbc46b8e https://github.com/WebKit/WebKit/commit/9d2e1868ff2f6788291d06b764513846dbc46b8e Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/PlatformWPE.cmake M Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.h M Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake M Tools/MiniBrowser/wpe/CMakeLists.txt M Tools/MiniBrowser/wpe/main.cpp M Tools/wpe/backends/PlatformWPE.cmake M Tools/wpe/backends/ViewBackend.cpp M Tools/wpe/backends/atk/ViewBackendAtk.cpp M Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp M Tools/wpe/backends/atk/WebKitAccessibleApplication.h Log Message: --- [WPE] Introduce USE(ATK) https://bugs.webkit.org/show_bug.cgi?id=267508 Reviewed by Michael Catanzaro. ENABLE_ACCESSIBILITY was removed in 273021@main, so add USE_ATK to keep accessibility optional in the WPE port. * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h: * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp: * Source/WebKit/UIProcess/API/wpe/PageClientImpl.h: * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::m_backend): (WKWPE::View::~View): * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp: (WebKit::WebPageProxy::bindAccessibilityTree): * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: * Tools/MiniBrowser/wpe/CMakeLists.txt: * Tools/MiniBrowser/wpe/main.cpp: (activate): * Tools/wpe/backends/PlatformWPE.cmake: * Tools/wpe/backends/ViewBackend.cpp: (WPEToolingBackends::ViewBackend::initializeAccessibility): (WPEToolingBackends::ViewBackend::updateAccessibilityState): * Tools/wpe/backends/atk/ViewBackendAtk.cpp: * Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp: * Tools/wpe/backends/atk/WebKitAccessibleApplication.h: Canonical link: https://commits.webkit.org/276392@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f10b74: [GTK][Skia] Implement PlatformWebView::windowSnaps...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f10b743dee70ce8e1a1755f95e7b62a7f0062831 https://github.com/WebKit/WebKit/commit/f10b743dee70ce8e1a1755f95e7b62a7f0062831 Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp Log Message: --- [GTK][Skia] Implement PlatformWebView::windowSnapshotImage() in WTR https://bugs.webkit.org/show_bug.cgi?id=271231 Reviewed by Alejandro G. Castro. * Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::viewSnapshot): (WTR::PlatformWebView::windowSnapshotImage): Canonical link: https://commits.webkit.org/276398@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bcddb3: [WTR][Skia] Add support for web contents pixel res...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bcddb3eea6b4257f6a974f9f78efdfedf9e68c8f https://github.com/WebKit/WebKit/commit/bcddb3eea6b4257f6a974f9f78efdfedf9e68c8f Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/Shared/API/c/cairo/WKImageCairo.cpp M Source/WebKit/Shared/API/c/cairo/WKImageCairo.h A Source/WebKit/Shared/API/c/skia/WKImageSkia.cpp A Source/WebKit/Shared/API/c/skia/WKImageSkia.h M Source/WebKit/SourcesGTK.txt M Source/WebKit/SourcesWPE.txt M Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp M Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp Log Message: --- [WTR][Skia] Add support for web contents pixel results https://bugs.webkit.org/show_bug.cgi?id=271239 Reviewed by Alejandro G. Castro. Add WKImageSkia with WKImageCreateSkImage() to be used from dumpPixelsAndCompareWithExpected(). * Source/WebKit/Shared/API/c/cairo/WKImageCairo.cpp: (WKImageCreateCairoSurface): (WKImageCreateFromCairoSurface): * Source/WebKit/Shared/API/c/cairo/WKImageCairo.h: * Source/WebKit/Shared/API/c/skia/WKImageSkia.cpp: Copied from Source/WebKit/Shared/API/c/cairo/WKImageCairo.h. (WKImageCreateSkImage): * Source/WebKit/Shared/API/c/skia/WKImageSkia.h: Copied from Source/WebKit/Shared/API/c/cairo/WKImageCairo.h. * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesWPE.txt: * Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: * Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Canonical link: https://commits.webkit.org/276401@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 143ff2: [Skia] Implement TestController::takeViewPortSnaps...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 143ff2a9a2aee70e3eb4fb2b8576acabff66c93e https://github.com/WebKit/WebKit/commit/143ff2a9a2aee70e3eb4fb2b8576acabff66c93e Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp M Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp Log Message: --- [Skia] Implement TestController::takeViewPortSnapshot() https://bugs.webkit.org/show_bug.cgi?id=271312 Reviewed by Alejandro G. Castro. * Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::takeViewPortSnapshot): * Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp: (WTR::TestController::takeViewPortSnapshot): Canonical link: https://commits.webkit.org/276407@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 867737: [Skia] Make GraphicsContextSkia constructor receiv...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 867737f23957b13585997afb13f21ebfe1d3be80 https://github.com/WebKit/WebKit/commit/867737f23957b13585997afb13f21ebfe1d3be80 Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h M Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/PathSkia.cpp M Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp M Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp Log Message: --- [Skia] Make GraphicsContextSkia constructor receive a SkCanvas instead of a SkSurface https://bugs.webkit.org/show_bug.cgi?id=271309 Reviewed by Alejandro G. Castro. For printing we won't have a SkSurface to pass. The constructor now receives a reference to a SkCanvas, so callers need to ensure the canvas will be alive, which is always the case except for ShareableBitmap. For that case we also include an optional destroy notify parameter that is used to release the associated SkSurface when the graphics context is destroyed. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::GraphicsContextSkia): (WebCore::GraphicsContextSkia::hasPlatformContext const): (WebCore::GraphicsContextSkia::getCTM const): (WebCore::GraphicsContextSkia::platformContext const): (WebCore::GraphicsContextSkia::save): (WebCore::GraphicsContextSkia::restore): (WebCore::GraphicsContextSkia::drawRect): (WebCore::GraphicsContextSkia::drawNativeImageInternal): (WebCore::GraphicsContextSkia::drawLine): (WebCore::GraphicsContextSkia::drawEllipse): (WebCore::GraphicsContextSkia::fillPath): (WebCore::GraphicsContextSkia::strokePath): (WebCore::GraphicsContextSkia::fillRect): (WebCore::GraphicsContextSkia::clip): (WebCore::GraphicsContextSkia::clipPath): (WebCore::GraphicsContextSkia::clipBounds const): (WebCore::GraphicsContextSkia::clipToImageBuffer): (WebCore::GraphicsContextSkia::drawDotsForDocumentMarker): (WebCore::GraphicsContextSkia::translate): (WebCore::GraphicsContextSkia::concatCTM): (WebCore::GraphicsContextSkia::setCTM): (WebCore::GraphicsContextSkia::beginTransparencyLayer): (WebCore::GraphicsContextSkia::endTransparencyLayer): (WebCore::GraphicsContextSkia::clearRect): (WebCore::GraphicsContextSkia::strokeRect): (WebCore::GraphicsContextSkia::clipOut): (WebCore::GraphicsContextSkia::rotate): (WebCore::GraphicsContextSkia::scale): (WebCore::GraphicsContextSkia::fillRoundedRectImpl): (WebCore::GraphicsContextSkia::fillRectWithRoundedHole): (WebCore::GraphicsContextSkia::drawPattern): (WebCore::GraphicsContextSkia::canvas const): Deleted. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h: * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp: (WebCore::ImageBufferSkiaAcceleratedBackend::create): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp: (WebCore::ImageBufferSkiaSurfaceBackend::ImageBufferSkiaSurfaceBackend): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h: * Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp: (WebCore::ImageBufferSkiaUnacceleratedBackend::create): * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::strokeContains const): (WebCore::PathSkia::strokeBoundingRect const): * Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp: (WebCore::ShareableBitmap::createGraphicsContext): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp: (WebCore::CoordinatedGraphicsLayer::paintTile): (WebCore::CoordinatedGraphicsLayer::paintImage): * Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp: (WebKit::BackingStore::incorporateUpdate): Canonical link: https://commits.webkit.org/276408@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f349ce: [Skia] Animation on images motion mark test doesn'...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f349cebbce3f2278e3944d1024a9ec04a1a929bb https://github.com/WebKit/WebKit/commit/f349cebbce3f2278e3944d1024a9ec04a1a929bb Author: Carlos Garcia Campos Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp Log Message: --- [Skia] Animation on images motion mark test doesn't work on the CPU https://bugs.webkit.org/show_bug.cgi?id=271319 Reviewed by Nikolas Zimmermann. Use SkSurface::peekPixels() instead of SkSurface::makeImageSnapshot() when creating a NativeImage reference. * Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp: (WebCore::ImageBufferSkiaUnacceleratedBackend::createNativeImageReference): Canonical link: https://commits.webkit.org/276448@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18960f: [Skia] Enable or disable antialiasing according to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18960f28ed56299605902a3f663aece2791c2735 https://github.com/WebKit/WebKit/commit/18960f28ed56299605902a3f663aece2791c2735 Author: Carlos Garcia Campos Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Enable or disable antialiasing according to the graphics context state https://bugs.webkit.org/show_bug.cgi?id=271370 Reviewed by Alejandro G. Castro. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::createFillPaint const): (WebCore::GraphicsContextSkia::createStrokePaint const): Canonical link: https://commits.webkit.org/276452@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c4b3e2: [Skia] Check if glFence is available before using it
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c4b3e26f6881ae3d97a0ac8f1cb09a105cd95522 https://github.com/WebKit/WebKit/commit/c4b3e26f6881ae3d97a0ac8f1cb09a105cd95522 Author: Carlos Garcia Campos Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/PlatformPlayStation.cmake M Source/WebCore/SourcesGTK.txt M Source/WebCore/SourcesWPE.txt M Source/WebCore/platform/graphics/egl/GLContext.cpp M Source/WebCore/platform/graphics/egl/GLContext.h A Source/WebCore/platform/graphics/egl/GLFence.cpp A Source/WebCore/platform/graphics/egl/GLFence.h M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.h Log Message: --- [Skia] Check if glFence is available before using it https://bugs.webkit.org/show_bug.cgi?id=271376 Reviewed by Miguel Gomez. If not available we need to call GrDirectContext::submit() with GrSyncCpu=kYes. This patch adds a helper class GLFence to wrap it, that can be extended in the future to support nvidia fences if needed too. * Source/WebCore/Headers.cmake: * Source/WebCore/PlatformPlayStation.cmake: * Source/WebCore/SourcesGTK.txt: * Source/WebCore/SourcesWPE.txt: * Source/WebCore/platform/graphics/egl/GLContext.cpp: (WebCore::GLContext::glExtensions const): * Source/WebCore/platform/graphics/egl/GLContext.h: * Source/WebCore/platform/graphics/egl/GLFence.cpp: Added. (WebCore::GLFence::create): (WebCore::GLFence::GLFence): (WebCore::GLFence::~GLFence): (WebCore::GLFence::wait): * Source/WebCore/platform/graphics/egl/GLFence.h: Added. * Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp: (Nicosia::AcceleratedBuffer::beginPainting): (Nicosia::AcceleratedBuffer::completePainting): (Nicosia::AcceleratedBuffer::waitUntilPaintingComplete): (Nicosia::AcceleratedBuffer::~AcceleratedBuffer): Deleted. * Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.h: Canonical link: https://commits.webkit.org/276463@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d0d771: [Skia] Crash when failing to create a font with cu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d0d77187c24c1e2bef6bba0fefc55da1cfe783b2 https://github.com/WebKit/WebKit/commit/d0d77187c24c1e2bef6bba0fefc55da1cfe783b2 Author: Carlos Garcia Campos Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp Log Message: --- [Skia] Crash when failing to create a font with custom data https://bugs.webkit.org/show_bug.cgi?id=271391 Reviewed by Adrian Perez de Castro. This happens for example with test fast/css/font-face-data-uri-invalid.html. SkFontMgr::makeFromData() fails to create the SkTypeface and returns nullptr that we don't check. * Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp: (WebCore::FontCustomPlatformData::create): Canonical link: https://commits.webkit.org/276473@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 82bbfe: [Skia] Create the font manager on demand when firs...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82bbfe731a36c812693c8326286281b561b52377 https://github.com/WebKit/WebKit/commit/82bbfe731a36c812693c8326286281b561b52377 Author: Carlos Garcia Campos Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/FontCache.h M Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp M Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp Log Message: --- [Skia] Create the font manager on demand when first needed https://bugs.webkit.org/show_bug.cgi?id=271396 Reviewed by Adrian Perez de Castro. We are creating the font manager in FontCache::platformInit(), but that's only called once for all the instances. This makes all offscreen canvas tests rendering text to crash, because the FontCache in the worker thread doesn't have a font manager. * Source/WebCore/platform/graphics/FontCache.h: (WebCore::FontCache::fontManager const): Deleted. * Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp: (WebCore::FontCache::platformInit): (WebCore::FontCache::fontManager const): (WebCore::FontCache::systemFallbackForCharacterCluster): (WebCore::FontCache::systemFontFamilies): (WebCore::FontCache::createFontPlatformData): * Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp: (WebCore::FontCustomPlatformData::create): Canonical link: https://commits.webkit.org/276483@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bdd874: Unreviewed. [GTK] Fix the build after 276859@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bdd874cb8ce5fcdf35806ada613b384fcfa8c151 https://github.com/WebKit/WebKit/commit/bdd874cb8ce5fcdf35806ada613b384fcfa8c151 Author: Carlos Garcia Campos Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp Log Message: --- Unreviewed. [GTK] Fix the build after 276859@main * Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp: (WebKit::DropTarget::accept): Canonical link: https://commits.webkit.org/276873@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4aa868: Unreviewed. [Skia] Fix build with clang after 2765...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4aa8685f0ebc20c9132bc6f361a7122dfd94d7da https://github.com/WebKit/WebKit/commit/4aa8685f0ebc20c9132bc6f361a7122dfd94d7da Author: Carlos Garcia Campos Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/skia/PathSkia.cpp Log Message: --- Unreviewed. [Skia] Fix build with clang after 276505@main * Source/WebCore/platform/graphics/skia/PathSkia.cpp: Canonical link: https://commits.webkit.org/276874@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d92649: [Skia] Convert SkScalar to HarfBuzz position witho...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d92649154483861d90db938e492acc88348607a8 https://github.com/WebKit/WebKit/commit/d92649154483861d90db938e492acc88348607a8 Author: Carlos Garcia Campos Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/skia/SkiaHarfBuzzFont.cpp Log Message: --- [Skia] Convert SkScalar to HarfBuzz position without converting first to float/double https://bugs.webkit.org/show_bug.cgi?id=272080 Reviewed by Adrian Perez de Castro. Add skScalarToHarfBuzzPosition() to replace floatToHarfBuzzPosition() and doubleToHarfBuzzPosition(). * Source/WebCore/platform/graphics/skia/SkiaHarfBuzzFont.cpp: (WebCore::skScalarToHarfBuzzPosition): (WebCore::SkiaHarfBuzzFont::scaledFont): (WebCore::SkiaHarfBuzzFont::glyphWidth): (WebCore::SkiaHarfBuzzFont::glyphWidths): (WebCore::SkiaHarfBuzzFont::glyphExtents): (WebCore::floatToHarfBuzzPosition): Deleted. (WebCore::doubleToHarfBuzzPosition): Deleted. Canonical link: https://commits.webkit.org/277052@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15b647: [Skia] Global alpha is not handled when drawing an...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15b647424382d82c7b2c120c3f15ebf8a4126392 https://github.com/WebKit/WebKit/commit/15b647424382d82c7b2c120c3f15ebf8a4126392 Author: Carlos Garcia Campos Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Global alpha is not handled when drawing an image or filling with a pattern https://bugs.webkit.org/show_bug.cgi?id=272151 Reviewed by Alejandro G. Castro. Set the global alpha when drawing images and filling with a pattern. Also don't apply the alpha when setting the color of shadows, since it's already taken from SkPaint global alpha or source color. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::drawNativeImageInternal): (WebCore::GraphicsContextSkia::createDropShadowFilterIfNeeded const): (WebCore::GraphicsContextSkia::setupFillSource const): Canonical link: https://commits.webkit.org/277106@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] af3cd7: [WPE] WPE Platform: add WPEToplevel
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: af3cd7645c2f0124130279549f392f8c89501fcb https://github.com/WebKit/WebKit/commit/af3cd7645c2f0124130279549f392f8c89501fcb Author: Carlos Garcia Campos Date: 2024-06-27 (Thu, 27 Jun 2024) Changed paths: M Source/WebKit/PlatformWPE.cmake M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/qt6/WPEDisplayQtQuick.cpp A Source/WebKit/UIProcess/API/wpe/qt6/WPEToplevelQtQuick.cpp A Source/WebKit/UIProcess/API/wpe/qt6/WPEToplevelQtQuick.h M Source/WebKit/UIProcess/API/wpe/qt6/WPEViewQtQuick.cpp M Source/WebKit/WPEPlatform/CMakeLists.txt A Source/WebKit/WPEPlatform/wpe/WPEToplevel.cpp A Source/WebKit/WPEPlatform/wpe/WPEToplevel.h A Source/WebKit/WPEPlatform/wpe/WPEToplevelPrivate.h M Source/WebKit/WPEPlatform/wpe/WPEView.cpp M Source/WebKit/WPEPlatform/wpe/WPEView.h A Source/WebKit/WPEPlatform/wpe/WPEViewPrivate.h M Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt M Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp A Source/WebKit/WPEPlatform/wpe/drm/WPEToplevelDRM.cpp A Source/WebKit/WPEPlatform/wpe/drm/WPEToplevelDRM.h M Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp M Source/WebKit/WPEPlatform/wpe/drm/wpe-drm.h M Source/WebKit/WPEPlatform/wpe/headless/CMakeLists.txt M Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp A Source/WebKit/WPEPlatform/wpe/headless/WPEToplevelHeadless.cpp A Source/WebKit/WPEPlatform/wpe/headless/WPEToplevelHeadless.h M Source/WebKit/WPEPlatform/wpe/headless/WPEViewHeadless.cpp M Source/WebKit/WPEPlatform/wpe/headless/wpe-headless.h M Source/WebKit/WPEPlatform/wpe/wayland/CMakeLists.txt M Source/WebKit/WPEPlatform/wpe/wayland/WPEDisplayWayland.cpp A Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp A Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.h A Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWaylandPrivate.h M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.h M Source/WebKit/WPEPlatform/wpe/wayland/wpe-wayland.h M Source/WebKit/WPEPlatform/wpe/wpe-platform.h M Tools/MiniBrowser/wpe/main.cpp M Tools/Scripts/webkitpy/style/checker.py M Tools/WebKitTestRunner/wpe/PlatformWebViewClientWPE.cpp Log Message: --- [WPE] WPE Platform: add WPEToplevel https://bugs.webkit.org/show_bug.cgi?id=275805 Reviewed by Alejandro G. Castro. Add a new class to handle platform toplevels. This will allow us to support multiple views in the same toplevel, but for now only one is supported. * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::m_backend): (WKWPE::viewToplevelIsFullScreen): (WKWPE::View::enterFullScreen): (WKWPE::View::exitFullScreen): * Source/WebKit/UIProcess/API/wpe/qt6/WPEDisplayQtQuick.cpp: (wpeDisplayQtQuickCreateView): * Source/WebKit/UIProcess/API/wpe/qt6/WPEToplevelQtQuick.cpp: Added. (wpeToplevelQtQuickDispose): (wpeToplevelQtQuickResize): (wpe_toplevel_qtquick_class_init): (wpe_toplevel_qtquick_new): * Source/WebKit/UIProcess/API/wpe/qt6/WPEToplevelQtQuick.h: Copied from Source/WebKit/WPEPlatform/wpe/headless/wpe-headless.h. * Source/WebKit/UIProcess/API/wpe/qt6/WPEViewQtQuick.cpp: (wpe_view_qtquick_class_init): (wpeViewQtQuickResize): Deleted. * Source/WebKit/WPEPlatform/CMakeLists.txt: * Source/WebKit/WPEPlatform/wpe/WPEToplevel.cpp: Added. (wpeToplevelGetProperty): (wpe_toplevel_class_init): (wpeToplevelAddView): (wpeToplevelRemoveView): (wpe_toplevel_get_display): (wpe_toplevel_set_title): (wpe_toplevel_get_max_views): (wpe_toplevel_get_n_views): (wpe_toplevel_foreach_view): (wpe_toplevel_closed): (wpe_toplevel_get_size): (wpe_toplevel_resize): (wpe_toplevel_resized): (wpe_toplevel_get_state): (wpe_toplevel_state_changed): (wpe_toplevel_get_scale): (wpe_toplevel_scale_changed): (wpe_toplevel_get_monitor): (wpe_toplevel_monitor_changed): (wpe_toplevel_fullscreen): (wpe_toplevel_unfullscreen): (wpe_toplevel_maximize): (wpe_toplevel_unmaximize): (wpe_toplevel_get_preferred_dma_buf_formats): (wpe_toplevel_preferred_dma_buf_formats_changed): * Source/WebKit/WPEPlatform/wpe/WPEToplevel.h: Added. * Source/WebKit/WPEPlatform/wpe/WPEToplevelPrivate.h: Copied from Source/WebKit/WPEPlatform/wpe/drm/wpe-drm.h. * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpeViewGetProperty): (wpeViewDispose): (wpe_view_class_init): (wpeViewToplevelStateChanged): (wpeViewScaleChanged): (wpeViewMonitorChanged): (wpeViewPreferredDMABufFormatsChanged): (wpe_view_get_toplevel): (wpe_view_set_toplevel): (wpe_view_get_toplevel_state): (wpe_view_get_monitor): (wpe_view_get_preferred_dma_buf_formats): (wpe_view_resize): Deleted. (wpe_view_scale_changed): Deleted. (wpe_view_get_state): Deleted. (wpe_view_state_changed
[webkit-changes] [WebKit/WebKit] 696c43: [GTK][WPE] Application ID is not used consistently
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 696c432e7e05d6da4c0661ef7d891b6fd7007ef2 https://github.com/WebKit/WebKit/commit/696c432e7e05d6da4c0661ef7d891b6fd7007ef2 Author: Carlos Garcia Campos Date: 2024-06-27 (Thu, 27 Jun 2024) Changed paths: M Source/WTF/wtf/PlatformGTK.cmake M Source/WTF/wtf/PlatformWPE.cmake A Source/WTF/wtf/glib/Application.cpp A Source/WTF/wtf/glib/Application.h M Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp M Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp M Source/WebKit/UIProcess/Notifications/glib/NotificationService.cpp M Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp Log Message: --- [GTK][WPE] Application ID is not used consistently https://bugs.webkit.org/show_bug.cgi?id=275946 Reviewed by Michael Catanzaro. We currently need the application ID from the bubblewrap sandbox, notifications, geolocation provider, and it's sent to the web process too. We are doing different things in all of those places. Add WTF::applicationID() and use it everywhere to ensure we always get the same value. * Source/WTF/wtf/PlatformGTK.cmake: * Source/WTF/wtf/PlatformWPE.cmake: * Source/WTF/wtf/glib/Application.cpp: Added. (WTF::applicationID): * Source/WTF/wtf/glib/Application.h: Added. * Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp: (WebKit::createFlatpakInfo): (WebKit::effectiveApplicationId): Deleted. * Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp: (WebKit::XDGDBusProxy::dbusSessionProxy): * Source/WebKit/UIProcess/Notifications/glib/NotificationService.cpp: (WebKit::applicationIcon): (WebKit::NotificationService::showNotification): * Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp: (WebKit::GeoclueGeolocationProvider::setupGeoclueClient): * Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp: (WebKit::WebProcessPool::platformInitializeWebProcess): Canonical link: https://commits.webkit.org/280444@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8fea18: [WPE] WPE Platform: implement WPEToplevel::get_tit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8fea187f12a146cba9ef2e8595c30b38e736413b https://github.com/WebKit/WebKit/commit/8fea187f12a146cba9ef2e8595c30b38e736413b Author: Carlos Garcia Campos Date: 2024-06-27 (Thu, 27 Jun 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp M Tools/MiniBrowser/wpe/main.cpp Log Message: --- [WPE] WPE Platform: implement WPEToplevel::get_title in wayland https://bugs.webkit.org/show_bug.cgi?id=275948 Reviewed by Nikolas Zimmermann. * Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp: (defaultTitle): (wpeToplevelWaylandConstructed): (wpeToplevelWaylandSetTitle): (wpe_toplevel_wayland_class_init): * Tools/MiniBrowser/wpe/main.cpp: (webViewTitleChanged): (createWebView): (activate): Canonical link: https://commits.webkit.org/280445@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a9708d: [WPE] WPE Platform: implement WPE_TOPLEVEL_STATE_A...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9708dce12751c5fe67c32c195f9d2aca105ecbe https://github.com/WebKit/WebKit/commit/a9708dce12751c5fe67c32c195f9d2aca105ecbe Author: Carlos Garcia Campos Date: 2024-06-28 (Fri, 28 Jun 2024) Changed paths: M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/WPEPlatform/wpe/drm/WPEToplevelDRM.cpp M Source/WebKit/WPEPlatform/wpe/headless/WPEToplevelHeadless.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp Log Message: --- [WPE] WPE Platform: implement WPE_TOPLEVEL_STATE_ACTIVE https://bugs.webkit.org/show_bug.cgi?id=275949 Reviewed by Nikolas Zimmermann. * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::m_backend): * Source/WebKit/WPEPlatform/wpe/drm/WPEToplevelDRM.cpp: (wpeToplevelDRMConstructed): * Source/WebKit/WPEPlatform/wpe/headless/WPEToplevelHeadless.cpp: (wpeToplevelHeadlessConstructed): (wpe_toplevel_headless_class_init): * Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp: Canonical link: https://commits.webkit.org/280447@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] abd2c2: REGRESSION(278498@main) [Skia] getUserMedia(device...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: abd2c22d3e30601af71488946899c7f3bbf4e326 https://github.com/WebKit/WebKit/commit/abd2c22d3e30601af71488946899c7f3bbf4e326 Author: Carlos Garcia Campos Date: 2024-06-28 (Fri, 28 Jun 2024) Changed paths: M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp Log Message: --- REGRESSION(278498@main) [Skia] getUserMedia(deviceID) frequently freezing in media stream tests under debug https://bugs.webkit.org/show_bug.cgi?id=275165 Reviewed by Philippe Normand. Why don't know why this only happens with Skia, but the problem is the emit frame timer running every 33ms doesn't allow other sources with the same or lower priority to run. We can change the priority to make sure run loop dispatcher sources are higher priority. * Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp: Canonical link: https://commits.webkit.org/280450@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 00b3d6: [WPE] Split WPEWebView into Legacy and Platform im...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00b3d6a56f5149245b9e1501389ae169846ec240 https://github.com/WebKit/WebKit/commit/00b3d6a56f5149245b9e1501389ae169846ec240 Author: Carlos Garcia Campos Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebKit/SourcesWPE.txt M Source/WebKit/UIProcess/API/C/wpe/WKView.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.h A Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.cpp A Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.h A Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp A Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h M Source/WebKit/UIProcess/Gamepad/libwpe/UIGamepadProviderLibWPE.cpp Log Message: --- [WPE] Split WPEWebView into Legacy and Platform implementations https://bugs.webkit.org/show_bug.cgi?id=275985 Reviewed by Nikolas Zimmermann. It makes clearer what code is expected to be used for new and old APIs. * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/API/C/wpe/WKView.cpp: (WKViewCreate): (WKViewCreateDeprecated): * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewCreatePage): (webkitWebViewGetRendererBufferFormat): * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp: (WebKit::PageClientImpl::doneWithTouchEvent): (WebKit::PageClientImpl::enterAcceleratedCompositingMode): (WebKit::PageClientImpl::exitAcceleratedCompositingMode): (WebKit::PageClientImpl::updateAcceleratedCompositingMode): (WebKit::PageClientImpl::enterFullScreen): (WebKit::PageClientImpl::exitFullScreen): * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::View::View): (WKWPE::View::close): (WKWPE::View::accessible const): (): Deleted. (WKWPE::m_backend): Deleted. (WKWPE::View::~View): Deleted. (WKWPE::View::setViewState): Deleted. (WKWPE::View::handleKeyboardEvent): Deleted. (WKWPE::View::synthesizeCompositionKeyPress): Deleted. (WKWPE::viewToplevelIsFullScreen): Deleted. (WKWPE::View::enterFullScreen): Deleted. (WKWPE::View::didEnterFullScreen): Deleted. (WKWPE::View::exitFullScreen): Deleted. (WKWPE::View::didExitFullScreen): Deleted. (WKWPE::View::requestExitFullScreen): Deleted. (WKWPE::View::setFullScreen): Deleted. (WKWPE::View::platformWebPageProxyForGamepadInput): Deleted. (WKWPE::View::updateAcceleratedSurface): Deleted. (WKWPE::View::renderBufferFormat const): Deleted. (WKWPE::View::updateDisplayID): Deleted. (WKWPE::View::touchPointsForEvent): Deleted. (WKWPE::View::setCursor): Deleted. (WKWPE::View::callAfterNextPresentationUpdate): Deleted. * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: (WKWPE::View::page): (WKWPE::View::client const): (WKWPE::View::size const): (WKWPE::View::backend const): (WKWPE::View::wpeView const): (WKWPE::View::setCursor): (WKWPE::View::create): Deleted. (WKWPE::View::backend): Deleted. (WKWPE::View::touchGestureController const): Deleted. * Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.cpp: Added. (WKWPE::ViewLegacy::ViewLegacy): (WKWPE::ViewLegacy::~ViewLegacy): (WKWPE::ViewLegacy::setViewState): (WKWPE::ViewLegacy::handleKeyboardEvent): (WKWPE::ViewLegacy::synthesizeCompositionKeyPress): (WKWPE::ViewLegacy::setFullScreen): (WKWPE::ViewLegacy::platformWebPageProxyForGamepadInput): (WKWPE::ViewLegacy::callAfterNextPresentationUpdate): * Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.h: Added. * Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp: Added. (WKWPE::ViewPlatform::ViewPlatform): (WKWPE::ViewPlatform::~ViewPlatform): (WKWPE::viewToplevelIsFullScreen): (WKWPE::ViewPlatform::enterFullScreen): (WKWPE::ViewPlatform::didEnterFullScreen): (WKWPE::ViewPlatform::exitFullScreen): (WKWPE::ViewPlatform::didExitFullScreen): (WKWPE::ViewPlatform::requestExitFullScreen): (WKWPE::ViewPlatform::updateAcceleratedSurface): (WKWPE::ViewPlatform::renderBufferFormat const): (WKWPE::ViewPlatform::updateDisplayID): (WKWPE::ViewPlatform::touchPointsForEvent): (WKWPE::ViewPlatform::synthesizeCompositionKeyPress): (WKWPE::ViewPlatform::setCursor): (WKWPE::ViewPlatform::callAfterNextPresentationUpdate): * Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h: Added. * Source/WebKit/UIProcess/Gamepad/libwpe/UIGamepadProviderLibWPE.cpp: (WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput): Canonical link: https://commits.webkit.org/280522@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0381c: [WPE] WPE Platform: fix toplevel resize under wayland
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0381cc1d025f3694d5d910f30cadba98ae76b04 https://github.com/WebKit/WebKit/commit/e0381cc1d025f3694d5d910f30cadba98ae76b04 Author: Carlos Garcia Campos Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp Log Message: --- [WPE] WPE Platform: fix toplevel resize under wayland https://bugs.webkit.org/show_bug.cgi?id=276069 Reviewed by Nikolas Zimmermann. WPEToplevelWayland is not notifying the views about the resize request. We should call wpeToplevelWaylandResized(). * Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp: (wpeToplevelWaylandResize): Canonical link: https://commits.webkit.org/280527@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 753627: [WPE] WPE Platform: set application ID on toplevel...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75362745f30d727ca88328a2be32ac8aa5f4b933 https://github.com/WebKit/WebKit/commit/75362745f30d727ca88328a2be32ac8aa5f4b933 Author: Carlos Garcia Campos Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp Log Message: --- [WPE] WPE Platform: set application ID on toplevel under wayland https://bugs.webkit.org/show_bug.cgi?id=275987 Reviewed by Alejandro G. Castro. * Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp: (wpeToplevelWaylandConstructed): Canonical link: https://commits.webkit.org/280529@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 14d24d: [GTK][WPE] DRMDeviceNode needs to be ThreadSafeRef...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 14d24d0067bb5d83653aed94987f7ea6137069a6 https://github.com/WebKit/WebKit/commit/14d24d0067bb5d83653aed94987f7ea6137069a6 Author: Carlos Garcia Campos Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/gbm/DRMDeviceManager.cpp M Source/WebCore/platform/graphics/gbm/DRMDeviceNode.cpp M Source/WebCore/platform/graphics/gbm/DRMDeviceNode.h Log Message: --- [GTK][WPE] DRMDeviceNode needs to be ThreadSafeRefCounted https://bugs.webkit.org/show_bug.cgi?id=275583 Reviewed by Nikolas Zimmermann. Make DRMDeviceNode ThreadSafeRefCounted and ensure the GBMDevice is always created in the main thread. * Source/WebCore/platform/graphics/gbm/DRMDeviceManager.cpp: (WebCore::DRMDeviceManager::initializeMainDevice): (WebCore::DRMDeviceManager::deviceNode): * Source/WebCore/platform/graphics/gbm/DRMDeviceNode.cpp: (WebCore::DRMDeviceNode::create): (WebCore::DRMDeviceNode::gbmDevice const): * Source/WebCore/platform/graphics/gbm/DRMDeviceNode.h: Canonical link: https://commits.webkit.org/280530@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 35cb17: [WPE] WPE Platform: copy toplevel views values to ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35cb1751bf8f1f7efc59fe033cf8a95ad5803c05 https://github.com/WebKit/WebKit/commit/35cb1751bf8f1f7efc59fe033cf8a95ad5803c05 Author: Carlos Garcia Campos Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/WPEToplevel.cpp Log Message: --- [WPE] WPE Platform: copy toplevel views values to a vector when iterating them https://bugs.webkit.org/show_bug.cgi?id=276071 Reviewed by Nikolas Zimmermann. We iterate the toplevel views to notify them about changes, that can emit signals and that could destroy the view causing the map to change while being iterated. * Source/WebKit/WPEPlatform/wpe/WPEToplevel.cpp: (wpe_toplevel_foreach_view): (wpe_toplevel_closed): (wpe_toplevel_state_changed): (wpe_toplevel_scale_changed): (wpe_toplevel_monitor_changed): (wpe_toplevel_preferred_dma_buf_formats_changed): Canonical link: https://commits.webkit.org/280566@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6461ef: [WPE] Create the WebPageProxy after initializing a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6461ef8e6cca4c13ffd021cf66d35182a156255f https://github.com/WebKit/WebKit/commit/6461ef8e6cca4c13ffd021cf66d35182a156255f Author: Carlos Garcia Campos Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.h M Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp M Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp Log Message: --- [WPE] Create the WebPageProxy after initializing activity state flags https://bugs.webkit.org/show_bug.cgi?id=276062 Reviewed by Nikolas Zimmermann. WebPageProxy queries the page client in the constructor to initialize the activity flags. If we initialize the WKWPE::View flags before creating the page we save an IPC message. * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::View::View): (WKWPE::View::createWebPage): * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: * Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.cpp: (WKWPE::ViewLegacy::ViewLegacy): * Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp: (WKWPE::ViewPlatform::ViewPlatform): * Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp: (WebKit::WebPreferences::platformInitializeStore): Canonical link: https://commits.webkit.org/280567@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8104e1: [WPE] WKWPE::View is refcounted
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8104e1d037fe1ef5d6824f8d893b5df6c2691452 https://github.com/WebKit/WebKit/commit/8104e1d037fe1ef5d6824f8d893b5df6c2691452 Author: Carlos Garcia Campos Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M Source/WebKit/UIProcess/API/C/wpe/WKView.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.h M Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h M Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp M Tools/WebKitTestRunner/libwpe/PlatformWebViewClient.h Log Message: --- [WPE] WKWPE::View is refcounted https://bugs.webkit.org/show_bug.cgi?id=276059 Reviewed by Michael Catanzaro. Create methods are returning a pointer, GLib API is using std::unique_ptr and WKTR and API tests are leaking the view. * Source/WebKit/UIProcess/API/C/wpe/WKView.cpp: (WKViewCreate): (WKViewCreateDeprecated): * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewCreatePage): * Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.h: * Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h: * Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp: (TestWebKitAPI::PlatformWebView::~PlatformWebView): * Tools/WebKitTestRunner/libwpe/PlatformWebViewClient.h: (WTR::PlatformWebViewClient::~PlatformWebViewClient): Canonical link: https://commits.webkit.org/280568@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6b394a: [WPE] Simplify WKWPE::ViewPlatform constructor
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6b394a6a5842367664e883136bf0e448c6e4fb0e https://github.com/WebKit/WebKit/commit/6b394a6a5842367664e883136bf0e448c6e4fb0e Author: Carlos Garcia Campos Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h Log Message: --- [WPE] Simplify WKWPE::ViewPlatform constructor https://bugs.webkit.org/show_bug.cgi?id=276114 Reviewed by Nikolas Zimmermann. Move signal callback implementations to helper functions to reduce the size of the constructor and improve readability. * Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp: (WKWPE::ViewPlatform::ViewPlatform): (WKWPE::ViewPlatform::activityStateChanged): (WKWPE::ViewPlatform::toplevelStateChanged): (WKWPE::ViewPlatform::handleEvent): * Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h: Canonical link: https://commits.webkit.org/280569@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de96df: [GTK][WPE] Use a common timer to schedule activity...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de96df2a7c26160bb5664d582cb72986ea9e827f https://github.com/WebKit/WebKit/commit/de96df2a7c26160bb5664d582cb72986ea9e827f Author: Carlos Garcia Campos Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/glib/WebPageProxyGLib.cpp Log Message: --- [GTK][WPE] Use a common timer to schedule activity state changes https://bugs.webkit.org/show_bug.cgi?id=276118 Reviewed by Michael Catanzaro. GTK is already using a timer, but we can use existing code in WebPageProxy to schedule activity state changes, and use it also for WPE. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate): (webkitWebViewBaseToplevelWindowIsActiveChanged): (webkitWebViewBaseToplevelWindowStateChanged): (webkitWebViewBaseToplevelWindowMonitorChanged): (webkitWebViewBaseSetToplevelOnScreenWindow): (webkitWebViewBaseMap): (webkitWebViewBaseUnmap): (webkitWebViewBaseSetFocus): (_WebKitWebViewBasePrivate::updateActivityStateTimerFired): Deleted. (webkitWebViewBaseScheduleUpdateActivityState): Deleted. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::activityStateChangeTimer): (WebKit::WebPageProxy::setSuppressVisibilityUpdates): (WebKit::WebPageProxy::activityStateDidChange): (WebKit::WebPageProxy::dispatchActivityStateChange): (WebKit::fullscreenVideoTextRecognitionTimer): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxyInternals.h: * Source/WebKit/UIProcess/glib/WebPageProxyGLib.cpp: (WebKit::WebPageProxy::scheduleActivityStateUpdate): Canonical link: https://commits.webkit.org/280614@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 438011: [WPE] Add support for local inspector when using t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 438011bd9f98e1fbb7df3ae9bb7362e494ec02ac https://github.com/WebKit/WebKit/commit/438011bd9f98e1fbb7df3ae9bb7362e494ec02ac Author: Carlos Garcia Campos Date: 2024-07-05 (Fri, 05 Jul 2024) Changed paths: M Source/WebKit/SourcesWPE.txt M Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h A Source/WebKit/UIProcess/Inspector/wpe/WebInspectorUIProxyWPE.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp M Source/WebKit/WebProcess/Inspector/WebInspectorUI.h M Source/WebKit/WebProcess/Inspector/gtk/WebInspectorUIGtk.cpp M Source/WebKit/WebProcess/Inspector/mac/WebInspectorUIMac.mm M Source/WebKit/WebProcess/Inspector/win/WebInspectorUIWin.cpp A Source/WebKit/WebProcess/Inspector/wpe/WebInspectorUIWPE.cpp M Source/cmake/OptionsWPE.cmake M Tools/MiniBrowser/wpe/main.cpp Log Message: --- [WPE] Add support for local inspector when using the WPE Platform API https://bugs.webkit.org/show_bug.cgi?id=276173 Reviewed by Alejandro G. Castro. * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in: * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::View::~View): * Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp: (webkit_web_view_toggle_inspector): * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp: * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h: (WebKit::WebInspectorUIProxy::platformCanAttach): * Source/WebKit/UIProcess/Inspector/wpe/WebInspectorUIProxyWPE.cpp: Added. (WebKit::inspectorWebsiteDataStore): (WebKit::WebInspectorUIProxy::platformCreateFrontendPage): (WebKit::WebInspectorUIProxy::platformCreateFrontendWindow): (WebKit::WebInspectorUIProxy::platformCloseFrontendPageAndWindow): (WebKit::WebInspectorUIProxy::platformDidCloseForCrash): (WebKit::WebInspectorUIProxy::platformInvalidate): (WebKit::WebInspectorUIProxy::platformResetState): (WebKit::WebInspectorUIProxy::platformBringToFront): (WebKit::WebInspectorUIProxy::platformBringInspectedPageToFront): (WebKit::WebInspectorUIProxy::platformHide): (WebKit::WebInspectorUIProxy::platformIsFront): (WebKit::WebInspectorUIProxy::platformSetForcedAppearance): (WebKit::WebInspectorUIProxy::platformRevealFileExternally): (WebKit::WebInspectorUIProxy::platformInspectedURLChanged): (WebKit::WebInspectorUIProxy::platformShowCertificate): (WebKit::WebInspectorUIProxy::platformSave): (WebKit::WebInspectorUIProxy::platformLoad): (WebKit::WebInspectorUIProxy::platformPickColorFromScreen): (WebKit::WebInspectorUIProxy::platformAttach): (WebKit::WebInspectorUIProxy::platformDetach): (WebKit::WebInspectorUIProxy::platformSetAttachedWindowHeight): (WebKit::WebInspectorUIProxy::platformSetSheetRect): (WebKit::WebInspectorUIProxy::platformStartWindowDrag): (WebKit::WebInspectorUIProxy::inspectorPageURL): (WebKit::WebInspectorUIProxy::inspectorTestPageURL): (WebKit::WebInspectorUIProxy::infoForLocalDebuggable): (WebKit::WebInspectorUIProxy::platformSetAttachedWindowWidth): (WebKit::WebInspectorUIProxy::platformAttachAvailabilityChanged): * Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp: (WebKit::WebInspectorUI::establishConnection): (WebKit::WebInspectorUI::didEstablishConnection): * Source/WebKit/WebProcess/Inspector/WebInspectorUI.h: * Source/WebKit/WebProcess/Inspector/gtk/WebInspectorUIGtk.cpp: (WebKit::WebInspectorUI::didEstablishConnection): * Source/WebKit/WebProcess/Inspector/mac/WebInspectorUIMac.mm: (WebKit::WebInspectorUI::didEstablishConnection): * Source/WebKit/WebProcess/Inspector/win/WebInspectorUIWin.cpp: (WebKit::WebInspectorUI::didEstablishConnection): * Source/WebKit/WebProcess/Inspector/wpe/WebInspectorUIWPE.cpp: Added. (WebKit::WebInspectorUI::didEstablishConnection): (WebKit::WebInspectorUI::canSave): (WebKit::WebInspectorUI::canLoad): (WebKit::WebInspectorUI::canPickColorFromScreen): (WebKit::WebInspectorUI::localizedStringsURL const): * Source/cmake/OptionsWPE.cmake: * Tools/MiniBrowser/wpe/main.cpp: Canonical link: https://commits.webkit.org/280678@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
