[webkit-changes] [WebKit/WebKit] bad02c: CGSHWCaptureWindowList should have CF_RETURNS_RETA...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bad02c77f4bda9b6a582c131924de658eae3d871
  
https://github.com/WebKit/WebKit/commit/bad02c77f4bda9b6a582c131924de658eae3d871
  Author: Ryosuke Niwa 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h

  Log Message:
  ---
  CGSHWCaptureWindowList should have CF_RETURNS_RETAINED
https://bugs.webkit.org/show_bug.cgi?id=290245

Reviewed by Geoffrey Garen.

Annotate CGSHWCaptureWindowList with CF_RETURNS_RETAINED.

* Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:

Canonical link: https://commits.webkit.org/292541@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5cd38a: WebCore::ReadableStream should have a virtual dest...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cd38aa5746a75bd4cf23bd48f2792f0bbe09c34
  
https://github.com/WebKit/WebKit/commit/5cd38aa5746a75bd4cf23bd48f2792f0bbe09c34
  Author: David Kilzer 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Source/WebCore/Modules/streams/ReadableStream.h
M Source/WebCore/Modules/webtransport/WebTransportReceiveStream.h
M Source/WebCore/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations

  Log Message:
  ---
  WebCore::ReadableStream should have a virtual destructor



Reviewed by Ryosuke Niwa.

* Source/WebCore/Modules/streams/ReadableStream.h:
(WebCore::ReadableStream::~ReadableStream):
- Make destructor virtual.
* Source/WebCore/Modules/webtransport/WebTransportReceiveStream.h:
- Mark WebCore::WebTransportReceiveStream as final.
(WebCore::WebTransportReceiveStream::~WebTransportReceiveStream):
- Declare default constructor as final.
* Source/WebCore/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations:
- Update expectations file after fixing the warning.

Canonical link: https://commits.webkit.org/292537@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2baf93: REGRESSION(292533@main): Broke Internal visionOS b...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2baf93c734ac1fa7f17dc2d1a1bdb7f16bcbf934
  
https://github.com/WebKit/WebKit/commit/2baf93c734ac1fa7f17dc2d1a1bdb7f16bcbf934
  Author: Jonathan Bedard 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration+Extras.swift

  Log Message:
  ---
  REGRESSION(292533@main): Broke Internal visionOS builds
https://bugs.webkit.org/show_bug.cgi?id=290252
rdar://147647733

Unreviewed build fix.

* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration+Extras.swift:

Canonical link: https://commits.webkit.org/292538@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dbe847: Use adoptCF and RetainPtr in AXTextMarkerRange::AX...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dbe84791c40f63eff0bb0a12852a515bb40539fd
  
https://github.com/WebKit/WebKit/commit/dbe84791c40f63eff0bb0a12852a515bb40539fd
  Author: Ryosuke Niwa 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Source/WebCore/accessibility/cocoa/AXTextMarkerCocoa.mm

  Log Message:
  ---
  Use adoptCF and RetainPtr in AXTextMarkerRange::AXTextMarkerRange
https://bugs.webkit.org/show_bug.cgi?id=290248

Reviewed by Geoffrey Garen.

Use adoptCf and RetainPtr instead of manually calling CFRelease.

* Source/WebCore/accessibility/cocoa/AXTextMarkerCocoa.mm:
(WebCore::AXTextMarkerRange::AXTextMarkerRange):

Canonical link: https://commits.webkit.org/292540@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8d714c: document.importNode from standards to quirks mode ...

[aproskuryakov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8d714c80eaa3f4ac5e58570a1c638d225e0c3346
  
https://github.com/WebKit/WebKit/commit/8d714c80eaa3f4ac5e58570a1c638d225e0c3346
  Author: Alexey Proskuryakov 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
A LayoutTests/fast/dom/importNode-quirks-class-sharing-expected.txt
A LayoutTests/fast/dom/importNode-quirks-class-sharing.html
M Source/WebCore/dom/Element.cpp

  Log Message:
  ---
  document.importNode from standards to quirks mode document can result in 
broken selector matching
https://bugs.webkit.org/show_bug.cgi?id=289795
rdar://147548958

Reviewed by Ryosuke Niwa.

Avoid sharing ElementData when cloning if one document has case folding 
behavior, and
another doesn't.

* LayoutTests/fast/dom/importNode-quirks-class-sharing-expected.txt: Added.
* LayoutTests/fast/dom/importNode-quirks-class-sharing.html: Added.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::cloneAttributesFromElement):

Canonical link: https://commits.webkit.org/292542@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 190edb: Optimize single-segment Path::fastBoundingRect()

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 190edbac90b933190f5879106a7893020f56e4bb
  
https://github.com/WebKit/WebKit/commit/190edbac90b933190f5879106a7893020f56e4bb
  Author: Simon Fraser 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Source/WebCore/platform/graphics/Path.cpp
M Source/WebCore/platform/graphics/PathSegment.cpp
M Source/WebCore/platform/graphics/PathSegment.h

  Log Message:
  ---
  Optimize single-segment Path::fastBoundingRect()
https://bugs.webkit.org/show_bug.cgi?id=290234
rdar://147623819

Reviewed by Cameron McCormack.

`PathStream::computeFastBoundingRect()` has some overhead we can remove if we 
just have
a single segment; the loop, and the call to `calculateEndPoint()`. So implement 
in
`Path::fastBoundingRect()` in a way that works for single segment paths.

* Source/WebCore/platform/graphics/Path.cpp:
(WebCore::Path::fastBoundingRect const):

Canonical link: https://commits.webkit.org/292543@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 63678c: [GStreamer] WebCodecs tests gardening

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63678cd8f5988b85df83b5298e75b38831d8d6b2
  
https://github.com/WebKit/WebKit/commit/63678cd8f5988b85df83b5298e75b38831d8d6b2
  Author: Philippe Normand 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_av1-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_h264-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp9-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any_av1-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoDecoder-codec-specific.https.any.worker_av1-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoDecoder-codec-specific.https.any_av1-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-drawImage.any-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-drawImage.any.worker-expected.txt

  Log Message:
  ---
  [GStreamer] WebCodecs tests gardening
https://bugs.webkit.org/show_bug.cgi?id=290254

Unreviewed, remove superfluous glib-specific test expectations and update 
expectations for a couple
tests.

* LayoutTests/platform/glib/TestExpectations:
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_av1-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_h264-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp9-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any_av1-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoDecoder-codec-specific.https.any.worker_av1-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoDecoder-codec-specific.https.any_av1-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-drawImage.any-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-drawImage.any.worker-expected.txt:
 Removed.

Canonical link: https://commits.webkit.org/292539@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a4cc57: [JSC] Add MulHigh

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4cc57da7cecacc29d071929c8941b27b906fba2
  
https://github.com/WebKit/WebKit/commit/a4cc57da7cecacc29d071929c8941b27b906fba2
  Author: Yusuke Suzuki 
  Date:   2025-03-21 (Fri, 21 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h
M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h
M Source/JavaScriptCore/assembler/X86Assembler.h
M Source/JavaScriptCore/b3/B3Const32Value.cpp
M Source/JavaScriptCore/b3/B3Const32Value.h
M Source/JavaScriptCore/b3/B3Const64Value.cpp
M Source/JavaScriptCore/b3/B3Const64Value.h
M Source/JavaScriptCore/b3/B3LowerToAir.cpp
M Source/JavaScriptCore/b3/B3Opcode.cpp
M Source/JavaScriptCore/b3/B3Opcode.h
M Source/JavaScriptCore/b3/B3ReduceStrength.cpp
M Source/JavaScriptCore/b3/B3Validate.cpp
M Source/JavaScriptCore/b3/B3Value.cpp
M Source/JavaScriptCore/b3/B3Value.h
M Source/JavaScriptCore/b3/B3ValueInlines.h
M Source/JavaScriptCore/b3/B3ValueKey.cpp
M Source/JavaScriptCore/b3/air/AirInstInlines.h
M Source/JavaScriptCore/b3/air/AirOpcode.opcodes
M Source/JavaScriptCore/b3/testb3.h
M Source/JavaScriptCore/b3/testb3_1.cpp
M Source/JavaScriptCore/b3/testb3_8.cpp

  Log Message:
  ---
  [JSC] Add MulHigh
https://bugs.webkit.org/show_bug.cgi?id=290088
rdar://147473808

Reviewed by Yijia Huang.

This patch adds MulHigh / UMulHigh B3 opcodes, which is extracting upper
extended bits from binary multiplication. (32bit * 32bit = 64bit, and
64bit's upper 32bit). This plays a critical role for Div / Mod's
strength reduction, so we would like to have them in IR explicitly.

* Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::mulHigh32):
(JSC::MacroAssemblerARM64::mulHigh64):
(JSC::MacroAssemblerARM64::uMulHigh32):
(JSC::MacroAssemblerARM64::uMulHigh64):
* Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::x86MulHigh32):
(JSC::MacroAssemblerX86_64::x86MulHigh64):
(JSC::MacroAssemblerX86_64::x86UMulHigh32):
(JSC::MacroAssemblerX86_64::x86UMulHigh64):
* Source/JavaScriptCore/assembler/X86Assembler.h:
(JSC::X86Assembler::mull_r):
(JSC::X86Assembler::mulq_r):
(JSC::X86Assembler::imull_r):
(JSC::X86Assembler::imulq_r):
* Source/JavaScriptCore/b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::mulHighConstant const):
(JSC::B3::Const32Value::uMulHighConstant const):
* Source/JavaScriptCore/b3/B3Const32Value.h:
* Source/JavaScriptCore/b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::mulHighConstant const):
(JSC::B3::Const64Value::uMulHighConstant const):
* Source/JavaScriptCore/b3/B3Const64Value.h:
* Source/JavaScriptCore/b3/B3LowerToAir.cpp:
* Source/JavaScriptCore/b3/B3Opcode.cpp:
(WTF::printInternal):
* Source/JavaScriptCore/b3/B3Opcode.h:
* Source/JavaScriptCore/b3/B3ReduceStrength.cpp:
* Source/JavaScriptCore/b3/B3Validate.cpp:
* Source/JavaScriptCore/b3/B3Value.cpp:
(JSC::B3::Value::mulHighConstant const):
(JSC::B3::Value::uMulHighConstant const):
(JSC::B3::Value::effects const):
(JSC::B3::Value::key const):
(JSC::B3::Value::typeFor):
* Source/JavaScriptCore/b3/B3Value.h:
* Source/JavaScriptCore/b3/B3ValueInlines.h:
* Source/JavaScriptCore/b3/B3ValueKey.cpp:
(JSC::B3::ValueKey::materialize const):
* Source/JavaScriptCore/b3/air/AirInstInlines.h:
(JSC::B3::Air::isX86MulHighHelperValid):
(JSC::B3::Air::isX86MulHigh32Valid):
(JSC::B3::Air::isX86MulHigh64Valid):
(JSC::B3::Air::isX86UMulHigh32Valid):
(JSC::B3::Air::isX86UMulHigh64Valid):
* Source/JavaScriptCore/b3/air/AirOpcode.opcodes:
* Source/JavaScriptCore/b3/testb3.h:
* Source/JavaScriptCore/b3/testb3_1.cpp:
(run):
* Source/JavaScriptCore/b3/testb3_8.cpp:
(testMulHigh64):
(testMulHigh32):
(testUMulHigh64):
(testUMulHigh32):

Canonical link: https://commits.webkit.org/292466@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 245b0d: Skip json-stringify-inspector-check.js.no-llint on...

[Daniel Liu]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 245b0deb16e98f21c89b43b0dcf96411827767f9
  
https://github.com/WebKit/WebKit/commit/245b0deb16e98f21c89b43b0dcf96411827767f9
  Author: Daniel Liu 
  Date:   2025-03-21 (Fri, 21 Mar 2025)

  Changed paths:
M JSTests/stress/json-stringify-inspector-check.js

  Log Message:
  ---
  Skip json-stringify-inspector-check.js.no-llint on all platforms when running 
Debug tests
https://bugs.webkit.org/show_bug.cgi?id=290212
rdar://147529212

Reviewed by Yusuke Suzuki

json-stringify-inspector-check.js will try to allocate >100MB of
executable memory on JIT tiers during Debug runs. We should just
skip this test then.

* JSTests/stress/json-stringify-inspector-check.js

Canonical link: https://commits.webkit.org/292515@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3388ea: Sync `css-tables` from WPT upstream

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3388eabffbdf9dc6b76a132ac46e5d3530023986
  
https://github.com/WebKit/WebKit/commit/3388eabffbdf9dc6b76a132ac46e5d3530023986
  Author: Ahmad Saleem 
  Date:   2025-03-21 (Fri, 21 Mar 2025)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/fixed-layout-2-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/fixed-layout-2.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/percent-height-replaced-in-percent-cell-003-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/percent-height-replaced-in-percent-cell-003.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/percent-height-replaced-in-percent-cell-004-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/percent-height-replaced-in-percent-cell-004.html
M LayoutTests/imported/w3c/web-platform-tests/css/css-tables/w3c-import.log

  Log Message:
  ---
  Sync `css-tables` from WPT upstream

https://bugs.webkit.org/show_bug.cgi?id=290221
rdar://147616971

Reviewed by Tim Nguyen.

Upstream commit: 
https://github.com/web-platform-tests/wpt/commit/24b0a3ae223a95ad7c3f11e42cb74018ad9c3ffe

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/fixed-layout-2-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/fixed-layout-2.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/w3c-import.log:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/percent-height-replaced-in-percent-cell-003-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/percent-height-replaced-in-percent-cell-003.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/percent-height-replaced-in-percent-cell-004-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/percent-height-replaced-in-percent-cell-004.html:

Canonical link: https://commits.webkit.org/292532@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ce733d: Fix outstanding static analyzer warnings in Paymen...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce733dee3b1077d479ee82f8414596aaf9a78ab3
  
https://github.com/WebKit/WebKit/commit/ce733dee3b1077d479ee82f8414596aaf9a78ab3
  Author: Ryosuke Niwa 
  Date:   2025-03-21 (Fri, 21 Mar 2025)

  Changed paths:
M Source/WebCore/Modules/applepay/PaymentSession.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h

  Log Message:
  ---
  Fix outstanding static analyzer warnings in PaymentSession.cpp
https://bugs.webkit.org/show_bug.cgi?id=290239

Reviewed by Alan Baradlay and Geoffrey Garen.

Add Document::protectedLoader and use it in PaymentSession::canCreateSession
to fix the unexpected static analyzer warnings.

* Source/WebCore/Modules/applepay/PaymentSession.cpp:
(WebCore::PaymentSession::canCreateSession):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::protectedLoader const):
* Source/WebCore/dom/Document.h:

Canonical link: https://commits.webkit.org/292531@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b12ed3: [SwiftUI] After using `.scrollTo` on a ScrollPosit...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b12ed39572951123a4b5a99c471e0262e9481001
  
https://github.com/WebKit/WebKit/commit/b12ed39572951123a4b5a99c471e0262e9481001
  Author: Richard Robinson 
  Date:   2025-03-21 (Fri, 21 Mar 2025)

  Changed paths:
M Source/WebKit/_WebKit_SwiftUI/Implementation/WebViewRepresentable.swift

  Log Message:
  ---
  [SwiftUI] After using `.scrollTo` on a ScrollPosition bound to a WebView, 
natural scrolling may stop working and/or get reset
https://bugs.webkit.org/show_bug.cgi?id=290240
rdar://146719277

Reviewed by Aditya Keerthi.

When the `.scrollTo` view modifier was attached to a `WebView`, user-driven 
scrolling would effectively
become non-functional in some cases. This is because when the view 
representable receives an update / gets re-computed,
part of the update logic included checking if there was a ScrollPosition set by 
the API client, and if so, scroll to
that position. Therefore, after user-driven scrolling, the actual scroll 
position would always get reset back to the
API-client specified position since there was nothing to avoid running that 
logic.

The solution to this issue requires two fixes:

1. If the current `ScrollPosition` hasn't changed, this indicates that the API 
client has not used `.scrollTo` again.
Therefore, the webpage should only be scrolled to the `ScrollPosition` position 
only once, and not repeatedly.

2. When a user-driven scroll happens, the `ScrollPosition` binding should have 
its `isPositionedByUser` property set
to `true`, which sets the other properties to `nil`.

By fixing (1), the functional issue is solved. Fixing (2) fixes the correctness 
issue. This PR only addresses (1) for
now, since the fix to (2) is significantly more complex and risky.

Fix (1) by checking if the `ScrollPosition` is equal to the prior one, and if 
so, early return. This works because the
`ScrollPosition` type has a seed value, which gets updated when `scrollTo` is 
called on it, which then changes the value's
identity.

* Source/WebKit/_WebKit_SwiftUI/Implementation/WebViewRepresentable.swift:
(WebViewCoordinator.updateScrollPosition(_:context:)):

Canonical link: https://commits.webkit.org/292534@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8c0057: REGRESSION(292368@main): [GTK3] Broke DOM bindings...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c0057018318f586ac0bf01ff84047623750327f
  
https://github.com/WebKit/WebKit/commit/8c0057018318f586ac0bf01ff84047623750327f
  Author: Philippe Normand 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M 
Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp
M 
Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp

  Log Message:
  ---
  REGRESSION(292368@main): [GTK3] Broke DOM bindings build
https://bugs.webkit.org/show_bug.cgi?id=290111

Unreviewed, fix DOM bindings build by casting CSSStyleProperties to their 
parent class,
CSSStyleDeclaration.

* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:
(webkit_dom_document_create_css_style_declaration):
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp:
(webkit_dom_element_get_style):

Canonical link: https://commits.webkit.org/292535@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3322df: REGRESSION (292396@main): [ Mac OS iOS Debug WK2 ...

[Jay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3322df279575581d87011f253e47ccdecc5efb5c
  
https://github.com/WebKit/WebKit/commit/3322df279575581d87011f253e47ccdecc5efb5c
  Author: Jay Stfleur 
  Date:   2025-03-21 (Fri, 21 Mar 2025)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  REGRESSION (292396@main): [ Mac OS iOS Debug WK2  ] 
http/tests/site-isolation/unload-grandchild-fetch.html is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=290235

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/292529@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7dc730: Fixed table layout should only be triggered when i...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7dc7304c93eb91190d7c4206103213778cc8b578
  
https://github.com/WebKit/WebKit/commit/7dc7304c93eb91190d7c4206103213778cc8b578
  Author: Ahmad Saleem 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/fixed-layout-2-expected.txt
M Source/WebCore/rendering/style/RenderStyleInlines.h

  Log Message:
  ---
  Fixed table layout should only be triggered when inline-size is not auto

https://bugs.webkit.org/show_bug.cgi?id=290247
rdar://problem/147636653

Reviewed by Alan Baradlay.

This patch aligns WebKit with CSSWG Resolution [1]:

[1] https://github.com/w3c/csswg-drafts/issues/10937#issuecomment-2669150397

"Fixed table layout is triggered except when inline-size is auto".

In this patch, we remove `allow-list` we had for different length types
and keep it to just `isAuto()`.`

* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::isFixedTableLayout const):
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/fixed-layout-2-expected.txt:
 Rebaselined

Canonical link: https://commits.webkit.org/292536@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d5ba7a: Address Safer CPP issues in UserActivation.cpp

[Alexsander Borges Damaceno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5ba7a39c0381f15e9340024c7d8301b16f7dae1
  
https://github.com/WebKit/WebKit/commit/d5ba7a39c0381f15e9340024c7d8301b16f7dae1
  Author: Alexsander Damaceno 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/html/UserActivation.cpp

  Log Message:
  ---
  Address Safer CPP issues in UserActivation.cpp
https://bugs.webkit.org/show_bug.cgi?id=289763

Reviewed by Tim Nguyen and Chris Dumez.

Address Safer CPP issues

* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/html/UserActivation.cpp:
(WebCore::UserActivation::hasBeenActive const):
(WebCore::UserActivation::isActive const):

Canonical link: https://commits.webkit.org/292550@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 239436: Fixing SaferCPP warnings in InjectedBundle.cpp

[kmonsen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2394366f6484884f885fb67c76f011821b412a71
  
https://github.com/WebKit/WebKit/commit/2394366f6484884f885fb67c76f011821b412a71
  Author: Kristian Monsen 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h

  Log Message:
  ---
  Fixing SaferCPP warnings in InjectedBundle.cpp
https://bugs.webkit.org/show_bug.cgi?id=290078
rdar://problem/147455928

Reviewed by Chris Dumez.

* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
(WebKit::InjectedBundle::addOriginAccessAllowListEntry):
(WebKit::InjectedBundle::removeOriginAccessAllowListEntry):
(WebKit::InjectedBundle::resetOriginAccessAllowLists):
(WebKit::InjectedBundle::numberOfPages):
(WebKit::InjectedBundle::pageNumberForElementById):
(WebKit::InjectedBundle::pageSizeAndMarginsInPixels):
(WebKit::InjectedBundle::isPageBoxVisible):
(WebKit::InjectedBundle::removeAllWebNotificationPermissions):
(WebKit::InjectedBundle::webNotificationID):
(WebKit::InjectedBundle::liveDocumentURLs):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::protectedNotificationPermissionRequestManager):
* Source/WebKit/WebProcess/WebPage/WebPage.h:

Canonical link: https://commits.webkit.org/292544@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9a9926: [Model] Handle the error case when the model asset...

[Ada Chan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a9926c5768c7e4ad8e879ba0e084972216ba089
  
https://github.com/WebKit/WebKit/commit/9a9926c5768c7e4ad8e879ba0e084972216ba089
  Author: Ada Chan 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M LayoutTests/model-element/model-element-ready-expected.txt
M LayoutTests/model-element/model-element-ready.html
A LayoutTests/model-element/resources/error-case.usdz
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in

  Log Message:
  ---
  [Model] Handle the error case when the model asset cannot be loaded
https://bugs.webkit.org/show_bug.cgi?id=290244
rdar://147635013

Reviewed by Mike Wyrzykowski.

If the model asset cannot be loaded for some reason (e.g. invalid
format), we should reject the ready promise on the model element.

* LayoutTests/model-element/model-element-ready-expected.txt:
* LayoutTests/model-element/model-element-ready.html:
Check ready promise is rejected when the model source points to an
asset that can't be loaded.
* LayoutTests/model-element/resources/error-case.usdz: Added.
A bad usdz example that doesn't have the expected content.
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::toResourceError):
(WebKit::RKModelLoaderUSD::load):
If no entity is loaded, treat this as a failed case.
(WebKit::ModelProcessModelPlayerProxy::didFailLoading):
Notify the web content side about this failed load.
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp:
(WebKit::ModelProcessModelPlayer::didFailLoading):
Notify the client (HTMLModelElement) about the failed load.
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h:
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in:

Canonical link: https://commits.webkit.org/292547@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f7073d: Fix the visionOS debug build after 292533@main

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7073d54a320d4c97e822a37a3f52fce9dce91f2
  
https://github.com/WebKit/WebKit/commit/f7073d54a320d4c97e822a37a3f52fce9dce91f2
  Author: Richard Robinson 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Source/WebKit/UIProcess/API/Swift/WebPage+Configuration.swift

  Log Message:
  ---
  Fix the visionOS debug build after 292533@main
https://bugs.webkit.org/show_bug.cgi?id=290264
rdar://147657648

Reviewed by Jonathan Bedard.

Unreviewed build fix.

* Source/WebKit/UIProcess/API/Swift/WebPage+Configuration.swift:
(Configuration.showsSystemScreenTimeBlockingView):

Canonical link: https://commits.webkit.org/292546@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bef74b: Make parsing SVG transform lists more efficient

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bef74b7519fb97bcf4bc14a23641412ec593b926
  
https://github.com/WebKit/WebKit/commit/bef74b7519fb97bcf4bc14a23641412ec593b926
  Author: Simon Fraser 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Source/WebCore/svg/SVGTransformList.cpp
M Source/WebCore/svg/SVGTransformList.h
M Source/WebCore/svg/SVGTransformable.cpp
M Source/WebCore/svg/SVGTransformable.h

  Log Message:
  ---
  Make parsing SVG transform lists more efficient
https://bugs.webkit.org/show_bug.cgi?id=290192
rdar://147591008

Reviewed by Said Abou-Hallawa.

Content that animates SVG transforms will often keep the same list of transform 
operations, but just
change the values. Currently, `SVGTransformList::parse()` implements this by 
clearing the list and
re-build it, but this involves a lot of object churn: each SVGTransform is 
heap-allocated, and itself
has a heap-allocated SVGMatrix. In addition, `detach()` and `attach()` have 
overhead.

Make this more efficient by re-using the existing SVGTransforms when possible. 
Do this by moving the
list management into `SVGTransformList::parseGeneric()`. Callers of `parse()` 
expect the list to be preserved
between calls, so the `ListReplacement` argument controls that behavior. Pass 
the existing object to
`SVGTransformable::parseTransform` if the type matches; we compare that with 
the return value to know
if the item was re-used. If not, we go back to appending.

Well tested by existing SVG tests.

* Source/WebCore/svg/SVGTransformList.cpp:
(WebCore::SVGTransformList::parseGeneric):
(WebCore::SVGTransformList::parse):
* Source/WebCore/svg/SVGTransformList.h:
* Source/WebCore/svg/SVGTransformable.cpp:
(WebCore::parseTransformGeneric):
(WebCore::SVGTransformable::parseTransform):
(WebCore::parseTransformValueGeneric): Deleted.
(WebCore::SVGTransformable::parseTransformValue): Deleted.
* Source/WebCore/svg/SVGTransformable.h:

Canonical link: https://commits.webkit.org/292545@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c5b7d0: Place WPT test in the right path

[Alexsander Borges Damaceno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5b7d05b6cf367b5993454bc0ae483bf4ccf3aca
  
https://github.com/WebKit/WebKit/commit/c5b7d05b6cf367b5993454bc0ae483bf4ccf3aca
  Author: Alexsander Damaceno 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M LayoutTests/imported/w3c/resources/import-expectations.json
R 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/block-in-inline-client-rects-001-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/block-in-inline-client-rects-001.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/block-in-inline-client-rects-001-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/block-in-inline-client-rects-001.html

  Log Message:
  ---
  Place WPT test in the right path
https://bugs.webkit.org/show_bug.cgi?id=290233

Reviewed by Tim Nguyen.

Fix wrong location for WPT test block-in-inline-client-rects-001.html and 
block-in-inline-client-rects-001-expected.txt that
I imported in wrong path before.

* 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/block-in-inline-client-rects-001-expected.txt:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/block-in-inline-client-rects-001-expected.txt.
* 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/block-in-inline-client-rects-001.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/block-in-inline-client-rects-001.html.
* LayoutTests/imported/w3c/resources/import-expectations.json:

Canonical link: https://commits.webkit.org/292552@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c12c37: update-safer-cpp-expectations doesn't recognize Fo...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c12c3721e055913285067dd8a847642cdff1bc3c
  
https://github.com/WebKit/WebKit/commit/c12c3721e055913285067dd8a847642cdff1bc3c
  Author: Ryosuke Niwa 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Tools/Scripts/update-safer-cpp-expectations

  Log Message:
  ---
  update-safer-cpp-expectations doesn't recognize ForwardDeclChecker and other 
recently added checkers
https://bugs.webkit.org/show_bug.cgi?id=290267

Reviewed by Chris Dumez.

Added the support for updating expectations for recently introduced RetainPtr 
checkers.

* Tools/Scripts/update-safer-cpp-expectations:

Canonical link: https://commits.webkit.org/292548@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7d7136: REGRESSION(284680@main): Buy and Learn More button...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d71367759047d95e2b5009fef521730d209dfbb
  
https://github.com/WebKit/WebKit/commit/7d71367759047d95e2b5009fef521730d209dfbb
  Author: Alan Baradlay 
  Date:   2025-03-20 (Thu, 20 Mar 2025)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/container-queries/nested-query-containers-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/tentative/baseline-td-expected.txt
M LayoutTests/platform/ios/fast/multicol/table-vertical-align-expected.txt
M LayoutTests/platform/ios/fast/table/vertical-align-baseline-expected.txt
M LayoutTests/platform/ios/tables/mozilla/bugs/bug10296-1-expected.txt
M 
LayoutTests/platform/ios/tables/mozilla/marvin/tbody_valign_baseline-expected.txt
M 
LayoutTests/platform/ios/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt
M 
LayoutTests/platform/ios/tables/mozilla/marvin/thead_valign_baseline-expected.txt
M 
LayoutTests/platform/ios/tables/mozilla/marvin/tr_valign_baseline-expected.txt
M 
LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
M LayoutTests/platform/mac/fast/multicol/table-vertical-align-expected.txt
M LayoutTests/platform/mac/fast/table/vertical-align-baseline-expected.txt
M LayoutTests/platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt
M 
LayoutTests/platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.txt
M 
LayoutTests/platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt
M 
LayoutTests/platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.txt
M 
LayoutTests/platform/mac/tables/mozilla/marvin/tr_valign_baseline-expected.txt
M 
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
M Source/WebCore/rendering/RenderTableSection.cpp

  Log Message:
  ---
  REGRESSION(284680@main): Buy and Learn More buttons overlap iPhone 16e image 
on iCloud.com
https://bugs.webkit.org/show_bug.cgi?id=290101


Unreviewed revert.

Canonical link: https://commits.webkit.org/292452@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 409c93: [JSC] Remove remaining hard coded test loop count ...

[SUZUKI Sosuke]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 409c9304985790d3e024131fadd7841c6fa95706
  
https://github.com/WebKit/WebKit/commit/409c9304985790d3e024131fadd7841c6fa95706
  Author: Sosuke Suzuki 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M JSTests/stress/iterator-open-throw-for-non-objects.js
M JSTests/stress/number-prototype-to-string-dfg-bad-this-value-radix-10.js
M 
JSTests/stress/number-prototype-to-string-dfg-bad-this-value-radix-absent.js
M JSTests/stress/putDirectWithReify-JSFinalObject.js
M JSTests/stress/regexp-exec-consistent-error-message.js
M JSTests/stress/regexp-split-side-effects-via-hasIndices-and-dotAll.js
M JSTests/stress/string-prototype-at.js

  Log Message:
  ---
  [JSC] Remove remaining hard coded test loop count for JSTests/stress
https://bugs.webkit.org/show_bug.cgi?id=290255

Reviewed by Yusuke Suzuki.

https://commits.webkit.org/289981@main introduced `testLoopCount` for JS
tests. But loop counts written as `runs = value` are remaining.

This patch fixes it.

* JSTests/stress/iterator-open-throw-for-non-objects.js:
* JSTests/stress/number-prototype-to-string-dfg-bad-this-value-radix-10.js:
* JSTests/stress/number-prototype-to-string-dfg-bad-this-value-radix-absent.js:
* JSTests/stress/putDirectWithReify-JSFinalObject.js:
* JSTests/stress/regexp-exec-consistent-error-message.js:
(test):
* JSTests/stress/regexp-split-side-effects-via-hasIndices-and-dotAll.js:
* JSTests/stress/string-prototype-at.js:
(test):

Canonical link: https://commits.webkit.org/292553@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 846126: [JSC] `DEFINE_VISIT_AGGREGATE` for `StringReplacea...

[SUZUKI Sosuke]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8461269197eb8ce483a1800b7ee0e51c5db78b02
  
https://github.com/WebKit/WebKit/commit/8461269197eb8ce483a1800b7ee0e51c5db78b02
  Author: Sosuke Suzuki 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/JavaScriptCore/Sources.txt
A Source/JavaScriptCore/runtime/StringReplaceCache.cpp
M Source/JavaScriptCore/runtime/StringReplaceCacheInlines.h

  Log Message:
  ---
  [JSC] `DEFINE_VISIT_AGGREGATE` for `StringReplaceaCache` should be used in 
source file
https://bugs.webkit.org/show_bug.cgi?id=290251

Reviewed by Yusuke Suzuki.

`DEFINE_VISIT_AGGREGATE` defines not-ininlined functions[1], so it should be 
used in source file.
However, it is used in `StringReplaceCacheInlines.h`. This patch fixes it.

[1]: 
https://github.com/WebKit/WebKit/blob/b12ed39572951123a4b5a99c471e0262e9481001/Source/JavaScriptCore/heap/SlotVisitorMacros.h#L54-L60

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/runtime/StringReplaceCache.cpp: Added.
(JSC::StringReplaceCache::visitAggregateImpl):
* Source/JavaScriptCore/runtime/StringReplaceCacheInlines.h:
(JSC::StringReplaceCache::visitAggregateImpl): Deleted.

Canonical link: https://commits.webkit.org/292554@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bdf66e: Math.hypot() is significantly slower than Math.sqrt()

[Keita Nonaka]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bdf66e673c2cd00105ced79e319cb12b8ba6b373
  
https://github.com/WebKit/WebKit/commit/bdf66e673c2cd00105ced79e319cb12b8ba6b373
  Author: Keita Nonaka 
  Date:   2025-03-22 (Sat, 22 Mar 2025)

  Changed paths:
A JSTests/microbenchmarks/math-hypot.js
A JSTests/microbenchmarks/math-sqrt.js
M Source/JavaScriptCore/runtime/MathObject.cpp

  Log Message:
  ---
  Math.hypot() is significantly slower than Math.sqrt()
https://bugs.webkit.org/show_bug.cgi?id=284631

Reviewed by Yusuke Suzuki.

optimized `Math.hypot()` for cases with 1, 2 or 3 arguments

* JSTests/microbenchmarks/math-hypot.js: Added.
(hypot):
* Source/JavaScriptCore/runtime/MathObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):

Canonical link: https://commits.webkit.org/292549@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes