[webkit-changes] [WebKit/WebKit] 332bf4: [WebGPU] idl constants should be namespace constan...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 332bf421e29d24986a9643cb4c337e910c26c22a https://github.com/WebKit/WebKit/commit/332bf421e29d24986a9643cb4c337e910c26c22a Author: Mike Wyrzykowski Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/Modules/WebGPU/GPUBufferUsage.idl M Source/WebCore/Modules/WebGPU/GPUColorWrite.idl M Source/WebCore/Modules/WebGPU/GPUMapMode.idl M Source/WebCore/Modules/WebGPU/GPUShaderStage.idl M Source/WebCore/Modules/WebGPU/GPUTextureUsage.idl Log Message: --- [WebGPU] idl constants should be namespace constants, not an interface with constant values https://bugs.webkit.org/show_bug.cgi?id=289222 rdar://146361873 Reviewed by Cameron McCormack. Specification says these should be namespace constants, not interface constants. WebKit added support for namespace constants ~3 years ago, but some of these files predated such support. * Source/WebCore/Modules/WebGPU/GPUBufferUsage.idl: * Source/WebCore/Modules/WebGPU/GPUColorWrite.idl: * Source/WebCore/Modules/WebGPU/GPUMapMode.idl: * Source/WebCore/Modules/WebGPU/GPUShaderStage.idl: * Source/WebCore/Modules/WebGPU/GPUTextureUsage.idl: Canonical link: https://commits.webkit.org/291687@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bdb7d3: [WPE] WPEPlatform: Use a ListHashSet instead of Ha...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bdb7d361e569bedeaa010442dcb4abd5c10d30ae https://github.com/WebKit/WebKit/commit/bdb7d361e569bedeaa010442dcb4abd5c10d30ae Author: Carlos Garcia Campos Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/WPEPlatform/wpe/WPEToplevel.cpp Log Message: --- [WPE] WPEPlatform: Use a ListHashSet instead of HashSet for the WPEToplevel views https://bugs.webkit.org/show_bug.cgi?id=289161 Reviewed by Alejandro G. Castro. That way we ensure wpe_toplevel_foreach_view() always iterates the views in the same order. * Source/WebKit/WPEPlatform/wpe/WPEToplevel.cpp: Canonical link: https://commits.webkit.org/291686@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 834e98: [iOS] The selection highlight boxes mess up when t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 834e9831da4db3819ec6547aaba1f98b5bd89a32 https://github.com/WebKit/WebKit/commit/834e9831da4db3819ec6547aaba1f98b5bd89a32 Author: Cathie Chen Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: A LayoutTests/editing/selection/ios/select-content-from-different-flow-001-expected.txt A LayoutTests/editing/selection/ios/select-content-from-different-flow-001.html A LayoutTests/editing/selection/ios/select-content-from-different-flow-002-expected.txt A LayoutTests/editing/selection/ios/select-content-from-different-flow-002.html A LayoutTests/editing/selection/ios/select-content-from-different-flow-003-expected.txt A LayoutTests/editing/selection/ios/select-content-from-different-flow-003.html A LayoutTests/editing/selection/ios/select-content-from-different-flow-004-expected.txt A LayoutTests/editing/selection/ios/select-content-from-different-flow-004.html A LayoutTests/editing/selection/ios/select-content-from-different-flow-005-expected.txt A LayoutTests/editing/selection/ios/select-content-from-different-flow-005.html M Source/WebCore/platform/ios/SelectionGeometry.h M Source/WebCore/rendering/RenderObject.cpp Log Message: --- [iOS] The selection highlight boxes mess up when the content switch between inflow and out-of-flow https://bugs.webkit.org/show_bug.cgi?id=269723 Reviewed by Wenson Hsieh. In iOS, the selection highlight boxes are coalesced. But if the selected content switch between inflow and out-of-flow, for instance, the content contains text with positioned ancestor and text from inflow, the combined box could include unexpected area. To fix this issue, we stop coalescing the highlight boxes of out-of-flow positioned content to others. * LayoutTests/editing/selection/ios/select-content-from-different-flow-001-expected.txt: Added. * LayoutTests/editing/selection/ios/select-content-from-different-flow-001.html: Added. * LayoutTests/editing/selection/ios/select-content-from-different-flow-002-expected.txt: Added. * LayoutTests/editing/selection/ios/select-content-from-different-flow-002.html: Added. * LayoutTests/editing/selection/ios/select-content-from-different-flow-003-expected.txt: Added. * LayoutTests/editing/selection/ios/select-content-from-different-flow-003.html: Added. * LayoutTests/editing/selection/ios/select-content-from-different-flow-004-expected.txt: Added. * LayoutTests/editing/selection/ios/select-content-from-different-flow-004.html: Added. * LayoutTests/editing/selection/ios/select-content-from-different-flow-005-expected.txt: Added. * LayoutTests/editing/selection/ios/select-content-from-different-flow-005.html: Added. * Source/WebCore/platform/ios/SelectionGeometry.h: (WebCore::SelectionGeometry::separateFromPreviousLine const): Return true if geometry requires to separate lines. (WebCore::SelectionGeometry::setSeparateFromPreviousLine): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::currentNodeRequiresToSeparateLines): Return true if current node is out-of-flow positioned. (WebCore::hasAncestorRequiresToSeparateLines): Check if the node has an out-of-flow ancestor within the stayWithin subtree. (WebCore::previousNodeRequiresToSeparateLines): (WebCore::RenderObject::collectSelectionGeometriesInternal): Distinguish if current renderer and previous renderer have switched between inflow and out-of-flow. If current renderer is positioned, or if the previous renderer has a positioned ancestor, then they are in different flows. Do not coalesce lines that are not in same flow. Canonical link: https://commits.webkit.org/291696@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 747826: [GStreamer] Add support for allowed output caps hi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7478268ef2e01a7eb7aee7d2579c190a3065a559 https://github.com/WebKit/WebKit/commit/7478268ef2e01a7eb7aee7d2579c190a3065a559 Author: Philippe Normand Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp M Source/WebCore/platform/gstreamer/GStreamerElementHarness.h M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstElementHarness.cpp Log Message: --- [GStreamer] Add support for allowed output caps hints in ElementHarness https://bugs.webkit.org/show_bug.cgi?id=288914 Reviewed by Xabier Rodriguez-Calvar. Instead of accepting ANY caps on its output pad, a Stream created by the harness can now provide hints for the caps negotiation. This will be useful for hardware video decoding support in our WebCodec backend. Driving-by, also require from the video decoder to attach video metas to its output buffers. This is a requirement for hardware video decoding (for vaapi decoders at least). * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: (WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder): * Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp: (WebCore::GStreamerElementHarness::GStreamerElementHarness): (WebCore::GStreamerElementHarness::Stream::Stream): * Source/WebCore/platform/gstreamer/GStreamerElementHarness.h: (WebCore::GStreamerElementHarness::Stream::create): (WebCore::GStreamerElementHarness::create): * Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstElementHarness.cpp: (TestWebKitAPI::TEST_F(GStreamerTest, harnessCustomCaps)): Canonical link: https://commits.webkit.org/291698@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c30953: [WPE][GTK] Propagate the font's computed locale to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c30953f1f00cf190463b4f21b0d9f1fef76b0591 https://github.com/WebKit/WebKit/commit/c30953f1f00cf190463b4f21b0d9f1fef76b0591 Author: Mirko Brodesser Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/lang-attribute-affects-rendering-of-second-text-run-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/lang-attribute-affects-rendering-of-second-text-run-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/lang-attribute-affects-rendering-of-second-text-run.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations M Source/WebCore/platform/graphics/skia/ComplexTextControllerSkia.cpp Log Message: --- [WPE][GTK] Propagate the font's computed locale to HarfBuzz https://bugs.webkit.org/show_bug.cgi?id=287629 Reviewed by Carlos Garcia Campos. GTK and WPE use HarfBuzz and the language wasn't propagated to it. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/lang-attribute-affects-rendering-of-second-text-run-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/lang-attribute-affects-rendering-of-second-text-run-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/lang-attribute-affects-rendering-of-second-text-run.html: Added. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/platform/graphics/skia/ComplexTextControllerSkia.cpp: (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Canonical link: https://commits.webkit.org/291691@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c07526: [GStreamer] Simplify ifdefs in buildDMABufCaps()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c075260247d527fea5c4b4e83e6f948c4c2e7653 https://github.com/WebKit/WebKit/commit/c075260247d527fea5c4b4e83e6f948c4c2e7653 Author: Philippe Normand Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp Log Message: --- [GStreamer] Simplify ifdefs in buildDMABufCaps() https://bugs.webkit.org/show_bug.cgi?id=289233 Reviewed by Carlos Garcia Campos. The whole function is already ifdeffed with USE(GBM) so checking it again in the function body is useless. * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::buildDMABufCaps): Canonical link: https://commits.webkit.org/291692@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dfb39d: [GStreamer][WebRTC] Move GCC bandwidth estimator c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dfb39d60eac51e37502de5a604127f78e50bfb49 https://github.com/WebKit/WebKit/commit/dfb39d60eac51e37502de5a604127f78e50bfb49 Author: Philippe Normand Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp Log Message: --- [GStreamer][WebRTC] Move GCC bandwidth estimator closer to transport elements https://bugs.webkit.org/show_bug.cgi?id=289156 Reviewed by Xabier Rodriguez-Calvar. By placing the estimator after rtpsession the estimator won't be burdened by its synchronization requirements. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::initializePipeline): Canonical link: https://commits.webkit.org/291697@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a8f22: Heap allocate TextOnlySimpleLineBuilder and RangeB...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a8f22846055c809de62d7fea99a9b11b9acd783 https://github.com/WebKit/WebKit/commit/6a8f22846055c809de62d7fea99a9b11b9acd783 Author: Antti Koivisto Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/RangeBasedLineBuilder.h M Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.h Log Message: --- Heap allocate TextOnlySimpleLineBuilder and RangeBasedLineBuilder https://bugs.webkit.org/show_bug.cgi?id=289236 rdar://146067168 Reviewed by Alan Baradlay. Nested inline blocks can result in deep recursion in extreme cases. Reduce stack usage on the recursion path. * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::layout): Heap allocate all LineBuilders. This reduces stack usage of this function from ~6KB to 600B. * Source/WebCore/layout/formattingContexts/inline/RangeBasedLineBuilder.h: * Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.h: Canonical link: https://commits.webkit.org/291694@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c9b00: Address Safer CPP warnings in HTMLDialogElement.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c9b009a367989e7cb150d128bd9b5f70bb46abd https://github.com/WebKit/WebKit/commit/6c9b009a367989e7cb150d128bd9b5f70bb46abd Author: Tim Nguyen Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations M Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations M Source/WebCore/html/HTMLDialogElement.cpp Log Message: --- Address Safer CPP warnings in HTMLDialogElement.cpp https://bugs.webkit.org/show_bug.cgi?id=289224 rdar://146363685 Reviewed by Ryosuke Niwa. * Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations: * Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations: * Source/WebCore/html/HTMLDialogElement.cpp: (WebCore::HTMLDialogElement::show): (WebCore::HTMLDialogElement::showModal): (WebCore::HTMLDialogElement::queueCancelTask): (WebCore::HTMLDialogElement::runFocusingSteps): (WebCore::HTMLDialogElement::queueDialogToggleEventTask): Canonical link: https://commits.webkit.org/291693@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c0c100: Unreviewed, unskip DocumentInlines.h on the Safer ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0c100ffc59b7eca29535ea5b64394350dd7a306 https://github.com/WebKit/WebKit/commit/c0c100ffc59b7eca29535ea5b64394350dd7a306 Author: Chris Dumez Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations Log Message: --- Unreviewed, unskip DocumentInlines.h on the Safer CPP bot now that it is passing https://bugs.webkit.org/show_bug.cgi?id=289248 * Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: Canonical link: https://commits.webkit.org/291700@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cff04f: [WebGPU] Make descriptor count / pointer initializ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cff04f81eb10bd7f7b8fad6204252122612c94e6 https://github.com/WebKit/WebKit/commit/cff04f81eb10bd7f7b8fad6204252122612c94e6 Author: Cameron McCormack Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/Modules/WebGPU/Implementation/WebGPUAdapterImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp M Source/WebGPU/WebGPU/PipelineLayout.mm M Source/WebGPU/WebGPU/RenderBundle.h M Source/WebGPU/WebGPU/RenderBundle.mm M Source/WebGPU/WebGPU/RenderBundleEncoder.h M Source/WebGPU/WebGPU/RenderBundleEncoder.mm Log Message: --- [WebGPU] Make descriptor count / pointer initialization more consistent rdar://146352901 https://bugs.webkit.org/show_bug.cgi?id=289215 Reviewed by Mike Wyrzykowski. In a number of the descriptor structs in WebGPU.h (and a couple of our own descriptor structs), lists of objects are described with a count variable and a pointer. We are not consistent about how we initialize these. 1. In https://bugs.webkit.org/show_bug.cgi?id=261511 we updated the WebGPU.h API header, and that updated the count member variables to be size_t. Adjust call sites so we no longer static_cast any counts down to uint32_t. 2. We sometimes look at whether the span or vector we're initializing from is empty, and if so store nullptr, and in other cases store whatever is returned from span::data() / Vector::data(). Always check and use nullptr when we're initializing from an empty list. 3. The RenderBundle and RenderBundleEncoder constructors initialize their m_descriptor members by copying the descriptor object passed in. This uses a copy constructor, and so causes the object to begin with a pointer to data held elsewhere. In the constructor body, we overwrite the pointer, but only if the size is non-zero. Change this to initialize to nullptr of the size is zero, so we don't keep around a stale pointer to someone else's memory (even if we wouldn't currently use it). 4. While here, make the Vector member variables on RenderBundle and RenderBundleEncoder that we keep a pointer into const, to make it less likely we modify it. (Another option would be to use a fixed allocation that cannot be modified, like UniqueArray, but UniqueArray does not have all the nice API that Vector has, nor its bounds checking operator[].) 5. Device::createPipelineLayout checks that descriptor.bindGroupLayoutsSpan() has a non-null based pointer, but semantically we want to check if the span is empty. If we have a span formed by a non-null base pointer and a zero count, we'd still proceed to create optionalBindGroupLayouts, which is wasteful. Change this to check the span's emptiness. * Source/WebCore/Modules/WebGPU/Implementation/WebGPUAdapterImpl.cpp: (WebCore::WebGPU::AdapterImpl::requestDevice): * Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp: (WebCore::WebGPU::CommandEncoderImpl::beginRenderPass): * Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp: (WebCore::WebGPU::DeviceImpl::createTexture): (WebCore::WebGPU::DeviceImpl::createBindGroupLayout): (WebCore::WebGPU::DeviceImpl::createPipelineLayout): (WebCore::WebGPU::DeviceImpl::createBindGroup): (WebCore::WebGPU::DeviceImpl::createShaderModule): (WebCore::WebGPU::convertToBacking): (WebCore::WebGPU::DeviceImpl::createRenderBundleEncoder): * Source/WebGPU/WebGPU/PipelineLayout.mm: (WebGPU::Device::createPipelineLayout): * Source/WebGPU/WebGPU/RenderBundle.h: * Source/WebGPU/WebGPU/RenderBundle.mm: (WebGPU::RenderBundle::RenderBundle): * Source/WebGPU/WebGPU/RenderBundleEncoder.h: * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: Canonical link: https://commits.webkit.org/291688@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a56817: [Gardening] [ macOS wk2 arm64 ] 2 imported/w3c/web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a568178efdb68748fbcc5f691c3d03be646d5ef3 https://github.com/WebKit/WebKit/commit/a568178efdb68748fbcc5f691c3d03be646d5ef3 Author: Yasmin Karimi Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening] [ macOS wk2 arm64 ] 2 imported/w3c/web-platform-tests/editing/other/delete-in-child-of-head.tentative.html?designMode=on&method=* are flaky failures. https://bugs.webkit.org/show_bug.cgi?id=289272 rdar://146409528 Unreviewed test gardening. Added test expectations for 2 flakily failing tests. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/291721@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 86bdb2: Cherry-pick 291711@main (da44fa7432e2). https://bu...
Branch: refs/heads/webkitglib/2.46 Home: https://github.com/WebKit/WebKit Commit: 86bdb2b0d7037d178b8a5fd4cb8748accd12d240 https://github.com/WebKit/WebKit/commit/86bdb2b0d7037d178b8a5fd4cb8748accd12d240 Author: Alicia Boya Garcia Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp Log Message: --- Cherry-pick 291711@main (da44fa7432e2). https://bugs.webkit.org/show_bug.cgi?id=289245 [GStreamer][Release] registerTrackId(): alternative IDs discarded https://bugs.webkit.org/show_bug.cgi?id=289245 Reviewed by Philippe Normand. Move side effects away from the assert so that they don't get removed in release builds. * Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp: (WebCore::MediaSourcePrivateGStreamer::registerTrackId): Canonical link: https://commits.webkit.org/291711@main Canonical link: https://commits.webkit.org/282416.470@webkitglib/2.46 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 257f42: Cherry-pick 291711@main (da44fa7432e2). https://bu...
Branch: refs/heads/webkitglib/2.48 Home: https://github.com/WebKit/WebKit Commit: 257f420e1ca60c4e5b4f3dde71f7e7c99f4d74ce https://github.com/WebKit/WebKit/commit/257f420e1ca60c4e5b4f3dde71f7e7c99f4d74ce Author: Alicia Boya Garcia Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp Log Message: --- Cherry-pick 291711@main (da44fa7432e2). https://bugs.webkit.org/show_bug.cgi?id=289245 [GStreamer][Release] registerTrackId(): alternative IDs discarded https://bugs.webkit.org/show_bug.cgi?id=289245 Reviewed by Philippe Normand. Move side effects away from the assert so that they don't get removed in release builds. * Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp: (WebCore::MediaSourcePrivateGStreamer::registerTrackId): Canonical link: https://commits.webkit.org/291711@main Canonical link: https://commits.webkit.org/290945.36@webkitglib/2.48 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e57d90: [GStreamer] Restore USE_GSTREAMER_GL build option
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e57d90ee7ddbd16c8d37534f5a57b368ed246f74 https://github.com/WebKit/WebKit/commit/e57d90ee7ddbd16c8d37534f5a57b368ed246f74 Author: Simon Pena Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/platform/GStreamer.cmake M Source/WebCore/platform/graphics/PlatformDisplay.cpp M Source/WebCore/platform/graphics/PlatformDisplay.h M Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.h M Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h M Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameConverter.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameConverter.h M Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h M Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferVideo.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferVideo.h M Source/cmake/GStreamerChecks.cmake M Source/cmake/GStreamerDefinitions.cmake M Source/cmake/GStreamerDependencies.cmake M Tools/Scripts/webkitperl/FeatureList.pm Log Message: --- [GStreamer] Restore USE_GSTREAMER_GL build option https://bugs.webkit.org/show_bug.cgi?id=289231 Reviewed by Carlos Garcia Campos. Some downstream ports are still unable to use GSTREAMER_GL. This addresses it by reverting 282892@main, as well as guarding the relevant new code that landed in the time the feature was gone. * Source/WebCore/platform/GStreamer.cmake: * Source/WebCore/platform/graphics/PlatformDisplay.cpp: (WebCore::PlatformDisplay::clearSharingGLContext): (WebCore::PlatformDisplay::terminateEGLDisplay): * Source/WebCore/platform/graphics/PlatformDisplay.h: * Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp: * Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.h: * Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp: * Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h: * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::registerWebKitGStreamerElements): (WebCore::deinitializeGStreamer): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h: * Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameConverter.cpp: (WebCore::GStreamerVideoFrameConverter::Pipeline::Pipeline): (WebCore::GStreamerVideoFrameConverter::Pipeline::run): (WebCore::GStreamerVideoFrameConverter::ensurePipeline): * Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameConverter.h: * Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp: (WebKitVideoSinkProbe::doProbe): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::tearDown): (WebCore::MediaPlayerPrivateGStreamer::createVideoSink): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp: * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferVideo.cpp: (WebCore::CoordinatedPlatformLayerBufferVideo::createBufferIfNeeded): (WebCore::CoordinatedPlatformLayerBufferVideo::paintToTextureMapper): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferVideo.h: * Source/cmake/GStreamerChecks.cmake: * Source/cmake/GStreamerDefinitions.cmake: * Source/cmake/GStreamerDependencies.cmake: * Tools/Scripts/webkitperl/FeatureList.pm: Canonical link: https://commits.webkit.org/291707@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 30eb04: Make `Vector::operator==` work correctly with padd...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 30eb04f14b597dea982fdc352f4d4c70fca5d22e https://github.com/WebKit/WebKit/commit/30eb04f14b597dea982fdc352f4d4c70fca5d22e Author: Chris Dumez Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WTF/wtf/VectorTraits.h M Source/WebCore/css/CSSKeyframesRule.cpp Log Message: --- Make `Vector::operator==` work correctly with padded structs https://bugs.webkit.org/show_bug.cgi?id=287554 rdar://144700872 Reviewed by Geoffrey Garen. VectorTraits::canCompareWithMemcmp is used to determine whether or not Vector can be used to compare 2 vectors. It was initialized using: - `std::is_standard_layout_v && std::is_trivial_v` However, this led to incorrect results on some platforms when using padded structures. To detect padded structures, we are now adding `std::has_unique_object_representations_v` to this check. This is what is used already for the assertion inside equalSpans(), before calling `memcmp()`. Per the documentation [1], has_unique_object_representations_v would return false for padded structs. [1] https://en.cppreference.com/w/cpp/types/has_unique_object_representations * Source/WTF/wtf/VectorTraits.h: * Source/WebCore/css/CSSKeyframesRule.cpp: (WebCore::StyleRuleKeyframes::findKeyframeIndex const): Canonical link: https://commits.webkit.org/291724@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 86f8e0: [Gardening] [ macOS wk2 arm64 ] 4 imported/w3c/web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86f8e03e8318acd67b7bd82abf9e469eb5bb6bb8 https://github.com/WebKit/WebKit/commit/86f8e03e8318acd67b7bd82abf9e469eb5bb6bb8 Author: Yasmin Karimi Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations A LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=off&white-space=normal-expected.png A LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=off&white-space=pre-expected.png A LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=off&white-space=pre-line-expected.png A LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=off&white-space=pre-wrap-expected.png A LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=on&white-space=normal-expected.png A LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=on&white-space=pre-expected.png A LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=on&white-space=pre-line-expected.png A LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=on&white-space=pre-wrap-expected.png Log Message: --- [Gardening] [ macOS wk2 arm64 ] 4 imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative.html?designMode=on&white-space=* are flaky failures. https://bugs.webkit.org/show_bug.cgi?id=289276 rdar://146417879 Unreviewed test gardening. Added test expectations for four flakily failing tests. * LayoutTests/platform/mac-wk2/TestExpectations: * LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=off&white-space=normal-expected.png: Added. * LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=off&white-space=pre-expected.png: Added. * LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=off&white-space=pre-line-expected.png: Added. * LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=off&white-space=pre-wrap-expected.png: Added. * LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=on&white-space=normal-expected.png: Added. * LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=on&white-space=pre-expected.png: Added. * LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=on&white-space=pre-line-expected.png: Added. * LayoutTests/platform/mac/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-child-of-head.tentative_designMode=on&white-space=pre-wrap-expected.png: Added. Canonical link: https://commits.webkit.org/291728@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c77364: [JSC] Fix cached call debug assertion in WeakMapPr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c773644264617781ccd1cc2f2e463a3eaa8d09d2 https://github.com/WebKit/WebKit/commit/c773644264617781ccd1cc2f2e463a3eaa8d09d2 Author: Max Rottenkolber Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/JavaScriptCore/runtime/WeakMapPrototype.cpp Log Message: --- [JSC] Fix cached call debug assertion in WeakMapPrototype https://bugs.webkit.org/show_bug.cgi?id=289079 Reviewed by Yusuke Suzuki, Sosuke Suzuki, and Justin Michaud. CachedCall is instantiated with the wrong number of parameters in protoFuncWeakMapGetOrInsertComputed. Fix it. * Source/JavaScriptCore/runtime/WeakMapPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Canonical link: https://commits.webkit.org/291729@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2d7a06: Crash under WebPageProxy::navigationGestureDidEnd()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2d7a0627e1cc827f36c31fae529943317b7f https://github.com/WebKit/WebKit/commit/2d7a0627e1cc827f36c31fae529943317b7f Author: Chris Dumez Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Crash under WebPageProxy::navigationGestureDidEnd() https://bugs.webkit.org/show_bug.cgi?id=289255 rdar://144866140 Reviewed by Charlie Wolfe. Make sure we null check the pageClient before dereferencing it. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::navigationGestureDidBegin): (WebKit::WebPageProxy::navigationGestureWillEnd): (WebKit::WebPageProxy::navigationGestureDidEnd): (WebKit::WebPageProxy::willRecordNavigationSnapshot): Canonical link: https://commits.webkit.org/291731@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 111c66: [Gardening] REGRESSION(Sequoia): [ macOS Sequoia x...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 111c66cf4f171536531b09ef72f845c2d600697d https://github.com/WebKit/WebKit/commit/111c66cf4f171536531b09ef72f845c2d600697d Author: Yasmin Karimi Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening] REGRESSION(Sequoia): [ macOS Sequoia x86_64 ] imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-after-snap.html is a constant failure. https://bugs.webkit.org/show_bug.cgi?id=288631 rdar://145678587 Unreviewed test gardening. Updated test gardening. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/291732@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8467e8: REGRESSION (288504@main): If Remote Snapshotting i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8467e81ce2ac98823449ea359b9ce0aa20b338cc https://github.com/WebKit/WebKit/commit/8467e81ce2ac98823449ea359b9ce0aa20b338cc Author: Said Abou-Hallawa Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- REGRESSION (288504@main): If Remote Snapshotting is enabled and transformX is applied, text is flipped when exporting a PDF https://bugs.webkit.org/show_bug.cgi?id=289187 rdar://146340218 Reviewed by Tim Horton. Turn off the experimental feature `RemoteSnapshottingEnabled` off by default till this bug is investigated. This feature will be enabled by default later. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/291733@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a18a55: [Gardening]: [ macOS ] media/media-garbage-collect...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a18a55d0554eec809d2f75fafb4014892e8c1ad9 https://github.com/WebKit/WebKit/commit/a18a55d0554eec809d2f75fafb4014892e8c1ad9 Author: Karl Rackler Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [ macOS ] media/media-garbage-collection.html is a flaky failure timeout crash https://bugs.webkit.org/show_bug.cgi?id=289275 rdar://146416725 Unreviewed test gardening. Add test expectations. * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/291727@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27fa2a: Add support for generating a consumer for CSS prop...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 27fa2a20b2901866b273cc5b2cbbca23637483a1
https://github.com/WebKit/WebKit/commit/27fa2a20b2901866b273cc5b2cbbca23637483a1
Author: Sam Weinig
Date: 2025-03-06 (Thu, 06 Mar 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/at-position-try-cssom-expected.txt
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/parser/CSSParserFastPaths.cpp
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.h
M Source/WebCore/css/scripts/process-css-properties.py
M Source/WebCore/css/scripts/test/TestCSSProperties.json
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.gperf
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.h
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyParsing.cpp
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSStyleDeclaration+PropertyNames.idl
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/StyleBuilderGenerated.cpp
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/StyleInterpolationWrapperMap.cpp
Log Message:
---
Add support for generating a consumer for CSS property's that require
arbitrary numeric ranges
https://bugs.webkit.org/show_bug.cgi?id=289170
Reviewed by Darin Adler.
To support CSS properties like font-weight, which contains the production
, support for arbitrary numeric ranges is required in the
code generator. This is done by replacing calls to dedicated consume{numeric
type}(...)
functions with direct use of CSSPrimitiveValueResolver.
CSSPrimitiveValueResolver
allows specifying an arbitrary strongly typed CSS value including any numeric
range it specifies.
* Source/WebCore/css/CSSProperties.json:
- Make 'font-weight' use the code generator and export it for use
in the font shorthand.
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeFont):
- Call new generated and exported function.
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::parseKeywordValue):
- Remove unused support for fast path parsing of descriptors. When
properties and descriptors share the same name (as is true with
'font-weight') but have different grammars, the fast path would
be incorrect.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.h:
(WebCore::CSSPropertyParserHelpers::consumeFontWeight): Deleted.
- Remove old hand written 'font-weight' consumer.
* Source/WebCore/css/process-css-properties.py:
- Remove mappings for range parameters and instead generate
appropriate CSS::Range expressions for them.
- Fix BNFLexer to support negative numeric tokens.
* Source/WebCore/css/scripts/test/TestCSSProperties.json:
- Add new test case with numeric ranges.
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.gperf:
* Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.h:
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyParsing.cpp:
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSStyleDeclaration+PropertyNames.idl:
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/StyleBuilderGenerated.cpp:
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/StyleInterpolationWrapperMap.cpp:
- Update results for new test case.
Canonical link: https://commits.webkit.org/291734@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 895c87: Regression(291671@main) unsafe cast in MicrotaskQu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 895c874d3ff658c0bc36e89f946171db399ce1ca https://github.com/WebKit/WebKit/commit/895c874d3ff658c0bc36e89f946171db399ce1ca Author: Yusuke Suzuki Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/JavaScriptCore/runtime/MicrotaskQueue.h M Source/WebCore/dom/Microtasks.cpp M Source/WebCore/dom/Microtasks.h Log Message: --- Regression(291671@main) unsafe cast in MicrotaskQueue::performMicrotaskCheckpoint() https://bugs.webkit.org/show_bug.cgi?id=289249 rdar://146400842 Reviewed by Chris Dumez, Ryosuke Niwa, and Geoffrey Garen. Suppress static analyzer's warning by adding typeId and cast helper. * Source/JavaScriptCore/runtime/MicrotaskQueue.h: (JSC::MicrotaskDispatcher::MicrotaskDispatcher): (JSC::MicrotaskDispatcher::type const): (JSC::MicrotaskDispatcher::isWebCoreMicrotaskDispatcher const): * Source/WebCore/dom/Microtasks.cpp: (WebCore::MicrotaskQueue::performMicrotaskCheckpoint): * Source/WebCore/dom/Microtasks.h: (WebCore::WebCoreMicrotaskDispatcher::WebCoreMicrotaskDispatcher): (isType): (WebCore::WebCoreMicrotaskDispatcher::type const): Deleted. Canonical link: https://commits.webkit.org/291735@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7b4c51: [SwiftUI] Improve efficiency and memory usage of `...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7b4c51c38b4971634886850b1b9cedb11b9d7775 https://github.com/WebKit/WebKit/commit/7b4c51c38b4971634886850b1b9cedb11b9d7775 Author: Richard Robinson Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/_WebKit_SwiftUI/API/View+WebViewModifiers.swift M Source/WebKit/_WebKit_SwiftUI/Implementation/CocoaWebViewAdapter.swift M Source/WebKit/_WebKit_SwiftUI/Implementation/EnvironmentValues+Extras.swift M Source/WebKit/_WebKit_SwiftUI/Implementation/ViewModifierContexts.swift R Source/WebKit/_WebKit_SwiftUI/Implementation/ViewModifiers.swift M Source/WebKit/_WebKit_SwiftUI/Implementation/WebViewRepresentable.swift Log Message: --- [SwiftUI] Improve efficiency and memory usage of `OnScrollGeometryChangeContext` https://bugs.webkit.org/show_bug.cgi?id=289283 rdar://145869526 Reviewed by Abrar Rahman Protyasha. Effectively reverts 291350@main, since upon investigation, the issue is a client-side issue and not an implementation issue. As a result, a hacky implementation workaround should be avoided; it is the client's responsibiilty to ensure views in general are not redrawn excessively. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/_WebKit_SwiftUI/API/View+WebViewModifiers.swift: * Source/WebKit/_WebKit_SwiftUI/Implementation/CocoaWebViewAdapter.swift: (CocoaWebViewAdapter.geometryDidChange(_:)): * Source/WebKit/_WebKit_SwiftUI/Implementation/EnvironmentValues+Extras.swift: (EnvironmentValues.webViewOnScrollGeometryChange): * Source/WebKit/_WebKit_SwiftUI/Implementation/ViewModifierContexts.swift: (Change.transform): Deleted. (Change.action): Deleted. (changes): Deleted. (apply(from:to:)): Deleted. * Source/WebKit/_WebKit_SwiftUI/Implementation/ViewModifiers.swift: Removed. * Source/WebKit/_WebKit_SwiftUI/Implementation/WebViewRepresentable.swift: (WebViewRepresentable.updatePlatformView(_:context:)): Canonical link: https://commits.webkit.org/291737@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad65a9: Address UncountedLocalVarsChecker warning in Docum...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad65a9078cb1a3401ec1fc39edea0b7ccb34558c https://github.com/WebKit/WebKit/commit/ad65a9078cb1a3401ec1fc39edea0b7ccb34558c Author: Tim Nguyen Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations M Source/WebCore/dom/DocumentFullscreen.cpp M Source/WebCore/html/HTMLElement.cpp Log Message: --- Address UncountedLocalVarsChecker warning in DocumentFullscreen.cpp https://bugs.webkit.org/show_bug.cgi?id=289240 rdar://146384866 Reviewed by Chris Dumez and Alan Baradlay. * Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations: * Source/WebCore/dom/DocumentFullscreen.cpp: (WebCore::DocumentFullscreen::elementEnterFullscreen): * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::showPopoverInternal): Canonical link: https://commits.webkit.org/291701@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1b97c7: Synchronize url WPT (IDNA edition)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1b97c71311f747e0cceeae1a1f073e417869a9a0 https://github.com/WebKit/WebKit/commit/1b97c71311f747e0cceeae1a1f073e417869a9a0 Author: Anne van Kesteren Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/url/IdnaTestV2-removed.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/url/IdnaTestV2-removed.window.html A LayoutTests/imported/w3c/web-platform-tests/url/IdnaTestV2-removed.window.js M LayoutTests/imported/w3c/web-platform-tests/url/IdnaTestV2.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/IdnaTestV2.window.js A LayoutTests/imported/w3c/web-platform-tests/url/resources/IdnaTestV2-removed.json M LayoutTests/imported/w3c/web-platform-tests/url/resources/IdnaTestV2.json M LayoutTests/imported/w3c/web-platform-tests/url/resources/toascii.json M LayoutTests/imported/w3c/web-platform-tests/url/resources/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/url/toascii.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/w3c-import.log A LayoutTests/platform/glib/imported/w3c/web-platform-tests/url/IdnaTestV2.window-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/url/toascii.window-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/url/IdnaTestV2.window-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/url/toascii.window-expected.txt A LayoutTests/platform/mac/imported/w3c/web-platform-tests/url/IdnaTestV2.window-expected.txt A LayoutTests/platform/mac/imported/w3c/web-platform-tests/url/toascii.window-expected.txt M LayoutTests/platform/win/TestExpectations Log Message: --- Synchronize url WPT (IDNA edition) https://bugs.webkit.org/show_bug.cgi?id=289168 rdar://146372617 Reviewed by Antoine Quint. Several changes have landed upstream to align with Unicode 16.0. The non-platform-specific expectations are aligned with Unicode 16.0. Cocoa ports are not and Linux appears to be further behind so they get platform-specific expectations. Windows does appear to be fully aligned so enable all URL tests for Windows while here. Last upstream commit in url/ (it so happens we already pulled these specific changes in selectively): https://github.com/web-platform-tests/wpt/commit/d2c39364360cfa39ce900f643f55ca6ef7b33093 * LayoutTests/imported/w3c/web-platform-tests/url/IdnaTestV2-removed.window-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/url/IdnaTestV2-removed.window.html: Added. * LayoutTests/imported/w3c/web-platform-tests/url/IdnaTestV2-removed.window.js: Added. (runTests): * LayoutTests/imported/w3c/web-platform-tests/url/IdnaTestV2.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/IdnaTestV2.window.js: (runTests): (encodeHostEndingCodePoints): Deleted. * LayoutTests/imported/w3c/web-platform-tests/url/resources/IdnaTestV2-removed.json: Added. * LayoutTests/imported/w3c/web-platform-tests/url/resources/IdnaTestV2.json: * LayoutTests/imported/w3c/web-platform-tests/url/resources/toascii.json: * LayoutTests/imported/w3c/web-platform-tests/url/resources/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/url/toascii.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/w3c-import.log: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/url/IdnaTestV2.window-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/url/toascii.window-expected.txt: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/url/IdnaTestV2.window-expected.txt: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/url/toascii.window-expected.txt: Added. * LayoutTests/platform/mac/imported/w3c/web-platform-tests/url/IdnaTestV2.window-expected.txt: Added. * LayoutTests/platform/mac/imported/w3c/web-platform-tests/url/toascii.window-expected.txt: Added. * LayoutTests/platform/win/TestExpectations: Canonical link: https://commits.webkit.org/291699@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ce4ba5: Remove unused forward decl from Internals.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce4ba58c81768cb8c1e60a717529b9164747711e https://github.com/WebKit/WebKit/commit/ce4ba58c81768cb8c1e60a717529b9164747711e Author: Ryan Reno Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/testing/Internals.h Log Message: --- Remove unused forward decl from Internals. https://bugs.webkit.org/show_bug.cgi?id=289250 rdar://146393963 Reviewed by Sammy Gill. UnsuspendableActiveDOMObject was created to aid in testing and removed shortly after (see 216021@main and 217868@main). There's still a forward declaration in Internals.h which can be removed. * Source/WebCore/testing/Internals.h: Canonical link: https://commits.webkit.org/291703@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e3d1a: AX: Accessibility hit test isn't working in PDFs h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e3d1a2b226b17917551467cc79d0969e6b24899 https://github.com/WebKit/WebKit/commit/5e3d1a2b226b17917551467cc79d0969e6b24899 Author: Utku Uckun Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm Log Message: --- AX: Accessibility hit test isn't working in PDFs https://bugs.webkit.org/show_bug.cgi?id=289175 rdar://146305664 Reviewed by Tyler Wilcock. Accessibility hit test in PDFKit expects hit point in screen coordinate space. Therefore, we need to convert the WebKit hit test point to screen space point before sending it over. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::accessibilityHitTestIntPoint const): (WebKit::UnifiedPDFPlugin::convertFromPluginToScreenForAccessibility const): * Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: (-[WKAccessibilityWebPageObject accessibilityHitTest:]): Canonical link: https://commits.webkit.org/291706@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 794342: [MSE] Fix MediaSource log identifier
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 794342272241264e8296982e8cfead53c9a63d94 https://github.com/WebKit/WebKit/commit/794342272241264e8296982e8cfead53c9a63d94 Author: Eric Carlson Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/Modules/mediasource/MediaSourceInterfaceMainThread.cpp M Source/WebCore/Modules/mediasource/MediaSourceInterfaceMainThread.h M Source/WebCore/Modules/mediasource/MediaSourceInterfaceProxy.h M Source/WebCore/Modules/mediasource/MediaSourceInterfaceWorker.cpp M Source/WebCore/Modules/mediasource/MediaSourceInterfaceWorker.h M Source/WebCore/html/HTMLMediaElement.cpp Log Message: --- [MSE] Fix MediaSource log identifier https://bugs.webkit.org/show_bug.cgi?id=289203 rdar://146337584 Reviewed by Jean Yves Avenard. Pass the HTMLMediaElement log identifier to the MediaSource. * Source/WebCore/Modules/mediasource/MediaSourceInterfaceMainThread.cpp: (WebCore::MediaSourceInterfaceMainThread::setLogIdentifier): * Source/WebCore/Modules/mediasource/MediaSourceInterfaceMainThread.h: * Source/WebCore/Modules/mediasource/MediaSourceInterfaceProxy.h: * Source/WebCore/Modules/mediasource/MediaSourceInterfaceWorker.cpp: (WebCore::MediaSourceInterfaceWorker::setLogIdentifier): * Source/WebCore/Modules/mediasource/MediaSourceInterfaceWorker.h: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Drive-by: Pass the `LOGIDENTIFIER` into the completion handler so logging includes the correct method name. Canonical link: https://commits.webkit.org/291708@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7adb2e: [JSC] `\-` shouldn't be parsed as range with `v` flag
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7adb2e46f423468de209bb1f19bddad6f9b629cb https://github.com/WebKit/WebKit/commit/7adb2e46f423468de209bb1f19bddad6f9b629cb Author: Sosuke Suzuki Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: A JSTests/stress/regexp-v-flag-non-range-hyphen.js M Source/JavaScriptCore/yarr/YarrParser.h M Source/JavaScriptCore/yarr/YarrPattern.cpp M Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp M Source/WebCore/contentextensions/URLFilterParser.cpp Log Message: --- [JSC] `\-` shouldn't be parsed as range with `v` flag https://bugs.webkit.org/show_bug.cgi?id=288223 Reviewed by Yusuke Suzuki. `[\d\-a]` should be parsed as a character class consisting of `\d`,a hyphen (0x002D), and `a`. However, in the current JSC implementation, if the `v` flag is enabled, the hyphen is treated as a range operator, causing a syntax error to be thrown. This patch fixes that behavior. This patch adds a `hyphenIsRange` argument to the `atomPatternCharacter` method in `ClassSetParserDelegate`. This matches the interface of the `atomPatternCharacter` method in `CharacterClassParserDelegate`. * JSTests/stress/regexp-v-flag-non-range-hyphen.js: Added. (compareArray): (throw.new.Error): (shouldBe): * Source/JavaScriptCore/yarr/YarrParser.h: (JSC::Yarr::Parser::ClassSetParserDelegate::atomPatternCharacter): (JSC::Yarr::Parser::parseClassSet): Canonical link: https://commits.webkit.org/291709@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da44fa: [GStreamer][Release] registerTrackId(): alternativ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da44fa7432e25045dc0183848b1d0c3837530011 https://github.com/WebKit/WebKit/commit/da44fa7432e25045dc0183848b1d0c3837530011 Author: Alicia Boya Garcia Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp Log Message: --- [GStreamer][Release] registerTrackId(): alternative IDs discarded https://bugs.webkit.org/show_bug.cgi?id=289245 Reviewed by Philippe Normand. Move side effects away from the assert so that they don't get removed in release builds. * Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp: (WebCore::MediaSourcePrivateGStreamer::registerTrackId): Canonical link: https://commits.webkit.org/291711@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 29a25c: REGRESSION: Service Worker downloads being prematu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29a25c5dec47044f06204f717903a09317646ee8 https://github.com/WebKit/WebKit/commit/29a25c5dec47044f06204f717903a09317646ee8 Author: Youenn Fablet Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm Log Message: --- REGRESSION: Service Worker downloads being prematurely interrupted since iOS 18.2 rdar://143065672 https://bugs.webkit.org/show_bug.cgi?id=286060 Reviewed by Per Arne Vollan. WKModernDownloadProgress place holder handling is only working with NetworkDataTask. We disable place holder handling in case the data is coming from service worker. Manually tested. * Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm: (WebKit::Download::publishProgress): Canonical link: https://commits.webkit.org/291712@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b6667a: [JSC] emitEncodeStructureID should be a no-op when...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6667ac3e18f1e2ce20c48e6e2cbbd3610ad8685 https://github.com/WebKit/WebKit/commit/b6667ac3e18f1e2ce20c48e6e2cbbd3610ad8685 Author: David Degazio Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h M Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h M Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h M Source/JavaScriptCore/jit/AssemblyHelpers.cpp Log Message: --- [JSC] emitEncodeStructureID should be a no-op when the structureIDMask is -1 https://bugs.webkit.org/show_bug.cgi?id=289114 rdar://146142200 Reviewed by Keith Miller. Modifies bitwise AND with immediate in the macro assembler to be a no-op when AND-ing with a -1 value. This removes an unnecessary instruction when compiling some structure ID operations on 64-bit platforms. * Source/JavaScriptCore/assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::and32): (JSC::MacroAssemblerARM64::and64): * Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::and32): * Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h: (JSC::MacroAssemblerRISCV64::and32): (JSC::MacroAssemblerRISCV64::and64): * Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::and32): (JSC::MacroAssemblerX86_64::and64): * Source/JavaScriptCore/jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::emitEncodeStructureID): Canonical link: https://commits.webkit.org/291713@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b46f59: Imperative invokers for popover don't fix focus order
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b46f59f1c06a8d2f0562fee7c42472c99d7dee85 https://github.com/WebKit/WebKit/commit/b46f59f1c06a8d2f0562fee7c42472c99d7dee85 Author: Luke Warlow Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/dom/ElementRareData.cpp M Source/WebCore/dom/ElementRareData.h M Source/WebCore/dom/NodeRareData.h M Source/WebCore/html/HTMLDialogElement.cpp M Source/WebCore/html/HTMLDialogElement.h M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLElement.h M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/html/HTMLFormControlElement.h M Source/WebCore/page/FocusController.cpp Log Message: --- Imperative invokers for popover don't fix focus order https://bugs.webkit.org/show_bug.cgi?id=286575 Reviewed by Tim Nguyen. The FocusController currently still relies on the popoverTargetElement of buttons, to look for popovers to move to the new focus order. This patch stores the invoked popover on the provided invoking element's rare data, and then updates FocusController to use this instead. This way both declarative and imperative popover relationships correctly fix focus order. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html: * Source/WebCore/dom/Element.cpp: (WebCore::Element::invokedPopover const): (WebCore::Element::setInvokedPopover): * Source/WebCore/dom/Element.h: (WebCore::Element::handleCommandInternal): * Source/WebCore/dom/ElementRareData.cpp: * Source/WebCore/dom/ElementRareData.h: (WebCore::ElementRareData::invokedPopover const): (WebCore::ElementRareData::setInvokedPopover): (WebCore::ElementRareData::useTypes const): * Source/WebCore/dom/NodeRareData.h: * Source/WebCore/html/HTMLDialogElement.cpp: (WebCore::HTMLDialogElement::handleCommandInternal): * Source/WebCore/html/HTMLDialogElement.h: * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::showPopoverInternal): (WebCore::HTMLElement::setInvoker): (WebCore::HTMLElement::hidePopoverInternal): (WebCore::HTMLElement::handleCommandInternal): * Source/WebCore/html/HTMLElement.h: * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::handlePopoverTargetAction): (WebCore::HTMLFormControlElement::handlePopoverTargetAction const): Deleted. * Source/WebCore/html/HTMLFormControlElement.h: * Source/WebCore/page/FocusController.cpp: (WebCore::openPopoverForInvoker): Canonical link: https://commits.webkit.org/291719@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d01ff: [Gardening]: [ macOS Debug wk2 ] imported/w3c/web-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d01ffbe397527a977113b343169ed586dc361a3 https://github.com/WebKit/WebKit/commit/1d01ffbe397527a977113b343169ed586dc361a3 Author: Karl Rackler Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: [ macOS Debug wk2 ] imported/w3c/web-platform-tests/mediacapture-streams/historical.https.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=289254 rdar://146397398 Unreviewed test gardening. Add test expectation. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/291705@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a3f83: [JSC] m_expressionInfo may be not set yet
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a3f835a76f0a6e024a2bf22cbb14462d167df5e https://github.com/WebKit/WebKit/commit/3a3f835a76f0a6e024a2bf22cbb14462d167df5e Author: Yusuke Suzuki Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp Log Message: --- [JSC] m_expressionInfo may be not set yet https://bugs.webkit.org/show_bug.cgi?id=289268 rdar://146399098 Reviewed by Yijia Huang. Since this field is set after object allocation is done, there is a chance that concurrent GC markers find this object before setting a value to m_expressionInfo field and accessing it. So, it can be a nullptr, thus we should check nullptr check before using it from concurrent GC markers. * Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp: (JSC::UnlinkedCodeBlock::visitChildrenImpl): Canonical link: https://commits.webkit.org/291720@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 10dc30: [Gardening] REGRESSION(291652@main?): [ macOS wk2 ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10dc30f94aef6f7a369e885d9be26857963e6a1d https://github.com/WebKit/WebKit/commit/10dc30f94aef6f7a369e885d9be26857963e6a1d Author: Yasmin Karimi Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening] REGRESSION(291652@main?): [ macOS wk2 Release ] accessibility/accessibility-node-memory-management.html is a constant timeout. https://bugs.webkit.org/show_bug.cgi?id=289287 rdar://146428038 Unreviewed test gardening. Added a test expectation for a constantly timing out test. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/291741@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa0c41: [GPUP][macOS] Address sandbox telemetry for IOAcce...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa0c41297c1c173bd9de511eaec688f813a4fe06 https://github.com/WebKit/WebKit/commit/fa0c41297c1c173bd9de511eaec688f813a4fe06 Author: Per Arne Vollan Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in Log Message: --- [GPUP][macOS] Address sandbox telemetry for IOAccelerator https://bugs.webkit.org/show_bug.cgi?id=289256 rdar://146062904 Reviewed by Brady Eidson. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: Canonical link: https://commits.webkit.org/291738@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b57333: StringWrapperCFAllocator::allocator should ensure ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b573336f9497c4e77211450aef0cc0ed18c3512e https://github.com/WebKit/WebKit/commit/b573336f9497c4e77211450aef0cc0ed18c3512e Author: Keith Miller Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WTF/wtf/text/cf/StringImplCF.cpp Log Message: --- StringWrapperCFAllocator::allocator should ensure the main thread's RunLoop is initialized. https://bugs.webkit.org/show_bug.cgi?id=289274 rdar://145650973 Reviewed by Yusuke Suzuki. Some users are seeing crashes where `RunLoop::main()` appears to return a `nullptr` while running `StringWrapperCFAllocator::deallocate`. It seems like someone should have initialized the main thread's RunLoop static variable already but it doesn't hurt to double check when getting the StringWrapperCFAllocator::allocator for the first time. This should speculatively fix the crashes. * Source/WTF/wtf/text/cf/StringImplCF.cpp: (WTF::StringWrapperCFAllocator::allocator): Canonical link: https://commits.webkit.org/291739@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eeecca: [JSC] Emit logical op children in condition contex...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eeecca442eb0e974f22a45b07660754a42106275 https://github.com/WebKit/WebKit/commit/eeecca442eb0e974f22a45b07660754a42106275 Author: David Degazio Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp Log Message: --- [JSC] Emit logical op children in condition context when overall result is ignored https://bugs.webkit.org/show_bug.cgi?id=289134 rdar://146174665 Reviewed by Yusuke Suzuki and Geoffrey Garen. Emits logical op children in condition context, meaning we compile them down to conditional branches instead of getting their values, when the overall result of a logical operation is known to be ignored. This fixes an issue where we were unable to fuse conditions and branches in discarded logical operations because the result value was assumed to be accessible. Also changes SourceElements to ignore the results of child statements unless the completion value is observable. * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::LogicalOpNode::emitBytecode): (JSC::SourceElements::emitBytecode): Canonical link: https://commits.webkit.org/291740@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8f545c: [Gardening]: New Test (281395@main): [ macOS wk2 ]...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8f545ca9e9ada22470695ab24c1bc16af6ab0f82 https://github.com/WebKit/WebKit/commit/8f545ca9e9ada22470695ab24c1bc16af6ab0f82 Author: Karl Rackler Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: New Test (281395@main): [ macOS wk2 ] fast/canvas/image-buffer-resource-limits.html is a flaky timeout crash https://bugs.webkit.org/show_bug.cgi?id=289284 rdar://146425264 Unreviewed test gardening. Add test expectation. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/291736@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 226e75: [JSC] WeakMap#getOrInsert should not call function...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 226e75002a92760b0a9ae34d4ee79ed38fcdd0c0 https://github.com/WebKit/WebKit/commit/226e75002a92760b0a9ae34d4ee79ed38fcdd0c0 Author: Yusuke Suzuki Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/JavaScriptCore/runtime/WeakMapPrototype.cpp Log Message: --- [JSC] WeakMap#getOrInsert should not call function under AssertNoGC https://bugs.webkit.org/show_bug.cgi?id=289278 rdar://145241628 Reviewed by Yijia Huang. We should not call function with AssertNoGC since it can cause whatever it want. * Source/JavaScriptCore/runtime/WeakMapPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Canonical link: https://commits.webkit.org/291742@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 798ff2: [JSC] Make JSC::CompleteSubspace::allocateSlow mem...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 798ff291e8a8672c75fbc03a8b01e5b64ed4438d https://github.com/WebKit/WebKit/commit/798ff291e8a8672c75fbc03a8b01e5b64ed4438d Author: Yusuke Suzuki Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/JavaScriptCore/heap/CompleteSubspace.cpp Log Message: --- [JSC] Make JSC::CompleteSubspace::allocateSlow memory exhaust explicit crash https://bugs.webkit.org/show_bug.cgi?id=287376 rdar://144494170 Reviewed by Mark Lam. Use RELEASE_ASSERT_RESOURCE_AVAILABLE for CompleteSubspace's memory exhaust crashes explicitly. * Source/JavaScriptCore/heap/CompleteSubspace.cpp: (JSC::CompleteSubspace::allocateSlow): (JSC::CompleteSubspace::reallocatePreciseAllocationNonVirtual): Canonical link: https://commits.webkit.org/291743@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2a0b6e: [Gardening] [ macOS wk2 Release ] 3 imported/w3c/w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a0b6e4745d006856a47a1a0bb32e88fa34812cd https://github.com/WebKit/WebKit/commit/2a0b6e4745d006856a47a1a0bb32e88fa34812cd Author: Yasmin Karimi Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening] [ macOS wk2 Release ] 3 imported/w3c/web-platform-tests/css/css-conditional/container-queries/canvas-as-container-00*.html are flaky failures. https://bugs.webkit.org/show_bug.cgi?id=289298 rdar://146433875 Unreviewed test gardening. Added test expectations for three flakily failing tests. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/291746@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b90ad9: Ensure completion handler from WebsiteDataStoreCli...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b90ad95246b984c810ce341e8827c00075c2d2bd https://github.com/WebKit/WebKit/commit/b90ad95246b984c810ce341e8827c00075c2d2bd Author: Jessica Cheung Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm Log Message: --- Ensure completion handler from WebsiteDataStoreClient::getScreenTimeURLs runs on main thread https://bugs.webkit.org/show_bug.cgi?id=289021 rdar://146061712 Reviewed by Aditya Keerthi. Ensure we are on main thread when calling captured completion handler. * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm: Canonical link: https://commits.webkit.org/291715@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1cd8f7: [Gardening]: [Sonoma Release wk2] Multiple tests i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1cd8f708e0dc67a768bd58cf724b765709aea748 https://github.com/WebKit/WebKit/commit/1cd8f708e0dc67a768bd58cf724b765709aea748 Author: Marta Darbinyan Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: [Sonoma Release wk2] Multiple tests in imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element are flaky failure https://bugs.webkit.org/show_bug.cgi?id=288732 rdar://145767949 Unreviewed test gardening * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/291718@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 00b6b2: AX: Webpage crashes when I jump between PDF form f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00b6b278c28ad131bbe0dfd09754a90752277129 https://github.com/WebKit/WebKit/commit/00b6b278c28ad131bbe0dfd09754a90752277129 Author: Utku Uckun Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm Log Message: --- AX: Webpage crashes when I jump between PDF form fields with tab button while VoiceOver is on https://bugs.webkit.org/show_bug.cgi?id=289279 rdar://146420768 Reviewed by Tyler Wilcock. Plugin and activeAnnotation are not thread safe and we shouldn't access from secondary thread. * Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm: (-[WKAccessibilityPDFDocumentObject accessibilityAssociatedControlForAnnotation:]): Canonical link: https://commits.webkit.org/291752@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5c937f: Sync `html/rendering/non-replaced-elements/phrasin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5c937f02cc224dc292ae18e39517fea0da062154 https://github.com/WebKit/WebKit/commit/5c937f02cc224dc292ae18e39517fea0da062154 Author: Ahmad Saleem Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/b-strong-styles-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/b-strong-styles-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/b-strong-styles.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/br-wbr-content/content-property.tentative-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/br-wbr-content/content-property.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/br-wbr-content/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/w3c-import.log M LayoutTests/platform/ios/TestExpectations Log Message: --- Sync `html/rendering/non-replaced-elements/phrasing-content-0` from WPT upstream https://bugs.webkit.org/show_bug.cgi?id=289300 rdar://146436222 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/c3ecfc18b83cf15084fad9573f25ece3f7122590 * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/br-wbr-content/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/b-strong-styles-expected.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/b-strong-styles-ref.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/b-strong-styles.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/br-wbr-content/content-property.tentative-expected.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/br-wbr-content/content-property.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/w3c-import.log: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/291759@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad6c26: AX: Page should be null checked in focusedLocalFrame
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad6c26a97fa46eaea5553fa3738cc4fa9fc70615 https://github.com/WebKit/WebKit/commit/ad6c26a97fa46eaea5553fa3738cc4fa9fc70615 Author: Joshua Hoffman Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm Log Message: --- AX: Page should be null checked in focusedLocalFrame https://bugs.webkit.org/show_bug.cgi?id=289263 rdar://146404979 Reviewed by Tyler Wilcock. We need to null check the result we get from m_page->corePage, since that is a pointer. Also, increase pointer hygiene and make it a smart pointer. * Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm: (-[WKAccessibilityWebPageObjectBase focusedLocalFrame]): Canonical link: https://commits.webkit.org/291749@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 29076a: [text-wrap-style:pretty] Fix edge case where orpha...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29076a47162d0c2dee2f141443ad73c3ae094f46 https://github.com/WebKit/WebKit/commit/29076a47162d0c2dee2f141443ad73c3ae094f46 Author: Yulun Wu Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: A LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-1-expected.html A LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-1.html M Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.cpp Log Message: --- [text-wrap-style:pretty] Fix edge case where orphan avoidance heuristics conflict. https://bugs.webkit.org/show_bug.cgi?id=289116 Reviewed by Alan Baradlay. Text-wrap-style:pretty does not correctly prevent orphans in some edge cases. This is caused by the usage of two separate orphan minimization heuristics which may interact in undexpected ways. This PR combines them and simplifies this heuristic to avoid unexpected edge cases. This PR also fixes an orphan minimization off-by-one error. Canonical link: https://commits.webkit.org/291750@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d4da8: Crash in WebChromeClient::clearPlaybackControlsMan...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d4da81abfddcf46d1e5f3e6130d5c330eacc3fa https://github.com/WebKit/WebKit/commit/0d4da81abfddcf46d1e5f3e6130d5c330eacc3fa Author: Andy Estes Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h Log Message: --- Crash in WebChromeClient::clearPlaybackControlsManager due to RELEASE_ASSERT in WeakRef::get() https://bugs.webkit.org/show_bug.cgi?id=289277 rdar://145885207 Reviewed by Chris Dumez. WebChromeClient is owned by its WebCore::Page but stores a WeakRef to a WebPage. If the WebCore::Page outlives its WebPage then code that accesses this WeakRef will crash due to a RELEASE_ASSERT in WeakRef::get() asserting that the underlying weak pointer is non-null. Since WebChromeClient::clearPlaybackControlsManager is called on a timer, it may be called after its WebPage has been destroyed but before its WebCore::Page has been. Resolved this by changing WebChromeClient::m_page from a WeakRef to a WeakPtr, then null-checking m_page before accessing it in WebChromeClient::clearPlaybackControlsManager. In a future change we should null-check all accesses to m_page in WebChromeClient. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::protectedPage const): (WebKit::WebChromeClient::clearPlaybackControlsManager): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: Canonical link: https://commits.webkit.org/291754@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2bae6a: Sync `intersection-observer` from WPT upstreams
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2bae6ab06c2cb5ec6564b1795b5965789e7833bc https://github.com/WebKit/WebKit/commit/2bae6ab06c2cb5ec6564b1795b5965789e7833bc Author: Ahmad Saleem Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/WEB_FEATURES.yml M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/bounding-box-expected.txt M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/bounding-box.html M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/callback-cross-realm-report-exception.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/clip-path-animation-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/clip-path-animation.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/clip-path-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/clip-path.html R LayoutTests/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/display-none.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/explicit-root-different-document-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/explicit-root-different-document.html R LayoutTests/imported/w3c/web-platform-tests/intersection-observer/explicit-root-different-document.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/intersection-observer/explicit-root-different-document.tentative.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/fixed-position-child-scroll-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/fixed-position-child-scroll.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/fixed-position-iframe-scroll-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/fixed-position-iframe-scroll.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/fixed-position-scroll-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/fixed-position-scroll.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/grow-height-and-scrolled-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/grow-height-and-scrolled.html M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/intersection-ratio-with-fractional-bounds-in-iframe.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/not-in-containing-block-chain-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/not-in-containing-block-chain.html R LayoutTests/imported/w3c/web-platform-tests/intersection-observer/not-in-containing-block-chain.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/intersection-observer/not-in-containing-block-chain.tentative.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/padding-clip-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/padding-clip.html M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/resources/intersection-observer-test-utils.js A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/resources/v2-midframe.sub.html M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/resources/v2-subframe.html M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/resources/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/root-vertical-rl-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/root-vertical-rl.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/scroll-and-root-margin-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/scroll-and-root-margin.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/scroll-margin-4-val-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/scroll-margin-4-val.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/scroll-margin-clip-path-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/scroll-margin-clip-path.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/scroll-margin-dynamic-expected.txt A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/scroll-margin-dynamic.html A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/scroll-margin-expected.txt A L
[webkit-changes] [WebKit/WebKit] d8fe46: Fix SVG paint server fallback handling for a non-e...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d8fe46f6db4623f4b1cfff8d264d36cfded2e6d1 https://github.com/WebKit/WebKit/commit/d8fe46f6db4623f4b1cfff8d264d36cfded2e6d1 Author: Ahmad Saleem Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/svg/pservers/reftests/fill-fallback-invalid-uri.svg R LayoutTests/platform/glib/svg/custom/invalid-fill-expected.txt R LayoutTests/platform/glib/svg/custom/invalid-uri-stroke-expected.txt R LayoutTests/platform/glib/svg/custom/recursive-pattern-expected.png M LayoutTests/platform/glib/svg/custom/recursive-pattern-expected.txt R LayoutTests/platform/glib/svg/hixie/error/003-expected.txt R LayoutTests/platform/gtk/svg/custom/external-paintserver-reference-expected.png R LayoutTests/platform/gtk/svg/custom/invalid-fill-expected.png R LayoutTests/platform/gtk/svg/custom/invalid-uri-stroke-expected.png R LayoutTests/platform/gtk/svg/custom/recursive-pattern-expected.png R LayoutTests/platform/gtk/svg/hixie/error/003-expected.png R LayoutTests/platform/ios/svg/custom/invalid-fill-expected.txt R LayoutTests/platform/ios/svg/custom/invalid-uri-stroke-expected.txt M LayoutTests/platform/ios/svg/custom/recursive-pattern-expected.txt R LayoutTests/platform/ios/svg/hixie/error/003-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-fill-expected.png R LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-fill-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-uri-stroke-expected.png R LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/invalid-uri-stroke-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/hixie/error/003-expected.png R LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/hixie/error/003-expected.txt R LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/invalid-fill-expected.png R LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/invalid-uri-stroke-expected.png R LayoutTests/platform/mac-sonoma-wk2-pixel/svg/hixie/error/003-expected.png R LayoutTests/platform/mac/svg/custom/invalid-fill-expected.png R LayoutTests/platform/mac/svg/custom/invalid-fill-expected.txt R LayoutTests/platform/mac/svg/custom/invalid-uri-stroke-expected.png R LayoutTests/platform/mac/svg/custom/invalid-uri-stroke-expected.txt R LayoutTests/platform/mac/svg/custom/recursive-pattern-expected.png M LayoutTests/platform/mac/svg/custom/recursive-pattern-expected.txt R LayoutTests/platform/mac/svg/hixie/error/003-expected.png R LayoutTests/platform/mac/svg/hixie/error/003-expected.txt R LayoutTests/platform/win/svg/custom/invalid-fill-expected.txt R LayoutTests/platform/win/svg/custom/invalid-uri-stroke-expected.txt M LayoutTests/svg/custom/external-paintserver-reference-expected.txt R LayoutTests/svg/custom/invalid-fill.svg R LayoutTests/svg/custom/invalid-uri-stroke.svg M LayoutTests/svg/custom/recursive-pattern.svg R LayoutTests/svg/hixie/error/003-expected.txt R LayoutTests/svg/hixie/error/003.xml M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.cpp Log Message: --- Fix SVG paint server fallback handling for a non-existent URL https://bugs.webkit.org/show_bug.cgi?id=287374 rdar://144493507 Reviewed by Simon Fraser. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. Merge: https://chromium.googlesource.com/chromium/src.git/+/08f435e092b8e4d8ee158c532489aaab08f8d0c4 , https://chromium.googlesource.com/chromium/src.git/+/8a0b30e1432898d243c79bab84b373243edb97f2 , https://chromium.googlesource.com/chromium/src.git/+/9ba199165cab706b90519a681f67ecce92241d5d This patch aligns and simplify SVG Paint Server handling as per web specification [1]: "If a paint server reference in a is invalid, and no fall-back value is given, no paint is rendered for that layer." & "The value none is a fallback value to use if the paint server reference in the layer is invalid (due to pointing to an element that does not exist or which is not a valid paint server)." [1] https://www.w3.org/TR/SVG2/painting.html#SpecifyingPaint This also syncs WPT from upstream for "fill-fallback-invalid-uri" test: Upstream commit: https://github.com/web-platform-tests/wpt/commit/5e030604129f588749fba9d39241edcfe9df1d8c * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.cpp: (WebCore::requestPaintingResource): (WebCore::inheritColorFromParentStyleIfNeeded): Deleted. * LayoutTests/platform/glib/svg/custom/invalid-fill-expected.txt: Removed. * LayoutTests/platform/glib/svg/custom/invalid-uri-stroke-expected.txt: Removed. * LayoutTests/platform/glib/svg/hixie/error/003-expected.txt: Removed. * LayoutTests/platform/gtk/svg/custom/invalid-fill-expected.png: Removed. * LayoutTests/platfor
[webkit-changes] [WebKit/WebKit] 9b705a: Make back/forward policy delegate API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b705a4990eba19136ff0e2ff448a6ccbf13b76a https://github.com/WebKit/WebKit/commit/9b705a4990eba19136ff0e2ff448a6ccbf13b76a Author: Brady Eidson Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegate.h M Source/WebKit/UIProcess/Cocoa/NavigationState.h M Source/WebKit/UIProcess/Cocoa/NavigationState.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm Log Message: --- Make back/forward policy delegate API rdar://146401641 https://bugs.webkit.org/show_bug.cgi?id=289285 Reviewed by Chris Dumez and Basuke Suzuki. * Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegate.h: * Source/WebKit/UIProcess/Cocoa/NavigationState.h: * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::setNavigationDelegate): (WebKit::NavigationState::NavigationClient::shouldGoToBackForwardListItem): * Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm: (-[BackForwardDelegateWithShouldGo webView:shouldGoToBackForwardListItem:willUseInstantBack:completionHandler:]): (-[BackForwardDelegateWithShouldGo _webView:shouldGoToBackForwardListItem:inPageCache:completionHandler:]): (-[BackForwardDelegateWithShouldGo webView:didFinishNavigation:]): (-[BackForwardDelegateWithShouldGoSPI _webView:willGoToBackForwardListItem:inPageCache:]): (TEST(WKNavigation, ShouldGoToBackForwardListItem)): Canonical link: https://commits.webkit.org/291747@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d8e4df: AX: VoiceOver focus pops out of the text field or ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d8e4df8c3919e26415b9ffb33f0e9bed0fc2d8cc https://github.com/WebKit/WebKit/commit/d8e4df8c3919e26415b9ffb33f0e9bed0fc2d8cc Author: Utku Uckun Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- AX: VoiceOver focus pops out of the text field or gets stuck in PDFs https://bugs.webkit.org/show_bug.cgi?id=289190 rdar://146323940 Reviewed by Tyler Wilcock. -We want to build isolated tree for the main frame plugins so accessibility objects can be retrieved by assistive technologies. But we don't want to set isolated tree as root because we want PDF plugin to handle requests. -VoiceOver expects to receive PDF annotation element as focusedUIElement instead of the WebKit text box. Therefore, when accessibilityFocusedUIElement is queried we want to return the AXAssociatedPluginParent if one exists. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::buildAccessibilityTreeIfNeeded): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm: (-[WKAccessibilityWebPageObjectBase accessibilityRootObjectWrapper:]): (-[WKAccessibilityWebPageObjectBase setIsolatedTreeRoot:]): * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::accessibilityFocusedUIElement): Canonical link: https://commits.webkit.org/291756@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f2bd29: Register WPE_SETTING_DRM_SCALE and provide a sane ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2bd2968f34cb46e63e17e3cfd2151882a177046 https://github.com/WebKit/WebKit/commit/f2bd2968f34cb46e63e17e3cfd2151882a177046 Author: Adrian Perez de Castro Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp M Source/WebKit/WPEPlatform/wpe/drm/WPEScreenDRM.cpp M Source/WebKit/WPEPlatform/wpe/drm/WPEScreenDRMPrivate.h Log Message: --- Register WPE_SETTING_DRM_SCALE and provide a sane default https://bugs.webkit.org/show_bug.cgi?id=289230 Reviewed by Carlos Garcia Campos. * Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp: (wpeDisplayDRMConstructed): Added, registers the WPE_SETTING_DRM_SCALE setting. (wpeDisplayDRMSetup): Improve the logic that parses the WPE_DRM_SCALE environment variable, checking for parsing errors and the value of the variable. If the value from the environment cannot be used, call wpeScreenDRMGuessScale() to find a reasonable default for the screen. While at it, bounds-check values possibly set by the application and avoid using them if too small or too big. (wpe_display_drm_class_init): * Source/WebKit/WPEPlatform/wpe/drm/WPEScreenDRM.cpp: (wpeScreenDRMGuessScale): Added, switches from 1.0 scaling to 2.0 if the screen is at least 1200px tall and has a density of 192dpi. The logic could use more finesse, choosing fractional values in between but works well enough as a first approach. * Source/WebKit/WPEPlatform/wpe/drm/WPEScreenDRMPrivate.h: Canonical link: https://commits.webkit.org/291757@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ab419: Refactoring: Making FontCascadeFonts "free" of Fon...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ab41908f1d8e47dc4ec29e7af03be97c6e8d110 https://github.com/WebKit/WebKit/commit/9ab41908f1d8e47dc4ec29e7af03be97c6e8d110 Author: Vitor Roriz Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebCore/platform/graphics/FontCache.cpp M Source/WebCore/platform/graphics/FontCache.h M Source/WebCore/platform/graphics/FontCascade.cpp M Source/WebCore/platform/graphics/FontCascade.h M Source/WebCore/platform/graphics/FontCascadeCache.cpp M Source/WebCore/platform/graphics/FontCascadeCache.h M Source/WebCore/platform/graphics/FontCascadeFonts.cpp M Source/WebCore/platform/graphics/FontCascadeFonts.h M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h Log Message: --- Refactoring: Making FontCascadeFonts "free" of FontSelector https://bugs.webkit.org/show_bug.cgi?id=289265 rdar://146405854 Reviewed by Matthieu Dubet. FontCascadeFonts is currently store in FontCascadeCache. FontCascadeFonts currently holds a RefPtr to its related FontSelector. In order to make it possible to share FontCascadeFont across documents (for specific simple cases), we need to make FontCascadeFont free of context. This patch proposes that FontCascade should hold the FontSelector instead. FontCascade is already responsible for interfacing between FontCascadeDescription and FontCascadeFonts. Also, FontCascadeFonts is usually accessed through FontCascade via functions like ::glyphDataForCharacter, ::width and others, so it make it simpler for passing the FontSelector to FontCascadeFonts when needed. This patch is just a refactoring preparation and should produce no changes. * Source/WebCore/platform/graphics/FontCache.cpp: (WebCore::FontCache::updateFontCascade): * Source/WebCore/platform/graphics/FontCache.h: * Source/WebCore/platform/graphics/FontCascade.cpp: (WebCore::FontCascade::FontCascade): (WebCore::FontCascade::operator=): (WebCore::FontCascade::operator== const): (WebCore::FontCascade::isCurrent const): (WebCore::FontCascade::fontSelectorVersion const): (WebCore::FontCascade::update const): (WebCore::FontCascade::glyphDataForCharacter const): (WebCore::operator<<): * Source/WebCore/platform/graphics/FontCascade.h: (WebCore::FontCascade::primaryFont const): (WebCore::FontCascade::fallbackRangesAt const): (WebCore::FontCascade::isFixedPitch const): (WebCore::FontCascade::canTakeFixedPitchFastContentMeasuring const): (WebCore::FontCascade::fontSelector const): * Source/WebCore/platform/graphics/FontCascadeCache.cpp: (WebCore::FontCascadeCache::retrieveOrAddCachedFonts): * Source/WebCore/platform/graphics/FontCascadeCache.h: * Source/WebCore/platform/graphics/FontCascadeFonts.cpp: (WebCore::FontCascadeFonts::FontCascadeFonts): (WebCore::FontCascadeFonts::determinePitch): (WebCore::FontCascadeFonts::determineCanTakeFixedPitchFastContentMeasuring): (WebCore::FontCascadeFonts::realizeFallbackRangesAt): (WebCore::findBestFallbackFont): (WebCore::FontCascadeFonts::glyphDataForSystemFallback): (WebCore::FontCascadeFonts::glyphDataForVariant): (WebCore::FontCascadeFonts::glyphDataForCharacter): (WebCore::operator<<): * Source/WebCore/platform/graphics/FontCascadeFonts.h: (WebCore::FontCascadeFonts::create): (WebCore::FontCascadeFonts::isFixedPitch): (WebCore::FontCascadeFonts::canTakeFixedPitchFastContentMeasuring): (WebCore::FontCascadeFonts::primaryFont): (WebCore::FontCascadeFonts::fontSelector): Deleted. (WebCore::FontCascadeFonts::fontSelector const): Deleted. (WebCore::FontCascadeFonts::fontSelectorVersion const): Deleted. * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::fontCascade): * Source/WebCore/rendering/style/RenderStyle.h: Canonical link: https://commits.webkit.org/291745@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7b87be: [Gardening] [ macOS wk2 ] imported/w3c/web-platfor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7b87bef2dc4b52ffcc58339037599fc8d44a2aa7 https://github.com/WebKit/WebKit/commit/7b87bef2dc4b52ffcc58339037599fc8d44a2aa7 Author: Yasmin Karimi Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening] [ macOS wk2 ] imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-rendering-invalidation.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=289299 rdar://146435918 Unreviewed test gardening. Added a test expectation for a flakily failing test. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/291748@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c5057d: Address more Safer CPP failures in WebViewImpl.mm
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5057d64bcd69499ba1b4bfaea96ae61ce4a6401 https://github.com/WebKit/WebKit/commit/c5057d64bcd69499ba1b4bfaea96ae61ce4a6401 Author: Chris Dumez Date: 2025-03-06 (Thu, 06 Mar 2025) Changed paths: M Source/WebKit/Platform/cocoa/_WKWebViewTextInputNotifications.mm M Source/WebKit/UIProcess/mac/CorrectionPanel.mm M Source/WebKit/UIProcess/mac/WebViewImpl.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: --- Address more Safer CPP failures in WebViewImpl.mm https://bugs.webkit.org/show_bug.cgi?id=289281 Reviewed by Charlie Wolfe. * Source/WebKit/Platform/cocoa/_WKWebViewTextInputNotifications.mm: (-[_WKWebViewTextInputNotifications dictationDidStart]): (-[_WKWebViewTextInputNotifications dictationDidEnd]): (-[_WKWebViewTextInputNotifications dictationDidPause]): (-[_WKWebViewTextInputNotifications dictationDidResume]): * Source/WebKit/UIProcess/mac/CorrectionPanel.mm: (WebKit::CorrectionPanel::recordAutocorrectionResponse): * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::WebViewImpl): (WebKit::m_flagsChangedEventMonitorTrackingArea): (WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent): (WebKit::WebViewImpl::performDragOperation): (WebKit::WebViewImpl::showWritingTools): (WebKit::WebViewImpl::protectedPage const): Deleted. Canonical link: https://commits.webkit.org/291755@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
