[webkit-changes] [WebKit/WebKit] 43c25c: [JSC] Extract MicrotaskQueue

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 43c25c9714e7fb514a0a2c70646dc457ab199ab7
  
https://github.com/WebKit/WebKit/commit/43c25c9714e7fb514a0a2c70646dc457ab199ab7
  Author: Yusuke Suzuki 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/JavaScriptCore/Sources.txt
A Source/JavaScriptCore/runtime/MicrotaskQueue.cpp
A Source/JavaScriptCore/runtime/MicrotaskQueue.h
M Source/JavaScriptCore/runtime/VM.cpp
M Source/JavaScriptCore/runtime/VM.h
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

  Log Message:
  ---
  [JSC] Extract MicrotaskQueue
https://bugs.webkit.org/show_bug.cgi?id=289074
rdar://146088353

Reviewed by Yijia Huang.

This patch extracts JSC's MicrotaskQueue to prepare to extend it to
fully cover WebCore use case. Right now it is only used for
JavaScriptCore framework etc.

1. This patch extends MicrotaskQueue to accept multiple instances. We
   have a linked list in VM and managing all the instances of
   MicrotaskQueue associated with this VM.
2. Move MicrotaskQueue to its own file.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/runtime/MicrotaskQueue.cpp: Added.
(JSC::QueuedTask::run):
(JSC::MicrotaskQueue::create):
(JSC::MicrotaskQueue::visitAggregateImpl):
* Source/JavaScriptCore/runtime/MicrotaskQueue.h: Added.
(JSC::QueuedTask::QueuedTask):
(JSC::QueuedTask::identifier const):
* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::queueMicrotask):
(JSC::VM::drainMicrotasks):
(JSC::VM::beginMarking):
(JSC::VM::visitAggregateImpl):
(JSC::QueuedTask::run): Deleted.
(JSC::MicrotaskQueue::visitAggregateImpl): Deleted.
* Source/JavaScriptCore/runtime/VM.h:
(JSC::QueuedTask::QueuedTask): Deleted.
(JSC::QueuedTask::identifier const): Deleted.
(JSC::MicrotaskQueue::dequeue): Deleted.
(JSC::MicrotaskQueue::enqueue): Deleted.
(JSC::MicrotaskQueue::isEmpty const): Deleted.
(JSC::MicrotaskQueue::size const): Deleted.
(JSC::MicrotaskQueue::clear): Deleted.
(JSC::MicrotaskQueue::beginMarking): Deleted.
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/291566@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1035e5: RenderDeprecatedFlexibleBox is commonly used as a ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1035e5e1586bc89f8f151e95c4fbdb440f42b12b
  
https://github.com/WebKit/WebKit/commit/1035e5e1586bc89f8f151e95c4fbdb440f42b12b
  Author: Alan Baradlay 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h

  Log Message:
  ---
  RenderDeprecatedFlexibleBox is commonly used as a wrapper for clamping
https://bugs.webkit.org/show_bug.cgi?id=288950

Reviewed by Antti Koivisto.

In many cases -webkit-box is used to only trigger block direction clamping (and 
no flexing is involved whatsoever) by wrapping the inline content inside a 
single (deprecated) flex item.

* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutSingleClampedFlexItem):
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h:

Canonical link: https://commits.webkit.org/291564@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 03d29d: REGRESSION (290132@main): invalid optional inWebKi...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03d29ddfa398e5d33d8fb5ff6806f9cbff1bbcbe
  
https://github.com/WebKit/WebKit/commit/03d29ddfa398e5d33d8fb5ff6806f9cbff1bbcbe
  Author: Matt Woodrow 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  ---
  REGRESSION (290132@main): invalid optional 
inWebKit::WebPage::commitPotentialTap.
https://bugs.webkit.org/show_bug.cgi?id=288949


Reviewed by Simon Fraser.

This can happen before the first transaction after commiting the load has been
received, but only recently was the latter using an optional (previously just
default initialized to 0).  Revert the previous behaviour where the lessThan
check won't succeed for a 0/std::nullopt value.

* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::commitPotentialTap):

Canonical link: https://commits.webkit.org/291584@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a0b986: Crash under WebExtensionContext::recordError.

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a0b9865e73b13eada52b61af630d0df6a2d1a550
  
https://github.com/WebKit/WebKit/commit/a0b9865e73b13eada52b61af630d0df6a2d1a550
  Author: Timothy Hatcher 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm

  Log Message:
  ---
  Crash under WebExtensionContext::recordError.
https://webkit.org/b/289103
rdar://145520129

Reviewed by Brian Weinstein.

Use recordErrorIfNeeded(), since the error might be nil if the script, 
stylesheet or
JSON data are otherwise empty files.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::addInjectedContent):
(WebKit::WebExtensionContext::loadDeclarativeNetRequestRules):

Canonical link: https://commits.webkit.org/291588@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e4ba0a: REGRESSION(289248@main?): Null LocalFrame derefere...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4ba0ad28c51e91d397e62fd09fce24e84203a7e
  
https://github.com/WebKit/WebKit/commit/e4ba0ad28c51e91d397e62fd09fce24e84203a7e
  Author: Charlie Wolfe 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/loader/NavigationDisabler.h

  Log Message:
  ---
  REGRESSION(289248@main?): Null LocalFrame dereference during render tree 
teardown
https://bugs.webkit.org/show_bug.cgi?id=289096
rdar://145408212

Reviewed by Simon Fraser.

Crash data indicates that dereferencing a null LocalFrame during render tree 
teardown has recently become
more likely. All crashes occur beneath Document::willBeRemovedFromFrame, which 
constructs a
NavigationDisabler that previously held a RefPtr to LocalFrame but, after 
289248@main, now holds a
WeakPtr. Revert it to a RefPtr to speculatively fix this crash.

* Source/WebCore/loader/NavigationDisabler.h:

Canonical link: https://commits.webkit.org/291590@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 58cda7: Unreviewed. Rebaseline the test for iOS.

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58cda70d6fd0d8236f2db8a6cac318bd3f9a7983
  
https://github.com/WebKit/WebKit/commit/58cda70d6fd0d8236f2db8a6cac318bd3f9a7983
  Author: Ryosuke Niwa 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/disabled-elements/event-propagate-disabled-keyboard.tentative-expected.txt

  Log Message:
  ---
  Unreviewed. Rebaseline the test for iOS.

* LayoutTests/platform/ios/TestExpectations:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/disabled-elements/event-propagate-disabled-keyboard.tentative-expected.txt:

Canonical link: https://commits.webkit.org/291591@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f0a388: run-benchmarks fails to run Speedometer3 if no sub...

[hysu]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0a38850f625233eb576f9f2f11d58b7596e2fdd
  
https://github.com/WebKit/WebKit/commit/f0a38850f625233eb576f9f2f11d58b7596e2fdd
  Author: Hysu Xiong 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer3.plan

  Log Message:
  ---
  run-benchmarks fails to run Speedometer3 if no subtests are specified
https://bugs.webkit.org/show_bug.cgi?id=289093
rdar://146122009

Reviewed by Dewei Zhu.

Define the default test entry point for SP3 as `index.html`, and only append 
the relevant `subtest` parameters if subtests have been specified.

* Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer3.plan:

Canonical link: https://commits.webkit.org/291570@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7634f1: [Site Isolation] Fix `_countStringMatches:`

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7634f1ef215cb771dcf967e33a1a263a17f2d15d
  
https://github.com/WebKit/WebKit/commit/7634f1ef215cb771dcf967e33a1a263a17f2d15d
  Author: Charlie Wolfe 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  ---
  [Site Isolation] Fix `_countStringMatches:`
https://bugs.webkit.org/show_bug.cgi?id=288998
rdar://146047341

Reviewed by Aditya Keerthi.

Send messages to all web processes associated with a page and aggregate 
responses.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::countStringMatches):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, CountStringMatches)):

Canonical link: https://commits.webkit.org/291575@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 655ee4: [WebGPU] Shader validation routines potentially re...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 655ee4d2796c44db41552773349f7cd950fcca56
  
https://github.com/WebKit/WebKit/commit/655ee4d2796c44db41552773349f7cd950fcca56
  Author: Mike Wyrzykowski 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebGPU/WebGPU/Buffer.h
M Source/WebGPU/WebGPU/Buffer.mm
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Device.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  ---
  [WebGPU] Shader validation routines potentially rely on UB in C++
https://bugs.webkit.org/show_bug.cgi?id=288726
rdar://145760120

Reviewed by Cameron McCormack.

The shader was using a buffer of sizeof(S) + sizeof(uint)
and writing to &S::lastUintMember + 1 assuming it would
write to the uint.

This is flagged by sanitizers, so be explict and define
the member we are writing to.

* Source/WebGPU/WebGPU/Buffer.h:
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Buffer::Buffer):
(WebGPU::Buffer::makeIndexIndirectBuffer): Deleted.
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::clampIndexBufferToValidValues):
(WebGPU::checkForIndirectDrawDeviceLost):

Canonical link: https://commits.webkit.org/291576@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4e5700: [Gardening] REGRESSION(iOS 18): [iOS] imported/w3c...

[karimiy21]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e57007e00ddfb83de880b1da49f556773a6c883
  
https://github.com/WebKit/WebKit/commit/4e57007e00ddfb83de880b1da49f556773a6c883
  Author: Yasmin Karimi 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [Gardening] REGRESSION(iOS 18): [iOS] 
imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-fixed-ancestor.html
 is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=289097
rdar://146124494

Unreviewed test gardening.

Added a test expectation for a flakily failing test.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/291577@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 70614e: [Wasm] GC Structs should have their backing store ...

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70614e20d83803524eb0aad97a9d11cc99a7b4ab
  
https://github.com/WebKit/WebKit/commit/70614e20d83803524eb0aad97a9d11cc99a7b4ab
  Author: Keith Miller 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
A JSTests/wasm/gc/struct-write-barrier.js
M Source/JavaScriptCore/heap/Heap.cpp
M Source/JavaScriptCore/heap/Heap.h
M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
M Source/JavaScriptCore/wasm/WasmBBQJIT.h
M Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp
M Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp
M Source/JavaScriptCore/wasm/WasmFormat.cpp
M Source/JavaScriptCore/wasm/WasmFormat.h
M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp
M Source/JavaScriptCore/wasm/WasmOperations.cpp
M Source/JavaScriptCore/wasm/WasmOperations.h
M Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp
M Source/JavaScriptCore/wasm/WasmTypeDefinition.h
M Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp
M Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.h

  Log Message:
  ---
  [Wasm] GC Structs should have their backing store allocated by a TrailingArray
https://bugs.webkit.org/show_bug.cgi?id=289031
rdar://146071849

Reviewed by Yusuke Suzuki.

Right now we allocate an out of line backing store for each wasm GC struct. Not 
only is this an extra
indirection on access but the malloc/free of this buffer is a significant 
overhead in the benchmark.

This change is about a 40% improvement on that subtest.

To make a trailing array work, wasm GC structs are now allocated out of a 
CompleteSubspace rather than
an IsoSubspace. This means we currently lose a bit of our Iso-heaping 
guarantees from the IsoSubspace
but in the future we can improve IsoAlignedMemoryAllocator to work for complete 
subspaces as well.

I also added a new validateWasmValue to help with future wasm GC debugging. 
Although, in my case it was
actually a missing write barrier.

* Source/JavaScriptCore/heap/Heap.cpp:
(JSC::Heap::webAssemblyInstanceSpaceSlow): Deleted.
* Source/JavaScriptCore/heap/Heap.h:
(JSC::Heap::webAssemblyInstanceSpace): Deleted.
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitStructSet): Deleted.
* Source/JavaScriptCore/wasm/WasmBBQJIT.h:
* Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitStructSet):
(JSC::Wasm::BBQJITImpl::BBQJIT::addStructNewDefault):
(JSC::Wasm::BBQJITImpl::BBQJIT::addStructNew):
(JSC::Wasm::BBQJITImpl::BBQJIT::addStructGet):
(JSC::Wasm::BBQJITImpl::BBQJIT::emitStructPayloadSet): Deleted.
* Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitStructSet):
(JSC::Wasm::BBQJITImpl::BBQJIT::addStructNewDefault):
(JSC::Wasm::BBQJITImpl::BBQJIT::addStructNew):
(JSC::Wasm::BBQJITImpl::BBQJIT::addStructGet):
(JSC::Wasm::BBQJITImpl::BBQJIT::addStructSet):
(JSC::Wasm::BBQJITImpl::BBQJIT::emitStructPayloadSet): Deleted.
* Source/JavaScriptCore/wasm/WasmFormat.cpp:
(JSC::Wasm::validateWasmValue):
* Source/JavaScriptCore/wasm/WasmFormat.h:
(JSC::Wasm::validateWasmValue):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::emitStructSet):
(JSC::Wasm::OMGIRGenerator::addStructNew):
(JSC::Wasm::OMGIRGenerator::addStructNewDefault):
(JSC::Wasm::OMGIRGenerator::addStructGet):
(JSC::Wasm::OMGIRGenerator::addStructSet):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp:
(JSC::Wasm::OMGIRGenerator::emitStructSet):
(JSC::Wasm::OMGIRGenerator::addStructNew):
(JSC::Wasm::OMGIRGenerator::addStructNewDefault):
(JSC::Wasm::OMGIRGenerator::addStructGet):
* Source/JavaScriptCore/wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_NOEXCEPT_JIT_OPERATION):
* Source/JavaScriptCore/wasm/WasmOperations.h:
* Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp:
(JSC::Wasm::StructType::dump const):
(JSC::Wasm::StructType::StructType):
(JSC::Wasm::ArrayType::dump const):
* Source/JavaScriptCore/wasm/WasmTypeDefinition.h:
(JSC::Wasm::StructType::offsetOfFieldInPayload const):
(JSC::Wasm::StructType::fieldOffsetFromInstancePayload):
(JSC::Wasm::StructType::offsetOfField const): Deleted.
(JSC::Wasm::StructType::offsetOfField): Deleted.
(JSC::Wasm::StructType::offsetOfFieldInternal const): Deleted.
* Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp:
(JSC::JSWebAssemblyStruct::JSWebAssemblyStruct):
(JSC::JSWebAssemblyStruct::create):
(JSC::JSWebAssemblyStruct::visitChildrenImpl):
(JSC::JSWebAssemblyStruct::fieldPointer const): Deleted.
(JSC::JSWebAssemblyStruct::fieldPointer): Deleted.
* Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.h:

Canonical link: https://commits.webkit.org/291579@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webk

[webkit-changes] [WebKit/WebKit] a77b2d: [Gardening]: REGRESSION(291521@main): [macOS iOS D...

[Marta]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a77b2d68c06cc6f48b76a199aa7be41709d4fa6a
  
https://github.com/WebKit/WebKit/commit/a77b2d68c06cc6f48b76a199aa7be41709d4fa6a
  Author: Marta Darbinyan 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION(291521@main): [macOS iOS Debug] 
ipc/large-vector-allocate-failure-crash.html is constantly crashing ( failure 
in EWS)
https://bugs.webkit.org/show_bug.cgi?id=289095
rdar://146121871

Unreviewed test gardening

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/291580@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0528dc: `webkitscmpy` should use the latest version of `we...

[Roy Reapor]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0528dcddca7f07791e1546d1f85daf4121f73f5b
  
https://github.com/WebKit/WebKit/commit/0528dcddca7f07791e1546d1f85daf4121f73f5b
  Author: Roy Reapor 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py

  Log Message:
  ---
  `webkitscmpy` should use the latest version of `webkitbugspy`
https://bugs.webkit.org/show_bug.cgi?id=289089
rdar://146117842

Reviewed by Jonathan Bedard.

webkitscmpy could fail to install if a newer webkitbugspy is installed.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:

Canonical link: https://commits.webkit.org/291568@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d49d59: AX: Add fast path for text marker ordering when on...

[Joshua Hoffman]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d49d59b1464d5196a8fafae70423b3e9ded4830b
  
https://github.com/WebKit/WebKit/commit/d49d59b1464d5196a8fafae70423b3e9ded4830b
  Author: Joshua Hoffman 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
A 
LayoutTests/accessibility/ax-thread-text-apis/range-from-webarea-expected.txt
A LayoutTests/accessibility/ax-thread-text-apis/range-from-webarea.html
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXTextMarker.cpp

  Log Message:
  ---
  AX: Add fast path for text marker ordering when one marker is the start of 
the root web area
https://bugs.webkit.org/show_bug.cgi?id=289034
rdar://146075994

Reviewed by Tyler Wilcock.

When we have a text marker at the root web area with offset 0, nothing can come 
before it.
With this knowledge, we can add a fast path to partialOrderByTraversal, so that 
we don't
have to walk the entire AX tree to determine ordering.

* 
LayoutTests/accessibility/ax-thread-text-apis/range-from-webarea-expected.txt: 
Added.
* LayoutTests/accessibility/ax-thread-text-apis/range-from-webarea.html: Added.
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::isRootWebArea const):
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarker::partialOrderByTraversal const):

Canonical link: https://commits.webkit.org/291578@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ff36d6: [ Gardening ]: REGRESSION(291521@main): [macOS iOS...

[Marta]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff36d61ac21d0065712007a89523df4b62cc5731
  
https://github.com/WebKit/WebKit/commit/ff36d61ac21d0065712007a89523df4b62cc5731
  Author: Marta Darbinyan 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [ Gardening ]: REGRESSION(291521@main): [macOS iOS Debug] 
ipc/large-vector-allocate-failure-crash.html is constantly crashing ( failure 
in EWS)
https://bugs.webkit.org/show_bug.cgi?id=289095
rdar://146121871

Unreviewed test gardening

Skipping additional test in ipc/ that crashes with test order.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/291581@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 337000: [WebCore] Use kCFAbsoluteTimeIntervalSince1970 ins...

[AZero13]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 337000b1d429c4dd8a1eaddab4f7719d538e5bca
  
https://github.com/WebKit/WebKit/commit/337000b1d429c4dd8a1eaddab4f7719d538e5bca
  Author: Rose 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp

  Log Message:
  ---
  [WebCore] Use kCFAbsoluteTimeIntervalSince1970 instead of having a hardcoded 
value
https://bugs.webkit.org/show_bug.cgi?id=288527

Reviewed by Alex Christensen.

We already have a constant for number of seconds for this: 
kCFAbsoluteTimeIntervalSince1970.

* Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp:
  (WebCore::CertificateInfo::summary const): Use 
kCFAbsoluteTimeIntervalSince1970

Canonical link: https://commits.webkit.org/291583@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6ad612: Update test and expectations for iOS for http/test...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ad61266bb23cd5374a8cd318d6d0be89e246437
  
https://github.com/WebKit/WebKit/commit/6ad61266bb23cd5374a8cd318d6d0be89e246437
  Author: Megan Gardner 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M 
LayoutTests/http/tests/scroll-to-text-fragment/generation-deal-with-newlines-in-directive.html
A 
LayoutTests/platform/ios/http/tests/scroll-to-text-fragment/generation-deal-with-newlines-in-directive-expected.txt

  Log Message:
  ---
  Update test and expectations for iOS for 
http/tests/scroll-to-text-fragment/generation-deal-with-newlines-in-directive.html
https://bugs.webkit.org/show_bug.cgi?id=288848
rdar://145868474

Unreviewed bug fix.

There is a bug in the spec where if we are looking for a range based on a 
directive that
has no prefix or suffix and the range ends in a period that is also the end of 
the document
then we fail to find the range. This cannot be fixed by adding a suffix or 
prefix to the
directive because there is nothing after the end to add context. This bug is 
also present in
Blink's implementation, and does seem to be a fallout from how the spec is 
written, so I do
believe it is an issue with the spec. But since it only affects situations in 
which the
document is very small, and you are attempting to select to the end of 
document, and the document
end's with a period, I am changing the test instead of investing more time in 
figuring out
the right way to fix the spec and/or our searching functionality.

The reason that iOS and macOS have different implementations is because of the 
age old decision
to use AppKit for our word boundary logic on mac and unicode on iOS, and this 
works for AppKit,
but the unicode implementation needs to add additional context to the directive 
to correctly find it.

* 
LayoutTests/http/tests/scroll-to-text-fragment/generation-deal-with-newlines-in-directive.html:
* 
LayoutTests/platform/ios/http/tests/scroll-to-text-fragment/generation-deal-with-newlines-in-directive-expected.txt:
 Added.

Canonical link: https://commits.webkit.org/291599@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 58ec39: REGRESSION(291425@main): Broke TestWebKitAPI.WebKi...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58ec39cb62b3308b97cc8aeb9a2053a5f2d1ab76
  
https://github.com/WebKit/WebKit/commit/58ec39cb62b3308b97cc8aeb9a2053a5f2d1ab76
  Author: Sihui Liu 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebKit/Shared/JavaScriptEvaluationResult.mm
M Tools/TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm

  Log Message:
  ---
  REGRESSION(291425@main): Broke TestWebKitAPI.WebKit.FindTextInImageOverlay, 
TestWebKitAPI.ResourceLoadStatistics.StorageAccessPromptSiteWithTrigger on Debug
rdar://146036731
https://bugs.webkit.org/show_bug.cgi?id=288983

Reviewed by Per Arne Vollan and Basuke Suzuki.

In 291425@main we disabled the roundtrip to SerializedScriptValue, which helps 
filter out unsupported objects. It turns
out some tests still need the filtering (the tests return Node after executing 
script). To fix the tests for now, revert
291425@main.

* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebKit/Shared/JavaScriptEvaluationResult.mm:
(WebKit::JavaScriptEvaluationResult::extract):
* Tools/TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
(TestWebKitAPI::didCreateBlob):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
(TEST(WKWebView, EvaluateJavaScriptErrorCases)):
(ReturnTypes)):

Canonical link: https://commits.webkit.org/291600@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8fafd9: Percent-width blocks cannot form a re-layout boundary

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8fafd9511671ba8d5e5aa08bf850404746b3b0a3
  
https://github.com/WebKit/WebKit/commit/8fafd9511671ba8d5e5aa08bf850404746b3b0a3
  Author: Ahmad Saleem 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
A 
LayoutTests/fast/css-intrinsic-dimensions/resize-inside-percent-width-overflow-hidden-expected.txt
A 
LayoutTests/fast/css-intrinsic-dimensions/resize-inside-percent-width-overflow-hidden.html
M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  ---
  Percent-width blocks cannot form a re-layout boundary

https://bugs.webkit.org/show_bug.cgi?id=247913
rdar://102577429

Reviewed by Alan Baradlay.

This patch is to align Webkit behavior with Blink / Chromium and Gecko / 
Firefox.

Inspired by (+ Tests): 
https://chromium.googlesource.com/chromium/src.git/+/da179e152dff0ab3e3dabc72299bd4fb586881c9

A block with non-visible overflow can only form a re-layout boundary if both
width and height are fixed.

The block may be inside a shrink-to-fit container (there's no cheap and
reliable way to detect that), so that changes inside it may affect its width.

Instead of `isFixed()` checks done in 256901@main, this patch adds missing
check of `width` being PercentOrCalculated.

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary):
of relayout for non-fixed container
* 
LayoutTests/fast/css-intrinsic-dimension/resize-inside-percent-width-overflow-hidden.html:
 Added Test Case
* 
LayoutTests/fast/css-intrinsic-dimension/resize-inside-percent-width-overflow-hidden-expected.txt:
 Added Test Case Expectations

Canonical link: https://commits.webkit.org/291607@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8f0f41: com.apple.WebKit.GPU at WebCore: WebCore::Fragment...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f0f41884d01fb0ea284cb84b833a7ba74045d5f
  
https://github.com/WebKit/WebKit/commit/8f0f41884d01fb0ea284cb84b833a7ba74045d5f
  Author: Jean-Yves Avenard 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M 
Source/WebCore/platform/graphics/avfoundation/FormatDescriptionUtilities.cpp

  Log Message:
  ---
  com.apple.WebKit.GPU at WebCore: WebCore::FragmentedSharedBuffer::append
https://bugs.webkit.org/show_bug.cgi?id=289133
rdar://122892059

Reviewed by Eric Carlson.

Exception indicates that the object retrieved wasn't a CFData so use dynamic
casting instead to abort early.

* Source/WebCore/platform/graphics/avfoundation/FormatDescriptionUtilities.cpp:
(WebCore::codecFromFormatDescription):

Canonical link: https://commits.webkit.org/291608@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9ce32a: REGRESSION (287742@main): RTL text sometimes chang...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ce32acb6e979de9b512540b3ced40d093d78e8f
  
https://github.com/WebKit/WebKit/commit/9ce32acb6e979de9b512540b3ced40d093d78e8f
  Author: Wenson Hsieh 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
A 
LayoutTests/editing/input/typing-does-not-change-rtl-text-direction-expected.html
A LayoutTests/editing/input/typing-does-not-change-rtl-text-direction.html
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp

  Log Message:
  ---
  REGRESSION (287742@main): RTL text sometimes changes direction while typing
https://bugs.webkit.org/show_bug.cgi?id=289102
rdar://146084533

Reviewed by Abrar Rahman Protyasha and Alan Baradlay.

This patch fixes a subtle bug in `TextUtil::containsStrongDirectionalityText` — 
this helper uses
SIMD to iterate through a string buffer by a fixed stride length (i.e. 4), in 
order to quickly rule
out the presence of bidi RTL text in a 16-bit string. After scanning through 
all of the full SIMD
strides, we then do one final pass over the final stride in the span. However, 
after the changes in
https://commits.webkit.org/287742@main, we now bail *immediately* from the main 
SIMD for-loop
because `span.size() < stride`. Since we never modify `span` in the for loop, 
we end up only looking
at the last 4 `UChar`s in the string buffer, which has the effect of RTL text 
flipping direction as
the user types, (seeming) at random.

To fix this, we:

1.  Invert the condition of the for loop, such that we iterate if `stride < 
span.size()`.

2.  Store a `span` to the final stride before iterating through the loop, such 
that we safely check
the last 4 characters in the buffer against `maybeBidiRTL`.

As an alternative, I considered checking the final stride (`span.last(stride)`) 
before entering the
for loop if `(span.size() % stride)` is non-zero, but decided against this, in 
favor of preserving
memory locality (i.e. only iterating forwards, from start to end, through the 
string buffer instad
of jumping from end to start to end).

* 
LayoutTests/editing/input/typing-does-not-change-rtl-text-direction-expected.html:
 Added.
* LayoutTests/editing/input/typing-does-not-change-rtl-text-direction.html: 
Added.

Add a test to exercise the fix.

* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::containsStrongDirectionalityText):

See above for more details.

Canonical link: https://commits.webkit.org/291602@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 10ac38: ASAN_TRAP | WTF::HashTable::lookup; WebCore::Legac...

[lopezlozoya]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 10ac38dba49ec8662dd59914a0583084eeb8455b
  
https://github.com/WebKit/WebKit/commit/10ac38dba49ec8662dd59914a0583084eeb8455b
  Author: Adan Lopez 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
A 
LayoutTests/svg/clip-path/clip-path-remove-null-client-from-cache-expected.txt
A LayoutTests/svg/clip-path/clip-path-remove-null-client-from-cache.html
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h

  Log Message:
  ---
  ASAN_TRAP | WTF::HashTable::lookup; 
WebCore::LegacyRenderSVGResourceClipper::removeClientFromCache; 
WebCore::SVGResources::removeClientFromCache
https://bugs.webkit.org/show_bug.cgi?id=288752
rdar://144407636

Reviewed by Ryosuke Niwa.

Change the from UncheckedKeyHashMap to WeakHashMap in m_clipper in 
LegacyRenderSVGResourceClipper.

* 
LayoutTests/svg/clip-path/clip-path-remove-null-client-from-cache-expected.txt: 
Added.
* LayoutTests/svg/clip-path/clip-path-remove-null-client-from-cache.html: Added.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h:

Canonical link: https://commits.webkit.org/291601@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b7b433: [Wasm] GC structs shouldn't need to visit fields i...

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7b433a1d53eeeba1bd4d97e27c5084595db579c
  
https://github.com/WebKit/WebKit/commit/b7b433a1d53eeeba1bd4d97e27c5084595db579c
  Author: Keith Miller 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/wasm/WasmFormat.cpp
M Source/JavaScriptCore/wasm/WasmFormat.h
M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp
M Source/JavaScriptCore/wasm/WasmOperations.cpp
M Source/JavaScriptCore/wasm/WasmOperations.h
M Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp
M Source/JavaScriptCore/wasm/WasmTypeDefinition.h
M Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp

  Log Message:
  ---
  [Wasm] GC structs shouldn't need to visit fields if there's no ref fields
https://bugs.webkit.org/show_bug.cgi?id=289112
rdar://146141202

Reviewed by Yusuke Suzuki.

There's a couple of changes in this PR that didn't make it into 291579@main:

1) GC structs shouldn't walk the fields looking for ref type fields unless 
there's at least
   one field with a ref type. In Dart-flutter-wasm a decent number of the 
structs have no outgoing
   pointers, which also seems likely to be the case in general. In the future 
we could also cache
   the offsets of outgoing pointers in the `Wasm::StructType` but since this 
didn't show any progression
   we should make sure it's worthwhile to use the extra memory.
2) Make `RTT` a `TrailingArray` subclass.
3) Rename `RTT::isSubRTT` to `RTT::isStrictSubRTT` and 
`RTT::isSubRTTWithEquality` to `RTT::isSubRTT`,
   which better matches the general programming language parlance.

As mentioned above this didn't seem to improve the benchmark but doesn't cost 
us any memory so it seems
worthwhile to just land.

* Source/JavaScriptCore/wasm/WasmFormat.cpp:
(JSC::Wasm::validateWasmValue):
* Source/JavaScriptCore/wasm/WasmFormat.h:
(JSC::Wasm::isSubtypeIndex):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::emitRefTestOrCast):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp:
(JSC::Wasm::OMGIRGenerator::emitRefTestOrCast):
* Source/JavaScriptCore/wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_NOEXCEPT_JIT_OPERATION):
* Source/JavaScriptCore/wasm/WasmOperations.h:
* Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp:
(JSC::Wasm::StructType::StructType):
(JSC::Wasm::RTT::isStrictSubRTT const):
(JSC::Wasm::TypeInformation::castReference):
(JSC::Wasm::RTT::isSubRTT const): Deleted.
* Source/JavaScriptCore/wasm/WasmTypeDefinition.h:
(JSC::Wasm::StructType::field const):
(JSC::Wasm::StructType::hasRefFieldTypes const):
(JSC::Wasm::StructType::setHasRecursiveReference):
(JSC::Wasm:: const):
* Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp:
(JSC::JSWebAssemblyStruct::visitChildrenImpl):

Canonical link: https://commits.webkit.org/291603@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bb28a3: Upstream gradient underline code for writing tools.

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb28a32363196b4070bf4763fee3c15b17d992bc
  
https://github.com/WebKit/WebKit/commit/bb28a32363196b4070bf4763fee3c15b17d992bc
  Author: Megan Gardner 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/rendering/TextBoxPainter.cpp

  Log Message:
  ---
  Upstream gradient underline code for writing tools.
https://bugs.webkit.org/show_bug.cgi?id=289128
rdar://problem/146166829

Reviewed by Abrar Rahman Protyasha.

Upstreaming code that should have been done last year.

* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::drawWritingToolsUnderline):
(WebCore::TextBoxPainter::paintPlatformDocumentMarker):
(WebCore::drawUnifiedTextReplacementUnderline): Deleted.

Canonical link: https://commits.webkit.org/291604@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bb6588: Address Safer more CPP failures in UIProcess/

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb658823cf9b5a18c98db4ed188112532a564773
  
https://github.com/WebKit/WebKit/commit/bb658823cf9b5a18c98db4ed188112532a564773
  Author: Chris Dumez 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp
M Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp
M Source/WebKit/UIProcess/mac/CorrectionPanel.mm
M Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm
M Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.mm
M Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm
M Source/WebKit/UIProcess/mac/WKImmediateActionController.mm
M Source/WebKit/UIProcess/mac/WKPrintingView.h
M Source/WebKit/UIProcess/mac/WKPrintingView.mm

  Log Message:
  ---
  Address Safer more CPP failures in UIProcess/
https://bugs.webkit.org/show_bug.cgi?id=289032

Reviewed by Geoffrey Garen and Darin Adler.

* Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::platformGamepadConnected):
(WebKit::UIGamepadProvider::platformGamepadDisconnected):
* Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp:
(WebKit::ServiceWorkerNotificationHandler::singleton):
(WebKit::ServiceWorkerNotificationHandler::showNotification):
(WebKit::ServiceWorkerNotificationHandler::cancelNotification):
(WebKit::ServiceWorkerNotificationHandler::clearNotifications):
(WebKit::ServiceWorkerNotificationHandler::didDestroyNotification):
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp:
(WebKit::RemoteLayerTreeEventDispatcher::updateAnimations):
* Source/WebKit/UIProcess/mac/CorrectionPanel.mm:
(WebKit::CorrectionPanel::recordAutocorrectionResponse):
* Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm:
(WebKit::DisplayCaptureSessionManager::promptForGetDisplayMedia):
(WebKit::DisplayCaptureSessionManager::cancelGetDisplayMediaPrompt):
* Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.mm:
(WebKit::UserMediaPermissionRequestProxyMac::canRequestDisplayCapturePermission):
* Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController cancelOperation:]):
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen:]):
(-[WKFullScreenWindowController exitFullScreenImmediately]):
(-[WKFullScreenWindowController requestExitFullScreen]):
(-[WKFullScreenWindowController 
finishedExitFullScreenAnimationAndExitImmediately:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimation]):
(-[WKFullScreenWindowController _manager]):
(-[WKFullScreenWindowController _videoPresentationManager]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
* Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _webHitTestResult]):
(-[WKImmediateActionController _defaultAnimationController]):
(-[WKImmediateActionController _animationControllerForDataDetectedText]):
(-[WKImmediateActionController _animationControllerForDataDetectedLink]):
* Source/WebKit/UIProcess/mac/WKPrintingView.h:
* Source/WebKit/UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView initWithFrameProxy:view:]):
(-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]):
(-[WKPrintingView _askPageToComputePageRects]):
(-[WKPrintingView _drawPreview:]):

Canonical link: https://commits.webkit.org/291605@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c647ea: imported/w3c/web-platform-tests/css/css-anchor-pos...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c647ea6965a7c44ee094b9ec15a0ddac39ebbc1c
  
https://github.com/WebKit/WebKit/commit/c647ea6965a7c44ee094b9ec15a0ddac39ebbc1c
  Author: Fujii Hironori 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/TestExpectations

  Log Message:
  ---
  
imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-change-css-visibility.html
 is unexpectedly passing after 291552@main
https://bugs.webkit.org/show_bug.cgi?id=26

Unreviewed test gardening.

* LayoutTests/TestExpectations: Unmarked it.

Canonical link: https://commits.webkit.org/291606@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 61519d: [Gardening] REGRESSION(290385@main - 290390@main?)...

[karimiy21]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 61519d0a2e0aa02513c8ca9392af55dc7bbfba2d
  
https://github.com/WebKit/WebKit/commit/61519d0a2e0aa02513c8ca9392af55dc7bbfba2d
  Author: Yasmin Karimi 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening] REGRESSION(290385@main - 290390@main?): [ wk2 arm64 ] 
imported/w3c/web-platform-tests/dom/nodes/remove-from-shadow-host-and-adopt-into-iframe.html
 is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=289090
rdar://146118642

Unreviewed test gardening.

Added a test expectation for a flakily timing out test.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/291567@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 75314a: [scroll-animations] WPT test `scroll-animations/cs...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75314a097510458122c6aa7b3814b3d6c5feb90d
  
https://github.com/WebKit/WebKit/commit/75314a097510458122c6aa7b3814b3d6c5feb90d
  Author: Antoine Quint 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-dynamic.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-dynamic.tentative.html
M Source/WebCore/animation/CSSAnimation.cpp

  Log Message:
  ---
  [scroll-animations] WPT test 
`scroll-animations/css/scroll-timeline-dynamic.tentative.html` is a failure
https://bugs.webkit.org/show_bug.cgi?id=289085

Reviewed by Anne van Kesteren.

The failing subtests in 
`scroll-animations/css/scroll-timeline-dynamic.tentative.html` were created 5 
years ago
and with the assumption that setting both `animation-play-state` and 
`animation-timeline` at once would first
set the play state, and then the timeline. However, the spec issue that the 
test refers to [0] has since been
addressed and the CSS Animations Level 2 specification now clearly says it's 
the opposite [1]:

When multiple animation-* properties are set simultaneously, 
animation-timeline is updated first,
so e.g. a change to animation-play-state applies to the 
simultaneously-applied timeline specified
in animation-timeline.

As a result we modify the WPT test to be in line with the current spec.

Additionally, we add this spec text as a comment in the relevant implementation 
code and ensure to match it
by placing the call to `syncStyleOriginatedTimeline()` up front under 
`CSSAnimation::syncPropertiesWithBackingAnimation()`.
Note that this doesn't change behavior since it was already called prior to 
handling `animation-play-state`
and the other properties that were handled prior to it had no bearing on the 
behavior of the procedure
to set the timeline.

[0] https://github.com/w3c/csswg-drafts/issues/5653
[1] https://drafts.csswg.org/css-animations-2/#animation-timeline

* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-dynamic.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-dynamic.tentative.html:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):

Canonical link: https://commits.webkit.org/291573@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 09ad2d: REGRESSION(262954@main): [GTK] Attempts access to ...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 09ad2dad9a7a592b16b06a87bd803e7878f36523
  
https://github.com/WebKit/WebKit/commit/09ad2dad9a7a592b16b06a87bd803e7878f36523
  Author: Adrian Perez de Castro 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/platform/SimpleCaretAnimator.cpp

  Log Message:
  ---
  REGRESSION(262954@main): [GTK] Attempts access to disengaged optional with 
caret blinking disabled
https://bugs.webkit.org/show_bug.cgi?id=289007

Reviewed by Carlos Garcia Campos.

* Source/WebCore/platform/SimpleCaretAnimator.cpp:
(WebCore::SimpleCaretAnimator::updateAnimationProperties): Always return
early when caret blinking is suspended, regardless of the current
blinking state; but nevertheless still schedule toggling the visibility
if needed.

Canonical link: https://commits.webkit.org/291555@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fc6911: Cherry-pick 288514@main (6c800745251d). https://bu...

[youennf]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: fc6911de1d792371dd12cb9b5f172fa01801a44c
  
https://github.com/WebKit/WebKit/commit/fc6911de1d792371dd12cb9b5f172fa01801a44c
  Author: Youenn Fablet 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-with-body.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-with-body.https.html
A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-with-body-worker.js
A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-with-body-worker.py
M Source/WebCore/Modules/fetch/FetchBody.cpp
M Source/WebCore/Modules/fetch/FetchBody.h
M Source/WebCore/Modules/fetch/FetchBodyOwner.h
M Source/WebCore/Modules/fetch/FetchResponse.cpp

  Log Message:
  ---
  Cherry-pick 288514@main (6c800745251d). 
https://bugs.webkit.org/show_bug.cgi?id=284184

Checking for presence of request body in Service Worker causes body to be 
dropped from request
rdar://141454387
https://bugs.webkit.org/show_bug.cgi?id=284184

Reviewed by Chris Dumez.

When getting request.body, we create a readable stream from the request 
body.
Then, when making the fetch from it, we would not send the request body 
since we are not handling body converted as a readable stream.
We add support to get back the body as an array buffer from the readable 
stream.

Covered by the added test.

* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-with-body.https-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-with-body.https.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-with-body-worker.js:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-with-body-worker.py:
 Added.
(main):
* Source/WebCore/Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::convertReadableStreamToArrayBuffer):
* Source/WebCore/Modules/fetch/FetchBody.h:
* Source/WebCore/Modules/fetch/FetchBodyOwner.h:
(WebCore::FetchBodyOwner::body):
(WebCore::FetchBodyOwner::body const):
* Source/WebCore/Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::fetch):

Canonical link: https://commits.webkit.org/288514@main

Canonical link: https://commits.webkit.org/282416.466@webkitglib/2.46



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b85b00: Cherry-pick 288818@main (0aed73553051). https://bu...

[Alex Christensen]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: b85b00257bbaf41e9289e1ca6865ad83534c7124
  
https://github.com/WebKit/WebKit/commit/b85b00257bbaf41e9289e1ca6865ad83534c7124
  Author: Fujii Hironori 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebKit/UIProcess/skia/BackingStoreSkia.cpp

  Log Message:
  ---
  Cherry-pick 288818@main (0aed73553051). 
https://bugs.webkit.org/show_bug.cgi?id=285718

[Skia] ASSERTION FAILED: bitmap->size() == updateSize : 
BackingStore::incorporateUpdate(UpdateInfo &&) on a fractional device scale 
factor display
https://bugs.webkit.org/show_bug.cgi?id=285718

Reviewed by Don Olmstead.

Windows supports fractional device scale factors. For example, 125%,
150% and 175% DPI display. BackingStore::incorporateUpdate has an
assertion that checkes a ShareableBitmap size is the bounding rect
size scaled by the device scale factor. However, this assertion failed
if the device scale factor was fractional.

 added `expandedIntSize` to
BackingStoreCairo.cpp to solve a same problem. Did the same for
BackingStoreSkia.cpp.

* Source/WebKit/UIProcess/skia/BackingStoreSkia.cpp:
(WebKit::BackingStore::incorporateUpdate):

Canonical link: https://commits.webkit.org/288818@main

Canonical link: https://commits.webkit.org/282416.463@webkitglib/2.46


  Commit: bebc133af7083b374c5c34c76461c0dae9662d4c
  
https://github.com/WebKit/WebKit/commit/bebc133af7083b374c5c34c76461c0dae9662d4c
  Author: Alex Christensen 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/dom/Document.cpp

  Log Message:
  ---
  Cherry-pick 288630@main (c4c4381fdb0f). 
https://bugs.webkit.org/show_bug.cgi?id=285645

Null check page in Document::nodeWillBeRemoved
https://bugs.webkit.org/show_bug.cgi?id=285645
rdar://142586492

Reviewed by Charlie Wolfe.

I have a crash log that indicates that it can be null during teardown.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::nodeWillBeRemoved):

Canonical link: https://commits.webkit.org/288630@main

Canonical link: https://commits.webkit.org/282416.464@webkitglib/2.46


  Commit: f4907c2c934ae4db907ee629f069304d2e158e22
  
https://github.com/WebKit/WebKit/commit/f4907c2c934ae4db907ee629f069304d2e158e22
  Author: Alex Christensen 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

  Log Message:
  ---
  Cherry-pick 288629@main (a0fef0ff952f). 
https://bugs.webkit.org/show_bug.cgi?id=285650

Add null check in InjectedBundlePage::didClearWindowForFrame
https://bugs.webkit.org/show_bug.cgi?id=285650
rdar://142587914

Reviewed by Charlie Wolfe.

Crash logs indicate it can be null, especially with site isolation on.

* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didClearWindowForFrame):

Canonical link: https://commits.webkit.org/288629@main

Canonical link: https://commits.webkit.org/282416.465@webkitglib/2.46


Compare: https://github.com/WebKit/WebKit/compare/63851859470d...f4907c2c934a

To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fcc735: Use ref-counting forwarding for `DocumentFullscreen`

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fcc73527e93d3d4948deec6328f1260245a7d856
  
https://github.com/WebKit/WebKit/commit/fcc73527e93d3d4948deec6328f1260245a7d856
  Author: Tim Nguyen 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WTF/wtf/LoggerHelper.h
M Source/WebCore/css/SelectorCheckerTestFunctions.h
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/DocumentFullscreen.cpp
M Source/WebCore/dom/DocumentFullscreen.h
M Source/WebCore/dom/DocumentOrShadowRootFullscreen.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/MediaElementSession.cpp
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/ScreenOrientation.cpp
M Source/WebCore/page/ios/ContentChangeObserver.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/style/StyleAdjuster.cpp
M Source/WebCore/style/UserAgentStyle.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  ---
  Use ref-counting forwarding for `DocumentFullscreen`
https://bugs.webkit.org/show_bug.cgi?id=288981
rdar://146036494

Reviewed by Chris Dumez.

Also address some smarter C++ warnings that appeared as a result.

* Source/WTF/wtf/LoggerHelper.h:
* Source/WebCore/css/SelectorCheckerTestFunctions.h:
(WebCore::matchesAnimatingFullscreenTransitionPseudoClass):
(WebCore::matchesFullscreenDocumentPseudoClass):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::commonTeardown):
(WebCore::Document::ensureFullscreen):
(WebCore::Document::protectedFullscreen):
(WebCore::Document::protectedFullscreen const):
(WebCore::eventTargetElementForDocument):
(WebCore::Document::checkedFullscreen): Deleted.
(WebCore::Document::checkedFullscreen const): Deleted.
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::fullscreenEnabled):
(WebCore::DocumentFullscreen::requestFullscreen):
(WebCore::DocumentFullscreen::willEnterFullscreen):
(WebCore::DocumentFullscreen::elementEnterFullscreen):
(WebCore::documentsToUnfullscreen):
(WebCore::DocumentFullscreen::exitFullscreen):
(WebCore::DocumentFullscreen::webkitExitFullscreen):
(WebCore::DocumentFullscreen::finishExitFullscreen):
(WebCore::DocumentFullscreen::fullyExitFullscreen):
(WebCore::DocumentFullscreen::queueFullscreenChangeEventForDocument):
* Source/WebCore/dom/DocumentFullscreen.h:
* Source/WebCore/dom/DocumentOrShadowRootFullscreen.cpp:
(WebCore::DocumentOrShadowRootFullscreen::fullscreenElement):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isFullscreen const):
(WebCore::HTMLMediaElement::isStandardFullscreen const):
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::exitFullscreen):
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::canShowControlsManager const):
(WebCore::MediaElementSession::updateMediaUsageIfChanged):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::documentBackgroundColor const):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::updateRendering):
(WebCore::Page::outermostFullscreenDocument const):
* Source/WebCore/page/ScreenOrientation.cpp:
(WebCore::ScreenOrientation::lock):
* Source/WebCore/page/ios/ContentChangeObserver.cpp:
(WebCore::isHiddenBehindFullscreenElement):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::isDescendantOfFullScreenLayer):
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):
* Source/WebCore/style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchDidStartProvisionalLoad):
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _didStartProvisionalLoadForFrame:]):

Canonical link: https://commits.webkit.org/291560@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] efcd4a: [GStreamer][MSE] Avoid adding redundant tracks to ...

[Vivienne]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: efcd4ab82387046eaa2a8534c34e085d32c41a25
  
https://github.com/WebKit/WebKit/commit/efcd4ab82387046eaa2a8534c34e085d32c41a25
  Author: Vivienne Watermeier 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/media/media-source/media-source-vttsimple-expected.txt
M LayoutTests/media/media-source/media-source-vttsimple.html
M LayoutTests/media/media-source/media-source-webm-expected.txt
M LayoutTests/media/media-source/media-source-webm.html
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  ---
  [GStreamer][MSE] Avoid adding redundant tracks to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=288974

Reviewed by Alicia Boya Garcia.

In MSE, WebKit already adds tracks to the HTMLMediaElement and the SourceBuffer 
in
SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment, so we need to
avoid adding each Track again in updateTracks.

* LayoutTests/media/media-source/media-source-vttsimple-expected.txt:
* LayoutTests/media/media-source/media-source-vttsimple.html: Explicitly test 
for the number of tracks.
* LayoutTests/media/media-source/media-source-webm-expected.txt:
* LayoutTests/media/media-source/media-source-webm.html: Ditto.
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateTracks): Don't add Tracks to 
MediaPlayer if in MSE.

Canonical link: https://commits.webkit.org/291559@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 977858: Cherry-pick 288458@main (1e3a17caec13). https://bu...

[Anne van Kesteren]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: 977858fd2a178b4e9cc6258f7cc656e6ac9b65cd
  
https://github.com/WebKit/WebKit/commit/977858fd2a178b4e9cc6258f7cc656e6ac9b65cd
  Author: Anne van Kesteren 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-type-checkbox-switch.tentative.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-type-checkbox-switch.tentative.window.js
M Source/WebCore/html/CheckboxInputType.cpp
M Source/WebCore/html/HTMLInputElement.cpp

  Log Message:
  ---
  Cherry-pick 288458@main (1e3a17caec13). 
https://bugs.webkit.org/show_bug.cgi?id=285338

ASSERTION FAILED: !input->userAgentShadowRoot() when cloning a switch input
https://bugs.webkit.org/show_bug.cgi?id=285338

Reviewed by Ryosuke Niwa.

No longer initialize a user agent shadow root when a switch attribute
is set through the parser or cloning as this will be taken care of
later.

Additionally, add more ScriptDisallowedScope::EventAllowedScope
annotations inside  user agent shadow root
creation as otherwise we'd run into asserts there as well.

* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-type-checkbox-switch.tentative.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-type-checkbox-switch.tentative.window.js:
* Source/WebCore/html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::createShadowSubtree):
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attributeChanged):

Canonical link: https://commits.webkit.org/288458@main

Canonical link: https://commits.webkit.org/282416.467@webkitglib/2.46



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6a5135: Cherry-pick 291555@main (09ad2dad9a7a). https://bu...

[Charlie Wolfe]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a51350ab5af5bec7904d910878d7426585f5f38
  
https://github.com/WebKit/WebKit/commit/6a51350ab5af5bec7904d910878d7426585f5f38
  Author: Adrian Perez de Castro 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/platform/SimpleCaretAnimator.cpp

  Log Message:
  ---
  Cherry-pick 291555@main (09ad2dad9a7a). 
https://bugs.webkit.org/show_bug.cgi?id=289007

REGRESSION(262954@main): [GTK] Attempts access to disengaged optional with 
caret blinking disabled
https://bugs.webkit.org/show_bug.cgi?id=289007

Reviewed by Carlos Garcia Campos.

* Source/WebCore/platform/SimpleCaretAnimator.cpp:
(WebCore::SimpleCaretAnimator::updateAnimationProperties): Always return
early when caret blinking is suspended, regardless of the current
blinking state; but nevertheless still schedule toggling the visibility
if needed.

Canonical link: https://commits.webkit.org/291555@main

Canonical link: https://commits.webkit.org/282416.460@webkitglib/2.46


  Commit: 9d5c2bd8324dbe8364fa250ecf35f4ad59162cd2
  
https://github.com/WebKit/WebKit/commit/9d5c2bd8324dbe8364fa250ecf35f4ad59162cd2
  Author: Simon Fraser 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/rendering/LayerAncestorClippingStack.cpp

  Log Message:
  ---
  Cherry-pick 291279@main (5664e32a23f7). 
https://bugs.webkit.org/show_bug.cgi?id=288743

Rare crash in LayerAncestorClippingStack::updateScrollingNodeLayers()
https://bugs.webkit.org/show_bug.cgi?id=288743
rdar://145408197

Reviewed by Matt Woodrow.

Crash data suggests that `entry.overflowScrollProxyNodeID` can be unset 
here,
causing the `Markable<>` to release-assertion. So check it before use.

* Source/WebCore/rendering/LayerAncestorClippingStack.cpp:
(WebCore::LayerAncestorClippingStack::updateScrollingNodeLayers):

Canonical link: https://commits.webkit.org/291279@main

Canonical link: https://commits.webkit.org/282416.461@webkitglib/2.46


  Commit: 63851859470d7f7e4c6dfad4996636b8e6657af3
  
https://github.com/WebKit/WebKit/commit/63851859470d7f7e4c6dfad4996636b8e6657af3
  Author: Charlie Wolfe 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/loader/ResourceLoader.cpp

  Log Message:
  ---
  Cherry-pick 291002@main (5a12c77c8686). 
https://bugs.webkit.org/show_bug.cgi?id=288429

Null pointer dereference in `ResourceLoader::ResourceLoader`
https://bugs.webkit.org/show_bug.cgi?id=288429
rdar://80832481

Reviewed by Pascoe.

Crash logs indicate page can be null.

* Source/WebCore/loader/ResourceLoader.cpp:

Canonical link: https://commits.webkit.org/291002@main

Canonical link: https://commits.webkit.org/282416.462@webkitglib/2.46


Compare: https://github.com/WebKit/WebKit/compare/99dfdb3497c7...63851859470d

To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b25295: [JSC] Remove unnecessary std::forward in ensureValue

[Yijia Huang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b25295dc5b258307bae2f5c360c8b6ac5e153f63
  
https://github.com/WebKit/WebKit/commit/b25295dc5b258307bae2f5c360c8b6ac5e153f63
  Author: Yijia Huang 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/runtime/WeakGCMap.h

  Log Message:
  ---
  [JSC] Remove unnecessary std::forward in ensureValue
https://bugs.webkit.org/show_bug.cgi?id=289073
rdar://146087220

Reviewed by Yusuke Suzuki.

The std::forward(functor) in ensureValue was misleading because
HashMap::ensure takes the functor as a const reference and does not move it.
This change removes the unnecessary forwarding to improve code clarity
without affecting functionality.

* Source/JavaScriptCore/runtime/WeakGCMap.h:

Canonical link: https://commits.webkit.org/291563@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 077aa3: [tvOS] Enable support for dark mode CSS features

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 077aa3644b02beda995fe63c691c7a850ed519bc
  
https://github.com/WebKit/WebKit/commit/077aa3644b02beda995fe63c691c7a850ed519bc
  Author: Aditya Keerthi 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h

  Log Message:
  ---
  [tvOS] Enable support for dark mode CSS features
https://bugs.webkit.org/show_bug.cgi?id=289071
rdar://140241648

Reviewed by Abrar Rahman Protyasha.

`UIUserInterfaceStyleDark` has been supported on tvOS since tvOS 10. Enable dark
mode CSS features to remove an unnecessary platform difference.

* Source/WTF/wtf/PlatformEnableCocoa.h:

Canonical link: https://commits.webkit.org/291565@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 38ab57: [Gardening]: New Test (261136@main): [ macOS wk2 ]...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38ab57b466d50d54844c8014a994609bcd31d86e
  
https://github.com/WebKit/WebKit/commit/38ab57b466d50d54844c8014a994609bcd31d86e
  Author: Karl Rackler 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: New Test (261136@main): [ macOS wk2 ] 
http/wpt/background-fetch/background-fetch-abort.window.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=289092
rdar://146121067

Unreviewed test gardening.

Add test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/291569@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c0ad5f: [SwiftUI] Update WebPage.DialogPresenting to lates...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0ad5fdef496c172c4b7ab5c6e310e24d9b54790
  
https://github.com/WebKit/WebKit/commit/c0ad5fdef496c172c4b7ab5c6e310e24d9b54790
  Author: Richard Robinson 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebKit/UIProcess/API/Swift/WebPage+DialogPresenting.swift
M Source/WebKit/UIProcess/Cocoa/WKUIDelegateAdapter.swift
M Tools/SwiftBrowser/Source/ViewModel/DialogPresenter.swift

  Log Message:
  ---
  [SwiftUI] Update WebPage.DialogPresenting to latest interface (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=289113
rdar://146141183

Reviewed by Aditya Keerthi.

Rename DialogPresenting to WebPage.DialogPresenting.

* Source/WebKit/UIProcess/API/Swift/WebPage+DialogPresenting.swift:
(DialogPresenting.handleJavaScriptAlert(_:initiatedBy:)):
(DialogPresenting.handleJavaScriptConfirm(_:initiatedBy:)):
(DialogPresenting.handleJavaScriptPrompt(_:defaultText:initiatedBy:)):
(DialogPresenting.handleFileInputPrompt(_:initiatedBy:)):
* Source/WebKit/UIProcess/Cocoa/WKUIDelegateAdapter.swift:
* Tools/SwiftBrowser/Source/ViewModel/DialogPresenter.swift:

Canonical link: https://commits.webkit.org/291589@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c5b2c0: [Gardening] REGRESSION(290786@main): [ iOS ] 3 imp...

[karimiy21]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5b2c0d4c87b44078c726a5c5f8c62d7ba3efd87
  
https://github.com/WebKit/WebKit/commit/c5b2c0d4c87b44078c726a5c5f8c62d7ba3efd87
  Author: Yasmin Karimi 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [Gardening] REGRESSION(290786@main): [ iOS ] 3 
imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/*.html are 
constant failures.
https://bugs.webkit.org/show_bug.cgi?id=289115
rdar://146142722

Unreviewed test gardening.

Added test expectations for constantly failing tests.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/291592@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1ea802: Cherry-pick 291480@main (1fa7aa721e41). https://bu...

[Chris Dumez]

  Branch: refs/heads/webkitglib/2.48
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ea8027adcf3e1cdccdfae7d5b52a4aad9c8f896
  
https://github.com/WebKit/WebKit/commit/1ea8027adcf3e1cdccdfae7d5b52a4aad9c8f896
  Author: Jean-Yves Avenard 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  ---
  Cherry-pick 291480@main (1fa7aa721e41). 
https://bugs.webkit.org/show_bug.cgi?id=288948

com.apple.WebKit.WebContent at com.apple.WebCore:  
WebCore::HTMLMediaElement::removeVideoTrack
https://bugs.webkit.org/show_bug.cgi?id=288948
rdar://145510693

Reviewed by Tim Nguyen.

Fix bad copy/paste typo.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removeTextTrack):
(WebCore::HTMLMediaElement::removeVideoTrack):

Canonical link: https://commits.webkit.org/291480@main

Canonical link: https://commits.webkit.org/290945.8@webkitglib/2.48


  Commit: 2e6ed01ef7b73043f50d0038441d4213757fcf6d
  
https://github.com/WebKit/WebKit/commit/2e6ed01ef7b73043f50d0038441d4213757fcf6d
  Author: Adrian Perez de Castro 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/platform/SimpleCaretAnimator.cpp

  Log Message:
  ---
  Cherry-pick 291555@main (09ad2dad9a7a). 
https://bugs.webkit.org/show_bug.cgi?id=289007

REGRESSION(262954@main): [GTK] Attempts access to disengaged optional with 
caret blinking disabled
https://bugs.webkit.org/show_bug.cgi?id=289007

Reviewed by Carlos Garcia Campos.

* Source/WebCore/platform/SimpleCaretAnimator.cpp:
(WebCore::SimpleCaretAnimator::updateAnimationProperties): Always return
early when caret blinking is suspended, regardless of the current
blinking state; but nevertheless still schedule toggling the visibility
if needed.

Canonical link: https://commits.webkit.org/291555@main

Canonical link: https://commits.webkit.org/290945.9@webkitglib/2.48


  Commit: 9d36a951d14cb25a5cf2683c2e04b86bdadeb2b3
  
https://github.com/WebKit/WebKit/commit/9d36a951d14cb25a5cf2683c2e04b86bdadeb2b3
  Author: Yusuke Suzuki 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/heap/CompleteSubspace.cpp
M Source/JavaScriptCore/heap/IsoSubspace.cpp
M Source/JavaScriptCore/heap/MarkedSpace.cpp
M Source/JavaScriptCore/heap/MarkedSpace.h
M Source/JavaScriptCore/heap/PreciseSubspace.cpp

  Log Message:
  ---
  Cherry-pick 291381@main (a6bd280ee534). 
https://bugs.webkit.org/show_bug.cgi?id=288854

[JSC] Fix a bug not calling didAllocate for PreciseAllocation (from 
290699@main)
https://bugs.webkit.org/show_bug.cgi?id=288854
rdar://145872082

Reviewed by Yijia Huang.

290699@main accidentally removed didAllocate call for PreciseAllocation.
This patch fixes it. Also we use non default parameter to make
isNewAllocation parameter more explicit from the caller side.

* Source/JavaScriptCore/heap/CompleteSubspace.cpp:
(JSC::CompleteSubspace::tryAllocateSlow):
* Source/JavaScriptCore/heap/IsoSubspace.cpp:
(JSC::IsoSubspace::tryAllocateLowerTierPrecise):
* Source/JavaScriptCore/heap/MarkedSpace.cpp:
(JSC::MarkedSpace::registerPreciseAllocation):
* Source/JavaScriptCore/heap/MarkedSpace.h:
* Source/JavaScriptCore/heap/PreciseSubspace.cpp:
(JSC::PreciseSubspace::tryAllocate):

Canonical link: https://commits.webkit.org/291381@main

Canonical link: https://commits.webkit.org/290945.10@webkitglib/2.48


  Commit: 0f2e067916d2d07822e67913a2e19a95bbfb136d
  
https://github.com/WebKit/WebKit/commit/0f2e067916d2d07822e67913a2e19a95bbfb136d
  Author: Philippe Normand 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp

  Log Message:
  ---
  Cherry-pick 291316@main (7ba4483acaf3). 
https://bugs.webkit.org/show_bug.cgi?id=286527

[GStreamer] Incorrect uses of StringView::rawCharacters()
https://bugs.webkit.org/show_bug.cgi?id=286527

Reviewed by Xabier Rodriguez-Calvar.

Our use of StringView::rawCharacters() is incorrect, its value being 
lifetime bound, so instead,
convert the StringView to a local CString and refer to its data.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::isContentTypeSupported const):
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:
(WebCore::retrieveTemporalIndex):
* 
Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(transformCaps):
* Source/WebCore/platform/

[webkit-changes] [WebKit/WebKit] e1f5a7: [scroll-animations] WPT test `scroll-animations/cs...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1f5a7186f60055bb8e4b682556d73d2576c412e
  
https://github.com/WebKit/WebKit/commit/e1f5a7186f60055bb8e4b682556d73d2576c412e
  Author: Antoine Quint 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-multi-pass.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-dynamic-expected.txt
M Source/WebCore/animation/StyleOriginatedTimelinesController.cpp

  Log Message:
  ---
  [scroll-animations] WPT test 
`scroll-animations/css/view-timeline-dynamic.html` is a failure
https://bugs.webkit.org/show_bug.cgi?id=289084

Reviewed by Anne van Kesteren.

The reason we were failing the first test in the WPT test 
`scroll-animations/css/view-timeline-dynamic.html` was that
when a CSS Animation's timeline was changed to an inactive timeline (due to 
multiple possible timelines within the scope
defined by a parent element using the `timeline-scope` property) we would fail 
to mark that animation's target as dirty
and the timeline change would thus not be observable through the computed style.

To that end, we now catch the case where 
`StyleOriginatedTimelinesController::attachAnimation()` would yield an inactive
timeline due to a conflict related to `timeline-scope`, and keep that animation 
in `m_cssAnimationsPendingAttachment`
such that it will be re-considered at the end of the style update in 
`documentDidResolveStyle()`. At that juncture,
the timeline attachment will be re-considered and the target marked as dirty if 
necessary.

However, this fix alone changed the result of the "Animations prefer 
non-deferred timelines" test in the WPT test
`scroll-animations/css/timeline-scope.html`. Indeed, the reason we passed that 
test was precisely because of our old
behavior where we failed to mark style as dirty in case `timeline-scope` 
conflict would yield an inactive timeline.

To keep a passing result for this test we ensure that if we get into such a 
conflict, we still consider the current
element for a non-deferred timeline (ie. one that doesn't require 
`timeline-scope` to be in scope for this animation
target).

Those combined changes also progressed a part of 
`css/scroll-timeline-multi-pass.tentative.html` which no longer
logs an assertion failure through the console.

* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-multi-pass.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-dynamic-expected.txt:
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
(WebCore::StyleOriginatedTimelinesController::determineTreeOrder):
(WebCore::StyleOriginatedTimelinesController::attachAnimation):

Canonical link: https://commits.webkit.org/291574@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 92efb1: [Modern Media Controls] String "Source" is not loc...

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92efb14991fa3ac987090a3299b532128ccb7b02
  
https://github.com/WebKit/WebKit/commit/92efb14991fa3ac987090a3299b532128ccb7b02
  Author: Eric Carlson 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/en.lproj/modern-media-controls-localized-strings.js

  Log Message:
  ---
  [Modern Media Controls] String "Source" is not localized in the 'Show Media 
Stats' pane
https://bugs.webkit.org/show_bug.cgi?id=288977
rdar://146034469

Reviewed by Aditya Keerthi.

* Source/WebCore/en.lproj/modern-media-controls-localized-strings.js: Add 
"Source"

Canonical link: https://commits.webkit.org/291562@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bff585: Add Speedometer 3.1 to browserbench.org

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bff585117836f7a9d1a588654f23b8770fd1b1ee
  
https://github.com/WebKit/WebKit/commit/bff585117836f7a9d1a588654f23b8770fd1b1ee
  Author: Ryosuke Niwa 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
A Websites/browserbench.org/Speedometer3.1/Development.md
A Websites/browserbench.org/Speedometer3.1/Governance.md
A Websites/browserbench.org/Speedometer3.1/InteractiveRunner.html
A Websites/browserbench.org/Speedometer3.1/LICENSE
A Websites/browserbench.org/Speedometer3.1/README.md
A Websites/browserbench.org/Speedometer3.1/Testing.md
A Websites/browserbench.org/Speedometer3.1/about.html
A Websites/browserbench.org/Speedometer3.1/babel.config.json
A Websites/browserbench.org/Speedometer3.1/index.html
A Websites/browserbench.org/Speedometer3.1/instructions.html
A Websites/browserbench.org/Speedometer3.1/package-lock.json
A Websites/browserbench.org/Speedometer3.1/package.json
A Websites/browserbench.org/Speedometer3.1/resources/benchmark-runner.mjs
A Websites/browserbench.org/Speedometer3.1/resources/charts/README.md
A Websites/browserbench.org/Speedometer3.1/resources/charts/chartjs.html
A Websites/browserbench.org/Speedometer3.1/resources/charts/chartjs.js
A Websites/browserbench.org/Speedometer3.1/resources/charts/datasets/README
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/datasets/airports.csv
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/datasets/flights-airports.csv
A Websites/browserbench.org/Speedometer3.1/resources/charts/developer.html
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/assets/chartjs-7fd89fd7.js
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/assets/chartjs-7fd89fd7.js.map
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/assets/developer-4ed993c7.js.map
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/assets/flights-airports-9a9e6422.js
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/assets/flights-airports-9a9e6422.js.map
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/assets/index-4ed993c7.js.map
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/assets/plot-562fbdb6.js
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/assets/plot-562fbdb6.js.map
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/chartjs.html
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/developer.html
A Websites/browserbench.org/Speedometer3.1/resources/charts/dist/index.html
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/dist/observable-plot.html
A Websites/browserbench.org/Speedometer3.1/resources/charts/index.html
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/observable-plot.html
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/observable-plot.js
A 
Websites/browserbench.org/Speedometer3.1/resources/charts/package-lock.json
A Websites/browserbench.org/Speedometer3.1/resources/charts/package.json
A Websites/browserbench.org/Speedometer3.1/resources/charts/vite.config.js
A Websites/browserbench.org/Speedometer3.1/resources/developer-mode.mjs
A Websites/browserbench.org/Speedometer3.1/resources/editors/.gitignore
A Websites/browserbench.org/Speedometer3.1/resources/editors/README.md
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/assets/README.md
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/assets/longscript.js
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/assets/longtext.html
A Websites/browserbench.org/Speedometer3.1/resources/editors/codemirror.html
A Websites/browserbench.org/Speedometer3.1/resources/editors/codemirror.js
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/dist/assets/codemirror-521de7ab.js
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/dist/assets/codemirror-521de7ab.js.map
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/dist/assets/index-2feebe42.css
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/dist/assets/index.es-02a92ebc.js
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/dist/assets/index.es-02a92ebc.js.map
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/dist/assets/main-4ed993c7.js.map
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/dist/assets/tiptap-95a40ba8.js
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/dist/assets/tiptap-95a40ba8.js.map
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/dist/codemirror.html
A Websites/browserbench.org/Speedometer3.1/resources/editors/dist/index.html
A 
Websites/browserbench.org/Speedometer3.1/resources/editors/dist/tiptap.html
  

[webkit-changes] [WebKit/WebKit] 8a8e8d: [Gardening] REGRESSION(283087@main?): [ iOS ] impo...

[karimiy21]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a8e8d4349334d5f336a25368fa36d0185967678
  
https://github.com/WebKit/WebKit/commit/8a8e8d4349334d5f336a25368fa36d0185967678
  Author: Yasmin Karimi 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [Gardening] REGRESSION(283087@main?): [ iOS ] 
imported/w3c/web-platform-tests/css/css-view-transitions/transition-skipped-after-animation-started.html
 is a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=289109
rdar://146136540

Unreviewed test gardening.

Added a test expectation for a flakily crashing test.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/291587@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 055528: [Win] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0555285a920928611be75316b22d17db1ee35b48
  
https://github.com/WebKit/WebKit/commit/0555285a920928611be75316b22d17db1ee35b48
  Author: Fujii Hironori 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/win/TestExpectations

  Log Message:
  ---
  [Win] Unreviewed test gardening

* LayoutTests/platform/win/TestExpectations:

Canonical link: https://commits.webkit.org/291586@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 84bc12: "Response served by service worker has redirection...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 84bc127d4e4a6b2975f108cb4a962f36fd315341
  
https://github.com/WebKit/WebKit/commit/84bc127d4e4a6b2975f108cb4a962f36fd315341
  Author: Youenn Fablet 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
A 
LayoutTests/http/wpt/service-workers/redirect-flag-navigation-cache-worker.js
A 
LayoutTests/http/wpt/service-workers/redirect-flag-navigation-cache.https-expected.txt
A 
LayoutTests/http/wpt/service-workers/redirect-flag-navigation-cache.https.html
A 
LayoutTests/http/wpt/service-workers/resources/cached-after-redirection.html
A 
LayoutTests/http/wpt/service-workers/resources/cached-after-redirection.html.headers
A 
LayoutTests/http/wpt/service-workers/resources/redirect-to-cached-after-redirection.py
M Source/WebCore/workers/service/FetchEvent.cpp
M 
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp

  Log Message:
  ---
  "Response served by service worker has redirections" may appear with NVIDIA 
GeForce NOW
rdar://144571433
https://bugs.webkit.org/show_bug.cgi?id=289080

Reviewed by Brady Eidson.

When navigation preloader uses the disk cache, it may retrieve a response that 
was fetched via a redirection. Its isRedirected flag will be set to true.
Given navigation preloader retrieved this value from the cache without 
redirection, we need to set the flag to false.

Otherwise, later during loading, the navigation preload response would fail 
security checks.

* 
LayoutTests/http/wpt/service-workers/redirect-flag-navigation-cache-worker.js: 
Added.
(onfetch.e.e.respondWith.new.Promise):
* 
LayoutTests/http/wpt/service-workers/redirect-flag-navigation-cache.https-expected.txt:
 Added.
* 
LayoutTests/http/wpt/service-workers/redirect-flag-navigation-cache.https.html: 
Added.
* LayoutTests/http/wpt/service-workers/resources/cached-after-redirection.html: 
Added.
* 
LayoutTests/http/wpt/service-workers/resources/cached-after-redirection.html.headers:
 Added.
* 
LayoutTests/http/wpt/service-workers/resources/redirect-to-cached-after-redirection.py:
 Added.
(main):
* Source/WebCore/workers/service/FetchEvent.cpp:
(WebCore::FetchEvent::navigationPreloadIsReady):
* 
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp:
(WebKit::ServiceWorkerNavigationPreloader::didReceiveResponse):

Canonical link: https://commits.webkit.org/291561@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d8c643: [Gardening] [ wk2 ] imported/w3c/web-platform-test...

[karimiy21]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d8c6437999b3e077304e42fbf83bb60b239f8424
  
https://github.com/WebKit/WebKit/commit/d8c6437999b3e077304e42fbf83bb60b239f8424
  Author: Yasmin Karimi 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening] [ wk2 ] 
imported/w3c/web-platform-tests/webcodecs/audio-data.crossOriginIsolated.https.any.html
 is a flaky time out.
https://bugs.webkit.org/show_bug.cgi?id=289094
rdar://146121852

Unreviewed test gardening.

Added a test expectation for a flakily timing out test.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/291582@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3d340b: Unreviewed non-unified source build fix 2025-03 (p...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d340b11a6ae2c4517a9d37885e20771dbade13a
  
https://github.com/WebKit/WebKit/commit/3d340b11a6ae2c4517a9d37885e20771dbade13a
  Author: Fujii Hironori 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/runtime/MicrotaskQueue.cpp

  Log Message:
  ---
  Unreviewed non-unified source build fix 2025-03 (part 2)
https://bugs.webkit.org/show_bug.cgi?id=288990

* Source/JavaScriptCore/runtime/MicrotaskQueue.cpp:

Canonical link: https://commits.webkit.org/291596@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7b6930: [Gardening] [ macOS wk2 Debug arm64 ] http/tests/e...

[karimiy21]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b6930285583fc9fbb6dbda356a0def654ba7c95
  
https://github.com/WebKit/WebKit/commit/7b6930285583fc9fbb6dbda356a0def654ba7c95
  Author: Yasmin Karimi 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening] [ macOS wk2 Debug arm64 ] 
http/tests/eventsource/eventsource-reconnect.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=289127
rdar://146165288

Unreviewed test gardening.

Added a test expectation for a flakily failing test.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/291598@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e3d6e0: Use smart pointers in WebXROpaqueFramebuffer

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3d6e0875a7a26b3fe200084914de415ce5dc1c7
  
https://github.com/WebKit/WebKit/commit/e3d6e0875a7a26b3fe200084914de415ce5dc1c7
  Author: Mike Wyrzykowski 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h
M Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp
M Source/WebCore/html/canvas/WebGLUtilities.h

  Log Message:
  ---
  Use smart pointers in WebXROpaqueFramebuffer
https://bugs.webkit.org/show_bug.cgi?id=285629
rdar://122475331

Reviewed by Dan Glastonbury.

WebXROpaqueFramebuffer stored a C++ reference to the WebGL context,
but it is not clear who ensures the GL context is retained during
the lifetime of the WebXROpaqueFramebuffer.

Via code inspection, the out of bounds access should only occur
if the reference was invalid or, more likely, 
WebGLRenderingContextBase::initializeContextState()
was never called, in which case the store / resolve should be a nop.

* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):
Bail if the WeakPtr is null.

* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h:
Store a WeakPtr instead of a &.

* Source/WebCore/html/canvas/WebGLUtilities.h:
(WebCore::ScopedWebGLRestoreTexture::~ScopedWebGLRestoreTexture):
Ensure we don't access out of bounds in the texture units.

Canonical link: https://commits.webkit.org/291611@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 525bcf: [Safer CPP] Drop WebViewImpl.mm from UncountedLamb...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 525bcff5a71657880a48e871e964f677bd003856
  
https://github.com/WebKit/WebKit/commit/525bcff5a71657880a48e871e964f677bd003856
  Author: Chris Dumez 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M 
Source/WebKit/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  ---
  [Safer CPP] Drop WebViewImpl.mm from 
UncountedLambdaCapturesCheckerExpectations
https://bugs.webkit.org/show_bug.cgi?id=288992

Reviewed by Geoffrey Garen.

* Source/WebKit/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::handleLegacyFilesPasteboard):

Canonical link: https://commits.webkit.org/291610@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8d2272: Address Safer CPP failures in WebCore/Modules/inde...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8d22725db7d0e5cb8de208c864a426fdb36e1964
  
https://github.com/WebKit/WebKit/commit/8d22725db7d0e5cb8de208c864a426fdb36e1964
  Author: Chris Dumez 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp
M Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp
M Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp
M Source/WebCore/Modules/indexeddb/server/MemoryIndex.h
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.h
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations

  Log Message:
  ---
  Address Safer CPP failures in WebCore/Modules/indexeddb/server
https://bugs.webkit.org/show_bug.cgi?id=289069

Reviewed by Geoffrey Garen.

* Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
* Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::beginTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::clearObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::deleteIndex):
(WebCore::IDBServer::MemoryIDBBackingStore::renameIndex):
(WebCore::IDBServer::MemoryIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::deleteRange):
(WebCore::IDBServer::MemoryIDBBackingStore::addRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getCount):
(WebCore::IDBServer::MemoryIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::MemoryIDBBackingStore::revertGeneratedKeyNumber):
(WebCore::IDBServer::MemoryIDBBackingStore::maybeUpdateKeyGeneratorNumber):
(WebCore::IDBServer::MemoryIDBBackingStore::openCursor):
(WebCore::IDBServer::MemoryIDBBackingStore::addIndex):
(WebCore::IDBServer::MemoryIDBBackingStore::revertAddIndex):
(WebCore::IDBServer::MemoryIDBBackingStore::updateIndexRecordsWithIndexKey):
(WebCore::IDBServer::MemoryIDBBackingStore::forEachObjectStoreRecord):
* Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp:
(WebCore::IDBServer::MemoryIndex::getResultForKeyRange const):
(WebCore::IDBServer::MemoryIndex::getAllRecords const):
* Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/291609@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4fe385: Forcing VM mini mode should also force libpas mini...

[Ryan Reno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4fe385a64692137346a10f015213f1563124b663
  
https://github.com/WebKit/WebKit/commit/4fe385a64692137346a10f015213f1563124b663
  Author: Ryan Reno 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/JavaScriptCore/runtime/InitializeThreading.cpp
M Source/WTF/wtf/FastMalloc.cpp
M Source/WTF/wtf/FastMalloc.h
M Source/bmalloc/bmalloc/bmalloc.cpp
M Source/bmalloc/bmalloc/bmalloc.h

  Log Message:
  ---
  Forcing VM mini mode should also force libpas mini mode
https://bugs.webkit.org/show_bug.cgi?id=289119
rdar://146147679

Reviewed by Keith Miller.

We disable mini mode in libpas if the process is identified as either an
application or a WebKit XPC service. However, there is a JSC option to
force mini mode either via code or the __XPC_JSC_forceVMMiniMode
environment variable. We should force mini mode in libpas when this
option is set.

* Source/JavaScriptCore/runtime/InitializeThreading.cpp:
(JSC::initialize):
* Source/WTF/wtf/FastMalloc.cpp:
(WTF::fastEnableMiniMode):
* Source/WTF/wtf/FastMalloc.h:
* Source/bmalloc/bmalloc/bmalloc.cpp:
(bmalloc::api::enableMiniMode):
* Source/bmalloc/bmalloc/bmalloc.h:

Canonical link: https://commits.webkit.org/291612@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fc5d5f: [Gardening]: REGRESSION (291262@main): [ macOS Deb...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc5d5fe602507fb651dc145bb0cc0d4bc2cf7975
  
https://github.com/WebKit/WebKit/commit/fc5d5fe602507fb651dc145bb0cc0d4bc2cf7975
  Author: Karl Rackler 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (291262@main): [ macOS Debug wk2 ] 
ipc/serialized-type-info.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=289098
rdar://146127677

Unreviewed test gardening.

Add test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/291593@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b0612e: `webkitscmpy` should use the latest version of `we...

[Roy Reapor]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0612ecc21cbccb80d96d6530d4c1391999bc1b8
  
https://github.com/WebKit/WebKit/commit/b0612ecc21cbccb80d96d6530d4c1391999bc1b8
  Author: Roy Reapor 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/setup.py

  Log Message:
  ---
  `webkitscmpy` should use the latest version of `webkitbugspy`
https://bugs.webkit.org/show_bug.cgi?id=289089
rdar://146117842

Reviewed by Jonathan Bedard.

Forgot to version bump `setup.py`.

* Tools/Scripts/libraries/webkitscmpy/setup.py:

Canonical link: https://commits.webkit.org/291595@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] be1c3b: [Gardening] [ macOS wk2 ] imported/w3c/web-platfor...

[karimiy21]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be1c3b770bf8a6224cf69ca965eeefa612934167
  
https://github.com/WebKit/WebKit/commit/be1c3b770bf8a6224cf69ca965eeefa612934167
  Author: Yasmin Karimi 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations
A 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https-expected.png

  Log Message:
  ---
  [Gardening] [ macOS wk2 ] 
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https.html
 is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=289121
rdar://146159078

Unreviewed test gardening.

Added a test expectation for a flakily failing test.

* LayoutTests/platform/mac-wk2/TestExpectations:
* 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https-expected.png:
 Added.

Canonical link: https://commits.webkit.org/291597@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 647445: Move inline functions of Node class from Container...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 647445dd15fa6223ee4108d7d9c2c300323d88a1
  
https://github.com/WebKit/WebKit/commit/647445dd15fa6223ee4108d7d9c2c300323d88a1
  Author: Fujii Hironori 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/accessibility/AccessibilityMathMLElement.cpp
M Source/WebCore/accessibility/AccessibilityTree.cpp
M Source/WebCore/bindings/js/JSNodeCustom.h
M Source/WebCore/dom/ContainerNode.h
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/ElementAndTextDescendantIterator.h
M Source/WebCore/dom/EventPath.cpp
M Source/WebCore/dom/Node.h
M Source/WebCore/dom/NodeInlines.h
M Source/WebCore/dom/NodeTraversal.h
M Source/WebCore/dom/Position.h
M Source/WebCore/dom/PositionInlines.h
M Source/WebCore/dom/PositionIterator.cpp
M Source/WebCore/dom/PositionIterator.h
M Source/WebCore/dom/RangeBoundaryPoint.h
M Source/WebCore/dom/RangeBoundaryPointInlines.h
M Source/WebCore/editing/ApplyStyleCommand.cpp
M Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp
M Source/WebCore/editing/RenderedPosition.cpp
M Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp
M Source/WebCore/page/SpatialNavigation.cpp
M Source/WebCore/xml/XPathPath.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMNode.mm
M Tools/TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp

  Log Message:
  ---
  Move inline functions of Node class from ContainerNode.h to NodeInlines.h
https://bugs.webkit.org/show_bug.cgi?id=289026

Reviewed by Ryosuke Niwa.

Some inline functions of Node class were defined in ContainerNode.h.
 added NodeInlines.h. Move the
inline functions to NodeInlines.h.

* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/accessibility/AccessibilityMathMLElement.cpp:
* Source/WebCore/accessibility/AccessibilityTree.cpp:
* Source/WebCore/bindings/js/JSNodeCustom.h:
* Source/WebCore/dom/ContainerNode.h:
(WebCore::Node::countChildNodes const): Deleted.
(WebCore::Node::traverseToChildAt const): Deleted.
(WebCore::Node::firstChild const): Deleted.
(WebCore::Node::protectedFirstChild const): Deleted.
(WebCore::Node::lastChild const): Deleted.
(WebCore::Node::protectedLastChild const): Deleted.
(WebCore::Node::hasChildNodes const): Deleted.
(WebCore::Node::rootNode const): Deleted.
(WebCore::collectChildNodes): Deleted.
(WebCore::Node::setParentNode): Deleted.
(WebCore::Node::protectedParentNode const): Deleted.
* Source/WebCore/dom/Element.cpp:
* Source/WebCore/dom/ElementAndTextDescendantIterator.h:
* Source/WebCore/dom/EventPath.cpp:
* Source/WebCore/dom/Node.h:
* Source/WebCore/dom/NodeInlines.h:
(WebCore::Node::countChildNodes const):
(WebCore::Node::traverseToChildAt const):
(WebCore::Node::firstChild const):
(WebCore::Node::protectedFirstChild const):
(WebCore::Node::lastChild const):
(WebCore::Node::protectedLastChild const):
(WebCore::Node::hasChildNodes const):
(WebCore::Node::rootNode const):
(WebCore::Node::setParentNode):
(WebCore::Node::protectedParentNode const):
(WebCore::collectChildNodes):
* Source/WebCore/dom/NodeTraversal.h:
* Source/WebCore/dom/Position.h:
(WebCore::offsetIsBeforeLastNodeOffset): Deleted.
* Source/WebCore/dom/PositionInlines.h:
(WebCore::offsetIsBeforeLastNodeOffset):
* Source/WebCore/dom/PositionIterator.cpp:
(WebCore::PositionIterator::PositionIterator):
* Source/WebCore/dom/PositionIterator.h:
(WebCore::PositionIterator::PositionIterator): Deleted.
* Source/WebCore/dom/RangeBoundaryPoint.h:
(WebCore::RangeBoundaryPoint::set): Deleted.
* Source/WebCore/dom/RangeBoundaryPointInlines.h:
(WebCore::RangeBoundaryPoint::set):
* Source/WebCore/editing/ApplyStyleCommand.cpp:
* Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp:
* Source/WebCore/editing/RenderedPosition.cpp:
* Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp:
* Source/WebCore/page/SpatialNavigation.cpp:
* Source/WebCore/xml/XPathPath.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
* Tools/TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:

Canonical link: https://commits.webkit.org/291613@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] da9a70: Unreviewed, reverting 291554@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da9a704f045044bbef369550edc30fc07873e7b5
  
https://github.com/WebKit/WebKit/commit/da9a704f045044bbef369550edc30fc07873e7b5
  Author: Commit Queue 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebKit/Configurations/WebKitSwift.xcconfig
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Unreviewed, reverting 291554@main.
https://bugs.webkit.org/show_bug.cgi?id=289075

Broke build

Reverted changeset:

"Build fix for CredentialUpdaterShim"

https://bugs.webkit.org/show_bug.cgi?id=289014
https://commits.webkit.org/291554@main
Canonical link: https://commits.webkit.org/291557@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 35f649: [JSC] Array#includes / Array#indexOf inlined code ...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35f649ea5f5470b4059aff6a349e6db1371974e5
  
https://github.com/WebKit/WebKit/commit/35f649ea5f5470b4059aff6a349e6db1371974e5
  Author: Yusuke Suzuki 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
A JSTests/stress/array-includes-empty.js
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

  Log Message:
  ---
  [JSC] Array#includes / Array#indexOf inlined code should check empty value
https://bugs.webkit.org/show_bug.cgi?id=288597
rdar://145655237

Reviewed by Yijia Huang.

We need to check whether they are empty before doing cell check.
Also we remove some unnecessary code.

* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOfOrArrayIncludes):

Canonical link: https://commits.webkit.org/291556@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 812ee9: Build fix for CredentialUpdaterShim

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 812ee98cd2ef4ff0664e36b4bb4dd0d42b310ddf
  
https://github.com/WebKit/WebKit/commit/812ee98cd2ef4ff0664e36b4bb4dd0d42b310ddf
  Author: Pascoe 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
M Source/WebKit/Configurations/WebKitSwift.xcconfig
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Build fix for CredentialUpdaterShim
https://bugs.webkit.org/show_bug.cgi?id=289014
rdar://problem/146058465

Unreviewed, build fix.

This is required to build correctly under certain configurations.

* Source/WebKit/Configurations/WebKitSwift.xcconfig:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/291554@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 75f68a: [WebGPU] Ensure staticThreadgroupMemoryLength does...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75f68af5e660a28446d188bf1c450d524ac594f1
  
https://github.com/WebKit/WebKit/commit/75f68af5e660a28446d188bf1c450d524ac594f1
  Author: Tadeu Zagallo 
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
A LayoutTests/fast/webgpu/nocrash/fuzz-145583179-expected.txt
A LayoutTests/fast/webgpu/nocrash/fuzz-145583179.html
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/Types.cpp
M Source/WebGPU/WGSL/WGSLShaderModule.cpp
M Source/WebGPU/WGSL/WGSLShaderModule.h

  Log Message:
  ---
  [WebGPU] Ensure staticThreadgroupMemoryLength does not exceed device 
capabilities
https://bugs.webkit.org/show_bug.cgi?id=288735
rdar://145583179

Reviewed by Mike Wyrzykowski.

We currently compute the total size for all workgroup variables and validate 
that
they do not exceed the device limit, but the validation was not performed 
correctly
when an override variable was used as array size.

* LayoutTests/fast/webgpu/nocrash/fuzz-145583179-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-145583179.html: Added.
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::determineUsedGlobals):
* Source/WebGPU/WGSL/Types.cpp:
(WGSL::Type::size const):
* Source/WebGPU/WGSL/WGSLShaderModule.cpp:
(WGSL::ShaderModule::validateOverrides):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::addOverrideValidation):

Canonical link: https://commits.webkit.org/291558@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes