[webkit-changes] [WebKit/WebKit] 337620: REGRESSION(285507@main): [ macOS iOS Debug ] ASSER...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3376205b5d9b7ccf64b938731f37a9f086406b15
  
https://github.com/WebKit/WebKit/commit/3376205b5d9b7ccf64b938731f37a9f086406b15
  Author: Chris Dumez 
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/testing/MockPaymentCoordinator.cpp
M Source/WebCore/testing/MockPaymentCoordinator.h

  Log Message:
  ---
  REGRESSION(285507@main): [ macOS iOS Debug ] ASSERTION FAILED: showCount == 
hideCount in virtual WebCore::MockPaymentCoordinator result of crash in ApplePay
https://bugs.webkit.org/show_bug.cgi?id=282003
rdar://138506302

Reviewed by Per Arne Vollan.

In 285507@main, MockPaymentCoordinator was made ref-counted, which means its
lifetime can now get extended. This means that when a MockPaymentCoordinator
get replaced with another, 2 MockPaymentCoordinator instance can be alive at
the same time, temporarily.

The assertion in the MockPaymentCoordinator destructor checks that the
coordinator has shown as many dialogs as it has hidden. However, this check
relies on global static variables. This used to work fine when only one
MockPaymentCoordinator could be alive at the same time. However, now that
this is no longer true, the assertion can be hit because a new 
MockPaymentCoordinator
instance may have shown a dialog before the previous MockPaymentCoordinator
got a chance to get destroyed.

To address the issue, I converted this global variables into data members.

* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::~MockPaymentCoordinator):
(WebCore::MockPaymentCoordinator::dispatchIfShowing):
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::cancelPayment):
(WebCore::MockPaymentCoordinator::completePaymentSession):
(WebCore::MockPaymentCoordinator::abortPaymentSession):
(WebCore::MockPaymentCoordinator::cancelPaymentSession):
* Source/WebCore/testing/MockPaymentCoordinator.h:

Canonical link: https://commits.webkit.org/285653@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aeacdd: Inputs with overflowing content cannot be scrolled...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aeacdd2cd7d9d2d77cc232b524975ee2f0815191
  
https://github.com/WebKit/WebKit/commit/aeacdd2cd7d9d2d77cc232b524975ee2f0815191
  Author: Wenson Hsieh 
  Date:   2024-10-23 (Wed, 23 Oct 2024)

  Changed paths:
A 
LayoutTests/editing/selection/ios/autoscroll-text-field-in-subframe-expected.txt
A LayoutTests/editing/selection/ios/autoscroll-text-field-in-subframe.html
M Source/WebCore/page/EventHandler.h
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/ios/EventHandlerIOS.mm
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  ---
  Inputs with overflowing content cannot be scrolled within an iFrame.
https://bugs.webkit.org/show_bug.cgi?id=277666
rdar://133320357

Reviewed by Abrar Rahman Protyasha.

Add support on iOS for selection autoscrolling, for content inside subframes. 
See below for more
details.

* 
LayoutTests/editing/selection/ios/autoscroll-text-field-in-subframe-expected.txt:
 Added.
* LayoutTests/editing/selection/ios/autoscroll-text-field-in-subframe.html: 
Added.

Add a layout test to exercise this fix. Note that the test will attempt to 
autoscroll against the
right edge of the focused input until it reaches the last selection offset, 
such that it will be
robust even if the maximum autoscrolling speed is lowered in the future.

* Source/WebCore/page/EventHandler.h:
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::setFocusedFrame):

Stop autoscrolling when a frame is no longer focused; this is necessary because 
it's no longer
guaranteed that `WebPage::cancelAutoscroll` will cancel autoscrolling in the 
correct frame, in the
case where the frame was blurred in the middle of autoscrolling.

* Source/WebCore/page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::startSelectionAutoscroll):
(WebCore::EventHandler::cancelSelectionAutoscroll):
(WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll const):

Avoid adjusting the target autoscroll position for subframes, since the edges 
of the unobscured
content rect aren't flush with the edges of the layout viewport.

* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::startAutoscrollAtPosition):

Implement the main fix here — instead of always using the local main frame, 
tell the focused or main
frame to autoscroll.

(WebKit::WebPage::cancelAutoscroll):

Canonical link: https://commits.webkit.org/285635@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 70483d: Cleanup DisplayListItem applyFilteredImageBufferIt...

[Nikolas Zimmermann]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70483d4c1a0f9914c7d7fcc763717c7c85cbd70e
  
https://github.com/WebKit/WebKit/commit/70483d4c1a0f9914c7d7fcc763717c7c85cbd70e
  Author: Nikolas Zimmermann 
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
M Source/WebCore/platform/graphics/displaylists/DisplayListItem.cpp

  Log Message:
  ---
  Cleanup DisplayListItem applyFilteredImageBufferItem() function
https://bugs.webkit.org/show_bug.cgi?id=282005

Reviewed by Adrian Perez de Castro.

Apply Saids post-land comment from PR 35576: make the
applyFilteredImageBufferItem() function more readable.

Covered by existing tests.

* Source/WebCore/platform/graphics/displaylists/DisplayListItem.cpp:
(WebCore::DisplayList::applyFilteredImageBufferItem):

Canonical link: https://commits.webkit.org/285657@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 019a91: [GStreamer][WebCodecs] H.264 encoding fixes

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 019a912ac61b2e8323294984123635caba20083a
  
https://github.com/WebKit/WebKit/commit/019a912ac61b2e8323294984123635caba20083a
  Author: Philippe Normand 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_baseline-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_high-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_main-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_baseline-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_high-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_main-expected.txt
M Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp
M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebCodecs] H.264 encoding fixes
https://bugs.webkit.org/show_bug.cgi?id=281977

Reviewed by Xabier Rodriguez-Calvar.

While debugging some mediarecorder test failure a caps negotiation issue was 
detected in our video
encoder. Encodebin2 was expecting an avc stream on the encoder output. Updating 
our encoder
accordingly made some WebCodec tests pass. In addition to that change, the X264 
encoder is
explicitely configured according to the requested H.264 profile.

* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_baseline-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_high-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_main-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_baseline-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_high-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_main-expected.txt:
 Removed.
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(webkit_video_encoder_class_init):

Canonical link: https://commits.webkit.org/285691@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7d575e: Default AbortSignal's reason to AbortError

[Marais Rossouw]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d575e9f5b200225c8feb627db492ee92ad1e5b6
  
https://github.com/WebKit/WebKit/commit/7d575e9f5b200225c8feb627db492ee92ad1e5b6
  Author: Marais Rossouw 
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
M Source/WebCore/dom/AbortController.cpp
M Source/WebCore/dom/AbortController.h
M Source/WebCore/dom/AbortController.idl
M Source/WebCore/dom/AbortSignal.cpp
M Source/WebCore/dom/InternalObserverFirst.cpp
M Source/WebCore/dom/Subscriber.cpp

  Log Message:
  ---
  Default AbortSignal's reason to AbortError
https://bugs.webkit.org/show_bug.cgi?id=281961

Reviewed by Chris Dumez.

The DOM specification for AbortSignal states that if no reason is provided,
to default or fallback to a DOMException AbortError. This pull request moves 
this
logic from the AbortController's abort method to AbortSignal's signalAbort 
method,
where it rightly belongs.

As specified in the AbortSignal spec, 
https://dom.spec.whatwg.org/#abortsignal-signal-abort, step 2:

> Set signal's abort reason to reason if it is provided; otherwise, to a new 
> "AbortError" DOMException.

In contrast, the AbortController spec, 
https://dom.spec.whatwg.org/#abortcontroller which simply states:

> The abort(reason) method steps are to signal abort on this with reason if it 
> is provided.

It does not mention the default behavior. Essentially, we're shifting this 
logic from
AbortController:abort to its encapsulated AbortSignal:signalAbort method.

* Source/WebCore/dom/AbortController.cpp:
(WebCore::AbortController::abort):
  Removes default reason, to simply forward it to the
  encapsulated AbortSignal:signalAbort.
* Source/WebCore/dom/AbortController.h:
* Source/WebCore/dom/AbortController.idl:
  We should not "[CallWith=CurrentGlobalObject]" for the abort method,
  instead use the GlobalObject the controller was constructed with.
* Source/WebCore/dom/AbortSignal.cpp:
(WebCore::AbortSignal::signalAbort):
  Logic implemented as description reads.
* Source/WebCore/dom/Subscriber.cpp:
(WebCore::Subscriber::close):
  AbortController::abort no longer accepts a globalObject, so removed
  the callsite reference.
* Source/WebCore/dom/InternalObserverFirst.cpp:
  AbortController::abort no longer accepts a globalObject, so removed
  the callsite reference.

Canonical link: https://commits.webkit.org/285686@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 241c80: Fix incorrect heap range assumption in B3LowerInt64

[aoikonomopoulos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 241c8040ba4dcbc7894c9f9cfa955cf4b5595631
  
https://github.com/WebKit/WebKit/commit/241c8040ba4dcbc7894c9f9cfa955cf4b5595631
  Author: Angelos Oikonomopoulos 
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
M Source/JavaScriptCore/b3/B3LowerInt64.cpp

  Log Message:
  ---
  Fix incorrect heap range assumption in B3LowerInt64
https://bugs.webkit.org/show_bug.cgi?id=282043

Reviewed by Yusuke Suzuki.

A memory access may reference an arbitrarily large area.

* Source/JavaScriptCore/b3/B3LowerInt64.cpp:

Canonical link: https://commits.webkit.org/285660@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7b5785: Implement Observable#forEach

[Marais Rossouw]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b5785e176c2c2c256da316e0ad378e927a404b9
  
https://github.com/WebKit/WebKit/commit/7b5785e176c2c2c256da316e0ad378e927a404b9
  Author: Marais Rossouw 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-forEach.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-forEach.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-forEach.window-expected.txt
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/dom/InternalObserverForEach.cpp
A Source/WebCore/dom/InternalObserverForEach.h
M Source/WebCore/dom/Observable.cpp
M Source/WebCore/dom/Observable.h
M Source/WebCore/dom/Observable.idl
A Source/WebCore/dom/VisitorCallback.h
A Source/WebCore/dom/VisitorCallback.idl

  Log Message:
  ---
  Implement Observable#forEach
https://bugs.webkit.org/show_bug.cgi?id=277510

Reviewed by Chris Dumez.

This change introduces the `.forEach` promise-returning operator
for Observables, using the InternalObserver and subscribes immediately.
This is required by the specification 
https://wicg.github.io/observable/#dom-observable-foreach.

This change also includes a new VisitorCallback IDL which represents a callback
that receives each value of an Subscription, which unlike MapperCallback, does 
not return a value.

* 
LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-forEach.any-expected.txt:
 Rebaselined.
* 
LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-forEach.any.worker-expected.txt:
 Rebaselined.
* 
LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-forEach.window-expected.txt:
 Rebaselined.
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/InternalObserverForEach.cpp: Added.
(WebCore::createInternalObserverOperatorForEach):
* Source/WebCore/dom/InternalObserverForEach.h: Added.
* Source/WebCore/dom/Observable.cpp:
(WebCore::Observable::forEach):
* Source/WebCore/dom/Observable.h:
* Source/WebCore/dom/Observable.idl:
  Exposes the `Promise forEach(callback, options)`.
* Source/WebCore/dom/VisitorCallback.h: Added.
* Source/WebCore/dom/VisitorCallback.idl: Added.

Canonical link: https://commits.webkit.org/285693@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e02197: [GStreamer][WebCodecs] Hardware decoding hints sup...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e02197ab6c7e3a45c42007dcb885e8fece6cc05c
  
https://github.com/WebKit/WebKit/commit/e02197ab6c7e3a45c42007dcb885e8fece6cc05c
  Author: Philippe Normand 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebCodecs] Hardware decoding hints support
https://bugs.webkit.org/show_bug.cgi?id=281985

Reviewed by Xabier Rodriguez-Calvar.

Take `prefer-hardware` HardwareAcceleration config option as a hint to select 
video decoders. If no
hardware decoder is found for the given codec, fallback to software decoder 
lookup.

* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp:
(WebCore::GStreamerVideoDecoder::create):

Canonical link: https://commits.webkit.org/285692@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cbe4ac: REGRESSION(285517@main): fast/forms/state-restore-...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cbe4acf30533396fa64369844d8311dab7945fd2
  
https://github.com/WebKit/WebKit/commit/cbe4acf30533396fa64369844d8311dab7945fd2
  Author: Charlie Wolfe 
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
M LayoutTests/fast/forms/resources/state-restore-broken-state-2.html

  Log Message:
  ---
  REGRESSION(285517@main): fast/forms/state-restore-broken-state.html is a 
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=282058
rdar://138579833

Reviewed by Alex Christensen.

285517@main added async IPC to 
`internals.setFormControlStateOfPreviousHistoryItem` that must complete
before calling `didLoadAnotherDocument`.

* LayoutTests/fast/forms/resources/state-restore-broken-state-2.html:

Canonical link: https://commits.webkit.org/285665@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c0f2f4: [css-anchor-position-1] Implement parsing support ...

[Pawel Lampe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0f2f40263ccd2bb5b7f407e124c84f85aead44e
  
https://github.com/WebKit/WebKit/commit/c0f2f40263ccd2bb5b7f407e124c84f85aead44e
  Author: Pawel Lampe 
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-center-001-expected.txt
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.h

  Log Message:
  ---
  [css-anchor-position-1] Implement parsing support for anchor-center value
https://bugs.webkit.org/show_bug.cgi?id=281846

Reviewed by Tim Nguyen.

This change adds parsing support for `anchor-center` CSS value as specified in:
https://drafts.csswg.org/css-anchor-position-1/#anchor-center

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-center-001-expected.txt:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp:
(WebCore::CSSPropertyParserHelpers::isSelfPositionKeyword):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentOffset):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisPositionForGridItem const):
(WebCore::RenderGrid::rowAxisPositionForGridItem const):
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:

Canonical link: https://commits.webkit.org/285641@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d99e05: Fix a smart pointer warning in SingleTimelineRange...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d99e05839a170b38ce41abcd66c76f75db0c4f09
  
https://github.com/WebKit/WebKit/commit/d99e05839a170b38ce41abcd66c76f75db0c4f09
  Author: Ryosuke Niwa 
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
M Source/WebCore/animation/TimelineRange.cpp

  Log Message:
  ---
  Fix a smart pointer warning in SingleTimelineRange::lengthForCSSValue
https://bugs.webkit.org/show_bug.cgi?id=282066

Reviewed by Tim Nguyen.

Deployed more smart pointer to address a recent regression.

* Source/WebCore/animation/TimelineRange.cpp:
(WebCore::SingleTimelineRange::lengthForCSSValue):

Canonical link: https://commits.webkit.org/285674@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f8da08: [Spatial Video] Controls not always showing when i...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8da0855d4f21c299687e8463cdb40cc369227e4
  
https://github.com/WebKit/WebKit/commit/f8da0855d4f21c299687e8463cdb40cc369227e4
  Author: Jean-Yves Avenard 
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

  Log Message:
  ---
  [Spatial Video] Controls not always showing when in spatial portal
https://bugs.webkit.org/show_bug.cgi?id=282041
rdar://136814882

Reviewed by Jer Noble.

We set our `PlayableViewController`'s automaticallyDockOnFullScreenPresentation 
property to true
whenever the docking icon was being displayed. This affected the presence of 
the controls being shown
when entered in spatial portal.
As a workaround, we set it back to `NO` if the "enter spatial" button is 
clicked on.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController _enterVideoFullscreenAction:]):

Canonical link: https://commits.webkit.org/285658@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 83dcd4: [scroll-animations] Have animation-range parsing h...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83dcd4537698ccc0d6bbbfc6b636a95dec36403d
  
https://github.com/WebKit/WebKit/commit/83dcd4537698ccc0d6bbbfc6b636a95dec36403d
  Author: Nikolaos Mouchtaris 
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-end-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-end-valid-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-shorthand-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-start-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-start-valid-expected.txt
M Source/WebCore/animation/TimelineRange.cpp
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.h

  Log Message:
  ---
  [scroll-animations] Have animation-range parsing handle sequences
https://bugs.webkit.org/show_bug.cgi?id=282004
rdar://138507260

Reviewed by Tim Nguyen.

Handle comma seperated sequences of animation ranges.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-end-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-end-valid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-shorthand-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-shorthand.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-start-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-start-valid-expected.txt:
* Source/WebCore/animation/TimelineRange.cpp:
(WebCore::SingleTimelineRange::parse):
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::serializeSingleAnimationRange const):
(WebCore::ShorthandSerializer::serializeAnimationRange const):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeAnimationRangeShorthand):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.cpp:
(WebCore::CSSPropertyParserHelpers::consumeAnimationRange):
(WebCore::CSSPropertyParserHelpers::consumeAnimationRangeStart):
(WebCore::CSSPropertyParserHelpers::consumeAnimationRangeEnd):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.h:

Canonical link: https://commits.webkit.org/285656@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4d92f5: [CoordinatedGraphics] Simplify tiled backing store...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d92f5fd6e60dd6bd687da9025b51172ab792c73
  
https://github.com/WebKit/WebKit/commit/4d92f5fd6e60dd6bd687da9025b51172ab792c73
  Author: Carlos Garcia Campos 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/platform/SourcesNicosia.txt
M Source/WebCore/platform/TextureMapper.cmake
R Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.cpp
R Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.h
M Source/WebCore/platform/graphics/nicosia/NicosiaCompositionLayer.h
M Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.cpp
M 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp
M 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStore.h
M 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStoreProxy.cpp
M 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStoreProxy.h
R 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStoreProxyClient.h
M 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
M 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsScene.cpp
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsScene.h
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp

  Log Message:
  ---
  [CoordinatedGraphics] Simplify tiled backing store handling
https://bugs.webkit.org/show_bug.cgi?id=280606

Reviewed by Miguel Gomez.

Remove NicosiaBackingStore and handle the updates in 
CoordinatedBackingStoreProxy.

* Source/WebCore/platform/SourcesNicosia.txt:
* Source/WebCore/platform/TextureMapper.cmake:
* Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.cpp: Removed.
* Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.h: Removed.
* Source/WebCore/platform/graphics/nicosia/NicosiaCompositionLayer.h:
* Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.cpp:
(Nicosia::SceneIntegration::UpdateScope::~UpdateScope):
* 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStore::createTile):
(WebCore::CoordinatedBackingStore::resize):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
* 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStoreProxy.cpp:
(WebCore::CoordinatedBackingStoreProxy::Update::appendUpdate):
(WebCore::CoordinatedBackingStoreProxy::create):
(WebCore::CoordinatedBackingStoreProxy::CoordinatedBackingStoreProxy):
(WebCore::CoordinatedBackingStoreProxy::updateIfNeeded):
(WebCore::CoordinatedBackingStoreProxy::createOrDestroyTiles):
(WebCore::CoordinatedBackingStoreProxy::takePendingUpdate):
* 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStoreProxy.h:
(WebCore::CoordinatedBackingStoreProxy::client): Deleted.
(WebCore::CoordinatedBackingStoreProxy::contentsScale const): Deleted.
(WebCore::CoordinatedBackingStoreProxy::coverRect const): Deleted.
(WebCore::CoordinatedBackingStoreProxy::Tile::Tile): Deleted.
(WebCore::CoordinatedBackingStoreProxy::Tile::resize): Deleted.
(WebCore::CoordinatedBackingStoreProxy::Tile::addDirtyRect): Deleted.
(WebCore::CoordinatedBackingStoreProxy::Tile::isDirty const): Deleted.
(WebCore::CoordinatedBackingStoreProxy::Tile::markClean): Deleted.
* 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStoreProxyClient.h:
 Removed.
* 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
* 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::updateBackingStore):
(WebKit::CoordinatedGraphicsScene::removeLayer):
(WebKit::CoordinatedGraphicsScene::updateSceneState):
(WebKit::CoordinatedGraphicsScene::purgeGLResources):
(WebKit::removeLayer): Deleted.
* 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsScene.h:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::flushLayers):

Canonical link: https://commits.webkit.org/285694@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6323a0: [GStreamer] Video encoder and decoder don't need t...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6323a0f54b4195636bae313b7b302c33823cec68
  
https://github.com/WebKit/WebKit/commit/6323a0f54b4195636bae313b7b302c33823cec68
  Author: Philippe Normand 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.h

  Log Message:
  ---
  [GStreamer] Video encoder and decoder don't need to be guarded by WEB_CODECS 
ifdefs
https://bugs.webkit.org/show_bug.cgi?id=281980

Reviewed by Xabier Rodriguez-Calvar.

WEB_CODECS dependency was removed in 272760@main and 285601@main.

* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp:
* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.h:

Canonical link: https://commits.webkit.org/285695@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f076fd: [WPE] WPE Platform: Add WPESettings API

[Patrick]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f076fdf8692a441dce2b82f193b8976d4436d424
  
https://github.com/WebKit/WebKit/commit/f076fdf8692a441dce2b82f193b8976d4436d424
  Author: Patrick Griffis 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebKit/WPEPlatform/CMakeLists.txt
M Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp
M Source/WebKit/WPEPlatform/wpe/WPEDisplay.h
A Source/WebKit/WPEPlatform/wpe/WPESettings.cpp
A Source/WebKit/WPEPlatform/wpe/WPESettings.h
M Tools/Scripts/run-wpe-tests
A Tools/TestWebKitAPI/Tests/WPEPlatform/TestSettings.cpp
M Tools/TestWebKitAPI/glib/CMakeLists.txt

  Log Message:
  ---
  [WPE] WPE Platform: Add WPESettings API
https://bugs.webkit.org/show_bug.cgi?id=280618

Reviewed by Carlos Garcia Campos.

This adds an API to store generic settings similar to GSettings.

Each setting has a known type and default value.

These settings can be saved and loaded from key files.

* Source/WebKit/WPEPlatform/CMakeLists.txt:
* Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp:
(wpe_display_get_settings):
* Source/WebKit/WPEPlatform/wpe/WPEDisplay.h:
* Source/WebKit/WPEPlatform/wpe/WPESettings.cpp: Added.
(SettingEntry::SettingEntry):
(SettingEntry::value const):
(wpe_settings_get_default):
(makeKeyPath):
(wpe_settings_register):
(wpe_settings_load_from_keyfile):
(wpe_settings_save_to_keyfile):
(wpe_settings_set_value):
(wpe_settings_get_value):
* Source/WebKit/WPEPlatform/wpe/WPESettings.h: Added.
* Tools/Scripts/run-wpe-tests:
(WPETestRunner):
(WPETestRunner.is_glib_test):
* Tools/TestWebKitAPI/Tests/WPEPlatform/TestSettings.cpp: Added.
(testSettingsRegistration):
(testSettingsSaveKeyFiles):
(testSettingsLoadKeyFiles):
(testSettingsChangedSignal):
(testSettingsHelperAPI):
(beforeAll):
(afterAll):
* Tools/TestWebKitAPI/glib/CMakeLists.txt:

Canonical link: https://commits.webkit.org/285702@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 31e806: Remove RSAES-pkcs1-v1.5 support

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31e806507852348d649add0eab1363d9a1fdab12
  
https://github.com/WebKit/WebKit/commit/31e806507852348d649add0eab1363d9a1fdab12
  Author: Nitin Mahendru 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk-expected.txt
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk.html
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8-expected.txt
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8.html
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki-expected.txt
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki.html
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt-expected.txt
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt.html
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-expected.txt
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable-expected.txt
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable.html
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key.html
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key-expected.txt
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key.html
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages-expected.txt
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages.html
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-expected.txt
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero-expected.txt
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum-expected.txt
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum.html
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable-expected.txt
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable.html
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key.html
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt-expected.txt
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt-expected.txt
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key-expected.txt
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key.html
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages-expected.txt
R 
LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages.html
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-expected.txt
R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key.html
R LayoutTests/crypto/workers/subtle/rsa-postMessage-worker-expected.txt
R LayoutTests/crypto/workers/subtle/rsa-postMessage-worker.html
R 
LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-decrypt-expected.txt
R LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html
R 
LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-encrypt-expected.txt
R LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Sources.txt
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/crypto/SubtleCrypto.cpp
R Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp
R Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h
R Source/WebCore/crypto/cocoa/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmRegistryMac.cpp
R Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp
M Source/WebCore/crypto/gcrypt/CryptoAlgorithmRegistryGCrypt.cpp
R Source/WebCore/crypto/openssl/CryptoAlgorithmRSAES_PKCS1_v1_5OpenSSL.cpp
M Source/WebCore/crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp
M Source/WebCore/platform/OpenSSL.cmake
M Source/WebCore/platform/SourcesGCrypt.txt

  Log Message:
  ---
  Remove RSAES-pkcs1-v1.5 support
https://bugs.webkit.org/show_bug.cgi?id=281144
rdar://137603955

Reviewed by David Kilzer and Youenn Fablet.

It is already deprecated in chrome and firefox and we have had it disabled by 
default for some
time now. See: https://commits.webkit.org/259018@main

It should be safe to just remove it now as we haven't heard any claims.
It's an algorithm with a long history of issues and should not be used.
mor

[webkit-changes] [WebKit/WebKit] 5cb898: Web Extensions fail to load Chinese localizations.

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cb898d5fbec7dca0ad41e125b5be9199cc2175d
  
https://github.com/WebKit/WebKit/commit/5cb898d5fbec7dca0ad41e125b5be9199cc2175d
  Author: Timothy Hatcher 
  Date:   2024-10-23 (Wed, 23 Oct 2024)

  Changed paths:
M Source/WTF/wtf/Language.cpp
M Source/WTF/wtf/Language.h
M Source/WTF/wtf/cocoa/LanguageCocoa.mm
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebKit/Shared/Extensions/_WKWebExtensionLocalization.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
M Source/WebKit/UIProcess/Extensions/WebExtension.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPILocalization.mm

  Log Message:
  ---
  Web Extensions fail to load Chinese localizations.
https://webkit.org/b/281928
rdar://problem/138435009

Reviewed by Brian Weinstein.

* Improve best match logic by using `indexOfBestMatchingLanguageInList()` with 
the extension's
  supported locales. This properly handles Chinese script codes.
* Add error handling for `default_locale` by validating it against the locales 
provided in the
  extension's `_locales` directory.

* Source/WTF/wtf/Language.cpp:
(WTF::canonicalLanguageIdentifier): Simplified to handle more than 2 parts.
(WTF::parseLocale): Added.
(WTF::indexOfBestMatchingLanguageInList): Simplified and use canonicalized 
input.
* Source/WTF/wtf/Language.h:
* Source/WTF/wtf/cocoa/LanguageCocoa.mm:
(WTF::parseLocale): Added.
* Source/WebCore/en.lproj/Localizable.strings: Updated.
* Source/WebKit/Shared/Extensions/_WKWebExtensionLocalization.mm:
(-[_WKWebExtensionLocalization initWithWebExtension:]): Use new helpers from 
WebExtension
to load the three possible localization dictionaries.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm:
(-[WKWebExtension defaultLocale]): Make the `NSLocale` here.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::parseManifest): Add error handling for `default_locale`.
(WebKit::WebExtension::preferredSystemLocales): Added.
(WebKit::WebExtension::parseLocale): Added.
(WebKit::WebExtension::defaultLocale): Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::toAPI): Added InvalidDefaultLocale error.
(WebKit::WebExtension::createError): Ditto.
(WebKit::WebExtension::supportedLocales): Added.
(WebKit::WebExtension::defaultLocale): Added.
(WebKit::WebExtension::bestMatchLocale): Added.
* Source/WebKit/UIProcess/Extensions/WebExtension.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST(WKWebExtension, DefaultLocaleParsing)): Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPILocalization.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, i18nWithFallback)): Force 
`en-US` to match expectations.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, i18nChineseSimplified)): 
Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nChineseSimplifiedOnly)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nChineseSimplifiedScript)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, i18nChineseTraditional)): 
Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nChineseSimplifiedInTaiwan)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nChineseTraditionalInChina)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nChineseSimplifiedInHongKong)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nChineseTraditionalOnly)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nChineseTraditionalScript)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nChineseLanguageFallback)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, i18nPortugueseBrazilian)): 
Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, i18nPortugueseEuropean)): 
Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nPortugueseUnitedStates)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nPortugueseUnitedStatesFallbackToBrazilian)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nPortugueseUnitedStatesFallbackToGeneric)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPILocalization, 
i18nPortugueseLanguageFallback)): Added.

Canonical link: https://commits.webkit.org/285633@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 42d585: [Nicosia] Make NicosiaPaintEngine cairo specific

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42d585435d455ca116928ca26eacc24976e91c48
  
https://github.com/WebKit/WebKit/commit/42d585435d455ca116928ca26eacc24976e91c48
  Author: Carlos Garcia Campos 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/platform/TextureMapper.cmake
M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContext.cpp
M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContext.h
M Source/WebCore/platform/graphics/nicosia/NicosiaPaintingOperation.h
M 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp
M 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h
R 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.cpp
R 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.h
R 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaPaintingOperationReplayCairo.h

  Log Message:
  ---
  [Nicosia] Make NicosiaPaintEngine cairo specific
https://bugs.webkit.org/show_bug.cgi?id=282087

Reviewed by Miguel Gomez.

This is only used by cairo nowadays, and cairo has always been the only 
implementation.

* Source/WebCore/platform/TextureMapper.cmake:
* Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContext.cpp:
(Nicosia::PaintingContext::createForPainting):
(Nicosia::PaintingContext::createForRecording):
(Nicosia::PaintingContext::PaintingContext):
(Nicosia::PaintingContext::~PaintingContext):
(Nicosia::PaintingContext::replay):
* Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContext.h:
(Nicosia::PaintingContext::graphicsContext):
* Source/WebCore/platform/graphics/nicosia/NicosiaPaintingOperation.h:
* 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::CairoOperationRecorder::didUpdateState):
(Nicosia::CairoOperationRecorder::setLineCap):
(Nicosia::CairoOperationRecorder::setLineDash):
(Nicosia::CairoOperationRecorder::setLineJoin):
(Nicosia::CairoOperationRecorder::setMiterLimit):
(Nicosia::CairoOperationRecorder::fillRect):
(Nicosia::CairoOperationRecorder::fillRoundedRect):
(Nicosia::CairoOperationRecorder::fillRectWithRoundedHole):
(Nicosia::CairoOperationRecorder::fillPath):
(Nicosia::CairoOperationRecorder::fillEllipse):
(Nicosia::CairoOperationRecorder::strokeRect):
(Nicosia::CairoOperationRecorder::strokePath):
(Nicosia::CairoOperationRecorder::strokeEllipse):
(Nicosia::CairoOperationRecorder::clearRect):
(Nicosia::CairoOperationRecorder::drawGlyphs):
(Nicosia::CairoOperationRecorder::drawImageBuffer):
(Nicosia::CairoOperationRecorder::drawFilteredImageBuffer):
(Nicosia::CairoOperationRecorder::drawNativeImageInternal):
(Nicosia::CairoOperationRecorder::drawPattern):
(Nicosia::CairoOperationRecorder::drawRect):
(Nicosia::CairoOperationRecorder::drawLine):
(Nicosia::CairoOperationRecorder::drawLinesForText):
(Nicosia::CairoOperationRecorder::drawDotsForDocumentMarker):
(Nicosia::CairoOperationRecorder::drawEllipse):
(Nicosia::CairoOperationRecorder::drawFocusRing):
(Nicosia::CairoOperationRecorder::save):
(Nicosia::CairoOperationRecorder::restore):
(Nicosia::CairoOperationRecorder::translate):
(Nicosia::CairoOperationRecorder::rotate):
(Nicosia::CairoOperationRecorder::scale):
(Nicosia::CairoOperationRecorder::concatCTM):
(Nicosia::CairoOperationRecorder::setCTM):
(Nicosia::CairoOperationRecorder::beginTransparencyLayer):
(Nicosia::CairoOperationRecorder::endTransparencyLayer):
(Nicosia::CairoOperationRecorder::clip):
(Nicosia::CairoOperationRecorder::clipOut):
(Nicosia::CairoOperationRecorder::clipPath):
(Nicosia::CairoOperationRecorder::clipToImageBuffer):
(Nicosia::contextForReplay): Deleted.
* 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
* 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.cpp: 
Removed.
* Source/WebCore/platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.h: 
Removed.
* 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaPaintingOperationReplayCairo.h:
 Removed.

Canonical link: https://commits.webkit.org/285697@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f0339c: [Static Analyzer CI] Update Safer-CPP-Checks queue...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0339cd13291ec15f92afc4e8b618ced46d07be5
  
https://github.com/WebKit/WebKit/commit/f0339cd13291ec15f92afc4e8b618ced46d07be5
  Author: Brianna Fan 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/config.json
M Tools/CISupport/build-webkit-org/factories_unittest.py
M Tools/CISupport/ews-build/config.json

  Log Message:
  ---
  [Static Analyzer CI] Update Safer-CPP-Checks queue to Sequoia
https://bugs.webkit.org/show_bug.cgi?id=282020
rdar://138521603

Reviewed by Ryan Haddad.

Make necessary config changes for the update.

* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/config.json:

Canonical link: https://commits.webkit.org/285700@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ad8966: [ews] unsafe-merge-queue sometimes fails with exce...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad8966f8e9dee6554214bc84cde2a6afe5a56112
  
https://github.com/WebKit/WebKit/commit/ad8966f8e9dee6554214bc84cde2a6afe5a56112
  Author: Brianna Fan 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] unsafe-merge-queue sometimes fails with exception in 
retrieve-pr-data-from-label-webkit-webkit step
https://bugs.webkit.org/show_bug.cgi?id=278941
rdar://135033550

Reviewed by Jonathan Bedard.

Add retries and error handling to get_number_of_prs_with_label.
If there are errors, attempt to print out the message for easier debugging.

* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.get_number_of_prs_with_label):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/285701@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 39636b: [Observable] Use AbortSignal directly

[Marais Rossouw]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39636bf8cda7370d8b98b48ce85bd37263852748
  
https://github.com/WebKit/WebKit/commit/39636bf8cda7370d8b98b48ce85bd37263852748
  Author: Marais Rossouw 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/dom/InternalObserverFirst.cpp
M Source/WebCore/dom/Subscriber.cpp
M Source/WebCore/dom/Subscriber.h

  Log Message:
  ---
  [Observable] Use AbortSignal directly
https://bugs.webkit.org/show_bug.cgi?id=282069

Reviewed by Chris Dumez.

As AbortController wraps an AbortSignal, there is no need for our
internal code to go through it as well. We save allocations, and still
entirely spec complaint. Seeing as the spec reads "to signal abort" in various
parts, which is only a concept on abort signals anyway.

* Source/WebCore/dom/InternalObserverFirst.cpp:
(WebCore::createInternalObserverOperatorFirst):
  The visitor signal should just be an AbortSignal, than through the
  AbortController bindings.
  Drive-by: Repeated Ref { m_promise } -> protectedPromise
* Source/WebCore/dom/Subscriber.cpp:
(WebCore::Subscriber::Subscriber):
  Construct a new AbortSignal, than AbortController
(WebCore::Subscriber::close):
  We need to signalAbort the AbortSignal, than abort the AbortController
* Source/WebCore/dom/Subscriber.h:

Canonical link: https://commits.webkit.org/285723@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7116fe: [Gardening] NEW TEST [ Sequoia+ x86_64 ] 5 swipe l...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7116fe69a53c97abe604808e04e4744b9bf6bb22
  
https://github.com/WebKit/WebKit/commit/7116fe69a53c97abe604808e04e4744b9bf6bb22
  Author: Jay Stfleur 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening] NEW TEST [ Sequoia+ x86_64 ] 5 swipe layout tests are timing out 
due to "Timed out waiting for notifyDone to be called"
https://bugs.webkit.org/show_bug.cgi?id=282126

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/285724@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bb0002: [FFC] Move resolveNonLogicalValues to FlexFormatti...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb00023f390ad37c2d06f4ff7218ec63bf98fba1
  
https://github.com/WebKit/WebKit/commit/bb00023f390ad37c2d06f4ff7218ec63bf98fba1
  Author: Alan Baradlay 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h
M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp

  Log Message:
  ---
  [FFC] Move resolveNonLogicalValues to FlexFormattingUtils
https://bugs.webkit.org/show_bug.cgi?id=282018

Reviewed by Antti Koivisto.

* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::Layout::FlexFormattingUtils::logicalJustifyContentPositionValue):
(WebCore::Layout::FlexFormattingUtils::isMainAxisParallelWithLeftRightAxis): 
Deleted.
(WebCore::Layout::FlexFormattingUtils::isInlineDirectionRTL): Deleted.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h:
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::handleMainAxisAlignment const):

Canonical link: https://commits.webkit.org/285698@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd6d30: Add tokenizer support for URLPattern API

[jelee53]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd6d30811d4248b258082ae01ef4626866f15b40
  
https://github.com/WebKit/WebKit/commit/bd6d30811d4248b258082ae01ef4626866f15b40
  Author: Jessica Lee 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/Headers.cmake
A Source/WebCore/Modules/url-pattern/URLPatternTokenizer.cpp
A Source/WebCore/Modules/url-pattern/URLPatternTokenizer.h
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj

  Log Message:
  ---
  Add tokenizer support for URLPattern API
https://bugs.webkit.org/show_bug.cgi?id=281730
rdar://138171576

Reviewed by Chris Dumez.

URLPattern API spec for tokenizer: https://urlpattern.spec.whatwg.org/#tokenizer

* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/url-pattern/URLPatternTokenizer.cpp: Added.
(WebCore::URLPatternUtilities::isValidNameCodepoint):
(WebCore::URLPatternUtilities::Token::isNull const):
(WebCore::URLPatternUtilities::Tokenizer::getNextCodePoint):
(WebCore::URLPatternUtilities::Tokenizer::seekNextCodePoint):
(WebCore::URLPatternUtilities::Tokenizer::addToken):
(WebCore::URLPatternUtilities::Tokenizer::processTokenizingError):
(WebCore::URLPatternUtilities::Tokenizer::Tokenizer):
(WebCore::URLPatternUtilities::Tokenizer::tokenize):
* Source/WebCore/Modules/url-pattern/URLPatternTokenizer.h: Added.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/285699@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0365e3: Unreviewed, reverting 285708@main (4692eacc698b)

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0365e306403f4fd1b97356a4fea1d154170e69c9
  
https://github.com/WebKit/WebKit/commit/0365e306403f4fd1b97356a4fea1d154170e69c9
  Author: Jonathan Bedard 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-002-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-xywh-rect-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/interpolation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/basic-shape-interpolation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-006-expected.txt
M Source/WTF/wtf/StdLibExtras.h
M Source/WebCore/CMakeLists.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/CSSPropertyAnimation.cpp
A Source/WebCore/css/BasicShapeConversion.cpp
A Source/WebCore/css/BasicShapeConversion.h
A Source/WebCore/css/BasicShapesShapeSegmentConversion.cpp
A Source/WebCore/css/BasicShapesShapeSegmentConversion.h
R Source/WebCore/css/CSSBasicShapeValue.cpp
R Source/WebCore/css/CSSBasicShapeValue.h
A Source/WebCore/css/CSSBasicShapes.cpp
A Source/WebCore/css/CSSBasicShapes.h
M Source/WebCore/css/CSSGradientValue.cpp
M Source/WebCore/css/CSSGradientValue.h
R Source/WebCore/css/CSSPathValue.cpp
R Source/WebCore/css/CSSPathValue.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSRayValue.cpp
M Source/WebCore/css/CSSRayValue.h
A Source/WebCore/css/CSSShapeSegmentValue.cpp
A Source/WebCore/css/CSSShapeSegmentValue.h
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/color/CSSUnresolvedColorKeyword.cpp
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M Source/WebCore/css/parser/CSSPropertyParser.h
R Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp
R Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.h
R Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.cpp
R Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.h
R Source/WebCore/css/parser/CSSPropertyParserConsumer+Motion.cpp
R Source/WebCore/css/parser/CSSPropertyParserConsumer+Motion.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.h
R Source/WebCore/css/parser/CSSPropertyParserConsumer+Shapes.cpp
R Source/WebCore/css/parser/CSSPropertyParserConsumer+Shapes.h
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
M Source/WebCore/css/process-css-properties.py
M Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp
A Source/WebCore/css/values/CSSGradient.cpp
A Source/WebCore/css/values/CSSGradient.h
A Source/WebCore/css/values/CSSPosition.cpp
A Source/WebCore/css/values/CSSPosition.h
A Source/WebCore/css/values/CSSPrimitiveNumericTypes+CSSValueVisitation.h
A 
Source/WebCore/css/values/CSSPrimitiveNumericTypes+ComputedStyleDependencies.cpp
A 
Source/WebCore/css/values/CSSPrimitiveNumericTypes+ComputedStyleDependencies.h
A Source/WebCore/css/values/CSSPrimitiveNumericTypes+EvaluateCalc.h
A Source/WebCore/css/values/CSSPrimitiveNumericTypes+Serialization.cpp
A Source/WebCore/css/values/CSSPrimitiveNumericTypes+Serialization.h
A Source/WebCore/css/values/CSSPrimitiveNumericTypes+SymbolReplacement.cpp
A Source/WebCore/css/values/CSSPrimitiveNumericTypes+SymbolReplacement.h
A Source/WebCore/css/values/CSSPrimitiveNumericTypes.cpp
A Source/WebCore/css/values/CSSPrimitiveNumericTypes.h
A Source/WebCore/css/values/CSSUnevaluatedCalc.cpp
A Source/WebCore/css/values/CSSUnevaluatedCalc.h
M Source/WebCore/css/values/CSSValueTypes.h
R Source/WebCore/css/values/backgrounds/CSSBorderRadius.cpp
R Source/WebCore/css/values/backgrounds/CSSBorderRadius.h
R Source/WebCore/css/values/backgrounds/CSSMinimallySerializingRectEdges.h
R Source/WebCore/css/values/images/CSSGradient.cpp
R Source/WebCore/css/values/images/CSSGradient.h
R

[webkit-changes] [WebKit/WebKit] 3d7827: Add a way for internal WebKit clients to extract a...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d7827fa1ae86043d77a65d3fe8479ba5b2ee20c
  
https://github.com/WebKit/WebKit/commit/3d7827fa1ae86043d77a65d3fe8479ba5b2ee20c
  Author: Wenson Hsieh 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/page/text-extraction/TextExtraction.cpp
M Source/WebCore/page/text-extraction/TextExtraction.h
M Source/WebKit/Shared/API/APIObject.h
M Source/WebKit/Shared/API/Cocoa/WebKitPrivate.h
M Source/WebKit/Shared/Cocoa/APIObject.mm
M Source/WebKit/Sources.txt
M Source/WebKit/SourcesCocoa.txt
A Source/WebKit/UIProcess/API/APITextRun.cpp
A Source/WebKit/UIProcess/API/APITextRun.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
A Source/WebKit/UIProcess/API/Cocoa/_WKTextRun.h
A Source/WebKit/UIProcess/API/Cocoa/_WKTextRun.mm
A Source/WebKit/UIProcess/API/Cocoa/_WKTextRunInternal.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/nested-frames.html
A Tools/TestWebKitAPI/Tests/WebKitCocoa/subframes.html

  Log Message:
  ---
  Add a way for internal WebKit clients to extract a list of all text and text 
rects on a webpage
https://bugs.webkit.org/show_bug.cgi?id=281795
rdar://138221056

Reviewed by Abrar Rahman Protyasha.

Add experimental WebKit SPI to collect all of the text on a webpage, along with 
bounding rects in
`WKWebView` coordinates. See below for more details.

* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::extractAllTextAndRectsRecursive):
(WebCore::TextExtraction::extractAllTextAndRects):

Implement the main logic here, which uses `TextIterator` to recursively extract 
visible text content
from each frame on the page.

* Source/WebCore/page/text-extraction/TextExtraction.h:
* Source/WebKit/Shared/API/APIObject.h:
* Source/WebKit/Shared/API/Cocoa/WebKitPrivate.h:
* Source/WebKit/Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
* Source/WebKit/Sources.txt:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/APITextRun.cpp: Copied from 
Source/WebCore/page/text-extraction/TextExtraction.h.
(API::TextRun::rectInWebView const):
* Source/WebKit/UIProcess/API/APITextRun.h: Copied from 
Source/WebCore/page/text-extraction/TextExtraction.h.

Add a new `API::Object` that represents a single piece of visible text, along 
with a rect in root
view coordinates.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _requestAllTextWithCompletionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKTextRun.h: Copied from 
Source/WebCore/page/text-extraction/TextExtraction.h.
* Source/WebKit/UIProcess/API/Cocoa/_WKTextRun.mm: Copied from 
Source/WebCore/page/text-extraction/TextExtraction.h.
(-[_WKTextRun dealloc]):
(-[_WKTextRun _apiObject]):
(-[_WKTextRun text]):
(-[_WKTextRun rectInWebView]):
(-[_WKTextRun debugDescription]):

Add a new Objective-C object, that wraps the C++ `API::Object` above.

* Source/WebKit/UIProcess/API/Cocoa/_WKTextRunInternal.h: Copied from 
Source/WebCore/page/text-extraction/TextExtraction.h.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestAllTextAndRects):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::requestAllTextAndRects):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:

Drive-by fix: wrap all of these tests in `namespace TestWebKitAPI`.

(-[WKWebView _allTextRuns]):
(TestWebKitAPI::TEST(WKWebView, GetContentsShouldReturnString)):
(TestWebKitAPI::TEST(WKWebView, GetContentsShouldFailWhenClosingPage)):
(TestWebKitAPI::TEST(WKWebView, GetContentsOfAllFramesShouldReturnString)):
(TestWebKitAPI::TEST(WKWebView, GetContentsShouldReturnAttributedString)):
(TestWebKitAPI::TEST(WKWebView, 
GetContentsWithOpticallySizedFontShouldReturnAttributedString)):
(TestWebKitAPI::TEST(WKWebView, AttributedStringAccessibilityLabel)):
(TestWebKitAPI::TEST(WKWebView, AttributedStringAttributeTypes)):
(TestWebKitAPI::TEST(WKWebView, AttributedStringWithoutNetworkLoads)):
(TestWebKitAPI::TEST(WKWebView, AttributedStringWithSourceApplicationBundleID)):
(TestWebKitAPI::TEST(WKWebView, TextWithWebFontAsAttributedString)):
(TestWebKitAPI::TES

[webkit-changes] [WebKit/WebKit] fe525f: [Gardening]: REGRESSION (280616@main?): [macOS Deb...

[Marta]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe525f2c206f98a35b62f9b6ee6fb94b724dbae5
  
https://github.com/WebKit/WebKit/commit/fe525f2c206f98a35b62f9b6ee6fb94b724dbae5
  Author: Marta Darbinyan 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (280616@main?): [macOS Debug wk2] ASSERTION FAILED: 
m_wrapper in *WebCore::JSEventListener::ensureJSFunction(ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=281793
rdar://138219837

Unreviewed test gardening

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/285711@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3f563e: [GTK] Use std::array and ASCIILiteral in DropTarge...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f563ed0bcbf5911f3f8ba04fdfe993bbb62c373
  
https://github.com/WebKit/WebKit/commit/3f563ed0bcbf5911f3f8ba04fdfe993bbb62c373
  Author: Adrian Perez de Castro 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp

  Log Message:
  ---
  [GTK] Use std::array and ASCIILiteral in DropTargetGtk4.cpp
https://bugs.webkit.org/show_bug.cgi?id=282095

Reviewed by Michael Catanzaro.

* Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp:
(WebKit::DropTarget::accept): Convert portalMIMETypes and supportedMimeTypes
to be std::array, use ASCIILiteral strings as their elements, and replace
usage of g_strv_contains() with std::ranges::contains(). Remove usage of
WTF_ALLOW_UNSAFE_BUFFER_USAGE_{BEGIN,END}.

Canonical link: https://commits.webkit.org/285713@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f5512c: [vision] Controls not always showing in spatial pl...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5512c37f54de84db9d0b46efcdcf4ba2b3051d1
  
https://github.com/WebKit/WebKit/commit/f5512c37f54de84db9d0b46efcdcf4ba2b3051d1
  Author: Jean-Yves Avenard 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
M Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift
M Source/WebKit/WebKitSwift/LinearMediaKit/WKSLinearMediaPlayer.h

  Log Message:
  ---
  [vision] Controls not always showing in spatial player
https://bugs.webkit.org/show_bug.cgi?id=282094
rdar://138595244

Reviewed by Andy Estes.

In 285658@main, we fixed entering spatial portal from element fullscreen after 
selecting the "view in spatial" button.
But it was incomplete.

whenever we configure the docking menu, we also set two properties on the 
PlayableViewController. Unfortunately, those properties
break spatial and prevent the media controls from appearing. So we only want to 
have them set when entering video fullscreen from
the environment menu.
There's no proper way to distinguish in which fashion we entered video 
fullscreen, either from a call to HTML's enterFullScreen, via the
docking environment or through the dedicated spatial button.
We add a property on the LinearMediaPlayer :enteredFromInline which is set if 
we entered fullscreen from the environment menu.
Later, before configuring fullscreen, we check that property and it set we 
clear the two PlayableViewController properties.

Manually tested on a real device with the following steps.
1- element fullscreen
2 - spatial
3 - exit
4- [go back to step 2 a random number of times)
5- exit element fullscreen
6 - enter native fullscreen (spatial)
7 - exit
8- [go back to step 6 a random number of times)
9 - go into element fullscreen
10 - tap on environment button, select 1
11 - exit
12- go back to step 8 a random number of times.
13 - goto 1.

* Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm:
(WebKit::VideoPresentationInterfaceLMK::setupFullscreen):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController 
configureEnvironmentPickerOrFullscreenVideoButtonView]):
(-[WKFullScreenViewController _enterVideoFullscreenAction:]):
* Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift:
(WKSLinearMediaPlayer.enteredFromInline):
* Source/WebKit/WebKitSwift/LinearMediaKit/WKSLinearMediaPlayer.h:

Canonical link: https://commits.webkit.org/285715@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9d5f18: Undo test changes expecting SameSite=Lax cookies b...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d5f18152a927cd0136adca280385f8e64ebb532
  
https://github.com/WebKit/WebKit/commit/9d5f18152a927cd0136adca280385f8e64ebb532
  Author: Charlie Wolfe 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M LayoutTests/http/tests/cookies/resources/testharness-helpers.js
M 
LayoutTests/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt
M 
LayoutTests/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page.html
M 
LayoutTests/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt
M 
LayoutTests/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker.html
M LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html
M 
LayoutTests/http/tests/cookies/same-site/resources/fetch-after-navigating-iframe-in-cross-origin-page.py
M 
LayoutTests/http/tests/cookies/same-site/resources/fetch-in-cross-origin-service-worker.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/anonymous-iframe/cookie.tentative.https.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/anonymous-iframe/cookie.tentative.https.window-expected.txt
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/ios-17/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/platform/wpe/TestExpectations

  Log Message:
  ---
  Undo test changes expecting SameSite=Lax cookies by default
https://bugs.webkit.org/show_bug.cgi?id=281984
rdar://138487628

Reviewed by Matthew Finkel.

* LayoutTests/http/tests/cookies/resources/testharness-helpers.js:
* 
LayoutTests/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt:
* 
LayoutTests/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page.html:
* 
LayoutTests/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt:
* 
LayoutTests/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker.html:
* LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html:
* 
LayoutTests/http/tests/cookies/same-site/resources/fetch-after-navigating-iframe-in-cross-origin-page.py:
* 
LayoutTests/http/tests/cookies/same-site/resources/fetch-in-cross-origin-service-worker.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/anonymous-iframe/cookie.tentative.https.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/anonymous-iframe/cookie.tentative.https.window-expected.txt:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios-17/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/285696@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 642ca0: Sometimes, WKTR installation does not succeed in t...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 642ca0497fb33759aead6b05d2ed5a109e55664f
  
https://github.com/WebKit/WebKit/commit/642ca0497fb33759aead6b05d2ed5a109e55664f
  Author: Per Arne Vollan 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Tools/Scripts/webkitpy/xcode/simulated_device.py
A Tools/WebKitTestRunner/Configurations/WebKitEligibilityUtil.xcconfig
A Tools/WebKitTestRunner/WebKitEligibilityUtil/main.cpp
M Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj

  Log Message:
  ---
  Sometimes, WKTR installation does not succeed in the Simulator
https://bugs.webkit.org/show_bug.cgi?id=281875
rdar://138351968

Reviewed by Elliott Williams.

This is caused by a daemon involved in the installation being suspended. This 
patch works around this
issue by creating a small utility that sends a XPC message to the daemon in 
order to resume execution.
This issue is flaky, so it is hard to confirm the fix is sufficient, but local 
testing looks good.

This patch was previously reviewed in 
https://github.com/WebKit/WebKit/pull/35544 and landed in
https://commits.webkit.org/285637@main. It is being relanded with a build fix 
for Debug mode.

* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.install_app):
* Tools/WebKitTestRunner/Configurations/WebKitEligibilityUtil.xcconfig: Added.
* Tools/WebKitTestRunner/WebKitEligibilityUtil/main.cpp: Added.
(main):
* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/285704@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 464329: [WASM] Fix consistency check in addBranchNull

[Yijia Huang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4643296068e547af9ad3d133f93d863affeb09f8
  
https://github.com/WebKit/WebKit/commit/4643296068e547af9ad3d133f93d863affeb09f8
  Author: Yijia Huang 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
A JSTests/wasm/gc/bug138038945.js
M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp

  Log Message:
  ---
  [WASM] Fix consistency check in addBranchNull
https://bugs.webkit.org/show_bug.cgi?id=281934
rdar://138038945

Reviewed by David Degazio.

In addBranchNull, when branching on null, the first push is used
to reserve a slot for the reference to avoid overwriting it with
the condition. Since this slot reservation is deliberate and the
expression-stack slot relationship doesn’t need to be preserved,
there’s no need for a consistency check after the first push in
this case.

The second push, used for the condition, is temporary and only
needed to perform the null check. It’s not part of WebAssembly's
core semantics, so no additional consistency checks are required.

This fix ensures that consistency checks are only applied where
necessary, avoiding redundant checks when pushing temporary
values or reserving slots.

* JSTests/wasm/gc/bug138038945.js: Added.
(catch):
* Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::addBranchNull):

Canonical link: https://commits.webkit.org/285705@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 70355b: [scroll-animations] Plumb CSS originated animation...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70355b3509bd6ff1aac7944eff0dcfda27f9896b
  
https://github.com/WebKit/WebKit/commit/70355b3509bd6ff1aac7944eff0dcfda27f9896b
  Author: Nikolaos Mouchtaris 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-dynamic-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-with-delay-and-range.tentative-expected.txt
M Source/WebCore/animation/CSSAnimation.cpp
M Source/WebCore/animation/CSSAnimation.h
M Source/WebCore/animation/WebAnimation.cpp
M Source/WebCore/animation/WebAnimation.h
M Source/WebCore/animation/WebAnimation.idl
M Source/WebCore/dom/Element.cpp

  Log Message:
  ---
  [scroll-animations] Plumb CSS originated animation range down to WebAnimation
https://bugs.webkit.org/show_bug.cgi?id=282059
rdar://138580596

Reviewed by Antoine Quint.

Plumb CSS originated animation range down to WebAnimation. Add override bindings
setters to prevent CSS animation range from overwriting JS animation range.

* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
* Source/WebCore/animation/WebAnimation.h:
(WebCore::WebAnimation::setRange):

Canonical link: https://commits.webkit.org/285707@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4692ea: Convert basic shapes types to strongly typed CSS/S...

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4692eacc698b91686bf635d0b4e3030853edfd97
  
https://github.com/WebKit/WebKit/commit/4692eacc698b91686bf635d0b4e3030853edfd97
  Author: Sam Weinig 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-002-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-xywh-rect-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/interpolation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/basic-shape-interpolation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-006-expected.txt
M Source/WTF/wtf/StdLibExtras.h
M Source/WebCore/CMakeLists.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/CSSPropertyAnimation.cpp
R Source/WebCore/css/BasicShapeConversion.cpp
R Source/WebCore/css/BasicShapeConversion.h
R Source/WebCore/css/BasicShapesShapeSegmentConversion.cpp
R Source/WebCore/css/BasicShapesShapeSegmentConversion.h
A Source/WebCore/css/CSSBasicShapeValue.cpp
A Source/WebCore/css/CSSBasicShapeValue.h
R Source/WebCore/css/CSSBasicShapes.cpp
R Source/WebCore/css/CSSBasicShapes.h
M Source/WebCore/css/CSSGradientValue.cpp
M Source/WebCore/css/CSSGradientValue.h
A Source/WebCore/css/CSSPathValue.cpp
A Source/WebCore/css/CSSPathValue.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSRayValue.cpp
M Source/WebCore/css/CSSRayValue.h
R Source/WebCore/css/CSSShapeSegmentValue.cpp
R Source/WebCore/css/CSSShapeSegmentValue.h
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/color/CSSUnresolvedColorKeyword.cpp
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M Source/WebCore/css/parser/CSSPropertyParser.h
A Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp
A Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.h
A Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.cpp
A Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.h
A Source/WebCore/css/parser/CSSPropertyParserConsumer+Motion.cpp
A Source/WebCore/css/parser/CSSPropertyParserConsumer+Motion.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.h
A Source/WebCore/css/parser/CSSPropertyParserConsumer+Shapes.cpp
A Source/WebCore/css/parser/CSSPropertyParserConsumer+Shapes.h
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
M Source/WebCore/css/process-css-properties.py
M Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp
R Source/WebCore/css/values/CSSGradient.cpp
R Source/WebCore/css/values/CSSGradient.h
R Source/WebCore/css/values/CSSPosition.cpp
R Source/WebCore/css/values/CSSPosition.h
R Source/WebCore/css/values/CSSPrimitiveNumericTypes+CSSValueVisitation.h
R 
Source/WebCore/css/values/CSSPrimitiveNumericTypes+ComputedStyleDependencies.cpp
R 
Source/WebCore/css/values/CSSPrimitiveNumericTypes+ComputedStyleDependencies.h
R Source/WebCore/css/values/CSSPrimitiveNumericTypes+EvaluateCalc.h
R Source/WebCore/css/values/CSSPrimitiveNumericTypes+Serialization.cpp
R Source/WebCore/css/values/CSSPrimitiveNumericTypes+Serialization.h
R Source/WebCore/css/values/CSSPrimitiveNumericTypes+SymbolReplacement.cpp
R Source/WebCore/css/values/CSSPrimitiveNumericTypes+SymbolReplacement.h
R Source/WebCore/css/values/CSSPrimitiveNumericTypes.cpp
R Source/WebCore/css/values/CSSPrimitiveNumericTypes.h
R Source/WebCore/css/values/CSSUnevaluatedCalc.cpp
R Source/WebCore/css/values/CSSUnevaluatedCalc.h
M Source/WebCore/css/values/CSSValueTypes.h
A Source/WebCore/css/values/backgrounds/CSSBorderRadius.cpp
A Source/WebCore/css/values/backgrounds/CSSBorderRadius.h
A Source/WebCore/css/values/backgrounds/CSSMinimallySerializingRectEdges.h
A Source/WebCore/css/values/images/CSSGradient.cpp
A Source/WebCore/css/values/images/CSSGradient.h
A Sour

[webkit-changes] [WebKit/WebKit] 2408b7: Allow upgrade requests in mixed content if the sch...

[Basuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2408b78fe65465e82a7b3b00a80f2327938fb3f1
  
https://github.com/WebKit/WebKit/commit/2408b78fe65465e82a7b3b00a80f2327938fb3f1
  Author: Basuke Suzuki 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/loader/MixedContentChecker.cpp
M Source/WebCore/loader/MixedContentChecker.h
M Tools/TestWebKitAPI/CMakeLists.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebCore/MixedContentChecker.cpp

  Log Message:
  ---
  Allow upgrade requests in mixed content if the scheme is handled by scheme 
handler.
https://bugs.webkit.org/show_bug.cgi?id=281883
rdar://131077815

Reviewed by Matthew Finkel.

In 274409@main, request upgrade in mixed content was implemented strictly 
following the spec.
https://www.w3.org/TR/mixed-content/#upgrade-algorithm

But for the compatibility of WKWebView, request upgrade should be allowed when 
the request is handled by special scheme handler.

This patch adds exception for the upgradable check in 
MixedContentChecker::shouldUpgradeInsecureContent().

Also adding first API test for MixedContentChecker by extracting the check for 
easier unit testing.

* Source/WebCore/loader/MixedContentChecker.cpp:
(WebCore::destinationIsImageAndInitiatorIsImageset):
(WebCore::MixedContentChecker::shouldUpgradeInsecureContent):
(WebCore::MixedContentChecker::canModifyRequest):
* Source/WebCore/loader/MixedContentChecker.h:
* Tools/TestWebKitAPI/CMakeLists.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebCore/MixedContentChecker.cpp: Added.
(TestWebKitAPI::TEST(MixedContentChecker, CanModifyRequest)):

Canonical link: https://commits.webkit.org/285709@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 26deb6: [Gardening][macOS wk2] `fast/canvas/canvas-blendin...

[Fady Farag]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26deb6c018478efe4fffbb8f297f285d1373a7b9
  
https://github.com/WebKit/WebKit/commit/26deb6c018478efe4fffbb8f297f285d1373a7b9
  Author: Fady Farag 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening][macOS wk2] `fast/canvas/canvas-blending-text.html` & 
`fast/canvas/canvas-composite-text-alpha.html` are no longer failing on macOS 
wk2
https://bugs.webkit.org/show_bug.cgi?id=230366
rdar://problem/83207621

Unreviewed test gardening.

Updating test expectations.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/285719@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 419bfc: Add support for av1, h264, h265 to CMUtilities cre...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 419bfcbd185ec17590204b2ea0bafa9c6ffdf190
  
https://github.com/WebKit/WebKit/commit/419bfcbd185ec17590204b2ea0bafa9c6ffdf190
  Author: Jean-Yves Avenard 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/platform/graphics/cocoa/CMUtilities.mm

  Log Message:
  ---
  Add support for av1, h264, h265 to CMUtilities 
createFormatDescriptionFromTrackInfo
https://bugs.webkit.org/show_bug.cgi?id=281970
rdar://138474062

Reviewed by Youenn Fablet.

FlyBy: Adopt smart pointers in method.

* Source/WebCore/platform/graphics/cocoa/CMUtilities.mm:
(WebCore::createFormatDescriptionFromTrackInfo):
(WebCore::toCMSampleBuffer):

Canonical link: https://commits.webkit.org/285718@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1a9763: Ignore -Wunsafe-buffer-usage-in-libc-call warnings...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a97633eac49ebe67f7891f0c00046bf4f42
  
https://github.com/WebKit/WebKit/commit/1a97633eac49ebe67f7891f0c00046bf4f42
  Author: David Kilzer 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Configurations/CommonBase.xcconfig
M Source/WebGPU/Configurations/Base.xcconfig
M Source/WebKit/Configurations/Base.xcconfig

  Log Message:
  ---
  Ignore -Wunsafe-buffer-usage-in-libc-call warnings when -Wunsafe-buffer-usage 
is enabled



Reviewed by Geoffrey Garen.

The -Wunsafe-buffer-usage warning also enables the
-Wunsafe-buffer-usage-in-libc-call warning, but those need a separate
pass to resolve, so turn them off for now.

* Configurations/CommonBase.xcconfig:
(WK_NO_UNSAFE_BUFFER_USAGE_IN_LIBC_CALL): Add.
- Define a build setting to disable the
  -Wunsafe-buffer-usage-in-libc-call warning.
* Source/WebGPU/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
- Add $(WK_NO_UNSAFE_BUFFER_USAGE_IN_LIBC_CALL) since
  -Wunsafe-buffer-usage is enabled for this project.
* Source/WebKit/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
- Ditto.

Canonical link: https://commits.webkit.org/285720@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a46b27: Don't crash when UTF-8 conversion of filename in `...

[Daniel Liu]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a46b2777b0cb2e2c7076728045d6225eea1e483a
  
https://github.com/WebKit/WebKit/commit/a46b2777b0cb2e2c7076728045d6225eea1e483a
  Author: Daniel Liu 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/JavaScriptCore/jsc.cpp

  Log Message:
  ---
  Don't crash when UTF-8 conversion of filename in 
`fetchScriptFromLocalFileSystem` fails
https://bugs.webkit.org/show_bug.cgi?id=281871
rdar://138178550

Reviewed by Yijia Huang.

Previously, `fetchScriptFromLocalFileSystem` assumed that UTF-8 conversion of 
the filename
would always succeed, and had a `RELEASE_ASSERT` asserting such. However, if 
this conversion
fails for any reason, we'll trip the assertion. This patch cleans up this case 
by having the
program fail gracefully.

* Source/JavaScriptCore/jsc.cpp:
(fillBufferWithContentsOfFile):

Canonical link: https://commits.webkit.org/285721@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd98a6: Unship support for `Clear-Site-Data: "executionCon...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd98a6494eff7394fc2fb7b1f27e08ddf2833e82
  
https://github.com/WebKit/WebKit/commit/bd98a6494eff7394fc2fb7b1f27e08ddf2833e82
  Author: Chris Dumez 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h
M 
Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp

  Log Message:
  ---
  Unship support for `Clear-Site-Data: "executionContext"` HTTP header value
https://bugs.webkit.org/show_bug.cgi?id=271700
rdar://125490226

Reviewed by Per Arne Vollan.

Unship support for `Clear-Site-Data: "executionContext"` HTTP header value. 
We've recently
added support but we're the only browser engine that supports this value. This 
header value
causes frames from the origin to get reloaded so it can lead to bad 
consequences if not used
properly. Now that we have evidence of such unexpected reloads on MDN, I think 
we should
unship for now.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
* Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h:
* Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in:
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::processClearSiteDataHeader):
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::addParametersShared):

Canonical link: https://commits.webkit.org/285712@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 71a79f: Unreviewed, reverting 285114@main.

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71a79ffe1b70eeb13026c565997513e69b553ba7
  
https://github.com/WebKit/WebKit/commit/71a79ffe1b70eeb13026c565997513e69b553ba7
  Author: Jer Noble 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebCore/Modules/WebGPU/GPUDevice.h
M Source/WebCore/css/CSSPseudoSelectors.json
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/FullscreenManager.cpp
M Source/WebCore/page/DiagnosticLoggingKeys.cpp
M Source/WebCore/page/DiagnosticLoggingKeys.h
M Source/WebCore/page/ElementTargetingController.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/WebProcess/GPU/media/gstreamer/VideoLayerRemoteGStreamer.cpp

  Log Message:
  ---
  Unreviewed, reverting 285114@main.
https://bugs.webkit.org/show_bug.cgi?id=282101

Broke In-Window Fullscreen on macOS

Reverted changeset:

"Build fixes for !ENABLE(VIDEO)"
https://bugs.webkit.org/show_bug.cgi?id=281253
https://commits.webkit.org/285114@main

Canonical link: https://commits.webkit.org/285710@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4a983d: [Gardening]: Undo test changes expecting SameSite=...

[Marta]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a983d37a17195e3608d5f9674842d5d9b7d5b96
  
https://github.com/WebKit/WebKit/commit/4a983d37a17195e3608d5f9674842d5d9b7d5b96
  Author: Marta Darbinyan 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: Undo test changes expecting SameSite=Lax cookies by default
https://bugs.webkit.org/show_bug.cgi?id=281984
rdar://138487628

Unreviewed test gardening

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/285716@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c7a8e5: Fix TestWebKitAPI.WebKit.InterruptionBetweenSamePr...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7a8e50690ab7b2dea9e0431439b0ba9cb73455a
  
https://github.com/WebKit/WebKit/commit/c7a8e50690ab7b2dea9e0431439b0ba9cb73455a
  Author: Alex Christensen 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.cpp
M 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.h
M 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.cpp
M 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.h
M 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp
M 
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp
M 
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.h

  Log Message:
  ---
  Fix TestWebKitAPI.WebKit.InterruptionBetweenSameProcessPages in debug builds
https://bugs.webkit.org/show_bug.cgi?id=282109
rdar://138651693

Reviewed by Chris Dumez.

The test correctly asserts that the WeakPtr is not safe to use from another 
thread.
This is what ThreadSafeWeakPtr is for.

* 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.cpp:
* 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.h:
* 
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.cpp:
(WebCore::AudioMediaStreamTrackRendererUnit::singleton):
(WebCore::AudioMediaStreamTrackRendererUnit::reset):
* Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.h:
* 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
* 
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::AudioMediaStreamTrackRendererInternalUnitManager::reset):
(WebKit::AudioMediaStreamTrackRendererInternalUnitManager::restartAllUnits):
(WebKit::AudioMediaStreamTrackRendererInternalUnitManagerProxy::createRemoteUnit):
(WebKit::AudioMediaStreamTrackRendererInternalUnitManagerProxy::startThread):
* 
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.h:

Canonical link: https://commits.webkit.org/285717@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7ea701: [css-anchor-position-1] Restart anchor resolution ...

[Kiet Ho]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ea7016e8f1762c542f93faa186a69debb1b81ea
  
https://github.com/WebKit/WebKit/commit/7ea7016e8f1762c542f93faa186a69debb1b81ea
  Author: Kiet Ho 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-in-css-min-max-function-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-in-css-min-max-function.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/reference/anchor-in-css-min-max-function-ref.html
M Source/WebCore/style/AnchorPositionEvaluator.cpp

  Log Message:
  ---
  [css-anchor-position-1] Restart anchor resolution if a new anchor reference 
is discovered after anchor resolution has concluded
rdar://137628927
https://bugs.webkit.org/show_bug.cgi?id=281169

Reviewed by Antti Koivisto.

It's possible for new anchor name references to be picked up after anchor 
resolution
has completed. Consider this CSS expression:

top: max(anchor(--a1 top),
 anchor(--a2 top),
 anchor(--a3 top))

min() and max() does short-circuit evaluation: the first argument is always 
evaluated,
and if any arguments from the second one evaluate to NaN, the overall result is 
NaN,
and the remaining arguments are not evaluated.

Dring the first pass of style/layout interleaving, only anchor(--a1 top) and
anchor(--a2 top) are evaluated. We learn that resolving this depends on anchor 
--a1 and
--a2, and we return NaN because there's no layout information to fully resolve. 
HOWEVER,
anchor(--a3 top) is not evaluated, and we don't pick up the dependency on --a3.

On the second pass of style/layout interleaving, anchor(--a1 top) and 
anchor(--a2 top)
evaluate to non-NaN, and only here is anchor(--a3 top) evaluated. BUT, at this 
point,
the anchor resolution process has already finished. If we request evaluation of 
anchor
--a3, it'll assume it's an invalid anchor reference, and not a anchor reference 
that we
have to resolve.

Fix this by setting the anchor resolution stage to the initial stage if we see
a new anchor reference. This forces anchor resolution to rerun and pick up new
references.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-in-css-min-max-function-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-in-css-min-max-function.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/reference/anchor-in-css-min-max-function-ref.html:
 Added.
* Source/WebCore/style/AnchorPositionEvaluator.cpp:
(WebCore::Style::AnchorPositionEvaluator::evaluate):

Canonical link: https://commits.webkit.org/285714@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9dad9c: [WebGPU] Packed struct types have unexpected sizes

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9dad9cc100737bd8ab26e356fff29b1299ba2e28
  
https://github.com/WebKit/WebKit/commit/9dad9cc100737bd8ab26e356fff29b1299ba2e28
  Author: Mike Wyrzykowski 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Source/WebGPU/WGSL/AttributeValidator.cpp

  Log Message:
  ---
  [WebGPU] Packed struct types have unexpected sizes
https://bugs.webkit.org/show_bug.cgi?id=281933
rdar://138380467

Reviewed by Dan Glastonbury.

The specification says that the alignment must be a multiple
of the required alignment.

* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::validateAlignment):

Canonical link: https://commits.webkit.org/285722@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes