[webkit-changes] [WebKit/WebKit] 467a48: [WebAuthn] Ensure conditional mediation paused whe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 467a48b3e198a8ee382fb052d54c6992e9d1cfb7 https://github.com/WebKit/WebKit/commit/467a48b3e198a8ee382fb052d54c6992e9d1cfb7 Author: Pascoe Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- [WebAuthn] Ensure conditional mediation paused when another page is focused https://bugs.webkit.org/show_bug.cgi?id=274998 rdar://128955691 Reviewed by Brent Fulgham. In the situation where a page gets unpaused, the activeConditionalMediationProxy does not get set. This later causes that page to fail to pause, which can cause an unrelated page to have conditional mediation while the page that started it is not focused. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::pauseConditionalAssertion): (WebKit::WebAuthenticatorCoordinatorProxy::unpauseConditionalAssertion): (WebKit::WebAuthenticatorCoordinatorProxy::makeActiveConditionalAssertion): Originally-landed-as: 272448.1062@safari-7618-branch (2e232301da1e). rdar://132956983 Canonical link: https://commits.webkit.org/281798@main Commit: ff621791b629fa47447f8ce9264d54544486547a https://github.com/WebKit/WebKit/commit/ff621791b629fa47447f8ce9264d54544486547a Author: Nisha Jain Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: A LayoutTests/fast/css/font-size-adjust-from-style-invalid-value-expected.txt A LayoutTests/fast/css/font-size-adjust-from-style-invalid-value.html M Source/WebCore/css/ComputedStyleExtractor.cpp Log Message: --- WebCore::fontSizeAdjustFromStyle; WebCore::ComputedStyleExtractor::valueForPropertyInStyle; WebCore::ComputedStyleExtractor::propertyValue https://bugs.webkit.org/show_bug.cgi?id=272821 rdar://126112927 Reviewed by Sihui Liu and Darin Adler. Crash happens in fontSizeAdjustFromStyle API due to invalid 'value' (float:NaN). Added check to validate the 'value'. * LayoutTests/fast/css/font-size-adjust-from-style-invalid-value-expected.txt: Added. * LayoutTests/fast/css/font-size-adjust-from-style-invalid-value.html: Added. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::fontSizeAdjustFromStyle): Originally-landed-as: 272448.951@safari-7618-branch (5e92cb84fde1). rdar://132957136 Canonical link: https://commits.webkit.org/281799@main Commit: e73dfba967ee3b8d87afc74425a343cac523845b https://github.com/WebKit/WebKit/commit/e73dfba967ee3b8d87afc74425a343cac523845b Author: Jer Noble Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp M Source/WebCore/platform/audio/PlatformMediaSessionManager.h M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm Log Message: --- Add support for CancellableTasks to PlatformMediaSessionManager https://bugs.webkit.org/show_bug.cgi?id=275117 rdar://127612016 Reviewed by Andy Estes. Pass a CancellableTask into callOnMainThread() rather than a raw Function, to allow the task to be cancelled before executing. * Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::~PlatformMediaSessionManager): (WebCore::PlatformMediaSessionManager::sessionCanProduceAudioChanged): (WebCore::PlatformMediaSessionManager::scheduleUpdateSessionState): (WebCore::PlatformMediaSessionManager::enqueueTaskOnMainThread): * Source/WebCore/platform/audio/PlatformMediaSessionManager.h: * Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::scheduleSessionStatusUpdate): (WebCore::MediaSessionManagerCocoa::sessionWillEndPlayback): Originally-landed-as: 272448.1079@safari-7618-branch (2131bc756e54). rdar://132957816 Canonical link: https://commits.webkit.org/281800@main Commit: 472726cd0306b8e15efddf187463cb78a4d8a272 https://github.com/WebKit/WebKit/commit/472726cd0306b8e15efddf187463cb78a4d8a272 Author: Chris Dumez Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M Source/WTF/wtf/Deque.h M Source/WebKit/Platform/IPC/Connection.cpp Log Message: --- Sync IPC messages may get processed out of order with async messages sent with the DispatchMessageEvenWhenWaitingForSyncReply option https://bugs.webkit.org/show_bug.cgi?id=274597 rdar://127810844 Reviewed by Geoffrey Garen and Ryosuke Niwa. When doing a sendSync() call, the caller waits until the remote process responds to the sync IPC. When receiving this sync IPC, the remote process may itself decide to send sync IPC back (or async IPC with the DispatchMessageEvenWhenWaitingForSyncReply option) to the other process, *before* responding to the sync IPC. In such cases, one would expect those intermediate IPC to be processed *before* the reply to the sync message, to mai
[webkit-changes] [WebKit/WebKit] 474a9b: Sync `svg/linking` tests from WPT upstream
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 474a9b3c3d32e932d03290b573ca15f7175e6bbc https://github.com/WebKit/WebKit/commit/474a9b3c3d32e932d03290b573ca15f7175e6bbc Author: Ahmad Saleem Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/href-a-element-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/href-feImage-element-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/href-filter-element-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/href-gradient-element-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/href-image-element-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/href-pattern-element-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/href-textPath-element-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/href-use-element-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/support/green-random-rects.svg A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/support/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-override-multiple-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-override-multiple.html R LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base.svg A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-descendant-combinator-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-descendant-combinator-002-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-descendant-combinator-003-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-descendant-combinator-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-hidden-attr-change-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-keyframes-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-nested-symbol-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-symbol-rendered-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-template-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-template-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/use-template.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/view-viewbox-override-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/view-viewbox-override.html M LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/svg/linking/scripted/a.text-getter-01-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/linking/scripted/a.text-getter-01.svg R LayoutTests/imported/w3c/web-platform-tests/svg/linking/scripted/a.text-setter-01-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/linking/scripted/a.text-setter-01.svg M LayoutTests/imported/w3c/web-platform-tests/svg/linking/scripted/href-animate-element.html M LayoutTests/imported/w3c/web-platform-tests/svg/linking/scripted/href-mpath-element.html M LayoutTests/imported/w3c/web-platform-tests/svg/linking/scripted/testcommon.js M LayoutTests/imported/w3c/web-platform-tests/svg/linking/scripted/w3c-import.log Log Message: --- Sync `svg/linking` tests from WPT upstream https://bugs.webkit.org/show_bug.cgi?id=277418 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/1eaddc37a55977200ae3f983eafc1cfcb121235e * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/svg/linki
[webkit-changes] [WebKit/WebKit] ba5aed: Unprefix -webkit-ruby-position
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba5aedf5f753d40e7f3d45e56105762b7408d9ea https://github.com/WebKit/WebKit/commit/ba5aedf5f753d40e7f3d45e56105762b7408d9ea Author: Antti Koivisto Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/inheritance-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/line-spacing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/parsing/ruby-position-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/css/CSSPrimitiveValueMappings.h M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/CSSToStyleMap.cpp M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/process-css-properties.py M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyleConstants.cpp M Source/WebCore/rendering/style/RenderStyleConstants.h M Source/WebCore/rendering/style/RenderStyleInlines.h M Source/WebCore/style/PropertyCascade.cpp M Tools/Scripts/webkitpy/style/checkers/jsonchecker.py Log Message: --- Unprefix -webkit-ruby-position https://bugs.webkit.org/show_bug.cgi?id=151306 rdar://86128259 Reviewed by Alan Baradlay. Support `ruby-position` with the standard value names (over/under/inter-character) excluding 'alternate'. * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/line-spacing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/parsing/ruby-position-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSPrimitiveValueMappings.h: (WebCore::toCSSValueID): (WebCore::fromCSSValueID): * Source/WebCore/css/CSSProperties.json: Add `ruby-position` and mark `-webkit-ruby-position` as its cascade alias. Use the new cascade-alias mechanism as a simple alias does not work because the syntax differs and the related-property mechanism can't be used as the property is marked top-priority. The new mechanism replaces the existing 'synonym' mechanism that does not have correct behavior when both synonyms are specified (the latter should override the earlier one). It was only used by one property. Also use the mechanism for -webkit-mask-source-type. * Source/WebCore/css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapFillMaskMode): * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle const): * Source/WebCore/css/process-css-properties.py: (StylePropertyCodeGenProperties): (StylePropertyCodeGenProperties.from_json): (StyleProperty.perform_fixups_for_cascade_alias_properties): (StyleProperty.perform_fixups): (GenerateCSSPropertyNames): Add support for cascade-alias mechanism. * Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp: (WebCore::Layout::InlineFormattingUtils::textEmphasisForInlineBox): * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::rubyPosition): (WebCore::Layout::RubyFormattingContext::placeAnnotationBox): (WebCore::Layout::RubyFormattingContext::adjustLayoutBoundsAndStretchAncestorRubyBase): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const): * Source/WebCore/rendering/style/RenderStyleConstants.cpp: (WebCore::operator<<): * Source/WebCore/rendering/style/RenderStyleConstants.h: Rename to match the standard naming. * Source/WebCore/rendering/style/RenderStyl
[webkit-changes] [WebKit/WebKit] d29115: [CSS Shape function] Add parsing support and stora...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d2911575fae37f3a740a934d2c2f874b94dd61c3 https://github.com/WebKit/WebKit/commit/d2911575fae37f3a740a934d2c2f874b94dd61c3 Author: Simon Fraser Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-shape-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-shape-parsing-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-computed.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-computed.tentative.html A LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-invalid.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-invalid.tentative.html A LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-valid.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-valid.tentative.html M LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-008-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/css/BasicShapeConversion.cpp M Source/WebCore/css/BasicShapeConversion.h A Source/WebCore/css/BasicShapesShapeSegmentConversion.cpp A Source/WebCore/css/BasicShapesShapeSegmentConversion.h M Source/WebCore/css/CSSBasicShapes.cpp M Source/WebCore/css/CSSShapeSegmentValue.cpp M Source/WebCore/css/CSSShapeSegmentValue.h M Source/WebCore/css/CSSToStyleMap.cpp M Source/WebCore/css/CSSValueKeywords.in M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/rendering/style/BasicShapes.cpp M Source/WebCore/rendering/style/BasicShapes.h A Source/WebCore/rendering/style/BasicShapesShape.cpp A Source/WebCore/rendering/style/BasicShapesShape.h M Source/WebCore/style/StyleBuilderConverter.h M Source/WebCore/style/StyleBuilderState.h Log Message: --- [CSS Shape function] Add parsing support and storage for shape() https://bugs.webkit.org/show_bug.cgi?id=277347 rdar://132814728 Reviewed by Tim Nguyen. Implement parsing, property value and computed style support for the `shape()` function[1]. We support the syntax as of the most recent edit[2] but without the flexible order of points and control points due to [3]. Added BasicShapesShapeSegmentConversion.h/cpp with helpers to convert between CSS values and the internal shapes. CSSShapeValue::customCSSText() is implemented. BasicShapeShape stores its segments as a vector of std::variant<>, much as we do for Paths, which avoids heap allocations per segment. Plumb Style::BuilderState deeper into BasicShapeConversion functions. This required passing an optional zoom override, used in some SVG cases (exercised by layout tests). Tentative WPT are included. Based on code by Noam Rosenthal. [1] https://drafts.csswg.org/css-shapes-2/#shape-function [2] https://github.com/w3c/csswg-drafts/commit/9770805c4e53 [3] https://github.com/w3c/csswg-drafts/issues/10666 * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-shape-expected.txt: Interpolation is not yet supported. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-shape-parsing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-computed.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-computed.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-invalid.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-invalid.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-valid.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/shape-function-valid.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-008-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/BasicShapeConversion.cpp: (WebCore::valueForBasicShape): (WebCore::convertToLengthPoint): (WebCore::basicShapeForValue): (WebCore::basicShapePathForValue): (WebCore::basicShapeShapeForValue): * Source/WebCore/css
[webkit-changes] [WebKit/WebKit] 9bf64e: Sync `svg/text` from WPT upstream
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9bf64e343827629889142128a37cebee8ffdad6e https://github.com/WebKit/WebKit/commit/9bf64e343827629889142128a37cebee8ffdad6e Author: Ahmad Saleem Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/svg/text/crashtests/textlength-zwj-crash.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/crashtests/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/first-letter-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/first-letter-ref.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/first-letter.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/green-100x100.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-dynamic-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-expected-mismatch.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lengthAdjust-large-font-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lengthAdjust-large-font-vertical-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lengthAdjust-large-font-vertical.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lengthAdjust-large-font.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lengthAdjust-vertical-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lengthAdjust-vertical.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/multiple-textpaths-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/no-background-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/no-margin-border-padding-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/opacity-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-bidi-controls-anchors-1-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-bidi-controls-anchors-1-ref.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-bidi-controls-anchors-1.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-bidi-controls-anchors-2-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-bidi-controls-anchors-2-ref.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-bidi-controls-anchors-2.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-complex-001-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-complex-002-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-font-face-load-image-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-font-face-load-image-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-font-face-load-image-svg.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-font-face-load-image.html A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-001-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-002-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-003-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-005-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-006-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-007-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-101-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-201-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-001-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-002-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-003-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-shape-inside-001-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-shape-inside-002-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-text-anchor-001-expected.svg A LayoutTests/imported/w3c
[webkit-changes] [WebKit/WebKit] f7dc84: Delete concept of synonyms from process-css-proper...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f7dc8448a6ab168d4994ff68fc4cfc15f6614d25 https://github.com/WebKit/WebKit/commit/f7dc8448a6ab168d4994ff68fc4cfc15f6614d25 Author: Antti Koivisto Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M Source/WebCore/css/process-css-properties.py M Tools/Scripts/webkitpy/style/checkers/jsonchecker.py Log Message: --- Delete concept of synonyms from process-css-properties.py https://bugs.webkit.org/show_bug.cgi?id=277589 rdar://problem/133124295 Reviewed by Alan Baradlay. The mechanism has been replaced by cascade aliases and is unused. * Source/WebCore/css/process-css-properties.py: (StylePropertyCodeGenProperties): (StyleProperty.__init__): (StyleProperty.from_json): (StyleProperty.perform_fixups): (StyleProperty.perform_fixups_for_synonyms): Deleted. * Tools/Scripts/webkitpy/style/checkers/jsonchecker.py: (JSONCSSPropertiesChecker.check_codegen_properties): Canonical link: https://commits.webkit.org/281807@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d3dd2b: Support closest-corner/farthest-corner in circle a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d3dd2bfb693614ceecd21241a5036baab651877a https://github.com/WebKit/WebKit/commit/d3dd2bfb693614ceecd21241a5036baab651877a Author: Simon Fraser Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-closest-corner-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-closest-corner.html A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-farthest-corner-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-farthest-corner.html A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-closest-farthest-corner-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-closest-farthest-corner.html A LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/reference/clip-path-ellipse-2-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-computed.html M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-valid.html M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/ellipse-function-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/ellipse-function-valid-expected.txt M Source/WebCore/css/BasicShapeConversion.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/rendering/style/BasicShapes.cpp M Source/WebCore/rendering/style/BasicShapes.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Support closest-corner/farthest-corner in circle and ellipse shapes https://bugs.webkit.org/show_bug.cgi?id=277454 rdar://132936677 Reviewed by Tim Nguyen. Add support for the `closest-corner` and `farthest-corner` radial-size keywords to the `circle()` and `ellipse()` basic shapes. This is specified in https://drafts.csswg.org/css-shapes/ and https://drafts.csswg.org/css-images-4/#radial-size. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-closest-corner-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-closest-corner.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-farthest-corner-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-circle-farthest-corner.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-closest-farthest-corner-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-closest-farthest-corner.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/reference/clip-path-ellipse-2-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-computed.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/circle-function-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/ellipse-function-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-functions/ellipse-function-valid-expected.txt: * Source/WebCore/css/BasicShapeConversion.cpp: (WebCore::basicShapeRadiusToCSSValue): (WebCore::cssValueToBasicShapeRadius): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeShapeRadius): * Source/WebCore/rendering/style/BasicShapes.cpp: (WebCore::BasicShapeCircle::floatValueForRadiusInBox const): (WebCore::BasicShapeEllipse::floatSizeForRadiusInBox const): (WebCore::operator<<): * Source/WebCore/rendering/style/BasicShapes.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/281808@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/
[webkit-changes] [WebKit/WebKit] 1f1720: REGRESSION (281723@main):[ iOS ]: 22 API test are ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f1720a65d5655edf8cc18ff247acd9ceee0363c https://github.com/WebKit/WebKit/commit/1f1720a65d5655edf8cc18ff247acd9ceee0363c Author: Timothy Hatcher Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M Source/WebKit/SourcesCocoa.txt M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h A Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionCommand.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMessagePort.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptions.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptions.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- REGRESSION (281723@main):[ iOS ]: 22 API test are constantly crashing. https://webkit.org/b/277563 rdar://problem/133081797 Reviewed by Wenson Hsieh. Define the old Web Extension API symbols to maintain bincompat with older OS builds. * Source/WebKit/SourcesCocoa.txt: Added _WKWebExtension.mm. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h: Added @interface. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm: Added. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h: Added @interface. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionCommand.h: Ditto. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h: Ditto. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.h: Ditto. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.h: Ditto. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h: Ditto. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMessagePort.h: Ditto. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptions.h: Ditto. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptions.h: Ditto. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Added _WKWebExtension.mm. Canonical link: https://commits.webkit.org/281809@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 959410: [JSC] Fix speculation for JSMap/SetIterator in DFG...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 959410e0ccfa1db00275b4c1f9412dc45f3ac033 https://github.com/WebKit/WebKit/commit/959410e0ccfa1db00275b4c1f9412dc45f3ac033 Author: Yijia Huang Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M Source/JavaScriptCore/bytecode/SpeculatedType.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp Log Message: --- [JSC] Fix speculation for JSMap/SetIterator in DFG and FTL https://bugs.webkit.org/show_bug.cgi?id=277576 rdar://133097257 Reviewed by Alexey Shvayka and Yusuke Suzuki. The speculation of speculateMap(Set)IteratorObject is definitely wrong. This patch fix all speculations for JSMap/SetIterator in DFG and FTL. * Source/JavaScriptCore/bytecode/SpeculatedType.cpp: (JSC::speculationFromJSType): * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): Canonical link: https://commits.webkit.org/281810@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa8948: Crash under makeString() in TextResourceDecoder::d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa8948cde34cafc320622c7d661ae40cb14edd6f https://github.com/WebKit/WebKit/commit/fa8948cde34cafc320622c7d661ae40cb14edd6f Author: Chris Dumez Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M Source/WebCore/loader/TextResourceDecoder.cpp M Source/WebCore/platform/Logging.h Log Message: --- Crash under makeString() in TextResourceDecoder::decodeAndFlush() https://bugs.webkit.org/show_bug.cgi?id=277565 rdar://133008864 Reviewed by Darin Adler. The crash seems to occurs because makeString() calls CRASH() when the resulting String's size wouldn't fit in a int32_t. There is nothing guaranteeing that the decoded data will have a size that will fit in a int32_t so I'm updating the code to use tryMakeString() instead which handles overflows without crashing and log an error in this case. * Source/WebCore/loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::decodeAndFlush): Canonical link: https://commits.webkit.org/281811@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0b6bdc: Introduce C SPI WKPageEvaluateJavaScriptInMainFram...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0b6bdc8b69f7b545c1c43217cf010f76eb6976bb https://github.com/WebKit/WebKit/commit/0b6bdc8b69f7b545c1c43217cf010f76eb6976bb Author: Alex Christensen Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M Source/WebKit/Shared/API/APIArray.cpp M Source/WebKit/Shared/API/APIArray.h M Source/WebKit/Shared/API/APIDictionary.cpp M Source/WebKit/Shared/API/APIDictionary.h A Source/WebKit/Shared/API/APISerializedScriptValue.cpp M Source/WebKit/Shared/API/APISerializedScriptValue.h M Source/WebKit/Shared/API/c/WKMutableArray.cpp M Source/WebKit/Shared/API/c/WKMutableArray.h M Source/WebKit/Shared/API/c/WKMutableDictionary.cpp M Source/WebKit/Shared/API/c/WKMutableDictionary.h M Source/WebKit/Shared/API/c/WKString.cpp M Source/WebKit/Shared/API/c/WKString.h M Source/WebKit/Sources.txt M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/C/WKPage.h M Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm M Source/WebKit/UIProcess/API/Cocoa/WKUserContentController.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDevToolsInspectedWindowCocoa.mm M Tools/TestWebKitAPI/JavaScriptTest.cpp M Tools/TestWebKitAPI/Tests/WebKit/DidAssociateFormControls.cpp M Tools/TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp M Tools/TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp M Tools/TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp M Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp M Tools/TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp M Tools/TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp M Tools/TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm M Tools/TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm M Tools/WebKitTestRunner/WorkQueueManager.cpp Log Message: --- Introduce C SPI WKPageEvaluateJavaScriptInMainFrame to avoid using WKSerializedScriptValueRef https://bugs.webkit.org/show_bug.cgi?id=277522 rdar://133024450 Reviewed by Timothy Hatcher. WKPageRunJavaScriptInMainFrame returns the result as a SerializedScriptValue, which you need a JS context to do anything with. WKWebView.evaluateJavaScript returns the result as an NSNumber, NSString, NSDate, NSArray, NSDictionary, or NSNull. This does the WKTypeRef equivalent to make the C SPI look more like the public ObjC API. The next step is to stop using SerializedScriptValue and a temporary JS context just to send a result of one of these 5 types. * Source/WebKit/Shared/API/APISerializedScriptValue.cpp: Copied from Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm. (API::SharedJSContext::SharedJSContext): (API::SharedJSContext::ensureContext): (API::SharedJSContext::releaseContextIfNecessary): (API::sharedContext): (API::SerializedScriptValue::deserializeWK): * Source/WebKit/Shared/API/APISerializedScriptValue.h: * Source/WebKit/Sources.txt: * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageRunJavaScriptInMainFrame): (WKPageEvaluateJavaScriptInMainFrame): (callRunJavaScriptBlockAndRelease): Deleted. (WKPageRunJavaScriptInMainFrame_b): Deleted. * Source/WebKit/UIProcess/API/C/WKPage.h: * Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm: (API::SerializedScriptValue::deserialize): * Source/WebKit/UIProcess/API/Cocoa/WKUserContentController.mm: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _evaluateJavaScript:asAsyncFunction:withSourceURL:withArguments:forceUserGesture:inFrame:inWorld:completionHandler:]): * Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm: (-[_WKInspectorExtension evaluateScript:frameURL:contextSecurityOrigin:useContentScriptContext:completionHandler:]): (-[_WKInspectorExtension evaluateScript:inTabWithIdentifier:completionHandler:]): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDevToolsInspectedWindowCocoa.mm: (WebKit::WebExtensionAPIDevToolsInspectedWindow::eval): Canonical link: https://commits.webkit.org/281812@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd58fd: Image decode failures should not be WebKit interna...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd58fda2512a566be80f30aa8cf43285ff414dda https://github.com/WebKit/WebKit/commit/cd58fda2512a566be80f30aa8cf43285ff414dda Author: Alex Christensen Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: M Source/WebKit/Shared/Cocoa/WebErrorsCocoa.mm M Source/WebKit/Shared/WebErrors.cpp M Source/WebKit/Shared/WebErrors.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm Log Message: --- Image decode failures should not be WebKit internal errors https://bugs.webkit.org/show_bug.cgi?id=277595 rdar://133136320 Reviewed by Tim Horton. If an image fails to decode, that should not be reported as an internal error, it should be a decode error. Otherwise we get these in stderr: ERROR: WebKit encountered an internal error. This is a WebKit bug. Also, the process was getting shut down during the message, so in practice if an image took more than a moment to load it would fail. I manually verified that adding preventProcessShutdownScope to the message fixes this issue. * Source/WebKit/Shared/Cocoa/WebErrorsCocoa.mm: (WebKit::decodeError): * Source/WebKit/Shared/WebErrors.cpp: (WebKit::decodeError): * Source/WebKit/Shared/WebErrors.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadAndDecodeImage): * Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm: (TestWebKitAPI::TEST(WebKit, LoadAndDecodeImage)): Canonical link: https://commits.webkit.org/281813@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 500827: [@page] Add support for jis-b4/jis-b5 sizes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 500827ca66dce441bc5b1e2a8b0ccecfa14417eb https://github.com/WebKit/WebKit/commit/500827ca66dce441bc5b1e2a8b0ccecfa14417eb Author: Tim Nguyen Date: 2024-08-03 (Sat, 03 Aug 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/size-valid-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/size-valid.html M LayoutTests/printing/page-format-data-expected.txt M LayoutTests/printing/page-format-data.html M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/CSSValueKeywords.in M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/style/StyleBuilder.cpp Log Message: --- [@page] Add support for jis-b4/jis-b5 sizes https://bugs.webkit.org/show_bug.cgi?id=277597 rdar://133138325 Reviewed by Darin Adler. https://drafts.csswg.org/css-page/#typedef-page-size-page-size * LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/size-valid-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/size-valid.html: Added. * LayoutTests/printing/page-format-data-expected.txt: * LayoutTests/printing/page-format-data.html: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeSize): (WebCore::CSSPropertyParserHelpers::consumePageSize): Deleted. * Source/WebCore/style/StyleBuilder.cpp: (WebCore::Style::pageSizeFromName): Canonical link: https://commits.webkit.org/281814@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
