[webkit-changes] [WebKit/WebKit] 8e166d: [GStreamer] Caps updates fixes for VideoFrame impl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e166d523ba140df8193012a9b4583bad59946a0 https://github.com/WebKit/WebKit/commit/8e166d523ba140df8193012a9b4583bad59946a0 Author: Philippe Normand Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp Log Message: --- [GStreamer] Caps updates fixes for VideoFrame implementation https://bugs.webkit.org/show_bug.cgi?id=276359 Reviewed by Xabier Rodriguez-Calvar. Copy the caps before updating them and also make sure the sample is writable before changing its caps. * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp: (WebCore::VideoFrameGStreamer::setFrameRate): (WebCore::VideoFrameGStreamer::setMaxFrameRate): Canonical link: https://commits.webkit.org/280807@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5a4113: [GStreamer] Paused pipelines accumulate when scrol...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a41131cab31450174e2b86e985cdbcfd0c60a19 https://github.com/WebKit/WebKit/commit/5a41131cab31450174e2b86e985cdbcfd0c60a19 Author: Philippe Normand Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h Log Message: --- [GStreamer] Paused pipelines accumulate when scrolling on Reddit pages with many videos https://bugs.webkit.org/show_bug.cgi?id=276296 Reviewed by Xabier Rodriguez-Calvar. Dispose the GStreamer pipeline if the destination TextureMapperPlatformLayerProxy becomes inactive, meaning that either the compositor is gone or the target layer no longer exists. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::tearDown): (WebCore::MediaPlayerPrivateGStreamer::isPipelineWaitingPreroll const): (WebCore::MediaPlayerPrivateGStreamer::buffered const): (WebCore::MediaPlayerPrivateGStreamer::pausedTimerFired): (WebCore::MediaPlayerPrivateGStreamer::pushTextureToCompositor): (WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor): (WebCore::MediaPlayerPrivateGStreamer::setVisibleInViewport): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Canonical link: https://commits.webkit.org/280808@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 487628: [Navigation] Implement NavigationDestination.getState
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4876281cfad6c0e881c669a99b48e564b7234f3e https://github.com/WebKit/WebKit/commit/4876281cfad6c0e881c669a99b48e564b7234f3e Author: Rob Buis Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-navigate-expected.txt M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/NavigationDestination.cpp M Source/WebCore/page/NavigationDestination.h M Source/WebCore/page/NavigationDestination.idl Log Message: --- [Navigation] Implement NavigationDestination.getState https://bugs.webkit.org/show_bug.cgi?id=276320 Reviewed by Alex Christensen. Implement NavigationDestination.getState functionality [1]. Note that state is not set yet in the traversal case and although it improves behaviour, it is obscured by an unrelated problem that makes those tests fail before getState is called. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigationhistoryentry-getstate * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-navigate-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): (WebCore::Navigation::dispatchPushReplaceReloadNavigateEvent): * Source/WebCore/page/NavigationDestination.cpp: (WebCore::NavigationDestination::getState const): * Source/WebCore/page/NavigationDestination.h: * Source/WebCore/page/NavigationDestination.idl: Canonical link: https://commits.webkit.org/280809@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a8589: margin and preferred width calculation for MathML ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a8589b0774a9bb9b5c19ec152cc229dc00bf0f7 https://github.com/WebKit/WebKit/commit/9a8589b0774a9bb9b5c19ec152cc229dc00bf0f7 Author: Frédéric Wang Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt M Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp M Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp M Source/WebCore/rendering/mathml/RenderMathMLRow.cpp M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp M Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp Log Message: --- margin and preferred width calculation for MathML elements https://bugs.webkit.org/show_bug.cgi?id=276358 Reviewed by Rob Buis. During calculation of MathML preferred widths, replace marginLogicalWidth() with marginIntrinsicLogicalWidthForChild(), as the margins are only set in layoutBlock (when recomputeLogicalWidth is called). This also fixes previous mistakes from 280733@main and 280768@main, when margin support was introduced for mroot and msup. * LayoutTests/TestExpectations: See https://bugs.webkit.org/show_bug.cgi?id=276358#c1 * LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-002-expected.txt: Mark all tests as PASSing. * LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Ditto. Note that mroot was even failing for the layout, not only the preferred width. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Removed, same as the generic file. * Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::computePreferredLogicalWidths): Use marginIntrinsicLogicalWidthForChild(). * Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::computePreferredLogicalWidths): Add missing marginIntrinsicLogicalWidthForChild() for mroot's index/base. (WebCore::RenderMathMLRoot::layoutBlock): Use the margin box for mroot's index/base (). * Source/WebCore/rendering/mathml/RenderMathMLRow.cpp: (WebCore::RenderMathMLRow::preferredLogicalWidthOfRowItems): Use marginIntrinsicLogicalWidthForChild(). * Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp: (WebCore::RenderMathMLScripts::computePreferredLogicalWidths): Use marginIntrinsicLogicalWidthForChild() and add one missing call. * Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::computePreferredLogicalWidths): Use marginIntrinsicLogicalWidthForChild(). Canonical link: https://commits.webkit.org/280810@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf10e5: Import updated WebCryptoAPI/derive_bits_keys from WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf10e505bfe2c38e0b30c91e404b12f013d6237b https://github.com/WebKit/WebKit/commit/cf10e505bfe2c38e0b30c91e404b12f013d6237b Author: Javier Fernandez Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_bits.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_bits.https.any.js M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_bits.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_bits.js A LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_bits_fixtures.js M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_keys.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_keys.https.any.js M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_keys.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_keys.js A LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.https.any.html A LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.https.any.js A LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.js A LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length_testcases.js A LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length_vectors.js M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.js M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker_1-1000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker_1001-2000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker_2001-3000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker_3001-last-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any_1-1000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any_1001-2000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any_2001-3000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any_3001-last-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.js M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_1-1000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_1001-2000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_2001-3000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_3001-4000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_4001-5000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_5001-6000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_6001-7000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_7001-8000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_8001-last-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any_1-1000-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_
[webkit-changes] [WebKit/WebKit] efacbb: Fix error in flexbox alignment overflow calculations.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: efacbbdcc42539c57f1fe9c5dcf40251ce703eef https://github.com/WebKit/WebKit/commit/efacbbdcc42539c57f1fe9c5dcf40251ce703eef Author: Elika Etemad Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: A LayoutTests/fast/overflow/flexbox-abspos-overflow-expected.html A LayoutTests/fast/overflow/flexbox-abspos-overflow.html A LayoutTests/fast/overflow/flexbox-multiline-overflow-expected.html A LayoutTests/fast/overflow/flexbox-multiline-overflow.html M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt M Source/WebCore/rendering/RenderFlexibleBox.cpp Log Message: --- Fix error in flexbox alignment overflow calculations. https://bugs.webkit.org/show_bug.cgi?id=276382 rdar://131201271 Reviewed by Alan Baradlay. This patch fixes the logic in contentAlignmentStartOverflow correctly clamp overflow, by handling reversed flows properly rather than returning an overly-large value in some cases. It also fixes the error where we only account for the last flex line. * LayoutTests/fast/overflow/flexbox-abspos-overflow-expected.html: Added. * LayoutTests/fast/overflow/flexbox-abspos-overflow.html: Added. * LayoutTests/fast/overflow/flexbox-multiline-overflow-expected.html: Added. * LayoutTests/fast/overflow/flexbox-multiline-overflow.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt: Partial revert of 273737@main * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt: Partial revert of 273737@main * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Shift reset for m_justifyContentStartOverflow out of the flex line loop. (WebCore::contentAlignmentStartOverflow): Fix logic to correctly account for reversing. (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Update call to pass reversing parameter. (WebCore::RenderFlexibleBox::alignFlexLines): Update call to pass reversing parameter, and fix multiline handling. Canonical link: https://commits.webkit.org/280812@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 04cc4a: [MSE][GStreamer] block data flow until source pad ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 04cc4a4e2fc235ab43cc38dbe880d9ddb6b6e5dd https://github.com/WebKit/WebKit/commit/04cc4a4e2fc235ab43cc38dbe880d9ddb6b6e5dd Author: Enrique Ocaña González Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp Log Message: --- [MSE][GStreamer] block data flow until source pad is exposed https://bugs.webkit.org/show_bug.cgi?id=276251 Reviewed by Xabier Rodriguez-Calvar. In WebKitMediaSrc, there could be a race between main thread (linking typefind element, see gsturisourcebin.c:setup_typefind) and streaming thread (pushing data). webKitMediaSrcLoop does wait for source pad to linked. However, there is no guarantee that peer pad is already active at that point. This may lead to data loss while peer the pad is being activated. This change blocks downstream flow during pad addition, allowing urisourcebin to link/activate typefind sink pad. See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1355 Original patch by Eugene Mutavchi . * Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp: (webKitMediaSrcEmitStreams): Add blocking probes to the Streams Pads, which will be removed after the pad has been added to the element. Canonical link: https://commits.webkit.org/280813@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2931ba: [WPE] WPE Platform: fix handling of view to send t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2931ba164f1ce2d8f9b0ddc448df90ad17222a68 https://github.com/WebKit/WebKit/commit/2931ba164f1ce2d8f9b0ddc448df90ad17222a68 Author: Carlos Garcia Campos Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWaylandPrivate.h M Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp Log Message: --- [WPE] WPE Platform: fix handling of view to send touch events under wayland https://bugs.webkit.org/show_bug.cgi?id=276423 Reviewed by Alejandro G. Castro. Touch events are only sent to the right WPEView if the current toplevel has the keyboard focus. We need to track the toplevel currently under touch the same way we do for pointer and keyboard events. * Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp: (wpeToplevelWaylandSetIsUnderTouch): (wpeToplevelWaylandGetVisibleViewUnderTouch): * Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWaylandPrivate.h: * Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp: Canonical link: https://commits.webkit.org/280814@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89f95d: Add missing `required` for RTCCodecStats dictionar...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89f95d2d94f9d1659c4a4243861bf740cfa77b8c https://github.com/WebKit/WebKit/commit/89f95d2d94f9d1659c4a4243861bf740cfa77b8c Author: Ahmad Saleem Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebCore/Modules/mediastream/RTCStatsReport.h M Source/WebCore/Modules/mediastream/RTCStatsReport.idl M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp Log Message: --- Add missing `required` for RTCCodecStats dictionary in RTCStatsReport.idl https://bugs.webkit.org/show_bug.cgi?id=274026 rdar://problem/128306882 Reviewed by Youenn Fablet and Philippe Normand. This patch aligns 'RTCCodecStats' as per web specification [1]: [1] https://w3c.github.io/webrtc-stats/#dom-rtccodecstats WebKit was missing `required` for 'payloadType', 'transportId' and 'mimeType' and this patch adds it. * Source/WebCore/Modules/mediastream/RTCStatsReport.h: * Source/WebCore/Modules/mediastream/RTCStatsReport.idl: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp: (WebCore::RTCStatsReport::CodecStats::CodecStats): Canonical link: https://commits.webkit.org/280815@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c49be9: Web Inspector: Add Versioned Protocol for iOS 18.0...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c49be90e170a4f8966126ca17ad32223fa95155f https://github.com/WebKit/WebKit/commit/c49be90e170a4f8966126ca17ad32223fa95155f Author: Razvan Caliman Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: A Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.0/InspectorBackendCommands.js A Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.0/InspectorBackendCommands.js A Source/WebInspectorUI/Versions/Inspector-iOS-18.0.json A Source/WebInspectorUI/Versions/Inspector-macOS-15.0.json Log Message: --- Web Inspector: Add Versioned Protocol for iOS 18.0 and macOS 15.0 https://bugs.webkit.org/show_bug.cgi?id=276234 rdar://131129905 Reviewed by Devin Rousso. Add a snapshot of protocol definitions used while inspecting iOS 18.0 and macOS 15.0. * Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.0/InspectorBackendCommands.js: Added. * Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.0/InspectorBackendCommands.js: Added. * Source/WebInspectorUI/Versions/Inspector-iOS-18.0.json: Added. * Source/WebInspectorUI/Versions/Inspector-macOS-15.0.json: Added. Canonical link: https://commits.webkit.org/280816@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 88b600: Debug assertion `ASSERT(editingRange.location != n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88b600d040a8c6caf2c28647720de8087aad63de https://github.com/WebKit/WebKit/commit/88b600d040a8c6caf2c28647720de8087aad63de Author: Richard Robinson Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebKit/Shared/EditingRange.cpp Log Message: --- Debug assertion `ASSERT(editingRange.location != notFound)` is frequently hit in Mail compose https://bugs.webkit.org/show_bug.cgi?id=276403 rdar://131427649 Reviewed by Ryosuke Niwa. The pattern of clients calling `selectedRangeWithCompletionHandler`, then passing the resulting range to `attributedSubstringForProposedRange` is not uncommon and happens in several circumstances (for example, AppKit does this when replying to an email in Mail, and WritingTools does this when showing the affordance). Since it is perfectly valid for `selectedRangeWithCompletionHandler` to return `NSNotFound`, and also valid for `attributedSubstringForProposedRange` to receive `NSNotFound`, and also results in valid behavior (when it is notFound, the behavior is just to return the whole range of the editable content), this assertion can and should be removed. * Source/WebKit/Shared/EditingRange.cpp: (WebKit::EditingRange::toRange): Canonical link: https://commits.webkit.org/280817@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 72c9c0: Disable chronod when booting simulated devices for...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 72c9c0bd54a86cce02e64a1b9fe8b6c3e57851b4 https://github.com/WebKit/WebKit/commit/72c9c0bd54a86cce02e64a1b9fe8b6c3e57851b4 Author: Ben Schwartz Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Tools/Scripts/webkitpy/xcode/simulated_device.py M Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py Log Message: --- Disable chronod when booting simulated devices for testing. rdar://13023 https://bugs.webkit.org/show_bug.cgi?id=275623 Reviewed by Elliott Williams. We're observing abnormally large memory usage from widgets-related processes on the iOS simulator. To combat this during investigation, we should unload `chronod` at simulator startup. * Tools/Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDeviceManager.Runtime.__init__): Add runtime.root (path to simulator runtime root). (SimulatedDeviceManager._create_device_with_runtime): Pass runtime root path to device init method. (SimulatedDevice.__init__): Add device.runtime_root (path to simulator runtime root). * Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py: Update mock data to include runtimeRoot. Canonical link: https://commits.webkit.org/280818@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d14f1: Do not dispatch fetch event if its client is alrea...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d14f119e11e9b20df828804d9c76cac7517fad8 https://github.com/WebKit/WebKit/commit/5d14f119e11e9b20df828804d9c76cac7517fad8 Author: Youenn Fablet Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: A LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https-expected.txt A LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https.html M Source/WebCore/workers/service/context/ServiceWorkerFetch.h M Source/WebCore/workers/service/context/ServiceWorkerThread.cpp M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h Log Message: --- Do not dispatch fetch event if its client is already cancelled https://bugs.webkit.org/show_bug.cgi?id=276417 rdar://131072280 Reviewed by Chris Dumez. We are adding a fetch task and cancelling it when receiving IPC messages. We are then queuing a task on the event loop to dispatch the fetch event. If the cancel message happens before the dispatch of the fetch event, we are no longer dispatching the event since it is unnecessary. To do so, we update the ServiceWorkerFetch::Client class to add a isCancelled getter and use it before dispatching the event. * LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https-expected.txt: Added. * LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https.html: Added. * Source/WebCore/workers/service/context/ServiceWorkerFetch.h: (WebCore::ServiceWorkerFetch::Client::isCancelled const): (WebCore::ServiceWorkerFetch::Client::cancel): * Source/WebCore/workers/service/context/ServiceWorkerThread.cpp: (WebCore::ServiceWorkerThread::queueTaskToFireFetchEvent): * Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: (WebKit::WebServiceWorkerFetchTaskClient::doCancel): (WebKit::WebServiceWorkerFetchTaskClient::cancel): Deleted. * Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h: Canonical link: https://commits.webkit.org/280819@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a37ba2: Adopt more smart pointers in loading
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a37ba25938493f786b6241403547d8c805ba4e71 https://github.com/WebKit/WebKit/commit/a37ba25938493f786b6241403547d8c805ba4e71 Author: Rob Buis Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/ResourceLoadNotifier.cpp M Source/WebCore/loader/ResourceLoader.cpp M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp Log Message: --- Adopt more smart pointers in loading https://bugs.webkit.org/show_bug.cgi?id=276363 Reviewed by Chris Dumez. Adopt more smart pointers in loading involving DocumentLoader accessing. This PR also fixes a few places where DocumentLoader was accessed unnecessarily. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::updateRequestAndAddExtraFields): (WebCore::FrameLoader::loadDifferentDocumentItem): * Source/WebCore/loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): * Source/WebCore/loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequestInternal): * Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingEntry): (WebCore::ApplicationCacheGroup::didFailLoadingEntry): (WebCore::ApplicationCacheGroup::didFailLoadingManifest): (WebCore::ApplicationCacheGroup::startLoadingEntry): * Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Canonical link: https://commits.webkit.org/280820@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de89aa: Optimize RenderBlock::paintCarets()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de89aaf09e387343d31cc8ae0c5a3a599f368894 https://github.com/WebKit/WebKit/commit/de89aaf09e387343d31cc8ae0c5a3a599f368894 Author: Simon Fraser Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/TextBoxPainter.cpp Log Message: --- Optimize RenderBlock::paintCarets() https://bugs.webkit.org/show_bug.cgi?id=276407 rdar://131436270 Reviewed by Alan Baradlay. `paintCarets()` calls `paintCaret()` for the two caret types, and in each branch we access either `frame().selection()` twice, or `page().dragCaretController()` twice, and compute `isContentEditable` even when we won't use it. Refactor `RenderBlock::paintCaret()` to just switch once for each caret type, using a lambda for the tiny bit of common code. Add early returns for the common case of no selection node, thus no renderer. `DragCaretController::caretRenderer()` can early return to avoid copying a `Position` by value. Move some variables in `TextBoxPainter::paintCompositionForeground()` to their point of first use. * Source/WebCore/editing/FrameSelection.cpp: (WebCore::DragCaretController::caretRenderer const): * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): * Source/WebCore/rendering/TextBoxPainter.cpp: (WebCore::TextBoxPainter::paintCompositionForeground): Canonical link: https://commits.webkit.org/280821@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a5621e: Web Inspector: Update COMPATIBILITY (macOS X.0, iO...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a5621e0c9b61812f4b37be8c0e79dcdbfc96cc3e https://github.com/WebKit/WebKit/commit/a5621e0c9b61812f4b37be8c0e79dcdbfc96cc3e Author: Razvan Caliman Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js M Source/WebInspectorUI/UserInterface/Models/DOMNode.js M Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js M Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js M Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js Log Message: --- Web Inspector: Update COMPATIBILITY (macOS X.0, iOS X.0) comments with latest versions https://bugs.webkit.org/show_bug.cgi?id=276232 rdar://129159284 Reviewed by Devin Rousso. * Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js: (WI.ConsoleManager.prototype.messagesCleared): (WI.ConsoleManager.prototype._setConsoleClearAPIEnabled): * Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js: (WI.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback): (WI.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility): * Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js: (WI.SettingsTabContentView.prototype._createConsoleSettingsView): Canonical link: https://commits.webkit.org/280822@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ca870: WKWebView _loadAndDecodeImage's maximum size param...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ca87096bd024ce32d7bfe87e86883db12a145fa https://github.com/WebKit/WebKit/commit/7ca87096bd024ce32d7bfe87e86883db12a145fa Author: Tim Horton Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/DestinationColorSpace.cpp M Source/WebCore/platform/graphics/DestinationColorSpace.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm Log Message: --- WKWebView _loadAndDecodeImage's maximum size parameter crops the image instead of scaling it https://bugs.webkit.org/show_bug.cgi?id=276384 rdar://131406675 Reviewed by Simon Fraser. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadAndDecodeImage): The _loadAndDecodeImage method has an optional parameter allowing clients to choose a maximum size for the image to be scaled into. However, the implementation crops the image into the maximum size, instead of scaling into it. Also, it currently scales images *up* to fit in the maximum size, instead of leaving smaller images alone. Fix both of these issues. Also, drive-by add a fallback to an sRGB destination in cases where the decoded image has a colorspace that it is not possible for us to draw into. Canonical link: https://commits.webkit.org/280823@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 91279c: Clean up some Apple Pay related feature flags
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 91279c62cb946d291e35eb9e67ae0f73eedc855c https://github.com/WebKit/WebKit/commit/91279c62cb946d291e35eb9e67ae0f73eedc855c Author: Tim Horton Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/PlatformUse.h M Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm M Source/WebCore/PAL/pal/spi/cocoa/PassKitInstallmentsSPI.h M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Clean up some Apple Pay related feature flags https://bugs.webkit.org/show_bug.cgi?id=276396 rdar://131420608 Reviewed by Abrar Rahman Protyasha and Sam Weinig. * Source/WTF/wtf/PlatformEnableCocoa.h: Assume ENABLE_APPLE_PAY_FEATURES if ENABLE_APPLE_PAY. Add ENABLE_APPLE_PAY_SETUP. * Source/WTF/wtf/PlatformHave.h: Add HAVE_PASSKIT and make it toggle all of the universally available HAVE_PASSKIT_* flags. Squish a bunch of the aforementioned flags together, removing some always-true version checks. * Source/WTF/wtf/PlatformUse.h: Define USE_PASSKIT in only one place. * Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm: (WebCore::convert): Drive-by workaround for a warning with PassKit on some recent SDKs. * Source/WebCore/PAL/pal/spi/cocoa/PassKitInstallmentsSPI.h: Remove PASSKIT_INSTALLMENTS_IN_SDK, just use APPLE_INTERNAL_SDK like other SPI headers. * Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::WebPaymentCoordinatorProxy::platformBeginApplePaySetup): (WebKit::WebPaymentCoordinatorProxy::platformEndApplePaySetup): Respect ENABLE_APPLE_PAY_SETUP. Fail immediately if it's not available. * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (operator==): (TEST(IPCSerialization, Basic)): USE(PASSKIT) already covers these platform exclusions; stop duplicating them. Canonical link: https://commits.webkit.org/280824@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 03191f: [ews] Add validation to prevent SDK or OS version ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 03191fc211d8c2f79172f58e36fc435b20e092f4 https://github.com/WebKit/WebKit/commit/03191fc211d8c2f79172f58e36fc435b20e092f4 Author: Aakash Jain Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [ews] Add validation to prevent SDK or OS version mismatch between corresponding builds on tester and builder queues https://bugs.webkit.org/show_bug.cgi?id=276379 Reviewed by Sam Sneddon. * Tools/CISupport/ews-build/steps.py: (Trigger.propertiesToPassToTriggers): (PrintConfiguration): (PrintConfiguration.run): (PrintConfiguration.parseAndValidate): (PrintConfiguration.getResultSummary): Canonical link: https://commits.webkit.org/280825@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0c94d8: Unreviewed, reverting 280317@main (c6894f128e9b)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c94d8cc6f1a7d386f656539ae4afb3db7f28519 https://github.com/WebKit/WebKit/commit/0c94d8cc6f1a7d386f656539ae4afb3db7f28519 Author: Dan Hecht Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/bmalloc/libpas/src/libpas/pas_bitfit_heap.c M Source/bmalloc/libpas/src/libpas/pas_segregated_heap.c M Source/bmalloc/libpas/src/test/BmallocTests.cpp Log Message: --- Unreviewed, reverting 280317@main (c6894f128e9b) https://bugs.webkit.org/show_bug.cgi?id=276430 rdar://131470729 PAS_ASSERT at pas_segregated_size_directory_enable_exclusive_views + 2032 Reverted change: [libpas] pas_segregated_heap_ensure_size_directory_for_size/check_medium_directories assert fail due to creating overlapping directories https://bugs.webkit.org/show_bug.cgi?id=275820 rdar://129774839 280317@main (c6894f128e9b) Canonical link: https://commits.webkit.org/280826@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 41ccf2: Fix internal builds after 280824@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 41ccf2c1317837ebe0d888bfeaa7027afa800665 https://github.com/WebKit/WebKit/commit/41ccf2c1317837ebe0d888bfeaa7027afa800665 Author: Tim Horton Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- Fix internal builds after 280824@main https://bugs.webkit.org/show_bug.cgi?id=276439 rdar://131476601 Unreviewed build fix. * Source/WTF/wtf/PlatformHave.h: Canonical link: https://commits.webkit.org/280827@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5666c1: PROGRESSION(275095@main): [ macOS ] workers/wasm-h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5666c1cb7742fac72df76acfb78b3e2ecedc4aa9 https://github.com/WebKit/WebKit/commit/5666c1cb7742fac72df76acfb78b3e2ecedc4aa9 Author: Anfernee Viduya Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- PROGRESSION(275095@main): [ macOS ] workers/wasm-hashset-many.h tml is flakey crashing. https://bugs.webkit.org/show_bug.cgi?id=276434 rdar://131474541 Unreviewed test gardening. Setting test expectations. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/280828@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4840a7: Migrate internal iOS 18 test baselines/expectation...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4840a7f165cbfa5794f7196737072336469ebb1c https://github.com/WebKit/WebKit/commit/4840a7f165cbfa5794f7196737072336469ebb1c Author: Ben Schwartz Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: A LayoutTests/platform/ios-17/TestExpectations A LayoutTests/platform/ios-17/css2.1/t0805-c5518-brdr-t-01-e-expected.txt A LayoutTests/platform/ios-17/css2.1/t0805-c5519-brdr-r-00-a-expected.txt A LayoutTests/platform/ios-17/css2.1/t0805-c5520-brdr-b-01-e-expected.txt A LayoutTests/platform/ios-17/css2.1/t0805-c5521-brdr-l-00-a-expected.txt A LayoutTests/platform/ios-17/css2.1/t0805-c5521-brdr-l-01-e-expected.txt A LayoutTests/platform/ios-17/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt A LayoutTests/platform/ios-17/css2.1/t0905-c414-flt-02-c-expected.txt A LayoutTests/platform/ios-17/css2.1/t0905-c414-flt-03-c-expected.txt A LayoutTests/platform/ios-17/css2.1/t0905-c414-flt-04-c-expected.txt A LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltblck-01-d-expected.txt A LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt A LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt A LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt A LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt A LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltwrap-00-b-expected.txt A LayoutTests/platform/ios-17/css2.1/t090501-c414-flt-01-b-expected.txt A LayoutTests/platform/ios-17/css2.1/t090501-c414-flt-03-b-g-expected.txt A LayoutTests/platform/ios-17/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt A LayoutTests/platform/ios-17/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt A LayoutTests/platform/ios-17/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt A LayoutTests/platform/ios-17/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-in-loose-expected.txt A LayoutTests/platform/ios-17/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-pr-normal-expected.txt A LayoutTests/platform/ios-17/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-pr-strict-expected.txt A LayoutTests/platform/ios-17/imported/w3c/web-platform-tests/css/css-text/i18n/zh/css-text-line-break-zh-pr-normal-expected.txt A LayoutTests/platform/ios-17/imported/w3c/web-platform-tests/css/css-text/i18n/zh/css-text-line-break-zh-pr-strict-expected.txt M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/ios/css2.1/t0805-c5518-brdr-t-01-e-expected.txt M LayoutTests/platform/ios/css2.1/t0805-c5519-brdr-r-00-a-expected.txt M LayoutTests/platform/ios/css2.1/t0805-c5520-brdr-b-01-e-expected.txt M LayoutTests/platform/ios/css2.1/t0805-c5521-brdr-l-00-a-expected.txt M LayoutTests/platform/ios/css2.1/t0805-c5521-brdr-l-01-e-expected.txt M LayoutTests/platform/ios/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt M LayoutTests/platform/ios/css2.1/t0905-c414-flt-02-c-expected.txt M LayoutTests/platform/ios/css2.1/t0905-c414-flt-03-c-expected.txt M LayoutTests/platform/ios/css2.1/t0905-c414-flt-04-c-expected.txt M LayoutTests/platform/ios/css2.1/t0905-c5525-fltblck-01-d-expected.txt M LayoutTests/platform/ios/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt M LayoutTests/platform/ios/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt M LayoutTests/platform/ios/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt M LayoutTests/platform/ios/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt M LayoutTests/platform/ios/css2.1/t0905-c5525-fltwrap-00-b-expected.txt M LayoutTests/platform/ios/css2.1/t090501-c414-flt-01-b-expected.txt M LayoutTests/platform/ios/css2.1/t090501-c414-flt-03-b-g-expected.txt M LayoutTests/platform/ios/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt M LayoutTests/platform/ios/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt M LayoutTests/platform/ios/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-in-loose-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-pr-normal-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-pr-strict-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-text/i18n/zh/css-text-line-break-zh-pr-normal-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-text/i18n/zh/css-text-line-break-zh-pr-strict-expected.txt Log Message: --- Migrate internal iOS 18 test baselines/expectations to OpenSource. https://bugs.webkit.org/show_bug.cgi?id=276370 rdar://131389611 Reviewed by Ryan Haddad. Migratin
[webkit-changes] [WebKit/WebKit] fce181: [JSC] Should use WeakPtr for Waiter's TicketData
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fce181433e3b5225ab4b92a9be2491415964291a https://github.com/WebKit/WebKit/commit/fce181433e3b5225ab4b92a9be2491415964291a Author: Yijia Huang Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/JavaScriptCore/runtime/WaiterListManager.cpp M Source/JavaScriptCore/runtime/WaiterListManager.h Log Message: --- [JSC] Should use WeakPtr for Waiter's TicketData https://bugs.webkit.org/show_bug.cgi?id=276410 rdar://131442732 Reviewed by Yusuke Suzuki. Previously, we fixed the memory issue in DeferredWorkTimer::TicketData by letting JSGlobalObject to strong reference TicketData's dependencies[1]. Later, we fixed the tracked TicketData with WeakHashSet in JSGlobalObject[2]. This patch fixed a similar issue by applying WeakPtr to Waiter's TicketData. I've confirmed that all DeferredWorkTimer::TicketData uses are guarded by WeakPtr, WeakHashSet, Ref, or RefPtr. [1] https://commits.webkit.org/279852@main [2] https://commits.webkit.org/280180@main * Source/JavaScriptCore/runtime/WaiterListManager.cpp: (JSC::Waiter::scheduleWorkAndClearTicket): (JSC::WaiterListManager::cancelAsyncWaiter): (JSC::Waiter::dump const): * Source/JavaScriptCore/runtime/WaiterListManager.h: Canonical link: https://commits.webkit.org/280830@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 099cda: Move methods of WinCairoPort class to the super class
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 099cdafc1313f7d09867dc8c86ee1fde67c4fdaa https://github.com/WebKit/WebKit/commit/099cdafc1313f7d09867dc8c86ee1fde67c4fdaa Author: Fujii Hironori Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py M Tools/Scripts/webkitpy/port/win.py Log Message: --- Move methods of WinCairoPort class to the super class https://bugs.webkit.org/show_bug.cgi?id=271244 Reviewed by Don Olmstead. Apple Windows port has gone. WinCairoPort class should be renamed to WinPort. This is a preparation for it. * Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py: * Tools/Scripts/webkitpy/port/win.py: Canonical link: https://commits.webkit.org/280831@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5c0b0d: iOS 18 expectations migration: update one test exp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5c0b0d8e9424e00098979be2ddbe08a3672afe99 https://github.com/WebKit/WebKit/commit/5c0b0d8e9424e00098979be2ddbe08a3672afe99 Author: Ben Schwartz Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M LayoutTests/platform/ios-17/TestExpectations Log Message: --- iOS 18 expectations migration: update one test expectation. https://bugs.webkit.org/show_bug.cgi?id=276370 rdar://131389611 Unreviewed test gardening. Updating test expectation for one straggling test after the iOS 18 baselines/ expectations migration completed in 280829@main. * LayoutTests/platform/ios-17/TestExpectations: Canonical link: https://commits.webkit.org/280832@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a0185: Support border/padding/margin on RenderMathMLOperator
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a01858119398922a3baa934a4eb225786d15cda https://github.com/WebKit/WebKit/commit/9a01858119398922a3baa934a4eb225786d15cda Author: Frédéric Wang Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp Log Message: --- Support border/padding/margin on RenderMathMLOperator https://bugs.webkit.org/show_bug.cgi?id=276357 Reviewed by Rob Buis. This patch adds support for border/padding/margin on `` elements for which useMathOperator() returns true and therefore uses use special layout and painting instead of deferring to RenderMathMLToken. * LayoutTests/TestExpectations: Mark borders/paddings/margins reftests for largeop/stretchy operators as passing. * Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::stretchTo): Include borders/paddings in logical width/height. (WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Include borders/paddings in preferred width. Children are text nodes, no need to consider margins. (WebCore::RenderMathMLOperator::layoutBlock): Include borders/paddings for in logical width/height. Also call recomputeLogicalWidth() to set the inline margins on the element (block margins are handled by the parent). Children are text nodes, no need to consider margins for them. (WebCore::RenderMathMLOperator::firstLineBaseline const): Include border/padding in the ascent. (WebCore::RenderMathMLOperator::paint): Shift painting by the left/top border/padding. Canonical link: https://commits.webkit.org/280833@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2cefb: http/tests/xmlhttprequest/gzip-content-type.html g...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2cefb9ce6aa390c827015ad65ab440ac2745bbc https://github.com/WebKit/WebKit/commit/e2cefb9ce6aa390c827015ad65ab440ac2745bbc Author: Chris Dumez Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M LayoutTests/http/conf/apache2.4-darwin-httpd.conf Log Message: --- http/tests/xmlhttprequest/gzip-content-type.html gives a different output depending on Apache version https://bugs.webkit.org/show_bug.cgi?id=276406 rdar://131423730 Reviewed by Brady Eidson and Aakash Jain. Some of out bots recently got an updated Apache version. When this happened, 2 XHR tests dealing with gzip-compressed responses have had a different output. In particular, the `Content-Length` HTTP header is no longer present on the response. Set the `ap_trust_cgilike_cl` Apache environment variable to allow CGI scripts to set the `Content-Length` HTTP header again, for backward compatibility: - https://httpd.apache.org/docs/current/env.html * LayoutTests/http/conf/apache2.4-darwin-httpd.conf: Canonical link: https://commits.webkit.org/280834@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5172cd: Import wpts for css-scrollbars
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5172cde601cc8795578f60f068b187b283a296bf https://github.com/WebKit/WebKit/commit/5172cde601cc8795578f60f068b187b283a296bf Author: Nikolaos Mouchtaris Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json R LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/auto-scrollbar-inline-children-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/auto-scrollbar-inline-children.html R LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/multicol-in-orthogonal-writing-mode-crash.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-001.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-002.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-003.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-004.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-005.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006-mis-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-mis-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-mis-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009-mis-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010-mis-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-011-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-011-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-011-mis-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-011-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-011.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-012-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-012-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-012.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-1-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-1-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-1-mis-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-1-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-1.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-2-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-2-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-2-mis-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-2-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-2.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-3-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-3-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-3-mis-ref.html
[webkit-changes] [WebKit/WebKit] 69db44: [libpas] PGM Crash Testing: Align allocation to pa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 69db44623766e6e27c87f20d7cb5add5220d59e9 https://github.com/WebKit/WebKit/commit/69db44623766e6e27c87f20d7cb5add5220d59e9 Author: Brandon Stewart Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp Log Message: --- [libpas] PGM Crash Testing: Align allocation to page size https://bugs.webkit.org/show_bug.cgi?id=276181 rdar://problem/13106 Reviewed by David Kilzer. PGM will align pages left or right, so by allocating the entire length of the page it will give the same result whether left or right aligned. This will make testing guard pages reliable again. * Source/JavaScriptCore/jsc.cpp: (crashPGMUAF): (crashPGMUpperGuardPage): (crashPGMLowerGuardPage): Canonical link: https://commits.webkit.org/280836@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 36f50a: [JSC] Disallow yield/await expressions in class fi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 36f50aab423c74d3b9b941e41a49b7ca2d581668 https://github.com/WebKit/WebKit/commit/36f50aab423c74d3b9b941e41a49b7ca2d581668 Author: Dan Hecht Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: A JSTests/stress/yield-await-class-field-initializer-expr.js M Source/JavaScriptCore/parser/Parser.cpp Log Message: --- [JSC] Disallow yield/await expressions in class field initializers https://bugs.webkit.org/show_bug.cgi?id=276438 rdar://119044881 Reviewed by Yusuke Suzuki. The language spec doesn't explictly disallow yield and await expressions in class field initializers, however it implicitly does given that the expression is effectively evaluated as if it's inside a method. Additionally, the consensus seems to be that these expressions should not be allowed, see: https://github.com/tc39/ecma262/issues/ The yield and await expressions are now handled differently, but similar to how they are each handled in other contexts. This also seems to be the least disruptive way to handle existing scripts, as well as consistent with other engines: yield: raise syntax error await: parse as an identifier Also adding a new test that generates and verifies scripts containing a class with a field initializer containing yield and await, where the class is either not nested or nested inside generator or async functions to verify the behavior of various combinations. * Source/JavaScriptCore/parser/Parser.cpp: (JSC::Parser::parseYieldExpression): (JSC::Parser::parseAwaitExpression): (JSC::Parser::parsePrimaryExpression): (JSC::Parser::parseUnaryExpression): Canonical link: https://commits.webkit.org/280837@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a053f: Clicking and dragging video viewer drags a layer ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a053f41c96e04f9c7747d6fad34251896c44542 https://github.com/WebKit/WebKit/commit/8a053f41c96e04f9c7747d6fad34251896c44542 Author: Dana Estra Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebCore/Modules/modern-media-controls/media/media-controller.js Log Message: --- Clicking and dragging video viewer drags a layer on top of the other https://bugs.webkit.org/show_bug.cgi?id=276400 rdar://127512495 Reviewed by Jer Noble and Antoine Quint. On YouTube.com, clicking and dragging on a video in Video Viewer causes elements on the page behind the video to come to the forefront. This is because YouTube gives a draggable=true attribute to the parent div of the video element. To fix this, now when we enter fullscreen on macOS, we add a dragstart event listener to the window, which calls preventDefault() when the dragstart event occurs. We remove this event listener when we enter inline. * Source/WebCore/Modules/modern-media-controls/media/media-controller.js: (MediaController.prototype.handleEvent): (MediaController.prototype._updateControlsIfNeeded): Canonical link: https://commits.webkit.org/280838@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad9437: Allow WKWebView clients to toggle fullscreen video
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad94373263a77c433dc04da03a3029c58962182b https://github.com/WebKit/WebKit/commit/ad94373263a77c433dc04da03a3029c58962182b Author: Andy Estes Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/HTMLMediaElement.h M Source/WebCore/platform/cocoa/PlaybackSessionModel.h M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm M Source/WebKit/UIProcess/mac/PageClientImplMac.mm M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLifecycle.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSpatialTrackingLabels.mm M Tools/TestWebKitAPI/Tests/mac/InWindowFullscreen.mm M Tools/TestWebKitAPI/Utilities.h Log Message: --- Allow WKWebView clients to toggle fullscreen video https://bugs.webkit.org/show_bug.cgi?id=276376 rdar://131394306 Reviewed by Jer Noble. Added APIs to WKWebViewPrivate.h that allow clients to (a) determine whether they can enter fullscreen video (-_canEnterFullscreen), and (b) enter fullscreen programatically (-_enterFullscreen). -_canEnterFullscreen is key-value observable. While here, made it possible to create a CheckedPtr to PlaybackSessionModel and WebFullScreenManagerProxy and fixed a bug with how PlaybackSessionManager::(enter|exit)Fullscreen created UserGestureIndicators. Added an API test. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/html/HTMLMediaElement.h: * Source/WebCore/platform/cocoa/PlaybackSessionModel.h: * Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h: * Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm: (WebCore::PlaybackSessionModelMediaElement::enterFullscreen): (WebCore::PlaybackSessionModelMediaElement::exitFullscreen): * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _canEnterFullscreen]): (-[WKWebView _enterFullscreen]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h: * Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h: * Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm: (WebKit::PageClientImplCocoa::videoControlsManagerDidChange): * Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h: (WebKit::PlaybackSessionManagerProxy::hasControlsManagerInterface const): * Source/WebKit/UIProcess/WebFullScreenManagerProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::canEnterFullscreen): (WebKit::WebPageProxy::enterFullscreen): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::videoControlsManagerDidChange): * Source/WebKit/UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::videoControlsManagerDidChange): * Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm: (WebKit::PlaybackSessionManager::enterFullscreen): (WebKit::PlaybackSessionManager::exitFullscreen): * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLifecycle.mm: Added. (-[FullscreenLifecycleObserver observeValueForKeyPath:ofObject:change:context:]): (TEST(Fullscreen, Lifecycle)): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSpatialTrackingLabels.mm: (TEST(WKWebView, DefaultSTSLabel)): * Tools/TestWebKitAPI/Tests/mac/InWindowFullscreen.mm: (TestWebKitAPI::TEST(InWindowFullscreen, CanToggleAfterPlaybackStarts)): (TestWebKitAPI::TEST(InWindowFullscreen, ToggleChangesIsActive)): (TestWebKitAPI::TEST(InWindowFullscreen, ToggleChangesIsActiveWithoutUserGesture)): (TestWebKitAPI::testEventually): Deleted. * Tools/TestWebKitAPI/Utilities.h: (TestWebKitAPI::Util::waitFor): Canonical link: https://commits.webkit.org/280839@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1bd46d: Add more release logging in RemoteLayerTreeDrawing...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1bd46d2bfa1bbcbea92fdda7080772ba32d7abdf https://github.com/WebKit/WebKit/commit/1bd46d2bfa1bbcbea92fdda7080772ba32d7abdf Author: Ryosuke Niwa Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebKit/UIProcess/DrawingAreaProxy.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h Log Message: --- Add more release logging in RemoteLayerTreeDrawingAreaProxyMac https://bugs.webkit.org/show_bug.cgi?id=276412 Reviewed by Simon Fraser. Add loggings when RemoteLayerTreeDrawingAreaProxyMac adds observer or its observer gets called for the first time after WKWebView becomes visible. * Source/WebKit/UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::viewIsBecomingVisible): (WebKit::DrawingAreaProxy::viewIsBecomingInvisible): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm: (WebKit::RemoteLayerTreeDrawingAreaProxyMac::scheduleDisplayRefreshCallbacks): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::viewIsBecomingVisible): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::viewIsBecomingInvisible): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::didRefreshDisplay): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dispatchActivityStateChange): (WebKit::WebPageProxy::viewIsBecomingVisible): (WebKit::WebPageProxy::viewIsBecomingInvisible): * Source/WebKit/UIProcess/WebPageProxy.h: Canonical link: https://commits.webkit.org/280840@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 024291: Negative exponent exception for BigInt not thrown ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02429197cd90525288d0a2681640e4236c62d783 https://github.com/WebKit/WebKit/commit/02429197cd90525288d0a2681640e4236c62d783 Author: Yijia Huang Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: A JSTests/stress/dead-code-eliminiation-with-side-effect-node.js M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp M Source/JavaScriptCore/runtime/JSBigInt.h M Source/JavaScriptCore/runtime/JSCJSValue.h M Source/JavaScriptCore/runtime/JSCJSValueInlines.h Log Message: --- Negative exponent exception for BigInt not thrown in JIT compiler https://bugs.webkit.org/show_bug.cgi?id=275939 rdar://131051084 Reviewed by Yusuke Suzuki. Some DFG nodes can have side effects even if their results are not used by others. In that case, we shouldn't clear the NodeMustGenerate flags unless they are proven not having side effects. * JSTests/stress/dead-code-eliminiation-with-side-effect-node.js: Added. (assert): (let.iteration.1e3.opt): (i.assert.opt.opt): (i.assert.opt): * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter::executeEffects): * Source/JavaScriptCore/dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): * Source/JavaScriptCore/runtime/JSBigInt.h: * Source/JavaScriptCore/runtime/JSCJSValue.h: * Source/JavaScriptCore/runtime/JSCJSValueInlines.h: (JSC::JSValue::isZeroBigInt const): (JSC::JSValue::isNegativeBigInt const): Canonical link: https://commits.webkit.org/280841@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b6027f: Disable support for git submodules in some configu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6027f4124113e78624ed739e09cbb56c63a37a9 https://github.com/WebKit/WebKit/commit/b6027f4124113e78624ed739e09cbb56c63a37a9 Author: Russell Epstein Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M .submitproject Log Message: --- Disable support for git submodules in some configurations. rdar://131500339 Reviewed by Ryan Haddad. * .submitproject: Disable git submodules for consumers of this configuration. Canonical link: https://commits.webkit.org/280842@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cb9b05: Messages::GPUConnectionToWebProcess::CreateGraphic...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cb9b0517ea6e2e1b9772f0929b29f445f1a64248 https://github.com/WebKit/WebKit/commit/cb9b0517ea6e2e1b9772f0929b29f445f1a64248 Author: Gerald Squelart Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp Log Message: --- Messages::GPUConnectionToWebProcess::CreateGraphicsContextGL/ReleaseGraphicsContextGL should only be handled when UseGPUProcessForWebGLEnabled is true https://bugs.webkit.org/show_bug.cgi?id=276355 rdar://107941430 Reviewed by Dan Glastonbury. GPUProcessPreferencesForWebProcess::isWebGLEnabled is now dependant on UseGPUProcessForWebGLEnabled, so that in case that the GPU process is not to be used for WebGL, messages from the GPU process related to WebGL will simply be ignored. * Source/WebKit/UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::preferencesForGPUProcess const): Canonical link: https://commits.webkit.org/280843@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c7836: [WebKit] Pass full paths to generate-serializers.p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c78362876edce207c947b1c56de1a4a628b1023 https://github.com/WebKit/WebKit/commit/3c78362876edce207c947b1c56de1a4a628b1023 Author: Elliott Williams Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources.make M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/Makefile Log Message: --- [WebKit] Pass full paths to generate-serializers.py and support derived .serialization.in files https://bugs.webkit.org/show_bug.cgi?id=276461 rdar://131500106 Reviewed by Ryosuke Niwa. * Source/WebKit/CMakeLists.txt: Pass fully-qualified paths to serialization profiles. * Source/WebKit/DerivedSources.make: - Pass fully-qualified paths to serialization profiles. - As a drive-by fix, turn the generate-serializers.py recipe into a pattern rule so that Make only invokes it once instead of once per output file. * Source/WebKit/Scripts/generate-serializers.py: (main): Remove the "DIRECTORY" argument parsing logic. * Source/WebKit/Scripts/webkit/tests/Makefile: Canonical link: https://commits.webkit.org/280844@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79c138: Add an extension point for PlatformHave.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79c13893532268733225cca1ef9e68031688775d https://github.com/WebKit/WebKit/commit/79c13893532268733225cca1ef9e68031688775d Author: Tim Horton Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- Add an extension point for PlatformHave.h https://bugs.webkit.org/show_bug.cgi?id=276457 Reviewed by Aditya Keerthi. * Source/WTF/wtf/PlatformHave.h: The order of includes in Platform.h is such that PlatformHave comes before AdditionalFeatureDefines, so we need a custom extension point here. Canonical link: https://commits.webkit.org/280845@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e660d5: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e660d510f966a861848c3b2818afc17ef6001c63 https://github.com/WebKit/WebKit/commit/e660d510f966a861848c3b2818afc17ef6001c63 Author: Fujii Hironori Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/280846@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c22363: AXObjectCache::characterOffsetFromVisiblePosition ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c223637aad47dceef3291a95636ceb9fc10ee1ab https://github.com/WebKit/WebKit/commit/c223637aad47dceef3291a95636ceb9fc10ee1ab Author: Tyler Wilcock Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: A LayoutTests/accessibility/mac/role-img-selection-hang-expected.txt A LayoutTests/accessibility/mac/role-img-selection-hang.html M Source/WebCore/accessibility/AXObjectCache.cpp Log Message: --- AXObjectCache::characterOffsetFromVisiblePosition can iterate infinitely when moving through role="img" container https://bugs.webkit.org/show_bug.cgi?id=276464 rdar://problem/131502510 Reviewed by Ryosuke Niwa. Given this markup: X Y When we create a VisiblePosition from this Position: (Position (anchor node: #text 0x159003ec0 length=1 "Y") (offset: 0) (anchor type: offset in anchor)) We get its `canonicalPosition` in the VisiblePosition constructor, which computes: (Position (anchor node: DIV 0x159003c40) (offset: 0) (anchor type: before anchor)) This starts iteration for `nextVisuallyDistinctCandidate` back at the beginning of the div, repeating until we get back to the "Y" position, in turn computing the before-anchor-div position, repeating forever. This happens because the div is role="img", which was special cased to be `Element::canContainRangeEndPoint()` in: https://bugs.webkit.org/attachment.cgi?id=229259&action=prettypatch (Find on Page can get stuck in a loop when the search string occurs in an input in a fieldset). Making it `canContainRangeEndPoint` also makes it `editingIgnoresContent == true`, in turn making it `Position::isCandidate() == true`. I tried to solve the core editing bug in https://github.com/WebKit/WebKit/pull/30614, but my approach (removing this special role="img" logic in Element::canContainRangeEndPoint()) caused other undesirable effects (more details in https://github.com/WebKit/WebKit/pull/30614#issuecomment-2221064954), so some other fix is needed (tracked by https://bugs.webkit.org/show_bug.cgi?id=276460). For now, this commit works around this foundational bug by changing `AXObjectCache::characterOffsetFromVisiblePosition` to detect we've moved back to the start position, and breaking to prevent an infinite loop. * LayoutTests/accessibility/mac/role-img-selection-hang-expected.txt: Added. * LayoutTests/accessibility/mac/role-img-selection-hang.html: Added. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::characterOffsetFromVisiblePosition): Canonical link: https://commits.webkit.org/280847@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
