[webkit-changes] [WebKit/WebKit] 6e1c47: [view-transitions] view-transition-name should cau...

2024-04-22 Thread mattwoodrow
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e1c477fdf2bbdc8a92c50af9c3d8961e430b665
  
https://github.com/WebKit/WebKit/commit/6e1c477fdf2bbdc8a92c50af9c3d8961e430b665
  Author: Matt Woodrow 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/dom/ViewTransition.h
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderTableRow.cpp
M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  ---
  [view-transitions] view-transition-name should cause flattening of 3d 
transforms.
https://bugs.webkit.org/show_bug.cgi?id=272951


Reviewed by Tim Nguyen.

Adjuster::adjust should force the used value of transform-style to flat, if
a view-transition-name value is present, or the element is captured in a view
transition.

Adds RenderElement::requiresRenderingConsolidationForViewTransition() for this
state (which can't be used for Adjuster unfortunately, since the style isn't
yet set), and switch other callsites to use it (so that we also get a layer
and backdrop root for the same conditions).

RenderLayerBacking can no longer rely on querying the name from style (since
it might be removed or changed), so adds 
viewTransitionNewPseudoForCapturedElement
for looking up the pseudo element via the captured elements list.

* LayoutTests/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::viewTransitionNewPseudoForCapturedElement):
* Source/WebCore/dom/ViewTransition.h:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::requiresLayer const):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::capturedInViewTransition const):
(WebCore::RenderElement::requiresRenderingConsolidationForViewTransition const):
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::requiresLayer const):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::canCreateStackingContext):
(WebCore::RenderLayer::shouldBeCSSStackingContext const):
(WebCore::RenderLayer::computeCanBeBackdropRoot const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateTransform):
(WebCore::RenderLayerBacking::updateGeometry):
* Source/WebCore/rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::requiresLayer const):
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):

Canonical link: https://commits.webkit.org/277801@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3466e3: [Skia] Add initial support for color spaces

2024-04-22 Thread Pawel Lampe
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3466e3a573ebcaa89a49e3f0649627c1409435f9
  
https://github.com/WebKit/WebKit/commit/3466e3a573ebcaa89a49e3f0649627c1409435f9
  Author: Pawel Lampe 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/platform/SourcesSkia.txt
M Source/WebCore/platform/graphics/ColorConversion.cpp
M Source/WebCore/platform/graphics/DestinationColorSpace.cpp
M Source/WebCore/platform/graphics/DestinationColorSpace.h
M Source/WebCore/platform/graphics/PixelBufferConversion.cpp
M Source/WebCore/platform/graphics/PlatformColorSpace.h
M Source/WebCore/platform/graphics/ShareableBitmap.cpp
M Source/WebCore/platform/graphics/filters/FEFlood.cpp
M Source/WebCore/platform/graphics/filters/FEFlood.h
M Source/WebCore/platform/graphics/filters/FilterImage.cpp
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp
M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp
A Source/WebCore/platform/graphics/skia/ColorSpaceSkia.cpp
A Source/WebCore/platform/graphics/skia/ColorSpaceSkia.h
M Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h
M 
Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp
M 
Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp
M Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp
M Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp
M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp
M Source/WebCore/platform/image-decoders/skia/ImageBackingStoreSkia.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.cpp
M Source/WebKit/PlatformGTK.cmake
M Source/WebKit/PlatformWPE.cmake
M Source/WebKit/Shared/WebCoreArgumentCoders.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
A Source/WebKit/Shared/skia/CoreIPCSkColorSpace.h
A Source/WebKit/Shared/skia/CoreIPCSkColorSpace.serialization.in
M Source/WebKit/Shared/skia/WebCoreArgumentCodersSkia.cpp
M Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp
M Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp
M Tools/WebKitTestRunner/wpe/PlatformWebViewClientWPE.cpp
M Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp

  Log Message:
  ---
  [Skia] Add initial support for color spaces
https://bugs.webkit.org/show_bug.cgi?id=272453

Reviewed by Carlos Garcia Campos.

With this change, the colorspaces are now enabled in all the codepaths 
requiring them.
This change leaves some codepaths unimplemented - to be implemented in followup 
PRs.
All the SVG filters are working now as good as they worked with cairo.

* Source/WebCore/platform/SourcesSkia.txt:
* Source/WebCore/platform/graphics/ColorConversion.cpp:
(WebCore::convertAndResolveColorComponents):
* Source/WebCore/platform/graphics/DestinationColorSpace.cpp:
(WebCore::DestinationColorSpace::SRGB):
(WebCore::DestinationColorSpace::LinearSRGB):
(WebCore::DestinationColorSpace::DisplayP3):
(WebCore::operator==):
(WebCore::DestinationColorSpace::asRGB const):
* Source/WebCore/platform/graphics/DestinationColorSpace.h:
(WebCore::DestinationColorSpace::platformColorSpace const):
* Source/WebCore/platform/graphics/PixelBufferConversion.cpp:
(WebCore::convertImagePixelsSkia):
(WebCore::convertImagePixels):
* Source/WebCore/platform/graphics/PlatformColorSpace.h:
* Source/WebCore/platform/graphics/ShareableBitmap.cpp:
(WebCore::ShareableBitmapConfiguration::ShareableBitmapConfiguration):
* Source/WebCore/platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::create):
* Source/WebCore/platform/graphics/filters/FEFlood.h:
* Source/WebCore/platform/graphics/filters/FilterImage.cpp:
(WebCore::FilterImage::requiresPixelBufferColorSpaceConversion const):
(WebCore::FilterImage::transformToColorSpace):
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp:
(WebCore::ImageGStreamer::ImageGStreamer):
* Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:
(Nicosia::UnacceleratedBuffer::UnacceleratedBuffer):
* Source/WebCore/platform/graphics/skia/ColorSpaceSkia.cpp: Copied from 
Source/WebCore/platform/image-decoders/skia/ImageBackingStoreSkia.cpp.
(WebCore::sRGBColorSpaceRef):
(WebCore::linearSRGBColorSpaceRef):
(WebCore::displayP3ColorSpaceRef):
* Source/WebCore/platform/graphics/skia/ColorSpaceSkia.h: Copied from 
Source/WebCore/platform/image-decoders/skia/ImageBackingStoreSkia.cpp.
* Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp:
(WebCore::GraphicsContextGL::createNativeImageFromPixelBuffer):
* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::GraphicsContextSkia):
(WebCore::GraphicsContextSk

[webkit-changes] [WebKit/WebKit] 5a84a9: Move old SVG Resource code to legacy

2024-04-22 Thread Rob Buis
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a84a91909d9c592060440c75bf43ec7bbfdd13f
  
https://github.com/WebKit/WebKit/commit/5a84a91909d9c592060440c75bf43ec7bbfdd13f
  Author: Rob Buis 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
R Source/WebCore/rendering/svg/SVGResources.cpp
R Source/WebCore/rendering/svg/SVGResources.h
R Source/WebCore/rendering/svg/SVGResourcesCache.cpp
R Source/WebCore/rendering/svg/SVGResourcesCache.h
R Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp
R Source/WebCore/rendering/svg/SVGResourcesCycleSolver.h
A Source/WebCore/rendering/svg/legacy/SVGResources.cpp
A Source/WebCore/rendering/svg/legacy/SVGResources.h
A Source/WebCore/rendering/svg/legacy/SVGResourcesCache.cpp
A Source/WebCore/rendering/svg/legacy/SVGResourcesCache.h
A Source/WebCore/rendering/svg/legacy/SVGResourcesCycleSolver.cpp
A Source/WebCore/rendering/svg/legacy/SVGResourcesCycleSolver.h

  Log Message:
  ---
  Move old SVG Resource code to legacy
https://bugs.webkit.org/show_bug.cgi?id=272989

Reviewed by Nikolas Zimmermann.

Move old SVG Resource code to legacy.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/rendering/svg/legacy/SVGResources.cpp: Renamed from 
Source/WebCore/rendering/svg/SVGResources.cpp.
(WebCore::SVGResources::SVGResources):
(WebCore::tagSet):
(WebCore::clipperFilterMaskerTags):
(WebCore::markerTags):
(WebCore::fillAndStrokeTags):
(WebCore::chainableResourceTags):
(WebCore::targetReferenceFromResource):
(WebCore::isChainableResource):
(WebCore::paintingResourceFromSVGPaint):
(WebCore::SVGResources::buildCachedResources):
(WebCore::SVGResources::layoutDifferentRootIfNeeded):
(WebCore::SVGResources::markerReverseStart const):
(WebCore::SVGResources::removeClientFromCache const):
(WebCore::SVGResources::resourceDestroyed):
(WebCore::SVGResources::buildSetOfResources):
(WebCore::SVGResources::setClipper):
(WebCore::SVGResources::resetClipper):
(WebCore::SVGResources::setFilter):
(WebCore::SVGResources::resetFilter):
(WebCore::SVGResources::setMarkerStart):
(WebCore::SVGResources::resetMarkerStart):
(WebCore::SVGResources::setMarkerMid):
(WebCore::SVGResources::resetMarkerMid):
(WebCore::SVGResources::setMarkerEnd):
(WebCore::SVGResources::resetMarkerEnd):
(WebCore::SVGResources::setMasker):
(WebCore::SVGResources::resetMasker):
(WebCore::SVGResources::setFill):
(WebCore::SVGResources::resetFill):
(WebCore::SVGResources::setStroke):
(WebCore::SVGResources::resetStroke):
(WebCore::SVGResources::setLinkedResource):
(WebCore::SVGResources::resetLinkedResource):
(WebCore::SVGResources::dump):
* Source/WebCore/rendering/svg/legacy/SVGResources.h: Renamed from 
Source/WebCore/rendering/svg/SVGResources.h.
(WebCore::SVGResources::clipper const):
(WebCore::SVGResources::masker const):
(WebCore::SVGResources::filter const):
(WebCore::SVGResources::markerStart const):
(WebCore::SVGResources::markerMid const):
(WebCore::SVGResources::markerEnd const):
(WebCore::SVGResources::fill const):
(WebCore::SVGResources::stroke const):
(WebCore::SVGResources::linkedResource const):
(WebCore::SVGResources::isEmpty const):
* Source/WebCore/rendering/svg/legacy/SVGResourcesCache.cpp: Renamed from 
Source/WebCore/rendering/svg/SVGResourcesCache.cpp.
(WebCore::SVGResourcesCache::addResourcesFromRenderer):
(WebCore::SVGResourcesCache::removeResourcesFromRenderer):
(WebCore::resourcesCacheFromRenderer):
(WebCore::SVGResourcesCache::cachedResourcesForRenderer):
(WebCore::hasPaintResourceRequiringRemovalOnClientLayoutChange):
(WebCore::hasResourcesRequiringRemovalOnClientLayoutChange):
(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::rendererCanHaveResources):
(WebCore::SVGResourcesCache::clientStyleChanged):
(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):
(WebCore::SVGResourcesCache::clientDestroyed):
(WebCore::SVGResourcesCache::resourceDestroyed):
(WebCore::SVGResourcesCache::SetStyleForScope::SetStyleForScope):
(WebCore::SVGResourcesCache::SetStyleForScope::~SetStyleForScope):
(WebCore::SVGResourcesCache::SetStyleForScope::setStyle):
* Source/WebCore/rendering/svg/legacy/SVGResourcesCache.h: Renamed from 
Source/WebCore/rendering/svg/SVGResourcesCache.h.
* Source/WebCore/rendering/svg/legacy/SVGResourcesCycleSolver.cpp: Renamed from 
Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp.
(WebCore::SVGResourcesCycleSolver::resourceContainsCycles):
(WebCore::SVGResourcesCycleSolver::resolveCycles):
(WebCore::SVGResourcesCycleSolver::breakCycle):
* Source/WebCore/rendering/svg/legacy/SVGResourcesCycleSolver.h: Renamed from 
Source/WebCore/rendering/svg/SVGResourcesCycleSolver.h.
(WebCore::SVGResourcesCycleSolver::SVGResourcesCycleSolver):

Canonical link: https://commits.webkit.org/277803@main

[webkit-changes] [WebKit/WebKit] 2e707d: Cherry-pick 277535@main (41f9311ef80a). https://bu...

2024-04-22 Thread Jani Hautakangas
  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e707dae42189f2512495d72797481981c5c212f
  
https://github.com/WebKit/WebKit/commit/2e707dae42189f2512495d72797481981c5c212f
  Author: Jani Hautakangas 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp

  Log Message:
  ---
  Cherry-pick 277535@main (41f9311ef80a). 
https://bugs.webkit.org/show_bug.cgi?id=272648

[WebDriver][GTK][WPE] Inspector server leaves dangling automation 
connections
https://bugs.webkit.org/show_bug.cgi?id=272648

Reviewed by Carlos Garcia Campos.

When connecting WebDriver to existing remote inspector server then inspector
server doesn't remove closed connections from automation connection tracking
map.

* Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::close):

Canonical link: https://commits.webkit.org/277535@main

Canonical link: https://commits.webkit.org/274313.148@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 9e5519: [GStreamer] Deadlock in webKitWebSrcCreate when ha...

2024-04-22 Thread Philippe Normand
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e5519436f6b4b766fe205d2adacf6668033e9bb
  
https://github.com/WebKit/WebKit/commit/9e5519436f6b4b766fe205d2adacf6668033e9bb
  Author: Philippe Normand 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Deadlock in webKitWebSrcCreate when handling non-flushing seeks
https://bugs.webkit.org/show_bug.cgi?id=272912

Reviewed by Xabier Rodriguez-Calvar.

When handling non-flushing seeks the GStreamer basesrc base class will pause 
the pad task instead of
sending a flush-start event, so in that situation the "unlock" vmethod is not 
called. In order to
prevent deadlocks, unlock the streaming thread before letting basesrc handle 
the non-flushing seek
event.

* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_class_init):
(webKitWebSrcEvent):

Canonical link: https://commits.webkit.org/277804@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3c60c9: Resync web-platform-tests/geolocation-API from ups...

2024-04-22 Thread Marcos Cáceres
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c60c9c636d30df6aeaf438434ba45c1afb28c8d
  
https://github.com/WebKit/WebKit/commit/3c60c9c636d30df6aeaf438434ba45c1afb28c8d
  Author: Marcos Caceres 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/clearWatch_TypeError-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute.https.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_TypeError-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/watchPosition_TypeError-expected.txt
A 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt
A 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt
A 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt
A 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt
A 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt
A 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt
A 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute.https.sub-expected.txt
A 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt
A 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt
A 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt
A 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt
A 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt
A 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt

  Log Message:
  ---
  Resync web-platform-tests/geolocation-API from upstream
https://bugs.webkit.org/show_bug.cgi?id=272764
rdar://126562783

Reviewed by Tim Nguyen.

Resync'ed tests from upstream.
Upstream commit: 
https://github.com/web-platform-tests/wpt/commit/911ae4d05e14feedfe20fb0e83597ad485b77d10

* 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/clearWatch_TypeError-expected.txt:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub.html:
* 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub.html:
* 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute.https.sub.html:
* 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub.html:
* 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions

[webkit-changes] [WebKit/WebKit] 583bc0: [GTK][Skia] Limit output file format to PDF

2024-04-22 Thread Georges Basile Stavracas Neto
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 583bc07f5974d41691aa6d0b1b4eda39a7c8b734
  
https://github.com/WebKit/WebKit/commit/583bc07f5974d41691aa6d0b1b4eda39a7c8b734
  Author: Georges Basile Stavracas Neto 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp

  Log Message:
  ---
  [GTK][Skia] Limit output file format to PDF
https://bugs.webkit.org/show_bug.cgi?id=272913

Reviewed by Michael Catanzaro and Carlos Garcia Campos.

Skia only supports printing to PDF files, but the Print portal assumes
that apps can print to PDF, PS, and SVG formats. If the user selects
PS or SVG through the Print portal dialog, and WebKit is using Skia,
we hit an assertion failure.

The next release of XDG Desktop Portal has new API [1] in the Print
portal made specifically to aid this, we can use it for Skia builds
and if the portal version matches.

[1] https://github.com/flatpak/xdg-desktop-portal/pull/1322/

* Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationPreparePrint):

Canonical link: https://commits.webkit.org/277806@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 492603: [css-motion] update WPT import of css/motion/anima...

2024-04-22 Thread Antoine Quint
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 492603712301eabf0c95bcd83eb4d0db0143a82a
  
https://github.com/WebKit/WebKit/commit/492603712301eabf0c95bcd83eb4d0db0143a82a
  Author: Antoine Quint 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-007-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-007.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-008-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-008.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-rotate-interpolation-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-rotate-interpolation-math-functions-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-rotate-interpolation-math-functions.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-rotate-interpolation.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/ray-angle-interpolation-math-functions-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/ray-angle-interpolation-math-functions.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/reftests/offset-path-path-interpolation-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/reftests/offset-path-with-transforms-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/reftests/w3c-import.log
M 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/w3c-import.log

  Log Message:
  ---
  [css-motion] update WPT import of css/motion/animation tests
https://bugs.webkit.org/show_bug.cgi?id=273054
rdar://126848099

Reviewed by Anne van Kesteren.

This matches the bfe3a92f9d revision of the WPT repository.

* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-007-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-007.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-008-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-008.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-rotate-interpolation-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-rotate-interpolation-math-functions-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-rotate-interpolation-math-functions.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-rotate-interpolation.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/ray-angle-interpolation-math-functions-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/ray-angle-interpolation-math-functions.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/reftests/offset-path-path-interpolation-ref.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/reftests/offset-path-with-transforms-ref.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/reftests/w3c-import.log:
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/w3c-import.log:

Canonical link: https://commits.webkit.org/277807@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 934cc6: [GTK][Skia] Add support for system font/ui

2024-04-22 Thread Carlos Garcia Campos
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 934cc6adde33abccd4a20f93380708d6ee1260aa
  
https://github.com/WebKit/WebKit/commit/934cc6adde33abccd4a20f93380708d6ee1260aa
  Author: Carlos Garcia Campos 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp

  Log Message:
  ---
  [GTK][Skia] Add support for system font/ui
https://bugs.webkit.org/show_bug.cgi?id=272971

Reviewed by Adrian Perez de Castro.

* Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::getFamilyNameStringFromFamily):

Canonical link: https://commits.webkit.org/277808@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 5d0cca: Permission policy console message still says "Feat...

2024-04-22 Thread Marcos Cáceres
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d0cca10f8f475b751c1eb36f1f1648dbf766d67
  
https://github.com/WebKit/WebKit/commit/5d0cca10f8f475b751c1eb36f1f1648dbf766d67
  Author: Marcos Caceres 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/fullscreen/full-screen-enabled-expected.txt
M LayoutTests/fullscreen/full-screen-enabled-prefixed-expected.txt
M LayoutTests/fullscreen/full-screen-iframe-not-allowed-expected.txt
M 
LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt
M LayoutTests/fullscreen/full-screen-restrictions-expected.txt
M LayoutTests/http/tests/fullscreen/fullscreen-feature-policy-expected.txt
M LayoutTests/http/tests/gamepad/gamepad-allow-attribute.https-expected.txt
M 
LayoutTests/http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt
M 
LayoutTests/http/tests/media/media-stream/get-user-media-in-embed-element-expected.txt
M 
LayoutTests/http/tests/paymentrequest/payment-allow-attribute.https-expected.txt
M 
LayoutTests/http/tests/security/sandboxed-iframe-geolocation-getCurrentPosition-expected.txt
M 
LayoutTests/http/tests/security/sandboxed-iframe-geolocation-watchPosition-expected.txt
M 
LayoutTests/http/tests/ssl/media-stream/get-user-media-different-host-expected.txt
M LayoutTests/http/tests/ssl/media-stream/get-user-media-nested-expected.txt
M LayoutTests/http/tests/webrtc/enumerateDevicesInFrames-expected.txt
M 
LayoutTests/http/tests/webshare/webshare-allow-attribute-canShare.https-expected.txt
M 
LayoutTests/http/tests/webshare/webshare-allow-attribute-share.https-expected.txt
M 
LayoutTests/http/tests/webxr/webxr-third-party-iframe-issessionsupported-denied-by-insufficient-feature-policy-expected.txt
M 
LayoutTests/http/tests/webxr/webxr-third-party-iframe-makexrcompatible-denied-by-insufficient-feature-policy-expected.txt
M 
LayoutTests/http/tests/webxr/webxr-third-party-iframe-requestsession-denied-by-insufficient-feature-policy-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-allow-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-feature-policy-none.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-allowed-by-permissions-policy.https.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-default-permissions-policy.https.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/permissions-policy/payment-disabled-by-permissions-policy.https.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/screen-wake-lock/wakelock-enabled-by-feature-policy-attribute-redirect-on-load.https.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy-cross-origin.https.sub-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-feature-policy-none.https-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/screen-wake-lock/wakelock-enabled-by-feature-policy-attribute-redirect-on-load.https.sub-expected.txt
M Source/WebCore/html/PermissionsPolicy.cpp

  Log Message:
  ---
  Permission policy console message still says "Feature policy"
https://bugs.webkit.org/show_bug.cgi?id=272931
rdar://126715054

Reviewed by Matthew Finkel.

Updated the console message to say "Permission policy" instead of "Feature 
policy".

* LayoutTests/fullscreen/full-screen-enabled-expected.txt:
* LayoutTests/fullscreen/full-screen-enabled-prefixed-expected.txt:
* LayoutTests/fullscreen/full-screen-iframe-not-allowed-expected.txt:
* 
LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt:
* LayoutTests/fullscreen/full-screen-restrictions-expected.txt:
* LayoutTests/http/tests/fullscreen/fullscreen-feature-policy-expected.txt:
* LayoutTests/http/tests/gamepad/gamepad-allow-attribute.https-expected.txt:
* 
LayoutTests/http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt:
* 
LayoutTests/http/tests/media/media-stream/get-user-media-in-embed-element-expected.txt:
* 
LayoutTests/http/tests/paymentrequest/payment-allow-attribute.https-expected.txt:
* 
LayoutTests/http/tests/security/sandboxed-iframe-geolocation-getCurrentPosition-expected.txt:
* 
LayoutTests/http/tests/security/sandboxed-iframe-geolocation-watchPosition-expected.txt:
* 
LayoutTests/http/tests/ssl/media-stream/get-us

[webkit-changes] [WebKit/WebKit] 2ea387: Cherry-pick 277470@main (907d986d108c). https://bu...

2024-04-22 Thread Jani Hautakangas
  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ea3878b16701a814ffba16e56bde92a7cc3cfe6
  
https://github.com/WebKit/WebKit/commit/2ea3878b16701a814ffba16e56bde92a7cc3cfe6
  Author: Przemyslaw Gorszkowski 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/userscripts/window-onerror-for-isolated-world-1-expected.txt
M LayoutTests/userscripts/window-onerror-for-isolated-world-2-expected.txt
M LayoutTests/userscripts/window-onerror-for-isolated-world-3-expected.txt
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/page/UserScript.cpp
M Source/WebCore/page/UserScript.h
A Source/WebCore/page/UserStyleSheet.cpp
M Source/WebCore/page/UserStyleSheet.h
M Source/WebCore/page/WorkerNavigator.cpp
M Source/WebKit/UIProcess/API/APIUserScript.cpp
M Source/WebKit/UIProcess/API/APIUserScript.h
M Source/WebKit/UIProcess/API/APIUserStyleSheet.cpp
M Source/WebKit/UIProcess/API/APIUserStyleSheet.h
M Source/WebKit/UIProcess/API/C/WKUserScriptRef.cpp
M Source/WebKit/UIProcess/API/Cocoa/WKUserScript.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKUserStyleSheet.mm

  Log Message:
  ---
  Cherry-pick 277470@main (907d986d108c). 
https://bugs.webkit.org/show_bug.cgi?id=272152

[GTK][WPE] missing URI for injected user scripts and style sheets
https://bugs.webkit.org/show_bug.cgi?id=272152

Reviewed by Adrian Perez de Castro.

User scripts/style sheets without the URI are not visible in WebInspector.

With this change the URI of injected user scripts/style sheets are 
generated as:
user-script:incremented_identifier
user-style:incremented_identifier

* LayoutTests/userscripts/window-onerror-for-isolated-world-1-expected.txt:
* LayoutTests/userscripts/window-onerror-for-isolated-world-2-expected.txt:
* LayoutTests/userscripts/window-onerror-for-isolated-world-3-expected.txt:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/UserScript.cpp: Copied from 
Source/WebKit/UIProcess/API/APIUserScript.cpp.
(WebCore::generateUniqueURL):
(WebCore::UserScript::UserScript):
* Source/WebCore/page/UserScript.h:
(WebCore::UserScript::UserScript): Deleted.
* Source/WebCore/page/UserStyleSheet.cpp: Copied from 
Source/WebKit/UIProcess/API/APIUserScript.cpp.
(WebCore::generateUniqueURL):
(WebCore::UserStyleSheet::UserStyleSheet):
* Source/WebCore/page/UserStyleSheet.h:
* Source/WebCore/page/WorkerNavigator.cpp:
* Source/WebKit/UIProcess/API/APIUserScript.cpp:
(API::UserScript::generateUniqueURL): Deleted.
* Source/WebKit/UIProcess/API/APIUserScript.h:
* Source/WebKit/UIProcess/API/APIUserStyleSheet.cpp:
(API::UserStyleSheet::generateUniqueURL): Deleted.
* Source/WebKit/UIProcess/API/APIUserStyleSheet.h:
* Source/WebKit/UIProcess/API/C/WKUserScriptRef.cpp:
(WKUserScriptCreateWithSource):

Canonical link: https://commits.webkit.org/277470@main

Canonical link: https://commits.webkit.org/274313.149@webkitglib/2.44


  Commit: 93bb4b2f95c7d28374f31d6c8d6900b0707ff51c
  
https://github.com/WebKit/WebKit/commit/93bb4b2f95c7d28374f31d6c8d6900b0707ff51c
  Author: Jani Hautakangas 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp

  Log Message:
  ---
  Cherry-pick 277725@main (d9188161eb32). 
https://bugs.webkit.org/show_bug.cgi?id=272643

[WebDriver][WPE] Scale mouse location according to device scale factor
https://bugs.webkit.org/show_bug.cgi?id=272643

Reviewed by Carlos Garcia Campos.

WebDriver operates in normal coordinates (not scaled) and thus location
in mouse simulation requests is not scaled according to device scale factor.

* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp:
(WebKit::deviceScaleLocationInView):
(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
(WebKit::WebAutomationSession::platformSimulateWheelInteraction):

Canonical link: https://commits.webkit.org/277725@main

Canonical link: https://commits.webkit.org/274313.150@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/2e707dae4218...93bb4b2f95c7

To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 2fa2e8: Add more smart pointers to CheckboxInputType.cpp

2024-04-22 Thread Rob Buis
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2fa2e804cc1bd7c1528e35b071c5943ac62094eb
  
https://github.com/WebKit/WebKit/commit/2fa2e804cc1bd7c1528e35b071c5943ac62094eb
  Author: Rob Buis 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/html/CheckboxInputType.cpp

  Log Message:
  ---
  Add more smart pointers to CheckboxInputType.cpp
https://bugs.webkit.org/show_bug.cgi?id=272897

Reviewed by Chris Dumez.

Add more smart pointers to CheckboxInputType.cpp.

* Source/WebCore/html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::handleMouseDownEvent):
(WebCore::CheckboxInputType::handleMouseMoveEvent):
(WebCore::CheckboxInputType::handleTouchEvent):
(WebCore::CheckboxInputType::willDispatchClick):
(WebCore::CheckboxInputType::didDispatchClick):
(WebCore::CheckboxInputType::disabledStateChanged):

Canonical link: https://commits.webkit.org/277810@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 7a4c98: [IFC] Do not invalidate LineLayout on style change...

2024-04-22 Thread Alan Baradlay
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a4c98d36d1c6ae6012d6e9bf91d520710d5d529
  
https://github.com/WebKit/WebKit/commit/7a4c98d36d1c6ae6012d6e9bf91d520710d5d529
  Author: Alan Baradlay 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/fast/repaint/box-shadow-top-left-repaint-expected.txt
M LayoutTests/fast/repaint/focus-ring-repaint-expected.txt
M LayoutTests/fast/repaint/leftover-after-shrinking-content-expected.txt
M LayoutTests/fast/repaint/overlapping-lines-with-ink-overflow-expected.txt
M LayoutTests/platform/ios/editing/style/table-selection-expected.txt
M LayoutTests/platform/mac/editing/style/table-selection-expected.txt
M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h
M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  ---
  [IFC] Do not invalidate LineLayout on style change unless it is completely 
stale
https://bugs.webkit.org/show_bug.cgi?id=272570

Reviewed by Antti Koivisto.

Instead of deleting the LineLayout object on style change, let's just 
invalidate the (inline item) cache when needed.

* LayoutTests/fast/repaint/focus-ring-repaint-expected.txt:
* LayoutTests/fast/repaint/leftover-after-shrinking-content-expected.txt:
* LayoutTests/fast/repaint/overlapping-lines-with-ink-overflow-expected.txt:
* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h:
* 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::InlineInvalidation::styleWillChange):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::styleDidChange):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):

Canonical link: https://commits.webkit.org/277811@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3aa8e1: Use ASCIILiteral more

2024-04-22 Thread Chris Dumez
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3aa8e1d0177332635b2f93ebef41748ee350ee66
  
https://github.com/WebKit/WebKit/commit/3aa8e1d0177332635b2f93ebef41748ee350ee66
  Author: Chris Dumez 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WTF/wtf/Logger.h
M Source/WTF/wtf/text/TextStream.h
M Source/WebCore/platform/xr/openxr/OpenXRInstance.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/svg/SVGLengthValue.cpp
M Source/WebCore/svg/SVGTransformValue.h
M Source/WebCore/testing/Internals.cpp
M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
M Source/WebGPU/WebGPU/RenderPipeline.mm
M Source/WebGPU/WebGPU/Texture.h
M Source/WebGPU/WebGPU/Texture.mm
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/Notifications/WebPushDaemonConnection.h
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerInterface.h
M Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.h
M Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
M Source/WebKit/Platform/IPC/Connection.cpp
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/Platform/IPC/MessageArgumentDescriptions.h
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
M Source/WebKit/Scripts/webkit/tests/MessageNames.cpp
M Source/WebKit/Scripts/webkit/tests/MessageNames.h
M 
Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessageReceiver.cpp
M Source/WebKit/Scripts/webkit/tests/TestWithEnabledIfMessageReceiver.cpp
M Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessageReceiver.cpp
M Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessageReceiver.cpp
M 
Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp
M Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessageReceiver.cpp
M 
Source/WebKit/Scripts/webkit/tests/TestWithStreamBatchedMessageReceiver.cpp
M Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessageReceiver.cpp
M Source/WebKit/Scripts/webkit/tests/TestWithStreamMessageReceiver.cpp
M 
Source/WebKit/Scripts/webkit/tests/TestWithStreamServerConnectionHandleMessageReceiver.cpp
M Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessageReceiver.cpp
M 
Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp
M 
Source/WebKit/Scripts/webkit/tests/TestWithoutUsingIPCConnectionMessageReceiver.cpp
M 
Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp
M 
Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.h
M Source/WebKit/Shared/AuxiliaryProcess.cpp
M Source/WebKit/Shared/Cocoa/XPCEndpoint.h
M Source/WebKit/Shared/ProcessTerminationReason.cpp
M Source/WebKit/Shared/ProcessTerminationReason.h
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
M Source/WebKit/Shared/WebPushDaemonConstants.h
M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
M Source/WebKit/Shared/mac/MediaFormatReader/MediaTrackReader.cpp
M Source/WebKit/Shared/mac/MediaFormatReader/MediaTrackReader.h
M Source/WebKit/Shared/mac/WebMemorySampler.mac.mm
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
M Source/WebKit/UIProcess/Cocoa/MediaPermissionUtilities.mm
M 
Source/WebKit/UIProcess/Cocoa/SOAuthorization/NavigationSOAuthorizationSession.mm
M 
Source/WebKit/UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.mm
M 
Source/WebKit/UIProcess/Cocoa/SOAuthorization/RedirectSOAuthorizationSession.mm
M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.h
M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm
M 
Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm
M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
M Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
M Source/WebKit/UIProcess/SuspendedPageProxy.cpp
M Source/WebKit/UIProcess/ViewGestureController.cpp
M Source/WebKit/UIProcess/ViewGestureController.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebProcess

[webkit-changes] [WebKit/WebKit] 3584ed: Change contributor email for Justin Michaud

2024-04-22 Thread Justin Michaud
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3584ed8d51465899cae685f0019b44c42a379e14
  
https://github.com/WebKit/WebKit/commit/3584ed8d51465899cae685f0019b44c42a379e14
  Author: Justin Michaud 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Change contributor email for Justin Michaud
https://bugs.webkit.org/show_bug.cgi?id=273064

Reviewed by Keith Miller.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/277813@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 444ddc: Webpage crashes when switching from PIP to in-window

2024-04-22 Thread Dana Estra
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 444ddcb41cbb0f3c0bee6810393551b8d35a610a
  
https://github.com/WebKit/WebKit/commit/444ddcb41cbb0f3c0bee6810393551b8d35a610a
  Author: Dana Estra 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/platform/mac/VideoPresentationInterfaceMac.mm

  Log Message:
  ---
  Webpage crashes when switching from PIP to in-window
https://bugs.webkit.org/show_bug.cgi?id=272943
rdar://126489417

Reviewed by Jer Noble.

When the video goes into PIP, the mode bitfield belonging to 
VideoPresentationInterfaceMac
Has its PIP bit set to 1. Then, when switching from PIP to in-window mode, the 
in-window
Bit is set to 1 before the PIP bit is cleared. During this time when both bits 
are turned
On, the interface attempts to switch to a fullscreen mode that does not exist. 
To fix this,
In VideoPresentationInterfaceMac::setMode and 
VideoPresentationInterfaceMac::clearMode we should
Check if any two bits are both true where one of them is the PIP bit. If this 
is the case,
Do not attempt to change the fullscreen mode and wait for the next instance of 
one of these
Functions being called.

* Source/WebCore/platform/mac/VideoPresentationInterfaceMac.mm:
(WebCore::VideoPresentationInterfaceMac::setMode):
(WebCore::VideoPresentationInterfaceMac::clearMode):

Canonical link: https://commits.webkit.org/277814@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] f04938: [IFC][Invalidation] Decouple inline formatting roo...

2024-04-22 Thread Alan Baradlay
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f049381ecbb039f64807cde91ca5ab06bc25009b
  
https://github.com/WebKit/WebKit/commit/f049381ecbb039f64807cde91ca5ab06bc25009b
  Author: Alan Baradlay 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp
M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
M Source/WebCore/rendering/RenderButton.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderMenuList.cpp

  Log Message:
  ---
  [IFC][Invalidation] Decouple inline formatting root and inline-level box 
invalidation
https://bugs.webkit.org/show_bug.cgi?id=273020

Reviewed by Antti Koivisto.

Add support for fine-grain invalidation when style changes depending on whether 
the current box is the root
of an inline formatting context or participates in inline layout (could be both 
e.g. inline-block).

e.g. unicode-bidi should be checked on both root and inline-box but going from 
inflow to out-of-flow should
only invalidate inline item caching when the box participates in inline layout 
(i.e. not when root's position value changes)

* 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::InlineInvalidation::rootStyleWillChange):
(WebCore::Layout::InlineInvalidation::styleWillChange):
* 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.h:
(WebCore::Layout::InlineInvalidation::needsPartialLayoutOnly):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::rootStyleWillChange):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
* Source/WebCore/rendering/RenderButton.cpp:
(WebCore::RenderButton::setInnerRenderer):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
* Source/WebCore/rendering/RenderMenuList.cpp:
(WebCore::if):

Canonical link: https://commits.webkit.org/277815@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 6cdec3: Change install location of WebKit process extensions

2024-04-22 Thread Per Arne Vollan
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6cdec3f17c421a043432eddb0f7fc525614c163e
  
https://github.com/WebKit/WebKit/commit/6cdec3f17c421a043432eddb0f7fc525614c163e
  Author: Per Arne Vollan 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebKit/Configurations/BaseExtension.xcconfig
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Change install location of WebKit process extensions
https://bugs.webkit.org/show_bug.cgi?id=268946
rdar://126613034

Reviewed by Jonathan Bedard.

This was previously landed in , but 
later reverted
due to incompatibilities with some iOS versions. This patch addresses this 
issue by
exempting an OS version from this change.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

* Source/WebKit/Configurations/BaseExtension.xcconfig:

Canonical link: https://commits.webkit.org/277816@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 936e94: [IFC][Cleanup] rebuildInlineItemListIfNeeded shoul...

2024-04-22 Thread Alan Baradlay
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 936e94b720191552815074cc6ecc5472bbaf097b
  
https://github.com/WebKit/WebKit/commit/936e94b720191552815074cc6ecc5472bbaf097b
  Author: Alan Baradlay 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  ---
  [IFC][Cleanup] rebuildInlineItemListIfNeeded should clear 
maximum-intrinsicwidth-line-content cache
https://bugs.webkit.org/show_bug.cgi?id=273022

Reviewed by Antti Koivisto.

...and some small scale drive-by cleanups.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layout):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::rebuildInlineItemListIfNeeded):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.h:
(WebCore::Layout::InlineInvalidation::mayOnlyNeedPartialLayout):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):

Canonical link: https://commits.webkit.org/277817@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] f38527: Versioning.

2024-04-22 Thread Commit Queue
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f38527dba5ff0fb12881e972733e2b88eed0b2c6
  
https://github.com/WebKit/WebKit/commit/f38527dba5ff0fb12881e972733e2b88eed0b2c6
  Author: Dan Robson 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7619.1.11

Canonical link: https://commits.webkit.org/277818@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 383a96: [ews] [GTK][WPE] Remove DerivedSources directories...

2024-04-22 Thread Diego Pino
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 383a968afba25dc67a10d75ee17f95e7ddeb5e1c
  
https://github.com/WebKit/WebKit/commit/383a968afba25dc67a10d75ee17f95e7ddeb5e1c
  Author: Diego Pino Garcia 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
M Tools/Scripts/clean-webkit

  Log Message:
  ---
  [ews] [GTK][WPE] Remove DerivedSources directories before 'compile-webkit' 
step
https://bugs.webkit.org/show_bug.cgi?id=267176

Reviewed by Jonathan Bedard and Carlos Alberto Lopez Perez.

This will avoid leftover files from previous builds may break the build
(only for WebKitGTK and WPE EWS build bots).

* Tools/CISupport/ews-build/factories.py:
(BuildFactory.__init__):
* Tools/CISupport/ews-build/steps.py:
(CleanDerivedSources):
(CleanDerivedSources.__init__):
(CleanDerivedSources.run):
* Tools/Scripts/clean-webkit:
(removeFiles):
(removeDerivedSources):
(main):

Canonical link: https://commits.webkit.org/277819@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 65d8fc: [IFC][Invalidation] Let's rebuild inline item list...

2024-04-22 Thread Alan Baradlay
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65d8fc47b72417a2c3a248e3fab8c4cfc887d265
  
https://github.com/WebKit/WebKit/commit/65d8fc47b72417a2c3a248e3fab8c4cfc887d265
  Author: Alan Baradlay 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h
M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp
M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  ---
  [IFC][Invalidation] Let's rebuild inline item list only once per partial 
layout
https://bugs.webkit.org/show_bug.cgi?id=273027

Reviewed by Antti Koivisto.

Let's introduce a dirty bit on inline item list so that when layout is preceded 
by
min/max computation, we don't run a second, redundant build on it.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layout):
(WebCore::Layout::InlineFormattingContext::minimumMaximumContentSize):
(WebCore::Layout::InlineFormattingContext::minimumContentSize):
(WebCore::Layout::InlineFormattingContext::maximumContentSize):
(WebCore::Layout::InlineFormattingContext::rebuildInlineItemListIfNeeded):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h:
(WebCore::Layout::InlineDamage::isInlineItemListDirty const):
(WebCore::Layout::InlineDamage::setInlineItemListClean):
(WebCore::Layout::InlineDamage::setInlineItemListDirty):
* 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::InlineInvalidation::rootStyleWillChange):
(WebCore::Layout::InlineInvalidation::styleWillChange):
(WebCore::Layout::InlineInvalidation::textInserted):
(WebCore::Layout::InlineInvalidation::textWillBeRemoved):
(WebCore::Layout::InlineInvalidation::inlineLevelBoxInserted):
(WebCore::Layout::InlineInvalidation::inlineLevelBoxWillBeRemoved):
* 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):

Canonical link: https://commits.webkit.org/277820@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 9b1d46: [view-transitions] https://simple-set-demos.glitch...

2024-04-22 Thread Antoine Quint
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b1d46ac8a7f149de038576205e6fbe8836b5670
  
https://github.com/WebKit/WebKit/commit/9b1d46ac8a7f149de038576205e6fbe8836b5670
  Author: Antoine Quint 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-easing/linear-timing-functions-syntax.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-easing/linear-timing-functions-syntax.tentative.html
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

  Log Message:
  ---
  [view-transitions] https://simple-set-demos.glitch.me/bounce doesn't animate 
correctly
https://bugs.webkit.org/show_bug.cgi?id=273065
rdar://126856305

Reviewed by Tim Nguyen.

While it's not entirely clear to me what the parsing code for the `linear()` 
timing function
was attempting to do to resolve implicit input values into explicit values, the 
css-easing
spec at https://drafts.csswg.org/css-easing/#linear-easing-function-serializing 
specifies
a simple linear interpolation behavior since the last explicit value. This 
wasn't correctly
tested by WPT, so we now have a test for this.

This makes https://simple-set-demos.glitch.me/bounce work as expected since we 
not compute
the correct interpolated values during the bounce animation.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-easing/linear-timing-functions-syntax.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-easing/linear-timing-functions-syntax.tentative.html:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeLinear):

Canonical link: https://commits.webkit.org/277821@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] b8fbb2: Drop mostly unused ActiveDOMObject::activeDOMObjec...

2024-04-22 Thread Chris Dumez
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8fbb2ae4605c2fe55bccfb12f74bd8d8eeba688
  
https://github.com/WebKit/WebKit/commit/b8fbb2ae4605c2fe55bccfb12f74bd8d8eeba688
  Author: Chris Dumez 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/Modules/WebGPU/GPUDevice.h
M Source/WebCore/Modules/applepay/ApplePaySession.cpp
M Source/WebCore/Modules/applepay/ApplePaySession.h
M Source/WebCore/Modules/applepay/ApplePaySetupWebCore.h
M Source/WebCore/Modules/audiosession/DOMAudioSession.cpp
M Source/WebCore/Modules/audiosession/DOMAudioSession.h
M Source/WebCore/Modules/cache/DOMCache.cpp
M Source/WebCore/Modules/cache/DOMCache.h
M Source/WebCore/Modules/cache/DOMCacheStorage.cpp
M Source/WebCore/Modules/cache/DOMCacheStorage.h
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/Modules/cookie-store/CookieStore.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp
M Source/WebCore/Modules/encryptedmedia/MediaKeySession.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemAccess.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.cpp
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h
M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp
M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h
M Source/WebCore/Modules/entriesapi/FileSystemDirectoryReader.cpp
M Source/WebCore/Modules/entriesapi/FileSystemDirectoryReader.h
M Source/WebCore/Modules/entriesapi/FileSystemEntry.cpp
M Source/WebCore/Modules/entriesapi/FileSystemEntry.h
M Source/WebCore/Modules/fetch/FetchRequest.cpp
M Source/WebCore/Modules/fetch/FetchRequest.h
M Source/WebCore/Modules/fetch/FetchResponse.cpp
M Source/WebCore/Modules/fetch/FetchResponse.h
M Source/WebCore/Modules/filesystemaccess/FileSystemHandle.cpp
M Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h
M Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp
M Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.h
M Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp
M Source/WebCore/Modules/gamepad/GamepadHapticActuator.h
M Source/WebCore/Modules/geolocation/Geolocation.cpp
M Source/WebCore/Modules/geolocation/Geolocation.h
M Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
M Source/WebCore/Modules/indexeddb/IDBDatabase.h
M Source/WebCore/Modules/indexeddb/IDBDatabaseNameAndVersionRequest.cpp
M Source/WebCore/Modules/indexeddb/IDBDatabaseNameAndVersionRequest.h
M Source/WebCore/Modules/indexeddb/IDBIndex.cpp
M Source/WebCore/Modules/indexeddb/IDBIndex.h
M Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp
M Source/WebCore/Modules/indexeddb/IDBObjectStore.h
M Source/WebCore/Modules/indexeddb/IDBRequest.cpp
M Source/WebCore/Modules/indexeddb/IDBRequest.h
M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
M Source/WebCore/Modules/indexeddb/IDBTransaction.h
M Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp
M Source/WebCore/Modules/mediarecorder/MediaRecorder.h
M Source/WebCore/Modules/mediasession/MediaSession.h
M Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h
M Source/WebCore/Modules/mediasource/MediaSource.cpp
M Source/WebCore/Modules/mediasource/MediaSource.h
M Source/WebCore/Modules/mediasource/SourceBuffer.cpp
M Source/WebCore/Modules/mediasource/SourceBuffer.h
M Source/WebCore/Modules/mediasource/SourceBufferList.cpp
M Source/WebCore/Modules/mediasource/SourceBufferList.h
M Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp
M Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h
M Source/WebCore/Modules/mediastream/ImageCapture.cpp
M Source/WebCore/Modules/mediastream/ImageCapture.h
M Source/WebCore/Modules/mediastream/MediaDevices.cpp
M Source/WebCore/Modules/mediastream/MediaDevices.h
M Source/WebCore/Modules/mediastream/MediaStream.cpp
M Source/WebCore/Modules/mediastream/MediaStream.h
M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
M Source/WebCore/Modules/mediastream/MediaStreamTrack.h
M Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp
M Source/WebCore/Modules/mediastream/RTCDTMFSender.h
M Source/WebCore/Modules/mediastream/RTCDataChannel.h
M Source/WebCore/Modules/mediastream/RTCDtlsTransport.h
M Source/WebCore/Modules/mediastream/RTCIceTransport.h
M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
M Source/WebCore/Modules/mediastream/RTCPeerConnection.h
M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.h
M Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.h
M Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.h
M Source/WebCore/Modules/mediastream/RTCSctpTransport.h
M Source/

[webkit-changes] [WebKit/WebKit] 021d0c: Unreviewed VisionOS build fix after 277785@main

2024-04-22 Thread Chris Dumez
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 021d0cdd53740b1a6adb0839e04539f1499ba2fe
  
https://github.com/WebKit/WebKit/commit/021d0cdd53740b1a6adb0839e04539f1499ba2fe
  Author: Chris Dumez 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/Model/ModelProcessProxy.cpp

  Log Message:
  ---
  Unreviewed VisionOS build fix after 277785@main

* Source/WebKit/UIProcess/Model/ModelProcessProxy.cpp:
(WebKit::ModelProcessProxy::modelProcessExited):

Canonical link: https://commits.webkit.org/277823@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 659b38: [Unified Text Replacement] Use updated mechanism f...

2024-04-22 Thread Richard Robinson
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 659b3867a43b088e7a74eab0d1e1e8cc77924a95
  
https://github.com/WebKit/WebKit/commit/659b3867a43b088e7a74eab0d1e1e8cc77924a95
  Author: Richard Robinson 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebKit/Shared/UnifiedTextReplacement.serialization.in
M Source/WebKit/Shared/WebTextReplacementData.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm

  Log Message:
  ---
  [Unified Text Replacement] Use updated mechanism for text replacement
https://bugs.webkit.org/show_bug.cgi?id=273039
rdar://125721090

Reviewed by Aditya Keerthi.

* Source/WebKit/Shared/UnifiedTextReplacement.serialization.in:
* Source/WebKit/Shared/WebTextReplacementData.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveReplacements):

Canonical link: https://commits.webkit.org/277824@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] c8847d: In order to create a PR from a fork in the same or...

2024-04-22 Thread Alex Atwater
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8847dcec4d27ac7c6568ad49b87029b6a650317
  
https://github.com/WebKit/WebKit/commit/c8847dcec4d27ac7c6568ad49b87029b6a650317
  Author: Alex Atwater 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py

  Log Message:
  ---
  In order to create a PR from a fork in the same organization, you must 
specify the head_repo param. This enables the param.
https://bugs.webkit.org/show_bug.cgi?id=272899
rdar://126695279 (Allow Github PR to specify head_repo param)

Reviewed by Jonathan Bedard.

This will allow us to pass the necessary param into the PR creation function.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:

Canonical link: https://commits.webkit.org/277825@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 997fde: [IFC] InlineItemsBuilder::populateBreakingPosition...

2024-04-22 Thread Alan Baradlay
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 997fded658dbe5d23faa3758bed139eee7aab81b
  
https://github.com/WebKit/WebKit/commit/997fded658dbe5d23faa3758bed139eee7aab81b
  Author: Alan Baradlay 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp

  Log Message:
  ---
  [IFC] InlineItemsBuilder::populateBreakingPositionCache should early return 
when inline item list is too small
https://bugs.webkit.org/show_bug.cgi?id=273044

Reviewed by Antti Koivisto.

* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::populateBreakingPositionCache):

Canonical link: https://commits.webkit.org/277826@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] a27800: Unreviewed VisionOS build fix after 277785@main

2024-04-22 Thread Chris Dumez
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a278006b98e46b72b2b0f8749eb7227ad21bacd4
  
https://github.com/WebKit/WebKit/commit/a278006b98e46b72b2b0f8749eb7227ad21bacd4
  Author: Chris Dumez 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp

  Log Message:
  ---
  Unreviewed VisionOS build fix after 277785@main

* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::modelProcessExited):

Canonical link: https://commits.webkit.org/277827@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 05d609: Unreviewed VisionOS build fix after 277785@main

2024-04-22 Thread Chris Dumez
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05d6097c835c36077cf49436dc2a8cbedde78d49
  
https://github.com/WebKit/WebKit/commit/05d6097c835c36077cf49436dc2a8cbedde78d49
  Author: Chris Dumez 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.cpp

  Log Message:
  ---
  Unreviewed VisionOS build fix after 277785@main

* Source/WebKit/ModelProcess/ModelConnectionToWebProcess.cpp:
(WebKit::ModelConnectionToWebProcess::didReceiveInvalidMessage):

Canonical link: https://commits.webkit.org/277828@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 472297: [Site Isolation] Make LocalDOMWindow::createWindow...

2024-04-22 Thread Sihui
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47229755a5e79561361ae8c827edd448c5f2bff3
  
https://github.com/WebKit/WebKit/commit/47229755a5e79561361ae8c827edd448c5f2bff3
  Author: Sihui Liu 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
A 
LayoutTests/http/tests/site-isolation/window-open-with-name-cross-site-expected.txt
A 
LayoutTests/http/tests/site-isolation/window-open-with-name-cross-site.html
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h

  Log Message:
  ---
  [Site Isolation] Make LocalDOMWindow::createWindow return Frame
https://bugs.webkit.org/show_bug.cgi?id=272995
rdar://problem/126759468

Reviewed by Alex Christensen and Pascoe.

Currently LocalDOMWindow::createWindow only returns `LocalFrame`, but 
`findFrameForNavigation` (invoked in
WebCore::createWindow) can return a `RemoteFrame` for window with target name. 
See new test for an example. To fix that,
make LocalDOMWindow::createWindow return Frame.

Test: http/tests/site-isolation/window-open-with-name-cross-site.html

* 
LayoutTests/http/tests/site-isolation/window-open-with-name-cross-site-expected.txt:
 Added.
* LayoutTests/http/tests/site-isolation/window-open-with-name-cross-site.html: 
Added.
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::createWindow):
* Source/WebCore/page/LocalDOMWindow.h:

Canonical link: https://commits.webkit.org/277829@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] da9231: Make CachedImage calculate allowsOrientationOverri...

2024-04-22 Thread Said Abou-Hallawa
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da92319fd54b5cf9dcbe546135204314df8ea4f8
  
https://github.com/WebKit/WebKit/commit/da92319fd54b5cf9dcbe546135204314df8ea4f8
  Author: Said Abou-Hallawa 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/html/HTMLImageElement.cpp
M Source/WebCore/loader/cache/CachedImage.cpp
M Source/WebCore/loader/cache/CachedImage.h

  Log Message:
  ---
  Make CachedImage calculate allowsOrientationOverride when loading the image 
is complete
https://bugs.webkit.org/show_bug.cgi?id=272690
rdar://126495895

Reviewed by Cameron McCormack.

Cache the value of allowsOrientationOverride when the image is loaded and reuse
the cached value instead of recalculating it every time it is needed.

* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::allowsOrientationOverride const):
* Source/WebCore/loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::clearImage):
(WebCore::CachedImage::finishLoading):
* Source/WebCore/loader/cache/CachedImage.h:

Canonical link: https://commits.webkit.org/277830@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] c8a840: [WebGPU] setVisibilityResultMode can be called twi...

2024-04-22 Thread mwyrzykowski
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8a8404f7311af14a4e4b347d2298ed73622caaa
  
https://github.com/WebKit/WebKit/commit/c8a8404f7311af14a4e4b347d2298ed73622caaa
  Author: Mike Wyrzykowski 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-272903-expected.txt
A LayoutTests/fast/webgpu/fuzz-272903.html
M Source/WebGPU/WebGPU/BindGroup.mm
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.h
M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  ---
  [WebGPU] setVisibilityResultMode can be called twice at the same offset, 
leading to validation errors
https://bugs.webkit.org/show_bug.cgi?id=272903


Reviewed by Tadeu Zagallo.

Add checks for some invalid inputs along with a test to catch
these cases.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-272903-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-272903.html: Added.
Add regression tests, the test passes if it reaches the end.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::endEncoding):
(WebGPU::CommandEncoder::copyBufferToTexture):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::beginOcclusionQuery):

Canonical link: https://commits.webkit.org/277831@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] de391f: Remove local test 'track-text-track-cue-list.html'...

2024-04-22 Thread Commit Queue
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de391fbc02a2418bb5d8fa0242ce56d89f2f0a4e
  
https://github.com/WebKit/WebKit/commit/de391fbc02a2418bb5d8fa0242ce56d89f2f0a4e
  Author: Ahmad Saleem 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
R LayoutTests/media/track/track-text-track-cue-list-expected.txt
R LayoutTests/media/track/track-text-track-cue-list.html

  Log Message:
  ---
  Remove local test 'track-text-track-cue-list.html' in favor of WPT

https://bugs.webkit.org/show_bug.cgi?id=123497

Reviewed by Eric Carlson.

This PR is to remove local test 'track-text-track-cue-list.html',
in favor of WPT test with same name.

* LayoutTests/media/track/track-text-track-cue-list-expected.txt: Removed.
* LayoutTests/media/track/track-text-track-cue-list.html: Removed.

Canonical link: https://commits.webkit.org/277832@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 403860: [Gardening]: REGRESSION (277809@main): [ macOS wk1...

2024-04-22 Thread martadarbinyan
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 40386075bc235539446174ecb2ab50d60bd2942e
  
https://github.com/WebKit/WebKit/commit/40386075bc235539446174ecb2ab50d60bd2942e
  Author: Marta Darbinyan 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (277809@main): [ macOS wk1 ] 
imported/w3c/web-platform-tests/geolocation-API are consistent failure
https://bugs.webkit.org/show_bug.cgi?id=273083
rdar://126878399

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/277833@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 124d36: [view-transitions] View transition pseudo elements...

2024-04-22 Thread mattwoodrow
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 124d36f180e38519cebcf56b356ea7e5e53b245b
  
https://github.com/WebKit/WebKit/commit/124d36f180e38519cebcf56b356ea7e5e53b245b
  Author: Matt Woodrow 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h

  Log Message:
  ---
  [view-transitions] View transition pseudo elements should be anonymous.
https://bugs.webkit.org/show_bug.cgi?id=273056

Reviewed by Tim Nguyen.

We have existing code that expects renderers that return false from isAnonymous
to also have a valid Element.

Rather than making the view-transition pseudo elements not-anonymous, we
should instead change the consumers of isAnonymous so that these 
pseudo-renderers
can still be containing blocks.

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation const):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::containingBlockForAutoHeightDetection const):
(WebCore::RenderBoxModelObject::requiresLayer const):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::isViewTransitionPseudo const): Deleted.
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::canCreateStackingContext):
(WebCore::RenderLayer::shouldBeCSSStackingContext const):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForViewTransition const):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::shouldBeAnonymous): Deleted.
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isViewTransitionPseudo const):
(WebCore::RenderObject::isAnonymousForPercentageResolution const):
(WebCore::RenderObject::node const):

Canonical link: https://commits.webkit.org/277834@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] ff9cef: [view-transitions] Replaced content rect offset is...

2024-04-22 Thread mattwoodrow
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff9ceff0e3c78e5c80ff0d55f972f0a0f585352e
  
https://github.com/WebKit/WebKit/commit/ff9ceff0e3c78e5c80ff0d55f972f0a0f585352e
  Author: Matt Woodrow 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderViewTransitionCapture.cpp
M Source/WebCore/rendering/RenderViewTransitionCapture.h

  Log Message:
  ---
  [view-transitions] Replaced content rect offset isn't respected when using 
layer attachment.
https://bugs.webkit.org/show_bug.cgi?id=273057

Reviewed by Tim Nguyen.

If the 'replaced content rect' starts outside of the content box (like happens 
with
`object-fit: none;`), then the layer attachment path doesn't handle this 
correctly.

Moves the addition of the replaced content rect location into the stored local 
overflow,
rather than doing so in a temporary in the painting code.

Adjusts the position of the attached layer by the difference between the 
renderer's
visual overflow rect, and where the capture layer actually begins (the local 
overflow
rect for the capture).

* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateTransform):
(WebCore::RenderLayerBacking::updateChildrenTransformAndAnchorPoint):
* Source/WebCore/rendering/RenderViewTransitionCapture.cpp:
(WebCore::RenderViewTransitionCapture::paintReplaced):
(WebCore::RenderViewTransitionCapture::layout):
(WebCore::RenderViewTransitionCapture::updateFromStyle):
(WebCore::RenderViewTransitionCapture::captureContentInset const):
(WebCore::RenderViewTransitionCapture::debugDescription const):
* Source/WebCore/rendering/RenderViewTransitionCapture.h:

Canonical link: https://commits.webkit.org/277835@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] b332f9: Drop StringView::characters8() / characters16()

2024-04-22 Thread Chris Dumez
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b332f986be2c69a696e8ab2646b087123fc64cc4
  
https://github.com/WebKit/WebKit/commit/b332f986be2c69a696e8ab2646b087123fc64cc4
  Author: Chris Dumez 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/builtins/BuiltinExecutables.cpp
M Source/JavaScriptCore/parser/Lexer.h
M Source/JavaScriptCore/runtime/ArrayPrototype.cpp
M Source/JavaScriptCore/runtime/IntlCollator.cpp
M Source/JavaScriptCore/runtime/IntlObjectInlines.h
M Source/JavaScriptCore/runtime/JSBigInt.cpp
M Source/JavaScriptCore/runtime/JSBigInt.h
M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
M Source/JavaScriptCore/runtime/JSImmutableButterfly.cpp
M Source/JavaScriptCore/runtime/ParseInt.h
M Source/JavaScriptCore/yarr/YarrJIT.cpp
M Source/WTF/wtf/Threading.cpp
M Source/WTF/wtf/text/StringSearch.h
M Source/WTF/wtf/text/StringView.h
M Source/WebCore/css/CSSFontFaceSet.cpp
M Source/WebCore/css/parser/CSSParserFastPaths.cpp
M Source/WebCore/css/parser/CSSParserToken.cpp
M Source/WebCore/html/HTMLAttachmentElement.cpp
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/TextRun.h
M Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp
M Source/WebCore/platform/network/create-http-header-name-table
M Source/WebCore/platform/sql/SQLiteStatement.cpp
M Source/WebCore/platform/text/SegmentedString.h
M Source/WebCore/rendering/RenderText.cpp
M Source/WebKit/Shared/API/c/WKString.cpp
M Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm
M Source/WebKitLegacy/mac/WebView/WebTextIterator.mm
M Tools/TestWebKitAPI/Tests/WTF/StringParsingBuffer.cpp

  Log Message:
  ---
  Drop StringView::characters8() / characters16()
https://bugs.webkit.org/show_bug.cgi?id=273052

Reviewed by Darin Adler.

Drop StringView::characters8() / characters16(), in favor to span8() / span16().

* Source/JavaScriptCore/builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createExecutable):
* Source/JavaScriptCore/parser/Lexer.h:
(JSC::Lexer::setCodeStart):
(JSC::Lexer::setCodeStart):
* Source/JavaScriptCore/runtime/ArrayPrototype.cpp:
(JSC::fastJoin):
* Source/JavaScriptCore/runtime/IntlCollator.cpp:
(JSC::IntlCollator::compareStrings const):
(JSC::IntlCollator::checkICULocaleInvariants):
* Source/JavaScriptCore/runtime/IntlObjectInlines.h:
(JSC::followedByNonLatinCharacter):
(JSC::compareASCIIWithUCADUCETLevel3):
(JSC::compareASCIIWithUCADUCET):
* Source/JavaScriptCore/runtime/JSBigInt.cpp:
(JSC::JSBigInt::parseInt):
* Source/JavaScriptCore/runtime/JSBigInt.h:
* Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/JSImmutableButterfly.cpp:
(JSC::JSImmutableButterfly::createFromString):
* Source/JavaScriptCore/runtime/ParseInt.h:
(JSC::parseInt):
* Source/JavaScriptCore/yarr/YarrJIT.cpp:
(JSC::Yarr::SubjectSampler::sample):
* Source/WTF/wtf/text/StringSearch.h:
(WTF::BoyerMooreHorspoolTable::BoyerMooreHorspoolTable):
* Source/WTF/wtf/text/StringView.h:
* Source/WebCore/css/CSSFontFaceSet.cpp:
(WebCore::codePointsFromString):
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::checkForValidDouble):
(WebCore::parseDouble):
(WebCore::parseColorIntOrPercentage):
(WebCore::isTenthAlpha):
(WebCore::parseAlphaValue):
(WebCore::mightBeRGBA):
(WebCore::mightBeRGB):
(WebCore::parseHexColorInternal):
(WebCore::parseNumericColor):
(WebCore::parseNamedColorInternal):
(WebCore::parseSimpleColorInternal):
(WebCore::CSSParserFastPaths::parseSimpleColor):
(WebCore::CSSParserFastPaths::parseHexColor):
(WebCore::CSSParserFastPaths::parseNamedColor):
* Source/WebCore/css/parser/CSSParserToken.cpp:
(WebCore::mergeIfAdjacent):
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::attachmentTitleForDisplay const):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::enclosingGlyphBoundsForText):
(WebCore::Layout::TextUtil::containsStrongDirectionalityText):
(WebCore::Layout::TextUtil::directionForTextContent):
(WebCore::Layout::TextUtil::canUseSimplifiedTextMeasuring):
* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::widthForSimpleTextSlow const):
(WebCore::FontCascade::codePath const):
(WebCore::FontCascade::characterRangeCodePath):
* Source/WebCore/platform/graphics/FontCascade.h:
* Source/WebCore/platform/graphics/TextRun.h:
* Source/WebCore/platform/network/create-http-header-name-table:
* Source/WebCore/platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::bindText):
* Source/WebCore/platform/text/SegmentedString.h:
(WebCo

[webkit-changes] [WebKit/WebKit] 8feb39: [UnifiedPDF] Do more fine-grained tile invalidation

2024-04-22 Thread Simon Fraser
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8feb3943337028bf46df4837262ae202e7fe30db
  
https://github.com/WebKit/WebKit/commit/8feb3943337028bf46df4837262ae202e7fe30db
  Author: Simon Fraser 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/TiledBacking.h
M Source/WebCore/platform/graphics/ca/TileController.cpp
M Source/WebCore/platform/graphics/ca/TileController.h
M Source/WebCore/platform/graphics/ca/TileGrid.cpp
M Source/WebCore/platform/graphics/ca/TileGrid.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPageCoverage.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp

  Log Message:
  ---
  [UnifiedPDF] Do more fine-grained tile invalidation
https://bugs.webkit.org/show_bug.cgi?id=273016
rdar://126779250

Reviewed by Tim Horton.

AsyncPDFRenderer's tile invalidation was based on the 
PDFConfigurationIdentifier changing,
which happened on scaling and layout changes. However, some kinds of layout 
(e.g. window
resize without automatic resizing) don't change the per-tile PDF contents, so 
in those cases
we can preserve rendered tiles, which can avoid large amounts of re-rendering 
for PDFs
which are expensive to render.

We can compare `TileRenderInfo`s to know if a tile has changed, since 
`PDFPageCoverage`
gives us page-relative rects for this tile.

Remove PDFConfigurationIdentifiers which we no longer need. Make it possible to 
test `TileRenderInfo`
for painting equality (which ignores the optional clip rect), and implement 
`renderInfoForTile()` which
allows us to compute a `TileRenderInfo` from the current state of the PDF and 
tile grid (we need
`rectForTile()` for this, which is added to `TiledBacking`).

Now `willRepaintTile()` can ask if we have a valid cached tile using more data 
than just
the tile index. `enqueueTilePaintIfNecessary()` can also early return if we 
have an existing
queued paint which is valid, and `didCompleteTileRender()` can ask whether the 
paint we
just completed asynchronously is still valid.

We do need a new identifier, PDFContentsVersionIdentifier, which increments 
when the PDF
contents change (e.g. an annotation update); this allows us to ask whether an 
enqueued
tile paint is still valid (e.g. for partial updates on form control changes).

* Source/WebCore/platform/graphics/TiledBacking.h:
* Source/WebCore/platform/graphics/ca/TileController.cpp:
(WebCore::TileController::rectForTile const):
* Source/WebCore/platform/graphics/ca/TileController.h:
* Source/WebCore/platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::rectForTile const):
* Source/WebCore/platform/graphics/ca/TileGrid.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h:
(WebKit::AsyncPDFRenderer::TileRenderInfo::equivalentForPainting const):
(WebKit::AsyncPDFRenderer::renderInfoForTile):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm:
(WebKit::AsyncPDFRenderer::AsyncPDFRenderer):
(WebKit::AsyncPDFRenderer::renderInfoIsValidForTile const):
(WebKit::AsyncPDFRenderer::willRepaintTile):
(WebKit::AsyncPDFRenderer::tilingScaleFactorDidChange):
(WebKit::AsyncPDFRenderer::enqueueTilePaintIfNecessary):
(WebKit::AsyncPDFRenderer::renderInfoForTile const):
(WebKit::AsyncPDFRenderer::enqueuePaintWithClip):
(WebKit::AsyncPDFRenderer::paintPDFIntoBuffer):
(WebKit::AsyncPDFRenderer::didCompleteTileRender):
(WebKit::AsyncPDFRenderer::paintTilesForPage):
(WebKit::AsyncPDFRenderer::pdfContentChangedInRect):
(WebKit::AsyncPDFRenderer::layoutConfigurationChanged): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPageCoverage.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updateLayerHierarchy):
(WebKit::UnifiedPDFPlugin::setScaleFactor):
* Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp:

Canonical link: https://commits.webkit.org/277837@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] da4ea5: Web Extension popup is slow and jittery when prese...

2024-04-22 Thread Timothy Hatcher
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da4ea518b228c320fb16ae92d065a990ff3dab17
  
https://github.com/WebKit/WebKit/commit/da4ea518b228c320fb16ae92d065a990ff3dab17
  Author: Timothy Hatcher 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionAction.h

  Log Message:
  ---
  Web Extension popup is slow and jittery when presenting.
https://webkit.org/b/273079
rdar://126646845

Reviewed by Brian Weinstein.

Fixes a few issues where popups were not presenting fast and jittering when 
animating open.
* Add the web view temporarily to a window to force it to layout. This was the 
primary issue,
  since WebKit was not laying-out various extension popups before it was added 
to a window.
* Stop updating the popover size when the size hasn't changed above the minimum.
* Reduced the timeout to 250ms in Release builds (and triple in Debug). All 
popups now
  display in less than 100ms on an M3 MacBook Pro. This can be reduced because 
the timeout
  starts after the document load, not prior to the load like it did before 
275454@main.
* Prevent the delegate method from being called when just accessing the 
popupWebView property
  on the action. It should only be called when the performActionForTab: method 
is called.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(-[_WKWebExtensionActionWebView contentSize]): Renamed from _contentSize to be 
public.
(-[_WKWebExtensionActionWebView _contentSizeDidChange]): Only call 
popupSizeDidChange
when the size is above the minimum.
(-[_WKWebExtensionActionWebView _contentSizeHasStabilized]): Renamed from
_checkIfContentSizeStabilizedAndPresentPopup to be clearer.
(-[_WKWebExtensionActionPopover initWithWebExtensionAction:]):
(WebKit::WebExtensionAction::WebExtensionAction):
(WebKit::WebExtensionAction::popupWebView): Remove unused LoadOnFirstAccess 
parameter.
(WebKit::WebExtensionAction::presentPopupWhenReady):
(WebKit::WebExtensionAction::popupDidFinishDocumentLoad):
(WebKit::WebExtensionAction::readyToPresentPopup):
(WebKit::WebExtensionAction::popupSizeDidChange): Moved readyToPresentPopup() 
call here.
(WebKit::WebExtensionAction::closePopup):
(-[_WKWebExtensionActionWebView _contentSize]): Deleted.
(-[_WKWebExtensionActionWebView _checkIfContentSizeStabilizedAndPresentPopup]): 
Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtensionAction.h:
(WebKit::WebExtensionAction::shouldPresentPopupWhenReady const):

Canonical link: https://commits.webkit.org/277838@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 27df57: Cherry-pick 276081@main (d1ce25eca8a3). https://bu...

2024-04-22 Thread Miguel Gómez
  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 27df57462b15f8a0e046aa52837f1ceff983a446
  
https://github.com/WebKit/WebKit/commit/27df57462b15f8a0e046aa52837f1ceff983a446
  Author: Miguel Gomez 
  Date:   2024-04-23 (Tue, 23 Apr 2024)

  Changed paths:
M Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css
M Source/WebInspectorUI/UserInterface/Views/TextEditor.css

  Log Message:
  ---
  Cherry-pick 276081@main (d1ce25eca8a3). 
https://bugs.webkit.org/show_bug.cgi?id=270849

[WPE] Fix text highlight on HTTP RWI running on Chromium
https://bugs.webkit.org/show_bug.cgi?id=270849

Reviewed by Tim Nguyen.

Remove the quotes around the CSS animation name in the relevant definitions,
as they should not be there.

* Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:
(.highlight .selection-area):
* Source/WebInspectorUI/UserInterface/Views/TextEditor.css:
(.text-editor > .CodeMirror .highlighted):
(.text-editor > .CodeMirror .hovered-expression-highlight):

Canonical link: https://commits.webkit.org/276081@main

Canonical link: https://commits.webkit.org/274313.151@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 7b0b2b: REGRESSION (277820@main): [ MacOS iOS ] editing/st...

2024-04-22 Thread Alan Baradlay
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b0b2b2301d34892b7fc91d1433ed0a2ecb00c56
  
https://github.com/WebKit/WebKit/commit/7b0b2b2301d34892b7fc91d1433ed0a2ecb00c56
  Author: Alan Baradlay 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/platform/ios/editing/style/table-selection-expected.txt
M LayoutTests/platform/mac/editing/style/table-selection-expected.txt

  Log Message:
  ---
  REGRESSION (277820@main): [ MacOS iOS ] editing/style/table-selection.html is 
a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=273093


Unreviewed test gardening.

* LayoutTests/platform/ios/editing/style/table-selection-expected.txt:
* LayoutTests/platform/mac/editing/style/table-selection-expected.txt:

Canonical link: https://commits.webkit.org/277839@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] e07755: [Gardening]: REGRESSION (277521@main): [ MacOS WK1...

2024-04-22 Thread martadarbinyan
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e07755fef93bcefd6fee132d0fd6705a89a70a2f
  
https://github.com/WebKit/WebKit/commit/e07755fef93bcefd6fee132d0fd6705a89a70a2f
  Author: Marta Darbinyan 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (277521@main): [ MacOS WK1 ] 
fast/css/viewport-height-border.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=272792
rdar://126590072

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/277840@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3e223a: [WebGPU] Queue::writeTexture can fail for some 1D ...

2024-04-22 Thread mwyrzykowski
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e223a775bcb5b78ead4a62810d4993540c1088c
  
https://github.com/WebKit/WebKit/commit/3e223a775bcb5b78ead4a62810d4993540c1088c
  Author: Mike Wyrzykowski 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-272911-expected.txt
A LayoutTests/fast/webgpu/fuzz-272911.html
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  ---
  [WebGPU] Queue::writeTexture can fail for some 1D texture copies
https://bugs.webkit.org/show_bug.cgi?id=272911


Reviewed by Tadeu Zagallo.

Add two missing checks which failed the Metal validation layer.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-272911-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-272911.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::copyTextureToBuffer):
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::writeTexture):

Canonical link: https://commits.webkit.org/277841@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] c61c30: Re-sync rgb()/rgba() implementation with the lates...

2024-04-22 Thread Sam Weinig
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c61c3004d66ab6e219241918cfa49ce12427ea4a
  
https://github.com/WebKit/WebKit/commit/c61c3004d66ab6e219241918cfa49ce12427ea4a
  Author: Sam Weinig 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-rgb-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-out-of-gamut-expected.txt
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp

  Log Message:
  ---
  Re-sync rgb()/rgba() implementation with the latest spec
https://bugs.webkit.org/show_bug.cgi?id=272942

Reviewed by Darin Adler.

The CSS Color specification has changed since rgb()/rgba() was last
worked on. This updates things to support:

- Modified parsing rules for the modern syntax which now allow mixed 
  and  values.
- Changes to the types used by the r/g/b/alpha symbols used in the relative
  color form to always be CSS_NUMBER.
- Requirement that the relative form serialize as `color(srgb )`.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-rgb-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-out-of-gamut-expected.txt:
Update another good chunk of tests to now pass.

* Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp:
(WebCore::CSSPropertyParserHelpers::normalizeRGBFunctionComponent):
(WebCore::CSSPropertyParserHelpers::normalizeRGBFunctionAlpha):
(WebCore::CSSPropertyParserHelpers::normalizeRGBFunctionComponents):
(WebCore::CSSPropertyParserHelpers::parseRelativeRGBParametersRaw):
(WebCore::CSSPropertyParserHelpers::parseNonRelativeRGBParametersLegacyRaw):
(WebCore::CSSPropertyParserHelpers::parseNonRelativeRGBParametersModernRaw):
(WebCore::CSSPropertyParserHelpers::parseNonRelativeRGBParametersRaw):
Work to separate parsing and normalization, allowing much of normalization
to be reused for all the parsing paths.

(WebCore::CSSPropertyParserHelpers::parseRGBParametersRaw):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionRaw):
(WebCore::CSSPropertyParserHelpers::parseColorFunction):
Remove distinction in parsing behavior between rgb() and rgba().

Canonical link: https://commits.webkit.org/277842@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] b8532b: Increase platform coverage of check-for-duplicated...

2024-04-22 Thread Sam Sneddon
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8532bcbdb398f3c962fb793b5b2eafe254fee9f
  
https://github.com/WebKit/WebKit/commit/b8532bcbdb398f3c962fb793b5b2eafe254fee9f
  Author: Sam Sneddon 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Tools/Scripts/check-for-duplicated-platform-test-results
M Tools/Scripts/webkitpy/port/factory.py
M Tools/Scripts/webkitpy/port/ios.py
M Tools/Scripts/webkitpy/port/win.py

  Log Message:
  ---
  Increase platform coverage of check-for-duplicated-platform-test-results
https://bugs.webkit.org/show_bug.cgi?id=271276

Reviewed by Jonathan Bedard.

This is really a smörgåsbord of small fixes; see below:

* Tools/Scripts/check-for-duplicated-platform-test-results:
(platform_list): Also use PortFactory.all_port_names() when 'all' is passed.
(check_platform): Some logging changes, plus creating a new optparse.Values 
object for each Port.
(main): Move webkit_test_runner to be an argument.
* Tools/Scripts/webkitpy/port/factory.py:
(PortFactory.all_port_names): Update our list of known ports.
* Tools/Scripts/webkitpy/port/ios.py:
(IOSPort.default_baseline_search_path): Use the generic device_type if one 
isn't passed.
* Tools/Scripts/webkitpy/port/win.py:
(WinPort.__init__): Only use the platform version if we're on Windows, to match 
MacPort.
(WinCairoPort._search_paths): Gracefully handle not knowing the name of a 
version.

Canonical link: https://commits.webkit.org/277843@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 191afe: Cherry-pick 275908@main (ff20e457cb9c). https://bu...

2024-04-22 Thread Georges Basile Stavracas Neto
  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 191afe5db3efcf8b51c4883b6fe7533c5d8b68a5
  
https://github.com/WebKit/WebKit/commit/191afe5db3efcf8b51c4883b6fe7533c5d8b68a5
  Author: Georges Basile Stavracas Neto 
  Date:   2024-04-23 (Tue, 23 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/gtk/DropTarget.h
M Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp

  Log Message:
  ---
  Cherry-pick 275908@main (ff20e457cb9c). 
https://bugs.webkit.org/show_bug.cgi?id=212079

[GTK] Receive dropped files using the File Transfer portal
https://bugs.webkit.org/show_bug.cgi?id=212079

Reviewed by Carlos Garcia Campos.

GTK4 has content serializers and deserializers that are able to read
from, and write to, the File Transfer portal. They're used when using
the high level content formats API, i.e. using GTypes. In particular,
GTK4 is able to convert from "application/vnd.portal.filetransfer" (and
the legacy "application/vnd.portal.files") from and into GdkFileLists.

The DropTargetGtk4 code did not advertise the GdkFileList GType as a
potential data offering, so GTK4 was never able to let the File Transfer
portal conversion happen.

Add the GdkFileList GType to the content formats.

This creates a small conflict: many apps, e.g. Nautilus, advertise files
both as "application/vnd.portal.filetransfer", and as "text/uri-list".
The file URIs under "text/uri-list" are meaningless to sandboxed apps,
as they might be in innaccessible locations. Which is why I've made the
executive decision to ignore "file://" URIs when the File Transfer portal
is used. Other types of URIs are preserved.

(Other browsers take a more radical approach of ignoring all URIs on the
presence of the File Transfer portal vendor.)

* Source/WebKit/UIProcess/API/gtk/DropTarget.h:
* Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp:
(WebKit::DropTarget::DropTarget):
(WebKit::DropTarget::accept):
(WebKit::DropReadAsyncData::DropReadAsyncData):
(WebKit::DropTarget::loadData):
(WebKit::DropTarget::didLoadData):

Canonical link: https://commits.webkit.org/275908@main

Canonical link: https://commits.webkit.org/274313.152@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 715267: [Gardening]: REGRESSION (277521@main): [ MacOS WK1...

2024-04-22 Thread martadarbinyan
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7152674f790ce84a0156b3e9a1de87ef20b3780d
  
https://github.com/WebKit/WebKit/commit/7152674f790ce84a0156b3e9a1de87ef20b3780d
  Author: Marta Darbinyan 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (277521@main): [ MacOS WK1 ] 
fast/css/viewport-height-border.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=272792
rdar://126590072

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/277844@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] d0bcde: [Site Isolation] Re-enable site-isolation/window-p...

2024-04-22 Thread Nikos Mouchtaris
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0bcde3bde39037225d11bb794dc5b297f2960ba
  
https://github.com/WebKit/WebKit/commit/d0bcde3bde39037225d11bb794dc5b297f2960ba
  Author: Nikolaos Mouchtaris 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Site Isolation] Re-enable site-isolation/window-properties.html
https://bugs.webkit.org/show_bug.cgi?id=269639
rdar://123547612

Unreviewed re-enable of test.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/277845@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 5a297f: REGRESSION (277781@main): [ iOS ] accessibility/io...

2024-04-22 Thread Jay Saintfleur
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a297f5b76fa8daa9798b739807a34052afa8780
  
https://github.com/WebKit/WebKit/commit/5a297f5b76fa8daa9798b739807a34052afa8780
  Author: Jay Stfleur 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  REGRESSION (277781@main): [ iOS ] accessibility/ios-simulator/math.html is a 
consistent failure
https://bugs.webkit.org/show_bug.cgi?id=273095
rdar://126887745

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/277846@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 0d30af: Avoid duplicate NetworkProcess::AddAllowedFirstPar...

2024-04-22 Thread Sihui
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d30af72a1b23a3fbe4c9b2a681b609c75dd7a02
  
https://github.com/WebKit/WebKit/commit/0d30af72a1b23a3fbe4c9b2a681b609c75dd7a02
  Author: Sihui Liu 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessPool.cpp

  Log Message:
  ---
  Avoid duplicate NetworkProcess::AddAllowedFirstPartyForCookies messages
https://bugs.webkit.org/show_bug.cgi?id=272731
rdar://126531726

Reviewed by Alex Christensen.

Network process currently receives multiple 
NetworkProcess::AddAllowedFirstPartyForCookies messages for the same process
identifier and site pair, even though 
NetworkProcessProxy::addAllowedFirstPartyForCookies asks to not send the message
when the entry already exists. This is caused by some call sites explicitly 
sending the AddAllowedFirstPartyForCookies
message to network process instead of invoking 
NetworkProcessProxy::addAllowedFirstPartyForCookies. This patch fixes
that issue.

This patch also fixes a use-after-move issue in 
WebFrameProxy::prepareForProvisionalNavigationInProcess.

* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::prepareForProvisionalNavigationInProcess):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess):

Canonical link: https://commits.webkit.org/277847@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 2e9fdd: One file per class for WeakPtrImpl, WeakPtrFactory...

2024-04-22 Thread geoffreygaren
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e9fdd8937169f6c6c4161bf5bcc4fd4cad3cef5
  
https://github.com/WebKit/WebKit/commit/2e9fdd8937169f6c6c4161bf5bcc4fd4cad3cef5
  Author: Geoffrey Garen 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
A Source/WTF/wtf/CanMakeWeakPtr.h
M Source/WTF/wtf/WeakPtr.h
A Source/WTF/wtf/WeakPtrFactory.h
A Source/WTF/wtf/WeakPtrImpl.h
M Source/WTF/wtf/WeakRef.h

  Log Message:
  ---
  One file per class for WeakPtrImpl, WeakPtrFactory, and CanMakeWeakPtr

https://bugs.webkit.org/show_bug.cgi?id=273084
rdar://126878970

Reviewed by Chris Dumez.

* Source/WTF/wtf/CanMakeWeakPtr.h:
* Source/WTF/wtf/WeakPtr.h:
* Source/WTF/wtf/WeakPtrImpl.h:

Canonical link: https://commits.webkit.org/277848@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] bd4b75: Update LoggerHelper::logClassName() to return an A...

2024-04-22 Thread Chris Dumez
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd4b75d88899cf73fdaf55a7d42116dbbf45b61e
  
https://github.com/WebKit/WebKit/commit/bd4b75d88899cf73fdaf55a7d42116dbbf45b61e
  Author: Chris Dumez 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WTF/wtf/Logger.h
M Source/WTF/wtf/LoggerHelper.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySession.h
M Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp
M Source/WebCore/Modules/encryptedmedia/NavigatorEME.cpp
M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h
M Source/WebCore/Modules/mediasession/MediaSession.cpp
M Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h
M Source/WebCore/Modules/mediasource/MediaSource.h
M Source/WebCore/Modules/mediasource/SourceBuffer.h
M Source/WebCore/Modules/mediastream/ImageCapture.h
M Source/WebCore/Modules/mediastream/MediaStream.h
M Source/WebCore/Modules/mediastream/MediaStreamTrack.h
M Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
M Source/WebCore/Modules/mediastream/RTCPeerConnection.h
M Source/WebCore/Modules/mediastream/RTCRtpReceiver.h
M Source/WebCore/Modules/mediastream/RTCRtpSender.h
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
M Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h
M Source/WebCore/Modules/remoteplayback/RemotePlayback.h
M Source/WebCore/Modules/webaudio/AudioNode.h
M Source/WebCore/Modules/webaudio/AudioParam.h
M Source/WebCore/Modules/webaudio/BaseAudioContext.h
M Source/WebCore/dom/FullscreenManager.h
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/html/MediaElementSession.h
M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.h
M Source/WebCore/html/track/AudioTrack.h
M Source/WebCore/html/track/InbandDataTextTrack.h
M Source/WebCore/html/track/InbandGenericTextTrack.h
M Source/WebCore/html/track/InbandWebVTTTextTrack.h
M Source/WebCore/html/track/LoadableTextTrack.h
M Source/WebCore/html/track/TextTrack.h
M Source/WebCore/html/track/VTTCue.h
M Source/WebCore/html/track/VideoTrack.h
M Source/WebCore/platform/audio/AudioSession.h
M Source/WebCore/platform/audio/PlatformMediaSession.h
M Source/WebCore/platform/audio/PlatformMediaSessionManager.h
M Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.h
M Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.h
M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h
M Source/WebCore/platform/audio/glib/MediaSessionManagerGLib.h
M Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h
M Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.h
M Source/WebCore/platform/cocoa/VideoPresentationModelVideoElement.h
M Source/WebCore/platform/graphics/AudioTrackPrivate.h
M Source/WebCore/platform/graphics/InbandTextTrackPrivate.h
M Source/WebCore/platform/graphics/TrackBuffer.h
M Source/WebCore/platform/graphics/VideoTrackPrivate.h
M Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.h
M 
Source/WebCore/platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.h
M Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h
M 
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
M Source/WebCore/platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

[webkit-changes] [WebKit/WebKit] 1d9888: macOS 14.4 Regression: HTML elements in a WebView ...

2024-04-22 Thread Simon Fraser
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d9888c85e204821e7f0489d01bc5b3ae0a42833
  
https://github.com/WebKit/WebKit/commit/1d9888c85e204821e7f0489d01bc5b3ae0a42833
  Author: Simon Fraser 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm

  Log Message:
  ---
  macOS 14.4 Regression: HTML elements in a WebView (Legacy) do not repaint 
when their width/height change
https://bugs.webkit.org/show_bug.cgi?id=270898
rdar://124564409

Reviewed by Matt Woodrow.

After 271261@main we don't update compositing layers on every layout, but when 
WebKitLegacy forces
layout, we need to update them. This fixes an issue resizing solid-color-only 
layers; for other
layers, the triggered repaint avoids the bug.

I tried to fix DumpRenderTree to respect `testRunner.dontForceRepaint()` so I 
could write a test,
but even with this, the runloop observer fires in DRT and updates layers, so 
the test didn't work.

* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]):

Canonical link: https://commits.webkit.org/277850@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 35e0f1: (REGRESSION 273633@main)Text layout changes when p...

2024-04-22 Thread Alan Baradlay
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35e0f13b017828f67e06e51368f5c7503fa8f238
  
https://github.com/WebKit/WebKit/commit/35e0f13b017828f67e06e51368f5c7503fa8f238
  Author: Alan Baradlay 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
A 
LayoutTests/fast/inline/shrink-to-fit-with-inline-box-with-word-spacing-expected.html
A 
LayoutTests/fast/inline/shrink-to-fit-with-inline-box-with-word-spacing.html
M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp

  Log Message:
  ---
  (REGRESSION 273633@main)Text layout changes when pointer hovers over content
https://bugs.webkit.org/show_bug.cgi?id=273094

Reviewed by Antti Koivisto.

In order to exercise the fast codepath for intrinsic width computation,
in addition to the block root the ancestor inline boxes also need eligible 
styles.

* 
LayoutTests/fast/inline/shrink-to-fit-with-inline-box-with-word-spacing-expected.html:
 Added.
* LayoutTests/fast/inline/shrink-to-fit-with-inline-box-with-word-spacing.html: 
Added.
* Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:
(WebCore::Layout::IntrinsicWidthHandler::IntrinsicWidthHandler):

Canonical link: https://commits.webkit.org/277851@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 05eebf: [JSC] Micro-optimize stricteq in Baseline JIT with...

2024-04-22 Thread Yusuke Suzuki
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05eebf301836e4602ceaac0926ba9d5367b7
  
https://github.com/WebKit/WebKit/commit/05eebf301836e4602ceaac0926ba9d5367b7
  Author: Yusuke Suzuki 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
A JSTests/stress/jstrict-eq-constant-simple.js
A JSTests/stress/jstrict-neq-constant-simple.js
A JSTests/stress/strict-eq-constant-simple.js
A JSTests/stress/strict-neq-constant-simple.js
M Source/JavaScriptCore/jit/JITOpcodes.cpp

  Log Message:
  ---
  [JSC] Micro-optimize stricteq in Baseline JIT with bitwise-comparable 
constants
https://bugs.webkit.org/show_bug.cgi?id=272948
rdar://126726702

Reviewed by Keith Miller.

We observed stricteq with true / false / void 0 / null cases in the wild, so 
let's have some optimized code generation even in baseline JIT since it is 
simple.

* JSTests/stress/jstrict-eq-constant-simple.js: Added.
(shouldBe):
(test1):
(test2):
(test3):
(test4):
* JSTests/stress/jstrict-neq-constant-simple.js: Added.
(shouldBe):
(test1):
(test2):
(test3):
(test4):
* JSTests/stress/strict-eq-constant-simple.js: Added.
(shouldBe):
(test1):
(test2):
(test3):
(test4):
* JSTests/stress/strict-neq-constant-simple.js: Added.
(shouldBe):
(test1):
(test2):
(test3):
(test4):
* Source/JavaScriptCore/jit/JITOpcodes.cpp:
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::compileOpStrictEqJump):

Canonical link: https://commits.webkit.org/277852@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 45e949: [WinCairo] Unreviewed test gardening

2024-04-22 Thread Fujii Hironori
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 45e9493a5ab1f1805a2833b164ca9762f7e7c7c1
  
https://github.com/WebKit/WebKit/commit/45e9493a5ab1f1805a2833b164ca9762f7e7c7c1
  Author: Fujii Hironori 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/277853@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] f8efe9: [JSC] Add some additional information bits to Samp...

2024-04-22 Thread Yusuke Suzuki
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8efe92246937af26fa6467f1d7725ba2727d3a6
  
https://github.com/WebKit/WebKit/commit/f8efe92246937af26fa6467f1d7725ba2727d3a6
  Author: Yusuke Suzuki 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/SamplingProfiler.cpp

  Log Message:
  ---
  [JSC] Add some additional information bits to SamplingProfiler's StackFrame
https://bugs.webkit.org/show_bug.cgi?id=273102
rdar://126895537

Reviewed by Mark Lam.

This patch adds some additional information bits to SamplingProfiler's 
StackFrame.
For now, we record isBuiltin information.

* Source/JavaScriptCore/runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::stackTracesAsJSON):

Canonical link: https://commits.webkit.org/277854@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 31db0f: [WebGPU] runClearEncoder may clear wrong depth sli...

2024-04-22 Thread mwyrzykowski
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31db0f6ee6a433c221719a930aab848e4bd871bd
  
https://github.com/WebKit/WebKit/commit/31db0f6ee6a433c221719a930aab848e4bd871bd
  Author: Mike Wyrzykowski 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-273017-expected.txt
A LayoutTests/fast/webgpu/fuzz-273017.html
M Source/WebGPU/WebGPU/CommandEncoder.h
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  ---
  [WebGPU] runClearEncoder may clear wrong depth slice for 3D textures
https://bugs.webkit.org/show_bug.cgi?id=273017


Reviewed by Tadeu Zagallo.

When running the clear encoder for a render pass which draws no geometry,
we must use all the existing render targets otherwise the PSO won't match.

Also we weren't setting the depth slice so overlap on 3D textures was possible,
which is not allowed.

* LayoutTests/fast/webgpu/fuzz-273017-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273017.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::runClearEncoder):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::m_maxDrawCount):

Canonical link: https://commits.webkit.org/277855@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] b2b409: [WebGPU] setPipelineState fails when X32_Stencil8 ...

2024-04-22 Thread mwyrzykowski
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b2b40994e9d80dd379273b97f5e33c99fa8c0e0d
  
https://github.com/WebKit/WebKit/commit/b2b40994e9d80dd379273b97f5e33c99fa8c0e0d
  Author: Mike Wyrzykowski 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-273021-expected.txt
A LayoutTests/fast/webgpu/fuzz-273021.html
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  ---
  [WebGPU] setPipelineState fails when X32_Stencil8 attachment is used in a 
Stencil8 pipeline
https://bugs.webkit.org/show_bug.cgi?id=273021


Reviewed by Tadeu Zagallo.

Calling setPipelineState with a Stencil8 format will fail so check
if we have such a mismatch before passing the validation check.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-273021-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273021.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::clearTextureIfNeeded):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::colorDepthStencilTargetsMatch const):

Canonical link: https://commits.webkit.org/277856@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes