[webkit-changes] [WebKit/WebKit] 9b9eb5: Replace 1-bit bitfields in RenderObjectBitfields w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b9eb59716b8ed70b8ada714e1c03ee7cb0c7b23 https://github.com/WebKit/WebKit/commit/9b9eb59716b8ed70b8ada714e1c03ee7cb0c7b23 Author: Ryosuke Niwa Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h Log Message: --- Replace 1-bit bitfields in RenderObjectBitfields with RenderObjectFlag https://bugs.webkit.org/show_bug.cgi?id=266609 Reviewed by Simon Fraser. Replace macros to generate 1-bit bitfields in RenderObjectBitfields with newly introduced RenderObjectFlag enum class for simplicity and clarity. * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::layoutBlock): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::clearNeedsLayout): (WebCore::RenderObject::setPreferredLogicalWidthsDirty): (WebCore::RenderObject::invalidateContainerPreferredLogicalWidths): (WebCore::RenderObject::destroy): (WebCore::RenderObject::ensureRareData): (WebCore::RenderObject::removeRareData): * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::beingDestroyed const): (WebCore::RenderObject::everHadLayout const): (WebCore::RenderObject::childrenInline const): (WebCore::RenderObject::setChildrenInline): (WebCore::RenderObject::isAnonymous const): (WebCore::RenderObject::isFloating const): (WebCore::RenderObject::isRenderText const): (WebCore::RenderObject::isRenderBox const): (WebCore::RenderObject::isInline const): (WebCore::RenderObject::isReplacedOrInlineBlock const): (WebCore::RenderObject::isHorizontalWritingMode const): (WebCore::RenderObject::hasReflection const): (WebCore::RenderObject::isRenderFragmentedFlow const): (WebCore::RenderObject::hasOutlineAutoAncestor const): (WebCore::RenderObject::paintContainmentApplies const): (WebCore::RenderObject::hasSVGTransform const): (WebCore::RenderObject::isExcludedFromNormalLayout const): (WebCore::RenderObject::setIsExcludedFromNormalLayout): (WebCore::RenderObject::hasLayer const): (WebCore::RenderObject::selfNeedsLayout const): (WebCore::RenderObject::needsPositionedMovementLayout const): (WebCore::RenderObject::posChildNeedsLayout const): (WebCore::RenderObject::needsSimplifiedNormalFlowLayout const): (WebCore::RenderObject::normalChildNeedsLayout const): (WebCore::RenderObject::preferredLogicalWidthsDirty const): (WebCore::RenderObject::hasNonVisibleOverflow const): (WebCore::RenderObject::hasTransformRelatedProperty const): (WebCore::RenderObject::setFloating): (WebCore::RenderObject::setInline): (WebCore::RenderObject::setIsRenderText): (WebCore::RenderObject::setIsRenderBox): (WebCore::RenderObject::setReplacedOrInlineBlock): (WebCore::RenderObject::setHorizontalWritingMode): (WebCore::RenderObject::setHasNonVisibleOverflow): (WebCore::RenderObject::setHasLayer): (WebCore::RenderObject::setHasTransformRelatedProperty): (WebCore::RenderObject::setNeedsPositionedMovementLayoutBit): (WebCore::RenderObject::setNormalChildNeedsLayoutBit): (WebCore::RenderObject::setPosChildNeedsLayoutBit): (WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayoutBit): (WebCore::RenderObject::setEverHadLayout): (WebCore::RenderObject::hasRareData const): (WebCore::RenderObject::RenderObjectBitfields::flags const): (WebCore::RenderObject::RenderObjectBitfields::hasFlag const): (WebCore::RenderObject::RenderObjectBitfields::setFlag): (WebCore::RenderObject::RenderObjectBitfields::clearFlag): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::needsSimplifiedNormalFlowLayoutOnly const): (WebCore::RenderObject::needsLayout const): (WebCore::RenderObject::needsPositionedMovementLayoutOnly const): (WebCore::RenderObject::setHasRareData): Deleted. (WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields): Deleted. Canonical link: https://commits.webkit.org/272255@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d2a8e: Remove `Element::nodeNamePreservingCase`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d2a8e2a2a0264d9dc994ddd32d7da3050736e8c https://github.com/WebKit/WebKit/commit/4d2a8e2a2a0264d9dc994ddd32d7da3050736e8c Author: Ahmad Saleem Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/editing/MarkupAccumulator.cpp Log Message: --- Remove `Element::nodeNamePreservingCase` https://bugs.webkit.org/show_bug.cgi?id=266600 Reviewed by Ryosuke Niwa. Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=166250 There is no need for this method, we can just use tagQName and it is just simplification. * Source/WebCore/dom/Element.cpp: (Element::nodeNamePreservingCase): Deleted * Source/WebCore/dom/Element.h: 'nodeNamePreservingCase' definition deleted * Source/WebCore/editing/MarkupAccumulator.cpp: (MarkupAccumulator::appendEndTag): (MarkupAccumulator::appendOpenTag): Canonical link: https://commits.webkit.org/272256@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a44e65: Unreviewed, reverting 272034@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a44e65393fd360dd41b3ceaec1ae0c80547374df https://github.com/WebKit/WebKit/commit/a44e65393fd360dd41b3ceaec1ae0c80547374df Author: Commit Queue Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/JavaScriptCore/assembler/ARM64Assembler.h M Source/JavaScriptCore/assembler/AssemblerBuffer.h M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h Log Message: --- Unreviewed, reverting 272034@main. https://bugs.webkit.org/show_bug.cgi?id=266621 SP3 0.5% regression Reverted changeset: "Inline some functions used in copyCompactAndLinkCode" https://bugs.webkit.org/show_bug.cgi?id=266362 https://commits.webkit.org/272034@main Canonical link: https://commits.webkit.org/272257@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 587398: [WPE][GStreamer] GLib-ERROR: Creating pipes for GW...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 587398a109bd8d56e4fd51a5e4baa5f1ddc9c484 https://github.com/WebKit/WebKit/commit/587398a109bd8d56e4fd51a5e4baa5f1ddc9c484 Author: Vitaly Dyachkov Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE][GStreamer] GLib-ERROR: Creating pipes for GWakeup: Too many open files https://bugs.webkit.org/show_bug.cgi?id=266577 Unreviewed test gardening. * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/272258@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 91e45c: [WPE][GStreamer] GStreamer-CRITICAL: gst_poll_writ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 91e45c495707272e5383321fd291118c7a020cdb https://github.com/WebKit/WebKit/commit/91e45c495707272e5383321fd291118c7a020cdb Author: Vitaly Dyachkov Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE][GStreamer] GStreamer-CRITICAL: gst_poll_write_control: assertion 'set != NULL' failed https://bugs.webkit.org/show_bug.cgi?id=266573 Unreviewed test gardening. * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/272259@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
webkit-changes@lists.webkit.org
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bf19131d8d08e3ff5751afb0e687ef16d5d4d73f https://github.com/WebKit/WebKit/commit/bf19131d8d08e3ff5751afb0e687ef16d5d4d73f Author: Vitaly Dyachkov Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE] ASSERTION FAILED: m_thread.ptr() == &Thread::current() https://bugs.webkit.org/show_bug.cgi?id=266624 Unreviewed test gardening. * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/272260@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d53c21: Enable assertion invalidation callbacks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d53c21da9b54ec190827f579db2daafff45a38fd https://github.com/WebKit/WebKit/commit/d53c21da9b54ec190827f579db2daafff45a38fd Author: Per Arne Vollan Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/Platform/cocoa/AssertionCapability.mm Log Message: --- Enable assertion invalidation callbacks https://bugs.webkit.org/show_bug.cgi?id=266472 Reviewed by Brent Fulgham. * Source/WebKit/Platform/cocoa/AssertionCapability.mm: Canonical link: https://commits.webkit.org/272261@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec311d: [WPE] WPE Platform: fix a crash when handling wayl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec311d6d964b58d9d62362b5d64d84fbb54f7e19 https://github.com/WebKit/WebKit/commit/ec311d6d964b58d9d62362b5d64d84fbb54f7e19 Author: Carlos Garcia Campos Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp Log Message: --- [WPE] WPE Platform: fix a crash when handling wayland DMA-BUF feedback with some compositors https://bugs.webkit.org/show_bug.cgi?id=266622 Reviewed by Alejandro G. Castro. Some compositors like weston don't sent the format table on every feedback message, but only the first time. Handle that case in main device message by stealing the format table from the previous committed feedback. * Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp: (DMABufFeedback::FormatTable::FormatTable): (DMABufFeedback::FormatTable::~FormatTable): (DMABufFeedback::create): (DMABufFeedback::DMABufFeedback): (DMABufFeedback::format): (DMABufFeedback::~DMABufFeedback): Deleted. Canonical link: https://commits.webkit.org/272262@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 98d2c9: REGRESSION (iOS 17): Front and Back Facing Camera ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 98d2c991bb5de85a4291d854df8c19b9ce9cdbd4 https://github.com/WebKit/WebKit/commit/98d2c991bb5de85a4291d854df8c19b9ce9cdbd4 Author: Kimmo Kinnunen Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/cv/GraphicsContextGLCVCocoa.cpp M Source/WebCore/platform/graphics/cv/GraphicsContextGLCVCocoa.h Log Message: --- REGRESSION (iOS 17): Front and Back Facing Camera Stutter https://bugs.webkit.org/show_bug.cgi?id=265556 rdar://119076271 Reviewed by Youenn Fablet. Some platforms appear to construct new IOSurface contents on top of existing IOSurface instance and metadata. Video texture upload was skipped if the IOSurface object instance pointer and seed matched, but on some platform it appears that camera produces such new surfaces with the surface id changing. Fix by adding surface id to the cache key. * Source/WebCore/platform/graphics/cv/GraphicsContextGLCVCocoa.cpp: (WebCore::GraphicsContextGLCVCocoa::copyVideoSampleToTexture): * Source/WebCore/platform/graphics/cv/GraphicsContextGLCVCocoa.h: Canonical link: https://commits.webkit.org/272263@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 35c1d1: Unreviewed, reverting 272261@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35c1d1b00df1b7c2859a43d9f2e479b0302252f8 https://github.com/WebKit/WebKit/commit/35c1d1b00df1b7c2859a43d9f2e479b0302252f8 Author: Commit Queue Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/Platform/cocoa/AssertionCapability.mm Log Message: --- Unreviewed, reverting 272261@main. https://bugs.webkit.org/show_bug.cgi?id=266633 Introduced build issue Reverted changeset: "Enable assertion invalidation callbacks" https://bugs.webkit.org/show_bug.cgi?id=266472 https://commits.webkit.org/272261@main Canonical link: https://commits.webkit.org/272264@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ceaf6d: Simplify 'targetNode' function from HitTestResult
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ceaf6d34ab11f187137f68e9127c99cd2678a752 https://github.com/WebKit/WebKit/commit/ceaf6d34ab11f187137f68e9127c99cd2678a752 Author: Ahmad Saleem Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/rendering/HitTestResult.cpp M Source/WebCore/rendering/HitTestResult.h Log Message: --- Simplify 'targetNode' function from HitTestResult https://bugs.webkit.org/show_bug.cgi?id=265891 rdar://problem/119566622 Reviewed by Tim Nguyen. Merge: https://chromium.googlesource.com/chromium/blink/+/ceea705be631379fd0d012d4f20128ad3e7296ea This patch is to simplify 'targetNode' function to return 'innerNode' rather than old code introduced in 18736@main, which didn't make sense: if a node is disconnected, its parent element also has to be disconnected, which means most of the logic in HitTestResult::targetNode was just dead code. * Source/WebCore/rendering/HitTestResult.cpp: (HitTestResult::targetNode): Deleted * Source/WebCore/rendering/HitTestResult.h: Inlined 'targetNode' to return 'innerNode' Canonical link: https://commits.webkit.org/272265@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7412c3: Add NativeImageBackend to support GPUP NativeImage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7412c32e31ca3a1627bc7a13ab915b919ff1af00 https://github.com/WebKit/WebKit/commit/7412c32e31ca3a1627bc7a13ab915b919ff1af00 Author: Kimmo Kinnunen Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/NativeImage.cpp M Source/WebCore/platform/graphics/NativeImage.h M Source/WebCore/platform/graphics/cairo/NativeImageCairo.cpp M Source/WebCore/platform/graphics/cg/NativeImageCG.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp Log Message: --- Add NativeImageBackend to support GPUP NativeImage https://bugs.webkit.org/show_bug.cgi?id=266216 rdar://119489321 Reviewed by Matt Woodrow. Add NativeImageBackend interface that future work can use to implement NativeImage that exists in GPUP. NativeImage instances are held as members of objects. Thus the interface cannot be based on NativeImage itself, because this would mean that transitioning from local to remote would need the held objects replaced. Instead, make the polymorphic extension point the "backend", similar to current ImageBuffer. Reland after revert. Revert targeted 271976@main and this was built on that. Land without the dependency to 271976@main. * Source/WebCore/platform/graphics/NativeImage.cpp: (WebCore::PlatformImageNativeImageBackend::platformImage const): (WebCore::PlatformImageNativeImageBackend::PlatformImageNativeImageBackend): (WebCore::NativeImage::create): (WebCore::NativeImage::NativeImage): (WebCore::NativeImage::platformImage const): (WebCore::NativeImage::replaceContents): (WebCore::NativeImage::setPlatformImage): Deleted. * Source/WebCore/platform/graphics/NativeImage.h: * Source/WebCore/platform/graphics/cg/NativeImageCG.cpp: (WebCore::NativeImage::create): (WebCore::NativeImage::size const): (WebCore::NativeImage::hasAlpha const): (WebCore::NativeImage::singlePixelSolidColor const): (WebCore::NativeImage::colorSpace const): (WebCore::NativeImage::clearSubimages): * Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp: (WebKit::createShareableBitmapFromNativeImage): Canonical link: https://commits.webkit.org/272266@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4be388: Ruby style cleanups
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4be388cadb468d7b951a79e5ea6940a3aec607e6 https://github.com/WebKit/WebKit/commit/4be388cadb468d7b951a79e5ea6940a3aec607e6 Author: Antti Koivisto Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/fast/ruby/ruby-block-style-not-updated-expected.txt M Source/WebCore/html/RubyElement.cpp M Source/WebCore/html/RubyTextElement.cpp M Source/WebCore/style/StyleAdjuster.cpp Log Message: --- Ruby style cleanups https://bugs.webkit.org/show_bug.cgi?id=266623 rdar://119856171 Reviewed by Tim Nguyen and Alan Baradlay. * LayoutTests/fast/ruby/ruby-block-style-not-updated-expected.txt: * Source/WebCore/html/RubyElement.cpp: (WebCore::RubyElement::createElementRenderer): * Source/WebCore/html/RubyTextElement.cpp: (WebCore::RubyTextElement::createElementRenderer): Ensure we can't create legacy ruby renderers with css ruby enabled. * Source/WebCore/style/StyleAdjuster.cpp: (WebCore::Style::forceBidiIsolationForRuby): Rename and include all cases to switch. (WebCore::Style::Adjuster::adjust const): Remove some no-op code. (WebCore::Style::adjustUnicodeBidiForRuby): Deleted. Canonical link: https://commits.webkit.org/272267@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fc2b98: [WPE] WPE Platform: make sure we release all wayla...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fc2b98d725a247025bd6c91e80d20153d9b950dc https://github.com/WebKit/WebKit/commit/fc2b98d725a247025bd6c91e80d20153d9b950dc Author: Carlos Garcia Campos Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/WPEPlatform/wpe/wayland/WPEDisplayWayland.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandOutput.cpp Log Message: --- [WPE] WPE Platform: make sure we release all wayland resources before the display https://bugs.webkit.org/show_bug.cgi?id=266626 Reviewed by Michael Catanzaro. The display is explicitly released in the dispose method, but other resources wrapped by smart pointers are released later in the finalize. Also use wl_output_release instead of wl_output_destroy when available. * Source/WebKit/WPEPlatform/wpe/wayland/WPEDisplayWayland.cpp: (wpeDisplayWaylandDispose): * Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandOutput.cpp: (WPE::WaylandOutput::~WaylandOutput): Canonical link: https://commits.webkit.org/272268@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d82d99: Remove most EnumTraits specializations under WebKi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d82d99d57d3f36d727cbc1e6c60155a42d81818a https://github.com/WebKit/WebKit/commit/d82d99d57d3f36d727cbc1e6c60155a42d81818a Author: Žan Doberšek Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/Authentication/AuthenticationChallengeDisposition.h A Source/WebKit/Shared/Authentication/AuthenticationChallengeDisposition.serialization.in M Source/WebKit/Shared/BackgroundFetchChange.h A Source/WebKit/Shared/BackgroundFetchChange.serialization.in M Source/WebKit/Shared/CacheModel.h A Source/WebKit/Shared/CacheModel.serialization.in M Source/WebKit/Shared/CoordinateSystem.h A Source/WebKit/Shared/CoordinateSystem.serialization.in M Source/WebKit/Shared/DragControllerAction.h A Source/WebKit/Shared/DragControllerAction.serialization.in M Source/WebKit/Shared/FocusedElementInformation.h M Source/WebKit/Shared/FocusedElementInformation.serialization.in M Source/WebKit/Shared/InspectorExtensionTypes.h A Source/WebKit/Shared/InspectorExtensionTypes.serialization.in M Source/WebKit/Shared/LayerTreeContext.h M Source/WebKit/Shared/LayerTreeContext.serialization.in M Source/WebKit/Shared/MediaPlaybackState.h A Source/WebKit/Shared/MediaPlaybackState.serialization.in M Source/WebKit/Shared/ResourceLoadInfo.h M Source/WebKit/Shared/SyntheticEditingCommandType.h A Source/WebKit/Shared/SyntheticEditingCommandType.serialization.in M Source/WebKit/Shared/TextRecognitionUpdateResult.h A Source/WebKit/Shared/TextRecognitionUpdateResult.serialization.in M Source/WebKit/Shared/UndoOrRedo.h A Source/WebKit/Shared/UndoOrRedo.serialization.in M Source/WebKit/Shared/VideoCodecType.h A Source/WebKit/Shared/VideoCodecType.serialization.in M Source/WebKit/Shared/WebGPU/WebGPUBindGroupEntry.h M Source/WebKit/Shared/WebGPU/WebGPUBindGroupEntry.serialization.in M Source/WebKit/Shared/WebsiteAutoplayPolicy.h A Source/WebKit/Shared/WebsiteAutoplayPolicy.serialization.in M Source/WebKit/Shared/WebsiteAutoplayQuirk.h A Source/WebKit/Shared/WebsiteAutoplayQuirk.serialization.in M Source/WebKit/Shared/WebsiteData/UnifiedOriginStorageLevel.h A Source/WebKit/Shared/WebsiteData/UnifiedOriginStorageLevel.serialization.in M Source/WebKit/Shared/WebsitePopUpPolicy.h A Source/WebKit/Shared/WebsitePopUpPolicy.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Remove most EnumTraits specializations under WebKit/Shared https://bugs.webkit.org/show_bug.cgi?id=266587 Reviewed by Chris Dumez. Remove the majority of EnumTraits specializations under WebKit/Shared in favor of serialization specifications that will be used to automatically generate the relevant enum validation code. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/Authentication/AuthenticationChallengeDisposition.h: * Source/WebKit/Shared/Authentication/AuthenticationChallengeDisposition.serialization.in: Copied from Source/WebKit/Shared/LayerTreeContext.serialization.in. * Source/WebKit/Shared/BackgroundFetchChange.h: * Source/WebKit/Shared/BackgroundFetchChange.serialization.in: Copied from Source/WebKit/Shared/LayerTreeContext.serialization.in. * Source/WebKit/Shared/CacheModel.h: * Source/WebKit/Shared/CacheModel.serialization.in: Copied from Source/WebKit/Shared/LayerTreeContext.serialization.in. * Source/WebKit/Shared/CoordinateSystem.h: * Source/WebKit/Shared/CoordinateSystem.serialization.in: Copied from Source/WebKit/Shared/LayerTreeContext.serialization.in. * Source/WebKit/Shared/DragControllerAction.h: * Source/WebKit/Shared/DragControllerAction.serialization.in: Copied from Source/WebKit/Shared/LayerTreeContext.serialization.in. * Source/WebKit/Shared/FocusedElementInformation.h: * Source/WebKit/Shared/FocusedElementInformation.serialization.in: * Source/WebKit/Shared/InspectorExtensionTypes.h: * Source/WebKit/Shared/InspectorExtensionTypes.serialization.in: Copied from Source/WebKit/Shared/LayerTreeContext.serialization.in. * Source/WebKit/Shared/LayerTreeContext.h: * Source/WebKit/Shared/LayerTreeContext.serialization.in: * Source/WebKit/Shared/MediaPlaybackState.h: * Source/WebKit/Shared/MediaPlaybackState.serialization.in: Copied from Source/WebKit/Shared/LayerTreeContext.serialization.in. * Source/WebKit/Shared/ResourceLoadInfo.h: * Source/WebKit/Shared/SyntheticEditingCommandType.h: * Source/WebKit/Shared/SyntheticEditingCommandType.serialization.in: Copied from Source/WebKit/Shared/LayerTreeContext.serialization.in. * Source/WebKit/Shared/TextRecognitionUpdateResult.h: * Source/WebKit/Shared/TextRecognitionUpdateResult.serialization.in:
[webkit-changes] [WebKit/WebKit] 27999f: Devirtualize even more type checks for RenderObject
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27999fcc9508fc5c531bccb64e3c147a5ea94cb0 https://github.com/WebKit/WebKit/commit/27999fcc9508fc5c531bccb64e3c147a5ea94cb0 Author: Ryosuke Niwa Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderLineBreak.cpp M Source/WebCore/rendering/RenderLineBreak.h M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/svg/RenderSVGBlock.cpp M Source/WebCore/rendering/svg/RenderSVGBlock.h M Source/WebCore/rendering/svg/RenderSVGContainer.cpp M Source/WebCore/rendering/svg/RenderSVGContainer.h M Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp M Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.h M Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp M Source/WebCore/rendering/svg/RenderSVGShape.cpp M Source/WebCore/rendering/svg/RenderSVGShape.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h Log Message: --- Devirtualize even more type checks for RenderObject https://bugs.webkit.org/show_bug.cgi?id=266615 Reviewed by Antti Koivisto. Devirtualize the remaining type checks for SVG by introducing SVG specific flags stored in the unused 8-bit space left after m_type. Utilize the same mechanism / same bits to store wbr-ness of RenderLineBreak as well. * Source/WebCore/rendering/RenderLineBreak.cpp: (WebCore::m_cachedLineHeight): (WebCore::m_isWBR): Deleted. * Source/WebCore/rendering/RenderLineBreak.h: * Source/WebCore/rendering/RenderObject.cpp: * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::isLegacyRenderSVGModelObject const): (WebCore::RenderObject::isRenderSVGModelObject const): (WebCore::RenderObject::svgFlags const): (WebCore::RenderObject::setSVGFlags): (WebCore::RenderObject::isRenderSVGBlock const): (WebCore::RenderObject::isRenderSVGContainer const): (WebCore::RenderObject::isLegacyRenderSVGContainer const): (WebCore::RenderObject::isLegacyRenderSVGHiddenContainer const): (WebCore::RenderObject::isRenderSVGShape const): (WebCore::RenderObject::isLegacyRenderSVGShape const): (WebCore::RenderObject::isLegacyRenderSVGResourceContainer const): (WebCore::RenderObject::isRenderSVGResourceContainer const): (WebCore::RenderObject::isWBR const): (WebCore::RenderObject::lineBreakFlags const): (WebCore::RenderObject::setLineBreakFlags): * Source/WebCore/rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::RenderSVGBlock): * Source/WebCore/rendering/svg/RenderSVGBlock.h: * Source/WebCore/rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): * Source/WebCore/rendering/svg/RenderSVGContainer.h: (WebCore::RenderSVGContainer::RenderSVGContainer): * Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer): * Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer): * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::RenderSVGModelObject): * Source/WebCore/rendering/svg/RenderSVGModelObject.h: (WebCore::RenderSVGModelObject::RenderSVGModelObject): * Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): * Source/WebCore/rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::RenderSVGShape): * Source/WebCore/rendering/svg/RenderSVGShape.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp: (WebCore::LegacyRenderSVGContainer::LegacyRenderSVGContainer): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.h: (WebCore::LegacyRenderSVGContainer::LegacyRenderSVGContainer): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.cpp: (WebCore::LegacyRenderSVGHiddenContainer::LegacyRenderSVGHiddenContainer): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.h: (WebCore::LegacyRenderSVGHiddenContainer::LegacyRenderSVGHiddenContainer): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp: (WebCore::LegacyRenderSVGModelO
[webkit-changes] [WebKit/WebKit] 9d0537: [Deprecated flexbox] Do not try to float position ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9d05374a137f8700373f1f22c0707b152dfe6cd6 https://github.com/WebKit/WebKit/commit/9d05374a137f8700373f1f22c0707b152dfe6cd6 Author: Alan Baradlay Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A LayoutTests/fast/flexbox/deprecated-flex-box-with-float-flex-item-expected.html A LayoutTests/fast/flexbox/deprecated-flex-box-with-float-flex-item.html M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h M Source/WebCore/style/StyleAdjuster.cpp Log Message: --- [Deprecated flexbox] Do not try to float position direct inflow children https://bugs.webkit.org/show_bug.cgi?id=266599 Reviewed by Antti Koivisto. Direct children with "float: left/right" are (correctly) laid out as if they were not float positioned. However at paint time, we treat them as floats but don't find them in RenderBlockFlow::m_floatingObjects (since we don't populate this list in flex layout). * LayoutTests/TestExpectations: * LayoutTests/fast/flexbox/deprecated-flex-box-with-float-flex-item-expected.html: Added. * LayoutTests/fast/flexbox/deprecated-flex-box-with-float-flex-item.html: Added. * Source/WebCore/style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const): Canonical link: https://commits.webkit.org/272271@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ec2f0: Remove IDL duplication in RemoteDOMWindow.idl
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ec2f0dd13a9084b135c7fe5574a91073bc6532a https://github.com/WebKit/WebKit/commit/6ec2f0dd13a9084b135c7fe5574a91073bc6532a Author: Alex Christensen Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/bindings/js/JSRemoteDOMWindowCustom.cpp M Source/WebCore/page/DOMWindow.idl M Source/WebCore/page/LocalDOMWindow.idl M Source/WebCore/page/RemoteDOMWindow.idl Log Message: --- Remove IDL duplication in RemoteDOMWindow.idl https://bugs.webkit.org/show_bug.cgi?id=266617 rdar://119851333 Reviewed by Chris Dumez. RemoteDOMWindow.idl used to have some of the functions that LocalDOMWindow.idl had. This moves them to a shared location and removes duplicate definitions, preferring the LocalDOMWindow definition if there were any differences. * Source/WebCore/bindings/js/JSRemoteDOMWindowCustom.cpp: (WebCore::JSRemoteDOMWindow::self const): (WebCore::JSRemoteDOMWindow::window const): (WebCore::JSRemoteDOMWindow::frames const): * Source/WebCore/page/DOMWindow.idl: * Source/WebCore/page/LocalDOMWindow.idl: * Source/WebCore/page/RemoteDOMWindow.idl: Canonical link: https://commits.webkit.org/272272@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f504ea: Fix memory leak in WKWebsiteDataStore.setProxyConf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f504ea5afe92d7ab05328284f8138421c3bac55c https://github.com/WebKit/WebKit/commit/f504ea5afe92d7ab05328284f8138421c3bac55c Author: Alex Christensen Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm Log Message: --- Fix memory leak in WKWebsiteDataStore.setProxyConfigurations https://bugs.webkit.org/show_bug.cgi?id=266616 rdar://119850830 Reviewed by Wenson Hsieh. * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore setProxyConfigurations:]): Canonical link: https://commits.webkit.org/272273@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b73bcf: Fix some potential debug assertions in WebCoreNSUR...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b73bcfa4b339b6caa674cf8f449ff34a1c739467 https://github.com/WebKit/WebKit/commit/b73bcfa4b339b6caa674cf8f449ff34a1c739467 Author: Alex Christensen Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h M Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm Log Message: --- Fix some potential debug assertions in WebCoreNSURLSession https://bugs.webkit.org/show_bug.cgi?id=266618 rdar://115087609 Reviewed by Chris Dumez. cancel and suspend can be called on any thread. If they are called on a background thread and the task finishes between when the selector is called on the background thread and the callOnMainThread lambda is called, then things can get into a bad state and we can hit the debug assertion in taskCompleted: indicating that a task was not in the set. To fix this, I add some state checks in cancel and suspend. Because _state can be written to from a background thread in cancel, I made the ivar std::atomic. I add WTF_GUARDED_BY_LOCK to prevent future issues around use of _dataTasks and ASSERT(isMainThread()); around use of _origins to verify its thread safety. * Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h: * Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm: (-[WebCoreNSURLSession task:addSecurityOrigin:]): (-[WebCoreNSURLSession isCrossOrigin:]): (-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]): (-[WebCoreNSURLSessionDataTask state]): (-[WebCoreNSURLSessionDataTask cancel]): (-[WebCoreNSURLSessionDataTask suspend]): (-[WebCoreNSURLSessionDataTask resume]): (-[WebCoreNSURLSessionDataTask _resource:loadFinishedWithError:metrics:]): Canonical link: https://commits.webkit.org/272274@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 09171c: REGRESSION (271643@main): [ Monterey+ wk2 Release ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 09171c10409c98d03cdb052de006780c66ce4ba0 https://github.com/WebKit/WebKit/commit/09171c10409c98d03cdb052de006780c66ce4ba0 Author: Aditya Keerthi Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/fast/selectors/selection-window-inactive-stroke-color.html M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderText.h M Source/WebCore/rendering/TextPaintStyle.cpp Log Message: --- REGRESSION (271643@main): [ Monterey+ wk2 Release x86_64 ] fast/selectors/selection-window-inactive-stroke-color.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=266508 rdar://119737142 Reviewed by Antti Koivisto. 271643@main modified `::selection` pseudo-style logic to use `getCachedPseudoStyle` rather than `getUncachedPseudoStyle`, as `::grammar-error` and `::spelling-error` were introduced. However, in WebKit, `::selection` supports the non-standard `:window-inactive`. Since it has the concept of changing state, it must use `getUncachedPseudoStyle`. Fix by reverting the parts of 271643@main which affected `::selection`. This was not caught by EWS, since `selection-window-inactive-stroke-color.html` has already been marked as a flaky failure. Fuzzy data has been added to maintain test coverage. The reason for fuzziness should be investigated separately in https://bugs.webkit.org/show_bug.cgi?id=216394. * LayoutTests/fast/selectors/selection-window-inactive-stroke-color.html: * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::rendererForPseudoStyleAcrossShadowBoundary const): (WebCore::RenderElement::textSegmentPseudoStyle const): (WebCore::RenderElement::selectionColor const): (WebCore::RenderElement::selectionPseudoStyle const): (WebCore::RenderElement::selectionBackgroundColor const): * Source/WebCore/rendering/RenderElement.h: * Source/WebCore/rendering/RenderText.h: (WebCore::RenderText::selectionPseudoStyle const): * Source/WebCore/rendering/TextPaintStyle.cpp: (WebCore::computeTextSelectionPaintStyle): Canonical link: https://commits.webkit.org/272275@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 57fdd1: [css-contain][css-grid] Relax size containment con...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 57fdd17822df399a4c26a0a3f3ad8342051c1eff https://github.com/WebKit/WebKit/commit/57fdd17822df399a4c26a0a3f3ad8342051c1eff Author: Sammy Gill Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-grid-indefinite-height-min-height-flex-row-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-grid-indefinite-height-min-height-flex-row.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-size-grid-indefinite-height-min-height-flex-row-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-size-grid-indefinite-height-min-height-flex-row.html M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp M Source/WebCore/rendering/RenderGrid.h Log Message: --- [css-contain][css-grid] Relax size containment constraints on "Expand Flexible Tracks," portion of grid track sizing algorithm. https://bugs.webkit.org/show_bug.cgi?id=266506 rdar://119736473 Reviewed by Alan Baradlay. This patch expands upon 272085@main which fixed a bug related to an interaction between grid layout and size containment. In particular, the patch allowed the grid track sizing algorithm to stretch auto sized tracks even during size containment. For the exact same reason we also want to relax the size containment constraint imposed upon the grid track sizing algorithm to allow it to perform portions of the "Expand Flexible Tracks," section. The only portion of this step we want to skip is when we are computing the flex fraction and the free space is indefinite, since this is the only part of this section that takes into consideration the grid's contents. To compute the flex fraction in this case, the spec says that it is the maximum of: - For each flexible track, if the flexible track’s flex factor is greater than one, the result of dividing the track’s base size by its flex factor; otherwise, the track’s base size. - For each grid item that crosses a flexible track, the result of finding the size of an fr using all the grid tracks that the item crosses and a space to fill of the item’s max-content contribution. During the size containment "Sizing as if empty," phase we can completely take into consideration the first computation, but we should not compute or consider the second. https://drafts.csswg.org/css-contain/#containment-size https://drafts.csswg.org/css-grid-2/#algo-flex-tracks * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-grid-indefinite-height-min-height-flex-row-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-grid-indefinite-height-min-height-flex-row.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-size-grid-indefinite-height-min-height-flex-row-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-size-grid-indefinite-height-min-height-flex-row.html: Added. * Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp: (WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const): (WebCore::GridTrackSizingAlgorithm::run): * Source/WebCore/rendering/RenderGrid.h: Canonical link: https://commits.webkit.org/272276@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 07319b: [scroll-anchoring] findAnchorElementRecursive shou...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07319b820ce70ac6e01093ed0c356c2e1b0eb25d https://github.com/WebKit/WebKit/commit/07319b820ce70ac6e01093ed0c356c2e1b0eb25d Author: Nikolaos Mouchtaris Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/position-change-heuristic-in-nested-scroll-box-expected.txt M Source/WebCore/page/scrolling/ScrollAnchoringController.cpp M Source/WebCore/rendering/RenderObject.cpp Log Message: --- [scroll-anchoring] findAnchorElementRecursive should descend into subscrollers if its not maintaining a scroll anchor https://bugs.webkit.org/show_bug.cgi?id=262557 rdar://116411088 Reviewed by Simon Fraser. We should only disallow descending into subscrollers if the subscroller is currently maintaining a scroll anchor. * LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/position-change-heuristic-in-nested-scroll-box-expected.txt: * Source/WebCore/page/scrolling/ScrollAnchoringController.cpp: (WebCore::elementForScrollableArea): (WebCore::ScrollAnchoringController::invalidateAnchorElement): (WebCore::canDescendIntoElement): (WebCore::ScrollAnchoringController::examineCandidate): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::findScrollAnchoringControllerForRenderer): Canonical link: https://commits.webkit.org/272277@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da4254: CSS line clamp together with float not working cor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da42549d3773aa043610e1db4e578ef79dc716d5 https://github.com/WebKit/WebKit/commit/da42549d3773aa043610e1db4e578ef79dc716d5 Author: Alan Baradlay Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A LayoutTests/fast/flexbox/line-clamp-with-float-expected.html A LayoutTests/fast/flexbox/line-clamp-with-float.html M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h M Source/WebCore/layout/formattingContexts/inline/InlineLineTypes.h M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp Log Message: --- CSS line clamp together with float not working correctly https://bugs.webkit.org/show_bug.cgi?id=266018 Reviewed by Antti Koivisto. 1. Line clamping should ignore lines with no inline content. It usually happens when floats don't let us put content on the candidate line (see numberOfLinesWithInlineContent) 2. Move lineEndingEllipsisPolicy to InlineFormattingUtils and use numberOfLinesWithInlineContent as input to decide of the ellipsis policy 3. LineEndingEllipsisPolicy::No -> LineEndingEllipsisPolicy::NoEllipsis 4. While line-clamp state is valid across block container boundaries, we should not apply it on floats/out-of-flow content (i.e. do not count lines inside floats) 5. RenderDeprecatedFlexibleBox::applyModernLineClamp should only return null_opt when we couldn't manage to run line clamping at all. * LayoutTests/fast/flexbox/line-clamp-with-float-expected.html: Added. * LayoutTests/fast/flexbox/line-clamp-with-float.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::lineLayout): (WebCore::Layout::InlineFormattingContext::createDisplayContentForInlineContent): (WebCore::Layout::lineEndingEllipsisPolicy): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h: * Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp: (WebCore::Layout::InlineFormattingUtils::lineEndingEllipsisPolicy): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h: * Source/WebCore/layout/formattingContexts/inline/InlineLineTypes.h: * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp: (WebCore::Layout::InlineDisplayLineBuilder::trailingEllipsisVisualRectAfterTruncation): * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::layoutModernLines): * Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): (WebCore::getHeightForLineCount): (WebCore::RenderDeprecatedFlexibleBox::applyModernLineClamp): Canonical link: https://commits.webkit.org/272278@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 30a915: [UnifiedPDF] Going from Single Page to Two Pages d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 30a915b5c386b5ecfc81b82be6d52072e8e6d108 https://github.com/WebKit/WebKit/commit/30a915b5c386b5ecfc81b82be6d52072e8e6d108 Author: Simon Fraser Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Going from Single Page to Two Pages doesn't reset the scroll position https://bugs.webkit.org/show_bug.cgi?id=266610 rdar://119520473 Reviewed by Tim Horton. When changing from the single page to the 2-page view in the UnifiedPDF viewer, the document can get shorter, so we may have to adjust the scroll position. Do this after PDF layout. In order to set the scroll position, we need to implement `requestScrollToPosition()` to talk to the relevant ScrollingCoordinator. Not testable because you can't change the view mode in a test. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::updateScrollingExtents): (WebKit::UnifiedPDFPlugin::requestScrollToPosition): (WebKit::toWebCoreCursorType): Canonical link: https://commits.webkit.org/272279@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b77e48: Adopt dynamicDowncast<>() further in WebCore
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b77e480dcfa67013da8a5302a103095074f2f0cf https://github.com/WebKit/WebKit/commit/b77e480dcfa67013da8a5302a103095074f2f0cf Author: Chris Dumez Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/animation/AcceleratedTimeline.cpp M Source/WebCore/animation/AnimationEffect.cpp M Source/WebCore/animation/AnimationTimeline.cpp M Source/WebCore/animation/CSSAnimation.cpp M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/animation/DocumentTimeline.cpp M Source/WebCore/animation/KeyframeEffect.cpp M Source/WebCore/animation/ViewTimeline.cpp M Source/WebCore/animation/WebAnimation.cpp M Source/WebCore/animation/WebAnimationUtilities.cpp M Source/WebCore/css/TransformFunctions.cpp M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/style/StyleBuilder.cpp M Source/WebCore/style/StyleBuilderConverter.h M Source/WebCore/style/StyleBuilderCustom.h M Source/WebCore/style/StyleBuilderState.cpp M Source/WebCore/style/StyleInvalidator.cpp M Source/WebCore/style/StylePendingResources.cpp M Source/WebCore/style/StyleResolveForFontRaw.cpp M Source/WebCore/style/StyleResolver.cpp M Source/WebCore/style/StyleScope.cpp M Source/WebCore/style/StyleSharingResolver.cpp M Source/WebCore/style/Styleable.cpp M Source/WebCore/style/Styleable.h M Source/WebCore/svg/SVGAnimateElementBase.h M Source/WebCore/svg/SVGComponentTransferFunctionElementInlines.h M Source/WebCore/svg/SVGDocument.h M Source/WebCore/svg/SVGElementInlines.h M Source/WebCore/svg/SVGGeometryElement.h M Source/WebCore/svg/SVGGradientElement.h M Source/WebCore/svg/SVGGraphicsElement.h M Source/WebCore/svg/SVGLengthContext.cpp M Source/WebCore/svg/SVGLengthValue.cpp M Source/WebCore/svg/SVGLinearGradientElement.cpp M Source/WebCore/svg/SVGLocatable.cpp M Source/WebCore/svg/SVGMPathElement.cpp M Source/WebCore/svg/SVGPathElement.cpp M Source/WebCore/svg/SVGPolyElement.h M Source/WebCore/svg/SVGRadialGradientElement.cpp M Source/WebCore/svg/SVGSVGElement.cpp M Source/WebCore/svg/SVGTextContentElement.cpp M Source/WebCore/svg/SVGTextContentElement.h M Source/WebCore/svg/SVGUseElement.cpp M Source/WebCore/svg/animation/SVGSMILElement.cpp M Source/WebCore/svg/animation/SVGSMILElement.h M Source/WebCore/svg/graphics/SVGImage.cpp M Source/WebCore/svg/properties/SVGPropertyAnimator.h Log Message: --- Adopt dynamicDowncast<>() further in WebCore https://bugs.webkit.org/show_bug.cgi?id=266640 Reviewed by Ryosuke Niwa. * Source/WebCore/animation/AcceleratedTimeline.cpp: (WebCore::AcceleratedTimeline::updateEffectStacks): * Source/WebCore/animation/AnimationEffect.cpp: (WebCore::AnimationEffect::bindingsUpdateTiming): (WebCore::AnimationEffect::progressUntilNextStep const): * Source/WebCore/animation/AnimationTimeline.cpp: (WebCore::AnimationTimeline::animationTimingDidChange): * Source/WebCore/animation/CSSAnimation.cpp: (WebCore::CSSAnimation::keyframesRuleDidChange): (WebCore::CSSAnimation::updateKeyframesIfNeeded): * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::blendFunc): * Source/WebCore/animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::animationCanBeRemoved): * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::getKeyframes): (WebCore::KeyframeEffect::setBindingsKeyframes): (WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes): (WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes): (WebCore::isLinearTimingFunctionWithPoints): (WebCore::KeyframeEffect::computeSomeKeyframesUseStepsOrLinearTimingFunctionWithPoints): (WebCore::KeyframeEffect::setAnimatedPropertiesInStyle): (WebCore::KeyframeEffect::computeExtentOfTransformAnimation const): (WebCore::KeyframeEffect::progressUntilNextStep const): (WebCore::KeyframeEffect::timingFunctionForKeyframe const): * Source/WebCore/animation/ViewTimeline.cpp: (WebCore::ViewTimeline::createFromCSSValue): * Source/WebCore/animation/WebAnimation.cpp: (WebCore::WebAnimation::setEffectInternal): (WebCore::WebAnimation::setTimeline): (WebCore::WebAnimation::acceleratedStateDidChange): (WebCore::WebAnimation::updateRelevance): (WebCore::WebAnimation::isReplaceable const): (WebCore::WebAnimation::commitStyles): * Source/WebCore/animation/WebAnimationUtilities.cpp: (WebCore::compareAnimationsByCompositeOrder): (WebCore::compareDeclarativeAnimationEvents): * Source/WebCore/css/TransformFunctions.cpp: (WebCore::transformForValue): * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeFontFeatureValuesRule): * Source/WebCore/style/StyleBuilder.cpp: (WebCore::Style::Builder::applyProperty): (WebCore::Style::Builder::resolveVariableReferences): * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter:
[webkit-changes] [WebKit/WebKit] 3a9c4b: Fix file-url based tests not working with runInCro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a9c4b78c818661e34cd0afa76f07faef656a52d https://github.com/WebKit/WebKit/commit/3a9c4b78c818661e34cd0afa76f07faef656a52d Author: Pascoe Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Tools/Scripts/webkitpy/layout_tests/servers/aliases.json M Tools/Scripts/webkitpy/port/driver.py M Tools/Scripts/webkitpy/port/driver_unittest.py Log Message: --- Fix file-url based tests not working with runInCrossOriginIFrame https://bugs.webkit.org/show_bug.cgi?id=265985 rdar://119300316 Reviewed by Alex Christensen. runInCrossOriginIFrame doesn't work with file:/// based tests as they can't be loaded in an i-frame. This change instead runs those tests via http whenever this option is enabled by using a new alias to the root of the LayoutTests directory. * Tools/Scripts/webkitpy/layout_tests/servers/aliases.json: * Tools/Scripts/webkitpy/port/driver.py: (Driver.is_http_test): (Driver.test_to_uri): (Driver.uri_to_test): (Driver._command_from_driver_input): (DriverProxy.is_http_test): (DriverProxy.test_to_uri): Canonical link: https://commits.webkit.org/272281@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 31f3fa: Replace 1-bit bitfields in RenderObjectBitfields w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 31f3fa746c57d619974607becacf8dbb00ed2ce0 https://github.com/WebKit/WebKit/commit/31f3fa746c57d619974607becacf8dbb00ed2ce0 Author: Ryosuke Niwa Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderObject.h Log Message: --- Replace 1-bit bitfields in RenderObjectBitfields with RenderObjectFlag https://bugs.webkit.org/show_bug.cgi?id=266609 Unreviewed build fix for Windows. * Source/WebCore/rendering/RenderObject.h: Canonical link: https://commits.webkit.org/272282@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ac5fd: .submitproject filter is insufficient
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ac5fdd88a906395297945d1a9788bbd661a9075 https://github.com/WebKit/WebKit/commit/6ac5fdd88a906395297945d1a9788bbd661a9075 Author: Dan Robson Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M .submitproject Log Message: --- .submitproject filter is insufficient https://bugs.webkit.org/show_bug.cgi?id=266646 rdar://119877887 Reviewed by Jonathan Bedard. SP3 was able to successfully submit using these filters. * .submitproject: Canonical link: https://commits.webkit.org/272283@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d60d4: Stop using CheckedPtr / CheckedRef with refcounted...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d60d452f8d3162ff0a40f6db74c65cd9ec8de8b https://github.com/WebKit/WebKit/commit/1d60d452f8d3162ff0a40f6db74c65cd9ec8de8b Author: Chris Dumez Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorker.cpp M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorker.h M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.h M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.h M Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp M Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.h M Source/WebKit/Shared/WebBackForwardListItem.cpp M Source/WebKit/Shared/WebBackForwardListItem.h M Source/WebKit/UIProcess/API/APIContentWorld.cpp M Source/WebKit/UIProcess/API/APIContentWorld.h M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm M Source/WebKit/UIProcess/Automation/WebAutomationSession.h M Source/WebKit/UIProcess/Cocoa/UIRemoteObjectRegistry.h M Source/WebKit/UIProcess/DrawingAreaProxy.cpp M Source/WebKit/UIProcess/DrawingAreaProxy.h M Source/WebKit/UIProcess/Inspector/Agents/InspectorBrowserAgent.h M Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.h M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h M Source/WebKit/UIProcess/Inspector/WebPageInspectorAgentBase.h M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h M Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm M Source/WebKit/UIProcess/ProvisionalFrameProxy.h M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/SpeechRecognitionPermissionManager.h M Source/WebKit/UIProcess/SuspendedPageProxy.cpp M Source/WebKit/UIProcess/SuspendedPageProxy.h M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h M Source/WebKit/UIProcess/ViewSnapshotStore.cpp M Source/WebKit/UIProcess/ViewSnapshotStore.h M Source/WebKit/UIProcess/WebFrameProxy.cpp M Source/WebKit/UIProcess/WebFrameProxy.h M Source/WebKit/UIProcess/WebPageGroup.cpp M Source/WebKit/UIProcess/WebPageGroup.h M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h M Source/WebKit/UIProcess/mac/WKImmediateActionController.h M Source/WebKit/UIProcess/mac/WKImmediateActionController.mm M Source/WebKit/UIProcess/mac/WKTextFinderClient.mm M Source/WebKit/WebProcess/Databases/WebDatabaseProvider.cpp M Source/WebKit/WebProcess/Databases/WebDatabaseProvider.h M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleScriptWorld.h M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp M Source/WebKit/WebProcess/Network/WebLoaderStrategy.h M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.h M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.h M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.h M Source/WebKit/WebProcess/WebCoreSupport/WebDateTimeChooser.h M Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.h M Source/WebKit/WebProcess/WebPage/Cocoa/WebRemoteObjectRegistry.h M Source/WebKit/WebProcess/WebPage/DrawingArea.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebURLSchemeHandlerProxy.h M Source/WebKit/WebProcess/WebPage/WebURLSchemeTaskProxy.h Log Message: --
[webkit-changes] [WebKit/WebKit] bcdeb1: [IFC][Ruby] Anonymous bases should have white-spac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bcdeb1ae72eb306219987658997deb4159a9ccb9 https://github.com/WebKit/WebKit/commit/bcdeb1ae72eb306219987658997deb4159a9ccb9 Author: Antti Koivisto Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/ruby/floating-ruby-text-expected.txt M LayoutTests/fast/ruby/positioned-ruby-text-expected.txt M LayoutTests/platform/ios/TestExpectations M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h Log Message: --- [IFC][Ruby] Anonymous bases should have white-space:nowrap https://bugs.webkit.org/show_bug.cgi?id=266635 rdar://119864996 Reviewed by Alan Baradlay. The UA stylesheet has 'white-space: nowrap' for bases https://www.w3.org/TR/css-ruby-1/#default-ua-ruby. This should also be applied to anonymous bases. The behavior matches Firefox. * LayoutTests/TestExpectations: * LayoutTests/fast/ruby/floating-ruby-text-expected.txt: * LayoutTests/fast/ruby/positioned-ruby-text-expected.txt: * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::propagateStyleToAnonymousChildren): Don't reset ruby style when propagating style changes to anonymous children. * Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp: (WebCore::createAnonymousStyleForRuby): Set 'white-space: nowrap' to anonymous base style. (WebCore::createAnonymousRendererForRuby): Factor into functions. (WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForStyleBasedRubyChild): (WebCore::RenderTreeBuilder::Ruby::attachForStyleBasedRuby): * Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h: Canonical link: https://commits.webkit.org/272285@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9fbee5: Enable assertion invalidation callbacks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9fbee5abc7c0e3687a9e628608c364b0023be8c9 https://github.com/WebKit/WebKit/commit/9fbee5abc7c0e3687a9e628608c364b0023be8c9 Author: Per Arne Vollan Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/Platform/cocoa/AssertionCapability.mm Log Message: --- Enable assertion invalidation callbacks https://bugs.webkit.org/show_bug.cgi?id=266472 Reviewed by Brent Fulgham. * Source/WebKit/Platform/cocoa/AssertionCapability.mm: Canonical link: https://commits.webkit.org/272286@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 767a3b: [TextureMapper] right side of for-loop condition m...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 767a3b1ebacc83fda69adabd2cd05dcb44eaa087 https://github.com/WebKit/WebKit/commit/767a3b1ebacc83fda69adabd2cd05dcb44eaa087 Author: Fujii Hironori Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/texmap/TextureMapper.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp Log Message: --- [TextureMapper] right side of for-loop condition must be constant for ES SL 1.0 https://bugs.webkit.org/show_bug.cgi?id=261870 Reviewed by Miguel Gomez. After 267646@main improved gaussian blur filter, nothing drawn on Raspberry Pi 3 which supports only GLES 2.0. The shader compiler reports the following errors. > Program log: ERROR:OPTIMIZER-3 (fragment shader, line 48) Support for for > loops is restricted : right side of condition expression must be constant > Program log: ERROR:OPTIMIZER-3 (fragment shader, line 49) Support for for > loops is restricted : right side of condition expression must be constant * Source/WebCore/platform/graphics/texmap/TextureMapper.cpp: Zero-fills the kernel. * Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp: Use a constant GAUSSIAN_KERNEL_MAX_HALF_SIZE for the for-loop of applyBlurFilter and applyAlphaBlur for GLES<3.0 (ESSL 1.0) Canonical link: https://commits.webkit.org/272287@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 86f27f: rdar://115423166 (jsc_fuz/wktr: ASSERT_WITH_SECURI...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86f27fc858891a42fda36754566503b8b66285d9 https://github.com/WebKit/WebKit/commit/86f27fc858891a42fda36754566503b8b66285d9 Author: Nisha Jain Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A LayoutTests/fast/text/crash-letter-spacing-infinite-expected.html A LayoutTests/fast/text/crash-letter-spacing-infinite.html A LayoutTests/fast/text/crash-word-spacing-infinite-expected.html A LayoutTests/fast/text/crash-word-spacing-infinite.html Log Message: --- rdar://115423166 (jsc_fuz/wktr: ASSERT_WITH_SECURITY_IMPLICATION(widthForLargestKnownToFit <= maxWidth); in WebCore::truncateString(...)) rdar://115423166 Reviewed by Myles C. Maxfield. letterSpacing API needs to be able to handle NaN value Signed-off-by: nishajain61 Originally-landed-as: 267815.115@safari-7617-branch (935e894057d7). rdar://119594424 Canonical link: https://commits.webkit.org/272288@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 95d8b8: [JSC] `return` in async generators doesn't correct...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 95d8b89d755cf9607a3fcf6e68cf1d9ac07c4abb https://github.com/WebKit/WebKit/commit/95d8b89d755cf9607a3fcf6e68cf1d9ac07c4abb Author: Alexey Shvayka Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A JSTests/stress/async-generator-return-is-awaited-in-finally.js M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp Log Message: --- [JSC] `return` in async generators doesn't correctly `await` its value https://bugs.webkit.org/show_bug.cgi?id=266604 Reviewed by Justin Michaud. This change: 1. Makes emitAwait() unconditional on presence of `finally`, which appears to be a bug of initial async generators implementation. Before this patch, if `return` was enclosed by a `try` block with `finally`, returned IteratorResult's value was a promise rather than awaited value. 2. Makes emitAwait() conditional on presence of `return` node's value as per spec [1], which is also observable. Aligns JSC with V8 and SpiderMonkey on both counts. [1]: https://tc39.es/ecma262/#sec-return-statement-runtime-semantics-evaluation * JSTests/stress/async-generator-return-is-awaited-in-finally.js: Added. * JSTests/test262/expectations.yaml: Mark 2 tests as passing. * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::ReturnNode::emitBytecode): Canonical link: https://commits.webkit.org/272289@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f607b: [build.webkit.org] Improve support for required ch...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f607be029bf0deefdc9f4e4edc27b9aa2a5ddd6 https://github.com/WebKit/WebKit/commit/0f607be029bf0deefdc9f4e4edc27b9aa2a5ddd6 Author: Aakash Jain Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Tools/CISupport/Shared/transfer-archive-to-s3 Log Message: --- [build.webkit.org] Improve support for required changes for uat/dev instance - part 2 https://bugs.webkit.org/show_bug.cgi?id=266654 Reviewed by Ryan Haddad. Auto-detect the uat/dev instance and make changes accordingly. Also change print statements to use f-strings. * Tools/CISupport/Shared/transfer-archive-to-s3: (uploadToS3): (archiveExists): Canonical link: https://commits.webkit.org/272290@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 766a34: [JSC] Async functions and generators should proper...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 766a344cdf5c50e18624ceda6f98f2d9d3f5eac1 https://github.com/WebKit/WebKit/commit/766a344cdf5c50e18624ceda6f98f2d9d3f5eac1 Author: Alexey Shvayka Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A JSTests/stress/async-function-broken-promise.js M JSTests/test262/expectations.yaml M Source/JavaScriptCore/builtins/PromiseOperations.js Log Message: --- [JSC] Async functions and generators should properly handle broken promises https://bugs.webkit.org/show_bug.cgi?id=266502 Reviewed by Justin Michaud. Before this change, abrupt completions of PromiseResolve [1] that arised during "constructor" lookup were not handled properly in async functions and generators, resulting in exception propagation up the call stack rather than rejecting a promise. That affected `await`, `yield`, and `return` called with a broken promise (i.e. with throwing "constructor" getter). Most likely, this is a regression from implementing async / await tick reduction proposal [2]. This patch guards "constructor" lookup with exception handling, ensuring that all call sites supply onRejected() callback that is semantically equivalent to throwing an exception at that point, as per spec. Invoking onRejected() synchronously, without extra microtask, is also required to match the standard, V8, and SpiderMonkey. Also, this change implements a proposal [3] to fix AsyncGenerator.prototype.return() called on a broken promise, aligning JSC with V8. [1]: https://tc39.es/ecma262/#sec-promise-resolve (step 1.a) [2]: https://github.com/tc39/ecma262/pull/1250 [3]: https://github.com/tc39/ecma262/pull/2683 * JSTests/stress/async-function-broken-promise.js: Added. * JSTests/test262/expectations.yaml: Mark 4 tests as passing. * Source/JavaScriptCore/builtins/PromiseOperations.js: (linkTimeConstant.resolveWithoutPromiseForAsyncAwait): Canonical link: https://commits.webkit.org/272291@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ff5cc: [WPE][GTK] Remove pkg-config use from FindLibBackt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ff5cc83058a1ec8db37ffa6784eed55eaa232b5 https://github.com/WebKit/WebKit/commit/0ff5cc83058a1ec8db37ffa6784eed55eaa232b5 Author: Michael Catanzaro Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/cmake/FindLibBacktrace.cmake Log Message: --- [WPE][GTK] Remove pkg-config use from FindLibBacktrace.cmake https://bugs.webkit.org/show_bug.cgi?id=265813 Reviewed by Adrian Perez de Castro. libbacktrace upstream does not distribute a pkg-config file. Apparently some downstreams are doing this, but I'm not sure who, because this software is not packaged in major distros like Debian or Fedora. It's not likely to be, because it doesn't have any releases. Let's not attempt to use a downstream-only pkg-config file. If pkg-config support can be upstream, that would be great. * Source/cmake/FindLibBacktrace.cmake: Canonical link: https://commits.webkit.org/272292@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d773cc: Fix attachment tests -folder-icon, -type-attribute...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d773ccf904e47e3e0f2426a956073fca8cdc2d54 https://github.com/WebKit/WebKit/commit/d773ccf904e47e3e0f2426a956073fca8cdc2d54 Author: Gerald Squelart Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/fast/attachment/attachment-default-icon-expected.html M LayoutTests/fast/attachment/attachment-default-icon.html M LayoutTests/fast/attachment/attachment-folder-icon-expected.html M LayoutTests/fast/attachment/attachment-folder-icon.html M LayoutTests/fast/attachment/attachment-type-attribute-expected.html M LayoutTests/fast/attachment/attachment-type-attribute.html M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- Fix attachment tests -folder-icon, -type-attribute, -default-icon https://bugs.webkit.org/show_bug.cgi?id=265962 rdar://119272478 Reviewed by Tim Nguyen. Let the attachments settle with the expected icons before taking a screenshot. * LayoutTests/fast/attachment/attachment-default-icon-expected.html: * LayoutTests/fast/attachment/attachment-default-icon.html: * LayoutTests/fast/attachment/attachment-folder-icon-expected.html: * LayoutTests/fast/attachment/attachment-folder-icon.html: * LayoutTests/fast/attachment/attachment-type-attribute-expected.html: * LayoutTests/fast/attachment/attachment-type-attribute.html: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/272293@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de47ae: WTFCrashWithSecurityImplication in WebCore::Render...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de47ae4003e992e436df92a14ed69138601d9039 https://github.com/WebKit/WebKit/commit/de47ae4003e992e436df92a14ed69138601d9039 Author: Antti Koivisto Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/multicol/last-set-crash-expected.txt A LayoutTests/fast/multicol/last-set-crash.html M LayoutTests/platform/glib/TestExpectations M Source/WebCore/rendering/RenderMultiColumnFlow.cpp M Source/WebCore/rendering/RenderMultiColumnFlow.h Log Message: --- WTFCrashWithSecurityImplication in WebCore::RenderFragmentedFlow::removeLineFragmentInfo() https://bugs.webkit.org/show_bug.cgi?id=264327 rdar://114559559 Reviewed by Alan Baradlay. * LayoutTests/TestExpectations: Skip test on debug due to some assertion failures. * LayoutTests/fast/multicol/last-set-crash-expected.txt: Added. * LayoutTests/fast/multicol/last-set-crash.html: Added. * Source/WebCore/rendering/RenderMultiColumnFlow.cpp: (WebCore::RenderMultiColumnFlow::fragmentAtBlockOffset const): Tree mutations may have made m_lastSetWorkedOn cache invalid by moving the multicolumn set under a different multicolumn flow. Check for this. * Source/WebCore/rendering/RenderMultiColumnFlow.h: Also make it use WeakPtr. Originally-landed-as: 267815.546@safari-7617-branch (f524a15d0633). rdar://114559559 Canonical link: https://commits.webkit.org/272294@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58e0ef: Wait until the tab load has completed before testi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58e0ef1f7853c5fb889e2bc03304503548e0c171 https://github.com/WebKit/WebKit/commit/58e0ef1f7853c5fb889e2bc03304503548e0c171 Author: Kiara Rose Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm Log Message: --- Wait until the tab load has completed before testing execute script for extension. https://bugs.webkit.org/show_bug.cgi?id=266647 rdar://119398971 Reviewed by Timothy Hatcher. Updated the check under `browser.tabs.onUpdated` event listener for the tab load being complete before testing the executeScript API. If the load isn't complete, we will be injecting the script too early for the test results to be accurate. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/272295@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79e81a: [ARM] Add release build type check to downcast()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79e81a318c92f39fccf9f61711d49a7ba5525413 https://github.com/WebKit/WebKit/commit/79e81a318c92f39fccf9f61711d49a7ba5525413 Author: Chris Dumez Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WTF/wtf/Ref.h M Source/WTF/wtf/RefPtr.h M Source/WTF/wtf/TypeCasts.h M Source/WTF/wtf/WeakPtr.h M Source/WTF/wtf/WeakRef.h M Source/WebCore/bindings/js/JSNodeCustom.cpp M Source/WebCore/css/BasicShapeFunctions.cpp M Source/WebCore/css/CSSValue.cpp M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/StyleRule.cpp M Source/WebCore/css/StyleSheetContents.cpp M Source/WebCore/css/calc/CSSCalcValue.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/ElementData.cpp M Source/WebCore/dom/ElementData.h M Source/WebCore/dom/Node.cpp M Source/WebCore/style/StyleScope.cpp Log Message: --- [ARM] Add release build type check to downcast() https://bugs.webkit.org/show_bug.cgi?id=266588 Reviewed by Brent Fulgham and Ryosuke Niwa. Add release build type check to downcast() on ARM, where this tested as performance neutral. Some more work will be needed to make it affordable on Intel. This patch introduces an uncheckedDowncast<>() which only does the type check on debug builds (like downcast<>() used to do). It is useful for cases where it is clear the code is safe (e.g. in a switch statement for the type), especially in hot code. This patch also converts some more `is<>() + downcast<>()` calls with `dynamicDowncast<>()`, which is now more efficient. * Source/WTF/wtf/Ref.h: (WTF::uncheckedDowncast): (WTF::downcast): * Source/WTF/wtf/RefPtr.h: (WTF::uncheckedDowncast): (WTF::downcast): * Source/WTF/wtf/TypeCasts.h: (WTF::uncheckedDowncast): (WTF::downcast): * Source/WTF/wtf/WeakPtr.h: (WTF::downcast): * Source/WTF/wtf/WeakRef.h: (WTF::downcast): * Source/WebCore/animation/AcceleratedTimeline.cpp: (WebCore::AcceleratedTimeline::updateEffectStacks): * Source/WebCore/animation/AnimationEffect.cpp: (WebCore::AnimationEffect::bindingsUpdateTiming): (WebCore::AnimationEffect::progressUntilNextStep const): * Source/WebCore/animation/AnimationTimeline.cpp: (WebCore::AnimationTimeline::animationTimingDidChange): * Source/WebCore/animation/CSSAnimation.cpp: (WebCore::CSSAnimation::keyframesRuleDidChange): (WebCore::CSSAnimation::updateKeyframesIfNeeded): * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::blendFunc): * Source/WebCore/animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::animationCanBeRemoved): * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::getKeyframes): (WebCore::KeyframeEffect::setBindingsKeyframes): (WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes): (WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes): (WebCore::isLinearTimingFunctionWithPoints): (WebCore::KeyframeEffect::computeSomeKeyframesUseStepsOrLinearTimingFunctionWithPoints): (WebCore::KeyframeEffect::setAnimatedPropertiesInStyle): (WebCore::KeyframeEffect::computeExtentOfTransformAnimation const): (WebCore::KeyframeEffect::progressUntilNextStep const): (WebCore::KeyframeEffect::timingFunctionForKeyframe const): * Source/WebCore/animation/ViewTimeline.cpp: (WebCore::ViewTimeline::createFromCSSValue): * Source/WebCore/animation/WebAnimation.cpp: (WebCore::WebAnimation::setEffectInternal): (WebCore::WebAnimation::setTimeline): (WebCore::WebAnimation::acceleratedStateDidChange): (WebCore::WebAnimation::updateRelevance): (WebCore::WebAnimation::isReplaceable const): (WebCore::WebAnimation::commitStyles): * Source/WebCore/animation/WebAnimationUtilities.cpp: (WebCore::compareAnimationsByCompositeOrder): (WebCore::compareDeclarativeAnimationEvents): * Source/WebCore/bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline): * Source/WebCore/css/BasicShapeFunctions.cpp: (WebCore::valueForBasicShape): * Source/WebCore/css/CSSValue.cpp: (WebCore::CSSValue::visitDerived): (WebCore::CSSValue::createDeprecatedCSSOMWrapper const): * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::valueForAnimationTimingFunction): (WebCore::valueForPathOperation): * Source/WebCore/css/StyleRule.cpp: (WebCore::StyleRuleBase::visitDerived): * Source/WebCore/css/StyleSheetContents.cpp: (WebCore::StyleSheetContents::traverseSubresources const): * Source/WebCore/css/TransformFunctions.cpp: (WebCore::transformForValue): * Source/WebCore/css/calc/CSSCalcValue.cpp: (WebCore::createCSS): * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeFontFeatureValuesRule): * Source/WebCore/dom/Document.cpp: (WebCore::Document::importNode): (WebCore::Document::adoptNode): (WebCore::Document::canAcceptChild const): * Source/WebCore/dom/Element.cpp: (WebCore::Element::createUniqueElementData): * Source/WebCore/dom/ElementData.cpp: (WebCore::ElementData::destroy): *
[webkit-changes] [WebKit/WebKit] 470e56: BBQJIT if conditions are very wrong
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 470e562ed7b830ee06b73b892c6ae243e48b9af2 https://github.com/WebKit/WebKit/commit/470e562ed7b830ee06b73b892c6ae243e48b9af2 Author: Justin Michaud Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A JSTests/wasm/stress/bbq-parallel-move.js M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp Log Message: --- BBQJIT if conditions are very wrong https://bugs.webkit.org/show_bug.cgi?id=26 rdar://problem/116145012 Reviewed by Keith Miller. BBQJIT if conditions are very wrong. By random chance, the condition value happens to be allocated in nonPreservedNonArgumentGPR1, but if you use more than 8 registers, we end up just reading a completely random value. Let's not do that. We also add some extra debugging assertions for parallel move. These shouldn't ever actually be hit, but they help us avoid a potential problem in the future if we make BBQ register allocation smarter. Finally, we allow allocating eax on x86, and fix some bugs surrounding if/else as a result. * JSTests/wasm/stress/bbq-parallel-move.js: Added. (from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.func.log_value.import.string_appeared_here.string_appeared_here.param.i32.func.export.string_appeared_here.param.p0.i32.param.p1.i32.param.p2.i32.local.p1.local.p1.local.p1.local.p1.local.p1.local.p1.local.p1.local.p1.local.p1.result.i32.local.p0.then.local.p2.local.p0.i32.const.0.else.i32.const.0.local.p2.call.f.func.f.param.i32.param.i32.param.i32.param.i32.param.i32.param.i32.param.i32.param.i32.param.i32.param.i32.param.pl.i32.call.log_value.local.pl.async test.): (from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.func.log_value.import.string_appeared_here.string_appeared_here.param.i32.func.export.string_appeared_here.param.p0.i32.param.p1.i32.param.p2.i32.local.p1.local.p1.local.p1.local.p1.local.p1.local.p1.local.p1.local.p1.local.p1.result.i32.local.p0.then.local.p2.local.p0.i32.const.0.else.i32.const.0.local.p2.call.f.func.f.param.i32.param.i32.param.i32.param.i32.param.i32.param.i32.param.i32.param.i32.param.i32.param.i32.param.pl.i32.call.log_value.local.pl.async test): * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::ControlData::ControlData): (JSC::Wasm::BBQJIT::addIf): (JSC::Wasm::BBQJIT::emitIndirectCall): (JSC::Wasm::BBQJIT::emitShuffle): Originally-landed-as: 267815.223@safari-7617-branch (3c476842d24c). rdar://119592377 Canonical link: https://commits.webkit.org/272297@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d37520: [GARDNEING]REGRESSION(271897@main): [ iOS17 ] impo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d37520e80c58215a5fbd6486eeca26b2eacbdee7 https://github.com/WebKit/WebKit/commit/d37520e80c58215a5fbd6486eeca26b2eacbdee7 Author: Robert Jenner Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [GARDNEING]REGRESSION(271897@main): [ iOS17 ] imported/w3c/web-platform-tests/css/css-cascade/scope-hover.html is a constant text failure https://bugs.webkit.org/show_bug.cgi?id=266652 rdar://119882318 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/272298@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e8b2c8: [scroll-anchoring] Reenable scroll anchoring on so...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8b2c8b9f620462989dfe351e10612df92eb43a2 https://github.com/WebKit/WebKit/commit/e8b2c8b9f620462989dfe351e10612df92eb43a2 Author: Nikolaos Mouchtaris Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/fast/dom/Element/body-scrollLeft-basics-quirks.html M LayoutTests/fast/dom/Element/body-scrollTop-basics-quirks.html M LayoutTests/fast/dom/Window/window-scroll-arguments.html M LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html M LayoutTests/fast/dom/vertical-scrollbar-when-dir-change.html M LayoutTests/fast/repaint/absolute-position-changed.html M LayoutTests/fast/scrolling/ios/adjust-scroll-snap-during-gesture.html M LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-main-frame.html M LayoutTests/fast/scrolling/ios/key-command-scroll-to-bottom.html M LayoutTests/fast/scrolling/ios/key-command-scroll-to-top.html M LayoutTests/fast/scrolling/ios/mixing-user-and-programmatic-scroll-002.html M LayoutTests/fast/scrolling/ios/mixing-user-and-programmatic-scroll-003.html M LayoutTests/fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html M LayoutTests/fast/scrolling/ios/scroll-iframe-001.html M LayoutTests/fast/scrolling/ios/scroll-iframe-002.html M LayoutTests/fast/scrolling/ios/scroll-iframe-003.html M LayoutTests/fast/scrolling/ios/scroll-to-beginning-and-end-of-document.html M LayoutTests/jquery/offset.html Log Message: --- [scroll-anchoring] Reenable scroll anchoring on some LayoutTests https://bugs.webkit.org/show_bug.cgi?id=262712 rdar://116533047 Reviewed by Tim Nguyen and Simon Fraser. Reenable scroll anchoring on some LayoutTests. * LayoutTests/fast/dom/Element/body-scrollLeft-basics-quirks.html: * LayoutTests/fast/dom/Element/body-scrollTop-basics-quirks.html: * LayoutTests/fast/dom/Window/window-scroll-arguments.html: * LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html: * LayoutTests/fast/dom/vertical-scrollbar-when-dir-change.html: Canonical link: https://commits.webkit.org/272299@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ef929c: [GARDNEING]NEW-TEST(270986@main):[ iOS17 ] 2X impo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ef929cdcbb994371ca99f88c8c0f0678730e5869 https://github.com/WebKit/WebKit/commit/ef929cdcbb994371ca99f88c8c0f0678730e5869 Author: Robert Jenner Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [GARDNEING]NEW-TEST(270986@main):[ iOS17 ] 2X imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-viewport-partially-onscreen are constant ImageOnlyFailures https://bugs.webkit.org/show_bug.cgi?id=20 rdar://119891914 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/272300@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23ee7d: [GARDENING]RE-IMPORT(271918@main) 3X imported/w3c/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23ee7d493e192c662fe09d2a6c21310bbd69cf9d https://github.com/WebKit/WebKit/commit/23ee7d493e192c662fe09d2a6c21310bbd69cf9d Author: Robert Jenner Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [GARDENING]RE-IMPORT(271918@main) 3X imported/w3c/web-platform-tests/css/selectors (layout-tests) are constant text failures https://bugs.webkit.org/show_bug.cgi?id=21 rdar://119894365 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/272301@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 552c7a: Remove double negative from ArithClz32 backwards p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 552c7a956d0eadaa0c5a8e660f2380b0534d1d96 https://github.com/WebKit/WebKit/commit/552c7a956d0eadaa0c5a8e660f2380b0534d1d96 Author: David Degazio Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp Log Message: --- Remove double negative from ArithClz32 backwards propagation https://bugs.webkit.org/show_bug.cgi?id=266505 rdar://119694893 Reviewed by Justin Michaud. Removes the extra ~ in front of NodeBytecodePrefersArrayIndex when processing a DFG ArithClz32 node in the backwards propagation phase. This makes it consistent with the other fields in the mask, instead of the current behavior, which always masks off all other bits except NodeBytecodePrefersArrayIndex. * Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp: (JSC::DFG::BackwardsPropagationPhase::propagate): Canonical link: https://commits.webkit.org/272302@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] baf3ea: Implement errorOccured in webNavigation.getFrame/g...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: baf3eae87da202e1ab9d7ccb2dff883fe503e2bc https://github.com/WebKit/WebKit/commit/baf3eae87da202e1ab9d7ccb2dff883fe503e2bc Author: Brian Weinstein Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebKit/Shared/FrameInfoData.h M Source/WebKit/Shared/FrameInfoData.serialization.in M Source/WebKit/UIProcess/API/APIFrameInfo.h M Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm M Source/WebKit/UIProcess/API/Cocoa/WKFrameInfoPrivate.h M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWebNavigationCocoa.mm M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm Log Message: --- Implement errorOccured in webNavigation.getFrame/getAllFrames https://bugs.webkit.org/show_bug.cgi?id=266499 rdar://118340990 Reviewed by Alex Christensen and Timothy Hatcher. Before this change, there was no way to determine if an error occurred in the load of a frame given a WKFrameInfo. This patch pipes that information from the FrameLoader -> WebFrame -> WKFrameInfo, and exposes it as SPI on the WKFrameInfo. This patch also adds some tests for both the new WKFrameInfo SPI and how it is exposed to extensions. * Source/WebCore/loader/FrameLoader.cpp: Clear m_errorOccurredInLoading in all of the places that load start. (WebCore::FrameLoader::dispatchDidFailProvisionalLoad): Set m_errorOccurredInLoading to true. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Set m_errorOccurredInLoading to true if necessary. * Source/WebCore/loader/FrameLoader.h: * Source/WebKit/Shared/FrameInfoData.h: Add the new parameter. * Source/WebKit/Shared/FrameInfoData.serialization.in: Ditto. * Source/WebKit/UIProcess/API/APIFrameInfo.h: * Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm: (-[WKFrameInfo _errorOccurred]): * Source/WebKit/UIProcess/API/Cocoa/WKFrameInfoPrivate.h: * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWebNavigationCocoa.mm: (WebKit::frameParametersForFrame): Include whether or not an error occurred. * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::info const): Include whether or not an error occurred. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm: (TestWebKitAPI::TEST): Add a test that when a frame load fails with an error, errorOccurred is set in the getFrame call. There are two flavors of this test, one with a failed provisional load, the other with a failed load after it had been committed. * Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm: Enhance the Frames test to: 1) Make sure the WKFrameInfo _errorOccurred SPI value is correct when loads fail and complete. 2) Perform an additional load after the failed load to make sure the error occurred state is reset. Canonical link: https://commits.webkit.org/272303@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3614ef: Web content renders blank on tab switch.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3614ef890007d387d7a8dc9c809eb80d645c275b https://github.com/WebKit/WebKit/commit/3614ef890007d387d7a8dc9c809eb80d645c275b Author: Matt Woodrow Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp Log Message: --- Web content renders blank on tab switch. https://bugs.webkit.org/show_bug.cgi?id=266655 Reviewed by Simon Fraser. m_previouslyPaintedRect is used to minimize the copy-forward rect when we know the new front buffer is also previous-previous-front-buffer (N-2). In that case we only need to copy the pixels drawn last time (into N-1), minus the pixel we're going to draw this time. If the buffer is N-2, but it's been purged, then that also needs to skip the optimization, so we clear m_previouslyPaintedRect. * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp: (WebKit::RemoteImageBufferSet::ensureBufferForDisplay): Canonical link: https://commits.webkit.org/272304@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe76e3: [GARDENING][ New Test ] (264228@main): [ iOS ] imp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe76e3a49854a46c121dddf528085931ea76459a https://github.com/WebKit/WebKit/commit/fe76e3a49854a46c121dddf528085931ea76459a Author: Robert Jenner Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [GARDENING][ New Test ] (264228@main): [ iOS ] imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=259132 rdar://112109419 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/272305@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3479e4: NetworkResourceLoader::isMainFrameLoad() should be...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3479e44a7b3628dd55a1df3a7f5b7919be913f6e https://github.com/WebKit/WebKit/commit/3479e44a7b3628dd55a1df3a7f5b7919be913f6e Author: Alex Christensen Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- NetworkResourceLoader::isMainFrameLoad() should be correct with site isolation enabled https://bugs.webkit.org/show_bug.cgi?id=266658 Reviewed by Pascoe. frameAncestorOrigins was empty so isMainFrameLoad() was incorrectly returning true for non-main frames, causing them not to commit loads if cross-origin-opener-policy header fields were present in the response of an iframe. Normally, NetworkResourceLoader::doCrossOriginOpenerHandlingOfResponse would return early because it wasn't a main frame load. That happens again after this PR. Since a web content process shouldn't know the origins of ancestor frames that aren't same-site, I add nullptr to the Vector> if I encounter a RemoteFrame in the tree ancestry. I added a few previously-unneeded null checks to prevent it from crashing. * Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::checkFrameAncestors): * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::shouldInterruptLoadForXFrameOptions): * Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm: (WebKit::SubFrameSOAuthorizationSession::shouldInterruptLoadForXFrameOptions): * Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/272306@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d912bb: Use WeakRef instead of CheckedPtr for WebExtension...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d912bb4b043eb727cc6e14223f3ae0e563222d65 https://github.com/WebKit/WebKit/commit/d912bb4b043eb727cc6e14223f3ae0e563222d65 Author: Chris Dumez Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIPortCocoa.mm M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIPort.h Log Message: --- Use WeakRef instead of CheckedPtr for WebExtensionAPIPort https://bugs.webkit.org/show_bug.cgi?id=266656 Reviewed by Timothy Hatcher. Use WeakRef instead of CheckedPtr for WebExtensionAPIPort for storage in containers. This generates more actionable crashes. Also make the constructors private since the class is refcounted. * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIPortCocoa.mm: (WebKit::WebExtensionAPIPort::get): (WebKit::WebExtensionAPIPort::add): (WebKit::WebExtensionAPIPort::remove): * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIPort.h: (WebKit::WebExtensionAPIPort::~WebExtensionAPIPort): Canonical link: https://commits.webkit.org/272307@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1fb550: [GARDENING]REGRESSION(271428@main): [ iOS 17 ] imp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fb5505e86e16bdff13c078b25383f42319aa906 https://github.com/WebKit/WebKit/commit/1fb5505e86e16bdff13c078b25383f42319aa906 Author: Robert Jenner Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [GARDENING]REGRESSION(271428@main): [ iOS 17 ] imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html is a constant text failure https://bugs.webkit.org/show_bug.cgi?id=25 rdar://119897560 Unreviewed Test Gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/272308@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 054b95: Stop using CheckedRef with Style::Resolver
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 054b954791a5e2d555c64b3b71701da32fdee1b0 https://github.com/WebKit/WebKit/commit/054b954791a5e2d555c64b3b71701da32fdee1b0 Author: Chris Dumez Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/style/MatchedDeclarationsCache.h M Source/WebCore/style/StyleResolver.h Log Message: --- Stop using CheckedRef with Style::Resolver https://bugs.webkit.org/show_bug.cgi?id=266657 Reviewed by Ryosuke Niwa. Stop using CheckedRef with Style::Resolver. Use WeakRef instead to generate more actionable crashes. * Source/WebCore/style/MatchedDeclarationsCache.h: * Source/WebCore/style/StyleResolver.h: Canonical link: https://commits.webkit.org/272309@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3d969d: [Gardening]: NEW TEST: [ Ventura+ wk2 Release x86_...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d969dd7a8163a6dea162e25a371e370c6872016 https://github.com/WebKit/WebKit/commit/3d969dd7a8163a6dea162e25a371e370c6872016 Author: Marta Darbinyan Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: NEW TEST: [ Ventura+ wk2 Release x86_64 ] media/video-audio-session-mode.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=265954 rdar://119265443 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/272310@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 35c1f1: Generalize RenderElementType as TypeFlag and make ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35c1f16c757919912b753c31234880400a5c6f25 https://github.com/WebKit/WebKit/commit/35c1f16c757919912b753c31234880400a5c6f25 Author: Ryosuke Niwa Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderBlock.h M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderBlockFlow.h M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBox.h M Source/WebCore/rendering/RenderBoxModelObject.cpp M Source/WebCore/rendering/RenderBoxModelObject.h M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderFlexibleBox.cpp M Source/WebCore/rendering/RenderFragmentContainer.cpp M Source/WebCore/rendering/RenderFragmentContainer.h M Source/WebCore/rendering/RenderFragmentedFlow.cpp M Source/WebCore/rendering/RenderImage.cpp M Source/WebCore/rendering/RenderImage.h M Source/WebCore/rendering/RenderInline.cpp M Source/WebCore/rendering/RenderLayerModelObject.cpp M Source/WebCore/rendering/RenderLayerModelObject.h M Source/WebCore/rendering/RenderMedia.cpp M Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.cpp M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/RenderReplaced.cpp M Source/WebCore/rendering/RenderReplaced.h M Source/WebCore/rendering/RenderText.cpp M Source/WebCore/rendering/RenderTextControl.cpp M Source/WebCore/rendering/RenderWidget.cpp M Source/WebCore/rendering/svg/RenderSVGBlock.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp Log Message: --- Generalize RenderElementType as TypeFlag and make it const https://bugs.webkit.org/show_bug.cgi?id=266659 Reviewed by Simon Fraser. This PR generalizes RenderElementType as TypeFlag to be used with any RenderObject instead of just RenderElement and moves IsAnonymous, IsText, and IsBox flags from RenderObjectFlag. It also renames the member variable to m_typeFlags and makes it const so that its value doesn't change once RenderObject is initialized. This PR also makes m_type const as well. Finally, this PR also creates RenderReplaced specific type flags (ReplacedFlag) and moves IsImage, IsMedia, IsWidget over there to free up more bits in TypeFlag. * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): * Source/WebCore/rendering/RenderBlock.h: * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::RenderBlockFlow): * Source/WebCore/rendering/RenderBlockFlow.h: (WebCore::RenderBlockFlow::RenderBlockFlow): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): * Source/WebCore/rendering/RenderBox.h: * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::RenderBoxModelObject): * Source/WebCore/rendering/RenderBoxModelObject.h: * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::RenderElement): * Source/WebCore/rendering/RenderElement.h: * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::RenderFlexibleBox): * Source/WebCore/rendering/RenderFragmentContainer.cpp: (WebCore::RenderFragmentContainer::RenderFragmentContainer): * Source/WebCore/rendering/RenderFragmentContainer.h: * Source/WebCore/rendering/RenderFragmentedFlow.cpp: (WebCore::RenderFragmentedFlow::RenderFragmentedFlow): * Source/WebCore/rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): * Source/WebCore/rendering/RenderImage.h: * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::RenderLayerModelObject): * Source/WebCore/rendering/RenderLayerModelObject.h: * Source/WebCore/rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): * Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.cpp: (WebCore::RenderMultiColumnSpannerPlaceholder::RenderMultiColumnSpannerPlaceholder): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData): (WebCore::RenderObject::setIsRenderFragmentedFlow): Deleted. * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::isRenderReplaced const): (WebCore::RenderObject::isRenderBoxModelObject const): (WebCore::RenderObject::isRenderBlock const): (WebCore::RenderObject::isRenderBlockFlow const): (WebCore::RenderObject::isRenderInline const): (WebCore::RenderObject::isRenderLayerModelObject const): (WebCore::RenderObject::isRenderMedia const): (WebCore::RenderObject::isRenderImage const): (WebCore::RenderObject::isRenderFragmentContainer co
[webkit-changes] [WebKit/WebKit] ccbbc0: [GARDENING]REGRESSION(271863@main): imported/w3c/w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ccbbc011cb239c7499a26e62f63a3d4c06aa9b04 https://github.com/WebKit/WebKit/commit/ccbbc011cb239c7499a26e62f63a3d4c06aa9b04 Author: Robert Jenner Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [GARDENING]REGRESSION(271863@main): imported/w3c/web-platform-tests/webrtc-extensions/RTCRtpSynchronizationSource-captureTimestamp.html is a flaky text failure https://bugs.webkit.org/show_bug.cgi?id=29 rdar://119899602 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/272312@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 64a739: Ensure NetworkStorageManager gets destroyed on the...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 64a739754a58011eb565cd42714159be4f9a48f0 https://github.com/WebKit/WebKit/commit/64a739754a58011eb565cd42714159be4f9a48f0 Author: Sihui Liu Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp Log Message: --- Ensure NetworkStorageManager gets destroyed on the main thread https://bugs.webkit.org/show_bug.cgi?id=266603 rdar://117839300 Reviewed by Chris Dumez and Alex Christensen. Dispatch a task to main thread to release ref of NetworkStorageManager in stopReceivingMessageFromConnection, which may help fix the crash under IDBStorageRegistry::removeConnectionToClient in rdar://117839300. * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::NetworkStorageManager::stopReceivingMessageFromConnection): Canonical link: https://commits.webkit.org/272313@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eae948: rdar://110000099 (jsc_fuz/wktr: invalid message We...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eae948cc319807613f9921d1babbcac374f57587 https://github.com/WebKit/WebKit/commit/eae948cc319807613f9921d1babbcac374f57587 Author: Erica Li Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A LayoutTests/editing/pasteboard/copy-paste-crash-onbeforeunload-event-expected.txt A LayoutTests/editing/pasteboard/copy-paste-crash-onbeforeunload-event.html M Source/WebCore/loader/FrameLoader.cpp Log Message: --- rdar://11099 (jsc_fuz/wktr: invalid message WebPasteboardProxy_GetPasteboardChangeCount) https://bugs.webkit.org/show_bug.cgi\?id\=262292 rdar://11099 Reviewed by Wenson Hsieh. Disable copy paste for beforeunload event. * LayoutTests/editing/pasteboard/copy-paste-crash-onbeforeunload-event-expected.txt: Added. * LayoutTests/editing/pasteboard/copy-paste-crash-onbeforeunload-event.html: Added. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::ForbidCopyPasteScope::ForbidCopyPasteScope): (WebCore::ForbidCopyPasteScope::~ForbidCopyPasteScope): (WebCore::FrameLoader::dispatchBeforeUnloadEvent): Originally-landed-as: 267815.226@safari-7617-branch (20bb95c77d7c). rdar://119592394 Canonical link: https://commits.webkit.org/272314@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eac7aa: Use-after-free crash under EventTarget::innerInvok...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eac7aa0748e71af41a45f74aed3448458734c12a https://github.com/WebKit/WebKit/commit/eac7aa0748e71af41a45f74aed3448458734c12a Author: Chris Dumez Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A LayoutTests/fast/events/document-destruction-during-event-firing-crash-expected.txt A LayoutTests/fast/events/document-destruction-during-event-firing-crash.html Log Message: --- Use-after-free crash under EventTarget::innerInvokeEventListeners() https://bugs.webkit.org/show_bug.cgi?id=263029 rdar://116802026 Reviewed by Ryosuke Niwa. Make sure we keep the script execution context alive by holding it in a Ref<>. * LayoutTests/fast/events/document-destruction-during-event-firing-crash-expected.txt: Added. * LayoutTests/fast/events/document-destruction-during-event-firing-crash.html: Added. * Source/WebCore/dom/EventTarget.cpp: (WebCore::EventTarget::innerInvokeEventListeners): Originally-landed-as: 267815.272@safari-7617-branch (fc0cce085a99). rdar://119565389 Canonical link: https://commits.webkit.org/272315@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4a40fe: Fix hang in SQLTransactionCoordinator::shutdown()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4a40fea04d2fc3fa045298f31baff6ca489a5959 https://github.com/WebKit/WebKit/commit/4a40fea04d2fc3fa045298f31baff6ca489a5959 Author: Ahmad Saleem Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.cpp Log Message: --- Fix hang in SQLTransactionCoordinator::shutdown() https://bugs.webkit.org/show_bug.cgi?id=266552 Reviewed by Chris Dumez. Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=181269 We should call `takeFirst` instead of `first` to decrease the size of `info.pendingTransactions`. Also update 'RefPtr' to 'RefPtr'. This changes does not have any test case. * Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.cpp: (SQLTransactionCoordinator::shutdown): Canonical link: https://commits.webkit.org/272316@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e2fbf: jsc_fuz/wktr: heap-use-after-free in WebCore::IDBS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e2fbff61ae90daff246d581be165947505b2d10 https://github.com/WebKit/WebKit/commit/5e2fbff61ae90daff246d581be165947505b2d10 Author: Nisha Jain Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A LayoutTests/storage/indexeddb/abort-index-rename-crash-expected.txt A LayoutTests/storage/indexeddb/abort-index-rename-crash.html M Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp M Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp M Source/WebCore/Modules/indexeddb/server/MemoryIndex.h M Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp M Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.h Log Message: --- jsc_fuz/wktr: heap-use-after-free in WebCore::IDBServer::MemoryObjectStore::takeIndexByIdentifier(unsigned long long) MemoryObjectStore.cpp:128. https://bugs.webkit.org/show_bug.cgi?id=264180. rdar://117463447. Reviewed by Sihui Liu. MemoryIndex now keeps WeakPtr to MemoryObjectStore 'm_objectStore' and checks it's validity before using it. Also RefPtr conversion from WekPtr using get() API as applicable. * LayoutTests/storage/indexeddb/abort-index-rename-crash-expected.txt: Added the test expected file. * LayoutTests/storage/indexeddb/abort-index-rename-crash.html: Added the test case. * Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp: Checks the validity of MemoryObjectStore pointer before using. (WebCore::IDBServer::MemoryBackingStoreTransaction::objectStoreDeleted): (WebCore::IDBServer::MemoryBackingStoreTransaction::indexRenamed): (WebCore::IDBServer::MemoryBackingStoreTransaction::abort): * Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp: Changed direct reference to WeakPtr. Also used RefPtr conversion using get() API as applicable. (WebCore::IDBServer::MemoryIndex::objectStoreCleared): (WebCore::IDBServer::MemoryIndex::clearIndexValueStore): (WebCore::IDBServer::MemoryIndex::replaceIndexValueStore): (WebCore::IDBServer::MemoryIndex::getResultForKeyRange const): (WebCore::IDBServer::MemoryIndex::getAllRecords const): * Source/WebCore/Modules/indexeddb/server/MemoryIndex.h: Changed direct reference to WeakPtr. (WebCore::IDBServer::MemoryIndex::objectStore): * Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp: Used RefPtr conversion using get() API for MemoryIndex based MemoryObjectStore object. (WebCore::IDBServer::MemoryIndexCursor::currentData): * Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.h: Originally-landed-as: 267815.545@safari-7617-branch (64bcd93cbc55). rdar://119599034 Canonical link: https://commits.webkit.org/272317@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f144d3: Generate CFURLRef serializer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f144d32fb2fd5a87b566f24243f7fdfaba747789 https://github.com/WebKit/WebKit/commit/f144d32fb2fd5a87b566f24243f7fdfaba747789 Author: Brady Eidson Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make A Source/WebKit/Shared/Cocoa/CoreIPCCFURL.h A Source/WebKit/Shared/Cocoa/CoreIPCCFURL.mm A Source/WebKit/Shared/Cocoa/CoreIPCCFURL.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCDate.h M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp M Source/WebKit/Shared/cf/ArgumentCodersCF.h M Source/WebKit/Shared/cf/CFTypes.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Generate CFURLRef serializer https://bugs.webkit.org/show_bug.cgi?id=266547 Reviewed by Alex Christensen. CFURL is just different enough from NSURL and WTF::URL to get its own wrapper. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/Cocoa/CoreIPCCFURL.h: Copied from Source/WebKit/Shared/Cocoa/CoreIPCDate.h. (WebKit::CoreIPCCFURL::CoreIPCCFURL): (WebKit::CoreIPCCFURL::createCFURL const): * Source/WebKit/Shared/Cocoa/CoreIPCCFURL.mm: Copied from Source/WebKit/Shared/Cocoa/CoreIPCDate.h. (WebKit::CoreIPCCFURL::createWithBaseURLAndBytes): (WebKit::CoreIPCCFURL::baseURL const): (WebKit::CoreIPCCFURL::bytes const): * Source/WebKit/Shared/Cocoa/CoreIPCCFURL.serialization.in: Copied from Source/WebKit/Shared/cf/CFTypes.serialization.in. * Source/WebKit/Shared/Cocoa/CoreIPCDate.h: (WebKit::CoreIPCDate::CoreIPCDate): * Source/WebKit/Shared/cf/ArgumentCodersCF.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder>::decode): Deleted. * Source/WebKit/Shared/cf/ArgumentCodersCF.h: * Source/WebKit/Shared/cf/CFTypes.serialization.in: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (TEST): Canonical link: https://commits.webkit.org/272318@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c94e71: Stop using CheckedPtr with GraphicsLayer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c94e713f78c210dbe7bff46e9711267812bf7766 https://github.com/WebKit/WebKit/commit/c94e713f78c210dbe7bff46e9711267812bf7766 Author: Chris Dumez Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/GraphicsLayer.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm Log Message: --- Stop using CheckedPtr with GraphicsLayer https://bugs.webkit.org/show_bug.cgi?id=23 Reviewed by Ryosuke Niwa. Stop using CheckedPtr with GraphicsLayer. Use WeakPtr instead to generate more actionable crashes in case of problem. * Source/WebCore/platform/graphics/GraphicsLayer.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm: (WebKit::RemoteLayerTreeContext::~RemoteLayerTreeContext): (WebKit::RemoteLayerTreeContext::adoptLayersFromContext): (WebKit::RemoteLayerTreeContext::graphicsLayerDidEnterContext): (WebKit::RemoteLayerTreeContext::graphicsLayerWillLeaveContext): Canonical link: https://commits.webkit.org/272319@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 633fbf: Use-after-free in FullscreenManager::requestFullsc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 633fbf1eab41bddec1989aadbb319a65200f6633 https://github.com/WebKit/WebKit/commit/633fbf1eab41bddec1989aadbb319a65200f6633 Author: Andy Estes Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: A LayoutTests/fullscreen/fullscreen-cancel-after-request-crash-expected.txt A LayoutTests/fullscreen/fullscreen-cancel-after-request-crash.html M Source/WebCore/dom/FullscreenManager.cpp Log Message: --- Use-after-free in FullscreenManager::requestFullscreenForElement https://bugs.webkit.org/show_bug.cgi?id=263140 rdar://116736343 Reviewed by Chris Dumez. Calling DeferredPromise::reject from the failedPreflights lambda in FullscreenManager::requestFullscreenForElement may cause the Document that owns the FullscreenManager to be deallocated, resulting in a use-after-free when the document is accessed again after rejecting the promise. Resolved this by keeping a Ref to m_document for the lifetime of the failedPreflights lambda. Added a layout test. * LayoutTests/fullscreen/fullscreen-cancel-after-request-crash-expected.txt: Added. * LayoutTests/fullscreen/fullscreen-cancel-after-request-crash.html: Added. * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::requestFullscreenForElement): Originally-landed-as: 267815.332@safari-7617-branch (dc44d44d42fd). rdar://119594954 Canonical link: https://commits.webkit.org/272320@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0471a: Sever window opener on manual navigation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0471a8d0e2bbc0c56745721aeb79ac57b7bd8a0 https://github.com/WebKit/WebKit/commit/e0471a8d0e2bbc0c56745721aeb79ac57b7bd8a0 Author: Ben Nham Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/NavigationAction.cpp M Source/WebCore/loader/NavigationAction.h M Source/WebCore/loader/PolicyChecker.cpp M Source/WebCore/page/ContextMenuController.cpp M Source/WebKit/Shared/NavigationActionData.h M Source/WebKit/Shared/NavigationActionData.serialization.in M Source/WebKit/UIProcess/API/APINavigation.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- Sever window opener on manual navigation https://bugs.webkit.org/show_bug.cgi?id=266354 rdar://118951619 Reviewed by Alex Christensen. When a user does a cross-origin manual navigation (e.g. navigating via the address bar, opening a bookmark, ...), then we should sever the window.opener reference. This should be safe since other browsers are already doing this: https://github.com/whatwg/html/issues/6356. This requires propagating the existing isRequestFromClientOrUserInput flag from more callsites. Previously we were only setting that flag on NavigationAction after a fragment navigation. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::loadDifferentDocumentItem): (WebCore::createWindow): * Source/WebCore/loader/NavigationAction.cpp: (WebCore::NavigationAction::NavigationAction): * Source/WebCore/loader/NavigationAction.h: * Source/WebCore/loader/PolicyChecker.cpp: (WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy): * Source/WebCore/page/ContextMenuController.cpp: (WebCore::openNewWindow): * Source/WebKit/Shared/NavigationActionData.h: * Source/WebKit/Shared/NavigationActionData.serialization.in: * Source/WebKit/UIProcess/API/APINavigation.h: (API::Navigation::isRequestFromClientOrUserInput const): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigationInternal): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::createWindow): * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: (WebKit::WebLocalFrameLoaderClient::didSameDocumentNavigationForFrameViaJSHistoryAPI): (WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::changeLocation): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/272321@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a672d7: Convert more enums to enum classes in RenderObject.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a672d770e472acb0951ddec06c2d290811c63059 https://github.com/WebKit/WebKit/commit/a672d770e472acb0951ddec06c2d290811c63059 Author: Ryosuke Niwa Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderFragmentedFlow.cpp M Source/WebCore/rendering/RenderLayer.h M Source/WebCore/rendering/RenderMultiColumnFlow.cpp M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp Log Message: --- Convert more enums to enum classes in RenderObject.h https://bugs.webkit.org/show_bug.cgi?id=26 Reviewed by Chris Dumez. Converted a few remaining enum types to enum classes. * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::resetEnclosingFragmentedFlowAndChildInfoIncludingDescendants): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::adjustFragmentedFlowStateOnContainingBlockChangeIfNeeded): (WebCore::RenderElement::removeFromRenderFragmentedFlow): (WebCore::RenderElement::removeFromRenderFragmentedFlowIncludingDescendants): * Source/WebCore/rendering/RenderFragmentedFlow.cpp: (WebCore::RenderFragmentedFlow::checkLinesConsistency const): * Source/WebCore/rendering/RenderLayer.h: (WebCore::RenderLayer::isInsideFragmentedFlow const): * Source/WebCore/rendering/RenderMultiColumnFlow.cpp: (WebCore::RenderMultiColumnFlow::RenderMultiColumnFlow): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::setFragmentedFlowStateIncludingDescendants): (WebCore::RenderObject::computedFragmentedFlowState): (WebCore::RenderObject::resetFragmentedFlowStateOnRemoval): (WebCore::enclosingFragmentedFlowFromRenderer): * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::hasVisibleBoxDecorations const): (WebCore::RenderObject::RenderObjectBitfields::setPositionedState): (WebCore::RenderObject::RenderObjectBitfields::setSelectionState): (WebCore::RenderObject::RenderObjectBitfields::setFragmentedFlowState): (WebCore::RenderObject::RenderObjectBitfields::setBoxDecorationState): (WebCore::RenderObject::setHasVisibleBoxDecorations): (WebCore::RenderObject::invalidateBackgroundObscurationStatus): (WebCore::RenderObject::backgroundIsKnownToBeObscured): (WebCore::RenderObject::enclosingFragmentedFlow const): (WebCore::RenderObject::setPositionState): * Source/WebCore/rendering/updating/RenderTreeBuilder.cpp: (WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange): Canonical link: https://commits.webkit.org/272322@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4ad61: AX: Move objectsForIds off of the main thread
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4ad61660d18fb4c6ea566f697dc59bfa0229ae3 https://github.com/WebKit/WebKit/commit/e4ad61660d18fb4c6ea566f697dc59bfa0229ae3 Author: Joshua Hoffman Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M LayoutTests/accessibility/mac/aria-errormessage-expected.txt M LayoutTests/accessibility/mac/aria-errormessage.html M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h Log Message: --- AX: Move objectsForIds off of the main thread https://bugs.webkit.org/show_bug.cgi?id=266608 rdar://116133586 Reviewed by Tyler Wilcock. This patch moves objectsForIDs completely off of the main thread by eagerly caching ignored objects that are origins/targets of relationships. This allows all potentially requested AX objects to be served from the AX thread. These objects are being added as unconnected in two spots: (1) when the isolated tree is initialized and (2) when a new relation is being added. * LayoutTests/accessibility/mac/aria-errormessage-expected.txt: * LayoutTests/accessibility/mac/aria-errormessage.html: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::addRelation): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::create): (WebCore::AXIsolatedTree::objectsForIDs): (WebCore::AXIsolatedTree::addUnconnectedNode): (WebCore::AXIsolatedTree::removeSubtreeFromNodeMap): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: Canonical link: https://commits.webkit.org/272323@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d154d6: Tighten RenderObject's type specific flags
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d154d61d96daec2950b18268d1e63be101ea4c02 https://github.com/WebKit/WebKit/commit/d154d61d96daec2950b18268d1e63be101ea4c02 Author: Ryosuke Niwa Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBox.h M Source/WebCore/rendering/RenderBoxModelObject.cpp M Source/WebCore/rendering/RenderBoxModelObject.h M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderFrameSet.cpp M Source/WebCore/rendering/RenderInline.cpp M Source/WebCore/rendering/RenderLayerModelObject.cpp M Source/WebCore/rendering/RenderLayerModelObject.h M Source/WebCore/rendering/RenderLineBreak.cpp M Source/WebCore/rendering/RenderListMarker.cpp M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/RenderReplaced.cpp M Source/WebCore/rendering/RenderReplica.cpp M Source/WebCore/rendering/RenderTableCol.cpp M Source/WebCore/rendering/RenderTableRow.cpp M Source/WebCore/rendering/RenderTableSection.cpp M Source/WebCore/rendering/RenderText.cpp M Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp Log Message: --- Tighten RenderObject's type specific flags https://bugs.webkit.org/show_bug.cgi?id=266673 Reviewed by Alan Baradlay. This PR introduces TypeSpecificFlags to wrap type specific flags in RenderObject. It can be instantiated by the default constructor as well as with an OptionSet of LineBreakFlag, ReplacedFlag, or SVGModelObjectFlag. The object also remembers the kind of flags stored as a security hardening measure (i.e. to prevent type confusion even when m_type / m_typeFlags and m_typeSpecificFlags get out of sync). Finally, this PR also makes RenderObject::m_typeSpecificFlags const so that it may not get mutated once the render object is initialized. * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): * Source/WebCore/rendering/RenderBox.h: (WebCore::RenderBox::RenderBox): * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::RenderBoxModelObject): * Source/WebCore/rendering/RenderBoxModelObject.h: * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::RenderElement): * Source/WebCore/rendering/RenderElement.h: * Source/WebCore/rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::RenderFrameSet): (WebCore::m_isResizing): Deleted. * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::RenderLayerModelObject): * Source/WebCore/rendering/RenderLayerModelObject.h: * Source/WebCore/rendering/RenderLineBreak.cpp: (WebCore::RenderLineBreak::RenderLineBreak): (WebCore::m_cachedLineHeight): * Source/WebCore/rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::RenderListMarker): (WebCore::m_listItem): Deleted. * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::TypeSpecificFlags::TypeSpecificFlags): (WebCore::RenderObject::TypeSpecificFlags::lineBreakFlags const): (WebCore::RenderObject::TypeSpecificFlags::replacedFlags const): (WebCore::RenderObject::TypeSpecificFlags::svgFlags const): (WebCore::RenderObject::TypeSpecificFlags::valueForKind const): (WebCore::RenderObject::isRenderMedia const): (WebCore::RenderObject::isRenderImage const): (WebCore::RenderObject::isRenderWidget const): (WebCore::RenderObject::isLegacyRenderSVGModelObject const): (WebCore::RenderObject::isRenderSVGModelObject const): (WebCore::RenderObject::isRenderSVGContainer const): (WebCore::RenderObject::isLegacyRenderSVGContainer const): (WebCore::RenderObject::isRenderSVGShape const): (WebCore::RenderObject::isLegacyRenderSVGShape const): (WebCore::RenderObject::isLegacyRenderSVGResourceContainer const): (WebCore::RenderObject::isRenderSVGResourceContainer const): (WebCore::RenderObject::isWBR const): (WebCore::RenderObject::lineBreakFlags const): Deleted. (WebCore::RenderObject::setLineBreakFlags): Deleted. (WebCore::RenderObject::replacedFlags const): Deleted. (WebCore::RenderObject::setReplacedFlags): Deleted. (WebCore::RenderObject::svgFlags const): Deleted. (WebCore::RenderObject::setSVGFlags): Deleted. * Source/WebCore/rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): * Source/WebCore/rendering/RenderReplica.cpp: (WebCore::RenderReplica::RenderReplica): * Source/WebCore/rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::RenderTableCol): * Source/WebCore/rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::RenderTableR
[webkit-changes] [WebKit/WebKit] 89f7f0: [web-animations] refactor animation code related t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89f7f09d29636e18884c6d74eb2790a0c3db2325 https://github.com/WebKit/WebKit/commit/89f7f09d29636e18884c6d74eb2790a0c3db2325 Author: Antoine Quint Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/WebCore/animation/BlendingKeyframes.cpp M Source/WebCore/animation/BlendingKeyframes.h M Source/WebCore/animation/KeyframeEffect.cpp M Source/WebCore/animation/KeyframeEffect.h Log Message: --- [web-animations] refactor animation code related to size-dependent transforms https://bugs.webkit.org/show_bug.cgi?id=266643 rdar://119876112 Reviewed by Simon Fraser. We have recently (272022@main) started accounting for whether a keyframe effect is targeting a transform-related property that is size-dependent. We already had some code that relied on a similar analysis to determine whether applying a keyframe effect required a forced layout prior to initiating an accelerated animation. We move the bits tracking that information from `KeyframeEffect` to `BlendingKeyframes`, which really is the best place to analyze keyframe data, and use the same bits to determine both cases described above. We will add more code to `BlendingKeyframes::analyzeKeyframe()` in the future, removing more code from `KeyframeEffect` and making the various keyframe iterations we do under `KeyframeEffect::setBlendingKeyframes()` more efficient. Finally, note that the code under `KeyframeEffect::computedNeedsForcedLayout()` did not account for the `translate` property while the code under `KeyframeEffect::computeHasSizeDependentTransform` did. The logic from the latter is now being used in both cases, meaning we also account for `translate` to determine whether a forced layout is required. This is the only behavioral change. * Source/WebCore/animation/BlendingKeyframes.cpp: (WebCore::BlendingKeyframes::insert): (WebCore::BlendingKeyframes::analyzeKeyframe): * Source/WebCore/animation/BlendingKeyframes.h: (WebCore::BlendingKeyframes::BlendingKeyframes): (WebCore::BlendingKeyframes::hasWidthDependentTransform const): (WebCore::BlendingKeyframes::hasHeightDependentTransform const): * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::computedNeedsForcedLayout): (WebCore::KeyframeEffect::applyPendingAcceleratedActions): (WebCore::KeyframeEffect::computeHasSizeDependentTransform): * Source/WebCore/animation/KeyframeEffect.h: Canonical link: https://commits.webkit.org/272325@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a2dd49: Update user-visible copyright strings to include 2024
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a2dd4989ff12d732aa18c90a1bc7ed41286edc8b https://github.com/WebKit/WebKit/commit/a2dd4989ff12d732aa18c90a1bc7ed41286edc8b Author: Jeff Miller Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/JavaScriptCore/Info.plist M Source/WebCore/Info.plist M Source/WebGPU/Info.plist M Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist M Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist M Source/WebKit/Info.plist M Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist M Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist M Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist M Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist M Source/WebKitLegacy/mac/Info.plist Log Message: --- Update user-visible copyright strings to include 2024 https://bugs.webkit.org/show_bug.cgi?id=265898 rdar://119212659 Reviewed by Mike Wyrzykowski. * Source/JavaScriptCore/Info.plist: * Source/WebCore/Info.plist: * Source/WebGPU/Info.plist: * Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist: * Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist: * Source/WebKit/Info.plist: * Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist: * Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist: * Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist: * Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist: * Source/WebKitLegacy/mac/Info.plist: Canonical link: https://commits.webkit.org/272326@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
