[webkit-changes] [WebKit/WebKit] ac45a2: [WGSL] Add support for textures

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac45a24e64e7049b9fc1e19b7221d074f30f2d49
  
https://github.com/WebKit/WebKit/commit/ac45a24e64e7049b9fc1e19b7221d074f30f2d49
  Author: Tadeu Zagallo 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebGPU/WGSL/AST/ASTTypeName.h
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/TypeStore.cpp
M Source/WebGPU/WGSL/TypeStore.h
M Source/WebGPU/WGSL/Types.cpp
M Source/WebGPU/WGSL/Types.h

  Log Message:
  ---
  [WGSL] Add support for textures
https://bugs.webkit.org/show_bug.cgi?id=254278


Reviewed by Mike Wyrzykowski.

Still needs the functions that use textures to make it useful, but this patch
adds support for textures in the parser, type checker and code generator.

* Source/WebGPU/WGSL/AST/ASTTypeName.h:
(WGSL::AST::ParameterizedTypeName::stringViewToKind):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/TypeStore.cpp:
(WGSL::TextureKey::extra const):
(WGSL::TypeStore::TypeStore):
(WGSL::TypeStore::textureType):
* Source/WebGPU/WGSL/TypeStore.h:
* Source/WebGPU/WGSL/Types.cpp:
(WGSL::Type::dump const):
* Source/WebGPU/WGSL/Types.h:

Canonical link: https://commits.webkit.org/262063@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bcf280: [media-controls] volume slider should animate when...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bcf280115e84f94ff9f5da5596e20ffb0fceebf8
  
https://github.com/WebKit/WebKit/commit/bcf280115e84f94ff9f5da5596e20ffb0fceebf8
  Author: Antoine Quint 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M 
LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api-expected.txt
M 
LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api-mute-expected.txt
M 
LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api-mute.html
M 
LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api.html
M Source/WebCore/Modules/modern-media-controls/controls/slider-base.js
M 
Source/WebCore/Modules/modern-media-controls/media/media-controller-support.js
M Source/WebCore/Modules/modern-media-controls/media/volume-support.js

  Log Message:
  ---
  [media-controls] volume slider should animate when mute button is toggled
https://bugs.webkit.org/show_bug.cgi?id=254350
rdar://102427937

Reviewed by Dean Jackson.

We used to simply snap the volume slider value as the mute button is toggled. 
Now we use a short animation
by checking we have an event passed to syncControl(), which indicates this is 
not the initial call to syncControl()
where we do not want to animate as we just want to match the initial state of 
the media element.

* 
LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api-expected.txt:
* 
LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api-mute-expected.txt:
* 
LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api-mute.html:
* 
LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api.html:
* Source/WebCore/Modules/modern-media-controls/controls/slider-base.js:
(SliderBase.prototype.set value):
(SliderBase.prototype.setValueAnimated):
(SliderBase.prototype._setValueInternal):
(SliderBase.prototype._handlePointerdownEvent):
* 
Source/WebCore/Modules/modern-media-controls/media/media-controller-support.js:
(MediaControllerSupport.prototype.handleEvent):
* Source/WebCore/Modules/modern-media-controls/media/volume-support.js:
(VolumeSupport.prototype.syncControl):
(VolumeSupport):

Canonical link: https://commits.webkit.org/262064@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dcc989: [MediaStream][GStreamer] Add support for InputDevi...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dcc9895b6eca34153724e9ad1ba1114e5eb83693
  
https://github.com/WebKit/WebKit/commit/dcc9895b6eca34153724e9ad1ba1114e5eb83693
  Author: Philippe Normand 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M 
Source/WebKit/UIProcess/glib/UserMediaPermissionRequestManagerProxyGLib.cpp
M Source/WebKit/WebProcess/glib/UserMediaCaptureManager.cpp
M Source/WebKit/WebProcess/glib/UserMediaCaptureManager.h
M Source/WebKit/WebProcess/glib/UserMediaCaptureManager.messages.in

  Log Message:
  ---
  [MediaStream][GStreamer] Add support for InputDeviceInfo
https://bugs.webkit.org/show_bug.cgi?id=254040

Reviewed by Carlos Garcia Campos.

The GLib UIProcess->WebProcess IPC now takes in account the desire for the 
UIProcess to reveal
device IDs and labels.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebKit/UIProcess/glib/UserMediaPermissionRequestManagerProxyGLib.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::platformGetMediaStreamDevices):
* Source/WebKit/WebProcess/glib/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::getMediaStreamDevices):
* Source/WebKit/WebProcess/glib/UserMediaCaptureManager.h:
* Source/WebKit/WebProcess/glib/UserMediaCaptureManager.messages.in:

Canonical link: https://commits.webkit.org/262065@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4c3e2a: [GStreamer] Harness: Support for output stream cap...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c3e2a4865d080ae74a85e16b5882ccabde11744
  
https://github.com/WebKit/WebKit/commit/4c3e2a4865d080ae74a85e16b5882ccabde11744
  Author: Philippe Normand 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp
M Source/WebCore/platform/gstreamer/GStreamerElementHarness.h

  Log Message:
  ---
  [GStreamer] Harness: Support for output stream caps changes
https://bugs.webkit.org/show_bug.cgi?id=254332

Reviewed by Xabier Rodriguez-Calvar.

The harness was internally caching output stream pad caps but additional caps 
events were not taken
in account. We now clear the cached caps when the pad receives a caps event.

* Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp:
(WebCore::GStreamerElementHarness::Stream::outputCaps):
(WebCore::GStreamerElementHarness::Stream::sinkEvent):
* Source/WebCore/platform/gstreamer/GStreamerElementHarness.h:

Canonical link: https://commits.webkit.org/262066@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0ea376: Add initial slew of tests for wide-layout attachment

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ea376b24d5bd5ed0d5649a940cc60fdf5862e5f
  
https://github.com/WebKit/WebKit/commit/0ea376b24d5bd5ed0d5649a940cc60fdf5862e5f
  Author: Gerald Squelart 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/attachment/cocoa/wide-attachment-class-expected.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-class.html
A 
LayoutTests/fast/attachment/cocoa/wide-attachment-default-icon-expected.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-default-icon.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-dom-expected.txt
A LayoutTests/fast/attachment/cocoa/wide-attachment-dom.html
A 
LayoutTests/fast/attachment/cocoa/wide-attachment-folder-icon-expected.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-folder-icon.html
A 
LayoutTests/fast/attachment/cocoa/wide-attachment-icon-from-file-extension-expected.html
A 
LayoutTests/fast/attachment/cocoa/wide-attachment-icon-from-file-extension.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-id-expected.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-id.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-rendering.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-save-event-expected.txt
A LayoutTests/fast/attachment/cocoa/wide-attachment-save-event.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-uti-expected.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-uti.html
A 
LayoutTests/fast/attachment/cocoa/wide-attachment-wrapping-action-expected-mismatch.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-wrapping-action.html
A 
LayoutTests/fast/attachment/mac/wide-attachment-element-gpu-process-expected.html
A LayoutTests/fast/attachment/mac/wide-attachment-element-gpu-process.html
A 
LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt
A LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic.html
A 
LayoutTests/fast/attachment/mac/wide-attachment-type-attribute-expected.html
A LayoutTests/fast/attachment/mac/wide-attachment-type-attribute.html
M LayoutTests/platform/ios-wk2/TestExpectations
A 
LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
M LayoutTests/platform/mac-wk2/TestExpectations
A 
LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
M Source/WebCore/html/HTMLAttachmentElement.cpp

  Log Message:
  ---
  Add initial slew of tests for wide-layout attachment
https://bugs.webkit.org/show_bug.cgi?id=254203
rdar://106984208

Reviewed by Aditya Keerthi.

Most are copies of the non-"wide" tests.

Minor bugs were revealed and fixed:
- When setting/changing the top-level attachment's id or class (or even style) 
attribute, it was copied to the inner attachment, possibly modifying its 
rendering through css. So instead of indiscriminately copying every attribute, 
only the necessary ones related to the icon/thumbnail display are now copied.
- setFile function calls on the top-level attachment needed to be forwarded to 
the inner attachment to display the correct icon in some cases.

Render tree tests could become proper ref tests once the inner attachment is 
replaced with a standard HTML image element.

* LayoutTests/TestExpectations:
* LayoutTests/fast/attachment/cocoa/wide-attachment-class-expected.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-class.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-default-icon-expected.html: 
Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-default-icon.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-dom-expected.txt: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-dom.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-folder-icon-expected.html: 
Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-folder-icon.html: Added.
* 
LayoutTests/fast/attachment/cocoa/wide-attachment-icon-from-file-extension-expected.html:
 Added.
* 
LayoutTests/fast/attachment/cocoa/wide-attachment-icon-from-file-extension.html:
 Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-id-expected.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-id.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-rendering.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-save-event-expected.txt: 
Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-save-event.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-uti-expected.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-uti.html: Added.
* 
LayoutTests/fast/attachment/cocoa/wide-attachment-wrapping-action-expected-mismatch.html:
 Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-wrapp

[webkit-changes] [WebKit/WebKit] f2f3c9: DFG should support tuples

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2f3c91fa89c2bef7d30bba0324cdba55aa3ae4f
  
https://github.com/WebKit/WebKit/commit/f2f3c91fa89c2bef7d30bba0324cdba55aa3ae4f
  Author: Keith Miller 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M JSTests/stress/for-in-redefine-enumerable.js
M Source/JavaScriptCore/b3/B3LowerToAir.cpp
M Source/JavaScriptCore/b3/B3Type.h
M Source/JavaScriptCore/b3/B3Validate.cpp
M Source/JavaScriptCore/b3/air/AirCCallingConvention.cpp
M Source/JavaScriptCore/b3/air/AirCCallingConvention.h
M Source/JavaScriptCore/b3/air/AirCustom.cpp
M Source/JavaScriptCore/b3/air/AirCustom.h
M Source/JavaScriptCore/b3/air/AirLowerAfterRegAlloc.cpp
M Source/JavaScriptCore/b3/air/AirLowerMacros.cpp
M Source/JavaScriptCore/b3/air/AirOpcode.opcodes
M Source/JavaScriptCore/b3/testb3.h
M Source/JavaScriptCore/b3/testb3_3.cpp
M Source/JavaScriptCore/b3/testb3_5.cpp
M Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGAtTailAbstractState.cpp
M Source/JavaScriptCore/dfg/DFGAtTailAbstractState.h
M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
M Source/JavaScriptCore/dfg/DFGClobberize.h
M Source/JavaScriptCore/dfg/DFGDoesGC.cpp
M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
M Source/JavaScriptCore/dfg/DFGGenerationInfo.h
M Source/JavaScriptCore/dfg/DFGGraph.cpp
M Source/JavaScriptCore/dfg/DFGGraph.h
M Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp
M Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h
M Source/JavaScriptCore/dfg/DFGMayExit.cpp
M Source/JavaScriptCore/dfg/DFGNode.h
M Source/JavaScriptCore/dfg/DFGNodeType.h
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/dfg/DFGOperations.h
M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp
M Source/JavaScriptCore/dfg/DFGSafeToExecute.h
M Source/JavaScriptCore/dfg/DFGScoreBoard.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
M Source/JavaScriptCore/dfg/DFGValidate.cpp
M Source/JavaScriptCore/dfg/DFGVirtualRegisterAllocationPhase.cpp
M Source/JavaScriptCore/ftl/FTLCapabilities.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
M Source/JavaScriptCore/ftl/FTLOutput.cpp
M Source/JavaScriptCore/ftl/FTLOutput.h
M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h

  Log Message:
  ---
  DFG should support tuples
https://bugs.webkit.org/show_bug.cgi?id=253413

Reviewed by Yusuke Suzuki.

This change adds support for tuples in the DFG. It works similarly to how tuples
work in B3 where there is a side buffer which holds most of the metadata for a
tuple. In the DFG there are three pieces of information held here:
1) The reference count
2) The result flags
3) The virtual register

1) tells us if the ExtractFromTuple Node for a given tuple result still exists
(e.g. it could have been constant folded or dead code eliminated). From that we
will decide to fill (3) the virtual register when allocating registers. If we
didn't have the reference count then we would have no way to know that the
virtual registers isn't going to be consumed thus we will leak it. Lastly we
have (2) the result flags for the node. This tells the ExtractFromTuple and
theoretically (as right now the only ExtractFromTuple users produce Int32s) any
 consumers of the ExtractFromTuple what value format the tuple's result will
 be in. For the DFG, we don't need this because we know there's at most one
 ExtractFromTuple for any given tuple index since we don't duplicate code.

When dumping the DFG graph ExtractFromTuple follows the same pattern as B3
and uses `<
EnumeratorNextUpdateIndexAndMode(Check:Untyped:D@97, Check:Untyped:D@98, 
Check:Untyped:D@100, Check:Untyped:D@99, VarArgs, 
SelectUsingPredictions+NonArray+InBounds+AsIs+Read, enumeratorModes = 4, 
R:World, W:Heap, Exits, ClobbersExit, bc#115, ExitValid)
  7  1  0:  D@102:< 1:->ExtractFromTuple(Check:Untyped:D@101, 
Int32|UseAsOther, <<0, bc#115, ExitInvalid)
  8  1  0:  D@103:MovHint(Check:Untyped:D@102, MustGen, loc10, 
W:SideState, ClobbersExit, bc#115, ExitInvalid)
  9  1  0:  D@104:< 1:->ExtractFromTuple(Check:Untyped:D@101, 
Int32|UseAsOther, <<1, bc#115, ExitInvalid)

This patch also adds support for calling operations in both the FTL/B3 via
CCall. CCall can take exactly the tuple of `{ pointerType(), pointerType() }`,
which, for every calling conevention we support, should be returned in both
the return value registers. As the only way to look into a tuple is via the
B3 prodecure, the first Air::Arg of any CCall/ColdCCall Inst is now the
CCallSpecial for the compiling Air::Code. This give

[webkit-changes] [WebKit/WebKit] 99cbb9: [MSE] media/media-source/media-source-fudge-factor...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99cbb993489c885e378a78ee4cf6186268393d4c
  
https://github.com/WebKit/WebKit/commit/99cbb993489c885e378a78ee4cf6186268393d4c
  Author: Jean-Yves Avenard 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M LayoutTests/media/media-source/media-source-fudge-factor-expected.txt
M LayoutTests/media/media-source/media-source-fudge-factor.html

  Log Message:
  ---
  [MSE] media/media-source/media-source-fudge-factor.html times out
https://bugs.webkit.org/show_bug.cgi?id=254385
rdar://107162814

Reviewed by Jer Noble.

The test assumed that it assumes that the `SourceBuffer.updating` attribute
will be false when `loadedmetadata` or `loadeddata` are fired.
This isn't guaranteed, only once `updateend` has fired would the updating
attribute be false, allowing to append more data again to the sourceBuffer.

* LayoutTests/media/media-source/media-source-fudge-factor-expected.txt:
* LayoutTests/media/media-source/media-source-fudge-factor.html:

Canonical link: https://commits.webkit.org/262069@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e6597f: m_styleScope should be a WeakPtr in InlineStyleShe...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6597f549cfd91df23cf7273a3eac8dd053a3887
  
https://github.com/WebKit/WebKit/commit/e6597f549cfd91df23cf7273a3eac8dd053a3887
  Author: Ryosuke Niwa 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebCore/dom/InlineStyleSheetOwner.cpp
M Source/WebCore/dom/InlineStyleSheetOwner.h

  Log Message:
  ---
  m_styleScope should be a WeakPtr in InlineStyleSheetOwner
https://bugs.webkit.org/show_bug.cgi?id=254397

Reviewed by Chris Dumez.

Use WeakPtr instead of a raw pointer in InlineStyleSheetOwner for Style::Scope.

* Source/WebCore/dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::insertedIntoDocument):
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):
* Source/WebCore/dom/InlineStyleSheetOwner.h:
(WebCore::InlineStyleSheetOwner::styleScope):

Canonical link: https://commits.webkit.org/262070@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ad2552: [MSE] media/media-source/media-source-video-playba...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad2552fcc7cd07baec962277407e66dffa2c33d7
  
https://github.com/WebKit/WebKit/commit/ad2552fcc7cd07baec962277407e66dffa2c33d7
  Author: Jean-Yves Avenard 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M 
LayoutTests/media/media-source/media-source-video-playback-quality-expected.txt
M LayoutTests/media/media-source/media-source-video-playback-quality.html

  Log Message:
  ---
  [MSE] media/media-source/media-source-video-playback-quality.html is a 
constant failure with MockMSE in GPUP
https://bugs.webkit.org/show_bug.cgi?id=254405
rdar://107182984

Reviewed by Youenn Fablet.

To get a valid VideoPlaybackQuality object about all the frames contained
in the SourceBuffer we must get the entire content first.
We modify the test so that the video is played to the end first and only
then get the VideoPlaybackQuality.

* 
LayoutTests/media/media-source/media-source-video-playback-quality-expected.txt:
* LayoutTests/media/media-source/media-source-video-playback-quality.html:

Canonical link: https://commits.webkit.org/262071@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b88c11: Implement URL.canParse()

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b88c11e4a3a5cb6c39f145d059412aedae8e581b
  
https://github.com/WebKit/WebKit/commit/b88c11e4a3a5cb6c39f145d059412aedae8e581b
  Author: Anne van Kesteren 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/url/historical.any-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/url/historical.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/url/historical.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.js
M Source/WebCore/html/DOMURL.cpp
M Source/WebCore/html/DOMURL.h
M Source/WebCore/html/DOMURL.idl

  Log Message:
  ---
  Implement URL.canParse()
https://bugs.webkit.org/show_bug.cgi?id=254147
rdar://106934916

Reviewed by Chris Dumez.

Additionally removes an overload that's not supported by the URL Standard.

* LayoutTests/imported/w3c/web-platform-tests/url/historical.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/historical.any.js:
(test):
* 
LayoutTests/imported/w3c/web-platform-tests/url/historical.any.worker-expected.txt:

Changes exported via https://github.com/web-platform-tests/wpt/pull/39177.

* 
LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.html: 
Added.
* LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.js: 
Added.
(forEach):

Imported from upstream.

* Source/WebCore/html/DOMURL.cpp:
(WebCore::DOMURL::canParse):
* Source/WebCore/html/DOMURL.h:
* Source/WebCore/html/DOMURL.idl:

Canonical link: https://commits.webkit.org/262072@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b0be55: Synchronize fetch/range WPT

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0be554718782f99c5f3ccb19b11ca0084c147ea
  
https://github.com/WebKit/WebKit/commit/b0be554718782f99c5f3ccb19b11ca0084c147ea
  Author: Anne van Kesteren 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/fetch/range/blob.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/fetch/range/blob.any.worker.html
M LayoutTests/imported/w3c/web-platform-tests/fetch/range/w3c-import.log

  Log Message:
  ---
  Synchronize fetch/range WPT
https://bugs.webkit.org/show_bug.cgi?id=254416
rdar://107184642

Reviewed by Youenn Fablet.

Corrects oversight of 09841b4faec73a9d1b15b37d68941a995f33cadf.

* 
LayoutTests/imported/w3c/web-platform-tests/fetch/range/blob.any.worker-expected.txt:
 Added.
* LayoutTests/imported/w3c/web-platform-tests/fetch/range/blob.any.worker.html: 
Added.
* LayoutTests/imported/w3c/web-platform-tests/fetch/range/w3c-import.log:

Canonical link: https://commits.webkit.org/262073@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e322dc: [EGL] Merge GLContext and GLContextEGL

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e322dc6f4a1493e12924c3d4e8f51351ed00a733
  
https://github.com/WebKit/WebKit/commit/e322dc6f4a1493e12924c3d4e8f51351ed00a733
  Author: Carlos Garcia Campos 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/PlatformPlayStation.cmake
M Source/WebCore/PlatformWin.cmake
M Source/WebCore/SourcesGTK.txt
M Source/WebCore/SourcesWPE.txt
R Source/WebCore/platform/graphics/GLContext.cpp
R Source/WebCore/platform/graphics/GLContext.h
M Source/WebCore/platform/graphics/PlatformDisplay.cpp
A Source/WebCore/platform/graphics/egl/GLContext.cpp
A Source/WebCore/platform/graphics/egl/GLContext.h
R Source/WebCore/platform/graphics/egl/GLContextEGL.cpp
R Source/WebCore/platform/graphics/egl/GLContextEGL.h
R Source/WebCore/platform/graphics/egl/GLContextEGLLibWPE.cpp
R Source/WebCore/platform/graphics/egl/GLContextEGLWayland.cpp
R Source/WebCore/platform/graphics/egl/GLContextEGLX11.cpp
A Source/WebCore/platform/graphics/egl/GLContextLibWPE.cpp
A Source/WebCore/platform/graphics/egl/GLContextWayland.cpp
A Source/WebCore/platform/graphics/egl/GLContextX11.cpp
M Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp
M Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp
M 
Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerDmabuf.cpp
M Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp
M Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp
M Source/WebCore/platform/xr/openxr/PlatformXROpenXR.h
M Source/WebKit/GPUProcess/graphics/wc/WCSceneContext.cpp
M 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp
M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp
M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp

  Log Message:
  ---
  [EGL] Merge GLContext and GLContextEGL
https://bugs.webkit.org/show_bug.cgi?id=254270

Reviewed by Adrian Perez de Castro.

GLContextEGL is now the only implementation of GLContext, so there's no
reason to have a base abstract class.

* Source/WebCore/Headers.cmake:
* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebCore/PlatformWin.cmake:
* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/SourcesWPE.txt:
* Source/WebCore/platform/graphics/GLContext.cpp: Removed.
* Source/WebCore/platform/graphics/GLContext.h: Removed.
* Source/WebCore/platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::sharingGLContext):
(WebCore::PlatformDisplay::initializeEGLDisplay):
* Source/WebCore/platform/graphics/egl/GLContext.cpp: Renamed from 
Source/WebCore/platform/graphics/egl/GLContextEGL.cpp.
(WebCore::initializeOpenGLShimsIfNeeded):
(WebCore::GLContext::errorString):
(WebCore::GLContext::lastErrorString):
(WebCore::GLContext::getEGLConfig):
(WebCore::GLContext::createWindowContext):
(WebCore::GLContext::createPbufferContext):
(WebCore::GLContext::createSurfacelessContext):
(WebCore::GLContext::createContext):
(WebCore::GLContext::createOffscreen):
(WebCore::GLContext::createSharing):
(WebCore::GLContext::GLContext):
(WebCore::GLContext::~GLContext):
(WebCore::GLContext::createContextForEGLVersion):
(WebCore::GLContext::makeContextCurrent):
(WebCore::GLContext::current):
(WebCore::GLContext::swapBuffers):
(WebCore::GLContext::platformContext):
(WebCore::GLContext::isExtensionSupported):
(WebCore::GLContext::version):
* Source/WebCore/platform/graphics/egl/GLContext.h: Added.
(WebCore::GLContext::display const):
(WebCore::GLContext::config const):
* Source/WebCore/platform/graphics/egl/GLContextEGL.h: Removed.
* Source/WebCore/platform/graphics/egl/GLContextEGLLibWPE.cpp:
(WebCore::GLContext::GLContext):
(WebCore::GLContext::createWindowSurfaceWPE):
(WebCore::GLContext::createWPEContext):
(WebCore::GLContext::destroyWPETarget):
(WebCore::GLContextEGL::GLContextEGL): Deleted.
(WebCore::GLContextEGL::createWindowSurfaceWPE): Deleted.
(WebCore::GLContextEGL::createWPEContext): Deleted.
(WebCore::GLContextEGL::destroyWPETarget): Deleted.
* Source/WebCore/platform/graphics/egl/GLContextEGLWayland.cpp:
(WebCore::GLContext::GLContext):
(WebCore::GLContext::createWindowSurfaceWayland):
(WebCore::GLContext::createWaylandContext):
(WebCore::GLContext::destroyWaylandWindow):
(WebCore::GLContextEGL::GLContextEGL): Deleted.
(WebCore::GLContextEGL::createWindowSurfaceWayland): Deleted.
(WebCore::GLContextEGL::createWaylandContext): Deleted.
(WebCore::GLContextEGL::destroyWaylandWindow): Deleted.
* Source/WebCore/platform/graphics/egl/GLContextEGLX11.cpp:
(WebCore::GLContext::GLContext):
(WebCore::GLContext::createWindowSurfaceX11):
(WebCore::GLContext::createPixmapContext):
(WebCore::GLContextEGL::GLContextEGL): Deleted.
(WebCore::GLContextEGL::createWindowS

[webkit-changes] [WebKit/WebKit] 9a3c1c: [GTK] Allow pasting content with async clipboard w...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a3c1c8a39911a0a0ecb0d51b142369ce0177fbe
  
https://github.com/WebKit/WebKit/commit/9a3c1c8a39911a0a0ecb0d51b142369ce0177fbe
  Author: Carlos Garcia Campos 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M LayoutTests/platform/gtk/TestExpectations
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp

  Log Message:
  ---
  [GTK] Allow pasting content with async clipboard when origin is the same
https://bugs.webkit.org/show_bug.cgi?id=254408

Reviewed by Michael Catanzaro.

* LayoutTests/platform/gtk/TestExpectations:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::requestDOMPasteAccess):

Canonical link: https://commits.webkit.org/262075@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 46d858: Animations inside a Details tag only fire once

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46d8589593777d7e9f8f23c66beabb1217205ba7
  
https://github.com/WebKit/WebKit/commit/46d8589593777d7e9f8f23c66beabb1217205ba7
  Author: Antoine Quint 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed.html
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp

  Log Message:
  ---
  Animations inside a Details tag only fire once
https://bugs.webkit.org/show_bug.cgi?id=254401

Reviewed by Antti Koivisto.

We should always cancel declarative animations in case of a Full teardown, and 
never
in the FullAfterSlotChange case. We remove the FALLTHROUGH to make this all 
clearer
and better distinguish the Full and FullAfterSlotChange cases.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed.html:
 Added.
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):

Canonical link: https://commits.webkit.org/262076@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2c9b83: RenderBlockFlows with no children should not even ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c9b8339e50271164d25924f3480325ac745840d
  
https://github.com/WebKit/WebKit/commit/2c9b8339e50271164d25924f3480325ac745840d
  Author: Alan Baradlay 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  ---
  RenderBlockFlows with no children should not even try to run inline layout
https://bugs.webkit.org/show_bug.cgi?id=254391

Reviewed by Antti Koivisto.

1. RenderBlockFlow's initial state is m_childrenInline = true
2. m_childrenInline is set to true when the block ends up with no children.
3. childrenInline() makes RenderBlockFlow run inline layout.

Initiating layout (IFC or BFC) does not make much sense when there's nothing to 
run layout on.

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren): RenderSVGText calls 
layoutInlineChildren with no children :|

Canonical link: https://commits.webkit.org/262077@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d71134: WritableStreamDefaultController constructor should...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d711341632f4ca031f5a5d2e6088b21e6a3fb0cc
  
https://github.com/WebKit/WebKit/commit/d711341632f4ca031f5a5d2e6088b21e6a3fb0cc
  Author: Youenn Fablet 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/constructor.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/constructor.any.worker-expected.txt
M Source/WebCore/Modules/streams/WritableStreamDefaultController.js

  Log Message:
  ---
  WritableStreamDefaultController constructor should throw if called directly
https://bugs.webkit.org/show_bug.cgi?id=254418
rdar://problem/107185937

Reviewed by Alex Christensen.

Fix the check in initializeWritableStreamDefaultController to make sure the 
constructor will throw.

* 
LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/constructor.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/constructor.any.worker-expected.txt:
* Source/WebCore/Modules/streams/WritableStreamDefaultController.js:
(initializeWritableStreamDefaultController):

Canonical link: https://commits.webkit.org/262078@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 44e1ce: ReadableStream.tee should make sure to have its in...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44e1ce63f4c05e126cc819df8b71b633e837285b
  
https://github.com/WebKit/WebKit/commit/44e1ce63f4c05e126cc819df8b71b633e837285b
  Author: Youenn Fablet 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/tee.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/tee.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/tee.any.sharedworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/tee.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee.any.serviceworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee.any.sharedworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee.any.worker-expected.txt
M Source/WebCore/Modules/streams/ReadableStreamInternals.js

  Log Message:
  ---
  ReadableStream.tee should make sure to have its internal pull promises handled
https://bugs.webkit.org/show_bug.cgi?id=254407
rdar://problem/107183268

Reviewed by Alex Christensen.

Make sure that the read promise used for teeing is handled.
We do not currently use the rejection handler as we handle closure with the 
closed promise.
A follow-up patch should update the tee algorithm to the latest specification.

* 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/tee.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/tee.any.sharedworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/tee.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/tee.any.worker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee.any.serviceworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee.any.sharedworker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee.any.worker-expected.txt:
* Source/WebCore/Modules/streams/ReadableStreamInternals.js:
(readableStreamTeePullFunction):

Canonical link: https://commits.webkit.org/262079@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e78009: ARQL: Launch Preview needs to be passed along the ...

[Dean Jackson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e7800968d1c8f502c22250854397d16fd0679cde
  
https://github.com/WebKit/WebKit/commit/e7800968d1c8f502c22250854397d16fd0679cde
  Author: Dean Jackson 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm
M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm

  Log Message:
  ---
  ARQL: Launch Preview needs to be passed along the appropriate disableScaling 
and customSharing fragment identifiers
https://bugs.webkit.org/show_bug.cgi?id=254371
rdar://106193234

Reviewed by Antoine Quint.

ARQL needs to see the fragment identifier on the link in order
to do things like disable scaling.

* Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm:
(WebKit::LegacyDownloadClient::didCreateDestination): Pass along the fragment 
identifier.
(WebKit::LegacyDownloadClient::didFinish): Copy the code from above.
* Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Don't 
explicitly remove the fragment identifier.

Canonical link: https://commits.webkit.org/262080@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 812232: Trimmed block-start margins for flex items in hori...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81223299d3fb4a43229294386028092f559b5944
  
https://github.com/WebKit/WebKit/commit/81223299d3fb4a43229294386028092f559b5944
  Author: Sammy Gill 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-block-start-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-block-start.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-multi-line-block-start-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-multi-line-block-start.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-block-start-dynamic-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-block-start-dynamic.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-block-start-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-block-start.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-multi-line-block-start-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-multi-line-block-start.html
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderObject.h

  Log Message:
  ---
  Trimmed block-start margins for flex items in horizontal writing mode should 
be reflected in computed style
https://bugs.webkit.org/show_bug.cgi?id=253712
rdar://106558991

Reviewed by Alan Baradlay.

Whenever we trim a block-start margin for a flex item, we should include
a bit of information for this trimmed margin as a piece of rare data
for the object. The trimming is done inside trimMainAxisMarginStart and
trimCrossAxisMarginStart, so we can wrap abstract the trimming into a
new helper method, RenderBlock::setTrimmedMarginForChild. This new
helper will trim the correct margin and also set the corresponding bit
of rare data

Then, inside of ComputedStyleExtractor we can check
if this bit has been set when trying to determine the block-start margin
when the flexbox is in horizontal writing-mode (i.e. the top margin).

For flex layout, we can clear these new bits whenever we go through
another layout and recreate the flex items.

We also need to update the conditions for determining whether the
margin-top property is layout dependent by taking into consideration
margin-trim. For flex items, this can be done by checking the set
margin-trim values on the flexbox.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-block-start-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-block-start.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-multi-line-block-start-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-column-multi-line-block-start.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-block-start-dynamic-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-block-start-dynamic.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-block-start-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-block-start.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-multi-line-block-start-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/flexbox-row-multi-line-block-start.html:
 Added.
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::isFlexItem):
(WebCore::rendererContainingBlockHasMarginTrim):
(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::setTrimmedMarginForChild):
* Source/WebCore/rendering/RenderBlock.h:
* S

[webkit-changes] [WebKit/WebKit] 0d254e: [UI-side compositing] Add infrastructure to get sc...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d254e93fc60fdfa8b1d64540af11826969c31c6
  
https://github.com/WebKit/WebKit/commit/0d254e93fc60fdfa8b1d64540af11826969c31c6
  Author: Nikolaos Mouchtaris 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h
M Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h
M Source/WebCore/page/scrolling/mac/ScrollerMac.h
M Source/WebCore/page/scrolling/mac/ScrollerMac.mm
M Source/WebCore/page/scrolling/mac/ScrollerPairMac.h
M Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm
M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h
M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.cpp
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
M Tools/WebKitTestRunner/mac/UIScriptControllerMac.h
M Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm

  Log Message:
  ---
  [UI-side compositing] Add infrastructure to get scrollbar state in layout 
tests
https://bugs.webkit.org/show_bug.cgi?id=254372
rdar://107154212

Reviewed by Simon Fraser.

Add UI-script controller function for getting scrollbar state for a scrolling 
tree
node id. Add an internals function for getting the scrolling tree node id from a
node.

* 
LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-reveal.html:
* Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:
* Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h:
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollbarStateForOrientation 
const):
* Source/WebCore/page/scrolling/mac/ScrollerMac.h:
* Source/WebCore/page/scrolling/mac/ScrollerMac.mm:
(WebCore::ScrollerMac::scrollbarState const):
* Source/WebCore/page/scrolling/mac/ScrollerPairMac.h:
* Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm:
(WebCore::ScrollerPairMac::scrollbarStateForOrientation const):
* Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
* Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
(WebCore::ScrollingTreeScrollingNodeDelegateMac::scrollbarStateForOrientation 
const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::scrollingNodeIDForNode):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _scrollbarStateForScrollingNodeID:isVertical:]):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::scrollbarStateForScrollingNodeID):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp:
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::scrollbarStateForOrientation 
const):
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h:
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.cpp:
(WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::scrollbarStateForOrientation
 const):
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scrollbarStateForScrollingNodeID):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::scrollbarStateForScrollingNodeID const):
* Tools/WebKitTestRunner/mac/UIScriptControllerMac.h:
* Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptControllerMac::scrollbarStateForScrollingNodeID const):

Canonical link: https://commits.webkit.org/262082@main


___
webkit-c

[webkit-changes] [WebKit/WebKit] c0b222: WebCore: Prefer mutableCopy over mutableCopyWithZone

[Rose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0b2221b92ed2006b6216173610b438198f5a620
  
https://github.com/WebKit/WebKit/commit/c0b2221b92ed2006b6216173610b438198f5a620
  Author: Rose <83477269+ataridre...@users.noreply.github.com>
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebCore/platform/mac/WebNSAttributedStringExtras.mm
M Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm

  Log Message:
  ---
  WebCore: Prefer mutableCopy over mutableCopyWithZone
https://bugs.webkit.org/show_bug.cgi?id=253825

Reviewed by Chris Dumez.

The mutableCopyWithZone method is not overridden, nor is the
zone parameter even acknowledged anymore by the Objective-C
runtime. We should replace calls to mutableCopyWithZone with
calls to mutableCopy.

* Source/WebCore/platform/mac/WebNSAttributedStringExtras.mm:
  (attributedStringByStrippingAttachmentCharacters): Replace
  mutableCopyWithZone with mutableCopy.

* Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:
  (initWithSession): Ditto.

Canonical link: https://commits.webkit.org/262083@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f953a3: JavaScriptCore: m_linkBuffer should be initialized...

[Rose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f953a3491357343e2784b672e31b779d15ca3be8
  
https://github.com/WebKit/WebKit/commit/f953a3491357343e2784b672e31b779d15ca3be8
  Author: Rose <83477269+ataridre...@users.noreply.github.com>
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/JavaScriptCore/jit/JIT.cpp

  Log Message:
  ---
  JavaScriptCore: m_linkBuffer should be initialized via WTF::makeUnique
https://bugs.webkit.org/show_bug.cgi?id=253156

Reviewed by Chris Dumez.

m_linkBuffer can be fast-allocated, so let's do this via WTF::makeUnique.

* Source/JavaScriptCore/jit/JIT.cpp:(JIT::compileAndLinkWithoutFinalizing):
  Use WTF::MakeUnique to initialize m_linkBuffer.

Canonical link: https://commits.webkit.org/262084@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a2a797: Re-import css/css-color WPT

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2a7976c62fa708453dc1ccfca1ae2bd77ec86f0
  
https://github.com/WebKit/WebKit/commit/a2a7976c62fa708453dc1ccfca1ae2bd77ec86f0
  Author: Tim Nguyen 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/css/css-color/oklch-010.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-function-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-function.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-lab-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-lab.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-function-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-function.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-mix-function-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-mix-function.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-function-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-function.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-lab-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-lab.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/gamut-mapping-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/gamut-mapping.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/w3c-import.log

  Log Message:
  ---
  Re-import css/css-color WPT
https://bugs.webkit.org/show_bug.cgi?id=254429
rdar://107190185

Reviewed by Simon Fraser.

Upstream revision: 
https://github.com/web-platform-tests/wpt/commit/cb2b2f3bc52dd7c61057cead5bc42f1f72d6828e

* LayoutTests/imported/w3c/web-platform-tests/css/css-color/oklch-010.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-function-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-function.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-lab-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-lab.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-function-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-function.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-mix-function-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-mix-function.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-function-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-function.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-lab-expect

[webkit-changes] [WebKit/WebKit] e74aa7: [UI-side compositing] tiled-drawing/tiled-backing-...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e74aa7f36cbd532f681b2c015002264a7d756b52
  
https://github.com/WebKit/WebKit/commit/e74aa7f36cbd532f681b2c015002264a7d756b52
  Author: Wenson Hsieh 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M LayoutTests/tiled-drawing/tiled-backing-in-window.html
M Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm

  Log Message:
  ---
  [UI-side compositing] tiled-drawing/tiled-backing-in-window.html fails when 
run on a 2x display
https://bugs.webkit.org/show_bug.cgi?id=254387
rdar://107038034

Reviewed by Simon Fraser.

This test fails when UI-side compositing is enabled. Consider the following 
sequence of events,
immediately upon unparenting the web view via `UIScriptController`, when 
running the test on a 2x
display with GPUP and UI-side compositing enabled:

1.  In the UI process, we schedule an activity state change (to tell the web 
process that the view
is no longer in a window).

2.  At the same time, we send an IPC message 
`WebPage::SetDeviceScaleFactor(2.0)` (the intrinsic
device scale is 2.0 in the UI process after unparenting the web view, since 
we fall back to the
main `NSScreen`'s `-backingScaleFactor`).

3.  In the web process, we receive the new device scale of 2.0, and mark each 
graphics layer with a
dirty bit: `LayerChange::ContentsScaleChanged`.

4.  In the web process, we then perform a rendering update that was previously 
scheduled (for any
reason). This causes us to `flushCompositingState` on the root layer, and 
recursively apply the
new contents scale to all sublayers.

5.  In the UI process, we then (finally) dispatch the activity state change 
that was scheduled in
step (1).

6.  In the web process, we receive the new activity state, and detach the root 
layer underneath
`RenderLayerCompositor::setIsInWindow`, with `isInWindow := false`.

Thus, each `PlatformCALayerRemote` ends up with a scale of 2.0 instead of 1.0 
after unparenting the
web view, which is reflected in the output of `layerTreeAsText`. In contrast, 
when GPUP and UI-side
compositing are disabled, step (4) occurs after (5-6) above, which causes us to 
bail earlier before
flushing the new backing store scale to the layer tree:

```
void RenderLayerCompositor::flushPendingLayerChanges(bool isFlushRoot)
{
…
if (rootLayerAttachment() == RootLayerUnattached) {
m_shouldFlushOnReattach = true;
return;  // < We early return here in the non-GPUP 
case.
}
…
```

...which allows the layers to retain a device scale of 1. Due to the fact that 
it's unclear whether
the post-GPUP behavior is better or worse (as the old behavior effectively 
leaves the layer content
scales out of sync with the device scale factor in the UI process), it's 
probably best to just fix
this test by making the test itself by forcing a `deviceScaleFactor` of 1.0.

* LayoutTests/tiled-drawing/tiled-backing-in-window.html:
* Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::changeWindowScaleIfNeeded):

Ensure that we actually call into `-_setOverrideDeviceScaleFactor:` when 
specifying a
`deviceScaleFactor=1.0` test runner option, by adjusting the implementation of 
this helper method
to not early return from the entire function if only the window's 
`-backingScaleFactor` matches.

Canonical link: https://commits.webkit.org/262086@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 075303: [ews-build.webkit.org] Convert add_label to Twiste...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 075303e0b2dd27b1bf1327618e9a091d06a22320
  
https://github.com/WebKit/WebKit/commit/075303e0b2dd27b1bf1327618e9a091d06a22320
  Author: Jonathan Bedard 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews-build.webkit.org] Convert add_label to Twisted requests
https://bugs.webkit.org/show_bug.cgi?id=251724
rdar://105023225

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.add_label): Use Twisted's request library.
(BlockPullRequest.run): add_label returns a deferred object.

Canonical link: https://commits.webkit.org/262087@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 221245: Fix PlayStation build after 262028@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2212452ed568748cfc593768086088f05f88e04a
  
https://github.com/WebKit/WebKit/commit/2212452ed568748cfc593768086088f05f88e04a
  Author: Don Olmstead 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Tools/MiniBrowser/playstation/MainWindow.cpp

  Log Message:
  ---
  Fix PlayStation build after 262028@main
https://bugs.webkit.org/show_bug.cgi?id=254439

Unreviewed build fix.

The include directory changes of 262028@main exposed an issue where
a `config.h` was being included in `MainWindow.cpp`. That file shouldn't
be available when compiling MiniBrowser.

Canonical link: https://commits.webkit.org/262088@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5bbb19: Fix build of ReloadPageAfterCrash on PlayStation

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5bbb190d55b93bc4947282cea2cc0dbd66bcada6
  
https://github.com/WebKit/WebKit/commit/5bbb190d55b93bc4947282cea2cc0dbd66bcada6
  Author: Don Olmstead 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp

  Log Message:
  ---
  Fix build of ReloadPageAfterCrash on PlayStation
https://bugs.webkit.org/show_bug.cgi?id=254440

Unreviewed build fix.

Wrong `USE` macro was being used for PlayStation with the WPE backend.

Canonical link: https://commits.webkit.org/262089@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0610e6: [hooks/pre-push] Handle no defined security level

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0610e673a8500b4924a29caab72a4c08d2daf393
  
https://github.com/WebKit/WebKit/commit/0610e673a8500b4924a29caab72a4c08d2daf393
  Author: Jonathan Bedard 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Tools/Scripts/hooks/pre-push

  Log Message:
  ---
  [hooks/pre-push] Handle no defined security level
https://bugs.webkit.org/show_bug.cgi?id=254299
rdar://107108896

Reviewed by Stephanie Lewis.

* Tools/Scripts/hooks/pre-push: Ensure that there is
always at least one value in MAX_LEVEL.

Canonical link: https://commits.webkit.org/262090@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 146943: Platform should support showing more descriptive l...

[dewei-zhu]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 14694378eb0cc9e6f21841c5cd22ca976883adae
  
https://github.com/WebKit/WebKit/commit/14694378eb0cc9e6f21841c5cd22ca976883adae
  Author: Dewei Zhu 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Websites/perf.webkit.org/init-database.sql
M Websites/perf.webkit.org/migrate-database.sql
M Websites/perf.webkit.org/public/admin/platforms.php
M Websites/perf.webkit.org/public/include/manifest-generator.php
M Websites/perf.webkit.org/public/v3/components/chart-styles.js
M 
Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js
M 
Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js
M Websites/perf.webkit.org/public/v3/models/platform.js
M Websites/perf.webkit.org/public/v3/pages/chart-pane.js
M Websites/perf.webkit.org/public/v3/pages/summary-page.js
M Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js
M Websites/perf.webkit.org/server-tests/api-manifest-tests.js

  Log Message:
  ---
  Platform should support showing more descriptive label instead of name.
https://bugs.webkit.org/show_bug.cgi?id=254360
rdar://107119770

Reviewed by Alexey Proskuryakov.

Add label field to 'platform' table to have the ability to show more decriptive
content for the platform with more flexibility.

* Websites/perf.webkit.org/init-database.sql: Added 'platform_label' to 
'platform' table.
* Websites/perf.webkit.org/migrate-database.sql: Added migration sql.
* Websites/perf.webkit.org/public/admin/platforms.php: Added support to edit 
platform.label in admin page.
* Websites/perf.webkit.org/public/include/manifest-generator.php: Expose 
platform.label to manifest.
* Websites/perf.webkit.org/public/v3/components/chart-styles.js:
(ChartStyles.resolveConfiguration): Use platform.label instead of platform.name.
* 
Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js:
(CustomAnalysisTaskConfigurator.prototype._updateTriggerable):
* 
Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js:
(CustomConfigurationTestGroupForm.prototype._updateTestGroupName): Use 
platform.label instead of platform.name.
* Websites/perf.webkit.org/public/v3/models/platform.js:
(Platform):
(Platform.prototype.label): Added label function to expose label information 
and fallback to platform name when
platform label is not specified.
* Websites/perf.webkit.org/public/v3/pages/chart-pane.js:
(ChartPane.prototype.render):
* Websites/perf.webkit.org/public/v3/pages/summary-page.js: Use platform.label 
instead of platform.name.
(SummaryPage.prototype._warningTextForGroup.mapAndSortByName):
* Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js: Use 
platform.label instead of platform.name.
(TestFreshnessPage.prototype._renderTooltip):
* Websites/perf.webkit.org/server-tests/api-manifest-tests.js: Updated unit 
tests.

Canonical link: https://commits.webkit.org/262091@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dcbe42: REGRESSION(260512@main) canvas-drawImage-hdr-video...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dcbe4246df7ca914970da5c40e0e550066696823
  
https://github.com/WebKit/WebKit/commit/dcbe4246df7ca914970da5c40e0e550066696823
  Author: Said Abou-Hallawa 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M LayoutTests/fast/canvas/canvas-drawImage-hdr-video-expected.txt
M LayoutTests/fast/canvas/canvas-drawImage-hdr-video.html
M LayoutTests/platform/glib/TestExpectations
R 
LayoutTests/platform/glib/fast/canvas/canvas-drawImage-hdr-video-expected.txt
R 
LayoutTests/platform/ios/fast/canvas/canvas-drawImage-hdr-video-expected.txt

  Log Message:
  ---
  REGRESSION(260512@main) canvas-drawImage-hdr-video.html has been consistently 
failing on the EWS bots
https://bugs.webkit.org/show_bug.cgi?id=254293
rdar://107083380

Reviewed by Simon Fraser.

Use a small tolerance when comparing the drawn pixel and the expected pixel. And
remove the platform expected results.

* LayoutTests/fast/canvas/canvas-drawImage-hdr-video-expected.txt:
* LayoutTests/fast/canvas/canvas-drawImage-hdr-video.html:
* LayoutTests/platform/glib/TestExpectations:
* 
LayoutTests/platform/glib/fast/canvas/canvas-drawImage-hdr-video-expected.txt: 
Removed.
* LayoutTests/platform/ios/fast/canvas/canvas-drawImage-hdr-video-expected.txt: 
Removed.

Canonical link: https://commits.webkit.org/262092@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0915a4: Move "Image Animation Control Enabled" to Animatio...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0915a453f8948722c7419e7ab0a796453df3bb65
  
https://github.com/WebKit/WebKit/commit/0915a453f8948722c7419e7ab0a796453df3bb65
  Author: Tim Nguyen 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Move "Image Animation Control Enabled" to Animation category in 
UnifiedWebPreferences.yaml
https://bugs.webkit.org/show_bug.cgi?id=254442
rdar://107199263

Reviewed by Tyler Wilcock.

DOM category is inaccurate. Also remove "Enabled" from the user-visible label, 
since none of the flags have this.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/262093@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 374bed: Move WebCodecs prefs to Media category in UnifiedW...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 374bed4d2a56f04d9154a7501ea73c53548182d5
  
https://github.com/WebKit/WebKit/commit/374bed4d2a56f04d9154a7501ea73c53548182d5
  Author: Tim Nguyen 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Move WebCodecs prefs to Media category in UnifiedWebPreferences.yaml
https://bugs.webkit.org/show_bug.cgi?id=254436
rdar://107198355

Reviewed by Brent Fulgham.

The WebCodecs API is for audio/video processing.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/262094@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 589cb4: iPad test results have not kept up with the new te...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 589cb41a4fd737789773468b7b99d01b0f64b9f4
  
https://github.com/WebKit/WebKit/commit/589cb41a4fd737789773468b7b99d01b0f64b9f4
  Author: Brent Fulgham 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M 
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt

  Log Message:
  ---
  iPad test results have not kept up with the new testable features in the build
https://bugs.webkit.org/show_bug.cgi?id=254438


Reviewed by Tim Nguyen.

A few CSS features that are now 'testable' are not properly reflected in the 
iPad test results.

* 
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

Canonical link: https://commits.webkit.org/262095@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1d4bf9: Reserve capacity for SelectorFilter::m_parentStack

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d4bf960fa26c85635d3a3c15b1eecc837fba280
  
https://github.com/WebKit/WebKit/commit/1d4bf960fa26c85635d3a3c15b1eecc837fba280
  Author: Chris Dumez 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebCore/css/SelectorFilter.cpp
M Source/WebCore/css/SelectorFilter.h
M Source/WebCore/style/StyleInvalidator.cpp

  Log Message:
  ---
  Reserve capacity for SelectorFilter::m_parentStack
https://bugs.webkit.org/show_bug.cgi?id=254423

Reviewed by Darin Adler.

Reserve capacity for SelectorFilter::m_parentStack for cases where we know how
many ancestors we're about to push.

* Source/WebCore/css/SelectorFilter.cpp:
(WebCore::SelectorFilter::initializeParentStack):
* Source/WebCore/css/SelectorFilter.h:
(WebCore::SelectorFilter::parentStackReserveInitialCapacity):
* Source/WebCore/style/StyleInvalidator.cpp:
(WebCore::Style::Invalidator::invalidateStyleWithMatchElement):

Canonical link: https://commits.webkit.org/262096@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6fbc6c: Add more logging to iOS print preview generation

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6fbc6c232e8b153cf99f89483fea48716ba58bc4
  
https://github.com/WebKit/WebKit/commit/6fbc6c232e8b153cf99f89483fea48716ba58bc4
  Author: Richard Robinson 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebCore/page/PrintContext.cpp
M Source/WebCore/platform/Logging.h
M Source/WebKit/UIProcess/_WKWebViewPrintFormatter.mm
M Source/WebKit/UIProcess/ios/WKContentView.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  ---
  Add more logging to iOS print preview generation
https://bugs.webkit.org/show_bug.cgi?id=254377
rdar://107159671

Reviewed by Tim Horton and Aditya Keerthi.

* Source/WebCore/page/PrintContext.cpp:
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSize):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::spoolPage):
* Source/WebCore/platform/Logging.h:
* Source/WebKit/UIProcess/ios/WKContentView.mm:
(-[WKContentView _attributesForPrintFormatter:]):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::endPrinting):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::computePagesForPrintingiOS):
(WebKit::WebPage::drawToImage):

Canonical link: https://commits.webkit.org/262097@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 77b199: color() function parsing incorrectly parses missin...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77b199a5f0447aa578394389d7c83eba85c98595
  
https://github.com/WebKit/WebKit/commit/77b199a5f0447aa578394389d7c83eba85c98595
  Author: Tim Nguyen 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M LayoutTests/css3/color/color-function-computed-style-expected.txt
M LayoutTests/css3/color/color-function-computed-style.html
M LayoutTests/css3/color/color-function-parsing-expected.txt
M LayoutTests/css3/color/color-function-parsing.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-function-expected.txt
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

  Log Message:
  ---
  color() function parsing incorrectly parses missing components
https://bugs.webkit.org/show_bug.cgi?id=251152
rdar://104679823

Reviewed by Darin Adler and Sam Weinig.

Start rejecting missing components in color() function.

Context:

>From Emilio:
color(srgb / 0.5) seems to parse on safari with the components zeroed out, but 
that seems wrong per spec. 
https://w3c.github.io/csswg-drafts/css-color-4/#funcdef-color only says the 
alpha is optional.

>From Chris Lilley:
This used to be correct per spec, long ago when color() also did custom color 
spaces and it was reasonable to omit some components and have them auto-filled 
with zero.

Now custom color spaces are in CSS Color 5, and clearly distinguished with a 
dashed-ident; while predefined color spaces are in CSS Color 4 and are wither 
an RGB space or an XYZ space. Both take 3 components, as the grammar makes 
clear.

There was some leftover prose about variable number of components, not up to 
date with the grammar change, which I just corrected.

* LayoutTests/css3/color/color-function-computed-style-expected.txt:
* LayoutTests/css3/color/color-function-computed-style.html:
* LayoutTests/css3/color/color-function-parsing-expected.txt:
* LayoutTests/css3/color/color-function-parsing.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-color-function-expected.txt:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForRGBTypesRaw):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForXYZTypesRaw):

Canonical link: https://commits.webkit.org/262098@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b0a888: REGRESSION(261977@main): TestWebKitAPI.ProcessSwap...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0a016324e0191a3569a7f65624b3d0a4b89
  
https://github.com/WebKit/WebKit/commit/b0a016324e0191a3569a7f65624b3d0a4b89
  Author: Nikolaos Mouchtaris 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp

  Log Message:
  ---
  REGRESSION(261977@main): 
TestWebKitAPI.ProcessSwap.ResizeWebViewDuringCrossSiteProvisionalNavigation is 
a constant crash
https://bugs.webkit.org/show_bug.cgi?id=254378
rdar://107161569

Reviewed by Simon Fraser.

Add null checks for ScrollingCoordinator and ScrollingTree.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::sizeDidChange):
(WebKit::RemoteLayerTreeDrawingAreaProxy::viewWillStartLiveResize):
(WebKit::RemoteLayerTreeDrawingAreaProxy::viewWillEndLiveResize):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::viewWillStartLiveResize):
(WebKit::RemoteScrollingCoordinatorProxy::viewWillEndLiveResize):
(WebKit::RemoteScrollingCoordinatorProxy::viewSizeDidChange):

Canonical link: https://commits.webkit.org/262099@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 139404: Add HTML category to UnifiedWebPreferences.yaml

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 139404b6f591d82bd665e03139871faa6f0ff5a9
  
https://github.com/WebKit/WebKit/commit/139404b6f591d82bd665e03139871faa6f0ff5a9
  Author: Tim Nguyen 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/GeneratePreferences.rb
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebKit/UIProcess/API/APIFeatureStatus.h
M Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm
M Source/WebKitLegacy/mac/WebView/WebFeature.h

  Log Message:
  ---
  Add HTML category to UnifiedWebPreferences.yaml
https://bugs.webkit.org/show_bug.cgi?id=254352
rdar://107144335

Reviewed by Brent Fulgham.

Lighten the DOM category by introducing a new HTML one, containing:
- inert attribute
- popover attribute
- Vertical form controls
- HTML  element
- HTML  document
- lazy image loading ()
- lazy iframe loading ()
- dialog element
- PDF.js (functionality wise similar to HTML  document, but also this is 
behind a build flag off by default, so doesn't matter where it goes as long as 
it can be turned on)

* Source/WTF/Scripts/GeneratePreferences.rb:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/UIProcess/API/APIFeatureStatus.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm:
(-[_WKFeature category]):
* Source/WebKitLegacy/mac/WebView/WebFeature.h:

Canonical link: https://commits.webkit.org/262100@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0caa8d: Use CMAKE__COMPILER_LAUNCHER for ccache inst...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0caa8dae5802427f096d1438bbc566160c85b05b
  
https://github.com/WebKit/WebKit/commit/0caa8dae5802427f096d1438bbc566160c85b05b
  Author: Fujii Hironori 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/cmake/WebKitCCache.cmake

  Log Message:
  ---
  Use CMAKE__COMPILER_LAUNCHER for ccache instead of RULE_LAUNCH_COMPILE
https://bugs.webkit.org/show_bug.cgi?id=254216

Reviewed by Michael Catanzaro.

The document says we should use CMAKE__COMPILER_LAUNCHER
variables or _COMPILER_LAUNCHER target property for ccache
instead of RULE_LAUNCH_COMPILE property.


Using RULE_LAUNCH_COMPILE for ccache caused a problem for the resource
compiler on Windows.

* Source/cmake/WebKitCCache.cmake:
Set CMAKE_C_COMPILER_LAUNCHER and CMAKE_CXX_COMPILER_LAUNCHER.

Canonical link: https://commits.webkit.org/262101@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2f1690: Replace ResourceResponse with ResourceResponse::Cr...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f169036ec502e5451e1a00f5d9d268cf4ffe6bd
  
https://github.com/WebKit/WebKit/commit/2f169036ec502e5451e1a00f5d9d268cf4ffe6bd
  Author: Sihui Liu 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/WebCore/Modules/cache/DOMCacheEngine.cpp
M Source/WebCore/Modules/cache/DOMCacheEngine.h
M Source/WebCore/loader/CrossOriginAccessControl.cpp
M Source/WebCore/loader/CrossOriginAccessControl.h
M Source/WebCore/platform/network/ResourceResponseBase.cpp
M Source/WebCore/platform/network/ResourceResponseBase.h
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.h
M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in
M Source/WebKit/Scripts/generate-serializers.py
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp

  Log Message:
  ---
  Replace ResourceResponse with ResourceResponse::CrossThreadData in 
CacheStorage messages
https://bugs.webkit.org/show_bug.cgi?id=254231
rdar://107020237

Reviewed by Youenn Fablet.

NetworkStorageManager receives and handles CacheStorage messages on a 
WorkQueue, which is not tied to one thread.
ResourceResponse contains AtomSring members, which can only be accessed from 
the thread where they are created. To avoid
threading issues, we replace ResourceResponse with 
ResourceResponse::CrossThreadData in CacheStorage messages that are
sent to and sent from NetworkStorageManager.

To make this change, this patch introduces DOMCacheEngine::CrossThreadRecord 
and adds encode/decode functions for
ResourceResponse::CrossThreadData. It also adds members to 
ResourceResponse::CrossThreadData so that it contains all
information needed for persistence encoding/decoding.

* Source/WebCore/Modules/cache/DOMCacheEngine.cpp:
(WebCore::DOMCacheEngine::toCrossThreadRecord):
(WebCore::DOMCacheEngine::fromCrossThreadRecord):
* Source/WebCore/Modules/cache/DOMCacheEngine.h:
(WebCore::DOMCacheEngine::CrossThreadRecord::CrossThreadRecord):
* Source/WebCore/loader/CrossOriginAccessControl.cpp:
(WebCore::shouldCrossOriginResourcePolicyCancelLoad):
(WebCore::validateCrossOriginResourcePolicy):
* Source/WebCore/loader/CrossOriginAccessControl.h:
* Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::CrossThreadData::isolatedCopy const):
(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WTF::Persistence::Coder::encode):
(WTF::Persistence::Coder::decode):
* Source/WebCore/platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::CrossThreadData::CrossThreadData):
* Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp:
(WebKit::toCacheStorageRecord):
(WebKit::CacheStorageCache::retrieveRecords):
(WebKit::CacheStorageCache::putRecords):
* Source/WebKit/NetworkProcess/storage/CacheStorageCache.h:
* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp:
(WebKit::decodeRecordHeader):
(WebKit::readRecordInfoFromFileData):
(WebKit::CacheStorageDiskStore::readRecordFromFileData):
(WebKit::encodeRecordHeader):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::cacheStorageRetrieveRecords):
(WebKit::NetworkStorageManager::cacheStoragePutRecords):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h:
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in:
* Source/WebKit/Scripts/generate-serializers.py:
(SerializedType.__init__):
(generate_headers_for_header):
(generate_header):
(parse_serialized_types):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::retrieveRecords):
(WebKit::WebCacheStorageConnection::batchPutOperation):

Canonical link: https://commits.webkit.org/262102@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3bc3bb: JSRopeString::resolveRopeToAtomString() doesn't ne...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3bc3bb7a66f12f722a3a7d3461d5b914a215ca69
  
https://github.com/WebKit/WebKit/commit/3bc3bb7a66f12f722a3a7d3461d5b914a215ca69
  Author: Chris Dumez 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/JavaScriptCore/runtime/JSString.cpp
M Source/JavaScriptCore/runtime/JSString.h
M Source/WTF/wtf/text/AtomString.h

  Log Message:
  ---
  JSRopeString::resolveRopeToAtomString() doesn't need to copy characters to a 
buffer when it is a substring
https://bugs.webkit.org/show_bug.cgi?id=254441

Reviewed by Yusuke Suzuki.

JSRopeString::resolveRopeToAtomString() doesn't need to copy characters to a
buffer when it is a substring, we can construct the AtomString straight from
the StringView::substring() output.

* Source/JavaScriptCore/runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeToAtomString const):
(JSC::JSRopeString::resolveRopeToExistingAtomString const):
(JSC::JSRopeString::resolveRopeInternal const): Deleted.
* Source/JavaScriptCore/runtime/JSString.h:
* Source/WTF/wtf/text/AtomString.h:

Canonical link: https://commits.webkit.org/262103@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f80c41: [ews-build.webkit.org] Convert AnalyzeLayoutTestsR...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f80c4133ba61ea386ed66e9964d12fa3de84ff26
  
https://github.com/WebKit/WebKit/commit/f80c4133ba61ea386ed66e9964d12fa3de84ff26
  Author: Jonathan Bedard 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews-build.webkit.org] Convert AnalyzeLayoutTestsResults to new-style
https://bugs.webkit.org/show_bug.cgi?id=251736
rdar://105041006

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(AnalyzeLayoutTestsResults.report_failure): Return deferred value since
_addToLog is asynchronous.
(AnalyzeLayoutTestsResults.report_pre_existing_failures): Return exit code.
(AnalyzeLayoutTestsResults.retry_build): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.
(AnalyzeLayoutTestsResults.run): Renamed from start.
(AnalyzeLayoutTestsResults.start): Renamed to run.
(AnalyzeLayoutTestsResultsRedTree.report_success): Return exit code.
(AnalyzeLayoutTestsResultsRedTree.report_warning): Ditto.
(AnalyzeLayoutTestsResultsRedTree.run):Renamed from start.
(AnalyzeLayoutTestsResultsRedTree.start): Renamed to run.

Canonical link: https://commits.webkit.org/262104@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e94fbc: REGRESSION (262041@main): Keyboard scrolling anima...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e94fbc9c6f2ad75e234c67d3642c0756c19679c8
  
https://github.com/WebKit/WebKit/commit/e94fbc9c6f2ad75e234c67d3642c0756c19679c8
  Author: Wenson Hsieh 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
A 
LayoutTests/fast/scrolling/programmatic-smooth-scroll-from-nonzero-offset-expected.txt
A 
LayoutTests/fast/scrolling/programmatic-smooth-scroll-from-nonzero-offset.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.cpp
M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp
M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h
M 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp

  Log Message:
  ---
  REGRESSION (262041@main): Keyboard scrolling animates from (0, 0) when smooth 
keyboard scrolling is disabled and UI-side compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=254428

Reviewed by Tim Horton.

My previous patch in 262041@main had a serious flaw — when decoding 
`ScrollingStateScrollingNode`,
we'll decode a `RequestedScrollData` and use 
`ScrollingStateScrollingNode::setRequestedScrollData`
to set the decoded data on the scrolling node. However, since:

- `setRequestedScrollData()` contains the request merging logic I added in 
262041@main, and...
- We decode the changed property flags before calling `setRequestedScrollData`.

...we end up treating all animated scrolling as starting from the origin. This 
patch fixes that by
keeping the merging logic in the web process, by passing in a 
`CanMergeScrollData::No` flag when
deserializing the scrolling state node.

Test: fast/scrolling/programmatic-smooth-scroll-from-nonzero-offset.html

* 
LayoutTests/fast/scrolling/programmatic-smooth-scroll-from-nonzero-offset-expected.txt:
 Added.
* 
LayoutTests/fast/scrolling/programmatic-smooth-scroll-from-nonzero-offset.html: 
Added.

Add a new layout test to exercise the bug, by scrolling (without animation) to 
a nonzero offset and
then performing an animated scroll from that offset, verifying that we don't 
attempt to start from
(0, 0) when performing the animated scroll.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.cpp:
(WebCore::RequestedScrollData::merge):

After fixing the above issue, I also discovered that with UI-side compositing 
enabled, the original
tests in `imported/w3c/web-platform-tests/css/cssom-view` that I tried to fix 
started failing again;
this is because of another subtle corner case that wasn't covered in when 
merging `RequestedScrollData`,
wherein the following sequence of programmatic scroll requests:

1. ScrollRequestType::PositionUpdate (Non-Animated)
2. ScrollRequestType::CancelAnimatedScroll
3. ScrollRequestType::PositionUpdate (Animated)

...caused us to stomp over the `requestedDataBeforeAnimatedScroll` in step (2), 
when merging the
animated scroll cancellation request into the position update. To address this 
and keep the WPT
passing with UI-side compositing enabled, I've adjusted the merging logic to 
preserve `scrollPosition`
after step (2), so that we can stash it in the 
`requestedDataBeforeAnimatedScroll` in step (3).

* Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::setRequestedScrollData):
* Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:
* 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder::decode):

Canonical link: https://commits.webkit.org/262105@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ed99b9: Web Inspector: (Regression: 254636@main) Mini cons...

[Patrick Angle]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed99b93877dd9c47942db5a0f56a82acc4adeebd
  
https://github.com/WebKit/WebKit/commit/ed99b93877dd9c47942db5a0f56a82acc4adeebd
  Author: Patrick Angle 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M 
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js
M Source/WebInspectorUI/UserInterface/Models/ConsoleCommandResultMessage.js
M Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js
M Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js
M Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js
M Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
M Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js
M Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js
M Source/WebInspectorUI/UserInterface/Views/QuickConsole.js
M Source/WebInspectorUI/UserInterface/Views/WebSocketResourceTreeElement.js

  Log Message:
  ---
  Web Inspector: (Regression: 254636@main) Mini console always opens when 
choosing "Inspect Element", even if it was previously closed
https://bugs.webkit.org/show_bug.cgi?id=253273
rdar://106260652

Reviewed by Devin Rousso.

When console snippets were introduced, the function signature of 
`appendImmediateExecutionWithResult` was updated so
that optional values were part of an options object. However, in changing that 
it appears it was assumed that the
default would be flipped to `false`, but that never happened. The parameter was 
no longer being provided by DOMManger
when inspecting an element, and therefor we fell back to the default of showing 
the quick console.

To fix this, we correct the `shouldRevealConsole` to be `false` by default, 
matching other option objects, and then
clean up other places where we were assuming it would still be true (mostly 
anywhere that a "Log [thing]" option was
present).

* 
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:
(WI.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult.saveResultCallback):
(WI.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult):
- Use the new options object of the ConsoleCommandResultMessage constructor.

* Source/WebInspectorUI/UserInterface/Models/ConsoleCommandResultMessage.js:
- Make `shouldRevealConsole` part of an options object, and make it default to 
false instead.

* Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:
(WI.AnimationContentView.prototype._populateAnimationTargetButtonContextMenu):
(WI.AnimationContentView):
* Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype._populateCanvasElementButtonContextMenu):
* Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:
(WI.CanvasTreeElement.prototype.populateContextMenu):
* Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:
* Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js:
(WI.ObjectPreviewView.prototype._contextMenuHandler):
(WI.ObjectPreviewView):
* Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WI.ObjectTreeBaseTreeElement.prototype._logSymbolProperty):
(WI.ObjectTreeBaseTreeElement.prototype._logValue):
* Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:
(WI.QuickConsole.prototype._handleDrop):
* Source/WebInspectorUI/UserInterface/Views/WebSocketResourceTreeElement.js:
(WI.WebSocketResourceTreeElement.prototype.populateContextMenu):

Canonical link: https://commits.webkit.org/262106@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b387b3: [PlayStation] Fix assertion crash of libpas pthrea...

[Basuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b387b3c61ceaf97fc854b64bbee510eeefb208e6
  
https://github.com/WebKit/WebKit/commit/b387b3c61ceaf97fc854b64bbee510eeefb208e6
  Author: Basuke Suzuki 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M Source/bmalloc/libpas/src/libpas/pas_lock.h

  Log Message:
  ---
  [PlayStation] Fix assertion crash of libpas pthread implementation.
https://bugs.webkit.org/show_bug.cgi?id=254452

Reviewed by Don Olmstead.

Fix trivial mistake which uses errno instead of returned error value.

* Source/bmalloc/libpas/src/libpas/pas_lock.h:
(pas_lock_try_lock):

Canonical link: https://commits.webkit.org/262107@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3f51f0: fast/scrolling/mac/keyboard-scrolling-terminates.h...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f51f0bc4ecb5f4c47e5da90f817c51ed542438a
  
https://github.com/WebKit/WebKit/commit/3f51f0bc4ecb5f4c47e5da90f817c51ed542438a
  Author: Wenson Hsieh 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M LayoutTests/fast/scrolling/mac/keyboard-scrolling-terminates.html

  Log Message:
  ---
  fast/scrolling/mac/keyboard-scrolling-terminates.html doesn't verify that 
scrolling terminates after 258483@main
https://bugs.webkit.org/show_bug.cgi?id=25

Reviewed by Simon Fraser.

Add a missing `await`, to ensure that the test actually waits for scrolling to 
finish after pressing
the down arrow key.

* LayoutTests/fast/scrolling/mac/keyboard-scrolling-terminates.html:

Canonical link: https://commits.webkit.org/262108@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d19167: REGRESSION (260451@main): Opening any PDF in WebKi...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d191671333e174c82b39ae2a71fc878e5026be12
  
https://github.com/WebKit/WebKit/commit/d191671333e174c82b39ae2a71fc878e5026be12
  Author: Tyler Wilcock 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
A 
LayoutTests/platform/mac-wk2/plugins/pdf-plugin-initial-scroll-position-expected.txt
A 
LayoutTests/platform/mac-wk2/plugins/pdf-plugin-initial-scroll-position.html
M Source/WebCore/plugins/PluginViewBase.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PluginView.cpp
M Source/WebKit/WebProcess/Plugins/PluginView.h

  Log Message:
  ---
  REGRESSION (260451@main): Opening any PDF in WebKit opens it halfway down the 
first page
https://bugs.webkit.org/show_bug.cgi?id=254374
rdar://106880773

Reviewed by Tim Horton.

Before 260451@main, the sequence for updating PDF scroll position on and 
shortly after load was this:

1. PDF plugin is initialized, scroll position is set to (0, 0)
2. PDFKit does `-[PDFLayerController _updateAutoScale]` and 
`-[PDFLayerController magnifyWithMagnification:atPoint:immediately:]`,
   and informs the `WKPDFLayerControllerDelegate` to update the scroll position 
to some greater than zero value (despite no scroll actually happening)
3. A call to `PDFPlugin::receivedNonLinearizedPDFSentinel()` is handled. Scroll 
position is set to (0, 0)

After 260451@main, the sequence became:

1. PDF plugin is initialized, scroll position is set to (0, 0)
2. PDFKit does magnification as described above, updates scroll position to (0, 
190 (or other >0 value)). This is dispatched to the main runloop to be handled 
asynchronously.
3. A call to `PDFPlugin::receivedNonLinearizedPDFSentinel()` is handled. Scroll 
position is set to (0, 0)
4. The async dispatch from step 2 is handled by the main runloop, overwriting 
the (0,0) value

This patch addresses the bug by using `callOnMainRunLoopAndWait` instead of 
`callOnMainRunLoop` inside `-[PDFPlugin updateScrollPosition:]`
to prevent incorrect re-ordering of scroll position changes.

* 
LayoutTests/platform/mac-wk2/plugins/pdf-plugin-initial-scroll-position-expected.txt:
 Added.
* LayoutTests/platform/mac-wk2/plugins/pdf-plugin-initial-scroll-position.html: 
Added.
* Source/WebCore/plugins/PluginViewBase.h:
(WebCore::PluginViewBase::scrollPositionForTesting const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::scrollPositionForPlugin):
(WebCore::Internals::pluginScrollPositionX):
(WebCore::Internals::pluginScrollPositionY):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate updateScrollPosition:]):
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::scrollPositionForTesting const):
* Source/WebKit/WebProcess/Plugins/PluginView.h:

Canonical link: https://commits.webkit.org/262109@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4d2490: [UI-Side Compositing] WebKit crashes when pressing...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d2490b20c7723522fa49719c8f48ded0fea99b7
  
https://github.com/WebKit/WebKit/commit/4d2490b20c7723522fa49719c8f48ded0fea99b7
  Author: Wenson Hsieh 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
A 
LayoutTests/fast/scrolling/mac/keyboard-scrolling-pagedown-pageup-expected.txt
A LayoutTests/fast/scrolling/mac/keyboard-scrolling-pagedown-pageup.html
M 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp

  Log Message:
  ---
  [UI-Side Compositing] WebKit crashes when pressing Page Up/Fn Up key
https://bugs.webkit.org/show_bug.cgi?id=254453
rdar://107206783

Reviewed by Simon Fraser.

262105@main inadvertently changed the order in which a scrolling node's 
`RequestedScrollData` and
`KeyboardScrollData` are decoded, but not the order in which they're encoded. 
This means that if
both `RequestedScrollPosition` and `KeyboardScrollData` flags are set on a 
state node, we'll end up
failing to decode the state node properly.

Fix this by correcting the order in which these two members are decoded.

Test: fast/scrolling/mac/keyboard-scrolling-pagedown-pageup.html

* 
LayoutTests/fast/scrolling/mac/keyboard-scrolling-pagedown-pageup-expected.txt: 
Added.
* LayoutTests/fast/scrolling/mac/keyboard-scrolling-pagedown-pageup.html: Added.
* 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder::decode):

Canonical link: https://commits.webkit.org/262110@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes