Re: [vpp-dev] do not SNAT if forwarding enabled

2019-04-03 Thread Shahid Khan
Hi,

can someone help us on below query ?

-Shahid.

On Mon, Apr 1, 2019 at 11:45 AM Shahid Khan via Lists.Fd.Io
 wrote:

>
> I have following query related to SNAT on VPP Release 19.0.1.02
>
> following is the code from vpp/src/plugins/nat/in2out.c
>
> static inline int
> snat_not_translate (snat_main_t * sm, vlib_node_runtime_t * node,
> u32 sw_if_index0, ip4_header_t * ip0, u32 proto0,
> u32 rx_fib_index0, u32 thread_index)
> {
>   udp_header_t *udp0 = ip4_next_header (ip0);
>   snat_session_key_t key0, sm0;
>   clib_bihash_kv_8_8_t kv0, value0;
>
>   key0.addr = ip0->dst_address;
>   key0.port = udp0->dst_port;
>   key0.protocol = proto0;
>   key0.fib_index = sm->outside_fib_index;
>   kv0.key = key0.as_u64;
>
>   /* NAT packet aimed at external address if */
>   /* has active sessions */
>   if (clib_bihash_search_8_8 (&sm->per_thread_data[thread_index].out2in,
> &kv0,
>   &value0))
> {
>   /* or is static mappings */
>   if (!snat_static_mapping_match (sm, key0, &sm0, 1, 0, 0, 0, 0, 0))
> return 0;
> }
>   else
> return 0;
>
>   if (sm->forwarding_enabled)
> return 1;
>
>
>   return snat_not_translate_fast (sm, node, sw_if_index0, ip0, proto0,
>   rx_fib_index0);
> }
>
> want to understand why above highlighted condition is there in code ?
>
> this  is causing SNAT to stop working the moment we enable forwarding.
> what will be impact we comment this condition ?
>
> -Shahid.
>
>
>
>
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#12680): https://lists.fd.io/g/vpp-dev/message/12680
> Mute This Topic: https://lists.fd.io/mt/30851776/1713129
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [
> shahidnasimk...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12691): https://lists.fd.io/g/vpp-dev/message/12691
Mute This Topic: https://lists.fd.io/mt/30851776/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[vpp-dev] marvell pp2

2019-04-03 Thread saint_sun 孙 via Lists . Fd . Io
Hi all,
I want to run vpp on marvell SOC board, anyone know how to set the startup.conf?
I have insmod the musdk_cma and mv_pp_uio.ko.

thanks





saint_sun-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12692): https://lists.fd.io/g/vpp-dev/message/12692
Mute This Topic: https://lists.fd.io/mt/30879416/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [vpp-dev] marvell pp2

2019-04-03 Thread Damjan Marion via Lists.Fd.Io


> On 3 Apr 2019, at 13:25, saint_sun 孙 via Lists.Fd.Io 
>  wrote:
> 
> Hi all,
> I want to run vpp on marvell SOC board, anyone know how to set the 
> startup.conf?
> I have insmod the musdk_cma and mv_pp_uio.ko.
> 

Have you read src/plugins/marvell/README.md ? There is no special startup.conf 
entry needed...

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12693): https://lists.fd.io/g/vpp-dev/message/12693
Mute This Topic: https://lists.fd.io/mt/30879756/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [vpp-dev] marvell pp2

2019-04-03 Thread saint_sun 孙 via Lists . Fd . Io

Damjan,thanks for your quick reply!So I don’t need to set any dpdk parameters 
in the startup.conf, am I right? I will read the document soon.



可用于iOS的myMail发送


2019年4月3日 星期三 +0800 20:11 发件人 dmarion=me@lists.fd.io  
:
>
>
>> On 3 Apr 2019, at 13:25, saint_sun 孙 via Lists.Fd.Io < 
>> saint_sun=aliyun@lists.fd.io > wrote:
>> 
>> Hi all,
>> I want to run vpp on marvell SOC board, anyone know how to set the 
>> startup.conf?
>> I have insmod the musdk_cma and mv_pp_uio.ko.
>> 
>
>Have you read src/plugins/marvell/README.md ? There is no special startup.conf 
>entry needed...
>
>-=-=-=-=-=-=-=-=-=-=-=-
>Links: You receive all messages sent to this group.
>
>View/Reply Online (#12693):  https://lists.fd.io/g/vpp-dev/message/12693
>Mute This Topic:  https://lists.fd.io/mt/30879756/1454168
>Group Owner:  vpp-dev+ow...@lists.fd.io
>Unsubscribe:  https://lists.fd.io/g/vpp-dev/unsub [saint_...@aliyun.com]
>-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12694): https://lists.fd.io/g/vpp-dev/message/12694
Mute This Topic: https://lists.fd.io/mt/30879756/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[vpp-dev] extra/libmemif Vs.src/vlibmemory

2019-04-03 Thread idoye
[Edited Message Follows]

I'm not sure I'm understating what is the different between those 2 directories 
in the git repository and How VPP is using the shared memory protocol 
implemented in the libmemif?

If I would like to make some changes in the shared memory protocol (that VPP 
use it) what code should I refactor?

--
Best regards,

Ido
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12688): https://lists.fd.io/g/vpp-dev/message/12688
Mute This Topic: https://lists.fd.io/mt/30866444/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[vpp-dev] VPP 19.04 Release Milestone F0 (API Freeze) is TODAY!

2019-04-03 Thread Dave Wallace

Folks,

Today is the VPP 19.04 Release Milestone F0 (API Freeze)!

After today, no more patches containing API files will be allowed to be 
merged without being reviewed and approved by the 19.04 release manager 
and a majority of the VPP committers.


The following patches are currently open under review and have not been 
marked as Review -2 are listed below.  Patch owners are listed in brackets.


Please let me know ASAP, if any of these are required for 19.04!

Thanks,
-daw-
"Your friendly VPP 19.04 Release Manager"

- %< -

https://gerrit.fd.io/r/18484    gbp: Add bd flags [Mohsin Kazmi]
https://gerrit.fd.io/r/18594    GBP: drop and contract counters [Neale 
Ranns]
https://gerrit.fd.io/r/18444    add deep virtual reassembly for ipv4 
[Klement Sekera]

https://gerrit.fd.io/r/18168    NAT: VPP-1531 nat api update [Filip Varga]
https://gerrit.fd.io/r/18549    reassembly: prevent long chain attack 
[Klement Sekera]
https://gerrit.fd.io/r/17093    VTL: Fix Segment routing API tests. 
[Paul Vinciguerra]

https://gerrit.fd.io/r/16712    VAT in Python [Ole Trøan]



https://gerrit.fd.io/r/16388    CSIT-541: add lwB4 functionality for 
lw4o6 [Asumu Takikawa]
https://gerrit.fd.io/r/14247    MAP: Input feature instead of going via 
FIB DPO [Ole Trøan]
https://gerrit.fd.io/r/14841    Port flowtable plugin to VPP to support 
DPI [Hongjun Ni]

https://gerrit.fd.io/r/11878    ACL Based Tracing [Neale Ranns]
https://gerrit.fd.io/r/13417    Increased link_speed field. [Dmitry 
Vakhrushev]




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12695): https://lists.fd.io/g/vpp-dev/message/12695
Mute This Topic: https://lists.fd.io/mt/30885141/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [vpp-dev] buffer indirection, cloning, and copying

2019-04-03 Thread G. Paul Ziemba
> 
> We do that by cloning, you can have multiple head buffers with small
> amount
> if data to accommodate l2/l3 headers and then such buffers have
> b->next_buffer
> pointing to shared tail buffer(s). Tail buffer(s) just need to have
> ref_count set properly
> to avoid that such buffer is freed prematurely.
> 

Perhaps more concrete information would clarify things: for code to support 
https://datatracker.ietf.org/doc/draft-hopps-ipsecme-iptfs , the aggregation of 
multiple small payload frames into a single tunnel frame requires some 
dis-aggregation at the tunnel's receive endpoint.

While it would be possible to make a functional implementation by recopying the 
payload frame pieces to new buffers for transmitting out of the tunnel, 
performance would be poor. The existing cloning mechanism does not appear to 
cover this situation because the cloned packets would need to end at different 
points in the original buffer. Do you have thoughts on a better way to do it?

many thanks!
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12696): https://lists.fd.io/g/vpp-dev/message/12696
Mute This Topic: https://lists.fd.io/mt/30784477/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-