Re: [PATCH 1/2] virtio: abstract virtqueue related methods
Hi zhenwei,
kernel test robot noticed the following build errors:
[auto build test ERROR on mst-vhost/linux-next]
[also build test ERROR on linus/master v6.4-rc1 next-20230512]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/zhenwei-pi/virtio-abstract-virtqueue-related-methods/20230512-174928
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
patch link:
https://lore.kernel.org/r/20230512094618.433707-2-pizhenwei%40bytedance.com
patch subject: [PATCH 1/2] virtio: abstract virtqueue related methods
config: loongarch-allyesconfig
(https://download.01.org/0day-ci/archive/20230513/202305130012.lq2kto5c-...@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/intel-lab-lkp/linux/commit/372bc1a0371968752fe0f5ec6e81edee6f9c44dd
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review
zhenwei-pi/virtio-abstract-virtqueue-related-methods/20230512-174928
git checkout 372bc1a0371968752fe0f5ec6e81edee6f9c44dd
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1
O=build_dir ARCH=loongarch olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1
O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot
| Link:
https://lore.kernel.org/oe-kbuild-all/202305130012.lq2kto5c-...@intel.com/
All errors (new ones prefixed by >>):
drivers/virtio/virtio.c: In function 'virtio_break_device':
>> drivers/virtio/virtio.c:893:24: error: 'struct virtqueue_ops' has no member
>> named '__builtin_loongarch_break'
893 | vq->ops->__break(vq);
|^~
vim +893 drivers/virtio/virtio.c
882
883 /*
884 * This should prevent the device from being used, allowing drivers to
885 * recover. You may need to grab appropriate locks to flush.
886 */
887 void virtio_break_device(struct virtio_device *dev)
888 {
889 struct virtqueue *vq;
890
891 spin_lock(&dev->vqs_list_lock);
892 list_for_each_entry(vq, &dev->vqs, list) {
> 893 vq->ops->__break(vq);
894 }
895 spin_unlock(&dev->vqs_list_lock);
896 }
897 EXPORT_SYMBOL_GPL(virtio_break_device);
898
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 1/2] virtio: abstract virtqueue related methods
Hi zhenwei, kernel test robot noticed the following build warnings: [auto build test WARNING on mst-vhost/linux-next] [also build test WARNING on linus/master v6.4-rc1 next-20230512] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/zhenwei-pi/virtio-abstract-virtqueue-related-methods/20230512-174928 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next patch link: https://lore.kernel.org/r/20230512094618.433707-2-pizhenwei%40bytedance.com patch subject: [PATCH 1/2] virtio: abstract virtqueue related methods reproduce: # https://github.com/intel-lab-lkp/linux/commit/372bc1a0371968752fe0f5ec6e81edee6f9c44dd git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review zhenwei-pi/virtio-abstract-virtqueue-related-methods/20230512-174928 git checkout 372bc1a0371968752fe0f5ec6e81edee6f9c44dd make menuconfig # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS make htmldocs If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305140142.c0qqq9wz-...@intel.com/ All warnings (new ones prefixed by >>): >> ./drivers/virtio/virtio_ring.c:1: warning: 'virtqueue_add_inbuf' not found >> ./drivers/virtio/virtio_ring.c:1: warning: 'virtqueue_add_outbuf' not found >> ./drivers/virtio/virtio_ring.c:1: warning: 'virtqueue_add_sgs' not found >> ./drivers/virtio/virtio_ring.c:1: warning: 'virtqueue_get_buf_ctx' not found >> ./drivers/virtio/virtio_ring.c:1: warning: 'virtqueue_disable_cb' not found >> ./drivers/virtio/virtio_ring.c:1: warning: 'virtqueue_enable_cb' not found vim +/virtqueue_add_inbuf +1 ./drivers/virtio/virtio_ring.c fd534e9b5fdcf9 Thomas Gleixner 2019-05-23 @1 // SPDX-License-Identifier: GPL-2.0-or-later 0a8a69dd77ddbd Rusty Russell 2007-10-22 2 /* Virtio ring implementation. 0a8a69dd77ddbd Rusty Russell 2007-10-22 3 * 0a8a69dd77ddbd Rusty Russell 2007-10-22 4 * Copyright 2007 Rusty Russell IBM Corporation 0a8a69dd77ddbd Rusty Russell 2007-10-22 5 */ 0a8a69dd77ddbd Rusty Russell 2007-10-22 6 #include 0a8a69dd77ddbd Rusty Russell 2007-10-22 7 #include e34f87256794b8 Rusty Russell 2008-07-25 8 #include 0a8a69dd77ddbd Rusty Russell 2007-10-22 9 #include 5a0e3ad6af8660 Tejun Heo 2010-03-24 10 #include b5a2c4f1996d1d Paul Gortmaker 2011-07-03 11 #include e93300b1afc7cd Rusty Russell 2012-01-12 12 #include 780bc7903a32ed Andy Lutomirski 2016-02-02 13 #include 88938359e2dfe1 Alexander Potapenko 2022-09-15 14 #include f8ce72632fa7ed Michael S. Tsirkin 2021-08-10 15 #include 78fe39872378b0 Andy Lutomirski 2016-02-02 16 #include 0a8a69dd77ddbd Rusty Russell 2007-10-22 17 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods
Hi zhenwei,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mst-vhost/linux-next]
[also build test WARNING on linus/master v6.4-rc2 next-20230517]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/zhenwei-pi/virtio-abstract-virtqueue-related-methods/20230517-110311
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
patch link:
https://lore.kernel.org/r/20230517025424.601141-2-pizhenwei%40bytedance.com
patch subject: [PATCH v2 1/2] virtio: abstract virtqueue related methods
config: alpha-randconfig-r003-20230517
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/intel-lab-lkp/linux/commit/146086b281eebe5c5368c387f96a0395c6252d41
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review
zhenwei-pi/virtio-abstract-virtqueue-related-methods/20230517-110311
git checkout 146086b281eebe5c5368c387f96a0395c6252d41
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1
O=build_dir ARCH=alpha olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1
O=build_dir ARCH=alpha SHELL=/bin/bash drivers/virtio/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202305171458.bzuep6rl-...@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/virtio/virtio_ring.c:2310: warning: expecting prototype for
>> virtqueue_detach_unused_buf(). Prototype was for
>> vring_virtqueue_detach_unused_buf() instead
>> drivers/virtio/virtio_ring.c:2499: warning: expecting prototype for
>> virtqueue_resize(). Prototype was for vring_virtqueue_resize() instead
>> drivers/virtio/virtio_ring.c:2673: warning: expecting prototype for
>> virtqueue_get_vring_size(). Prototype was for
>> vring_virtqueue_get_vring_size() instead
vim +2310 drivers/virtio/virtio_ring.c
e6f633e5beab65 Tiwei Bie 2018-11-21 2300
138fd25148638a Tiwei Bie 2018-11-21 2301 /**
138fd25148638a Tiwei Bie 2018-11-21 2302 *
virtqueue_detach_unused_buf - detach first unused buffer
a5581206c565a7 Jiang Biao 2019-04-23 2303 * @_vq: the struct
virtqueue we're talking about.
138fd25148638a Tiwei Bie 2018-11-21 2304 *
138fd25148638a Tiwei Bie 2018-11-21 2305 * Returns NULL or the
"data" token handed to virtqueue_add_*().
a62eecb3a9c086 Xuan Zhuo 2022-08-01 2306 * This is not valid on an
active queue; it is useful for device
a62eecb3a9c086 Xuan Zhuo 2022-08-01 2307 * shutdown or the reset
queue.
138fd25148638a Tiwei Bie 2018-11-21 2308 */
146086b281eebe zhenwei pi 2023-05-17 2309 static void
*vring_virtqueue_detach_unused_buf(struct virtqueue *_vq)
138fd25148638a Tiwei Bie 2018-11-21 @2310 {
1ce9e6055fa0a9 Tiwei Bie 2018-11-21 2311 struct vring_virtqueue
*vq = to_vvq(_vq);
1ce9e6055fa0a9 Tiwei Bie 2018-11-21 2312
1ce9e6055fa0a9 Tiwei Bie 2018-11-21 2313 return vq->packed_ring
? virtqueue_detach_unused_buf_packed(_vq) :
1ce9e6055fa0a9 Tiwei Bie 2018-11-21 2314
virtqueue_detach_unused_buf_split(_vq);
138fd25148638a Tiwei Bie 2018-11-21 2315 }
c021eac4148c16 Shirley Ma 2010-01-18 2316
138fd25148638a Tiwei Bie 2018-11-21 2317 static inline bool
more_used(const struct vring_virtqueue *vq)
138fd25148638a Tiwei Bie 2018-11-21 2318 {
1ce9e6055fa0a9 Tiwei Bie 2018-11-21 2319 return vq->packed_ring
? more_used_packed(vq) : more_used_split(vq);
138fd25148638a Tiwei Bie 2018-11-21 2320 }
138fd25148638a Tiwei Bie 2018-11-21 2321
5c669c4a4c6aa0 Ricardo Cañuelo2022-08-10 2322 /**
5c669c4a4c6aa0 Ricardo Cañuelo2022-08-10 2323 * vring_interrupt - notify
a virtqueue on an interrupt
5c669c4a4c6aa0 Ricardo Cañuelo2022-08-10 2324 * @irq: the IRQ number
(ignored)
5c669c4a4c6aa0 Ricardo Cañuelo2022-08-10 2325 * @_vq: the struct
virtqueue to notify
5c669c4a4c6aa0 Ricardo Cañuelo2022-08-10 2326 *
5c669c4a4c6aa0 Ricardo Cañuelo2022-08-10 2327 * Calls the callback
function of @_vq to process the virtqueue
5c669c4a4c6aa0 Ricardo Cañuelo2022-08-10 2328 * notification.
5c669c4a4c6aa0 Ricardo Cañ
Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance
Hi Liang, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805 base: net-next/main patch link: https://lore.kernel.org/r/20230526054621.18371-2-liangchen.linux%40gmail.com patch subject: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230526/202305262334.gifq3wpg-...@intel.com/config) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/bfba563f43bba37181d8502cb2e566c32f96ec9e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805 git checkout bfba563f43bba37181d8502cb2e566c32f96ec9e # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202305262334.gifq3wpg-...@intel.com/ All errors (new ones prefixed by >>): ld: vmlinux.o: in function `virtnet_find_vqs': >> virtio_net.c:(.text+0x901fb5): undefined reference to `page_pool_create' ld: vmlinux.o: in function `add_recvbuf_mergeable.isra.0': >> virtio_net.c:(.text+0x905618): undefined reference to `page_pool_alloc_pages' ld: vmlinux.o: in function `xdp_linearize_page': virtio_net.c:(.text+0x906b6b): undefined reference to `page_pool_alloc_pages' ld: vmlinux.o: in function `mergeable_xdp_get_buf.isra.0': virtio_net.c:(.text+0x90728f): undefined reference to `page_pool_alloc_pages' -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net-next 5/5] virtio_net: Implement DMA pre-handler
Hi Liang, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805 base: net-next/main patch link: https://lore.kernel.org/r/20230526054621.18371-5-liangchen.linux%40gmail.com patch subject: [PATCH net-next 5/5] virtio_net: Implement DMA pre-handler config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20230527/202305270110.tbnsdh0z-...@intel.com/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/e968bb5cacd30b672d0ccf705a24f1a792ff45aa git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805 git checkout e968bb5cacd30b672d0ccf705a24f1a792ff45aa # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202305270110.tbnsdh0z-...@intel.com/ All errors (new ones prefixed by >>, old ones prefixed by <<): >> ERROR: modpost: "iommu_get_dma_domain" [drivers/net/virtio_net.ko] undefined! -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net-next 3/5] virtio_net: Add page pool fragmentation support
Hi Liang, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805 base: net-next/main patch link: https://lore.kernel.org/r/20230526054621.18371-3-liangchen.linux%40gmail.com patch subject: [PATCH net-next 3/5] virtio_net: Add page pool fragmentation support config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230527/202305270116.tj31ijnl-...@intel.com/config) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/dda0469e059354b61192e1d25b77c57351346282 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805 git checkout dda0469e059354b61192e1d25b77c57351346282 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202305270116.tj31ijnl-...@intel.com/ All errors (new ones prefixed by >>): ld: vmlinux.o: in function `virtnet_find_vqs': virtio_net.c:(.text+0x901fd2): undefined reference to `page_pool_create' ld: vmlinux.o: in function `add_recvbuf_mergeable.isra.0': virtio_net.c:(.text+0x905662): undefined reference to `page_pool_alloc_pages' >> ld: virtio_net.c:(.text+0x905715): undefined reference to >> `page_pool_alloc_frag' ld: vmlinux.o: in function `xdp_linearize_page': virtio_net.c:(.text+0x906c50): undefined reference to `page_pool_alloc_pages' ld: virtio_net.c:(.text+0x906e33): undefined reference to `page_pool_alloc_frag' ld: vmlinux.o: in function `mergeable_xdp_get_buf.isra.0': >> virtio_net.c:(.text+0x90740e): undefined reference to `page_pool_alloc_frag' >> ld: virtio_net.c:(.text+0x90750b): undefined reference to >> `page_pool_alloc_pages' -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v4 1/1] vringh: IOMEM support
Hi Shunsuke, kernel test robot noticed the following build warnings: [auto build test WARNING on mst-vhost/linux-next] [also build test WARNING on linus/master horms-ipvs/master v6.4-rc4 next-20230602] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shunsuke-Mie/vringh-IOMEM-support/20230602-135351 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next patch link: https://lore.kernel.org/r/20230602055211.309960-2-mie%40igel.co.jp patch subject: [PATCH v4 1/1] vringh: IOMEM support config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230602/202306021725.3otsfxpf-...@intel.com/config) compiler: alpha-linux-gcc (GCC) 12.3.0 reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/de2a1f5220c32e953400f225aba6bd294a8d41b8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Shunsuke-Mie/vringh-IOMEM-support/20230602-135351 git checkout de2a1f5220c32e953400f225aba6bd294a8d41b8 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306021725.3otsfxpf-...@intel.com/ All warnings (new ones prefixed by >>): >> drivers/vhost/vringh.c:1661:5: warning: no previous prototype for >> 'vringh_init_iomem' [-Wmissing-prototypes] 1661 | int vringh_init_iomem(struct vringh *vrh, u64 features, unsigned int num, | ^ >> drivers/vhost/vringh.c:1683:5: warning: no previous prototype for >> 'vringh_getdesc_iomem' [-Wmissing-prototypes] 1683 | int vringh_getdesc_iomem(struct vringh *vrh, struct vringh_kiov *riov, | ^~~~ >> drivers/vhost/vringh.c:1714:9: warning: no previous prototype for >> 'vringh_iov_pull_iomem' [-Wmissing-prototypes] 1714 | ssize_t vringh_iov_pull_iomem(struct vringh *vrh, struct vringh_kiov *riov, | ^ >> drivers/vhost/vringh.c:1729:9: warning: no previous prototype for >> 'vringh_iov_push_iomem' [-Wmissing-prototypes] 1729 | ssize_t vringh_iov_push_iomem(struct vringh *vrh, struct vringh_kiov *wiov, | ^ >> drivers/vhost/vringh.c:1744:6: warning: no previous prototype for >> 'vringh_abandon_iomem' [-Wmissing-prototypes] 1744 | void vringh_abandon_iomem(struct vringh *vrh, unsigned int num) | ^~~~ >> drivers/vhost/vringh.c:1759:5: warning: no previous prototype for >> 'vringh_complete_iomem' [-Wmissing-prototypes] 1759 | int vringh_complete_iomem(struct vringh *vrh, u16 head, u32 len) | ^ >> drivers/vhost/vringh.c:1777:6: warning: no previous prototype for >> 'vringh_notify_enable_iomem' [-Wmissing-prototypes] 1777 | bool vringh_notify_enable_iomem(struct vringh *vrh) | ^~ >> drivers/vhost/vringh.c:1790:6: warning: no previous prototype for >> 'vringh_notify_disable_iomem' [-Wmissing-prototypes] 1790 | void vringh_notify_disable_iomem(struct vringh *vrh) | ^~~ >> drivers/vhost/vringh.c:1802:5: warning: no previous prototype for >> 'vringh_need_notify_iomem' [-Wmissing-prototypes] 1802 | int vringh_need_notify_iomem(struct vringh *vrh) | ^~~~ vim +/vringh_init_iomem +1661 drivers/vhost/vringh.c 1647 1648 /** 1649 * vringh_init_iomem - initialize a vringh for a vring on io-memory. 1650 * @vrh: the vringh to initialize. 1651 * @features: the feature bits for this ring. 1652 * @num: the number of elements. 1653 * @weak_barriers: true if we only need memory barriers, not I/O. 1654 * @desc: the userspace descriptor pointer. 1655 * @avail: the userspace avail pointer. 1656 * @used: the userspace used pointer. 1657 * 1658 * Returns an error if num is invalid: you should check pointers 1659 * yourself! 1660 */ > 1661 int vringh_init_iomem(stru
Re: [PATCH v4 1/1] vringh: IOMEM support
Hi Shunsuke, kernel test robot noticed the following build warnings: [auto build test WARNING on mst-vhost/linux-next] [also build test WARNING on linus/master horms-ipvs/master v6.4-rc4 next-20230602] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shunsuke-Mie/vringh-IOMEM-support/20230602-135351 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next patch link: https://lore.kernel.org/r/20230602055211.309960-2-mie%40igel.co.jp patch subject: [PATCH v4 1/1] vringh: IOMEM support config: hexagon-randconfig-r034-20230531 (https://download.01.org/0day-ci/archive/20230603/202306030119.ng7cqmj8-...@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 4faf3aaf28226a4e950c103a14f6fc1d1fdabb1b) reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/de2a1f5220c32e953400f225aba6bd294a8d41b8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Shunsuke-Mie/vringh-IOMEM-support/20230602-135351 git checkout de2a1f5220c32e953400f225aba6bd294a8d41b8 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=hexagon olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/vhost/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306030119.ng7cqmj8-...@intel.com/ All warnings (new ones prefixed by >>): In file included from drivers/vhost/vringh.c:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __raw_readb(PCI_IOBASE + addr); ~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); ~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) ^ In file included from drivers/vhost/vringh.c:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); ~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) ^ In file included from drivers/vhost/vringh.c:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-point
Re: [PATCH v4 1/1] vringh: IOMEM support
Hi Shunsuke, kernel test robot noticed the following build errors: [auto build test ERROR on mst-vhost/linux-next] [also build test ERROR on linus/master horms-ipvs/master v6.4-rc4 next-20230602] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shunsuke-Mie/vringh-IOMEM-support/20230602-135351 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next patch link: https://lore.kernel.org/r/20230602055211.309960-2-mie%40igel.co.jp patch subject: [PATCH v4 1/1] vringh: IOMEM support config: i386-randconfig-i003-20230531 (https://download.01.org/0day-ci/archive/20230603/202306030216.bpwr6xv0-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/de2a1f5220c32e953400f225aba6bd294a8d41b8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Shunsuke-Mie/vringh-IOMEM-support/20230602-135351 git checkout de2a1f5220c32e953400f225aba6bd294a8d41b8 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 olddefconfig make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306030216.bpwr6xv0-...@intel.com/ All errors (new ones prefixed by >>): drivers/vhost/vringh.c: In function 'getu16_iomem': >> drivers/vhost/vringh.c:1610:37: error: implicit declaration of function >> 'ioread16' [-Werror=implicit-function-declaration] 1610 | *val = vringh16_to_cpu(vrh, ioread16(p)); | ^~~~ drivers/vhost/vringh.c: In function 'putu16_iomem': >> drivers/vhost/vringh.c:1616:9: error: implicit declaration of function >> 'iowrite16' [-Werror=implicit-function-declaration] 1616 | iowrite16(cpu_to_vringh16(vrh, val), p); | ^ drivers/vhost/vringh.c: In function 'copydesc_iomem': >> drivers/vhost/vringh.c:1623:9: error: implicit declaration of function >> 'memcpy_fromio'; did you mean 'memcpy_from_bvec'? >> [-Werror=implicit-function-declaration] 1623 | memcpy_fromio(dst, src, len); | ^ | memcpy_from_bvec drivers/vhost/vringh.c: In function 'putused_iomem': >> drivers/vhost/vringh.c:1630:9: error: implicit declaration of function >> 'memcpy_toio' [-Werror=implicit-function-declaration] 1630 | memcpy_toio(dst, src, num * sizeof(*dst)); | ^~~ drivers/vhost/vringh.c: At top level: drivers/vhost/vringh.c:1661:5: warning: no previous prototype for 'vringh_init_iomem' [-Wmissing-prototypes] 1661 | int vringh_init_iomem(struct vringh *vrh, u64 features, unsigned int num, | ^ drivers/vhost/vringh.c:1683:5: warning: no previous prototype for 'vringh_getdesc_iomem' [-Wmissing-prototypes] 1683 | int vringh_getdesc_iomem(struct vringh *vrh, struct vringh_kiov *riov, | ^~~~ drivers/vhost/vringh.c:1714:9: warning: no previous prototype for 'vringh_iov_pull_iomem' [-Wmissing-prototypes] 1714 | ssize_t vringh_iov_pull_iomem(struct vringh *vrh, struct vringh_kiov *riov, | ^ drivers/vhost/vringh.c:1729:9: warning: no previous prototype for 'vringh_iov_push_iomem' [-Wmissing-prototypes] 1729 | ssize_t vringh_iov_push_iomem(struct vringh *vrh, struct vringh_kiov *wiov, | ^ drivers/vhost/vringh.c:1744:6: warning: no previous prototype for 'vringh_abandon_iomem' [-Wmissing-prototypes] 1744 | void vringh_abandon_iomem(struct vringh *vrh, unsigned int num) | ^~~~ drivers/vhost/vringh.c:1759:5: warning: no previous prototype for 'vringh_complete_iomem' [-Wmissing-prototypes] 1759 | int vringh_complete_iomem(struct vringh *vrh, u16 head, u32 len) | ^ drivers/vhost/vringh.c:1777:6: warning: no previous prototype for 'vringh_notify_enable_iomem' [-Wmissing-prototypes] 1777 | bool vringh_notify_enable_iomem(struct vringh *vrh) | ^~ drivers/vhost/vringh.c:1790:6: warning: no previous prototype for 'vringh_notify_disable_iomem' [-Wmissing-prototypes] 1790 | void vringh_notify_disable_
Re: [PATCH v4 1/1] vringh: IOMEM support
Hi Shunsuke, kernel test robot noticed the following build warnings: [auto build test WARNING on mst-vhost/linux-next] [also build test WARNING on linus/master horms-ipvs/master v6.4-rc4 next-20230602] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shunsuke-Mie/vringh-IOMEM-support/20230602-135351 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next patch link: https://lore.kernel.org/r/20230602055211.309960-2-mie%40igel.co.jp patch subject: [PATCH v4 1/1] vringh: IOMEM support config: nios2-randconfig-s053-20230531 (https://download.01.org/0day-ci/archive/20230603/202306031019.wwkekrgz-...@intel.com/config) compiler: nios2-linux-gcc (GCC) 12.3.0 reproduce: mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/de2a1f5220c32e953400f225aba6bd294a8d41b8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Shunsuke-Mie/vringh-IOMEM-support/20230602-135351 git checkout de2a1f5220c32e953400f225aba6bd294a8d41b8 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=nios2 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/vhost/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306031019.wwkekrgz-...@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/vhost/vringh.c:1630:21: sparse: sparse: incorrect type in argument 1 >> (different address spaces) @@ expected void volatile [noderef] __iomem >> *addr @@ got struct vring_used_elem *dst @@ drivers/vhost/vringh.c:1630:21: sparse: expected void volatile [noderef] __iomem *addr drivers/vhost/vringh.c:1630:21: sparse: got struct vring_used_elem *dst drivers/vhost/vringh.c:592:18: sparse: sparse: restricted __virtio16 degrades to integer drivers/vhost/vringh.c:592:18: sparse: sparse: restricted __virtio16 degrades to integer drivers/vhost/vringh.c:592:18: sparse: sparse: cast to restricted __virtio16 drivers/vhost/vringh.c:1280:23: sparse: sparse: restricted __virtio16 degrades to integer drivers/vhost/vringh.c:1280:23: sparse: sparse: restricted __virtio16 degrades to integer drivers/vhost/vringh.c:1280:23: sparse: sparse: cast to restricted __virtio16 >> drivers/vhost/vringh.c:1610:46: sparse: sparse: incorrect type in argument 1 >> (different address spaces) @@ expected void const volatile [noderef] >> __iomem *addr @@ got restricted __virtio16 const [usertype] *p @@ drivers/vhost/vringh.c:1610:46: sparse: expected void const volatile [noderef] __iomem *addr drivers/vhost/vringh.c:1610:46: sparse: got restricted __virtio16 const [usertype] *p >> drivers/vhost/vringh.c:1610:45: sparse: sparse: incorrect type in argument 2 >> (different base types) @@ expected restricted __virtio16 [usertype] val >> @@ got unsigned short @@ drivers/vhost/vringh.c:1610:45: sparse: expected restricted __virtio16 [usertype] val drivers/vhost/vringh.c:1610:45: sparse: got unsigned short >> drivers/vhost/vringh.c:1623:28: sparse: sparse: incorrect type in argument 2 >> (different address spaces) @@ expected void const volatile [noderef] >> __iomem *addr @@ got void const *src @@ drivers/vhost/vringh.c:1623:28: sparse: expected void const volatile [noderef] __iomem *addr drivers/vhost/vringh.c:1623:28: sparse: got void const *src >> drivers/vhost/vringh.c:1637:28: sparse: sparse: incorrect type in argument 2 >> (different address spaces) @@ expected void const volatile [noderef] >> __iomem *addr @@ got void *src @@ drivers/vhost/vringh.c:1637:28: sparse: expected void const volatile [noderef] __iomem *addr drivers/vhost/vringh.c:1637:28: sparse: got void *src >> drivers/vhost/vringh.c:1644:21: sparse: sparse: incorrect type in argument 1 >> (different address spaces) @@ expected void volatile [noderef] __iomem >> *addr @@ got void *dst @@ drivers/vhost/vringh.c:1644:21: sparse: expect
Re: [PATCH] Revert "virtio-blk: support completion batching for the IRQ path"
Hi Michael, kernel test robot noticed the following build errors: [auto build test ERROR on axboe-block/for-next] [also build test ERROR on linus/master v6.4-rc5 next-20230608] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Michael-S-Tsirkin/Revert-virtio-blk-support-completion-batching-for-the-IRQ-path/20230609-054840 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next patch link: https://lore.kernel.org/r/9443f7273fbba6e62f89e54cbb2a70d2c93ed8e9.1686260774.git.mst%40redhat.com patch subject: [PATCH] Revert "virtio-blk: support completion batching for the IRQ path" config: s390-randconfig-r014-20230608 (https://download.01.org/0day-ci/archive/20230609/202306090808.d1u5zgz9-...@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install s390 cross compiling tool for clang build # apt-get install binutils-s390x-linux-gnu git remote add axboe-block https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git git fetch axboe-block for-next git checkout axboe-block/for-next b4 shazam https://lore.kernel.org/r/9443f7273fbba6e62f89e54cbb2a70d2c93ed8e9.1686260774.git@redhat.com # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=s390 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/block/ If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306090808.d1u5zgz9-...@intel.com/ All errors (new ones prefixed by >>): In file included from drivers/block/virtio_blk.c:10: In file included from include/linux/virtio.h:7: In file included from include/linux/scatterlist.h:9: In file included from arch/s390/include/asm/io.h:75: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 547 | val = __raw_readb(PCI_IOBASE + addr); | ~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~ ^ include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x)) | ^ include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16' 102 | #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x)) | ^ In file included from drivers/block/virtio_blk.c:10: In file included from include/linux/virtio.h:7: In file included from include/linux/scatterlist.h:9: In file included from arch/s390/include/asm/io.h:75: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~ ^ include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x)) | ^ include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32' 115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x)) | ^ In file included from drivers/block/virtio_blk.c:10: In file included from include/linux/virtio.h:7: In file included from include/linux/scatterlist.h:9: In file included from arch/s390/include/asm/io.h:75: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-po
Re: [PATCH] Revert "virtio-blk: support completion batching for the IRQ path"
Hi Michael,
kernel test robot noticed the following build errors:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master v6.4-rc5 next-20230608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Michael-S-Tsirkin/Revert-virtio-blk-support-completion-batching-for-the-IRQ-path/20230609-054840
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
for-next
patch link:
https://lore.kernel.org/r/9443f7273fbba6e62f89e54cbb2a70d2c93ed8e9.1686260774.git.mst%40redhat.com
patch subject: [PATCH] Revert "virtio-blk: support completion batching for the
IRQ path"
config: alpha-allyesconfig
(https://download.01.org/0day-ci/archive/20230609/202306090826.c1fzmdme-...@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add axboe-block
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
git fetch axboe-block for-next
git checkout axboe-block/for-next
b4 shazam
https://lore.kernel.org/r/9443f7273fbba6e62f89e54cbb2a70d2c93ed8e9.1686260774.git@redhat.com
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross
W=1 O=build_dir ARCH=alpha olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross
W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202306090826.c1fzmdme-...@intel.com/
All errors (new ones prefixed by >>):
drivers/block/virtio_blk.c: In function 'virtblk_poll':
>> drivers/block/virtio_blk.c:1283:55: error: 'struct virtblk_req' has no
>> member named 'status'
1283 | !blk_mq_add_to_batch(req, iob, vbr->status,
| ^~
vim +1283 drivers/block/virtio_blk.c
1266
1267 static int virtblk_poll(struct blk_mq_hw_ctx *hctx, struct
io_comp_batch *iob)
1268 {
1269 struct virtio_blk *vblk = hctx->queue->queuedata;
1270 struct virtio_blk_vq *vq = get_virtio_blk_vq(hctx);
1271 struct virtblk_req *vbr;
1272 unsigned long flags;
1273 unsigned int len;
1274 int found = 0;
1275
1276 spin_lock_irqsave(&vq->lock, flags);
1277
1278 while ((vbr = virtqueue_get_buf(vq->vq, &len)) != NULL) {
1279 struct request *req = blk_mq_rq_from_pdu(vbr);
1280
1281 found++;
1282 if (!blk_mq_complete_request_remote(req) &&
> 1283 !blk_mq_add_to_batch(req, iob, vbr->status,
1284 virtblk_complete_batch))
1285 virtblk_request_done(req);
1286 }
1287
1288 if (found)
1289 blk_mq_start_stopped_hw_queues(vblk->disk->queue, true);
1290
1291 spin_unlock_irqrestore(&vq->lock, flags);
1292
1293 return found;
1294 }
1295
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v1 3/5] mm/memory_hotplug: make offline_and_remove_memory() timeout instead of failing on fatal signals
Hi David, kernel test robot noticed the following build warnings: [auto build test WARNING on 6995e2de6891c724bfeb2db33d7b87775f913ad1] url: https://github.com/intel-lab-lkp/linux/commits/David-Hildenbrand/mm-memory_hotplug-check-for-fatal-signals-only-in-offline_pages/20230627-192444 base: 6995e2de6891c724bfeb2db33d7b87775f913ad1 patch link: https://lore.kernel.org/r/20230627112220.229240-4-david%40redhat.com patch subject: [PATCH v1 3/5] mm/memory_hotplug: make offline_and_remove_memory() timeout instead of failing on fatal signals config: x86_64-randconfig-x006-20230627 (https://download.01.org/0day-ci/archive/20230628/202306280935.dktwlhfd-...@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20230628/202306280935.dktwlhfd-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306280935.dktwlhfd-...@intel.com/ All warnings (new ones prefixed by >>): >> mm/memory_hotplug.c:163:13: warning: unused variable >> 'mhp_offlining_timer_active' [-Wunused-variable] static bool mhp_offlining_timer_active; ^ mm/memory_hotplug.c:166:13: warning: unused function 'mhp_offline_timer_fn' [-Wunused-function] static void mhp_offline_timer_fn(struct timer_list *unused) ^ 2 warnings generated. vim +/mhp_offlining_timer_active +163 mm/memory_hotplug.c 154 155 /* 156 * Protected by the device hotplug lock: offline_and_remove_memory() 157 * will activate a timer such that offlining cannot be stuck forever. 158 * 159 * With an active timer, fatal signals will be ignored, because they can be 160 * counter-productive when dying user space triggers device unplug/driver 161 * unloading that ends up offlining+removing device memory. 162 */ > 163 static bool mhp_offlining_timer_active; 164 static atomic_t mhp_offlining_timer_expired; 165 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[linux-next:master] BUILD REGRESSION 1c6f93977947dbba1fc4d250c4eb8a7d4cfdecf1
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 1c6f93977947dbba1fc4d250c4eb8a7d4cfdecf1 Add linux-next specific
files for 20230704
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202306260401.qzlyqpv2-...@intel.com
https://lore.kernel.org/oe-kbuild-all/202306301709.lvrxzycj-...@intel.com
https://lore.kernel.org/oe-kbuild-all/202306301756.x8dgyynl-...@intel.com
Error/Warning: (recently discovered and may have been fixed)
drivers/bluetooth/btmtk.c:386:32: error: no member named 'dump' in 'struct
hci_dev'
drivers/bluetooth/btmtk.c:386:44: error: 'struct hci_dev' has no member named
'dump'
drivers/char/mem.c:164:25: error: implicit declaration of function
'unxlate_dev_mem_ptr'; did you mean 'xlate_dev_mem_ptr'?
[-Werror=implicit-function-declaration]
drivers/mfd/max77541.c:176:18: warning: cast to smaller integer type 'enum
max7754x_ids' from 'const void *' [-Wvoid-pointer-to-enum-cast]
lib/kunit/executor_test.c:138:4: warning: cast from 'void (*)(const void *)' to
'kunit_action_t *' (aka 'void (*)(void *)') converts to incompatible function
type [-Wcast-function-type-strict]
lib/kunit/test.c:775:38: warning: cast from 'void (*)(const void *)' to
'kunit_action_t *' (aka 'void (*)(void *)') converts to incompatible function
type [-Wcast-function-type-strict]
Unverified Error/Warning (likely false positive, please contact us if
interested):
drivers/vhost/vhost.c:1654 vhost_vring_ioctl() error: uninitialized symbol 'vq'.
drivers/vhost/vhost.c:1685 vhost_vring_ioctl() error: uninitialized symbol
'idx'.
drivers/vhost/vhost.c:763 vhost_worker_ioctl() error: uninitialized symbol 'vq'.
drivers/vhost/vhost.c:774 vhost_worker_ioctl() error: uninitialized symbol
'idx'.
{standard input}: Error: local label `"2" (instance number 9 of a fb label)' is
not defined
Error/Warning ids grouped by kconfigs:
gcc_recent_errors
|-- alpha-randconfig-r002-20230704
| `-- drivers-bluetooth-btmtk.c:error:struct-hci_dev-has-no-member-named-dump
|-- loongarch-randconfig-r022-20230704
| `-- drivers-bluetooth-btmtk.c:error:struct-hci_dev-has-no-member-named-dump
|-- m68k-randconfig-r016-20230704
| `-- drivers-bluetooth-btmtk.c:error:struct-hci_dev-has-no-member-named-dump
|-- microblaze-randconfig-r073-20230703
| `-- drivers-bluetooth-btmtk.c:error:struct-hci_dev-has-no-member-named-dump
|-- nios2-randconfig-r034-20230704
| `-- drivers-bluetooth-btmtk.c:error:struct-hci_dev-has-no-member-named-dump
|-- riscv-randconfig-m031-20230703
| |--
drivers-vhost-vhost.c-vhost_vring_ioctl()-error:uninitialized-symbol-idx-.
| |--
drivers-vhost-vhost.c-vhost_vring_ioctl()-error:uninitialized-symbol-vq-.
| |--
drivers-vhost-vhost.c-vhost_worker_ioctl()-error:uninitialized-symbol-idx-.
| `--
drivers-vhost-vhost.c-vhost_worker_ioctl()-error:uninitialized-symbol-vq-.
|-- sh-allmodconfig
| |--
drivers-char-mem.c:error:implicit-declaration-of-function-unxlate_dev_mem_ptr
| `--
standard-input:Error:local-label-(instance-number-of-a-fb-label)-is-not-defined
|-- sh-randconfig-r015-20230704
| |-- drivers-bluetooth-btmtk.c:error:struct-hci_dev-has-no-member-named-dump
| `--
drivers-char-mem.c:error:implicit-declaration-of-function-unxlate_dev_mem_ptr
|-- sh-sh7710voipgw_defconfig
| `--
drivers-char-mem.c:error:implicit-declaration-of-function-unxlate_dev_mem_ptr
|-- sparc-randconfig-r005-20230704
| `-- drivers-bluetooth-btmtk.c:error:struct-hci_dev-has-no-member-named-dump
`-- x86_64-buildonly-randconfig-r003-20230703
`-- drivers-bluetooth-btmtk.c:error:struct-hci_dev-has-no-member-named-dump
clang_recent_errors
|-- arm64-randconfig-r033-20230704
| `--
drivers-mfd-max77541.c:warning:cast-to-smaller-integer-type-enum-max7754x_ids-from-const-void
|-- hexagon-randconfig-r041-20230703
| |-- drivers-bluetooth-btmtk.c:error:no-member-named-dump-in-struct-hci_dev
| |--
lib-kunit-executor_test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type
| `--
lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type
|-- hexagon-randconfig-r045-20230703
| |--
lib-kunit-executor_test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type
| `--
lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type
|-- i386-randconfig-i011-20230703
| `-- drivers-bluetooth-btmtk.c:error:no-member-named-dump-in-struct-hci_dev
`-- s390-randconfig-r006-20230704
|--
lib-kunit-executor_test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type
`--
lib-kunit-test.c:warning:cast-from-void-(-)(const-void-)-to-kunit_action_t-(aka-void-(-)(void-)-)-converts-to-incompatible-function-type
elapsed
Re: [PATCH vhost v12 10/10] virtio_net: merge dma operations when filling mergeable buffers
Hi Xuan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on v6.4]
[cannot apply to mst-vhost/linux-next linus/master v6.5-rc2 v6.5-rc1
next-20230719]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Xuan-Zhuo/virtio_ring-check-use_dma_api-before-unmap-desc-for-indirect/20230719-121424
base: v6.4
patch link:
https://lore.kernel.org/r/20230719040422.126357-11-xuanzhuo%40linux.alibaba.com
patch subject: [PATCH vhost v12 10/10] virtio_net: merge dma operations when
filling mergeable buffers
config: i386-randconfig-i006-20230718
(https://download.01.org/0day-ci/archive/20230719/202307191819.0tatknwa-...@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce:
(https://download.01.org/0day-ci/archive/20230719/202307191819.0tatknwa-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202307191819.0tatknwa-...@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/virtio_net.c: In function 'virtnet_rq_init_one_sg':
>> drivers/net/virtio_net.c:624:41: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
624 | rq->sg[0].dma_address = (dma_addr_t)addr;
| ^
drivers/net/virtio_net.c: In function 'virtnet_rq_alloc':
>> drivers/net/virtio_net.c:682:28: warning: cast to pointer from integer of
>> different size [-Wint-to-pointer-cast]
682 | *sg_addr = (void *)(dma->addr + alloc_frag->offset -
sizeof(*dma));
|^
vim +624 drivers/net/virtio_net.c
619
620 static void virtnet_rq_init_one_sg(struct receive_queue *rq, void
*addr, u32 len)
621 {
622 if (rq->do_dma) {
623 sg_init_table(rq->sg, 1);
> 624 rq->sg[0].dma_address = (dma_addr_t)addr;
625 rq->sg[0].length = len;
626 } else {
627 sg_init_one(rq->sg, addr, len);
628 }
629 }
630
631 static void *virtnet_rq_alloc(struct receive_queue *rq, u32 size,
632void **sg_addr, gfp_t gfp)
633 {
634 struct page_frag *alloc_frag = &rq->alloc_frag;
635 struct virtnet_rq_dma *dma;
636 struct device *dev;
637 void *buf, *head;
638 dma_addr_t addr;
639
640 if (unlikely(!skb_page_frag_refill(size, alloc_frag, gfp)))
641 return NULL;
642
643 head = (char *)page_address(alloc_frag->page);
644
645 if (rq->do_dma) {
646 dma = head;
647
648 /* new pages */
649 if (!alloc_frag->offset) {
650 if (rq->last_dma) {
651 /* Now, the new page is allocated, the
last dma
652 * will not be used. So the dma can be
unmapped
653 * if the ref is 0.
654 */
655 virtnet_rq_unmap(rq, rq->last_dma, 0);
656 rq->last_dma = NULL;
657 }
658
659 dev = virtqueue_dma_dev(rq->vq);
660
661 dma->len = alloc_frag->size - sizeof(*dma);
662
663 addr = dma_map_single_attrs(dev, dma + 1,
dma->len, DMA_FROM_DEVICE, 0);
664 if (addr == DMA_MAPPING_ERROR)
665 return NULL;
666
667 dma->addr = addr;
668 dma->need_sync = dma_need_sync(dev, addr);
669
670 /* Add a reference to dma to prevent the entire
dma from
671 * being released during error handling. This
reference
672 * will be freed after the pages are no longer
used.
673 */
674 get_page(alloc_frag->page);
675 dma->ref = 1;
676 alloc_frag->offset = sizeof(*dma);
677
678 rq->last_dma = dma;
679 }
680
681 ++dma->ref;
> 682 *sg_addr = (void
Re: [PATCH v2 21/22] i2c: virtio: Remove #ifdef guards for PM related functions
Hi Paul, kernel test robot noticed the following build errors: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on brgl/gpio/for-next krzk/for-next linus/master v6.5-rc2 next-20230721] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Paul-Cercueil/i2c-au1550-Remove-ifdef-guards-for-PM-related-functions/20230722-200209 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next patch link: https://lore.kernel.org/r/20230722115310.27681-5-paul%40crapouillou.net patch subject: [PATCH v2 21/22] i2c: virtio: Remove #ifdef guards for PM related functions config: nios2-randconfig-r005-20230722 (https://download.01.org/0day-ci/archive/20230722/202307222129.q7wjpurg-...@intel.com/config) compiler: nios2-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230722/202307222129.q7wjpurg-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202307222129.q7wjpurg-...@intel.com/ All errors (new ones prefixed by >>): >> drivers/i2c/busses/i2c-virtio.c:270:10: error: 'struct virtio_driver' has no >> member named 'freeze' 270 | .freeze = pm_sleep_ptr(virtio_i2c_freeze), | ^~ In file included from include/linux/cpumask.h:10, from include/linux/smp.h:13, from include/linux/lockdep.h:14, from include/linux/spinlock.h:63, from include/linux/mmzone.h:8, from include/linux/gfp.h:7, from include/linux/slab.h:16, from include/linux/resource_ext.h:11, from include/linux/acpi.h:13, from drivers/i2c/busses/i2c-virtio.c:11: >> include/linux/kernel.h:58:33: error: initialization of 'const struct >> virtio_device_id *' from incompatible pointer type 'int (*)(struct >> virtio_device *)' [-Werror=incompatible-pointer-types] 58 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL) | ^ include/linux/pm.h:452:28: note: in expansion of macro 'PTR_IF' 452 | #define pm_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr)) |^~ drivers/i2c/busses/i2c-virtio.c:270:35: note: in expansion of macro 'pm_sleep_ptr' 270 | .freeze = pm_sleep_ptr(virtio_i2c_freeze), | ^~~~ include/linux/kernel.h:58:33: note: (near initialization for 'virtio_i2c_driver.id_table') 58 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL) | ^ include/linux/pm.h:452:28: note: in expansion of macro 'PTR_IF' 452 | #define pm_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr)) |^~ drivers/i2c/busses/i2c-virtio.c:270:35: note: in expansion of macro 'pm_sleep_ptr' 270 | .freeze = pm_sleep_ptr(virtio_i2c_freeze), | ^~~~ include/linux/kernel.h:58:33: warning: initialized field overwritten [-Woverride-init] 58 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL) | ^ include/linux/pm.h:452:28: note: in expansion of macro 'PTR_IF' 452 | #define pm_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr)) |^~ drivers/i2c/busses/i2c-virtio.c:270:35: note: in expansion of macro 'pm_sleep_ptr' 270 | .freeze = pm_sleep_ptr(virtio_i2c_freeze), | ^~~~ include/linux/kernel.h:58:33: note: (near initialization for 'virtio_i2c_driver.id_table') 58 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL) | ^ include/linux/pm.h:452:28: note: in expansion of macro 'PTR_IF' 452 | #define pm_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr)) |^~ drivers/i2c/busses/i2c-virtio.c:270:35: note: in expansion of macro 'pm_sleep_ptr' 270 | .freeze = pm_sleep_ptr(virtio_i2c_freeze), | ^~~~ >> drivers/i2c/busses/i2c-virtio.c:271:10: error: 'stru
Re: [PATCH v2 21/22] i2c: virtio: Remove #ifdef guards for PM related functions
Hi Paul,
kernel test robot noticed the following build errors:
[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on brgl/gpio/for-next krzk/for-next linus/master
v6.5-rc2 next-20230721]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Paul-Cercueil/i2c-au1550-Remove-ifdef-guards-for-PM-related-functions/20230722-200209
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
i2c/for-next
patch link:
https://lore.kernel.org/r/20230722115310.27681-5-paul%40crapouillou.net
patch subject: [PATCH v2 21/22] i2c: virtio: Remove #ifdef guards for PM
related functions
config: i386-randconfig-r015-20230722
(https://download.01.org/0day-ci/archive/20230722/20230746.k1gyogcb-...@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git
8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce:
(https://download.01.org/0day-ci/archive/20230722/20230746.k1gyogcb-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/20230746.k1gyogcb-...@intel.com/
All errors (new ones prefixed by >>):
>> drivers/i2c/busses/i2c-virtio.c:270:3: error: field designator 'freeze' does
>> not refer to any field in type 'struct virtio_driver'
.freeze = pm_sleep_ptr(virtio_i2c_freeze),
^
>> drivers/i2c/busses/i2c-virtio.c:271:3: error: field designator 'restore'
>> does not refer to any field in type 'struct virtio_driver'
.restore= pm_sleep_ptr(virtio_i2c_restore),
^
2 errors generated.
vim +270 drivers/i2c/busses/i2c-virtio.c
260
261 static struct virtio_driver virtio_i2c_driver = {
262 .feature_table = features,
263 .feature_table_size = ARRAY_SIZE(features),
264 .id_table = id_table,
265 .probe = virtio_i2c_probe,
266 .remove = virtio_i2c_remove,
267 .driver = {
268 .name = "i2c_virtio",
269 },
> 270 .freeze = pm_sleep_ptr(virtio_i2c_freeze),
> 271 .restore= pm_sleep_ptr(virtio_i2c_restore),
272 };
273 module_virtio_driver(virtio_i2c_driver);
274
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[linux-next:master] BUILD REGRESSION a734662572708cf062e974f659ae50c24fc1ad17
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: a734662572708cf062e974f659ae50c24fc1ad17 Add linux-next specific
files for 20230801
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202307251531.p8zlftmz-...@intel.com
https://lore.kernel.org/oe-kbuild-all/202308020154.xrcb9bwt-...@intel.com
Error/Warning: (recently discovered and may have been fixed)
../lib/gcc/loongarch64-linux/12.3.0/plugin/include/config/loongarch/loongarch-opts.h:31:10:
fatal error: loongarch-def.h: No such file or directory
clang-16: error: unknown argument: '-msym32'
drivers/i2c/busses/i2c-virtio.c:270:3: error: field designator 'freeze' does
not refer to any field in type 'struct virtio_driver'
drivers/i2c/busses/i2c-virtio.c:271:3: error: field designator 'restore' does
not refer to any field in type 'struct virtio_driver'
drivers/regulator/max77857-regulator.c:312:16: error: initializer element is
not a compile-time constant
include/asm-generic/io.h:1137:20: error: static declaration of 'ioport_map'
follows non-static declaration
include/asm-generic/io.h:1147:22: error: static declaration of 'ioport_unmap'
follows non-static declaration
include/asm-generic/io.h:636:15: error: redefinition of 'inb_p'
include/asm-generic/io.h:644:15: error: redefinition of 'inw_p'
include/asm-generic/io.h:652:15: error: redefinition of 'inl_p'
include/asm-generic/io.h:660:16: error: redefinition of 'outb_p'
include/asm-generic/io.h:668:16: error: redefinition of 'outw_p'
include/asm-generic/io.h:676:16: error: redefinition of 'outl_p'
include/asm-generic/io.h:689:14: error: redefinition of 'insb'
include/asm-generic/io.h:697:14: error: redefinition of 'insw'
include/asm-generic/io.h:705:14: error: redefinition of 'insl'
include/asm-generic/io.h:713:15: error: redefinition of 'outsb'
include/asm-generic/io.h:722:15: error: redefinition of 'outsw'
include/asm-generic/io.h:731:15: error: redefinition of 'outsl'
Unverified Error/Warning (likely false positive, please contact us if
interested):
sh4-linux-gcc: internal compiler error: Segmentation fault signal terminated
program cc1
{standard input}: Warning: end of file not at end of a line; newline inserted
{standard input}:1095: Error: pcrel too far
Error/Warning ids grouped by kconfigs:
gcc_recent_errors
|-- loongarch-allmodconfig
| `--
lib-gcc-loongarch64-linux-..-plugin-include-config-loongarch-loongarch-opts.h:fatal-error:loongarch-def.h:No-such-file-or-directory
|-- sh-allmodconfig
| |--
sh4-linux-gcc:internal-compiler-error:Segmentation-fault-signal-terminated-program-cc1
| |-- standard-input:Error:pcrel-too-far
| `-- standard-input:Warning:end-of-file-not-at-end-of-a-line-newline-inserted
`-- sh-randconfig-r023-20230731
|-- include-asm-generic-io.h:error:redefinition-of-inb_p
|-- include-asm-generic-io.h:error:redefinition-of-inl_p
|-- include-asm-generic-io.h:error:redefinition-of-insb
|-- include-asm-generic-io.h:error:redefinition-of-insl
|-- include-asm-generic-io.h:error:redefinition-of-insw
|-- include-asm-generic-io.h:error:redefinition-of-inw_p
|-- include-asm-generic-io.h:error:redefinition-of-outb_p
|-- include-asm-generic-io.h:error:redefinition-of-outl_p
|-- include-asm-generic-io.h:error:redefinition-of-outsb
|-- include-asm-generic-io.h:error:redefinition-of-outsl
|-- include-asm-generic-io.h:error:redefinition-of-outsw
|-- include-asm-generic-io.h:error:redefinition-of-outw_p
|--
include-asm-generic-io.h:error:static-declaration-of-ioport_map-follows-non-static-declaration
`--
include-asm-generic-io.h:error:static-declaration-of-ioport_unmap-follows-non-static-declaration
clang_recent_errors
|-- hexagon-allmodconfig
| |--
drivers-i2c-busses-i2c-virtio.c:error:field-designator-freeze-does-not-refer-to-any-field-in-type-struct-virtio_driver
| |--
drivers-i2c-busses-i2c-virtio.c:error:field-designator-restore-does-not-refer-to-any-field-in-type-struct-virtio_driver
| `--
drivers-regulator-max77857-regulator.c:error:initializer-element-is-not-a-compile-time-constant
|-- hexagon-randconfig-r015-20230731
| `--
drivers-regulator-max77857-regulator.c:error:initializer-element-is-not-a-compile-time-constant
|-- i386-randconfig-i012-20230731
| |--
drivers-i2c-busses-i2c-virtio.c:error:field-designator-freeze-does-not-refer-to-any-field-in-type-struct-virtio_driver
| `--
drivers-i2c-busses-i2c-virtio.c:error:field-designator-restore-does-not-refer-to-any-field-in-type-struct-virtio_driver
`-- mips-sb1250_swarm_defconfig
`-- clang:error:unknown-argument:msym32
elapsed time: 725m
configs tested: 111
configs skipped: 5
tested configs:
alphaallyesconfig gcc
alpha defconfig gcc
alpharandconfig-r026-20230731 gcc
arc alldefconfig gcc
arc allyesconfig gcc
arc
Re: [PATCH] A new virtio pci driver is added for listening to vcpus inside guest. Each vcpu creates a corresponding thread to periodically send data to qemu's back-end watchdog device.
Hi zhanghao1, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.5-rc5 next-20230809] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/zhanghao1/A-new-virtio-pci-driver-is-added-for-listening-to-vcpus-inside-guest-Each-vcpu-creates-a-corresponding-thread-to-periodi/20230731-092546 base: linus/master patch link: https://lore.kernel.org/r/20230731012405.234611-1-zhanghao1%40kylinos.cn patch subject: [PATCH] A new virtio pci driver is added for listening to vcpus inside guest. Each vcpu creates a corresponding thread to periodically send data to qemu's back-end watchdog device. config: sparc64-randconfig-r071-20230811 (https://download.01.org/0day-ci/archive/20230811/202308110442.0txlneks-...@intel.com/config) compiler: sparc64-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230811/202308110442.0txlneks-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308110442.0txlneks-...@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/virtio/virtio_vcpu_stall_detector.c:76:17: sparse: sparse: incorrect >> type in initializer (different address spaces) @@ expected void const >> [noderef] __percpu *__vpp_verify @@ got struct vcpu_stall_priv * @@ drivers/virtio/virtio_vcpu_stall_detector.c:76:17: sparse: expected void const [noderef] __percpu *__vpp_verify drivers/virtio/virtio_vcpu_stall_detector.c:76:17: sparse: got struct vcpu_stall_priv * >> drivers/virtio/virtio_vcpu_stall_detector.c:89:37: sparse: sparse: incorrect >> type in assignment (different base types) @@ expected unsigned int >> [usertype] ticks @@ got restricted __virtio32 @@ drivers/virtio/virtio_vcpu_stall_detector.c:89:37: sparse: expected unsigned int [usertype] ticks drivers/virtio/virtio_vcpu_stall_detector.c:89:37: sparse: got restricted __virtio32 drivers/virtio/virtio_vcpu_stall_detector.c:117:17: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got struct vcpu_stall_priv * @@ drivers/virtio/virtio_vcpu_stall_detector.c:117:17: sparse: expected void const [noderef] __percpu *__vpp_verify drivers/virtio/virtio_vcpu_stall_detector.c:117:17: sparse: got struct vcpu_stall_priv * drivers/virtio/virtio_vcpu_stall_detector.c:129:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] ticks @@ got restricted __virtio32 @@ drivers/virtio/virtio_vcpu_stall_detector.c:129:37: sparse: expected unsigned int [usertype] ticks drivers/virtio/virtio_vcpu_stall_detector.c:129:37: sparse: got restricted __virtio32 >> drivers/virtio/virtio_vcpu_stall_detector.c:193:26: sparse: sparse: >> incorrect type in assignment (different address spaces) @@ expected >> struct vcpu_stall_priv *priv @@ got struct vcpu_stall_priv [noderef] >> __percpu * @@ drivers/virtio/virtio_vcpu_stall_detector.c:193:26: sparse: expected struct vcpu_stall_priv *priv drivers/virtio/virtio_vcpu_stall_detector.c:193:26: sparse: got struct vcpu_stall_priv [noderef] __percpu * drivers/virtio/virtio_vcpu_stall_detector.c:203:24: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got struct vcpu_stall_priv * @@ drivers/virtio/virtio_vcpu_stall_detector.c:203:24: sparse: expected void const [noderef] __percpu *__vpp_verify drivers/virtio/virtio_vcpu_stall_detector.c:203:24: sparse: got struct vcpu_stall_priv * >> drivers/virtio/virtio_vcpu_stall_detector.c:207:15: sparse: sparse: no >> generic selection for 'unsigned int virtio_cread_v' >> drivers/virtio/virtio_vcpu_stall_detector.c:207:15: sparse: sparse: >> incompatible types in comparison expression (different base types): >> drivers/virtio/virtio_vcpu_stall_detector.c:207:15: sparse:bad type * >> drivers/virtio/virtio_vcpu_stall_detector.c:207:15: sparse:unsigned int * >> drivers/virtio/virtio_vcpu_stall_detector.c:207:15: sparse: sparse: no >> generic selection for 'unsigned int [addressable] virtio_cread_v' drivers/virtio/virtio_vcpu_stall_detector.c:217:15: sparse: sparse: no generic selection for 'unsigned int virtio_cread_v' drivers/virtio/virtio_vcpu_stall_detect
[mst-vhost:vhost 34/46] drivers/vdpa/vdpa_user/vduse_dev.c:1812:23: error: use of undeclared identifier 'VIRTIO_RING_F_INDIRECT_DESC'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: bb59e1f960bd07f70a4b3d8de99bfd8d71835199
commit: 334f48a83105ebe129a660d1ea1a0c29f87d50c7 [34/46] vduse: Temporarily
disable control queue features
config: x86_64-buildonly-randconfig-r001-20230811
(https://download.01.org/0day-ci/archive/20230811/202308110712.wcqoog00-...@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git
ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce:
(https://download.01.org/0day-ci/archive/20230811/202308110712.wcqoog00-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202308110712.wcqoog00-...@intel.com/
All errors (new ones prefixed by >>):
>> drivers/vdpa/vdpa_user/vduse_dev.c:1812:23: error: use of undeclared
>> identifier 'VIRTIO_RING_F_INDIRECT_DESC'
config->features &= VDUSE_NET_VALID_FEATURES_MASK;
^
drivers/vdpa/vdpa_user/vduse_dev.c:66:11: note: expanded from macro
'VDUSE_NET_VALID_FEATURES_MASK'
BIT_ULL(VIRTIO_RING_F_INDIRECT_DESC) | \
^
>> drivers/vdpa/vdpa_user/vduse_dev.c:1812:23: error: use of undeclared
>> identifier 'VIRTIO_F_EVENT_IDX'
drivers/vdpa/vdpa_user/vduse_dev.c:67:11: note: expanded from macro
'VDUSE_NET_VALID_FEATURES_MASK'
BIT_ULL(VIRTIO_F_EVENT_IDX) | \
^
>> drivers/vdpa/vdpa_user/vduse_dev.c:1812:23: error: use of undeclared
>> identifier 'VIRTIO_F_IOMMU_PLATFORM'
drivers/vdpa/vdpa_user/vduse_dev.c:69:11: note: expanded from macro
'VDUSE_NET_VALID_FEATURES_MASK'
BIT_ULL(VIRTIO_F_IOMMU_PLATFORM) | \
^
drivers/vdpa/vdpa_user/vduse_dev.c:2007:51: warning: shift count >= width of
type [-Wshift-count-overflow]
ret = dma_set_mask_and_coherent(&vdev->vdpa.dev, DMA_BIT_MASK(64));
^~~~
include/linux/dma-mapping.h:77:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
1 warning and 3 errors generated.
vim +/VIRTIO_RING_F_INDIRECT_DESC +1812 drivers/vdpa/vdpa_user/vduse_dev.c
1804
1805 static void vduse_dev_features_filter(struct vduse_dev_config *config)
1806 {
1807 /*
1808 * Temporarily filter out virtio-net's control virtqueue and
features
1809 * that depend on it while CVQ is being made more robust for
VDUSE.
1810 */
1811 if (config->device_id == VIRTIO_ID_NET)
> 1812 config->features &= VDUSE_NET_VALID_FEATURES_MASK;
1813 }
1814
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net-next 6/8] virtio-net: support rx netdim
Hi Heng, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/virtio-net-initially-change-the-value-of-tx-frames/20230811-150529 base: net-next/main patch link: https://lore.kernel.org/r/20230811065512.22190-7-hengqi%40linux.alibaba.com patch subject: [PATCH net-next 6/8] virtio-net: support rx netdim config: i386-randconfig-i011-20230811 (https://download.01.org/0day-ci/archive/20230811/202308112234.awbppmuv-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230811/202308112234.awbppmuv-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308112234.awbppmuv-...@intel.com/ All errors (new ones prefixed by >>, old ones prefixed by <<): WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-kworld-315u.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-kworld-pc150u.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-kworld-plus-tv-analog.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-leadtek-y04g0051.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-lme2510.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-manli.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-mecool-kiii-pro.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-mecool-kii-pro.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-medion-x10.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-minix-neo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-msi-digivox-iii.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-msi-digivox-ii.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-msi-tvanywhere.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-msi-tvanywhere-plus.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-nebula.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-nec-terratec-cinergy-xs.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-norwood.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-npgtech.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-odroid.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pctv-sedna.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pine64.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pinnacle-color.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pinnacle-grey.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pixelview-002t.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pixelview-mk12.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pixelview-new.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pixelview.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-powercolor-real-angel.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-proteus-2309.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-purpletv.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pv951.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-rc6-mce.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-real-audio-220-32-keys.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-reddo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-snapstream-firefly.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-streamzap.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-su3000.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-tanix-tx3mini.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-tanix-tx5max.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-tbs-nec.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-technisat-ts35.o WARNING: modp
Re: [PATCH net-next 7/8] virtio-net: support tx netdim
Hi Heng, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/virtio-net-initially-change-the-value-of-tx-frames/20230811-150529 base: net-next/main patch link: https://lore.kernel.org/r/20230811065512.22190-8-hengqi%40linux.alibaba.com patch subject: [PATCH net-next 7/8] virtio-net: support tx netdim config: i386-randconfig-i011-20230811 (https://download.01.org/0day-ci/archive/20230811/202308112350.gtajkzog-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230811/202308112350.gtajkzog-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308112350.gtajkzog-...@intel.com/ All errors (new ones prefixed by >>, old ones prefixed by <<): WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-kworld-315u.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-kworld-pc150u.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-kworld-plus-tv-analog.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-leadtek-y04g0051.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-lme2510.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-manli.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-mecool-kiii-pro.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-mecool-kii-pro.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-medion-x10.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-minix-neo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-msi-digivox-iii.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-msi-digivox-ii.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-msi-tvanywhere.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-msi-tvanywhere-plus.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-nebula.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-nec-terratec-cinergy-xs.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-norwood.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-npgtech.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-odroid.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pctv-sedna.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pine64.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pinnacle-color.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pinnacle-grey.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pixelview-002t.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pixelview-mk12.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pixelview-new.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pixelview.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-powercolor-real-angel.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-proteus-2309.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-purpletv.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-pv951.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-rc6-mce.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-real-audio-220-32-keys.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-reddo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-snapstream-firefly.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-streamzap.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-su3000.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-tanix-tx3mini.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-tanix-tx5max.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-tbs-nec.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/media/rc/keymaps/rc-technisat-ts35.o WARNING: modp
Re: [PATCH net-next 6/8] virtio-net: support rx netdim
Hi Heng,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url:
https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/virtio-net-initially-change-the-value-of-tx-frames/20230811-150529
base: net-next/main
patch link:
https://lore.kernel.org/r/20230811065512.22190-7-hengqi%40linux.alibaba.com
patch subject: [PATCH net-next 6/8] virtio-net: support rx netdim
config: microblaze-randconfig-r081-20230814
(https://download.01.org/0day-ci/archive/20230814/202308142100.l4cn4g6z-...@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.3.0
reproduce:
(https://download.01.org/0day-ci/archive/20230814/202308142100.l4cn4g6z-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202308142100.l4cn4g6z-...@intel.com/
All errors (new ones prefixed by >>):
microblaze-linux-ld: drivers/net/virtio_net.o: in function
`virtnet_rx_dim_work':
>> drivers/net/virtio_net.c:3269: undefined reference to
>> `net_dim_get_rx_moderation'
microblaze-linux-ld: drivers/net/virtio_net.o: in function
`virtnet_rx_dim_update':
>> drivers/net/virtio_net.c:1985: undefined reference to `net_dim'
vim +3269 drivers/net/virtio_net.c
3258
3259 static void virtnet_rx_dim_work(struct work_struct *work)
3260 {
3261 struct dim *dim = container_of(work, struct dim, work);
3262 struct receive_queue *rq = container_of(dim,
3263 struct receive_queue, dim);
3264 struct virtnet_info *vi = rq->vq->vdev->priv;
3265 struct net_device *dev = vi->dev;
3266 struct dim_cq_moder update_moder;
3267 int qnum = rq - vi->rq, err;
3268
> 3269 update_moder = net_dim_get_rx_moderation(dim->mode,
> dim->profile_ix);
3270 err = virtnet_send_rx_notf_coal_vq_cmd(vi, qnum,
3271 update_moder.usec,
3272 update_moder.pkts);
3273 if (err)
3274 pr_debug("%s: Failed to send dim parameters on rxq%d\n",
3275 dev->name, (int)(rq - vi->rq));
3276
3277 dim->state = DIM_START_MEASURE;
3278 }
3279
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] vdpa/mlx5: Fix firmware error on creation of 1k VQs
Hi Dragos,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.5 next-20230829]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Dragos-Tatulea/vdpa-mlx5-Fix-firmware-error-on-creation-of-1k-VQs/20230830-014600
base: linus/master
patch link:
https://lore.kernel.org/r/20230829174219.928343-1-dtatulea%40nvidia.com
patch subject: [PATCH] vdpa/mlx5: Fix firmware error on creation of 1k VQs
config: sparc-allyesconfig
(https://download.01.org/0day-ci/archive/20230830/202308300241.q7t7ouf3-...@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20230830/202308300241.q7t7ouf3-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202308300241.q7t7ouf3-...@intel.com/
All warnings (new ones prefixed by >>):
drivers/vdpa/mlx5/net/mlx5_vnet.c: In function 'read_umem_params':
>> drivers/vdpa/mlx5/net/mlx5_vnet.c:658:1: warning: the frame size of 4128
>> bytes is larger than 2048 bytes [-Wframe-larger-than=]
658 | }
| ^
vim +658 drivers/vdpa/mlx5/net/mlx5_vnet.c
627
628 static int read_umem_params(struct mlx5_vdpa_net *ndev)
629 {
630 u32 out[MLX5_ST_SZ_DW(query_hca_cap_out)] = {};
631 u32 in[MLX5_ST_SZ_DW(query_hca_cap_in)] = {};
632 u16 opmod = (MLX5_CAP_VDPA_EMULATION << 1) |
(HCA_CAP_OPMOD_GET_CUR & 0x01);
633 struct mlx5_core_dev *mdev = ndev->mvdev.mdev;
634 void *caps;
635 int err;
636
637 MLX5_SET(query_hca_cap_in, in, opcode,
MLX5_CMD_OP_QUERY_HCA_CAP);
638 MLX5_SET(query_hca_cap_in, in, op_mod, opmod);
639 err = mlx5_cmd_exec_inout(mdev, query_hca_cap, in, out);
640 if (err) {
641 mlx5_vdpa_warn(&ndev->mvdev,
642 "Failed reading vdpa umem capabilities with err
%d\n", err);
643 return err;
644 }
645
646 caps = MLX5_ADDR_OF(query_hca_cap_out, out, capability);
647
648 ndev->umem_1_buffer_param_a = MLX5_GET(virtio_emulation_cap,
caps, umem_1_buffer_param_a);
649 ndev->umem_1_buffer_param_b = MLX5_GET(virtio_emulation_cap,
caps, umem_1_buffer_param_b);
650
651 ndev->umem_2_buffer_param_a = MLX5_GET(virtio_emulation_cap,
caps, umem_2_buffer_param_a);
652 ndev->umem_2_buffer_param_b = MLX5_GET(virtio_emulation_cap,
caps, umem_2_buffer_param_b);
653
654 ndev->umem_3_buffer_param_a = MLX5_GET(virtio_emulation_cap,
caps, umem_3_buffer_param_a);
655 ndev->umem_3_buffer_param_b = MLX5_GET(virtio_emulation_cap,
caps, umem_3_buffer_param_b);
656
657 return 0;
> 658 }
659
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH vfio 07/11] virtio-pci: Introduce admin commands
Hi Yishai, kernel test robot noticed the following build errors: [auto build test ERROR on awilliam-vfio/for-linus] [also build test ERROR on mst-vhost/linux-next linus/master v6.6-rc2 next-20230921] [cannot apply to awilliam-vfio/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yishai-Hadas/virtio-pci-Use-virtio-pci-device-layer-vq-info-instead-of-generic-one/20230922-062611 base: https://github.com/awilliam/linux-vfio.git for-linus patch link: https://lore.kernel.org/r/20230921124040.145386-8-yishaih%40nvidia.com patch subject: [PATCH vfio 07/11] virtio-pci: Introduce admin commands config: i386-randconfig-012-20230924 (https://download.01.org/0day-ci/archive/20230924/202309241353.ykr3cc2k-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230924/202309241353.ykr3cc2k-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309241353.ykr3cc2k-...@intel.com/ All errors (new ones prefixed by >>): In file included from : >> ./usr/include/linux/virtio_pci.h:250:9: error: unknown type name 'u8' 250 | u8 offset; /* Starting offset of the register(s) to write. */ | ^~ ./usr/include/linux/virtio_pci.h:251:9: error: unknown type name 'u8' 251 | u8 reserved[7]; | ^~ ./usr/include/linux/virtio_pci.h:252:9: error: unknown type name 'u8' 252 | u8 registers[]; | ^~ ./usr/include/linux/virtio_pci.h:256:9: error: unknown type name 'u8' 256 | u8 offset; /* Starting offset of the register(s) to read. */ | ^~ ./usr/include/linux/virtio_pci.h:266:9: error: unknown type name 'u8' 266 | u8 flags; /* 0 = end of list, 1 = owner device, 2 = member device */ | ^~ ./usr/include/linux/virtio_pci.h:267:9: error: unknown type name 'u8' 267 | u8 bar; /* BAR of the member or the owner device */ | ^~ ./usr/include/linux/virtio_pci.h:268:9: error: unknown type name 'u8' 268 | u8 padding[6]; | ^~ -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH vfio 07/11] virtio-pci: Introduce admin commands
Hi Yishai,
kernel test robot noticed the following build warnings:
[auto build test WARNING on awilliam-vfio/for-linus]
[also build test WARNING on linus/master v6.6-rc3 next-20230921]
[cannot apply to awilliam-vfio/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Yishai-Hadas/virtio-pci-Use-virtio-pci-device-layer-vq-info-instead-of-generic-one/20230922-062611
base: https://github.com/awilliam/linux-vfio.git for-linus
patch link:
https://lore.kernel.org/r/20230921124040.145386-8-yishaih%40nvidia.com
patch subject: [PATCH vfio 07/11] virtio-pci: Introduce admin commands
config: x86_64-rhel-8.3-rust
(https://download.01.org/0day-ci/archive/20230925/202309251120.rwbiazym-...@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git
ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20230925/202309251120.rwbiazym-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202309251120.rwbiazym-...@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/virtio/virtio_pci_modern_dev.c:3:
In file included from include/linux/virtio_pci_modern.h:6:
>> include/uapi/linux/virtio_pci.h:270:4: warning: attribute '__packed__' is
>> ignored, place it after "struct" to apply attribute to type declaration
>> [-Wignored-attributes]
}; __packed
^
include/linux/compiler_attributes.h:304:56: note: expanded from macro
'__packed'
#define __packed__attribute__((__packed__))
^
1 warning generated.
vim +270 include/uapi/linux/virtio_pci.h
264
265 struct virtio_admin_cmd_notify_info_data {
266 u8 flags; /* 0 = end of list, 1 = owner device, 2 = member
device */
267 u8 bar; /* BAR of the member or the owner device */
268 u8 padding[6];
269 __le64 offset; /* Offset within bar. */
> 270 }; __packed
271
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH vhost 01/22] virtio_ring: virtqueue_set_dma_premapped support disable
Hi Xuan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc5 next-20231011]
[cannot apply to mst-vhost/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Xuan-Zhuo/virtio_ring-virtqueue_set_dma_premapped-support-disable/20231011-180709
base: linus/master
patch link:
https://lore.kernel.org/r/20231011092728.105904-2-xuanzhuo%40linux.alibaba.com
patch subject: [PATCH vhost 01/22] virtio_ring: virtqueue_set_dma_premapped
support disable
config: m68k-allyesconfig
(https://download.01.org/0day-ci/archive/20231011/202310112204.h03tudph-...@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20231011/202310112204.h03tudph-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202310112204.h03tudph-...@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/virtio/virtio_ring.c:2788: warning: Function parameter or member
>> 'mode' not described in 'virtqueue_set_dma_premapped'
vim +2788 drivers/virtio/virtio_ring.c
c790e8e1817f1a Xuan Zhuo 2022-08-01 2765
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2766 /**
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2767 * virtqueue_set_dma_premapped - set
the vring premapped mode
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2768 * @_vq: the struct virtqueue we're
talking about.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2769 *
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2770 * Enable the premapped mode of the
vq.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2771 *
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2772 * The vring in premapped mode does
not do dma internally, so the driver must
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2773 * do dma mapping in advance. The
driver must pass the dma_address through
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2774 * dma_address of scatterlist. When
the driver got a used buffer from
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2775 * the vring, it has to unmap the
dma address.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2776 *
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2777 * This function must be called
immediately after creating the vq, or after vq
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2778 * reset, and before adding any
buffers to it.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2779 *
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2780 * Caller must ensure we don't call
this with other virtqueue operations
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2781 * at the same time (except where
noted).
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2782 *
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2783 * Returns zero or a negative error.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2784 * 0: success.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2785 * -EINVAL: vring does not use the
dma api, so we can not enable premapped mode.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2786 */
f8d1a236ad114f Xuan Zhuo 2023-10-11 2787 int
virtqueue_set_dma_premapped(struct virtqueue *_vq, bool mode)
8daafe9ebbd21a Xuan Zhuo 2023-08-10 @2788 {
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2789 struct vring_virtqueue *vq =
to_vvq(_vq);
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2790 u32 num;
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2791
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2792 START_USE(vq);
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2793
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2794 num = vq->packed_ring ?
vq->packed.vring.num : vq->split.vring.num;
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2795
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2796 if (num != vq->vq.num_free) {
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2797 END_USE(vq);
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2798 return -EINVAL;
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2799 }
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2800
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2801 if (!vq->use_dma_api) {
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2802 END_USE(vq);
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2803 return -EINVAL;
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2804 }
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2805
f8d1a236ad114f Xuan Zhuo 2023-10-11 2806 if (mode) {
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2807 vq->premapped = true;
b319940f83c21b Xuan Zhuo 2023-08-10 2808 vq->do_unmap = false;
f8d1a236ad114f Xuan Zhuo 2023-10-11 2809 } else {
f8d1a236ad114f Xuan Zhuo 2023-10-11 2810 vq->premapped = false;
f8d1a236ad114f Xuan Zhuo 2023-1
Re: [PATCH vhost 05/22] virtio_net: independent directory
Hi Xuan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc5 next-20231011]
[cannot apply to mst-vhost/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Xuan-Zhuo/virtio_ring-virtqueue_set_dma_premapped-support-disable/20231011-180709
base: linus/master
patch link:
https://lore.kernel.org/r/20231011092728.105904-6-xuanzhuo%40linux.alibaba.com
patch subject: [PATCH vhost 05/22] virtio_net: independent directory
config: sparc-allyesconfig
(https://download.01.org/0day-ci/archive/20231012/202310120705.ar0wpj7m-...@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20231012/202310120705.ar0wpj7m-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202310120705.ar0wpj7m-...@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/virtio/main.c: In function 'virtnet_find_vqs':
>> drivers/net/virtio/main.c:4091:48: warning: '%d' directive writing between 1
>> and 11 bytes into a region of size 10 [-Wformat-overflow=]
4091 | sprintf(vi->rq[i].name, "input.%d", i);
|^~
drivers/net/virtio/main.c:4091:41: note: directive argument in the range
[-2147483641, 65534]
4091 | sprintf(vi->rq[i].name, "input.%d", i);
| ^~
drivers/net/virtio/main.c:4091:17: note: 'sprintf' output between 8 and 18
bytes into a destination of size 16
4091 | sprintf(vi->rq[i].name, "input.%d", i);
| ^~
drivers/net/virtio/main.c:4092:49: warning: '%d' directive writing between 1
and 11 bytes into a region of size 9 [-Wformat-overflow=]
4092 | sprintf(vi->sq[i].name, "output.%d", i);
| ^~
drivers/net/virtio/main.c:4092:41: note: directive argument in the range
[-2147483641, 65534]
4092 | sprintf(vi->sq[i].name, "output.%d", i);
| ^~~
drivers/net/virtio/main.c:4092:17: note: 'sprintf' output between 9 and 19
bytes into a destination of size 16
4092 | sprintf(vi->sq[i].name, "output.%d", i);
| ^~~
vim +4091 drivers/net/virtio/main.c
d85b758f72b05a drivers/net/virtio_net.c Michael S. Tsirkin 2017-03-09 4046
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4047
static int virtnet_find_vqs(struct virtnet_info *vi)
3f9c10b0d478a3 drivers/net/virtio_net.c Amit Shah 2011-12-22 4048 {
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4049
vq_callback_t **callbacks;
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4050
struct virtqueue **vqs;
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4051
int ret = -ENOMEM;
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4052
int i, total_vqs;
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4053
const char **names;
d45b897b11eaf9 drivers/net/virtio_net.c Michael S. Tsirkin 2017-03-06 4054
bool *ctx;
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4055
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4056
/* We expect 1 RX virtqueue followed by 1 TX virtqueue, followed by
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4057
* possible N-1 RX/TX queue pairs used in multiqueue mode, followed by
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4058
* possible control vq.
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4059
*/
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4060
total_vqs = vi->max_queue_pairs * 2 +
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4061
virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ);
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4062
986a4f4d452dec drivers/net/virtio_net.c Jason Wang 2012-12-07 4063
/* Allocate space for find_vqs
Re: [PATCH vhost 11/22] virtio_net: sq support premapped mode
Hi Xuan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc5 next-20231013]
[cannot apply to mst-vhost/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Xuan-Zhuo/virtio_ring-virtqueue_set_dma_premapped-support-disable/20231011-180709
base: linus/master
patch link:
https://lore.kernel.org/r/20231011092728.105904-12-xuanzhuo%40linux.alibaba.com
patch subject: [PATCH vhost 11/22] virtio_net: sq support premapped mode
config: parisc-randconfig-001-20231013
(https://download.01.org/0day-ci/archive/20231013/202310131711.qjbkiwe0-...@intel.com/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20231013/202310131711.qjbkiwe0-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202310131711.qjbkiwe0-...@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/net/virtio/main.c:25:
drivers/net/virtio/virtio_net.h: In function 'virtnet_sq_unmap':
>> drivers/net/virtio/virtio_net.h:235:25: warning: cast from pointer to
>> integer of different size [-Wpointer-to-int-cast]
235 | head = (void *)((u64)data & ~VIRTIO_XMIT_DATA_MASK);
| ^
>> drivers/net/virtio/virtio_net.h:235:16: warning: cast to pointer from
>> integer of different size [-Wint-to-pointer-cast]
235 | head = (void *)((u64)data & ~VIRTIO_XMIT_DATA_MASK);
|^
drivers/net/virtio/main.c: In function 'virtnet_sq_map_sg':
>> drivers/net/virtio/main.c:600:25: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
600 | return (void *)((u64)head | ((u64)data &
VIRTIO_XMIT_DATA_MASK));
| ^
drivers/net/virtio/main.c:600:38: warning: cast from pointer to integer of
different size [-Wpointer-to-int-cast]
600 | return (void *)((u64)head | ((u64)data &
VIRTIO_XMIT_DATA_MASK));
| ^
>> drivers/net/virtio/main.c:600:16: warning: cast to pointer from integer of
>> different size [-Wint-to-pointer-cast]
600 | return (void *)((u64)head | ((u64)data &
VIRTIO_XMIT_DATA_MASK));
|^
drivers/net/virtio/main.c: In function 'virtnet_find_vqs':
drivers/net/virtio/main.c:3977:48: warning: '%d' directive writing between 1
and 11 bytes into a region of size 10 [-Wformat-overflow=]
3977 | sprintf(vi->rq[i].name, "input.%d", i);
|^~
drivers/net/virtio/main.c:3977:41: note: directive argument in the range
[-2147483641, 65534]
3977 | sprintf(vi->rq[i].name, "input.%d", i);
| ^~
drivers/net/virtio/main.c:3977:17: note: 'sprintf' output between 8 and 18
bytes into a destination of size 16
3977 | sprintf(vi->rq[i].name, "input.%d", i);
| ^~
drivers/net/virtio/main.c:3978:49: warning: '%d' directive writing between 1
and 11 bytes into a region of size 9 [-Wformat-overflow=]
3978 | sprintf(vi->sq[i].name, "output.%d", i);
| ^~
drivers/net/virtio/main.c:3978:41: note: directive argument in the range
[-2147483641, 65534]
3978 | sprintf(vi->sq[i].name, "output.%d", i);
| ^~~
drivers/net/virtio/main.c:3978:17: note: 'sprintf' output between 9 and 19
bytes into a destination of size 16
3978 | sprintf(vi->sq[i].name, "output.%d", i);
| ^~~
vim +235 drivers/net/virtio/virtio_net.h
230
231 static inline void *virtnet_sq_unmap(struct virtnet_sq *sq, void *data)
232 {
233 struct virtnet_sq_dma *next, *head;
234
> 235 head = (void *)((u64)data & ~VIRTIO_XMIT_DATA_MASK);
236
237 data = head->data;
238
239 while (head) {
240 virtqueue_dma_unmap_page_attrs(sq->vq, head->addr,
head->len, DMA_TO_DEVICE, 0);
241
24
Re: [PATCH V1 vfio 6/9] virtio-pci: Introduce APIs to execute legacy IO admin commands
Hi Yishai,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc6 next-20231017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Yishai-Hadas/virtio-pci-Fix-common-config-map-for-modern-device/20231017-214450
base: linus/master
patch link:
https://lore.kernel.org/r/20231017134217.82497-7-yishaih%40nvidia.com
patch subject: [PATCH V1 vfio 6/9] virtio-pci: Introduce APIs to execute legacy
IO admin commands
config: alpha-allyesconfig
(https://download.01.org/0day-ci/archive/20231018/202310180437.jo2csm6u-...@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20231018/202310180437.jo2csm6u-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202310180437.jo2csm6u-...@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/virtio/virtio_pci_modern.c:731:5: warning: no previous prototype for
>> 'virtio_pci_admin_list_query' [-Wmissing-prototypes]
731 | int virtio_pci_admin_list_query(struct pci_dev *pdev, u8 *buf, int
buf_size)
| ^~~
>> drivers/virtio/virtio_pci_modern.c:758:5: warning: no previous prototype for
>> 'virtio_pci_admin_list_use' [-Wmissing-prototypes]
758 | int virtio_pci_admin_list_use(struct pci_dev *pdev, u8 *buf, int
buf_size)
| ^
>> drivers/virtio/virtio_pci_modern.c:786:5: warning: no previous prototype for
>> 'virtio_pci_admin_legacy_io_write' [-Wmissing-prototypes]
786 | int virtio_pci_admin_legacy_io_write(struct pci_dev *pdev, u16
opcode,
| ^~~~
>> drivers/virtio/virtio_pci_modern.c:831:5: warning: no previous prototype for
>> 'virtio_pci_admin_legacy_io_read' [-Wmissing-prototypes]
831 | int virtio_pci_admin_legacy_io_read(struct pci_dev *pdev, u16 opcode,
| ^~~
>> drivers/virtio/virtio_pci_modern.c:877:5: warning: no previous prototype for
>> 'virtio_pci_admin_legacy_io_notify_info' [-Wmissing-prototypes]
877 | int virtio_pci_admin_legacy_io_notify_info(struct pci_dev *pdev,
| ^~
vim +/virtio_pci_admin_list_query +731 drivers/virtio/virtio_pci_modern.c
721
722 /*
723 * virtio_pci_admin_list_query - Provides to driver list of commands
724 * supported for the PCI VF.
725 * @dev: VF pci_dev
726 * @buf: buffer to hold the returned list
727 * @buf_size: size of the given buffer
728 *
729 * Returns 0 on success, or negative on failure.
730 */
> 731 int virtio_pci_admin_list_query(struct pci_dev *pdev, u8 *buf, int
> buf_size)
732 {
733 struct virtio_device *virtio_dev =
virtio_pci_vf_get_pf_dev(pdev);
734 struct virtio_admin_cmd cmd = {};
735 struct scatterlist result_sg;
736
737 if (!virtio_dev)
738 return -ENODEV;
739
740 sg_init_one(&result_sg, buf, buf_size);
741 cmd.opcode = cpu_to_le16(VIRTIO_ADMIN_CMD_LIST_QUERY);
742 cmd.group_type = cpu_to_le16(VIRTIO_ADMIN_GROUP_TYPE_SRIOV);
743 cmd.result_sg = &result_sg;
744
745 return vp_modern_admin_cmd_exec(virtio_dev, &cmd);
746 }
747 EXPORT_SYMBOL_GPL(virtio_pci_admin_list_query);
748
749 /*
750 * virtio_pci_admin_list_use - Provides to device list of commands
751 * used for the PCI VF.
752 * @dev: VF pci_dev
753 * @buf: buffer which holds the list
754 * @buf_size: size of the given buffer
755 *
756 * Returns 0 on success, or negative on failure.
757 */
> 758 int virtio_pci_admin_list_use(struct pci_dev *pdev, u8 *buf, int
> buf_size)
759 {
760 struct virtio_device *virtio_dev =
virtio_pci_vf_get_pf_dev(pdev);
761 struct virtio_admin_cmd cmd = {};
762 struct scatterlist data_sg;
763
764 if (!virtio_dev)
765 return -ENODEV;
766
767 sg_init_one(&data_sg, buf, buf_size);
768 cmd.opcode = cpu_to_le16(VIRTIO_ADMIN_CMD_LIST_USE);
769 cmd.group_type = cpu_to_le16(VIRTIO_ADMIN_GROUP_TYPE_SRIOV);
770 cmd.data_sg = &data_sg;
771
772 return vp_modern_admin_cmd_exec(virtio_dev, &c
Re: [PATCH v2] ALSA: virtio: use copy and fill_silence callbacks
Hi Matias,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa]
url:
https://github.com/intel-lab-lkp/linux/commits/Matias-Ezequiel-Vara-Larsen/ALSA-virtio-use-copy-and-fill_silence-callbacks/20231018-185108
base: 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa
patch link:https://lore.kernel.org/r/ZS%2B392ZzVIoEyv8n%40fedora
patch subject: [PATCH v2] ALSA: virtio: use copy and fill_silence callbacks
config: m68k-allyesconfig
(https://download.01.org/0day-ci/archive/20231018/202310182118.4uwjre2p-...@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20231018/202310182118.4uwjre2p-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202310182118.4uwjre2p-...@intel.com/
All warnings (new ones prefixed by >>):
>> sound/virtio/virtio_pcm_msg.c:200: warning: Function parameter or member
>> 'offset' not described in 'virtsnd_pcm_msg_send'
>> sound/virtio/virtio_pcm_msg.c:200: warning: Function parameter or member
>> 'bytes' not described in 'virtsnd_pcm_msg_send'
2 warnings as Errors
vim +200 sound/virtio/virtio_pcm_msg.c
f40a28679e0b7c Anton Yakovlev 2021-03-02 184
f40a28679e0b7c Anton Yakovlev 2021-03-02 185 /**
f40a28679e0b7c Anton Yakovlev 2021-03-02 186 *
virtsnd_pcm_msg_send() - Send asynchronous I/O messages.
f40a28679e0b7c Anton Yakovlev 2021-03-02 187 * @vss: VirtIO PCM
substream.
f40a28679e0b7c Anton Yakovlev 2021-03-02 188 *
f40a28679e0b7c Anton Yakovlev 2021-03-02 189 * All messages are
organized in an ordered circular list. Each time the
f40a28679e0b7c Anton Yakovlev 2021-03-02 190 * function is
called, all currently non-enqueued messages are added to the
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 191 * virtqueue. For
this, the function uses offset and bytes to calculate the
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 192 * messages that
need to be added.
f40a28679e0b7c Anton Yakovlev 2021-03-02 193 *
f40a28679e0b7c Anton Yakovlev 2021-03-02 194 * Context: Any
context. Expects the tx/rx queue and the VirtIO substream
f40a28679e0b7c Anton Yakovlev 2021-03-02 195 *
spinlocks to be held by caller.
f40a28679e0b7c Anton Yakovlev 2021-03-02 196 * Return: 0 on
success, -errno on failure.
f40a28679e0b7c Anton Yakovlev 2021-03-02 197 */
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 198 int
virtsnd_pcm_msg_send(struct virtio_pcm_substream *vss, unsigned long offset,
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 199
unsigned long bytes)
f40a28679e0b7c Anton Yakovlev 2021-03-02 @200 {
f40a28679e0b7c Anton Yakovlev 2021-03-02 201 struct
virtio_snd *snd = vss->snd;
f40a28679e0b7c Anton Yakovlev 2021-03-02 202 struct
virtio_device *vdev = snd->vdev;
f40a28679e0b7c Anton Yakovlev 2021-03-02 203 struct
virtqueue *vqueue = virtsnd_pcm_queue(vss)->vqueue;
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 204 unsigned long
period_bytes = snd_pcm_lib_period_bytes(vss->substream);
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 205 unsigned long
start, end, i;
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 206 unsigned int
msg_count = vss->msg_count;
f40a28679e0b7c Anton Yakovlev 2021-03-02 207 bool notify =
false;
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 208 int rc;
f40a28679e0b7c Anton Yakovlev 2021-03-02 209
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 210 start = offset
/ period_bytes;
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 211 end = (offset +
bytes - 1) / period_bytes;
f40a28679e0b7c Anton Yakovlev 2021-03-02 212
10ad52116c3a46 Matias Ezequiel Vara Larsen 2023-10-18 213 for (i = start;
i <= end; i++) {
f40a28679e0b7c Anton Yakovlev 2021-03-02 214 struct
virtio_pcm_msg *msg = vss->msgs[i];
f40a28679e0b7c Anton Yakovlev 2021-03-02 215 struct
scatterlist *psgs[] = {
f40a28679e0b7c Anton Yakovlev 2021-03-02 216
&msg->sgs[PCM_MSG_SG_XFER],
f40a28679e0b7c Anton Yakovlev 2021-03-02 217
&msg->sgs[PCM_MSG_SG_DATA],
f40a28679e0b7c Anton Yakovlev 2021-03-02 218
&msg->sgs[PCM_MSG_SG_STATUS]
f40a28679e0b7c A
[mst-vhost:vhost 18/35] drivers/virtio/virtio_pci_modern.c:54:17: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' {aka 'unsigned int'}
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: 185ec99c107fe7659a9d809bc7a8e7ab3c338bf9
commit: 37c82be3988d4cc710dee436d47cd80e792cab93 [18/35] virtio_pci: add check
for common cfg size
config: parisc-allyesconfig
(https://download.01.org/0day-ci/archive/20231019/202310190338.es0nnnf4-...@intel.com/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20231019/202310190338.es0nnnf4-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202310190338.es0nnnf4-...@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/pci.h:37,
from drivers/virtio/virtio_pci_common.h:21,
from drivers/virtio/virtio_pci_modern.c:20:
drivers/virtio/virtio_pci_modern.c: In function
'__vp_check_common_size_one_feature':
>> drivers/virtio/virtio_pci_modern.c:54:17: warning: format '%ld' expects
>> argument of type 'long int', but argument 3 has type 'size_t' {aka 'unsigned
>> int'} [-Wformat=]
54 | "virtio: common cfg size(%ld) does not match the
feature %s\n",
|
^~
include/linux/dev_printk.h:110:30: note: in definition of macro
'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__);
\
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt),
##__VA_ARGS__)
|^~~
drivers/virtio/virtio_pci_modern.c:53:9: note: in expansion of macro
'dev_err'
53 | dev_err(&vdev->dev,
| ^~~
drivers/virtio/virtio_pci_modern.c:54:44: note: format string is defined here
54 | "virtio: common cfg size(%ld) does not match the
feature %s\n",
| ~~^
||
|long int
| %d
vim +54 drivers/virtio/virtio_pci_modern.c
> 20 #include "virtio_pci_common.h"
21
22 static u64 vp_get_features(struct virtio_device *vdev)
23 {
24 struct virtio_pci_device *vp_dev = to_vp_device(vdev);
25
26 return vp_modern_get_features(&vp_dev->mdev);
27 }
28
29 static void vp_transport_features(struct virtio_device *vdev, u64
features)
30 {
31 struct virtio_pci_device *vp_dev = to_vp_device(vdev);
32 struct pci_dev *pci_dev = vp_dev->pci_dev;
33
34 if ((features & BIT_ULL(VIRTIO_F_SR_IOV)) &&
35 pci_find_ext_capability(pci_dev,
PCI_EXT_CAP_ID_SRIOV))
36 __virtio_set_bit(vdev, VIRTIO_F_SR_IOV);
37
38 if (features & BIT_ULL(VIRTIO_F_RING_RESET))
39 __virtio_set_bit(vdev, VIRTIO_F_RING_RESET);
40 }
41
42 static int __vp_check_common_size_one_feature(struct virtio_device
*vdev, u32 fbit,
43 u32 offset, const char
*fname)
44 {
45 struct virtio_pci_device *vp_dev = to_vp_device(vdev);
46
47 if (!__virtio_test_bit(vdev, fbit))
48 return 0;
49
50 if (likely(vp_dev->mdev.common_len >= offset))
51 return 0;
52
53 dev_err(&vdev->dev,
> 54 "virtio: common cfg size(%ld) does not match the
feature %s\n",
55 vp_dev->mdev.common_len, fname);
56
57 return -EINVAL;
58 }
59
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v3 1/5] x86/paravirt: move some functions and defines to alternative
Hi Juergen,
kernel test robot noticed the following build warnings:
[auto build test WARNING on kvm/queue]
[cannot apply to tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Juergen-Gross/x86-paravirt-move-some-functions-and-defines-to-alternative/20231019-171709
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
patch link:
https://lore.kernel.org/r/20231019091520.14540-2-jgross%40suse.com
patch subject: [PATCH v3 1/5] x86/paravirt: move some functions and defines to
alternative
reproduce:
(https://download.01.org/0day-ci/archive/20231019/202310191944.z8sc9h8o-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202310191944.z8sc9h8o-...@intel.com/
# many are suggestions rather than must-fix
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
#32: FILE: arch/x86/include/asm/alternative.h:334:
+#define DEFINE_ASM_FUNC(func, instr, sec) \
+ asm (".pushsection " #sec ", \"ax\"\n" \
+".global " #func "\n\t"\
+".type " #func ", @function\n\t" \
+ASM_FUNC_ALIGN "\n"\
+#func ":\n\t" \
+ASM_ENDBR \
+instr "\n\t" \
+ASM_RET\
+".size " #func ", . - " #func "\n\t" \
+".popsection")
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v3 4/5] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2
Hi Juergen, kernel test robot noticed the following build warnings: [auto build test WARNING on kvm/queue] [cannot apply to tip/x86/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Juergen-Gross/x86-paravirt-move-some-functions-and-defines-to-alternative/20231019-171709 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue patch link: https://lore.kernel.org/r/20231019091520.14540-5-jgross%40suse.com patch subject: [PATCH v3 4/5] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2 reproduce: (https://download.01.org/0day-ci/archive/20231019/202310191920.r0c39s5h-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310191920.r0c39s5h-...@intel.com/ # many are suggestions rather than must-fix ERROR:BRACKET_SPACE: space prohibited before open square bracket '[' #92: FILE: arch/x86/include/asm/paravirt_types.h:281: +#define paravirt_ptr(op) [paravirt_opptr] "m" (pv_ops.op) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v3 5/5] x86/paravirt: remove no longer needed paravirt patching code
Hi Juergen, kernel test robot noticed the following build warnings: [auto build test WARNING on kvm/queue] [cannot apply to tip/x86/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Juergen-Gross/x86-paravirt-move-some-functions-and-defines-to-alternative/20231019-171709 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue patch link: https://lore.kernel.org/r/20231019091520.14540-6-jgross%40suse.com patch subject: [PATCH v3 5/5] x86/paravirt: remove no longer needed paravirt patching code reproduce: (https://download.01.org/0day-ci/archive/20231019/202310191909.ussrxzxc-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310191909.ussrxzxc-...@intel.com/ # many are suggestions rather than must-fix WARNING:SPLIT_STRING: quoted string split across lines #327: FILE: arch/x86/tools/relocs.c:69: "__x86_cpu_dev_(start|end)|" + "__alt_instructions(_end)?|" -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH V1 vfio 6/9] virtio-pci: Introduce APIs to execute legacy IO admin commands
Hi Yishai,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc6]
[cannot apply to next-20231020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Yishai-Hadas/virtio-pci-Fix-common-config-map-for-modern-device/20231017-214450
base: linus/master
patch link:
https://lore.kernel.org/r/20231017134217.82497-7-yishaih%40nvidia.com
patch subject: [PATCH V1 vfio 6/9] virtio-pci: Introduce APIs to execute legacy
IO admin commands
config: x86_64-rhel-8.3-rust
(https://download.01.org/0day-ci/archive/20231022/202310220842.adaiizso-...@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git
ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20231022/202310220842.adaiizso-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202310220842.adaiizso-...@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/virtio/virtio_pci_modern.c:731:5: warning: no previous prototype for
>> function 'virtio_pci_admin_list_query' [-Wmissing-prototypes]
int virtio_pci_admin_list_query(struct pci_dev *pdev, u8 *buf, int buf_size)
^
drivers/virtio/virtio_pci_modern.c:731:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int virtio_pci_admin_list_query(struct pci_dev *pdev, u8 *buf, int buf_size)
^
static
>> drivers/virtio/virtio_pci_modern.c:758:5: warning: no previous prototype for
>> function 'virtio_pci_admin_list_use' [-Wmissing-prototypes]
int virtio_pci_admin_list_use(struct pci_dev *pdev, u8 *buf, int buf_size)
^
drivers/virtio/virtio_pci_modern.c:758:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int virtio_pci_admin_list_use(struct pci_dev *pdev, u8 *buf, int buf_size)
^
static
>> drivers/virtio/virtio_pci_modern.c:786:5: warning: no previous prototype for
>> function 'virtio_pci_admin_legacy_io_write' [-Wmissing-prototypes]
int virtio_pci_admin_legacy_io_write(struct pci_dev *pdev, u16 opcode,
^
drivers/virtio/virtio_pci_modern.c:786:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int virtio_pci_admin_legacy_io_write(struct pci_dev *pdev, u16 opcode,
^
static
>> drivers/virtio/virtio_pci_modern.c:831:5: warning: no previous prototype for
>> function 'virtio_pci_admin_legacy_io_read' [-Wmissing-prototypes]
int virtio_pci_admin_legacy_io_read(struct pci_dev *pdev, u16 opcode,
^
drivers/virtio/virtio_pci_modern.c:831:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int virtio_pci_admin_legacy_io_read(struct pci_dev *pdev, u16 opcode,
^
static
>> drivers/virtio/virtio_pci_modern.c:877:5: warning: no previous prototype for
>> function 'virtio_pci_admin_legacy_io_notify_info' [-Wmissing-prototypes]
int virtio_pci_admin_legacy_io_notify_info(struct pci_dev *pdev,
^
drivers/virtio/virtio_pci_modern.c:877:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int virtio_pci_admin_legacy_io_notify_info(struct pci_dev *pdev,
^
static
5 warnings generated.
vim +/virtio_pci_admin_list_query +731 drivers/virtio/virtio_pci_modern.c
721
722 /*
723 * virtio_pci_admin_list_query - Provides to driver list of commands
724 * supported for the PCI VF.
725 * @dev: VF pci_dev
726 * @buf: buffer to hold the returned list
727 * @buf_size: size of the given buffer
728 *
729 * Returns 0 on success, or negative on failure.
730 */
> 731 int virtio_pci_admin_list_query(struct pci_dev *pdev, u8 *buf, int
> buf_size)
732 {
733 struct virtio_device *virtio_dev =
virtio_pci_vf_get_pf_dev(pdev);
734 struct virtio_admin_cmd cmd = {};
735 struct scatterlist result_sg;
736
737 if (!virtio_dev)
738 return -ENODEV;
739
740 sg_init_one(&result_sg, buf, buf_size);
741 cmd.opcode = cpu_to_le16(VIRTIO_ADMIN_CMD_LIST_QUERY);
742 cmd.group_type = cpu_to_le16(VIRTIO_ADMIN_GROUP_TYPE_SRIOV);
743 cmd.result_sg = &result_sg;
744
Re: [PATCH v3 4/5] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2
Hi Juergen, kernel test robot noticed the following build errors: [auto build test ERROR on kvm/queue] [also build test ERROR on tip/master linus/master v6.6-rc7 next-20231025] [cannot apply to tip/x86/core kvm/linux-next tip/auto-latest] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Juergen-Gross/x86-paravirt-move-some-functions-and-defines-to-alternative/20231019-171709 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue patch link: https://lore.kernel.org/r/20231019091520.14540-5-jgross%40suse.com patch subject: [PATCH v3 4/5] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2 config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231026/202310261653.lkirqagq-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231026/202310261653.lkirqagq-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310261653.lkirqagq-...@intel.com/ All errors (new ones prefixed by >>): arch/x86/entry/entry_64.S: Assembler messages: >> arch/x86/entry/entry_64.S:454: Error: no such instruction: `alt_call_instr' arch/x86/entry/entry_64.S:319: Info: macro invoked from here arch/x86/entry/entry_64.S:1138: Info: macro invoked from here vim +454 arch/x86/entry/entry_64.S 6368558c37107b Thomas Gleixner 2020-05-21 442 cfa82a00533f70 Thomas Gleixner 2020-02-25 443 /** cfa82a00533f70 Thomas Gleixner 2020-02-25 444 * idtentry_mce_db - Macro to generate entry stubs for #MC and #DB cfa82a00533f70 Thomas Gleixner 2020-02-25 445 * @vector: Vector number cfa82a00533f70 Thomas Gleixner 2020-02-25 446 * @asmsym: ASM symbol for the entry point cfa82a00533f70 Thomas Gleixner 2020-02-25 447 * @cfunc: C function to be called cfa82a00533f70 Thomas Gleixner 2020-02-25 448 * cfa82a00533f70 Thomas Gleixner 2020-02-25 449 * The macro emits code to set up the kernel context for #MC and #DB cfa82a00533f70 Thomas Gleixner 2020-02-25 450 * cfa82a00533f70 Thomas Gleixner 2020-02-25 451 * If the entry comes from user space it uses the normal entry path cfa82a00533f70 Thomas Gleixner 2020-02-25 452 * including the return to user space work and preemption checks on cfa82a00533f70 Thomas Gleixner 2020-02-25 453 * exit. cfa82a00533f70 Thomas Gleixner 2020-02-25 @454 * cfa82a00533f70 Thomas Gleixner 2020-02-25 455 * If hits in kernel mode then it needs to go through the paranoid cfa82a00533f70 Thomas Gleixner 2020-02-25 456 * entry as the exception can hit any random state. No preemption cfa82a00533f70 Thomas Gleixner 2020-02-25 457 * check on exit to keep the paranoid path simple. cfa82a00533f70 Thomas Gleixner 2020-02-25 458 */ cfa82a00533f70 Thomas Gleixner 2020-02-25 459 .macro idtentry_mce_db vector asmsym cfunc cfa82a00533f70 Thomas Gleixner 2020-02-25 460 SYM_CODE_START(\asmsym) 4708ea14bef314 Josh Poimboeuf 2023-03-01 461 UNWIND_HINT_IRET_ENTRY 8f93402b92d443 Peter Zijlstra 2022-03-08 462 ENDBR cfa82a00533f70 Thomas Gleixner 2020-02-25 463 ASM_CLAC c64cc2802a784e Lai Jiangshan 2022-04-21 464 cld cfa82a00533f70 Thomas Gleixner 2020-02-25 465 cfa82a00533f70 Thomas Gleixner 2020-02-25 466 pushq $-1 /* ORIG_RAX: no syscall to restart */ cfa82a00533f70 Thomas Gleixner 2020-02-25 467 cfa82a00533f70 Thomas Gleixner 2020-02-25 468 /* cfa82a00533f70 Thomas Gleixner 2020-02-25 469 * If the entry is from userspace, switch stacks and treat it as cfa82a00533f70 Thomas Gleixner 2020-02-25 470 * a normal entry. cfa82a00533f70 Thomas Gleixner 2020-02-25 471 */ cfa82a00533f70 Thomas Gleixner 2020-02-25 472 testb $3, CS-ORIG_RAX(%rsp) cfa82a00533f70 Thomas Gleixner 2020-02-25 473 jnz .Lfrom_usermode_switch_stack_\@ cfa82a00533f70 Thomas Gleixner 2020-02-25 474 c82965f9e53005 Chang S. Bae2020-05-28 475 /* paranoid_entry returns GS information for paranoid_exit in EBX. */ cfa82a00533f70 Thomas Gleixner 2020-02-25 476 callparanoid_entry cfa82a00533f70 Thomas Gleixner 2020-02-25 477 cfa82a00533f70 Thomas Gleixner 2020-02-25 478 UNWIND_HINT_REGS cfa82a00533f70 Thomas Gleixner 2020-02-25 479 cfa82a00533f70 Thomas Gleixner 2020-02-25 480 movq%rsp, %rdi /* pt_regs pointer */ cfa82a00533f70 Thomas Gleixner 2020-02-25 481 cfa82a00533f70 Thomas Gleixner 2020-02-25
Re: [PATCH V2 vfio 5/9] virtio-pci: Initialize the supported admin commands
Hi Yishai,
kernel test robot noticed the following build warnings:
[auto build test WARNING on awilliam-vfio/for-linus]
[also build test WARNING on linus/master v6.6]
[cannot apply to awilliam-vfio/next mst-vhost/linux-next next-20231102]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Yishai-Hadas/virtio-Define-feature-bit-for-administration-virtqueue/20231030-000414
base: https://github.com/awilliam/linux-vfio.git for-linus
patch link:
https://lore.kernel.org/r/20231029155952.67686-6-yishaih%40nvidia.com
patch subject: [PATCH V2 vfio 5/9] virtio-pci: Initialize the supported admin
commands
config: i386-randconfig-061-20231102
(https://download.01.org/0day-ci/archive/20231103/202311030838.gjyabtjm-...@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20231103/202311030838.gjyabtjm-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202311030838.gjyabtjm-...@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/virtio/virtio_pci_modern.c:726:16: sparse: sparse: restricted __le16
>> degrades to integer
vim +726 drivers/virtio/virtio_pci_modern.c
673
674 static int vp_modern_admin_cmd_exec(struct virtio_device *vdev,
675 struct virtio_admin_cmd *cmd)
676 {
677 struct scatterlist *sgs[VIRTIO_AVQ_SGS_MAX], hdr, stat;
678 struct virtio_pci_device *vp_dev = to_vp_device(vdev);
679 struct virtio_admin_cmd_status *va_status;
680 unsigned int out_num = 0, in_num = 0;
681 struct virtio_admin_cmd_hdr *va_hdr;
682 struct virtqueue *avq;
683 u16 status;
684 int ret;
685
686 avq = virtio_has_feature(vdev, VIRTIO_F_ADMIN_VQ) ?
687 vp_dev->admin_vq.info.vq : NULL;
688 if (!avq)
689 return -EOPNOTSUPP;
690
691 va_status = kzalloc(sizeof(*va_status), GFP_KERNEL);
692 if (!va_status)
693 return -ENOMEM;
694
695 va_hdr = kzalloc(sizeof(*va_hdr), GFP_KERNEL);
696 if (!va_hdr) {
697 ret = -ENOMEM;
698 goto err_alloc;
699 }
700
701 va_hdr->opcode = cmd->opcode;
702 va_hdr->group_type = cmd->group_type;
703 va_hdr->group_member_id = cmd->group_member_id;
704
705 /* Add header */
706 sg_init_one(&hdr, va_hdr, sizeof(*va_hdr));
707 sgs[out_num] = &hdr;
708 out_num++;
709
710 if (cmd->data_sg) {
711 sgs[out_num] = cmd->data_sg;
712 out_num++;
713 }
714
715 /* Add return status */
716 sg_init_one(&stat, va_status, sizeof(*va_status));
717 sgs[out_num + in_num] = &stat;
718 in_num++;
719
720 if (cmd->result_sg) {
721 sgs[out_num + in_num] = cmd->result_sg;
722 in_num++;
723 }
724
725 if (cmd->opcode == VIRTIO_ADMIN_CMD_LIST_QUERY ||
> 726 cmd->opcode == VIRTIO_ADMIN_CMD_LIST_USE)
727 ret = __virtqueue_exec_admin_cmd(&vp_dev->admin_vq, sgs,
728 out_num, in_num,
729 sgs, GFP_KERNEL);
730 else
731 ret = virtqueue_exec_admin_cmd(&vp_dev->admin_vq, sgs,
732 out_num, in_num,
733 sgs, GFP_KERNEL);
734 if (ret) {
735 dev_err(&vdev->dev,
736 "Failed to execute command on admin vq: %d\n.",
ret);
737 goto err_cmd_exec;
738 }
739
740 status = le16_to_cpu(va_status->status);
741 if (status != VIRTIO_ADMIN_STATUS_OK) {
742 dev_err(&vdev->dev,
743 "admin command error: status(%#x)
qualifier(%#x)\n",
744 status,
le16_to_cpu(va_status->status_qualifier));
745 ret = -status;
746 }
747
748 err_cmd_exec:
749 kfree(va_hdr);
750 err_alloc:
751
Re: [PATCH net-next v2 4/5] virtio-net: support rx netdim
Hi Heng, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/virtio-net-returns-whether-napi-is-complete/20231103-040818 base: net-next/main patch link: https://lore.kernel.org/r/12c77098b73313eea8fdc88a3d1d20611444827d.1698929590.git.hengqi%40linux.alibaba.com patch subject: [PATCH net-next v2 4/5] virtio-net: support rx netdim config: arm-vexpress_defconfig (https://download.01.org/0day-ci/archive/20231106/202311061237.i4bmaa06-...@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231106/202311061237.i4bmaa06-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311061237.i4bmaa06-...@intel.com/ All errors (new ones prefixed by >>): >> ld.lld: error: undefined symbol: net_dim_get_rx_moderation >>> referenced by virtio_net.c:3529 (drivers/net/virtio_net.c:3529) >>> drivers/net/virtio_net.o:(virtnet_rx_dim_work) in archive vmlinux.a -- >> ld.lld: error: undefined symbol: net_dim >>> referenced by virtio_net.c:2176 (drivers/net/virtio_net.c:2176) >>> drivers/net/virtio_net.o:(virtnet_poll) in archive vmlinux.a -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI
Hi Wu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.15-rc3 next-20210922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wu-Zongyong/virtio-pci-introduce-legacy-device-module/20210929-115033
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
a4e6f95a891ac08bd09d62e3e6dae239b150f4c1
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/86ed35603fb93a4bc8c8929ff89edd5f6556ca44
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wu-Zongyong/virtio-pci-introduce-legacy-device-module/20210929-115033
git checkout 86ed35603fb93a4bc8c8929ff89edd5f6556ca44
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross
ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/vdpa/alibaba/eni_vdpa.c:446:13: error: 'eni_vdpa_free_irq_vectors'
>> defined but not used [-Werror=unused-function]
446 | static void eni_vdpa_free_irq_vectors(void *data)
| ^
>> drivers/vdpa/alibaba/eni_vdpa.c:423:12: error: 'eni_vdpa_get_num_queues'
>> defined but not used [-Werror=unused-function]
423 | static u16 eni_vdpa_get_num_queues(struct eni_vdpa *eni_vdpa)
|^~~
>> drivers/vdpa/alibaba/eni_vdpa.c:396:37: error: 'eni_vdpa_ops' defined but
>> not used [-Werror=unused-const-variable=]
396 | static const struct vdpa_config_ops eni_vdpa_ops = {
| ^~~~
cc1: all warnings being treated as errors
vim +/eni_vdpa_free_irq_vectors +446 drivers/vdpa/alibaba/eni_vdpa.c
395
> 396 static const struct vdpa_config_ops eni_vdpa_ops = {
397 .get_features = eni_vdpa_get_features,
398 .set_features = eni_vdpa_set_features,
399 .get_status = eni_vdpa_get_status,
400 .set_status = eni_vdpa_set_status,
401 .reset = eni_vdpa_reset,
402 .get_vq_num_max = eni_vdpa_get_vq_num_max,
403 .get_vq_num_min = eni_vdpa_get_vq_num_min,
404 .get_vq_state = eni_vdpa_get_vq_state,
405 .set_vq_state = eni_vdpa_set_vq_state,
406 .set_vq_cb = eni_vdpa_set_vq_cb,
407 .set_vq_ready = eni_vdpa_set_vq_ready,
408 .get_vq_ready = eni_vdpa_get_vq_ready,
409 .set_vq_num = eni_vdpa_set_vq_num,
410 .set_vq_address = eni_vdpa_set_vq_address,
411 .kick_vq= eni_vdpa_kick_vq,
412 .get_device_id = eni_vdpa_get_device_id,
413 .get_vendor_id = eni_vdpa_get_vendor_id,
414 .get_vq_align = eni_vdpa_get_vq_align,
415 .get_config_size = eni_vdpa_get_config_size,
416 .get_config = eni_vdpa_get_config,
417 .set_config = eni_vdpa_set_config,
418 .set_config_cb = eni_vdpa_set_config_cb,
419 .get_vq_irq = eni_vdpa_get_vq_irq,
420 };
421
422
> 423 static u16 eni_vdpa_get_num_queues(struct eni_vdpa *eni_vdpa)
424 {
425 struct virtio_pci_legacy_device *ldev = &eni_vdpa->ldev;
426 u32 features = vp_legacy_get_features(ldev);
427 u16 num = 2;
428
429 if (features & BIT_ULL(VIRTIO_NET_F_MQ)) {
430 __virtio16 max_virtqueue_pairs;
431
432 eni_vdpa_get_config(&eni_vdpa->vdpa,
433 offsetof(struct virtio_net_config,
max_virtqueue_pairs),
434 &max_virtqueue_pairs,
435 sizeof(max_virtqueue_pairs));
436 num = 2 *
__virtio16_to_cpu(virtio_legacy_is_little_endian(),
437 max_virtqueue_pairs);
438 }
439
440 if (features & BIT_ULL(VIRTIO_NET_F_CTRL_VQ))
441 num += 1;
442
443 return num;
444 }
445
> 446 static void eni_vdpa_free_irq_vectors(void *data)
447 {
448 pci_free_irq_vectors(data);
449 }
450
---
0-DAY CI Kernel Test Service, Inte
Re: [PATCH V4 6/8] io_uring: switch to kernel_worker
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20211007]
[cannot apply to mst-vhost/linux-next vgupta-arc/for-next arm64/for-next/core
uclinux-h8/h8300-next geert-m68k/for-next openrisc/for-next
deller-parisc/for-next powerpc/next s390/features linus/master v5.15-rc4
v5.15-rc3 v5.15-rc2 v5.15-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Mike-Christie/Use-copy_process-create_io_thread-in-vhost-layer/20211008-093610
base:f8dc23b3dc0cc5b32dfd0c446e59377736d073a7
config: hexagon-randconfig-r045-20211007 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
b1a45c62f03ecbeb4544b0c65a01ee4586235a61)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/19238ec927cb55bbd6fd6bdf64bac6a99f457b8c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Mike-Christie/Use-copy_process-create_io_thread-in-vhost-layer/20211008-093610
git checkout 19238ec927cb55bbd6fd6bdf64bac6a99f457b8c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
ARCH=hexagon
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
kernel/fork.c:161:13: warning: no previous prototype for function
'arch_release_task_struct' [-Wmissing-prototypes]
void __weak arch_release_task_struct(struct task_struct *tsk)
^
kernel/fork.c:161:1: note: declare 'static' if the function is not intended
to be used outside of this translation unit
void __weak arch_release_task_struct(struct task_struct *tsk)
^
static
kernel/fork.c:814:20: warning: no previous prototype for function
'arch_task_cache_init' [-Wmissing-prototypes]
void __init __weak arch_task_cache_init(void) { }
^
kernel/fork.c:814:1: note: declare 'static' if the function is not intended
to be used outside of this translation unit
void __init __weak arch_task_cache_init(void) { }
^
static
kernel/fork.c:909:12: warning: no previous prototype for function
'arch_dup_task_struct' [-Wmissing-prototypes]
int __weak arch_dup_task_struct(struct task_struct *dst,
^
kernel/fork.c:909:1: note: declare 'static' if the function is not intended
to be used outside of this translation unit
int __weak arch_dup_task_struct(struct task_struct *dst,
^
static
>> kernel/fork.c:2581:21: warning: no previous prototype for function
>> 'create_io_thread' [-Wmissing-prototypes]
struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
^
kernel/fork.c:2581:1: note: declare 'static' if the function is not intended
to be used outside of this translation unit
struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
^
static
4 warnings generated.
vim +/create_io_thread +2581 kernel/fork.c
13585fa0668c72 Nadav Amit2019-04-25 2574
cc440e8738e5c8 Jens Axboe2021-03-04 2575 /*
cc440e8738e5c8 Jens Axboe2021-03-04 2576 * This is like kernel_clone(),
but shaved down and tailored to just
cc440e8738e5c8 Jens Axboe2021-03-04 2577 * creating io_uring workers. It
returns a created task, or an error pointer.
cc440e8738e5c8 Jens Axboe2021-03-04 2578 * The returned task is
inactive, and the caller must fire it up through
cc440e8738e5c8 Jens Axboe2021-03-04 2579 * wake_up_new_task(p). All
signals are blocked in the created task.
cc440e8738e5c8 Jens Axboe2021-03-04 2580 */
cc440e8738e5c8 Jens Axboe2021-03-04 @2581 struct task_struct
*create_io_thread(int (*fn)(void *), void *arg, int node)
cc440e8738e5c8 Jens Axboe2021-03-04 2582 {
cc440e8738e5c8 Jens Axboe2021-03-04 2583 unsigned long flags =
CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|
cc440e8738e5c8 Jens Axboe2021-03-04 2584
CLONE_IO;
cc440e8738e5c8 Jens Axboe2021-03-04 2585 struct kernel_clone_args args =
{
cc440e8738e5c8 Jens Axboe2021-03-04 2586 .flags =
((lower_32_bits(flags) | CLONE_VM |
cc440e8738e5c8 Jens Axboe2021-03-04 2587
CLONE_UNTRACED) & ~CSIGNAL),
cc440e8738e5c8 Jens Axboe2021-03-04 2588 .exit_signal=
(lower_32_bits(flags) & CSIGNAL),
cc440e8738e5c8 Jens Axboe2021-03-04 2589 .stack
Re: [PATCH V4 6/8] io_uring: switch to kernel_worker
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20211007]
[cannot apply to mst-vhost/linux-next vgupta-arc/for-next arm64/for-next/core
uclinux-h8/h8300-next geert-m68k/for-next openrisc/for-next
deller-parisc/for-next powerpc/next s390/features linus/master v5.15-rc4
v5.15-rc3 v5.15-rc2 v5.15-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Mike-Christie/Use-copy_process-create_io_thread-in-vhost-layer/20211008-093610
base:f8dc23b3dc0cc5b32dfd0c446e59377736d073a7
config: arc-randconfig-r043-20211007 (attached as .config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/19238ec927cb55bbd6fd6bdf64bac6a99f457b8c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Mike-Christie/Use-copy_process-create_io_thread-in-vhost-layer/20211008-093610
git checkout 19238ec927cb55bbd6fd6bdf64bac6a99f457b8c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross
ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
kernel/fork.c:161:13: warning: no previous prototype for
'arch_release_task_struct' [-Wmissing-prototypes]
161 | void __weak arch_release_task_struct(struct task_struct *tsk)
| ^~~~
kernel/fork.c:814:20: warning: no previous prototype for
'arch_task_cache_init' [-Wmissing-prototypes]
814 | void __init __weak arch_task_cache_init(void) { }
|^~~~
kernel/fork.c:909:12: warning: no previous prototype for
'arch_dup_task_struct' [-Wmissing-prototypes]
909 | int __weak arch_dup_task_struct(struct task_struct *dst,
|^~~~
>> kernel/fork.c:2581:21: warning: no previous prototype for 'create_io_thread'
>> [-Wmissing-prototypes]
2581 | struct task_struct *create_io_thread(int (*fn)(void *), void *arg,
int node)
| ^~~~
In file included from include/linux/perf_event.h:25,
from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:87,
from kernel/fork.c:54:
arch/arc/include/asm/perf_event.h:126:27: warning: 'arc_pmu_cache_map'
defined but not used [-Wunused-const-variable=]
126 | static const unsigned int
arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = {
| ^
arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map'
defined but not used [-Wunused-const-variable=]
91 | static const char * const arc_pmu_ev_hw_map[] = {
| ^
vim +/create_io_thread +2581 kernel/fork.c
13585fa0668c72 Nadav Amit2019-04-25 2574
cc440e8738e5c8 Jens Axboe2021-03-04 2575 /*
cc440e8738e5c8 Jens Axboe2021-03-04 2576 * This is like kernel_clone(),
but shaved down and tailored to just
cc440e8738e5c8 Jens Axboe2021-03-04 2577 * creating io_uring workers. It
returns a created task, or an error pointer.
cc440e8738e5c8 Jens Axboe2021-03-04 2578 * The returned task is
inactive, and the caller must fire it up through
cc440e8738e5c8 Jens Axboe2021-03-04 2579 * wake_up_new_task(p). All
signals are blocked in the created task.
cc440e8738e5c8 Jens Axboe2021-03-04 2580 */
cc440e8738e5c8 Jens Axboe2021-03-04 @2581 struct task_struct
*create_io_thread(int (*fn)(void *), void *arg, int node)
cc440e8738e5c8 Jens Axboe2021-03-04 2582 {
cc440e8738e5c8 Jens Axboe2021-03-04 2583 unsigned long flags =
CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|
cc440e8738e5c8 Jens Axboe2021-03-04 2584
CLONE_IO;
cc440e8738e5c8 Jens Axboe2021-03-04 2585 struct kernel_clone_args args =
{
cc440e8738e5c8 Jens Axboe2021-03-04 2586 .flags =
((lower_32_bits(flags) | CLONE_VM |
cc440e8738e5c8 Jens Axboe2021-03-04 2587
CLONE_UNTRACED) & ~CSIGNAL),
cc440e8738e5c8 Jens Axboe2021-03-04 2588 .exit_signal=
(lower_32_bits(flags) & CSIGNAL),
cc440e8738e5c8 Jens Axboe2021-03-04 2589 .stack =
(unsigned long)fn,
cc440e8738e5c8 Jens Axboe2021-03-04 259
[mst-vhost:vhost 14/16] drivers/virtio/virtio.c:207:13: error: 'virtio_reset_device' defined but not used
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: 825f5e35666901a3cf6963c8ea3aea0898846a8e
commit: e958cd4aadfac0d2968c71208d39069e7968164c [14/16] virtio: wrap
config->reset calls
config: microblaze-buildonly-randconfig-r001-20211013 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?id=e958cd4aadfac0d2968c71208d39069e7968164c
git remote add mst-vhost
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
git fetch --no-tags mst-vhost vhost
git checkout e958cd4aadfac0d2968c71208d39069e7968164c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross
ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
drivers/virtio/virtio.c:207:13: error: static declaration of
'virtio_reset_device' follows non-static declaration
207 | static void virtio_reset_device(struct virtio_device *dev)
| ^~~
In file included from drivers/virtio/virtio.c:2:
include/linux/virtio.h:141:6: note: previous declaration of
'virtio_reset_device' with type 'void(struct virtio_device *)'
141 | void virtio_reset_device(struct virtio_device *dev);
| ^~~
>> drivers/virtio/virtio.c:207:13: error: 'virtio_reset_device' defined but not
>> used [-Werror=unused-function]
207 | static void virtio_reset_device(struct virtio_device *dev)
| ^~~
cc1: all warnings being treated as errors
vim +/virtio_reset_device +207 drivers/virtio/virtio.c
206
> 207 static void virtio_reset_device(struct virtio_device *dev)
208 {
209 dev->config->reset(dev);
210 }
211
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[mst-vhost:vhost 4/47] drivers/block/virtio_blk.c:175:17: error: implicit declaration of function 'sg_free_table_chained'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: 2b109044b081148b58974f5696ffd4383c3e9abb
commit: b2c5221fd074fbb0e57d6707bed5b7386bf430ed [4/47] virtio-blk: avoid
preallocating big SGL for data
config: riscv-nommu_virt_defconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?id=b2c5221fd074fbb0e57d6707bed5b7386bf430ed
git remote add mst-vhost
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
git fetch --no-tags mst-vhost vhost
git checkout b2c5221fd074fbb0e57d6707bed5b7386bf430ed
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross
ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
drivers/block/virtio_blk.c: In function 'virtblk_unmap_data':
>> drivers/block/virtio_blk.c:175:17: error: implicit declaration of function
>> 'sg_free_table_chained' [-Werror=implicit-function-declaration]
175 | sg_free_table_chained(&vbr->sg_table,
| ^
drivers/block/virtio_blk.c: In function 'virtblk_map_data':
>> drivers/block/virtio_blk.c:188:15: error: implicit declaration of function
>> 'sg_alloc_table_chained'; did you mean 'sg_alloc_table'?
>> [-Werror=implicit-function-declaration]
188 | err = sg_alloc_table_chained(&vbr->sg_table,
| ^~
| sg_alloc_table
cc1: some warnings being treated as errors
vim +/sg_free_table_chained +175 drivers/block/virtio_blk.c
171
172 static void virtblk_unmap_data(struct request *req, struct virtblk_req
*vbr)
173 {
174 if (blk_rq_nr_phys_segments(req))
> 175 sg_free_table_chained(&vbr->sg_table,
176VIRTIO_BLK_INLINE_SG_CNT);
177 }
178
179 static int virtblk_map_data(struct blk_mq_hw_ctx *hctx, struct request
*req,
180 struct virtblk_req *vbr)
181 {
182 int err;
183
184 if (!blk_rq_nr_phys_segments(req))
185 return 0;
186
187 vbr->sg_table.sgl = vbr->sg;
> 188 err = sg_alloc_table_chained(&vbr->sg_table,
189 blk_rq_nr_phys_segments(req),
190 vbr->sg_table.sgl,
191 VIRTIO_BLK_INLINE_SG_CNT);
192 if (unlikely(err))
193 return -ENOMEM;
194
195 return blk_rq_map_sg(hctx->queue, req, vbr->sg_table.sgl);
196 }
197
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[mst-vhost:vhost 4/47] drivers/block/virtio_blk.c:238:24: sparse: sparse: incorrect type in return expression (different base types)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: 2b109044b081148b58974f5696ffd4383c3e9abb
commit: b2c5221fd074fbb0e57d6707bed5b7386bf430ed [4/47] virtio-blk: avoid
preallocating big SGL for data
config: i386-randconfig-s001-20211025 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?id=b2c5221fd074fbb0e57d6707bed5b7386bf430ed
git remote add mst-vhost
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
git fetch --no-tags mst-vhost vhost
git checkout b2c5221fd074fbb0e57d6707bed5b7386bf430ed
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/block/virtio_blk.c:238:24: sparse: sparse: incorrect type in return
>> expression (different base types) @@ expected int @@ got restricted
>> blk_status_t [usertype] @@
drivers/block/virtio_blk.c:238:24: sparse: expected int
drivers/block/virtio_blk.c:238:24: sparse: got restricted blk_status_t
[usertype]
drivers/block/virtio_blk.c:246:32: sparse: sparse: incorrect type in return
expression (different base types) @@ expected int @@ got restricted
blk_status_t [usertype] @@
drivers/block/virtio_blk.c:246:32: sparse: expected int
drivers/block/virtio_blk.c:246:32: sparse: got restricted blk_status_t
[usertype]
>> drivers/block/virtio_blk.c:320:24: sparse: sparse: incorrect type in return
>> expression (different base types) @@ expected restricted blk_status_t @@
>> got int [assigned] err @@
drivers/block/virtio_blk.c:320:24: sparse: expected restricted
blk_status_t
drivers/block/virtio_blk.c:320:24: sparse: got int [assigned] err
vim +238 drivers/block/virtio_blk.c
203
204 static int virtblk_setup_cmd(struct virtio_device *vdev, struct request
*req,
205 struct virtblk_req *vbr)
206 {
207 bool unmap = false;
208 u32 type;
209
210 vbr->out_hdr.sector = 0;
211
212 switch (req_op(req)) {
213 case REQ_OP_READ:
214 type = VIRTIO_BLK_T_IN;
215 vbr->out_hdr.sector = cpu_to_virtio64(vdev,
216blk_rq_pos(req));
217 break;
218 case REQ_OP_WRITE:
219 type = VIRTIO_BLK_T_OUT;
220 vbr->out_hdr.sector = cpu_to_virtio64(vdev,
221blk_rq_pos(req));
222 break;
223 case REQ_OP_FLUSH:
224 type = VIRTIO_BLK_T_FLUSH;
225 break;
226 case REQ_OP_DISCARD:
227 type = VIRTIO_BLK_T_DISCARD;
228 break;
229 case REQ_OP_WRITE_ZEROES:
230 type = VIRTIO_BLK_T_WRITE_ZEROES;
231 unmap = !(req->cmd_flags & REQ_NOUNMAP);
232 break;
233 case REQ_OP_DRV_IN:
234 type = VIRTIO_BLK_T_GET_ID;
235 break;
236 default:
237 WARN_ON_ONCE(1);
> 238 return BLK_STS_IOERR;
239 }
240
241 vbr->out_hdr.type = cpu_to_virtio32(vdev, type);
242 vbr->out_hdr.ioprio = cpu_to_virtio32(vdev,
req_get_ioprio(req));
243
244 if (type == VIRTIO_BLK_T_DISCARD || type ==
VIRTIO_BLK_T_WRITE_ZEROES) {
245 if (virtblk_setup_discard_write_zeroes(req, unmap))
246 return BLK_STS_RESOURCE;
247 }
248
249 return 0;
250 }
251
252 static inline void virtblk_request_done(struct request *req)
253 {
254 struct virtblk_req *vbr = blk_mq_rq_to_pdu(req);
255
256 virtblk_unmap_data(req, vbr);
257 virtblk_cleanup_cmd(req);
258 blk_mq_end_request(req, virtblk_result(vbr));
259 }
260
261 static void virtblk_done(struct virtqueue *vq)
262 {
263 struct virtio_blk *vblk = vq->vdev->priv;
264 bool req_done = false;
265 int qid = vq->index;
266 struct virtblk_req *vbr;
267 unsigned long flags;
268 unsigned int len;
269
270 spin_lock_irqsave(&vblk->vqs[qid].lock, flags);
271 do {
272 virtqueue_disable_cb(vq);
273 while ((vbr = virtqueue_get_
Re: [PATCH 1/3] virtio: cache indirect desc for split
Hi Xuan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on horms-ipvs/master]
[also build test WARNING on linus/master v5.15-rc7 next-20211027]
[cannot apply to mst-vhost/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/8935e116c155fb7d484bad35a42b2ca98f75e384
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
git checkout 8935e116c155fb7d484bad35a42b2ca98f75e384
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross
ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
drivers/virtio/virtio_ring.c: In function 'desc_cache_chain_free_split':
>> drivers/virtio/virtio_ring.c:438:25: warning: cast to pointer from integer
>> of different size [-Wint-to-pointer-cast]
438 | chain = (void *)desc->addr;
| ^
drivers/virtio/virtio_ring.c: In function 'desc_cache_put_split':
>> drivers/virtio/virtio_ring.c:447:30: warning: cast from pointer to integer
>> of different size [-Wpointer-to-int-cast]
447 | desc->addr = (u64)vq->desc_cache_chain;
| ^
drivers/virtio/virtio_ring.c: In function 'alloc_indirect_split':
drivers/virtio/virtio_ring.c:464:48: warning: cast to pointer from integer
of different size [-Wint-to-pointer-cast]
464 | vq->desc_cache_chain = (void *)desc->addr;
|^
vim +438 drivers/virtio/virtio_ring.c
431
432 static void desc_cache_chain_free_split(void *chain)
433 {
434 struct vring_desc *desc;
435
436 while (chain) {
437 desc = chain;
> 438 chain = (void *)desc->addr;
439 kfree(desc);
440 }
441 }
442
443 static void desc_cache_put_split(struct vring_virtqueue *vq,
444 struct vring_desc *desc, int n)
445 {
446 if (vq->use_desc_cache && n <= VIRT_QUEUE_CACHE_DESC_NUM) {
> 447 desc->addr = (u64)vq->desc_cache_chain;
448 vq->desc_cache_chain = desc;
449 } else {
450 kfree(desc);
451 }
452 }
453
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 2/3] virtio: cache indirect desc for packed
Hi Xuan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on horms-ipvs/master]
[also build test WARNING on linus/master v5.15-rc7]
[cannot apply to mst-vhost/linux-next next-20211027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: hexagon-randconfig-r045-20211027 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
5db7568a6a1fcb408eb8988abdaff2a225a8eb72)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/bb65ceda850ed4592d8a940e01926d5e3d33ae92
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
git checkout bb65ceda850ed4592d8a940e01926d5e3d33ae92
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
ARCH=hexagon
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/virtio/virtio_ring.c:1467:7: warning: variable 'len' is
>> uninitialized when used here [-Wuninitialized]
n = len / sizeof(struct vring_packed_desc);
^~~
drivers/virtio/virtio_ring.c:1460:10: note: initialize the variable 'len' to
silence this warning
u32 len, n;
^
= 0
1 warning generated.
vim +/len +1467 drivers/virtio/virtio_ring.c
1433
1434 static void detach_buf_packed(struct vring_virtqueue *vq,
1435unsigned int id, void **ctx)
1436 {
1437 struct vring_desc_state_packed *state = NULL;
1438 struct vring_packed_desc *desc;
1439 unsigned int i, curr;
1440
1441 state = &vq->packed.desc_state[id];
1442
1443 /* Clear data ptr. */
1444 state->data = NULL;
1445
1446 vq->packed.desc_extra[state->last].next = vq->free_head;
1447 vq->free_head = id;
1448 vq->vq.num_free += state->num;
1449
1450 if (unlikely(vq->use_dma_api)) {
1451 curr = id;
1452 for (i = 0; i < state->num; i++) {
1453 vring_unmap_state_packed(vq,
1454 &vq->packed.desc_extra[curr]);
1455 curr = vq->packed.desc_extra[curr].next;
1456 }
1457 }
1458
1459 if (vq->indirect) {
1460 u32 len, n;
1461
1462 /* Free the indirect table, if any, now that it's
unmapped. */
1463 desc = state->indir_desc;
1464 if (!desc)
1465 return;
1466
> 1467 n = len / sizeof(struct vring_packed_desc);
1468
1469 if (vq->use_dma_api) {
1470 len = vq->packed.desc_extra[id].len;
1471 for (i = 0; i < n; i++)
1472 vring_unmap_desc_packed(vq, &desc[i]);
1473 }
1474
1475 desc_cache_put_packed(vq, desc, n);
1476 state->indir_desc = NULL;
1477 } else if (ctx) {
1478 *ctx = state->indir_desc;
1479 }
1480 }
1481
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 1/3] virtio: cache indirect desc for split
Hi Xuan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on horms-ipvs/master]
[also build test WARNING on linus/master v5.15-rc7 next-20211027]
[cannot apply to mst-vhost/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: i386-randconfig-s002-20211027 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://github.com/0day-ci/linux/commit/8935e116c155fb7d484bad35a42b2ca98f75e384
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
git checkout 8935e116c155fb7d484bad35a42b2ca98f75e384
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=i386 SHELL=/bin/bash drivers/virtio/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/virtio/virtio_ring.c:438:26: sparse: sparse: cast from restricted
>> __virtio64
>> drivers/virtio/virtio_ring.c:447:28: sparse: sparse: incorrect type in
>> assignment (different base types) @@ expected restricted __virtio64
>> [usertype] addr @@ got unsigned long long [usertype] @@
drivers/virtio/virtio_ring.c:447:28: sparse: expected restricted
__virtio64 [usertype] addr
drivers/virtio/virtio_ring.c:447:28: sparse: got unsigned long long
[usertype]
drivers/virtio/virtio_ring.c:464:49: sparse: sparse: cast from restricted
__virtio64
vim +438 drivers/virtio/virtio_ring.c
431
432 static void desc_cache_chain_free_split(void *chain)
433 {
434 struct vring_desc *desc;
435
436 while (chain) {
437 desc = chain;
> 438 chain = (void *)desc->addr;
439 kfree(desc);
440 }
441 }
442
443 static void desc_cache_put_split(struct vring_virtqueue *vq,
444 struct vring_desc *desc, int n)
445 {
446 if (vq->use_desc_cache && n <= VIRT_QUEUE_CACHE_DESC_NUM) {
> 447 desc->addr = (u64)vq->desc_cache_chain;
448 vq->desc_cache_chain = desc;
449 } else {
450 kfree(desc);
451 }
452 }
453
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 2/3] virtio: cache indirect desc for packed
Hi Xuan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on horms-ipvs/master]
[also build test WARNING on linus/master v5.15-rc7]
[cannot apply to mst-vhost/linux-next next-20211027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: i386-randconfig-s002-20211027 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://github.com/0day-ci/linux/commit/bb65ceda850ed4592d8a940e01926d5e3d33ae92
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
git checkout bb65ceda850ed4592d8a940e01926d5e3d33ae92
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=i386 SHELL=/bin/bash drivers/virtio/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
drivers/virtio/virtio_ring.c:438:26: sparse: sparse: cast from restricted
__virtio64
drivers/virtio/virtio_ring.c:447:28: sparse: sparse: incorrect type in
assignment (different base types) @@ expected restricted __virtio64
[usertype] addr @@ got unsigned long long [usertype] @@
drivers/virtio/virtio_ring.c:447:28: sparse: expected restricted
__virtio64 [usertype] addr
drivers/virtio/virtio_ring.c:447:28: sparse: got unsigned long long
[usertype]
drivers/virtio/virtio_ring.c:464:49: sparse: sparse: cast from restricted
__virtio64
>> drivers/virtio/virtio_ring.c:1083:26: sparse: sparse: cast from restricted
>> __le64
>> drivers/virtio/virtio_ring.c:1092:28: sparse: sparse: incorrect type in
>> assignment (different base types) @@ expected restricted __le64
>> [usertype] addr @@ got unsigned long long [usertype] @@
drivers/virtio/virtio_ring.c:1092:28: sparse: expected restricted __le64
[usertype] addr
drivers/virtio/virtio_ring.c:1092:28: sparse: got unsigned long long
[usertype]
drivers/virtio/virtio_ring.c:1109:49: sparse: sparse: cast from restricted
__le64
vim +1083 drivers/virtio/virtio_ring.c
1076
1077 static void desc_cache_chain_free_packed(void *chain)
1078 {
1079 struct vring_packed_desc *desc;
1080
1081 while (chain) {
1082 desc = chain;
> 1083 chain = (void *)desc->addr;
1084 kfree(desc);
1085 }
1086 }
1087
1088 static void desc_cache_put_packed(struct vring_virtqueue *vq,
1089struct vring_packed_desc *desc, int n)
1090 {
1091 if (vq->use_desc_cache && n <= VIRT_QUEUE_CACHE_DESC_NUM) {
> 1092 desc->addr = (u64)vq->desc_cache_chain;
1093 vq->desc_cache_chain = desc;
1094 } else {
1095 kfree(desc);
1096 }
1097 }
1098
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 2/3] virtio: cache indirect desc for packed
Hi Xuan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on horms-ipvs/master]
[also build test ERROR on linus/master v5.15-rc7]
[cannot apply to mst-vhost/linux-next next-20211027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: i386-buildonly-randconfig-r005-20211027 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
5db7568a6a1fcb408eb8988abdaff2a225a8eb72)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/bb65ceda850ed4592d8a940e01926d5e3d33ae92
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
git checkout bb65ceda850ed4592d8a940e01926d5e3d33ae92
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/virtio/virtio_ring.c:1467:7: error: variable 'len' is uninitialized
>> when used here [-Werror,-Wuninitialized]
n = len / sizeof(struct vring_packed_desc);
^~~
drivers/virtio/virtio_ring.c:1460:10: note: initialize the variable 'len' to
silence this warning
u32 len, n;
^
= 0
1 error generated.
vim +/len +1467 drivers/virtio/virtio_ring.c
1433
1434 static void detach_buf_packed(struct vring_virtqueue *vq,
1435unsigned int id, void **ctx)
1436 {
1437 struct vring_desc_state_packed *state = NULL;
1438 struct vring_packed_desc *desc;
1439 unsigned int i, curr;
1440
1441 state = &vq->packed.desc_state[id];
1442
1443 /* Clear data ptr. */
1444 state->data = NULL;
1445
1446 vq->packed.desc_extra[state->last].next = vq->free_head;
1447 vq->free_head = id;
1448 vq->vq.num_free += state->num;
1449
1450 if (unlikely(vq->use_dma_api)) {
1451 curr = id;
1452 for (i = 0; i < state->num; i++) {
1453 vring_unmap_state_packed(vq,
1454 &vq->packed.desc_extra[curr]);
1455 curr = vq->packed.desc_extra[curr].next;
1456 }
1457 }
1458
1459 if (vq->indirect) {
1460 u32 len, n;
1461
1462 /* Free the indirect table, if any, now that it's
unmapped. */
1463 desc = state->indir_desc;
1464 if (!desc)
1465 return;
1466
> 1467 n = len / sizeof(struct vring_packed_desc);
1468
1469 if (vq->use_dma_api) {
1470 len = vq->packed.desc_extra[id].len;
1471 for (i = 0; i < n; i++)
1472 vring_unmap_desc_packed(vq, &desc[i]);
1473 }
1474
1475 desc_cache_put_packed(vq, desc, n);
1476 state->indir_desc = NULL;
1477 } else if (ctx) {
1478 *ctx = state->indir_desc;
1479 }
1480 }
1481
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v2 3/3] virtio-net: enable virtio indirect cache
Hi Xuan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on horms-ipvs/master] [also build test WARNING on linus/master v5.15-rc7] [cannot apply to mst-vhost/linux-next next-20211028] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-support-cache-indirect-desc/20211028-185145 base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master config: i386-randconfig-a004-20211028 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/e8418946355cc294b006c6692990dae15a22d85f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xuan-Zhuo/virtio-support-cache-indirect-desc/20211028-185145 git checkout e8418946355cc294b006c6692990dae15a22d85f # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/virtio_net.c:35: warning: This comment starts with '/**', but >> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Because virtio desc cache will increase memory overhead, users can turn it vim +35 drivers/net/virtio_net.c 33 34 /** > 35 * Because virtio desc cache will increase memory overhead, users can turn it 36 * off or select an acceptable value. The maximum value is 2 + MAX_SKB_FRAGS. 37 */ 38 static u32 virtio_desc_cache_thr = 4; 39 module_param(virtio_desc_cache_thr, uint, 0644); 40 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 1/4] dma-buf: add dma_fence_describe and dma_resv_describe
Hi "Christian,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20211028]
[cannot apply to drm/drm-next drm-intel/for-linux-next
drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master
airlied/drm-next v5.15-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Christian-K-nig/dma-buf-add-dma_fence_describe-and-dma_resv_describe/20211028-171805
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/80ae7cf414dbdb7fa9f48a46cc1bfa25b0a4fda7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Christian-K-nig/dma-buf-add-dma_fence_describe-and-dma_resv_describe/20211028-171805
git checkout 80ae7cf414dbdb7fa9f48a46cc1bfa25b0a4fda7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross
ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
drivers/dma-buf/dma-fence.c: In function 'dma_fence_describe':
>> drivers/dma-buf/dma-fence.c:919:9: error: implicit declaration of function
>> 'seq_printf'; did you mean 'bstr_printf'?
>> [-Werror=implicit-function-declaration]
919 | seq_printf(seq, "%s %s seq %llu %ssignalled\n",
| ^~
| bstr_printf
cc1: all warnings being treated as errors
vim +919 drivers/dma-buf/dma-fence.c
909
910 /**
911 * dma_fence_describe - Dump fence describtion into seq_file
912 * @fence: the 6fence to describe
913 * @seq: the seq_file to put the textual description into
914 *
915 * Dump a textual description of the fence and it's state into the
seq_file.
916 */
917 void dma_fence_describe(struct dma_fence *fence, struct seq_file *seq)
918 {
> 919 seq_printf(seq, "%s %s seq %llu %ssignalled\n",
920 fence->ops->get_driver_name(fence),
921 fence->ops->get_timeline_name(fence), fence->seqno,
922 dma_fence_is_signaled(fence) ? "" : "un");
923 }
924 EXPORT_SYMBOL(dma_fence_describe);
925
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 1/4] dma-buf: add dma_fence_describe and dma_resv_describe
Hi "Christian,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20211029]
[cannot apply to drm/drm-next drm-intel/for-linux-next
drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master
airlied/drm-next v5.15-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Christian-K-nig/dma-buf-add-dma_fence_describe-and-dma_resv_describe/20211028-171805
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: hexagon-randconfig-r045-20211031 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
d321548c3ce987f4f21350ba1c81fdb5d4354224)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/80ae7cf414dbdb7fa9f48a46cc1bfa25b0a4fda7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Christian-K-nig/dma-buf-add-dma_fence_describe-and-dma_resv_describe/20211028-171805
git checkout 80ae7cf414dbdb7fa9f48a46cc1bfa25b0a4fda7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
ARCH=hexagon
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/dma-buf/dma-fence.c:919:2: error: implicit declaration of function
>> 'seq_printf' [-Werror,-Wimplicit-function-declaration]
seq_printf(seq, "%s %s seq %llu %ssignalled\n",
^
1 error generated.
vim +/seq_printf +919 drivers/dma-buf/dma-fence.c
909
910 /**
911 * dma_fence_describe - Dump fence describtion into seq_file
912 * @fence: the 6fence to describe
913 * @seq: the seq_file to put the textual description into
914 *
915 * Dump a textual description of the fence and it's state into the
seq_file.
916 */
917 void dma_fence_describe(struct dma_fence *fence, struct seq_file *seq)
918 {
> 919 seq_printf(seq, "%s %s seq %llu %ssignalled\n",
920 fence->ops->get_driver_name(fence),
921 fence->ops->get_timeline_name(fence), fence->seqno,
922 dma_fence_is_signaled(fence) ? "" : "un");
923 }
924 EXPORT_SYMBOL(dma_fence_describe);
925
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] drm/virtio: delay pinning the pages till first use
Hi Maksym,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on next-20211104]
[cannot apply to v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Maksym-Wezdecki/drm-virtio-delay-pinning-the-pages-till-first-use/20211102-193430
base: git://anongit.freedesktop.org/drm/drm drm-next
config: i386-buildonly-randconfig-r002-20211101 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
264d3b6d4e08401c5b50a85bd76e80b3461d77e6)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/1795d2fd78a334a37a02dba76ac1e314cf122467
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Maksym-Wezdecki/drm-virtio-delay-pinning-the-pages-till-first-use/20211102-193430
git checkout 1795d2fd78a334a37a02dba76ac1e314cf122467
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/virtio/virtgpu_object.c:254:11: error: variable 'ents' is
>> uninitialized when used here [-Werror,-Wuninitialized]
ents, nents);
^~~~
drivers/gpu/drm/virtio/virtgpu_object.c:219:35: note: initialize the
variable 'ents' to silence this warning
struct virtio_gpu_mem_entry *ents;
^
= NULL
>> drivers/gpu/drm/virtio/virtgpu_object.c:254:17: error: variable 'nents' is
>> uninitialized when used here [-Werror,-Wuninitialized]
ents, nents);
^
drivers/gpu/drm/virtio/virtgpu_object.c:220:20: note: initialize the
variable 'nents' to silence this warning
unsigned int nents;
^
= 0
2 errors generated.
vim +/ents +254 drivers/gpu/drm/virtio/virtgpu_object.c
2f2aa13724d568 Gerd Hoffmann 2020-02-07 210
dc5698e80cf724 Dave Airlie 2013-09-09 211 int
virtio_gpu_object_create(struct virtio_gpu_device *vgdev,
4441235f9566e6 Gerd Hoffmann 2019-03-18 212
struct virtio_gpu_object_params *params,
530b28426a94b8 Gerd Hoffmann 2019-03-18 213
struct virtio_gpu_object **bo_ptr,
530b28426a94b8 Gerd Hoffmann 2019-03-18 214
struct virtio_gpu_fence *fence)
dc5698e80cf724 Dave Airlie 2013-09-09 215 {
e2324300f427ff Gerd Hoffmann 2019-08-29 216 struct
virtio_gpu_object_array *objs = NULL;
c66df701e783bc Gerd Hoffmann 2019-08-29 217 struct
drm_gem_shmem_object *shmem_obj;
dc5698e80cf724 Dave Airlie 2013-09-09 218 struct
virtio_gpu_object *bo;
2f2aa13724d568 Gerd Hoffmann 2020-02-07 219 struct
virtio_gpu_mem_entry *ents;
2f2aa13724d568 Gerd Hoffmann 2020-02-07 220 unsigned int nents;
dc5698e80cf724 Dave Airlie 2013-09-09 221 int ret;
dc5698e80cf724 Dave Airlie 2013-09-09 222
dc5698e80cf724 Dave Airlie 2013-09-09 223 *bo_ptr = NULL;
dc5698e80cf724 Dave Airlie 2013-09-09 224
c66df701e783bc Gerd Hoffmann 2019-08-29 225 params->size =
roundup(params->size, PAGE_SIZE);
c66df701e783bc Gerd Hoffmann 2019-08-29 226 shmem_obj =
drm_gem_shmem_create(vgdev->ddev, params->size);
c66df701e783bc Gerd Hoffmann 2019-08-29 227 if (IS_ERR(shmem_obj))
c66df701e783bc Gerd Hoffmann 2019-08-29 228 return
PTR_ERR(shmem_obj);
c66df701e783bc Gerd Hoffmann 2019-08-29 229 bo =
gem_to_virtio_gpu_obj(&shmem_obj->base);
dc5698e80cf724 Dave Airlie 2013-09-09 230
556c62e85f9b97 Matthew Wilcox 2018-10-30 231 ret =
virtio_gpu_resource_id_get(vgdev, &bo->hw_res_handle);
e2324300f427ff Gerd Hoffmann 2019-08-29 232 if (ret < 0)
e2324300f427ff Gerd Hoffmann 2019-08-29 233 goto
err_free_gem;
e2324300f427ff Gerd Hoffmann 2019-08-29 234
530b28426a94b8 Gerd Hoffmann 2019-03-18 235 bo->dumb = params->dumb;
530b28426a94b8 Gerd Hoffmann 2019-03-18 236
e2324300f427ff Gerd Hoffmann
Re: [PATCH] virtio-mmio: harden interrupt
Hi Jason,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.16-rc2 next-20211125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jason-Wang/virtio-mmio-harden-interrupt/20211125-143334
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
5f53fa508db098c9d372423a6dac31c8a5679cdf
config: m68k-allyesconfig
(https://download.01.org/0day-ci/archive/20211125/202111251934.ybhaqyh7-...@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/e19a8a1a95bd891090863b2d6828b8dc55d3633f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jason-Wang/virtio-mmio-harden-interrupt/20211125-143334
git checkout e19a8a1a95bd891090863b2d6828b8dc55d3633f
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross
ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/virtio/virtio_mmio.c:105:6: warning: no previous prototype for
>> 'vm_disable_cbs' [-Wmissing-prototypes]
105 | void vm_disable_cbs(struct virtio_device *vdev)
| ^~
>> drivers/virtio/virtio_mmio.c:121:6: warning: no previous prototype for
>> 'vm_enable_cbs' [-Wmissing-prototypes]
121 | void vm_enable_cbs(struct virtio_device *vdev)
| ^
vim +/vm_disable_cbs +105 drivers/virtio/virtio_mmio.c
103
104 /* disable irq handlers */
> 105 void vm_disable_cbs(struct virtio_device *vdev)
106 {
107 struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev);
108 int irq = platform_get_irq(vm_dev->pdev, 0);
109
110 /*
111 * The below synchronize() guarantees that any
112 * interrupt for this line arriving after
113 * synchronize_irq() has completed is guaranteed to see
114 * intx_soft_enabled == false.
115 */
116 WRITE_ONCE(vm_dev->intr_soft_enabled, false);
117 synchronize_irq(irq);
118 }
119
120 /* enable irq handlers */
> 121 void vm_enable_cbs(struct virtio_device *vdev)
122 {
123 struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev);
124 int irq = platform_get_irq(vm_dev->pdev, 0);
125
126 disable_irq(irq);
127 /*
128 * The above disable_irq() provides TSO ordering and
129 * as such promotes the below store to store-release.
130 */
131 WRITE_ONCE(vm_dev->intr_soft_enabled, true);
132 enable_irq(irq);
133 return;
134 }
135
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] virtio-mmio: harden interrupt
Hi Jason,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.16-rc2 next-20211125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jason-Wang/virtio-mmio-harden-interrupt/20211125-143334
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
5f53fa508db098c9d372423a6dac31c8a5679cdf
config: mips-buildonly-randconfig-r003-20211125
(https://download.01.org/0day-ci/archive/20211125/202111252001.z5tli1np-...@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
67a1c45def8a75061203461ab0060c75c864df1c)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
#
https://github.com/0day-ci/linux/commit/e19a8a1a95bd891090863b2d6828b8dc55d3633f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jason-Wang/virtio-mmio-harden-interrupt/20211125-143334
git checkout e19a8a1a95bd891090863b2d6828b8dc55d3633f
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/virtio/virtio_mmio.c:105:6: warning: no previous prototype for
>> function 'vm_disable_cbs' [-Wmissing-prototypes]
void vm_disable_cbs(struct virtio_device *vdev)
^
drivers/virtio/virtio_mmio.c:105:1: note: declare 'static' if the function
is not intended to be used outside of this translation unit
void vm_disable_cbs(struct virtio_device *vdev)
^
static
>> drivers/virtio/virtio_mmio.c:121:6: warning: no previous prototype for
>> function 'vm_enable_cbs' [-Wmissing-prototypes]
void vm_enable_cbs(struct virtio_device *vdev)
^
drivers/virtio/virtio_mmio.c:121:1: note: declare 'static' if the function
is not intended to be used outside of this translation unit
void vm_enable_cbs(struct virtio_device *vdev)
^
static
2 warnings generated.
vim +/vm_disable_cbs +105 drivers/virtio/virtio_mmio.c
103
104 /* disable irq handlers */
> 105 void vm_disable_cbs(struct virtio_device *vdev)
106 {
107 struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev);
108 int irq = platform_get_irq(vm_dev->pdev, 0);
109
110 /*
111 * The below synchronize() guarantees that any
112 * interrupt for this line arriving after
113 * synchronize_irq() has completed is guaranteed to see
114 * intx_soft_enabled == false.
115 */
116 WRITE_ONCE(vm_dev->intr_soft_enabled, false);
117 synchronize_irq(irq);
118 }
119
120 /* enable irq handlers */
> 121 void vm_enable_cbs(struct virtio_device *vdev)
122 {
123 struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev);
124 int irq = platform_get_irq(vm_dev->pdev, 0);
125
126 disable_irq(irq);
127 /*
128 * The above disable_irq() provides TSO ordering and
129 * as such promotes the below store to store-release.
130 */
131 WRITE_ONCE(vm_dev->intr_soft_enabled, true);
132 enable_irq(irq);
133 return;
134 }
135
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] virtio/vsock: fix the transport to work with VMADDR_CID_ANY
Hi Wei,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mst-vhost/linux-next]
[also build test WARNING on net-next/master net/master linus/master v5.16-rc2
next-20211125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wei-Wang/virtio-vsock-fix-the-transport-to-work-with-VMADDR_CID_ANY/20211125-163238
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: riscv-allyesconfig
(https://download.01.org/0day-ci/archive/20211126/202111260614.iagwvzym-...@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/007dbd2e6e604bf8b17a4cec1357113a26983838
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wei-Wang/virtio-vsock-fix-the-transport-to-work-with-VMADDR_CID_ANY/20211125-163238
git checkout 007dbd2e6e604bf8b17a4cec1357113a26983838
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross
ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
net/vmw_vsock/virtio_transport_common.c: In function
'virtio_transport_recv_pkt':
>> net/vmw_vsock/virtio_transport_common.c:1246:28: warning: variable 'vsk' set
>> but not used [-Wunused-but-set-variable]
1246 | struct vsock_sock *vsk;
|^~~
vim +/vsk +1246 net/vmw_vsock/virtio_transport_common.c
e4b1ef152f53d5e Arseny Krasnov 2021-06-11 1238
06a8fc78367d070 Asias He 2016-07-28 1239 /* We are under the
virtio-vsock's vsock->rx_lock or vhost-vsock's vq->mutex
06a8fc78367d070 Asias He 2016-07-28 1240 * lock.
06a8fc78367d070 Asias He 2016-07-28 1241 */
4c7246dc45e2706 Stefano Garzarella 2019-11-14 1242 void
virtio_transport_recv_pkt(struct virtio_transport *t,
4c7246dc45e2706 Stefano Garzarella 2019-11-14 1243
struct virtio_vsock_pkt *pkt)
06a8fc78367d070 Asias He 2016-07-28 1244 {
06a8fc78367d070 Asias He 2016-07-28 1245 struct sockaddr_vm src,
dst;
06a8fc78367d070 Asias He 2016-07-28 @1246 struct vsock_sock *vsk;
06a8fc78367d070 Asias He 2016-07-28 1247 struct sock *sk;
06a8fc78367d070 Asias He 2016-07-28 1248 bool space_available;
06a8fc78367d070 Asias He 2016-07-28 1249
f83f12d660d1171 Michael S. Tsirkin 2016-12-06 1250 vsock_addr_init(&src,
le64_to_cpu(pkt->hdr.src_cid),
06a8fc78367d070 Asias He 2016-07-28 1251
le32_to_cpu(pkt->hdr.src_port));
f83f12d660d1171 Michael S. Tsirkin 2016-12-06 1252 vsock_addr_init(&dst,
le64_to_cpu(pkt->hdr.dst_cid),
06a8fc78367d070 Asias He 2016-07-28 1253
le32_to_cpu(pkt->hdr.dst_port));
06a8fc78367d070 Asias He 2016-07-28 1254
06a8fc78367d070 Asias He 2016-07-28 1255
trace_virtio_transport_recv_pkt(src.svm_cid, src.svm_port,
06a8fc78367d070 Asias He 2016-07-28 1256
dst.svm_cid, dst.svm_port,
06a8fc78367d070 Asias He 2016-07-28 1257
le32_to_cpu(pkt->hdr.len),
06a8fc78367d070 Asias He 2016-07-28 1258
le16_to_cpu(pkt->hdr.type),
06a8fc78367d070 Asias He 2016-07-28 1259
le16_to_cpu(pkt->hdr.op),
06a8fc78367d070 Asias He 2016-07-28 1260
le32_to_cpu(pkt->hdr.flags),
06a8fc78367d070 Asias He 2016-07-28 1261
le32_to_cpu(pkt->hdr.buf_alloc),
06a8fc78367d070 Asias He 2016-07-28 1262
le32_to_cpu(pkt->hdr.fwd_cnt));
06a8fc78367d070 Asias He 2016-07-28 1263
e4b1ef152f53d5e Arseny Krasnov 2021-06-11 1264 if
(!virtio_transport_valid_type(le16_to_cpu(pkt->hdr.type))) {
4c7246dc45e2706 Stefano Garzarella 2019-11-14 1265
(void)virtio_transport_reset_no_sock(t, pkt);
06a8fc78367d070 Asias He 2016-07-28 1266 goto free_pkt;
06a8fc78367d070 Asias He 2016-07-28 1267 }
06a8fc78367d070 Asias He 2016-07-28 1268
06a8fc78367d070 Asias He 2016-07-28 1269 /* The socket must be
in connected or bound table
06
Re: [PATCH] virtio_mmio: pm: Add notification handlers for restore and freeze
Hi Mikhail,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Mikhail-Golubev/virtio_mmio-pm-Add-notification-handlers-for-restore-and-freeze/20211214-001636
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
136057256686de39cc3a07c2e39ef6bc43003ff6
config: m68k-randconfig-r033-20211213
(https://download.01.org/0day-ci/archive/20211214/202112140201.xecfvzym-...@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/86cd610f19003c4d848c13e5e00e38e9bc41f54e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Mikhail-Golubev/virtio_mmio-pm-Add-notification-handlers-for-restore-and-freeze/20211214-001636
git checkout 86cd610f19003c4d848c13e5e00e38e9bc41f54e
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross
O=build_dir ARCH=m68k SHELL=/bin/bash drivers/virtio/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
drivers/virtio/virtio_mmio.c: In function 'virtio_mmio_freeze':
>> drivers/virtio/virtio_mmio.c:770:16: error: implicit declaration of function
>> 'virtio_device_freeze'; did you mean 'virtio_device_ready'?
>> [-Werror=implicit-function-declaration]
770 | return virtio_device_freeze(&vm_dev->vdev);
|^~~~
|virtio_device_ready
drivers/virtio/virtio_mmio.c: In function 'virtio_mmio_restore':
>> drivers/virtio/virtio_mmio.c:778:16: error: implicit declaration of function
>> 'virtio_device_restore'; did you mean 'virtio_mmio_restore'?
>> [-Werror=implicit-function-declaration]
778 | return virtio_device_restore(&vm_dev->vdev);
|^
|virtio_mmio_restore
cc1: some warnings being treated as errors
vim +770 drivers/virtio/virtio_mmio.c
764
765 static int __maybe_unused virtio_mmio_freeze(struct device *dev)
766 {
767 struct platform_device *pdev = to_platform_device(dev);
768 struct virtio_mmio_device *vm_dev = platform_get_drvdata(pdev);
769
> 770 return virtio_device_freeze(&vm_dev->vdev);
771 }
772
773 static int __maybe_unused virtio_mmio_restore(struct device *dev)
774 {
775 struct platform_device *pdev = to_platform_device(dev);
776 struct virtio_mmio_device *vm_dev = platform_get_drvdata(pdev);
777
> 778 return virtio_device_restore(&vm_dev->vdev);
779 }
780
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[mst-vhost:vhost 30/44] drivers/vdpa/mlx5/net/mlx5_vnet.c:1247:23: sparse: sparse: cast to restricted __le16
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: 008842b2060c14544ff452483ffd2241d145c7b2
commit: 7620d51af29aa1c5d32150db2ac4b6187ef8af3a [30/44] vdpa/mlx5: Support
configuring max data virtqueue
config: powerpc-allmodconfig
(https://download.01.org/0day-ci/archive/20220108/202201082258.akrhnajx-...@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?id=7620d51af29aa1c5d32150db2ac4b6187ef8af3a
git remote add mst-vhost
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
git fetch --no-tags mst-vhost vhost
git checkout 7620d51af29aa1c5d32150db2ac4b6187ef8af3a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc
SHELL=/bin/bash drivers/vdpa/mlx5/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/vdpa/mlx5/net/mlx5_vnet.c:1247:23: sparse: sparse: cast to
>> restricted __le16
>> drivers/vdpa/mlx5/net/mlx5_vnet.c:1247:23: sparse: sparse: cast from
>> restricted __virtio16
vim +1247 drivers/vdpa/mlx5/net/mlx5_vnet.c
1232
1233 static int create_rqt(struct mlx5_vdpa_net *ndev)
1234 {
1235 __be32 *list;
1236 int max_rqt;
1237 void *rqtc;
1238 int inlen;
1239 void *in;
1240 int i, j;
1241 int err;
1242 int num;
1243
1244 if (!(ndev->mvdev.actual_features & BIT_ULL(VIRTIO_NET_F_MQ)))
1245 num = 1;
1246 else
> 1247 num = le16_to_cpu(ndev->config.max_virtqueue_pairs);
1248
1249 max_rqt = min_t(int, roundup_pow_of_two(num),
1250 1 << MLX5_CAP_GEN(ndev->mvdev.mdev,
log_max_rqt_size));
1251 if (max_rqt < 1)
1252 return -EOPNOTSUPP;
1253
1254 inlen = MLX5_ST_SZ_BYTES(create_rqt_in) + max_rqt *
MLX5_ST_SZ_BYTES(rq_num);
1255 in = kzalloc(inlen, GFP_KERNEL);
1256 if (!in)
1257 return -ENOMEM;
1258
1259 MLX5_SET(create_rqt_in, in, uid, ndev->mvdev.res.uid);
1260 rqtc = MLX5_ADDR_OF(create_rqt_in, in, rqt_context);
1261
1262 MLX5_SET(rqtc, rqtc, list_q_type,
MLX5_RQTC_LIST_Q_TYPE_VIRTIO_NET_Q);
1263 MLX5_SET(rqtc, rqtc, rqt_max_size, max_rqt);
1264 list = MLX5_ADDR_OF(rqtc, rqtc, rq_num[0]);
1265 for (i = 0, j = 0; i < max_rqt; i++, j += 2)
1266 list[i] = cpu_to_be32(ndev->vqs[j % (2 *
num)].virtq_id);
1267
1268 MLX5_SET(rqtc, rqtc, rqt_actual_size, max_rqt);
1269 err = mlx5_vdpa_create_rqt(&ndev->mvdev, in, inlen,
&ndev->res.rqtn);
1270 kfree(in);
1271 if (err)
1272 return err;
1273
1274 return 0;
1275 }
1276
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 3/3] virtio-crypto: implement RSA algorithm
Hi zhenwei,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linux/master linus/master
v5.16 next-20220121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/zhenwei-pi/Introduce-akcipher-service-for-virtio-crypto/20220121-102730
base:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: hexagon-randconfig-r026-20220120
(https://download.01.org/0day-ci/archive/20220121/202201211427.tgczsuoo-...@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
d4baf3b1322b84816aa623d8e8cb45a49cb68b84)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/fa1045d13dd16399ab0287c599719a977892cf05
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
zhenwei-pi/Introduce-akcipher-service-for-virtio-crypto/20220121-102730
git checkout fa1045d13dd16399ab0287c599719a977892cf05
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/crypto/virtio/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/crypto/virtio/virtio_crypto_akcipher_algo.c:276:5: warning: no
>> previous prototype for function 'virtio_crypto_rsa_do_req'
>> [-Wmissing-prototypes]
int virtio_crypto_rsa_do_req(struct crypto_engine *engine, void *vreq)
^
drivers/crypto/virtio/virtio_crypto_akcipher_algo.c:276:1: note: declare
'static' if the function is not intended to be used outside of this translation
unit
int virtio_crypto_rsa_do_req(struct crypto_engine *engine, void *vreq)
^
static
1 warning generated.
vim +/virtio_crypto_rsa_do_req +276
drivers/crypto/virtio/virtio_crypto_akcipher_algo.c
275
> 276 int virtio_crypto_rsa_do_req(struct crypto_engine *engine, void *vreq)
277 {
278 struct akcipher_request *req = container_of(vreq, struct
akcipher_request, base);
279 struct virtio_crypto_akcipher_request *vc_akcipher_req =
akcipher_request_ctx(req);
280 struct virtio_crypto_request *vc_req = &vc_akcipher_req->base;
281 struct virtio_crypto_akcipher_ctx *ctx =
vc_akcipher_req->akcipher_ctx;
282 struct virtio_crypto *vcrypto = ctx->vcrypto;
283 struct data_queue *data_vq = vc_req->dataq;
284 struct virtio_crypto_op_header *header;
285 struct virtio_crypto_akcipher_data_req *akcipher_req;
286 int ret;
287
288 vc_req->sgs = NULL;
289 vc_req->req_data = kzalloc_node(sizeof(*vc_req->req_data),
290 GFP_KERNEL, dev_to_node(&vcrypto->vdev->dev));
291 if (!vc_req->req_data)
292 return -ENOMEM;
293
294 /* build request header */
295 header = &vc_req->req_data->header;
296 header->opcode = cpu_to_le32(vc_akcipher_req->opcode);
297 header->algo = cpu_to_le32(VIRTIO_CRYPTO_AKCIPHER_RSA);
298 header->session_id = cpu_to_le64(ctx->session_id);
299
300 /* build request akcipher data */
301 akcipher_req = &vc_req->req_data->u.akcipher_req;
302 akcipher_req->para.src_data_len = cpu_to_le32(req->src_len);
303 akcipher_req->para.dst_data_len = cpu_to_le32(req->dst_len);
304
305 ret = __virtio_crypto_akcipher_do_req(vc_akcipher_req, req,
data_vq);
306 if (ret < 0) {
307 kfree_sensitive(vc_req->req_data);
308 vc_req->req_data = NULL;
309 return ret;
310 }
311
312 return 0;
313 }
314
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[RFC PATCH] virtio-crypto: virtio_crypto_rsa_do_req() can be static
drivers/crypto/virtio/virtio_crypto_akcipher_algo.c:276:5: warning: symbol
'virtio_crypto_rsa_do_req' was not declared. Should it be static?
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
virtio_crypto_akcipher_algo.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/virtio/virtio_crypto_akcipher_algo.c
b/drivers/crypto/virtio/virtio_crypto_akcipher_algo.c
index eebccf71b2fab..2b3f8780b7551 100644
--- a/drivers/crypto/virtio/virtio_crypto_akcipher_algo.c
+++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algo.c
@@ -273,7 +273,7 @@ static int __virtio_crypto_akcipher_do_req(struct
virtio_crypto_akcipher_request
return -ENOMEM;
}
-int virtio_crypto_rsa_do_req(struct crypto_engine *engine, void *vreq)
+static int virtio_crypto_rsa_do_req(struct crypto_engine *engine, void *vreq)
{
struct akcipher_request *req = container_of(vreq, struct
akcipher_request, base);
struct virtio_crypto_akcipher_request *vc_akcipher_req =
akcipher_request_ctx(req);
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 3/3] virtio-crypto: implement RSA algorithm
Hi zhenwei, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on herbert-cryptodev-2.6/master] [also build test WARNING on herbert-crypto-2.6/master linux/master linus/master v5.16 next-20220121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/zhenwei-pi/Introduce-akcipher-service-for-virtio-crypto/20220121-102730 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master config: i386-randconfig-s001 (https://download.01.org/0day-ci/archive/20220121/202201211638.iipjx8kd-...@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/fa1045d13dd16399ab0287c599719a977892cf05 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review zhenwei-pi/Introduce-akcipher-service-for-virtio-crypto/20220121-102730 git checkout fa1045d13dd16399ab0287c599719a977892cf05 # save the config file to linux build tree mkdir build_dir make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/crypto/virtio/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) >> drivers/crypto/virtio/virtio_crypto_akcipher_algo.c:276:5: sparse: sparse: >> symbol 'virtio_crypto_rsa_do_req' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 3/3] virtio-crypto: implement RSA algorithm
Hi zhenwei, Thank you for the patch! Yet something to improve: [auto build test ERROR on herbert-cryptodev-2.6/master] [also build test ERROR on herbert-crypto-2.6/master linux/master linus/master v5.16 next-20220121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/zhenwei-pi/Introduce-akcipher-service-for-virtio-crypto/20220121-102730 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master config: nios2-randconfig-c024-20220120 (https://download.01.org/0day-ci/archive/20220122/202201220521.kldw6vyy-...@intel.com/config) compiler: nios2-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/fa1045d13dd16399ab0287c599719a977892cf05 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review zhenwei-pi/Introduce-akcipher-service-for-virtio-crypto/20220121-102730 git checkout fa1045d13dd16399ab0287c599719a977892cf05 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): nios2-linux-ld: drivers/crypto/virtio/virtio_crypto_akcipher_algo.o: in function `virtio_crypto_rsa_set_key': virtio_crypto_akcipher_algo.c:(.text+0x4d4): undefined reference to `rsa_parse_priv_key' virtio_crypto_akcipher_algo.c:(.text+0x4d4): relocation truncated to fit: R_NIOS2_CALL26 against `rsa_parse_priv_key' >> nios2-linux-ld: virtio_crypto_akcipher_algo.c:(.text+0x514): undefined >> reference to `rsa_parse_pub_key' virtio_crypto_akcipher_algo.c:(.text+0x514): relocation truncated to fit: R_NIOS2_CALL26 against `rsa_parse_pub_key' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 3/3] virtio-crypto: implement RSA algorithm
Hi zhenwei, Thank you for the patch! Yet something to improve: [auto build test ERROR on herbert-cryptodev-2.6/master] [also build test ERROR on herbert-crypto-2.6/master linux/master linus/master v5.16 next-20220121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/zhenwei-pi/Introduce-akcipher-service-for-virtio-crypto/20220121-102730 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master config: mips-randconfig-r006-20220117 (https://download.01.org/0day-ci/archive/20220122/202201220847.wxhzvj4g-...@intel.com/config) compiler: mipsel-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/fa1045d13dd16399ab0287c599719a977892cf05 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review zhenwei-pi/Introduce-akcipher-service-for-virtio-crypto/20220121-102730 git checkout fa1045d13dd16399ab0287c599719a977892cf05 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): mipsel-linux-ld: drivers/crypto/virtio/virtio_crypto_akcipher_algo.o: in function `virtio_crypto_rsa_set_key': virtio_crypto_akcipher_algo.c:(.text+0x5d8): undefined reference to `rsa_parse_priv_key' >> mipsel-linux-ld: virtio_crypto_akcipher_algo.c:(.text+0x61c): undefined >> reference to `rsa_parse_pub_key' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH V2 3/4] vhost_vdpa: don't setup irq offloading when irq_num < 0
Hi Zhu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mst-vhost/linux-next]
[also build test WARNING on horms-ipvs/master linus/master v5.17-rc1
next-20220125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Zhu-Lingshan/vDPA-ifcvf-implement-shared-IRQ-feature/20220125-174020
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: arm-randconfig-c002-20220124
(https://download.01.org/0day-ci/archive/20220126/202201260245.1ytb6ywe-...@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
997e128e2a78f5a5434fc75997441ae1ee76f8a4)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
#
https://github.com/0day-ci/linux/commit/9242eae873643db8562d24857da7d05a2950ecfe
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Zhu-Lingshan/vDPA-ifcvf-implement-shared-IRQ-feature/20220125-174020
git checkout 9242eae873643db8562d24857da7d05a2950ecfe
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
O=build_dir ARCH=arm SHELL=/bin/bash drivers/vhost/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/vhost/vdpa.c:99:6: warning: variable 'irq' is uninitialized when
>> used here [-Wuninitialized]
if (irq < 0)
^~~
drivers/vhost/vdpa.c:94:14: note: initialize the variable 'irq' to silence
this warning
int ret, irq;
^
= 0
1 warning generated.
vim +/irq +99 drivers/vhost/vdpa.c
88
89 static void vhost_vdpa_setup_vq_irq(struct vhost_vdpa *v, u16 qid)
90 {
91 struct vhost_virtqueue *vq = &v->vqs[qid];
92 const struct vdpa_config_ops *ops = v->vdpa->config;
93 struct vdpa_device *vdpa = v->vdpa;
94 int ret, irq;
95
96 if (!ops->get_vq_irq)
97 return;
98
> 99 if (irq < 0)
100 return;
101
102 irq = ops->get_vq_irq(vdpa, qid);
103 irq_bypass_unregister_producer(&vq->call_ctx.producer);
104 if (!vq->call_ctx.ctx || irq < 0)
105 return;
106
107 vq->call_ctx.producer.token = vq->call_ctx.ctx;
108 vq->call_ctx.producer.irq = irq;
109 ret = irq_bypass_register_producer(&vq->call_ctx.producer);
110 if (unlikely(ret))
111 dev_info(&v->dev, "vq %u, irq bypass producer (token
%p) registration fails, ret = %d\n",
112 qid, vq->call_ctx.producer.token, ret);
113 }
114
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 2/8] VMCI: dma dg: add MMIO access to registers
Hi Jorgen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
7ab004dbcbee38b8a70798835d3ffcd97a985a5e
config: x86_64-allyesconfig
(https://download.01.org/0day-ci/archive/20220203/202202030055.o6cyduja-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/f2afd39bab80c2e42ac789f6d949d779411df928
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
git checkout f2afd39bab80c2e42ac789f6d949d779411df928
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/misc/vmw_vmci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/misc/vmw_vmci/vmci_guest.c:93:14: warning: no previous prototype for
>> 'vmci_read_reg' [-Wmissing-prototypes]
93 | unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
| ^
>> drivers/misc/vmw_vmci/vmci_guest.c:100:6: warning: no previous prototype for
>> 'vmci_write_reg' [-Wmissing-prototypes]
100 | void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
| ^~
vim +/vmci_read_reg +93 drivers/misc/vmw_vmci/vmci_guest.c
92
> 93 unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
94 {
95 if (dev->mmio_base != NULL)
96 return readl(dev->mmio_base + reg);
97 return ioread32(dev->iobase + reg);
98 }
99
> 100 void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
101 {
102 if (dev->mmio_base != NULL)
103 writel(val, dev->mmio_base + reg);
104 else
105 iowrite32(val, dev->iobase + reg);
106 }
107
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 7/8] VMCI: dma dg: add support for DMA datagrams sends
Hi Jorgen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
7ab004dbcbee38b8a70798835d3ffcd97a985a5e
config: x86_64-allyesconfig
(https://download.01.org/0day-ci/archive/20220203/202202030100.5mr551y1-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/303777a2a8daa11d529827395318bb698ddee57e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
git checkout 303777a2a8daa11d529827395318bb698ddee57e
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/misc/vmw_vmci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
drivers/misc/vmw_vmci/vmci_guest.c:103:14: warning: no previous prototype
for 'vmci_read_reg' [-Wmissing-prototypes]
103 | unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
| ^
drivers/misc/vmw_vmci/vmci_guest.c:110:6: warning: no previous prototype for
'vmci_write_reg' [-Wmissing-prototypes]
110 | void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
| ^~
>> drivers/misc/vmw_vmci/vmci_guest.c:118:5: warning: no previous prototype for
>> 'vmci_write_data' [-Wmissing-prototypes]
118 | int vmci_write_data(struct vmci_guest_device *dev, struct
vmci_datagram *dg)
| ^~~
vim +/vmci_write_data +118 drivers/misc/vmw_vmci/vmci_guest.c
117
> 118 int vmci_write_data(struct vmci_guest_device *dev, struct vmci_datagram
> *dg)
119 {
120 int result;
121
122 if (dev->mmio_base != NULL) {
123 struct vmci_data_in_out_header *buffer_header =
dev->tx_buffer;
124 u8 *dg_out_buffer = (u8 *)(buffer_header + 1);
125
126 if (VMCI_DG_SIZE(dg) > VMCI_MAX_DG_SIZE)
127 return VMCI_ERROR_INVALID_ARGS;
128
129 /*
130 * Initialize send buffer with outgoing datagram
131 * and set up header for inline data. Device will
132 * not access buffer asynchronously - only after
133 * the write to VMCI_DATA_OUT_LOW_ADDR.
134 */
135 memcpy(dg_out_buffer, dg, VMCI_DG_SIZE(dg));
136 buffer_header->opcode = 0;
137 buffer_header->size = VMCI_DG_SIZE(dg);
138 buffer_header->busy = 1;
139
140 vmci_write_reg(dev, lower_32_bits(dev->tx_buffer_base),
141 VMCI_DATA_OUT_LOW_ADDR);
142
143 /* Caller holds a spinlock, so cannot block. */
144 spin_until_cond(buffer_header->busy == 0);
145
146 result = vmci_read_reg(vmci_dev_g,
VMCI_RESULT_LOW_ADDR);
147 if (result == VMCI_SUCCESS)
148 result = (int)buffer_header->result;
149 } else {
150 iowrite8_rep(dev->iobase + VMCI_DATA_OUT_ADDR,
151 dg, VMCI_DG_SIZE(dg));
152 result = vmci_read_reg(vmci_dev_g,
VMCI_RESULT_LOW_ADDR);
153 }
154
155 return result;
156 }
157
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[RFC PATCH] VMCI: dma dg: vmci_read_reg() can be static
drivers/misc/vmw_vmci/vmci_guest.c:93:14: warning: symbol 'vmci_read_reg' was
not declared. Should it be static?
drivers/misc/vmw_vmci/vmci_guest.c:100:6: warning: symbol 'vmci_write_reg' was
not declared. Should it be static?
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
vmci_guest.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/vmw_vmci/vmci_guest.c
b/drivers/misc/vmw_vmci/vmci_guest.c
index d00430e5aba36..081f7b0c23f5f 100644
--- a/drivers/misc/vmw_vmci/vmci_guest.c
+++ b/drivers/misc/vmw_vmci/vmci_guest.c
@@ -90,14 +90,14 @@ u32 vmci_get_vm_context_id(void)
return vm_context_id;
}
-unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
+static unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
{
if (dev->mmio_base != NULL)
return readl(dev->mmio_base + reg);
return ioread32(dev->iobase + reg);
}
-void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
+static void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
{
if (dev->mmio_base != NULL)
writel(val, dev->mmio_base + reg);
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 2/8] VMCI: dma dg: add MMIO access to registers
Hi Jorgen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
7ab004dbcbee38b8a70798835d3ffcd97a985a5e
config: i386-randconfig-s002
(https://download.01.org/0day-ci/archive/20220203/202202030509.zjep87ms-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://github.com/0day-ci/linux/commit/f2afd39bab80c2e42ac789f6d949d779411df928
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
git checkout f2afd39bab80c2e42ac789f6d949d779411df928
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=i386 SHELL=/bin/bash drivers/misc/vmw_vmci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/misc/vmw_vmci/vmci_guest.c:96:45: sparse: sparse: incorrect type in
>> argument 1 (different address spaces) @@ expected void const volatile
>> [noderef] __iomem *addr @@ got char * @@
drivers/misc/vmw_vmci/vmci_guest.c:96:45: sparse: expected void const
volatile [noderef] __iomem *addr
drivers/misc/vmw_vmci/vmci_guest.c:96:45: sparse: got char *
>> drivers/misc/vmw_vmci/vmci_guest.c:93:14: sparse: sparse: symbol
>> 'vmci_read_reg' was not declared. Should it be static?
>> drivers/misc/vmw_vmci/vmci_guest.c:103:44: sparse: sparse: incorrect type in
>> argument 2 (different address spaces) @@ expected void volatile
>> [noderef] __iomem *addr @@ got char * @@
drivers/misc/vmw_vmci/vmci_guest.c:103:44: sparse: expected void
volatile [noderef] __iomem *addr
drivers/misc/vmw_vmci/vmci_guest.c:103:44: sparse: got char *
>> drivers/misc/vmw_vmci/vmci_guest.c:100:6: sparse: sparse: symbol
>> 'vmci_write_reg' was not declared. Should it be static?
>> drivers/misc/vmw_vmci/vmci_guest.c:473:27: sparse: sparse: incorrect type in
>> assignment (different address spaces) @@ expected char *mmio_base @@
>> got void [noderef] __iomem * @@
drivers/misc/vmw_vmci/vmci_guest.c:473:27: sparse: expected char
*mmio_base
drivers/misc/vmw_vmci/vmci_guest.c:473:27: sparse: got void [noderef]
__iomem *
Please review and possibly fold the followup patch.
vim +96 drivers/misc/vmw_vmci/vmci_guest.c
92
> 93 unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
94 {
95 if (dev->mmio_base != NULL)
> 96 return readl(dev->mmio_base + reg);
97 return ioread32(dev->iobase + reg);
98 }
99
> 100 void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
101 {
102 if (dev->mmio_base != NULL)
> 103 writel(val, dev->mmio_base + reg);
104 else
105 iowrite32(val, dev->iobase + reg);
106 }
107
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 2/8] VMCI: dma dg: add MMIO access to registers
Hi Jorgen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
7ab004dbcbee38b8a70798835d3ffcd97a985a5e
config: i386-randconfig-a013-20220131
(https://download.01.org/0day-ci/archive/20220203/202202030643.4ehod5sg-...@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
6b1e844b69f15bb7dffaf9365cd2b355d2eb7579)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/f2afd39bab80c2e42ac789f6d949d779411df928
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
git checkout f2afd39bab80c2e42ac789f6d949d779411df928
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
O=build_dir ARCH=i386 SHELL=/bin/bash drivers/misc/vmw_vmci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/misc/vmw_vmci/vmci_guest.c:93:14: warning: no previous prototype for
>> function 'vmci_read_reg' [-Wmissing-prototypes]
unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
^
drivers/misc/vmw_vmci/vmci_guest.c:93:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
^
static
>> drivers/misc/vmw_vmci/vmci_guest.c:100:6: warning: no previous prototype for
>> function 'vmci_write_reg' [-Wmissing-prototypes]
void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
^
drivers/misc/vmw_vmci/vmci_guest.c:100:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
^
static
2 warnings generated.
vim +/vmci_read_reg +93 drivers/misc/vmw_vmci/vmci_guest.c
92
> 93 unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
94 {
95 if (dev->mmio_base != NULL)
96 return readl(dev->mmio_base + reg);
97 return ioread32(dev->iobase + reg);
98 }
99
> 100 void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
101 {
102 if (dev->mmio_base != NULL)
103 writel(val, dev->mmio_base + reg);
104 else
105 iowrite32(val, dev->iobase + reg);
106 }
107
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 6/8] VMCI: dma dg: allocate send and receive buffers for DMA datagrams
Hi Jorgen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
7ab004dbcbee38b8a70798835d3ffcd97a985a5e
config: i386-randconfig-s002
(https://download.01.org/0day-ci/archive/20220203/202202030713.sj9t0zv6-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://github.com/0day-ci/linux/commit/a5ca330527cc5a2ed5eba621707076ab15d856e5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
git checkout a5ca330527cc5a2ed5eba621707076ab15d856e5
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=i386 SHELL=/bin/bash drivers/misc/vmw_vmci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
drivers/misc/vmw_vmci/vmci_guest.c:105:45: sparse: sparse: incorrect type in
argument 1 (different address spaces) @@ expected void const volatile
[noderef] __iomem *addr @@ got char * @@
drivers/misc/vmw_vmci/vmci_guest.c:105:45: sparse: expected void const
volatile [noderef] __iomem *addr
drivers/misc/vmw_vmci/vmci_guest.c:105:45: sparse: got char *
drivers/misc/vmw_vmci/vmci_guest.c:102:14: sparse: sparse: symbol
'vmci_read_reg' was not declared. Should it be static?
drivers/misc/vmw_vmci/vmci_guest.c:112:44: sparse: sparse: incorrect type in
argument 2 (different address spaces) @@ expected void volatile [noderef]
__iomem *addr @@ got char * @@
drivers/misc/vmw_vmci/vmci_guest.c:112:44: sparse: expected void
volatile [noderef] __iomem *addr
drivers/misc/vmw_vmci/vmci_guest.c:112:44: sparse: got char *
drivers/misc/vmw_vmci/vmci_guest.c:109:6: sparse: sparse: symbol
'vmci_write_reg' was not declared. Should it be static?
drivers/misc/vmw_vmci/vmci_guest.c:514:27: sparse: sparse: incorrect type in
assignment (different address spaces) @@ expected char *mmio_base @@
got void [noderef] __iomem * @@
drivers/misc/vmw_vmci/vmci_guest.c:514:27: sparse: expected char
*mmio_base
drivers/misc/vmw_vmci/vmci_guest.c:514:27: sparse: got void [noderef]
__iomem *
>> drivers/misc/vmw_vmci/vmci_guest.c:869:43: sparse: sparse: incorrect type in
>> argument 2 (different address spaces) @@ expected void [noderef] __iomem
>> * @@ got char *mmio_base @@
drivers/misc/vmw_vmci/vmci_guest.c:869:43: sparse: expected void
[noderef] __iomem *
drivers/misc/vmw_vmci/vmci_guest.c:869:43: sparse: got char *mmio_base
vim +869 drivers/misc/vmw_vmci/vmci_guest.c
813
814 static void vmci_guest_remove_device(struct pci_dev *pdev)
815 {
816 struct vmci_guest_device *vmci_dev = pci_get_drvdata(pdev);
817 int vmci_err;
818
819 dev_dbg(&pdev->dev, "Removing device\n");
820
821 atomic_dec(&vmci_num_guest_devices);
822
823 vmci_qp_guest_endpoints_exit();
824
825 vmci_err = vmci_event_unsubscribe(ctx_update_sub_id);
826 if (vmci_err < VMCI_SUCCESS)
827 dev_warn(&pdev->dev,
828 "Failed to unsubscribe from event (type=%d)
with subscriber (ID=0x%x): %d\n",
829 VMCI_EVENT_CTX_ID_UPDATE, ctx_update_sub_id,
vmci_err);
830
831 spin_lock_irq(&vmci_dev_spinlock);
832 vmci_dev_g = NULL;
833 vmci_pdev = NULL;
834 spin_unlock_irq(&vmci_dev_spinlock);
835
836 dev_dbg(&pdev->dev, "Resetting vmci device\n");
837 vmci_write_reg(vmci_dev, VMCI_CONTROL_RESET, VMCI_CONTROL_ADDR);
838
839 /*
840 * Free IRQ and then disable MSI/MSI-X as appropriate. For
841 * MSI-X, we might have multiple vectors, each with their own
842 * IRQ, which we must free too.
843 */
844 if (vmci_dev->exclusive_vectors) {
845 free_irq(pci_irq_vector(pdev, 1), vmci_dev);
846 if (vmci_dev->mmio_base != NULL)
847
Re: [PATCH 7/8] VMCI: dma dg: add support for DMA datagrams sends
Hi Jorgen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
7ab004dbcbee38b8a70798835d3ffcd97a985a5e
config: i386-randconfig-a013-20220131
(https://download.01.org/0day-ci/archive/20220203/202202030803.bfgzqtfl-...@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
6b1e844b69f15bb7dffaf9365cd2b355d2eb7579)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/303777a2a8daa11d529827395318bb698ddee57e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034
git checkout 303777a2a8daa11d529827395318bb698ddee57e
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
O=build_dir ARCH=i386 SHELL=/bin/bash drivers/misc/vmw_vmci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
drivers/misc/vmw_vmci/vmci_guest.c:103:14: warning: no previous prototype
for function 'vmci_read_reg' [-Wmissing-prototypes]
unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
^
drivers/misc/vmw_vmci/vmci_guest.c:103:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
^
static
drivers/misc/vmw_vmci/vmci_guest.c:110:6: warning: no previous prototype for
function 'vmci_write_reg' [-Wmissing-prototypes]
void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
^
drivers/misc/vmw_vmci/vmci_guest.c:110:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
^
static
>> drivers/misc/vmw_vmci/vmci_guest.c:118:5: warning: no previous prototype for
>> function 'vmci_write_data' [-Wmissing-prototypes]
int vmci_write_data(struct vmci_guest_device *dev, struct vmci_datagram *dg)
^
drivers/misc/vmw_vmci/vmci_guest.c:118:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int vmci_write_data(struct vmci_guest_device *dev, struct vmci_datagram *dg)
^
static
3 warnings generated.
vim +/vmci_write_data +118 drivers/misc/vmw_vmci/vmci_guest.c
109
> 110 void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
111 {
112 if (dev->mmio_base != NULL)
113 writel(val, dev->mmio_base + reg);
114 else
115 iowrite32(val, dev->iobase + reg);
116 }
117
> 118 int vmci_write_data(struct vmci_guest_device *dev, struct vmci_datagram
> *dg)
119 {
120 int result;
121
122 if (dev->mmio_base != NULL) {
123 struct vmci_data_in_out_header *buffer_header =
dev->tx_buffer;
124 u8 *dg_out_buffer = (u8 *)(buffer_header + 1);
125
126 if (VMCI_DG_SIZE(dg) > VMCI_MAX_DG_SIZE)
127 return VMCI_ERROR_INVALID_ARGS;
128
129 /*
130 * Initialize send buffer with outgoing datagram
131 * and set up header for inline data. Device will
132 * not access buffer asynchronously - only after
133 * the write to VMCI_DATA_OUT_LOW_ADDR.
134 */
135 memcpy(dg_out_buffer, dg, VMCI_DG_SIZE(dg));
136 buffer_header->opcode = 0;
137 buffer_header->size = VMCI_DG_SIZE(dg);
138 buffer_header->busy = 1;
139
140 vmci_write_reg(dev, lower_32_bits(dev->tx_buffer_base),
141 VMCI_DATA_OUT_LOW_ADDR);
142
143 /* Caller holds a spinlock, so cannot block. */
144 spin_until_cond(buffer_header->busy == 0);
145
146
[RFC PATCH] VMCI: dma dg: vmci_write_data() can be static
drivers/misc/vmw_vmci/vmci_guest.c:118:5: warning: symbol 'vmci_write_data' was
not declared. Should it be static?
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
vmci_guest.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/vmw_vmci/vmci_guest.c
b/drivers/misc/vmw_vmci/vmci_guest.c
index ca73a19134041e..ba3443dda081bf 100644
--- a/drivers/misc/vmw_vmci/vmci_guest.c
+++ b/drivers/misc/vmw_vmci/vmci_guest.c
@@ -115,7 +115,7 @@ void vmci_write_reg(struct vmci_guest_device *dev, u32 val,
u32 reg)
iowrite32(val, dev->iobase + reg);
}
-int vmci_write_data(struct vmci_guest_device *dev, struct vmci_datagram *dg)
+static int vmci_write_data(struct vmci_guest_device *dev, struct vmci_datagram
*dg)
{
int result;
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 7/8] VMCI: dma dg: add support for DMA datagrams sends
Hi Jorgen, I love your patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on linux/master linus/master v5.17-rc2 next-20220202] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 7ab004dbcbee38b8a70798835d3ffcd97a985a5e config: i386-randconfig-s002 (https://download.01.org/0day-ci/archive/20220203/202202031004.smrs3z6m-...@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/303777a2a8daa11d529827395318bb698ddee57e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034 git checkout 303777a2a8daa11d529827395318bb698ddee57e # save the config file to linux build tree mkdir build_dir make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/misc/vmw_vmci/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) drivers/misc/vmw_vmci/vmci_guest.c:106:45: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got char * @@ drivers/misc/vmw_vmci/vmci_guest.c:106:45: sparse: expected void const volatile [noderef] __iomem *addr drivers/misc/vmw_vmci/vmci_guest.c:106:45: sparse: got char * drivers/misc/vmw_vmci/vmci_guest.c:103:14: sparse: sparse: symbol 'vmci_read_reg' was not declared. Should it be static? drivers/misc/vmw_vmci/vmci_guest.c:113:44: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got char * @@ drivers/misc/vmw_vmci/vmci_guest.c:113:44: sparse: expected void volatile [noderef] __iomem *addr drivers/misc/vmw_vmci/vmci_guest.c:113:44: sparse: got char * drivers/misc/vmw_vmci/vmci_guest.c:110:6: sparse: sparse: symbol 'vmci_write_reg' was not declared. Should it be static? >> drivers/misc/vmw_vmci/vmci_guest.c:118:5: sparse: sparse: symbol >> 'vmci_write_data' was not declared. Should it be static? drivers/misc/vmw_vmci/vmci_guest.c:554:27: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char *mmio_base @@ got void [noderef] __iomem * @@ drivers/misc/vmw_vmci/vmci_guest.c:554:27: sparse: expected char *mmio_base drivers/misc/vmw_vmci/vmci_guest.c:554:27: sparse: got void [noderef] __iomem * drivers/misc/vmw_vmci/vmci_guest.c:909:43: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __iomem * @@ got char *mmio_base @@ drivers/misc/vmw_vmci/vmci_guest.c:909:43: sparse: expected void [noderef] __iomem * drivers/misc/vmw_vmci/vmci_guest.c:909:43: sparse: got char *mmio_base Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 6/8] vhost_task: Allow vhost layer to use copy_process
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mst-vhost/linux-next]
[also build test WARNING on tip/x86/core linus/master v5.17-rc2 next-20220203]
[cannot apply to davem-sparc/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Mike-Christie/Use-copy_process-in-vhost-layer/20220203-050454
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: sparc-randconfig-s032-20220130
(https://download.01.org/0day-ci/archive/20220203/202202032131.gnmg7b6h-...@intel.com/config)
compiler: sparc-linux-gcc (GCC) 11.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://github.com/0day-ci/linux/commit/2c7380ae8136c224f4c7074027303b97b0a0f84c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Mike-Christie/Use-copy_process-in-vhost-layer/20220203-050454
git checkout 2c7380ae8136c224f4c7074027303b97b0a0f84c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sparc
SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> kernel/vhost_task.c:85:24: sparse: sparse: incorrect type in argument 1
>> (different base types) @@ expected unsigned int [usertype] size @@
>> got restricted gfp_t @@
kernel/vhost_task.c:85:24: sparse: expected unsigned int [usertype] size
kernel/vhost_task.c:85:24: sparse: got restricted gfp_t
>> kernel/vhost_task.c:85:36: sparse: sparse: incorrect type in argument 2
>> (different base types) @@ expected restricted gfp_t [usertype] flags @@
>>got unsigned int @@
kernel/vhost_task.c:85:36: sparse: expected restricted gfp_t [usertype]
flags
kernel/vhost_task.c:85:36: sparse: got unsigned int
vim +85 kernel/vhost_task.c
62
63 /**
64 * vhost_task_create - create a copy of a process to be used by the
kernel
65 * @fn: thread stack
66 * @arg: data to be passed to fn
67 * @node: numa node to allocate task from
68 *
69 * This returns a specialized task for use by the vhost layer or NULL on
70 * failure. The returned task is inactive, and the caller must fire it
up
71 * through vhost_task_start().
72 */
73 struct vhost_task *vhost_task_create(int (*fn)(void *), void *arg, int
node)
74 {
75 struct kernel_clone_args args = {
76 .flags = CLONE_FS | CLONE_UNTRACED | CLONE_VM,
77 .exit_signal= 0,
78 .stack = (unsigned long)vhost_task_fn,
79 .worker_flags = USER_WORKER | USER_WORKER_NO_FILES |
80USER_WORKER_SIG_IGN,
81 };
82 struct vhost_task *vtsk;
83 struct task_struct *tsk;
84
> 85 vtsk = kzalloc(GFP_KERNEL, sizeof(*vtsk));
86 if (!vtsk)
87 return ERR_PTR(-ENOMEM);
88
89 init_completion(&vtsk->exited);
90 vtsk->data = arg;
91 vtsk->fn = fn;
92 args.stack_size = (unsigned long)vtsk;
93
94 tsk = copy_process(NULL, 0, node, &args);
95 if (IS_ERR(tsk)) {
96 kfree(vtsk);
97 return NULL;
98 }
99
100 vtsk->task = tsk;
101
102 return vtsk;
103 }
104 EXPORT_SYMBOL_GPL(vhost_task_create);
105
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 6/8] vhost_task: Allow vhost layer to use copy_process
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mst-vhost/linux-next]
[also build test WARNING on tip/x86/core linus/master v5.17-rc2]
[cannot apply to davem-sparc/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Mike-Christie/Use-copy_process-in-vhost-layer/20220203-050454
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: x86_64-randconfig-s021
(https://download.01.org/0day-ci/archive/20220203/202202032136.uq6pxzyt-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://github.com/0day-ci/linux/commit/2c7380ae8136c224f4c7074027303b97b0a0f84c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Mike-Christie/Use-copy_process-in-vhost-layer/20220203-050454
git checkout 2c7380ae8136c224f4c7074027303b97b0a0f84c
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> kernel/vhost_task.c:85:24: sparse: sparse: incorrect type in argument 1
>> (different base types) @@ expected unsigned long [usertype] size @@
>> got restricted gfp_t @@
kernel/vhost_task.c:85:24: sparse: expected unsigned long [usertype] size
kernel/vhost_task.c:85:24: sparse: got restricted gfp_t
>> kernel/vhost_task.c:85:36: sparse: sparse: incorrect type in argument 2
>> (different base types) @@ expected restricted gfp_t [usertype] flags @@
>>got unsigned long @@
kernel/vhost_task.c:85:36: sparse: expected restricted gfp_t [usertype]
flags
kernel/vhost_task.c:85:36: sparse: got unsigned long
vim +85 kernel/vhost_task.c
62
63 /**
64 * vhost_task_create - create a copy of a process to be used by the
kernel
65 * @fn: thread stack
66 * @arg: data to be passed to fn
67 * @node: numa node to allocate task from
68 *
69 * This returns a specialized task for use by the vhost layer or NULL on
70 * failure. The returned task is inactive, and the caller must fire it
up
71 * through vhost_task_start().
72 */
73 struct vhost_task *vhost_task_create(int (*fn)(void *), void *arg, int
node)
74 {
75 struct kernel_clone_args args = {
76 .flags = CLONE_FS | CLONE_UNTRACED | CLONE_VM,
77 .exit_signal= 0,
78 .stack = (unsigned long)vhost_task_fn,
79 .worker_flags = USER_WORKER | USER_WORKER_NO_FILES |
80USER_WORKER_SIG_IGN,
81 };
82 struct vhost_task *vtsk;
83 struct task_struct *tsk;
84
> 85 vtsk = kzalloc(GFP_KERNEL, sizeof(*vtsk));
86 if (!vtsk)
87 return ERR_PTR(-ENOMEM);
88
89 init_completion(&vtsk->exited);
90 vtsk->data = arg;
91 vtsk->fn = fn;
92 args.stack_size = (unsigned long)vtsk;
93
94 tsk = copy_process(NULL, 0, node, &args);
95 if (IS_ERR(tsk)) {
96 kfree(vtsk);
97 return NULL;
98 }
99
100 vtsk->task = tsk;
101
102 return vtsk;
103 }
104 EXPORT_SYMBOL_GPL(vhost_task_create);
105
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v4 3/4] drivers/net/virtio_net: Added RSS hash report.
Hi Andrew,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mst-vhost/linux-next]
[also build test WARNING on net/master horms-ipvs/master net-next/master
linus/master v5.17-rc5 next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Andrew-Melnychenko/RSS-support-for-VirtioNet/20220222-200334
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: i386-randconfig-s002-20220221
(https://download.01.org/0day-ci/archive/20220223/202202230342.hpye6dha-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://github.com/0day-ci/linux/commit/4fda71c17afd24d8afb675baa0bb14dbbc6cd23c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Andrew-Melnychenko/RSS-support-for-VirtioNet/20220222-200334
git checkout 4fda71c17afd24d8afb675baa0bb14dbbc6cd23c
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades
to integer
drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades
to integer
drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades
to integer
drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades
to integer
drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades
to integer
drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades
to integer
drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades
to integer
drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades
to integer
drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades
to integer
>> drivers/net/virtio_net.c:1178:35: sparse: sparse: incorrect type in argument
>> 2 (different base types) @@ expected unsigned int [usertype] hash @@
>> got restricted __le32 const [usertype] hash_value @@
drivers/net/virtio_net.c:1178:35: sparse: expected unsigned int
[usertype] hash
drivers/net/virtio_net.c:1178:35: sparse: got restricted __le32 const
[usertype] hash_value
vim +1178 drivers/net/virtio_net.c
1151
1152 static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash
*hdr_hash,
1153 struct sk_buff *skb)
1154 {
1155 enum pkt_hash_types rss_hash_type;
1156
1157 if (!hdr_hash || !skb)
1158 return;
1159
1160 switch (hdr_hash->hash_report) {
1161 case VIRTIO_NET_HASH_REPORT_TCPv4:
1162 case VIRTIO_NET_HASH_REPORT_UDPv4:
1163 case VIRTIO_NET_HASH_REPORT_TCPv6:
1164 case VIRTIO_NET_HASH_REPORT_UDPv6:
1165 case VIRTIO_NET_HASH_REPORT_TCPv6_EX:
1166 case VIRTIO_NET_HASH_REPORT_UDPv6_EX:
1167 rss_hash_type = PKT_HASH_TYPE_L4;
1168 break;
1169 case VIRTIO_NET_HASH_REPORT_IPv4:
1170 case VIRTIO_NET_HASH_REPORT_IPv6:
1171 case VIRTIO_NET_HASH_REPORT_IPv6_EX:
1172 rss_hash_type = PKT_HASH_TYPE_L3;
1173 break;
1174 case VIRTIO_NET_HASH_REPORT_NONE:
1175 default:
1176 rss_hash_type = PKT_HASH_TYPE_NONE;
1177 }
> 1178 skb_set_hash(skb, hdr_hash->hash_value, rss_hash_type);
1179 }
1180
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[mst-vhost:vhost 28/60] nios2-linux-ld: virtio_crypto_akcipher_algs.c:undefined reference to `rsa_parse_pub_key'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: c5f633abfd09491ae7ecbc7fcfca08332ad00a8b commit: 8a75f36b5d7a48f1c5a0b46638961c951ec6ecd9 [28/60] virtio-crypto: implement RSA algorithm config: nios2-randconfig-p002-20220308 (https://download.01.org/0day-ci/archive/20220309/202203090014.ulendnaq-...@intel.com/config) compiler: nios2-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?id=8a75f36b5d7a48f1c5a0b46638961c951ec6ecd9 git remote add mst-vhost https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git git fetch --no-tags mst-vhost vhost git checkout 8a75f36b5d7a48f1c5a0b46638961c951ec6ecd9 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): nios2-linux-ld: drivers/crypto/virtio/virtio_crypto_akcipher_algs.o: in function `virtio_crypto_rsa_set_key': virtio_crypto_akcipher_algs.c:(.text+0x4bc): undefined reference to `rsa_parse_priv_key' virtio_crypto_akcipher_algs.c:(.text+0x4bc): relocation truncated to fit: R_NIOS2_CALL26 against `rsa_parse_priv_key' >> nios2-linux-ld: virtio_crypto_akcipher_algs.c:(.text+0x4e8): undefined >> reference to `rsa_parse_pub_key' virtio_crypto_akcipher_algs.c:(.text+0x4e8): relocation truncated to fit: R_NIOS2_CALL26 against `rsa_parse_pub_key' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[mst-vhost:vhost 28/60] drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:378: undefined reference to `rsa_parse_priv_key'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: c5f633abfd09491ae7ecbc7fcfca08332ad00a8b
commit: 8a75f36b5d7a48f1c5a0b46638961c951ec6ecd9 [28/60] virtio-crypto:
implement RSA algorithm
config: x86_64-randconfig-a015
(https://download.01.org/0day-ci/archive/20220309/202203090030.caeqq1u8-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?id=8a75f36b5d7a48f1c5a0b46638961c951ec6ecd9
git remote add mst-vhost
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
git fetch --no-tags mst-vhost vhost
git checkout 8a75f36b5d7a48f1c5a0b46638961c951ec6ecd9
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
ld: drivers/crypto/virtio/virtio_crypto_akcipher_algs.o: in function
`virtio_crypto_rsa_set_key':
>> drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:378: undefined reference
>> to `rsa_parse_priv_key'
>> ld: drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:381: undefined
>> reference to `rsa_parse_pub_key'
vim +378 drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
354
355 static int virtio_crypto_rsa_set_key(struct crypto_akcipher *tfm,
356 const void *key,
357 unsigned int keylen,
358 bool private,
359 int padding_algo,
360 int hash_algo)
361 {
362 struct virtio_crypto_akcipher_ctx *ctx = akcipher_tfm_ctx(tfm);
363 struct virtio_crypto_rsa_ctx *rsa_ctx = &ctx->rsa_ctx;
364 struct virtio_crypto *vcrypto;
365 struct virtio_crypto_ctrl_header header;
366 struct virtio_crypto_akcipher_session_para para;
367 struct rsa_key rsa_key = {0};
368 int node = virtio_crypto_get_current_node();
369 uint32_t keytype;
370 int ret;
371
372 /* mpi_free will test n, just free it. */
373 mpi_free(rsa_ctx->n);
374 rsa_ctx->n = NULL;
375
376 if (private) {
377 keytype = VIRTIO_CRYPTO_AKCIPHER_KEY_TYPE_PRIVATE;
> 378 ret = rsa_parse_priv_key(&rsa_key, key, keylen);
379 } else {
380 keytype = VIRTIO_CRYPTO_AKCIPHER_KEY_TYPE_PUBLIC;
> 381 ret = rsa_parse_pub_key(&rsa_key, key, keylen);
382 }
383
384 if (ret)
385 return ret;
386
387 rsa_ctx->n = mpi_read_raw_data(rsa_key.n, rsa_key.n_sz);
388 if (!rsa_ctx->n)
389 return -ENOMEM;
390
391 if (!ctx->vcrypto) {
392 vcrypto = virtcrypto_get_dev_node(node,
VIRTIO_CRYPTO_SERVICE_AKCIPHER,
393
VIRTIO_CRYPTO_AKCIPHER_RSA);
394 if (!vcrypto) {
395 pr_err("virtio_crypto: Could not find a virtio
device in the system or unsupported algo\n");
396 return -ENODEV;
397 }
398
399 ctx->vcrypto = vcrypto;
400 } else {
401 virtio_crypto_alg_akcipher_close_session(ctx);
402 }
403
404 /* set ctrl header */
405 header.opcode =
cpu_to_le32(VIRTIO_CRYPTO_AKCIPHER_CREATE_SESSION);
406 header.algo = cpu_to_le32(VIRTIO_CRYPTO_AKCIPHER_RSA);
407 header.queue_id = 0;
408
409 /* set RSA para */
410 para.algo = cpu_to_le32(VIRTIO_CRYPTO_AKCIPHER_RSA);
411 para.keytype = cpu_to_le32(keytype);
412 para.keylen = cpu_to_le32(keylen);
413 para.u.rsa.padding_algo = cpu_to_le32(padding_algo);
414 para.u.rsa.hash_algo = cpu_to_le32(hash_algo);
415
416 return virtio_crypto_alg_akcipher_init_session(ctx, &header,
¶, key, keylen);
417 }
418
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 1/2] vsock: each transport cycles only on its own sockets
Hi Jiyong,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on 3bf7edc84a9eb4007dd9a0cb8878a7e1d5ec6a3b]
url:
https://github.com/0day-ci/linux/commits/Jiyong-Park/vsock-cycle-only-on-its-own-socket/20220310-205638
base: 3bf7edc84a9eb4007dd9a0cb8878a7e1d5ec6a3b
config: x86_64-rhel-8.3
(https://download.01.org/0day-ci/archive/20220311/202203111023.spyfgn7w-...@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/6219060e1d706d7055fb0829b3bf23c5ae84790e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jiyong-Park/vsock-cycle-only-on-its-own-socket/20220310-205638
git checkout 6219060e1d706d7055fb0829b3bf23c5ae84790e
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/vmw_vsock/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
net/vmw_vsock/vmci_transport.c: In function 'vmci_transport_handle_detach':
>> net/vmw_vsock/vmci_transport.c:808:25: error: 'vmci_transport' undeclared
>> (first use in this function)
808 | if (vsk->transport != &vmci_transport)
| ^~
net/vmw_vsock/vmci_transport.c:808:25: note: each undeclared identifier is
reported only once for each function it appears in
vim +/vmci_transport +808 net/vmw_vsock/vmci_transport.c
800
801 static void vmci_transport_handle_detach(struct sock *sk)
802 {
803 struct vsock_sock *vsk;
804
805 vsk = vsock_sk(sk);
806
807 /* Only handle our own sockets */
> 808 if (vsk->transport != &vmci_transport)
809 return;
810
811 if (!vmci_handle_is_invalid(vmci_trans(vsk)->qp_handle)) {
812 sock_set_flag(sk, SOCK_DONE);
813
814 /* On a detach the peer will not be sending or receiving
815 * anymore.
816 */
817 vsk->peer_shutdown = SHUTDOWN_MASK;
818
819 /* We should not be sending anymore since the peer
won't be
820 * there to receive, but we can still receive if there
is data
821 * left in our consume queue. If the local endpoint is
a host,
822 * we can't call vsock_stream_has_data, since that may
block,
823 * but a host endpoint can't read data once the VM has
824 * detached, so there is no available data in that case.
825 */
826 if (vsk->local_addr.svm_cid == VMADDR_CID_HOST ||
827 vsock_stream_has_data(vsk) <= 0) {
828 if (sk->sk_state == TCP_SYN_SENT) {
829 /* The peer may detach from a queue
pair while
830 * we are still in the connecting
state, i.e.,
831 * if the peer VM is killed after
attaching to
832 * a queue pair, but before we complete
the
833 * handshake. In that case, we treat
the detach
834 * event like a reset.
835 */
836
837 sk->sk_state = TCP_CLOSE;
838 sk->sk_err = ECONNRESET;
839 sk_error_report(sk);
840 return;
841 }
842 sk->sk_state = TCP_CLOSE;
843 }
844 sk->sk_state_change(sk);
845 }
846 }
847
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v2 1/2] virtio-blk: support polling I/O
Hi Suwan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.17]
[also build test WARNING on next-20220321]
[cannot apply to axboe-block/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Suwan-Kim/virtio-blk-support-polling-I-O-and-mq_ops-queue_rqs/20220321-223027
base:f443e374ae131c168a065ea1748feac6b2e76613
config: x86_64-rhel-8.3-kselftests
(https://download.01.org/0day-ci/archive/20220322/202203220946.ykj9gui8-...@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://github.com/0day-ci/linux/commit/5388c0729248236712cf865643a2190989dabbb5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Suwan-Kim/virtio-blk-support-polling-I-O-and-mq_ops-queue_rqs/20220321-223027
git checkout 5388c0729248236712cf865643a2190989dabbb5
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=x86_64 SHELL=/bin/bash drivers/block/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/block/virtio_blk.c:803:66: sparse: sparse: incorrect type in
>> argument 3 (different base types) @@ expected int ioerror @@ got
>> restricted blk_status_t @@
drivers/block/virtio_blk.c:803:66: sparse: expected int ioerror
drivers/block/virtio_blk.c:803:66: sparse: got restricted blk_status_t
vim +803 drivers/block/virtio_blk.c
788
789 static int virtblk_poll(struct blk_mq_hw_ctx *hctx, struct
io_comp_batch *iob)
790 {
791 struct virtio_blk_vq *vq = hctx->driver_data;
792 struct virtblk_req *vbr;
793 unsigned long flags;
794 unsigned int len;
795 int found = 0;
796
797 spin_lock_irqsave(&vq->lock, flags);
798
799 while ((vbr = virtqueue_get_buf(vq->vq, &len)) != NULL) {
800 struct request *req = blk_mq_rq_from_pdu(vbr);
801
802 found++;
> 803 if (!blk_mq_add_to_batch(req, iob, virtblk_result(vbr),
804 virtblk_complete_batch))
805 blk_mq_complete_request(req);
806 }
807
808 spin_unlock_irqrestore(&vq->lock, flags);
809
810 return found;
811 }
812
--
0-DAY CI Kernel Test Service
https://01.org/lkp
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 04/17] vhost: prep vhost_dev_init users to handle failures
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on vhost/linux-next]
[also build test WARNING on v5.9 next-20201021]
[cannot apply to target/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Mike-Christie/vhost-fix-scsi-cmd-handling-and-cgroup-support/20201022-083844
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: x86_64-randconfig-a013-20201021 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
ee6abef5323d59b983129bf3514ef6775d1d6cd5)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/6e1629548d318c2c9af7490379a3c9d7e3cba0d5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Mike-Christie/vhost-fix-scsi-cmd-handling-and-cgroup-support/20201022-083844
git checkout 6e1629548d318c2c9af7490379a3c9d7e3cba0d5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/vhost/vsock.c:633:6: warning: variable 'ret' is used uninitialized
>> whenever 'if' condition is true [-Wsometimes-uninitialized]
if (vhost_dev_init(&vsock->dev, vqs, ARRAY_SIZE(vsock->vqs),
^~~~
drivers/vhost/vsock.c:648:9: note: uninitialized use occurs here
return ret;
^~~
drivers/vhost/vsock.c:633:2: note: remove the 'if' if its condition is
always false
if (vhost_dev_init(&vsock->dev, vqs, ARRAY_SIZE(vsock->vqs),
^~~~
drivers/vhost/vsock.c:609:9: note: initialize the variable 'ret' to silence
this warning
int ret;
^
= 0
1 warning generated.
vim +633 drivers/vhost/vsock.c
604
605 static int vhost_vsock_dev_open(struct inode *inode, struct file *file)
606 {
607 struct vhost_virtqueue **vqs;
608 struct vhost_vsock *vsock;
609 int ret;
610
611 /* This struct is large and allocation could fail, fall back to
vmalloc
612 * if there is no other way.
613 */
614 vsock = kvmalloc(sizeof(*vsock), GFP_KERNEL |
__GFP_RETRY_MAYFAIL);
615 if (!vsock)
616 return -ENOMEM;
617
618 vqs = kmalloc_array(ARRAY_SIZE(vsock->vqs), sizeof(*vqs),
GFP_KERNEL);
619 if (!vqs) {
620 ret = -ENOMEM;
621 goto out;
622 }
623
624 vsock->guest_cid = 0; /* no CID assigned yet */
625
626 atomic_set(&vsock->queued_replies, 0);
627
628 vqs[VSOCK_VQ_TX] = &vsock->vqs[VSOCK_VQ_TX];
629 vqs[VSOCK_VQ_RX] = &vsock->vqs[VSOCK_VQ_RX];
630 vsock->vqs[VSOCK_VQ_TX].handle_kick =
vhost_vsock_handle_tx_kick;
631 vsock->vqs[VSOCK_VQ_RX].handle_kick =
vhost_vsock_handle_rx_kick;
632
> 633 if (vhost_dev_init(&vsock->dev, vqs, ARRAY_SIZE(vsock->vqs),
634 UIO_MAXIOV, VHOST_VSOCK_PKT_WEIGHT,
635 VHOST_VSOCK_WEIGHT, true, NULL))
636 goto err_dev_init;
637
638 file->private_data = vsock;
639 spin_lock_init(&vsock->send_pkt_list_lock);
640 INIT_LIST_HEAD(&vsock->send_pkt_list);
641 vhost_work_init(&vsock->send_pkt_work,
vhost_transport_send_pkt_work);
642 return 0;
643
644 err_dev_init:
645 kfree(vqs);
646 out:
647 vhost_vsock_free(vsock);
648 return ret;
649 }
650
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH V3 2/3] vhost: vdpa: report iova range
Hi Jason,
I love your patch! Perhaps something to improve:
[auto build test WARNING on vhost/linux-next]
[also build test WARNING on linus/master v5.9 next-20201023]
[cannot apply to linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-API-for-reporting-IOVA-range/20201023-102708
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: m68k-randconfig-r034-20201022 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/446e7b97838ebf87f1acd61580137716fdad104a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jason-Wang/vDPA-API-for-reporting-IOVA-range/20201023-102708
git checkout 446e7b97838ebf87f1acd61580137716fdad104a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
drivers/vhost/vdpa.c: In function 'vhost_vdpa_setup_vq_irq':
drivers/vhost/vdpa.c:94:6: warning: variable 'ret' set but not used
[-Wunused-but-set-variable]
94 | int ret, irq;
| ^~~
drivers/vhost/vdpa.c: In function 'vhost_vdpa_unlocked_ioctl':
>> drivers/vhost/vdpa.c:483:5: warning: this statement may fall through
>> [-Wimplicit-fallthrough=]
483 | r = copy_to_user(featurep, &features, sizeof(features));
| ~~^
drivers/vhost/vdpa.c:484:2: note: here
484 | case VHOST_VDPA_GET_IOVA_RANGE:
| ^~~~
vim +483 drivers/vhost/vdpa.c
4c8cf31885f69e8 Tiwei Bie2020-03-26 426
4c8cf31885f69e8 Tiwei Bie2020-03-26 427 static long
vhost_vdpa_unlocked_ioctl(struct file *filep,
4c8cf31885f69e8 Tiwei Bie2020-03-26 428
unsigned int cmd, unsigned long arg)
4c8cf31885f69e8 Tiwei Bie2020-03-26 429 {
4c8cf31885f69e8 Tiwei Bie2020-03-26 430struct vhost_vdpa *v =
filep->private_data;
4c8cf31885f69e8 Tiwei Bie2020-03-26 431struct vhost_dev *d = &v->vdev;
4c8cf31885f69e8 Tiwei Bie2020-03-26 432void __user *argp = (void
__user *)arg;
a127c5bbb6a8eee Jason Wang 2020-09-07 433u64 __user *featurep = argp;
a127c5bbb6a8eee Jason Wang 2020-09-07 434u64 features;
4c8cf31885f69e8 Tiwei Bie2020-03-26 435long r;
4c8cf31885f69e8 Tiwei Bie2020-03-26 436
a127c5bbb6a8eee Jason Wang 2020-09-07 437if (cmd ==
VHOST_SET_BACKEND_FEATURES) {
a127c5bbb6a8eee Jason Wang 2020-09-07 438r =
copy_from_user(&features, featurep, sizeof(features));
a127c5bbb6a8eee Jason Wang 2020-09-07 439if (r)
a127c5bbb6a8eee Jason Wang 2020-09-07 440return r;
a127c5bbb6a8eee Jason Wang 2020-09-07 441if (features &
~VHOST_VDPA_BACKEND_FEATURES)
a127c5bbb6a8eee Jason Wang 2020-09-07 442return
-EOPNOTSUPP;
a127c5bbb6a8eee Jason Wang 2020-09-07 443
vhost_set_backend_features(&v->vdev, features);
a127c5bbb6a8eee Jason Wang 2020-09-07 444return 0;
a127c5bbb6a8eee Jason Wang 2020-09-07 445}
a127c5bbb6a8eee Jason Wang 2020-09-07 446
4c8cf31885f69e8 Tiwei Bie2020-03-26 447mutex_lock(&d->mutex);
4c8cf31885f69e8 Tiwei Bie2020-03-26 448
4c8cf31885f69e8 Tiwei Bie2020-03-26 449switch (cmd) {
4c8cf31885f69e8 Tiwei Bie2020-03-26 450case VHOST_VDPA_GET_DEVICE_ID:
4c8cf31885f69e8 Tiwei Bie2020-03-26 451r =
vhost_vdpa_get_device_id(v, argp);
4c8cf31885f69e8 Tiwei Bie2020-03-26 452break;
4c8cf31885f69e8 Tiwei Bie2020-03-26 453case VHOST_VDPA_GET_STATUS:
4c8cf31885f69e8 Tiwei Bie2020-03-26 454r =
vhost_vdpa_get_status(v, argp);
4c8cf31885f69e8 Tiwei Bie2020-03-26 455break;
4c8cf31885f69e8 Tiwei Bie2020-03-26 456case VHOST_VDPA_SET_STATUS:
4c8cf31885f69e8 Tiwei Bie2020-03-26 457r =
vhost_vdpa_set_status(v, argp);
4c8cf31885f69e8 Tiwei Bie2020-03-26 458break;
4c8cf31885f69e8 Tiwei Bie2020-03-26 459case VHOST_VDPA_GET_CONFIG:
4c8cf31885f69e8 Tiwei Bie2020-03-26 460r =
vhost_vdpa_get_config(v, argp);
4c8cf31885f69e8 Tiwei Bie2020-03-26 461break;
4c8cf31885f69e8 Tiwei Bie2020-03-26 462case VHOST_VDPA_SE
Re: [Intel-gfx] [PATCH 5/5] drm/: Constify struct drm_driver
Hi Daniel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next
linus/master v5.9 next-20201023]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-radeon-Stop-changing-the-drm_driver-struct/20201023-203020
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: arm64-randconfig-r011-20201022 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/9e2fdb03c9047a5d4b24b3e95f0370bcc59eec5e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Daniel-Vetter/drm-radeon-Stop-changing-the-drm_driver-struct/20201023-203020
git checkout 9e2fdb03c9047a5d4b24b3e95f0370bcc59eec5e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c:921:1: warning: 'static' is
>> not at beginning of declaration [-Wold-style-declaration]
921 | const static struct drm_driver ade_driver = {
| ^
vim +/static +921 drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
920
> 921 const static struct drm_driver ade_driver = {
922 .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
923 .fops = &ade_fops,
924 DRM_GEM_CMA_DRIVER_OPS,
925 .name = "kirin",
926 .desc = "Hisilicon Kirin620 SoC DRM Driver",
927 .date = "20150718",
928 .major = 1,
929 .minor = 0,
930 };
931
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers
Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.10-rc1 next-20201028] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: alpha-randconfig-r003-20201029 (attached as .config) compiler: alpha-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/188b22d2b66860695df5d07bf2b7115976790b2c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618 git checkout 188b22d2b66860695df5d07bf2b7115976790b2c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from drivers/gpu/drm/qxl/qxl_drv.c:31: >> drivers/gpu/drm/qxl/qxl_drv.h:178:35: warning: 'struct qxl_device' declared >> inside parameter list will not be visible outside of this definition or >> declaration 178 | int qxl_debugfs_fence_init(struct qxl_device *rdev); | ^~ vim +178 drivers/gpu/drm/qxl/qxl_drv.h f64122c1f6ade30 Dave Airlie 2013-02-25 177 f64122c1f6ade30 Dave Airlie 2013-02-25 @178 int qxl_debugfs_fence_init(struct qxl_device *rdev); f64122c1f6ade30 Dave Airlie 2013-02-25 179 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers
Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.10-rc1 next-20201029] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: powerpc-randconfig-r015-20201029 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 772aaa602383cf82795572ebcd86b0e660f3579f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # https://github.com/0day-ci/linux/commit/188b22d2b66860695df5d07bf2b7115976790b2c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618 git checkout 188b22d2b66860695df5d07bf2b7115976790b2c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from drivers/gpu/drm/qxl/qxl_drv.c:31: >> drivers/gpu/drm/qxl/qxl_drv.h:178:35: warning: declaration of 'struct >> qxl_device' will not be visible outside of this function [-Wvisibility] int qxl_debugfs_fence_init(struct qxl_device *rdev); ^ 1 warning generated. vim +178 drivers/gpu/drm/qxl/qxl_drv.h f64122c1f6ade30 Dave Airlie 2013-02-25 177 f64122c1f6ade30 Dave Airlie 2013-02-25 @178 int qxl_debugfs_fence_init(struct qxl_device *rdev); f64122c1f6ade30 Dave Airlie 2013-02-25 179 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v2 02/17] x86/hyperv: detect if Linux is the root partition
Hi Wei,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/x86/core]
[also build test ERROR on asm-generic/master iommu/next tip/timers/core
pci/next linus/master v5.10-rc2 next-20201105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201106-010058
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
238c91115cd05c71447ea071624a4c9fe661f970
config: x86_64-randconfig-m001-20201104 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/3984ce0be67e74b8945288f1751a91615459f75e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201106-010058
git checkout 3984ce0be67e74b8945288f1751a91615459f75e
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
arch/x86/kernel/cpu/mshyperv.c: In function 'ms_hyperv_init_platform':
>> arch/x86/kernel/cpu/mshyperv.c:247:3: error: 'hv_root_partition' undeclared
>> (first use in this function); did you mean 'blk_drop_partitions'?
247 | hv_root_partition = true;
| ^
| blk_drop_partitions
arch/x86/kernel/cpu/mshyperv.c:247:3: note: each undeclared identifier is
reported only once for each function it appears in
vim +247 arch/x86/kernel/cpu/mshyperv.c
218
219 /*
220 * Extract the features and hints
221 */
222 ms_hyperv.features = cpuid_eax(HYPERV_CPUID_FEATURES);
223 ms_hyperv.misc_features = cpuid_edx(HYPERV_CPUID_FEATURES);
224 ms_hyperv.hints= cpuid_eax(HYPERV_CPUID_ENLIGHTMENT_INFO);
225
226 pr_info("Hyper-V: features 0x%x, hints 0x%x, misc 0x%x\n",
227 ms_hyperv.features, ms_hyperv.hints,
ms_hyperv.misc_features);
228
229 ms_hyperv.max_vp_index =
cpuid_eax(HYPERV_CPUID_IMPLEMENT_LIMITS);
230 ms_hyperv.max_lp_index =
cpuid_ebx(HYPERV_CPUID_IMPLEMENT_LIMITS);
231
232 pr_debug("Hyper-V: max %u virtual processors, %u logical
processors\n",
233 ms_hyperv.max_vp_index, ms_hyperv.max_lp_index);
234
235 /*
236 * Check CPU management privilege.
237 *
238 * To mirror what Windows does we should extract CPU management
239 * features and use the ReservedIdentityBit to detect if Linux
is the
240 * root partition. But that requires negotiating CPU management
241 * interface (a process to be finalized).
242 *
243 * For now, use the privilege flag as the indicator for running
as
244 * root.
245 */
246 if (cpuid_ebx(HYPERV_CPUID_FEATURES) & HV_CPU_MANAGEMENT) {
> 247 hv_root_partition = true;
248 pr_info("Hyper-V: running as root partition\n");
249 }
250
251 /*
252 * Extract host information.
253 */
254 if (cpuid_eax(HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS) >=
255 HYPERV_CPUID_VERSION) {
256 hv_host_info_eax = cpuid_eax(HYPERV_CPUID_VERSION);
257 hv_host_info_ebx = cpuid_ebx(HYPERV_CPUID_VERSION);
258 hv_host_info_ecx = cpuid_ecx(HYPERV_CPUID_VERSION);
259 hv_host_info_edx = cpuid_edx(HYPERV_CPUID_VERSION);
260
261 pr_info("Hyper-V Host Build:%d-%d.%d-%d-%d.%d\n",
262 hv_host_info_eax, hv_host_info_ebx >> 16,
263 hv_host_info_ebx & 0x, hv_host_info_ecx,
264 hv_host_info_edx >> 24, hv_host_info_edx &
0xFF);
265 }
266
267 if (ms_hyperv.features & HV_X64_ACCESS_FREQUENCY_MSRS &&
268 ms_hyperv.misc_features &
HV_FEATURE_FREQUENCY_MSRS_AVAILABLE) {
269 x86_platform.calibrate_tsc = hv_get_tsc_khz;
270 x86_platform.calibrate_cpu = hv_get_tsc_khz;
271 }
272
273 if (ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED) {
274 ms_hyperv.nested_features =
275 cpuid_eax(HYPERV_CPU
Re: [PATCH v2 07/17] x86/hyperv: extract partition ID from Microsoft Hypervisor if necessary
Hi Wei,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/x86/core]
[also build test WARNING on asm-generic/master iommu/next tip/timers/core
pci/next linus/master v5.10-rc2 next-20201105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201106-010058
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
238c91115cd05c71447ea071624a4c9fe661f970
config: i386-randconfig-r002-20201104 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/83c03b4e30e729a77688b8c0ffeffa2a555dcce7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201106-010058
git checkout 83c03b4e30e729a77688b8c0ffeffa2a555dcce7
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> arch/x86/hyperv/hv_init.c:341:13: warning: no previous prototype for
>> 'hv_get_partition_id' [-Wmissing-prototypes]
341 | void __init hv_get_partition_id(void)
| ^~~
vim +/hv_get_partition_id +341 arch/x86/hyperv/hv_init.c
340
> 341 void __init hv_get_partition_id(void)
342 {
343 struct hv_get_partition_id *output_page;
344 u16 status;
345 unsigned long flags;
346
347 local_irq_save(flags);
348 output_page = *this_cpu_ptr(hyperv_pcpu_output_arg);
349 status = hv_do_hypercall(HVCALL_GET_PARTITION_ID, NULL,
output_page) &
350 HV_HYPERCALL_RESULT_MASK;
351 if (status != HV_STATUS_SUCCESS)
352 pr_err("Failed to get partition ID: %d\n", status);
353 else
354 hv_current_partition_id = output_page->partition_id;
355 local_irq_restore(flags);
356
357 /* No point in proceeding if this failed */
358 BUG_ON(status != HV_STATUS_SUCCESS);
359 }
360
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v2 07/17] x86/hyperv: extract partition ID from Microsoft Hypervisor if necessary
Hi Wei,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/x86/core]
[also build test WARNING on asm-generic/master iommu/next tip/timers/core
pci/next linus/master v5.10-rc2 next-20201105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201106-010058
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
238c91115cd05c71447ea071624a4c9fe661f970
config: x86_64-randconfig-s021-20201105 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-76-gf680124b-dirty
#
https://github.com/0day-ci/linux/commit/83c03b4e30e729a77688b8c0ffeffa2a555dcce7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201106-010058
git checkout 83c03b4e30e729a77688b8c0ffeffa2a555dcce7
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> arch/x86/hyperv/hv_init.c:341:13: warning: no previous prototype for
>> 'hv_get_partition_id' [-Wmissing-prototypes]
341 | void __init hv_get_partition_id(void)
| ^~~
vim +/hv_get_partition_id +341 arch/x86/hyperv/hv_init.c
340
> 341 void __init hv_get_partition_id(void)
342 {
343 struct hv_get_partition_id *output_page;
344 u16 status;
345 unsigned long flags;
346
347 local_irq_save(flags);
348 output_page = *this_cpu_ptr(hyperv_pcpu_output_arg);
349 status = hv_do_hypercall(HVCALL_GET_PARTITION_ID, NULL,
output_page) &
350 HV_HYPERCALL_RESULT_MASK;
351 if (status != HV_STATUS_SUCCESS)
352 pr_err("Failed to get partition ID: %d\n", status);
353 else
354 hv_current_partition_id = output_page->partition_id;
355 local_irq_restore(flags);
356
357 /* No point in proceeding if this failed */
358 BUG_ON(status != HV_STATUS_SUCCESS);
359 }
360
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v2 02/17] x86/hyperv: detect if Linux is the root partition
Hi Wei,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/x86/core]
[also build test ERROR on asm-generic/master iommu/next tip/timers/core
pci/next linus/master v5.10-rc2 next-20201105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201106-010058
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
238c91115cd05c71447ea071624a4c9fe661f970
config: x86_64-randconfig-a004-20201104 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
09ec07827b1128504457a93dee80b2ceee1af600)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/3984ce0be67e74b8945288f1751a91615459f75e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201106-010058
git checkout 3984ce0be67e74b8945288f1751a91615459f75e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> arch/x86/kernel/cpu/mshyperv.c:247:3: error: use of undeclared identifier
>> 'hv_root_partition'
hv_root_partition = true;
^
1 error generated.
vim +/hv_root_partition +247 arch/x86/kernel/cpu/mshyperv.c
218
219 /*
220 * Extract the features and hints
221 */
222 ms_hyperv.features = cpuid_eax(HYPERV_CPUID_FEATURES);
223 ms_hyperv.misc_features = cpuid_edx(HYPERV_CPUID_FEATURES);
224 ms_hyperv.hints= cpuid_eax(HYPERV_CPUID_ENLIGHTMENT_INFO);
225
226 pr_info("Hyper-V: features 0x%x, hints 0x%x, misc 0x%x\n",
227 ms_hyperv.features, ms_hyperv.hints,
ms_hyperv.misc_features);
228
229 ms_hyperv.max_vp_index =
cpuid_eax(HYPERV_CPUID_IMPLEMENT_LIMITS);
230 ms_hyperv.max_lp_index =
cpuid_ebx(HYPERV_CPUID_IMPLEMENT_LIMITS);
231
232 pr_debug("Hyper-V: max %u virtual processors, %u logical
processors\n",
233 ms_hyperv.max_vp_index, ms_hyperv.max_lp_index);
234
235 /*
236 * Check CPU management privilege.
237 *
238 * To mirror what Windows does we should extract CPU management
239 * features and use the ReservedIdentityBit to detect if Linux
is the
240 * root partition. But that requires negotiating CPU management
241 * interface (a process to be finalized).
242 *
243 * For now, use the privilege flag as the indicator for running
as
244 * root.
245 */
246 if (cpuid_ebx(HYPERV_CPUID_FEATURES) & HV_CPU_MANAGEMENT) {
> 247 hv_root_partition = true;
248 pr_info("Hyper-V: running as root partition\n");
249 }
250
251 /*
252 * Extract host information.
253 */
254 if (cpuid_eax(HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS) >=
255 HYPERV_CPUID_VERSION) {
256 hv_host_info_eax = cpuid_eax(HYPERV_CPUID_VERSION);
257 hv_host_info_ebx = cpuid_ebx(HYPERV_CPUID_VERSION);
258 hv_host_info_ecx = cpuid_ecx(HYPERV_CPUID_VERSION);
259 hv_host_info_edx = cpuid_edx(HYPERV_CPUID_VERSION);
260
261 pr_info("Hyper-V Host Build:%d-%d.%d-%d-%d.%d\n",
262 hv_host_info_eax, hv_host_info_ebx >> 16,
263 hv_host_info_ebx & 0x, hv_host_info_ecx,
264 hv_host_info_edx >> 24, hv_host_info_edx &
0xFF);
265 }
266
267 if (ms_hyperv.features & HV_X64_ACCESS_FREQUENCY_MSRS &&
268 ms_hyperv.misc_features &
HV_FEATURE_FREQUENCY_MSRS_AVAILABLE) {
269 x86_platform.calibrate_tsc = hv_get_tsc_khz;
270 x86_platform.calibrate_cpu = hv_get_tsc_khz;
271 }
272
273 if (ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED) {
Re: [PATCH v2 12/12] x86/paravirt: have only one paravirt patch function
Hi Juergen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v5.10-rc4]
[also build test WARNING on next-20201120]
[cannot apply to tip/x86/core xen-tip/linux-next tip/x86/asm]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Juergen-Gross/x86-major-paravirt-cleanup/20201120-194934
base:09162bc32c880a791c6c0668ce0745cf7958f576
config: x86_64-randconfig-r014-20201120 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
3ded927cf80ac519f9f9c4664fef08787f7c537d)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/340df5e02c66ec37486a1f31e6497a22dab65059
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Juergen-Gross/x86-major-paravirt-cleanup/20201120-194934
git checkout 340df5e02c66ec37486a1f31e6497a22dab65059
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> arch/x86/kernel/paravirt.c:124:10: warning: no previous prototype for
>> function 'paravirt_patch_insns' [-Wmissing-prototypes]
unsigned paravirt_patch_insns(void *insn_buff, unsigned len,
^
arch/x86/kernel/paravirt.c:124:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
unsigned paravirt_patch_insns(void *insn_buff, unsigned len,
^
static
1 warning generated.
vim +/paravirt_patch_insns +124 arch/x86/kernel/paravirt.c
63f70270ccd981c arch/i386/kernel/paravirt.c Jeremy Fitzhardinge 2007-05-02 123
1fc654cf6e04b40 arch/x86/kernel/paravirt.c Ingo Molnar 2019-04-25 @124
unsigned paravirt_patch_insns(void *insn_buff, unsigned len,
63f70270ccd981c arch/i386/kernel/paravirt.c Jeremy Fitzhardinge 2007-05-02 125
const char *start, const char *end)
63f70270ccd981c arch/i386/kernel/paravirt.c Jeremy Fitzhardinge 2007-05-02 126
{
63f70270ccd981c arch/i386/kernel/paravirt.c Jeremy Fitzhardinge 2007-05-02 127
unsigned insn_len = end - start;
63f70270ccd981c arch/i386/kernel/paravirt.c Jeremy Fitzhardinge 2007-05-02 128
2777cae2b19d4a0 arch/x86/kernel/paravirt.c Ingo Molnar 2019-04-25 129
/* Alternative instruction is too large for the patch site and we
cannot continue: */
2777cae2b19d4a0 arch/x86/kernel/paravirt.c Ingo Molnar 2019-04-25 130
BUG_ON(insn_len > len || start == NULL);
2777cae2b19d4a0 arch/x86/kernel/paravirt.c Ingo Molnar 2019-04-25 131
1fc654cf6e04b40 arch/x86/kernel/paravirt.c Ingo Molnar 2019-04-25 132
memcpy(insn_buff, start, insn_len);
139ec7c416248b9 arch/i386/kernel/paravirt.c Rusty Russell 2006-12-07 133
139ec7c416248b9 arch/i386/kernel/paravirt.c Rusty Russell 2006-12-07 134
return insn_len;
139ec7c416248b9 arch/i386/kernel/paravirt.c Rusty Russell 2006-12-07 135
}
139ec7c416248b9 arch/i386/kernel/paravirt.c Rusty Russell 2006-12-07 136
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v2 11/12] x86/paravirt: switch functions with custom code to ALTERNATIVE
Hi Juergen, I love your patch! Perhaps something to improve: [auto build test WARNING on v5.10-rc4] [also build test WARNING on next-20201120] [cannot apply to tip/x86/core xen-tip/linux-next tip/x86/asm] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Juergen-Gross/x86-major-paravirt-cleanup/20201120-194934 base:09162bc32c880a791c6c0668ce0745cf7958f576 config: x86_64-rhel-7.6-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/fd8d46a7a2c51313ee14c43af60ff337279384ef git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Juergen-Gross/x86-major-paravirt-cleanup/20201120-194934 git checkout fd8d46a7a2c51313ee14c43af60ff337279384ef # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/misc/lkdtm/bugs.o: warning: objtool: .altinstr_replacement+0x0: >> alternative modifies stack --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v3 15/17] x86/hyperv: implement an MSI domain for root partition
Hi Wei,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/x86/core]
[also build test WARNING on asm-generic/master iommu/next tip/timers/core
pci/next linus/master v5.10-rc5]
[cannot apply to next-20201124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201125-011026
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
238c91115cd05c71447ea071624a4c9fe661f970
config: i386-randconfig-a015-20201124 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/ae7533bcd9667c0f23b545d941d3c68460f91ea2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201125-011026
git checkout ae7533bcd9667c0f23b545d941d3c68460f91ea2
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
arch/x86/hyperv/irqdomain.c: In function 'hv_irq_compose_msi_msg':
arch/x86/hyperv/irqdomain.c:146:8: error: implicit declaration of function
'msi_desc_to_pci_dev'; did you mean 'msi_desc_to_dev'?
[-Werror=implicit-function-declaration]
146 | dev = msi_desc_to_pci_dev(msidesc);
|^~~
|msi_desc_to_dev
>> arch/x86/hyperv/irqdomain.c:146:6: warning: assignment to 'struct pci_dev *'
>> from 'int' makes pointer from integer without a cast [-Wint-conversion]
146 | dev = msi_desc_to_pci_dev(msidesc);
| ^
arch/x86/hyperv/irqdomain.c: In function 'hv_msi_domain_free_irqs':
arch/x86/hyperv/irqdomain.c:277:2: error: implicit declaration of function
'for_each_pci_msi_entry'; did you mean 'for_each_msi_entry'?
[-Werror=implicit-function-declaration]
277 | for_each_pci_msi_entry(entry, pdev) {
| ^~
| for_each_msi_entry
arch/x86/hyperv/irqdomain.c:277:37: error: expected ';' before '{' token
277 | for_each_pci_msi_entry(entry, pdev) {
| ^~
| ;
arch/x86/hyperv/irqdomain.c:268:6: warning: unused variable 'i'
[-Wunused-variable]
268 | int i;
| ^
arch/x86/hyperv/irqdomain.c: At top level:
arch/x86/hyperv/irqdomain.c:298:22: error: 'msi_domain_set_affinity'
undeclared here (not in a function); did you mean 'irq_can_set_affinity'?
298 | .irq_set_affinity = msi_domain_set_affinity,
| ^~~
| irq_can_set_affinity
arch/x86/hyperv/irqdomain.c:302:15: error: variable 'pci_msi_domain_ops' has
initializer but incomplete type
302 | static struct msi_domain_ops pci_msi_domain_ops = {
| ^~
arch/x86/hyperv/irqdomain.c:303:3: error: 'struct msi_domain_ops' has no
member named 'domain_free_irqs'
303 | .domain_free_irqs = hv_msi_domain_free_irqs,
| ^~~~
>> arch/x86/hyperv/irqdomain.c:303:22: warning: excess elements in struct
>> initializer
303 | .domain_free_irqs = hv_msi_domain_free_irqs,
| ^~~
arch/x86/hyperv/irqdomain.c:303:22: note: (near initialization for
'pci_msi_domain_ops')
arch/x86/hyperv/irqdomain.c:304:3: error: 'struct msi_domain_ops' has no
member named 'msi_prepare'
304 | .msi_prepare = pci_msi_prepare,
| ^~~
arch/x86/hyperv/irqdomain.c:304:18: error: 'pci_msi_prepare' undeclared here
(not in a function)
304 | .msi_prepare = pci_msi_prepare,
| ^~~
arch/x86/hyperv/irqdomain.c:304:18: warning: excess elements in struct
initializer
arch/x86/hyperv/irqdomain.c:304:18: note: (near initialization for
'pci_msi_domain_ops')
arch/x86/hyperv/irqdomain.c:307:15: error: variable 'hv_pci_msi_domain_info'
has initializer but incomplete type
307 | static struct msi_domain_info hv_pci_msi_domain_info = {
| ^~~
arch/x86/hyperv/irqdomain.c:308:3: error: 'struct msi_domain_info' has no
member named 'flags'
308 | .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
|
Re: [PATCH v3 15/17] x86/hyperv: implement an MSI domain for root partition
Hi Wei,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/x86/core]
[also build test WARNING on asm-generic/master iommu/next tip/timers/core
pci/next linus/master v5.10-rc5]
[cannot apply to next-20201124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201125-011026
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
238c91115cd05c71447ea071624a4c9fe661f970
config: x86_64-randconfig-a003-20201125 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
77e98eaee2e8d4b9b297b66fda5b1e51e2a6)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/ae7533bcd9667c0f23b545d941d3c68460f91ea2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201125-011026
git checkout ae7533bcd9667c0f23b545d941d3c68460f91ea2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
arch/x86/hyperv/irqdomain.c:303:3: error: field designator
'domain_free_irqs' does not refer to any field in type 'struct msi_domain_ops'
.domain_free_irqs = hv_msi_domain_free_irqs,
^
>> arch/x86/hyperv/irqdomain.c:316:28: warning: no previous prototype for
>> function 'hv_create_pci_msi_domain' [-Wmissing-prototypes]
struct irq_domain * __init hv_create_pci_msi_domain(void)
^
arch/x86/hyperv/irqdomain.c:316:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
struct irq_domain * __init hv_create_pci_msi_domain(void)
^
static
1 warning and 1 error generated.
vim +/hv_create_pci_msi_domain +316 arch/x86/hyperv/irqdomain.c
301
302 static struct msi_domain_ops pci_msi_domain_ops = {
> 303 .domain_free_irqs = hv_msi_domain_free_irqs,
304 .msi_prepare= pci_msi_prepare,
305 };
306
307 static struct msi_domain_info hv_pci_msi_domain_info = {
308 .flags = MSI_FLAG_USE_DEF_DOM_OPS |
MSI_FLAG_USE_DEF_CHIP_OPS |
309MSI_FLAG_PCI_MSIX,
310 .ops= &pci_msi_domain_ops,
311 .chip = &hv_pci_msi_controller,
312 .handler= handle_edge_irq,
313 .handler_name = "edge",
314 };
315
> 316 struct irq_domain * __init hv_create_pci_msi_domain(void)
317 {
318 struct irq_domain *d = NULL;
319 struct fwnode_handle *fn;
320
321 fn = irq_domain_alloc_named_fwnode("HV-PCI-MSI");
322 if (fn)
323 d = pci_msi_create_irq_domain(fn,
&hv_pci_msi_domain_info, x86_vector_domain);
324
325 /* No point in going further if we can't get an irq domain */
326 BUG_ON(!d);
327
328 return d;
329 }
330
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v3 17/17] x86/hyperv: handle IO-APIC when running as root
Hi Wei,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/x86/core]
[also build test WARNING on asm-generic/master iommu/next tip/timers/core
pci/next linus/master v5.10-rc5]
[cannot apply to next-20201124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201125-011026
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
238c91115cd05c71447ea071624a4c9fe661f970
config: x86_64-randconfig-a003-20201125 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
77e98eaee2e8d4b9b297b66fda5b1e51e2a6)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/591ad2444b6b7d63ab24ce8f16a4e367085bbb5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201125-011026
git checkout 591ad2444b6b7d63ab24ce8f16a4e367085bbb5d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
arch/x86/hyperv/irqdomain.c:305:3: error: field designator
'domain_free_irqs' does not refer to any field in type 'struct msi_domain_ops'
.domain_free_irqs = hv_msi_domain_free_irqs,
^
arch/x86/hyperv/irqdomain.c:318:28: warning: no previous prototype for
function 'hv_create_pci_msi_domain' [-Wmissing-prototypes]
struct irq_domain * __init hv_create_pci_msi_domain(void)
^
arch/x86/hyperv/irqdomain.c:318:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
struct irq_domain * __init hv_create_pci_msi_domain(void)
^
static
>> arch/x86/hyperv/irqdomain.c:499:6: warning: no previous prototype for
>> function 'hv_ioapic_ack_level' [-Wmissing-prototypes]
void hv_ioapic_ack_level(struct irq_data *irq_data)
^
arch/x86/hyperv/irqdomain.c:499:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
void hv_ioapic_ack_level(struct irq_data *irq_data)
^
static
>> arch/x86/hyperv/irqdomain.c:526:5: warning: no previous prototype for
>> function 'hv_acpi_register_gsi' [-Wmissing-prototypes]
int hv_acpi_register_gsi(struct device *dev, u32 gsi, int trigger, int
polarity)
^
arch/x86/hyperv/irqdomain.c:526:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
int hv_acpi_register_gsi(struct device *dev, u32 gsi, int trigger, int
polarity)
^
static
>> arch/x86/hyperv/irqdomain.c:550:6: warning: no previous prototype for
>> function 'hv_acpi_unregister_gsi' [-Wmissing-prototypes]
void hv_acpi_unregister_gsi(u32 gsi)
^
arch/x86/hyperv/irqdomain.c:550:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
void hv_acpi_unregister_gsi(u32 gsi)
^
static
4 warnings and 1 error generated.
vim +/hv_ioapic_ack_level +499 arch/x86/hyperv/irqdomain.c
498
> 499 void hv_ioapic_ack_level(struct irq_data *irq_data)
500 {
501 /*
502 * Per email exchange with Hyper-V team, all is needed is write
to
503 * LAPIC's EOI register. They don't support directed EOI to
IO-APIC.
504 * Hyper-V handles it for us.
505 */
506 apic_ack_irq(irq_data);
507 }
508
509 struct irq_chip hv_ioapic_chip __read_mostly = {
510 .name = "HV-IO-APIC",
511 .irq_startup= hv_ioapic_startup_irq,
512 .irq_mask = hv_ioapic_mask_irq,
513 .irq_unmask = hv_ioapic_unmask_irq,
514 .irq_ack= irq_chip_ack_parent,
515 .irq_eoi= hv_ioapic_ack_level,
516 .irq_set_affinity = hv_ioapic_set_affinity,
517 .irq_retrigger = irq_chip_retrigger_hierarchy,
518 .irq_get_irqchip_state = ioapic_irq_get_chip_state,
519
Re: [PATCH v10 33/81] KVM: introspection: add hook/unhook ioctls
Hi "Adalbert,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on dc924b062488a0376aae41d3e0a27dc99f852a5e]
url:
https://github.com/0day-ci/linux/commits/Adalbert-Laz-r/VM-introspection/20201125-174530
base:dc924b062488a0376aae41d3e0a27dc99f852a5e
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/fa233c4711c43446c876e84ca6f87b702b0990a8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Adalbert-Laz-r/VM-introspection/20201125-174530
git checkout fa233c4711c43446c876e84ca6f87b702b0990a8
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
arch/x86/kvm/../../../virt/kvm/introspection/kvmi.c:90:6: warning: no
previous prototype for 'kvmi_put' [-Wmissing-prototypes]
90 | void kvmi_put(struct kvm *kvm)
| ^~~~
>> arch/x86/kvm/../../../virt/kvm/introspection/kvmi.c:121:5: warning: no
>> previous prototype for 'kvmi_hook' [-Wmissing-prototypes]
121 | int kvmi_hook(struct kvm *kvm, const struct kvm_introspection_hook
*hook)
| ^
vim +/kvmi_hook +121 arch/x86/kvm/../../../virt/kvm/introspection/kvmi.c
120
> 121 int kvmi_hook(struct kvm *kvm, const struct kvm_introspection_hook
> *hook)
122 {
123 struct kvm_introspection *kvmi;
124 int err = 0;
125
126 mutex_lock(&kvm->kvmi_lock);
127
128 if (kvm->kvmi) {
129 err = -EEXIST;
130 goto out;
131 }
132
133 kvmi = kvmi_alloc(kvm, hook);
134 if (!kvmi) {
135 err = -ENOMEM;
136 goto out;
137 }
138
139 kvm->kvmi = kvmi;
140
141 err = __kvmi_hook(kvm, hook);
142 if (err)
143 goto destroy;
144
145 init_completion(&kvm->kvmi_complete);
146
147 refcount_set(&kvm->kvmi_ref, 1);
148
149 kvmi->recv = kthread_run(kvmi_recv_thread, kvmi, "kvmi-recv");
150 if (IS_ERR(kvmi->recv)) {
151 err = -ENOMEM;
152 kvmi_put(kvm);
153 goto unhook;
154 }
155
156 goto out;
157
158 unhook:
159 __kvmi_unhook(kvm);
160 destroy:
161 kvmi_destroy(kvmi);
162 out:
163 mutex_unlock(&kvm->kvmi_lock);
164 return err;
165 }
166
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v10 25/81] KVM: x86: export kvm_vcpu_ioctl_x86_get_xsave()
Hi "Adalbert, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on dc924b062488a0376aae41d3e0a27dc99f852a5e] url: https://github.com/0day-ci/linux/commits/Adalbert-Laz-r/VM-introspection/20201125-174530 base:dc924b062488a0376aae41d3e0a27dc99f852a5e config: s390-allyesconfig (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/311f49fb9bd7c7968a435ccfbf075cd4d1bd8079 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Adalbert-Laz-r/VM-introspection/20201125-174530 git checkout 311f49fb9bd7c7968a435ccfbf075cd4d1bd8079 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from arch/s390/kernel/asm-offsets.c:11: >> include/linux/kvm_host.h:925:14: warning: 'struct kvm_xsave' declared inside >> parameter list will not be visible outside of this definition or declaration 925 | struct kvm_xsave *guest_xsave); | ^ -- In file included from arch/s390/kernel/asm-offsets.c:11: >> include/linux/kvm_host.h:925:14: warning: 'struct kvm_xsave' declared inside >> parameter list will not be visible outside of this definition or declaration 925 | struct kvm_xsave *guest_xsave); | ^ vim +925 include/linux/kvm_host.h 900 901 int kvm_arch_vcpu_ioctl_translate(struct kvm_vcpu *vcpu, 902 struct kvm_translation *tr); 903 904 int kvm_arch_vcpu_ioctl_get_regs(struct kvm_vcpu *vcpu, struct kvm_regs *regs); 905 void kvm_arch_vcpu_get_regs(struct kvm_vcpu *vcpu, struct kvm_regs *regs); 906 int kvm_arch_vcpu_ioctl_set_regs(struct kvm_vcpu *vcpu, struct kvm_regs *regs); 907 void kvm_arch_vcpu_set_regs(struct kvm_vcpu *vcpu, struct kvm_regs *regs, 908 bool clear_exception); 909 int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu, 910struct kvm_sregs *sregs); 911 void kvm_arch_vcpu_get_sregs(struct kvm_vcpu *vcpu, 912struct kvm_sregs *sregs); 913 int kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu, 914struct kvm_sregs *sregs); 915 int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu, 916 struct kvm_mp_state *mp_state); 917 int kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu, 918 struct kvm_mp_state *mp_state); 919 int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu, 920 struct kvm_guest_debug *dbg); 921 int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu); 922 int kvm_arch_vcpu_set_guest_debug(struct kvm_vcpu *vcpu, 923struct kvm_guest_debug *dbg); 924 void kvm_vcpu_ioctl_x86_get_xsave(struct kvm_vcpu *vcpu, > 925struct kvm_xsave *guest_xsave); 926 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v10 25/81] KVM: x86: export kvm_vcpu_ioctl_x86_get_xsave()
Hi "Adalbert, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on dc924b062488a0376aae41d3e0a27dc99f852a5e] url: https://github.com/0day-ci/linux/commits/Adalbert-Laz-r/VM-introspection/20201125-174530 base:dc924b062488a0376aae41d3e0a27dc99f852a5e config: mips-randconfig-r013-20201125 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 77e98eaee2e8d4b9b297b66fda5b1e51e2a6) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/0day-ci/linux/commit/311f49fb9bd7c7968a435ccfbf075cd4d1bd8079 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Adalbert-Laz-r/VM-introspection/20201125-174530 git checkout 311f49fb9bd7c7968a435ccfbf075cd4d1bd8079 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from arch/mips/kernel/asm-offsets.c:24: >> include/linux/kvm_host.h:925:14: warning: declaration of 'struct kvm_xsave' >> will not be visible outside of this function [-Wvisibility] struct kvm_xsave *guest_xsave); ^ arch/mips/kernel/asm-offsets.c:26:6: warning: no previous prototype for function 'output_ptreg_defines' [-Wmissing-prototypes] void output_ptreg_defines(void) ^ arch/mips/kernel/asm-offsets.c:26:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void output_ptreg_defines(void) ^ static arch/mips/kernel/asm-offsets.c:78:6: warning: no previous prototype for function 'output_task_defines' [-Wmissing-prototypes] void output_task_defines(void) ^ arch/mips/kernel/asm-offsets.c:78:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void output_task_defines(void) ^ static arch/mips/kernel/asm-offsets.c:93:6: warning: no previous prototype for function 'output_thread_info_defines' [-Wmissing-prototypes] void output_thread_info_defines(void) ^ arch/mips/kernel/asm-offsets.c:93:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void output_thread_info_defines(void) ^ static arch/mips/kernel/asm-offsets.c:110:6: warning: no previous prototype for function 'output_thread_defines' [-Wmissing-prototypes] void output_thread_defines(void) ^ arch/mips/kernel/asm-offsets.c:110:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void output_thread_defines(void) ^ static arch/mips/kernel/asm-offsets.c:138:6: warning: no previous prototype for function 'output_thread_fpu_defines' [-Wmissing-prototypes] void output_thread_fpu_defines(void) ^ arch/mips/kernel/asm-offsets.c:138:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void output_thread_fpu_defines(void) ^ static arch/mips/kernel/asm-offsets.c:181:6: warning: no previous prototype for function 'output_mm_defines' [-Wmissing-prototypes] void output_mm_defines(void) ^ arch/mips/kernel/asm-offsets.c:181:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void output_mm_defines(void) ^ static arch/mips/kernel/asm-offsets.c:220:6: warning: no previous prototype for function 'output_sc_defines' [-Wmissing-prototypes] void output_sc_defines(void) ^ arch/mips/kernel/asm-offsets.c:220:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void output_sc_defines(void) ^ static arch/mips/kernel/asm-offsets.c:255:6: warning: no previous prototype for function 'output_signal_defined' [-Wmissing-prototypes] void output_signal_defined(void) ^ arch/mips/kernel/asm-offsets.c:255:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void output_signal_defined(void) ^ static arch/mips/kernel/asm-offsets.c:348:6: warning: no previous prototype for function 'output_kvm_defines' [-Wmissing-prototypes] void output_kvm_defines(void) ^
Re: [PATCH v10 32/81] KVM: introduce VM introspection
Hi "Adalbert,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on dc924b062488a0376aae41d3e0a27dc99f852a5e]
url:
https://github.com/0day-ci/linux/commits/Adalbert-Laz-r/VM-introspection/20201125-174530
base:dc924b062488a0376aae41d3e0a27dc99f852a5e
config: mips-malta_kvm_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/6ffa5da71155bd0bed0d68c52af248bda256d0f2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Adalbert-Laz-r/VM-introspection/20201125-174530
git checkout 6ffa5da71155bd0bed0d68c52af248bda256d0f2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
In file included from arch/mips/kvm/../../../virt/kvm/kvm_main.c:18:
include/linux/kvm_host.h:925:14: warning: 'struct kvm_xsave' declared inside
parameter list will not be visible outside of this definition or declaration
925 | struct kvm_xsave *guest_xsave);
| ^
include/linux/kvm_host.h:927:13: warning: 'struct kvm_xsave' declared inside
parameter list will not be visible outside of this definition or declaration
927 | struct kvm_xsave *guest_xsave);
| ^
arch/mips/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_create_vm':
>> arch/mips/kvm/../../../virt/kvm/kvm_main.c:806:6: error:
>> 'enable_introspection' undeclared (first use in this function)
806 | if (enable_introspection)
| ^~~~
arch/mips/kvm/../../../virt/kvm/kvm_main.c:806:6: note: each undeclared
identifier is reported only once for each function it appears in
arch/mips/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_destroy_vm':
arch/mips/kvm/../../../virt/kvm/kvm_main.c:861:6: error:
'enable_introspection' undeclared (first use in this function)
861 | if (enable_introspection)
| ^~~~
arch/mips/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_init':
arch/mips/kvm/../../../virt/kvm/kvm_main.c:5012:6: error:
'enable_introspection' undeclared (first use in this function)
5012 | if (enable_introspection) {
| ^~~~
vim +/enable_introspection +806 arch/mips/kvm/../../../virt/kvm/kvm_main.c
797
798 r = kvm_init_mmu_notifier(kvm);
799 if (r)
800 goto out_err_no_mmu_notifier;
801
802 r = kvm_arch_post_init_vm(kvm);
803 if (r)
804 goto out_err;
805
> 806 if (enable_introspection)
807 kvmi_create_vm(kvm);
808
809 mutex_lock(&kvm_lock);
810 list_add(&kvm->vm_list, &vm_list);
811 mutex_unlock(&kvm_lock);
812
813 preempt_notifier_inc();
814
815 return kvm;
816
817 out_err:
818 #if defined(CONFIG_MMU_NOTIFIER) && defined(KVM_ARCH_WANT_MMU_NOTIFIER)
819 if (kvm->mmu_notifier.ops)
820 mmu_notifier_unregister(&kvm->mmu_notifier,
current->mm);
821 #endif
822 out_err_no_mmu_notifier:
823 hardware_disable_all();
824 out_err_no_disable:
825 kvm_arch_destroy_vm(kvm);
826 out_err_no_arch_destroy_vm:
827 WARN_ON_ONCE(!refcount_dec_and_test(&kvm->users_count));
828 for (i = 0; i < KVM_NR_BUSES; i++)
829 kfree(kvm_get_bus(kvm, i));
830 for (i = 0; i < KVM_ADDRESS_SPACE_NUM; i++)
831 kvm_free_memslots(kvm, __kvm_memslots(kvm, i));
832 cleanup_srcu_struct(&kvm->irq_srcu);
833 out_err_no_irq_srcu:
834 cleanup_srcu_struct(&kvm->srcu);
835 out_err_no_srcu:
836 kvm_arch_free_vm(kvm);
837 mmdrop(current->mm);
838 return ERR_PTR(r);
839 }
840
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v10 63/81] KVM: introspection: add KVMI_VCPU_INJECT_EXCEPTION + KVMI_VCPU_EVENT_TRAP
Hi "Adalbert,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on dc924b062488a0376aae41d3e0a27dc99f852a5e]
url:
https://github.com/0day-ci/linux/commits/Adalbert-Laz-r/VM-introspection/20201125-174530
base:dc924b062488a0376aae41d3e0a27dc99f852a5e
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/248beb976ebfd430c3535cc442d0ba198f1ab1d6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Adalbert-Laz-r/VM-introspection/20201125-174530
git checkout 248beb976ebfd430c3535cc442d0ba198f1ab1d6
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
arch/x86/kvm/kvmi_msg.c: In function 'handle_vcpu_inject_exception':
>> arch/x86/kvm/kvmi_msg.c:158:38: warning: variable 'arch' set but not used
>> [-Wunused-but-set-variable]
158 | struct kvm_vcpu_arch_introspection *arch;
| ^~~~
vim +/arch +158 arch/x86/kvm/kvmi_msg.c
152
153 static int handle_vcpu_inject_exception(const struct kvmi_vcpu_msg_job
*job,
154 const struct kvmi_msg_hdr *msg,
155 const void *_req)
156 {
157 const struct kvmi_vcpu_inject_exception *req = _req;
> 158 struct kvm_vcpu_arch_introspection *arch;
159 struct kvm_vcpu *vcpu = job->vcpu;
160 int ec;
161
162 arch = &VCPUI(vcpu)->arch;
163
164 if (!kvmi_is_event_allowed(KVMI(vcpu->kvm),
KVMI_VCPU_EVENT_TRAP))
165 ec = -KVM_EPERM;
166 else if (req->padding1 || req->padding2)
167 ec = -KVM_EINVAL;
168 else if (VCPUI(vcpu)->arch.exception.pending ||
169 VCPUI(vcpu)->arch.exception.send_event)
170 ec = -KVM_EBUSY;
171 else
172 ec = kvmi_arch_cmd_vcpu_inject_exception(vcpu, req);
173
174 return kvmi_msg_vcpu_reply(job, msg, ec, NULL, 0);
175 }
176
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
