Re: [PATCH RFC v6 17/20] virtio-net: enable virtio 1.0
On Thu, Dec 11, 2014 at 02:25:19PM +0100, Cornelia Huck wrote:
> virtio-net (non-vhost) now should have everything in place to support
> virtio 1.0: let's enable the feature bit for it.
>
> Note that VIRTIO_F_VERSION_1 is technically a transport feature; once
> every device is ready for virtio 1.0, we can move setting this
> feature bit out of the individual devices.
>
> Signed-off-by: Cornelia Huck
So to use this with e.g. tun, you need to make tun device LE.
I posted a kernel patch 1418732988-3535-1-git-send-email-...@redhat.com
with TUNSETVNETLE/TUNGETVNETLE ioctls to support it.
But you still need to call them in qemu, and disable virtio-1.0
if not there.
> ---
> hw/net/virtio-net.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 7ee2bd6..b5dd356 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -473,6 +473,7 @@ static uint64_t virtio_net_get_features(VirtIODevice
> *vdev, uint64_t features)
> }
>
> if (!get_vhost_net(nc->peer)) {
> +virtio_add_feature(&features, VIRTIO_F_VERSION_1);
> return features;
> }
> return vhost_net_get_features(get_vhost_net(nc->peer), features);
> --
> 1.7.9.5
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 8/9] virtio_pci: split out legacy device support
Michael S. Tsirkin wrote:
> Move everything dealing with legacy devices out to virtio_pci_legacy.c.
> Expose common code APIs in virtio_pci.h
>
> Signed-off-by: Michael S. Tsirkin
This breaks virtio_pci because you deleted the licence from it.
-- >8 --
Subject: virtio_pci: Restore module licence and other attributes
When the virtio_pci driver was moved into virtio_pci_legacy.c the
module licence and other attributes went AWOL. This patch restores
them.
Signed-off-by: Herbert Xu
diff --git a/drivers/virtio/virtio_pci_legacy.c
b/drivers/virtio/virtio_pci_legacy.c
index 2588252..6b100e3 100644
--- a/drivers/virtio/virtio_pci_legacy.c
+++ b/drivers/virtio/virtio_pci_legacy.c
@@ -324,3 +324,8 @@ static struct pci_driver virtio_pci_driver = {
};
module_pci_driver(virtio_pci_driver);
+
+MODULE_AUTHOR("Anthony Liguori ");
+MODULE_DESCRIPTION("virtio-pci");
+MODULE_LICENSE("GPL");
+MODULE_VERSION("1");
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 8/9] virtio_pci: split out legacy device support
On Wed, Dec 17, 2014 at 08:03:10AM +1100, Herbert Xu wrote:
> Michael S. Tsirkin wrote:
> > Move everything dealing with legacy devices out to virtio_pci_legacy.c.
> > Expose common code APIs in virtio_pci.h
> >
> > Signed-off-by: Michael S. Tsirkin
>
> This breaks virtio_pci because you deleted the licence from it.
>
> -- >8 --
> Subject: virtio_pci: Restore module licence and other attributes
>
> When the virtio_pci driver was moved into virtio_pci_legacy.c the
> module licence and other attributes went AWOL. This patch restores
> them.
>
> Signed-off-by: Herbert Xu
Thanks!
I'll apply a similar patch but to virtio_pci_common.
Will send a pull request with this included tomorrow.
> diff --git a/drivers/virtio/virtio_pci_legacy.c
> b/drivers/virtio/virtio_pci_legacy.c
> index 2588252..6b100e3 100644
> --- a/drivers/virtio/virtio_pci_legacy.c
> +++ b/drivers/virtio/virtio_pci_legacy.c
> @@ -324,3 +324,8 @@ static struct pci_driver virtio_pci_driver = {
> };
>
> module_pci_driver(virtio_pci_driver);
> +
> +MODULE_AUTHOR("Anthony Liguori ");
> +MODULE_DESCRIPTION("virtio-pci");
> +MODULE_LICENSE("GPL");
> +MODULE_VERSION("1");
>
> Cheers,
> --
> Email: Herbert Xu
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 8/9] virtio_pci: split out legacy device support
On Wed, Dec 17, 2014 at 08:03:10AM +1100, Herbert Xu wrote:
> Michael S. Tsirkin wrote:
> > Move everything dealing with legacy devices out to virtio_pci_legacy.c.
> > Expose common code APIs in virtio_pci.h
> >
> > Signed-off-by: Michael S. Tsirkin
>
> This breaks virtio_pci because you deleted the licence from it.
>
> -- >8 --
> Subject: virtio_pci: Restore module licence and other attributes
>
> When the virtio_pci driver was moved into virtio_pci_legacy.c the
> module licence and other attributes went AWOL. This patch restores
> them.
>
> Signed-off-by: Herbert Xu
I applied this with a minor tweak, and pushed to linux-next.
Unfortunately it's very late here, so I can't test properly
and send pull request today, but will try to do tomorrow.
The tree with a fix is here:
git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git for_linus
> diff --git a/drivers/virtio/virtio_pci_legacy.c
> b/drivers/virtio/virtio_pci_legacy.c
> index 2588252..6b100e3 100644
> --- a/drivers/virtio/virtio_pci_legacy.c
> +++ b/drivers/virtio/virtio_pci_legacy.c
> @@ -324,3 +324,8 @@ static struct pci_driver virtio_pci_driver = {
> };
>
> module_pci_driver(virtio_pci_driver);
> +
> +MODULE_AUTHOR("Anthony Liguori ");
> +MODULE_DESCRIPTION("virtio-pci");
> +MODULE_LICENSE("GPL");
> +MODULE_VERSION("1");
>
> Cheers,
> --
> Email: Herbert Xu
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
