Re: [virt-tools-list] [virt-manager][PATCH v1 1/2] Modify the default graphics device to "vnc" for ppc64 and ppc64le
On 12/15/2015 09:06 PM, Kevin Zhao wrote:
Modify the default graphics device to "vnc",since the powerpc
does't support spice devices.Otherwise, virt-manager can not
be used in ppc64 and ppc64le hardware.So that change make
virt-manager supports arch "ppc64" and "ppc64le".Also add
a test case to cover this change.
---
.../compare/virt-install-ppc64le-cdrom-f22.xml | 39 ++
tests/clitest.py | 2 +-
virtinst/guest.py | 3 ++
3 files changed, 43 insertions(+), 1 deletion(-)
create mode 100644
tests/cli-test-xml/compare/virt-install-ppc64le-cdrom-f22.xml
diff --git a/tests/cli-test-xml/compare/virt-install-ppc64le-cdrom-f22.xml
b/tests/cli-test-xml/compare/virt-install-ppc64le-cdrom-f22.xml
new file mode 100644
index 000..c710169
--- /dev/null
+++ b/tests/cli-test-xml/compare/virt-install-ppc64le-cdrom-f22.xml
@@ -0,0 +1,39 @@
+
+ foobar
+ ----
+ 1048576
+ 1048576
+ 1
+
+hvm
+
+
+
+
+ destroy
+ destroy
+ destroy
+
+/usr/bin/qemu-system-ppc64
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/tests/clitest.py b/tests/clitest.py
index 994b415..f2085cc 100644
--- a/tests/clitest.py
+++ b/tests/clitest.py
@@ -702,7 +702,7 @@ c.add_compare("--connect %(URI-KVM-AARCH64)s --disk
%(EXISTIMG1)s --import --os-
c.add_compare("--arch ppc64 --machine pseries --boot network --disk %(EXISTIMG1)s
--os-variant fedora20 --network none", "ppc64-pseries-f20")
c.add_compare("--arch ppc64 --boot network --disk %(EXISTIMG1)s --os-variant fedora20
--network none", "ppc64-machdefault-f20")
c.add_compare("--connect %(URI-KVM-PPC64LE)s --import --disk %(EXISTIMG1)s --os-variant
fedora20", "ppc64le-kvm-import")
-
+c.add_compare("--arch ppc64 --machine pseries --connect %(URI-KVM-PPC64LE)s --disk
%(EXISTIMG1)s --disk %(EXISTIMG3)s,device=cdrom --os-variant fedora22",
"ppc64le-cdrom-f22")
# s390x tests
c.add_compare("--arch s390x --machine s390-ccw-virtio --connect %(URI-KVM-S390X)s --boot
kernel=/kernel.img,initrd=/initrd.img --disk %(EXISTIMG1)s --disk %(EXISTIMG3)s,device=cdrom
--os-variant fedora21", "s390x-cdrom")
c.add_compare("--arch s390x --machine s390-ccw-virtio --connect %(URI-KVM-S390X-KVMIBM)s
--boot kernel=/kernel.img,initrd=/initrd.img --disk %(EXISTIMG1)s --disk %(EXISTIMG3)s,device=cdrom
--os-variant fedora21 --watchdog diag288,action=reset", "s390x-cdrom-KVMIBM")
diff --git a/virtinst/guest.py b/virtinst/guest.py
index 6284b1f..f075345 100644
--- a/virtinst/guest.py
+++ b/virtinst/guest.py
@@ -1125,6 +1125,9 @@ class Guest(XMLBuilder):
"Using vnc.")
gtype = "vnc"
+if self.os.is_ppc64():
+gtype = "vnc"
+
gfx.type = gtype
for dev in self.get_devices("graphics"):
ACK.
Regards.
- Chen
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [virt-manager][PATCH v1 2/2] Modify the xml file for the virt-install for ppc64le
On 12/15/2015 09:06 PM, Kevin Zhao wrote: Modify the xml file for virt-install of ppc64le for importing existing image using KVM.Because the spice devices has not been supported by powerpc64 and powerpc64le,the only supporting graphic device is vnc. Signed-off-by: Kevin Zhao --- .../compare/virt-install-ppc64le-kvm-import.xml | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/tests/cli-test-xml/compare/virt-install-ppc64le-kvm-import.xml b/tests/cli-test-xml/compare/virt-install-ppc64le-kvm-import.xml index 7a3d4c2..5166f03 100644 --- a/tests/cli-test-xml/compare/virt-install-ppc64le-kvm-import.xml +++ b/tests/cli-test-xml/compare/virt-install-ppc64le-kvm-import.xml @@ -23,21 +23,10 @@ - - - + - - - - - - - - - ACK. Regards. - Chen ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [virt-manager][PATCH v1 1/2] Modify the default graphics device to "vnc" for ppc64 and ppc64le
On 12/15/2015 08:06 AM, Kevin Zhao wrote:
> Modify the default graphics device to "vnc",since the powerpc
> does't support spice devices.Otherwise, virt-manager can not
> be used in ppc64 and ppc64le hardware.So that change make
> virt-manager supports arch "ppc64" and "ppc64le".Also add
> a test case to cover this change.
> ---
> .../compare/virt-install-ppc64le-cdrom-f22.xml | 39
> ++
> tests/clitest.py | 2 +-
> virtinst/guest.py | 3 ++
> 3 files changed, 43 insertions(+), 1 deletion(-)
> create mode 100644
> tests/cli-test-xml/compare/virt-install-ppc64le-cdrom-f22.xml
>
> diff --git a/tests/cli-test-xml/compare/virt-install-ppc64le-cdrom-f22.xml
> b/tests/cli-test-xml/compare/virt-install-ppc64le-cdrom-f22.xml
> new file mode 100644
> index 000..c710169
> --- /dev/null
> +++ b/tests/cli-test-xml/compare/virt-install-ppc64le-cdrom-f22.xml
> @@ -0,0 +1,39 @@
> +
> + foobar
> + ----
> + 1048576
> + 1048576
> + 1
> +
> +hvm
> +
> +
> +
> +
> + destroy
> + destroy
> + destroy
> +
> +/usr/bin/qemu-system-ppc64
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> diff --git a/tests/clitest.py b/tests/clitest.py
> index 994b415..f2085cc 100644
> --- a/tests/clitest.py
> +++ b/tests/clitest.py
> @@ -702,7 +702,7 @@ c.add_compare("--connect %(URI-KVM-AARCH64)s --disk
> %(EXISTIMG1)s --import --os-
> c.add_compare("--arch ppc64 --machine pseries --boot network --disk
> %(EXISTIMG1)s --os-variant fedora20 --network none", "ppc64-pseries-f20")
> c.add_compare("--arch ppc64 --boot network --disk %(EXISTIMG1)s --os-variant
> fedora20 --network none", "ppc64-machdefault-f20")
> c.add_compare("--connect %(URI-KVM-PPC64LE)s --import --disk %(EXISTIMG1)s
> --os-variant fedora20", "ppc64le-kvm-import")
> -
> +c.add_compare("--arch ppc64 --machine pseries --connect %(URI-KVM-PPC64LE)s
> --disk %(EXISTIMG1)s --disk %(EXISTIMG3)s,device=cdrom --os-variant
> fedora22", "ppc64le-cdrom-f22")
> # s390x tests
> c.add_compare("--arch s390x --machine s390-ccw-virtio --connect
> %(URI-KVM-S390X)s --boot kernel=/kernel.img,initrd=/initrd.img --disk
> %(EXISTIMG1)s --disk %(EXISTIMG3)s,device=cdrom --os-variant fedora21",
> "s390x-cdrom")
> c.add_compare("--arch s390x --machine s390-ccw-virtio --connect
> %(URI-KVM-S390X-KVMIBM)s --boot kernel=/kernel.img,initrd=/initrd.img --disk
> %(EXISTIMG1)s --disk %(EXISTIMG3)s,device=cdrom --os-variant fedora21
> --watchdog diag288,action=reset", "s390x-cdrom-KVMIBM")
> diff --git a/virtinst/guest.py b/virtinst/guest.py
> index 6284b1f..f075345 100644
> --- a/virtinst/guest.py
> +++ b/virtinst/guest.py
> @@ -1125,6 +1125,9 @@ class Guest(XMLBuilder):
>"Using vnc.")
> gtype = "vnc"
>
> +if self.os.is_ppc64():
> +gtype = "vnc"
> +
> gfx.type = gtype
>
> for dev in self.get_devices("graphics"):
>
Thanks for the report, indeed our behavior is wrong. But this fix isn't
correct... spice is only supported for qemu running on x86 _host_, it doesn't
have anything to do with the qemu emulated arch. I pushed a patch with the
proper fix:
commit 33ca0fff7dab62bfa64a24bcdd1d862a9c17245f
Author: Cole Robinson
Date: Tue Dec 15 21:06:19 2015 +0800
Only use spice on x86
qemu isn't compiled with spice support for non-x86
Reported-by: Kevin Zhao
- Cole
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [virt-manager PATCH] Prohibit adding PCI host devices to container
On 12/23/2015 07:01 AM, Pavel Fedin wrote:
> libvirt does not allow this and attempt to do so causes error during domain
> startup. Prevent this in the beginning instead with correct explanation.
>
> Signed-off-by: Pavel Fedin
> ---
> virtManager/addhardware.py | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py
> index 8de710d..6d812e3 100644
> --- a/virtManager/addhardware.py
> +++ b/virtManager/addhardware.py
> @@ -376,9 +376,14 @@ class vmmAddHardware(vmmGObjectUI):
>self.conn.is_nodedev_capable(),
>_("Connection does not support host device
> enumeration"),
>"usb")
> +if self.vm.is_container():
> +enabled = False
> +errstr = _("Not supported for this guest type")
> +else:
> +enabled = self.conn.is_nodedev_capable()
> +errstr = _("Connection does not support host device enumeration")
> add_hw_option("PCI Host Device", "system-run", PAGE_HOSTDEV,
> - self.conn.is_nodedev_capable(),
> - _("Connection does not support host device
> enumeration"),
> + enabled, errstr,
>"pci")
> add_hw_option("Video", "video-display", PAGE_VIDEO, True,
>_("Libvirt version does not support video devices."))
>
Thanks, pushed with some minor tweaks
- Cole
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
