[vchkpw] vdeluser isCatchall mysql segfault (was Re: [vchkpw] Decided to make the plunge today on late version of vpopmail)

2007-09-07 Thread Japheth Cleaver
> Hi Steve,
>
> i think the problem is related to something i posted some days ago but
> without any answer.
>
> Look at the post :
>
> Re: [vchkpw] vdeluser segfault posted on 19/08/2007 be my answering
> to a previous post.
>
> Let me know if it is the case.
> Bye,
> Marcello
>
> Steve Cole wrote:
>> On two (low volume) machines with vpopmail interfaced with mysql as the
>> data
>> store, it seemed to work successfully.  I updated the database schema
>> with no
>> issues.  This is with v5.4.21
>>
>> However, when I do a "vdeluser" on either machine, the program
>> segfaults.  On
>> both systems.
>>
>> I tried various things like making sure my LDFLAGS="" and CFLAGS="-O"
>> only to
>> be sure it wasn't a compiler issue, without luck.
>>
>> So, to be clear, this is on two Debian Etch machines with GCC 4.1.1-15
>> and
>> MySQL 5.0.32-7etch1 installed.
>>
>> Going back to 5.4.17 seemed to be no issue at all and of course, it
>> works as
>> expected.
>>


I would concur. From a cursory look at the logic, I don't see how this
really works when using MySQL aliases. I commented out the entire catchall
check when moving to 5.4.19 simply to keep things working.


Regards,
-jc


--- vpopmail.c.orig 2007-08-23 16:46:31.0 -0700
+++ vpopmail.c  2007-08-23 17:03:51.0 -0700
@@ -1733,9 +1733,9 @@
   }

   /* Make sure we are not the email address of the catchall account */
-  if ( isCatchall( user, domain, Dir )) {
-return(VA_CANNOT_DELETE_CATCHALL);
-}
+  // if ( isCatchall( user, domain, Dir )) {
+  //  return(VA_CANNOT_DELETE_CATCHALL);
+  //  }

 #ifdef ONCHANGE_SCRIPT
   /* tell other programs that data has changed */





Re: [vchkpw] Decided to make the plunge today on late version of vpopmail

2007-09-07 Thread Marcello Lupo

Hi Steve,

i think the problem is related to something i posted some days ago but 
without any answer.


Look at the post :

Re: [vchkpw] vdeluser segfault posted on 19/08/2007 be my answering 
to a previous post.


Let me know if it is the case.
Bye,
Marcello

Steve Cole wrote:
On two (low volume) machines with vpopmail interfaced with mysql as the data 
store, it seemed to work successfully.  I updated the database schema with no 
issues.  This is with v5.4.21


However, when I do a "vdeluser" on either machine, the program segfaults.  On 
both systems.


I tried various things like making sure my LDFLAGS="" and CFLAGS="-O" only to 
be sure it wasn't a compiler issue, without luck.


So, to be clear, this is on two Debian Etch machines with GCC 4.1.1-15 and 
MySQL 5.0.32-7etch1 installed.  

Going back to 5.4.17 seemed to be no issue at all and of course, it works as 
expected.


  




Re: [vchkpw] vdeluser isCatchall mysql segfault (was Re: [vchkpw] Decided to make the plunge today on late version of vpopmail)

2007-09-07 Thread Rick Widmer
Can someone who can see it fail please send me your ./configure options 
so maybe I can make it fail here?



Rick

Marcello Lupo wrote:

Hi,
i agree with your method to bybass the problem but in this way you will 
be able to delete a catch all account

for the domain without notice.
I think the best is to fix this issue making possible that the default 
alias is inserted in the valias table like the others
(if you use aliases in database), or to let the function check both file 
and database.
Moreover if it don't found the default alias in the database (this is 
what happen now) it should segfault but assume

that the account is not catchall.
I'm not a coder and i'm not able to do it.

Bye,
Marcello


Japheth Cleaver wrote:

Hi Steve,

i think the problem is related to something i posted some days ago but
without any answer.

Look at the post :

Re: [vchkpw] vdeluser segfault posted on 19/08/2007 be my answering
to a previous post.

Let me know if it is the case.
Bye,
Marcello

Steve Cole wrote:
   

On two (low volume) machines with vpopmail interfaced with mysql as the
data
store, it seemed to work successfully.  I updated the database schema
with no
issues.  This is with v5.4.21

However, when I do a "vdeluser" on either machine, the program
segfaults.  On
both systems.

I tried various things like making sure my LDFLAGS="" and CFLAGS="-O"
only to
be sure it wasn't a compiler issue, without luck.

So, to be clear, this is on two Debian Etch machines with GCC 4.1.1-15
and
MySQL 5.0.32-7etch1 installed.

Going back to 5.4.17 seemed to be no issue at all and of course, it
works as
expected.

  



I would concur. From a cursory look at the logic, I don't see how this
really works when using MySQL aliases. I commented out the entire 
catchall

check when moving to 5.4.19 simply to keep things working.


Regards,
-jc


--- vpopmail.c.orig 2007-08-23 16:46:31.0 -0700
+++ vpopmail.c  2007-08-23 17:03:51.0 -0700
@@ -1733,9 +1733,9 @@
   }

   /* Make sure we are not the email address of the catchall account */
-  if ( isCatchall( user, domain, Dir )) {
-return(VA_CANNOT_DELETE_CATCHALL);
-}
+  // if ( isCatchall( user, domain, Dir )) {
+  //  return(VA_CANNOT_DELETE_CATCHALL);
+  //  }

 #ifdef ONCHANGE_SCRIPT
   /* tell other programs that data has changed */

  





Re: [vchkpw] vdeluser isCatchall mysql segfault (was Re: [vchkpw] Decided to make the plunge today on late version of vpopmail)

2007-09-07 Thread Marcello Lupo

Hi,
i agree with your method to bybass the problem but in this way you will 
be able to delete a catch all account

for the domain without notice.
I think the best is to fix this issue making possible that the default 
alias is inserted in the valias table like the others
(if you use aliases in database), or to let the function check both file 
and database.
Moreover if it don't found the default alias in the database (this is 
what happen now) it should segfault but assume

that the account is not catchall.
I'm not a coder and i'm not able to do it.

Bye,
Marcello


Japheth Cleaver wrote:

Hi Steve,

i think the problem is related to something i posted some days ago but
without any answer.

Look at the post :

Re: [vchkpw] vdeluser segfault posted on 19/08/2007 be my answering
to a previous post.

Let me know if it is the case.
Bye,
Marcello

Steve Cole wrote:


On two (low volume) machines with vpopmail interfaced with mysql as the
data
store, it seemed to work successfully.  I updated the database schema
with no
issues.  This is with v5.4.21

However, when I do a "vdeluser" on either machine, the program
segfaults.  On
both systems.

I tried various things like making sure my LDFLAGS="" and CFLAGS="-O"
only to
be sure it wasn't a compiler issue, without luck.

So, to be clear, this is on two Debian Etch machines with GCC 4.1.1-15
and
MySQL 5.0.32-7etch1 installed.

Going back to 5.4.17 seemed to be no issue at all and of course, it
works as
expected.

  



I would concur. From a cursory look at the logic, I don't see how this
really works when using MySQL aliases. I commented out the entire catchall
check when moving to 5.4.19 simply to keep things working.


Regards,
-jc


--- vpopmail.c.orig 2007-08-23 16:46:31.0 -0700
+++ vpopmail.c  2007-08-23 17:03:51.0 -0700
@@ -1733,9 +1733,9 @@
   }

   /* Make sure we are not the email address of the catchall account */
-  if ( isCatchall( user, domain, Dir )) {
-return(VA_CANNOT_DELETE_CATCHALL);
-}
+  // if ( isCatchall( user, domain, Dir )) {
+  //  return(VA_CANNOT_DELETE_CATCHALL);
+  //  }

 #ifdef ONCHANGE_SCRIPT
   /* tell other programs that data has changed */

  


Re: [vchkpw] vdeluser isCatchall mysql segfault (was Re: [vchkpw] Decided to make the plunge today on late version of vpopmail)

2007-09-07 Thread Marcello Lupo

Hi Rick,
this is my configure options with vpopmail-5.4.19 :

./configure --enable-roaming-users 
--enable-tcpserver-file=/home/vpopmail/etc/tcp.smtp 
--enable-relay-clear-minutes=15 \
--enable-onchange-script --enable-auth-module=mysql --enable-logging=p 
--enable-mysql-limits --enable-valias  \
--enable-incdir=/usr/include/mysql --enable-libdir=/usr/lib64/mysql 
--disable-clear-passwd


It is making the problem on this installation.
Thanks,
Bye,
Marcello




Rick Widmer wrote:
Can someone who can see it fail please send me your ./configure 
options so maybe I can make it fail here?



Rick

Marcello Lupo wrote:

Hi,
i agree with your method to bybass the problem but in this way you 
will be able to delete a catch all account

for the domain without notice.
I think the best is to fix this issue making possible that the 
default alias is inserted in the valias table like the others
(if you use aliases in database), or to let the function check both 
file and database.
Moreover if it don't found the default alias in the database (this is 
what happen now) it should segfault but assume

that the account is not catchall.
I'm not a coder and i'm not able to do it.

Bye,
Marcello


Japheth Cleaver wrote:

Hi Steve,

i think the problem is related to something i posted some days ago but
without any answer.

Look at the post :

Re: [vchkpw] vdeluser segfault posted on 19/08/2007 be my 
answering

to a previous post.

Let me know if it is the case.
Bye,
Marcello

Steve Cole wrote:
  
On two (low volume) machines with vpopmail interfaced with mysql 
as the

data
store, it seemed to work successfully.  I updated the database schema
with no
issues.  This is with v5.4.21

However, when I do a "vdeluser" on either machine, the program
segfaults.  On
both systems.

I tried various things like making sure my LDFLAGS="" and CFLAGS="-O"
only to
be sure it wasn't a compiler issue, without luck.

So, to be clear, this is on two Debian Etch machines with GCC 
4.1.1-15

and
MySQL 5.0.32-7etch1 installed.

Going back to 5.4.17 seemed to be no issue at all and of course, it
works as
expected.

  



I would concur. From a cursory look at the logic, I don't see how this
really works when using MySQL aliases. I commented out the entire 
catchall

check when moving to 5.4.19 simply to keep things working.


Regards,
-jc


--- vpopmail.c.orig 2007-08-23 16:46:31.0 -0700
+++ vpopmail.c  2007-08-23 17:03:51.0 -0700
@@ -1733,9 +1733,9 @@
   }

   /* Make sure we are not the email address of the catchall account */
-  if ( isCatchall( user, domain, Dir )) {
-return(VA_CANNOT_DELETE_CATCHALL);
-}
+  // if ( isCatchall( user, domain, Dir )) {
+  //  return(VA_CANNOT_DELETE_CATCHALL);
+  //  }

 #ifdef ONCHANGE_SCRIPT
   /* tell other programs that data has changed */

  










Re: [vchkpw] vdeluser isCatchall mysql segfault (was Re: [vchkpw] Decided to make the plunge today on late version of vpopmail)

2007-09-07 Thread Rick Widmer



Marcello Lupo wrote:

Hi Rick,
this is my configure options with vpopmail-5.4.19 :

./configure --enable-roaming-users 
--enable-tcpserver-file=/home/vpopmail/etc/tcp.smtp 
--enable-relay-clear-minutes=15 \
--enable-onchange-script --enable-auth-module=mysql --enable-logging=p 
--enable-mysql-limits --enable-valias  \
--enable-incdir=/usr/include/mysql --enable-libdir=/usr/lib64/mysql 
--disable-clear-passwd


Cool!  It failed.  Now on to a fix...