Re: [PATCH v4] imx: support i.MX8QM DMSSE20 a1 board

2022-10-05 Thread oliver.gra...@kococonnector.com
On 13/07/22, Marcel Ziswiler wrote:
> Hi Oliver
> 
> On Tue, 2022-07-12 at 12:14 +0200, Oliver Graute wrote:
> > Add i.MX8QM DMSSE20 a1 board support
> > 
> > U-Boot 2022.07-00033-g2a5cf8e9e7 (Jul 12 2022 - 11:29:05 +0200)
> > 
> > Model: Advantech iMX8QM DMSSE20
> > Board: DMS-SE20A1 8GB
> > Build: SCFW 549b1e18, SECO-FW c9de51c0, ATF 5782363
> > Boot:  USB
> > DRAM:  8 GiB
> > Core:  100 devices, 19 uclasses, devicetree: separate
> > MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2
> > Loading Environment from MMC... OK
> > In:    serial@5a06
> > Out:   serial@5a06
> > Err:   serial@5a06
> > Net:   eth0: ethernet@5b04
> > Warning: ethernet@5b05 (eth1) using random MAC address - 
> > aa:a2:be:5b:81:4a
> > , eth1: ethernet@5b05
> > Hit any key to stop autoboot:  0
> > 
> > Signed-off-by: Oliver Graute 
> > ---
> >  Changes for v4
> >  -update atf fw version
> >  -update seco fw version
> >  -update scfw version
> >  -move CONFIG_IMX_SMMU to imx8qm_dmsse20a1_defconfig
> >  -move CONFIG_LOADADDR to imx8qm_dmsse20a1_defconfig
> >  -move CONFIG_SYS_LOAD_ADDR to imx8qm_dmsse20a1_defconfig
> >  -move CONFIG_SYS_MALLOC_LEN to imx8qm_dmsse20a1_defconfig
> >  -move CONFIG_SYS_MMC_IMG_LOAD_PART to imx8qm_dmsse20a1_defconfig
> >  -move CONFIG_FSL_USDHC to imx8qm_dmsse20a1_defconfig
> >  -replaced CONFIG_SPL_MMC_SUPPORT with CONFIG_SPL_MMC
> >  -replaced CONFIG_SPL_SERIAL_SUPPORT with CONFIG_SPL_SERIAL
> >  -drop CONFIG_FEC_XCV_TYPE
> > 
> > Changes for v3
> >  -Remove addr parameter from reset_cpu()
> >  -moved some configs into defconfig
> > 
> > Changes for v2
> >  -replaced bd_t with struct bd_info
> >  -added missing DTS in MAINTAINERS
> >  -replaced README with imx8qm-dmsse20-a1.rst
> >  -move CMD_FUSE to Kconfig
> >  -removed fdt_high
> >  -added i2c support
> >  -added rtc support
> > 
> >  arch/arm/dts/Makefile |   1 +
> >  arch/arm/dts/imx8qm-dmsse20-a1.dts    | 407 ++
> >  arch/arm/mach-imx/imx8/Kconfig    |   7 +
> >  board/advantech/imx8qm_dmsse20_a1/Kconfig |  17 +
> >  board/advantech/imx8qm_dmsse20_a1/MAINTAINERS |   7 +
> >  board/advantech/imx8qm_dmsse20_a1/Makefile    |   8 +
> >  .../imx8qm_dmsse20_a1/imx8qm_dmsse20_a1.c | 188 
> >  .../advantech/imx8qm_dmsse20_a1/imximage.cfg  |  21 +
> >  board/advantech/imx8qm_dmsse20_a1/spl.c   | 224 ++
> >  common/Kconfig    |   2 +-
> >  configs/imx8qm_dmsse20a1_defconfig    | 105 +
> >  doc/board/advantech/imx8qm-dmsse20-a1.rst |  59 +++
> >  doc/board/advantech/index.rst |   1 +
> >  include/configs/imx8qm_dmsse20.h  | 164 +++
> >  14 files changed, 1210 insertions(+), 1 deletion(-)
> >  create mode 100644 arch/arm/dts/imx8qm-dmsse20-a1.dts
> >  create mode 100644 board/advantech/imx8qm_dmsse20_a1/Kconfig
> >  create mode 100644 board/advantech/imx8qm_dmsse20_a1/MAINTAINERS
> >  create mode 100644 board/advantech/imx8qm_dmsse20_a1/Makefile
> >  create mode 100644 board/advantech/imx8qm_dmsse20_a1/imx8qm_dmsse20_a1.c
> >  create mode 100644 board/advantech/imx8qm_dmsse20_a1/imximage.cfg
> >  create mode 100644 board/advantech/imx8qm_dmsse20_a1/spl.c
> >  create mode 100644 configs/imx8qm_dmsse20a1_defconfig
> >  create mode 100644 doc/board/advantech/imx8qm-dmsse20-a1.rst
> >  create mode 100644 include/configs/imx8qm_dmsse20.h
> > 
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> > index a7e0d9f6c0..50bc76289f 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -920,6 +920,7 @@ dtb-$(CONFIG_ARCH_IMX8) += \
> > fsl-imx8qm-apalis.dtb \
> > fsl-imx8qm-mek.dtb \
> > imx8qm-cgtqmx8.dtb \
> > +   imx8qm-dmsse20-a1.dtb \
> > imx8qm-rom7720-a1.dtb \
> > fsl-imx8qxp-ai_ml.dtb \
> > fsl-imx8qxp-colibri.dtb \
> > diff --git a/arch/arm/dts/imx8qm-dmsse20-a1.dts 
> > b/arch/arm/dts/imx8qm-dmsse20-a1.dts
> > new file mode 100644
> > index 00..81ef7fb2ce
> > --- /dev/null
> > +++ b/arch/arm/dts/imx8qm-dmsse20-a1.dts
> > @@ -0,0 +1,407 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> 
> For device trees it is usually advisable to use the following license:
> 
> GPL-2.0-or-later OR MIT
> 
> Anyway, please use at least latest SPDX notation being GPL-2.0-or-later 
> rather than GPL-2.0+.

ok 

> 
> > +/*
> > + * Copyright 2017 NXP
> 
> That also seems bogus to me.

ok

> 
> > + */
> > +
> > +/dts-v1/;
> > +
> > +/* First 128KB is for PSCI ATF. */
> > +/memreserve/ 0x8000 0x0002;
> > +
> > +#include "fsl-imx8qm.dtsi"
> > +
> > +/ {
> > +   model = "Advantech iMX8QM DMSSE20";
> > +   compatible = "fsl,imx8qm-mek", "fsl,imx8qm";
> > +
> > +   aliases {
> > +  mmc0 = &usdhc1;
> > +  mmc2 = &usdhc3;
> > +   };
> > +
> > +   chosen {
> > +   bootargs = "console=ttyLP0,115200 
> > earlycon=lpuart32,0x5a06,115200";
> 
> This stuff is completely d

Re: [PATCH v2 8/8] imx: imx8: apalis: switch to binman

2022-11-10 Thread oliver.gra...@kococonnector.com
On 09/11/22, Marcel Ziswiler wrote:
> Hi Oliver
> 
> Thanks for working on this.
> 
> On Fri, 2022-11-04 at 16:03 +0100, Oliver Graute wrote:
> > Switch to use binman to pack images
> > 
> > Signed-off-by: Oliver Graute 
> > ---
> > Changes for v2
> >  - use common imx8qm-u-boot.dtsi
> >  - guard SPL nodes with CONFIG_SPL
> 
> I don't think it is that simple. Even after guarding them SPL nodes the 
> flash.bin one still references them,
> not? And yes, so far we never used SPL for them 8/8X as that honestly does 
> not really make much sense given the
> SCFW does the actual RAM initialisation. Anyway, I am not very clear on 
> how/what exactly that all means now.

On imx8qm-rom7720 we use the SCFW for RAM initalisation too but still use
SPL.  
> 
> Another topic is that flash.bin is now just the SPL whereas previously 
> u-boot-dtb.imx was the entire thing. But
> again, that could have been related to us not using SPL.

yes, thats right, if I guard the SPL subnode in imx-boot node I get a 0 byte
flash.bin. 

At the moment I don't know the best way here. I would be grateful for
some hints here.

> >  CONFIG_FIT=y +CONFIG_FIT_EXTERNAL_OFFSET=0x3000
> 
> Also not quite sure what exactly that is now.

its introduced by commit 3814fcba12323b9f30f39ee5455f3f9a7e955c64

Best regards,

Oliver