Re: [Twisted-Python] Twisted Release Planning

2021-07-09 Thread Tom Most
šŸŒ‹

Automating all this is a great project! Please feel free to ping me for reviews.

---Tom

On Thu, Jul 8, 2021, at 10:16 AM, Adi Roiban wrote:
> 
> 
> On Tue, 6 Jul 2021 at 14:21, Adi Roiban  wrote:
>> 
>> 
>> On Tue, 6 Jul 2021 at 01:55, Glyph  wrote:
>>> 
>>> On July 5, 2021 at 3:55:38 PM, Adi Roiban (a...@roiban.ro) wrote:
>>> 
 Hi,
 
 I don't have much time or much "need" but if needed I can help with a new 
 Twisted release.
>>> Hooray! I’m hype for 21.7!
>>> 
>> I have created the release ticket and will create the release branch and RC 
>> soon.
> 
> I am planning to create the release branch soon.
> 
> I plan to do the release based on the updated documentation from 
> https://github.com/twisted/twisted/pull/1616
> 
> That is, create the release branch, push the packages to PyPI and only after 
> these steps as for a review for the PR
> and send the release candidate announcement.
> 
> Let me know if the release pull request should have an approved review before 
> pushing the release candidate files to PyPi.
> 
> -- 
> Adi Roiban
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
> 
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python


Re: [Twisted-Python] Twisted Release Planning

2021-07-09 Thread Adi Roiban
On Fri, 9 Jul 2021 at 08:34, Tom Most  wrote:

> šŸŒ‹
>
> Automating all this is a great project! Please feel free to ping me for
> reviews.
>
>
There is one blocker PR for the release as the newsfragment checks are
failing on the release branch... since the code is executed on the
to-be-merged on a branch named by GitHub Action something like
refs/pull/1617/merge

so the new fragment check fails to detect it as a release branch...as a
release branch should have a name starting with 'release-'

The PR is here. Any feedback will help to get this merge
https://github.com/twisted/twisted/pull/1617

This PR is important as I want to have a green release branch.

For the previous release, we just ignored the failure and did the release
anyway
But for this release I want it fixed :)



This is also a non-blocker PR which contains a minor clarification for the
release process

https://github.com/twisted/twisted/pull/1616

-- 
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python