Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol
On 10 March 2018 at 04:57, Glyph wrote: > On Mar 9, 2018, at 4:03 AM, Ilya Skriblovsky > wrote: > > > Just wanted to make sure, did I all what I should do for putting this ticket > into review: https://twistedmatrix.com/trac/ticket/9374 ? > Should I just wait for maintainers to review it? > > > You've done all the right things. :) I went for an initial review. > The best thing you can do to accelerate your own change getting reviewed is > to code review others' changes, so that when a reviewer arrives to > stochastically select something to review it is more likely that they'll > select your thing instead of one of the other things :-). +1 I am thinking of adding this to the wiki page for the review process. I think that we can try and see how it goes. Doing a review is not easy, you end up with the responsibility for the approved code, but with the size of the queue I think that we should try. > The second best thing you can do is to donate a lot of money using the form > on the front page of the web site: > https://twistedmatrix.com/trac/#DonatetoTwisted, which, at some point, will > allow us to re-start the Twisted fellowship program > http://labs.twistedmatrix.com/2015/06/twisted-fellowship-2015-call-for.html > and have someone actually keep the review queue clear as their actual paid > responsibility :). > -g +1 on this. I think that it might work even if we get someone to work on this 1 hour per day. Glyph, do you know what is the required money we need to raise to start this program... and are the current money on bank now? Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol
> You've done all the right things. :) Thanks for clarifications and congrats on your newborn! сб, 10 мар. 2018 г. в 7:58, Glyph : > On Mar 9, 2018, at 4:03 AM, Ilya Skriblovsky > wrote: > > > Just wanted to make sure, did I all what I should do for putting this > ticket into review: https://twistedmatrix.com/trac/ticket/9374 ? > Should I just wait for maintainers to review it? > > > You've done all the right things. :) > > Twisted maintainers go through the list at https://twisted.reviews and > review things, and you can indeed see that your change is on that list. > > Unfortunately, as you can see, there's quite a backlog. Personally I have > been quite busy with a new child and a new startup, so (as previously > discussed on this very mailing list) I haven't been doing much in the way > of code review myself recently. Even what little open source time I have > needs to be focused elsewhere at the moment. > > The best thing you can do to accelerate your own change getting reviewed > is to code review others' changes, so that when a reviewer arrives to > stochastically select something to review it is more likely that they'll > select your thing instead of one of the other things :-). > > The second best thing you can do is to donate a lot of money using the > form on the front page of the web site: > https://twistedmatrix.com/trac/#DonatetoTwisted, which, at some point, > will allow us to re-start the Twisted fellowship program > http://labs.twistedmatrix.com/2015/06/twisted-fellowship-2015-call-for.html > and > have someone actually keep the review queue clear as their actual paid > responsibility :). > > -g > ___ > Twisted-Python mailing list > Twisted-Python@twistedmatrix.com > https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
[Twisted-Python] Weekly Bug Summary
Bug summary __ Summary for 2018-03-04 through 2018-03-11 Opened Closed Total Change Enhancements: 0 2 1381 -2 Defects: 0 1911 -1 Tasks: 0 0 93 +0 Regressions: 0 0 6 +0 Total: 0 3 2392 -3 |== Type Changes |== Priority Changes |== Component Changes |Defect: -1 |Normal: -2 |Core: -3 |Enhancement: -2 |Lowest: -1 Total Tickets Open Tickets New / Reopened Bugs __ Closed Bugs __ = Normal = [#9343] Add a ensureBytes() helper function (opened by rodrigc, closed by Craig Rodrigues , fixed) enhancement core http://twistedmatrix.com/trac/ticket/9343 [#9365] Fix typo in finger08.py (opened by rodrigc, closed by adiroiban, fixed) defect core http://twistedmatrix.com/trac/ticket/9365 = Lowest = [#9338] Add `twist' to list of commands we provide shell tab-completion for (opened by teratorn, closed by Adi Roiban , fixed) enhancement core http://twistedmatrix.com/trac/ticket/9338 Ticket Lifetime Stats __ Oldest open ticket - [#50] conch command-line client doesn't work in win32 (since 2003-07-12 14:41:06). Newest open ticket - [#9386] Iterating over a DeferredList loops forever on Python 3 (since 2018-02-27 23:40:47.275410). Mean open ticket age: 2209 days, 16:38:09.348985. Median: 2056 days, 10:10:38.758988. Standard deviation: 1283 days, 5:45:58.581318. Interquartile range: 1850 days, 20:48:30.795914. Mean time between ticket creation and ticket resolution: 635 days, 6:07:41.981363. Median: 67 days, 6:49:20. Standard deviation is 1030 days, 16:50:30.941726. The interquartile range is 871 days, 7:17:52. Mean time spent in review: 104 days, 8:17:57.302993. Median: 4 days, 18:12:48. Standard deviation: 508 days, 11:28:06.478599. Interquartile range: 22 days, 23:29:29.981067. Mean number of times a ticket is reviewed: 1.84046978224. Median: 1 Standard deviation: 1.44806396049. Interquartile range: 1. Contributor Stats __ In the last 4 weeks, 5 unique ticket reporters 5 unique ticket reviewers 5 unique ticket resolvers In the last 24 weeks, 39 unique ticket reporters 11 unique ticket reviewers 12 unique ticket resolvers In the last 48 weeks, 79 unique ticket reporters 22 unique ticket reviewers 24 unique ticket resolvers ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
