Re: [Twisted-Python] Please fix the broken buildbots

[Mark Williams]

Glyph got me all set up so I can work on the Buildbots.  Thanks,
Glyph!

I hope to resolve the issue Craig identified soon and will announce
any progress.  Stay tuned!

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Please fix the broken buildbots

[Amber "Hawkie" Brown]

So I also investigated and it appeared like the hack I had in 
https://github.com/twisted-infra/braid/blob/master/services/buildbot/master/twisted_factories.py#L368
 to prevent this from occurring disappeared in prod; I think maybe Adi pushed 
up something trying to replicate what it was doing without committing it :)

I've redeployed from master of braid, and it appears to be working now.

- Amber

> On 23 Aug 2016, at 15:43, Mark Williams  wrote:
> 
> Glyph got me all set up so I can work on the Buildbots.  Thanks,
> Glyph!
> 
> I hope to resolve the issue Craig identified soon and will announce
> any progress.  Stay tuned!
> 
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Please fix the broken buildbots

[Adi Roiban]

Hi,

On 23 August 2016 at 08:51, Amber "Hawkie" Brown
 wrote:
> So I also investigated and it appeared like the hack I had in 
> https://github.com/twisted-infra/braid/blob/master/services/buildbot/master/twisted_factories.py#L368
>  to prevent this from occurring disappeared in prod; I think maybe Adi pushed 
> up something trying to replicate what it was doing without committing it :)

I broke the build. Sorry for that.

I saw those conflicting lines ... and I went for the one injecting the
test case ... as this is how it was supposed to work :)

I am working on creating tox/ven builders for everything... and as
part of that, I have refactored some factories ...as there is some
code duplication.

I have created a PR now... https://github.com/twisted-infra/braid/pull/223

I think that we should have tests =
[WithProperties("%(test-case-name:~twisted)s")]

This should put twisted when test-case-name is not defined by a build job.

Any objections on that?

-- 
Adi Roiban

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Tests on Windows with Python 3 now passing

[Adi Roiban]

On 23 August 2016 at 05:49, Glyph Lefkowitz  wrote:
>
> On Aug 22, 2016, at 9:29 PM, Craig Rodrigues  wrote:
>
> I have fixed the tests that were failing on Windows with Python 3.
>
> If you look at:
> https://ci.appveyor.com/project/adiroiban/twisted/build/trunk-1008
>
> We now have builds running on Python 3.3, 3.4, and 3.5 on Windows.
> These builds are also uploading coverage results to codecov.io.
>
> I looked at that build and on Python 3.5 we have:
>
> 9539 tests (2338 skipped, 7201 succeeded)
>
>
> This is awesome.  I hope it'll open the door to more Windows/py3-minded
> contributors!
Great news.

Now that we have windows on appveyor, can we remove the Windows builders?

The windows builders are stuck on the virtualenv --clear step.

https://buildbot.twistedmatrix.com/boxes-unsupported?branch=8544-tox-for-buildbot

As part of the work for #8544 I have created tox environment for all
builders  https://github.com/twisted/twisted/pull/280

so we should be able to run on appveyor the nomodules and bdist builders

for the bdist, we still need to see if is ok  to publish the wheel on
Azure and if is ok to create it from Win2008R2 Server vs Win7

-- 
Adi Roiban

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Waiting time for tests running on Travis CI and Buildbot

[Adi Roiban]

We now have 15 concurrent jobs for the next 10 days.

Please check if it makes a difference worth more than $6000 per year :)

Also, do we need both python 3.3 and 3.4 jobs?

I think that we have non python 3.5 builders to prevent the usage of
string formatting for bytes which is not available in 3.3 and 3.4.

What are the differences between 3.3 and 3.4  that requires us to have
both versions?

Regards,
Adi

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Waiting time for tests running on Travis CI and Buildbot

[Glyph Lefkowitz]

> On Aug 23, 2016, at 4:24 AM, Adi Roiban  wrote:
> 
> We now have 15 concurrent jobs for the next 10 days.
> 
> Please check if it makes a difference worth more than $6000 per year :)
> 
> Also, do we need both python 3.3 and 3.4 jobs?
> 
> I think that we have non python 3.5 builders to prevent the usage of
> string formatting for bytes which is not available in 3.3 and 3.4.
> 
> What are the differences between 3.3 and 3.4  that requires us to have
> both versions?

We can't enumerate them.  If we support 3.3, we have to test on 3.3.  For 
example, there's some difference in the way the garbage collector works which 
made the PB tests fail on 3.3 but not 3.4; it turns out that this change was 
fixed by adding better test cleanup, and did not necessitate a change to the 
implementation, but small undocumented changes can easily require different 
implementation strategies.

We can drop support for 3.3 of course, but that's a separate discussion.

-glyph
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Waiting time for tests running on Travis CI and Buildbot

[Mark Williams]

On Tue, Aug 23, 2016 at 09:44:16AM -0700, Glyph Lefkowitz wrote:
>
> We can drop support for 3.3 of course, but that's a separate discussion.

I'm marginally in favor of it.  I appreciate Adi's concern about the
build infrastructure.  And thanks to the inimitable Donald Stufft,
it's easy to get a sense of how popular Python 3.3 is among Twisted
users and whether or not dropping support for it will affect a large
percentage of them.

He provided the following BigTable Query to run against the PyPI
downloads dataset (available at
https://bigquery.cloud.google.com/dataset/the-psf:pypi?pli=1 ):

SELECT
  REGEXP_EXTRACT(details.python, r"^([^\.]+\.[^\.]+)") as python_version,
  COUNT(*) as downloads,
FROM
  TABLE_DATE_RANGE(
[the-psf:pypi.downloads],
DATE_ADD(CURRENT_TIMESTAMP(), -31, "day"),
DATE_ADD(CURRENT_TIMESTAMP(), -1, "day")
  )
WHERE file.project = 'twisted'
GROUP BY python_version
ORDER BY
  downloads DESC


Here're the results:

python_version  downloads
2.7 446869
null21959
3.5 15204
3.4 11245
2.6 5060
3.3 1060
3.2 271
3.6 241
2.4 5
1.173
2.5 2

(Donald explained that `null` represents mirrors and caches like
bandersnatch.)

It appears that dropping Python 3.3 wouldn't exclude very many of our
users.

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Waiting time for tests running on Travis CI and Buildbot

[Amber "Hawkie" Brown]

The only reason to support Python 3.3 is PyPy3. However, since they now have 
funding to push it to 3.5, and PyPy3 is by no means production ready, I think 
it is reasonable to do this.

I will announce the release after Twisted 16.4 as the final one to support 
Python 3.3, in accordance with our compatibility policy.

- Amber

> On 24 Aug 2016, at 01:27, Mark Williams  wrote:
> 
> On Tue, Aug 23, 2016 at 09:44:16AM -0700, Glyph Lefkowitz wrote:
>> 
>> We can drop support for 3.3 of course, but that's a separate discussion.
> 
> I'm marginally in favor of it.  I appreciate Adi's concern about the
> build infrastructure.  And thanks to the inimitable Donald Stufft,
> it's easy to get a sense of how popular Python 3.3 is among Twisted
> users and whether or not dropping support for it will affect a large
> percentage of them.
> 
> He provided the following BigTable Query to run against the PyPI
> downloads dataset (available at
> https://bigquery.cloud.google.com/dataset/the-psf:pypi?pli=1 ):
> 
> SELECT
>  REGEXP_EXTRACT(details.python, r"^([^\.]+\.[^\.]+)") as python_version,
>  COUNT(*) as downloads,
> FROM
>  TABLE_DATE_RANGE(
>[the-psf:pypi.downloads],
>DATE_ADD(CURRENT_TIMESTAMP(), -31, "day"),
>DATE_ADD(CURRENT_TIMESTAMP(), -1, "day")
>  )
> WHERE file.project = 'twisted'
> GROUP BY python_version
> ORDER BY
>  downloads DESC
> 
> 
> Here're the results:
> 
> python_versiondownloads
> 2.7 446869
> null21959
> 3.5 15204
> 3.4 11245
> 2.6 5060
> 3.3 1060
> 3.2 271
> 3.6 241
> 2.4 5
> 1.17  3
> 2.5   2
> 
> (Donald explained that `null` represents mirrors and caches like
> bandersnatch.)
> 
> It appears that dropping Python 3.3 wouldn't exclude very many of our
> users.
> 
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Waiting time for tests running on Travis CI and Buildbot

[Glyph Lefkowitz]

> On Aug 23, 2016, at 10:27 AM, Mark Williams  wrote:
> 
> It appears that dropping Python 3.3 wouldn't exclude very many of our
> users.

1/5 as many as Python 2.6, which we already don't support :).

-glyph___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Waiting time for tests running on Travis CI and Buildbot

[Glyph Lefkowitz]

> On Aug 23, 2016, at 10:32 AM, Amber Hawkie Brown  
> wrote:
> 
> However, since they now have funding to push it to 3.5,

... and can I just reiterate how SUPER PUMPED I am about this???

-g___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Regarding moving on with ticket #7934 (New Logging System)

[Eeshan Garg]

Hello!

Just submitted a PR for this, .

Thanks! :-)
Eeshan

On Wed, Jun 22, 2016 at 12:24 AM, Eeshan Garg 
wrote:

> Hello again!
>
> I am fully aware that it has been a _very_ long time since I mentioned
> that I would get on with ,
> but I haven't really had the time to actually do anything about it. :-/
>
> I would love to work on more tickets like  trac/ticket/7897> and help port Twisted to the new logging system and
> kind of get back into the flow of submitting patches and contributing to
> Twisted again (I miss it so much!!).
>
> My main concerns about moving on with #7934 after my last patch have
> already been reported by hawkowl in  trac/ticket/7983>. However, it was a bit unclear to me from the
> discussions in 7983 as to how to move forward. It would mean a lot to me if
> someone who is working on this right now (or glyph or hawkowl) could please
> give me a couple of pointers as to what should be done with the "self.log"
> issue for porting existing code to the new logging system.
>
> - Should I declare a log attribute for an entire module to use?
>
> - Should I rewrite my new patch around hawkowl's suggestion in 7983, use
> _loggerFor for everything? If so, how do you refer to the Logger instance
> to compare the log_logger in the event dict with what is expected (since
> asserting everything in the event dict, including log_logger is crucial for
> optimum test coverage)?
>
> - Or is there another way I should be searching for? Has anything changed
> since 7983 was filed? :-)
>
> I have already started working on the other suggestions put forth by the
> reviewers (such as context managers for capturing log events, etc.).
> Looking forward to contributing more!
>
> Regards,
> Eeshan Garg
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python