[Twisted-Python] setup.py broken in trunk

[Glyph Lefkowitz]

41482c4fe5442bcc7b046ab53bf15409f2031abd makes a change such that 'pip install 
-e .' (and indeed, 'pip install .') no longer installs 'twist'.

I think we should revert this.

Clearly we have a problem with our test suite, if we're not catching the 
binaries disappearing on us :-).

-glyph
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] setup.py broken in trunk

[Adi Roiban]

Yes. Will revert it. My fault for not correctly solving the conflicts
during merge.


On 21 August 2016 at 11:13, Glyph Lefkowitz  wrote:
> 41482c4fe5442bcc7b046ab53bf15409f2031abd makes a change such that 'pip 
> install -e .' (and indeed, 'pip install .') no longer installs 'twist'.
>
> I think we should revert this.
>
> Clearly we have a problem with our test suite, if we're not catching the 
> binaries disappearing on us :-).
>
> -glyph
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python



-- 
Adi Roiban

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] setup.py broken in trunk

[Adi Roiban]

On 21 August 2016 at 11:13, Glyph Lefkowitz  wrote:
> 41482c4fe5442bcc7b046ab53bf15409f2031abd makes a change such that 'pip 
> install -e .' (and indeed, 'pip install .') no longer installs 'twist'.
>
> I think we should revert this.
>
> Clearly we have a problem with our test suite, if we're not catching the 
> binaries disappearing on us :-).

I have reverted and re-submitted the ticket for review. Sorry for the trouble!

I have not yet added integration tests for the console scripts.

I think that before writing such tests we need to make sure that
development environments and CI environments all have `pip install -e
.` or something similar called.

For more details see https://twistedmatrix.com/trac/ticket/8622#comment:8

Craig is pushing for removing bin/trial and after bin/trial is removed
I think that all environments will need to have `pip install .` called
so that we don't run the OS trial version.

There is also ticket https://twistedmatrix.com/trac/ticket/8544 which
tries to create tox environments for all Buildbot builders so that we
can run everything with Tox on buildbot CI system.

-- 
Adi Roiban

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] setup.py broken in trunk

[Glyph Lefkowitz]

> On Aug 21, 2016, at 4:19 AM, Adi Roiban  wrote:
> 
> On 21 August 2016 at 11:13, Glyph Lefkowitz  wrote:
>> 41482c4fe5442bcc7b046ab53bf15409f2031abd makes a change such that 'pip 
>> install -e .' (and indeed, 'pip install .') no longer installs 'twist'.
>> 
>> I think we should revert this.
>> 
>> Clearly we have a problem with our test suite, if we're not catching the 
>> binaries disappearing on us :-).
> 
> I have reverted and re-submitted the ticket for review. Sorry for the trouble!

Thanks for fixing!

> I have not yet added integration tests for the console scripts.
> 
> I think that before writing such tests we need to make sure that
> development environments and CI environments all have `pip install -e
> .` or something similar called.
> 
> For more details see https://twistedmatrix.com/trac/ticket/8622#comment:8


> Craig is pushing for removing bin/trial and after bin/trial is removed
> I think that all environments will need to have `pip install .` called
> so that we don't run the OS trial version.
> 
> There is also ticket https://twistedmatrix.com/trac/ticket/8544 which
> tries to create tox environments for all Buildbot builders so that we
> can run everything with Tox on buildbot CI system.

Once we have `tox` everywhere, we don't need a separate step to run `pip`.  
This seems like the right way to address it.

-g
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Twisted 16.4.0 Prerelease 2 Announcement

[Amber "Hawkie" Brown]

Hi everyone!

I bring you a new Twisted 16.4.0 prerelease, with the following fixes:

- Twisted's HTTP server, when operating over TLS, would not cleanly close 
sockets, causing it to build up CLOSE_WAIT sockets until it would eventually 
run out of file descriptors. (from 16.3.2)
- AMP no longer fails on floats on Python 3.

For more information, check the NEWS file (link provided below).

As usual, it's available for download -- go here 
(https://twistedmatrix.com/Releases/pre/16.4.0pre2/ 
) to get the prerelease 
tarballs and the full NEWS file. If you want to install it right away, run:

   pip install 
https://twistedmatrix.com/Releases/pre/16.4.0pre2/Twisted-16.4.0rc2.tar.bz2 


Please let me know if you have any issues, as well as if you don't! If 
everything works well, that's a good thing for me to know :)

Twisted Regards,
Amber Brown (HawkOwl)


signature.asc
Description: Message signed with OpenPGP using GPGMail
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python