[Twisted-Python] Unhandled Error in python 3 test suite

2015-03-23 Thread Adi Roiban
When running the pyhon3 tests I see many Unhandled Error
ex:
https://buildbot.twistedmatrix.com/builders/python-3.3-tests/builds/2736/steps/shell/logs/stdio

This looks bad. Is this a bug in the test runner or a bug in the code?

Thanks!
-- 
Adi Roiban

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python


Re: [Twisted-Python] Unhandled Error in python 3 test suite

2015-03-23 Thread HawkOwl

> On 23 Mar 2015, at 22:05, Adi Roiban  wrote:
> 
> When running the pyhon3 tests I see many Unhandled Error
> ex:
> https://buildbot.twistedmatrix.com/builders/python-3.3-tests/builds/2736/steps/shell/logs/stdio
> 
> This looks bad. Is this a bug in the test runner or a bug in the code?
> 
> Thanks!
> --
> Adi Roiban

Hi Adi,

It's not really a bug -- it's just that the stderr isn't being captured like 
real Trial does. Twisted will reraise errors so they show up in logs, but will 
actually handle them (I think, anyway). The traceback formatting just says it's 
an unhandled error. That is, it was handled by Twisted, but it was unhandled by 
user code, and generated an errback or such.

- Hawkie


signature.asc
Description: Message signed with OpenPGP using GPGMail
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python


Re: [Twisted-Python] Unhandled Error in python 3 test suite

2015-03-23 Thread Tristan Seligmann
On 23 March 2015 at 16:25, HawkOwl  wrote:
> It's not really a bug -- it's just that the stderr isn't being captured like 
> real Trial does. Twisted will reraise errors so they show up in logs, but 
> will actually handle them (I think, anyway). The traceback formatting just 
> says it's an unhandled error. That is, it was handled by Twisted, but it was 
> unhandled by user code, and generated an errback or such.

Note that "Unhandled error in Deferred" is the default log message for
log.err, and a lot (most?) of the code that logs a failure calls
log.err without passing a different message.
-- 
mithrandi, i Ainil en-Balandor, a faer Ambar

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python