Re: [Twisted-Python] twistedchecker TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)

2014-09-29 Thread Glyph 

On Sep 28, 2014, at 11:16 PM, Wolfgang Rohdewald  
wrote:

> Am Sonntag, 28. September 2014, 17:15:37 schrieb Glyph:
>> How did you install twistedchecker?
> 
> installing is not even needed:
> 
> git clone https://github.com/twisted/twistedchecker
> cd twistedchecker
> ~/src/Twisted/bin/trial twistedchecker
> 
> trial being the latest from twisted svn trunk, I get the same error
> 
> pylint --version
> No config file found, using default configuration
> pylint 0.26.0, 
> astng 0.24.3, common 0.61.0
> Python 2.7.6 (default, Mar 22 2014, 22:59:56) 
> [GCC 4.8.2]

Hmm.

It seems as though twistedchecker does not itself have continuous integration 
set up, so I don't have any test results to look at.  It seems to be working on 
our buildbots (for now, at least) but I'm not sure why.

This week I will try to get 
 merged, among other 
things.

-glyph

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] twistedchecker TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)

2014-09-29 Thread Wolfgang Rohdewald 
Am Montag, 29. September 2014, 00:07:33 schrieb Glyph:
> This week I will try to get 
>  merged,

which requires exactly pep8 1.5.1

Ubuntu 14.04 installs 1.4.6
I have the current 1.5.7

After downgrading to 1.4.6, twistedchecker works correctly.


-- 
Wolfgang

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Python 3.3 buildslaves

2014-09-29 Thread Glyph 

On Sep 14, 2014, at 5:09 PM, exar...@twistedmatrix.com wrote:

> Hello,
> 
> I noticed that https://twistedmatrix.com/trac/ticket/7355 is a blocker
> for the release of Twisted 14.1 and #7355 is blocked Python 3.3 buildbot
> configuration/availability issues.
> 
> Who can look at why one of the Python 3.3 slaves is offline and why
> the two slaves are configured differently?

The configuration of the two slaves has been made consistent, and I have 
reviewed and landed the relevant ticket.

At long last, that particular square on the build matrix is green.

-glyph


___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] glorious green

2014-09-29 Thread Glyph 
I will probably be going to sleep before py-select-gc gets around to finishing, 
but other than that, 

 is completely green.  If  were 
reviewed, we might be able to make 
 
look a bit more like the solid green rectangle it really ought to be.

-glyph___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] twistedchecker TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)

2014-09-29 Thread Glyph Lefkowitz 
On Sep 29, 2014, at 12:31 AM, Wolfgang Rohdewald  
wrote:

> Am Montag, 29. September 2014, 00:07:33 schrieb Glyph:
>> This week I will try to get 
>>  merged,
> 
> which requires exactly pep8 1.5.1
> 
> Ubuntu 14.04 installs 1.4.6
> I have the current 1.5.7
> 
> After downgrading to 1.4.6, twistedchecker works correctly.

The issue is actually logilab-common, not pep8 itself; twistedchecker can deal 
with more recent pep8 versions.

I fixed this on twistedchecker master:



More exciting, though, is Adi Roiban's contribution of Travis-CI continuous 
integration:



so we can pick up the pace on twistedchecker improvements a bit.  (The buildbot 
already runs straight out of Git, so improvements go live almost immediately.)

-glyph___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] twistedchecker TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)

2014-09-29 Thread Adi Roiban 
On 29 September 2014 20:11, Glyph Lefkowitz  wrote:
> On Sep 29, 2014, at 12:31 AM, Wolfgang Rohdewald 
> wrote:
>
> Am Montag, 29. September 2014, 00:07:33 schrieb Glyph:
>
> This week I will try to get
>  merged,
>
>
> which requires exactly pep8 1.5.1
>
> Ubuntu 14.04 installs 1.4.6
> I have the current 1.5.7
>
> After downgrading to 1.4.6, twistedchecker works correctly.
>
>
> The issue is actually logilab-common, not pep8 itself; twistedchecker can
> deal with more recent pep8 versions.
>
I got this similar error when I was using pep8 1.5.1 ... after upgrade
to 1.5.6 all was fine.

Please check latest setup.py from master... and the install line from
travis.yml

Cheers!
-- 
Adi Roiban

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python