Re: [trojita] Patch seemingly submitted to Arch Linux builds by upstream breaks icons

2021-08-05 Thread Jan Kundrát
I had a bug opened in the Archlinux repos about latest patch 
breaking the icon: https://bugs.archlinux.org/task/70665


Arojas now told me they got it from upstream. Is upstream aware 
of this problem?

Will they fix it?


The bug report appears to talk about the tray icon. I don't recall any 
patches in Trojita touching tray icons. Perhaps they meant the Qt project 
as the upstream?


Jan



[trojita] Patch seemingly submitted to Arch Linux builds by upstream breaks icons

2021-08-05 Thread Oskar Roesler

Hello,

I had a bug opened in the Archlinux repos about latest patch breaking the 
icon: https://bugs.archlinux.org/task/70665


Arojas now told me they got it from upstream. Is upstream aware of this 
problem?

Will they fix it?

Regards,
Oskar Roesler



Re: [trojita] Patch seemingly submitted to Arch Linux builds by upstream breaks icons

2021-08-05 Thread Oskar Roesler
Ok, now I'm unsure and let's see if the bug disappears when I build the old 
version without the patch.

Am Donnerstag, 5. August 2021 11:07:25 CEST schrieb Jan Kundrát:
I had a bug opened in the Archlinux repos about latest patch 
breaking the icon: https://bugs.archlinux.org/task/70665


Arojas now told me they got it from upstream. Is upstream 
aware of this problem?

Will they fix it?


The bug report appears to talk about the tray icon. I don't 
recall any patches in Trojita touching tray icons. Perhaps they 
meant the Qt project as the upstream?


Jan







Re: [trojita] Patch seemingly submitted to Arch Linux builds by upstream breaks icons

2021-08-05 Thread Thomas Lübking

Am Thu, Aug 05, 2021 at 01:09:14PM +0200 schrieb Oskar Roesler:
I now built trojita-0.7-4 instead of 0.7.-5 and icons works again. I 
had to make git reset HEAD~2 bc of some Arch internal commit. These 
are the problematic patches:


trojita-highdpi.patch::"https://invent.kde.org/pim/trojita/-/commit/eecc474a.patch";

trojita-wayland.patch::"https://invent.kde.org/pim/trojita/-/commit/81e84200.patch";)



From the nature of the patches and the illustrating screenshot I guess
what happens is that Qt generates a HGE version of the icon,
trojita paints some semi-fixed size text on it and then the entire
thing is scaled down to fit the systray (nice to see that the systray
protocol still sucks, even w/ wayland…)

Cheers,
Thomas



Re: [trojita] Patch seemingly submitted to Arch Linux builds by upstream breaks icons

2021-08-05 Thread Oskar Roesler
I now built trojita-0.7-4 instead of 0.7.-5 and icons works again. 
I had to make git reset HEAD~2 bc of some Arch internal commit. These are 
the problematic patches:


trojita-highdpi.patch::"https://invent.kde.org/pim/trojita/-/commit/eecc474a.patch";

trojita-wayland.patch::"https://invent.kde.org/pim/trojita/-/commit/81e84200.patch";)
Ironically I am on Wayland (Sway, Wlroots) and couldn't notice any visible 
or behavioural improvements due to these patches.
They simply break the icon and I don't think there's much hidden 
functionality in Trojita that I don't use.


Regards,
Oskar

Am Donnerstag, 5. August 2021 11:14:58 CEST schrieb Oskar Roesler:
Ok, now I'm unsure and let's see if the bug disappears when I 
build the old version without the patch.

Am Donnerstag, 5. August 2021 11:07:25 CEST schrieb Jan Kundrát:

...
The bug report appears to talk about the tray icon. I don't 
recall any patches in Trojita touching tray icons. Perhaps they 
meant the Qt project as the upstream?


Jan

 ...